[Buildbot-commits] [buildbot/buildbot] b25c1f: steps: added support for VS2012 via msbuild

Tue Oct 2 14:34:48 UTC 2012

  Branch: refs/heads/nine
  Home:   https://github.com/buildbot/buildbot
  Commit: b25c1fe9341e87d279757b0245d3df10093d7f92
      https://github.com/buildbot/buildbot/commit/b25c1fe9341e87d279757b0245d3df10093d7f92
  Author: Oleg Smolsky <oleg at smolsky.net>
  Date:   2012-09-25 (Tue, 25 Sep 2012)

  Changed paths:
    M master/buildbot/steps/vstudio.py

  Log Message:
  -----------
  steps: added support for VS2012 via msbuild

 - the step is called MsBuild as the same code would work for VS2010
   (barring the environment variable name)
 - this new step allows for building drivers as the new Windows Driver Kit 8 integrates into VS2012
   (you can target Vista, Win7 and Win8)

  Commit: 68bbc4888614efa05d93db0dd608557551a28325
      https://github.com/buildbot/buildbot/commit/68bbc4888614efa05d93db0dd608557551a28325
  Author: Oleg Smolsky <oleg at smolsky.net>
  Date:   2012-09-27 (Thu, 27 Sep 2012)

  Changed paths:
    M master/buildbot/steps/vstudio.py

  Log Message:
  -----------
  steps: refactored MsBuild step according to review comments

  Commit: c4de44857247d5d2fdb670bf39a2be8101a71af8
      https://github.com/buildbot/buildbot/commit/c4de44857247d5d2fdb670bf39a2be8101a71af8
  Author: Oleg Smolsky <oleg at smolsky.net>
  Date:   2012-09-27 (Thu, 27 Sep 2012)

  Changed paths:
    M master/buildbot/steps/vstudio.py

  Log Message:
  -----------
  steps: removed junk from an old rev (proper merge)

  Commit: 3e2cd7e5c7fea30f2ac8e14a59a55bef048098b8
      https://github.com/buildbot/buildbot/commit/3e2cd7e5c7fea30f2ac8e14a59a55bef048098b8
  Author: Oleg Smolsky <oleg at smolsky.net>
  Date:   2012-09-27 (Thu, 27 Sep 2012)

  Changed paths:
    M master/buildbot/steps/vstudio.py

  Log Message:
  -----------
  steps: removed another couple of uneeded changes

  Commit: a2078a2a182d3ca6fbaca909b049c020e58558ed
      https://github.com/buildbot/buildbot/commit/a2078a2a182d3ca6fbaca909b049c020e58558ed
  Author: Oleg Smolsky <oleg at smolsky.net>
  Date:   2012-09-28 (Fri, 28 Sep 2012)

  Changed paths:
    M master/buildbot/steps/vstudio.py

  Log Message:
  -----------
  MsBuild: minor cleanups

  Commit: f0cb6b16569bff16d3a1458c89bb4fc42c1ca2eb
      https://github.com/buildbot/buildbot/commit/f0cb6b16569bff16d3a1458c89bb4fc42c1ca2eb
  Author: Oleg Smolsky <oleg at smolsky.net>
  Date:   2012-09-29 (Sat, 29 Sep 2012)

  Changed paths:
    M master/buildbot/test/unit/test_steps_vstudio.py

  Log Message:
  -----------
  msbuild: added a minimal unit test

  Commit: a81f829f789defcb61f726d38427dd3b9144027d
      https://github.com/buildbot/buildbot/commit/a81f829f789defcb61f726d38427dd3b9144027d
  Author: Oleg Smolsky <oleg at smolsky.net>
  Date:   2012-09-29 (Sat, 29 Sep 2012)

  Changed paths:
    M master/docs/manual/cfg-buildsteps.rst

  Log Message:
  -----------
  steps: extended docs with MsBuild details

  Commit: 6974f038836fd7411e8ac9999d8695a04e5b9098
      https://github.com/buildbot/buildbot/commit/6974f038836fd7411e8ac9999d8695a04e5b9098
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2012-09-29 (Sat, 29 Sep 2012)

  Changed paths:
    M master/buildbot/steps/vstudio.py
    M master/docs/manual/cfg-buildsteps.rst

  Log Message:
  -----------
  pyflakes and whitespace

  Commit: b2fd75b4c9c2119886208396733242973e9bf426
      https://github.com/buildbot/buildbot/commit/b2fd75b4c9c2119886208396733242973e9bf426
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2012-09-29 (Sat, 29 Sep 2012)

  Changed paths:
    M master/buildbot/steps/vstudio.py
    M master/buildbot/test/unit/test_steps_vstudio.py
    M master/docs/manual/cfg-buildsteps.rst

  Log Message:
  -----------
  Merge branch 'pull532'

  Commit: e52a5548d86186929f5b0f193bcf8593cff02f73
      https://github.com/buildbot/buildbot/commit/e52a5548d86186929f5b0f193bcf8593cff02f73
  Author: Martin Geisler <martin at geisler.net>
  Date:   2012-09-30 (Sun, 30 Sep 2012)

  Changed paths:
    M master/docs/developer/master-slave.rst
    M master/docs/manual/cfg-buildfactories.rst
    M master/docs/manual/cfg-buildslaves.rst
    M master/docs/manual/cfg-buildsteps.rst
    M master/docs/manual/cfg-changesources.rst
    M master/docs/manual/cfg-properties.rst
    M master/docs/manual/cmdline.rst
    M master/docs/manual/customization.rst
    M master/docs/manual/installation.rst
    M master/docs/manual/introduction.rst
    M master/docs/tutorial/firstrun.rst
    M master/docs/tutorial/tour.rst

  Log Message:
  -----------
  Fix capitalization of Python

  Commit: ebd397624cb067e7d633a639e4713280ca149c3e
      https://github.com/buildbot/buildbot/commit/ebd397624cb067e7d633a639e4713280ca149c3e
  Author: Martin Geisler <martin at geisler.net>
  Date:   2012-09-30 (Sun, 30 Sep 2012)

  Changed paths:
    M master/docs/developer/master-slave.rst

  Log Message:
  -----------
  Fix "Pythons" -> "Python's"

  Commit: 3367e488223130444704531e41de3385b5f6d2af
      https://github.com/buildbot/buildbot/commit/3367e488223130444704531e41de3385b5f6d2af
  Author: Martin Geisler <martin at geisler.net>
  Date:   2012-09-30 (Sun, 30 Sep 2012)

  Changed paths:
    M master/docs/manual/cfg-buildsteps.rst
    M master/docs/manual/cfg-changesources.rst
    M master/docs/manual/cmdline.rst
    M master/docs/relnotes/0.8.7.rst

  Log Message:
  -----------
  Fix capitalization of Mercurial

  Commit: c2388e4789b42be3ade7200928927e240e63f32b
      https://github.com/buildbot/buildbot/commit/c2388e4789b42be3ade7200928927e240e63f32b
  Author: Martin Geisler <martin at geisler.net>
  Date:   2012-09-30 (Sun, 30 Sep 2012)

  Changed paths:
    M master/docs/manual/cfg-buildsteps.rst
    M master/docs/manual/cfg-changesources.rst
    M master/docs/manual/cfg-global.rst
    M master/docs/manual/cfg-schedulers.rst
    M master/docs/manual/cfg-statustargets.rst
    M master/docs/manual/cmdline.rst
    M master/docs/manual/concepts.rst
    M master/docs/relnotes/0.8.6.rst
    M master/docs/relnotes/0.8.7.rst
    M master/docs/relnotes/index.rst
    M master/docs/tutorial/firstrun.rst
    M master/docs/tutorial/tour.rst

  Log Message:
  -----------
  Fix capitalization of Git

  Commit: 142b08d259235b61281f34092ae2e155cc4d9d7e
      https://github.com/buildbot/buildbot/commit/142b08d259235b61281f34092ae2e155cc4d9d7e
  Author: Martin Geisler <martin at geisler.net>
  Date:   2012-09-30 (Sun, 30 Sep 2012)

  Changed paths:
    M master/docs/manual/cfg-changesources.rst
    M master/docs/manual/cfg-statustargets.rst
    M master/docs/manual/customization.rst
    M master/docs/relnotes/0.8.6.rst

  Log Message:
  -----------
  Fix capitalization of GitHub

  Commit: 3a168f0bc6611c1fd9348d858445f8263b25d362
      https://github.com/buildbot/buildbot/commit/3a168f0bc6611c1fd9348d858445f8263b25d362
  Author: Martin Geisler <martin at geisler.net>
  Date:   2012-09-30 (Sun, 30 Sep 2012)

  Changed paths:
    M master/docs/manual/cfg-changesources.rst
    M master/docs/manual/cmdline.rst

  Log Message:
  -----------
  Fix capitalization of Monotone

  Commit: 8891b29d51c4e851b13f374150b8c9ac757ba664
      https://github.com/buildbot/buildbot/commit/8891b29d51c4e851b13f374150b8c9ac757ba664
  Author: Martin Geisler <martin at geisler.net>
  Date:   2012-09-30 (Sun, 30 Sep 2012)

  Changed paths:
    M master/docs/manual/cmdline.rst

  Log Message:
  -----------
  Fix capitalization of Darcs

  Commit: da9b656f5e4f54a70fe1d9a86633a1c2b31c14eb
      https://github.com/buildbot/buildbot/commit/da9b656f5e4f54a70fe1d9a86633a1c2b31c14eb
  Author: Martin Geisler <martin at geisler.net>
  Date:   2012-09-30 (Sun, 30 Sep 2012)

  Changed paths:
    M master/docs/manual/cfg-buildsteps.rst
    M master/docs/manual/cfg-global.rst

  Log Message:
  -----------
  Fix capitalization of Hg

  Commit: d2c4da9e0f627910a06911e017c1104903f4212e
      https://github.com/buildbot/buildbot/commit/d2c4da9e0f627910a06911e017c1104903f4212e
  Author: Martin Geisler <martin at geisler.net>
  Date:   2012-09-30 (Sun, 30 Sep 2012)

  Changed paths:
    M master/docs/relnotes/0.8.6.rst
    M master/docs/relnotes/0.8.7.rst

  Log Message:
  -----------
  Fix missing literal block

  Commit: 4b69fce95c1148dc84e520ba7e11315d7a84dffa
      https://github.com/buildbot/buildbot/commit/4b69fce95c1148dc84e520ba7e11315d7a84dffa
  Author: Bryce Adelstein-Lelbach <blelbach at cct.lsu.edu>
  Date:   2012-10-01 (Mon, 01 Oct 2012)

  Changed paths:
    M slave/contrib/init-scripts/buildslave.init.sh

  Log Message:
  -----------
  Add missing 'then' to the buildslave init script

  Commit: d7d745b6ca9e0b9e0b0f4bf4e6b7ee86f066019d
      https://github.com/buildbot/buildbot/commit/d7d745b6ca9e0b9e0b0f4bf4e6b7ee86f066019d
  Author: Tom Prince <tom.prince at ualberta.net>
  Date:   2012-10-01 (Mon, 01 Oct 2012)

  Changed paths:
    M slave/contrib/init-scripts/buildslave.init.sh

  Log Message:
  -----------
  Merge pull request #541 from brycelelbach/init-script

Init script fix

  Commit: 67e1507b3cd7dcd44a1565a07ea308274cfa8403
      https://github.com/buildbot/buildbot/commit/67e1507b3cd7dcd44a1565a07ea308274cfa8403
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2012-10-01 (Mon, 01 Oct 2012)

  Changed paths:
    M master/docs/developer/master-slave.rst
    M master/docs/manual/cfg-buildfactories.rst
    M master/docs/manual/cfg-buildslaves.rst
    M master/docs/manual/cfg-buildsteps.rst
    M master/docs/manual/cfg-changesources.rst
    M master/docs/manual/cfg-global.rst
    M master/docs/manual/cfg-properties.rst
    M master/docs/manual/cfg-schedulers.rst
    M master/docs/manual/cfg-statustargets.rst
    M master/docs/manual/cmdline.rst
    M master/docs/manual/concepts.rst
    M master/docs/manual/customization.rst
    M master/docs/manual/installation.rst
    M master/docs/manual/introduction.rst
    M master/docs/relnotes/0.8.6.rst
    M master/docs/relnotes/0.8.7.rst
    M master/docs/relnotes/index.rst
    M master/docs/tutorial/firstrun.rst
    M master/docs/tutorial/tour.rst

  Log Message:
  -----------
  Merge branch 'doc' of git://github.com/mgeisler/buildbot

  Commit: 1fa1c4fc511ee6d3006594c8eb3c26c969d7e598
      https://github.com/buildbot/buildbot/commit/1fa1c4fc511ee6d3006594c8eb3c26c969d7e598
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2012-10-01 (Mon, 01 Oct 2012)

  Changed paths:
    M slave/contrib/init-scripts/buildslave.init.sh

  Log Message:
  -----------
  Merge branch 'master' of github.com:buildbot/buildbot

  Commit: 2ab18d865f06db1b643d5b005eb83a35a6927da4
      https://github.com/buildbot/buildbot/commit/2ab18d865f06db1b643d5b005eb83a35a6927da4
  Author: Pierre Tardy <pierre.tardy at intel.com>
  Date:   2012-10-02 (Tue, 02 Oct 2012)

  Changed paths:
    M master/buildbot/test/__init__.py
    A master/buildbot/test/unit/test_util_namespace.py
    A master/buildbot/util/namespace.py

  Log Message:
  -----------
  namespace: convenience class for json like data

One thing that is cooler with java-script than in python is that
dictionaries and objects are the same thing. It allows browsing of
complex hierarchical data syntactically easy.

One will always prefer writing:
buildrequest.properties.myprop
rather than
brdict['properties']['myprop']

This class allows such syntax sugar, by converting a dictionary
to something that responds to both object and dictionary duck typing

We don't redo the mistakes of java-script model, and don't allow this
class to be inherited, and forbid to implement any specific method
apart from the '__' prefixed duck-typing
only keys() items() and values() are reserved and cannot be accessed
via object notation. they can only be accessed via dict like
notation

First implementation, that use an internal _dict attribute

    test_benchmark1 ...
create + access
pure dict          : 0.00572395324707
Namespace as dict  : 0.29655623436 ( 5180 %)
Namespace as object: 0.293313026428 ( 5124 %)
access only
pure dict          : 0.00226902961731
Namespace as dict  : 0.219506025314 ( 9674 %)
Namespace as object: 0.236507892609 ( 10423 %)
                                             [OK]
    test_benchmark2 ...
create + access
pure dict          : 0.00633692741394
Namespace as dict  : 0.345242977142 ( 5448 %)
Namespace as object: 0.35455083847 ( 5594 %)
access only
pure dict          : 0.00258111953735
Namespace as dict  : 0.259343862534 ( 10047 %)
Namespace as object: 0.266692876816 ( 10332 %)
                                             [OK]
    test_benchmark3 ...
create + access
pure dict          : 0.0107021331787
Namespace as dict  : 3.95416998863 ( 36947 %)
Namespace as object: 4.02670288086 ( 37625 %)
access only
pure dict          : 0.00716400146484
Namespace as dict  : 3.73691916466 ( 52162 %)
Namespace as object: 3.7946138382 ( 52967 %)

  Commit: cf14a297879ca2c83c17a3e14f95ff094e7047c2
      https://github.com/buildbot/buildbot/commit/cf14a297879ca2c83c17a3e14f95ff094e7047c2
  Author: Pierre Tardy <pierre.tardy at intel.com>
  Date:   2012-10-02 (Tue, 02 Oct 2012)

  Changed paths:
    M master/buildbot/util/namespace.py

  Log Message:
  -----------
  _Namespace as a dict subclass implementation

This needs copy of the actually data.
But dict like read access are then native

    test_benchmark1 ...
create + access
pure dict          : 0.00615882873535
Namespace as dict  : 0.456478118896 ( 7411 %)
Namespace as object: 0.478987932205 ( 7777 %)
access only
pure dict          : 0.00246000289917
Namespace as dict  : 0.00496506690979 ( 201 %)
Namespace as object: 0.0221290588379 ( 899 %)
                                             [OK]
    test_benchmark2 ...
create + access
pure dict          : 0.00630712509155
Namespace as dict  : 0.768087148666 ( 12178 %)
Namespace as object: 0.792205810547 ( 12560 %)
access only
pure dict          : 0.00248885154724
Namespace as dict  : 0.00506806373596 ( 203 %)
Namespace as object: 0.0225648880005 ( 906 %)
                                             [OK]
    test_benchmark3 ...
create + access
pure dict          : 0.0112509727478
Namespace as dict  : 9.57195401192 ( 85076 %)
Namespace as object: 9.70584011078 ( 86266 %)
access only
pure dict          : 0.00751686096191
Namespace as dict  : 0.027991771698 ( 372 %)
Namespace as object: 0.168903112411 ( 2246 %)

Signed-off-by: Pierre Tardy <pierre.tardy at intel.com>

  Commit: 548849afd3d84ad9e2d546f5eea33fbd6baed493
      https://github.com/buildbot/buildbot/commit/548849afd3d84ad9e2d546f5eea33fbd6baed493
  Author: Pierre Tardy <pierre.tardy at intel.com>
  Date:   2012-10-02 (Tue, 02 Oct 2012)

  Changed paths:
    M master/buildbot/util/namespace.py

  Log Message:
  -----------
  try to avoid data copy. This does not work, as dict is a native
class, and its method cannot be changed.

  Commit: d137598c5ea969656d63331fc5f50bc54cb303d0
      https://github.com/buildbot/buildbot/commit/d137598c5ea969656d63331fc5f50bc54cb303d0
  Author: Pierre Tardy <pierre.tardy at intel.com>
  Date:   2012-10-02 (Tue, 02 Oct 2012)

  Changed paths:
    M master/buildbot/util/namespace.py

  Log Message:
  -----------
  Revert "try to avoid data copy. This does not work, as dict is a native"

This reverts commit 68b982561e3442ada73a9d0dbaf5960a43a68764.

  Commit: b60e33e989cae55768355b2cf0ece024c0bb4708
      https://github.com/buildbot/buildbot/commit/b60e33e989cae55768355b2cf0ece024c0bb4708
  Author: Pierre Tardy <pierre.tardy at intel.com>
  Date:   2012-10-02 (Tue, 02 Oct 2012)

  Changed paths:
    M master/buildbot/util/namespace.py

  Log Message:
  -----------
  namespace: final implementation

We translate inner dicts on the fly. This is thus
a good compromise

    test_benchmark1 ...
create + access
pure dict          : 0.00651502609253
Namespace as dict  : 0.152539968491 ( 2341 %)
Namespace as object: 0.173326015472 ( 2660 %)
access only
pure dict          : 0.00234913825989
Namespace as dict  : 0.0270440578461 ( 1151 %)
Namespace as object: 0.0485229492188 ( 2065 %)
                                             [OK]
    test_benchmark2 ...
create + access
pure dict          : 0.00629901885986
Namespace as dict  : 0.31452703476 ( 4993 %)
Namespace as object: 0.336041927338 ( 5334 %)
access only
pure dict          : 0.00247311592102
Namespace as dict  : 0.154057979584 ( 6229 %)
Namespace as object: 0.179447889328 ( 7255 %)
                                             [OK]
    test_benchmark3 ...
create + access
pure dict          : 0.0114121437073
Namespace as dict  : 0.848978042603 ( 7439 %)
Namespace as object: 1.067289114 ( 9352 %)
access only
pure dict          : 0.00813007354736
Namespace as dict  : 0.208504915237 ( 2564 %)
Namespace as object: 0.392553091049 ( 4828 %)

  Commit: 249732f58a6bf2f825dfea92dc44240a31d24ccf
      https://github.com/buildbot/buildbot/commit/249732f58a6bf2f825dfea92dc44240a31d24ccf
  Author: Pierre Tardy <pierre.tardy at intel.com>
  Date:   2012-10-02 (Tue, 02 Oct 2012)

  Changed paths:
    M master/buildbot/test/unit/test_util_namespace.py
    M master/buildbot/util/namespace.py

  Log Message:
  -----------
  more optimization

After reflexion, it looks that we need to optimize read access
time rather than creation time.

  Commit: 1a644e892fd62ea16b85a00913cd6b5fb3231af9
      https://github.com/buildbot/buildbot/commit/1a644e892fd62ea16b85a00913cd6b5fb3231af9
  Author: Pierre Tardy <pierre.tardy at intel.com>
  Date:   2012-10-02 (Tue, 02 Oct 2012)

  Changed paths:
    M master/buildbot/test/unit/test_util_namespace.py

  Log Message:
  -----------
  remove the inheritence forbid from the specs

Implementing it will impact performance
http://code.activestate.com/recipes/141933-forbidding-inheritance/

Signed-off-by: Pierre Tardy <pierre.tardy at intel.com>

  Commit: ec125d1fc0fb2f36fc94fffebc4d8228164079af
      https://github.com/buildbot/buildbot/commit/ec125d1fc0fb2f36fc94fffebc4d8228164079af
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2012-10-02 (Tue, 02 Oct 2012)

  Changed paths:
    M master/buildbot/test/__init__.py
    A master/buildbot/test/unit/test_util_namespace.py
    A master/buildbot/util/namespace.py

  Log Message:
  -----------
  Merge branch 'yamlconfig' of git://github.com/tardyp/buildbot

  Commit: d76261298030bb3597db3ef7cb9f0ac8e76391ad
      https://github.com/buildbot/buildbot/commit/d76261298030bb3597db3ef7cb9f0ac8e76391ad
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2012-10-02 (Tue, 02 Oct 2012)

  Changed paths:
    M master/buildbot/test/unit/test_util_namespace.py

  Log Message:
  -----------
  remove benchmark tests

  Commit: c09ed1e950962fb3ffa8cd2f6103cc967c249955
      https://github.com/buildbot/buildbot/commit/c09ed1e950962fb3ffa8cd2f6103cc967c249955
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2012-10-02 (Tue, 02 Oct 2012)

  Changed paths:
    M master/buildbot/steps/vstudio.py
    M master/buildbot/test/__init__.py
    M master/buildbot/test/unit/test_steps_vstudio.py
    A master/buildbot/test/unit/test_util_namespace.py
    A master/buildbot/util/namespace.py
    M master/docs/developer/master-slave.rst
    M master/docs/manual/cfg-buildfactories.rst
    M master/docs/manual/cfg-buildslaves.rst
    M master/docs/manual/cfg-buildsteps.rst
    M master/docs/manual/cfg-changesources.rst
    M master/docs/manual/cfg-global.rst
    M master/docs/manual/cfg-properties.rst
    M master/docs/manual/cfg-schedulers.rst
    M master/docs/manual/cfg-statustargets.rst
    M master/docs/manual/cmdline.rst
    M master/docs/manual/concepts.rst
    M master/docs/manual/customization.rst
    M master/docs/manual/installation.rst
    M master/docs/manual/introduction.rst
    M master/docs/relnotes/0.8.6.rst
    M master/docs/relnotes/0.8.7.rst
    M master/docs/relnotes/index.rst
    M master/docs/tutorial/firstrun.rst
    M master/docs/tutorial/tour.rst
    M slave/contrib/init-scripts/buildslave.init.sh

  Log Message:
  -----------
  Merge branch 'master' into nine

Compare: https://github.com/buildbot/buildbot/compare/a33f61daaa7a...c09ed1e95096