[Buildbot-commits] [buildbot/buildbot] 374e8c: Make FakeMaster a full class, not a Mock

GitHub noreply at github.com
Sun May 27 18:49:49 UTC 2012


  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot
  Commit: 374e8c7dd9d248d6e596e4a7db8145a5f82459bc
      https://github.com/buildbot/buildbot/commit/374e8c7dd9d248d6e596e4a7db8145a5f82459bc
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2012-05-27 (Sun, 27 May 2012)

  Changed paths:
    M master/buildbot/process/builder.py
    M master/buildbot/test/fake/fakemaster.py
    M master/buildbot/test/integration/test_slave_comm.py
    M master/buildbot/test/unit/test_process_builder.py
    M master/buildbot/test/unit/test_steps_trigger.py

  Log Message:
  -----------
  Make FakeMaster a full class, not a Mock

This is a compromise between adding the required methods (and other
classes) to fakemaster.py, and mocking out the required methods/class in
the tests, or using a real method/class where appropriate.  Fixes #2302


  Commit: 8d0e78a56344d3ecd4cd08b00feafbbb2565b34d
      https://github.com/buildbot/buildbot/commit/8d0e78a56344d3ecd4cd08b00feafbbb2565b34d
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2012-05-27 (Sun, 27 May 2012)

  Changed paths:
    M master/buildbot/process/builder.py
    M master/buildbot/test/fake/fakemaster.py
    M master/buildbot/test/integration/test_slave_comm.py
    M master/buildbot/test/unit/test_process_builder.py
    M master/buildbot/test/unit/test_steps_trigger.py

  Log Message:
  -----------
  Merge branch 'bug2302' of git://github.com/djmitche/buildbot

* 'bug2302' of git://github.com/djmitche/buildbot:
  Make FakeMaster a full class, not a Mock


Compare: https://github.com/buildbot/buildbot/compare/cc5b2ed...8d0e78a


More information about the Commits mailing list