[Buildbot-commits] [Buildbot] #2305: If doStepIf callable errors out build ends badly

[Buildbot]

#2305: If doStepIf callable errors out build ends badly
----------------------+--------------------
Reporter:  Jc2k       |       Owner:
    Type:  defect     |      Status:  new
Priority:  major      |   Milestone:  0.8.+
 Version:  master     |  Resolution:
Keywords:  buildstep  |
----------------------+--------------------

Comment (by dustin):

 Ah, indeed, I get
 {{{
 2012-05-26 18:35:55-0500 [-] BuildStep.failed; traceback follows
         Traceback (most recent call last):
           File "/home/dustin/code/buildbot/t/buildbot/sand27/lib/python2.7
 /site-packages/twisted/internet/defer.py", line 290, in addCallbacks
             self._runCallbacks()
           File "/home/dustin/code/buildbot/t/buildbot/sand27/lib/python2.7
 /site-packages/twisted/internet/defer.py", line 551, in _runCallbacks
             current.result = callback(current.result, *args, **kw)
           File "/home/dustin/code/buildbot/t/buildbot/sand27/lib/python2.7
 /site-packages/twisted/internet/defer.py", line 368, in callback
             self._startRunCallbacks(result)
           File "/home/dustin/code/buildbot/t/buildbot/sand27/lib/python2.7
 /site-packages/twisted/internet/defer.py", line 464, in _startRunCallbacks
             self._runCallbacks()
         --- <exception caught here> ---
           File "/home/dustin/code/buildbot/t/buildbot/sand27/lib/python2.7
 /site-packages/twisted/internet/defer.py", line 551, in _runCallbacks
             current.result = callback(current.result, *args, **kw)
           File
 "/home/dustin/code/buildbot/t/buildbot/master/buildbot/process/buildstep.py",
 line 636, in finished
             self._finishFinished(results)
           File
 "/home/dustin/code/buildbot/t/buildbot/master/buildbot/process/buildstep.py",
 line 645, in _finishFinished
             hidden = self._maybeEvaluate(self.hideStepIf, results, self)
           File
 "/home/dustin/code/buildbot/t/buildbot/master/buildbot/process/buildstep.py",
 line 758, in _maybeEvaluate
             value = value(*args, **kwargs)
         exceptions.TypeError: <lambda>() takes no arguments (2 given)

 2012-05-26 18:35:55-0500 [-] exception during failure processing
 2012-05-26 18:35:55-0500 [-] Unhandled Error
         Traceback (most recent call last):
           File "/home/dustin/code/buildbot/t/buildbot/sand27/lib/python2.7
 /site-packages/twisted/internet/defer.py", line 551, in _runCallbacks
             current.result = callback(current.result, *args, **kw)
           File "/home/dustin/code/buildbot/t/buildbot/sand27/lib/python2.7
 /site-packages/twisted/internet/defer.py", line 368, in callback
             self._startRunCallbacks(result)
           File "/home/dustin/code/buildbot/t/buildbot/sand27/lib/python2.7
 /site-packages/twisted/internet/defer.py", line 464, in _startRunCallbacks
             self._runCallbacks()
           File "/home/dustin/code/buildbot/t/buildbot/sand27/lib/python2.7
 /site-packages/twisted/internet/defer.py", line 551, in _runCallbacks
             current.result = callback(current.result, *args, **kw)
         --- <exception caught here> ---
           File
 "/home/dustin/code/buildbot/t/buildbot/master/buildbot/process/buildstep.py",
 line 662, in failed
             self.progress.finish()
           File
 "/home/dustin/code/buildbot/t/buildbot/master/buildbot/status/progress.py",
 line 85, in finish
             self.buildProgress.stepFinished(self.name)
           File
 "/home/dustin/code/buildbot/t/buildbot/master/buildbot/status/progress.py",
 line 165, in stepFinished
             assert(stepname not in self.finishedSteps)
         exceptions.AssertionError:
 }}}

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2305#comment:3>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation