[Buildbot-commits] [Buildbot] #2305: If doStepIf callable errors out build ends badly

[Buildbot]

#2305: If doStepIf callable errors out build ends badly
----------------------+--------------------
Reporter:  Jc2k       |       Owner:
    Type:  defect     |      Status:  new
Priority:  major      |   Milestone:  0.8.+
 Version:  master     |  Resolution:
Keywords:  buildstep  |
----------------------+--------------------
Changes (by dustin):

 * milestone:  0.8.7 => 0.8.+


Comment:

 Hm, I get an EXCEPTION status from

 {{{
 f1.addStep(ShellCommand(command="sleep 10", doStepIf=lambda : True))
 }}}

 The exception is ugly, because it's from a DeferredList, but the state
 seems to come out correctly.

 {{{
  (view as text)

 Traceback (most recent call last):
 Failure: twisted.internet.defer.FirstError: FirstError[#0, [Failure
 instance: Traceback: <type 'exceptions.TypeError'>: <lambda>() takes no
 arguments (1 given)
 /home/dustin/code/buildbot/t/buildbot/sand27/lib/python2.7/site-
 packages/twisted/internet/defer.py:301:addCallback
 /home/dustin/code/buildbot/t/buildbot/sand27/lib/python2.7/site-
 packages/twisted/internet/defer.py:290:addCallbacks
 /home/dustin/code/buildbot/t/buildbot/sand27/lib/python2.7/site-
 packages/twisted/internet/defer.py:551:_runCallbacks
 /home/dustin/code/buildbot/t/buildbot/master/buildbot/process/buildstep.py:566:_startStep_2
 --- <exception caught here> ---
 /home/dustin/code/buildbot/t/buildbot/sand27/lib/python2.7/site-
 packages/twisted/internet/defer.py:134:maybeDeferred
 ]]

 }}}

 Can you give some more detail on what you're seeing?

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2305#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation