[Buildbot-commits] [Buildbot] #2301: buildbot waterfall page shows error after reconfig

[Buildbot]

#2301: buildbot waterfall page shows error after reconfig
---------------------+------------------------
Reporter:  pwp       |       Owner:
    Type:  defect    |      Status:  new
Priority:  major     |   Milestone:  undecided
 Version:  0.8.6p1   |  Resolution:
Keywords:  reconfig  |
---------------------+------------------------
Changes (by dustin):

 * priority:  critical => major


Comment:

 That seems unlikely to help -- `site.buildbot_service` is already set
 toward the end of `setServiceParent`, and that value is used in the
 second-to-last stack frame.

 I can reproduce while reconfig'ing every 0.5s and clicking around
 webStatus:
 {{{
 2012-05-19 19:01:14-0500 [-] configuration update complete
 2012-05-19 19:01:15-0500 [HTTPChannel,0,172.16.1.20] Unhandled Error
         Traceback (most recent call last):
           File "/home/dustin/code/buildbot/t/buildbot/sand27/lib/python2.7
 /site-packages/twisted/web/http.py", line 1349, in dataReceived
             finishCallback(data[contentLength:])
           File "/home/dustin/code/buildbot/t/buildbot/sand27/lib/python2.7
 /site-packages/twisted/web/http.py", line 1563, in _finishRequestBody
             self.allContentReceived()
           File "/home/dustin/code/buildbot/t/buildbot/sand27/lib/python2.7
 /site-packages/twisted/web/http.py", line 1618, in allContentReceived
             req.requestReceived(command, path, version)
           File "/home/dustin/code/buildbot/t/buildbot/sand27/lib/python2.7
 /site-packages/twisted/web/http.py", line 773, in requestReceived
             self.process()
         --- <exception caught here> ---
           File "/home/dustin/code/buildbot/t/buildbot/sand27/lib/python2.7
 /site-packages/twisted/web/server.py", line 131, in process
             resrc = self.site.getResourceFor(self)
           File "/home/dustin/code/buildbot/t/buildbot/sand27/lib/python2.7
 /site-packages/twisted/web/server.py", line 562, in getResourceFor
             return resource.getChildForRequest(self.resource, request)
           File "/home/dustin/code/buildbot/t/buildbot/sand27/lib/python2.7
 /site-packages/twisted/web/resource.py", line 65, in getChildForRequest
             resource = resource.getChildWithDefault(pathElement, request)
           File "/home/dustin/code/buildbot/t/buildbot/sand27/lib/python2.7
 /site-packages/twisted/web/resource.py", line 169, in getChildWithDefault
             return self.getChild(path, request)
           File
 "/home/dustin/code/buildbot/t/buildbot/master/buildbot/status/web/builder.py",
 line 556, in getChild
             s = self.getStatus(req)
           File
 "/home/dustin/code/buildbot/t/buildbot/master/buildbot/status/web/base.py",
 line 182, in getStatus
             return request.site.buildbot_service.getStatus()
           File
 "/home/dustin/code/buildbot/t/buildbot/master/buildbot/status/web/baseweb.py",
 line 498, in getStatus
             return self.master.getStatus()
         exceptions.AttributeError: 'NoneType' object has no attribute
 'getStatus'

 2012-05-19 19:01:15-0500 [-] beginning configuration update
 }}}

 but I think that was just getting lucky.  I can't reproduce with the
 suggested patch, but I also can't reproduce a second time *with* the
 suggested patch..

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2301#comment:6>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation