[Buildbot-commits] [buildbot/buildbot] a8f887: Use magic __new__ for step factories.

GitHub noreply at github.com
Tue May 15 00:51:18 UTC 2012


  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot
  Commit: a8f88771f93ac92e0a9043bd2e5c359a4395a1e6
      https://github.com/buildbot/buildbot/commit/a8f88771f93ac92e0a9043bd2e5c359a4395a1e6
  Author: Tom Prince <tom.prince at ualberta.net>
  Date:   2012-03-31 (Sat, 31 Mar 2012)

  Changed paths:
    M master/buildbot/config.py
    M master/buildbot/process/build.py
    M master/buildbot/process/buildstep.py
    M master/buildbot/test/unit/test_config.py
    M master/buildbot/test/unit/test_process_build.py
    M master/buildbot/test/util/steps.py

  Log Message:
  -----------
  Use magic __new__ for step factories.


  Commit: a77e511860b1be57feaa79ed4cf6a66d08eafca8
      https://github.com/buildbot/buildbot/commit/a77e511860b1be57feaa79ed4cf6a66d08eafca8
  Author: Tom Prince <tom.prince at ualberta.net>
  Date:   2012-03-31 (Sat, 31 Mar 2012)

  Changed paths:
    M master/buildbot/process/buildstep.py
    M master/buildbot/process/mtrlogobserver.py
    M master/buildbot/steps/master.py
    M master/buildbot/steps/maxq.py
    M master/buildbot/steps/package/rpm/rpmbuild.py
    M master/buildbot/steps/python.py
    M master/buildbot/steps/python_twisted.py
    M master/buildbot/steps/shell.py
    M master/buildbot/steps/slave.py
    M master/buildbot/steps/source/base.py
    M master/buildbot/steps/source/bzr.py
    M master/buildbot/steps/source/cvs.py
    M master/buildbot/steps/source/git.py
    M master/buildbot/steps/source/mercurial.py
    M master/buildbot/steps/source/oldsource.py
    M master/buildbot/steps/source/svn.py
    M master/buildbot/steps/subunit.py
    M master/buildbot/steps/transfer.py
    M master/buildbot/steps/trigger.py
    M master/buildbot/steps/vstudio.py

  Log Message:
  -----------
  Remove calls to BuildStep.addFactoryArguments.

This call does nothing anymore, so remove calls to it. The function is still
around for backwards compatibility.


  Commit: fe0de9359599f78dacc2896abe5b706f640783e2
      https://github.com/buildbot/buildbot/commit/fe0de9359599f78dacc2896abe5b706f640783e2
  Author: Tom Prince <tom.prince at ualberta.net>
  Date:   2012-03-31 (Sat, 31 Mar 2012)

  Changed paths:
    M master/buildbot/process/build.py

  Log Message:
  -----------
  Don't bother copying build step arguments.

*args and **kwargs automatically make copies of what get passed to them.


  Commit: 87ba7381dd04cfc81b14d773e81c6169ca5f7c2c
      https://github.com/buildbot/buildbot/commit/87ba7381dd04cfc81b14d773e81c6169ca5f7c2c
  Author: Tom Prince <tom.prince at ualberta.net>
  Date:   2012-03-31 (Sat, 31 Mar 2012)

  Changed paths:
    M master/buildbot/process/build.py
    M master/buildbot/process/buildstep.py
    M master/buildbot/test/unit/test_process_build.py
    M master/buildbot/test/util/steps.py

  Log Message:
  -----------
  BuildStep: Make getStepFactory return a factory function.

Previously, it returned a factory, and arguments for the factory.
This was used to print an error when the factory failed. This is moved
into the factory function itself. The config also checks step locks. This
functionality will be removed.


  Commit: f114f217e971c59978b077a56446dfb4a6326267
      https://github.com/buildbot/buildbot/commit/f114f217e971c59978b077a56446dfb4a6326267
  Author: Tom Prince <tom.prince at ualberta.net>
  Date:   2012-03-31 (Sat, 31 Mar 2012)

  Changed paths:
    M master/buildbot/process/factory.py

  Log Message:
  -----------
  Remove deprecated support for passing step factories a tuples.

Instead, we support either BuildStep objects, or 0-argument callables.


  Commit: af7b6149b82a6ee648d22dbc1f18678cfbd872b9
      https://github.com/buildbot/buildbot/commit/af7b6149b82a6ee648d22dbc1f18678cfbd872b9
  Author: Tom Prince <tom.prince at ualberta.net>
  Date:   2012-03-31 (Sat, 31 Mar 2012)

  Changed paths:
    M master/buildbot/config.py
    M master/buildbot/test/unit/test_config.py

  Log Message:
  -----------
  MasterConfig: Don't check for slave lock conflicts.

With the change to representing step factories as callables, we
no longer are able to examine the step arguments to check for a locks
argument, so remove the check.


  Commit: 88cc9ab41fb4d2eb2b07276b03a8da4369127230
      https://github.com/buildbot/buildbot/commit/88cc9ab41fb4d2eb2b07276b03a8da4369127230
  Author: Tom Prince <tom.prince at ualberta.net>
  Date:   2012-03-31 (Sat, 31 Mar 2012)

  Changed paths:
    M master/buildbot/process/buildstep.py

  Log Message:
  -----------
  Remove silly call of __init__ from __new__ in BuildStep.


  Commit: 92feb5062728c5e8b555031c52836c02692e7245
      https://github.com/buildbot/buildbot/commit/92feb5062728c5e8b555031c52836c02692e7245
  Author: Tom Prince <tom.prince at ualberta.net>
  Date:   2012-03-31 (Sat, 31 Mar 2012)

  Changed paths:
    M master/buildbot/process/factory.py
    M master/buildbot/test/unit/test_process_factory.py

  Log Message:
  -----------
  Remove s().


  Commit: 798120c7ceabf005a4eb6c236d11be4f671d6796
      https://github.com/buildbot/buildbot/commit/798120c7ceabf005a4eb6c236d11be4f671d6796
  Author: Tom Prince <tom.prince at ualberta.net>
  Date:   2012-03-31 (Sat, 31 Mar 2012)

  Changed paths:
    M master/buildbot/process/buildstep.py
    M master/buildbot/test/unit/test_process_factory.py

  Log Message:
  -----------
  Create a _BuildStepFactory to capture the arguments to BuildStep subclasses.

We use an instance of this class, rather than a closure mostly to make it
easier to test that the right factories are getting created.


  Commit: 060c98297f759de8b9e6a678d9c472d29bc10579
      https://github.com/buildbot/buildbot/commit/060c98297f759de8b9e6a678d9c472d29bc10579
  Author: Tom Prince <tom.prince at ualberta.net>
  Date:   2012-04-01 (Sun, 01 Apr 2012)

  Changed paths:
    M master/buildbot/interfaces.py
    M master/buildbot/process/build.py
    M master/buildbot/process/buildstep.py
    M master/buildbot/process/factory.py
    M master/buildbot/test/util/steps.py

  Log Message:
  -----------
  Add a IBuildStepFactory, and make BuildFactory require instances.

Rather than having a class implementing __call__ representing step
factories, use a class with a real method.


  Commit: 024182e4ef4c2ecdc110b26eb18f56fd3abf7576
      https://github.com/buildbot/buildbot/commit/024182e4ef4c2ecdc110b26eb18f56fd3abf7576
  Author: Tom Prince <tom.prince at ualberta.net>
  Date:   2012-05-08 (Tue, 08 May 2012)

  Changed paths:
    M master/docs/developer/cls-buildsteps.rst
    M master/docs/manual/customization.rst

  Log Message:
  -----------
  Rewrap some buildstep documentation.


  Commit: 369e4185bf1b8b50fe116d9d9eb0bd7624710582
      https://github.com/buildbot/buildbot/commit/369e4185bf1b8b50fe116d9d9eb0bd7624710582
  Author: Tom Prince <tom.prince at ualberta.net>
  Date:   2012-05-08 (Tue, 08 May 2012)

  Changed paths:
    M master/docs/developer/cls-buildsteps.rst
    M master/docs/manual/customization.rst

  Log Message:
  -----------
  Update documentation to reflect new BuildStep constructors.

Since addFactoryArguments no longer needs to be called, remove the
documentation about it


  Commit: d73d939aa70ff388d83ce09d4179fb11fbef6e4c
      https://github.com/buildbot/buildbot/commit/d73d939aa70ff388d83ce09d4179fb11fbef6e4c
  Author: Tom Prince <tom.prince at ualberta.net>
  Date:   2012-05-08 (Tue, 08 May 2012)

  Changed paths:
    M master/buildbot/process/buildstep.py
    M master/buildbot/test/unit/test_process_factory.py
    M master/buildbot/test/util/steps.py

  Log Message:
  -----------
  Mark _getStepFactory and _factory as private.


  Commit: 51ae9da33893ba8205be9cd871ad24584cfcbd09
      https://github.com/buildbot/buildbot/commit/51ae9da33893ba8205be9cd871ad24584cfcbd09
  Author: Tom Prince <tom.prince at ualberta.net>
  Date:   2012-05-08 (Tue, 08 May 2012)

  Changed paths:
    M master/buildbot/test/unit/test_process_build.py

  Log Message:
  -----------
  Fix test_process_build to use IBuildStepFactory.

These tests should be fixed to not use Mock, but until then,
use a custom FakeStepFactory to "build" the mock.


  Commit: 9eb7be702d9c64be4f8dad30fee24a30f2bb0237
      https://github.com/buildbot/buildbot/commit/9eb7be702d9c64be4f8dad30fee24a30f2bb0237
  Author: Tom Prince <tom.prince at ualberta.net>
  Date:   2012-05-13 (Sun, 13 May 2012)

  Changed paths:
    M master/buildbot/config.py
    M master/buildbot/interfaces.py
    M master/buildbot/process/build.py
    M master/buildbot/process/buildstep.py
    M master/buildbot/process/factory.py
    M master/buildbot/process/mtrlogobserver.py
    M master/buildbot/steps/master.py
    M master/buildbot/steps/maxq.py
    M master/buildbot/steps/package/rpm/rpmbuild.py
    M master/buildbot/steps/python.py
    M master/buildbot/steps/python_twisted.py
    M master/buildbot/steps/shell.py
    M master/buildbot/steps/slave.py
    M master/buildbot/steps/source/base.py
    M master/buildbot/steps/source/bzr.py
    M master/buildbot/steps/source/cvs.py
    M master/buildbot/steps/source/git.py
    M master/buildbot/steps/source/mercurial.py
    M master/buildbot/steps/source/oldsource.py
    M master/buildbot/steps/source/svn.py
    M master/buildbot/steps/subunit.py
    M master/buildbot/steps/transfer.py
    M master/buildbot/steps/trigger.py
    M master/buildbot/steps/vstudio.py
    M master/buildbot/test/unit/test_config.py
    M master/buildbot/test/unit/test_process_build.py
    M master/buildbot/test/unit/test_process_factory.py
    M master/buildbot/test/util/steps.py
    M master/docs/developer/cls-buildsteps.rst
    M master/docs/manual/customization.rst

  Log Message:
  -----------
  Merge branch 'magic-__new__'

Conflicts:
	master/buildbot/steps/master.py
	master/buildbot/steps/shell.py
	master/buildbot/steps/source/base.py
	master/buildbot/steps/source/git.py
	master/buildbot/steps/source/svn.py
	master/docs/developer/cls-buildsteps.rst


  Commit: 56523b37eb51f9c5adedcc8af54b001f7bde79d0
      https://github.com/buildbot/buildbot/commit/56523b37eb51f9c5adedcc8af54b001f7bde79d0
  Author: Tom Prince <tom.prince at ualberta.net>
  Date:   2012-05-14 (Mon, 14 May 2012)

  Changed paths:
    M master/buildbot/test/unit/test_process_buildstep.py

  Log Message:
  -----------
  Fix test handling exception from BuildStep.start.


Compare: https://github.com/buildbot/buildbot/compare/56adff3...56523b3


More information about the Commits mailing list