[Buildbot-commits] [buildbot/buildbot] 249d87: Properly fix import loop between buildbot.config a...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot
  Commit: 249d87f4e4a02f12ea674fe7d242f16c16763e47
      https://github.com/buildbot/buildbot/commit/249d87f4e4a02f12ea674fe7d242f16c16763e47
  Author: Tom Prince <tom.prince at ualberta.net>
  Date:   2012-03-30 (Fri, 30 Mar 2012)

  Changed paths:
    M master/buildbot/config.py
  M master/buildbot/process/properties.py

  Log Message:
  -----------
  Properly fix import loop between buildbot.config and buildbot.process.properties.

config is more fundamental that properties, so limit the scope of imports there.


  Commit: dd4db7136f6e6f7847a98c2c232498c3f30cbebe
      https://github.com/buildbot/buildbot/commit/dd4db7136f6e6f7847a98c2c232498c3f30cbebe
  Author: Tom Prince <tom.prince at ualberta.net>
  Date:   2012-03-30 (Fri, 30 Mar 2012)

  Changed paths:
    M master/buildbot/test/unit/test_steps_source_svn.py

  Log Message:
  -----------
  Properly monkey patch things in test_steps_source_svn.

Previously, the tests were order dependent, due to failing to restore
the patch after the end of the test. Instead use self.patch to handle
restoring afterwards.

This was caught by running trial with '--random'.


Compare: https://github.com/buildbot/buildbot/compare/c271360...dd4db71