[Buildbot-commits] [buildbot/buildbot] 82430c: Disable checkpoint_fullfsync on all SQLite connect...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot
  Commit: 82430ca61f94bb7b9b516305bee870b693783136
      https://github.com/buildbot/buildbot/commit/82430ca61f94bb7b9b516305bee870b693783136
  Author: Mark Rowe <mrowe at apple.com>
  Date:   2012-03-29 (Thu, 29 Mar 2012)

  Changed paths:
    M master/buildbot/db/enginestrategy.py

  Log Message:
  -----------
  Disable checkpoint_fullfsync on all SQLite connections.

The checkpoint_fullfsync pragma is enabled by default on the version of SQLite that
ships with OS X Lion and newer. This setting enables use of the F_FULLSYNC fcntl rather
than fsync when transactions are moved from the WAL back in to the database proper. The
fcntl waits until the disk drive reports that all buffered data has been written to
permanent storage, in constrast to fsync which merely waits until the data has reached
the disk controller. F_FULLSYNC is more robust in the face of catastrophic system failure
but incurs a substantial performance hit for being so.

This change reduces the time it takes to run the buildbot.test.integration.test_upgrade
suite of tests on one machine from over 27 seconds to under 7 seconds.

Fixes #2256.


  Commit: d0616da10e7c7c8d821a646852c9ec1b95656386
      https://github.com/buildbot/buildbot/commit/d0616da10e7c7c8d821a646852c9ec1b95656386
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2012-03-29 (Thu, 29 Mar 2012)

  Changed paths:
    M master/buildbot/db/enginestrategy.py

  Log Message:
  -----------
  Merge branch 'bug-2256-sqlite-checkpoint-fullfsync' of git://github.com/bdash/buildbot

* 'bug-2256-sqlite-checkpoint-fullfsync' of git://github.com/bdash/buildbot:
  Disable checkpoint_fullfsync on all SQLite connections.


Compare: https://github.com/buildbot/buildbot/compare/93c1437...d0616da