[Buildbot-commits] [Buildbot] #2066: Fix new source steps' URL handling

[Buildbot]

#2066: Fix new source steps' URL handling
------------------------+--------------------
Reporter:  in3xes       |       Owner:
    Type:  enhancement  |      Status:  new
Priority:  minor        |   Milestone:  0.8.7
 Version:  0.8.4p2      |  Resolution:
Keywords:  simple       |
------------------------+--------------------

Comment (by dustin):

 Copying the relevant parts from those comments:

 ----

 baseURL vs svnurl

 These names are confusing, and as I understand it, are just a vestige of
 backward compatibility. Since this step requires that users choose it
 explicitly, we have a chance to do it right. What do these two parameters
 accomplish, and how could we do that with one parameter, with lots of
 flexibility for the user? What about the common case when the repository
 in the SourceStamp is sufficient - do we need to make the user specify a
 URL to the SVN step in that case, too? You don't need to implement the
 full flexibility yet, but think ahead when deciding how to handle these
 URLs.

 (me)

 ...

 This comment also applies to repoURL/baseURL of the Mercurial step. It
 would be good if all the new source steps could have consistent paramater
 naming among them selves, rather than with the old steps, which were not
 consistent.

 Tom

 ----

 Note that we've renamed svnurl to repourl
 (http://buildbot.net/buildbot/docs/0.8.6/release-notes.html), but that
 wasn't the whole deal.

 We've lost the advantage that I mentioned above - these steps are now in
 0.8.5 and 0.8.6 production deployments using baseURL or repourl.  Still,
 I'd be happy to see this simplified, even at the cost of some (well-
 documented, easily-mitigated) backward incompatibility.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2066#comment:3>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation