[Buildbot-commits] [Buildbot] #2246: buildbot.status.builder.BuilderStatus uses slow LRU implementation

[Buildbot]

#2246: buildbot.status.builder.BuilderStatus uses slow LRU implementation
------------------------+--------------------
Reporter:  szager       |       Owner:
    Type:  defect       |      Status:  new
Priority:  critical     |   Milestone:  0.8.7
 Version:  0.8.6        |  Resolution:
Keywords:  performance  |
------------------------+--------------------

Comment (by szager):

 Dustin,

 You're correct on all counts.  We have a very big and heavily-trafficed
 consoled, and that accounts for the frequency of hitting the build cache.

 And you may well be right that using the deferred-based solution would not
 be a performance drag; but the prospect of increasing the number of
 deferred callback sequences by a factor of 10, in an already heavily CPU-
 bound process, gave me pause.

 In fact, I did exactly as you have suggested, and added a SyncLRUCache to
 lru.py, which inherits from ASyncLRUCache and uses the same algorithm.  It
 has been live for a couple of days now, and first indications are that it
 has dramatically improved the performance of the web interface (and
 "dramatically" may be a dramatic understatement).

 I'd like to wait and see how this holds up on a busy weekday, but if you'd
 like to preview the patch, it's here:

 http://codereview.chromium.org/9703108/

 Stefan

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2246#comment:5>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation