[Buildbot-commits] [Buildbot] #2180: Allow for "git describe" in addition to got_revision
Buildbot
nobody at buildbot.net
Fri Mar 16 17:45:01 UTC 2012
#2180: Allow for "git describe" in addition to got_revision
----------------------------+------------------------
Reporter: jaredgrubb | Owner:
Type: enhancement | Status: reopened
Priority: minor | Milestone: undecided
Version: 0.8.5 | Resolution:
Keywords: git, buildslave |
----------------------------+------------------------
Changes (by dustin):
* status: closed => reopened
* resolution: wontfix =>
Comment:
I like the flexibility of it, for sure. We don't currently have a great
way to get properties out of dictionaries, though, and I'm loathe to
create a desire for that.
Way back when we first started talking about dictionaries in properties,
we were thinking of keying them on repostitory (we hadn't invented
"codebase" yet). I wonder if this would be *more* usable if the
properties were just named with the codebase, e.g., "%s-commit-
description", maybe with a fallback to just "commit-description" for the
empty codebase?
I'm not suggesting that change just yet -- I'd like to hear what others
think first.
--
Ticket URL: <http://trac.buildbot.net/ticket/2180#comment:7>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation
More information about the Commits
mailing list