[Buildbot-commits] [Buildbot] #2139: locks held by slaves are not released when slave goes missing

[Buildbot]

#2139: locks held by slaves are not released when slave goes missing
--------------------+---------------------
Reporter:  dwlocks  |       Owner:
    Type:  defect   |      Status:  closed
Priority:  major    |   Milestone:  0.8.6
 Version:  0.8.4p2  |  Resolution:  fixed
Keywords:           |
--------------------+---------------------

Comment (by dustin):

 Tom fixed this up already, but thanks for clarifying:
 {{{
 #!patch
 commit 7d78de7d0b311ac34261a7e08eb951394c9ac734
 Author: Tom Prince <tom.prince at ualberta.net>
 Date:   Thu Jan 19 16:24:06 2012 -0500

     Fix stupid type s/release/releaseLocks/.

 diff --git a/master/buildbot/buildslave.py b/master/buildbot/buildslave.py
 index b8c3c3a..cd5dae7 100644
 --- a/master/buildbot/buildslave.py
 +++ b/master/buildbot/buildslave.py
 @@ -460,7 +460,7 @@ class
 AbstractBuildSlave(config.ReconfigurableServiceMixin, pb.Avatar,
          log.msg("BuildSlave.detached(%s)" % self.slavename)
          self.botmaster.master.status.slaveDisconnected(self.slavename)
          self.stopKeepaliveTimer()
 -        self.release()
 +        self.releaseLocks()

          # notify watchers, but do so in the next reactor iteration so
 that
          # any further detached() action by subclasses happens first
 }}}

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2139#comment:5>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation