[Buildbot-commits] [Buildbot] #1799: Fix pipe symbol with ^ workaround

Buildbot nobody at buildbot.net
Tue Mar 13 05:13:24 UTC 2012


#1799: Fix pipe symbol with ^ workaround
----------------------------+---------------------
Reporter:  todd             |       Owner:
    Type:  defect           |      Status:  closed
Priority:  major            |   Milestone:  0.8.+
 Version:  0.8.3p1          |  Resolution:  fixed
Keywords:  windows, sprint  |
----------------------------+---------------------
Changes (by Nate Bragg):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 Fixes #1799

 This patch escapes all pipes in list commands that do not occur by
 themself.  This addresses the problem passing in Visual Studio
 configuration names, which in their commands are by default patterned
 like [...,"Release|Win32",...], which can't be parsed by the shell.

 However, this does not touch two different conditions: lone pipes
 in a command list (e.g., ['a','|','b'] assumes you want to pipe
 the output of a into b) and pipes inside string commands (e.g.,
 where the full command is "a | b", not in a list, it is assumed
 that you don't want an escaped pipe).

 Additionally, this commit adds a skip decorator for the platform,
 to clean up that syntax.
  Changeset: a87bf4ebee80c9f7d90ffb491aeb51cbf0d231a5

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1799#comment:4>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation


More information about the Commits mailing list