[Buildbot-commits] [buildbot/buildbot] a87bf4: Fixes #1799

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot
  Commit: a87bf4ebee80c9f7d90ffb491aeb51cbf0d231a5
      https://github.com/buildbot/buildbot/commit/a87bf4ebee80c9f7d90ffb491aeb51cbf0d231a5
  Author: Nate Bragg <nate.bragg at adb-air.com>
  Date:   2012-03-12 (Mon, 12 Mar 2012)

  Changed paths:
    M slave/buildslave/runprocess.py
  M slave/buildslave/test/unit/test_runprocess.py
  M slave/buildslave/test/util/compat.py

  Log Message:
  -----------
  Fixes #1799

This patch escapes all pipes in list commands that do not occur by
themself.  This addresses the problem passing in Visual Studio
configuration names, which in their commands are by default patterned
like [...,"Release|Win32",...], which can't be parsed by the shell.

However, this does not touch two different conditions: lone pipes
in a command list (e.g., ['a','|','b'] assumes you want to pipe
the output of a into b) and pipes inside string commands (e.g.,
where the full command is "a | b", not in a list, it is assumed
that you don't want an escaped pipe).

Additionally, this commit adds a skip decorator for the platform,
to clean up that syntax.


  Commit: f8eadc25321689873e736cc4947b3047ed815c30
      https://github.com/buildbot/buildbot/commit/f8eadc25321689873e736cc4947b3047ed815c30
  Author: Nate Bragg <nate.bragg at adb-air.com>
  Date:   2012-03-12 (Mon, 12 Mar 2012)

  Changed paths:
    M master/docs/manual/cfg-buildsteps.rst

  Log Message:
  -----------
  Added pipe-escaping doc


  Commit: 69fc8309fe6f9b050434f7db43cd9d5faa9229cb
      https://github.com/buildbot/buildbot/commit/69fc8309fe6f9b050434f7db43cd9d5faa9229cb
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2012-03-12 (Mon, 12 Mar 2012)

  Changed paths:
    M master/docs/manual/cfg-buildsteps.rst
  M slave/buildslave/runprocess.py
  M slave/buildslave/test/unit/test_runprocess.py
  M slave/buildslave/test/util/compat.py

  Log Message:
  -----------
  Merge branch '1799' of git://github.com/NateBragg/buildbot

* '1799' of git://github.com/NateBragg/buildbot:
  Added pipe-escaping doc
  Fixes #1799

Whitespace (tabs) fixed in the merge


Compare: https://github.com/buildbot/buildbot/compare/2f22b52...69fc830