From nobody at buildbot.net Thu Mar 1 00:36:50 2012 From: nobody at buildbot.net (Buildbot) Date: Thu, 01 Mar 2012 00:36:50 -0000 Subject: [Buildbot-commits] [Buildbot] #2220: exception on upgrade-master In-Reply-To: <038.3515a64f56c22e16d2e95dd521a98b31@buildbot.net> References: <038.3515a64f56c22e16d2e95dd521a98b31@buildbot.net> Message-ID: <053.d15de49e1e9d4070fe5c4ec6501ff78b@buildbot.net> #2220: exception on upgrade-master -------------------+-------------------- Reporter: dustin | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.6 Version: 0.8.6 | Resolution: Keywords: | -------------------+-------------------- Comment (by dustin): This is sqlite-3.3.6, which is lower than the minimum (3.4.0). We flag this on master startup, but not on upgrade. So we should fix that. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Thu Mar 1 02:42:13 2012 From: nobody at buildbot.net (Buildbot) Date: Thu, 01 Mar 2012 02:42:13 -0000 Subject: [Buildbot-commits] [Buildbot] #2221: wrap db upgrade scripts in a transaction Message-ID: <038.750aff02dde97b891a4270a17a980e5f@buildbot.net> #2221: wrap db upgrade scripts in a transaction ------------------------+---------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.6 Version: 0.8.5 | Keywords: database ------------------------+---------------------- ..so that a failing upgrade does not hose the DB -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Thu Mar 1 02:49:21 2012 From: noreply at github.com (GitHub) Date: Wed, 29 Feb 2012 18:49:21 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] b91145: suggest 'git log' with tags in release notes Message-ID: <4f4ee3b1d30b8_2d511049aec9924e@sh2.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: b91145471c40daf54ee12dab20bcfde928c43123 https://github.com/buildbot/buildbot/commit/b91145471c40daf54ee12dab20bcfde928c43123 Author: Dustin J. Mitchell Date: 2012-02-29 (Wed, 29 Feb 2012) Changed paths: M master/docs/release-notes.rst Log Message: ----------- suggest 'git log' with tags in release notes Commit: 96de335d3c06271b47dc8a93f8dfb4bbf7d1f416 https://github.com/buildbot/buildbot/commit/96de335d3c06271b47dc8a93f8dfb4bbf7d1f416 Author: Dustin J. Mitchell Date: 2012-02-29 (Wed, 29 Feb 2012) Changed paths: M MAINTAINERS.txt Log Message: ----------- add Callek to the windows maintainers list Commit: 71ccf1a008e82cf9681110a2a42d6cc91e764373 https://github.com/buildbot/buildbot/commit/71ccf1a008e82cf9681110a2a42d6cc91e764373 Author: Dustin J. Mitchell Date: 2012-02-29 (Wed, 29 Feb 2012) Changed paths: M MAINTAINERS.txt Log Message: ----------- add Bill per hangout conversation Compare: https://github.com/buildbot/buildbot/compare/665c2d6...71ccf1a From noreply at github.com Thu Mar 1 03:11:01 2012 From: noreply at github.com (GitHub) Date: Wed, 29 Feb 2012 19:11:01 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] 0ff9d0: remove double entry Message-ID: <4f4ee8c54a727_25b21554af01161fa@sh2.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 0ff9d0b5e99f13d8c62f2af516970d36cd5b6b26 https://github.com/buildbot/buildbot/commit/0ff9d0b5e99f13d8c62f2af516970d36cd5b6b26 Author: Dustin J. Mitchell Date: 2012-02-29 (Wed, 29 Feb 2012) Changed paths: M MAINTAINERS.txt Log Message: ----------- remove double entry Commit: 5b708f0bfd31e26e41c04d353e7c9fd8e68146eb https://github.com/buildbot/buildbot/commit/5b708f0bfd31e26e41c04d353e7c9fd8e68146eb Author: Dustin J. Mitchell Date: 2012-02-29 (Wed, 29 Feb 2012) Changed paths: M MAINTAINERS.txt Log Message: ----------- add Callek for hg, too Commit: a26ea40af846c2c2da7437cf039d448ec21f42ac https://github.com/buildbot/buildbot/commit/a26ea40af846c2c2da7437cf039d448ec21f42ac Author: Dustin J. Mitchell Date: 2012-02-29 (Wed, 29 Feb 2012) Changed paths: M MAINTAINERS.txt Log Message: ----------- remove statuses Commit: c9a04c57dfebac4ec6dab27717fa2e6d8724e46f https://github.com/buildbot/buildbot/commit/c9a04c57dfebac4ec6dab27717fa2e6d8724e46f Author: Dustin J. Mitchell Date: 2012-02-29 (Wed, 29 Feb 2012) Changed paths: M MAINTAINERS.txt Log Message: ----------- sort committers and update slave donors Commit: 5fe8217bab7f0facdd8f17625ecdb16a809f7d9a https://github.com/buildbot/buildbot/commit/5fe8217bab7f0facdd8f17625ecdb16a809f7d9a Author: Dustin J. Mitchell Date: 2012-02-29 (Wed, 29 Feb 2012) Changed paths: M MAINTAINERS.txt M master/buildbot/steps/source/__init__.py M master/buildbot/steps/source/oldsource.py M master/buildbot/test/regressions/test_oldpaths.py R master/contrib/bk_buildbot.py M master/docs/developer/definitions.rst M master/docs/manual/cfg-buildsteps.rst M master/docs/release-notes.rst R slave/buildslave/commands/bk.py M slave/buildslave/commands/registry.py R slave/buildslave/test/unit/test_commands_bk.py Log Message: ----------- remove BK. Fixes #2198. Fixes #1773. Fixes #891. Fixes #1715. Compare: https://github.com/buildbot/buildbot/compare/71ccf1a...5fe8217 From nobody at buildbot.net Thu Mar 1 03:11:15 2012 From: nobody at buildbot.net (Buildbot) Date: Thu, 01 Mar 2012 03:11:15 -0000 Subject: [Buildbot-commits] [Buildbot] #891: Better BK tests In-Reply-To: <038.b2cd0b947803f158bea663784a34c052@buildbot.net> References: <038.b2cd0b947803f158bea663784a34c052@buildbot.net> Message-ID: <053.0b7cc6ed3a7664fb65c9d2046be626a7@buildbot.net> #891: Better BK tests ------------------------+--------------------- Reporter: dustin | Owner: Type: enhancement | Status: closed Priority: major | Milestone: 0.8.+ Version: 0.8.0 | Resolution: fixed Keywords: bk | ------------------------+--------------------- Changes (by Dustin J. Mitchell): * status: assigned => closed * resolution: => fixed Comment: remove BK. Fixes #2198. Fixes #1773. Fixes #891. Fixes #1715. Changeset: 5fe8217bab7f0facdd8f17625ecdb16a809f7d9a -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Thu Mar 1 03:11:15 2012 From: nobody at buildbot.net (Buildbot) Date: Thu, 01 Mar 2012 03:11:15 -0000 Subject: [Buildbot-commits] [Buildbot] #1715: BK command ignores args['revision'] In-Reply-To: <038.b9e58de830e5b482ca8ddd876310cc8a@buildbot.net> References: <038.b9e58de830e5b482ca8ddd876310cc8a@buildbot.net> Message-ID: <053.5057bb623a5b775990e9bd45928fd53a@buildbot.net> #1715: BK command ignores args['revision'] -------------------+--------------------- Reporter: dustin | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.+ Version: 0.8.2 | Resolution: fixed Keywords: bk | -------------------+--------------------- Changes (by Dustin J. Mitchell): * status: new => closed * resolution: => fixed Comment: remove BK. Fixes #2198. Fixes #1773. Fixes #891. Fixes #1715. Changeset: 5fe8217bab7f0facdd8f17625ecdb16a809f7d9a -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Thu Mar 1 03:11:15 2012 From: nobody at buildbot.net (Buildbot) Date: Thu, 01 Mar 2012 03:11:15 -0000 Subject: [Buildbot-commits] [Buildbot] #1773: deprecate 'default branch' In-Reply-To: <038.07b8bbcf29816b44f3bd20048e226379@buildbot.net> References: <038.07b8bbcf29816b44f3bd20048e226379@buildbot.net> Message-ID: <053.974fd948f6233c045f5703e88890fcad@buildbot.net> #1773: deprecate 'default branch' --------------------------------------------------+--------------------- Reporter: dustin | Owner: Type: enhancement | Status: closed Priority: major | Milestone: 0.8.7 Version: 0.8.3p1 | Resolution: fixed Keywords: bk, bzr, cvs, darcs, git, hg, p4, svn | --------------------------------------------------+--------------------- Changes (by Dustin J. Mitchell): * status: new => closed * resolution: => fixed Comment: remove BK. Fixes #2198. Fixes #1773. Fixes #891. Fixes #1715. Changeset: 5fe8217bab7f0facdd8f17625ecdb16a809f7d9a -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Thu Mar 1 03:11:14 2012 From: nobody at buildbot.net (Buildbot) Date: Thu, 01 Mar 2012 03:11:14 -0000 Subject: [Buildbot-commits] [Buildbot] #2198: remove BK In-Reply-To: <038.d5de2e6c144f9ad358c20f1fc4cccd02@buildbot.net> References: <038.d5de2e6c144f9ad358c20f1fc4cccd02@buildbot.net> Message-ID: <053.f5f3a552de885fb38c742384cf7ec7e5@buildbot.net> #2198: remove BK -------------------+--------------------- Reporter: dustin | Owner: Type: task | Status: closed Priority: major | Milestone: 0.8.+ Version: 0.8.5 | Resolution: fixed Keywords: bk | -------------------+--------------------- Changes (by Dustin J. Mitchell): * status: new => closed * resolution: => fixed Comment: remove BK. Fixes #2198. Fixes #1773. Fixes #891. Fixes #1715. Changeset: 5fe8217bab7f0facdd8f17625ecdb16a809f7d9a -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Thu Mar 1 03:15:10 2012 From: nobody at buildbot.net (Buildbot) Date: Thu, 01 Mar 2012 03:15:10 -0000 Subject: [Buildbot-commits] [Buildbot] #1773: deprecate 'default branch' In-Reply-To: <038.07b8bbcf29816b44f3bd20048e226379@buildbot.net> References: <038.07b8bbcf29816b44f3bd20048e226379@buildbot.net> Message-ID: <053.532e6b7356b15a715d60afb7f1722735@buildbot.net> #1773: deprecate 'default branch' ----------------------------------------------+----------------------- Reporter: dustin | Owner: Type: enhancement | Status: reopened Priority: major | Milestone: 0.8.7 Version: 0.8.3p1 | Resolution: Keywords: bzr, cvs, darcs, git, hg, p4, svn | ----------------------------------------------+----------------------- Changes (by dustin): * keywords: bk, bzr, cvs, darcs, git, hg, p4, svn => bzr, cvs, darcs, git, hg, p4, svn * status: closed => reopened * resolution: fixed => Comment: ..well, fixed for BK by virtue of removing BK support, but still open for the other VC's -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Thu Mar 1 05:09:44 2012 From: noreply at github.com (GitHub) Date: Wed, 29 Feb 2012 21:09:44 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] 74d0b8: Be more verbose about sqlite version problems Message-ID: <4f4f04987839a_17b23fd626c39aec62091@sh1.rs.github.com.mail> Branch: refs/heads/buildbot-0.8.6 Home: https://github.com/buildbot/buildbot Commit: 74d0b85e70911e21295691a0ac361084cb849965 https://github.com/buildbot/buildbot/commit/74d0b85e70911e21295691a0ac361084cb849965 Author: Dustin J. Mitchell Date: 2012-02-29 (Wed, 29 Feb 2012) Changed paths: M master/buildbot/db/connector.py M master/buildbot/db/pool.py M master/buildbot/scripts/runner.py Log Message: ----------- Be more verbose about sqlite version problems This will let users know when they are using an incompatible version of SQLite, at least. Fixes #2220. From nobody at buildbot.net Thu Mar 1 05:09:49 2012 From: nobody at buildbot.net (Buildbot) Date: Thu, 01 Mar 2012 05:09:49 -0000 Subject: [Buildbot-commits] [Buildbot] #2220: exception on upgrade-master In-Reply-To: <038.3515a64f56c22e16d2e95dd521a98b31@buildbot.net> References: <038.3515a64f56c22e16d2e95dd521a98b31@buildbot.net> Message-ID: <053.446be3d1fb20867b621d63d96c4ce359@buildbot.net> #2220: exception on upgrade-master -------------------+--------------------- Reporter: dustin | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.6 Version: 0.8.6 | Resolution: fixed Keywords: | -------------------+--------------------- Changes (by Dustin J. Mitchell): * status: new => closed * resolution: => fixed Comment: Be more verbose about sqlite version problems This will let users know when they are using an incompatible version of SQLite, at least. Fixes #2220. Changeset: 74d0b85e70911e21295691a0ac361084cb849965 -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Thu Mar 1 05:11:17 2012 From: noreply at github.com (GitHub) Date: Wed, 29 Feb 2012 21:11:17 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] 74d0b8: Be more verbose about sqlite version problems Message-ID: <4f4f04f519aee_335d3f8c5770f2ec3761f@sh1.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 74d0b85e70911e21295691a0ac361084cb849965 https://github.com/buildbot/buildbot/commit/74d0b85e70911e21295691a0ac361084cb849965 Author: Dustin J. Mitchell Date: 2012-02-29 (Wed, 29 Feb 2012) Changed paths: M master/buildbot/db/connector.py M master/buildbot/db/pool.py M master/buildbot/scripts/runner.py Log Message: ----------- Be more verbose about sqlite version problems This will let users know when they are using an incompatible version of SQLite, at least. Fixes #2220. Commit: 339397d4af0fc9eea09ec4e034c01942bebd689a https://github.com/buildbot/buildbot/commit/339397d4af0fc9eea09ec4e034c01942bebd689a Author: Dustin J. Mitchell Date: 2012-02-29 (Wed, 29 Feb 2012) Changed paths: M master/buildbot/db/connector.py M master/buildbot/db/pool.py M master/buildbot/scripts/runner.py Log Message: ----------- Merge branch 'buildbot-0.8.6' * buildbot-0.8.6: Be more verbose about sqlite version problems Compare: https://github.com/buildbot/buildbot/compare/5fe8217...339397d From nobody at buildbot.net Thu Mar 1 05:11:28 2012 From: nobody at buildbot.net (Buildbot) Date: Thu, 01 Mar 2012 05:11:28 -0000 Subject: [Buildbot-commits] [Buildbot] #2220: exception on upgrade-master In-Reply-To: <038.3515a64f56c22e16d2e95dd521a98b31@buildbot.net> References: <038.3515a64f56c22e16d2e95dd521a98b31@buildbot.net> Message-ID: <053.3d689933c42453b7acc7b58bbdf6184a@buildbot.net> #2220: exception on upgrade-master -------------------+--------------------- Reporter: dustin | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.6 Version: 0.8.6 | Resolution: fixed Keywords: | -------------------+--------------------- Comment (by Dustin J. Mitchell): Be more verbose about sqlite version problems This will let users know when they are using an incompatible version of SQLite, at least. Fixes #2220. Changeset: 74d0b85e70911e21295691a0ac361084cb849965 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Thu Mar 1 05:31:36 2012 From: nobody at buildbot.net (Buildbot) Date: Thu, 01 Mar 2012 05:31:36 -0000 Subject: [Buildbot-commits] [Buildbot] #2221: wrap db upgrade scripts in a transaction In-Reply-To: <038.750aff02dde97b891a4270a17a980e5f@buildbot.net> References: <038.750aff02dde97b891a4270a17a980e5f@buildbot.net> Message-ID: <053.a0dec11305c3e75556c7f496f12d8568@buildbot.net> #2221: wrap db upgrade scripts in a transaction ------------------------+---------------------- Reporter: dustin | Owner: Type: enhancement | Status: closed Priority: major | Milestone: 0.8.6 Version: 0.8.5 | Resolution: wontfix Keywords: database | ------------------------+---------------------- Changes (by dustin): * status: new => closed * resolution: => wontfix Comment: Now I remember why I didn't do this before! Upgrade scripts take engines, not connections. Connections are the tie-in for transactions, so there's not a comfortable way to wrap each upgrade step in a transaction. More to the point, sqlite doesn't support schema modifications as part of transactions, and MySQL just doesn't (really) support transactions, so this would only work for Postgres, anyway. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Thu Mar 1 15:01:12 2012 From: noreply at github.com (GitHub) Date: Thu, 01 Mar 2012 07:01:12 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] 63678e: Fix permissions for contrib scripts (chmod +-x). Message-ID: <4f4f8f38c168c_6a30de9af484677@sh2.rs.github.com.mail> Branch: refs/heads/buildbot-0.8.6 Home: https://github.com/buildbot/buildbot Commit: 63678eefd9aece8c9f542c346e2a20f6693f02d5 https://github.com/buildbot/buildbot/commit/63678eefd9aece8c9f542c346e2a20f6693f02d5 Author: Tom Prince Date: 2012-03-01 (Thu, 01 Mar 2012) Changed paths: A master/contrib/bzr_buildbot.py R master/contrib/bzr_buildbot.py A master/contrib/fix_changes_pickle_encoding.py R master/contrib/fix_changes_pickle_encoding.py Log Message: ----------- Fix permissions for contrib scripts (chmod +-x). Thaks to jollyroger for noticing this. From noreply at github.com Thu Mar 1 15:09:37 2012 From: noreply at github.com (GitHub) Date: Thu, 01 Mar 2012 07:09:37 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] e5d354: Add description lines to init scripts Message-ID: <4f4f91314afb_d3415cfae869132@sh2.rs.github.com.mail> Branch: refs/heads/buildbot-0.8.6 Home: https://github.com/buildbot/buildbot Commit: e5d354159e2000ffa9b3f958d401e41d6b8e2e23 https://github.com/buildbot/buildbot/commit/e5d354159e2000ffa9b3f958d401e41d6b8e2e23 Author: Andriy Senkovych Date: 2012-03-01 (Thu, 01 Mar 2012) Changed paths: M master/contrib/init-scripts/buildmaster.init.sh M slave/contrib/init-scripts/buildslave.init.sh Log Message: ----------- Add description lines to init scripts Commit: a0d3d79f1766fc3aac22bf91e06a9409c695514c https://github.com/buildbot/buildbot/commit/a0d3d79f1766fc3aac22bf91e06a9409c695514c Author: Andriy Senkovych Date: 2012-03-01 (Thu, 01 Mar 2012) Changed paths: M master/MANIFEST.in Log Message: ----------- Make libvirt-related contrb files to be included into sdist tarball. Commit: cd3a1abaeea6dd9413a4cb46bb1bdaf05913e2bc https://github.com/buildbot/buildbot/commit/cd3a1abaeea6dd9413a4cb46bb1bdaf05913e2bc Author: Andriy Senkovych Date: 2012-03-01 (Thu, 01 Mar 2012) Changed paths: M master/MANIFEST.in Log Message: ----------- Include master/contrib/blockertest into sdist tarball. Compare: https://github.com/buildbot/buildbot/compare/63678ee...cd3a1ab From noreply at github.com Thu Mar 1 15:10:21 2012 From: noreply at github.com (GitHub) Date: Thu, 01 Mar 2012 07:10:21 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] 63678e: Fix permissions for contrib scripts (chmod +-x). Message-ID: <4f4f915de2573_6c0a3fe78e1b7af0882c3@sh1.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 63678eefd9aece8c9f542c346e2a20f6693f02d5 https://github.com/buildbot/buildbot/commit/63678eefd9aece8c9f542c346e2a20f6693f02d5 Author: Tom Prince Date: 2012-03-01 (Thu, 01 Mar 2012) Changed paths: A master/contrib/bzr_buildbot.py R master/contrib/bzr_buildbot.py A master/contrib/fix_changes_pickle_encoding.py R master/contrib/fix_changes_pickle_encoding.py Log Message: ----------- Fix permissions for contrib scripts (chmod +-x). Thaks to jollyroger for noticing this. Commit: e5d354159e2000ffa9b3f958d401e41d6b8e2e23 https://github.com/buildbot/buildbot/commit/e5d354159e2000ffa9b3f958d401e41d6b8e2e23 Author: Andriy Senkovych Date: 2012-03-01 (Thu, 01 Mar 2012) Changed paths: M master/contrib/init-scripts/buildmaster.init.sh M slave/contrib/init-scripts/buildslave.init.sh Log Message: ----------- Add description lines to init scripts Commit: a0d3d79f1766fc3aac22bf91e06a9409c695514c https://github.com/buildbot/buildbot/commit/a0d3d79f1766fc3aac22bf91e06a9409c695514c Author: Andriy Senkovych Date: 2012-03-01 (Thu, 01 Mar 2012) Changed paths: M master/MANIFEST.in Log Message: ----------- Make libvirt-related contrb files to be included into sdist tarball. Commit: cd3a1abaeea6dd9413a4cb46bb1bdaf05913e2bc https://github.com/buildbot/buildbot/commit/cd3a1abaeea6dd9413a4cb46bb1bdaf05913e2bc Author: Andriy Senkovych Date: 2012-03-01 (Thu, 01 Mar 2012) Changed paths: M master/MANIFEST.in Log Message: ----------- Include master/contrib/blockertest into sdist tarball. Commit: 18275aa9ad4a6459e06156259e7e8d0b60e043d3 https://github.com/buildbot/buildbot/commit/18275aa9ad4a6459e06156259e7e8d0b60e043d3 Author: Tom Prince Date: 2012-03-01 (Thu, 01 Mar 2012) Changed paths: M master/MANIFEST.in R master/contrib/bzr_buildbot.py A master/contrib/bzr_buildbot.py A master/contrib/fix_changes_pickle_encoding.py R master/contrib/fix_changes_pickle_encoding.py M master/contrib/init-scripts/buildmaster.init.sh M slave/contrib/init-scripts/buildslave.init.sh Log Message: ----------- Merge branch 'buildbot-0.8.6' Compare: https://github.com/buildbot/buildbot/compare/339397d...18275aa From nobody at buildbot.net Thu Mar 1 16:19:17 2012 From: nobody at buildbot.net (Buildbot) Date: Thu, 01 Mar 2012 16:19:17 -0000 Subject: [Buildbot-commits] [Buildbot] #2221: wrap db upgrade scripts in a transaction In-Reply-To: <038.750aff02dde97b891a4270a17a980e5f@buildbot.net> References: <038.750aff02dde97b891a4270a17a980e5f@buildbot.net> Message-ID: <053.f98d54953963b69db10e2216b989c1c2@buildbot.net> #2221: wrap db upgrade scripts in a transaction ------------------------+---------------------- Reporter: dustin | Owner: Type: enhancement | Status: closed Priority: major | Milestone: 0.8.6 Version: 0.8.5 | Resolution: wontfix Keywords: database | ------------------------+---------------------- Comment (by exarkun): Actually, SQLite3 does support schema modifications as part of transactions: {{{ >>> from sqlite3 import connect >>> connection = connect(':memory:', isolation_level=None) >>> cursor = connection.cursor() >>> cursor.execute('BEGIN IMMEDIATE TRANSACTION') >>> cursor.execute('CREATE TABLE foo ( a integer, b integer )') >>> cursor.execute('COMMIT') >>> cursor.execute('BEGIN IMMEDIATE TRANSACTION') >>> list(cursor.execute('SELECT * FROM foo')) [] >>> cursor.execute('DROP TABLE foo') >>> cursor.execute('ROLLBACK') >>> list(cursor.execute('SELECT * FROM foo')) [] >>> }}} The pysqlite2 interface to this functionality is rather obtuse, and the documentation is very unclear on the matter, which I suppose is why you thought it did not work. At the actual SQLite3 layer the support is quite solid, though, and has been present for many years. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Thu Mar 1 16:28:46 2012 From: nobody at buildbot.net (Buildbot) Date: Thu, 01 Mar 2012 16:28:46 -0000 Subject: [Buildbot-commits] [Buildbot] #2218: Add support for declarative configuration. In-Reply-To: <042.6eb1d8f39addc6ad3d2fe89bf0002f85@buildbot.net> References: <042.6eb1d8f39addc6ad3d2fe89bf0002f85@buildbot.net> Message-ID: <057.bb8c1da50bb54dea326f4e904fb52989@buildbot.net> #2218: Add support for declarative configuration. ------------------------+-------------------- Reporter: tom.prince | Owner: Type: enhancement | Status: new Priority: major | Milestone: 1.0.+ Version: 0.8.5 | Resolution: Keywords: config | ------------------------+-------------------- Comment (by exarkun): Still better, particularly considering the relative effort compared to the interface in the above example, would be to just have BuildBot know how to load a `master_cfg.json` file (should JSON be selected as the right configuration format) and put the `fromjson.load` call somewhere in the implementation of BuildBot itself, not in the "configuration file" exposed to the admin for customization. The former removes the attractive nuisance of a place to drop arbitrary, inscrutable Python code (an attractive nuisance place directly in front of every new buildbot user's face). The ability to use a Python-syntax master.cfg would be retained for quite some time, of course, to support old configurations and provide an escape hatch for functionality not yet supported by the non-Python configuration file. However, my ultimate goal would be to remove the unstructured dumping ground of master.cfg in favor of non-Python configuration and a more structured configuration plugin mechanism. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Thu Mar 1 16:30:35 2012 From: nobody at buildbot.net (Buildbot) Date: Thu, 01 Mar 2012 16:30:35 -0000 Subject: [Buildbot-commits] [Buildbot] #2221: wrap db upgrade scripts in a transaction In-Reply-To: <038.750aff02dde97b891a4270a17a980e5f@buildbot.net> References: <038.750aff02dde97b891a4270a17a980e5f@buildbot.net> Message-ID: <053.65191cde51a8d6a06fb85cf91fa67561@buildbot.net> #2221: wrap db upgrade scripts in a transaction ------------------------+---------------------- Reporter: dustin | Owner: Type: enhancement | Status: closed Priority: major | Milestone: 0.8.6 Version: 0.8.5 | Resolution: wontfix Keywords: database | ------------------------+---------------------- Comment (by dustin): I wrestled with some problems with this in older versions of sqlite, where the schema changes would not appear for any connections open concurrently with the schema changes themselves. See #1810. I don't especially want to re-open that can of worms again. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Thu Mar 1 16:44:50 2012 From: nobody at buildbot.net (Buildbot) Date: Thu, 01 Mar 2012 16:44:50 -0000 Subject: [Buildbot-commits] [Buildbot] #2218: Add support for declarative configuration. In-Reply-To: <042.6eb1d8f39addc6ad3d2fe89bf0002f85@buildbot.net> References: <042.6eb1d8f39addc6ad3d2fe89bf0002f85@buildbot.net> Message-ID: <057.9ee6cc37eecb82bd0b7626a9423416db@buildbot.net> #2218: Add support for declarative configuration. ------------------------+-------------------- Reporter: tom.prince | Owner: Type: enhancement | Status: new Priority: major | Milestone: 1.0.+ Version: 0.8.5 | Resolution: Keywords: config | ------------------------+-------------------- Comment (by dustin): Having the `fromjson.load` call in Buildbot makes sense. I also like that you've separated plugins (which to me means steps, schedulers, status receivers, and so on) from configuration. Lots of Buildbot users do dynamic configuration generation -- it's even done in the metabuildbot configuration -- but that can be handled by generating JSON. This would have the added advantage of getting away from the pains of the existing format: * real, functional objects are instantiated in the config (e.g., schedulers) * lots of backward compatiblity * different case requirements * import paths used in configs live forever * ..I could think of more.. In fact, this wouldn't be horribly difficult to accomplish with the new `MasterConfig` support. Which brings us to the painful but all-too-common question: who's up for implementing this? I'll start by adding it to ProjectIdeas. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Thu Mar 1 19:00:12 2012 From: nobody at buildbot.net (Buildbot) Date: Thu, 01 Mar 2012 19:00:12 -0000 Subject: [Buildbot-commits] [Buildbot] #1951: Improve Nightly's next-build-finding algorithm In-Reply-To: <038.cadfd8cbd2ebf386bea86eaaf5cffd2a@buildbot.net> References: <038.cadfd8cbd2ebf386bea86eaaf5cffd2a@buildbot.net> Message-ID: <053.e5cc01da14caa6b371a4156e3fd4b8e5@buildbot.net> #1951: Improve Nightly's next-build-finding algorithm -----------------------------------------+-------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.+ Version: 0.8.3p1 | Resolution: Keywords: performance, simplem, sprint | -----------------------------------------+-------------------- Changes (by tom.prince): * keywords: performance, simple => performance, simplem, sprint -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Thu Mar 1 19:00:35 2012 From: nobody at buildbot.net (Buildbot) Date: Thu, 01 Mar 2012 19:00:35 -0000 Subject: [Buildbot-commits] [Buildbot] #1951: Improve Nightly's next-build-finding algorithm In-Reply-To: <038.cadfd8cbd2ebf386bea86eaaf5cffd2a@buildbot.net> References: <038.cadfd8cbd2ebf386bea86eaaf5cffd2a@buildbot.net> Message-ID: <053.b99967f9a87d01d736b290879295ef98@buildbot.net> #1951: Improve Nightly's next-build-finding algorithm ----------------------------------------+-------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.+ Version: 0.8.3p1 | Resolution: Keywords: performance, simple, sprint | ----------------------------------------+-------------------- Changes (by tom.prince): * keywords: performance, simplem, sprint => performance, simple, sprint -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Mar 2 16:30:13 2012 From: nobody at buildbot.net (Buildbot) Date: Fri, 02 Mar 2012 16:30:13 -0000 Subject: [Buildbot-commits] [Buildbot] #2222: master-side git step doesn't support reference repos. Message-ID: <042.5952e6fcb38fe92bbd45d04287640e0d@buildbot.net> #2222: master-side git step doesn't support reference repos. ------------------------+------------------- Reporter: tom.prince | Owner: Type: enhancement | Status: new Priority: trivial | Milestone: 0.8.7 Version: master | Keywords: git ------------------------+------------------- --reference is the option that needs to be passed to clone -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 3 01:12:06 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 03 Mar 2012 01:12:06 -0000 Subject: [Buildbot-commits] [Buildbot] #2223: Consider reverting removal of slave-side BK step. Message-ID: <042.adba6b490c04c5469778d0f4c5d73657@buildbot.net> #2223: Consider reverting removal of slave-side BK step. -----------------------+------------------------ Reporter: tom.prince | Owner: tom.prince Type: defect | Status: new Priority: major | Milestone: 0.8.7 Version: master | Keywords: bk -----------------------+------------------------ harlan has indicated an interest in maintaining BK support, and working on a master-side BK step. To ease transition, we should consider keeping the slave-side step around at least until such time as there is a master-side step. This ticket is marked as 0.8.7 defect as a reminder to revisit the issue before releasing 0.8.7. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 3 03:55:37 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 03 Mar 2012 03:55:37 -0000 Subject: [Buildbot-commits] [Buildbot] #2198: remove BK In-Reply-To: <038.d5de2e6c144f9ad358c20f1fc4cccd02@buildbot.net> References: <038.d5de2e6c144f9ad358c20f1fc4cccd02@buildbot.net> Message-ID: <053.88c92d9f925a86234038ace760c55eaf@buildbot.net> #2198: remove BK -------------------+----------------------- Reporter: dustin | Owner: Type: task | Status: reopened Priority: major | Milestone: 0.8.+ Version: 0.8.5 | Resolution: Keywords: bk | -------------------+----------------------- Changes (by harlan): * status: closed => reopened * resolution: fixed => Comment: I'm interested in supporting BK for buildbot. Please revert the deletion, 'k? -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 3 15:56:43 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 03 Mar 2012 15:56:43 -0000 Subject: [Buildbot-commits] [Buildbot] #2198: remove BK In-Reply-To: <038.d5de2e6c144f9ad358c20f1fc4cccd02@buildbot.net> References: <038.d5de2e6c144f9ad358c20f1fc4cccd02@buildbot.net> Message-ID: <053.86a270df1275648fab969d51a7b1a03a@buildbot.net> #2198: remove BK -------------------+--------------------- Reporter: dustin | Owner: Type: task | Status: closed Priority: major | Milestone: 0.8.+ Version: 0.8.5 | Resolution: fixed Keywords: bk | -------------------+--------------------- Changes (by dustin): * status: reopened => closed * resolution: => fixed Comment: We'll un-revert in #2223 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 3 16:00:18 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 03 Mar 2012 16:00:18 -0000 Subject: [Buildbot-commits] [Buildbot] #1715: BK command ignores args['revision'] In-Reply-To: <038.b9e58de830e5b482ca8ddd876310cc8a@buildbot.net> References: <038.b9e58de830e5b482ca8ddd876310cc8a@buildbot.net> Message-ID: <053.f8547842749dd4108cd704563c1934c1@buildbot.net> #1715: BK command ignores args['revision'] -------------------+----------------------- Reporter: dustin | Owner: Type: defect | Status: reopened Priority: major | Milestone: 0.8.+ Version: 0.8.2 | Resolution: Keywords: bk | -------------------+----------------------- Changes (by dustin): * cc: harlan (added) * status: closed => reopened * resolution: fixed => -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 3 16:02:05 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 03 Mar 2012 16:02:05 -0000 Subject: [Buildbot-commits] [Buildbot] #2223: Consider reverting removal of slave-side BK step. In-Reply-To: <042.adba6b490c04c5469778d0f4c5d73657@buildbot.net> References: <042.adba6b490c04c5469778d0f4c5d73657@buildbot.net> Message-ID: <057.11b44ea3935c85a1cf0a97e097fee144@buildbot.net> #2223: Consider reverting removal of slave-side BK step. -----------------------+------------------------- Reporter: tom.prince | Owner: tom.prince Type: defect | Status: new Priority: major | Milestone: 0.8.7 Version: master | Resolution: Keywords: bk | -----------------------+------------------------- Comment (by dustin): Harlan is going to look at the possibility of restoring the slave-side step (and adding tests and fixing #1715) or, preferably, adding a master- side step and not supporting slave-side BK anymore. I haven't done the revert yet, but it's in version control so there's no rush and we can do that whenever it's required. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 3 20:44:41 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 03 Mar 2012 20:44:41 -0000 Subject: [Buildbot-commits] [Buildbot] #2223: Consider reverting removal of slave-side BK step. In-Reply-To: <042.adba6b490c04c5469778d0f4c5d73657@buildbot.net> References: <042.adba6b490c04c5469778d0f4c5d73657@buildbot.net> Message-ID: <057.61b2b9309986c1cc9abad2a8aab9c262@buildbot.net> #2223: Consider reverting removal of slave-side BK step. -----------------------+------------------------- Reporter: tom.prince | Owner: tom.prince Type: defect | Status: new Priority: major | Milestone: 0.8.7 Version: master | Resolution: Keywords: bk | -----------------------+------------------------- Comment (by dustin): Harlan, can I get your name/email for inclusion in MAINTAINERS.txt? -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 3 21:59:55 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 03 Mar 2012 21:59:55 -0000 Subject: [Buildbot-commits] [Buildbot] #2224: Support MySQL partitioning Message-ID: <038.407e30bc95d777b71e4bf74b2d50fcc5@buildbot.net> #2224: Support MySQL partitioning ------------------------+---------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.9.+ Version: 0.8.2 | Keywords: database ------------------------+---------------------- A big Buildbot install dumps massive amounts of data into the DB, and its "normal" pruning process is just DELETE statements, which don't necessarily free up space, and at any rate can leave tables badly fragmented. A DBA will tell you that the fix is to partition the data by time, and simply drop partitions when they are no longer needed. No fragmentation, no delays on pruning, no muss, no fuss. I think that this is *primarily* something that would be done by a skilled DBA without modification of Buildbot itself, but let's figure out if Buildbot can make this easier or if there are other modifications that could help. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sat Mar 3 22:38:31 2012 From: noreply at github.com (GitHub) Date: Sat, 03 Mar 2012 14:38:31 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] 7d5b00: add Harlan as BK maintainer Message-ID: <4f529d6746e6c_113c3fc74cde0af0725c9@sh1.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 7d5b00ba39a8001b1e55f7186e6fa759bcab6547 https://github.com/buildbot/buildbot/commit/7d5b00ba39a8001b1e55f7186e6fa759bcab6547 Author: Dustin J. Mitchell Date: 2012-03-03 (Sat, 03 Mar 2012) Changed paths: M MAINTAINERS.txt Log Message: ----------- add Harlan as BK maintainer From noreply at github.com Sun Mar 4 17:23:54 2012 From: noreply at github.com (GitHub) Date: Sun, 04 Mar 2012 09:23:54 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] c22b52: add IRC nicks to MAINTAINERS.txt Message-ID: <4f53a52a61b8d_6c1185eae8517e8@sh2.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: c22b52599e5154309c7d46354505c322cdbff1f5 https://github.com/buildbot/buildbot/commit/c22b52599e5154309c7d46354505c322cdbff1f5 Author: Dustin J. Mitchell Date: 2012-03-04 (Sun, 04 Mar 2012) Changed paths: M MAINTAINERS.txt Log Message: ----------- add IRC nicks to MAINTAINERS.txt From noreply at github.com Sun Mar 4 23:48:16 2012 From: noreply at github.com (GitHub) Date: Sun, 04 Mar 2012 15:48:16 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] ef79ac: Add jollyroger and Adam Collard as Debian/Ubuntu m... Message-ID: <4f53ff401b889_32a33ff9e39142f056379@sh1.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: ef79ac82978b619d94fc2bdf780d70f62048f862 https://github.com/buildbot/buildbot/commit/ef79ac82978b619d94fc2bdf780d70f62048f862 Author: Dustin J. Mitchell Date: 2012-03-04 (Sun, 04 Mar 2012) Changed paths: M MAINTAINERS.txt Log Message: ----------- Add jollyroger and Adam Collard as Debian/Ubuntu maintainers From nobody at buildbot.net Mon Mar 5 00:21:48 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 05 Mar 2012 00:21:48 -0000 Subject: [Buildbot-commits] [Buildbot] #2225: LoggingBuildStep should take an option to specify which exit codes indicate errors. Message-ID: <042.54a88721511b2a05ea80e07a5ad115d2@buildbot.net> #2225: LoggingBuildStep should take an option to specify which exit codes indicate errors. ------------------------+------------------------ Reporter: tom.prince | Owner: tom.prince Type: enhancement | Status: new Priority: major | Milestone: 0.8.7 Version: 0.8.2 | Keywords: ------------------------+------------------------ See https://mxr.mozilla.org/build/source/buildbotcustom/steps/misc.py#242 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Mar 5 00:33:18 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 05 Mar 2012 00:33:18 -0000 Subject: [Buildbot-commits] [Buildbot] #2226: Add a buildstep that just renders stuff into a log file. Message-ID: <042.15bf7a88e35697a03e04984a593c5ce0@buildbot.net> #2226: Add a buildstep that just renders stuff into a log file. ------------------------+------------------------ Reporter: tom.prince | Owner: tom.prince Type: enhancement | Status: new Priority: major | Milestone: 0.8.7 Version: 0.8.5 | Keywords: ------------------------+------------------------ See https://mxr.mozilla.org/build/source/buildbotcustom/steps/misc.py#698 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Mar 5 03:10:30 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 05 Mar 2012 03:10:30 -0000 Subject: [Buildbot-commits] [Buildbot] #870: Http log rotation triggers exceptions.WindowsError on master when multiple web ports are present In-Reply-To: <038.696c4e783612fd6be7606a909d141c0a@buildbot.net> References: <038.696c4e783612fd6be7606a909d141c0a@buildbot.net> Message-ID: <053.cb84dd589ae786439f655bf4aab7fe33@buildbot.net> #870: Http log rotation triggers exceptions.WindowsError on master when multiple web ports are present ---------------------------------+-------------------- Reporter: dustin | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.0 | Resolution: Keywords: web, windows, sprint | ---------------------------------+-------------------- Changes (by dustin): * keywords: web, windows => web, windows, sprint * priority: blocker => major -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Mar 5 03:13:03 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 05 Mar 2012 03:13:03 -0000 Subject: [Buildbot-commits] [Buildbot] #377: funny arg splitting for cmd.exe in some cases but not others In-Reply-To: <037.33f4c903f9e3c3d1df369b585b771fc4@buildbot.net> References: <037.33f4c903f9e3c3d1df369b585b771fc4@buildbot.net> Message-ID: <052.129d35807622e5e2e094c49a92a7e0a2@buildbot.net> #377: funny arg splitting for cmd.exe in some cases but not others ----------------------------+-------------------- Reporter: zooko | Owner: Type: defect | Status: new Priority: critical | Milestone: 0.8.+ Version: 0.7.9 | Resolution: Keywords: windows, sprint | ----------------------------+-------------------- Changes (by dustin): * keywords: windows => windows, sprint Comment: I think that the approach in comment 16 is still the best here. Someone with a Windows system to test on should be able to knock this together pretty quickly. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Mar 5 03:14:52 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 05 Mar 2012 03:14:52 -0000 Subject: [Buildbot-commits] [Buildbot] #739: HTML logs do not get compressed In-Reply-To: <039.2b0ebe3105f086521fea6a5dd8cfc947@buildbot.net> References: <039.2b0ebe3105f086521fea6a5dd8cfc947@buildbot.net> Message-ID: <054.613dbad6391b86964586118a6943a91f@buildbot.net> #739: HTML logs do not get compressed ---------------------+-------------------- Reporter: marcusl | Owner: Type: defect | Status: new Priority: critical | Milestone: 0.8.+ Version: 0.7.12 | Resolution: Keywords: sprint | ---------------------+-------------------- Changes (by dustin): * keywords: => sprint Comment: This code hasn't changed much in the intervening two years, so this bug is likely still present. Let's try to reproduce, then take apart the resulting pickle and write a fix. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Mar 5 03:21:32 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 05 Mar 2012 03:21:32 -0000 Subject: [Buildbot-commits] [Buildbot] #1854: FileUpload never times out In-Reply-To: <039.e7bfab756d445121a2e0b7af56f23535@buildbot.net> References: <039.e7bfab756d445121a2e0b7af56f23535@buildbot.net> Message-ID: <054.fe9accf123f187613924b8b17681f3ff@buildbot.net> #1854: FileUpload never times out -----------------------------+-------------------- Reporter: exarkun | Owner: Type: defect | Status: new Priority: critical | Milestone: 0.8.+ Version: 0.8.2 | Resolution: Keywords: transfer, sprint | -----------------------------+-------------------- Changes (by dustin): * keywords: transfer => transfer, sprint Comment: This should be relatively easy to replicate (e.g., using iptables). I think that the fix is to add a keepalive or timeout to the step. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Mar 5 03:22:08 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 05 Mar 2012 03:22:08 -0000 Subject: [Buildbot-commits] [Buildbot] #2098: support for patches in master-side source steps In-Reply-To: <038.7bf88629819eaedd012609f66bc29db2@buildbot.net> References: <038.7bf88629819eaedd012609f66bc29db2@buildbot.net> Message-ID: <053.84b522579d46e59348129543ecba4c94@buildbot.net> #2098: support for patches in master-side source steps -------------------------------------+-------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: critical | Milestone: 0.8.+ Version: 0.8.4p2 | Resolution: Keywords: master-side-source-steps | -------------------------------------+-------------------- Changes (by dustin): * keywords: => master-side-source-steps -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Mar 5 03:28:28 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 05 Mar 2012 03:28:28 -0000 Subject: [Buildbot-commits] [Buildbot] #2132: Builder status in waterfall not updated In-Reply-To: <041.4a880c39b94b8731b1b9377f4a70dea4@buildbot.net> References: <041.4a880c39b94b8731b1b9377f4a70dea4@buildbot.net> Message-ID: <056.e6697a77c2404c0d8ecfc33adeb5c315@buildbot.net> #2132: Builder status in waterfall not updated ----------------------+-------------------- Reporter: homer5439 | Owner: Type: defect | Status: new Priority: critical | Milestone: 0.8.7 Version: 0.8.5 | Resolution: Keywords: status | ----------------------+-------------------- Changes (by dustin): * milestone: 0.8.+ => 0.8.7 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Mar 5 03:28:56 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 05 Mar 2012 03:28:56 -0000 Subject: [Buildbot-commits] [Buildbot] #2181: triggerable broken with sourcestampsets In-Reply-To: <038.ea83a3efb6ac67f3a5168c5c5a0d26bc@buildbot.net> References: <038.ea83a3efb6ac67f3a5168c5c5a0d26bc@buildbot.net> Message-ID: <053.1f1ff3836380a96014fba84990a7c4d9@buildbot.net> #2181: triggerable broken with sourcestampsets ---------------------+--------------------- Reporter: dustin | Owner: Type: defect | Status: closed Priority: critical | Milestone: 0.8.+ Version: 0.8.5 | Resolution: fixed Keywords: | ---------------------+--------------------- Changes (by dustin): * status: new => closed * resolution: => fixed -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Mar 5 03:31:14 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 05 Mar 2012 03:31:14 -0000 Subject: [Buildbot-commits] [Buildbot] #68: New mechanism for monitoring buildbot startup In-Reply-To: <039.592b19946618ac245ee0d41afdd879a6@buildbot.net> References: <039.592b19946618ac245ee0d41afdd879a6@buildbot.net> Message-ID: <054.d9f381062136d0b7f2c18efa5eac49d1@buildbot.net> #68: New mechanism for monitoring buildbot startup --------------------+----------------------- Reporter: joduinn | Owner: warner Type: defect | Status: assigned Priority: major | Milestone: 0.8.+ Version: 0.7.5 | Resolution: Keywords: sprint | --------------------+----------------------- Changes (by dustin): * keywords: => sprint Comment: This may make a good sprint project - even if that's only for POSIX or only for Windows. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Mar 5 03:34:05 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 05 Mar 2012 03:34:05 -0000 Subject: [Buildbot-commits] [Buildbot] #2207: MailNotifier use the user-db by default, but that doesn't properly get populated. In-Reply-To: <042.d785d3f7f38d095b49c36c4643c9ffd6@buildbot.net> References: <042.d785d3f7f38d095b49c36c4643c9ffd6@buildbot.net> Message-ID: <057.a7024872edc790f3858273d2058a552a@buildbot.net> #2207: MailNotifier use the user-db by default, but that doesn't properly get populated. -----------------------+-------------------- Reporter: tom.prince | Owner: Type: defect | Status: new Priority: critical | Milestone: 0.8.+ Version: master | Resolution: Keywords: users | -----------------------+-------------------- Changes (by dustin): * keywords: => users -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Mar 5 03:34:57 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 05 Mar 2012 03:34:57 -0000 Subject: [Buildbot-commits] [Buildbot] #75: IM status targets In-Reply-To: <038.077cde644a25b8ae82acb2a21287d86e@buildbot.net> References: <038.077cde644a25b8ae82acb2a21287d86e@buildbot.net> Message-ID: <053.6b3f2e9f89b653f6e6134219b029e4d7@buildbot.net> #75: IM status targets ------------------------+--------------------- Reporter: warner | Owner: warner Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: 0.7.5 | Resolution: Keywords: irc | ------------------------+--------------------- Changes (by dustin): * keywords: => irc -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Mar 5 03:37:24 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 05 Mar 2012 03:37:24 -0000 Subject: [Buildbot-commits] [Buildbot] #97: Use svn switch to improve efficiency In-Reply-To: <041.fdcc077787c8f6a36b12df6a065f70a9@buildbot.net> References: <041.fdcc077787c8f6a36b12df6a065f70a9@buildbot.net> Message-ID: <056.36e15f59b31ea95d6b37328317c8c073@buildbot.net> #97: Use svn switch to improve efficiency ------------------------+----------------------- Reporter: retracile | Owner: Type: enhancement | Status: reopened Priority: major | Milestone: 0.8.+ Version: 0.8.3 | Resolution: Keywords: svn, sprint | ------------------------+----------------------- Changes (by dustin): * keywords: svn => svn, sprint Comment: duncanphilipnorman - any update on this bug? For someone interested in subversion support, perhaps this could be finished up during the !PyCon sprints? -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Mar 5 03:41:53 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 05 Mar 2012 03:41:53 -0000 Subject: [Buildbot-commits] [Buildbot] #159: should be possible to have two buildbot.steps.source.SVN(mode="copy") steps in a single build factory In-Reply-To: <039.026d4399280638dac0c43934f327f915@buildbot.net> References: <039.026d4399280638dac0c43934f327f915@buildbot.net> Message-ID: <054.d76650d0e13ed4de7a743eda6ff1ef7d@buildbot.net> #159: should be possible to have two buildbot.steps.source.SVN(mode="copy") steps in a single build factory -----------------------------+-------------------- Reporter: exarkun | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.7 Version: 0.7.6 | Resolution: Keywords: projrepo, sprint | -----------------------------+-------------------- Changes (by dustin): * keywords: projrepo => projrepo, sprint * milestone: 0.8.+ => 0.8.7 Comment: This should be part of the master-side implementation (of all source steps, in fact). This will become much more important when multirepo support is complete. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Mar 5 03:42:50 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 05 Mar 2012 03:42:50 -0000 Subject: [Buildbot-commits] [Buildbot] #159: should be possible to have two buildbot.steps.source.SVN(mode="copy") steps in a single build factory In-Reply-To: <039.026d4399280638dac0c43934f327f915@buildbot.net> References: <039.026d4399280638dac0c43934f327f915@buildbot.net> Message-ID: <054.b77e975eb514fd93daf6a432dd668b5c@buildbot.net> #159: should be possible to have two buildbot.steps.source.SVN(mode="copy") steps in a single build factory -------------------------------------------------+------------------------- Reporter: exarkun | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.7 Version: 0.7.6 | Resolution: Keywords: projrepo, sprint, master-side- | source-steps | -------------------------------------------------+------------------------- Changes (by dustin): * keywords: projrepo, sprint => projrepo, sprint, master-side-source-steps -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Mar 5 03:43:18 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 05 Mar 2012 03:43:18 -0000 Subject: [Buildbot-commits] [Buildbot] #167: svnversion is pretty slow, particularly on windows In-Reply-To: <039.770b2e3e130bad3926877820624859b9@buildbot.net> References: <039.770b2e3e130bad3926877820624859b9@buildbot.net> Message-ID: <054.1ef142bc48348b3b627330574e04f558@buildbot.net> #167: svnversion is pretty slow, particularly on windows --------------------------------------------------+----------------------- Reporter: exarkun | Owner: ipv6guru Type: defect | Status: accepted Priority: major | Milestone: 0.8.+ Version: 0.7.6 | Resolution: Keywords: svn, sprint, master-side-source-steps | --------------------------------------------------+----------------------- Changes (by dustin): * keywords: svn => svn, sprint, master-side-source-steps -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Mar 5 03:45:47 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 05 Mar 2012 03:45:47 -0000 Subject: [Buildbot-commits] [Buildbot] #203: py.test buildbot support In-Reply-To: <037.242869309a5953a83a3fe3ebe8bd4918@buildbot.net> References: <037.242869309a5953a83a3fe3ebe8bd4918@buildbot.net> Message-ID: <052.b30d175146ceb90ffb2e65daadb389e0@buildbot.net> #203: py.test buildbot support ------------------------+------------------------- Reporter: fijal | Owner: Type: enhancement | Status: closed Priority: major | Milestone: 0.8.+ Version: 0.7.6 | Resolution: worksforme Keywords: | ------------------------+------------------------- Changes (by dustin): * status: new => closed * resolution: => worksforme -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Mar 5 03:51:19 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 05 Mar 2012 03:51:19 -0000 Subject: [Buildbot-commits] [Buildbot] #205: button which takes me to the most recent green->red state transition In-Reply-To: <037.7940944cf1042b523bb7ea03ddceae26@buildbot.net> References: <037.7940944cf1042b523bb7ea03ddceae26@buildbot.net> Message-ID: <052.a6c7e30431bec7002bab1ce1e4389162@buildbot.net> #205: button which takes me to the most recent green->red state transition ------------------------+-------------------- Reporter: zooko | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.9.+ Version: 0.7.6 | Resolution: Keywords: web | ------------------------+-------------------- Changes (by dustin): * milestone: 0.8.+ => 0.9.+ -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Mar 5 03:52:13 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 05 Mar 2012 03:52:13 -0000 Subject: [Buildbot-commits] [Buildbot] #212: buildbot doesn't respond to darcs tags In-Reply-To: <037.1030dcc6d9512e2f583b74228a664f7e@buildbot.net> References: <037.1030dcc6d9512e2f583b74228a664f7e@buildbot.net> Message-ID: <052.0eb72c7a0c43bd8a509ecf50a4d86e4f@buildbot.net> #212: buildbot doesn't respond to darcs tags ------------------------+-------------------- Reporter: zooko | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: 0.7.6 | Resolution: Keywords: darcs | ------------------------+-------------------- Changes (by dustin): * type: defect => enhancement -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Mar 5 03:56:04 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 05 Mar 2012 03:56:04 -0000 Subject: [Buildbot-commits] [Buildbot] #310: MailNotifier: use mime types for log file attachments? In-Reply-To: <039.c0f3a169c07b8049ca6cb0492d8b9236@buildbot.net> References: <039.c0f3a169c07b8049ca6cb0492d8b9236@buildbot.net> Message-ID: <054.b6d144b8a64fc3d6f25927cb4d66f580@buildbot.net> #310: MailNotifier: use mime types for log file attachments? ------------------------+-------------------- Reporter: spurkis | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.9.+ Version: 0.7.7 | Resolution: Keywords: mail | ------------------------+-------------------- Changes (by dustin): * milestone: 0.8.+ => 0.9.+ Comment: logs, in general, should have mime types. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Mar 5 03:56:12 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 05 Mar 2012 03:56:12 -0000 Subject: [Buildbot-commits] [Buildbot] #2207: MailNotifier use the user-db by default, but that doesn't properly get populated. In-Reply-To: <042.d785d3f7f38d095b49c36c4643c9ffd6@buildbot.net> References: <042.d785d3f7f38d095b49c36c4643c9ffd6@buildbot.net> Message-ID: <057.8994d20023aeea3602bdc72af0150f85@buildbot.net> #2207: MailNotifier use the user-db by default, but that doesn't properly get populated. ------------------------+-------------------- Reporter: tom.prince | Owner: Type: defect | Status: new Priority: critical | Milestone: 0.8.+ Version: master | Resolution: Keywords: users, mail | ------------------------+-------------------- Changes (by dustin): * keywords: users => users, mail -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Mar 5 04:07:45 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 05 Mar 2012 04:07:45 -0000 Subject: [Buildbot-commits] [Buildbot] #371: ShellCommand argument "logfiles" does not properly work for HTML log files In-Reply-To: <035.ed912ff1ea57972c51ba895981321e1d@buildbot.net> References: <035.ed912ff1ea57972c51ba895981321e1d@buildbot.net> Message-ID: <050.9198440fc1172fa2fa5ee09c2eaf1218@buildbot.net> #371: ShellCommand argument "logfiles" does not properly work for HTML log files ------------------------+-------------------- Reporter: cli | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: 0.7.9 | Resolution: Keywords: web | ------------------------+-------------------- Changes (by dustin): * keywords: => web -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Mon Mar 5 04:07:50 2012 From: noreply at github.com (GitHub) Date: Sun, 04 Mar 2012 20:07:50 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] e84ab2: Move Source class from steps.source.oldsource to s... Message-ID: <4f543c16b525e_32a33ff9e39142f07437e@sh1.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: e84ab229c0dcf4453103a35f6fc39ce1fcb4f6b9 https://github.com/buildbot/buildbot/commit/e84ab229c0dcf4453103a35f6fc39ce1fcb4f6b9 Author: Tom Prince Date: 2012-03-04 (Sun, 04 Mar 2012) Changed paths: M master/buildbot/steps/source/__init__.py A master/buildbot/steps/source/base.py M master/buildbot/steps/source/bzr.py M master/buildbot/steps/source/cvs.py M master/buildbot/steps/source/git.py M master/buildbot/steps/source/mercurial.py M master/buildbot/steps/source/oldsource.py M master/buildbot/steps/source/svn.py A master/buildbot/test/unit/test_steps_source_base_Source.py A master/buildbot/test/unit/test_steps_source_oldsource_ComputeRepositoryURL.py R master/buildbot/test/unit/test_steps_source_oldsource_Source.py Log Message: ----------- Move Source class from steps.source.oldsource to steps.source.base. Source moved to oldsource when that was created from steps.source. Since it is also used as the base class for the new steps, move it into its own file. Commit: 6da63a007607e2a5c20b15a04b3ab5f95997452f https://github.com/buildbot/buildbot/commit/6da63a007607e2a5c20b15a04b3ab5f95997452f Author: Tom Prince Date: 2012-03-04 (Sun, 04 Mar 2012) Changed paths: M master/buildbot/steps/source/__init__.py M master/buildbot/test/regressions/test_oldpaths.py M master/docs/release-notes.rst Log Message: ----------- Remove compatibility import of undocumented _ComputeRepositoryURL. Compare: https://github.com/buildbot/buildbot/compare/ef79ac8...6da63a0 From nobody at buildbot.net Mon Mar 5 04:11:13 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 05 Mar 2012 04:11:13 -0000 Subject: [Buildbot-commits] [Buildbot] #419: No tests for buildbot.changes.hgbuildbot.py ? In-Reply-To: <039.a0482836020bd633f2a3f0750c8f5e9c@buildbot.net> References: <039.a0482836020bd633f2a3f0750c8f5e9c@buildbot.net> Message-ID: <054.8393ae342216fb1da6bb27bdb3830fe3@buildbot.net> #419: No tests for buildbot.changes.hgbuildbot.py ? ---------------------+---------------------- Reporter: marcusl | Owner: marcusl Type: defect | Status: new Priority: major | Milestone: 0.8.+ Version: 0.7.9 | Resolution: Keywords: hg tests | ---------------------+---------------------- Comment (by dustin): Given the problems with this file - it has trouble mixing the hg and Twisted runtimes - I wonder if we shouldn't split it up into a simple hg hook and a more complex Buildbot-specific portion. That would at least allow the latter to be tested. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Mar 5 04:13:54 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 05 Mar 2012 04:13:54 -0000 Subject: [Buildbot-commits] [Buildbot] #440: py2exe buildbot.exe fails to find sample.cfg when creating new master In-Reply-To: <039.699c0329c2de8e5da28d5a281c6ba24b@buildbot.net> References: <039.699c0329c2de8e5da28d5a281c6ba24b@buildbot.net> Message-ID: <054.3479bdd1ca0004427bb964aaab52eb8d@buildbot.net> #440: py2exe buildbot.exe fails to find sample.cfg when creating new master --------------------+---------------------- Reporter: marcusl | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.+ Version: 0.7.10 | Resolution: wontfix Keywords: windows | --------------------+---------------------- Changes (by dustin): * status: assigned => closed * resolution: => wontfix Comment: For the moment, we're not trying to support py2exe. I'm sure this utility supports this sort of behavior, though. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Mar 5 04:24:10 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 05 Mar 2012 04:24:10 -0000 Subject: [Buildbot-commits] [Buildbot] #470: SVN step, sub-directory of branch and add peg revision In-Reply-To: <040.f679496973d56570c564312c853ea98b@buildbot.net> References: <040.f679496973d56570c564312c853ea98b@buildbot.net> Message-ID: <055.5eceac908d05bdc85f8c8dd049ea51db@buildbot.net> #470: SVN step, sub-directory of branch and add peg revision ------------------------+--------------------- Reporter: ipv6guru | Owner: Type: enhancement | Status: closed Priority: major | Milestone: 0.8.+ Version: 0.7.10 | Resolution: fixed Keywords: svn | ------------------------+--------------------- Changes (by dustin): * status: new => closed * resolution: => fixed Comment: I don't see much reason to use pegged-version URLs. And showing the branch name in the status occurs in a number of places already. And the master-side steps do not use `.buildbot-sourcedata`. So I think this is somewhere between "fixed" and "wontfix" -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Mar 5 04:28:02 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 05 Mar 2012 04:28:02 -0000 Subject: [Buildbot-commits] [Buildbot] #2227: Make contrib/post_build_request.py usable via import Message-ID: <042.4efad3ee00a8974bb8375e16c4bed645@buildbot.net> #2227: Make contrib/post_build_request.py usable via import ------------------------+------------------- Reporter: tom.prince | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.+ Version: 0.8.5 | Keywords: ------------------------+------------------- `contrib/bzr_buildbot.py` and `buildbot/changes/hgbuildbot.py` both talk to the master via twisted PB. However, they are designed to be imported by other potentially long running code. If they are called twice from the same process, they will fail, since twisted's reactor is not restartable. `contrib/post_build_request.py` is designed to be used without twisted, so if it had a library entry point, the about two programs could be implemented in terms of it. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Mar 5 04:28:35 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 05 Mar 2012 04:28:35 -0000 Subject: [Buildbot-commits] [Buildbot] #518: allow complete rebuild during force In-Reply-To: <040.552f63dffbe457d99f43e8c92ff2d8f0@buildbot.net> References: <040.552f63dffbe457d99f43e8c92ff2d8f0@buildbot.net> Message-ID: <055.410c8d54328994c76b6e6c7b000f332f@buildbot.net> #518: allow complete rebuild during force ------------------------+-------------------- Reporter: ipv6guru | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: 0.7.10 | Resolution: Keywords: sprint | ------------------------+-------------------- Changes (by dustin): * keywords: => sprint Comment: This could be implemented with a property that can be set !ForceScheduler and implemented in the source steps. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Mar 5 04:29:05 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 05 Mar 2012 04:29:05 -0000 Subject: [Buildbot-commits] [Buildbot] #419: No tests for buildbot.changes.hgbuildbot.py ? In-Reply-To: <039.a0482836020bd633f2a3f0750c8f5e9c@buildbot.net> References: <039.a0482836020bd633f2a3f0750c8f5e9c@buildbot.net> Message-ID: <054.a493665279eb45bd576d6cfc77a07155@buildbot.net> #419: No tests for buildbot.changes.hgbuildbot.py ? ---------------------+---------------------- Reporter: marcusl | Owner: marcusl Type: defect | Status: new Priority: major | Milestone: 0.8.+ Version: 0.7.9 | Resolution: Keywords: hg tests | ---------------------+---------------------- Comment (by tom.prince): One particular issue with the hg/twisted interaction, is that this will try to start the reactor multiple times in a long-running hg process. It would probably be best to implement this using `buildbot sendchange` or `contrib/post_build_request.py`. #2227 would obviate the need to spawn an new process for this. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Mar 5 04:29:35 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 05 Mar 2012 04:29:35 -0000 Subject: [Buildbot-commits] [Buildbot] #531: Cache different SVN branches when switching between them. In-Reply-To: <040.fa067077286a613921ee02f6be222875@buildbot.net> References: <040.fa067077286a613921ee02f6be222875@buildbot.net> Message-ID: <055.8acb83e85bd3367c04d6e59cd749660e@buildbot.net> #531: Cache different SVN branches when switching between them. ------------------------+---------------------- Reporter: ipv6guru | Owner: Type: enhancement | Status: closed Priority: major | Milestone: 0.8.+ Version: 0.7.10 | Resolution: wontfix Keywords: svn | ------------------------+---------------------- Changes (by dustin): * status: new => closed * resolution: => wontfix Comment: I think that using `svn switch` (#97) is the better solution here. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Mar 5 04:31:18 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 05 Mar 2012 04:31:18 -0000 Subject: [Buildbot-commits] [Buildbot] #536: Show total tests run in summary page In-Reply-To: <040.f6fb432ab76b7d9e3d46dded5ff3c152@buildbot.net> References: <040.f6fb432ab76b7d9e3d46dded5ff3c152@buildbot.net> Message-ID: <055.960776f0f8fe1e7924573997994f321b@buildbot.net> #536: Show total tests run in summary page ------------------------+-------------------- Reporter: ipv6guru | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.9.+ Version: 0.7.10 | Resolution: Keywords: | ------------------------+-------------------- Changes (by dustin): * milestone: 0.8.+ => 0.9.+ Comment: I think that *getting* this information is a part of a larger, and presently rather incoherent, project to collect accurate information about test results and summarize that within and across builds. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Mar 5 04:32:43 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 05 Mar 2012 04:32:43 -0000 Subject: [Buildbot-commits] [Buildbot] #537: pause buildslaves In-Reply-To: <040.48f20d02519df66a5f2f4a17c988a2ef@buildbot.net> References: <040.48f20d02519df66a5f2f4a17c988a2ef@buildbot.net> Message-ID: <055.f12f7ecc37438e6a3a886543a4385568@buildbot.net> #537: pause buildslaves ------------------------+-------------------- Reporter: ipv6guru | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: 0.7.10 | Resolution: Keywords: sprint | ------------------------+-------------------- Changes (by dustin): * keywords: => sprint -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Mar 5 04:56:33 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 05 Mar 2012 04:56:33 -0000 Subject: [Buildbot-commits] [Buildbot] #538: web server does not use gzip encoding In-Reply-To: <040.7f2cf6f4d9dd1ba3c2c3b9d78a2b3394@buildbot.net> References: <040.7f2cf6f4d9dd1ba3c2c3b9d78a2b3394@buildbot.net> Message-ID: <055.129eded4da302d4a5b7d557cb2933391@buildbot.net> #538: web server does not use gzip encoding ------------------------+-------------------- Reporter: ipv6guru | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: 0.7.10 | Resolution: Keywords: web, sprint | ------------------------+-------------------- Changes (by dustin): * keywords: web => web, sprint Old description: > My build logs are generally > 1MB in size and I noticed that viewing > the log on the web server does not use gzip encoding. In the simple > test I did of one of my log files, it would have been a 95% savings in > size to gzip the file for transfer. > > HTTP/1.1 200 OK > Transfer-encoding: chunked > Date: Fri, 17 Jun 2005 21:38:33 GMT > Content-type: text/html > Server: TwistedWeb/2.0.1 > Submitted: > Stephen A. Davis ( soundgeek ) - 2005-06-18 05:49 > > Extra Comment :- > > twisted's web server probably has a way to make this work.. > I'll poke around. New description: My build logs are generally > 1MB in size and I noticed that viewing the log on the web server does not use gzip encoding. In the simple test I did of one of my log files, it would have been a 95% savings in size to gzip the file for transfer. {{{ HTTP/1.1 200 OK Transfer-encoding: chunked Date: Fri, 17 Jun 2005 21:38:33 GMT Content-type: text/html Server: TwistedWeb/2.0.1 }}} Submitted: Stephen A. Davis ( soundgeek ) - 2005-06-18 05:49 Extra Comment :- twisted's web server probably has a way to make this work.. I'll poke around. -- Comment: It would be great to find a way to do this with Twisted Web. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Mar 5 04:58:20 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 05 Mar 2012 04:58:20 -0000 Subject: [Buildbot-commits] [Buildbot] #2228: Allow specific ForceSchedulers to be associated with specific WebStatuses. Message-ID: <042.cdddcb9d6783b39e9977c48990d4ef8b@buildbot.net> #2228: Allow specific ForceSchedulers to be associated with specific WebStatuses. ------------------------+------------------------ Reporter: tom.prince | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.+ Version: master | Keywords: web, force ------------------------+------------------------ If different webstatus instances are available to different people, they should get different force build options. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Mar 5 04:59:18 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 05 Mar 2012 04:59:18 -0000 Subject: [Buildbot-commits] [Buildbot] #2228: Allow specific ForceSchedulers to be associated with specific WebStatuses. In-Reply-To: <042.cdddcb9d6783b39e9977c48990d4ef8b@buildbot.net> References: <042.cdddcb9d6783b39e9977c48990d4ef8b@buildbot.net> Message-ID: <057.6e69e0c9007b7a9dad9df097630f4351@buildbot.net> #2228: Allow specific ForceSchedulers to be associated with specific WebStatuses. -------------------------------+-------------------- Reporter: tom.prince | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.+ Version: master | Resolution: Keywords: web, force, sprint | -------------------------------+-------------------- Changes (by dustin): * keywords: web, force => web, force, sprint -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Mar 5 04:59:39 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 05 Mar 2012 04:59:39 -0000 Subject: [Buildbot-commits] [Buildbot] #2229: irc bot should interact with ForceSchedulers Message-ID: <042.84b5c3b1bf077da8c4506a200db8fa7a@buildbot.net> #2229: irc bot should interact with ForceSchedulers ------------------------+------------------------ Reporter: tom.prince | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.+ Version: 0.8.5 | Keywords: irc, force ------------------------+------------------------ -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Mar 5 05:00:05 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 05 Mar 2012 05:00:05 -0000 Subject: [Buildbot-commits] [Buildbot] #540: overhaul ETA calculation In-Reply-To: <040.92953aafe7562adb1b4d7d14c9032354@buildbot.net> References: <040.92953aafe7562adb1b4d7d14c9032354@buildbot.net> Message-ID: <055.aaeb962002a453cd6b5ace78a016f46e@buildbot.net> #540: overhaul ETA calculation ------------------------+----------------------- Reporter: ipv6guru | Owner: warner Type: enhancement | Status: assigned Priority: major | Milestone: 0.9.+ Version: 0.7.10 | Resolution: Keywords: | ------------------------+----------------------- Changes (by dustin): * milestone: 0.8.+ => 0.9.+ Comment: We should think about how this works in the statusdb world.. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Mar 5 05:05:09 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 05 Mar 2012 05:05:09 -0000 Subject: [Buildbot-commits] [Buildbot] #581: Automatic builder creation for new branches In-Reply-To: <041.279f3c2d7a648bd6f8a842c8d5c1c124@buildbot.net> References: <041.279f3c2d7a648bd6f8a842c8d5c1c124@buildbot.net> Message-ID: <056.c56a2efe86b7779b95648b8af55e7c87@buildbot.net> #581: Automatic builder creation for new branches ------------------------+--------------------- Reporter: mhoermann | Owner: warner Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: 0.7.10 | Resolution: Keywords: | ------------------------+--------------------- Comment (by dustin): Why do you need a new builder for each branch? -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Mar 5 05:06:02 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 05 Mar 2012 05:06:02 -0000 Subject: [Buildbot-commits] [Buildbot] #593: Flexible default logging. In-Reply-To: <036.c3e04619608372e892fa072cae93348f@buildbot.net> References: <036.c3e04619608372e892fa072cae93348f@buildbot.net> Message-ID: <051.9e89b7affb4100bd26045fcdb79c97bd@buildbot.net> #593: Flexible default logging. -------------------+-------------------- Reporter: verm | Owner: Type: defect | Status: new Priority: major | Milestone: 0.9.+ Version: 0.7.11 | Resolution: Keywords: | -------------------+-------------------- Changes (by dustin): * milestone: 0.8.+ => 0.9.+ -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Mar 5 05:07:12 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 05 Mar 2012 05:07:12 -0000 Subject: [Buildbot-commits] [Buildbot] #624: Add Latent BuildSlave for DRMAA supporting systems In-Reply-To: <041.3430041265de70991f979b41faaacc48@buildbot.net> References: <041.3430041265de70991f979b41faaacc48@buildbot.net> Message-ID: <056.c931bd80cd639165645857f6c57c814a@buildbot.net> #624: Add Latent BuildSlave for DRMAA supporting systems ---------------------------+---------------------- Reporter: smackware | Owner: Type: enhancement | Status: closed Priority: major | Milestone: 0.8.+ Version: | Resolution: wontfix Keywords: virtualization | ---------------------------+---------------------- Changes (by dustin): * status: new => closed * resolution: => wontfix Comment: No response for quite a while -- feel free to re-open if there's further work on this. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Mar 5 05:08:43 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 05 Mar 2012 05:08:43 -0000 Subject: [Buildbot-commits] [Buildbot] #631: IRC bot gives 'ValueError' when fed a singlequote In-Reply-To: <037.145e30a59c45a8b48b0e29a664e47091@buildbot.net> References: <037.145e30a59c45a8b48b0e29a664e47091@buildbot.net> Message-ID: <052.c6a46d091f8db500579047cf7bdbc16a@buildbot.net> #631: IRC bot gives 'ValueError' when fed a singlequote ------------------------+----------------------- Reporter: tycho | Owner: ddunbar Type: defect | Status: assigned Priority: major | Milestone: 0.8.+ Version: 0.7.11 | Resolution: Keywords: irc, sprint | ------------------------+----------------------- Changes (by dustin): * keywords: irc => irc, sprint Old description: > Example: > > CrawlBuild, force build crawl-debug-x86_64-centos attempt to > bomb with rvollmert's latest changes > Something bad happened (see logs): 'exceptions.ValueError'> > > Gives: > > 2009-10-22 00:45:22-0700 [IrcStatusBot,client] irc command force > 2009-10-22 00:45:22-0700 [IrcStatusBot,client] Unhandled Error > Traceback (most recent call last): > File "/usr/lib/python2.6/site- > packages/twisted/words/protocols/irc.py", line 1484, in lineReceived > self.handleCommand(command, prefix, params) > File "/usr/lib/python2.6/site- > packages/twisted/words/protocols/irc.py", line 1496, in handleCommand > method(prefix, params) > File "/usr/lib/python2.6/site- > packages/twisted/words/protocols/irc.py", line 1041, in irc_PRIVMSG > self.privmsg(user, channel, message) > File "/usr/lib/python2.6/site- > packages/buildbot/status/words.py", line 724, in privmsg > contact.handleMessage(message, user) > --- --- > File "/usr/lib/python2.6/site- > packages/buildbot/status/words.py", line 635, in handleMessage > meth(args.strip(), who) > File "/usr/lib/python2.6/site- > packages/buildbot/status/words.py", line 380, in command_FORCE > args = shlex.split(args) # TODO: this requires python2.3 or > newer > File "/usr/lib/python2.6/shlex.py", line 279, in split > return list(lex) > File "/usr/lib/python2.6/shlex.py", line 269, in next > token = self.get_token() > File "/usr/lib/python2.6/shlex.py", line 96, in get_token > raw = self.read_token() > File "/usr/lib/python2.6/shlex.py", line 172, in read_token > raise ValueError, "No closing quotation" > exceptions.ValueError: No closing quotation > > Should I be reporting this to Twisted or can you guys work around this? > > And uh, it looks to me like this is a route to a security hole if it's > not escaping the singlequote. New description: Example: {{{ CrawlBuild, force build crawl-debug-x86_64-centos attempt to bomb with rvollmert's latest changes Something bad happened (see logs): }}} Gives: {{{ 2009-10-22 00:45:22-0700 [IrcStatusBot,client] irc command force 2009-10-22 00:45:22-0700 [IrcStatusBot,client] Unhandled Error Traceback (most recent call last): File "/usr/lib/python2.6/site- packages/twisted/words/protocols/irc.py", line 1484, in lineReceived self.handleCommand(command, prefix, params) File "/usr/lib/python2.6/site- packages/twisted/words/protocols/irc.py", line 1496, in handleCommand method(prefix, params) File "/usr/lib/python2.6/site- packages/twisted/words/protocols/irc.py", line 1041, in irc_PRIVMSG self.privmsg(user, channel, message) File "/usr/lib/python2.6/site- packages/buildbot/status/words.py", line 724, in privmsg contact.handleMessage(message, user) --- --- File "/usr/lib/python2.6/site- packages/buildbot/status/words.py", line 635, in handleMessage meth(args.strip(), who) File "/usr/lib/python2.6/site- packages/buildbot/status/words.py", line 380, in command_FORCE args = shlex.split(args) # TODO: this requires python2.3 or newer File "/usr/lib/python2.6/shlex.py", line 279, in split return list(lex) File "/usr/lib/python2.6/shlex.py", line 269, in next token = self.get_token() File "/usr/lib/python2.6/shlex.py", line 96, in get_token raw = self.read_token() File "/usr/lib/python2.6/shlex.py", line 172, in read_token raise ValueError, "No closing quotation" exceptions.ValueError: No closing quotation }}} Should I be reporting this to Twisted or can you guys work around this? And uh, it looks to me like this is a route to a security hole if it's not escaping the singlequote. -- -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Mar 5 05:09:56 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 05 Mar 2012 05:09:56 -0000 Subject: [Buildbot-commits] [Buildbot] #581: Automatic builder creation for new branches In-Reply-To: <041.279f3c2d7a648bd6f8a842c8d5c1c124@buildbot.net> References: <041.279f3c2d7a648bd6f8a842c8d5c1c124@buildbot.net> Message-ID: <056.15ed50cbf9f8305ffead656b09040dcb@buildbot.net> #581: Automatic builder creation for new branches ------------------------+--------------------- Reporter: mhoermann | Owner: warner Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: 0.7.10 | Resolution: Keywords: | ------------------------+--------------------- Comment (by tom.prince): Currently, buildbot only takes into account the current and previous build on a given builder when determining whether to report a state transition between success and failure. If you want track that state per-branch, the only way right now is to have separate builders. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Mar 5 05:10:24 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 05 Mar 2012 05:10:24 -0000 Subject: [Buildbot-commits] [Buildbot] #678: Allow CVS checkout/export of multiple modules In-Reply-To: <042.f34393f2c1b8e73c7a97f44a772b281e@buildbot.net> References: <042.f34393f2c1b8e73c7a97f44a772b281e@buildbot.net> Message-ID: <057.7de8f0426b833245b54a5aa5bd492f0a@buildbot.net> #678: Allow CVS checkout/export of multiple modules -------------------------+------------------------- Reporter: satyagraha | Owner: unpaidbill Type: enhancement | Status: assigned Priority: major | Milestone: 0.8.+ Version: 0.7.11 | Resolution: Keywords: projrepo cvs | -------------------------+------------------------- Comment (by dustin): Bill, were you going to get this merged? What's the status? -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Mar 5 05:13:02 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 05 Mar 2012 05:13:02 -0000 Subject: [Buildbot-commits] [Buildbot] #716: Add parent-rev to change and use this in console In-Reply-To: <039.81698b2ccba200d5a6bf1ef015c57e28@buildbot.net> References: <039.81698b2ccba200d5a6bf1ef015c57e28@buildbot.net> Message-ID: <054.25d81f3610973b5802d5861bc0b9121a@buildbot.net> #716: Add parent-rev to change and use this in console -------------------------+-------------------- Reporter: marcusl | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.9.+ Version: master | Resolution: Keywords: git hg darcs | -------------------------+-------------------- Changes (by dustin): * milestone: 0.8.+ => 0.9.+ -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Mar 5 05:14:06 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 05 Mar 2012 05:14:06 -0000 Subject: [Buildbot-commits] [Buildbot] #765: web display for schedulers In-Reply-To: <038.66afa28eb1a2b70b4d632d38c02a7ccb@buildbot.net> References: <038.66afa28eb1a2b70b4d632d38c02a7ccb@buildbot.net> Message-ID: <053.b4740250a2c949c8b601dd64b34d54e4@buildbot.net> #765: web display for schedulers ------------------------+-------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.0 | Resolution: Keywords: web, sprint | ------------------------+-------------------- Changes (by dustin): * keywords: web => web, sprint Comment: !ForceScheduler is done; just adding this page should be straightforward. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Mar 5 05:21:37 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 05 Mar 2012 05:21:37 -0000 Subject: [Buildbot-commits] [Buildbot] #2055: buildmaster spins when build starts In-Reply-To: <038.7c5d837314c12cddc1ef74bf0334dab5@buildbot.net> References: <038.7c5d837314c12cddc1ef74bf0334dab5@buildbot.net> Message-ID: <053.b19017558e89bca265368ec4ab12920a@buildbot.net> #2055: buildmaster spins when build starts --------------------+------------------------- Reporter: mmorse | Owner: Type: defect | Status: closed Priority: major | Milestone: ongoing Version: 0.8.4p2 | Resolution: worksforme Keywords: | --------------------+------------------------- Changes (by dustin): * keywords: threadbugs => * status: new => closed * resolution: => worksforme Comment: I haven't seen more examples of this -- I'm going to close as WORKSFORME on the assumption that Lion or one of the Snow Leopard updates fixed this. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Mar 5 05:22:37 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 05 Mar 2012 05:22:37 -0000 Subject: [Buildbot-commits] [Buildbot] #789: Source stamp filtering, sorting, and clustering in web views In-Reply-To: <039.e54bab987922e2f005f08fb8c265248d@buildbot.net> References: <039.e54bab987922e2f005f08fb8c265248d@buildbot.net> Message-ID: <054.32f14c0e97f596aedf9aa7122c3193f0@buildbot.net> #789: Source stamp filtering, sorting, and clustering in web views ---------------------+-------------------- Reporter: marcusl | Owner: Type: task | Status: new Priority: critical | Milestone: 0.9.+ Version: 0.8.0 | Resolution: Keywords: web | ---------------------+-------------------- Changes (by dustin): * keywords: web, ship-this => web -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Mar 5 05:22:50 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 05 Mar 2012 05:22:50 -0000 Subject: [Buildbot-commits] [Buildbot] #24: save build status in an SQL database In-Reply-To: <038.79520b4a8accd5cb1f26c635b721c8f8@buildbot.net> References: <038.79520b4a8accd5cb1f26c635b721c8f8@buildbot.net> Message-ID: <053.1bf19d01b5f6a171ca9a86fa40f70fb7@buildbot.net> #24: save build status in an SQL database ------------------------+----------------------- Reporter: warner | Owner: warner Type: enhancement | Status: assigned Priority: minor | Milestone: 0.9.0 Version: | Resolution: Keywords: database | ------------------------+----------------------- Changes (by dustin): * keywords: database ship-this => database -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Mar 5 05:23:19 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 05 Mar 2012 05:23:19 -0000 Subject: [Buildbot-commits] [Buildbot] #1728: Git: add support for setting additional information via Git notes In-Reply-To: <043.8b1d4a52e38fd8f9864e8e19f915c616@buildbot.net> References: <043.8b1d4a52e38fd8f9864e8e19f915c616@buildbot.net> Message-ID: <058.ac1022a6eca65a7b68929974473aec3c@buildbot.net> #1728: Git: add support for setting additional information via Git notes ------------------------+-------------------- Reporter: PiotrSikora | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.2 | Resolution: Keywords: git, gerrit | ------------------------+-------------------- Changes (by dustin): * keywords: git, gerrit ship-this => git, gerrit -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Mar 5 05:23:28 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 05 Mar 2012 05:23:28 -0000 Subject: [Buildbot-commits] [Buildbot] #875: enhance ways of coordinating builds - flocks? In-Reply-To: <040.f883260b3ed2f19b8eb335e5a36698bd@buildbot.net> References: <040.f883260b3ed2f19b8eb335e5a36698bd@buildbot.net> Message-ID: <055.4afdd67d8459af0ef1472b0bfe223c25@buildbot.net> #875: enhance ways of coordinating builds - flocks? -----------------------+----------------------- Reporter: bhearsum | Owner: djmitche Type: undecided | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.0 | Resolution: Keywords: buildcoord | -----------------------+----------------------- Changes (by dustin): * keywords: buildcoord ship-this => buildcoord -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Mar 5 05:35:23 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 05 Mar 2012 05:35:23 -0000 Subject: [Buildbot-commits] [Buildbot] #802: Early Timeouts In-Reply-To: <036.58329d64961ba69fb33add0c59d81bae@buildbot.net> References: <036.58329d64961ba69fb33add0c59d81bae@buildbot.net> Message-ID: <051.0c79d27cc8c716adfd78bfd706a9581f@buildbot.net> #802: Early Timeouts -------------------+------------------------- Reporter: axel | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.+ Version: 0.7.12 | Resolution: worksforme Keywords: | -------------------+------------------------- Changes (by dustin): * status: new => closed * resolution: => worksforme -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Mar 5 05:35:58 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 05 Mar 2012 05:35:58 -0000 Subject: [Buildbot-commits] [Buildbot] #806: Need branch name display In-Reply-To: <041.0b6e5b0e15b3da9bf4fde730b1cd2597@buildbot.net> References: <041.0b6e5b0e15b3da9bf4fde730b1cd2597@buildbot.net> Message-ID: <056.c11c94dc9a073c7d404c89b4d2217563@buildbot.net> #806: Need branch name display ------------------------+-------------------- Reporter: dabrahams | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: 0.7.12 | Resolution: Keywords: web, sprint | ------------------------+-------------------- Changes (by dustin): * keywords: web => web, sprint -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Mar 5 05:36:26 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 05 Mar 2012 05:36:26 -0000 Subject: [Buildbot-commits] [Buildbot] #807: "Brokenness display" In-Reply-To: <041.72fa4fecbf8eb95c09c8780487dc1c37@buildbot.net> References: <041.72fa4fecbf8eb95c09c8780487dc1c37@buildbot.net> Message-ID: <056.e37eccfe4cd35b5953d9e3eec205dea3@buildbot.net> #807: "Brokenness display" ------------------------+-------------------- Reporter: dabrahams | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.9.+ Version: 0.7.12 | Resolution: Keywords: web | ------------------------+-------------------- Changes (by dustin): * milestone: 0.8.+ => 0.9.+ -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Mar 5 05:37:58 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 05 Mar 2012 05:37:58 -0000 Subject: [Buildbot-commits] [Buildbot] #2164: Triggering a Nightly Build only if Continuous build status is success In-Reply-To: <044.65ab04c023d7d9934e6fa7d4bf38f193@buildbot.net> References: <044.65ab04c023d7d9934e6fa7d4bf38f193@buildbot.net> Message-ID: <059.f0ef4903d5d86ce5e575e61d766e4134@buildbot.net> #2164: Triggering a Nightly Build only if Continuous build status is success ----------------------------+--------------------- Reporter: mariamarcano | Owner: Type: support-request | Status: closed Priority: major | Milestone: Version: 0.8.3p1 | Resolution: fixed Keywords: | ----------------------------+--------------------- Changes (by dustin): * status: new => closed * resolution: => fixed Comment: Please re-open with any further questions. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Mar 5 05:39:00 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 05 Mar 2012 05:39:00 -0000 Subject: [Buildbot-commits] [Buildbot] #1799: Fix pipe symbol with ^ workaround In-Reply-To: <036.70f4fc784899f73c738eab2f8aaa9bdc@buildbot.net> References: <036.70f4fc784899f73c738eab2f8aaa9bdc@buildbot.net> Message-ID: <051.7e209222e1b49b98abcec53d8f9f48cb@buildbot.net> #1799: Fix pipe symbol with ^ workaround ----------------------------+-------------------- Reporter: todd | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.3p1 | Resolution: Keywords: windows, sprint | ----------------------------+-------------------- Changes (by dustin): * keywords: windows => windows, sprint * milestone: => 0.8.+ -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Mar 5 05:40:08 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 05 Mar 2012 05:40:08 -0000 Subject: [Buildbot-commits] [Buildbot] #1990: Source steps falling back to complete re-initialization should not be mandatory In-Reply-To: <037.a8ad1401ad7ff566359b5a60a33f9e3e@buildbot.net> References: <037.a8ad1401ad7ff566359b5a60a33f9e3e@buildbot.net> Message-ID: <052.5c2032e7791cf5be11bea034212ab703@buildbot.net> #1990: Source steps falling back to complete re-initialization should not be mandatory -------------------------------------+-------------------- Reporter: ayust | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.4 | Resolution: Keywords: master-side-source-steps | -------------------------------------+-------------------- Changes (by dustin): * keywords: => master-side-source-steps * milestone: undecided => 0.8.+ -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Mar 5 05:40:35 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 05 Mar 2012 05:40:35 -0000 Subject: [Buildbot-commits] [Buildbot] #2186: github change_hook needs security by default In-Reply-To: <040.b0011a230d9ec9a00c8a78bbb647063d@buildbot.net> References: <040.b0011a230d9ec9a00c8a78bbb647063d@buildbot.net> Message-ID: <055.dba5818ec850a015807a167c203dd469@buildbot.net> #2186: github change_hook needs security by default ------------------------------+-------------------- Reporter: stefanha | Owner: Type: enhancement | Status: new Priority: critical | Milestone: 0.8.7 Version: 0.8.5 | Resolution: Keywords: github web sprint | ------------------------------+-------------------- Changes (by dustin): * keywords: github,web => github web sprint * priority: major => critical * milestone: undecided => 0.8.7 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Mar 5 05:41:27 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 05 Mar 2012 05:41:27 -0000 Subject: [Buildbot-commits] [Buildbot] #2192: GerritChangeSource: event filter In-Reply-To: <039.932060cedd125e5e24c932433e1fe070@buildbot.net> References: <039.932060cedd125e5e24c932433e1fe070@buildbot.net> Message-ID: <054.eee0130f7c49cc3e8d6bf076c7a75892@buildbot.net> #2192: GerritChangeSource: event filter ------------------------+------------------------- Reporter: sanxiyn | Owner: Type: enhancement | Status: closed Priority: major | Milestone: undecided Version: 0.8.5 | Resolution: worksforme Keywords: gerrit | ------------------------+------------------------- Changes (by dustin): * status: new => closed * resolution: => worksforme Comment: This bug remains here for reference for others, but it doesn't look like something we'd merge as-is, per tom's comments. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Mar 5 05:42:36 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 05 Mar 2012 05:42:36 -0000 Subject: [Buildbot-commits] [Buildbot] #2180: Allow for "git describe" in addition to got_revision In-Reply-To: <042.f0bb38d6a7f6d5b4159cc3a8bf6a0f8c@buildbot.net> References: <042.f0bb38d6a7f6d5b4159cc3a8bf6a0f8c@buildbot.net> Message-ID: <057.41924b0ae03b9396738aa0da5ff888e6@buildbot.net> #2180: Allow for "git describe" in addition to got_revision ----------------------------+------------------------ Reporter: jaredgrubb | Owner: Type: enhancement | Status: closed Priority: minor | Milestone: undecided Version: 0.8.5 | Resolution: wontfix Keywords: git, buildslave | ----------------------------+------------------------ Changes (by dustin): * status: new => closed * resolution: => wontfix Comment: I think that this would be best handled with a separate shellcommand. With multirepo support, it's not clear where such a value would go (in fact, `got_revision` has caused some consternation, too). -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Mar 5 05:42:52 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 05 Mar 2012 05:42:52 -0000 Subject: [Buildbot-commits] [Buildbot] #2179: Test Suite fails to detect missing 'yield wfd; res = wfd.getResult()' in build step tests. In-Reply-To: <042.a4a888721a06040f079b4ceb4aa1e771@buildbot.net> References: <042.a4a888721a06040f079b4ceb4aa1e771@buildbot.net> Message-ID: <057.48c161af8c1aaefd256bf5968af70d9e@buildbot.net> #2179: Test Suite fails to detect missing 'yield wfd; res = wfd.getResult()' in build step tests. -----------------------+------------------------ Reporter: tom.prince | Owner: Type: defect | Status: closed Priority: minor | Milestone: undecided Version: master | Resolution: wontfix Keywords: | -----------------------+------------------------ Changes (by dustin): * status: new => closed * resolution: => wontfix Comment: Now that we can use `inlineCallbacks`, this isn't a problem. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Mar 5 05:56:32 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 05 Mar 2012 05:56:32 -0000 Subject: [Buildbot-commits] [Buildbot] #2186: github change_hook needs security by default In-Reply-To: <040.b0011a230d9ec9a00c8a78bbb647063d@buildbot.net> References: <040.b0011a230d9ec9a00c8a78bbb647063d@buildbot.net> Message-ID: <055.2c612789e176561bf73d63201803ccdd@buildbot.net> #2186: github change_hook needs security by default ------------------------------+-------------------- Reporter: stefanha | Owner: Type: enhancement | Status: new Priority: critical | Milestone: 0.8.7 Version: 0.8.5 | Resolution: Keywords: github web sprint | ------------------------------+-------------------- Comment (by tom.prince): I wonder if github hooks support HTTP basic auth? If they do, specifying a user/passwd in the url, and supporting it in buildbot is all that is required. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Mar 5 14:27:24 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 05 Mar 2012 14:27:24 -0000 Subject: [Buildbot-commits] [Buildbot] #1854: FileUpload never times out In-Reply-To: <039.e7bfab756d445121a2e0b7af56f23535@buildbot.net> References: <039.e7bfab756d445121a2e0b7af56f23535@buildbot.net> Message-ID: <054.b58aa71a664cacef1783c4e7bdef65c8@buildbot.net> #1854: FileUpload never times out -----------------------------+-------------------- Reporter: exarkun | Owner: Type: defect | Status: new Priority: critical | Milestone: 0.8.+ Version: 0.8.2 | Resolution: Keywords: transfer, sprint | -----------------------------+-------------------- Comment (by exarkun): A document covering good testing practices, in particular testing of code involving protocols and timing, has recently been added to the Twisted documentation: http://twistedmatrix.com/documents/current/core/howto/trial.html#auto4 It may be helpful in developing good unit tests for this functionality. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Mar 5 16:02:06 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 05 Mar 2012 16:02:06 -0000 Subject: [Buildbot-commits] [Buildbot] #97: Use svn switch to improve efficiency In-Reply-To: <041.fdcc077787c8f6a36b12df6a065f70a9@buildbot.net> References: <041.fdcc077787c8f6a36b12df6a065f70a9@buildbot.net> Message-ID: <056.1afeaecf353e512267fab048c6185f63@buildbot.net> #97: Use svn switch to improve efficiency ------------------------+----------------------- Reporter: retracile | Owner: Type: enhancement | Status: reopened Priority: major | Milestone: 0.8.+ Version: 0.8.3 | Resolution: Keywords: svn, sprint | ------------------------+----------------------- Comment (by duncanphilipnorman): Replying to [comment:8 dustin]: > duncanphilipnorman - any update on this bug? > > For someone interested in subversion support, perhaps this could be finished up during the !PyCon sprints? No progress, as my job has kept me too busy. I can confirm that the patch works well against 0.8.3, as we've been using it live since I posted it here. If anyone else has interest in porting it to 0.8.5, I strongly encourage it! If I do find time to start working on this, I'll comment here first so that we're not duplicating effort. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Mon Mar 5 18:42:55 2012 From: noreply at github.com (GitHub) Date: Mon, 05 Mar 2012 10:42:55 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] Message-ID: <4f55092f6c2bc_1cbd1d3eaf421365b@sh2.rs.github.com.mail> Branch: refs/tags/v0.8.6rc1 Home: https://github.com/buildbot/buildbot From nobody at buildbot.net Mon Mar 5 19:58:23 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 05 Mar 2012 19:58:23 -0000 Subject: [Buildbot-commits] [Buildbot] #2180: Allow for "git describe" in addition to got_revision In-Reply-To: <042.f0bb38d6a7f6d5b4159cc3a8bf6a0f8c@buildbot.net> References: <042.f0bb38d6a7f6d5b4159cc3a8bf6a0f8c@buildbot.net> Message-ID: <057.47c4fc2afee1e5e60e0a35deb1832e80@buildbot.net> #2180: Allow for "git describe" in addition to got_revision ----------------------------+------------------------ Reporter: jaredgrubb | Owner: Type: enhancement | Status: closed Priority: minor | Milestone: undecided Version: 0.8.5 | Resolution: wontfix Keywords: git, buildslave | ----------------------------+------------------------ Comment (by jaredgrubb): So I suppose a "got_description" added into the sourcestamp would be not workable? One alternative is that got_revision could be filled with the description instead of the revision based on some boolean option (along with something to get the right revision out for a subsequent rebuild). Locally I've been just adding it as a property named "got_descirption{%s}"%project. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Mar 5 19:58:47 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 05 Mar 2012 19:58:47 -0000 Subject: [Buildbot-commits] [Buildbot] #2230: _ComputeRepositoryURL is broken with respect to multi-repo changes. Message-ID: <042.61cf3e79d7e33ef2c3cb111ef1abf29d@buildbot.net> #2230: _ComputeRepositoryURL is broken with respect to multi-repo changes. -----------------------+------------------------ Reporter: tom.prince | Owner: tom.prince Type: defect | Status: new Priority: major | Milestone: 0.8.7 Version: master | Keywords: -----------------------+------------------------ _ComputeRepositoryURL needs the codebase passed in from the source step. The easiest way to get this is to pass in the codebase in the constructor. Since this involves moving the constructor upcall, fixing this creates a merge conflict with the [step-factor changes](https://github.com/tomprince/buildbot/compare/buildbot:master ...magic-__new__). I will fix this, once that branch is merged. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Mar 5 19:59:29 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 05 Mar 2012 19:59:29 -0000 Subject: [Buildbot-commits] [Buildbot] #2180: Allow for "git describe" in addition to got_revision In-Reply-To: <042.f0bb38d6a7f6d5b4159cc3a8bf6a0f8c@buildbot.net> References: <042.f0bb38d6a7f6d5b4159cc3a8bf6a0f8c@buildbot.net> Message-ID: <057.a64b9a9b6a2a3eed779a79610aafa96f@buildbot.net> #2180: Allow for "git describe" in addition to got_revision ----------------------------+------------------------ Reporter: jaredgrubb | Owner: Type: enhancement | Status: closed Priority: minor | Milestone: undecided Version: 0.8.5 | Resolution: wontfix Keywords: git, buildslave | ----------------------------+------------------------ Comment (by dustin): I don't want to add additional fields to sourcestamps. I think a property is the right approach, and you're close - probably including the codebase in the property name is the right approach. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Mar 5 20:08:00 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 05 Mar 2012 20:08:00 -0000 Subject: [Buildbot-commits] [Buildbot] #2180: Allow for "git describe" in addition to got_revision In-Reply-To: <042.f0bb38d6a7f6d5b4159cc3a8bf6a0f8c@buildbot.net> References: <042.f0bb38d6a7f6d5b4159cc3a8bf6a0f8c@buildbot.net> Message-ID: <057.9cdbff362df3698afb9d1d32233d254a@buildbot.net> #2180: Allow for "git describe" in addition to got_revision ----------------------------+------------------------ Reporter: jaredgrubb | Owner: Type: enhancement | Status: closed Priority: minor | Milestone: undecided Version: 0.8.5 | Resolution: wontfix Keywords: git, buildslave | ----------------------------+------------------------ Comment (by tom.prince): Or having the property be a dictionary, rather than a string, would also work. Although, at this point we don't have any tools for working with such things easily. On the other hand, it would be nice if buildbot where more aware of the history of repositories, and this would be reasonable information to know. (Except of course that there are many possible option you might want to pass to 'git describe'). Do other version control systems have something similliar? -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Mar 5 23:23:18 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 05 Mar 2012 23:23:18 -0000 Subject: [Buildbot-commits] [Buildbot] #2180: Allow for "git describe" in addition to got_revision In-Reply-To: <042.f0bb38d6a7f6d5b4159cc3a8bf6a0f8c@buildbot.net> References: <042.f0bb38d6a7f6d5b4159cc3a8bf6a0f8c@buildbot.net> Message-ID: <057.182b8d65c281c9d0e50aababddc3a275@buildbot.net> #2180: Allow for "git describe" in addition to got_revision ----------------------------+------------------------ Reporter: jaredgrubb | Owner: Type: enhancement | Status: closed Priority: minor | Milestone: undecided Version: 0.8.5 | Resolution: wontfix Keywords: git, buildslave | ----------------------------+------------------------ Comment (by jaredgrubb): Yeh, I didnt consider it, but "git describe" does have args you might want to alter (eg, --abbrev and --tags come to mind). So, maybe this really is a separate Step class and not built into the Git class. It looks like you can make hg do something similar (http://mercurial.selenic.com/wiki/GitConcepts). -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Mar 5 23:25:13 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 05 Mar 2012 23:25:13 -0000 Subject: [Buildbot-commits] [Buildbot] #2231: ForceScheduler should validate its paramter types Message-ID: <042.7fdaee2d8bd1034781abc75a27aca83c@buildbot.net> #2231: ForceScheduler should validate its paramter types ------------------------+----------------------- Reporter: jaredgrubb | Owner: Type: enhancement | Status: new Priority: major | Milestone: undecided Version: 0.8.6 | Keywords: ------------------------+----------------------- In my ignorance, I did the following: ForceScheduler(..., reason="foo", ...) But when I went to the builder on the waterfall, I got a very cryptic exception. Turns out that reason needs to be one of the field parameter types, like StringParameter. This makes sense now, but it would be nice if ForceScheduler could do some verification to catch this early. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Tue Mar 6 18:13:40 2012 From: nobody at buildbot.net (Buildbot) Date: Tue, 06 Mar 2012 18:13:40 -0000 Subject: [Buildbot-commits] [Buildbot] #2045: Implicit limit of 1000 builders per slave In-Reply-To: <035.55d811d1be045ddf3ef52ca4764c3b95@buildbot.net> References: <035.55d811d1be045ddf3ef52ca4764c3b95@buildbot.net> Message-ID: <050.bffee9f169811ae1314c8a151242c145@buildbot.net> #2045: Implicit limit of 1000 builders per slave ------------------------+-------------------- Reporter: xrg | Owner: Type: defect | Status: new Priority: minor | Milestone: 0.8.+ Version: 0.8.4 | Resolution: Keywords: performance | ------------------------+-------------------- Changes (by peterschueller): * cc: schueller.p@? (added) Comment: ah finally I know why suddenly a part of my builders can no longer attach! :( Thanks for the quickfix, however it is important to note that this has to be done BOTH in master and slave (quite obvious but I first failed at that nevertheless) Another issue is the 10 second timeout for "buildbot restart" or "buildbot reconfig" commands. I have huge amounts of builders, so this always times out which is kind of uncomfortable. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Thu Mar 8 16:25:32 2012 From: nobody at buildbot.net (Buildbot) Date: Thu, 08 Mar 2012 16:25:32 -0000 Subject: [Buildbot-commits] [Buildbot] #2232: ForceScheduler should repopulate on error Message-ID: <042.8776053bf275446880cebe62970da16a@buildbot.net> #2232: ForceScheduler should repopulate on error -----------------------+----------------------- Reporter: jaredgrubb | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.6 | Keywords: -----------------------+----------------------- Here is my setup: * ForceScheduler(..., properties=[StringParameter(default="foo",..)]) I submitted a build via the web, but neglected to fill in my name. Buildbot complained (Your name:: please fill in email address in the form User ) and showed the form again, but the property was reset to the default value. It would be nice if the form was filled back out as the user submitted it. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Mar 9 00:27:05 2012 From: nobody at buildbot.net (Buildbot) Date: Fri, 09 Mar 2012 00:27:05 -0000 Subject: [Buildbot-commits] [Buildbot] #2233: gitpoller should detect when it needs to reinitialize its state. Message-ID: <042.a98c26c43c4f6fac9b2583beee812904@buildbot.net> #2233: gitpoller should detect when it needs to reinitialize its state. -----------------------+---------------------------- Reporter: tom.prince | Owner: Type: defect | Status: new Priority: minor | Milestone: undecided Version: 0.8.5 | Keywords: git, gitpoller -----------------------+---------------------------- GitPoller currently asumes that if its directory exists (and is a git repo?) that the repo is initialized properly for how it is configured. It should be smart enough to recover from config/state mismatches. Either by detecting a mismatch, or always initializing in an idempotent maner. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Fri Mar 9 07:59:12 2012 From: noreply at github.com (GitHub) Date: Thu, 08 Mar 2012 23:59:12 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] 4038a9: teach fakedb.changes.addChange about codebase Message-ID: <4f59b8501cc64_55f1aabae41884e3@sh2.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 4038a94d1eefb15de6186fdc4a6432e60c8feb29 https://github.com/buildbot/buildbot/commit/4038a94d1eefb15de6186fdc4a6432e60c8feb29 Author: Dustin J. Mitchell Date: 2012-03-08 (Thu, 08 Mar 2012) Changed paths: M master/buildbot/test/fake/fakedb.py Log Message: ----------- teach fakedb.changes.addChange about codebase Commit: 9b925d1ce91b7ae2e9f879e1746680163d20e9fd https://github.com/buildbot/buildbot/commit/9b925d1ce91b7ae2e9f879e1746680163d20e9fd Author: Dustin J. Mitchell Date: 2012-03-08 (Thu, 08 Mar 2012) Changed paths: A common/validate.sh Log Message: ----------- add my validation script so others can use it, too Commit: f84ebdc70dddb261d4e915e96c14ecd1b5d6dccc https://github.com/buildbot/buildbot/commit/f84ebdc70dddb261d4e915e96c14ecd1b5d6dccc Author: Dustin J. Mitchell Date: 2012-03-08 (Thu, 08 Mar 2012) Changed paths: M master/buildbot/test/unit/test_process_builder.py Log Message: ----------- remove a bogus test that's not running anyway This test is bogus because it is asserting that requests can't be merged if they don't have the same codebases. This is not the case, though - merge functions are allowed to do whatever they want to do. This test wasn't being run because it's a generator but wasn't decorated with defer.deferredGenerator. Commit: b8f1c46bc0ce76134438c85e9b1b73f4ca92c580 https://github.com/buildbot/buildbot/commit/b8f1c46bc0ce76134438c85e9b1b73f4ca92c580 Author: Dustin J. Mitchell Date: 2012-03-08 (Thu, 08 Mar 2012) Changed paths: M master/buildbot/config.py M master/docs/manual/cfg-intro.rst Log Message: ----------- improve docs on error messages Compare: https://github.com/buildbot/buildbot/compare/6da63a0...b8f1c46 From noreply at github.com Fri Mar 9 08:16:10 2012 From: noreply at github.com (GitHub) Date: Fri, 09 Mar 2012 00:16:10 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] 2452bd: fix links in style.rst Message-ID: <4f59bc4a708e9_570e3f83b264daf014575@sh1.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 2452bd7a657c603957dddc3e8d3f3a586e0d3c77 https://github.com/buildbot/buildbot/commit/2452bd7a657c603957dddc3e8d3f3a586e0d3c77 Author: Dustin J. Mitchell Date: 2012-03-09 (Fri, 09 Mar 2012) Changed paths: M master/docs/developer/style.rst Log Message: ----------- fix links in style.rst From noreply at github.com Sat Mar 10 01:21:37 2012 From: noreply at github.com (GitHub) Date: Fri, 09 Mar 2012 17:21:37 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] c23f85: fix formatting in release notes Message-ID: <4f5aaca16430e_64c410c7af01469a4@sh2.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: c23f851a8e52dbba0a4ce85cdb5cfca9d14d453e https://github.com/buildbot/buildbot/commit/c23f851a8e52dbba0a4ce85cdb5cfca9d14d453e Author: Dustin J. Mitchell Date: 2012-03-09 (Fri, 09 Mar 2012) Changed paths: M master/docs/release-notes.rst Log Message: ----------- fix formatting in release notes From noreply at github.com Sat Mar 10 03:32:21 2012 From: noreply at github.com (GitHub) Date: Fri, 09 Mar 2012 19:32:21 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] afddbf: Require Python-2.5 and Twisted-9.0.0 on master. Message-ID: <4f5acb45ca473_f6c3fad78f132f8488e2@sh1.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: afddbfa2ef1ddc259bf01d5a01d1b90b694cd665 https://github.com/buildbot/buildbot/commit/afddbfa2ef1ddc259bf01d5a01d1b90b694cd665 Author: Dustin J. Mitchell Date: 2012-03-09 (Fri, 09 Mar 2012) Changed paths: M master/docs/manual/installation.rst M master/docs/release-notes.rst M master/setup.py Log Message: ----------- Require Python-2.5 and Twisted-9.0.0 on master. Refs #2182. Refs #2157. Commit: 99a0d88e73018065e5af0a440e83ca95075d4161 https://github.com/buildbot/buildbot/commit/99a0d88e73018065e5af0a440e83ca95075d4161 Author: Dustin J. Mitchell Date: 2012-03-09 (Fri, 09 Mar 2012) Changed paths: M master/buildbot/buildslave.py M master/buildbot/changes/bonsaipoller.py M master/buildbot/changes/gerritchangesource.py M master/buildbot/changes/gitpoller.py M master/buildbot/changes/manager.py M master/buildbot/changes/p4poller.py M master/buildbot/changes/pb.py M master/buildbot/changes/svnpoller.py M master/buildbot/config.py M master/buildbot/db/sourcestamps.py M master/buildbot/master.py M master/buildbot/process/botmaster.py M master/buildbot/process/builder.py M master/buildbot/process/debug.py M master/buildbot/process/users/manager.py M master/buildbot/process/users/manual.py M master/buildbot/process/users/users.py M master/buildbot/schedulers/basic.py M master/buildbot/schedulers/dependent.py M master/buildbot/schedulers/manager.py M master/buildbot/schedulers/timed.py M master/buildbot/schedulers/trysched.py M master/buildbot/scripts/runner.py M master/buildbot/status/buildrequest.py M master/buildbot/status/master.py M master/buildbot/status/status_push.py M master/buildbot/status/web/build.py M master/buildbot/status/web/builder.py M master/buildbot/status/web/change_hook.py M master/buildbot/status/web/console.py M master/buildbot/status/web/grid.py M master/buildbot/status/web/root.py M master/buildbot/status/web/slaves.py M master/buildbot/status/web/status_json.py M master/buildbot/status/web/users.py M master/buildbot/steps/source/bzr.py M master/buildbot/steps/source/cvs.py M master/buildbot/steps/source/git.py M master/buildbot/steps/source/mercurial.py M master/buildbot/steps/source/svn.py M master/buildbot/test/fake/remotecommand.py M master/buildbot/test/fuzz/test_lru.py M master/buildbot/test/integration/test_slave_comm.py M master/buildbot/test/integration/test_upgrade.py M master/buildbot/test/unit/test_buildslave.py M master/buildbot/test/unit/test_changes_pb.py M master/buildbot/test/unit/test_config.py M master/buildbot/test/unit/test_db_base.py M master/buildbot/test/unit/test_db_connector.py M master/buildbot/test/unit/test_db_pool.py M master/buildbot/test/unit/test_master.py M master/buildbot/test/unit/test_process_botmaster_BotMaster.py M master/buildbot/test/unit/test_process_builder.py M master/buildbot/test/unit/test_process_debug.py M master/buildbot/test/unit/test_process_users_manager.py M master/buildbot/test/unit/test_schedulers_basic.py M master/buildbot/test/unit/test_schedulers_dependent.py M master/buildbot/test/unit/test_schedulers_manager.py M master/buildbot/test/unit/test_schedulers_timed_Nightly.py M master/buildbot/test/unit/test_status_master.py M master/buildbot/test/unit/test_steps_shell.py M master/buildbot/test/unit/test_util_lru.py M master/buildbot/util/maildir.py M master/docs/developer/style.rst M master/docs/developer/webstatus.rst Log Message: ----------- change deferredGenerator to inlineCallbacks globally This removes *most* references to deferredGenerator/waitForDeferred, except those in master/buildbot/schedulers/base.py and master/buildbot/process/buildrequest.py, to avoid conflicts with a pending patch. Once that patch lands, we will need to make an additional sweep through the codebase. Refs #2157. Compare: https://github.com/buildbot/buildbot/compare/c23f851...99a0d88 From nobody at buildbot.net Sat Mar 10 03:32:28 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 10 Mar 2012 03:32:28 -0000 Subject: [Buildbot-commits] [Buildbot] #2157: drop support for Python-2.4 In-Reply-To: <038.ef994c5ec15e437a654d0b735959adeb@buildbot.net> References: <038.ef994c5ec15e437a654d0b735959adeb@buildbot.net> Message-ID: <053.b2187c14452e545a7826c36bcf848019@buildbot.net> #2157: drop support for Python-2.4 ------------------------+--------------------- Reporter: dustin | Owner: dustin Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: master | Resolution: Keywords: | ------------------------+--------------------- Comment (by Dustin J. Mitchell): change deferredGenerator to inlineCallbacks globally This removes *most* references to deferredGenerator/waitForDeferred, except those in master/buildbot/schedulers/base.py and master/buildbot/process/buildrequest.py, to avoid conflicts with a pending patch. Once that patch lands, we will need to make an additional sweep through the codebase. Refs #2157. Changeset: 99a0d88e73018065e5af0a440e83ca95075d4161 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 10 03:32:27 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 10 Mar 2012 03:32:27 -0000 Subject: [Buildbot-commits] [Buildbot] #2182: deprecate compatibility with Twisted-8.x.x after 0.8.6 In-Reply-To: <038.223490c7b83417680ae2cbf57b74b762@buildbot.net> References: <038.223490c7b83417680ae2cbf57b74b762@buildbot.net> Message-ID: <053.c5b5f40d1d49bd54f498cd41b4ab3708@buildbot.net> #2182: deprecate compatibility with Twisted-8.x.x after 0.8.6 ------------------------+-------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.5 | Resolution: Keywords: | ------------------------+-------------------- Comment (by Dustin J. Mitchell): Require Python-2.5 and Twisted-9.0.0 on master. Refs #2182. Refs #2157. Changeset: afddbfa2ef1ddc259bf01d5a01d1b90b694cd665 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 10 03:32:28 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 10 Mar 2012 03:32:28 -0000 Subject: [Buildbot-commits] [Buildbot] #2157: drop support for Python-2.4 In-Reply-To: <038.ef994c5ec15e437a654d0b735959adeb@buildbot.net> References: <038.ef994c5ec15e437a654d0b735959adeb@buildbot.net> Message-ID: <053.48a876bc2e2cccd944cde52210402138@buildbot.net> #2157: drop support for Python-2.4 ------------------------+--------------------- Reporter: dustin | Owner: dustin Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: master | Resolution: Keywords: | ------------------------+--------------------- Comment (by Dustin J. Mitchell): Require Python-2.5 and Twisted-9.0.0 on master. Refs #2182. Refs #2157. Changeset: afddbfa2ef1ddc259bf01d5a01d1b90b694cd665 -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sat Mar 10 05:48:04 2012 From: noreply at github.com (GitHub) Date: Fri, 09 Mar 2012 21:48:04 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] 785617: Apply fix for Twisted bug 4520 Message-ID: <4f5aeb14bae8c_ebaf75ae45051b@sh2.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 785617fa993b822b2a6710f3d0c1e69973920040 https://github.com/buildbot/buildbot/commit/785617fa993b822b2a6710f3d0c1e69973920040 Author: Dustin J. Mitchell Date: 2012-03-09 (Fri, 09 Mar 2012) Changed paths: M master/buildbot/monkeypatches/__init__.py A master/buildbot/monkeypatches/bug4520.py Log Message: ----------- Apply fix for Twisted bug 4520 Only on affected platforms. From noreply at github.com Sat Mar 10 06:25:30 2012 From: noreply at github.com (GitHub) Date: Fri, 09 Mar 2012 22:25:30 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] 2f7402: Merge branch 'fix_sourcestampsetid_rebased' of git... Message-ID: <4f5af3dad7d0b_b68d5aae82436fe@sh2.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 2f7402b8cabfc7682656e1c585522c697e03755a https://github.com/buildbot/buildbot/commit/2f7402b8cabfc7682656e1c585522c697e03755a Author: Dustin J. Mitchell Date: 2012-03-09 (Fri, 09 Mar 2012) Changed paths: M master/buildbot/schedulers/triggerable.py M master/buildbot/sourcestamp.py M master/buildbot/steps/trigger.py M master/buildbot/test/unit/test_schedulers_triggerable.py M master/buildbot/test/unit/test_steps_trigger.py Log Message: ----------- Merge branch 'fix_sourcestampsetid_rebased' of git://github.com/hborkhuis/buildbot into buildbot-0.8.6 * 'fix_sourcestampsetid_rebased' of git://github.com/hborkhuis/buildbot: parameter renamed Test with new interface between Trigger and Triggerable getSourceStampSetId always returns the setid A new setid is created if a sourcestamps is added to the database. Trigger gets sourcestampsetid from triggerable. Commit: 13a3833f88b5fd3fc48b5c5208ffbe1ad2d13e86 https://github.com/buildbot/buildbot/commit/13a3833f88b5fd3fc48b5c5208ffbe1ad2d13e86 Author: Dustin J. Mitchell Date: 2012-03-09 (Fri, 09 Mar 2012) Changed paths: M master/buildbot/schedulers/triggerable.py M master/buildbot/sourcestamp.py M master/buildbot/steps/trigger.py M master/buildbot/test/unit/test_schedulers_triggerable.py M master/buildbot/test/unit/test_steps_trigger.py Log Message: ----------- Merge branch 'buildbot-0.8.6' * buildbot-0.8.6: parameter renamed Test with new interface between Trigger and Triggerable getSourceStampSetId always returns the setid A new setid is created if a sourcestamps is added to the database. Trigger gets sourcestampsetid from triggerable. Compare: https://github.com/buildbot/buildbot/compare/785617f...13a3833 From noreply at github.com Sat Mar 10 06:25:29 2012 From: noreply at github.com (GitHub) Date: Fri, 09 Mar 2012 22:25:29 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] 463175: A new setid is created if a sourcestamps is added ... Message-ID: <4f5af3d99b411_f6c3fad78f132f859057@sh1.rs.github.com.mail> Branch: refs/heads/buildbot-0.8.6 Home: https://github.com/buildbot/buildbot Commit: 463175fecba4d7876d6ec21f868a9bf3f1202d1f https://github.com/buildbot/buildbot/commit/463175fecba4d7876d6ec21f868a9bf3f1202d1f Author: Harry Borkhuis Date: 2012-03-07 (Wed, 07 Mar 2012) Changed paths: M master/buildbot/schedulers/triggerable.py M master/buildbot/steps/trigger.py M master/buildbot/test/unit/test_steps_trigger.py Log Message: ----------- A new setid is created if a sourcestamps is added to the database. Trigger gets sourcestampsetid from triggerable. Commit: 049370a5a949e91cbf928f8ff3221280b155d530 https://github.com/buildbot/buildbot/commit/049370a5a949e91cbf928f8ff3221280b155d530 Author: Harry Borkhuis Date: 2012-03-07 (Wed, 07 Mar 2012) Changed paths: M master/buildbot/sourcestamp.py Log Message: ----------- getSourceStampSetId always returns the setid Commit: 77fc05d14267eb70a41000fc7694fdb0d77a3a0f https://github.com/buildbot/buildbot/commit/77fc05d14267eb70a41000fc7694fdb0d77a3a0f Author: Harry Borkhuis Date: 2012-03-07 (Wed, 07 Mar 2012) Changed paths: M master/buildbot/test/unit/test_schedulers_triggerable.py Log Message: ----------- Test with new interface between Trigger and Triggerable Commit: 158935816c2c568a722db91a19592932279bc6aa https://github.com/buildbot/buildbot/commit/158935816c2c568a722db91a19592932279bc6aa Author: Harry Borkhuis Date: 2012-03-08 (Thu, 08 Mar 2012) Changed paths: M master/buildbot/steps/trigger.py Log Message: ----------- parameter renamed Commit: 2f7402b8cabfc7682656e1c585522c697e03755a https://github.com/buildbot/buildbot/commit/2f7402b8cabfc7682656e1c585522c697e03755a Author: Dustin J. Mitchell Date: 2012-03-09 (Fri, 09 Mar 2012) Changed paths: M master/buildbot/schedulers/triggerable.py M master/buildbot/sourcestamp.py M master/buildbot/steps/trigger.py M master/buildbot/test/unit/test_schedulers_triggerable.py M master/buildbot/test/unit/test_steps_trigger.py Log Message: ----------- Merge branch 'fix_sourcestampsetid_rebased' of git://github.com/hborkhuis/buildbot into buildbot-0.8.6 * 'fix_sourcestampsetid_rebased' of git://github.com/hborkhuis/buildbot: parameter renamed Test with new interface between Trigger and Triggerable getSourceStampSetId always returns the setid A new setid is created if a sourcestamps is added to the database. Trigger gets sourcestampsetid from triggerable. Compare: https://github.com/buildbot/buildbot/compare/cd3a1ab...2f7402b From nobody at buildbot.net Sat Mar 10 09:24:53 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 10 Mar 2012 09:24:53 -0000 Subject: [Buildbot-commits] [Buildbot] #2233: gitpoller should detect when it needs to reinitialize its state. In-Reply-To: <042.a98c26c43c4f6fac9b2583beee812904@buildbot.net> References: <042.a98c26c43c4f6fac9b2583beee812904@buildbot.net> Message-ID: <057.4730e3af5b2d6c22fd8c5f8bf666956a@buildbot.net> #2233: gitpoller should detect when it needs to reinitialize its state. ---------------------------+-------------------- Reporter: tom.prince | Owner: Type: defect | Status: new Priority: minor | Milestone: 0.8.7 Version: 0.8.5 | Resolution: Keywords: git, gitpoller | ---------------------------+-------------------- Changes (by dustin): * milestone: undecided => 0.8.7 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 10 09:25:06 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 10 Mar 2012 09:25:06 -0000 Subject: [Buildbot-commits] [Buildbot] #2232: ForceScheduler should repopulate on error In-Reply-To: <042.8776053bf275446880cebe62970da16a@buildbot.net> References: <042.8776053bf275446880cebe62970da16a@buildbot.net> Message-ID: <057.8be4f0a68a1585c6c9f4ad14418c78bb@buildbot.net> #2232: ForceScheduler should repopulate on error -----------------------+-------------------- Reporter: jaredgrubb | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.7 Version: 0.8.6 | Resolution: Keywords: | -----------------------+-------------------- Changes (by dustin): * milestone: undecided => 0.8.7 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 10 09:25:24 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 10 Mar 2012 09:25:24 -0000 Subject: [Buildbot-commits] [Buildbot] #2231: ForceScheduler should validate its paramter types In-Reply-To: <042.7fdaee2d8bd1034781abc75a27aca83c@buildbot.net> References: <042.7fdaee2d8bd1034781abc75a27aca83c@buildbot.net> Message-ID: <057.99b1eff329cae95609ee47c734b724fc@buildbot.net> #2231: ForceScheduler should validate its paramter types ------------------------+-------------------- Reporter: jaredgrubb | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.7 Version: 0.8.6 | Resolution: Keywords: | ------------------------+-------------------- Changes (by dustin): * milestone: undecided => 0.8.7 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 10 09:25:40 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 10 Mar 2012 09:25:40 -0000 Subject: [Buildbot-commits] [Buildbot] #2231: ForceScheduler should validate its paramter types In-Reply-To: <042.7fdaee2d8bd1034781abc75a27aca83c@buildbot.net> References: <042.7fdaee2d8bd1034781abc75a27aca83c@buildbot.net> Message-ID: <057.3635b4808f156741d61271b6e6c76558@buildbot.net> #2231: ForceScheduler should validate its paramter types ------------------------+-------------------- Reporter: jaredgrubb | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.7 Version: 0.8.6 | Resolution: Keywords: force | ------------------------+-------------------- Changes (by dustin): * keywords: => force -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 10 09:25:47 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 10 Mar 2012 09:25:47 -0000 Subject: [Buildbot-commits] [Buildbot] #2232: ForceScheduler should repopulate on error In-Reply-To: <042.8776053bf275446880cebe62970da16a@buildbot.net> References: <042.8776053bf275446880cebe62970da16a@buildbot.net> Message-ID: <057.a0ae1f936259abba69f338a4a3913bc5@buildbot.net> #2232: ForceScheduler should repopulate on error -----------------------+-------------------- Reporter: jaredgrubb | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.7 Version: 0.8.6 | Resolution: Keywords: force | -----------------------+-------------------- Changes (by dustin): * keywords: => force -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 10 09:29:55 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 10 Mar 2012 09:29:55 -0000 Subject: [Buildbot-commits] [Buildbot] #708: Incorporate bzr_poller.py and add more docs In-Reply-To: <038.493ebe47318ffd7630fc2757d22b566e@buildbot.net> References: <038.493ebe47318ffd7630fc2757d22b566e@buildbot.net> Message-ID: <053.5a1a03e27ab5ed636a8397864722b5d3@buildbot.net> #708: Incorporate bzr_poller.py and add more docs ------------------------+-------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: master | Resolution: Keywords: bzr | ------------------------+-------------------- Comment (by dustin): psykidellic - did you finish this? -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 10 09:31:36 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 10 Mar 2012 09:31:36 -0000 Subject: [Buildbot-commits] [Buildbot] #833: buildbot.status.web.logs assumes logfiles are in utf-8 In-Reply-To: <038.9f4696a9d9da0b680d99e925cc4b6cc2@buildbot.net> References: <038.9f4696a9d9da0b680d99e925cc4b6cc2@buildbot.net> Message-ID: <053.a4feecb8d646aa801ecf35fd9d204eef@buildbot.net> #833: buildbot.status.web.logs assumes logfiles are in utf-8 ---------------------+-------------------- Reporter: dustin | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.0 | Resolution: Keywords: encoding | ---------------------+-------------------- Comment (by dustin): The right solution here is to treat logfiles as bytestrings, and offer some flexible display options in the web status. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 10 09:40:57 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 10 Mar 2012 09:40:57 -0000 Subject: [Buildbot-commits] [Buildbot] #2234: have a better-defined approach to mocking Message-ID: <038.3f03218cf576664488eee36dd4b5b887@buildbot.net> #2234: have a better-defined approach to mocking ------------------------+-------------------- Reporter: dustin | Owner: dustin Type: enhancement | Status: new Priority: major | Milestone: 0.9.+ Version: 0.8.5 | Keywords: tests ------------------------+-------------------- This year's testing track at !PyCon had a lot of content about hitting the right approach with mocks -- and the pains of not doing so. One major point was to make your mocks authoritative (one or zero mocks for any system), narrow (minimal implementation), and isolated (don't depend on the real system). Most of the mocks used in Buildbot are already authoritative -- the stuff in `master/buidlbot/test/fake` in particular, but even some of the mocks in individual test files are unique. There are a lot of status and process class mocks, thought, that are not authoritative. The DB mocks, at least, are narrow - they are pretty poor implementations of the API, in fact. And they are quite well isolated. The path from here is: * state this as policy * check patches against it * fix existing violations * test the mocks * mocks should pass the same tests that the system they're mocking pass * especially for DB API * where this isn't practical, using introspection to compare function signatures gets 80% of the win -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 10 09:44:02 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 10 Mar 2012 09:44:02 -0000 Subject: [Buildbot-commits] [Buildbot] #2235: common testing support for multiple API layers with the same signature Message-ID: <038.1fe376c73ad14d1cdd26c80ef02670c1@buildbot.net> #2235: common testing support for multiple API layers with the same signature ------------------------+-------------------- Reporter: dustin | Owner: dustin Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.5 | Keywords: tests ------------------------+-------------------- There are a few places -- `addChange` and `addBuildset`, at least -- where a whole pile of attributes get passed around from function to function. These should all have the same signature and the same default values (and should match their mocks). This has consistently been a source of pain, and in fact is pretty ugly. Let's first try to minimize the ugliness (perhaps by passing dicts?), and then build some testing code to help where the ugliness remains. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 10 09:44:13 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 10 Mar 2012 09:44:13 -0000 Subject: [Buildbot-commits] [Buildbot] #2235: common testing support for multiple API layers with the same signature In-Reply-To: <038.1fe376c73ad14d1cdd26c80ef02670c1@buildbot.net> References: <038.1fe376c73ad14d1cdd26c80ef02670c1@buildbot.net> Message-ID: <053.01c9fe97b717be3a02f09f20f784f3ed@buildbot.net> #2235: common testing support for multiple API layers with the same signature ------------------------+--------------------- Reporter: dustin | Owner: dustin Type: enhancement | Status: new Priority: major | Milestone: 0.9.+ Version: 0.8.5 | Resolution: Keywords: tests | ------------------------+--------------------- Changes (by dustin): * milestone: 0.8.+ => 0.9.+ -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 10 17:16:04 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 10 Mar 2012 17:16:04 -0000 Subject: [Buildbot-commits] [Buildbot] #2234: have a better-defined approach to mocking In-Reply-To: <038.3f03218cf576664488eee36dd4b5b887@buildbot.net> References: <038.3f03218cf576664488eee36dd4b5b887@buildbot.net> Message-ID: <053.0c838b72b37b8813271dcf68f2b43a7f@buildbot.net> #2234: have a better-defined approach to mocking ------------------------+--------------------- Reporter: dustin | Owner: dustin Type: enhancement | Status: new Priority: major | Milestone: 0.9.+ Version: 0.8.5 | Resolution: Keywords: tests | ------------------------+--------------------- Comment (by tom.prince): - We also have at least one place where we mock out part of twisted (we mock out out a request in the webhook tests - the mock library has some support for creating a mock that matches the signature of a given object or class. This could probably get us the introspection bit. - The scheduler tests have various implementations of ``addBuildset*`` that they use to fake out methods on the base class. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 10 17:16:50 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 10 Mar 2012 17:16:50 -0000 Subject: [Buildbot-commits] [Buildbot] #875: enhance ways of coordinating builds - flocks? In-Reply-To: <040.f883260b3ed2f19b8eb335e5a36698bd@buildbot.net> References: <040.f883260b3ed2f19b8eb335e5a36698bd@buildbot.net> Message-ID: <055.e917edcce775c36f083f4796dac5a7bc@buildbot.net> #875: enhance ways of coordinating builds - flocks? -----------------------+----------------------- Reporter: bhearsum | Owner: djmitche Type: undecided | Status: closed Priority: major | Milestone: 0.8.+ Version: 0.8.0 | Resolution: wontfix Keywords: buildcoord | -----------------------+----------------------- Changes (by dustin): * status: new => closed * resolution: => wontfix Comment: I think that we don't actually need a new model -- rather, sourcestampsets will do a decent job of this. Flocks would run into pain from merging. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 10 17:18:07 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 10 Mar 2012 17:18:07 -0000 Subject: [Buildbot-commits] [Buildbot] #893: Mercurial source step needs username and passwd parms In-Reply-To: <041.58daf607623bd946caee397fda9b28aa@buildbot.net> References: <041.58daf607623bd946caee397fda9b28aa@buildbot.net> Message-ID: <056.988ce65ffec33955db73dd975542eaf3@buildbot.net> #893: Mercurial source step needs username and passwd parms ------------------------+-------------------- Reporter: bgunnison | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.0 | Resolution: Keywords: hg | ------------------------+-------------------- Comment (by dustin): This should get added to the new master-side steps. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 10 17:25:46 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 10 Mar 2012 17:25:46 -0000 Subject: [Buildbot-commits] [Buildbot] #2234: have a better-defined approach to mocking In-Reply-To: <038.3f03218cf576664488eee36dd4b5b887@buildbot.net> References: <038.3f03218cf576664488eee36dd4b5b887@buildbot.net> Message-ID: <053.2b078455e5d3aa9739b2634b50725d65@buildbot.net> #2234: have a better-defined approach to mocking ------------------------+--------------------- Reporter: dustin | Owner: dustin Type: enhancement | Status: new Priority: major | Milestone: 0.9.+ Version: 0.8.5 | Resolution: Keywords: tests | ------------------------+--------------------- Comment (by dustin): There's no problem with mocking third-party objects -- in fact, that's the "normal" use of mocks. Synchronizing the mock and the API there has not been problematic, and should be tested with integration tests. Mock can do some introspection (and Foord announced that 0.8.0 has "autospec", which makes it even easier). However, I'd like to check the signatures directly, rather than relying on the tests to uncover any inconsistencies by getting an error from mock. If practical, we can do both! -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 10 17:26:50 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 10 Mar 2012 17:26:50 -0000 Subject: [Buildbot-commits] [Buildbot] #904: implement build filtering in web ui (was: implement one_line_per_build?filter=XXX) In-Reply-To: <040.0b0cd4cb20328af40458771e6938ba6b@buildbot.net> References: <040.0b0cd4cb20328af40458771e6938ba6b@buildbot.net> Message-ID: <055.f1668062d5b188adaaa2301e8a715745@buildbot.net> #904: implement build filtering in web ui --------------------------+-------------------- Reporter: bhearsum | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.9.+ Version: 0.8.0 | Resolution: Keywords: web, database | --------------------------+-------------------- Changes (by dustin): * milestone: 0.8.+ => 0.9.+ -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 10 17:29:22 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 10 Mar 2012 17:29:22 -0000 Subject: [Buildbot-commits] [Buildbot] #913: revlink callback and builders view does not work together. In-Reply-To: <041.112559e1d8b72c9b44183fd09197ae39@buildbot.net> References: <041.112559e1d8b72c9b44183fd09197ae39@buildbot.net> Message-ID: <056.2e28cb09af8d973577eb504f9bde714f@buildbot.net> #913: revlink callback and builders view does not work together. --------------------------+-------------------- Reporter: cdadhemar | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.7 Version: 0.8.0 | Resolution: Keywords: web, projrepo | --------------------------+-------------------- Changes (by dustin): * milestone: 0.8.+ => 0.8.7 Comment: Is this something we can fix once multirepo has landed? -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 10 17:36:23 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 10 Mar 2012 17:36:23 -0000 Subject: [Buildbot-commits] [Buildbot] #921: buildmaster logging should be more segregated In-Reply-To: <040.f26eb6b5fa73609c33c0d37dc50714a3@buildbot.net> References: <040.f26eb6b5fa73609c33c0d37dc50714a3@buildbot.net> Message-ID: <055.14093e80e4ce59863cebd00ec2c9251f@buildbot.net> #921: buildmaster logging should be more segregated ------------------------+-------------------- Reporter: bhearsum | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.0 | Resolution: Keywords: sprint | ------------------------+-------------------- Changes (by dustin): * keywords: => sprint Comment: This is a good sprint project, even if it doesn't get "solved", any improvement to this logging will be helpful. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 10 17:39:02 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 10 Mar 2012 17:39:02 -0000 Subject: [Buildbot-commits] [Buildbot] #928: Allow builder to be associated with multiple categories In-Reply-To: <038.51386ed5975d423860b7df3ecfae8e27@buildbot.net> References: <038.51386ed5975d423860b7df3ecfae8e27@buildbot.net> Message-ID: <053.4bf170671b8e1041799dd9240bb9479d@buildbot.net> #928: Allow builder to be associated with multiple categories ------------------------+-------------------- Reporter: stefan | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.0 | Resolution: Keywords: sprint | ------------------------+-------------------- Changes (by dustin): * keywords: => sprint Comment: Maybe we should introduce builder "tags", and make category a deprecated special case of that? -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 10 17:44:07 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 10 Mar 2012 17:44:07 -0000 Subject: [Buildbot-commits] [Buildbot] #952: CUnit support In-Reply-To: <037.12f5de32ce2d4b016d23e74525702c10@buildbot.net> References: <037.12f5de32ce2d4b016d23e74525702c10@buildbot.net> Message-ID: <052.7dab02d46d6a9842f4f635e8d4b25082@buildbot.net> #952: CUnit support ------------------------+------------------------- Reporter: mattn | Owner: Type: enhancement | Status: closed Priority: major | Milestone: 0.8.+ Version: | Resolution: worksforme Keywords: | ------------------------+------------------------- Changes (by dustin): * status: new => closed * resolution: => worksforme Comment: I suspect that this is generally just rolled as a !ShellCommand. I'll be happy to see this re-opened (or better, a pull request) if someone's got a generally-useful implementation. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 10 17:51:13 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 10 Mar 2012 17:51:13 -0000 Subject: [Buildbot-commits] [Buildbot] #956: Send an email notification to the person who forces/rebuilds a build In-Reply-To: <053.90a141f4d7d39441567be12e2bab5e39@buildbot.net> References: <053.90a141f4d7d39441567be12e2bab5e39@buildbot.net> Message-ID: <068.027904ec8b2a8778042bc30b1ac1b3d8@buildbot.net> #956: Send an email notification to the person who forces/rebuilds a build ----------------------------------+-------------------- Reporter: yogawa@? | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.1 | Resolution: Keywords: mail, users | ----------------------------------+-------------------- Changes (by dustin): * keywords: mail => mail, users -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 10 17:53:32 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 10 Mar 2012 17:53:32 -0000 Subject: [Buildbot-commits] [Buildbot] #960: Convert all buildbot classes to new style, i.e. inherit from object. In-Reply-To: <038.d2790722df76541e40fedfc676770414@buildbot.net> References: <038.d2790722df76541e40fedfc676770414@buildbot.net> Message-ID: <053.53a8183756931d7c3da395ebd5e1dd2c@buildbot.net> #960: Convert all buildbot classes to new style, i.e. inherit from object. -------------------+-------------------- Reporter: maruel | Owner: Type: task | Status: new Priority: major | Milestone: 1.0.+ Version: 0.8.1 | Resolution: Keywords: tests | -------------------+-------------------- Changes (by dustin): * milestone: 0.8.+ => 1.0.+ Comment: I think this will need to wait *longer* than statusdb (#24), since for a good while we'll support upgrading from pickles to statusdb. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 10 18:02:03 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 10 Mar 2012 18:02:03 -0000 Subject: [Buildbot-commits] [Buildbot] #984: per-project revlink In-Reply-To: <039.dadc1ed0406277c545f191d04933f465@buildbot.net> References: <039.dadc1ed0406277c545f191d04933f465@buildbot.net> Message-ID: <054.73002b94484d7445e6c1077ad4f0fb2a@buildbot.net> #984: per-project revlink ------------------------+-------------------- Reporter: moschny | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.1 | Resolution: Keywords: web, sprint | ------------------------+-------------------- Changes (by dustin): * keywords: web => web, sprint -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 10 18:09:56 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 10 Mar 2012 18:09:56 -0000 Subject: [Buildbot-commits] [Buildbot] #994: reconfig by graceful failover In-Reply-To: <038.c34319c417a76e46839ddd101bfeba6a@buildbot.net> References: <038.c34319c417a76e46839ddd101bfeba6a@buildbot.net> Message-ID: <053.3e04c52c43af70e59d3827492fc8965f@buildbot.net> #994: reconfig by graceful failover ------------------------------+-------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: major | Milestone: 1.0.+ Version: 0.8.1 | Resolution: Keywords: database reconfig | ------------------------------+-------------------- Changes (by dustin): * milestone: 0.8.+ => 1.0.+ Comment: The new config interface actually does a bit better job with reconfigs, but there are still problems: * reloading/pre-initializing Python from the config file (ugh, and we have some fixes) * performance / memory consumption -- Buildbot can end up using a lot of memory (and whether this is Buildbot or custom modules is unclear - see the [tag:performance performance tag]), and restarting the process is a great way to flush that. So this is still necessary, but less soon. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 10 18:10:51 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 10 Mar 2012 18:10:51 -0000 Subject: [Buildbot-commits] [Buildbot] #995: Build end time = 0 (Dec 31, 1969) In-Reply-To: <039.f1b2f82c59e5eba952e41546574649a6@buildbot.net> References: <039.f1b2f82c59e5eba952e41546574649a6@buildbot.net> Message-ID: <054.d1f0fb28de3ed29c1abeb4c0026d087d@buildbot.net> #995: Build end time = 0 (Dec 31, 1969) --------------------+------------------------- Reporter: exarkun | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.+ Version: 0.8.1 | Resolution: worksforme Keywords: | --------------------+------------------------- Changes (by dustin): * status: new => closed * resolution: => worksforme Comment: I suspect that this came from the old DB interface, so I'm going to assume it's fixed! -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 10 18:17:23 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 10 Mar 2012 18:17:23 -0000 Subject: [Buildbot-commits] [Buildbot] #921: buildmaster logging should be more segregated In-Reply-To: <040.f26eb6b5fa73609c33c0d37dc50714a3@buildbot.net> References: <040.f26eb6b5fa73609c33c0d37dc50714a3@buildbot.net> Message-ID: <055.cff88f6dfdbbb5866b5e4e1ee5fc1ad6@buildbot.net> #921: buildmaster logging should be more segregated ------------------------+-------------------- Reporter: bhearsum | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.0 | Resolution: Keywords: sprint | ------------------------+-------------------- Comment (by tom.prince): {{{ from twisted.python.log import ILogContext, callWithContext }}} might be relevant here. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 10 18:30:46 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 10 Mar 2012 18:30:46 -0000 Subject: [Buildbot-commits] [Buildbot] #960: Convert all buildbot classes to new style, i.e. inherit from object. In-Reply-To: <038.d2790722df76541e40fedfc676770414@buildbot.net> References: <038.d2790722df76541e40fedfc676770414@buildbot.net> Message-ID: <053.45ef7af874365d687dddb7edfa5c51ee@buildbot.net> #960: Convert all buildbot classes to new style, i.e. inherit from object. -------------------+-------------------- Reporter: maruel | Owner: Type: task | Status: new Priority: major | Milestone: 1.0.+ Version: 0.8.1 | Resolution: Keywords: tests | -------------------+-------------------- Comment (by tom.prince): We can probably change this after statusdb lands. 1. Provide a separate tool for upgrading pickles. 2. Provide a custom unpickler, that overrides ``find_class`` to redirect objects to compatibility classes. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 10 19:06:37 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 10 Mar 2012 19:06:37 -0000 Subject: [Buildbot-commits] [Buildbot] #996: set up vulnerability-handling process In-Reply-To: <038.36b0e4686697d3833782444f438d4671@buildbot.net> References: <038.36b0e4686697d3833782444f438d4671@buildbot.net> Message-ID: <053.f310343363126e9ae3829d8c31e68a00@buildbot.net> #996: set up vulnerability-handling process -------------------+--------------------- Reporter: dustin | Owner: dustin Type: task | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.1 | Resolution: Keywords: | -------------------+--------------------- Comment (by dustin): We have a team in process now (in MAINTAINERS.txt), and given the low level of reports, I think that's sufficient. I just added a pretty lame SecurityPolicy. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 10 19:09:47 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 10 Mar 2012 19:09:47 -0000 Subject: [Buildbot-commits] [Buildbot] #998: better handling for tags in changesources (was: git_buildbot.py ignores tags) In-Reply-To: <036.92225bad6a92f142c6531bf660f7d90a@buildbot.net> References: <036.92225bad6a92f142c6531bf660f7d90a@buildbot.net> Message-ID: <051.ae5494a85ce0ee6769f7d85794a22fc6@buildbot.net> #998: better handling for tags in changesources -------------------------+-------------------- Reporter: chrb | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.1 | Resolution: Keywords: git, hg, svn | -------------------------+-------------------- Changes (by dustin): * keywords: git => git, hg, svn Comment: I think that we need a better, more general solution to this. Unfortunately, different VC's handle tags differently -- for Git, they are not a commit, whereas for svn and hg, they are. And in hg, the URL needs to change. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 10 19:16:27 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 10 Mar 2012 19:16:27 -0000 Subject: [Buildbot-commits] [Buildbot] #1009: Detect builds that fail consecutively for different reasons In-Reply-To: <037.9072cfd56af9c31d4e5ab410dbbfbe2f@buildbot.net> References: <037.9072cfd56af9c31d4e5ab410dbbfbe2f@buildbot.net> Message-ID: <052.aba631f5c0d79109d77a6a2a3b43477a@buildbot.net> #1009: Detect builds that fail consecutively for different reasons ------------------------+-------------------- Reporter: ayust | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.9.+ Version: 0.8.1 | Resolution: Keywords: buildcoord | ------------------------+-------------------- Changes (by dustin): * keywords: => buildcoord * milestone: 0.8.+ => 0.9.+ -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 10 19:24:27 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 10 Mar 2012 19:24:27 -0000 Subject: [Buildbot-commits] [Buildbot] #1038: Audit TimerService / other looping calls In-Reply-To: <038.4c96b15288faad52c58d8f2a564849bf@buildbot.net> References: <038.4c96b15288faad52c58d8f2a564849bf@buildbot.net> Message-ID: <053.117ccd9308782fb48f1b80aeb2990551@buildbot.net> #1038: Audit TimerService / other looping calls -----------------------------+-------------------- Reporter: catlee | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.1 | Resolution: Keywords: database, sprint | -----------------------------+-------------------- Changes (by dustin): * keywords: database => database, sprint -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 10 19:24:53 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 10 Mar 2012 19:24:53 -0000 Subject: [Buildbot-commits] [Buildbot] #1039: Allow trigger -> triggerable to span masters In-Reply-To: <038.fa20366b372b6a82d150302063839a01@buildbot.net> References: <038.fa20366b372b6a82d150302063839a01@buildbot.net> Message-ID: <053.fd79c1167df9472dc4bed8703f4298f5@buildbot.net> #1039: Allow trigger -> triggerable to span masters -------------------------+-------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.9.0 Version: 0.8.1 | Resolution: Keywords: database, mq | -------------------------+-------------------- Changes (by dustin): * keywords: database => database, mq * milestone: 0.8.+ => 0.9.0 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 10 19:27:15 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 10 Mar 2012 19:27:15 -0000 Subject: [Buildbot-commits] [Buildbot] #1054: sqlite3.ProgrammingError when starting a rebuild with non-ASCII chars in re-build reason In-Reply-To: <044.2de614d921abd44d3f564e3b01bf901d@buildbot.net> References: <044.2de614d921abd44d3f564e3b01bf901d@buildbot.net> Message-ID: <059.562950ddce3a13ff66f6546f1d75abe7@buildbot.net> #1054: sqlite3.ProgrammingError when starting a rebuild with non-ASCII chars in re-build reason -------------------------+-------------------- Reporter: andialbrecht | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.7 Version: 0.8.1 | Resolution: Keywords: database | -------------------------+-------------------- Changes (by dustin): * milestone: 0.8.+ => 0.8.7 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 10 19:32:36 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 10 Mar 2012 19:32:36 -0000 Subject: [Buildbot-commits] [Buildbot] #1064: Logging ChangeFilter checks In-Reply-To: <036.ea1b0c67a656f852f154c2ba07bb974b@buildbot.net> References: <036.ea1b0c67a656f852f154c2ba07bb974b@buildbot.net> Message-ID: <051.1f9e269d93d5e72b6a26dba745811ed2@buildbot.net> #1064: Logging ChangeFilter checks ------------------------+-------------------- Reporter: strk | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.2 | Resolution: Keywords: sprint | ------------------------+-------------------- Changes (by dustin): * keywords: => sprint -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 10 19:35:35 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 10 Mar 2012 19:35:35 -0000 Subject: [Buildbot-commits] [Buildbot] #1688: there should be some way to retry builds that fail in setupBuild without submitting new Changes. In-Reply-To: <040.cf0839495386f26c7888290ad64ef90a@buildbot.net> References: <040.cf0839495386f26c7888290ad64ef90a@buildbot.net> Message-ID: <055.43c43eb09bd9996b6cd4cff0bb9ae9fa@buildbot.net> #1688: there should be some way to retry builds that fail in setupBuild without submitting new Changes. ------------------------+-------------------- Reporter: bhearsum | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.2 | Resolution: Keywords: | ------------------------+-------------------- Comment (by dustin): Looking back, I think catlee's suggestion was correct - if `setupBuild` fails, the claim should be retired and the build request will be re- assigned (well, attempted) again. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 10 21:19:26 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 10 Mar 2012 21:19:26 -0000 Subject: [Buildbot-commits] [Buildbot] #1689: sendchange should not require changed files In-Reply-To: <037.17dc227f70c6458d54e6f4a13daab38b@buildbot.net> References: <037.17dc227f70c6458d54e6f4a13daab38b@buildbot.net> Message-ID: <052.2a3f125b3430fa0556ef09f07ca9c5a4@buildbot.net> #1689: sendchange should not require changed files -------------------+-------------------- Reporter: ayust | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.7 Version: master | Resolution: Keywords: sprint | -------------------+-------------------- Changes (by dustin): * keywords: => sprint * milestone: 0.8.+ => 0.8.7 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 10 21:19:38 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 10 Mar 2012 21:19:38 -0000 Subject: [Buildbot-commits] [Buildbot] #1696: use twisted.web.Guard for authentication In-Reply-To: <038.c7736385ae029f93dfece0a95e26bc84@buildbot.net> References: <038.c7736385ae029f93dfece0a95e26bc84@buildbot.net> Message-ID: <053.6c7607d73b6ef6b95d52946c93e73b56@buildbot.net> #1696: use twisted.web.Guard for authentication ------------------------+-------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.9.0 Version: 0.8.2 | Resolution: Keywords: web, | ------------------------+-------------------- Changes (by dustin): * milestone: 0.8.+ => 0.9.0 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 10 21:21:12 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 10 Mar 2012 21:21:12 -0000 Subject: [Buildbot-commits] [Buildbot] #1705: Provide a better way of working with resources utilized by builds In-Reply-To: <037.54f21eb698a41efe8036282ff0340d4b@buildbot.net> References: <037.54f21eb698a41efe8036282ff0340d4b@buildbot.net> Message-ID: <052.37c1c9be5ea27f645801d679d2979f82@buildbot.net> #1705: Provide a better way of working with resources utilized by builds ------------------------+-------------------- Reporter: ayust | Owner: Type: enhancement | Status: new Priority: major | Milestone: 1.0.+ Version: master | Resolution: Keywords: | ------------------------+-------------------- Changes (by dustin): * milestone: 0.8.+ => 1.0.+ -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 10 21:22:07 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 10 Mar 2012 21:22:07 -0000 Subject: [Buildbot-commits] [Buildbot] #1728: Git: add support for setting additional information via Git notes In-Reply-To: <043.8b1d4a52e38fd8f9864e8e19f915c616@buildbot.net> References: <043.8b1d4a52e38fd8f9864e8e19f915c616@buildbot.net> Message-ID: <058.5c15208bfef681c4c7524fa3fffa3357@buildbot.net> #1728: Git: add support for setting additional information via Git notes ------------------------+-------------------- Reporter: PiotrSikora | Owner: Type: enhancement | Status: new Priority: major | Milestone: 1.0.+ Version: 0.8.2 | Resolution: Keywords: git, gerrit | ------------------------+-------------------- Changes (by dustin): * milestone: 0.8.+ => 1.0.+ -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 10 21:27:59 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 10 Mar 2012 21:27:59 -0000 Subject: [Buildbot-commits] [Buildbot] #1733: GerritStatusPush: missing retrying mechanism for staus updates In-Reply-To: <043.0e18d609a765c2de261443f25a429724@buildbot.net> References: <043.0e18d609a765c2de261443f25a429724@buildbot.net> Message-ID: <058.6bdeeaa7f4f7ef0740476f4572981bf0@buildbot.net> #1733: GerritStatusPush: missing retrying mechanism for staus updates -----------------------------+-------------------- Reporter: PiotrSikora | Owner: Type: defect | Status: new Priority: major | Milestone: 0.9.+ Version: 0.8.2 | Resolution: Keywords: gerrit, mq, mail | -----------------------------+-------------------- Changes (by dustin): * keywords: gerrit => gerrit, mq, mail * milestone: 0.8.+ => 0.9.+ -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 10 21:30:37 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 10 Mar 2012 21:30:37 -0000 Subject: [Buildbot-commits] [Buildbot] #1782: Hide email address in web status In-Reply-To: <038.56052ef3d3464397f95b3fcc291e0c55@buildbot.net> References: <038.56052ef3d3464397f95b3fcc291e0c55@buildbot.net> Message-ID: <053.a8e112f049c9427e6f912e8515a0b6f0@buildbot.net> #1782: Hide email address in web status ------------------------+-------------------- Reporter: tfogal | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.3p1 | Resolution: Keywords: users | ------------------------+-------------------- Changes (by dustin): * keywords: => users -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 10 21:33:07 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 10 Mar 2012 21:33:07 -0000 Subject: [Buildbot-commits] [Buildbot] #1784: Buildmaster blocks In-Reply-To: <040.b9bf7390b4609c7970b110cd158d5cf1@buildbot.net> References: <040.b9bf7390b4609c7970b110cd158d5cf1@buildbot.net> Message-ID: <055.cf4b5eb935ba5bb96264d8d560882907@buildbot.net> #1784: Buildmaster blocks ------------------------+------------------------- Reporter: Schenker | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.+ Version: 0.8.0 | Resolution: worksforme Keywords: performance | ------------------------+------------------------- Changes (by dustin): * status: new => closed * resolution: => worksforme -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 10 21:34:57 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 10 Mar 2012 21:34:57 -0000 Subject: [Buildbot-commits] [Buildbot] #1790: Nightly scheduler should have an option to not re-schedule missed builds In-Reply-To: <035.292c6bc21dbda0cafa9d366bfc8f411e@buildbot.net> References: <035.292c6bc21dbda0cafa9d366bfc8f411e@buildbot.net> Message-ID: <050.b7d95e12e9fc2753b616e7c188d1a47a@buildbot.net> #1790: Nightly scheduler should have an option to not re-schedule missed builds ------------------------+-------------------- Reporter: aki | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.2 | Resolution: Keywords: sprint | ------------------------+-------------------- Changes (by dustin): * keywords: => sprint -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 10 21:39:17 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 10 Mar 2012 21:39:17 -0000 Subject: [Buildbot-commits] [Buildbot] #1794: UI for displaying test results In-Reply-To: <041.e541d58ea8c1293e93ea80873861e229@buildbot.net> References: <041.e541d58ea8c1293e93ea80873861e229@buildbot.net> Message-ID: <056.ec9ba2659a8f95a0bfea286a05ad487a@buildbot.net> #1794: UI for displaying test results ------------------------+------------------------ Reporter: liucougar | Owner: liucougar Type: enhancement | Status: new Priority: major | Milestone: 0.9.+ Version: 0.8.3p1 | Resolution: Keywords: web | ------------------------+------------------------ Changes (by dustin): * milestone: 0.8.+ => 0.9.+ -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 10 21:40:45 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 10 Mar 2012 21:40:45 -0000 Subject: [Buildbot-commits] [Buildbot] #1795: add python script slave-side command In-Reply-To: <038.e85839bcaeecc89b05fe39de8747e2e9@buildbot.net> References: <038.e85839bcaeecc89b05fe39de8747e2e9@buildbot.net> Message-ID: <053.bc858d24edb837a73e6987d934a03294@buildbot.net> #1795: add python script slave-side command ------------------------+-------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.3p1 | Resolution: Keywords: sprint | ------------------------+-------------------- Changes (by dustin): * keywords: => sprint -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 10 21:41:39 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 10 Mar 2012 21:41:39 -0000 Subject: [Buildbot-commits] [Buildbot] #1800: Automatically create "templates" folder with explanatory "readme.txt" on create/update master In-Reply-To: <039.c1df8e027943a49015f72fd5783fca61@buildbot.net> References: <039.c1df8e027943a49015f72fd5783fca61@buildbot.net> Message-ID: <054.381d5587bb756c44695eb2cbbdb58b8e@buildbot.net> #1800: Automatically create "templates" folder with explanatory "readme.txt" on create/update master ------------------------+-------------------- Reporter: marcusl | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.7 Version: 0.8.3p1 | Resolution: Keywords: web, sprint | ------------------------+-------------------- Changes (by dustin): * keywords: web => web, sprint * milestone: 0.8.+ => 0.8.7 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 10 21:42:33 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 10 Mar 2012 21:42:33 -0000 Subject: [Buildbot-commits] [Buildbot] #1801: refactor slave/buildslave/runprocess.py In-Reply-To: <038.dbe890d09f95792c8f35a619c410e1fa@buildbot.net> References: <038.dbe890d09f95792c8f35a619c410e1fa@buildbot.net> Message-ID: <053.b42110f076ed3522f2e939febe6f74d2@buildbot.net> #1801: refactor slave/buildslave/runprocess.py ------------------------+-------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.7 Version: 0.8.3p1 | Resolution: Keywords: kill | ------------------------+-------------------- Changes (by dustin): * milestone: 0.8.+ => 0.8.7 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 10 21:45:19 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 10 Mar 2012 21:45:19 -0000 Subject: [Buildbot-commits] [Buildbot] #1807: aggregate coverage from all metabuildbot builders In-Reply-To: <038.fbd4026cb0390f7e085aa96a3d473c33@buildbot.net> References: <038.fbd4026cb0390f7e085aa96a3d473c33@buildbot.net> Message-ID: <053.5e4f5bd1b92e04a397257093627bad89@buildbot.net> #1807: aggregate coverage from all metabuildbot builders --------------------+-------------------- Reporter: dustin | Owner: Type: task | Status: new Priority: major | Milestone: 1.0.+ Version: 0.8.3p1 | Resolution: Keywords: tests | --------------------+-------------------- Changes (by dustin): * milestone: 0.8.+ => 1.0.+ Comment: We may want to consider using branch coverage at this point, too. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 10 21:48:19 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 10 Mar 2012 21:48:19 -0000 Subject: [Buildbot-commits] [Buildbot] #1808: Scheduler with treeStableTimer "merges" changes to multiple projects into single SourceStamp In-Reply-To: <039.cd87665d300c4855d7e125d8690e0a31@buildbot.net> References: <039.cd87665d300c4855d7e125d8690e0a31@buildbot.net> Message-ID: <054.3ec3f95faa10ad3cfdcc3698741bba4b@buildbot.net> #1808: Scheduler with treeStableTimer "merges" changes to multiple projects into single SourceStamp --------------------+-------------------- Reporter: aivarsk | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.3p1 | Resolution: Keywords: sprint | --------------------+-------------------- Changes (by dustin): * keywords: => sprint -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 10 21:52:09 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 10 Mar 2012 21:52:09 -0000 Subject: [Buildbot-commits] [Buildbot] #1822: Support schedulers "claiming" their schedulerid In-Reply-To: <038.dc5a8ef119444049494f81c927fed200@buildbot.net> References: <038.dc5a8ef119444049494f81c927fed200@buildbot.net> Message-ID: <053.174417ebbe99d4e975fe6fa7de9cc4bf@buildbot.net> #1822: Support schedulers "claiming" their schedulerid ------------------------+-------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.9.0 Version: master | Resolution: Keywords: database | ------------------------+-------------------- Changes (by dustin): * milestone: 0.8.+ => 0.9.0 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 10 21:54:16 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 10 Mar 2012 21:54:16 -0000 Subject: [Buildbot-commits] [Buildbot] #1825: Nightly scheduler should use a smarter algorithm to find the next time In-Reply-To: <038.9230397741f016ec165d088d9e530123@buildbot.net> References: <038.9230397741f016ec165d088d9e530123@buildbot.net> Message-ID: <053.b783b3c932392a5a4969d58429dd1b2c@buildbot.net> #1825: Nightly scheduler should use a smarter algorithm to find the next time ------------------------+------------------------ Reporter: dustin | Owner: Type: enhancement | Status: closed Priority: major | Milestone: 0.8.+ Version: master | Resolution: duplicate Keywords: | ------------------------+------------------------ Changes (by dustin): * status: new => closed * resolution: => duplicate Comment: dup #1951 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 10 23:05:52 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 10 Mar 2012 23:05:52 -0000 Subject: [Buildbot-commits] [Buildbot] #1827: Make graceful shutdown a buildbot command In-Reply-To: <035.0e49a5e0b9b88be7892ca41082c5f07e@buildbot.net> References: <035.0e49a5e0b9b88be7892ca41082c5f07e@buildbot.net> Message-ID: <050.39a649c45592914fa10ea1ff058135ae@buildbot.net> #1827: Make graceful shutdown a buildbot command ------------------------+----------------------- Reporter: mjw | Owner: ayust Type: enhancement | Status: assigned Priority: major | Milestone: 0.8.7 Version: 0.8.3p1 | Resolution: Keywords: sprint | ------------------------+----------------------- Changes (by dustin): * milestone: 0.8.+ => 0.8.7 Comment: jstultz in IRC just asked about this today. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 10 23:08:53 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 10 Mar 2012 23:08:53 -0000 Subject: [Buildbot-commits] [Buildbot] #1850: Possibility to display the branch of the changes in the changes waterfall column In-Reply-To: <040.126db59196919bc45475d560861b1e4b@buildbot.net> References: <040.126db59196919bc45475d560861b1e4b@buildbot.net> Message-ID: <055.50853e299b13f04bda66ab074d2f85fd@buildbot.net> #1850: Possibility to display the branch of the changes in the changes waterfall column ------------------------+-------------------- Reporter: ykoehler | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.3 | Resolution: Keywords: web, sprint | ------------------------+-------------------- Changes (by dustin): * keywords: web => web, sprint -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 10 23:09:56 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 10 Mar 2012 23:09:56 -0000 Subject: [Buildbot-commits] [Buildbot] #1851: Display scheduler name in the builder title In-Reply-To: <040.c1de18b6ed5c8e86c32ecbfdbc425283@buildbot.net> References: <040.c1de18b6ed5c8e86c32ecbfdbc425283@buildbot.net> Message-ID: <055.b7c0b233a7b4514dd700ddd11278295f@buildbot.net> #1851: Display scheduler name in the builder title ------------------------+-------------------- Reporter: ykoehler | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.3 | Resolution: Keywords: web | ------------------------+-------------------- Changes (by dustin): * keywords: => web Comment: There should probably be a map from builders to schedulers, with each scheduler annotated as to its expected next time. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 10 23:12:55 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 10 Mar 2012 23:12:55 -0000 Subject: [Buildbot-commits] [Buildbot] #1851: Display scheduler name in the builder title In-Reply-To: <040.c1de18b6ed5c8e86c32ecbfdbc425283@buildbot.net> References: <040.c1de18b6ed5c8e86c32ecbfdbc425283@buildbot.net> Message-ID: <055.0cb36f78388b2791264140e9f3bdb154@buildbot.net> #1851: Display scheduler name in the builder title ------------------------+-------------------- Reporter: ykoehler | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.3 | Resolution: Keywords: web | ------------------------+-------------------- Comment (by dustin): (and thus this will require a web page for schedulers - #765) -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 10 23:15:57 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 10 Mar 2012 23:15:57 -0000 Subject: [Buildbot-commits] [Buildbot] #1859: SVNPoller failed In-Reply-To: <047.2d513d25d13b2c3dc1cca3ce6ec90821@buildbot.net> References: <047.2d513d25d13b2c3dc1cca3ce6ec90821@buildbot.net> Message-ID: <062.9ca233f70db5e839709c06937a992c1b@buildbot.net> #1859: SVNPoller failed ----------------------------+------------------------------- Reporter: sanlokenpatidar | Owner: Lokendra Patidar Type: support-request | Status: closed Priority: major | Milestone: 0.8.+ Version: master | Resolution: worksforme Keywords: | ----------------------------+------------------------------- Changes (by dustin): * status: new => closed * resolution: => worksforme -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 10 23:17:37 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 10 Mar 2012 23:17:37 -0000 Subject: [Buildbot-commits] [Buildbot] #1864: Nightly scheduler don't trigger builds if last_build is in future In-Reply-To: <036.48435b958e958b75fab97d8f12d01fe4@buildbot.net> References: <036.48435b958e958b75fab97d8f12d01fe4@buildbot.net> Message-ID: <051.91b9ec06e3b43c5abf4dbc8e73d58a4c@buildbot.net> #1864: Nightly scheduler don't trigger builds if last_build is in future --------------------+--------------------- Reporter: dion | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.+ Version: 0.8.3p1 | Resolution: fixed Keywords: | --------------------+--------------------- Changes (by dustin): * status: new => closed * resolution: => fixed -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 10 23:21:41 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 10 Mar 2012 23:21:41 -0000 Subject: [Buildbot-commits] [Buildbot] #1883: How to solve it "step 'svn' complete: failure" In-Reply-To: <047.f32790d34d5ad0cbc33db4d54fd61808@buildbot.net> References: <047.f32790d34d5ad0cbc33db4d54fd61808@buildbot.net> Message-ID: <062.cc313a548ccd406179de4cf9ff9f72a1@buildbot.net> #1883: How to solve it "step 'svn' complete: failure" ----------------------------+------------------------- Reporter: sanlokenpatidar | Owner: Type: support-request | Status: closed Priority: major | Milestone: 0.8.+ Version: 0.8.3p1 | Resolution: worksforme Keywords: | ----------------------------+------------------------- Changes (by dustin): * status: new => closed * resolution: => worksforme -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 10 23:23:46 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 10 Mar 2012 23:23:46 -0000 Subject: [Buildbot-commits] [Buildbot] #1890: debug Buildbot's memory use In-Reply-To: <038.8fe001fd1b66f9ec9dbbb0f215b0fa1f@buildbot.net> References: <038.8fe001fd1b66f9ec9dbbb0f215b0fa1f@buildbot.net> Message-ID: <053.a63327568b063b344eb58cb6883d1cf5@buildbot.net> #1890: debug Buildbot's memory use ------------------------+-------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: master | Resolution: Keywords: performance | ------------------------+-------------------- Changes (by dustin): * keywords: docs => performance Comment: I learned about `socketconsole` at this year's PyCon, which gives you an external way to look at what each thread is doing at a given time. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 10 23:30:20 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 10 Mar 2012 23:30:20 -0000 Subject: [Buildbot-commits] [Buildbot] #1880: Graceful *restart* of the master in addition to existing graceful shutdown In-Reply-To: <038.ebb24abe8987755b9e554a44312cf6a9@buildbot.net> References: <038.ebb24abe8987755b9e554a44312cf6a9@buildbot.net> Message-ID: <053.cd2d34dfbd22bf7a5a635808570e50ad@buildbot.net> #1880: Graceful *restart* of the master in addition to existing graceful shutdown ------------------------+------------------------ Reporter: dustin | Owner: Type: enhancement | Status: closed Priority: major | Milestone: 0.9.+ Version: 0.8.3p1 | Resolution: duplicate Keywords: reconfig | ------------------------+------------------------ Changes (by dustin): * status: new => closed * resolution: => duplicate Comment: dup #994 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 10 23:30:32 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 10 Mar 2012 23:30:32 -0000 Subject: [Buildbot-commits] [Buildbot] #994: reconfig by graceful failover In-Reply-To: <038.c34319c417a76e46839ddd101bfeba6a@buildbot.net> References: <038.c34319c417a76e46839ddd101bfeba6a@buildbot.net> Message-ID: <053.809c91d34f7e76627bfc05123819fa68@buildbot.net> #994: reconfig by graceful failover ------------------------------+-------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: major | Milestone: 1.0.+ Version: 0.8.1 | Resolution: Keywords: database reconfig | ------------------------------+-------------------- Comment (by dustin): see also #1880 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 10 23:34:03 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 10 Mar 2012 23:34:03 -0000 Subject: [Buildbot-commits] [Buildbot] #2236: Experiment with loading config in a "rollback importer" Message-ID: <038.5fd44b61ce46772e2877b318a8727941@buildbot.net> #2236: Experiment with loading config in a "rollback importer" ------------------------+---------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.5 | Keywords: reconfig ------------------------+---------------------- See http://pyunit.sourceforge.net/notes/reloading.html -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 10 23:34:34 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 10 Mar 2012 23:34:34 -0000 Subject: [Buildbot-commits] [Buildbot] #1891: investigate and document using exocet to reload modules In-Reply-To: <038.e27c647ef8c8f85cc331a1b299507b28@buildbot.net> References: <038.e27c647ef8c8f85cc331a1b299507b28@buildbot.net> Message-ID: <053.c6ff53398eee0271929f695b34e64ecc@buildbot.net> #1891: investigate and document using exocet to reload modules ------------------------+-------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.3p1 | Resolution: Keywords: reconfig | ------------------------+-------------------- Changes (by dustin): * keywords: docs => reconfig -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 10 23:36:48 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 10 Mar 2012 23:36:48 -0000 Subject: [Buildbot-commits] [Buildbot] #1948: WithProperties doesn't interact properly with reconfig In-Reply-To: <041.537f4449c6c3fce9ae209d184140932f@buildbot.net> References: <041.537f4449c6c3fce9ae209d184140932f@buildbot.net> Message-ID: <056.38033dda3dccaa84aa79cdf9394cfce4@buildbot.net> #1948: WithProperties doesn't interact properly with reconfig ----------------------+-------------------- Reporter: dabrahams | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.3p1 | Resolution: Keywords: reconfig | ----------------------+-------------------- Changes (by dustin): * keywords: => reconfig Comment: Probably the correct solution here is to not have builders try to notice that they have been reconfigured, but just use the new configuration directly. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Mar 11 00:19:16 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 11 Mar 2012 00:19:16 -0000 Subject: [Buildbot-commits] [Buildbot] #1964: If a shell script (.sh) has to be run from the master.cfg file , in which path should the script exist and what is the add step command that needs to be given in the master.cfg file? In-Reply-To: <047.f6c2e4c4fb69c71413268dae65be661c@buildbot.net> References: <047.f6c2e4c4fb69c71413268dae65be661c@buildbot.net> Message-ID: <062.d91219fd3ded716659ca7890e875c71e@buildbot.net> #1964: If a shell script (.sh) has to be run from the master.cfg file , in which path should the script exist and what is the add step command that needs to be given in the master.cfg file? ----------------------------+------------------------- Reporter: sanlokenpatidar | Owner: Type: support-request | Status: closed Priority: major | Milestone: 0.8.+ Version: 0.8.3p1 | Resolution: worksforme Keywords: | ----------------------------+------------------------- Changes (by dustin): * status: new => closed * resolution: => worksforme -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Mar 11 00:19:42 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 11 Mar 2012 00:19:42 -0000 Subject: [Buildbot-commits] [Buildbot] #1967: mode="copy" fails the second+ time around on win32, due to the directory sticking around. In-Reply-To: <038.3b750927173a9c90bf755ae6d9158961@buildbot.net> References: <038.3b750927173a9c90bf755ae6d9158961@buildbot.net> Message-ID: <053.640bffae0b9be68e7177e589133f9e7a@buildbot.net> #1967: mode="copy" fails the second+ time around on win32, due to the directory sticking around. --------------------+------------------------- Reporter: tfogal | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.+ Version: 0.8.3p1 | Resolution: worksforme Keywords: windows | --------------------+------------------------- Changes (by dustin): * status: new => closed * resolution: => worksforme -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Mar 11 00:30:24 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 11 Mar 2012 00:30:24 -0000 Subject: [Buildbot-commits] [Buildbot] #2019: graceful shutdown and triggered builds don't play as expected (0.8.4p1) In-Reply-To: <039.1df5e0ed3d0c636c0cfad3244068609f@buildbot.net> References: <039.1df5e0ed3d0c636c0cfad3244068609f@buildbot.net> Message-ID: <054.b7faa74370459fe46e5a0d4a981de2ab@buildbot.net> #2019: graceful shutdown and triggered builds don't play as expected (0.8.4p1) --------------------+-------------------- Reporter: dberger | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.4p1 | Resolution: Keywords: | --------------------+-------------------- Comment (by dustin): Actually, the fix for this is #1039 -- once that's in place, the triggering should be persistent, and can be picked up after restart. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Mar 11 00:31:04 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 11 Mar 2012 00:31:04 -0000 Subject: [Buildbot-commits] [Buildbot] #2050: Use metrics to start benchmarking Buildbot's performance in metabuildbot In-Reply-To: <038.c297aa9733e4a8fd3ee6bc2bdebf3725@buildbot.net> References: <038.c297aa9733e4a8fd3ee6bc2bdebf3725@buildbot.net> Message-ID: <053.82daf567721f2ee8712dc06dca60d78c@buildbot.net> #2050: Use metrics to start benchmarking Buildbot's performance in metabuildbot -------------------------------+-------------------- Reporter: dustin | Owner: Type: task | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.4p1 | Resolution: Keywords: performance, admin | -------------------------------+-------------------- Changes (by dustin): * keywords: performance => performance, admin -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Mar 11 00:31:50 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 11 Mar 2012 00:31:50 -0000 Subject: [Buildbot-commits] [Buildbot] #2073: buildbot is unable to delete subdirectories of the build dir that have non-ASCII names under Windows In-Reply-To: <042.e46ce6f3d9f38cabd09dcaa4bcf63163@buildbot.net> References: <042.e46ce6f3d9f38cabd09dcaa4bcf63163@buildbot.net> Message-ID: <057.b6275c16170f75c2a705501c9de0f66b@buildbot.net> #2073: buildbot is unable to delete subdirectories of the build dir that have non- ASCII names under Windows ------------------------------+------------------------- Reporter: davidsarah | Owner: davidsarah Type: defect | Status: accepted Priority: major | Milestone: 0.8.+ Version: 0.8.4p2 | Resolution: Keywords: encoding, windows | ------------------------------+------------------------- Comment (by dustin): Any progress here? -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Mar 11 00:35:02 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 11 Mar 2012 00:35:02 -0000 Subject: [Buildbot-commits] [Buildbot] #2077: DirectoryUpload creates missing directories with umode 077 In-Reply-To: <040.29904cf49ccbcea00440645b2bc68d50@buildbot.net> References: <040.29904cf49ccbcea00440645b2bc68d50@buildbot.net> Message-ID: <055.43a2a4b26dc63614a9ce86f5d4a816f8@buildbot.net> #2077: DirectoryUpload creates missing directories with umode 077 ------------------------+-------------------- Reporter: dtrosset | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.4p2 | Resolution: Keywords: sprint | ------------------------+-------------------- Changes (by dustin): * keywords: => sprint Comment: the mode option would be preferred (probably with a different default) -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Mar 11 00:35:55 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 11 Mar 2012 00:35:55 -0000 Subject: [Buildbot-commits] [Buildbot] #2103: merge schedulers table into objects table In-Reply-To: <038.b37253e89f25a5bf222cf1440f88a6a4@buildbot.net> References: <038.b37253e89f25a5bf222cf1440f88a6a4@buildbot.net> Message-ID: <053.4512e19ee9721712c169e36789b1ceb7@buildbot.net> #2103: merge schedulers table into objects table ------------------------+--------------------- Reporter: dustin | Owner: Type: enhancement | Status: closed Priority: major | Milestone: 0.8.+ Version: 0.8.4p2 | Resolution: fixed Keywords: database | ------------------------+--------------------- Changes (by dustin): * status: new => closed * resolution: => fixed Comment: Fixed: {{{ commit aa33b96aa03070a63490351dd0f0e232092965b0 Author: Dustin J. Mitchell Date: Sat Jan 14 00:13:34 2012 -0600 Simplify scheduler-related DB schema Schedulers identities are now tracked as objects, rather than with a distinct table -- so the 'schedulers' table is gone. The Dependent scheduler no longer has a dedicated table to keep track of upstream buildsets. This is handled with object state, instead. So the 'scheduler_upstream_buildsets' table is gone, too. }}} -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Mar 11 00:36:14 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 11 Mar 2012 00:36:14 -0000 Subject: [Buildbot-commits] [Buildbot] #2103: merge schedulers table into objects table In-Reply-To: <038.b37253e89f25a5bf222cf1440f88a6a4@buildbot.net> References: <038.b37253e89f25a5bf222cf1440f88a6a4@buildbot.net> Message-ID: <053.c04ccecc98c611568c8a02d296888b52@buildbot.net> #2103: merge schedulers table into objects table ------------------------+--------------------- Reporter: dustin | Owner: Type: enhancement | Status: closed Priority: major | Milestone: 0.8.6 Version: 0.8.4p2 | Resolution: fixed Keywords: database | ------------------------+--------------------- Changes (by dustin): * milestone: 0.8.+ => 0.8.6 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Mar 11 00:37:11 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 11 Mar 2012 00:37:11 -0000 Subject: [Buildbot-commits] [Buildbot] #2106: Buildbot requires pycrypto to setup even an unencrypted manhole In-Reply-To: <042.b881d87fc9ffff62fed02b40b1d6272b@buildbot.net> References: <042.b881d87fc9ffff62fed02b40b1d6272b@buildbot.net> Message-ID: <057.5b08bcaea6ba9b6143a2231298719442@buildbot.net> #2106: Buildbot requires pycrypto to setup even an unencrypted manhole -----------------------+-------------------- Reporter: jollyroger | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.4p2 | Resolution: Keywords: sprint | -----------------------+-------------------- Changes (by dustin): * keywords: => sprint -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Mar 11 00:38:28 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 11 Mar 2012 00:38:28 -0000 Subject: [Buildbot-commits] [Buildbot] #2129: Support unix domain sockets for build slaves. In-Reply-To: <042.5d0d5f84857cae42694c0568b95d07c2@buildbot.net> References: <042.5d0d5f84857cae42694c0568b95d07c2@buildbot.net> Message-ID: <057.7ac0cec92cb883e0ec493a00255a4f6f@buildbot.net> #2129: Support unix domain sockets for build slaves. ------------------------+-------------------- Reporter: simpletoon | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.5 | Resolution: Keywords: sprint | ------------------------+-------------------- Changes (by dustin): * keywords: => sprint -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Mar 11 00:39:05 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 11 Mar 2012 00:39:05 -0000 Subject: [Buildbot-commits] [Buildbot] #2138: ability to plug-in new slave-side commands In-Reply-To: <038.1ae0499b220d892beff33bf2becdf64d@buildbot.net> References: <038.1ae0499b220d892beff33bf2becdf64d@buildbot.net> Message-ID: <053.244dbb5508cb17faa075a88e249db675@buildbot.net> #2138: ability to plug-in new slave-side commands ------------------------+--------------------- Reporter: dustin | Owner: dustin Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.5 | Resolution: Keywords: docs | ------------------------+--------------------- Changes (by dustin): * keywords: => docs -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Mar 11 00:41:07 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 11 Mar 2012 00:41:07 -0000 Subject: [Buildbot-commits] [Buildbot] #2176: buildslave hangs trying to kill process after "1200 seconds without output" In-Reply-To: <036.b16b7bc9de52fc28c23a1d1e44d26fb4@buildbot.net> References: <036.b16b7bc9de52fc28c23a1d1e44d26fb4@buildbot.net> Message-ID: <051.fc57ddec0e09526c03613d2f323dfbcb@buildbot.net> #2176: buildslave hangs trying to kill process after "1200 seconds without output" ----------------------------------+-------------------- Reporter: hjwp | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.5 | Resolution: Keywords: windows, sprint, kill | ----------------------------------+-------------------- Changes (by dustin): * keywords: windows => windows, sprint, kill -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Mar 11 00:47:13 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 11 Mar 2012 00:47:13 -0000 Subject: [Buildbot-commits] [Buildbot] #2182: deprecate compatibility with Twisted-8.x.x after 0.8.6 In-Reply-To: <038.223490c7b83417680ae2cbf57b74b762@buildbot.net> References: <038.223490c7b83417680ae2cbf57b74b762@buildbot.net> Message-ID: <053.5b6ce49ae5d07eaba15d8b5c77364977@buildbot.net> #2182: deprecate compatibility with Twisted-8.x.x after 0.8.6 ------------------------+--------------------- Reporter: dustin | Owner: Type: enhancement | Status: closed Priority: major | Milestone: 0.8.+ Version: 0.8.5 | Resolution: fixed Keywords: | ------------------------+--------------------- Changes (by dustin): * status: new => closed * resolution: => fixed -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Mar 11 00:47:24 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 11 Mar 2012 00:47:24 -0000 Subject: [Buildbot-commits] [Buildbot] #2182: deprecate compatibility with Twisted-8.x.x after 0.8.6 In-Reply-To: <038.223490c7b83417680ae2cbf57b74b762@buildbot.net> References: <038.223490c7b83417680ae2cbf57b74b762@buildbot.net> Message-ID: <053.44523c48b7a0d3e072715bcae5f287a0@buildbot.net> #2182: deprecate compatibility with Twisted-8.x.x after 0.8.6 ------------------------+--------------------- Reporter: dustin | Owner: Type: enhancement | Status: closed Priority: major | Milestone: 0.8.6 Version: 0.8.5 | Resolution: fixed Keywords: | ------------------------+--------------------- Changes (by dustin): * milestone: 0.8.+ => 0.8.6 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Mar 11 00:48:07 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 11 Mar 2012 00:48:07 -0000 Subject: [Buildbot-commits] [Buildbot] #2203: svn copy method, timeout setting has no impact In-Reply-To: <035.6e064d864f152aafabd80460867793de@buildbot.net> References: <035.6e064d864f152aafabd80460867793de@buildbot.net> Message-ID: <050.a507b16ed54379672a3eb081ede43207@buildbot.net> #2203: svn copy method, timeout setting has no impact -------------------+-------------------- Reporter: doh | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.7 Version: 0.8.5 | Resolution: Keywords: | -------------------+-------------------- Changes (by dustin): * milestone: 0.8.+ => 0.8.7 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Mar 11 00:48:59 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 11 Mar 2012 00:48:59 -0000 Subject: [Buildbot-commits] [Buildbot] #2214: BuildStep's for multi-repo should include sourcebase in the names In-Reply-To: <042.390a8e63efa40f433cb326072e61e6cd@buildbot.net> References: <042.390a8e63efa40f433cb326072e61e6cd@buildbot.net> Message-ID: <057.548a21f9193f9095c60467bedd4aacb1@buildbot.net> #2214: BuildStep's for multi-repo should include sourcebase in the names ------------------------+-------------------- Reporter: jaredgrubb | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.7 Version: 0.8.5 | Resolution: Keywords: projrepo | ------------------------+-------------------- Changes (by dustin): * milestone: 0.8.+ => 0.8.7 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Mar 11 00:52:14 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 11 Mar 2012 00:52:14 -0000 Subject: [Buildbot-commits] [Buildbot] #2077: DirectoryUpload creates missing directories with umode 077 In-Reply-To: <040.29904cf49ccbcea00440645b2bc68d50@buildbot.net> References: <040.29904cf49ccbcea00440645b2bc68d50@buildbot.net> Message-ID: <055.f58ef129c2497bf394f173118ab9a860@buildbot.net> #2077: DirectoryUpload creates missing directories with umode 077 ------------------------+-------------------- Reporter: dtrosset | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.4p2 | Resolution: Keywords: sprint | ------------------------+-------------------- Comment (by dustin): The master will also grow a umask - see #2169. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Mar 11 00:57:17 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 11 Mar 2012 00:57:17 -0000 Subject: [Buildbot-commits] [Buildbot] #2073: buildbot is unable to delete subdirectories of the build dir that have non-ASCII names under Windows In-Reply-To: <042.e46ce6f3d9f38cabd09dcaa4bcf63163@buildbot.net> References: <042.e46ce6f3d9f38cabd09dcaa4bcf63163@buildbot.net> Message-ID: <057.6e95eb69d9e418176e276f4c62ef660d@buildbot.net> #2073: buildbot is unable to delete subdirectories of the build dir that have non- ASCII names under Windows ------------------------------+------------------------- Reporter: davidsarah | Owner: davidsarah Type: defect | Status: accepted Priority: major | Milestone: 0.8.+ Version: 0.8.4p2 | Resolution: Keywords: encoding, windows | ------------------------------+------------------------- Comment (by davidsarah): Sorry, this got pushed down my priority list when I got a new job. Will try to get to it in the next two weeks, unless someone else wants to take it over. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Mar 11 01:04:55 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 11 Mar 2012 01:04:55 -0000 Subject: [Buildbot-commits] [Buildbot] #219: 'stop builder' raises an exception In-Reply-To: <037.162a36aeb008ea4bff2c2635f8cc0bd9@buildbot.net> References: <037.162a36aeb008ea4bff2c2635f8cc0bd9@buildbot.net> Message-ID: <052.bfe74da79e936b4c35963bf3ac4fc671@buildbot.net> #219: 'stop builder' raises an exception -------------------+-------------------- Reporter: TTimo | Owner: Type: defect | Status: new Priority: minor | Milestone: 0.8.+ Version: 0.7.6 | Resolution: Keywords: locks | -------------------+-------------------- Changes (by dustin): * keywords: => locks -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Mar 11 01:06:25 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 11 Mar 2012 01:06:25 -0000 Subject: [Buildbot-commits] [Buildbot] #265: more detailed descriptions at the top of waterfall In-Reply-To: <037.370a81f796ba7a9201e9ed40f357f71b@buildbot.net> References: <037.370a81f796ba7a9201e9ed40f357f71b@buildbot.net> Message-ID: <052.a570dcc5b72c529a50f1c8dd083ec159@buildbot.net> #265: more detailed descriptions at the top of waterfall ------------------------+-------------------- Reporter: zooko | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.9.+ Version: 0.7.7 | Resolution: Keywords: web | ------------------------+-------------------- Changes (by dustin): * milestone: 0.8.+ => 0.9.+ -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Mar 11 01:11:49 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 11 Mar 2012 01:11:49 -0000 Subject: [Buildbot-commits] [Buildbot] #303: Error during svn update/checkout leaves bogus revision/branch in waterfall In-Reply-To: <039.3b3f9ef4b4fc20a73aa63fe66259cffa@buildbot.net> References: <039.3b3f9ef4b4fc20a73aa63fe66259cffa@buildbot.net> Message-ID: <054.bd85270a7453a01a62f87c174f87a951@buildbot.net> #303: Error during svn update/checkout leaves bogus revision/branch in waterfall --------------------+------------------------- Reporter: marcusl | Owner: Type: defect | Status: closed Priority: minor | Milestone: 0.8.+ Version: 0.7.7 | Resolution: worksforme Keywords: web | --------------------+------------------------- Changes (by dustin): * status: new => closed * resolution: => worksforme -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Mar 11 01:14:32 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 11 Mar 2012 01:14:32 -0000 Subject: [Buildbot-commits] [Buildbot] #2073: buildbot is unable to delete subdirectories of the build dir that have non-ASCII names under Windows In-Reply-To: <042.e46ce6f3d9f38cabd09dcaa4bcf63163@buildbot.net> References: <042.e46ce6f3d9f38cabd09dcaa4bcf63163@buildbot.net> Message-ID: <057.07b4756452c2da5ec65c96b9066ced8f@buildbot.net> #2073: buildbot is unable to delete subdirectories of the build dir that have non- ASCII names under Windows ------------------------------+------------------------- Reporter: davidsarah | Owner: davidsarah Type: defect | Status: accepted Priority: major | Milestone: 0.8.+ Version: 0.8.4p2 | Resolution: Keywords: encoding, windows | ------------------------------+------------------------- Comment (by dustin): I expect that it's all yours :) -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Mar 11 01:16:15 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 11 Mar 2012 01:16:15 -0000 Subject: [Buildbot-commits] [Buildbot] #339: inline logs in HTML Emails and capture errors in Compile In-Reply-To: <035.703840e8341f8372589deee485b8783c@buildbot.net> References: <035.703840e8341f8372589deee485b8783c@buildbot.net> Message-ID: <050.be938261eec438c4466b6f8db9bb529c@buildbot.net> #339: inline logs in HTML Emails and capture errors in Compile ------------------------+--------------------- Reporter: tzz | Owner: dustin Type: enhancement | Status: new Priority: minor | Milestone: 0.8.+ Version: 0.7.8 | Resolution: Keywords: mail | ------------------------+--------------------- Comment (by dustin): I've totally lost track of what's required here? -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Mar 11 01:21:23 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 11 Mar 2012 01:21:23 -0000 Subject: [Buildbot-commits] [Buildbot] #360: Pending builds part of Builder summary page doesn't include a build that waiting for a slave In-Reply-To: <042.f7ca56579ae5d0bebf6352c3462545b8@buildbot.net> References: <042.f7ca56579ae5d0bebf6352c3462545b8@buildbot.net> Message-ID: <057.9a50c36a91b8e5012b947af240d8a6fc@buildbot.net> #360: Pending builds part of Builder summary page doesn't include a build that waiting for a slave -----------------------+------------------------- Reporter: nhemingway | Owner: Type: defect | Status: closed Priority: minor | Milestone: 0.8.+ Version: 0.7.9 | Resolution: worksforme Keywords: | -----------------------+------------------------- Changes (by dustin): * status: new => closed * resolution: => worksforme Comment: At least now, builders don't start a build until there's a slave available -- and if that slave goes away at an inopportune time, the request should go back to unclaimed. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Mar 11 01:24:03 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 11 Mar 2012 01:24:03 -0000 Subject: [Buildbot-commits] [Buildbot] #422: [PATCH] Status reporting to twitter In-Reply-To: <038.aa5cc57b1d996bdff4e26a56fa3647f7@buildbot.net> References: <038.aa5cc57b1d996bdff4e26a56fa3647f7@buildbot.net> Message-ID: <053.0517b9273f80001732574fad77217903@buildbot.net> #422: [PATCH] Status reporting to twitter ------------------------+---------------------- Reporter: marijn | Owner: Type: enhancement | Status: closed Priority: minor | Milestone: 0.8.+ Version: 0.7.9 | Resolution: wontfix Keywords: | ------------------------+---------------------- Changes (by dustin): * status: new => closed * resolution: => wontfix Comment: Re-open this if there's interest -- take wontfix to mean "won't-merge- like-this" -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Mar 11 01:24:11 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 11 Mar 2012 01:24:11 -0000 Subject: [Buildbot-commits] [Buildbot] #2214: BuildStep's for multi-repo should include sourcebase in the names In-Reply-To: <042.390a8e63efa40f433cb326072e61e6cd@buildbot.net> References: <042.390a8e63efa40f433cb326072e61e6cd@buildbot.net> Message-ID: <057.f62f3cbc3f27012d51da8ec9cf6c5862@buildbot.net> #2214: BuildStep's for multi-repo should include sourcebase in the names ------------------------+-------------------- Reporter: jaredgrubb | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.7 Version: 0.8.5 | Resolution: Keywords: projrepo | ------------------------+-------------------- Comment (by jaredgrubb): My current suggestion is that every BuildStep should take a sourcestamp parameter to indicate what it applies to, and the Status classes (like MailNotifier or Waterfall) should mix that in somehow. What do you think? -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Mar 11 01:25:25 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 11 Mar 2012 01:25:25 -0000 Subject: [Buildbot-commits] [Buildbot] #530: ability to log into slaves from the master In-Reply-To: <040.0f5a7da6f6e3666f9df893567b3cee4c@buildbot.net> References: <040.0f5a7da6f6e3666f9df893567b3cee4c@buildbot.net> Message-ID: <055.1cb5e32ac6c5bc6f87e599b5a8d4a1c4@buildbot.net> #530: ability to log into slaves from the master ------------------------+--------------------- Reporter: ipv6guru | Owner: Type: enhancement | Status: closed Priority: minor | Milestone: 0.8.+ Version: 0.7.10 | Resolution: fixed Keywords: | ------------------------+--------------------- Changes (by dustin): * status: new => closed * resolution: => fixed Comment: catlee actually provided a means to do this in contrib/fakemaster.py: {{{ commit e1b3b9f79672bf35ecf8fd2e21dc24856618c219 Author: Chris AtLee Date: Thu Jan 12 10:46:13 2012 -0500 Add fakemaster.py script to contrib fakemaster allows you to enter commands via stdin to a connected buildslave. }}} -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Mar 11 01:58:56 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 11 Mar 2012 01:58:56 -0000 Subject: [Buildbot-commits] [Buildbot] #2214: BuildStep's for multi-repo should include sourcebase in the names In-Reply-To: <042.390a8e63efa40f433cb326072e61e6cd@buildbot.net> References: <042.390a8e63efa40f433cb326072e61e6cd@buildbot.net> Message-ID: <057.9f08d3fab5f7e9b442ffbd2f6f488982@buildbot.net> #2214: BuildStep's for multi-repo should include sourcebase in the names ------------------------+-------------------- Reporter: jaredgrubb | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.7 Version: 0.8.5 | Resolution: Keywords: projrepo | ------------------------+-------------------- Comment (by dustin): I think that source steps' default names (and descriptions) should include the codebase. However, I don't think that other steps should try to do this automatically. If users want to set these, they can set an explicit `name=`. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Mar 11 02:00:45 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 11 Mar 2012 02:00:45 -0000 Subject: [Buildbot-commits] [Buildbot] #595: RFE: Allow FileDownload from arbitrary file object In-Reply-To: <039.f1b505a045c08c0d3c482804d19e43ef@buildbot.net> References: <039.f1b505a045c08c0d3c482804d19e43ef@buildbot.net> Message-ID: <054.eda926ccf04c8a7a710d915f3096b1b4@buildbot.net> #595: RFE: Allow FileDownload from arbitrary file object ------------------------+-------------------- Reporter: ddunbar | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.+ Version: 0.7.11 | Resolution: Keywords: sprint | ------------------------+-------------------- Changes (by dustin): * keywords: => sprint Comment: Mozilla has some similar steps in http://hg.mozilla.org/build/buildbotcustom/file/23c3f3c91571/steps/transfer.py I wouldn't have a big problem with merging these, if someone is interested in writing up tests and docs and putting a patch together. Of course, please keep proper attribution. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Mar 11 02:01:04 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 11 Mar 2012 02:01:04 -0000 Subject: [Buildbot-commits] [Buildbot] #605: Unable to figure out how to get /grid to use a different CSS file than buildbot.css In-Reply-To: <035.21c8aa99a6f036efa3e17e35fc3b8288@buildbot.net> References: <035.21c8aa99a6f036efa3e17e35fc3b8288@buildbot.net> Message-ID: <050.87a64204859c23b6be596fc00e4d86d2@buildbot.net> #605: Unable to figure out how to get /grid to use a different CSS file than buildbot.css -------------------+------------------------- Reporter: dre | Owner: Type: defect | Status: closed Priority: minor | Milestone: 0.8.+ Version: 0.7.11 | Resolution: worksforme Keywords: web | -------------------+------------------------- Changes (by dustin): * status: new => closed * resolution: => worksforme -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Mar 11 02:01:37 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 11 Mar 2012 02:01:37 -0000 Subject: [Buildbot-commits] [Buildbot] #659: Add bytecode cache for jinja In-Reply-To: <039.e6068e1b99acc35d382628804c42dcb6@buildbot.net> References: <039.e6068e1b99acc35d382628804c42dcb6@buildbot.net> Message-ID: <054.953627409798944a42d9b0fc531d17e0@buildbot.net> #659: Add bytecode cache for jinja --------------------+------------------------- Reporter: marcusl | Owner: Type: task | Status: closed Priority: minor | Milestone: 0.8.+ Version: 0.7.11 | Resolution: worksforme Keywords: web | --------------------+------------------------- Changes (by dustin): * status: new => closed * resolution: => worksforme -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Mar 11 02:18:58 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 11 Mar 2012 02:18:58 -0000 Subject: [Buildbot-commits] [Buildbot] #2214: BuildStep's for multi-repo should include sourcebase in the names In-Reply-To: <042.390a8e63efa40f433cb326072e61e6cd@buildbot.net> References: <042.390a8e63efa40f433cb326072e61e6cd@buildbot.net> Message-ID: <057.afb38dfb80bac807ca032896b5b63822@buildbot.net> #2214: BuildStep's for multi-repo should include sourcebase in the names ------------------------+-------------------- Reporter: jaredgrubb | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.7 Version: 0.8.5 | Resolution: Keywords: projrepo | ------------------------+-------------------- Comment (by jaredgrubb): I should have said "a BuildStep ''can'' take a codebase" rather than ''should''... I've experimented with this a bit, and here's my observations: * adding it to the name is annoying because you often want the original name of the step as well ... so your steps look like Build(name="build Foo"), Git(name="git Foo"), etc. You have to repeat yourself or do something very verbose like Git(name=Git.name+" Foo") which is weird. * adding it to the name works well with the Build Status page ("__git Foo__") * adding it to the description makes the waterfall work nicely ("building Foo", "updating Bar") * but adding to *both* name and waterfall makes the Build Status page noisy (you end up with "__Git Foo:__ ''building Foo''") -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Mar 11 03:44:58 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 11 Mar 2012 03:44:58 -0000 Subject: [Buildbot-commits] [Buildbot] #2236: Experiment with loading config in a "rollback importer" In-Reply-To: <038.5fd44b61ce46772e2877b318a8727941@buildbot.net> References: <038.5fd44b61ce46772e2877b318a8727941@buildbot.net> Message-ID: <053.787e6d399f65a3c39d39e549248a9451@buildbot.net> #2236: Experiment with loading config in a "rollback importer" ------------------------+-------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.5 | Resolution: Keywords: reconfig | ------------------------+-------------------- Comment (by jaredgrubb): Really cool. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Mar 11 07:08:10 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 11 Mar 2012 07:08:10 -0000 Subject: [Buildbot-commits] [Buildbot] #2214: BuildStep's for multi-repo should include sourcebase in the names In-Reply-To: <042.390a8e63efa40f433cb326072e61e6cd@buildbot.net> References: <042.390a8e63efa40f433cb326072e61e6cd@buildbot.net> Message-ID: <057.803bfeef1f2cf7298b11ba18efee1107@buildbot.net> #2214: BuildStep's for multi-repo should include sourcebase in the names ------------------------+-------------------- Reporter: jaredgrubb | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.7 Version: 0.8.5 | Resolution: Keywords: projrepo | ------------------------+-------------------- Comment (by dustin): I think we're talking past one another, so perhaps it's time to be explicit with code? -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Mar 11 07:19:05 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 11 Mar 2012 07:19:05 -0000 Subject: [Buildbot-commits] [Buildbot] #1802: send SIGTERM before SIGKILL In-Reply-To: <038.512ed97667fb96d4260afa3530716da1@buildbot.net> References: <038.512ed97667fb96d4260afa3530716da1@buildbot.net> Message-ID: <053.f6ac8f3a3e02488998584f0097010388@buildbot.net> #1802: send SIGTERM before SIGKILL ------------------------+------------------------ Reporter: dustin | Owner: Type: enhancement | Status: closed Priority: major | Milestone: 0.8.+ Version: 0.8.3p1 | Resolution: duplicate Keywords: kill | ------------------------+------------------------ Changes (by dustin): * status: new => closed * resolution: => duplicate Comment: dup #751 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Mar 11 07:27:25 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 11 Mar 2012 07:27:25 -0000 Subject: [Buildbot-commits] [Buildbot] #831: Need a means to set keepaliveTimeout on slaves In-Reply-To: <038.66dcb64b0a58b4344ed89616430b6178@buildbot.net> References: <038.66dcb64b0a58b4344ed89616430b6178@buildbot.net> Message-ID: <053.72dcf45526ae6657ff2843597c0e17e0@buildbot.net> #831: Need a means to set keepaliveTimeout on slaves ------------------------+--------------------- Reporter: dustin | Owner: Type: enhancement | Status: closed Priority: minor | Milestone: 0.8.+ Version: 0.7.12 | Resolution: fixed Keywords: | ------------------------+--------------------- Changes (by dustin): * status: new => closed * resolution: => fixed Comment: This is no longer an issue: failing if you don't hear a response to a keepalive is wrong; rather, the keepalive is just to keep the connection alive and detect a dead connection via socket errors so that it can be destroyed and re-tried. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Mar 11 07:30:00 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 11 Mar 2012 07:30:00 -0000 Subject: [Buildbot-commits] [Buildbot] #839: shell.Compile should invoke platform-specific compilation method In-Reply-To: <038.bd598c9fda07a205c5a07dc577dd7695@buildbot.net> References: <038.bd598c9fda07a205c5a07dc577dd7695@buildbot.net> Message-ID: <053.239aee2f963d0049bc5f3f318af61994@buildbot.net> #839: shell.Compile should invoke platform-specific compilation method ------------------------+-------------------- Reporter: tfogal | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.+ Version: 0.8.0 | Resolution: Keywords: sprint | ------------------------+-------------------- Changes (by dustin): * keywords: => sprint Comment: Now that we have more info about the slave available master-side, it may be interesting to re-visit this in a more generic form. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Mar 11 07:32:07 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 11 Mar 2012 07:32:07 -0000 Subject: [Buildbot-commits] [Buildbot] #896: Try should capture and send e-mail address of the submitter so that notifications can be sent In-Reply-To: <039.dd16e9ce5631939f93c8f0c0bcaebc2b@buildbot.net> References: <039.dd16e9ce5631939f93c8f0c0bcaebc2b@buildbot.net> Message-ID: <054.77402c415393e835c904465826781f0b@buildbot.net> #896: Try should capture and send e-mail address of the submitter so that notifications can be sent ------------------------+-------------------- Reporter: marcusl | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.+ Version: 0.8.0 | Resolution: Keywords: try, users | ------------------------+-------------------- Changes (by dustin): * keywords: try => try, users -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Mar 11 07:35:26 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 11 Mar 2012 07:35:26 -0000 Subject: [Buildbot-commits] [Buildbot] #978: Changes should have multiple users In-Reply-To: <041.98f857cbb54e3c6c85643e2bff7f4435@buildbot.net> References: <041.98f857cbb54e3c6c85643e2bff7f4435@buildbot.net> Message-ID: <056.a99206a19ceb73abb96c4f0d04cb1ec9@buildbot.net> #978: Changes should have multiple users -----------------------+-------------------- Reporter: dabrahams | Owner: Type: defect | Status: new Priority: minor | Milestone: 0.8.+ Version: 0.8.1 | Resolution: Keywords: git, users | -----------------------+-------------------- Changes (by dustin): * keywords: git => git, users -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Mar 11 07:36:44 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 11 Mar 2012 07:36:44 -0000 Subject: [Buildbot-commits] [Buildbot] #980: Status display that lists just running builds In-Reply-To: <038.4b6c2bc55b8c247dc337e4171a2804c3@buildbot.net> References: <038.4b6c2bc55b8c247dc337e4171a2804c3@buildbot.net> Message-ID: <053.410e927dc63e70ecc16ba67909e84511@buildbot.net> #980: Status display that lists just running builds ------------------------+-------------------- Reporter: catlee | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.9.+ Version: 0.8.1 | Resolution: Keywords: web | ------------------------+-------------------- Changes (by dustin): * milestone: 0.8.+ => 0.9.+ -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Mar 11 07:37:22 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 11 Mar 2012 07:37:22 -0000 Subject: [Buildbot-commits] [Buildbot] #987: Missing command line for visual studio /clean In-Reply-To: <040.6df45e4f3a10e66654c8ced4b0556c37@buildbot.net> References: <040.6df45e4f3a10e66654c8ced4b0556c37@buildbot.net> Message-ID: <055.c7cceeadb37686f873655d89b2924cc0@buildbot.net> #987: Missing command line for visual studio /clean ------------------------+----------------------- Reporter: JDelfour | Owner: dustin Type: enhancement | Status: accepted Priority: minor | Milestone: 0.8.+ Version: 0.8.1 | Resolution: Keywords: windows | ------------------------+----------------------- Changes (by dustin): * cc: callek (added) * owner: => dustin * status: new => accepted -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Mar 11 07:38:09 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 11 Mar 2012 07:38:09 -0000 Subject: [Buildbot-commits] [Buildbot] #993: Expose category information in a structured way In-Reply-To: <039.a16577ab29ca293becee127a21c51f09@buildbot.net> References: <039.a16577ab29ca293becee127a21c51f09@buildbot.net> Message-ID: <054.797ec6c58cbeb8c7e24861d3eb0d82e3@buildbot.net> #993: Expose category information in a structured way ------------------------+-------------------- Reporter: exarkun | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.9.0 Version: 0.8.1 | Resolution: Keywords: | ------------------------+-------------------- Changes (by dustin): * milestone: 0.8.+ => 0.9.0 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Mar 11 07:40:06 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 11 Mar 2012 07:40:06 -0000 Subject: [Buildbot-commits] [Buildbot] #1004: comprehensive handling of build artifacts (was: provide consistent url access to build-uploaded files on master) In-Reply-To: <037.844d5680ff8660081b550315a57c2194@buildbot.net> References: <037.844d5680ff8660081b550315a57c2194@buildbot.net> Message-ID: <052.20819eb33e2b5ba91a966242132103c8@buildbot.net> #1004: comprehensive handling of build artifacts ------------------------+-------------------- Reporter: ayust | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 1.0.+ Version: master | Resolution: Keywords: | ------------------------+-------------------- Changes (by dustin): * milestone: 0.8.+ => 1.0.+ Comment: I'm going to broaden this out to represent something that has been talked about for a while, but never worked on. Most of the proposals have revolved around an "artifact server" which could be separate from the master, and which could both accept files from slaves and serve those files to other clients - slaves or users. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Mar 11 07:41:46 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 11 Mar 2012 07:41:46 -0000 Subject: [Buildbot-commits] [Buildbot] #1703: Use a shorter timeout for old slave disconnection (perhaps based on configuration) In-Reply-To: <039.7e16ba417216f6a0b728cbcfebbff56e@buildbot.net> References: <039.7e16ba417216f6a0b728cbcfebbff56e@buildbot.net> Message-ID: <054.ae4297c0d963dea4fcf840e4229c849f@buildbot.net> #1703: Use a shorter timeout for old slave disconnection (perhaps based on configuration) ------------------------+-------------------- Reporter: exarkun | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.+ Version: 0.8.2 | Resolution: Keywords: | ------------------------+-------------------- Comment (by dustin): ..or, is there a way to tune TCP's timeouts on a per-socket basis? -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Mar 11 07:52:53 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 11 Mar 2012 07:52:53 -0000 Subject: [Buildbot-commits] [Buildbot] #1706: Metrics framework In-Reply-To: <038.7386d5f0d91ede4bd6dbe71e37ef9d96@buildbot.net> References: <038.7386d5f0d91ede4bd6dbe71e37ef9d96@buildbot.net> Message-ID: <053.b393aab2fd0a88722e75e722b63d3af1@buildbot.net> #1706: Metrics framework ------------------------+--------------------- Reporter: catlee | Owner: catlee Type: enhancement | Status: closed Priority: minor | Milestone: 0.8.+ Version: 0.8.2 | Resolution: fixed Keywords: | ------------------------+--------------------- Changes (by dustin): * status: new => closed * resolution: => fixed Comment: dup #1945 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Mar 11 07:55:35 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 11 Mar 2012 07:55:35 -0000 Subject: [Buildbot-commits] [Buildbot] #2237: Schedulers should have names and reconfigService methods Message-ID: <038.ea3c9e9516640ac3c188109e2069c7a7@buildbot.net> #2237: Schedulers should have names and reconfigService methods ------------------------+-------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.7 Version: 0.8.5 | Keywords: github ------------------------+-------------------- Rather than using comparableMixin to try to figure out if schedulers are "the same", Buildbot should use scheduler names. And the schedulers which remain present before and after a reconfig should get `reconfigService` called to look at any config changes. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Mar 11 07:56:35 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 11 Mar 2012 07:56:35 -0000 Subject: [Buildbot-commits] [Buildbot] #1734: buildbot should raise a warning if a scheduler in c['schedulers'] doesn't actually get added In-Reply-To: <038.7a5d8eb72f2708e5c53dd50abc2f2f76@buildbot.net> References: <038.7a5d8eb72f2708e5c53dd50abc2f2f76@buildbot.net> Message-ID: <053.be4bf8647abe7f227b65d98c74d7f188@buildbot.net> #1734: buildbot should raise a warning if a scheduler in c['schedulers'] doesn't actually get added -------------------+---------------------- Reporter: catlee | Owner: Type: defect | Status: closed Priority: minor | Milestone: 0.8.+ Version: 0.8.2 | Resolution: wontfix Keywords: simple | -------------------+---------------------- Changes (by dustin): * status: new => closed * resolution: => wontfix Comment: Actually, #2237 is the better solution here. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Mar 11 07:59:25 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 11 Mar 2012 07:59:25 -0000 Subject: [Buildbot-commits] [Buildbot] #1738: Properties: "category" property is missing from Build properties In-Reply-To: <043.f64838526d69c05c8d221730a5d4a65d@buildbot.net> References: <043.f64838526d69c05c8d221730a5d4a65d@buildbot.net> Message-ID: <058.98789cb1ab9caf2a94b716aa258a7d29@buildbot.net> #1738: Properties: "category" property is missing from Build properties ------------------------+---------------------- Reporter: PiotrSikora | Owner: Type: enhancement | Status: closed Priority: minor | Milestone: 0.8.+ Version: 0.8.2 | Resolution: invalid Keywords: | ------------------------+---------------------- Changes (by dustin): * status: new => closed * resolution: => invalid Comment: ..and now with multirepo we may have multiple changes from multiple codebases! -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Mar 11 08:00:58 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 11 Mar 2012 08:00:58 -0000 Subject: [Buildbot-commits] [Buildbot] #786: Should be able to Obfuscate parameters in master configs In-Reply-To: <038.7f9b622321dcde36cc7a41f1e0c83922@buildbot.net> References: <038.7f9b622321dcde36cc7a41f1e0c83922@buildbot.net> Message-ID: <053.8288482396d7477f9a0ed2474beb5f96@buildbot.net> #786: Should be able to Obfuscate parameters in master configs ------------------------+------------------------ Reporter: catlee | Owner: Type: enhancement | Status: closed Priority: minor | Milestone: 0.8.+ Version: 0.7.12 | Resolution: duplicate Keywords: | ------------------------+------------------------ Changes (by dustin): * status: new => closed * resolution: => duplicate Comment: dup #1748 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Mar 11 08:04:03 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 11 Mar 2012 08:04:03 -0000 Subject: [Buildbot-commits] [Buildbot] #1766: Can't pass extra arguments to SVNPoller In-Reply-To: <037.dc3f52f4b0f33e7254c85d2b5e27a3a5@buildbot.net> References: <037.dc3f52f4b0f33e7254c85d2b5e27a3a5@buildbot.net> Message-ID: <052.ac5b5a46af1b80b72371b69ba517ea5d@buildbot.net> #1766: Can't pass extra arguments to SVNPoller ------------------------+-------------------- Reporter: fgsch | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.+ Version: 0.8.3p1 | Resolution: Keywords: svn, sprint | ------------------------+-------------------- Changes (by dustin): * keywords: svn => svn, sprint Comment: The latter isn't the case anymore, with master-side steps, so code-sharing is an option. Still, this shouldn't be particularly difficult. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Mar 11 08:06:13 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 11 Mar 2012 08:06:13 -0000 Subject: [Buildbot-commits] [Buildbot] #1826: Periodic scheduler should not necessarily run at master startup In-Reply-To: <038.b1d9295a21989a6d1befac025c8a21e0@buildbot.net> References: <038.b1d9295a21989a6d1befac025c8a21e0@buildbot.net> Message-ID: <053.fb5399e162e030b596e74ae851147e6f@buildbot.net> #1826: Periodic scheduler should not necessarily run at master startup ------------------------+-------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.+ Version: master | Resolution: Keywords: sprint | ------------------------+-------------------- Changes (by dustin): * keywords: => sprint -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Mar 11 08:07:09 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 11 Mar 2012 08:07:09 -0000 Subject: [Buildbot-commits] [Buildbot] #1848: Cookies to remember web usernames In-Reply-To: <041.c7ad4e6001681bf1a08277684316ffbb@buildbot.net> References: <041.c7ad4e6001681bf1a08277684316ffbb@buildbot.net> Message-ID: <056.12d48b384f2615167a77a88f451e7608@buildbot.net> #1848: Cookies to remember web usernames ------------------------+--------------------- Reporter: dabrahams | Owner: Type: enhancement | Status: closed Priority: minor | Milestone: 0.8.+ Version: 0.8.3p1 | Resolution: fixed Keywords: web | ------------------------+--------------------- Changes (by dustin): * status: new => closed * resolution: => fixed Comment: Cookies have landed, actually! -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Mar 11 08:08:05 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 11 Mar 2012 08:08:05 -0000 Subject: [Buildbot-commits] [Buildbot] #1868: Support for Dummy slaves and/or Builders that don't require slaves In-Reply-To: <038.760e4461d05bed406fe50982bba74537@buildbot.net> References: <038.760e4461d05bed406fe50982bba74537@buildbot.net> Message-ID: <053.e9b89b0895a702b0ecda4a494e5e8005@buildbot.net> #1868: Support for Dummy slaves and/or Builders that don't require slaves ------------------------+-------------------- Reporter: catlee | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.+ Version: 0.8.3p1 | Resolution: Keywords: | ------------------------+-------------------- Comment (by dustin): I think that this should end up being implemented as a build that just doesn't require a slave, and the build request distributor should handle that appropriately. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Mar 11 08:09:14 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 11 Mar 2012 08:09:14 -0000 Subject: [Buildbot-commits] [Buildbot] #1926: GET requests on target URLs of POST forms should be refused In-Reply-To: <038.b71206413f158ff9f352fac93471a431@buildbot.net> References: <038.b71206413f158ff9f352fac93471a431@buildbot.net> Message-ID: <053.8202db3c74d538e8264f591a59124ef3@buildbot.net> #1926: GET requests on target URLs of POST forms should be refused ------------------------+-------------------- Reporter: pitrou | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.9.0 Version: 0.8.3 | Resolution: Keywords: web | ------------------------+-------------------- Changes (by dustin): * milestone: 0.8.+ => 0.9.0 Comment: This is quite a good idea, in fact. In general, we should be sure that URLs are careful about which verbs they respond to. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Mar 11 08:13:00 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 11 Mar 2012 08:13:00 -0000 Subject: [Buildbot-commits] [Buildbot] #789: Source stamp filtering, sorting, and clustering in web views In-Reply-To: <039.e54bab987922e2f005f08fb8c265248d@buildbot.net> References: <039.e54bab987922e2f005f08fb8c265248d@buildbot.net> Message-ID: <054.2aa08921a13f9543a41240e6187e9315@buildbot.net> #789: Source stamp filtering, sorting, and clustering in web views ---------------------+-------------------- Reporter: marcusl | Owner: Type: task | Status: new Priority: critical | Milestone: 0.9.+ Version: 0.8.0 | Resolution: Keywords: web | ---------------------+-------------------- Comment (by dustin): Today, in hearing about !TastyPie, I learned that Django has a rather extensive set of filtering primitives which can be reflected in a REST API. We should try to replicate those. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Mar 11 08:15:07 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 11 Mar 2012 08:15:07 -0000 Subject: [Buildbot-commits] [Buildbot] #1053: schedulerdb should have id columns on all tables In-Reply-To: <036.4ff7f269375e4aa2c6c44266d369e161@buildbot.net> References: <036.4ff7f269375e4aa2c6c44266d369e161@buildbot.net> Message-ID: <051.d8bd956bde9d066b90a86f111a70cf17@buildbot.net> #1053: schedulerdb should have id columns on all tables -----------------------------+-------------------- Reporter: Pike | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.7 Version: 0.8.2 | Resolution: Keywords: database, sprint | -----------------------------+-------------------- Changes (by dustin): * keywords: database => database, sprint -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Mar 11 08:17:02 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 11 Mar 2012 08:17:02 -0000 Subject: [Buildbot-commits] [Buildbot] #1848: Cookies to remember web usernames In-Reply-To: <041.c7ad4e6001681bf1a08277684316ffbb@buildbot.net> References: <041.c7ad4e6001681bf1a08277684316ffbb@buildbot.net> Message-ID: <056.e4fd75e31088ef7c0e7aaf5fc2465388@buildbot.net> #1848: Cookies to remember web usernames ------------------------+----------------------- Reporter: dabrahams | Owner: Type: enhancement | Status: reopened Priority: minor | Milestone: 0.8.+ Version: 0.8.3p1 | Resolution: Keywords: web | ------------------------+----------------------- Changes (by tom.prince): * status: closed => reopened * resolution: fixed => Comment: There still is a way to specify who you are if authentication isn't enabled. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Mar 11 08:17:27 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 11 Mar 2012 08:17:27 -0000 Subject: [Buildbot-commits] [Buildbot] #1703: Use a shorter timeout for old slave disconnection (perhaps based on configuration) In-Reply-To: <039.7e16ba417216f6a0b728cbcfebbff56e@buildbot.net> References: <039.7e16ba417216f6a0b728cbcfebbff56e@buildbot.net> Message-ID: <054.566d86d15e6f940f54149875e7cf4b68@buildbot.net> #1703: Use a shorter timeout for old slave disconnection (perhaps based on configuration) ------------------------+-------------------- Reporter: exarkun | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.+ Version: 0.8.2 | Resolution: Keywords: | ------------------------+-------------------- Comment (by tom.prince): On the other hand, improving the bulk data protocol, so that large payloads don't hold up the connection. The attached patch is untested codce that purports to do that. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Mar 11 08:17:47 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 11 Mar 2012 08:17:47 -0000 Subject: [Buildbot-commits] [Buildbot] #2188: status targets are replaced, even if their configuration is unchanged. In-Reply-To: <042.92a01be8422aa1bf756415ec9d9859ef@buildbot.net> References: <042.92a01be8422aa1bf756415ec9d9859ef@buildbot.net> Message-ID: <057.89ccdc3508cbf83be34dd0ea5b4548a0@buildbot.net> #2188: status targets are replaced, even if their configuration is unchanged. ------------------------+-------------------- Reporter: tom.prince | Owner: Type: enhancement | Status: new Priority: trivial | Milestone: 0.8.7 Version: master | Resolution: Keywords: reconfig | ------------------------+-------------------- Changes (by dustin): * keywords: => reconfig * milestone: 0.8.+ => 0.8.7 Comment: Let's give status targets names! -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Mar 11 08:19:34 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 11 Mar 2012 08:19:34 -0000 Subject: [Buildbot-commits] [Buildbot] #2237: Schedulers should have names and reconfigService methods In-Reply-To: <038.ea3c9e9516640ac3c188109e2069c7a7@buildbot.net> References: <038.ea3c9e9516640ac3c188109e2069c7a7@buildbot.net> Message-ID: <053.92e28ea1d531593444bc469bd6bb3b69@buildbot.net> #2237: Schedulers should have names and reconfigService methods ------------------------+-------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.7 Version: 0.8.5 | Resolution: Keywords: reconfig | ------------------------+-------------------- Changes (by dustin): * keywords: github => reconfig -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Mar 11 15:46:49 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 11 Mar 2012 15:46:49 -0000 Subject: [Buildbot-commits] [Buildbot] #2048: Also adding 'committer' to interested users for MailNotifier In-Reply-To: <036.ddab455e872e0cf7c0f4c1546cd25fe3@buildbot.net> References: <036.ddab455e872e0cf7c0f4c1546cd25fe3@buildbot.net> Message-ID: <051.b697809c31d188998ea94d5301a7901d@buildbot.net> #2048: Also adding 'committer' to interested users for MailNotifier ------------------------+-------------------- Reporter: deng | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.+ Version: 0.8.4p1 | Resolution: Keywords: users | ------------------------+-------------------- Changes (by dustin): * keywords: => users -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Mar 11 15:50:59 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 11 Mar 2012 15:50:59 -0000 Subject: [Buildbot-commits] [Buildbot] #2074: Support using a list for svnurl in source.SVN In-Reply-To: <037.5ea86d882977582b5969339bcfb63b09@buildbot.net> References: <037.5ea86d882977582b5969339bcfb63b09@buildbot.net> Message-ID: <052.489bfb14f26835d3fc9ee370948913ba@buildbot.net> #2074: Support using a list for svnurl in source.SVN ------------------------+-------------------- Reporter: jonny | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.+ Version: 0.8.4p2 | Resolution: Keywords: svn | ------------------------+-------------------- Comment (by dustin): I think that the new multirepo support may help - you would just run multiple SVN steps. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Mar 11 15:58:22 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 11 Mar 2012 15:58:22 -0000 Subject: [Buildbot-commits] [Buildbot] #1703: Use a shorter timeout for old slave disconnection (perhaps based on configuration) In-Reply-To: <039.7e16ba417216f6a0b728cbcfebbff56e@buildbot.net> References: <039.7e16ba417216f6a0b728cbcfebbff56e@buildbot.net> Message-ID: <054.e10692433e5bd9e1df5cf0360d872e43@buildbot.net> #1703: Use a shorter timeout for old slave disconnection (perhaps based on configuration) ------------------------+-------------------- Reporter: exarkun | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.+ Version: 0.8.2 | Resolution: Keywords: | ------------------------+-------------------- Comment (by dustin): There are lots of other reasons for this timeout to find itself invoked -- stateful firewalls being one possibility. Using Twisted's producer/consumer model would be a good fix all the same! -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Mar 11 16:41:41 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 11 Mar 2012 16:41:41 -0000 Subject: [Buildbot-commits] [Buildbot] #2137: Store cached slave information in db In-Reply-To: <038.f26f9ab318df9cac4be74655285c5715@buildbot.net> References: <038.f26f9ab318df9cac4be74655285c5715@buildbot.net> Message-ID: <053.df91464289b35d294460bf59fe23147f@buildbot.net> #2137: Store cached slave information in db -----------------------------+-------------------- Reporter: tfogal | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.9.+ Version: 0.8.5 | Resolution: Keywords: simple, database | -----------------------------+-------------------- Changes (by dustin): * keywords: simple => simple, database * milestone: 0.8.+ => 0.9.+ Comment: I think we'll end up adding a slaves table eventually (to get slave id's and stop replicating the slave name everywhere), which would be a good place to drop this info. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Mar 11 16:43:20 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 11 Mar 2012 16:43:20 -0000 Subject: [Buildbot-commits] [Buildbot] #2154: Master-side git source step breaks revision+shallow In-Reply-To: <036.86713fb284eb4264cef6d32314567f45@buildbot.net> References: <036.86713fb284eb4264cef6d32314567f45@buildbot.net> Message-ID: <051.7983ca1b1135e9904521a056167f4aed@buildbot.net> #2154: Master-side git source step breaks revision+shallow ------------------------------------------+-------------------- Reporter: Tobi | Owner: Type: defect | Status: new Priority: minor | Milestone: 0.8.+ Version: master | Resolution: Keywords: git, master-side-source-steps | ------------------------------------------+-------------------- Changes (by dustin): * keywords: git => git, master-side-source-steps -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Mar 11 16:44:08 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 11 Mar 2012 16:44:08 -0000 Subject: [Buildbot-commits] [Buildbot] #2165: Support ternary substitution in WithProperties In-Reply-To: <042.4b2c171050850b3d9c3b20a504de0f02@buildbot.net> References: <042.4b2c171050850b3d9c3b20a504de0f02@buildbot.net> Message-ID: <057.0b9eb3f4c6c69e114250e169f20519bb@buildbot.net> #2165: Support ternary substitution in WithProperties ------------------------+-------------------- Reporter: jaredgrubb | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.+ Version: 0.8.5 | Resolution: Keywords: sprint | ------------------------+-------------------- Changes (by dustin): * keywords: => sprint -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Mar 11 16:44:47 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 11 Mar 2012 16:44:47 -0000 Subject: [Buildbot-commits] [Buildbot] #2169: make umask on master configurable In-Reply-To: <040.3502b75d5f281edc33ea0d30f68e0617@buildbot.net> References: <040.3502b75d5f281edc33ea0d30f68e0617@buildbot.net> Message-ID: <055.71cd4551d29f655d3f73353d53e20e6a@buildbot.net> #2169: make umask on master configurable ---------------------------+-------------------- Reporter: mverwijs | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.+ Version: 0.8.5 | Resolution: Keywords: simple, sprint | ---------------------------+-------------------- Changes (by dustin): * keywords: simple => simple, sprint -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Mar 11 16:53:12 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 11 Mar 2012 16:53:12 -0000 Subject: [Buildbot-commits] [Buildbot] #2217: Allow MailNotifier's messageFormatter to be asynchronous In-Reply-To: <042.132b75752a27c925942736402dee281e@buildbot.net> References: <042.132b75752a27c925942736402dee281e@buildbot.net> Message-ID: <057.3761c0b5b76ac62ab9ea2caa6c9a9ce0@buildbot.net> #2217: Allow MailNotifier's messageFormatter to be asynchronous --------------------------------+-------------------- Reporter: tom.prince | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.+ Version: master | Resolution: Keywords: mail, sprint, tests | --------------------------------+-------------------- Changes (by dustin): * keywords: mail => mail, sprint, tests -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Mar 11 16:54:37 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 11 Mar 2012 16:54:37 -0000 Subject: [Buildbot-commits] [Buildbot] #2227: Make contrib/post_build_request.py usable via import In-Reply-To: <042.4efad3ee00a8974bb8375e16c4bed645@buildbot.net> References: <042.4efad3ee00a8974bb8375e16c4bed645@buildbot.net> Message-ID: <057.b79606e09ef493062e8ec452cce49c54@buildbot.net> #2227: Make contrib/post_build_request.py usable via import ------------------------+-------------------- Reporter: tom.prince | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.+ Version: 0.8.5 | Resolution: Keywords: | ------------------------+-------------------- Comment (by dustin): These should probably use web hooks instead. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Mar 11 16:58:55 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 11 Mar 2012 16:58:55 -0000 Subject: [Buildbot-commits] [Buildbot] #262: win32 buildbot2.bat not included in scripts directory when installing In-Reply-To: <035.4228ecac24e2ef964fa7c623db54b6fa@buildbot.net> References: <035.4228ecac24e2ef964fa7c623db54b6fa@buildbot.net> Message-ID: <050.e07fb6a8b9053247ff26a6dd13c91ab6@buildbot.net> #262: win32 buildbot2.bat not included in scripts directory when installing ------------------------+-------------------- Reporter: epu | Owner: Type: enhancement | Status: new Priority: trivial | Milestone: 0.8.+ Version: 0.7.7 | Resolution: Keywords: windows | ------------------------+-------------------- Comment (by dustin): Is this still the case? Is this easy to fix? -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Mar 11 16:59:37 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 11 Mar 2012 16:59:37 -0000 Subject: [Buildbot-commits] [Buildbot] #906: please offer a way to pipe shell output in 'i/o view' through external tool In-Reply-To: <041.59e1a81bb78614dad89cef74fdaa10ac@buildbot.net> References: <041.59e1a81bb78614dad89cef74fdaa10ac@buildbot.net> Message-ID: <056.a0a81c7dd176a52ef7a27fe2c768c284@buildbot.net> #906: please offer a way to pipe shell output in 'i/o view' through external tool ------------------------+-------------------- Reporter: dothebart | Owner: Type: enhancement | Status: new Priority: trivial | Milestone: 0.9.+ Version: master | Resolution: Keywords: web, mq | ------------------------+-------------------- Changes (by dustin): * keywords: web => web, mq * milestone: 0.8.+ => 0.9.+ Comment: We could probably do this with a command-line client in the brave new mq world.. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Mar 11 17:00:41 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 11 Mar 2012 17:00:41 -0000 Subject: [Buildbot-commits] [Buildbot] #1768: MailNotifier emails sent with base64 encoding In-Reply-To: <039.a3c5ed7b7703fddacb868504fd6c9228@buildbot.net> References: <039.a3c5ed7b7703fddacb868504fd6c9228@buildbot.net> Message-ID: <054.e7537fb6f7388faa30f90e44132b0c4c@buildbot.net> #1768: MailNotifier emails sent with base64 encoding --------------------+-------------------- Reporter: cortana | Owner: Type: defect | Status: new Priority: trivial | Milestone: 0.8.7 Version: 0.8.3p1 | Resolution: Keywords: mail | --------------------+-------------------- Changes (by dustin): * milestone: 0.8.+ => 0.8.7 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Mar 11 17:01:15 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 11 Mar 2012 17:01:15 -0000 Subject: [Buildbot-commits] [Buildbot] #1769: Try schedulers do not allow you to set patch subdir In-Reply-To: <038.0223e4c4db105277a548f1d6eda5d860@buildbot.net> References: <038.0223e4c4db105277a548f1d6eda5d860@buildbot.net> Message-ID: <053.adb63c5ea7e779dcfd318bcdfefcc1ed@buildbot.net> #1769: Try schedulers do not allow you to set patch subdir --------------------+-------------------- Reporter: dustin | Owner: Type: defect | Status: new Priority: trivial | Milestone: 0.8.+ Version: 0.8.3p1 | Resolution: Keywords: try | --------------------+-------------------- Comment (by dustin): I'm not sure this actually *bothers* anyone - maybe we should just remove subdir support? -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Mar 11 17:01:34 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 11 Mar 2012 17:01:34 -0000 Subject: [Buildbot-commits] [Buildbot] #2069: Information on improving P4 object In-Reply-To: <041.c4fe6ed6003604099e173d6800bcf661@buildbot.net> References: <041.c4fe6ed6003604099e173d6800bcf661@buildbot.net> Message-ID: <056.748a4e6bde06e3af1bb980555d4dc603@buildbot.net> #2069: Information on improving P4 object ------------------------+-------------------- Reporter: johnwbyrd | Owner: Type: enhancement | Status: new Priority: trivial | Milestone: 0.8.+ Version: 0.8.4p2 | Resolution: Keywords: p4 | ------------------------+-------------------- Comment (by dustin): Any updates here? -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Mar 11 18:30:03 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 11 Mar 2012 18:30:03 -0000 Subject: [Buildbot-commits] [Buildbot] #778: 'latest' revision get's stuck on grid views when source step fails In-Reply-To: <039.27a06b248f9920dc90571d9fde33c0c5@buildbot.net> References: <039.27a06b248f9920dc90571d9fde33c0c5@buildbot.net> Message-ID: <054.4c023a6f59a7e31b828023751766f0f3@buildbot.net> #778: 'latest' revision get's stuck on grid views when source step fails --------------------+-------------------- Reporter: marcusl | Owner: Type: defect | Status: new Priority: major | Milestone: 0.9.+ Version: 0.7.12 | Resolution: Keywords: web | --------------------+-------------------- Comment (by dustin): In general, grid's sourcestamp-sorting needs some work - it also confuses revisions on the default branch with revisions on the 'master' branch, for example. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Mar 11 18:32:03 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 11 Mar 2012 18:32:03 -0000 Subject: [Buildbot-commits] [Buildbot] #1831: support recording username for web clicks In-Reply-To: <038.9e41b01353390cce49c1d029e452bb7c@buildbot.net> References: <038.9e41b01353390cce49c1d029e452bb7c@buildbot.net> Message-ID: <053.e8771be8ff614dfa2525ae5479eef9fc@buildbot.net> #1831: support recording username for web clicks ------------------------+---------------------- Reporter: dustin | Owner: Type: enhancement | Status: closed Priority: major | Milestone: 0.9.+ Version: master | Resolution: invalid Keywords: | ------------------------+---------------------- Changes (by dustin): * status: new => closed * resolution: => invalid Comment: I've totally forgotten what the context was here.. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Mar 11 18:36:39 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 11 Mar 2012 18:36:39 -0000 Subject: [Buildbot-commits] [Buildbot] #1882: enable/disable slaves w/o putting them offline by stopping service In-Reply-To: <035.9cab9ce90ff58650278f81b52732b458@buildbot.net> References: <035.9cab9ce90ff58650278f81b52732b458@buildbot.net> Message-ID: <050.15269a839185625365a4bd6580bba141@buildbot.net> #1882: enable/disable slaves w/o putting them offline by stopping service ------------------------+------------------------ Reporter: gg0 | Owner: Type: enhancement | Status: closed Priority: major | Milestone: 0.9.+ Version: 0.8.3 | Resolution: duplicate Keywords: | ------------------------+------------------------ Changes (by dustin): * status: new => closed * resolution: => duplicate Comment: #537 describes pausing slaves, achieving a similar effect. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Mar 11 18:37:57 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 11 Mar 2012 18:37:57 -0000 Subject: [Buildbot-commits] [Buildbot] #1901: real tests for Blocker In-Reply-To: <038.178e3d8147269ed2950575c4e6cdccbf@buildbot.net> References: <038.178e3d8147269ed2950575c4e6cdccbf@buildbot.net> Message-ID: <053.d430cdb359932265875da51e436ad272@buildbot.net> #1901: real tests for Blocker ------------------------+-------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.9.+ Version: 0.8.3p1 | Resolution: Keywords: tests | ------------------------+-------------------- Comment (by dustin): We're at the next PyCon, and we have a decent step-testing architecture now! -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Mar 11 18:39:36 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 11 Mar 2012 18:39:36 -0000 Subject: [Buildbot-commits] [Buildbot] #1977: transitions between working / broken not computed per-branch In-Reply-To: <041.02daa6178728651fb513ff2c7280e668@buildbot.net> References: <041.02daa6178728651fb513ff2c7280e668@buildbot.net> Message-ID: <056.7e9182315ad23158963e2a4621a4767a@buildbot.net> #1977: transitions between working / broken not computed per-branch ---------------------------------+-------------------- Reporter: dabrahams | Owner: Type: defect | Status: new Priority: major | Milestone: 0.9.+ Version: 0.8.3p1 | Resolution: Keywords: database, buildcoord | ---------------------------------+-------------------- Changes (by dustin): * keywords: database => database, buildcoord -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Mar 11 18:41:16 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 11 Mar 2012 18:41:16 -0000 Subject: [Buildbot-commits] [Buildbot] #2071: Force Build per builder security, property In-Reply-To: <038.9e5dd19a9a377a1b558ed2dedd7e774b@buildbot.net> References: <038.9e5dd19a9a377a1b558ed2dedd7e774b@buildbot.net> Message-ID: <053.ff264565fdf4eaa0358d8bb68139ab58@buildbot.net> #2071: Force Build per builder security, property ------------------------+-------------------- Reporter: jachen | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.9.+ Version: 0.8.4p2 | Resolution: Keywords: web, force | ------------------------+-------------------- Changes (by dustin): * keywords: web => web, force Comment: We have force schedulers now, so it just remains to add auth. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Mar 11 18:41:44 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 11 Mar 2012 18:41:44 -0000 Subject: [Buildbot-commits] [Buildbot] #205: button which takes me to the most recent green->red state transition In-Reply-To: <037.7940944cf1042b523bb7ea03ddceae26@buildbot.net> References: <037.7940944cf1042b523bb7ea03ddceae26@buildbot.net> Message-ID: <052.41fbb89c74cedbebabc0f073c8779266@buildbot.net> #205: button which takes me to the most recent green->red state transition ----------------------------+-------------------- Reporter: zooko | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.9.+ Version: 0.7.6 | Resolution: Keywords: web, buildcoord | ----------------------------+-------------------- Changes (by dustin): * keywords: web => web, buildcoord -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sun Mar 11 18:43:47 2012 From: noreply at github.com (GitHub) Date: Sun, 11 Mar 2012 11:43:47 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 36b195: fix sdist to copy NEWS appropriately into master a... Message-ID: <4f5cf263237c0_28bf3ff7791722fc73395@sh1.rs.github.com.mail> Branch: refs/tags/v0.8.6 Home: https://github.com/buildbot/buildbot Commit: 36b19532c4661ce8c84f00fd795bb25ed702571d https://github.com/buildbot/buildbot/commit/36b19532c4661ce8c84f00fd795bb25ed702571d Author: Dustin J. Mitchell Date: 2012-03-11 (Sun, 11 Mar 2012) Changed paths: R master/NEWS M master/setup.py R slave/NEWS M slave/setup.py Log Message: ----------- fix sdist to copy NEWS appropriately into master and slave From noreply at github.com Sun Mar 11 18:44:50 2012 From: noreply at github.com (GitHub) Date: Sun, 11 Mar 2012 11:44:50 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] Message-ID: <4f5cf2a28b795_635516abae81204c9@sh2.rs.github.com.mail> Branch: refs/tags/v0.8.6 Home: https://github.com/buildbot/buildbot From noreply at github.com Sun Mar 11 18:44:49 2012 From: noreply at github.com (GitHub) Date: Sun, 11 Mar 2012 11:44:49 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 36b195: fix sdist to copy NEWS appropriately into master a... Message-ID: <4f5cf2a1a159c_58619faaf0866c6@sh2.rs.github.com.mail> Branch: refs/heads/buildbot-0.8.6 Home: https://github.com/buildbot/buildbot Commit: 36b19532c4661ce8c84f00fd795bb25ed702571d https://github.com/buildbot/buildbot/commit/36b19532c4661ce8c84f00fd795bb25ed702571d Author: Dustin J. Mitchell Date: 2012-03-11 (Sun, 11 Mar 2012) Changed paths: R master/NEWS M master/setup.py R slave/NEWS M slave/setup.py Log Message: ----------- fix sdist to copy NEWS appropriately into master and slave Commit: 40857bf44376f5e27f1658ae1e9bc1ef2c1fa251 https://github.com/buildbot/buildbot/commit/40857bf44376f5e27f1658ae1e9bc1ef2c1fa251 Author: Dustin J. Mitchell Date: 2012-03-11 (Sun, 11 Mar 2012) Changed paths: M master/buildbot/schedulers/triggerable.py M master/buildbot/sourcestamp.py M master/buildbot/steps/trigger.py M master/buildbot/test/unit/test_schedulers_triggerable.py M master/buildbot/test/unit/test_steps_trigger.py Log Message: ----------- Merge branch 'buildbot-0.8.6' of github.com:buildbot/buildbot into buildbot-0.8.6 * 'buildbot-0.8.6' of github.com:buildbot/buildbot: parameter renamed Test with new interface between Trigger and Triggerable getSourceStampSetId always returns the setid A new setid is created if a sourcestamps is added to the database. Trigger gets sourcestampsetid from triggerable. Compare: https://github.com/buildbot/buildbot/compare/2f7402b...40857bf From nobody at buildbot.net Sun Mar 11 20:48:03 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 11 Mar 2012 20:48:03 -0000 Subject: [Buildbot-commits] [Buildbot] #971: Build a windows installer In-Reply-To: <038.6c763d0f053bc258fcb2f8f99b00326c@buildbot.net> References: <038.6c763d0f053bc258fcb2f8f99b00326c@buildbot.net> Message-ID: <053.88dab526041a66053fb9a2d499096cbc@buildbot.net> #971: Build a windows installer ------------------------+----------------------- Reporter: dustin | Owner: fatman2 Type: enhancement | Status: accepted Priority: major | Milestone: 0.8.+ Version: | Resolution: Keywords: windows | ------------------------+----------------------- Comment (by dustin): I just learned about esky - http://pypi.python.org/pypi/esky/0.9.5 - from Ryan Kelly. Could we use this, rather than an installer? So users can just download buildslave.exe and run it? Esky can do automatic updates and signing and whatnot, but I don't think we need any of those. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Mar 11 21:22:00 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 11 Mar 2012 21:22:00 -0000 Subject: [Buildbot-commits] [Buildbot] #2238: Need TeX-compatible images for PDF generation Message-ID: <038.7dd06c0c62ba4856eaa53640dd29e202@buildbot.net> #2238: Need TeX-compatible images for PDF generation -------------------+------------------- Reporter: dustin | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.7 Version: 0.8.6 | Keywords: docs -------------------+------------------- readthedocs tries to make PDFs, and fails: {{{ None:None: WARNING: no matching candidate for image URI u'manual/_images/overview.*' None:None: WARNING: no matching candidate for image URI u'manual/_images/slaves.*' None:None: WARNING: no matching candidate for image URI u'manual/_images/master.*' None:None: WARNING: no matching candidate for image URI u'manual/_images/status.*' }}} -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Mar 11 22:59:51 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 11 Mar 2012 22:59:51 -0000 Subject: [Buildbot-commits] [Buildbot] #2239: Use pyrasite to introspect Buildbot Message-ID: <038.bc30a74d0e48fb80b56ef9e43e920f59@buildbot.net> #2239: Use pyrasite to introspect Buildbot ------------------------+------------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: major | Milestone: ongoing Version: 0.8.6 | Keywords: performance ------------------------+------------------------- From the lightning talks at PyCon 2012: https://fedorahosted.org/pyrasite/ It's a GUI interface that injects its talons into running Python processes. So you could say "wow, my Buildbot is huge!!", or "..slow!!", open up pyrasite, and get great visibility into what's going wrong. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Mar 11 23:22:59 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 11 Mar 2012 23:22:59 -0000 Subject: [Buildbot-commits] [Buildbot] #1968: Multi-prefix support for PBChangeSource In-Reply-To: <037.6e39d558ae82ef5d43aec9db24951f82@buildbot.net> References: <037.6e39d558ae82ef5d43aec9db24951f82@buildbot.net> Message-ID: <052.7556fdb4ac37397a9a570a44584bd1e1@buildbot.net> #1968: Multi-prefix support for PBChangeSource ------------------------+-------------------- Reporter: LoTek | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.+ Version: 0.8.3p1 | Resolution: Keywords: try | ------------------------+-------------------- Comment (by dustin): I merged this to master: https://github.com/djmitche/buildbot/tree/bug1968 This still fails tests, and lacks documentation. I'm not totally convinced that the implementation is correct, either -- does it handle no prefix correctly? It will need a bit more testing (and docs). -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sun Mar 11 23:41:52 2012 From: noreply at github.com (GitHub) Date: Sun, 11 Mar 2012 16:41:52 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] c9637e: mention utility of xmlcharrefreplace in encoding/d... Message-ID: <4f5d3840a77c8_66a91a87af419747@sh2.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: c9637e667175b2188b0e50cad755dcf9f963b17c https://github.com/buildbot/buildbot/commit/c9637e667175b2188b0e50cad755dcf9f963b17c Author: Dustin J. Mitchell Date: 2012-03-11 (Sun, 11 Mar 2012) Changed paths: M master/docs/developer/encodings.rst Log Message: ----------- mention utility of xmlcharrefreplace in encoding/decoding From nobody at buildbot.net Sun Mar 11 23:50:12 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 11 Mar 2012 23:50:12 -0000 Subject: [Buildbot-commits] [Buildbot] #1054: sqlite3.ProgrammingError when starting a rebuild with non-ASCII chars in re-build reason In-Reply-To: <044.2de614d921abd44d3f564e3b01bf901d@buildbot.net> References: <044.2de614d921abd44d3f564e3b01bf901d@buildbot.net> Message-ID: <059.d29d2a27858bbad03efcf16a3cfb2a6e@buildbot.net> #1054: sqlite3.ProgrammingError when starting a rebuild with non-ASCII chars in re-build reason -------------------------+-------------------- Reporter: andialbrecht | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.7 Version: 0.8.1 | Resolution: Keywords: database | -------------------------+-------------------- Comment (by dustin): I still get this when rebuilding because "?" : (ProgrammingError) You must not use 8-bit bytestrings unless you use a text_factory that can interpret 8-bit bytestrings (like text_factory = str). It is highly recommended that you instead just switch your application to Unicode strings. u'INSERT INTO buildsets (external_idstring, reason, submitted_at, complete, complete_at, results, sourcestampsetid) VALUES (?, ?, ?, ?, ?, ?, ?)' (None, "The web- page 'rebuild' button was pressed by '': \xe2\x98\x83\n", 1331509675.957143, 0, None, -1, 2) so this definitely isn't fixed. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Mar 12 00:48:40 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 12 Mar 2012 00:48:40 -0000 Subject: [Buildbot-commits] [Buildbot] #1054: sqlite3.ProgrammingError when starting a rebuild with non-ASCII chars in re-build reason In-Reply-To: <044.2de614d921abd44d3f564e3b01bf901d@buildbot.net> References: <044.2de614d921abd44d3f564e3b01bf901d@buildbot.net> Message-ID: <059.2cfd21c40182be297256207b0b80f22a@buildbot.net> #1054: sqlite3.ProgrammingError when starting a rebuild with non-ASCII chars in re-build reason -----------------------------+-------------------- Reporter: andialbrecht | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.7 Version: 0.8.1 | Resolution: Keywords: database, sprint | -----------------------------+-------------------- Changes (by dustin): * keywords: database => database, sprint -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Mar 12 03:01:21 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 12 Mar 2012 03:01:21 -0000 Subject: [Buildbot-commits] [Buildbot] #2214: BuildStep's for multi-repo should include sourcebase in the names In-Reply-To: <042.390a8e63efa40f433cb326072e61e6cd@buildbot.net> References: <042.390a8e63efa40f433cb326072e61e6cd@buildbot.net> Message-ID: <057.28671eaa0c44b9e459c18109131e1b1d@buildbot.net> #2214: BuildStep's for multi-repo should include sourcebase in the names ------------------------+-------------------- Reporter: jaredgrubb | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.7 Version: 0.8.5 | Resolution: Keywords: projrepo | ------------------------+-------------------- Comment (by jaredgrubb): Per discussion with Dustin, we converged on this for a first try: * SourceStep : add the codebase to the name and description * BuildStep in general : add a new optional parameter ("descriptionSuffix"?) to add to the names -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Mar 12 03:50:59 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 12 Mar 2012 03:50:59 -0000 Subject: [Buildbot-commits] [Buildbot] #1799: Fix pipe symbol with ^ workaround In-Reply-To: <036.70f4fc784899f73c738eab2f8aaa9bdc@buildbot.net> References: <036.70f4fc784899f73c738eab2f8aaa9bdc@buildbot.net> Message-ID: <051.03236804078791c94744398deb02ab12@buildbot.net> #1799: Fix pipe symbol with ^ workaround ----------------------------+-------------------- Reporter: todd | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.3p1 | Resolution: Keywords: windows, sprint | ----------------------------+-------------------- Description changed by dustin: Old description: > Class buildbot.steps.vstudio.VC10 can't handle config names with a pipe > (|) in it, e.g. "Release|Win32". > > A workaround is to use buildbpt.steps.shell.ShellCommand and escape the > pipe with a ^, e.g.: > > {{{ > ShellCommand(command=['devenv.com', 'Solution.sln', '/Build', > 'Release^|Win32']) > }}} > > The following would *not* work, because the ^ is missing: > > {{{ > ShellCommand(command=['devenv.com', 'Solution.sln', '/Build', > 'Release|Win32']) > }}} > > Maybe this workaround can be used to fix this bug. One simple solution > would be to search for pipes (|) and replace them with ^|. New description: Class buildbot.steps.vstudio.VC10 can't handle config names with a pipe (|) in it, e.g. {{{"Release|Win32"}}}. A workaround is to use buildbpt.steps.shell.ShellCommand and escape the pipe with a {{{^}}}, e.g.: {{{ ShellCommand(command=['devenv.com', 'Solution.sln', '/Build', 'Release^|Win32']) }}} The following would *not* work, because the ^ is missing: {{{ ShellCommand(command=['devenv.com', 'Solution.sln', '/Build', 'Release|Win32']) }}} Maybe this workaround can be used to fix this bug. One simple solution would be to search for pipes {{{|}}} and replace them with {{{^|}}}. -- -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Mon Mar 12 04:17:32 2012 From: noreply at github.com (GitHub) Date: Sun, 11 Mar 2012 21:17:32 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 23150b: Add basic tests for rpmbuild Message-ID: <4f5d78dcad0c2_717e58ae41274e@sh2.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 23150b527b5a3addbd6fb6b3c37bd512d27e26e0 https://github.com/buildbot/buildbot/commit/23150b527b5a3addbd6fb6b3c37bd512d27e26e0 Author: Dustin J. Mitchell Date: 2012-03-11 (Sun, 11 Mar 2012) Changed paths: M master/buildbot/steps/package/rpm/rpmbuild.py A master/buildbot/test/unit/test_steps_package_rpm_rpmbuild.py M master/docs/manual/cfg-buildsteps.rst Log Message: ----------- Add basic tests for rpmbuild From noreply at github.com Mon Mar 12 04:43:24 2012 From: noreply at github.com (GitHub) Date: Sun, 11 Mar 2012 21:43:24 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 87108e: remote 'TODO' and wrap long lines in model.py Message-ID: <4f5d7eeceece_4a1c3f96184cd2fc1265e6@sh1.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 87108ec4088dc7fd5394ac3c1d0bd3b465300d92 https://github.com/buildbot/buildbot/commit/87108ec4088dc7fd5394ac3c1d0bd3b465300d92 Author: Dustin J. Mitchell Date: 2012-03-11 (Sun, 11 Mar 2012) Changed paths: M master/buildbot/db/model.py Log Message: ----------- remote 'TODO' and wrap long lines in model.py From noreply at github.com Mon Mar 12 04:51:08 2012 From: noreply at github.com (GitHub) Date: Sun, 11 Mar 2012 21:51:08 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 4d813b: don't unnecessarily override setupProgress in vstu... Message-ID: <4f5d80bc234e2_533b3ff7b3019aec793e1@sh1.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 4d813b61b19d9b23d3fe3456d224711cbc2cc4fe https://github.com/buildbot/buildbot/commit/4d813b61b19d9b23d3fe3456d224711cbc2cc4fe Author: Dustin J. Mitchell Date: 2012-03-11 (Sun, 11 Mar 2012) Changed paths: M master/buildbot/steps/vstudio.py Log Message: ----------- don't unnecessarily override setupProgress in vstudio.py From nobody at buildbot.net Mon Mar 12 05:20:43 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 12 Mar 2012 05:20:43 -0000 Subject: [Buildbot-commits] [Buildbot] #2240: sourcestampset size assertion fails in master Message-ID: <038.85f74ce19c1161a3c3a71fcff7eb216c@buildbot.net> #2240: sourcestampset size assertion fails in master ---------------------+------------------- Reporter: dustin | Owner: Type: defect | Status: new Priority: critical | Milestone: 0.8.7 Version: master | Keywords: ---------------------+------------------- {{{ Traceback (most recent call last): File "/home/dustin/code/buildbot/t/buildbot/sand27/lib/python2.7 /site-packages/twisted/internet/defer.py", line 368, in callback self._startRunCallbacks(result) File "/home/dustin/code/buildbot/t/buildbot/sand27/lib/python2.7 /site-packages/twisted/internet/defer.py", line 464, in _startRunCallbacks self._runCallbacks() File "/home/dustin/code/buildbot/t/buildbot/sand27/lib/python2.7 /site-packages/twisted/internet/defer.py", line 551, in _runCallbacks current.result = callback(current.result, *args, **kw) File "/home/dustin/code/buildbot/t/buildbot/sand27/lib/python2.7 /site-packages/twisted/internet/defer.py", line 916, in gotResult _deferGenerator(g, deferred) --- --- File "/home/dustin/code/buildbot/t/buildbot/sand27/lib/python2.7 /site-packages/twisted/internet/defer.py", line 891, in _deferGenerator result = g.next() File "/home/dustin/code/buildbot/t/buildbot/master/buildbot/process/buildrequest.py", line 129, in _make_br assert len(sslist) > 0, "Empty sourcestampset: db schema enforces set to exist but cannot enforce a non empty set" exceptions.TypeError: object of type 'NoneType' has no len() }}} This is making sprinters unhappy as they try to test! -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Mon Mar 12 05:50:44 2012 From: noreply at github.com (GitHub) Date: Sun, 11 Mar 2012 22:50:44 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] c97cad: Return a value from getSourceStamps() Message-ID: <4f5d8eb4d56ae_533d3feddd9cd2f8430a9@sh1.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: c97cadfb0669536447b33dd316ee99588c657454 https://github.com/buildbot/buildbot/commit/c97cadfb0669536447b33dd316ee99588c657454 Author: Dustin J. Mitchell Date: 2012-03-11 (Sun, 11 Mar 2012) Changed paths: M master/buildbot/db/sourcestamps.py Log Message: ----------- Return a value from getSourceStamps() Fixes #2240. From nobody at buildbot.net Mon Mar 12 05:50:50 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 12 Mar 2012 05:50:50 -0000 Subject: [Buildbot-commits] [Buildbot] #2240: sourcestampset size assertion fails in master In-Reply-To: <038.85f74ce19c1161a3c3a71fcff7eb216c@buildbot.net> References: <038.85f74ce19c1161a3c3a71fcff7eb216c@buildbot.net> Message-ID: <053.6a1a702ebe14ac2c503be1148ddd7184@buildbot.net> #2240: sourcestampset size assertion fails in master ---------------------+--------------------- Reporter: dustin | Owner: Type: defect | Status: closed Priority: critical | Milestone: 0.8.7 Version: master | Resolution: fixed Keywords: | ---------------------+--------------------- Changes (by Dustin J. Mitchell): * status: new => closed * resolution: => fixed Comment: Return a value from getSourceStamps() Fixes #2240. Changeset: c97cadfb0669536447b33dd316ee99588c657454 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Mar 12 06:06:33 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 12 Mar 2012 06:06:33 -0000 Subject: [Buildbot-commits] [Buildbot] #2241: invalid getSourceStamp call in oldsource.py In-Reply-To: <038.ab65151a7bbe56f7beca4af36e8ea417@buildbot.net> References: <038.ab65151a7bbe56f7beca4af36e8ea417@buildbot.net> Message-ID: <053.921e834aac7f02234fec5b8732f53751@buildbot.net> #2241: invalid getSourceStamp call in oldsource.py -------------------+-------------------- Reporter: dustin | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.7 Version: master | Resolution: Keywords: | -------------------+-------------------- Comment (by Dustin J. Mitchell): hack _ComputeRepositoryURL to use codebase '' Refs #2241. This is not an actual "fix", but I believe the next multirepo patch will address this. Changeset: 07172ee37f21d2a291275067240d68b3ac58e379 -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Mon Mar 12 06:06:27 2012 From: noreply at github.com (GitHub) Date: Sun, 11 Mar 2012 23:06:27 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 07172e: hack _ComputeRepositoryURL to use codebase '' Message-ID: <4f5d9263489ff_212b1bc6af043938@sh2.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 07172ee37f21d2a291275067240d68b3ac58e379 https://github.com/buildbot/buildbot/commit/07172ee37f21d2a291275067240d68b3ac58e379 Author: Dustin J. Mitchell Date: 2012-03-11 (Sun, 11 Mar 2012) Changed paths: M master/buildbot/steps/source/oldsource.py M master/buildbot/test/unit/test_steps_source_oldsource_ComputeRepositoryURL.py Log Message: ----------- hack _ComputeRepositoryURL to use codebase '' Refs #2241. This is not an actual "fix", but I believe the next multirepo patch will address this. From nobody at buildbot.net Mon Mar 12 05:48:26 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 12 Mar 2012 05:48:26 -0000 Subject: [Buildbot-commits] [Buildbot] #2241: invalid getSourceStamp call in oldsource.py Message-ID: <038.ab65151a7bbe56f7beca4af36e8ea417@buildbot.net> #2241: invalid getSourceStamp call in oldsource.py -------------------+------------------- Reporter: dustin | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.7 Version: master | Keywords: -------------------+------------------- {{{ Traceback (most recent call last): File "/home/dustin/code/buildbot/t/buildbot/sand27/lib/python2.7/site- packages/twisted/internet/defer.py", line 134, in maybeDeferred result = f(*args, **kw) File "/home/dustin/code/buildbot/t/buildbot/master/buildbot/process/buildstep.py", line 505, in startStep d.addCallback(self._startStep_2) File "/home/dustin/code/buildbot/t/buildbot/sand27/lib/python2.7/site- packages/twisted/internet/defer.py", line 301, in addCallback callbackKeywords=kw) File "/home/dustin/code/buildbot/t/buildbot/sand27/lib/python2.7/site- packages/twisted/internet/defer.py", line 290, in addCallbacks self._runCallbacks() --- --- File "/home/dustin/code/buildbot/t/buildbot/sand27/lib/python2.7/site- packages/twisted/internet/defer.py", line 551, in _runCallbacks current.result = callback(current.result, *args, **kw) File "/home/dustin/code/buildbot/t/buildbot/master/buildbot/process/buildstep.py", line 547, in _startStep_2 setattr(self, renderable, self.build.render(getattr(self, renderable))) File "/home/dustin/code/buildbot/t/buildbot/master/buildbot/process/properties.py", line 177, in render return props.render(value) File "/home/dustin/code/buildbot/t/buildbot/master/buildbot/process/properties.py", line 137, in render return renderable.getRenderingFor(self) File "/home/dustin/code/buildbot/t/buildbot/master/buildbot/steps/source/oldsource.py", line 40, in getRenderingFor s = build.getSourceStamp() exceptions.TypeError: getSourceStamp() takes exactly 2 arguments (1 given) }}} -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Mon Mar 12 06:57:28 2012 From: noreply at github.com (GitHub) Date: Sun, 11 Mar 2012 23:57:28 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 026699: Refactor all monkey patches into the same dir. Message-ID: <4f5d9e58d490_208f1b04af4861e@sh2.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 02669913d76bf0c2f14a957a0ca55c4bcb632b86 https://github.com/buildbot/buildbot/commit/02669913d76bf0c2f14a957a0ca55c4bcb632b86 Author: Dustin J. Mitchell Date: 2012-03-11 (Sun, 11 Mar 2012) Changed paths: M master/buildbot/monkeypatches/__init__.py A master/buildbot/monkeypatches/servicechecks.py A master/buildbot/monkeypatches/testcase_patch.py M master/buildbot/test/__init__.py M master/buildbot/test/test_extra_coverage.py R master/buildbot/util/monkeypatches.py Log Message: ----------- Refactor all monkey patches into the same dir. From noreply at github.com Mon Mar 12 17:27:50 2012 From: noreply at github.com (GitHub) Date: Mon, 12 Mar 2012 10:27:50 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] ddd9f8: Sort the list of builders returned by master statu... Message-ID: <4f5e32166e584_48c03fe99e9be2f014718a@sh1.rs.github.com.mail> Branch: refs/heads/buildbot-0.8.6 Home: https://github.com/buildbot/buildbot Commit: ddd9f8dc4b34f93e48b38d1c85c32e50858eede6 https://github.com/buildbot/buildbot/commit/ddd9f8dc4b34f93e48b38d1c85c32e50858eede6 Author: Tom Prince Date: 2012-03-12 (Mon, 12 Mar 2012) Changed paths: M master/buildbot/status/master.py Log Message: ----------- Sort the list of builders returned by master status. We have a number of places where we use this list as is, for displaying lists of builders. In previous versions, this list happened to be in the same order as in the config. Since that is no longer the case, give at least *some* ordering of the list, rather than a completely random seeming order. Commit: 05d60d1172c9e5a9f641f557c4e2265aeafbdcca https://github.com/buildbot/buildbot/commit/05d60d1172c9e5a9f641f557c4e2265aeafbdcca Author: Dustin J. Mitchell Date: 2012-03-12 (Mon, 12 Mar 2012) Changed paths: M master/buildbot/status/master.py Log Message: ----------- Merge branch 'sort-builder-list' of git://github.com/tomprince/buildbot into buildbot-0.8.6 * 'sort-builder-list' of git://github.com/tomprince/buildbot: Sort the list of builders returned by master status. Compare: https://github.com/buildbot/buildbot/compare/40857bf...05d60d1 From noreply at github.com Mon Mar 12 17:27:51 2012 From: noreply at github.com (GitHub) Date: Mon, 12 Mar 2012 10:27:51 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] ddd9f8: Sort the list of builders returned by master statu... Message-ID: <4f5e3217d9042_34ba1719ae81803fc@sh2.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: ddd9f8dc4b34f93e48b38d1c85c32e50858eede6 https://github.com/buildbot/buildbot/commit/ddd9f8dc4b34f93e48b38d1c85c32e50858eede6 Author: Tom Prince Date: 2012-03-12 (Mon, 12 Mar 2012) Changed paths: M master/buildbot/status/master.py Log Message: ----------- Sort the list of builders returned by master status. We have a number of places where we use this list as is, for displaying lists of builders. In previous versions, this list happened to be in the same order as in the config. Since that is no longer the case, give at least *some* ordering of the list, rather than a completely random seeming order. Commit: 05d60d1172c9e5a9f641f557c4e2265aeafbdcca https://github.com/buildbot/buildbot/commit/05d60d1172c9e5a9f641f557c4e2265aeafbdcca Author: Dustin J. Mitchell Date: 2012-03-12 (Mon, 12 Mar 2012) Changed paths: M master/buildbot/status/master.py Log Message: ----------- Merge branch 'sort-builder-list' of git://github.com/tomprince/buildbot into buildbot-0.8.6 * 'sort-builder-list' of git://github.com/tomprince/buildbot: Sort the list of builders returned by master status. Commit: a646edcd5ac7c3aa1e0d246067f76fe52f950702 https://github.com/buildbot/buildbot/commit/a646edcd5ac7c3aa1e0d246067f76fe52f950702 Author: Dustin J. Mitchell Date: 2012-03-12 (Mon, 12 Mar 2012) Changed paths: R master/NEWS M master/buildbot/status/master.py M master/setup.py R slave/NEWS M slave/setup.py Log Message: ----------- Merge branch 'buildbot-0.8.6' * buildbot-0.8.6: Sort the list of builders returned by master status. fix sdist to copy NEWS appropriately into master and slave Compare: https://github.com/buildbot/buildbot/compare/0266991...a646edc From noreply at github.com Mon Mar 12 17:59:17 2012 From: noreply at github.com (GitHub) Date: Mon, 12 Mar 2012 10:59:17 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] dbd8a8: Remove README.w32 Message-ID: <4f5e3975b5ce4_673a3fd4d99d62f8922b6@sh1.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: dbd8a8606904770c6f9b02767c9d50a9f597e34c https://github.com/buildbot/buildbot/commit/dbd8a8606904770c6f9b02767c9d50a9f597e34c Author: Dustin J. Mitchell Date: 2012-03-12 (Mon, 12 Mar 2012) Changed paths: R master/README.w32 Log Message: ----------- Remove README.w32 Fixes #881. From nobody at buildbot.net Mon Mar 12 17:59:49 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 12 Mar 2012 17:59:49 -0000 Subject: [Buildbot-commits] [Buildbot] #881: convert README.w32 into wiki and/or texinfo documentation In-Reply-To: <038.0998540d1f7c18dc846e696fbd87c892@buildbot.net> References: <038.0998540d1f7c18dc846e696fbd87c892@buildbot.net> Message-ID: <053.04c7c7b8a4cdf9777ad0af5c6aca8444@buildbot.net> #881: convert README.w32 into wiki and/or texinfo documentation ----------------------------------+--------------------- Reporter: dustin | Owner: Type: enhancement | Status: closed Priority: major | Milestone: 0.8.+ Version: 0.8.0 | Resolution: fixed Keywords: windows, docs, sprint | ----------------------------------+--------------------- Changes (by Dustin J. Mitchell): * status: new => closed * resolution: => fixed Comment: Remove README.w32 Fixes #881. Changeset: dbd8a8606904770c6f9b02767c9d50a9f597e34c -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Mar 12 19:48:37 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 12 Mar 2012 19:48:37 -0000 Subject: [Buildbot-commits] [Buildbot] #2214: BuildStep's for multi-repo should include sourcebase in the names In-Reply-To: <042.390a8e63efa40f433cb326072e61e6cd@buildbot.net> References: <042.390a8e63efa40f433cb326072e61e6cd@buildbot.net> Message-ID: <057.fc68e735ce2a778e2fe98b63a2860973@buildbot.net> #2214: BuildStep's for multi-repo should include sourcebase in the names ------------------------+-------------------- Reporter: jaredgrubb | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.7 Version: 0.8.5 | Resolution: Keywords: projrepo | ------------------------+-------------------- Comment (by jaredgrubb): Have this implemented; will post a pull request shortly. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Mon Mar 12 19:54:04 2012 From: noreply at github.com (GitHub) Date: Mon, 12 Mar 2012 12:54:04 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 70780c: Add umask to buildbot.tac which propagates and set... Message-ID: <4f5e545c2bfd_b6c3fa22cb91af01022c5@sh1.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 70780c3789e68d55b3b8f8a5a2f8a32ba325a8af https://github.com/buildbot/buildbot/commit/70780c3789e68d55b3b8f8a5a2f8a32ba325a8af Author: William Deegan Date: 2012-03-12 (Mon, 12 Mar 2012) Changed paths: M master/buildbot/master.py M master/buildbot/scripts/runner.py Log Message: ----------- Add umask to buildbot.tac which propagates and sets default umask for buildbot master. Ticket 2169 Commit: a0a919e4293b16585a223025f362b0666019d1e5 https://github.com/buildbot/buildbot/commit/a0a919e4293b16585a223025f362b0666019d1e5 Author: William Deegan Date: 2012-03-12 (Mon, 12 Mar 2012) Changed paths: M MAINTAINERS.txt A common/validate.sh M master/MANIFEST.in R master/NEWS R master/README.w32 M master/buildbot/__init__.py M master/buildbot/buildslave.py M master/buildbot/changes/bonsaipoller.py M master/buildbot/changes/changes.py M master/buildbot/changes/gerritchangesource.py M master/buildbot/changes/gitpoller.py M master/buildbot/changes/hgbuildbot.py M master/buildbot/changes/manager.py M master/buildbot/changes/p4poller.py M master/buildbot/changes/pb.py M master/buildbot/changes/svnpoller.py M master/buildbot/clients/tryclient.py M master/buildbot/config.py M master/buildbot/db/base.py M master/buildbot/db/buildsets.py M master/buildbot/db/changes.py M master/buildbot/db/connector.py M master/buildbot/db/migrate/versions/001_initial.py A master/buildbot/db/migrate/versions/021_fix_postgres_sequences.py A master/buildbot/db/migrate/versions/022_add_codebase.py R master/buildbot/db/migrate/versions/__init__.py A master/buildbot/db/migrate/versions/__init__.py M master/buildbot/db/model.py M master/buildbot/db/pool.py M master/buildbot/db/sourcestamps.py M master/buildbot/db/state.py M master/buildbot/db/users.py M master/buildbot/ec2buildslave.py M master/buildbot/manhole.py M master/buildbot/master.py M master/buildbot/monkeypatches/__init__.py A master/buildbot/monkeypatches/bug4520.py A master/buildbot/monkeypatches/servicechecks.py A master/buildbot/monkeypatches/testcase_patch.py M master/buildbot/process/botmaster.py M master/buildbot/process/build.py M master/buildbot/process/builder.py M master/buildbot/process/buildrequest.py M master/buildbot/process/buildstep.py M master/buildbot/process/debug.py M master/buildbot/process/factory.py M master/buildbot/process/metrics.py M master/buildbot/process/properties.py M master/buildbot/process/users/manager.py M master/buildbot/process/users/manual.py M master/buildbot/process/users/users.py M master/buildbot/schedulers/base.py M master/buildbot/schedulers/basic.py M master/buildbot/schedulers/dependent.py M master/buildbot/schedulers/manager.py M master/buildbot/schedulers/timed.py M master/buildbot/schedulers/triggerable.py M master/buildbot/schedulers/trysched.py M master/buildbot/scripts/reconfig.py M master/buildbot/scripts/runner.py M master/buildbot/sourcestamp.py M master/buildbot/status/build.py M master/buildbot/status/builder.py M master/buildbot/status/buildrequest.py M master/buildbot/status/mail.py M master/buildbot/status/master.py M master/buildbot/status/persistent_queue.py M master/buildbot/status/status_push.py M master/buildbot/status/web/baseweb.py M master/buildbot/status/web/build.py M master/buildbot/status/web/builder.py M master/buildbot/status/web/change_hook.py M master/buildbot/status/web/console.py M master/buildbot/status/web/grid.py M master/buildbot/status/web/hooks/github.py M master/buildbot/status/web/hooks/googlecode.py M master/buildbot/status/web/root.py M master/buildbot/status/web/slaves.py M master/buildbot/status/web/status_json.py M master/buildbot/status/web/users.py M master/buildbot/steps/blocker.py M master/buildbot/steps/maxq.py M master/buildbot/steps/package/rpm/rpmbuild.py M master/buildbot/steps/python.py M master/buildbot/steps/shell.py M master/buildbot/steps/source/__init__.py A master/buildbot/steps/source/base.py M master/buildbot/steps/source/bzr.py M master/buildbot/steps/source/cvs.py M master/buildbot/steps/source/git.py M master/buildbot/steps/source/mercurial.py M master/buildbot/steps/source/oldsource.py M master/buildbot/steps/source/svn.py M master/buildbot/steps/transfer.py M master/buildbot/steps/trigger.py M master/buildbot/steps/vstudio.py M master/buildbot/test/__init__.py M master/buildbot/test/fake/fakedb.py M master/buildbot/test/fake/remotecommand.py M master/buildbot/test/fuzz/test_lru.py M master/buildbot/test/integration/test_configs.py M master/buildbot/test/integration/test_slave_comm.py M master/buildbot/test/integration/test_upgrade.py M master/buildbot/test/regressions/test_oldpaths.py M master/buildbot/test/regressions/test_shell_command_properties.py M master/buildbot/test/test_extra_coverage.py M master/buildbot/test/unit/test_buildslave.py M master/buildbot/test/unit/test_changes_mail.py M master/buildbot/test/unit/test_changes_pb.py M master/buildbot/test/unit/test_changes_svnpoller.py M master/buildbot/test/unit/test_config.py M master/buildbot/test/unit/test_db_base.py M master/buildbot/test/unit/test_db_changes.py M master/buildbot/test/unit/test_db_connector.py M master/buildbot/test/unit/test_db_migrate_versions_011_add_buildrequest_claims.py A master/buildbot/test/unit/test_db_migrate_versions_021_fix_postgres_sequences.py A master/buildbot/test/unit/test_db_migrate_versions_022_add_codebase.py M master/buildbot/test/unit/test_db_pool.py M master/buildbot/test/unit/test_db_sourcestamps.py M master/buildbot/test/unit/test_master.py M master/buildbot/test/unit/test_process_botmaster_BotMaster.py M master/buildbot/test/unit/test_process_build.py M master/buildbot/test/unit/test_process_builder.py M master/buildbot/test/unit/test_process_buildrequest.py M master/buildbot/test/unit/test_process_debug.py A master/buildbot/test/unit/test_process_factory.py M master/buildbot/test/unit/test_process_properties.py M master/buildbot/test/unit/test_process_users_manager.py M master/buildbot/test/unit/test_schedulers_base.py M master/buildbot/test/unit/test_schedulers_basic.py M master/buildbot/test/unit/test_schedulers_dependent.py M master/buildbot/test/unit/test_schedulers_forcesched.py M master/buildbot/test/unit/test_schedulers_manager.py M master/buildbot/test/unit/test_schedulers_timed_Nightly.py M master/buildbot/test/unit/test_schedulers_triggerable.py M master/buildbot/test/unit/test_schedulers_trysched.py M master/buildbot/test/unit/test_scripts_checkconfig.py M master/buildbot/test/unit/test_scripts_runner.py M master/buildbot/test/unit/test_sourcestamp.py M master/buildbot/test/unit/test_status_logfile.py M master/buildbot/test/unit/test_status_master.py M master/buildbot/test/unit/test_status_web_change_hook.py M master/buildbot/test/unit/test_status_web_change_hooks_github.py A master/buildbot/test/unit/test_steps_package_rpm_rpmbuild.py M master/buildbot/test/unit/test_steps_shell.py A master/buildbot/test/unit/test_steps_source_base_Source.py A master/buildbot/test/unit/test_steps_source_oldsource_ComputeRepositoryURL.py R master/buildbot/test/unit/test_steps_source_oldsource_Source.py M master/buildbot/test/unit/test_steps_transfer.py M master/buildbot/test/unit/test_steps_trigger.py M master/buildbot/test/unit/test_util_lru.py M master/buildbot/test/unit/test_util_maildir.py M master/buildbot/test/util/change_import.py M master/buildbot/util/maildir.py R master/buildbot/util/monkeypatches.py R master/contrib/bk_buildbot.py A master/contrib/bzr_buildbot.py R master/contrib/bzr_buildbot.py R master/contrib/fix_changes_pickle_encoding.py A master/contrib/fix_changes_pickle_encoding.py M master/contrib/init-scripts/buildmaster.init.sh R master/docs/_images/header-text-transparent.png A master/docs/_images/header-text-transparent.png R master/docs/_static/buildbot.ico A master/docs/_static/buildbot.ico M master/docs/conf.py M master/docs/developer/config.rst M master/docs/developer/definitions.rst M master/docs/developer/encodings.rst M master/docs/developer/style.rst M master/docs/developer/webstatus.rst M master/docs/manual/cfg-builders.rst M master/docs/manual/cfg-buildsteps.rst M master/docs/manual/cfg-changesources.rst M master/docs/manual/cfg-global.rst M master/docs/manual/cfg-intro.rst M master/docs/manual/cfg-properties.rst M master/docs/manual/concepts.rst M master/docs/manual/installation.rst M master/docs/release-notes.rst A master/docs/release-notes/0.8.6.rst M master/setup.py A media/header-text-transparent.png R media/header-text-transparent.png R slave/NEWS R slave/buildslave/commands/bk.py M slave/buildslave/commands/registry.py R slave/buildslave/test/unit/test_commands_bk.py M slave/contrib/init-scripts/buildslave.init.sh M slave/setup.py Log Message: ----------- Merge remote-tracking branch 'upstream/master' into ticket_2169 Commit: c854a2f6ca5e9dfd7fe52e1faac928bba31fd63d https://github.com/buildbot/buildbot/commit/c854a2f6ca5e9dfd7fe52e1faac928bba31fd63d Author: William Deegan Date: 2012-03-12 (Mon, 12 Mar 2012) Changed paths: M master/buildbot/scripts/runner.py Log Message: ----------- changed to have default umask None, which should default the umask to twistd's default (currently 077) Commit: cfa13136a2a7f927b220320c381f9996644080c6 https://github.com/buildbot/buildbot/commit/cfa13136a2a7f927b220320c381f9996644080c6 Author: Dustin J. Mitchell Date: 2012-03-12 (Mon, 12 Mar 2012) Changed paths: M master/buildbot/master.py M master/buildbot/scripts/runner.py Log Message: ----------- Merge branch 'ticket_2169' of git://github.com/bdbaddog/buildbot * 'ticket_2169' of git://github.com/bdbaddog/buildbot: changed to have default umask None, which should default the umask to twistd's default (currently 077) Add umask to buildbot.tac which propagates and sets default umask for buildbot master. Ticket 2169 Compare: https://github.com/buildbot/buildbot/compare/dbd8a86...cfa1313 From nobody at buildbot.net Mon Mar 12 20:04:01 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 12 Mar 2012 20:04:01 -0000 Subject: [Buildbot-commits] [Buildbot] #2169: make umask on master configurable In-Reply-To: <040.3502b75d5f281edc33ea0d30f68e0617@buildbot.net> References: <040.3502b75d5f281edc33ea0d30f68e0617@buildbot.net> Message-ID: <055.6b1a43fdf6780585395f4d3f19e74be3@buildbot.net> #2169: make umask on master configurable ---------------------------+--------------------- Reporter: mverwijs | Owner: Type: enhancement | Status: closed Priority: minor | Milestone: 0.8.+ Version: 0.8.5 | Resolution: fixed Keywords: simple, sprint | ---------------------------+--------------------- Changes (by dustin): * status: new => closed * resolution: => fixed Comment: bdbaddog just fixed this: {{{ commit cfa13136a2a7f927b220320c381f9996644080c6 Merge: dbd8a86 c854a2f Author: Dustin J. Mitchell Date: Mon Mar 12 14:53:02 2012 -0500 Merge branch 'ticket_2169' of git://github.com/bdbaddog/buildbot * 'ticket_2169' of git://github.com/bdbaddog/buildbot: changed to have default umask None, which should default the umask to twistd's default (currently 077) Add umask to buildbot.tac which propagates and sets default umask for buildbot master. Ticket 2169 }}} -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Mar 12 20:24:45 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 12 Mar 2012 20:24:45 -0000 Subject: [Buildbot-commits] [Buildbot] #2077: DirectoryUpload creates missing directories with umode 077 In-Reply-To: <040.29904cf49ccbcea00440645b2bc68d50@buildbot.net> References: <040.29904cf49ccbcea00440645b2bc68d50@buildbot.net> Message-ID: <055.b32573c49aae9059506fed48f3456ba0@buildbot.net> #2077: DirectoryUpload creates missing directories with umode 077 ------------------------+------------------------ Reporter: dtrosset | Owner: Type: enhancement | Status: closed Priority: major | Milestone: 0.8.+ Version: 0.8.4p2 | Resolution: duplicate Keywords: sprint | ------------------------+------------------------ Changes (by bdbaddog): * status: new => closed * resolution: => duplicate Comment: This should be resolved by fix for #2169. Effectively a duplicate of 2169. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Mar 12 21:35:26 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 12 Mar 2012 21:35:26 -0000 Subject: [Buildbot-commits] [Buildbot] #1808: Scheduler with treeStableTimer "merges" changes to multiple projects into single SourceStamp In-Reply-To: <039.cd87665d300c4855d7e125d8690e0a31@buildbot.net> References: <039.cd87665d300c4855d7e125d8690e0a31@buildbot.net> Message-ID: <054.071364d0a44dd8edc326438962e30793@buildbot.net> #1808: Scheduler with treeStableTimer "merges" changes to multiple projects into single SourceStamp --------------------+-------------------- Reporter: aivarsk | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.3p1 | Resolution: Keywords: sprint | --------------------+-------------------- Comment (by jaredgrubb): I have a patch ready for this; I still need to test this on an actual production buildmaster, since the unit tests only test against a fake db. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Mon Mar 12 21:49:47 2012 From: noreply at github.com (GitHub) Date: Mon, 12 Mar 2012 14:49:47 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] bec38d: Merge branch 'none-buildreq-fix' of git://github.c... Message-ID: <4f5e6f7bac533_17aa1588ae42441fc@sh2.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: bec38d2adcb674de2547411e5cf17610b09d1872 https://github.com/buildbot/buildbot/commit/bec38d2adcb674de2547411e5cf17610b09d1872 Author: Dustin J. Mitchell Date: 2012-03-12 (Mon, 12 Mar 2012) Changed paths: M master/buildbot/status/buildrequest.py M master/buildbot/status/web/builder.py Log Message: ----------- Merge branch 'none-buildreq-fix' of git://github.com/djmitche/buildbot into buildbot-0.8.6 * 'none-buildreq-fix' of git://github.com/djmitche/buildbot: Do not rely on BuildRequestStatus._buildrequest being non-None Commit: 4f20e1a4cfd4876d4fc2b518570aad564602d23c https://github.com/buildbot/buildbot/commit/4f20e1a4cfd4876d4fc2b518570aad564602d23c Author: Dustin J. Mitchell Date: 2012-03-12 (Mon, 12 Mar 2012) Changed paths: M master/buildbot/status/buildrequest.py M master/buildbot/status/web/builder.py Log Message: ----------- Merge branch 'buildbot-0.8.6' * buildbot-0.8.6: Do not rely on BuildRequestStatus._buildrequest being non-None Conflicts: (over inlineCallbacks) master/buildbot/status/buildrequest.py master/buildbot/status/web/builder.py including a fix for non-yielded Deferreds Compare: https://github.com/buildbot/buildbot/compare/cfa1313...4f20e1a From noreply at github.com Mon Mar 12 21:49:46 2012 From: noreply at github.com (GitHub) Date: Mon, 12 Mar 2012 14:49:46 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 49c047: Do not rely on BuildRequestStatus._buildrequest be... Message-ID: <4f5e6f7aa8cc8_20263fa95f020aec110927@sh1.rs.github.com.mail> Branch: refs/heads/buildbot-0.8.6 Home: https://github.com/buildbot/buildbot Commit: 49c047dba3dfa49bd2a640478f40eb9248f96a63 https://github.com/buildbot/buildbot/commit/49c047dba3dfa49bd2a640478f40eb9248f96a63 Author: Dustin J. Mitchell Date: 2012-03-12 (Mon, 12 Mar 2012) Changed paths: M master/buildbot/status/buildrequest.py M master/buildbot/status/web/builder.py Log Message: ----------- Do not rely on BuildRequestStatus._buildrequest being non-None Nor even on _getBuildRequest -- add a getter instead. Commit: bec38d2adcb674de2547411e5cf17610b09d1872 https://github.com/buildbot/buildbot/commit/bec38d2adcb674de2547411e5cf17610b09d1872 Author: Dustin J. Mitchell Date: 2012-03-12 (Mon, 12 Mar 2012) Changed paths: M master/buildbot/status/buildrequest.py M master/buildbot/status/web/builder.py Log Message: ----------- Merge branch 'none-buildreq-fix' of git://github.com/djmitche/buildbot into buildbot-0.8.6 * 'none-buildreq-fix' of git://github.com/djmitche/buildbot: Do not rely on BuildRequestStatus._buildrequest being non-None Compare: https://github.com/buildbot/buildbot/compare/05d60d1...bec38d2 From noreply at github.com Mon Mar 12 23:06:39 2012 From: noreply at github.com (GitHub) Date: Mon, 12 Mar 2012 16:06:39 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 23e078: fix typos; h/t to pselle Message-ID: <4f5e817fc4ecf_1d663fe7472342f466088@sh1.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 23e078649af58d001a7ece498032cb10ca707cf3 https://github.com/buildbot/buildbot/commit/23e078649af58d001a7ece498032cb10ca707cf3 Author: Dustin J. Mitchell Date: 2012-03-12 (Mon, 12 Mar 2012) Changed paths: M master/docs/manual/cfg-schedulers.rst Log Message: ----------- fix typos; h/t to pselle Commit: b0716221eca3ec685a48771473d6266e0f6ed1c5 https://github.com/buildbot/buildbot/commit/b0716221eca3ec685a48771473d6266e0f6ed1c5 Author: Pam Selle Date: 2012-03-12 (Mon, 12 Mar 2012) Changed paths: M master/buildbot/schedulers/timed.py M master/buildbot/test/unit/test_schedulers_timed_Nightly.py A master/buildbot/util/croniter.py Log Message: ----------- More efficient Nightly next build algorithm. Fixes #1951 Added croniter under MIT license Some edge test cases are skipped Commit: 1d2c14b6c06c2bd1f37670fabc73e5a73a3f4e6d https://github.com/buildbot/buildbot/commit/1d2c14b6c06c2bd1f37670fabc73e5a73a3f4e6d Author: Pam Selle Date: 2012-03-12 (Mon, 12 Mar 2012) Changed paths: M master/buildbot/schedulers/timed.py M master/buildbot/util/croniter.py Log Message: ----------- Pyflakes fixes Fixed unused imports and variable errors from pyflakes Commit: 39d6eb8bcc2d5c2c0f1ec4d3f48115c4382671ec https://github.com/buildbot/buildbot/commit/39d6eb8bcc2d5c2c0f1ec4d3f48115c4382671ec Author: Dustin J. Mitchell Date: 2012-03-12 (Mon, 12 Mar 2012) Changed paths: M master/buildbot/schedulers/timed.py M master/docs/release-notes.rst M master/setup.py Log Message: ----------- Require python-dateutil==1.5, and only import it if using Nightly Refs #1951. Commit: f23540d74201ec1a7527ac8843acbd2163c7f433 https://github.com/buildbot/buildbot/commit/f23540d74201ec1a7527ac8843acbd2163c7f433 Author: Dustin J. Mitchell Date: 2012-03-12 (Mon, 12 Mar 2012) Changed paths: M master/buildbot/schedulers/timed.py M master/buildbot/test/unit/test_schedulers_timed_Nightly.py A master/buildbot/util/croniter.py M master/docs/release-notes.rst M master/setup.py Log Message: ----------- Merge branch 'croniter-compat' * croniter-compat: Require python-dateutil==1.5, and only import it if using Nightly Pyflakes fixes More efficient Nightly next build algorithm. Compare: https://github.com/buildbot/buildbot/compare/4f20e1a...f23540d From nobody at buildbot.net Mon Mar 12 23:06:47 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 12 Mar 2012 23:06:47 -0000 Subject: [Buildbot-commits] [Buildbot] #1951: Improve Nightly's next-build-finding algorithm In-Reply-To: <038.cadfd8cbd2ebf386bea86eaaf5cffd2a@buildbot.net> References: <038.cadfd8cbd2ebf386bea86eaaf5cffd2a@buildbot.net> Message-ID: <053.599f0a18f4684623f2dac043dd63abd5@buildbot.net> #1951: Improve Nightly's next-build-finding algorithm ----------------------------------------+--------------------- Reporter: dustin | Owner: Type: enhancement | Status: closed Priority: minor | Milestone: 0.8.+ Version: 0.8.3p1 | Resolution: fixed Keywords: performance, simple, sprint | ----------------------------------------+--------------------- Changes (by Pam Selle): * status: new => closed * resolution: => fixed Comment: More efficient Nightly next build algorithm. Fixes #1951 Added croniter under MIT license Some edge test cases are skipped Changeset: b0716221eca3ec685a48771473d6266e0f6ed1c5 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Mar 12 23:06:48 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 12 Mar 2012 23:06:48 -0000 Subject: [Buildbot-commits] [Buildbot] #1951: Improve Nightly's next-build-finding algorithm In-Reply-To: <038.cadfd8cbd2ebf386bea86eaaf5cffd2a@buildbot.net> References: <038.cadfd8cbd2ebf386bea86eaaf5cffd2a@buildbot.net> Message-ID: <053.3a4f6e6c05a9cd9ce8336cc8cfbfa08c@buildbot.net> #1951: Improve Nightly's next-build-finding algorithm ----------------------------------------+--------------------- Reporter: dustin | Owner: Type: enhancement | Status: closed Priority: minor | Milestone: 0.8.+ Version: 0.8.3p1 | Resolution: fixed Keywords: performance, simple, sprint | ----------------------------------------+--------------------- Comment (by Dustin J. Mitchell): Require python-dateutil==1.5, and only import it if using Nightly Refs #1951. Changeset: 39d6eb8bcc2d5c2c0f1ec4d3f48115c4382671ec -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Mon Mar 12 23:28:07 2012 From: noreply at github.com (GitHub) Date: Mon, 12 Mar 2012 16:28:07 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 74a7cb: Merge branch 'bug2126' of git://github.com/douglat... Message-ID: <4f5e86876925e_64293fbefafd2afc202067@sh1.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 74a7cb1012a733986c88f0e08625127b77d98348 https://github.com/buildbot/buildbot/commit/74a7cb1012a733986c88f0e08625127b77d98348 Author: Dustin J. Mitchell Date: 2012-03-12 (Mon, 12 Mar 2012) Changed paths: M master/buildbot/schedulers/trysched.py M master/buildbot/test/unit/test_schedulers_trysched.py Log Message: ----------- Merge branch 'bug2126' of git://github.com/douglatornell/buildbot * 'bug2126' of git://github.com/douglatornell/buildbot: PEP 8 cleanup; whitespace and long lines. Add creation of try jobdir & subdirs during master startup. Pyflake fixed in merge From noreply at github.com Tue Mar 13 00:04:24 2012 From: noreply at github.com (GitHub) Date: Mon, 12 Mar 2012 17:04:24 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] f7a7f2: mention python-dateutil requirement in requirement... Message-ID: <4f5e8f087b367_9371314aec189498@sh2.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: f7a7f2da7dedcd378cbde8967f318338c6a41c6b https://github.com/buildbot/buildbot/commit/f7a7f2da7dedcd378cbde8967f318338c6a41c6b Author: Dustin J. Mitchell Date: 2012-03-12 (Mon, 12 Mar 2012) Changed paths: M master/docs/manual/installation.rst Log Message: ----------- mention python-dateutil requirement in requirements Commit: a603baa790a3beaf96f1f84c3d4368ef524756f0 https://github.com/buildbot/buildbot/commit/a603baa790a3beaf96f1f84c3d4368ef524756f0 Author: Dustin J. Mitchell Date: 2012-03-12 (Mon, 12 Mar 2012) Changed paths: M master/buildbot/scripts/runner.py A master/buildbot/status/web/files/templates_readme.txt Log Message: ----------- Merge branch 'ticket_1800' of git://github.com/bdbaddog/buildbot * 'ticket_1800' of git://github.com/bdbaddog/buildbot: create readme file for templates directory when running create-master. Fixes #1800 Compare: https://github.com/buildbot/buildbot/compare/74a7cb1...a603baa From nobody at buildbot.net Tue Mar 13 00:04:30 2012 From: nobody at buildbot.net (Buildbot) Date: Tue, 13 Mar 2012 00:04:30 -0000 Subject: [Buildbot-commits] [Buildbot] #1800: Automatically create "templates" folder with explanatory "readme.txt" on create/update master In-Reply-To: <039.c1df8e027943a49015f72fd5783fca61@buildbot.net> References: <039.c1df8e027943a49015f72fd5783fca61@buildbot.net> Message-ID: <054.471c7996600d4c862e8fa8b45e37398a@buildbot.net> #1800: Automatically create "templates" folder with explanatory "readme.txt" on create/update master ------------------------+--------------------- Reporter: marcusl | Owner: Type: enhancement | Status: closed Priority: major | Milestone: 0.8.7 Version: 0.8.3p1 | Resolution: fixed Keywords: web, sprint | ------------------------+--------------------- Changes (by Dustin J. Mitchell): * status: new => closed * resolution: => fixed Comment: Merge branch 'ticket_1800' of git://github.com/bdbaddog/buildbot * 'ticket_1800' of git://github.com/bdbaddog/buildbot: create readme file for templates directory when running create-master. Fixes #1800 Changeset: a603baa790a3beaf96f1f84c3d4368ef524756f0 -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Tue Mar 13 00:30:31 2012 From: noreply at github.com (GitHub) Date: Mon, 12 Mar 2012 17:30:31 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 514ffa: fix tests on POSIX and add another Message-ID: <4f5e952774d69_673a3fd4d99d62f8200299@sh1.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 514ffac4bee6c4b87c9b3df40a92018ea885d694 https://github.com/buildbot/buildbot/commit/514ffac4bee6c4b87c9b3df40a92018ea885d694 Author: Dustin J. Mitchell Date: 2012-03-12 (Mon, 12 Mar 2012) Changed paths: M slave/buildslave/test/unit/test_runprocess.py Log Message: ----------- fix tests on POSIX and add another Commit: 6ab99c4f4781d94b4bb8a5556e4237537b7bfbd6 https://github.com/buildbot/buildbot/commit/6ab99c4f4781d94b4bb8a5556e4237537b7bfbd6 Author: Dustin J. Mitchell Date: 2012-03-12 (Mon, 12 Mar 2012) Changed paths: M slave/buildslave/runprocess.py M slave/buildslave/test/unit/test_runprocess.py Log Message: ----------- Merge branch 'bug377' * bug377: fix tests on POSIX and add another Added regression test Fix for #377 Compare: https://github.com/buildbot/buildbot/compare/a603baa...6ab99c4 From noreply at github.com Tue Mar 13 00:40:12 2012 From: noreply at github.com (GitHub) Date: Mon, 12 Mar 2012 17:40:12 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] f378e7: context manages are not available on the slave Message-ID: <4f5e976c636ca_1d663fe7472342f490345@sh1.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: f378e730b9c3ebb8a1c53a37391e775ec4d918f1 https://github.com/buildbot/buildbot/commit/f378e730b9c3ebb8a1c53a37391e775ec4d918f1 Author: Dustin J. Mitchell Date: 2012-03-12 (Mon, 12 Mar 2012) Changed paths: M slave/buildslave/runprocess.py Log Message: ----------- context manages are not available on the slave From noreply at github.com Tue Mar 13 01:27:02 2012 From: noreply at github.com (GitHub) Date: Mon, 12 Mar 2012 18:27:02 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] ea2bb9: add tests for create-master options Message-ID: <4f5ea266d217f_4971adcaf435171@sh2.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: ea2bb9e96c723604a0cb8ce742d8bfa438637cd2 https://github.com/buildbot/buildbot/commit/ea2bb9e96c723604a0cb8ce742d8bfa438637cd2 Author: Dustin J. Mitchell Date: 2012-03-12 (Mon, 12 Mar 2012) Changed paths: M master/buildbot/test/unit/test_scripts_runner.py Log Message: ----------- add tests for create-master options From noreply at github.com Tue Mar 13 02:23:59 2012 From: noreply at github.com (GitHub) Date: Mon, 12 Mar 2012 19:23:59 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] bb724b: Add the ability to check for the existence of remo... Message-ID: <4f5eafbf43adf_33c13ff59aed82ec1292f@sh1.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: bb724b7c874571e4c87cb3382ab7509286271228 https://github.com/buildbot/buildbot/commit/bb724b7c874571e4c87cb3382ab7509286271228 Author: Dustin J. Mitchell Date: 2012-03-12 (Mon, 12 Mar 2012) Changed paths: M master/buildbot/test/fake/remotecommand.py M master/buildbot/test/util/steps.py Log Message: ----------- Add the ability to check for the existence of remote command args that are not actually comparable Commit: ce3cfd3605ec371552c2c6749c4904cbc2af7ad1 https://github.com/buildbot/buildbot/commit/ce3cfd3605ec371552c2c6749c4904cbc2af7ad1 Author: Dustin J. Mitchell Date: 2012-03-12 (Mon, 12 Mar 2012) Changed paths: M master/buildbot/test/unit/test_changes_gitpoller.py Log Message: ----------- add tests for gitpoller's default gitbin Commit: 498951ee9efbe812c04f9d977772f2f8465b9fa3 https://github.com/buildbot/buildbot/commit/498951ee9efbe812c04f9d977772f2f8465b9fa3 Author: Dustin J. Mitchell Date: 2012-03-12 (Mon, 12 Mar 2012) Changed paths: M master/buildbot/changes/gitpoller.py Log Message: ----------- the actual fix - include os.environ when running rev-parse Commit: 021f812509044b5fd0e1b1969fe83a28bd55c445 https://github.com/buildbot/buildbot/commit/021f812509044b5fd0e1b1969fe83a28bd55c445 Author: Dustin J. Mitchell Date: 2012-03-12 (Mon, 12 Mar 2012) Changed paths: M master/buildbot/changes/gitpoller.py M master/buildbot/test/unit/test_changes_gitpoller.py Log Message: ----------- Merge remote-tracking branch 'lorentz/gitpoller-gitbin-which' * lorentz/gitpoller-gitbin-which: the actual fix - include os.environ when running rev-parse add tests for gitpoller's default gitbin Make GitPoller search for git if not specified Commit: 006ea7e15af5b54370f17aaa02a19121965a0a9b https://github.com/buildbot/buildbot/commit/006ea7e15af5b54370f17aaa02a19121965a0a9b Author: Dustin J. Mitchell Date: 2012-03-12 (Mon, 12 Mar 2012) Changed paths: M master/buildbot/test/fake/remotecommand.py M master/buildbot/test/util/steps.py Log Message: ----------- Merge branch 'expect-incomparable' * expect-incomparable: Add the ability to check for the existence of remote command args that are not actually comparable Compare: https://github.com/buildbot/buildbot/compare/ea2bb9e...006ea7e From noreply at github.com Tue Mar 13 02:27:43 2012 From: noreply at github.com (GitHub) Date: Mon, 12 Mar 2012 19:27:43 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 5cae8d: defer.returnValue does not need to be yielded Message-ID: <4f5eb09f761bf_4981c4fae48723d@sh2.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 5cae8d20e8843894d6aca155db8149c7d2f78a7b https://github.com/buildbot/buildbot/commit/5cae8d20e8843894d6aca155db8149c7d2f78a7b Author: Dustin J. Mitchell Date: 2012-03-12 (Mon, 12 Mar 2012) Changed paths: M master/buildbot/db/sourcestamps.py M master/buildbot/status/web/console.py M master/buildbot/status/web/grid.py M master/buildbot/status/web/root.py M master/buildbot/status/web/slaves.py M master/buildbot/status/web/status_json.py M master/buildbot/status/web/users.py M master/buildbot/steps/source/cvs.py M master/buildbot/steps/source/git.py M master/buildbot/steps/source/svn.py M master/docs/developer/style.rst M master/docs/developer/webstatus.rst Log Message: ----------- defer.returnValue does not need to be yielded From noreply at github.com Tue Mar 13 02:32:33 2012 From: noreply at github.com (GitHub) Date: Mon, 12 Mar 2012 19:32:33 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 87b431: do not require email-address formatting if the fie... Message-ID: <4f5eb1c1a0e09_33c13ff59aed82ec131642@sh1.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 87b4314a5bc9447ebcc8283a28a5ea6cdd89077a https://github.com/buildbot/buildbot/commit/87b4314a5bc9447ebcc8283a28a5ea6cdd89077a Author: Dustin J. Mitchell Date: 2012-03-12 (Mon, 12 Mar 2012) Changed paths: M master/buildbot/schedulers/forcesched.py Log Message: ----------- do not require email-address formatting if the field is not required From noreply at github.com Tue Mar 13 02:40:31 2012 From: noreply at github.com (GitHub) Date: Mon, 12 Mar 2012 19:40:31 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] b0886c: fix typo Message-ID: <4f5eb39fbed0d_193316d0af051666@sh2.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: b0886c6154e89d0d66a7a637e60abc054140185e https://github.com/buildbot/buildbot/commit/b0886c6154e89d0d66a7a637e60abc054140185e Author: Dustin J. Mitchell Date: 2012-03-12 (Mon, 12 Mar 2012) Changed paths: M master/buildbot/test/unit/test_schedulers_trysched.py Log Message: ----------- fix typo From noreply at github.com Tue Mar 13 04:30:57 2012 From: noreply at github.com (GitHub) Date: Mon, 12 Mar 2012 21:30:57 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 8a8f18: Restore individual cancel-build buttons Message-ID: <4f5ecd817c8de_59c93fe5620e02f444354@sh1.rs.github.com.mail> Branch: refs/heads/buildbot-0.8.6 Home: https://github.com/buildbot/buildbot Commit: 8a8f18b4f0b3dcdf29f3cd703aae83925db0a71a https://github.com/buildbot/buildbot/commit/8a8f18b4f0b3dcdf29f3cd703aae83925db0a71a Author: Dustin J. Mitchell Date: 2012-03-12 (Mon, 12 Mar 2012) Changed paths: M master/buildbot/status/web/templates/forms.html Log Message: ----------- Restore individual cancel-build buttons These were hidden by an errant edit when web auth was added. Previously, the buttons would only be displayed when a username/password form was not required; that unique logic is no longer necessary. From noreply at github.com Tue Mar 13 04:31:00 2012 From: noreply at github.com (GitHub) Date: Mon, 12 Mar 2012 21:31:00 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 8a8f18: Restore individual cancel-build buttons Message-ID: <4f5ecd841a86d_484c3fa5a1f55aec9562e@sh1.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 8a8f18b4f0b3dcdf29f3cd703aae83925db0a71a https://github.com/buildbot/buildbot/commit/8a8f18b4f0b3dcdf29f3cd703aae83925db0a71a Author: Dustin J. Mitchell Date: 2012-03-12 (Mon, 12 Mar 2012) Changed paths: M master/buildbot/status/web/templates/forms.html Log Message: ----------- Restore individual cancel-build buttons These were hidden by an errant edit when web auth was added. Previously, the buttons would only be displayed when a username/password form was not required; that unique logic is no longer necessary. Commit: 2f22b52ec9aee694ab7df313267e17c2f6f0ba87 https://github.com/buildbot/buildbot/commit/2f22b52ec9aee694ab7df313267e17c2f6f0ba87 Author: Dustin J. Mitchell Date: 2012-03-12 (Mon, 12 Mar 2012) Changed paths: M master/buildbot/status/web/templates/forms.html Log Message: ----------- Merge branch 'buildbot-0.8.6' * buildbot-0.8.6: Restore individual cancel-build buttons Compare: https://github.com/buildbot/buildbot/compare/b0886c6...2f22b52 From noreply at github.com Tue Mar 13 05:13:13 2012 From: noreply at github.com (GitHub) Date: Mon, 12 Mar 2012 22:13:13 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] a87bf4: Fixes #1799 Message-ID: <4f5ed769d5cca_4f4a3f8991933af0679da@sh1.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: a87bf4ebee80c9f7d90ffb491aeb51cbf0d231a5 https://github.com/buildbot/buildbot/commit/a87bf4ebee80c9f7d90ffb491aeb51cbf0d231a5 Author: Nate Bragg Date: 2012-03-12 (Mon, 12 Mar 2012) Changed paths: M slave/buildslave/runprocess.py M slave/buildslave/test/unit/test_runprocess.py M slave/buildslave/test/util/compat.py Log Message: ----------- Fixes #1799 This patch escapes all pipes in list commands that do not occur by themself. This addresses the problem passing in Visual Studio configuration names, which in their commands are by default patterned like [...,"Release|Win32",...], which can't be parsed by the shell. However, this does not touch two different conditions: lone pipes in a command list (e.g., ['a','|','b'] assumes you want to pipe the output of a into b) and pipes inside string commands (e.g., where the full command is "a | b", not in a list, it is assumed that you don't want an escaped pipe). Additionally, this commit adds a skip decorator for the platform, to clean up that syntax. Commit: f8eadc25321689873e736cc4947b3047ed815c30 https://github.com/buildbot/buildbot/commit/f8eadc25321689873e736cc4947b3047ed815c30 Author: Nate Bragg Date: 2012-03-12 (Mon, 12 Mar 2012) Changed paths: M master/docs/manual/cfg-buildsteps.rst Log Message: ----------- Added pipe-escaping doc Commit: 69fc8309fe6f9b050434f7db43cd9d5faa9229cb https://github.com/buildbot/buildbot/commit/69fc8309fe6f9b050434f7db43cd9d5faa9229cb Author: Dustin J. Mitchell Date: 2012-03-12 (Mon, 12 Mar 2012) Changed paths: M master/docs/manual/cfg-buildsteps.rst M slave/buildslave/runprocess.py M slave/buildslave/test/unit/test_runprocess.py M slave/buildslave/test/util/compat.py Log Message: ----------- Merge branch '1799' of git://github.com/NateBragg/buildbot * '1799' of git://github.com/NateBragg/buildbot: Added pipe-escaping doc Fixes #1799 Whitespace (tabs) fixed in the merge Compare: https://github.com/buildbot/buildbot/compare/2f22b52...69fc830 From nobody at buildbot.net Tue Mar 13 05:13:24 2012 From: nobody at buildbot.net (Buildbot) Date: Tue, 13 Mar 2012 05:13:24 -0000 Subject: [Buildbot-commits] [Buildbot] #1799: Fix pipe symbol with ^ workaround In-Reply-To: <036.70f4fc784899f73c738eab2f8aaa9bdc@buildbot.net> References: <036.70f4fc784899f73c738eab2f8aaa9bdc@buildbot.net> Message-ID: <051.6e759a6255fe6a2f0952b726a38e2796@buildbot.net> #1799: Fix pipe symbol with ^ workaround ----------------------------+--------------------- Reporter: todd | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.+ Version: 0.8.3p1 | Resolution: fixed Keywords: windows, sprint | ----------------------------+--------------------- Comment (by Dustin J. Mitchell): Merge branch '1799' of git://github.com/NateBragg/buildbot * '1799' of git://github.com/NateBragg/buildbot: Added pipe-escaping doc Fixes #1799 Whitespace (tabs) fixed in the merge Changeset: 69fc8309fe6f9b050434f7db43cd9d5faa9229cb -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Tue Mar 13 05:13:24 2012 From: nobody at buildbot.net (Buildbot) Date: Tue, 13 Mar 2012 05:13:24 -0000 Subject: [Buildbot-commits] [Buildbot] #1799: Fix pipe symbol with ^ workaround In-Reply-To: <036.70f4fc784899f73c738eab2f8aaa9bdc@buildbot.net> References: <036.70f4fc784899f73c738eab2f8aaa9bdc@buildbot.net> Message-ID: <051.e3b0a21393578430971b4eef15c6a39c@buildbot.net> #1799: Fix pipe symbol with ^ workaround ----------------------------+--------------------- Reporter: todd | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.+ Version: 0.8.3p1 | Resolution: fixed Keywords: windows, sprint | ----------------------------+--------------------- Changes (by Nate Bragg): * status: new => closed * resolution: => fixed Comment: Fixes #1799 This patch escapes all pipes in list commands that do not occur by themself. This addresses the problem passing in Visual Studio configuration names, which in their commands are by default patterned like [...,"Release|Win32",...], which can't be parsed by the shell. However, this does not touch two different conditions: lone pipes in a command list (e.g., ['a','|','b'] assumes you want to pipe the output of a into b) and pipes inside string commands (e.g., where the full command is "a | b", not in a list, it is assumed that you don't want an escaped pipe). Additionally, this commit adds a skip decorator for the platform, to clean up that syntax. Changeset: a87bf4ebee80c9f7d90ffb491aeb51cbf0d231a5 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Tue Mar 13 05:14:36 2012 From: nobody at buildbot.net (Buildbot) Date: Tue, 13 Mar 2012 05:14:36 -0000 Subject: [Buildbot-commits] [Buildbot] #928: Allow builder to be associated with multiple categories In-Reply-To: <038.51386ed5975d423860b7df3ecfae8e27@buildbot.net> References: <038.51386ed5975d423860b7df3ecfae8e27@buildbot.net> Message-ID: <053.23bd3fa8fd2c880c32be14df6b46eaf7@buildbot.net> #928: Allow builder to be associated with multiple categories ------------------------+-------------------- Reporter: stefan | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.0 | Resolution: Keywords: sprint | ------------------------+-------------------- Comment (by jaredgrubb): Have a patch in progress. Per discussion with Dustin today at the sprint, the approach is: * deprecate the use of categories w.r.t builders (but not changes) * a builder now has 'tags' * a category set on a builder (or specified in a web status url) will just really alias as a tag * updating grid, t-grid, waterfall, mail, and feed -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Tue Mar 13 05:18:03 2012 From: noreply at github.com (GitHub) Date: Mon, 12 Mar 2012 22:18:03 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 68a15b: Merge branch 'bug2126' of git://github.com/douglat... Message-ID: <4f5ed88b9468_4926de1ae82203f@sh2.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 68a15ba4397da56f11025ee853febe42b482ce19 https://github.com/buildbot/buildbot/commit/68a15ba4397da56f11025ee853febe42b482ce19 Author: Dustin J. Mitchell Date: 2012-03-12 (Mon, 12 Mar 2012) Changed paths: M master/buildbot/clients/tryclient.py M master/buildbot/schedulers/trysched.py A master/buildbot/test/unit/test_clients_tryclient.py M master/buildbot/test/unit/test_schedulers_trysched.py Log Message: ----------- Merge branch 'bug2126' of git://github.com/douglatornell/buildbot * 'bug2126' of git://github.com/douglatornell/buildbot: Add property handling for Try_Jobdir (ssh) scheduler re: #2126. Refs #2126. From nobody at buildbot.net Tue Mar 13 05:18:13 2012 From: nobody at buildbot.net (Buildbot) Date: Tue, 13 Mar 2012 05:18:13 -0000 Subject: [Buildbot-commits] [Buildbot] #2126: buildbot try --properties=prop=value doesn't work with try_jobdir In-Reply-To: <035.99c90048ac5befbeb80a67a3e92d2cee@buildbot.net> References: <035.99c90048ac5befbeb80a67a3e92d2cee@buildbot.net> Message-ID: <050.c966ab4aa4a4b7ae7e77add3780506f5@buildbot.net> #2126: buildbot try --properties=prop=value doesn't work with try_jobdir ------------------------+-------------------- Reporter: gg0 | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.5 | Resolution: Keywords: try, sprint | ------------------------+-------------------- Comment (by Dustin J. Mitchell): Merge branch 'bug2126' of git://github.com/douglatornell/buildbot * 'bug2126' of git://github.com/douglatornell/buildbot: Add property handling for Try_Jobdir (ssh) scheduler re: #2126. Refs #2126. Changeset: 68a15ba4397da56f11025ee853febe42b482ce19 -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Tue Mar 13 17:32:18 2012 From: noreply at github.com (GitHub) Date: Tue, 13 Mar 2012 10:32:18 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 14c0ee: Merge branch 'none_pid' of git://github.com/NateBr... Message-ID: <4f5f84a264eed_2fd63f8f5a78e2f89182e@sh1.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 14c0eedea2051012492f658906c2f6f4df076f5b https://github.com/buildbot/buildbot/commit/14c0eedea2051012492f658906c2f6f4df076f5b Author: Dustin J. Mitchell Date: 2012-03-13 (Tue, 13 Mar 2012) Changed paths: M slave/buildslave/runprocess.py Log Message: ----------- Merge branch 'none_pid' of git://github.com/NateBragg/buildbot * 'none_pid' of git://github.com/NateBragg/buildbot: A bad PID still fails, but gives a cleaner traceback From nobody at buildbot.net Tue Mar 13 17:50:26 2012 From: nobody at buildbot.net (Buildbot) Date: Tue, 13 Mar 2012 17:50:26 -0000 Subject: [Buildbot-commits] [Buildbot] #2242: Include the favicon explicitly in the template Message-ID: <037.84d5ed27b0d150be2a843f5fc3298c11@buildbot.net> #2242: Include the favicon explicitly in the template ------------------------+------------------- Reporter: Unode | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.7 Version: 0.8.5 | Keywords: ------------------------+------------------- Under some conditions the favicon may not be loaded by the browser. Adding it explicitly to the template solves the most common issues. Attached is a simple patch that does exactly that. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Tue Mar 13 17:55:28 2012 From: nobody at buildbot.net (Buildbot) Date: Tue, 13 Mar 2012 17:55:28 -0000 Subject: [Buildbot-commits] [Buildbot] #2243: Include the favicon explicitly in the template Message-ID: <037.be4f3be60e0e361bd1616ff935275ade@buildbot.net> #2243: Include the favicon explicitly in the template ------------------------+------------------- Reporter: Unode | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.7 Version: 0.8.5 | Keywords: ------------------------+------------------- Under some conditions the favicon may not be loaded by the browser. Adding it explicitly to the template solves the most common issues. Attached is a simple patch that does exactly that. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Tue Mar 13 18:00:29 2012 From: nobody at buildbot.net (Buildbot) Date: Tue, 13 Mar 2012 18:00:29 -0000 Subject: [Buildbot-commits] [Buildbot] #2242: Include the favicon explicitly in the template In-Reply-To: <037.84d5ed27b0d150be2a843f5fc3298c11@buildbot.net> References: <037.84d5ed27b0d150be2a843f5fc3298c11@buildbot.net> Message-ID: <052.814957dbaf0049e9dac40df12084b687@buildbot.net> #2242: Include the favicon explicitly in the template ------------------------+-------------------- Reporter: Unode | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.7 Version: 0.8.5 | Resolution: Keywords: | ------------------------+-------------------- Comment (by dustin): I don't see an attachment? -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Tue Mar 13 18:01:16 2012 From: nobody at buildbot.net (Buildbot) Date: Tue, 13 Mar 2012 18:01:16 -0000 Subject: [Buildbot-commits] [Buildbot] #2243: Include the favicon explicitly in the template In-Reply-To: <037.be4f3be60e0e361bd1616ff935275ade@buildbot.net> References: <037.be4f3be60e0e361bd1616ff935275ade@buildbot.net> Message-ID: <052.4399cbe1d6c97ae664db1c348308a405@buildbot.net> #2243: Include the favicon explicitly in the template ------------------------+------------------------ Reporter: Unode | Owner: Type: enhancement | Status: closed Priority: minor | Milestone: 0.8.7 Version: 0.8.5 | Resolution: duplicate Keywords: | ------------------------+------------------------ Changes (by Unode): * status: new => closed * resolution: => duplicate Comment: Duplicate of #2242 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Tue Mar 13 18:03:35 2012 From: nobody at buildbot.net (Buildbot) Date: Tue, 13 Mar 2012 18:03:35 -0000 Subject: [Buildbot-commits] [Buildbot] #2242: Include the favicon explicitly in the template In-Reply-To: <037.84d5ed27b0d150be2a843f5fc3298c11@buildbot.net> References: <037.84d5ed27b0d150be2a843f5fc3298c11@buildbot.net> Message-ID: <052.60effbf99bf129e685b4b48c4c5d1413@buildbot.net> #2242: Include the favicon explicitly in the template ------------------------+-------------------- Reporter: Unode | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.7 Version: 0.8.5 | Resolution: Keywords: | ------------------------+-------------------- Comment (by Unode): Akismet is not letting me add the attachment. Keeps complaining it's spam. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Tue Mar 13 18:20:20 2012 From: noreply at github.com (GitHub) Date: Tue, 13 Mar 2012 11:20:20 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] e4c2d2: Add favicon explicitly on the template, relative t... Message-ID: <4f5f8fe445415_8e517dcae8120446@sh2.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: e4c2d26441c11d4dd0baf289b289c8f7ec405127 https://github.com/buildbot/buildbot/commit/e4c2d26441c11d4dd0baf289b289c8f7ec405127 Author: Renato Alves Date: 2012-03-13 (Tue, 13 Mar 2012) Changed paths: M master/buildbot/status/web/templates/layout.html Log Message: ----------- Add favicon explicitly on the template, relative to the project root From nobody at buildbot.net Tue Mar 13 18:21:13 2012 From: nobody at buildbot.net (Buildbot) Date: Tue, 13 Mar 2012 18:21:13 -0000 Subject: [Buildbot-commits] [Buildbot] #2242: Include the favicon explicitly in the template In-Reply-To: <037.84d5ed27b0d150be2a843f5fc3298c11@buildbot.net> References: <037.84d5ed27b0d150be2a843f5fc3298c11@buildbot.net> Message-ID: <052.0078d5a93039f289b181e654a9c4c294@buildbot.net> #2242: Include the favicon explicitly in the template ------------------------+--------------------- Reporter: Unode | Owner: Type: enhancement | Status: closed Priority: minor | Milestone: 0.8.7 Version: 0.8.5 | Resolution: fixed Keywords: | ------------------------+--------------------- Changes (by dustin): * status: new => closed * resolution: => fixed Comment: Unode pastebinned it to me: {{{ !patch From 0bdc5f305753dc755743bc40e6bd3d0aabddef19 Mon Sep 17 00:00:00 2001 From: Renato Alves Date: Tue, 13 Mar 2012 17:50:49 +0000 Subject: [PATCH] Add favicon explicitly on the template, relative to the project root --- master/buildbot/status/web/templates/layout.html | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/master/buildbot/status/web/templates/layout.html b/master/buildbot/status/web/templates/layout.html index b70a36e..3c25a93 100644 --- a/master/buildbot/status/web/templates/layout.html +++ b/master/buildbot/status/web/templates/layout.html @@ -15,6 +15,7 @@ {{ pageTitle|e }} + {% endblock %} -- 1.7.5.4 }}} and it's applied. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Tue Mar 13 18:28:21 2012 From: noreply at github.com (GitHub) Date: Tue, 13 Mar 2012 11:28:21 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 2b6708: Merge branch 'missing-buildslave-properties' of gi... Message-ID: <4f5f91c58695c_8e517dcae81219a0@sh2.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 2b6708eb90165f48a815d9a7e422971899fc1208 https://github.com/buildbot/buildbot/commit/2b6708eb90165f48a815d9a7e422971899fc1208 Author: Dustin J. Mitchell Date: 2012-03-13 (Tue, 13 Mar 2012) Changed paths: M master/buildbot/buildslave.py M master/buildbot/test/unit/test_buildslave.py Log Message: ----------- Merge branch 'missing-buildslave-properties' of git://github.com/tomprince/buildbot into buildbot-0.8.6 * 'missing-buildslave-properties' of git://github.com/tomprince/buildbot: Fix population of slave properties on initial config. Commit: 9224d77e7b6f71c7dd156939f476d251090d9d07 https://github.com/buildbot/buildbot/commit/9224d77e7b6f71c7dd156939f476d251090d9d07 Author: Dustin J. Mitchell Date: 2012-03-13 (Tue, 13 Mar 2012) Changed paths: M master/buildbot/buildslave.py M master/buildbot/test/unit/test_buildslave.py Log Message: ----------- Merge branch 'buildbot-0.8.6' * buildbot-0.8.6: Fix population of slave properties on initial config. Conflicts: master/buildbot/test/unit/test_buildslave.py (inlineCallbacks vs. deferredGenerator) Compare: https://github.com/buildbot/buildbot/compare/e4c2d26...9224d77 From noreply at github.com Tue Mar 13 18:28:19 2012 From: noreply at github.com (GitHub) Date: Tue, 13 Mar 2012 11:28:19 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 2b6708: Merge branch 'missing-buildslave-properties' of gi... Message-ID: <4f5f91c3b9723_46b23fd175ef7af077577@sh1.rs.github.com.mail> Branch: refs/heads/buildbot-0.8.6 Home: https://github.com/buildbot/buildbot Commit: 2b6708eb90165f48a815d9a7e422971899fc1208 https://github.com/buildbot/buildbot/commit/2b6708eb90165f48a815d9a7e422971899fc1208 Author: Dustin J. Mitchell Date: 2012-03-13 (Tue, 13 Mar 2012) Changed paths: M master/buildbot/buildslave.py M master/buildbot/test/unit/test_buildslave.py Log Message: ----------- Merge branch 'missing-buildslave-properties' of git://github.com/tomprince/buildbot into buildbot-0.8.6 * 'missing-buildslave-properties' of git://github.com/tomprince/buildbot: Fix population of slave properties on initial config. From noreply at github.com Tue Mar 13 18:30:36 2012 From: noreply at github.com (GitHub) Date: Tue, 13 Mar 2012 11:30:36 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 41e330: Merge branch 'mastershellcmd_improvements' of git:... Message-ID: <4f5f924c71c5a_2bee1227ae45699f@sh2.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 41e3308fd68baa5b01f250a0e6d8e4893004606f https://github.com/buildbot/buildbot/commit/41e3308fd68baa5b01f250a0e6d8e4893004606f Author: Dustin J. Mitchell Date: 2012-03-13 (Tue, 13 Mar 2012) Changed paths: M master/buildbot/steps/master.py M master/buildbot/test/unit/test_steps_master.py M master/docs/manual/cfg-buildsteps.rst M slave/buildslave/runprocess.py Log Message: ----------- Merge branch 'mastershellcmd_improvements' of git://github.com/fpoirotte/buildbot * 'mastershellcmd_improvements' of git://github.com/fpoirotte/buildbot: Add tests & documentation. Improvements for MasterShellCommand's env. From nobody at buildbot.net Tue Mar 13 19:25:52 2012 From: nobody at buildbot.net (Buildbot) Date: Tue, 13 Mar 2012 19:25:52 -0000 Subject: [Buildbot-commits] [Buildbot] #2139: locks held by slaves are not released when slave goes missing In-Reply-To: <039.9c45009795e8e9815fcee44f137bd228@buildbot.net> References: <039.9c45009795e8e9815fcee44f137bd228@buildbot.net> Message-ID: <054.7b9f5dd7c3c8f2ab01cd747e35d9639f@buildbot.net> #2139: locks held by slaves are not released when slave goes missing --------------------+--------------------- Reporter: dwlocks | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.6 Version: 0.8.4p2 | Resolution: fixed Keywords: | --------------------+--------------------- Comment (by dwlocks): That should be self.releaseLocks() It's committed in dwlocks/buildbot-0.8.4 7d0212ff8ec3f6d17c95e4df8fff493e29634682 diff --git a/master/buildbot/buildslave.py b/master/buildbot/buildslave.py index e71d338..495544f 100644 --- a/master/buildbot/buildslave.py +++ b/master/buildbot/buildslave.py @@ -407,7 +407,7 @@ class AbstractBuildSlave(pb.Avatar, service.MultiService): log.msg("BuildSlave.detached(%s)" % self.slavename) self.botmaster.parent.status.slaveDisconnected(self.slavename) self.stopKeepaliveTimer() - self.release() + self.releaseLocks() def disconnect(self): """Forcibly disconnect the slave. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Tue Mar 13 21:27:14 2012 From: nobody at buildbot.net (Buildbot) Date: Tue, 13 Mar 2012 21:27:14 -0000 Subject: [Buildbot-commits] [Buildbot] #2139: locks held by slaves are not released when slave goes missing In-Reply-To: <039.9c45009795e8e9815fcee44f137bd228@buildbot.net> References: <039.9c45009795e8e9815fcee44f137bd228@buildbot.net> Message-ID: <054.d25d389f5a66298494d47dfbd84febd0@buildbot.net> #2139: locks held by slaves are not released when slave goes missing --------------------+--------------------- Reporter: dwlocks | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.6 Version: 0.8.4p2 | Resolution: fixed Keywords: | --------------------+--------------------- Comment (by dustin): Tom fixed this up already, but thanks for clarifying: {{{ #!patch commit 7d78de7d0b311ac34261a7e08eb951394c9ac734 Author: Tom Prince Date: Thu Jan 19 16:24:06 2012 -0500 Fix stupid type s/release/releaseLocks/. diff --git a/master/buildbot/buildslave.py b/master/buildbot/buildslave.py index b8c3c3a..cd5dae7 100644 --- a/master/buildbot/buildslave.py +++ b/master/buildbot/buildslave.py @@ -460,7 +460,7 @@ class AbstractBuildSlave(config.ReconfigurableServiceMixin, pb.Avatar, log.msg("BuildSlave.detached(%s)" % self.slavename) self.botmaster.master.status.slaveDisconnected(self.slavename) self.stopKeepaliveTimer() - self.release() + self.releaseLocks() # notify watchers, but do so in the next reactor iteration so that # any further detached() action by subclasses happens first }}} -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Tue Mar 13 23:25:02 2012 From: noreply at github.com (GitHub) Date: Tue, 13 Mar 2012 16:25:02 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] b05a1f: remove twisted-0.8.1-specific code Message-ID: <4f5fd74e82737_6f3c3f98881122f8997d6@sh1.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: b05a1fd515dc6e82a177eabfd5fbea5d35e3a718 https://github.com/buildbot/buildbot/commit/b05a1fd515dc6e82a177eabfd5fbea5d35e3a718 Author: Dustin J. Mitchell Date: 2012-03-13 (Tue, 13 Mar 2012) Changed paths: M master/buildbot/db/pool.py Log Message: ----------- remove twisted-0.8.1-specific code From noreply at github.com Wed Mar 14 17:18:45 2012 From: noreply at github.com (GitHub) Date: Wed, 14 Mar 2012 10:18:45 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 69aa71: Revert "Make GitPoller search for git if not speci... Message-ID: <4f60d2f5c3f46_70c112caf41842c0@sh2.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 69aa7184f15b30ed8c18c736216253bf999af07c https://github.com/buildbot/buildbot/commit/69aa7184f15b30ed8c18c736216253bf999af07c Author: Dustin J. Mitchell Date: 2012-03-14 (Wed, 14 Mar 2012) Changed paths: M master/buildbot/changes/gitpoller.py M master/buildbot/test/unit/test_changes_gitpoller.py Log Message: ----------- Revert "Make GitPoller search for git if not specified" This reverts commit 748c3b3649a19a00761c58aa0592a66b8c8e86fa, and subsequent test changes that correspond with it. I promised not to commit this, and then got distracted. It makes tests fail if git is not installed. From noreply at github.com Wed Mar 14 17:52:32 2012 From: noreply at github.com (GitHub) Date: Wed, 14 Mar 2012 10:52:32 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 746675: fix docs for buildbot user --op=get Message-ID: <4f60dae0dd28a_71073ffdac0d3aec52389@sh1.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 7466758ad2698c5d5f26b93f8980d8a86c9295fb https://github.com/buildbot/buildbot/commit/7466758ad2698c5d5f26b93f8980d8a86c9295fb Author: Dustin J. Mitchell Date: 2012-03-14 (Wed, 14 Mar 2012) Changed paths: M master/docs/manual/cmdline.rst Log Message: ----------- fix docs for buildbot user --op=get Thanks to Christian Unger From nobody at buildbot.net Wed Mar 14 18:05:30 2012 From: nobody at buildbot.net (Buildbot) Date: Wed, 14 Mar 2012 18:05:30 -0000 Subject: [Buildbot-commits] [Buildbot] #377: funny arg splitting for cmd.exe in some cases but not others In-Reply-To: <037.33f4c903f9e3c3d1df369b585b771fc4@buildbot.net> References: <037.33f4c903f9e3c3d1df369b585b771fc4@buildbot.net> Message-ID: <052.8b60e33ab1ba60408fe8936dfc9e2f39@buildbot.net> #377: funny arg splitting for cmd.exe in some cases but not others ----------------------------+--------------------- Reporter: zooko | Owner: Type: defect | Status: closed Priority: critical | Milestone: 0.8.+ Version: 0.7.9 | Resolution: fixed Keywords: windows, sprint | ----------------------------+--------------------- Changes (by dustin): * status: new => closed * resolution: => fixed Comment: This was fixed in {{{ commit d23a36634e80a705443db5997e302f74c34d4aca Author: Nate Bragg Date: Mon Mar 12 11:57:28 2012 -0400 Fix for #377 This works around the impedance mismatch between twisted and window's cmd.exe when it comes to properly escaping spaces, while preserving current list command escaping. }}} -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Mar 14 18:09:08 2012 From: nobody at buildbot.net (Buildbot) Date: Wed, 14 Mar 2012 18:09:08 -0000 Subject: [Buildbot-commits] [Buildbot] #2244: buildbot's sample config requires signing in to force builds now, but the tutorial doesn't document this. Message-ID: <042.2338f251fca63491ff969de1589a42a2@buildbot.net> #2244: buildbot's sample config requires signing in to force builds now, but the tutorial doesn't document this. -----------------------+----------------------- Reporter: tom.prince | Owner: Type: defect | Status: new Priority: critical | Milestone: undecided Version: 0.8.6 | Keywords: docs -----------------------+----------------------- -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Mar 14 18:24:51 2012 From: nobody at buildbot.net (Buildbot) Date: Wed, 14 Mar 2012 18:24:51 -0000 Subject: [Buildbot-commits] [Buildbot] #1854: FileUpload never times out In-Reply-To: <039.e7bfab756d445121a2e0b7af56f23535@buildbot.net> References: <039.e7bfab756d445121a2e0b7af56f23535@buildbot.net> Message-ID: <054.b18785091ceb8cb2d9fe6f7a5b4b61e9@buildbot.net> #1854: FileUpload never times out -----------------------------+----------------------- Reporter: exarkun | Owner: juanl Type: defect | Status: accepted Priority: critical | Milestone: 0.8.+ Version: 0.8.2 | Resolution: Keywords: transfer, sprint | -----------------------------+----------------------- Changes (by juanl): * owner: => juanl * status: new => accepted -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Mar 14 22:19:04 2012 From: nobody at buildbot.net (Buildbot) Date: Wed, 14 Mar 2012 22:19:04 -0000 Subject: [Buildbot-commits] [Buildbot] #1854: FileUpload never times out In-Reply-To: <039.e7bfab756d445121a2e0b7af56f23535@buildbot.net> References: <039.e7bfab756d445121a2e0b7af56f23535@buildbot.net> Message-ID: <054.ac31c45325591f7c6576ac42c66a8779@buildbot.net> #1854: FileUpload never times out -----------------------------+----------------------- Reporter: exarkun | Owner: juanl Type: defect | Status: accepted Priority: critical | Milestone: 0.8.+ Version: 0.8.2 | Resolution: Keywords: transfer, sprint | -----------------------------+----------------------- Comment (by Ben): I raised the same trouble with a full hard disk. The builder remained stuck in the upload step, reporting "uploading" (yellow: step in progress), where the logs clearly reported the OSError (err.html only, err.txt was empty), and the build status (at the top of the waterfall) also reported the exception (purple) but as happening on another step of the build ... I cleanly shutdown the master, after reboot, the build in question was not to be seen anywhere anymore ( it completely disappeared ). -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Wed Mar 14 22:38:54 2012 From: noreply at github.com (GitHub) Date: Wed, 14 Mar 2012 15:38:54 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] c4bef6: web: replace the content of the /users page with t... Message-ID: <4f611dfe50ddc_38a3f86a40122f4149611@sh1.rs.github.com.mail> Branch: refs/heads/buildbot-0.8.6 Home: https://github.com/buildbot/buildbot Commit: c4bef66682f3513f9ce83b765b5eba42b6891afe https://github.com/buildbot/buildbot/commit/c4bef66682f3513f9ce83b765b5eba42b6891afe Author: Benoit Allard Date: 2012-03-14 (Wed, 14 Mar 2012) Changed paths: M master/buildbot/status/web/templates/users.html R master/buildbot/status/web/templates/users_table.html M master/buildbot/status/web/users.py Log Message: ----------- web: replace the content of the /users page with the one of the /users/table The /users page was anyway broken since 43eb37b06ce5c75db9e7c6140782bde05b5a57a0 Commit: b6f92ab087eee878150a2990c40d3bc6026add15 https://github.com/buildbot/buildbot/commit/b6f92ab087eee878150a2990c40d3bc6026add15 Author: Tom Prince Date: 2012-03-14 (Wed, 14 Mar 2012) Changed paths: M master/buildbot/status/web/templates/users.html R master/buildbot/status/web/templates/users_table.html M master/buildbot/status/web/users.py Log Message: ----------- Merge pull request #356 from benallard/webusers web: replace the content of the /users page with the one of the /users/table Compare: https://github.com/buildbot/buildbot/compare/2b6708e...b6f92ab From noreply at github.com Wed Mar 14 23:15:29 2012 From: noreply at github.com (GitHub) Date: Wed, 14 Mar 2012 16:15:29 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 40dd92: Allow IRC message handlers to return deferreds. Message-ID: <4f612691b34d0_20a83fb8ca7372fc11212e@sh1.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 40dd927c90e8293fda812caa3e15eb1cf6e74fef https://github.com/buildbot/buildbot/commit/40dd927c90e8293fda812caa3e15eb1cf6e74fef Author: Tom Prince Date: 2012-03-14 (Wed, 14 Mar 2012) Changed paths: M master/buildbot/status/words.py M master/buildbot/test/unit/test_status_words.py Log Message: ----------- Allow IRC message handlers to return deferreds. From noreply at github.com Wed Mar 14 23:28:31 2012 From: noreply at github.com (GitHub) Date: Wed, 14 Mar 2012 16:28:31 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 4d8b00: Remove useless inlineCallback. Message-ID: <4f61299fda19d_14261858ae4128612@sh2.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 4d8b00177c162e000c2e91c36d68f3494e3f7438 https://github.com/buildbot/buildbot/commit/4d8b00177c162e000c2e91c36d68f3494e3f7438 Author: Tom Prince Date: 2012-03-14 (Wed, 14 Mar 2012) Changed paths: M master/buildbot/process/users/users.py Log Message: ----------- Remove useless inlineCallback. Commit: e0453151d0e721386480dc32ab0cd21ca9a570b3 https://github.com/buildbot/buildbot/commit/e0453151d0e721386480dc32ab0cd21ca9a570b3 Author: Tom Prince Date: 2012-03-14 (Wed, 14 Mar 2012) Changed paths: M master/buildbot/status/words.py Log Message: ----------- Fix pyflakes warnings. Compare: https://github.com/buildbot/buildbot/compare/40dd927...e045315 From noreply at github.com Thu Mar 15 00:20:09 2012 From: noreply at github.com (GitHub) Date: Wed, 14 Mar 2012 17:20:09 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 1b45c1: Fix TestFileUpload.testTimestamp Message-ID: <4f6135b96fa61_25351782ae89449d@sh2.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 1b45c144f664bcfc0c1ef23e7df66150ae8f6539 https://github.com/buildbot/buildbot/commit/1b45c144f664bcfc0c1ef23e7df66150ae8f6539 Author: Jorge Gonzalez Date: 2012-03-14 (Wed, 14 Mar 2012) Changed paths: M master/buildbot/test/unit/test_steps_transfer.py Log Message: ----------- Fix TestFileUpload.testTimestamp Not all filesystems (e.g. ext3) return a meaningful fractional part in in access and mod time timestamps. Coerce all values to int and just compare at the second granularity. Change-Id: I179b481fbc087814b813eb7c14141e828aec3ea9 Commit: 1ac0745532404f7d76fdb058ef524dfcf35ebfe7 https://github.com/buildbot/buildbot/commit/1ac0745532404f7d76fdb058ef524dfcf35ebfe7 Author: Tom Prince Date: 2012-03-14 (Wed, 14 Mar 2012) Changed paths: M master/buildbot/test/unit/test_steps_transfer.py Log Message: ----------- Merge pull request #357 from pepesaurio/TestFileUpload_fix Fix TestFileUpload.testTimestamp fractional support Compare: https://github.com/buildbot/buildbot/compare/e045315...1ac0745 From noreply at github.com Thu Mar 15 01:28:32 2012 From: noreply at github.com (GitHub) Date: Wed, 14 Mar 2012 18:28:32 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] caaef1: Fix pyflakes. Message-ID: <4f6145c0145c0_20a83fb8ca7372fc14338d@sh1.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: caaef11d82851f29d898011abea0be074d98e7d2 https://github.com/buildbot/buildbot/commit/caaef11d82851f29d898011abea0be074d98e7d2 Author: Tom Prince Date: 2012-03-14 (Wed, 14 Mar 2012) Changed paths: M master/buildbot/test/unit/test_steps_transfer.py Log Message: ----------- Fix pyflakes. From noreply at github.com Thu Mar 15 13:21:41 2012 From: noreply at github.com (GitHub) Date: Thu, 15 Mar 2012 06:21:41 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 502ed8: Merge pull request #361 from djmitche/faster-upgra... Message-ID: <4f61ece5c6401_7ff83fa2d88bcaf879970@sh1.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 502ed82bbe1e5760baf22f6bfd5f7b1b416dbc0b https://github.com/buildbot/buildbot/commit/502ed82bbe1e5760baf22f6bfd5f7b1b416dbc0b Author: Tom Prince Date: 2012-03-15 (Thu, 15 Mar 2012) Changed paths: M master/buildbot/db/migrate/versions/001_initial.py Log Message: ----------- Merge pull request #361 from djmitche/faster-upgrades don't populate change_links in db version 1 From nobody at buildbot.net Thu Mar 15 17:05:38 2012 From: nobody at buildbot.net (Buildbot) Date: Thu, 15 Mar 2012 17:05:38 -0000 Subject: [Buildbot-commits] [Buildbot] #1766: Can't pass extra arguments to SVNPoller In-Reply-To: <037.dc3f52f4b0f33e7254c85d2b5e27a3a5@buildbot.net> References: <037.dc3f52f4b0f33e7254c85d2b5e27a3a5@buildbot.net> Message-ID: <052.dcc8b6b801a7ed48863ab27886b2c5e8@buildbot.net> #1766: Can't pass extra arguments to SVNPoller ------------------------+----------------------- Reporter: fgsch | Owner: bdbaddog Type: enhancement | Status: assigned Priority: minor | Milestone: 0.8.+ Version: 0.8.3p1 | Resolution: Keywords: svn, sprint | ------------------------+----------------------- Changes (by bdbaddog): * owner: => bdbaddog * status: new => assigned Comment: Work in progress. Code is done, working on tests, then I'll send a pull request. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Thu Mar 15 18:40:34 2012 From: nobody at buildbot.net (Buildbot) Date: Thu, 15 Mar 2012 18:40:34 -0000 Subject: [Buildbot-commits] [Buildbot] #2245: grid.py Deferred instance has no attribute '__len__' Message-ID: <040.954b158d6fa780e365c8eecc45e2b031@buildbot.net> #2245: grid.py Deferred instance has no attribute '__len__' ----------------------+----------------------- Reporter: kevbroch | Owner: Type: undecided | Status: new Priority: major | Milestone: undecided Version: master | Keywords: ----------------------+----------------------- Clicking on grid link generates this: /Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site- packages/buildbot-0.8.6_166_g502ed82-py2.7.egg/buildbot/status/web/grid.py, line 81 in builder_cxt 79 state = "waiting" 80 81 n_pending = len(builder.getPendingBuildRequestStatuses()) 82 : Deferred instance has no attribute '__len__' -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Thu Mar 15 18:51:45 2012 From: nobody at buildbot.net (Buildbot) Date: Thu, 15 Mar 2012 18:51:45 -0000 Subject: [Buildbot-commits] [Buildbot] #2245: grid.py Deferred instance has no attribute '__len__' In-Reply-To: <040.954b158d6fa780e365c8eecc45e2b031@buildbot.net> References: <040.954b158d6fa780e365c8eecc45e2b031@buildbot.net> Message-ID: <055.c8cb2e8e50184ef455e881a209f5d0c8@buildbot.net> #2245: grid.py Deferred instance has no attribute '__len__' ----------------------+------------------------ Reporter: kevbroch | Owner: Type: undecided | Status: new Priority: major | Milestone: undecided Version: master | Resolution: Keywords: | ----------------------+------------------------ Description changed by tom.prince: Old description: > Clicking on grid link generates this: > > /Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site- > packages/buildbot-0.8.6_166_g502ed82-py2.7.egg/buildbot/status/web/grid.py, > line 81 in builder_cxt > 79 state = "waiting" > 80 > 81 n_pending = len(builder.getPendingBuildRequestStatuses()) > 82 > : Deferred instance has no attribute > '__len__' New description: Clicking on grid link generates this: {{{ /Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site- packages/buildbot-0.8.6_166_g502ed82-py2.7.egg/buildbot/status/web/grid.py, line 81 in builder_cxt 79 state = "waiting" 80 81 n_pending = len(builder.getPendingBuildRequestStatuses()) 82 : Deferred instance has no attribute '__len__' }}} -- -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Thu Mar 15 19:16:48 2012 From: noreply at github.com (GitHub) Date: Thu, 15 Mar 2012 12:16:48 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 1afe3b: Fix webstatus grid wrt inlineCallbacks. Message-ID: <4f62402079b12_43493fa2a00aa2f86875d@sh1.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 1afe3b5da85e13150fa80d04081fb7b81c40bf50 https://github.com/buildbot/buildbot/commit/1afe3b5da85e13150fa80d04081fb7b81c40bf50 Author: Tom Prince Date: 2012-03-15 (Thu, 15 Mar 2012) Changed paths: M master/buildbot/status/web/grid.py Log Message: ----------- Fix webstatus grid wrt inlineCallbacks. Fixes #2245. From nobody at buildbot.net Thu Mar 15 19:16:54 2012 From: nobody at buildbot.net (Buildbot) Date: Thu, 15 Mar 2012 19:16:54 -0000 Subject: [Buildbot-commits] [Buildbot] #2245: grid.py Deferred instance has no attribute '__len__' In-Reply-To: <040.954b158d6fa780e365c8eecc45e2b031@buildbot.net> References: <040.954b158d6fa780e365c8eecc45e2b031@buildbot.net> Message-ID: <055.e17948f4e56b7d6b31ab387d36141a28@buildbot.net> #2245: grid.py Deferred instance has no attribute '__len__' ----------------------+------------------------ Reporter: kevbroch | Owner: Type: undecided | Status: closed Priority: major | Milestone: undecided Version: master | Resolution: fixed Keywords: | ----------------------+------------------------ Changes (by Tom Prince): * status: new => closed * resolution: => fixed Comment: Fix webstatus grid wrt inlineCallbacks. Fixes #2245. Changeset: 1afe3b5da85e13150fa80d04081fb7b81c40bf50 -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Fri Mar 16 00:32:14 2012 From: noreply at github.com (GitHub) Date: Thu, 15 Mar 2012 17:32:14 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 491004: transfer: Remove reference to self.cmd.stderr. Message-ID: <4f628a0e1601d_59ac1183ae8224bd@sh2.rs.github.com.mail> Branch: refs/heads/buildbot-0.8.6 Home: https://github.com/buildbot/buildbot Commit: 491004cb55e97b54af8ec362d3822a8c7196ccbf https://github.com/buildbot/buildbot/commit/491004cb55e97b54af8ec362d3822a8c7196ccbf Author: Tom Prince Date: 2012-03-15 (Thu, 15 Mar 2012) Changed paths: M master/buildbot/steps/transfer.py Log Message: ----------- transfer: Remove reference to self.cmd.stderr. This is fallout from merging RemoteCommand classes. From noreply at github.com Fri Mar 16 00:34:14 2012 From: noreply at github.com (GitHub) Date: Thu, 15 Mar 2012 17:34:14 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 491004: transfer: Remove reference to self.cmd.stderr. Message-ID: <4f628a86ea74f_73bb3facd767fafc490e2@sh1.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 491004cb55e97b54af8ec362d3822a8c7196ccbf https://github.com/buildbot/buildbot/commit/491004cb55e97b54af8ec362d3822a8c7196ccbf Author: Tom Prince Date: 2012-03-15 (Thu, 15 Mar 2012) Changed paths: M master/buildbot/steps/transfer.py Log Message: ----------- transfer: Remove reference to self.cmd.stderr. This is fallout from merging RemoteCommand classes. Commit: 0653f9a42a50f35ce768c79d46b86bca83edd2ae https://github.com/buildbot/buildbot/commit/0653f9a42a50f35ce768c79d46b86bca83edd2ae Author: Tom Prince Date: 2012-03-15 (Thu, 15 Mar 2012) Changed paths: M master/buildbot/status/web/templates/users.html R master/buildbot/status/web/templates/users_table.html M master/buildbot/status/web/users.py M master/buildbot/steps/transfer.py Log Message: ----------- Merge branch 'buildbot-0.8.6' Conflicts: master/buildbot/status/web/users.py Compare: https://github.com/buildbot/buildbot/compare/1afe3b5...0653f9a From noreply at github.com Fri Mar 16 01:13:25 2012 From: noreply at github.com (GitHub) Date: Thu, 15 Mar 2012 18:13:25 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 0fe46f: Remote with: tarfile.open use. Message-ID: <4f6293b5328ae_609b3fae46b932f89183a@sh1.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 0fe46faf4cb29fc50b8dd5e1d217fea15de884fa https://github.com/buildbot/buildbot/commit/0fe46faf4cb29fc50b8dd5e1d217fea15de884fa Author: Tom Prince Date: 2012-03-15 (Thu, 15 Mar 2012) Changed paths: M master/buildbot/steps/transfer.py Log Message: ----------- Remote with: tarfile.open use. Support for this was only added in python 2.7, so we can't use it yet. From nobody at buildbot.net Fri Mar 16 04:43:15 2012 From: nobody at buildbot.net (Buildbot) Date: Fri, 16 Mar 2012 04:43:15 -0000 Subject: [Buildbot-commits] [Buildbot] #2224: Support MySQL partitioning In-Reply-To: <038.407e30bc95d777b71e4bf74b2d50fcc5@buildbot.net> References: <038.407e30bc95d777b71e4bf74b2d50fcc5@buildbot.net> Message-ID: <053.2a3ef01ab895a07bca281b31e5d0571d@buildbot.net> #2224: Support MySQL partitioning ------------------------+-------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.9.+ Version: 0.8.2 | Resolution: Keywords: database | ------------------------+-------------------- Comment (by dustin): From what I can gather, this wouldn't require any changes to buildbot. At best, we could provide a contrib script to set this up (alter tables, etc.). -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Mar 16 09:49:42 2012 From: nobody at buildbot.net (Buildbot) Date: Fri, 16 Mar 2012 09:49:42 -0000 Subject: [Buildbot-commits] [Buildbot] #2246: buildbot.status.builder.BuilderStatus uses slow LRU implementation Message-ID: <038.40bad940dfb221e5429ad6b07df6f571@buildbot.net> #2246: buildbot.status.builder.BuilderStatus uses slow LRU implementation ---------------------+----------------------- Reporter: szager | Owner: Type: defect | Status: new Priority: critical | Milestone: undecided Version: 0.8.6 | Keywords: ---------------------+----------------------- BuilderStatus uses a very simple LRU implementation for storing BuildStatus objects. When profiling a very busy buildbot master, I found that fully a third of the CPU cycles were spent in BuildStatus.touchBuildCache(). That method features a linear-time lookup and expensive list operations (remove and copy). Is there any reason why BuilderStatus shouldn't use buildbot.util.lru.AsyncLRUCache for this? If that sounds like a good idea, I can submit a patch. Thanks, Stefan -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Mar 16 14:19:32 2012 From: nobody at buildbot.net (Buildbot) Date: Fri, 16 Mar 2012 14:19:32 -0000 Subject: [Buildbot-commits] [Buildbot] #2246: buildbot.status.builder.BuilderStatus uses slow LRU implementation In-Reply-To: <038.40bad940dfb221e5429ad6b07df6f571@buildbot.net> References: <038.40bad940dfb221e5429ad6b07df6f571@buildbot.net> Message-ID: <053.74a4d535e3fe9e970acfb4ca61b85858@buildbot.net> #2246: buildbot.status.builder.BuilderStatus uses slow LRU implementation ---------------------+------------------------ Reporter: szager | Owner: Type: defect | Status: new Priority: critical | Milestone: undecided Version: 0.8.6 | Resolution: Keywords: | ---------------------+------------------------ Comment (by tom.prince): That does sound like a good idea. Note that this will involve making `getBuildByNumber`, which will mean updating all of its callers, not all of which are tested, unfortunately. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Mar 16 17:19:42 2012 From: nobody at buildbot.net (Buildbot) Date: Fri, 16 Mar 2012 17:19:42 -0000 Subject: [Buildbot-commits] [Buildbot] #2180: Allow for "git describe" in addition to got_revision In-Reply-To: <042.f0bb38d6a7f6d5b4159cc3a8bf6a0f8c@buildbot.net> References: <042.f0bb38d6a7f6d5b4159cc3a8bf6a0f8c@buildbot.net> Message-ID: <057.43e114f7dec83b0d0476f33bcf707520@buildbot.net> #2180: Allow for "git describe" in addition to got_revision ----------------------------+------------------------ Reporter: jaredgrubb | Owner: Type: enhancement | Status: closed Priority: minor | Milestone: undecided Version: 0.8.5 | Resolution: wontfix Keywords: git, buildslave | ----------------------------+------------------------ Comment (by jaredgrubb): I have a patch ready for this. What I've implemented is an new param to Git which will do a 'git describe' after the 'git rev-parse' step. * Git(..., getDescription=True) => "git describe HEAD" * Git(..., getDescription={'match': 'foo-*'}) => "git describe --match foo-* HEAD" * Git(..., getDescription={'tags': True, 'exact-match': True}) => "git describe --tags --exact-match HEAD" * Git(..., getDescription={'match': 'foo-*', 'abbrev': 0}) => "git describe --match foo-* --abbrev=0 HEAD" The description is then added to the property 'got_description', which is a dict keyed by codebase. I figure since this is a 0.8.7 feature, if people want to use it, then keying by codebase (or using the default codebase='') is a reasonable expectation. If you dont mind this approach, I'll do a pull request. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Fri Mar 16 17:35:18 2012 From: noreply at github.com (GitHub) Date: Fri, 16 Mar 2012 10:35:18 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 6f41af: Merge branch 'upgrade-master-fixes' of git://githu... Message-ID: <4f6379d6ee72c_599a1607aec129481@sh2.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 6f41afbcffcdc67f552ba4e2747bd09991b3054b https://github.com/buildbot/buildbot/commit/6f41afbcffcdc67f552ba4e2747bd09991b3054b Author: Dustin J. Mitchell Date: 2012-03-16 (Fri, 16 Mar 2012) Changed paths: M master/buildbot/scripts/runner.py Log Message: ----------- Merge branch 'upgrade-master-fixes' of git://github.com/tomprince/buildbot * 'upgrade-master-fixes' of git://github.com/tomprince/buildbot: Don't fail upgrading, if the public_html updates can't be written. Change to correct directory before loading config in upgrade-master. From nobody at buildbot.net Fri Mar 16 17:45:01 2012 From: nobody at buildbot.net (Buildbot) Date: Fri, 16 Mar 2012 17:45:01 -0000 Subject: [Buildbot-commits] [Buildbot] #2180: Allow for "git describe" in addition to got_revision In-Reply-To: <042.f0bb38d6a7f6d5b4159cc3a8bf6a0f8c@buildbot.net> References: <042.f0bb38d6a7f6d5b4159cc3a8bf6a0f8c@buildbot.net> Message-ID: <057.85fef27d4bf0d8660f71fdd1f9503981@buildbot.net> #2180: Allow for "git describe" in addition to got_revision ----------------------------+------------------------ Reporter: jaredgrubb | Owner: Type: enhancement | Status: reopened Priority: minor | Milestone: undecided Version: 0.8.5 | Resolution: Keywords: git, buildslave | ----------------------------+------------------------ Changes (by dustin): * status: closed => reopened * resolution: wontfix => Comment: I like the flexibility of it, for sure. We don't currently have a great way to get properties out of dictionaries, though, and I'm loathe to create a desire for that. Way back when we first started talking about dictionaries in properties, we were thinking of keying them on repostitory (we hadn't invented "codebase" yet). I wonder if this would be *more* usable if the properties were just named with the codebase, e.g., "%s-commit- description", maybe with a fallback to just "commit-description" for the empty codebase? I'm not suggesting that change just yet -- I'd like to hear what others think first. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Fri Mar 16 17:49:33 2012 From: noreply at github.com (GitHub) Date: Fri, 16 Mar 2012 10:49:33 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] b88839: be explicit in the errors expected from an integri... Message-ID: <4f637d2d3bfea_86cd8faf416027@sh2.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: b8883939f673f71d425ff4b29539f495d186ab29 https://github.com/buildbot/buildbot/commit/b8883939f673f71d425ff4b29539f495d186ab29 Author: Dustin J. Mitchell Date: 2012-03-16 (Fri, 16 Mar 2012) Changed paths: M master/buildbot/test/unit/test_db_users.py Log Message: ----------- be explicit in the errors expected from an integrity error Commit: 1d8dd2fb796b6e010ad3a81e9ffa27472716cddf https://github.com/buildbot/buildbot/commit/1d8dd2fb796b6e010ad3a81e9ffa27472716cddf Author: Dustin J. Mitchell Date: 2012-03-16 (Fri, 16 Mar 2012) Changed paths: M master/buildbot/test/regressions/test_import_unicode_changes.py M master/buildbot/test/unit/test_changes_p4poller.py M master/buildbot/test/unit/test_db_buildsets.py M master/buildbot/test/unit/test_db_connector.py M master/buildbot/test/unit/test_db_pool.py M master/buildbot/test/unit/test_db_state.py M master/buildbot/test/unit/test_db_users.py M master/buildbot/test/unit/test_process_users_manual.py M master/buildbot/test/unit/test_scripts_runner.py M master/buildbot/test/unit/test_util_lru.py M slave/buildslave/test/unit/test_commands_transfer.py Log Message: ----------- Merge branch 'assertFailure' * assertFailure: be explicit in the errors expected from an integrity error use addFailure instead of a longer addCallbacks form Compare: https://github.com/buildbot/buildbot/compare/6f41afb...1d8dd2f From nobody at buildbot.net Fri Mar 16 17:54:06 2012 From: nobody at buildbot.net (Buildbot) Date: Fri, 16 Mar 2012 17:54:06 -0000 Subject: [Buildbot-commits] [Buildbot] #2180: Allow for "git describe" in addition to got_revision In-Reply-To: <042.f0bb38d6a7f6d5b4159cc3a8bf6a0f8c@buildbot.net> References: <042.f0bb38d6a7f6d5b4159cc3a8bf6a0f8c@buildbot.net> Message-ID: <057.d879c673003337113d3d008c30752186@buildbot.net> #2180: Allow for "git describe" in addition to got_revision ----------------------------+------------------------ Reporter: jaredgrubb | Owner: Type: enhancement | Status: reopened Priority: minor | Milestone: undecided Version: 0.8.5 | Resolution: Keywords: git, buildslave | ----------------------------+------------------------ Comment (by jaredgrubb): I saw that lists are supported ('owners' is set to [u'jgrubb'] on my 0.8.6 bot), so I assumed dict's were ok too. Before I did the dict approach, I was doing "got_description{%s}" in my own bot ... if someone wanted something different from the default prop name, could provide a 'set-property' key or something in the getDescription dict; hey, it could even be a callable! ... Maybe that's too many custom knobs before anyone's asked for it, but thought I'd throw it out there. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Mar 16 18:51:04 2012 From: nobody at buildbot.net (Buildbot) Date: Fri, 16 Mar 2012 18:51:04 -0000 Subject: [Buildbot-commits] [Buildbot] #2246: buildbot.status.builder.BuilderStatus uses slow LRU implementation In-Reply-To: <038.40bad940dfb221e5429ad6b07df6f571@buildbot.net> References: <038.40bad940dfb221e5429ad6b07df6f571@buildbot.net> Message-ID: <053.9d641eb890f94ce2465d3ca86058e660@buildbot.net> #2246: buildbot.status.builder.BuilderStatus uses slow LRU implementation ---------------------+------------------------ Reporter: szager | Owner: Type: defect | Status: new Priority: critical | Milestone: undecided Version: 0.8.6 | Resolution: Keywords: | ---------------------+------------------------ Comment (by szager): After looking at this a bit more carefully, I'm not sure that AsyncLRUCache is the right way to go. Looking at the call counts in my profiling data, this change would cause an increase in the number of defer.Deferred callback sequences by approximately a factor of 10. That's no mistake: BuilderStatus.touchBuildCache() is called several hundred times per second, about ten times more frequently than defer.Deferred.callback(). I'm wary of blithely adding that amount of complexity to a method called so frequently. From what I can tell, the AsyncLRUCache implementation uses Deferred's primarily to accomodate concurrent access to the cache. That's probably overkill for this purpose (after all, the existing implementation of BuilderStatus.touchBuildCache has no such protection). I think a better approach will be to use the basic LRU logic from AsyncLRUCache (which looks pretty sound), minus the concurrency protections. Please let me know if that sounds reasonable. I'm going to cook up an implementation to use for our project (we are in dire straits right now), and I can report back on the outcome. Thanks, Stefan -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Mar 16 19:04:44 2012 From: nobody at buildbot.net (Buildbot) Date: Fri, 16 Mar 2012 19:04:44 -0000 Subject: [Buildbot-commits] [Buildbot] #2246: buildbot.status.builder.BuilderStatus uses slow LRU implementation In-Reply-To: <038.40bad940dfb221e5429ad6b07df6f571@buildbot.net> References: <038.40bad940dfb221e5429ad6b07df6f571@buildbot.net> Message-ID: <053.de782f125eb20814824dfd184ca9d651@buildbot.net> #2246: buildbot.status.builder.BuilderStatus uses slow LRU implementation ---------------------+------------------------ Reporter: szager | Owner: Type: defect | Status: new Priority: critical | Milestone: undecided Version: 0.8.6 | Resolution: Keywords: | ---------------------+------------------------ Comment (by tom.prince): Well, we can currently get away with a synchronous implementation, since we store the build state in pickles which we read synchronously[1]. We are planning to eventually move the build status into the database, at which point the cache will need to be asynchronous, anyway. [1] This has issues of its own, but moving to the database will fix this anyway. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Fri Mar 16 20:58:25 2012 From: noreply at github.com (GitHub) Date: Fri, 16 Mar 2012 13:58:25 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] ffa1da: Update the tutorial to include logging in Message-ID: <4f63a97128733_3f4af8baec429bc@sh2.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: ffa1da2a34ecc12f3a5efae9ba4aeb8dcf0919cb https://github.com/buildbot/buildbot/commit/ffa1da2a34ecc12f3a5efae9ba4aeb8dcf0919cb Author: Dustin J. Mitchell Date: 2012-03-16 (Fri, 16 Mar 2012) Changed paths: M master/docs/tutorial/tour.rst Log Message: ----------- Update the tutorial to include logging in Fixes #2244. From nobody at buildbot.net Fri Mar 16 20:58:31 2012 From: nobody at buildbot.net (Buildbot) Date: Fri, 16 Mar 2012 20:58:31 -0000 Subject: [Buildbot-commits] [Buildbot] #2244: buildbot's sample config requires signing in to force builds now, but the tutorial doesn't document this. In-Reply-To: <042.2338f251fca63491ff969de1589a42a2@buildbot.net> References: <042.2338f251fca63491ff969de1589a42a2@buildbot.net> Message-ID: <057.f6bca2e2554880714cb723e6cbb32523@buildbot.net> #2244: buildbot's sample config requires signing in to force builds now, but the tutorial doesn't document this. -----------------------+------------------------ Reporter: tom.prince | Owner: Type: defect | Status: closed Priority: critical | Milestone: undecided Version: 0.8.6 | Resolution: fixed Keywords: docs | -----------------------+------------------------ Changes (by Dustin J. Mitchell): * status: new => closed * resolution: => fixed Comment: Update the tutorial to include logging in Fixes #2244. Changeset: ffa1da2a34ecc12f3a5efae9ba4aeb8dcf0919cb -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Mar 16 21:47:46 2012 From: nobody at buildbot.net (Buildbot) Date: Fri, 16 Mar 2012 21:47:46 -0000 Subject: [Buildbot-commits] [Buildbot] #2247: Build.lostRemote doesn't properly handle the case when the build hasn't started yet. Message-ID: <042.a001e85ecd6fd148e2b733fcadcb6714@buildbot.net> #2247: Build.lostRemote doesn't properly handle the case when the build hasn't started yet. -----------------------+------------------- Reporter: tom.prince | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.7 Version: 0.8.6 | Keywords: -----------------------+------------------- This can occur if the build is waiting for locks, so there isn't yet a `currentStep`. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Mar 16 22:48:52 2012 From: nobody at buildbot.net (Buildbot) Date: Fri, 16 Mar 2012 22:48:52 -0000 Subject: [Buildbot-commits] [Buildbot] #2248: ForceScheduler does not reconfig correctly Message-ID: <042.99e7ab81106a14f19ba121dda7936209@buildbot.net> #2248: ForceScheduler does not reconfig correctly -----------------------+----------------------- Reporter: jaredgrubb | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.6 | Keywords: -----------------------+----------------------- If you change a ForceScheduler's properties, they do not update on reconfig. You have to fully restart the buildmaster. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sat Mar 17 04:27:23 2012 From: noreply at github.com (GitHub) Date: Fri, 16 Mar 2012 21:27:23 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] f53f86: Fix compare_attrs of ForceScheduler. Message-ID: <4f6412ab95f10_402d3fae11d00af8726de@sh1.rs.github.com.mail> Branch: refs/heads/buildbot-0.8.6 Home: https://github.com/buildbot/buildbot Commit: f53f86bb508a7d0cf006f35b7ff600b16b87df95 https://github.com/buildbot/buildbot/commit/f53f86bb508a7d0cf006f35b7ff600b16b87df95 Author: Tom Prince Date: 2012-03-16 (Fri, 16 Mar 2012) Changed paths: M master/buildbot/schedulers/forcesched.py M master/buildbot/test/unit/test_schedulers_forcesched.py Log Message: ----------- Fix compare_attrs of ForceScheduler. 'forceProperties' was mistakenly listed as 'properties'. The names are confusing since ForceScheduler inherits a properties attribute with a different meaning, from BaseScheduler. Fixes #2248. From nobody at buildbot.net Sat Mar 17 04:27:30 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 17 Mar 2012 04:27:30 -0000 Subject: [Buildbot-commits] [Buildbot] #2248: ForceScheduler does not reconfig correctly In-Reply-To: <042.99e7ab81106a14f19ba121dda7936209@buildbot.net> References: <042.99e7ab81106a14f19ba121dda7936209@buildbot.net> Message-ID: <057.3ca90fdf768c9d26c38a41be0a38eb75@buildbot.net> #2248: ForceScheduler does not reconfig correctly -----------------------+------------------------ Reporter: jaredgrubb | Owner: Type: defect | Status: closed Priority: major | Milestone: undecided Version: 0.8.6 | Resolution: fixed Keywords: | -----------------------+------------------------ Changes (by Tom Prince): * status: new => closed * resolution: => fixed Comment: Fix compare_attrs of ForceScheduler. 'forceProperties' was mistakenly listed as 'properties'. The names are confusing since ForceScheduler inherits a properties attribute with a different meaning, from BaseScheduler. Fixes #2248. Changeset: f53f86bb508a7d0cf006f35b7ff600b16b87df95 -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sat Mar 17 17:16:42 2012 From: noreply at github.com (GitHub) Date: Sat, 17 Mar 2012 10:16:42 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 4e1b4f: add buildbot.util.makeLists Message-ID: <4f64c6fa18670_671e12dfaf47412c@sh2.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 4e1b4fa2324523cb283cdb6584648cccb7c712d3 https://github.com/buildbot/buildbot/commit/4e1b4fa2324523cb283cdb6584648cccb7c712d3 Author: Dustin J. Mitchell Date: 2012-03-17 (Sat, 17 Mar 2012) Changed paths: M master/buildbot/test/unit/test_util.py M master/buildbot/util/__init__.py M master/docs/developer/utils.rst Log Message: ----------- add buildbot.util.makeLists Commit: 2a8b8fcab82f319616e104445d130586c8237349 https://github.com/buildbot/buildbot/commit/2a8b8fcab82f319616e104445d130586c8237349 Author: Dustin J. Mitchell Date: 2012-03-17 (Sat, 17 Mar 2012) Changed paths: M master/buildbot/test/unit/test_util.py M master/buildbot/util/__init__.py M master/buildbot/util/bbcollections.py M master/buildbot/util/eventual.py M master/buildbot/util/lru.py M master/docs/developer/utils.rst Log Message: ----------- Update documentation for buildbot.utils (there's still more to do) Compare: https://github.com/buildbot/buildbot/compare/ffa1da2...2a8b8fc From noreply at github.com Sat Mar 17 18:17:34 2012 From: noreply at github.com (GitHub) Date: Sat, 17 Mar 2012 11:17:34 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] b22798: Fix handling of a lost slave while waiting for a l... Message-ID: <4f64d53eef1c9_76a2f4caf4795d@sh2.rs.github.com.mail> Branch: refs/heads/buildbot-0.8.6 Home: https://github.com/buildbot/buildbot Commit: b22798faa6cb4759da1ca57b8efa71a5973b73a2 https://github.com/buildbot/buildbot/commit/b22798faa6cb4759da1ca57b8efa71a5973b73a2 Author: Tom Prince Date: 2012-03-17 (Sat, 17 Mar 2012) Changed paths: M master/buildbot/process/build.py M master/buildbot/test/unit/test_process_build.py Log Message: ----------- Fix handling of a lost slave while waiting for a lock. Fixes #2247. From nobody at buildbot.net Sat Mar 17 18:17:40 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 17 Mar 2012 18:17:40 -0000 Subject: [Buildbot-commits] [Buildbot] #2247: Build.lostRemote doesn't properly handle the case when the build hasn't started yet. In-Reply-To: <042.a001e85ecd6fd148e2b733fcadcb6714@buildbot.net> References: <042.a001e85ecd6fd148e2b733fcadcb6714@buildbot.net> Message-ID: <057.eb6b7ee90bf3069ab18b28afef711a8f@buildbot.net> #2247: Build.lostRemote doesn't properly handle the case when the build hasn't started yet. -----------------------+--------------------- Reporter: tom.prince | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.7 Version: 0.8.6 | Resolution: fixed Keywords: | -----------------------+--------------------- Changes (by Tom Prince): * status: new => closed * resolution: => fixed Comment: Fix handling of a lost slave while waiting for a lock. Fixes #2247. Changeset: b22798faa6cb4759da1ca57b8efa71a5973b73a2 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 17 21:13:12 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 17 Mar 2012 21:13:12 -0000 Subject: [Buildbot-commits] [Buildbot] #2165: Support ternary substitution in WithProperties In-Reply-To: <042.4b2c171050850b3d9c3b20a504de0f02@buildbot.net> References: <042.4b2c171050850b3d9c3b20a504de0f02@buildbot.net> Message-ID: <057.46c30aa1491deec8c8628b5a99ed4346@buildbot.net> #2165: Support ternary substitution in WithProperties ------------------------+------------------------- Reporter: jaredgrubb | Owner: jaredgrubb Type: enhancement | Status: assigned Priority: minor | Milestone: 0.8.+ Version: 0.8.5 | Resolution: Keywords: sprint | ------------------------+------------------------- Changes (by jaredgrubb): * owner: => jaredgrubb * status: new => assigned Comment: I have a patch ready for this. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 17 21:14:23 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 17 Mar 2012 21:14:23 -0000 Subject: [Buildbot-commits] [Buildbot] #2214: BuildStep's for multi-repo should include sourcebase in the names In-Reply-To: <042.390a8e63efa40f433cb326072e61e6cd@buildbot.net> References: <042.390a8e63efa40f433cb326072e61e6cd@buildbot.net> Message-ID: <057.b48afdce86c8160ee1e480b97895f0a9@buildbot.net> #2214: BuildStep's for multi-repo should include sourcebase in the names ------------------------+------------------------- Reporter: jaredgrubb | Owner: jaredgrubb Type: enhancement | Status: assigned Priority: major | Milestone: 0.8.7 Version: 0.8.5 | Resolution: Keywords: projrepo | ------------------------+------------------------- Changes (by jaredgrubb): * owner: => jaredgrubb * status: new => assigned -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 17 21:14:43 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 17 Mar 2012 21:14:43 -0000 Subject: [Buildbot-commits] [Buildbot] #1808: Scheduler with treeStableTimer "merges" changes to multiple projects into single SourceStamp In-Reply-To: <039.cd87665d300c4855d7e125d8690e0a31@buildbot.net> References: <039.cd87665d300c4855d7e125d8690e0a31@buildbot.net> Message-ID: <054.cb38e67a86cb37f8362fc1c0ce9de800@buildbot.net> #1808: Scheduler with treeStableTimer "merges" changes to multiple projects into single SourceStamp --------------------+------------------------- Reporter: aivarsk | Owner: jaredgrubb Type: defect | Status: assigned Priority: major | Milestone: 0.8.+ Version: 0.8.3p1 | Resolution: Keywords: sprint | --------------------+------------------------- Changes (by jaredgrubb): * owner: => jaredgrubb * status: new => assigned -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 17 21:14:59 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 17 Mar 2012 21:14:59 -0000 Subject: [Buildbot-commits] [Buildbot] #2180: Allow for "git describe" in addition to got_revision In-Reply-To: <042.f0bb38d6a7f6d5b4159cc3a8bf6a0f8c@buildbot.net> References: <042.f0bb38d6a7f6d5b4159cc3a8bf6a0f8c@buildbot.net> Message-ID: <057.e0901e43db5fa711683ed03713adfce6@buildbot.net> #2180: Allow for "git describe" in addition to got_revision ----------------------------+------------------------- Reporter: jaredgrubb | Owner: jaredgrubb Type: enhancement | Status: assigned Priority: minor | Milestone: undecided Version: 0.8.5 | Resolution: Keywords: git, buildslave | ----------------------------+------------------------- Changes (by jaredgrubb): * owner: => jaredgrubb * status: reopened => assigned -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 17 21:19:45 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 17 Mar 2012 21:19:45 -0000 Subject: [Buildbot-commits] [Buildbot] #928: Allow builder to be associated with multiple categories In-Reply-To: <038.51386ed5975d423860b7df3ecfae8e27@buildbot.net> References: <038.51386ed5975d423860b7df3ecfae8e27@buildbot.net> Message-ID: <053.82638ae4656ea03f5edc8d02d59d7a6c@buildbot.net> #928: Allow builder to be associated with multiple categories ------------------------+------------------------- Reporter: stefan | Owner: jaredgrubb Type: enhancement | Status: assigned Priority: major | Milestone: 0.8.+ Version: 0.8.0 | Resolution: Keywords: sprint | ------------------------+------------------------- Changes (by jaredgrubb): * owner: => jaredgrubb * status: new => assigned -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sat Mar 17 22:31:14 2012 From: noreply at github.com (GitHub) Date: Sat, 17 Mar 2012 15:31:14 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 728bea: Merge branch '987' of git://github.com/NateBragg/b... Message-ID: <4f6510b229de7_1e45102aae88446d@sh2.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 728beac2b7f68b81a2d245309360dbb6cc1f05d8 https://github.com/buildbot/buildbot/commit/728beac2b7f68b81a2d245309360dbb6cc1f05d8 Author: Dustin J. Mitchell Date: 2012-03-17 (Sat, 17 Mar 2012) Changed paths: M master/buildbot/steps/vstudio.py M master/buildbot/test/unit/test_steps_vstudio.py M master/docs/manual/cfg-buildsteps.rst Log Message: ----------- Merge branch '987' of git://github.com/NateBragg/buildbot * '987' of git://github.com/NateBragg/buildbot: Added some docs Added 'clean' command for visual studio From noreply at github.com Sat Mar 17 22:40:02 2012 From: noreply at github.com (GitHub) Date: Sat, 17 Mar 2012 15:40:02 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] bcabd5: Merge branch 'fix-directory-upload' of git://githu... Message-ID: <4f6512c2a5c74_671e12dfaf4924b3@sh2.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: bcabd579c5069b7657456214a647edfac140de85 https://github.com/buildbot/buildbot/commit/bcabd579c5069b7657456214a647edfac140de85 Author: Dustin J. Mitchell Date: 2012-03-17 (Sat, 17 Mar 2012) Changed paths: M master/buildbot/steps/transfer.py M master/buildbot/test/fake/remotecommand.py M master/buildbot/test/unit/test_steps_transfer.py Log Message: ----------- Merge branch 'fix-directory-upload' of git://github.com/tomprince/buildbot * 'fix-directory-upload' of git://github.com/tomprince/buildbot: Add a basic test for DirectoryUpload step. Commit: 5a5eecf333eb61c329d27201509d3f10c9c559da https://github.com/buildbot/buildbot/commit/5a5eecf333eb61c329d27201509d3f10c9c559da Author: Dustin J. Mitchell Date: 2012-03-17 (Sat, 17 Mar 2012) Changed paths: M master/buildbot/steps/transfer.py Log Message: ----------- rename StatusRemoteCommand to function-like name Compare: https://github.com/buildbot/buildbot/compare/728beac...5a5eecf From noreply at github.com Sat Mar 17 23:04:36 2012 From: noreply at github.com (GitHub) Date: Sat, 17 Mar 2012 16:04:36 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 6db593: give TarFile a name parameter so it doesn't try to... Message-ID: <4f651884ae29f_6f083fece50aeaf87834b@sh1.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 6db593cb16785832b93ca2735ddc6ddc1fb3420a https://github.com/buildbot/buildbot/commit/6db593cb16785832b93ca2735ddc6ddc1fb3420a Author: Dustin J. Mitchell Date: 2012-03-17 (Sat, 17 Mar 2012) Changed paths: M master/buildbot/test/unit/test_steps_transfer.py Log Message: ----------- give TarFile a name parameter so it doesn't try to get one from StringIO (works around Python-2.5.1 bug) From nobody at buildbot.net Sat Mar 17 23:22:50 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 17 Mar 2012 23:22:50 -0000 Subject: [Buildbot-commits] [Buildbot] #2249: change merging is no longer picking the newest change Message-ID: <038.f93398e709d16911e6724171d2de32ee@buildbot.net> #2249: change merging is no longer picking the newest change -------------------+------------------- Reporter: dustin | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.7 Version: 0.8.6 | Keywords: -------------------+------------------- See attached, where three changes were merged. They are displayed out of order on the page, and in fact the middle one numerically (4012) was the one that supplied the revision. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Mar 18 00:35:26 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 18 Mar 2012 00:35:26 -0000 Subject: [Buildbot-commits] [Buildbot] #2246: buildbot.status.builder.BuilderStatus uses slow LRU implementation In-Reply-To: <038.40bad940dfb221e5429ad6b07df6f571@buildbot.net> References: <038.40bad940dfb221e5429ad6b07df6f571@buildbot.net> Message-ID: <053.db776f25fbfd9c62614ea3db9c34ddda@buildbot.net> #2246: buildbot.status.builder.BuilderStatus uses slow LRU implementation ------------------------+-------------------- Reporter: szager | Owner: Type: defect | Status: new Priority: critical | Milestone: 0.8.7 Version: 0.8.6 | Resolution: Keywords: performance | ------------------------+-------------------- Changes (by dustin): * keywords: => performance * milestone: undecided => 0.8.7 Comment: szager - I'm curious why you're seeing so many hits to that method in a second. My guess is that it's due to the web status being heavily used? There's a significant advantage to using existing, well-tested code (AsyncLRUCache) for this purpose. Deferreds are well-tested and performant, so I don't think avoiding them for performance reasons is ok without some hard data. That said, `getBuild` is called a *lot*, in a synchronous fashion, so I expect that making it async will involve a lot of work -- work on untested, bad code. The async implementation is based on http://code.activestate.com/recipes/498245-lru-and-lfu-cache-decorators - perhaps you could add (and test and document) a synchronous implementation in `master/buildbot/util/lru.py` and use that? -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Mar 18 00:45:52 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 18 Mar 2012 00:45:52 -0000 Subject: [Buildbot-commits] [Buildbot] #2180: Allow for "git describe" in addition to got_revision In-Reply-To: <042.f0bb38d6a7f6d5b4159cc3a8bf6a0f8c@buildbot.net> References: <042.f0bb38d6a7f6d5b4159cc3a8bf6a0f8c@buildbot.net> Message-ID: <057.c229b76f9de4731e5c4d28fb3f9ce623@buildbot.net> #2180: Allow for "git describe" in addition to got_revision ----------------------------+------------------------- Reporter: jaredgrubb | Owner: jaredgrubb Type: enhancement | Status: assigned Priority: minor | Milestone: undecided Version: 0.8.5 | Resolution: Keywords: git, buildslave | ----------------------------+------------------------- Comment (by dustin): I suspect that the common use-case is to substitute the description into a filename somewhere, and for that folks will want to use `Interpolate`. Let's go with the property-per-codebase approach described in comment 7, or the variant in comment 8, and see how that flies. If there are good reasons to use a dictionary, too, we can add that in without any problems. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sun Mar 18 02:20:21 2012 From: noreply at github.com (GitHub) Date: Sat, 17 Mar 2012 19:20:21 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 7fafe7: fix typo in docs Message-ID: <4f654665f31dd_521a3f907c137af8633bd@sh1.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 7fafe781d48a919e63728b347f19b1aa668ba53d https://github.com/buildbot/buildbot/commit/7fafe781d48a919e63728b347f19b1aa668ba53d Author: Dustin J. Mitchell Date: 2012-03-17 (Sat, 17 Mar 2012) Changed paths: M master/docs/manual/cfg-schedulers.rst Log Message: ----------- fix typo in docs From nobody at buildbot.net Sun Mar 18 02:57:49 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 18 Mar 2012 02:57:49 -0000 Subject: [Buildbot-commits] [Buildbot] #2246: buildbot.status.builder.BuilderStatus uses slow LRU implementation In-Reply-To: <038.40bad940dfb221e5429ad6b07df6f571@buildbot.net> References: <038.40bad940dfb221e5429ad6b07df6f571@buildbot.net> Message-ID: <053.c49edf0c20efe067f9d28226d319b824@buildbot.net> #2246: buildbot.status.builder.BuilderStatus uses slow LRU implementation ------------------------+-------------------- Reporter: szager | Owner: Type: defect | Status: new Priority: critical | Milestone: 0.8.7 Version: 0.8.6 | Resolution: Keywords: performance | ------------------------+-------------------- Comment (by szager): Dustin, You're correct on all counts. We have a very big and heavily-trafficed consoled, and that accounts for the frequency of hitting the build cache. And you may well be right that using the deferred-based solution would not be a performance drag; but the prospect of increasing the number of deferred callback sequences by a factor of 10, in an already heavily CPU- bound process, gave me pause. In fact, I did exactly as you have suggested, and added a SyncLRUCache to lru.py, which inherits from ASyncLRUCache and uses the same algorithm. It has been live for a couple of days now, and first indications are that it has dramatically improved the performance of the web interface (and "dramatically" may be a dramatic understatement). I'd like to wait and see how this holds up on a busy weekday, but if you'd like to preview the patch, it's here: http://codereview.chromium.org/9703108/ Stefan -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Mar 18 05:23:14 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 18 Mar 2012 05:23:14 -0000 Subject: [Buildbot-commits] [Buildbot] #2246: buildbot.status.builder.BuilderStatus uses slow LRU implementation In-Reply-To: <038.40bad940dfb221e5429ad6b07df6f571@buildbot.net> References: <038.40bad940dfb221e5429ad6b07df6f571@buildbot.net> Message-ID: <053.218aa505814189fd25a2d4f7913584f7@buildbot.net> #2246: buildbot.status.builder.BuilderStatus uses slow LRU implementation ------------------------+-------------------- Reporter: szager | Owner: Type: defect | Status: new Priority: critical | Milestone: 0.8.7 Version: 0.8.6 | Resolution: Keywords: performance | ------------------------+-------------------- Comment (by dustin): I don't see any difference between the nested `ref_key` function in AsyncLRUCache and the `_ref_key` method in your patch. Using a method incurs some overhead, too. Even just the get method here is a lot of duplicate code, which makes good sense from the perspective of an external patch, but not much sense for something merged to Buildbot. If you could factor this out into an `LRUBase` class with two subclasses for sync and async interfaces, that might be best. Then the first half of `get` could be factored into something like `_get_hits` (including the nested `ref_key` function), which is called from both the sync and async `get` methods. Thanks for keeping to the Buildbot style in `lru.py`. As for the new test script, it uses 2-space indents in the second half, so that should be fixed up before being submitted as a pull request. All in all, I think this is a great improvement, so please do take the time to make these changes -- then when you do upgrade to 0.8.7 or higher, you won't have to reapply this patch! In general, I'll be interested to know of any other performance improvements you uncover in Buildbot. [tag:performance The performance tag] lists some other relevant bugs. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sun Mar 18 05:30:06 2012 From: noreply at github.com (GitHub) Date: Sat, 17 Mar 2012 22:30:06 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 963de2: fetched upstream and rebased. Also fixed a typo on... Message-ID: <4f6572de981e_63b13fb5b8bf0aec692f9@sh1.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 963de23740ff6aa1e75a1556b4e2cb14aaca67e5 https://github.com/buildbot/buildbot/commit/963de23740ff6aa1e75a1556b4e2cb14aaca67e5 Author: Mark Lakewood Date: 2012-03-17 (Sat, 17 Mar 2012) Changed paths: M master/buildbot/schedulers/trysched.py Log Message: ----------- fetched upstream and rebased. Also fixed a typo on BadJobfile Commit: 2a4c41b4af154b31de7e8cb29dbe84b9d0c19e8f https://github.com/buildbot/buildbot/commit/2a4c41b4af154b31de7e8cb29dbe84b9d0c19e8f Author: Dustin J. Mitchell Date: 2012-03-17 (Sat, 17 Mar 2012) Changed paths: M master/buildbot/schedulers/trysched.py M master/buildbot/test/unit/test_schedulers_trysched.py Log Message: ----------- Merge branch 'master' of https://github.com/mlakewood/buildbot * 'master' of https://github.com/mlakewood/buildbot: fetched upstream and rebased. Also fixed a typo on BadJobfile Changed the log.msg to a rais BadJobFile for visibility to the user Fixed up the checking for file length to use a seek() followed by a tell() Added an extra check to give a better warning message for a patch that is too big (file permissions returned to 644 in the merge) Compare: https://github.com/buildbot/buildbot/compare/7fafe78...2a4c41b From nobody at buildbot.net Mon Mar 19 01:04:14 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 19 Mar 2012 01:04:14 -0000 Subject: [Buildbot-commits] [Buildbot] #1766: Can't pass extra arguments to SVNPoller In-Reply-To: <037.dc3f52f4b0f33e7254c85d2b5e27a3a5@buildbot.net> References: <037.dc3f52f4b0f33e7254c85d2b5e27a3a5@buildbot.net> Message-ID: <052.a8f393c2c6b8aee8289a29436f02b9b6@buildbot.net> #1766: Can't pass extra arguments to SVNPoller ------------------------+----------------------- Reporter: fgsch | Owner: bdbaddog Type: enhancement | Status: assigned Priority: minor | Milestone: 0.8.+ Version: 0.8.3p1 | Resolution: Keywords: svn, sprint | ------------------------+----------------------- Comment (by bdbaddog): Can you pull and try the code at: https://github.com/bdbaddog/buildbot/commit/fecd5bcb78fea91031bed27d216ab295cab5d1b8 And see if that resolves this issue for you? I've set a pull request for this. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Mar 19 17:04:10 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 19 Mar 2012 17:04:10 -0000 Subject: [Buildbot-commits] [Buildbot] #2250: Upload step fails Message-ID: <038.e712882b8b8eb15707ccfc1ebfbd1feb@buildbot.net> #2250: Upload step fails -------------------+----------------------- Reporter: fribes | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.6 | Keywords: -------------------+----------------------- Hi, After upgrading from 0.8.5 to version 0.8.6, the following error occurred : {{{ Traceback (most recent call last): File "/usr/lib/python2.6/dist-packages/twisted/internet/defer.py", line 213, in addCallbacks self._runCallbacks() File "/usr/lib/python2.6/dist-packages/twisted/internet/defer.py", line 371, in _runCallbacks self.result = callback(self.result, *args, **kw) File "/usr/lib/python2.6/dist-packages/twisted/internet/defer.py", line 280, in callback self._startRunCallbacks(result) File "/usr/lib/python2.6/dist-packages/twisted/internet/defer.py", line 354, in _startRunCallbacks self._runCallbacks() --- --- File "/usr/lib/python2.6/dist-packages/twisted/internet/defer.py", line 371, in _runCallbacks self.result = callback(self.result, *args, **kw) File "/usr/local/lib/python2.6/dist- packages/buildbot-0.8.6-py2.6.egg/buildbot/steps/transfer.py", line 377, in finished if self.cmd.stderr != '': exceptions.AttributeError: StatusRemoteCommand instance has no attribute 'stderr' }}} Any idea ? Thx -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Mar 19 17:04:54 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 19 Mar 2012 17:04:54 -0000 Subject: [Buildbot-commits] [Buildbot] #2250: Upload step fails In-Reply-To: <038.e712882b8b8eb15707ccfc1ebfbd1feb@buildbot.net> References: <038.e712882b8b8eb15707ccfc1ebfbd1feb@buildbot.net> Message-ID: <053.8cb4d115d4c00047f767a07f6639fbcd@buildbot.net> #2250: Upload step fails -------------------+------------------------ Reporter: fribes | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.6 | Resolution: Keywords: | -------------------+------------------------ Changes (by fribes): * cc: fribes@? (added) -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Mar 19 17:07:32 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 19 Mar 2012 17:07:32 -0000 Subject: [Buildbot-commits] [Buildbot] #2250: Upload step fails In-Reply-To: <038.e712882b8b8eb15707ccfc1ebfbd1feb@buildbot.net> References: <038.e712882b8b8eb15707ccfc1ebfbd1feb@buildbot.net> Message-ID: <053.8c6b6e1b2c66828d6e57026455709e97@buildbot.net> #2250: Upload step fails -------------------+------------------------ Reporter: fribes | Owner: Type: defect | Status: closed Priority: major | Milestone: undecided Version: 0.8.6 | Resolution: fixed Keywords: | -------------------+------------------------ Changes (by tom.prince): * status: new => closed * resolution: => fixed Comment: This is fixed in {{{ commit 491004cb55e97b54af8ec362d3822a8c7196ccbf Author: Tom Prince Date: Thu Mar 15 20:31:19 2012 -0400 transfer: Remove reference to self.cmd.stderr. This is fallout from merging RemoteCommand classes. }}} which is in the buildbot-0.8.6 branch, and will be released as part of v0.8.6p1 in a week or two. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Tue Mar 20 06:38:53 2012 From: nobody at buildbot.net (Buildbot) Date: Tue, 20 Mar 2012 06:38:53 -0000 Subject: [Buildbot-commits] [Buildbot] #2246: buildbot.status.builder.BuilderStatus uses slow LRU implementation In-Reply-To: <038.40bad940dfb221e5429ad6b07df6f571@buildbot.net> References: <038.40bad940dfb221e5429ad6b07df6f571@buildbot.net> Message-ID: <053.d39436ede633f4c107a1456773c66e0a@buildbot.net> #2246: buildbot.status.builder.BuilderStatus uses slow LRU implementation ------------------------+-------------------- Reporter: szager | Owner: Type: defect | Status: new Priority: critical | Milestone: 0.8.7 Version: 0.8.6 | Resolution: Keywords: performance | ------------------------+-------------------- Comment (by szager): The jury is in, and this change has indeed resulted in a vast performance improvement to our buildot performance. Where previously our CPU load was consistently pegged at 100%, now it averages around 60% under full load. More importantly, the web UI is *much* more responsive. I have submitted a patch: https://github.com/buildbot/buildbot/pull/366 Let me know what you think. Thanks, Stefan -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Mar 21 21:01:44 2012 From: nobody at buildbot.net (Buildbot) Date: Wed, 21 Mar 2012 21:01:44 -0000 Subject: [Buildbot-commits] [Buildbot] #2251: SingleBranchScheduler in 0.8.5 (and 0.8.6) does not show "next in ... minutes" anymore Message-ID: <037.951e1c1ddd381fbb0c031f265b3b97dd@buildbot.net> #2251: SingleBranchScheduler in 0.8.5 (and 0.8.6) does not show "next in ... minutes" anymore --------------------+------------------- Reporter: anjos | Owner: Type: defect | Status: new Priority: trivial | Milestone: 0.8.7 Version: 0.8.6 | Keywords: --------------------+------------------- This feature used to exist before 0.8.5 was introduced. According to Justin: "The problem is that the non-timed schedulers do not implement the `getPendingBuildTimes` method. The fix is to implement this method, based on the treeStableTimer. Do you want to take a shot at that? If not, please file a bug for that purpose.". So, here it is the bug. I might still give a shot at this if I have the time, but it is made public to others if they wish to work on it. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Thu Mar 22 02:29:54 2012 From: nobody at buildbot.net (Buildbot) Date: Thu, 22 Mar 2012 02:29:54 -0000 Subject: [Buildbot-commits] [Buildbot] #2252: Reconfig after adding step results in buildException Message-ID: <037.7bbf90948ad8dd0d707e96de4e16894d@buildbot.net> #2252: Reconfig after adding step results in buildException -------------------+----------------------- Reporter: tmidd | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.6 | Keywords: -------------------+----------------------- I added an extra step to a builder and then reconfig'ed the master. The step I added was automatically named MasterShellCommand_2 which pushed the previous owner of that name to MasterShellCommand_3 (which didn't exist previously). There were no builds running on the builder when I did the reconfig. The next time the builder finished it threw the following exception and failed to "end" correctly - that is, subsequent builds are pending even though there is no active build. Restarting the master seems to have fixed the problem. 2012-03-22 14:22:25+1300 [-] setting expectations for next time 2012-03-22 14:22:25+1300 [-] .buildException 2012-03-22 14:22:25+1300 [-] Unhandled Error Traceback (most recent call last): File "/usr/local/lib/python2.7/site- packages/buildbot-0.8.6-py2.7.egg/buildbot/process/build.py", line 396, in _stepDone return self.startNextStep() File "/usr/local/lib/python2.7/site- packages/buildbot-0.8.6-py2.7.egg/buildbot/process/build.py", line 386, in startNextStep d.addCallback(self._stepDone, s) File "/usr/local/lib/python2.7/site- packages/Twisted-12.0.0-py2.7-linux-x86_64.egg/twisted/internet/defer.py", line 301, in addCallback callbackKeywords=kw) File "/usr/local/lib/python2.7/site- packages/Twisted-12.0.0-py2.7-linux-x86_64.egg/twisted/internet/defer.py", line 290, in addCallbacks self._runCallbacks() --- --- File "/usr/local/lib/python2.7/site- packages/Twisted-12.0.0-py2.7-linux-x86_64.egg/twisted/internet/defer.py", line 551, in _runCallbacks current.result = callback(current.result, *args, **kw) File "/usr/local/lib/python2.7/site- packages/buildbot-0.8.6-py2.7.egg/buildbot/process/build.py", line 396, in _stepDone return self.startNextStep() File "/usr/local/lib/python2.7/site- packages/buildbot-0.8.6-py2.7.egg/buildbot/process/build.py", line 383, in startNextStep return self.allStepsDone() File "/usr/local/lib/python2.7/site- packages/buildbot-0.8.6-py2.7.egg/buildbot/process/build.py", line 486, in allStepsDone return self.buildFinished(text, self.result) File "/usr/local/lib/python2.7/site- packages/buildbot-0.8.6-py2.7.egg/buildbot/process/build.py", line 517, in buildFinished self.builder.setExpectations(self.progress) File "/usr/local/lib/python2.7/site- packages/buildbot-0.8.6-py2.7.egg/buildbot/process/builder.py", line 450, in setExpectations self.expectations.update(progress) File "/usr/local/lib/python2.7/site- packages/buildbot-0.8.6-py2.7.egg/buildbot/status/progress.py", line 295, in update old = self.times[name] exceptions.KeyError: 'MasterShellCommand_3' It looks like it's trying to find the new step in a dict that wasn't updated correctly by the reconfig, although I haven't had a proper look through the code yet to confirm exactly what's going wrong. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Thu Mar 22 03:05:05 2012 From: nobody at buildbot.net (Buildbot) Date: Thu, 22 Mar 2012 03:05:05 -0000 Subject: [Buildbot-commits] [Buildbot] #2252: Reconfig after adding step results in buildException In-Reply-To: <037.7bbf90948ad8dd0d707e96de4e16894d@buildbot.net> References: <037.7bbf90948ad8dd0d707e96de4e16894d@buildbot.net> Message-ID: <052.ba3b238819a25b981cae2bbcd3d1ee75@buildbot.net> #2252: Reconfig after adding step results in buildException -------------------+------------------------ Reporter: tmidd | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.6 | Resolution: Keywords: | -------------------+------------------------ Comment (by tmidd): Just noticed this exception is followed by another a minute or so later: {{{ 2012-03-22 14:23:39+1300 [-] Unhandled error in Deferred: 2012-03-22 14:23:39+1300 [-] Unhandled Error Traceback (most recent call last): File "/usr/local/lib/python2.7/site- packages/buildbot-0.8.6-py2.7.egg/buildbot/process/build.py", line 396, in _stepDone return self.startNextStep() File "/usr/local/lib/python2.7/site- packages/buildbot-0.8.6-py2.7.egg/buildbot/process/build.py", line 387, in startNextStep d.addErrback(self.buildException) File "/usr/local/lib/python2.7/site- packages/Twisted-12.0.0-py2.7-linux-x86_64.egg/twisted/internet/defer.py", line 312, in addErrback errbackKeywords=kw) File "/usr/local/lib/python2.7/site- packages/Twisted-12.0.0-py2.7-linux-x86_64.egg/twisted/internet/defer.py", line 290, in addCallbacks self._runCallbacks() --- --- File "/usr/local/lib/python2.7/site- packages/Twisted-12.0.0-py2.7-linux-x86_64.egg/twisted/internet/defer.py", line 551, in _runCallbacks current.result = callback(current.result, *args, **kw) File "/usr/local/lib/python2.7/site- packages/buildbot-0.8.6-py2.7.egg/buildbot/process/build.py", line 491, in buildException self.buildFinished(["build", "exception"], EXCEPTION) File "/usr/local/lib/python2.7/site- packages/buildbot-0.8.6-py2.7.egg/buildbot/process/build.py", line 507, in buildFinished self.remote.dontNotifyOnDisconnect(self.lostRemote) File "/usr/local/lib/python2.7/site- packages/Twisted-12.0.0-py2.7-linux-x86_64.egg/twisted/spread/pb.py", line 306, in dontNotifyOnDisconnect self.disconnectCallbacks.remove(callback) exceptions.ValueError: list.remove(x): x not in list }}} -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Thu Mar 22 04:02:33 2012 From: noreply at github.com (GitHub) Date: Wed, 21 Mar 2012 21:02:33 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] b915a4: Fix crashes when adding new steps in reconfig. Message-ID: <4f6aa4598d5aa_3313f85acc192f817290@sh1.rs.github.com.mail> Branch: refs/heads/buildbot-0.8.6 Home: https://github.com/buildbot/buildbot Commit: b915a48d7ef30da0dbb80397911737e53473ce49 https://github.com/buildbot/buildbot/commit/b915a48d7ef30da0dbb80397911737e53473ce49 Author: Tom Prince Date: 2012-03-21 (Wed, 21 Mar 2012) Changed paths: M master/buildbot/status/progress.py A master/buildbot/test/unit/test_status_progress.py Log Message: ----------- Fix crashes when adding new steps in reconfig. Fixes #2252. Commit: cfdb00bdadb27d45e2170c9db9ff05e351a08a1b https://github.com/buildbot/buildbot/commit/cfdb00bdadb27d45e2170c9db9ff05e351a08a1b Author: Tom Prince Date: 2012-03-21 (Wed, 21 Mar 2012) Changed paths: M master/buildbot/status/master.py Log Message: ----------- Use naturalSort instead of sort for builer lists. Compare: https://github.com/buildbot/buildbot/compare/b22798f...cfdb00b From nobody at buildbot.net Thu Mar 22 04:02:40 2012 From: nobody at buildbot.net (Buildbot) Date: Thu, 22 Mar 2012 04:02:40 -0000 Subject: [Buildbot-commits] [Buildbot] #2252: Reconfig after adding step results in buildException In-Reply-To: <037.7bbf90948ad8dd0d707e96de4e16894d@buildbot.net> References: <037.7bbf90948ad8dd0d707e96de4e16894d@buildbot.net> Message-ID: <052.337fba1d35a2d9fed35908ea46ab0983@buildbot.net> #2252: Reconfig after adding step results in buildException -------------------+------------------------ Reporter: tmidd | Owner: Type: defect | Status: closed Priority: major | Milestone: undecided Version: 0.8.6 | Resolution: fixed Keywords: | -------------------+------------------------ Changes (by Tom Prince): * status: new => closed * resolution: => fixed Comment: Fix crashes when adding new steps in reconfig. Fixes #2252. Changeset: b915a48d7ef30da0dbb80397911737e53473ce49 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Thu Mar 22 05:06:05 2012 From: nobody at buildbot.net (Buildbot) Date: Thu, 22 Mar 2012 05:06:05 -0000 Subject: [Buildbot-commits] [Buildbot] #2253: Deal gracefully with exceptions thrown before a build is fully started. Message-ID: <042.502e4bfc2195e4e199f3bdfb474d498c@buildbot.net> #2253: Deal gracefully with exceptions thrown before a build is fully started. -----------------------+----------------------- Reporter: tom.prince | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.6 | Keywords: -----------------------+----------------------- Traceback from #2252 demonstrating this. {{{ 2012-03-22 14:23:39+1300 [-] Unhandled error in Deferred: 2012-03-22 14:23:39+1300 [-] Unhandled Error Traceback (most recent call last): File "/usr/local/lib/python2.7/site- packages/buildbot-0.8.6-py2.7.egg/buildbot/process/build.py", line 396, in _stepDone return self.startNextStep() File "/usr/local/lib/python2.7/site- packages/buildbot-0.8.6-py2.7.egg/buildbot/process/build.py", line 387, in startNextStep d.addErrback(self.buildException) File "/usr/local/lib/python2.7/site- packages/Twisted-12.0.0-py2.7-linux-x86_64.egg/twisted/internet/defer.py", line 312, in addErrback errbackKeywords=kw) File "/usr/local/lib/python2.7/site- packages/Twisted-12.0.0-py2.7-linux-x86_64.egg/twisted/internet/defer.py", line 290, in addCallbacks self._runCallbacks() --- --- File "/usr/local/lib/python2.7/site- packages/Twisted-12.0.0-py2.7-linux-x86_64.egg/twisted/internet/defer.py", line 551, in _runCallbacks current.result = callback(current.result, *args, **kw) File "/usr/local/lib/python2.7/site- packages/buildbot-0.8.6-py2.7.egg/buildbot/process/build.py", line 491, in buildException self.buildFinished(["build", "exception"], EXCEPTION) File "/usr/local/lib/python2.7/site- packages/buildbot-0.8.6-py2.7.egg/buildbot/process/build.py", line 507, in buildFinished self.remote.dontNotifyOnDisconnect(self.lostRemote) File "/usr/local/lib/python2.7/site- packages/Twisted-12.0.0-py2.7-linux-x86_64.egg/twisted/spread/pb.py", line 306, in dontNotifyOnDisconnect self.disconnectCallbacks.remove(callback) exceptions.ValueError: list.remove(x): x not in list }}} -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Thu Mar 22 14:12:51 2012 From: nobody at buildbot.net (Buildbot) Date: Thu, 22 Mar 2012 14:12:51 -0000 Subject: [Buildbot-commits] [Buildbot] #2254: MailNotifier gives exception: 'NoneType' object has no attribute 'changes' Message-ID: <042.ec522c4c8e9d0f9358077dcb5c27e1d2@buildbot.net> #2254: MailNotifier gives exception: 'NoneType' object has no attribute 'changes' -----------------------+----------------------- Reporter: jaredgrubb | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.6 | Keywords: -----------------------+----------------------- I see this exception in my logs: 14046 2012-03-21 20:12:14-0700 [-] Starting factory 14047 2012-03-21 20:12:14-0700 [-] Exception caught notifying of buildFinished event 14048 2012-03-21 20:12:14-0700 [-] Unhandled Error 14049 Traceback (most recent call last): 14050 File "/Users/buildbot/ctbot/src/master/buildbot/status/build.py", line 285, in buildFinished 14051 w.callback(self) 14052 File "/Users/buildbot/ctbot/sandbox/lib/python2.7/site- packages/twisted/internet/defer.py", line 368, in callback 14053 self._startRunCallbacks(result) 14054 File "/Users/buildbot/ctbot/sandbox/lib/python2.7/site- packages/twisted/internet/defer.py", line 464, in _startRunCallbacks 14055 self._runCallbacks() 14056 File "/Users/buildbot/ctbot/sandbox/lib/python2.7/site- packages/twisted/internet/defer.py", line 551, in _runCallbacks 14057 current.result = callback(current.result, *args, **kw) 14058 --- --- 14059 File "/Users/buildbot/ctbot/src/master/buildbot/status/builder.py", line 512, in _buildFinished 14060 w.buildFinished(name, s, results) 14061 File "/Users/buildbot/ctbot/src/master/buildbot/status/mail.py", line 435, in buildFinished 14062 return self.buildMessage(name, [build], results) 14063 File "/Users/buildbot/ctbot/src/master/buildbot/status/mail.py", line 654, in buildMessage 14064 d = self.useUsers(build) 14065 File "/Users/buildbot/ctbot/src/master/buildbot/status/mail.py", line 673, in useUsers 14066 d = self.parent.db.changes.getChangeUids(change.number) 14067 exceptions.AttributeError: 'NoneType' object has no attribute 'changes' 14068 Sometimes when I see this exception, I get an email; but not always. How does this boject end up without a 'db'? -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Thu Mar 22 14:13:27 2012 From: nobody at buildbot.net (Buildbot) Date: Thu, 22 Mar 2012 14:13:27 -0000 Subject: [Buildbot-commits] [Buildbot] #2254: MailNotifier gives exception: 'NoneType' object has no attribute 'changes' In-Reply-To: <042.ec522c4c8e9d0f9358077dcb5c27e1d2@buildbot.net> References: <042.ec522c4c8e9d0f9358077dcb5c27e1d2@buildbot.net> Message-ID: <057.b49eab0efe517c333f3be04cccbd0ff8@buildbot.net> #2254: MailNotifier gives exception: 'NoneType' object has no attribute 'changes' -----------------------+------------------------ Reporter: jaredgrubb | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.6 | Resolution: Keywords: | -----------------------+------------------------ Comment (by jaredgrubb): Redoing with better formatting: {{{ 14046 2012-03-21 20:12:14-0700 [-] Starting factory 14047 2012-03-21 20:12:14-0700 [-] Exception caught notifying of buildFinished event 14048 2012-03-21 20:12:14-0700 [-] Unhandled Error 14049 Traceback (most recent call last): 14050 File "/Users/buildbot/ctbot/src/master/buildbot/status/build.py", line 285, in buildFinished 14051 w.callback(self) 14052 File "/Users/buildbot/ctbot/sandbox/lib/python2.7/site- packages/twisted/internet/defer.py", line 368, in callback 14053 self._startRunCallbacks(result) 14054 File "/Users/buildbot/ctbot/sandbox/lib/python2.7/site- packages/twisted/internet/defer.py", line 464, in _startRunCallbacks 14055 self._runCallbacks() 14056 File "/Users/buildbot/ctbot/sandbox/lib/python2.7/site- packages/twisted/internet/defer.py", line 551, in _runCallbacks 14057 current.result = callback(current.result, *args, **kw) 14058 --- --- 14059 File "/Users/buildbot/ctbot/src/master/buildbot/status/builder.py", line 512, in _buildFinished 14060 w.buildFinished(name, s, results) 14061 File "/Users/buildbot/ctbot/src/master/buildbot/status/mail.py", line 435, in buildFinished 14062 return self.buildMessage(name, [build], results) 14063 File "/Users/buildbot/ctbot/src/master/buildbot/status/mail.py", line 654, in buildMessage 14064 d = self.useUsers(build) 14065 File "/Users/buildbot/ctbot/src/master/buildbot/status/mail.py", line 673, in useUsers 14066 d = self.parent.db.changes.getChangeUids(change.number) 14067 exceptions.AttributeError: 'NoneType' object has no attribute 'changes' 14068 }}} -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Thu Mar 22 14:57:00 2012 From: noreply at github.com (GitHub) Date: Thu, 22 Mar 2012 07:57:00 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 17abf8: Fix addStep deprecation warnings to report user co... Message-ID: <4f6b3dbcb193d_48a43fddd5b04af857941@sh1.rs.github.com.mail> Branch: refs/heads/buildbot-0.8.6 Home: https://github.com/buildbot/buildbot Commit: 17abf832e8de1b5532482a33ac0bb95906e8ea0d https://github.com/buildbot/buildbot/commit/17abf832e8de1b5532482a33ac0bb95906e8ea0d Author: Tom Prince Date: 2012-03-22 (Thu, 22 Mar 2012) Changed paths: M master/buildbot/process/factory.py Log Message: ----------- Fix addStep deprecation warnings to report user code responsible for the warning. From nobody at buildbot.net Thu Mar 22 22:48:34 2012 From: nobody at buildbot.net (Buildbot) Date: Thu, 22 Mar 2012 22:48:34 -0000 Subject: [Buildbot-commits] [Buildbot] #2254: MailNotifier gives exception: 'NoneType' object has no attribute 'changes' In-Reply-To: <042.ec522c4c8e9d0f9358077dcb5c27e1d2@buildbot.net> References: <042.ec522c4c8e9d0f9358077dcb5c27e1d2@buildbot.net> Message-ID: <057.2652752b478f4feecdd6a3cc22c4e7da@buildbot.net> #2254: MailNotifier gives exception: 'NoneType' object has no attribute 'changes' -----------------------+------------------------ Reporter: jaredgrubb | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.6 | Resolution: Keywords: | -----------------------+------------------------ Comment (by jaredgrubb): It just occured to me that this might be happening when the build ends with an Exception failure .. Since updating to 0.8.6 , I just realized that I havent seen any emails with the status of "Exception failure". -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Mar 23 02:11:52 2012 From: nobody at buildbot.net (Buildbot) Date: Fri, 23 Mar 2012 02:11:52 -0000 Subject: [Buildbot-commits] [Buildbot] #2255: forms.html is missing a closing div Message-ID: <042.673c72b2c05cea2447c67ea707f2fcd5@buildbot.net> #2255: forms.html is missing a closing div -----------------------+----------------------- Reporter: jaredgrubb | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.6 | Keywords: -----------------------+----------------------- Pretty sure this div is missing: {{{ diff --git a/master/buildbot/status/web/templates/forms.html b/master/buildbot/status/web/templates/forms.html index a74c28a..846fb46 100644 --- a/master/buildbot/status/web/templates/forms.html +++ b/master/buildbot/status/web/templates/forms.html @@ -140,6 +140,7 @@ {% endfor %}
+ {% endif %} {% endif %} {% endfor %} }}} -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Mar 23 04:34:15 2012 From: nobody at buildbot.net (Buildbot) Date: Fri, 23 Mar 2012 04:34:15 -0000 Subject: [Buildbot-commits] [Buildbot] #2256: sqlite is fantastically slow on blelbach-4 Message-ID: <038.3f00cf89cae24019b257c735c20aed1a@buildbot.net> #2256: sqlite is fantastically slow on blelbach-4 -------------------+------------------------- Reporter: dustin | Owner: Type: defect | Status: new Priority: minor | Milestone: 0.8.7 Version: 0.8.6 | Keywords: performance -------------------+------------------------- Look at these times: {{{ 2012-03-22 21:42:22-0600 [-] Log opened. 2012-03-22 21:42:22-0600 [-] --> buildbot.test.integration.test_upgrade.TestWeirdChanges.testUpgradeChangeNoRevision <-- 2012-03-22 21:42:22-0600 [-] cleaning database sqlite:// 2012-03-22 21:42:22-0600 [-] Setting up database with URL 'sqlite:///state.sqlite' 2012-03-22 21:42:22-0600 [-] setting database journal mode to 'wal' 2012-03-22 21:42:22-0600 [-] using SQLAlchemy-Migrate version 0.7.1 2012-03-22 21:42:24-0600 [-] migrating schema version 0 -> 1 2012-03-22 21:42:25-0600 [-] migrating schema version 1 -> 2 2012-03-22 21:42:27-0600 [-] migrating schema version 2 -> 3 2012-03-22 21:42:28-0600 [-] migrating schema version 3 -> 4 2012-03-22 21:42:29-0600 [-] migrating schema version 4 -> 5 2012-03-22 21:42:33-0600 [-] migrating schema version 5 -> 6 2012-03-22 21:42:33-0600 [-] migrating schema version 6 -> 7 2012-03-22 21:42:34-0600 [-] migrating schema version 7 -> 8 2012-03-22 21:42:34-0600 [-] migrating schema version 8 -> 9 2012-03-22 21:42:34-0600 [-] migrating schema version 9 -> 10 2012-03-22 21:42:35-0600 [-] migrating schema version 10 -> 11 2012-03-22 21:42:36-0600 [-] migrating schema version 11 -> 12 2012-03-22 21:42:37-0600 [-] migrating schema version 12 -> 13 2012-03-22 21:42:37-0600 [-] migrating schema version 13 -> 14 2012-03-22 21:42:38-0600 [-] migrating schema version 14 -> 15 2012-03-22 21:42:38-0600 [-] migrating schema version 15 -> 16 2012-03-22 21:42:38-0600 [-] migrating schema version 16 -> 17 2012-03-22 21:42:40-0600 [-] migrating schema version 17 -> 18 2012-03-22 21:42:41-0600 [-] migrating schema version 18 -> 19 2012-03-22 21:42:42-0600 [-] migrating schema version 19 -> 20 2012-03-22 21:42:42-0600 [-] migrating schema version 20 -> 21 2012-03-22 21:42:42-0600 [-] migrating schema version 21 -> 22 2012-03-22 21:42:43-0600 [-] Main loop terminated. }}} I took a brief look at dtruss output, but its timing information doesn't make sense to me - it claims to be in usec, but seems to actually be in units 1/65536 of a second. And I'm not sure if the decoration of each syscall is when the syscall *started* or when it *completed*. It *looks* like the fsync operations at WAL check points take 100's of msec, which would certainly explain this behavior. The drive in this system is a Hitachi HTS545050B9SA02. My r5 Mac Mini (Lion) shows the same behavior. This runs fine on my Macbook (Snow Leopard). This runs a lot faster (although not blindingly fast) if I turn off WAL mode. I'm running sqlite3 3.7.8. The buildslave has 3.7.7. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Mar 23 04:52:42 2012 From: nobody at buildbot.net (Buildbot) Date: Fri, 23 Mar 2012 04:52:42 -0000 Subject: [Buildbot-commits] [Buildbot] #2256: sqlite is fantastically slow on Lion (was: sqlite is fantastically slow on blelbach-4) In-Reply-To: <038.3f00cf89cae24019b257c735c20aed1a@buildbot.net> References: <038.3f00cf89cae24019b257c735c20aed1a@buildbot.net> Message-ID: <053.646c0d20f718818b07e52f1e1fbde153@buildbot.net> #2256: sqlite is fantastically slow on Lion ------------------------+-------------------- Reporter: dustin | Owner: Type: defect | Status: new Priority: minor | Milestone: 0.8.7 Version: 0.8.6 | Resolution: Keywords: performance | ------------------------+-------------------- -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Mar 23 23:33:12 2012 From: nobody at buildbot.net (Buildbot) Date: Fri, 23 Mar 2012 23:33:12 -0000 Subject: [Buildbot-commits] [Buildbot] #2257: incomplete path sanitization for buildstep names Message-ID: <039.603ad79b3cf36206f418fa3f92f6af40@buildbot.net> #2257: incomplete path sanitization for buildstep names --------------------+----------------------- Reporter: brendan | Owner: Type: defect | Status: new Priority: minor | Milestone: undecided Version: 0.8.5 | Keywords: --------------------+----------------------- Setting the "name" attribute of a buildstep to "./foo" produces a buildstep URL of the form ..."steps/.%2Ffoo". This link is broken (and the log file is in the form ..."-log-._foo"). -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Mar 23 23:34:42 2012 From: nobody at buildbot.net (Buildbot) Date: Fri, 23 Mar 2012 23:34:42 -0000 Subject: [Buildbot-commits] [Buildbot] #2257: incomplete path sanitization for buildstep names In-Reply-To: <039.603ad79b3cf36206f418fa3f92f6af40@buildbot.net> References: <039.603ad79b3cf36206f418fa3f92f6af40@buildbot.net> Message-ID: <054.e7e3c02b5b465405babd77941064a57b@buildbot.net> #2257: incomplete path sanitization for buildstep names --------------------+------------------------ Reporter: brendan | Owner: Type: defect | Status: new Priority: minor | Milestone: undecided Version: 0.8.5 | Resolution: Keywords: | --------------------+------------------------ Comment (by callek): a buildsteps name is not a path. What makes you think it should be? -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Fri Mar 23 23:44:42 2012 From: noreply at github.com (GitHub) Date: Fri, 23 Mar 2012 16:44:42 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 1c5803: Merge branch 'mailnotifier-is-buggy' (early part) ... Message-ID: <4f6d0aeac880c_32e13fd46b8b32f49718b@sh1.rs.github.com.mail> Branch: refs/heads/buildbot-0.8.6 Home: https://github.com/buildbot/buildbot Commit: 1c58034bfcba5f74ec7abb08716b3f225f068f1a https://github.com/buildbot/buildbot/commit/1c58034bfcba5f74ec7abb08716b3f225f068f1a Author: Tom Prince Date: 2012-03-23 (Fri, 23 Mar 2012) Changed paths: M master/buildbot/status/mail.py Log Message: ----------- Merge branch 'mailnotifier-is-buggy' (early part) into buildbot-0.8.6 From nobody at buildbot.net Sat Mar 24 02:59:55 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 24 Mar 2012 02:59:55 -0000 Subject: [Buildbot-commits] [Buildbot] #2257: incomplete URL sanitization for buildstep names (was: incomplete path sanitization for buildstep names) In-Reply-To: <039.603ad79b3cf36206f418fa3f92f6af40@buildbot.net> References: <039.603ad79b3cf36206f418fa3f92f6af40@buildbot.net> Message-ID: <054.1be99f8e9da7bf10c0008092ef99b9a8@buildbot.net> #2257: incomplete URL sanitization for buildstep names --------------------+------------------------ Reporter: brendan | Owner: Type: defect | Status: new Priority: minor | Milestone: undecided Version: 0.8.5 | Resolution: Keywords: | --------------------+------------------------ -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 24 17:04:03 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 24 Mar 2012 17:04:03 -0000 Subject: [Buildbot-commits] [Buildbot] #2258: master-side Git timeout ineffective Message-ID: <038.c31a3ba33418ecbfad1eb227a2737dfb@buildbot.net> #2258: master-side Git timeout ineffective -------------------+------------------------------------------- Reporter: dustin | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.7 Version: 0.8.6 | Keywords: git, master-side-source-steps -------------------+------------------------------------------- Hi, My source checkout looks like the following but it's timing out after 1200 seconds, which I think is the default. Is it possible that timeout isn't getting passed through? Also, I didn't get the since that the git devs were fired up about adding a --progress option for submodules so I'm afraid a longer timeout is my only option for now. from master.cfg: {{{ from buildbot.steps.source.git import Git factory.addStep(Git(repourl='git at github.com:erdc-cm/proteus.git', branch='master', progress=True, retryFetch=True, method='fresh', mode='full', submodules=True, timeout=45*60)) }}} Error message: {{{ Cloning into externalPackages/python... command timed out: 1200 seconds without output, attempting to kill process killed by signal 9 program finished with exit code -1 elapsedTime=1200.562956 }}} -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 24 17:56:06 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 24 Mar 2012 17:56:06 -0000 Subject: [Buildbot-commits] [Buildbot] #2255: forms.html is missing a closing div In-Reply-To: <042.673c72b2c05cea2447c67ea707f2fcd5@buildbot.net> References: <042.673c72b2c05cea2447c67ea707f2fcd5@buildbot.net> Message-ID: <057.5af9ec3751530b0afc1be84e1607d5d0@buildbot.net> #2255: forms.html is missing a closing div -----------------------+-------------------- Reporter: jaredgrubb | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.6 Version: 0.8.6 | Resolution: Keywords: | -----------------------+-------------------- Changes (by dustin): * milestone: undecided => 0.8.6 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 24 18:06:39 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 24 Mar 2012 18:06:39 -0000 Subject: [Buildbot-commits] [Buildbot] #2252: Reconfig after adding step results in buildException In-Reply-To: <037.7bbf90948ad8dd0d707e96de4e16894d@buildbot.net> References: <037.7bbf90948ad8dd0d707e96de4e16894d@buildbot.net> Message-ID: <052.16ecca484ce2c2a2c9d981bac74ac71a@buildbot.net> #2252: Reconfig after adding step results in buildException -------------------+--------------------- Reporter: tmidd | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.6 Version: 0.8.6 | Resolution: fixed Keywords: | -------------------+--------------------- Changes (by dustin): * milestone: undecided => 0.8.6 Old description: > I added an extra step to a builder and then reconfig'ed the master. The > step I added was automatically named MasterShellCommand_2 which pushed > the previous owner of that name to MasterShellCommand_3 (which didn't > exist previously). There were no builds running on the builder when I did > the reconfig. > > The next time the builder finished it threw the following exception and > failed to "end" correctly - that is, subsequent builds are pending even > though there is no active build. Restarting the master seems to have > fixed the problem. > > 2012-03-22 14:22:25+1300 [-] setting expectations for next time > 2012-03-22 14:22:25+1300 [-] .buildException > 2012-03-22 14:22:25+1300 [-] Unhandled Error > Traceback (most recent call last): > File "/usr/local/lib/python2.7/site- > packages/buildbot-0.8.6-py2.7.egg/buildbot/process/build.py", line 396, > in _stepDone > return self.startNextStep() > File "/usr/local/lib/python2.7/site- > packages/buildbot-0.8.6-py2.7.egg/buildbot/process/build.py", line 386, > in startNextStep > d.addCallback(self._stepDone, s) > File "/usr/local/lib/python2.7/site- > packages/Twisted-12.0.0-py2.7-linux- > x86_64.egg/twisted/internet/defer.py", line 301, in addCallback > callbackKeywords=kw) > File "/usr/local/lib/python2.7/site- > packages/Twisted-12.0.0-py2.7-linux- > x86_64.egg/twisted/internet/defer.py", line 290, in addCallbacks > self._runCallbacks() > --- --- > File "/usr/local/lib/python2.7/site- > packages/Twisted-12.0.0-py2.7-linux- > x86_64.egg/twisted/internet/defer.py", line 551, in _runCallbacks > current.result = callback(current.result, *args, **kw) > File "/usr/local/lib/python2.7/site- > packages/buildbot-0.8.6-py2.7.egg/buildbot/process/build.py", line 396, > in _stepDone > return self.startNextStep() > File "/usr/local/lib/python2.7/site- > packages/buildbot-0.8.6-py2.7.egg/buildbot/process/build.py", line 383, > in startNextStep > return self.allStepsDone() > File "/usr/local/lib/python2.7/site- > packages/buildbot-0.8.6-py2.7.egg/buildbot/process/build.py", line 486, > in allStepsDone > return self.buildFinished(text, self.result) > File "/usr/local/lib/python2.7/site- > packages/buildbot-0.8.6-py2.7.egg/buildbot/process/build.py", line 517, > in buildFinished > self.builder.setExpectations(self.progress) > File "/usr/local/lib/python2.7/site- > packages/buildbot-0.8.6-py2.7.egg/buildbot/process/builder.py", line 450, > in setExpectations > self.expectations.update(progress) > File "/usr/local/lib/python2.7/site- > packages/buildbot-0.8.6-py2.7.egg/buildbot/status/progress.py", line 295, > in update > old = self.times[name] > exceptions.KeyError: 'MasterShellCommand_3' > > It looks like it's trying to find the new step in a dict that wasn't > updated correctly by the reconfig, although I haven't had a proper look > through the code yet to confirm exactly what's going wrong. New description: I added an extra step to a builder and then reconfig'ed the master. The step I added was automatically named MasterShellCommand_2 which pushed the previous owner of that name to MasterShellCommand_3 (which didn't exist previously). There were no builds running on the builder when I did the reconfig. The next time the builder finished it threw the following exception and failed to "end" correctly - that is, subsequent builds are pending even though there is no active build. Restarting the master seems to have fixed the problem. {{{ 2012-03-22 14:22:25+1300 [-] setting expectations for next time 2012-03-22 14:22:25+1300 [-] .buildException 2012-03-22 14:22:25+1300 [-] Unhandled Error Traceback (most recent call last): File "/usr/local/lib/python2.7/site- packages/buildbot-0.8.6-py2.7.egg/buildbot/process/build.py", line 396, in _stepDone return self.startNextStep() File "/usr/local/lib/python2.7/site- packages/buildbot-0.8.6-py2.7.egg/buildbot/process/build.py", line 386, in startNextStep d.addCallback(self._stepDone, s) File "/usr/local/lib/python2.7/site- packages/Twisted-12.0.0-py2.7-linux-x86_64.egg/twisted/internet/defer.py", line 301, in addCallback callbackKeywords=kw) File "/usr/local/lib/python2.7/site- packages/Twisted-12.0.0-py2.7-linux-x86_64.egg/twisted/internet/defer.py", line 290, in addCallbacks self._runCallbacks() --- --- File "/usr/local/lib/python2.7/site- packages/Twisted-12.0.0-py2.7-linux-x86_64.egg/twisted/internet/defer.py", line 551, in _runCallbacks current.result = callback(current.result, *args, **kw) File "/usr/local/lib/python2.7/site- packages/buildbot-0.8.6-py2.7.egg/buildbot/process/build.py", line 396, in _stepDone return self.startNextStep() File "/usr/local/lib/python2.7/site- packages/buildbot-0.8.6-py2.7.egg/buildbot/process/build.py", line 383, in startNextStep return self.allStepsDone() File "/usr/local/lib/python2.7/site- packages/buildbot-0.8.6-py2.7.egg/buildbot/process/build.py", line 486, in allStepsDone return self.buildFinished(text, self.result) File "/usr/local/lib/python2.7/site- packages/buildbot-0.8.6-py2.7.egg/buildbot/process/build.py", line 517, in buildFinished self.builder.setExpectations(self.progress) File "/usr/local/lib/python2.7/site- packages/buildbot-0.8.6-py2.7.egg/buildbot/process/builder.py", line 450, in setExpectations self.expectations.update(progress) File "/usr/local/lib/python2.7/site- packages/buildbot-0.8.6-py2.7.egg/buildbot/status/progress.py", line 295, in update old = self.times[name] exceptions.KeyError: 'MasterShellCommand_3' }}} It looks like it's trying to find the new step in a dict that wasn't updated correctly by the reconfig, although I haven't had a proper look through the code yet to confirm exactly what's going wrong. -- -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sat Mar 24 18:30:41 2012 From: noreply at github.com (GitHub) Date: Sat, 24 Mar 2012 11:30:41 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 8cbf56: Add a missing tag Message-ID: <4f6e12d17c78d_6c26f25ae485760@sh2.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 8cbf56cca8f77965afc95804de9496bd3e901dc1 https://github.com/buildbot/buildbot/commit/8cbf56cca8f77965afc95804de9496bd3e901dc1 Author: Dustin J. Mitchell Date: 2012-03-24 (Sat, 24 Mar 2012) Changed paths: M master/buildbot/status/web/templates/forms.html Log Message: ----------- Add a missing tag Fixes #2255. Commit: 084c17d33fb112c9d4f196b4ea70d70536468d78 https://github.com/buildbot/buildbot/commit/084c17d33fb112c9d4f196b4ea70d70536468d78 Author: Dustin J. Mitchell Date: 2012-03-24 (Sat, 24 Mar 2012) Changed paths: M master/buildbot/process/build.py M master/buildbot/test/unit/test_process_build.py Log Message: ----------- Be somewhat more resilient to buildFinished failures This isn't perfect, because buildFinished alters a lot of state and the means of cleaning up from a partial execution is not clear. Fixes #2253. Commit: a41b538e40de671d9e984da0ef5a7338a847ab75 https://github.com/buildbot/buildbot/commit/a41b538e40de671d9e984da0ef5a7338a847ab75 Author: Dustin J. Mitchell Date: 2012-03-24 (Sat, 24 Mar 2012) Changed paths: M master/buildbot/process/build.py M master/buildbot/schedulers/forcesched.py M master/buildbot/status/web/templates/forms.html M master/buildbot/test/unit/test_process_build.py M master/buildbot/test/unit/test_schedulers_forcesched.py Log Message: ----------- Merge branch 'buildbot-0.8.6' * buildbot-0.8.6: Be somewhat more resilient to buildFinished failures Add a missing tag Fix handling of a lost slave while waiting for a lock. Fix compare_attrs of ForceScheduler. Compare: https://github.com/buildbot/buildbot/compare/2a4c41b...a41b538 From nobody at buildbot.net Sat Mar 24 18:30:50 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 24 Mar 2012 18:30:50 -0000 Subject: [Buildbot-commits] [Buildbot] #2253: Deal gracefully with exceptions thrown before a build is fully started. In-Reply-To: <042.502e4bfc2195e4e199f3bdfb474d498c@buildbot.net> References: <042.502e4bfc2195e4e199f3bdfb474d498c@buildbot.net> Message-ID: <057.573f116d60db8f6d8474beb351b93d47@buildbot.net> #2253: Deal gracefully with exceptions thrown before a build is fully started. -----------------------+------------------------ Reporter: tom.prince | Owner: Type: defect | Status: closed Priority: major | Milestone: undecided Version: 0.8.6 | Resolution: fixed Keywords: | -----------------------+------------------------ Changes (by Dustin J. Mitchell): * status: new => closed * resolution: => fixed Comment: Be somewhat more resilient to buildFinished failures This isn't perfect, because buildFinished alters a lot of state and the means of cleaning up from a partial execution is not clear. Fixes #2253. Changeset: 084c17d33fb112c9d4f196b4ea70d70536468d78 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 24 18:30:49 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 24 Mar 2012 18:30:49 -0000 Subject: [Buildbot-commits] [Buildbot] #2255: forms.html is missing a closing div In-Reply-To: <042.673c72b2c05cea2447c67ea707f2fcd5@buildbot.net> References: <042.673c72b2c05cea2447c67ea707f2fcd5@buildbot.net> Message-ID: <057.d90758a89086aa9305b543870301824e@buildbot.net> #2255: forms.html is missing a closing div -----------------------+--------------------- Reporter: jaredgrubb | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.6 Version: 0.8.6 | Resolution: fixed Keywords: | -----------------------+--------------------- Changes (by Dustin J. Mitchell): * status: new => closed * resolution: => fixed Comment: Add a missing tag Fixes #2255. Changeset: 8cbf56cca8f77965afc95804de9496bd3e901dc1 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 24 18:34:53 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 24 Mar 2012 18:34:53 -0000 Subject: [Buildbot-commits] [Buildbot] #2249: change merging is no longer picking the newest change In-Reply-To: <038.f93398e709d16911e6724171d2de32ee@buildbot.net> References: <038.f93398e709d16911e6724171d2de32ee@buildbot.net> Message-ID: <053.aa750d2085f394e16d0a5c8c7728f0b4@buildbot.net> #2249: change merging is no longer picking the newest change -------------------+-------------------- Reporter: dustin | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.6 Version: 0.8.6 | Resolution: Keywords: | -------------------+-------------------- Changes (by dustin): * milestone: 0.8.7 => 0.8.6 -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sat Mar 24 18:34:53 2012 From: noreply at github.com (GitHub) Date: Sat, 24 Mar 2012 11:34:53 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 8cbf56: Add a missing tag Message-ID: <4f6e13cd6bd1f_28e73fc6610332f479498@sh1.rs.github.com.mail> Branch: refs/heads/buildbot-0.8.6 Home: https://github.com/buildbot/buildbot Commit: 8cbf56cca8f77965afc95804de9496bd3e901dc1 https://github.com/buildbot/buildbot/commit/8cbf56cca8f77965afc95804de9496bd3e901dc1 Author: Dustin J. Mitchell Date: 2012-03-24 (Sat, 24 Mar 2012) Changed paths: M master/buildbot/status/web/templates/forms.html Log Message: ----------- Add a missing tag Fixes #2255. Commit: 084c17d33fb112c9d4f196b4ea70d70536468d78 https://github.com/buildbot/buildbot/commit/084c17d33fb112c9d4f196b4ea70d70536468d78 Author: Dustin J. Mitchell Date: 2012-03-24 (Sat, 24 Mar 2012) Changed paths: M master/buildbot/process/build.py M master/buildbot/test/unit/test_process_build.py Log Message: ----------- Be somewhat more resilient to buildFinished failures This isn't perfect, because buildFinished alters a lot of state and the means of cleaning up from a partial execution is not clear. Fixes #2253. Commit: 45013e4c65db5d1a59cc89a13eebe551b5510a17 https://github.com/buildbot/buildbot/commit/45013e4c65db5d1a59cc89a13eebe551b5510a17 Author: Dustin J. Mitchell Date: 2012-03-24 (Sat, 24 Mar 2012) Changed paths: M master/buildbot/process/factory.py M master/buildbot/status/mail.py M master/buildbot/status/master.py M master/buildbot/status/progress.py A master/buildbot/test/unit/test_status_progress.py Log Message: ----------- Merge branch 'buildbot-0.8.6' of github.com:buildbot/buildbot into buildbot-0.8.6 * 'buildbot-0.8.6' of github.com:buildbot/buildbot: Fix addStep deprecation warnings to report user code responsible for the warning. Use naturalSort instead of sort for builer lists. Fix crashes when adding new steps in reconfig. Fix out of order error in MailNotifier._gotBuilds. Commit: 8bad9e85e2d26a0df95a7e31d69ae187af5e0dda https://github.com/buildbot/buildbot/commit/8bad9e85e2d26a0df95a7e31d69ae187af5e0dda Author: Dustin J. Mitchell Date: 2012-03-24 (Sat, 24 Mar 2012) Changed paths: M master/buildbot/status/mail.py M master/buildbot/test/unit/test_status_progress.py Log Message: ----------- fix pyflakes Compare: https://github.com/buildbot/buildbot/compare/1c58034...8bad9e8 From noreply at github.com Sat Mar 24 18:34:54 2012 From: noreply at github.com (GitHub) Date: Sat, 24 Mar 2012 11:34:54 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 45013e: Merge branch 'buildbot-0.8.6' of github.com:buildb... Message-ID: <4f6e13ceabffa_30253ffb00a37aec449c0@sh1.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 45013e4c65db5d1a59cc89a13eebe551b5510a17 https://github.com/buildbot/buildbot/commit/45013e4c65db5d1a59cc89a13eebe551b5510a17 Author: Dustin J. Mitchell Date: 2012-03-24 (Sat, 24 Mar 2012) Changed paths: M master/buildbot/process/factory.py M master/buildbot/status/mail.py M master/buildbot/status/master.py M master/buildbot/status/progress.py A master/buildbot/test/unit/test_status_progress.py Log Message: ----------- Merge branch 'buildbot-0.8.6' of github.com:buildbot/buildbot into buildbot-0.8.6 * 'buildbot-0.8.6' of github.com:buildbot/buildbot: Fix addStep deprecation warnings to report user code responsible for the warning. Use naturalSort instead of sort for builer lists. Fix crashes when adding new steps in reconfig. Fix out of order error in MailNotifier._gotBuilds. Commit: 8bad9e85e2d26a0df95a7e31d69ae187af5e0dda https://github.com/buildbot/buildbot/commit/8bad9e85e2d26a0df95a7e31d69ae187af5e0dda Author: Dustin J. Mitchell Date: 2012-03-24 (Sat, 24 Mar 2012) Changed paths: M master/buildbot/status/mail.py M master/buildbot/test/unit/test_status_progress.py Log Message: ----------- fix pyflakes Commit: 4cfbacb604f3460d294da7759686298292772e0d https://github.com/buildbot/buildbot/commit/4cfbacb604f3460d294da7759686298292772e0d Author: Dustin J. Mitchell Date: 2012-03-24 (Sat, 24 Mar 2012) Changed paths: M master/buildbot/process/factory.py M master/buildbot/status/mail.py M master/buildbot/status/master.py M master/buildbot/status/progress.py A master/buildbot/test/unit/test_status_progress.py Log Message: ----------- Merge branch 'buildbot-0.8.6' * buildbot-0.8.6: fix pyflakes Fix addStep deprecation warnings to report user code responsible for the warning. Use naturalSort instead of sort for builer lists. Fix crashes when adding new steps in reconfig. Fix out of order error in MailNotifier._gotBuilds. Compare: https://github.com/buildbot/buildbot/compare/a41b538...4cfbacb From nobody at buildbot.net Sat Mar 24 18:34:56 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 24 Mar 2012 18:34:56 -0000 Subject: [Buildbot-commits] [Buildbot] #2255: forms.html is missing a closing div In-Reply-To: <042.673c72b2c05cea2447c67ea707f2fcd5@buildbot.net> References: <042.673c72b2c05cea2447c67ea707f2fcd5@buildbot.net> Message-ID: <057.cb9521b9e2a6d8703d99dbe5a5c4b1a3@buildbot.net> #2255: forms.html is missing a closing div -----------------------+--------------------- Reporter: jaredgrubb | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.6 Version: 0.8.6 | Resolution: fixed Keywords: | -----------------------+--------------------- Comment (by Dustin J. Mitchell): Add a missing tag Fixes #2255. Changeset: 8cbf56cca8f77965afc95804de9496bd3e901dc1 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 24 18:34:57 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 24 Mar 2012 18:34:57 -0000 Subject: [Buildbot-commits] [Buildbot] #2253: Deal gracefully with exceptions thrown before a build is fully started. In-Reply-To: <042.502e4bfc2195e4e199f3bdfb474d498c@buildbot.net> References: <042.502e4bfc2195e4e199f3bdfb474d498c@buildbot.net> Message-ID: <057.e884dc6550b2791f0644c2303016438f@buildbot.net> #2253: Deal gracefully with exceptions thrown before a build is fully started. -----------------------+------------------------ Reporter: tom.prince | Owner: Type: defect | Status: closed Priority: major | Milestone: undecided Version: 0.8.6 | Resolution: fixed Keywords: | -----------------------+------------------------ Comment (by Dustin J. Mitchell): Be somewhat more resilient to buildFinished failures This isn't perfect, because buildFinished alters a lot of state and the means of cleaning up from a partial execution is not clear. Fixes #2253. Changeset: 084c17d33fb112c9d4f196b4ea70d70536468d78 -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sat Mar 24 20:39:48 2012 From: noreply at github.com (GitHub) Date: Sat, 24 Mar 2012 13:39:48 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 8dd9fd: remove spurious message Message-ID: <4f6e31146acb7_b273f91f56f0aec1064c2@sh1.rs.github.com.mail> Branch: refs/heads/buildbot-0.8.6 Home: https://github.com/buildbot/buildbot Commit: 8dd9fd0dd2bb61997ec22e70322723ab8b058e42 https://github.com/buildbot/buildbot/commit/8dd9fd0dd2bb61997ec22e70322723ab8b058e42 Author: Dustin J. Mitchell Date: 2012-03-24 (Sat, 24 Mar 2012) Changed paths: M master/buildbot/process/buildstep.py Log Message: ----------- remove spurious message Commit: b6d339e86ee3d9700e558d41b5bae5522dea47fd https://github.com/buildbot/buildbot/commit/b6d339e86ee3d9700e558d41b5bae5522dea47fd Author: Dustin J. Mitchell Date: 2012-03-24 (Sat, 24 Mar 2012) Changed paths: M master/buildbot/revlinks.py Log Message: ----------- remove spurious print Compare: https://github.com/buildbot/buildbot/compare/8bad9e8...b6d339e From noreply at github.com Sat Mar 24 20:39:49 2012 From: noreply at github.com (GitHub) Date: Sat, 24 Mar 2012 13:39:49 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 8dd9fd: remove spurious message Message-ID: <4f6e3115bc1b0_73e71710aec10433a@sh2.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 8dd9fd0dd2bb61997ec22e70322723ab8b058e42 https://github.com/buildbot/buildbot/commit/8dd9fd0dd2bb61997ec22e70322723ab8b058e42 Author: Dustin J. Mitchell Date: 2012-03-24 (Sat, 24 Mar 2012) Changed paths: M master/buildbot/process/buildstep.py Log Message: ----------- remove spurious message Commit: b6d339e86ee3d9700e558d41b5bae5522dea47fd https://github.com/buildbot/buildbot/commit/b6d339e86ee3d9700e558d41b5bae5522dea47fd Author: Dustin J. Mitchell Date: 2012-03-24 (Sat, 24 Mar 2012) Changed paths: M master/buildbot/revlinks.py Log Message: ----------- remove spurious print Commit: 6fd7b1b51ba9fd1782c3e1fd3c052e04842f8fb4 https://github.com/buildbot/buildbot/commit/6fd7b1b51ba9fd1782c3e1fd3c052e04842f8fb4 Author: Dustin J. Mitchell Date: 2012-03-24 (Sat, 24 Mar 2012) Changed paths: M master/buildbot/process/buildstep.py M master/buildbot/revlinks.py Log Message: ----------- Merge branch 'buildbot-0.8.6' * buildbot-0.8.6: remove spurious print remove spurious message Compare: https://github.com/buildbot/buildbot/compare/4cfbacb...6fd7b1b From nobody at buildbot.net Sat Mar 24 20:59:00 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 24 Mar 2012 20:59:00 -0000 Subject: [Buildbot-commits] [Buildbot] #2249: change merging is no longer picking the newest change In-Reply-To: <038.f93398e709d16911e6724171d2de32ee@buildbot.net> References: <038.f93398e709d16911e6724171d2de32ee@buildbot.net> Message-ID: <053.4d8bb070d3287ae9f0b8eb308abdbe20@buildbot.net> #2249: change merging is no longer picking the newest change -------------------+-------------------- Reporter: dustin | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.7 Version: 0.8.6 | Resolution: Keywords: | -------------------+-------------------- Changes (by dustin): * milestone: 0.8.6 => 0.8.7 Comment: I can't reproduce this externally. I'm using a sendchange loop to send changes every 2s for a 5s build, and the changes come out in the right order, and with the right revision. Here's what I've got so far, from the db: * Changes 4011 and 4012 were placed in the same sourcestamp (1976) due to a tree stable timer. Change 4013 was in its own sourcestamp (1977). * Buildset 1980 points to ss 1976, and buildset 1981 points to ss 1977 * os-leopard !BuildRequest 42880 points to buildset 1980, and 42922 points to buildset 1981. The build-starting process looks like this: * in `maybeStartBuild`, `unclaimed_requests = [
,
]` (sorted by the buildsets' `submitted_at`) * it calls `_chooseBuild`, which simply returns the first - `
` * that gets merged with br 42922 * `Build()` gets called with `[
,
]` * it sets its `.source` to `
.mergeWith([
])` * ..which calls `SourceStamp.mergeWith` * ..which concatenates the changes as `
.changes +
.changes`, or `[ , , ]` * ..and calls the `SourceStamp` constructor, which gets the revision from the last change, and thus should get change 4013's revision. Clearly, something did not happen as expected here: by the time `SourceStamp.mergeWith` got called, the build requests were in the wrong order. So either unclaimed_requests is not sorted correctly, or `_chooseBuild` is misbehaving, or the merging is re-ordering things. All of those seem pretty bulletproof. `unclaimed_requests` is properly sorted - I tested by shuffling the list before sorting. `_chooseBuild` just returns `[0]`. And while `_mergeRequests` does use `gatherResults`, it does so in a fashion that correctly maintains order - I tested by adding a random delay to each `_brdictToBuildRequest` invocation. So I'm at a loss to figure out what went wrong here. Which means I can't fix it for 0.8.6 without more evidence. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sat Mar 24 21:02:23 2012 From: noreply at github.com (GitHub) Date: Sat, 24 Mar 2012 14:02:23 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 5225a7: Bump the test timeout for upgrade tests Message-ID: <4f6e365f66b0b_8ab1be0af442799@sh2.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 5225a7605fb4dc9cbfa10285a2e84d45b6c6e3bd https://github.com/buildbot/buildbot/commit/5225a7605fb4dc9cbfa10285a2e84d45b6c6e3bd Author: Dustin J. Mitchell Date: 2012-03-24 (Sat, 24 Mar 2012) Changed paths: M master/buildbot/test/integration/test_upgrade.py Log Message: ----------- Bump the test timeout for upgrade tests These take less than 1s on my linux system, but on a busy HFS filesystem can take over 120s. Refs #2256. From nobody at buildbot.net Sat Mar 24 21:02:30 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 24 Mar 2012 21:02:30 -0000 Subject: [Buildbot-commits] [Buildbot] #2256: sqlite is fantastically slow on Lion In-Reply-To: <038.3f00cf89cae24019b257c735c20aed1a@buildbot.net> References: <038.3f00cf89cae24019b257c735c20aed1a@buildbot.net> Message-ID: <053.db677deb31cdbc317b8a338890b78d4d@buildbot.net> #2256: sqlite is fantastically slow on Lion ------------------------+-------------------- Reporter: dustin | Owner: Type: defect | Status: new Priority: minor | Milestone: 0.8.7 Version: 0.8.6 | Resolution: Keywords: performance | ------------------------+-------------------- Comment (by Dustin J. Mitchell): Bump the test timeout for upgrade tests These take less than 1s on my linux system, but on a busy HFS filesystem can take over 120s. Refs #2256. Changeset: 5225a7605fb4dc9cbfa10285a2e84d45b6c6e3bd -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sat Mar 24 23:30:03 2012 From: noreply at github.com (GitHub) Date: Sat, 24 Mar 2012 16:30:03 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] aa687f: Merge branch 'mail-notifier' of https://github.com... Message-ID: <4f6e58fb4a467_36fd115daf088265@sh2.rs.github.com.mail> Branch: refs/heads/buildbot-0.8.6 Home: https://github.com/buildbot/buildbot Commit: aa687fae879dbfc9496fb92fbac77f0db7cb6d75 https://github.com/buildbot/buildbot/commit/aa687fae879dbfc9496fb92fbac77f0db7cb6d75 Author: Dustin J. Mitchell Date: 2012-03-24 (Sat, 24 Mar 2012) Changed paths: M master/buildbot/status/mail.py M master/buildbot/status/master.py M master/buildbot/test/unit/test_status_mail.py Log Message: ----------- Merge branch 'mail-notifier' of https://github.com/tomprince/buildbot into buildbot-0.8.6 * 'mail-notifier' of https://github.com/tomprince/buildbot: Fix bogus reference to master_status.db in buildbot.status.mail. From noreply at github.com Sat Mar 24 23:30:04 2012 From: noreply at github.com (GitHub) Date: Sat, 24 Mar 2012 16:30:04 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] aa687f: Merge branch 'mail-notifier' of https://github.com... Message-ID: <4f6e58fcb2480_2cc9115caec388e2@sh2.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: aa687fae879dbfc9496fb92fbac77f0db7cb6d75 https://github.com/buildbot/buildbot/commit/aa687fae879dbfc9496fb92fbac77f0db7cb6d75 Author: Dustin J. Mitchell Date: 2012-03-24 (Sat, 24 Mar 2012) Changed paths: M master/buildbot/status/mail.py M master/buildbot/status/master.py M master/buildbot/test/unit/test_status_mail.py Log Message: ----------- Merge branch 'mail-notifier' of https://github.com/tomprince/buildbot into buildbot-0.8.6 * 'mail-notifier' of https://github.com/tomprince/buildbot: Fix bogus reference to master_status.db in buildbot.status.mail. Commit: 6aba4c4f37b47fe526b9ebbb9581116b73285eb4 https://github.com/buildbot/buildbot/commit/6aba4c4f37b47fe526b9ebbb9581116b73285eb4 Author: Dustin J. Mitchell Date: 2012-03-24 (Sat, 24 Mar 2012) Changed paths: M master/buildbot/status/mail.py M master/buildbot/status/master.py M master/buildbot/test/unit/test_status_mail.py Log Message: ----------- Merge branch 'buildbot-0.8.6' * buildbot-0.8.6: Fix bogus reference to master_status.db in buildbot.status.mail. Compare: https://github.com/buildbot/buildbot/compare/5225a76...6aba4c4 From noreply at github.com Sun Mar 25 01:50:03 2012 From: noreply at github.com (GitHub) Date: Sat, 24 Mar 2012 18:50:03 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 7482c3: Merge branch 'ticket_1766' of git://github.com/bdb... Message-ID: <4f6e79cb2a192_52053ff28a815af8103359@sh1.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 7482c3eb49c455d1d62d289a8e6127eaede543f4 https://github.com/buildbot/buildbot/commit/7482c3eb49c455d1d62d289a8e6127eaede543f4 Author: Dustin J. Mitchell Date: 2012-03-24 (Sat, 24 Mar 2012) Changed paths: M master/buildbot/changes/svnpoller.py M master/buildbot/test/unit/test_changes_svnpoller.py M master/buildbot/test/util/gpo.py M master/docs/manual/cfg-changesources.rst M master/docs/release-notes/0.8.6.rst Log Message: ----------- Merge branch 'ticket_1766' of git://github.com/bdbaddog/buildbot * 'ticket_1766' of git://github.com/bdbaddog/buildbot: removed test code which wasn't used in the end added extra_args to SVNPoller documentation interim checkin. Functions, but needs tests From nobody at buildbot.net Sun Mar 25 23:54:08 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 25 Mar 2012 23:54:08 -0000 Subject: [Buildbot-commits] [Buildbot] #2254: MailNotifier gives exception: 'NoneType' object has no attribute 'changes' In-Reply-To: <042.ec522c4c8e9d0f9358077dcb5c27e1d2@buildbot.net> References: <042.ec522c4c8e9d0f9358077dcb5c27e1d2@buildbot.net> Message-ID: <057.6573614652dbaae612380105a96dd5e3@buildbot.net> #2254: MailNotifier gives exception: 'NoneType' object has no attribute 'changes' -----------------------+--------------------- Reporter: jaredgrubb | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.6 Version: 0.8.6 | Resolution: fixed Keywords: | -----------------------+--------------------- Changes (by dustin): * status: new => closed * resolution: => fixed * milestone: undecided => 0.8.6 Comment: I'm not sure why this didn't get automatically recorded. {{{ commit 4d3b0318025ca38c148a09e2fec5f2f97f61be57 Author: Tom Prince Date: Fri Mar 23 19:32:20 2012 -0400 Fix bogus reference to master_status.db in buildbot.status.mail. Fixes #2254. }}} -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Mar 26 01:19:45 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 26 Mar 2012 01:19:45 -0000 Subject: [Buildbot-commits] [Buildbot] #2259: Support a read-only backend db Message-ID: <038.349b88175100a5389d22a048d7ba407a@buildbot.net> #2259: Support a read-only backend db ------------------------+---------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.7 Version: 0.8.6p1 | Keywords: database ------------------------+---------------------- The DB API currently only supports one `db_url`. We should support two, so that most of the getXxx methods can use the read-only DB. Operations that require read-after-write consistency would still use the read-write DB. MySQL supports master/slave replication, where the slave(s) can support read-only operations, so this would allow us to scale database access appropriately for read-heavy applications (e.g., frontend web servers). MySQL replication has a small delay, so we'd still want to do things like claiming buildrequests exclusively on the read-write DB. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Mar 26 19:38:13 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 26 Mar 2012 19:38:13 -0000 Subject: [Buildbot-commits] [Buildbot] #1747: output from different stages mixed after slave disconnects/reconnects In-Reply-To: <041.dc47916f5f59bc1973e6919b8a0771c9@buildbot.net> References: <041.dc47916f5f59bc1973e6919b8a0771c9@buildbot.net> Message-ID: <056.3a69e162ced24a5f26f301b9d90c485d@buildbot.net> #1747: output from different stages mixed after slave disconnects/reconnects ----------------------+----------------------- Reporter: philippem | Owner: Type: defect | Status: reopened Priority: major | Milestone: 0.8.+ Version: 0.8.2 | Resolution: Keywords: windows | ----------------------+----------------------- Comment (by dustin): Amber just discovered that if the builddir is the same for multiple builders, then there's a good chance that their 'stdio' logs will append to one another, which can cause this kind of mixed-up log to appear. Perhaps that's what's going on here? -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Mar 26 19:54:52 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 26 Mar 2012 19:54:52 -0000 Subject: [Buildbot-commits] [Buildbot] #2260: 'builddir' path is used on both master and slave Message-ID: <037.7959f633653eb0835f9d4fef7d20a5a4@buildbot.net> #2260: 'builddir' path is used on both master and slave ---------------------+------------------- Reporter: ayust | Owner: Type: defect | Status: new Priority: critical | Milestone: 0.9.0 Version: master | Keywords: ---------------------+------------------- So as it turns out, a given builder's `builddir` property is actually used for two different things: * On the slave, it's the path to the directory which contains the builder data (sourcestamp, etc) and workdir * On the master, it's the path to the directory which contains the saved build results For relative paths, this works "ok" most of the time - on the master, it's relative to the master's root directory (which is unique-per-master), and on the slave, it's relative to the slave's root directory (which is fine, because it's unique-per-slave, and slaves are currently unique-per- master). Problems arise, however, if one of the following is true: * two different buildbot (masters/slaves) are running on the same machine, and an '''absolute''' path is used * two builders have the same builddir, even if they're on different slaves Because the builddir path is also used on the master for storing results files, this introduces a potential conflict between paths for multiple builders (potentially even across different masters, in the case of absolute paths) which can result in race conditions and/or combination of data from different builds. At a bare minimum, Builder should be changed to have ''separate'' path settings for the master-side data storage and the slave-side build directory. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Mar 26 19:58:31 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 26 Mar 2012 19:58:31 -0000 Subject: [Buildbot-commits] [Buildbot] #2260: 'builddir' path is used on both master and slave In-Reply-To: <037.7959f633653eb0835f9d4fef7d20a5a4@buildbot.net> References: <037.7959f633653eb0835f9d4fef7d20a5a4@buildbot.net> Message-ID: <052.b6cb93059ac885c4d031cf8342dcfd27@buildbot.net> #2260: 'builddir' path is used on both master and slave ---------------------+-------------------- Reporter: ayust | Owner: Type: defect | Status: new Priority: critical | Milestone: 0.9.0 Version: master | Resolution: Keywords: | ---------------------+-------------------- Comment (by tom.prince): There is already both `builddir` and `slavebuilddir`, with the latter defaulting to the former. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Mar 26 20:22:06 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 26 Mar 2012 20:22:06 -0000 Subject: [Buildbot-commits] [Buildbot] #2260: 'builddir' path is used on both master and slave In-Reply-To: <037.7959f633653eb0835f9d4fef7d20a5a4@buildbot.net> References: <037.7959f633653eb0835f9d4fef7d20a5a4@buildbot.net> Message-ID: <052.3b811c2418c1ff91fecf9a17f8654cf6@buildbot.net> #2260: 'builddir' path is used on both master and slave ---------------------+-------------------- Reporter: ayust | Owner: Type: defect | Status: new Priority: critical | Milestone: 0.9.0 Version: master | Resolution: Keywords: | ---------------------+-------------------- Comment (by ayust): I'd say they should get renamed then, because I definitely expect `builddir` to refer to the slave directory first. `resultsdir` would make more sense for the master's version, and it's the one that should get set explicit if different. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Mon Mar 26 22:15:03 2012 From: noreply at github.com (GitHub) Date: Mon, 26 Mar 2012 15:15:03 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 9a2d07: add release notes for 0.8.6p1 Message-ID: <4f70ea67152b1_72233fe2a0cceaf8745ea@sh1.rs.github.com.mail> Branch: refs/tags/v0.8.6p1 Home: https://github.com/buildbot/buildbot Commit: 9a2d07b07592787fb68f2f0cee4a1c6258f26314 https://github.com/buildbot/buildbot/commit/9a2d07b07592787fb68f2f0cee4a1c6258f26314 Author: Dustin J. Mitchell Date: 2012-03-25 (Sun, 25 Mar 2012) Changed paths: M master/docs/release-notes.rst Log Message: ----------- add release notes for 0.8.6p1 From nobody at buildbot.net Tue Mar 27 05:07:23 2012 From: nobody at buildbot.net (Buildbot) Date: Tue, 27 Mar 2012 05:07:23 -0000 Subject: [Buildbot-commits] [Buildbot] #1747: output from different stages mixed after slave disconnects/reconnects In-Reply-To: <041.dc47916f5f59bc1973e6919b8a0771c9@buildbot.net> References: <041.dc47916f5f59bc1973e6919b8a0771c9@buildbot.net> Message-ID: <056.351d764be198c7caf5c08be411c6519f@buildbot.net> #1747: output from different stages mixed after slave disconnects/reconnects ----------------------+----------------------- Reporter: philippem | Owner: Type: defect | Status: reopened Priority: major | Milestone: 0.8.+ Version: 0.8.2 | Resolution: Keywords: windows | ----------------------+----------------------- Comment (by dustin): #2260, in particular. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Tue Mar 27 05:11:00 2012 From: nobody at buildbot.net (Buildbot) Date: Tue, 27 Mar 2012 05:11:00 -0000 Subject: [Buildbot-commits] [Buildbot] #2260: 'builddir' path is used on both master and slave In-Reply-To: <037.7959f633653eb0835f9d4fef7d20a5a4@buildbot.net> References: <037.7959f633653eb0835f9d4fef7d20a5a4@buildbot.net> Message-ID: <052.26c416f2066e9a78286fa0e582bf4108@buildbot.net> #2260: 'builddir' path is used on both master and slave -------------------+-------------------- Reporter: ayust | Owner: Type: defect | Status: new Priority: minor | Milestone: 0.8.7 Version: master | Resolution: Keywords: simple | -------------------+-------------------- Changes (by dustin): * keywords: => simple * priority: critical => minor * milestone: 0.9.0 => 0.8.7 Comment: At one point, there were explicit checks for overlapping builddirs, though slavedirs are intentionally allowed to overlap (Use At Your Own Risk). This check, assuming it's still working, would prevent the second point -- "two builders have the same builddir" -- from occurring. Since this will be obviated by moving this data to the database, perhaps for the remainder of 0.8.x we should just issue a warning for absolute paths in builddirs? * minor because while this caused mayhem, it is something of a corner case; and * simple because adding this warning only requires grokking `master/buildbot/config.py`. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Tue Mar 27 05:36:55 2012 From: nobody at buildbot.net (Buildbot) Date: Tue, 27 Mar 2012 05:36:55 -0000 Subject: [Buildbot-commits] [Buildbot] #1747: output from different stages mixed after slave disconnects/reconnects In-Reply-To: <041.dc47916f5f59bc1973e6919b8a0771c9@buildbot.net> References: <041.dc47916f5f59bc1973e6919b8a0771c9@buildbot.net> Message-ID: <056.06f288b548c18f92f506aef9ca6aa8ea@buildbot.net> #1747: output from different stages mixed after slave disconnects/reconnects ----------------------+----------------------- Reporter: philippem | Owner: Type: defect | Status: reopened Priority: major | Milestone: 0.8.+ Version: 0.8.2 | Resolution: Keywords: windows | ----------------------+----------------------- Comment (by philippem): Many of our slaves use the same builddir, since our product's runtime assumes a fixed path. That could be the source of this bug. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Tue Mar 27 05:38:33 2012 From: nobody at buildbot.net (Buildbot) Date: Tue, 27 Mar 2012 05:38:33 -0000 Subject: [Buildbot-commits] [Buildbot] #1747: output from different stages mixed after slave disconnects/reconnects In-Reply-To: <041.dc47916f5f59bc1973e6919b8a0771c9@buildbot.net> References: <041.dc47916f5f59bc1973e6919b8a0771c9@buildbot.net> Message-ID: <056.13f4694532d9f5582cf55b83270f09a4@buildbot.net> #1747: output from different stages mixed after slave disconnects/reconnects ----------------------+----------------------- Reporter: philippem | Owner: Type: defect | Status: reopened Priority: major | Milestone: 0.8.+ Version: 0.8.2 | Resolution: Keywords: windows | ----------------------+----------------------- Comment (by dustin): Hm, interesting - see my comments in #2260, particularly around builddirs needing to be distinct on a single master. Are you running multiple master instances on the same host? -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Tue Mar 27 16:09:22 2012 From: nobody at buildbot.net (Buildbot) Date: Tue, 27 Mar 2012 16:09:22 -0000 Subject: [Buildbot-commits] [Buildbot] #1747: output from different stages mixed after slave disconnects/reconnects In-Reply-To: <041.dc47916f5f59bc1973e6919b8a0771c9@buildbot.net> References: <041.dc47916f5f59bc1973e6919b8a0771c9@buildbot.net> Message-ID: <056.ce0906af33719c857448ddb0b5bb1624@buildbot.net> #1747: output from different stages mixed after slave disconnects/reconnects ----------------------+----------------------- Reporter: philippem | Owner: Type: defect | Status: reopened Priority: major | Milestone: 0.8.+ Version: 0.8.2 | Resolution: Keywords: windows | ----------------------+----------------------- Comment (by philippem): There is one build master on its own host. Each slave builds a different branch from svn. Originally we had deployed four builders on each slave, two (running tests, debug followed by release) using an explicit builder, and two for a buildbot-chosen builder (continous, compile only). The debug and release builds for a given branch are sequential. A few months ago we further separated the "full" and "continuous" builds for the same branch onto separate slaves. So yes, there are multiple builders with the same build-dir, but they are running on different slaves. I have not seen the bug recently, but I am no longer involved with day-to- day maintenance. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Mar 28 04:11:41 2012 From: nobody at buildbot.net (Buildbot) Date: Wed, 28 Mar 2012 04:11:41 -0000 Subject: [Buildbot-commits] [Buildbot] #2257: incomplete URL sanitization for buildstep names In-Reply-To: <039.603ad79b3cf36206f418fa3f92f6af40@buildbot.net> References: <039.603ad79b3cf36206f418fa3f92f6af40@buildbot.net> Message-ID: <054.cd208490384819c7717967a68ec52183@buildbot.net> #2257: incomplete URL sanitization for buildstep names --------------------+-------------------- Reporter: brendan | Owner: Type: defect | Status: new Priority: minor | Milestone: 0.9.0 Version: 0.8.5 | Resolution: Keywords: web | --------------------+-------------------- Changes (by dustin): * keywords: => web * milestone: undecided => 0.9.0 Comment: Slashes in builder names tend to turn out badly, yes. We should quote them both directions, and the new web interface will get this right. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Mar 28 04:12:38 2012 From: nobody at buildbot.net (Buildbot) Date: Wed, 28 Mar 2012 04:12:38 -0000 Subject: [Buildbot-commits] [Buildbot] #2180: Allow for "git describe" in addition to got_revision In-Reply-To: <042.f0bb38d6a7f6d5b4159cc3a8bf6a0f8c@buildbot.net> References: <042.f0bb38d6a7f6d5b4159cc3a8bf6a0f8c@buildbot.net> Message-ID: <057.7acbc7cc441d4ec901e0abaddeadb513@buildbot.net> #2180: Allow for "git describe" in addition to got_revision ------------------------+------------------------- Reporter: jaredgrubb | Owner: jaredgrubb Type: enhancement | Status: assigned Priority: minor | Milestone: 0.8.7 Version: 0.8.5 | Resolution: Keywords: git | ------------------------+------------------------- Changes (by dustin): * keywords: git, buildslave => git * milestone: undecided => 0.8.7 Comment: Note, too, that some big changes to Interpolate are about to land, so you may want to work on top of tomprince's branch until it gets merged: https://github.com/buildbot/buildbot/pull/290 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Mar 28 04:22:06 2012 From: nobody at buildbot.net (Buildbot) Date: Wed, 28 Mar 2012 04:22:06 -0000 Subject: [Buildbot-commits] [Buildbot] #1747: output from different stages mixed after slave disconnects/reconnects In-Reply-To: <041.dc47916f5f59bc1973e6919b8a0771c9@buildbot.net> References: <041.dc47916f5f59bc1973e6919b8a0771c9@buildbot.net> Message-ID: <056.8000bcee1dbad1a6113b5ff1363c889e@buildbot.net> #1747: output from different stages mixed after slave disconnects/reconnects ----------------------+------------------------- Reporter: philippem | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.+ Version: 0.8.2 | Resolution: worksforme Keywords: windows | ----------------------+------------------------- Changes (by dustin): * status: reopened => closed * resolution: => worksforme Comment: OK, I'm going to close this on the assumption it's either a fluke or an instance of #2260. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Mar 28 05:50:22 2012 From: nobody at buildbot.net (Buildbot) Date: Wed, 28 Mar 2012 05:50:22 -0000 Subject: [Buildbot-commits] [Buildbot] #2261: Nightly test tests fail in timezones which differ by odd multiples of 30 minutes from UTC. Message-ID: <035.e397a4a95a3b2b7ca34fa31411bc020c@buildbot.net> #2261: Nightly test tests fail in timezones which differ by odd multiples of 30 minutes from UTC. --------------------+----------------------------- Reporter: sa1 | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.6p1 | Keywords: timezone, tests --------------------+----------------------------- The tests: buildbot.test.unit.test_schedulers_timed_Nightly.Nightly.test_iterations_onlyIfChanged_mixed_changes buildbot.test.unit.test_schedulers_timed_Nightly.Nightly.test_iterations_onlyIfChanged_no_changes buildbot.test.unit.test_schedulers_timed_Nightly.Nightly.test_iterations_onlyIfChanged_off_branch_changes fail in timezones like UTC+0530 which differ by odd multiples of 30 minutes from UTC. Error messages are similar for all 3 tests: e.g http://paste.pocoo.org/show/572382/ -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Mar 28 07:40:04 2012 From: nobody at buildbot.net (Buildbot) Date: Wed, 28 Mar 2012 07:40:04 -0000 Subject: [Buildbot-commits] [Buildbot] #2261: Nightly tests fail in timezones which differ by odd multiples of 30 minutes from UTC. (was: Nightly test tests fail in timezones which differ by odd multiples of 30 minutes from UTC.) In-Reply-To: <035.e397a4a95a3b2b7ca34fa31411bc020c@buildbot.net> References: <035.e397a4a95a3b2b7ca34fa31411bc020c@buildbot.net> Message-ID: <050.2e8539e8763de4e1d554fd0316c9643a@buildbot.net> #2261: Nightly tests fail in timezones which differ by odd multiples of 30 minutes from UTC. ----------------------------+------------------------ Reporter: sa1 | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.6p1 | Resolution: Keywords: timezone, tests | ----------------------------+------------------------ -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Wed Mar 28 14:57:26 2012 From: noreply at github.com (GitHub) Date: Wed, 28 Mar 2012 07:57:26 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 9a2d07: add release notes for 0.8.6p1 Message-ID: <4f7326d632982_cba1657aec178641@sh2.rs.github.com.mail> Branch: refs/heads/buildbot-0.8.6 Home: https://github.com/buildbot/buildbot Commit: 9a2d07b07592787fb68f2f0cee4a1c6258f26314 https://github.com/buildbot/buildbot/commit/9a2d07b07592787fb68f2f0cee4a1c6258f26314 Author: Dustin J. Mitchell Date: 2012-03-25 (Sun, 25 Mar 2012) Changed paths: M master/docs/release-notes.rst Log Message: ----------- add release notes for 0.8.6p1 From noreply at github.com Wed Mar 28 14:57:28 2012 From: noreply at github.com (GitHub) Date: Wed, 28 Mar 2012 07:57:28 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 9a2d07: add release notes for 0.8.6p1 Message-ID: <4f7326d86cee2_6383fac95f512f81009d8@sh1.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 9a2d07b07592787fb68f2f0cee4a1c6258f26314 https://github.com/buildbot/buildbot/commit/9a2d07b07592787fb68f2f0cee4a1c6258f26314 Author: Dustin J. Mitchell Date: 2012-03-25 (Sun, 25 Mar 2012) Changed paths: M master/docs/release-notes.rst Log Message: ----------- add release notes for 0.8.6p1 Commit: 471cdc393d335cde2e7f85701c7ddac04091b5cc https://github.com/buildbot/buildbot/commit/471cdc393d335cde2e7f85701c7ddac04091b5cc Author: Dustin J. Mitchell Date: 2012-03-25 (Sun, 25 Mar 2012) Changed paths: M master/docs/release-notes/0.8.6.rst Log Message: ----------- Merge branch 'buildbot-0.8.6' * buildbot-0.8.6: add release notes for 0.8.6p1 Commit: 6a3cbd9b8024a50507fbc078a98fed0191674b8a https://github.com/buildbot/buildbot/commit/6a3cbd9b8024a50507fbc078a98fed0191674b8a Author: Dustin J. Mitchell Date: 2012-03-28 (Wed, 28 Mar 2012) Changed paths: M master/buildbot/test/unit/test_schedulers_timed_Nightly.py M master/buildbot/util/croniter.py Log Message: ----------- Fix croniter bug #9 Fix from https://github.com/taichino/croniter/issues/9#issuecomment-4751137 Compare: https://github.com/buildbot/buildbot/compare/7482c3e...6a3cbd9 From nobody at buildbot.net Wed Mar 28 14:59:42 2012 From: nobody at buildbot.net (Buildbot) Date: Wed, 28 Mar 2012 14:59:42 -0000 Subject: [Buildbot-commits] [Buildbot] #2261: Nightly tests fail in timezones which differ by odd multiples of 30 minutes from UTC. In-Reply-To: <035.e397a4a95a3b2b7ca34fa31411bc020c@buildbot.net> References: <035.e397a4a95a3b2b7ca34fa31411bc020c@buildbot.net> Message-ID: <050.837ba6ac31d914cbb34bd85f16d282e4@buildbot.net> #2261: Nightly tests fail in timezones which differ by odd multiples of 30 minutes from UTC. ----------------------------+------------------------ Reporter: sa1 | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.6p1 | Resolution: Keywords: timezone, tests | ----------------------------+------------------------ Comment (by dustin): test failure, here rather than pastebin: {{{ buildbot.test.unit.test_schedulers_timed_Nightly Nightly test_iterations_onlyIfChanged_off_branch_changes ... [FAIL] =============================================================================== [FAIL] Traceback (most recent call last): File "/home/sa1/src/buildbot- work/buildbot/master/buildbot/test/unit/test_schedulers_timed_Nightly.py", line 339, in test_iterations_onlyIfChanged_off_branch_changes self.db.state.assertStateByClass('test', 'Nightly', last_build=1500) File "/home/sa1/src/buildbot- work/buildbot/master/buildbot/test/fake/fakedb.py", line 852, in assertStateByClass "state is %r" % (state,)) File "/usr/lib/python2.7/site-packages/twisted/trial/unittest.py", line 270, in assertEqual % (msg, pformat(first), pformat(second))) twisted.trial.unittest.FailTest: state is {'last_build': '900.0'} not equal: a = 900.0 b = 1500 buildbot.test.unit.test_schedulers_timed_Nightly.Nightly.test_iterations_onlyIfChanged_off_branch_changes ------------------------------------------------------------------------------- Ran 1 tests in 0.004s FAILED (failures=1) }}} -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Mar 28 16:26:14 2012 From: nobody at buildbot.net (Buildbot) Date: Wed, 28 Mar 2012 16:26:14 -0000 Subject: [Buildbot-commits] [Buildbot] #2261: Nightly tests fail in timezones which differ by odd multiples of 30 minutes from UTC. In-Reply-To: <035.e397a4a95a3b2b7ca34fa31411bc020c@buildbot.net> References: <035.e397a4a95a3b2b7ca34fa31411bc020c@buildbot.net> Message-ID: <050.ffbabc8dd9260bc12366b757e27f62f7@buildbot.net> #2261: Nightly tests fail in timezones which differ by odd multiples of 30 minutes from UTC. --------------------------+-------------------- Reporter: sa1 | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.7 Version: 0.8.6p1 | Resolution: Keywords: tests, simple | --------------------------+-------------------- Changes (by dustin): * keywords: timezone, tests => tests, simple * milestone: undecided => 0.8.7 Comment: The problem here is purely in the tests, so the solution will be exclusively in `test_schedulers_timed_Nightly.py`. The current code assumes that epoch time 0 is zero minutes past the hour (it doesn't matter which hour). So it assumes that 1500 seconds is 25 minutes past the hour, when in fact it's 55 minutes past the hour. The '900' is from minute 45. The 25 and 45 are from `minute` in {{{ #! python def do_test_iterations_onlyIfChanged(self, *changes_at): fII = mock.Mock(name='fII') sched = self.makeScheduler(name='test', builderNames=[ 'test' ], branch=None, minute=[5, 25, 45], onlyIfChanged=True, fileIsImportant=fII) }}} I suspect that the correct solution is to calculate an offset, in seconds, to 0 minutes past the hour in local time. Then advance the clock by that offset before starting, and adjust the asserted times by the same offset. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Mar 28 17:48:11 2012 From: nobody at buildbot.net (Buildbot) Date: Wed, 28 Mar 2012 17:48:11 -0000 Subject: [Buildbot-commits] [Buildbot] #2262: filter what parts of trac get indexed Message-ID: <038.e0b1aad886ec853be686a74f8fe6839a@buildbot.net> #2262: filter what parts of trac get indexed -------------------+--------------------- Reporter: dustin | Owner: Type: task | Status: new Priority: major | Milestone: ongoing Version: | Keywords: admin -------------------+--------------------- For example, timeline is useless. A sitemap may help here, but at least a `robots.txt` at http://trac.buildbot.net/robots.txt -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Mar 28 17:52:17 2012 From: nobody at buildbot.net (Buildbot) Date: Wed, 28 Mar 2012 17:52:17 -0000 Subject: [Buildbot-commits] [Buildbot] #2066: Fix new source steps' URL handling In-Reply-To: <038.4b2beb27a185303ae6bd92ef91a5b2d9@buildbot.net> References: <038.4b2beb27a185303ae6bd92ef91a5b2d9@buildbot.net> Message-ID: <053.d957a44824f8b0d986d9a3035ff2eb70@buildbot.net> #2066: Fix new source steps' URL handling ------------------------+-------------------- Reporter: in3xes | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.7 Version: 0.8.4p2 | Resolution: Keywords: simple | ------------------------+-------------------- Comment (by dustin): Copying the relevant parts from those comments: ---- baseURL vs svnurl These names are confusing, and as I understand it, are just a vestige of backward compatibility. Since this step requires that users choose it explicitly, we have a chance to do it right. What do these two parameters accomplish, and how could we do that with one parameter, with lots of flexibility for the user? What about the common case when the repository in the SourceStamp is sufficient - do we need to make the user specify a URL to the SVN step in that case, too? You don't need to implement the full flexibility yet, but think ahead when deciding how to handle these URLs. (me) ... This comment also applies to repoURL/baseURL of the Mercurial step. It would be good if all the new source steps could have consistent paramater naming among them selves, rather than with the old steps, which were not consistent. Tom ---- Note that we've renamed svnurl to repourl (http://buildbot.net/buildbot/docs/0.8.6/release-notes.html), but that wasn't the whole deal. We've lost the advantage that I mentioned above - these steps are now in 0.8.5 and 0.8.6 production deployments using baseURL or repourl. Still, I'd be happy to see this simplified, even at the cost of some (well- documented, easily-mitigated) backward incompatibility. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Mar 28 18:19:56 2012 From: nobody at buildbot.net (Buildbot) Date: Wed, 28 Mar 2012 18:19:56 -0000 Subject: [Buildbot-commits] [Buildbot] #2131: Can't tell if rebuild button has been pressed In-Reply-To: <036.7122e229416b1bd757741a8e182a6d10@buildbot.net> References: <036.7122e229416b1bd757741a8e182a6d10@buildbot.net> Message-ID: <051.e5844e73c3fbaa31c2908131a9fc27f2@buildbot.net> #2131: Can't tell if rebuild button has been pressed ------------------------+-------------------- Reporter: dank | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.9.+ Version: 0.8.5 | Resolution: Keywords: web | ------------------------+-------------------- Comment (by wakeupsid): JavaScript UI can solve this problem. We can display Status of the build after clicking rebuild button. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Thu Mar 29 03:37:29 2012 From: noreply at github.com (GitHub) Date: Wed, 28 Mar 2012 20:37:29 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 9a4e42: Don't call _ref_key from put() -- matches previous... Message-ID: <4f73d8f94ee37_5092113cae4610eb@sh2.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 9a4e42fd06917bfdbbd8e0eeffa086cd22a8e06c https://github.com/buildbot/buildbot/commit/9a4e42fd06917bfdbbd8e0eeffa086cd22a8e06c Author: Stefan Zager Date: 2012-03-28 (Wed, 28 Mar 2012) Changed paths: M master/buildbot/status/builder.py M master/buildbot/util/lru.py Log Message: ----------- Don't call _ref_key from put() -- matches previous behavior. In builder.py, use miss_fn_kwargs to pass a new value through to the buildCache. Commit: 72a3afcfabb691f6458deebfec3b049d1cd33278 https://github.com/buildbot/buildbot/commit/72a3afcfabb691f6458deebfec3b049d1cd33278 Author: Dustin J. Mitchell Date: 2012-03-28 (Wed, 28 Mar 2012) Changed paths: M master/buildbot/process/builder.py M master/buildbot/status/builder.py A master/buildbot/test/unit/test_status_builder_cache.py M master/buildbot/test/unit/test_util_lru.py M master/buildbot/util/lru.py M master/docs/developer/utils.rst Log Message: ----------- Merge branch 'sync-lru2' of git://github.com/szager/buildbot into synclru * 'sync-lru2' of git://github.com/szager/buildbot: Don't call _ref_key from put() -- matches previous behavior. No tab characters in docs. Moved pydoc stuff into the manual, added comments for non-public methods. Add a syncronous LRU cache implementation, and use it for the build cache in buildbot.status.builder.BuilderStatus. Commit: dd60a5906fccbe57f17c3c1245e580c3eac0731e https://github.com/buildbot/buildbot/commit/dd60a5906fccbe57f17c3c1245e580c3eac0731e Author: Dustin J. Mitchell Date: 2012-03-28 (Wed, 28 Mar 2012) Changed paths: M master/buildbot/test/unit/test_util_lru.py Log Message: ----------- add test from comments on pull request 367 Commit: 1d82ec9c45d5481d71f025498a437cb7af061842 https://github.com/buildbot/buildbot/commit/1d82ec9c45d5481d71f025498a437cb7af061842 Author: Dustin J. Mitchell Date: 2012-03-28 (Wed, 28 Mar 2012) Changed paths: M master/buildbot/status/builder.py M master/buildbot/test/unit/test_status_builder_cache.py Log Message: ----------- fix pyflakes Commit: 93c1437647890c432fba931307b1c29792055f7a https://github.com/buildbot/buildbot/commit/93c1437647890c432fba931307b1c29792055f7a Author: Dustin J. Mitchell Date: 2012-03-28 (Wed, 28 Mar 2012) Changed paths: M master/buildbot/status/builder.py M master/buildbot/test/unit/test_status_builder_cache.py M master/buildbot/test/unit/test_util_lru.py Log Message: ----------- Merge branch 'synclru' * synclru: fix pyflakes add test from comments on pull request 367 Compare: https://github.com/buildbot/buildbot/compare/6a3cbd9...93c1437 From nobody at buildbot.net Thu Mar 29 09:15:02 2012 From: nobody at buildbot.net (Buildbot) Date: Thu, 29 Mar 2012 09:15:02 -0000 Subject: [Buildbot-commits] [Buildbot] #2256: sqlite is fantastically slow on Lion In-Reply-To: <038.3f00cf89cae24019b257c735c20aed1a@buildbot.net> References: <038.3f00cf89cae24019b257c735c20aed1a@buildbot.net> Message-ID: <053.a09665e4a13cdcbf430966c70ee07332@buildbot.net> #2256: sqlite is fantastically slow on Lion ------------------------+-------------------- Reporter: dustin | Owner: Type: defect | Status: new Priority: minor | Milestone: 0.8.7 Version: 0.8.6 | Resolution: Keywords: performance | ------------------------+-------------------- Comment (by bdash): This is because OS X's version of SQLite has checkpoint_fullfsync enabled by default. This causes SQLite to use the incredibly heavyweight fcntl F_FULLFSYNC that blocks until all buffered data is flushed to the disk platters. This is in contrast to on other platforms where SQLite simply uses fsync, which blocks until buffered data has been flushed from host memory to the disk controller. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Thu Mar 29 09:43:43 2012 From: nobody at buildbot.net (Buildbot) Date: Thu, 29 Mar 2012 09:43:43 -0000 Subject: [Buildbot-commits] [Buildbot] #2256: sqlite is fantastically slow on Lion In-Reply-To: <038.3f00cf89cae24019b257c735c20aed1a@buildbot.net> References: <038.3f00cf89cae24019b257c735c20aed1a@buildbot.net> Message-ID: <053.2ae53c9e774de9cede7c915f3790c3c5@buildbot.net> #2256: sqlite is fantastically slow on Lion ------------------------+-------------------- Reporter: dustin | Owner: Type: defect | Status: new Priority: minor | Milestone: 0.8.7 Version: 0.8.6 | Resolution: Keywords: performance | ------------------------+-------------------- Comment (by bdash): https://github.com/buildbot/buildbot/pull/368 should address this. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Thu Mar 29 14:39:35 2012 From: noreply at github.com (GitHub) Date: Thu, 29 Mar 2012 07:39:35 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 82430c: Disable checkpoint_fullfsync on all SQLite connect... Message-ID: <4f7474273926f_5b0f1c55ae81507de@sh2.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 82430ca61f94bb7b9b516305bee870b693783136 https://github.com/buildbot/buildbot/commit/82430ca61f94bb7b9b516305bee870b693783136 Author: Mark Rowe Date: 2012-03-29 (Thu, 29 Mar 2012) Changed paths: M master/buildbot/db/enginestrategy.py Log Message: ----------- Disable checkpoint_fullfsync on all SQLite connections. The checkpoint_fullfsync pragma is enabled by default on the version of SQLite that ships with OS X Lion and newer. This setting enables use of the F_FULLSYNC fcntl rather than fsync when transactions are moved from the WAL back in to the database proper. The fcntl waits until the disk drive reports that all buffered data has been written to permanent storage, in constrast to fsync which merely waits until the data has reached the disk controller. F_FULLSYNC is more robust in the face of catastrophic system failure but incurs a substantial performance hit for being so. This change reduces the time it takes to run the buildbot.test.integration.test_upgrade suite of tests on one machine from over 27 seconds to under 7 seconds. Fixes #2256. Commit: d0616da10e7c7c8d821a646852c9ec1b95656386 https://github.com/buildbot/buildbot/commit/d0616da10e7c7c8d821a646852c9ec1b95656386 Author: Dustin J. Mitchell Date: 2012-03-29 (Thu, 29 Mar 2012) Changed paths: M master/buildbot/db/enginestrategy.py Log Message: ----------- Merge branch 'bug-2256-sqlite-checkpoint-fullfsync' of git://github.com/bdash/buildbot * 'bug-2256-sqlite-checkpoint-fullfsync' of git://github.com/bdash/buildbot: Disable checkpoint_fullfsync on all SQLite connections. Compare: https://github.com/buildbot/buildbot/compare/93c1437...d0616da From nobody at buildbot.net Thu Mar 29 14:39:42 2012 From: nobody at buildbot.net (Buildbot) Date: Thu, 29 Mar 2012 14:39:42 -0000 Subject: [Buildbot-commits] [Buildbot] #2256: sqlite is fantastically slow on Lion In-Reply-To: <038.3f00cf89cae24019b257c735c20aed1a@buildbot.net> References: <038.3f00cf89cae24019b257c735c20aed1a@buildbot.net> Message-ID: <053.6ed5dd623f8346de27d86bb61bf16cd9@buildbot.net> #2256: sqlite is fantastically slow on Lion ------------------------+--------------------- Reporter: dustin | Owner: Type: defect | Status: closed Priority: minor | Milestone: 0.8.7 Version: 0.8.6 | Resolution: fixed Keywords: performance | ------------------------+--------------------- Changes (by Mark Rowe): * status: new => closed * resolution: => fixed Comment: Disable checkpoint_fullfsync on all SQLite connections. The checkpoint_fullfsync pragma is enabled by default on the version of SQLite that ships with OS X Lion and newer. This setting enables use of the F_FULLSYNC fcntl rather than fsync when transactions are moved from the WAL back in to the database proper. The fcntl waits until the disk drive reports that all buffered data has been written to permanent storage, in constrast to fsync which merely waits until the data has reached the disk controller. F_FULLSYNC is more robust in the face of catastrophic system failure but incurs a substantial performance hit for being so. This change reduces the time it takes to run the buildbot.test.integration.test_upgrade suite of tests on one machine from over 27 seconds to under 7 seconds. Fixes #2256. Changeset: 82430ca61f94bb7b9b516305bee870b693783136 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Thu Mar 29 15:17:19 2012 From: nobody at buildbot.net (Buildbot) Date: Thu, 29 Mar 2012 15:17:19 -0000 Subject: [Buildbot-commits] [Buildbot] #2066: Fix new source steps' URL handling In-Reply-To: <038.4b2beb27a185303ae6bd92ef91a5b2d9@buildbot.net> References: <038.4b2beb27a185303ae6bd92ef91a5b2d9@buildbot.net> Message-ID: <053.bde37ebae2d0b6269aa42ef2e44a95d9@buildbot.net> #2066: Fix new source steps' URL handling ------------------------+-------------------- Reporter: in3xes | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.7 Version: 0.8.4p2 | Resolution: Keywords: simple | ------------------------+-------------------- Comment (by sa1): There is no simple way to handle subversion urls by just the baseURL, as there are no guarantees of patterns in how branches are stored in the svn file system. For projects with no convention, repourl is the only way that is acceptable. e.g branches/dev/branch and branches/for-upstream may be the locations of two "branches". "branch" here simply means a folder that is buildable. For projects that do have a convention as to how branches are stored, the documentation states that the baseURL and branch are simply concatenated together to derive the repoURL to use for the checkout. This is inadequate. But the code contains a simpler way of specifying a convention for the branches by adding a branch_placeholder. If %%BRANCH%% is specified in the baseURL, it is replaced by branch in the generated repourl. This addresses a lot of simple branch conventions and is in my opinion the simplest way of adding flexibility for the user. This pattern of baseURL is also perhaps not compatible with the url in the source stamp. But I believe that this is the best way to handle the situation. The configuration for specifying how branches are stored can be be made more complex for complicated setups if we want to have the required flexibility. To have an all-encompassing configuration does not seem to be possible. There is a sample BDF(branch description format) specified here http://article.gmane.org/gmane.comp.version-control.git/192801 which can be used to specify the location of branches but the scope of the description is too expansive for our purpose and only serves to indicate the complexity in such a task. Other simple url patterns can be added later if they are in widespread use by some project. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Thu Mar 29 19:01:12 2012 From: nobody at buildbot.net (Buildbot) Date: Thu, 29 Mar 2012 19:01:12 -0000 Subject: [Buildbot-commits] [Buildbot] #2256: sqlite is fantastically slow on Lion In-Reply-To: <038.3f00cf89cae24019b257c735c20aed1a@buildbot.net> References: <038.3f00cf89cae24019b257c735c20aed1a@buildbot.net> Message-ID: <053.72a744ad675e3fc281c81023bba6bf8e@buildbot.net> #2256: sqlite is fantastically slow on Lion ------------------------+--------------------- Reporter: dustin | Owner: Type: defect | Status: closed Priority: minor | Milestone: 0.8.7 Version: 0.8.6 | Resolution: fixed Keywords: performance | ------------------------+--------------------- Comment (by bdash): https://github.com/buildbot/buildbot/pull/369 should fix the test failures that 82430c introduced with older versions of SQLAlchemy. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Thu Mar 29 19:22:52 2012 From: noreply at github.com (GitHub) Date: Thu, 29 Mar 2012 12:22:52 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] cabcf0: Fix tests after 82430c when using older versions S... Message-ID: <4f74b68cd7c6f_10353fa593a4b2f8732f6@sh1.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: cabcf07b827c9b11ed056953ca462f5de2dc4fb7 https://github.com/buildbot/buildbot/commit/cabcf07b827c9b11ed056953ca462f5de2dc4fb7 Author: Mark Rowe Date: 2012-03-29 (Thu, 29 Mar 2012) Changed paths: M master/buildbot/db/enginestrategy.py Log Message: ----------- Fix tests after 82430c when using older versions SQLAlchemy. Use an object that implements the PoolListener interface to listen for the connect event when using SQLAlchemy prior to 0.7. This also moves the registration of the event listener ahead of the changing of the journal mode to ensure that the database connection that SQLAlchemy spins up when executing the journal mode pragma also triggers the event listener, and doesn't miss out on having checkpoint_fullfsync disabled. Commit: e1cc7ed819a366dbed52dffcf92d73265b08481b https://github.com/buildbot/buildbot/commit/e1cc7ed819a366dbed52dffcf92d73265b08481b Author: Dustin J. Mitchell Date: 2012-03-29 (Thu, 29 Mar 2012) Changed paths: M master/buildbot/db/enginestrategy.py Log Message: ----------- Merge branch 'fix-bug-2256-fallout' of git://github.com/bdash/buildbot * 'fix-bug-2256-fallout' of git://github.com/bdash/buildbot: Fix tests after 82430c when using older versions SQLAlchemy. Compare: https://github.com/buildbot/buildbot/compare/d0616da...e1cc7ed From nobody at buildbot.net Fri Mar 30 13:34:47 2012 From: nobody at buildbot.net (Buildbot) Date: Fri, 30 Mar 2012 13:34:47 -0000 Subject: [Buildbot-commits] [Buildbot] #2263: Traceback during sending mail in 0.8.6p1 Message-ID: <041.e10c90bb395ec75db8e05b2a4381ca82@buildbot.net> #2263: Traceback during sending mail in 0.8.6p1 ----------------------+----------------------- Reporter: dottedmag | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.6p1 | Keywords: mail ----------------------+----------------------- Configuration: {{{ MailNotifier(fromaddr='autobuild at company.com', sendToInterestedUsers=False, extraRecipients=['mailing-list at company.com'], subject='Build status changed on %(builder)s', mode='change', buildSetSummary=True, relayhost='relay.host.company.com'), }}} Traceback: {{{ 2012-03-30_13:16:18.61062 Traceback (most recent call last): 2012-03-30_13:16:18.61063 File "/usr/lib/python2.7/dist- packages/twisted/internet/defer.py", line 545, in _runCallbacks 2012-03-30_13:16:18.61063 current.result = callback(current.result, *args, **kw) 2012-03-30_13:16:18.61064 File "/usr/lib/python2.7/dist- packages/twisted/internet/defer.py", line 796, in _cbDeferred 2012-03-30_13:16:18.61065 self.callback(self.resultList) 2012-03-30_13:16:18.61065 File "/usr/lib/python2.7/dist- packages/twisted/internet/defer.py", line 362, in callback 2012-03-30_13:16:18.61066 self._startRunCallbacks(result) 2012-03-30_13:16:18.61066 File "/usr/lib/python2.7/dist- packages/twisted/internet/defer.py", line 458, in _startRunCallbacks 2012-03-30_13:16:18.61067 self._runCallbacks() 2012-03-30_13:16:18.61067 --- --- 2012-03-30_13:16:18.61068 File "/usr/lib/python2.7/dist- packages/twisted/internet/defer.py", line 545, in _runCallbacks 2012-03-30_13:16:18.61068 current.result = callback(current.result, *args, **kw) 2012-03-30_13:16:18.61069 File "/usr/lib/python2.7/dist- packages/buildbot/status/mail.py", line 448, in _gotBuilds 2012-03-30_13:16:18.61070 buildset['results']) 2012-03-30_13:16:18.61070 File "/usr/lib/python2.7/dist- packages/buildbot/status/mail.py", line 644, in buildMessage 2012-03-30_13:16:18.61072 results, builds, patches, logs) 2012-03-30_13:16:18.61073 File "/usr/lib/python2.7/dist- packages/buildbot/status/mail.py", line 543, in createEmail 2012-03-30_13:16:18.61074 type = msgdict['type'] 2012-03-30_13:16:18.61075 exceptions.KeyError: 'type' }}} -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Mar 30 14:58:31 2012 From: nobody at buildbot.net (Buildbot) Date: Fri, 30 Mar 2012 14:58:31 -0000 Subject: [Buildbot-commits] [Buildbot] #2066: Fix new source steps' URL handling In-Reply-To: <038.4b2beb27a185303ae6bd92ef91a5b2d9@buildbot.net> References: <038.4b2beb27a185303ae6bd92ef91a5b2d9@buildbot.net> Message-ID: <053.968b431d8377bf597d7d95f6466a049b@buildbot.net> #2066: Fix new source steps' URL handling ------------------------+-------------------- Reporter: in3xes | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.7 Version: 0.8.4p2 | Resolution: Keywords: simple | ------------------------+-------------------- Comment (by tom.prince): I wonder what if any behavior people expect when having a branch, when using `repourl`? It seems to me like it wouldn't be unreasonable to have the appending behavior apply to `repourl`, and have an option to specify the use of `%%BRANCH%%` as a placeholder in repourl. I don't actually use svn, so I don't know how well this would work. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Mar 30 15:12:49 2012 From: nobody at buildbot.net (Buildbot) Date: Fri, 30 Mar 2012 15:12:49 -0000 Subject: [Buildbot-commits] [Buildbot] #2066: Fix new source steps' URL handling In-Reply-To: <038.4b2beb27a185303ae6bd92ef91a5b2d9@buildbot.net> References: <038.4b2beb27a185303ae6bd92ef91a5b2d9@buildbot.net> Message-ID: <053.d918ba92a3fa803b6f4540c51201b2c4@buildbot.net> #2066: Fix new source steps' URL handling ------------------------+-------------------- Reporter: in3xes | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.7 Version: 0.8.4p2 | Resolution: Keywords: simple | ------------------------+-------------------- Comment (by sa1): Yes, that should work. If there's no branch specified the extreme corner case(if its possible)that there's a folder named %%BRANCH%% is covered. :) If there's a branch specified and there's no placeholder in the repourl we can generate an error. I don't think people expect any behavior at the moment because the code would ignore the branch information completely. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Fri Mar 30 15:16:56 2012 From: noreply at github.com (GitHub) Date: Fri, 30 Mar 2012 08:16:56 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 71cde7: Don't try to send email, if there are no interesti... Message-ID: <4f75ce68dd70d_22f81415af41402d9@sh2.rs.github.com.mail> Branch: refs/heads/buildbot-0.8.6 Home: https://github.com/buildbot/buildbot Commit: 71cde798e611d8690f8e0a1c59e42da7f91bffdc https://github.com/buildbot/buildbot/commit/71cde798e611d8690f8e0a1c59e42da7f91bffdc Author: Tom Prince Date: 2012-03-30 (Fri, 30 Mar 2012) Changed paths: M master/buildbot/status/mail.py M master/buildbot/test/unit/test_status_mail.py Log Message: ----------- Don't try to send email, if there are no interesting builds. Fixes #2236. Commit: 5e9e96e89109917973a9d0daadba1cdf5aa84a7c https://github.com/buildbot/buildbot/commit/5e9e96e89109917973a9d0daadba1cdf5aa84a7c Author: Tom Prince Date: 2012-03-30 (Fri, 30 Mar 2012) Changed paths: M master/buildbot/status/mail.py M master/buildbot/test/unit/test_status_mail.py Log Message: ----------- Merge branch 'mailnotifier' into buildbot-0.8.6 Compare: https://github.com/buildbot/buildbot/compare/9a2d07b...5e9e96e From nobody at buildbot.net Fri Mar 30 15:17:12 2012 From: nobody at buildbot.net (Buildbot) Date: Fri, 30 Mar 2012 15:17:12 -0000 Subject: [Buildbot-commits] [Buildbot] #2236: Experiment with loading config in a "rollback importer" In-Reply-To: <038.5fd44b61ce46772e2877b318a8727941@buildbot.net> References: <038.5fd44b61ce46772e2877b318a8727941@buildbot.net> Message-ID: <053.fde16391d805dfcd76b16eec19a62308@buildbot.net> #2236: Experiment with loading config in a "rollback importer" ------------------------+--------------------- Reporter: dustin | Owner: Type: enhancement | Status: closed Priority: major | Milestone: 0.8.+ Version: 0.8.5 | Resolution: fixed Keywords: reconfig | ------------------------+--------------------- Changes (by Tom Prince): * status: new => closed * resolution: => fixed Comment: Don't try to send email, if there are no interesting builds. Fixes #2236. Changeset: 71cde798e611d8690f8e0a1c59e42da7f91bffdc -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Fri Mar 30 15:17:28 2012 From: noreply at github.com (GitHub) Date: Fri, 30 Mar 2012 08:17:28 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 71cde7: Don't try to send email, if there are no interesti... Message-ID: <4f75ce885bcdf_4b3a12afae8619db@sh2.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 71cde798e611d8690f8e0a1c59e42da7f91bffdc https://github.com/buildbot/buildbot/commit/71cde798e611d8690f8e0a1c59e42da7f91bffdc Author: Tom Prince Date: 2012-03-30 (Fri, 30 Mar 2012) Changed paths: M master/buildbot/status/mail.py M master/buildbot/test/unit/test_status_mail.py Log Message: ----------- Don't try to send email, if there are no interesting builds. Fixes #2236. Commit: 5e9e96e89109917973a9d0daadba1cdf5aa84a7c https://github.com/buildbot/buildbot/commit/5e9e96e89109917973a9d0daadba1cdf5aa84a7c Author: Tom Prince Date: 2012-03-30 (Fri, 30 Mar 2012) Changed paths: M master/buildbot/status/mail.py M master/buildbot/test/unit/test_status_mail.py Log Message: ----------- Merge branch 'mailnotifier' into buildbot-0.8.6 Commit: 73045be674fad8ff56192cc63d0071a2036f8c9c https://github.com/buildbot/buildbot/commit/73045be674fad8ff56192cc63d0071a2036f8c9c Author: Tom Prince Date: 2012-03-30 (Fri, 30 Mar 2012) Changed paths: M master/buildbot/status/mail.py M master/buildbot/test/unit/test_status_mail.py Log Message: ----------- Merge branch 'buildbot-0.8.6' Compare: https://github.com/buildbot/buildbot/compare/e1cc7ed...73045be From nobody at buildbot.net Fri Mar 30 15:17:45 2012 From: nobody at buildbot.net (Buildbot) Date: Fri, 30 Mar 2012 15:17:45 -0000 Subject: [Buildbot-commits] [Buildbot] #2236: Experiment with loading config in a "rollback importer" In-Reply-To: <038.5fd44b61ce46772e2877b318a8727941@buildbot.net> References: <038.5fd44b61ce46772e2877b318a8727941@buildbot.net> Message-ID: <053.9a5e7b20c433f7537b6e6bfa207a0c56@buildbot.net> #2236: Experiment with loading config in a "rollback importer" ------------------------+--------------------- Reporter: dustin | Owner: Type: enhancement | Status: closed Priority: major | Milestone: 0.8.+ Version: 0.8.5 | Resolution: fixed Keywords: reconfig | ------------------------+--------------------- Comment (by Tom Prince): Don't try to send email, if there are no interesting builds. Fixes #2236. Changeset: 71cde798e611d8690f8e0a1c59e42da7f91bffdc -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Fri Mar 30 15:32:50 2012 From: noreply at github.com (GitHub) Date: Fri, 30 Mar 2012 08:32:50 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 025089: Fix TestMailNotifier.test_buildsetFinished_doesnt_... Message-ID: <4f75d2221f4d1_5d481bfaae42236c@sh2.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 0250898272dffa9c1d5778cfdece4196c1db6313 https://github.com/buildbot/buildbot/commit/0250898272dffa9c1d5778cfdece4196c1db6313 Author: Tom Prince Date: 2012-03-30 (Fri, 30 Mar 2012) Changed paths: M master/buildbot/test/unit/test_status_mail.py Log Message: ----------- Fix TestMailNotifier.test_buildsetFinished_doesnt_send_email for changes in trunk. MailNotifier was fixed to use self.master.db rather than self.parent.db. Fix the new test to respect that. From nobody at buildbot.net Fri Mar 30 20:18:02 2012 From: nobody at buildbot.net (Buildbot) Date: Fri, 30 Mar 2012 20:18:02 -0000 Subject: [Buildbot-commits] [Buildbot] #2264: Document Interpolate and IRenderable. Message-ID: <042.56d50725f9103c1c685d68ea3f0a6fb5@buildbot.net> #2264: Document Interpolate and IRenderable. ------------------------+------------------------ Reporter: tom.prince | Owner: tom.prince Type: enhancement | Status: new Priority: critical | Milestone: 0.8.7 Version: master | Keywords: docs ------------------------+------------------------ `Interpolate`, as the new preferred way of accessing properties needs to be documented before we release 0.8.7. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Mar 30 20:25:12 2012 From: nobody at buildbot.net (Buildbot) Date: Fri, 30 Mar 2012 20:25:12 -0000 Subject: [Buildbot-commits] [Buildbot] #2265: Ensure that all properties can be converted to json. Message-ID: <042.ec39ec882f9837162fd9e2de587a7f82@buildbot.net> #2265: Ensure that all properties can be converted to json. -----------------------+------------------- Reporter: tom.prince | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.7 Version: 0.8.6p1 | Keywords: -----------------------+------------------- We have never supported anything else, but we don't verify that this is the case. Currently things probably won't break, if the properties are set during the build, since the objects get stored in a pickle. Once the build status moves to the database, more things will start to break. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Fri Mar 30 20:26:02 2012 From: noreply at github.com (GitHub) Date: Fri, 30 Mar 2012 13:26:02 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] b4b7b3: Get rid of debugging code. Message-ID: <4f7616da955d6_2a8b16d9aec31085@sh2.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: b4b7b312192b248fc50e451f9f09daee0a119a6a https://github.com/buildbot/buildbot/commit/b4b7b312192b248fc50e451f9f09daee0a119a6a Author: Tom Prince Date: 2012-03-30 (Fri, 30 Mar 2012) Changed paths: M master/buildbot/process/properties.py Log Message: ----------- Get rid of debugging code. Commit: 30ada95b51088cce45de132790a520e0abc0547e https://github.com/buildbot/buildbot/commit/30ada95b51088cce45de132790a520e0abc0547e Author: Tom Prince Date: 2012-03-30 (Fri, 30 Mar 2012) Changed paths: M master/buildbot/process/properties.py M master/buildbot/test/unit/test_process_properties.py Log Message: ----------- Fix handling of positional aruguments, and add tests for it. Now we only try to parse lookup keys, if we aren't doing positional substitution. Before, we were unconditionally parsing, which failed in the case of positional arguments. Commit: 1155ab9aa91fe875cc361abf3de881eb095d5ea6 https://github.com/buildbot/buildbot/commit/1155ab9aa91fe875cc361abf3de881eb095d5ea6 Author: Tom Prince Date: 2012-03-30 (Fri, 30 Mar 2012) Changed paths: M master/buildbot/test/unit/test_process_properties.py Log Message: ----------- Move tests of deferred renderables to kw tests. Properties should be jsonable, so there shouldn't be renderablw instances there. We don't test to ensure this, but we should be using them in tests. Commit: 77883a23b7759afe1cf2cc60a1472ea9a0773b6c https://github.com/buildbot/buildbot/commit/77883a23b7759afe1cf2cc60a1472ea9a0773b6c Author: Tom Prince Date: 2012-03-30 (Fri, 30 Mar 2012) Changed paths: M master/buildbot/status/tinderbox.py Log Message: ----------- Use inlineCallbacks in status/tinderbox. This code was written before we dropped support for python 2.4. Clean it up before merging. Commit: 6aa10e11b3492feebb19a323f026d28aab0657a8 https://github.com/buildbot/buildbot/commit/6aa10e11b3492feebb19a323f026d28aab0657a8 Author: Tom Prince Date: 2012-03-30 (Fri, 30 Mar 2012) Changed paths: M master/buildbot/interfaces.py M master/docs/release-notes.rst Log Message: ----------- Document the fact that IRenderable.getRenderingFor can now return deferreds. This should really be documented in the manual, but IRenderable isn't yet documented there. Commit: 7aaf8eb2767ae03714df5af416d4173f8ac1d48b https://github.com/buildbot/buildbot/commit/7aaf8eb2767ae03714df5af416d4173f8ac1d48b Author: Tom Prince Date: 2012-03-30 (Fri, 30 Mar 2012) Changed paths: M master/buildbot/interfaces.py M master/buildbot/process/buildstep.py M master/buildbot/process/properties.py M master/buildbot/status/mail.py M master/buildbot/status/tinderbox.py M master/buildbot/steps/source/oldsource.py M master/buildbot/test/unit/test_config.py M master/buildbot/test/unit/test_process_buildstep.py M master/buildbot/test/unit/test_process_properties.py M master/buildbot/test/unit/test_status_mail.py M master/buildbot/test/unit/test_steps_source_base_Source.py M master/buildbot/test/unit/test_steps_source_oldsource_ComputeRepositoryURL.py A master/buildbot/test/util/config.py M master/docs/release-notes.rst Log Message: ----------- Merge pull request #290 from tomprince/prop-defer Allow renderables to return deferreds Compare: https://github.com/buildbot/buildbot/compare/0250898...7aaf8eb From noreply at github.com Fri Mar 30 20:45:41 2012 From: noreply at github.com (GitHub) Date: Fri, 30 Mar 2012 13:45:41 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] e35caa: Fix pyflakes errors. Message-ID: <4f761b75af1f4_232eeb8ae8122547@sh2.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: e35caa38edb2a79e22718a1f2c43e9c3fe57c080 https://github.com/buildbot/buildbot/commit/e35caa38edb2a79e22718a1f2c43e9c3fe57c080 Author: Tom Prince Date: 2012-03-30 (Fri, 30 Mar 2012) Changed paths: M master/buildbot/process/properties.py M master/buildbot/status/tinderbox.py M master/buildbot/test/unit/test_process_properties.py Log Message: ----------- Fix pyflakes errors. From noreply at github.com Sat Mar 31 03:46:57 2012 From: noreply at github.com (GitHub) Date: Fri, 30 Mar 2012 20:46:57 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 57721a: Add some tests for the renderable adapters. Message-ID: <4f767e3151967_403a3f84ca95a2fc26537a@sh1.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 57721a3d32dea2b2a6a476c41064706e9fc107e0 https://github.com/buildbot/buildbot/commit/57721a3d32dea2b2a6a476c41064706e9fc107e0 Author: Tom Prince Date: 2012-03-30 (Fri, 30 Mar 2012) Changed paths: M master/buildbot/test/unit/test_process_properties.py Log Message: ----------- Add some tests for the renderable adapters. Commit: 9d7706e619227d45174ffb1064bc9e77f2b64211 https://github.com/buildbot/buildbot/commit/9d7706e619227d45174ffb1064bc9e77f2b64211 Author: Tom Prince Date: 2012-03-30 (Fri, 30 Mar 2012) Changed paths: M master/buildbot/test/unit/test_process_properties.py Log Message: ----------- Change direct tests of PropertyMap to use WithProperties instead. PropertyMap is an implementation detail of WithProperties, so test the user interface directly, instead of the implementation detail. Commit: c271360c0e9919edbef78238fc01b4c58c8888f5 https://github.com/buildbot/buildbot/commit/c271360c0e9919edbef78238fc01b4c58c8888f5 Author: Tom Prince Date: 2012-03-30 (Fri, 30 Mar 2012) Changed paths: M master/buildbot/process/properties.py Log Message: ----------- Don't store a PropertyMap on Properties. PropertyMap is an implementation detail of WithProperties, so the only thing that should need to know about it is WithProperties. Compare: https://github.com/buildbot/buildbot/compare/e35caa3...c271360 From noreply at github.com Sat Mar 31 04:13:31 2012 From: noreply at github.com (GitHub) Date: Fri, 30 Mar 2012 21:13:31 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 249d87: Properly fix import loop between buildbot.config a... Message-ID: <4f76846b80253_407a1201aec7264d@sh2.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 249d87f4e4a02f12ea674fe7d242f16c16763e47 https://github.com/buildbot/buildbot/commit/249d87f4e4a02f12ea674fe7d242f16c16763e47 Author: Tom Prince Date: 2012-03-30 (Fri, 30 Mar 2012) Changed paths: M master/buildbot/config.py M master/buildbot/process/properties.py Log Message: ----------- Properly fix import loop between buildbot.config and buildbot.process.properties. config is more fundamental that properties, so limit the scope of imports there. Commit: dd4db7136f6e6f7847a98c2c232498c3f30cbebe https://github.com/buildbot/buildbot/commit/dd4db7136f6e6f7847a98c2c232498c3f30cbebe Author: Tom Prince Date: 2012-03-30 (Fri, 30 Mar 2012) Changed paths: M master/buildbot/test/unit/test_steps_source_svn.py Log Message: ----------- Properly monkey patch things in test_steps_source_svn. Previously, the tests were order dependent, due to failing to restore the patch after the end of the test. Instead use self.patch to handle restoring afterwards. This was caught by running trial with '--random'. Compare: https://github.com/buildbot/buildbot/compare/c271360...dd4db71 From nobody at buildbot.net Sat Mar 31 20:47:18 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 31 Mar 2012 20:47:18 -0000 Subject: [Buildbot-commits] [Buildbot] #2266: No longer get emails if build ends with Exception Message-ID: <042.4d2ce5f0f7b0219d432bae134017a18f@buildbot.net> #2266: No longer get emails if build ends with Exception -----------------------+----------------------- Reporter: jaredgrubb | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.6p1 | Keywords: -----------------------+----------------------- After updating to 0.8.6 / 0.8.6p1, I have noticed that I never get emails if the build ends with Exception. The last "Exception" email I got was on March 1, For example, a successful build ends with the following log: {{{ 2012-03-31 13:34:42-0700 [-] step 'Foo' complete: success 2012-03-31 13:34:42-0700 [-] : build finished 2012-03-31 13:34:42-0700 [-] sending mail (6944 bytes) to ['somewhere at gmail.com'] 2012-03-31 13:34:42-0700 [-] Starting factory 2012-03-31 13:34:42-0700 [-] setting expectations for next time 2012-03-31 13:34:42-0700 [-] new expectations: 263.892459631 seconds 2012-03-31 13:34:42-0700 [-] releaseLocks(): [] 2012-03-31 13:34:42-0700 [-] releaseLocks(): [(, )] 2012-03-31 13:34:42-0700 [ESMTPSender,client] Stopping factory }}} but if, for example, I do a stop-build from the web: {{{ 2012-03-31 13:27:32-0700 [HTTPChannel,2,xxx] web stopBuild of build Foo:35 2012-03-31 13:27:32-0700 [HTTPChannel,2,xxx] : stopping build: The web-page 'stop build' button was pressed by '<unknown>': 2012-03-31 13:27:32-0700 [HTTPChannel,2,xxx] addCompleteLog(interrupt) 2012-03-31 13:27:32-0700 [HTTPChannel,2,xxx] RemoteCommand.interrupt The web-page 'stop build' button was pressed by '<unknown>': 2012-03-31 13:27:32-0700 [Broker,0,127.0.0.1] rc=-12012-03-31 13:27:32-0700 [-] closing log 2012-03-31 13:27:33-0700 [-] addCompleteLog(warnings (4)) 2012-03-31 13:27:33-0700 [-] releaseLocks(): [] 2012-03-31 13:27:33-0700 [-] step 'Foo' complete: exception 2012-03-31 13:27:33-0700 [-] : build finished 2012-03-31 13:27:34-0700 [-] releaseLocks(): [] 2012-03-31 13:27:34-0700 [-] releaseLocks(): [(, )] }}} In the good case, immediately after "build finished", you get a "sending mail" line, a factory call to ESMTPSenderFactory, and then the locks are released. In the bad case, immediately after "build finished", it goes straight to releasing the locks, skipping the email step. My status config looks like this: {{{ mail.MailNotifier( fromaddr=EMAIL_CONFIG['from_address'], builders=[ 'Bar', ], extraRecipients=EMAIL_CONFIG['all_addresses'], sendToInterestedUsers=EMAIL_CONFIG['sendToInterestedUsers'], relayhost="xxx", mode='all', lookup=Xxx(), messageFormatter=FormatBuildResults() ), mail.MailNotifier( fromaddr=EMAIL_CONFIG['from_address'], builders=[ 'Bar', ], extraRecipients=EMAIL_CONFIG['fail_addresses'], sendToInterestedUsers=False, # these users will get email due to the 'all' one above relayhost="xxx", mode='failing', messageFormatter=FormatBuildResults() ), }}} -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 31 21:42:56 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 31 Mar 2012 21:42:56 -0000 Subject: [Buildbot-commits] [Buildbot] #2266: No longer get emails if build ends with Exception In-Reply-To: <042.4d2ce5f0f7b0219d432bae134017a18f@buildbot.net> References: <042.4d2ce5f0f7b0219d432bae134017a18f@buildbot.net> Message-ID: <057.73f6c09e953dd894f6bcb42f82758ee1@buildbot.net> #2266: No longer get emails if build ends with Exception -----------------------+------------------------- Reporter: jaredgrubb | Owner: jaredgrubb Type: defect | Status: assigned Priority: major | Milestone: undecided Version: 0.8.6p1 | Resolution: Keywords: | -----------------------+------------------------- Changes (by jaredgrubb): * owner: => jaredgrubb * status: new => assigned Comment: Tom pointed out the change that caused this (6d4367c807302f359eb9eb580c48233ef7e90fd9). Basically, EXCEPTION results are being skipped now by all MailNotifier mode's. His suggestion was to add a new mode, "exception", since an EXCEPTION really isnt something that should be factored into a "failing", "warnings", or "change" mode. We'll also map "all" to include this new type. I'll prepare a patch for this. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sat Mar 31 22:05:14 2012 From: noreply at github.com (GitHub) Date: Sat, 31 Mar 2012 15:05:14 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 790e4c: Fix TestMailNotifier.test_buildsetFinished_doesnt_... Message-ID: <4f777f9a1dce5_8f03fb4e51b22fc8343c@sh1.rs.github.com.mail> Branch: refs/heads/buildbot-0.8.6 Home: https://github.com/buildbot/buildbot Commit: 790e4c9811ae18d240ccd7afc1b2fbd8b664c712 https://github.com/buildbot/buildbot/commit/790e4c9811ae18d240ccd7afc1b2fbd8b664c712 Author: Tom Prince Date: 2012-03-31 (Sat, 31 Mar 2012) Changed paths: M master/buildbot/test/unit/test_status_mail.py Log Message: ----------- Fix TestMailNotifier.test_buildsetFinished_doesnt_send_email. MailNotifier was fixed to use self.master.db rather than self.parent.db. Fix the new test to respect that. Apparently this was changed 0.8.6p1.