[Buildbot-commits] [Buildbot] #2322: Exception when checking out Mercurial repository

[Buildbot]

#2322: Exception when checking out Mercurial repository
---------------------+------------------------
Reporter:  pepsiman  |       Owner:
    Type:  defect    |      Status:  new
Priority:  major     |   Milestone:  undecided
 Version:  0.8.6p1   |  Resolution:
Keywords:  hg        |
---------------------+------------------------

Comment (by callek):

 Overall I think this is ok to take if its fixing broken behavior. I'm not
 sure I completely understand why its broken (.hgeol I never heard of
 before now)

 The caveats:

 * the + is not printed when local changes exist.
 * local uncommitted merges print 2 revs.

 The first issue is not a problem, imo since this code would have already
 raised a ValueError in such a case (since length would have been 41)

 I also think it is safe to ignore the error caused by part 2 here, since
 an uncommitted change would also cause the + (with TWO changesets, same
 line) in the other method we currently use.

 So long story short r+ for dustin or you to do an official pull request
 and merge.

 Might as well update the Old source step version while you're here:

 https://github.com/buildbot/buildbot/blob/master/slave/buildslave/commands/hg.py#L273

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2322#comment:2>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation