[Buildbot-commits] [Buildbot] #2320: P4Source: ignore PATH

[Buildbot]

#2320: P4Source: ignore PATH
--------------------+-----------------------
Reporter:  sanxiyn  |      Owner:
    Type:  defect   |     Status:  new
Priority:  major    |  Milestone:  undecided
 Version:  0.8.6p1  |   Keywords:  p4
--------------------+-----------------------
 P4Source's p4bin defaults to "p4", and the manual says "You only need to
 do this if the perforce binary is not in the path of the buildbot user".
 This is currently not the case.

 P4Source sanitizes environment to include P4* variables and ultimately
 calls os.execvpe. But "When the environment is being replaced, the new
 environment is used as the source of the PATH variable" (Python Library
 Reference). PATH is not included in the sanitized environment.

 The end result is that you get an error if your perforce binary is
 installed at /opt/bin/p4, even if /opt/bin is in PATH. How did this work
 at all? Because execvpe defaults to confstr(_CS_PATH) if PATH can't be
 found...

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2320>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation