[Buildbot-commits] [Buildbot] #2311: Forced Scheduler don't erforce required or need_email

[Buildbot]

#2311: Forced Scheduler don't erforce required or need_email
-------------------+-----------------------
Reporter:  Jiuka   |      Owner:
    Type:  defect  |     Status:  new
Priority:  major   |  Milestone:  undecided
 Version:  master  |   Keywords:
-------------------+-----------------------
 [https://github.com/buildbot/buildbot/blob/master/master/buildbot/status/web/builder.py#L138
 ForceBuildActionResource ask Authz] for the username and pass this as
 owner to ForceScheduler.force

 [https://github.com/buildbot/buildbot/blob/master/master/buildbot/status/web/authz.py#L96
 Authz.getUsernameFull] returns eigther the formvalue username or
 "<unknown>" for unauthenticated users.

 [https://github.com/buildbot/buildbot/blob/master/master/buildbot/schedulers/forcesched.py#L291
 ForceScheduler] thin check if owner is None then get the value from
 [https://github.com/buildbot/buildbot/blob/master/master/buildbot/schedulers/forcesched.py#L125
 UserNameParameter] which enforce the required and/or need_email.

 As getUsernameFull will return u'' if the form was not filled in or
 "<unknown>" if the form input was missing, this will never happens.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2311>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation