[Buildbot-commits] [Buildbot] #2139: locks held by slaves are not released when slave goes missing

[Buildbot]

#2139: locks held by slaves are not released when slave goes missing
--------------------+--------------------
Reporter:  dwlocks  |       Owner:
    Type:  defect   |      Status:  new
Priority:  major    |   Milestone:  0.8.6
 Version:  0.8.4p2  |  Resolution:
Keywords:           |
--------------------+--------------------

Comment (by dustin):

 tomprince suggets
 {{{
 #!patch
 diff --git a/master/buildbot/buildslave.py b/master/buildbot/buildslave.py
 index 9f06e65..b8c3c3a 100644
 --- a/master/buildbot/buildslave.py
 +++ b/master/buildbot/buildslave.py
 @@ -460,6 +460,7 @@ class
 AbstractBuildSlave(config.ReconfigurableServiceMixin, pb.Avatar,
          log.msg("BuildSlave.detached(%s)" % self.slavename)
          self.botmaster.master.status.slaveDisconnected(self.slavename)
          self.stopKeepaliveTimer()
 + self.release()

          # notify watchers, but do so in the next reactor iteration so
 that
          # any further detached() action by subclasses happens first
 }}}
 which seems adequate to me, but is untested.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2139#comment:2>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation