[Buildbot-commits] [Buildbot] #2122: Race condition causes error describing step

[Buildbot]

#2122: Race condition causes error describing step
-------------------+--------------------
Reporter:  tmidd   |       Owner:
    Type:  defect  |      Status:  new
Priority:  minor   |   Milestone:  0.8.6
 Version:  0.8.5   |  Resolution:
Keywords:          |
-------------------+--------------------

Comment (by seb_kuzminsky):

 Replying to [comment:3 dustin]:
 > Does that WithProperties reference something that the SetProperty should
 set?

 I have two SetProperty() calls that have trouble; one tries to use the
 property it sets and one doesn't.

 Here's the one that uses its own property:

 {{{
 set_property_branch = shell.SetProperty(
     command = WithProperties('if [ ! -z "%(branch)s" ]; then echo
 %(branch)s; else echo master; fi'),
     property = 'branch',
     haltOnFailure = 1
 )
 }}}

 And here's the one that doesn't:

 {{{
 def get_version_extractor(rc, stdout, stderr):
     s = stdout.strip()
     if s == '':
         return None  # how do you report error from an extract_fn?
     return { 'version': s }

 set_property_version = shell.SetProperty(
     command = WithProperties("scripts/get-version-from-git %(branch)s"),
     extract_fn = get_version_extractor,
     haltOnFailure = 1
 )
 }}}

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2122#comment:4>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation