[Buildbot-commits] [Buildbot] #2126: buildbot try --properties=prop=value doesn't work with try_jobdir

[Buildbot]

#2126: buildbot try --properties=prop=value doesn't work with try_jobdir
-------------------+--------------------
Reporter:  gg0     |       Owner:
    Type:  defect  |      Status:  new
Priority:  major   |   Milestone:  0.8.6
 Version:  0.8.5   |  Resolution:
Keywords:  try     |
-------------------+--------------------

Comment (by dlatornell):

 I've explored this issue a bit. I can confirm that:
 {{{
 buildbot try --connect=ssh --properties=abc=def,ghi=jkl ...
 }}}
 can trigger a build but the properties will not be passed to the builder.

 I was expecting to find that the properties had just been dropped
 somewhere along the chain of events, however, that's not what I found. In
 short, the properties option is not implemented for the try client when it
 is used in `ssh` mode; it's only there for `pb` mode.

 I think the `ssh` implementation would require handling of properties in
 the `createJobfile` function in `tryclient.py` and the `parseJob` and
 `handleJobFile` methods in `trysched.py`. The job file format will have to
 be extended to support key/value pairs.

 Unfortunately, I can't devote the time to implement this now. But I
 thought I should share my findings and opinions.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2126#comment:6>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation