From nobody at buildbot.net Sun Jan 1 00:20:30 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 01 Jan 2012 00:20:30 -0000 Subject: [Buildbot-commits] [Buildbot] #746: upgrade-master with missing state.sqlite file hangs forever In-Reply-To: <038.611b67b98ca83ab3606993809b4d1949@buildbot.net> References: <038.611b67b98ca83ab3606993809b4d1949@buildbot.net> Message-ID: <053.7259b98afe744c1cbf4b448c0bddda8d@buildbot.net> #746: upgrade-master with missing state.sqlite file hangs forever -------------------+--------------------- Reporter: catlee | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.0 Version: 0.8.0 | Resolution: fixed Keywords: | -------------------+--------------------- Changes (by dustin): * status: reopened => closed * resolution: => fixed Comment: This may be related to the weird threads-and-locks behavior we've been seeing on *BSD platforms, e.g., #2055. I'll close for now since there's been no further reproduction. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Jan 1 20:28:20 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 01 Jan 2012 20:28:20 -0000 Subject: [Buildbot-commits] [Buildbot] #42: Add load-balancing support In-Reply-To: <038.85fc6c355e585fd4db1f92f9c9e903da@buildbot.net> References: <038.85fc6c355e585fd4db1f92f9c9e903da@buildbot.net> Message-ID: <053.cf3ebca0e812269838148288e7a7040b@buildbot.net> #42: Add load-balancing support --------------------------+--------------------- Reporter: stefan | Owner: warner Type: enhancement | Status: closed Priority: major | Milestone: 0.8.+ Version: 0.8.0 | Resolution: fixed Keywords: loadbalancing | --------------------------+--------------------- Changes (by dustin): * status: new => closed * resolution: => fixed Comment: I don't think that there is anything actionable in this bug, aside from "make load balancing better!". The multi-master support has gone some way toward this (and also made it much more complex). There's a load-balancing tag now (http://trac.buildbot.net/tags/%27loadbalancing%27), which can track the general project adequately. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Jan 1 20:29:03 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 01 Jan 2012 20:29:03 -0000 Subject: [Buildbot-commits] [Buildbot] #66: need a test for the BonsaiMaildirSource In-Reply-To: <038.d06c589d607d0b941af936b4970df3f5@buildbot.net> References: <038.d06c589d607d0b941af936b4970df3f5@buildbot.net> Message-ID: <053.fc996ce43056f13317d993bceb53b11d@buildbot.net> #66: need a test for the BonsaiMaildirSource -------------------+--------------------- Reporter: warner | Owner: warner Type: task | Status: closed Priority: minor | Milestone: 0.8.+ Version: 0.7.5 | Resolution: fixed Keywords: tests | -------------------+--------------------- Changes (by dustin): * status: new => closed * resolution: => fixed Comment: This was removed in 0.8.2, so no longer needs tests :) -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Jan 1 21:25:25 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 01 Jan 2012 21:25:25 -0000 Subject: [Buildbot-commits] [Buildbot] #2087: move dev docs to sphinx In-Reply-To: <038.8516733ab6c8fef0b20ffd225986db06@buildbot.net> References: <038.8516733ab6c8fef0b20ffd225986db06@buildbot.net> Message-ID: <053.3655d75f780fb3c31cd6e8b42eb7e81b@buildbot.net> #2087: move dev docs to sphinx ------------------------+-------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.9.+ Version: master | Resolution: Keywords: docs | ------------------------+-------------------- Changes (by dustin): * milestone: 0.8.6 => 0.9.+ Comment: The dev docs in sphinx are coming along nicely, so I'm going to bump this ahead to 0.9.+ to remind myself to remove docstrings when that's complete. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Mon Jan 2 23:36:12 2012 From: noreply at github.com (noreply at github.com) Date: Mon, 2 Jan 2012 15:36:12 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] b44676: add addChange to FakeDB Message-ID: <20120102233612.AFD704243E@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: b44676c1e3075644a15b7eb8e8bbab55da91cadb https://github.com/buildbot/buildbot/commit/b44676c1e3075644a15b7eb8e8bbab55da91cadb Author: Dustin J. Mitchell Date: 2012-01-02 (Mon, 02 Jan 2012) Changed paths: M master/buildbot/test/fake/fakedb.py M master/buildbot/test/unit/test_schedulers_basic.py M master/buildbot/test/util/scheduler.py Log Message: ----------- add addChange to FakeDB Commit: db6d1424f27bcd71307765a133fd4b04ade1300e https://github.com/buildbot/buildbot/commit/db6d1424f27bcd71307765a133fd4b04ade1300e Author: Dustin J. Mitchell Date: 2012-01-02 (Mon, 02 Jan 2012) Changed paths: M master/buildbot/db/changes.py M master/buildbot/test/fake/fakedb.py M master/buildbot/util/__init__.py Log Message: ----------- make epoch2datetime & datetime2epoch handle None Commit: 8d8e350b685ae3fcf9693f459b3d5b27153e9428 https://github.com/buildbot/buildbot/commit/8d8e350b685ae3fcf9693f459b3d5b27153e9428 Author: Dustin J. Mitchell Date: 2012-01-02 (Mon, 02 Jan 2012) Changed paths: M master/buildbot/db/buildrequests.py M master/buildbot/test/fake/fakedb.py M master/buildbot/test/unit/test_db_buildrequests.py M master/docs/developer/database.rst M master/docs/release-notes.rst Log Message: ----------- add complete_at param to completeBuildset Compare: https://github.com/buildbot/buildbot/compare/4e89084...8d8e350 From noreply at github.com Tue Jan 3 06:17:55 2012 From: noreply at github.com (noreply at github.com) Date: Mon, 2 Jan 2012 22:17:55 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] e97045: finish making db methods take explicit complete_at... Message-ID: <20120103061755.DC94B42369@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: e97045f1f30ed967a35aabd5557954a5c86f6be7 https://github.com/buildbot/buildbot/commit/e97045f1f30ed967a35aabd5557954a5c86f6be7 Author: Dustin J. Mitchell Date: 2012-01-02 (Mon, 02 Jan 2012) Changed paths: M master/buildbot/db/buildrequests.py M master/buildbot/db/buildsets.py M master/buildbot/test/fake/fakedb.py M master/buildbot/test/unit/test_db_buildrequests.py M master/buildbot/test/unit/test_db_buildsets.py M master/docs/developer/database.rst M master/docs/release-notes.rst Log Message: ----------- finish making db methods take explicit complete_at arguments From nobody at buildbot.net Wed Jan 4 10:04:08 2012 From: nobody at buildbot.net (Buildbot) Date: Wed, 04 Jan 2012 10:04:08 -0000 Subject: [Buildbot-commits] [Buildbot] #2168: Docs on python MySQL requirements missing Message-ID: <040.2dbe0810a6995869927c76ee8e759b86@buildbot.net> #2168: Docs on python MySQL requirements missing ------------------------+----------------------- Reporter: mverwijs | Owner: Type: enhancement | Status: new Priority: major | Milestone: undecided Version: 0.8.5 | Keywords: docs ------------------------+----------------------- Documentation on how to install the mysql requirements for BuildBot are missing. A non-python-programmer will find it hard to figure out how learn which (python) packages are missing and what commands to invoke. On Debian, these steps include: * As root: apt-get build-dep python-mysqldb * As buildbot-user: pip install MySQL-python -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Wed Jan 4 16:26:44 2012 From: noreply at github.com (noreply at github.com) Date: Wed, 4 Jan 2012 08:26:44 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] 2a0ad4: Add MySQL-python requirement for Postgres. Message-ID: <20120104162644.D49D6426BC@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 2a0ad4574931a168a7fe2ecd56c16317fc27465d https://github.com/buildbot/buildbot/commit/2a0ad4574931a168a7fe2ecd56c16317fc27465d Author: Dustin J. Mitchell Date: 2012-01-04 (Wed, 04 Jan 2012) Changed paths: M master/docs/manual/installation.rst Log Message: ----------- Add MySQL-python requirement for Postgres. Fixes #2168 From nobody at buildbot.net Wed Jan 4 16:26:50 2012 From: nobody at buildbot.net (Buildbot) Date: Wed, 04 Jan 2012 16:26:50 -0000 Subject: [Buildbot-commits] [Buildbot] #2168: Docs on python MySQL requirements missing In-Reply-To: <040.2dbe0810a6995869927c76ee8e759b86@buildbot.net> References: <040.2dbe0810a6995869927c76ee8e759b86@buildbot.net> Message-ID: <055.25c87778d2b4ffb30109643989c39bb1@buildbot.net> #2168: Docs on python MySQL requirements missing ------------------------+------------------------ Reporter: mverwijs | Owner: Type: enhancement | Status: closed Priority: major | Milestone: undecided Version: 0.8.5 | Resolution: fixed Keywords: docs | ------------------------+------------------------ Changes (by Dustin J. Mitchell): * status: new => closed * resolution: => fixed Comment: Add MySQL-python requirement for Postgres. Fixes #2168 Changeset: 2a0ad4574931a168a7fe2ecd56c16317fc27465d -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Jan 6 05:16:04 2012 From: nobody at buildbot.net (Buildbot) Date: Fri, 06 Jan 2012 05:16:04 -0000 Subject: [Buildbot-commits] [Buildbot] #1951: Improve Nightly's next-build-finding algorithm In-Reply-To: <038.cadfd8cbd2ebf386bea86eaaf5cffd2a@buildbot.net> References: <038.cadfd8cbd2ebf386bea86eaaf5cffd2a@buildbot.net> Message-ID: <053.d1aa65aca0810d7636de65a491f506f3@buildbot.net> #1951: Improve Nightly's next-build-finding algorithm --------------------------------+-------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.+ Version: 0.8.3p1 | Resolution: Keywords: performance, simple | --------------------------------+-------------------- Changes (by dustin): * keywords: performance => performance, simple Comment: This will take some thought about how best to calculate the next matching time, without long iteration. But the tests are already written, and this doesn't require much knowledge of the rest of Buildbot's internals. Thus I'm tagging it as "simple". -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Jan 6 05:18:02 2012 From: nobody at buildbot.net (Buildbot) Date: Fri, 06 Jan 2012 05:18:02 -0000 Subject: [Buildbot-commits] [Buildbot] #1820: store configuration values in self.master.config In-Reply-To: <038.d73b9124a0c220076348d7da9bda8fbe@buildbot.net> References: <038.d73b9124a0c220076348d7da9bda8fbe@buildbot.net> Message-ID: <053.721ee351f782bcff526a92f8ed00c76f@buildbot.net> #1820: store configuration values in self.master.config ------------------------+--------------------- Reporter: dustin | Owner: Type: enhancement | Status: closed Priority: major | Milestone: 0.8.6 Version: master | Resolution: fixed Keywords: | ------------------------+--------------------- Changes (by dustin): * status: new => closed * resolution: => fixed * milestone: 0.8.+ => 0.8.6 Comment: This is done: {{{ commit b4fb9fbf2243db6d091202f58ced453483fecd29 Author: Dustin J. Mitchell Date: Sat Nov 12 00:32:16 2011 -0600 Refactor configuration handling This moves configuration loading and checking out of the master, and into a new module. Where possible, configuration is accessed directly in as many cases as possible, rather than being disseminated across the master at reconfiguration time. For services that need to modify their behavior when reconfigured, the ReconfigurableServiceMixin defines a general method of notification, eliminating service-specific code from the master. Schedulers are still stopped and re-started at every reconfiguration; this may be changed in the future. }}} -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Jan 6 05:19:59 2012 From: nobody at buildbot.net (Buildbot) Date: Fri, 06 Jan 2012 05:19:59 -0000 Subject: [Buildbot-commits] [Buildbot] #1734: buildbot should raise a warning if a scheduler in c['schedulers'] doesn't actually get added In-Reply-To: <038.7a5d8eb72f2708e5c53dd50abc2f2f76@buildbot.net> References: <038.7a5d8eb72f2708e5c53dd50abc2f2f76@buildbot.net> Message-ID: <053.293eae884472a646666b2fa36e6894c6@buildbot.net> #1734: buildbot should raise a warning if a scheduler in c['schedulers'] doesn't actually get added -------------------+-------------------- Reporter: catlee | Owner: Type: defect | Status: new Priority: minor | Milestone: 0.8.+ Version: 0.8.2 | Resolution: Keywords: simple | -------------------+-------------------- Changes (by dustin): * keywords: => simple Comment: This should be relatively easy to add and test in master/buildbot/config.py -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Jan 6 09:36:28 2012 From: nobody at buildbot.net (Buildbot) Date: Fri, 06 Jan 2012 09:36:28 -0000 Subject: [Buildbot-commits] [Buildbot] #2169: make umask on master configurable Message-ID: <040.3502b75d5f281edc33ea0d30f68e0617@buildbot.net> #2169: make umask on master configurable ------------------------+----------------------- Reporter: mverwijs | Owner: Type: enhancement | Status: new Priority: minor | Milestone: undecided Version: 0.8.5 | Keywords: ------------------------+----------------------- In my setup, the master creates an APT and YUM repository using MasterShellCommands. These commands result in files and folders that are inaccessable to any other user due to Twistd's restrictive settings. I've modded ''lib/python2.6/site-packages/Twisted-11.1.0-py2.6-linux- x86_64.egg/twisted/scripts/_twistd_unix.py'' to have a less restrictive umask, as I was unable to find any other way to do this. It would be useful if the method used for Slaves to set the umask was applied to the Master as well. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Jan 6 15:56:46 2012 From: nobody at buildbot.net (Buildbot) Date: Fri, 06 Jan 2012 15:56:46 -0000 Subject: [Buildbot-commits] [Buildbot] #2169: make umask on master configurable In-Reply-To: <040.3502b75d5f281edc33ea0d30f68e0617@buildbot.net> References: <040.3502b75d5f281edc33ea0d30f68e0617@buildbot.net> Message-ID: <055.08cc3d435003f02c936b5b89f3199cd8@buildbot.net> #2169: make umask on master configurable ------------------------+-------------------- Reporter: mverwijs | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.+ Version: 0.8.5 | Resolution: Keywords: simple | ------------------------+-------------------- Changes (by dustin): * keywords: => simple * milestone: undecided => 0.8.+ -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Fri Jan 6 16:08:18 2012 From: noreply at github.com (noreply at github.com) Date: Fri, 6 Jan 2012 08:08:18 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] 726e9f: Flatten lists in shell commands, so that propertie... Message-ID: <20120106160818.8A037421BD@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 726e9f81c103939d22bd18d53ca65c66cfb8aed7 https://github.com/buildbot/buildbot/commit/726e9f81c103939d22bd18d53ca65c66cfb8aed7 Author: Dustin J. Mitchell Date: 2012-01-06 (Fri, 06 Jan 2012) Changed paths: M master/buildbot/steps/shell.py M master/buildbot/test/unit/test_steps_shell.py Log Message: ----------- Flatten lists in shell commands, so that properties can insert multiple args Patch by Edmund Wong . Fixes #2150. Commit: 745c1e528e178b3685933a7f24c4bd42792421e2 https://github.com/buildbot/buildbot/commit/745c1e528e178b3685933a7f24c4bd42792421e2 Author: Dustin J. Mitchell Date: 2012-01-06 (Fri, 06 Jan 2012) Changed paths: M master/docs/manual/cfg-buildsteps.rst M master/docs/release-notes.rst Log Message: ----------- release notes and docs - Refs #2150. Compare: https://github.com/buildbot/buildbot/compare/2a0ad45...745c1e5 From nobody at buildbot.net Fri Jan 6 16:08:25 2012 From: nobody at buildbot.net (Buildbot) Date: Fri, 06 Jan 2012 16:08:25 -0000 Subject: [Buildbot-commits] [Buildbot] #2150: flatten nested lists in ShellCommands commands=.. In-Reply-To: <038.14f993230a6f84afcbdc15438565f7ea@buildbot.net> References: <038.14f993230a6f84afcbdc15438565f7ea@buildbot.net> Message-ID: <053.2954ceda1be94196a6c44b5196502652@buildbot.net> #2150: flatten nested lists in ShellCommands commands=.. ------------------------+--------------------- Reporter: mmadia | Owner: ewong Type: enhancement | Status: closed Priority: major | Milestone: 0.8.6 Version: 0.8.5 | Resolution: fixed Keywords: simple | ------------------------+--------------------- Comment (by Dustin J. Mitchell): release notes and docs - Refs #2150. Changeset: 745c1e528e178b3685933a7f24c4bd42792421e2 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Jan 6 16:08:25 2012 From: nobody at buildbot.net (Buildbot) Date: Fri, 06 Jan 2012 16:08:25 -0000 Subject: [Buildbot-commits] [Buildbot] #2150: flatten nested lists in ShellCommands commands=.. In-Reply-To: <038.14f993230a6f84afcbdc15438565f7ea@buildbot.net> References: <038.14f993230a6f84afcbdc15438565f7ea@buildbot.net> Message-ID: <053.a7183d0ad4a62eaf986e6cb03227f052@buildbot.net> #2150: flatten nested lists in ShellCommands commands=.. ------------------------+--------------------- Reporter: mmadia | Owner: ewong Type: enhancement | Status: closed Priority: major | Milestone: 0.8.6 Version: 0.8.5 | Resolution: fixed Keywords: simple | ------------------------+--------------------- Changes (by Dustin J. Mitchell): * status: assigned => closed * resolution: => fixed Comment: Flatten lists in shell commands, so that properties can insert multiple args Patch by Edmund Wong . Fixes #2150. Changeset: 726e9f81c103939d22bd18d53ca65c66cfb8aed7 -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sat Jan 7 00:40:21 2012 From: noreply at github.com (GitHub) Date: Fri, 06 Jan 2012 16:40:21 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] : Test against NoneType before calling results funct... Message-ID: <4f0794752630e_4e7d3fe61bdf82fc89889@sh1.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 9a95fac03a980e9fb8a7e8fbc3324f78bb7bdd10 https://github.com/buildbot/buildbot/commit/9a95fac03a980e9fb8a7e8fbc3324f78bb7bdd10 Author: Jared Morrow Date: 2012-01-06 (Fri, 06 Jan 2012) Changed paths: M master/buildbot/status/mail.py Log Message: ----------- Test against NoneType before calling results function Commit: bc2169b6781544d3ec469435d908f2af52927c67 https://github.com/buildbot/buildbot/commit/bc2169b6781544d3ec469435d908f2af52927c67 Author: Dustin J. Mitchell Date: 2012-01-06 (Fri, 06 Jan 2012) Changed paths: M master/buildbot/status/mail.py Log Message: ----------- Merge branch 'master' of git://github.com/jaredmorrow/buildbot * 'master' of git://github.com/jaredmorrow/buildbot: Test against NoneType before calling results function Compare: https://github.com/buildbot/buildbot/compare/745c1e5...bc2169b From nobody at buildbot.net Sat Jan 7 18:17:42 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 07 Jan 2012 18:17:42 -0000 Subject: [Buildbot-commits] [Buildbot] #2170: Trigger steps could link to triggered builds Message-ID: <042.6e80a0d0bfe7fc7b121e773479357903@buildbot.net> #2170: Trigger steps could link to triggered builds ------------------------+------------------------ Reporter: jaredgrubb | Owner: jaredgrubb Type: enhancement | Status: new Priority: major | Milestone: 0.8.6 Version: 0.8.5 | Keywords: ------------------------+------------------------ Currently, there is no information pushed back to the Trigger step about any of the triggered builds. Doing so would allow many nice features: * ability to add URL links between trigger steps and the triggered builds (in both waterfall and in detail view) * ability for status targets to retrieve more details about those builds (for example, include URL to triggered build summaries, or even traverse deeper into the triggers to create nested lists of information about a build). This definitely should work when waitForFinish=True, and in theory could work even for waitForFinish=False, but I'm not going to attempt that yet. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Jan 7 18:18:57 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 07 Jan 2012 18:18:57 -0000 Subject: [Buildbot-commits] [Buildbot] #2170: Trigger steps could link to triggered builds In-Reply-To: <042.6e80a0d0bfe7fc7b121e773479357903@buildbot.net> References: <042.6e80a0d0bfe7fc7b121e773479357903@buildbot.net> Message-ID: <057.c674c0b56a1c89ef1d1d9c08f9626232@buildbot.net> #2170: Trigger steps could link to triggered builds ------------------------+------------------------- Reporter: jaredgrubb | Owner: jaredgrubb Type: enhancement | Status: accepted Priority: major | Milestone: 0.8.6 Version: 0.8.5 | Resolution: Keywords: | ------------------------+------------------------- Changes (by jaredgrubb): * status: new => accepted Comment: Marking as 0.8.6 as I do have a patch ready for review and should be generating a pull request shortly. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Jan 7 23:20:15 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 07 Jan 2012 23:20:15 -0000 Subject: [Buildbot-commits] [Buildbot] #2171: older sqlalchemies fail to quote default values Message-ID: <038.644d4364ed71900e09958d97da7d84ce@buildbot.net> #2171: older sqlalchemies fail to quote default values -------------------+---------------------- Reporter: dustin | Owner: dustin Type: defect | Status: new Priority: major | Milestone: 0.8.6 Version: 0.8.5 | Keywords: database -------------------+---------------------- This will need to be monkeypatched. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Jan 7 23:22:52 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 07 Jan 2012 23:22:52 -0000 Subject: [Buildbot-commits] [Buildbot] #2171: older sqlalchemies fail to quote default values In-Reply-To: <038.644d4364ed71900e09958d97da7d84ce@buildbot.net> References: <038.644d4364ed71900e09958d97da7d84ce@buildbot.net> Message-ID: <053.8df9a2e4e256abfc453b34af467c2661@buildbot.net> #2171: older sqlalchemies fail to quote default values ---------------------+--------------------- Reporter: dustin | Owner: dustin Type: defect | Status: new Priority: major | Milestone: 0.8.6 Version: 0.8.5 | Resolution: Keywords: database | ---------------------+--------------------- Comment (by dustin): Specifically, 0.7.1 fails with {{{ import sqlalchemy as sa engine = sa.create_engine('sqlite:///', echo=True) engine.execute(''' CREATE TABLE test ( project VARCHAR(1) DEFAULT '' NOT NULL )''') metadata = sa.MetaData(bind=engine) tbl = sa.Table('test', metadata, autoload=True) engine.execute('drop table test') tbl.create() }}} with {{{ 2012-01-07 17:22:08,981 INFO sqlalchemy.engine.base.Engine CREATE TABLE test ( project VARCHAR(1) DEFAULT '' NOT NULL ) ... CREATE TABLE test ( project VARCHAR(1) DEFAULT NOT NULL ) }}} I'll see what the diffs are between those versions and try to monkey-patch in the fix. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Jan 8 00:04:35 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 08 Jan 2012 00:04:35 -0000 Subject: [Buildbot-commits] [Buildbot] #2171: older sqlalchemies fail to quote default values In-Reply-To: <038.644d4364ed71900e09958d97da7d84ce@buildbot.net> References: <038.644d4364ed71900e09958d97da7d84ce@buildbot.net> Message-ID: <053.deb6725fbfae2f097e7e01e65d4e9af4@buildbot.net> #2171: older sqlalchemies fail to quote default values ---------------------+--------------------- Reporter: dustin | Owner: dustin Type: defect | Status: new Priority: major | Milestone: 0.8.6 Version: 0.8.5 | Resolution: Keywords: database | ---------------------+--------------------- Comment (by dustin): That would be http://www.sqlalchemy.org/trac/ticket/2189, and the monkeypatch is a bit long, but not hard. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sun Jan 8 00:07:12 2012 From: noreply at github.com (GitHub) Date: Sat, 07 Jan 2012 16:07:12 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] : Merge branch 'multirepo' of git://github.com/hbork... Message-ID: <4f08de30a84e3_54973ffc62dd9afc1917ba@sh1.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 91e5aac6f83b47d6bf064a4405222cfe81335e81 https://github.com/buildbot/buildbot/commit/91e5aac6f83b47d6bf064a4405222cfe81335e81 Author: Dustin J. Mitchell Date: 2012-01-07 (Sat, 07 Jan 2012) Changed paths: M master/buildbot/db/buildsets.py M master/buildbot/db/connector.py A master/buildbot/db/migrate/versions/018_add_sourcestampset.py M master/buildbot/db/model.py M master/buildbot/db/sourcestamps.py A master/buildbot/db/sourcestampsets.py M master/buildbot/process/build.py M master/buildbot/process/builder.py M master/buildbot/process/buildrequest.py M master/buildbot/schedulers/base.py M master/buildbot/schedulers/dependent.py M master/buildbot/schedulers/forcesched.py M master/buildbot/schedulers/trysched.py M master/buildbot/sourcestamp.py M master/buildbot/status/web/builder.py M master/buildbot/steps/source/oldsource.py M master/buildbot/test/fake/fakedb.py M master/buildbot/test/integration/test_upgrade.py M master/buildbot/test/unit/test_db_buildrequests.py M master/buildbot/test/unit/test_db_builds.py M master/buildbot/test/unit/test_db_buildsets.py A master/buildbot/test/unit/test_db_migrate_versions_18_add_sourcestampset.py M master/buildbot/test/unit/test_db_sourcestamps.py A master/buildbot/test/unit/test_db_sourcestampsets.py M master/buildbot/test/unit/test_master.py M master/buildbot/test/unit/test_process_builder.py M master/buildbot/test/unit/test_process_buildrequest.py M master/buildbot/test/unit/test_schedulers_base.py M master/buildbot/test/unit/test_schedulers_dependent.py M master/buildbot/test/unit/test_schedulers_forcesched.py M master/buildbot/test/unit/test_schedulers_triggerable.py M master/buildbot/test/unit/test_schedulers_trysched.py M master/buildbot/test/unit/test_sourcestamp.py M master/buildbot/test/unit/test_status_client.py M master/buildbot/test/unit/test_status_mail.py M master/buildbot/test/unit/test_status_master.py M master/buildbot/test/util/sourcesteps.py M master/docs/developer/database.rst Log Message: ----------- Merge branch 'multirepo' of git://github.com/hborkhuis/buildbot into multirepo * 'multirepo' of git://github.com/hborkhuis/buildbot: add two buildset indexes after creating the table markup and index issues fixed Test if a assertion fails when sourcestampset is empty All pull request comment processed Comment removed Index added for performance Fixed failing tests due to new multirepo functionality This patch contains the first modifications for supporting multi repository buildsets. database: new table 'sourcestampsets' buildsets and sourcestamps refere to this table business logic: build can return sourcestamps for given 'repo id' or buildrequest.source builder can handle sourcestamp sets containing exactly 1 sourcestamp buildrequest has now properties 'source' (backwards comp) and 'sources' status/web: rebuild and force can handle sourcestampsets with exacly 1 sourcestamp test: all test modified to support sourcestampsets (add set when insertdata) Commit: 602a1bb25aeead96419633fce991f04dcfc696f1 https://github.com/buildbot/buildbot/commit/602a1bb25aeead96419633fce991f04dcfc696f1 Author: Dustin J. Mitchell Date: 2012-01-07 (Sat, 07 Jan 2012) Changed paths: A master/buildbot/test/unit/test_db_migrate_versions_018_add_sourcestampset.py R master/buildbot/test/unit/test_db_migrate_versions_18_add_sourcestampset.py Log Message: ----------- rename test script to correspond to migration script name Commit: a53ed55dcf4fb077c81f471bf0e4881bf13988b1 https://github.com/buildbot/buildbot/commit/a53ed55dcf4fb077c81f471bf0e4881bf13988b1 Author: Dustin J. Mitchell Date: 2012-01-07 (Sat, 07 Jan 2012) Changed paths: M master/buildbot/db/enginestrategy.py A master/buildbot/test/unit/test_util_sautils.py M master/buildbot/util/sautils.py Log Message: ----------- add sa_version function, use it Commit: 21f356aff5086ad3eb0c1c60474b0c3bf2df6d4c https://github.com/buildbot/buildbot/commit/21f356aff5086ad3eb0c1c60474b0c3bf2df6d4c Author: Dustin J. Mitchell Date: 2012-01-07 (Sat, 07 Jan 2012) Changed paths: M master/buildbot/monkeypatches/__init__.py A master/buildbot/monkeypatches/sqlalchemy2364.py Log Message: ----------- monkeypatch sqlalchemy to not use constraint names with sqlite Commit: f0523f252142dca7f40387c2f0b1b09a42534609 https://github.com/buildbot/buildbot/commit/f0523f252142dca7f40387c2f0b1b09a42534609 Author: Dustin J. Mitchell Date: 2012-01-07 (Sat, 07 Jan 2012) Changed paths: M master/buildbot/db/migrate/versions/018_add_sourcestampset.py M master/buildbot/db/sourcestampsets.py M master/buildbot/schedulers/base.py M master/buildbot/schedulers/trysched.py M master/buildbot/test/unit/test_db_sourcestamps.py M master/buildbot/test/unit/test_db_sourcestampsets.py Log Message: ----------- fix pyflakes, comments Commit: 42acc9160506a0cd15ac04a17720c0e8faf1be34 https://github.com/buildbot/buildbot/commit/42acc9160506a0cd15ac04a17720c0e8faf1be34 Author: Dustin J. Mitchell Date: 2012-01-07 (Sat, 07 Jan 2012) Changed paths: M master/docs/release-notes.rst Log Message: ----------- add release notes Commit: 9a157d0259dc9fba60ccaa8501f1449265377335 https://github.com/buildbot/buildbot/commit/9a157d0259dc9fba60ccaa8501f1449265377335 Author: Dustin J. Mitchell Date: 2012-01-07 (Sat, 07 Jan 2012) Changed paths: M master/buildbot/scripts/runner.py Log Message: ----------- run monkeypatches on create-master and ugprade-master, too Commit: 9bc8fb20d4145d9138f2ab1b3de76f6382eb46e0 https://github.com/buildbot/buildbot/commit/9bc8fb20d4145d9138f2ab1b3de76f6382eb46e0 Author: Dustin J. Mitchell Date: 2012-01-07 (Sat, 07 Jan 2012) Changed paths: M master/buildbot/monkeypatches/__init__.py A master/buildbot/monkeypatches/sqlalchemy2189.py Log Message: ----------- fix sqlalchemy's handling of server defaults in reflection This fixes #2171, based on sqlalchemy bug 2189. Commit: 22305803cc8b0c0872e8bc2fa39ce3d1464454ee https://github.com/buildbot/buildbot/commit/22305803cc8b0c0872e8bc2fa39ce3d1464454ee Author: Dustin J. Mitchell Date: 2012-01-07 (Sat, 07 Jan 2012) Changed paths: M master/buildbot/db/buildsets.py M master/buildbot/db/connector.py M master/buildbot/db/enginestrategy.py A master/buildbot/db/migrate/versions/018_add_sourcestampset.py M master/buildbot/db/model.py M master/buildbot/db/sourcestamps.py A master/buildbot/db/sourcestampsets.py M master/buildbot/monkeypatches/__init__.py A master/buildbot/monkeypatches/sqlalchemy2189.py A master/buildbot/monkeypatches/sqlalchemy2364.py M master/buildbot/process/build.py M master/buildbot/process/builder.py M master/buildbot/process/buildrequest.py M master/buildbot/schedulers/base.py M master/buildbot/schedulers/dependent.py M master/buildbot/schedulers/forcesched.py M master/buildbot/schedulers/trysched.py M master/buildbot/scripts/runner.py M master/buildbot/sourcestamp.py M master/buildbot/status/web/builder.py M master/buildbot/steps/source/oldsource.py M master/buildbot/test/fake/fakedb.py M master/buildbot/test/integration/test_upgrade.py M master/buildbot/test/unit/test_db_buildrequests.py M master/buildbot/test/unit/test_db_builds.py M master/buildbot/test/unit/test_db_buildsets.py A master/buildbot/test/unit/test_db_migrate_versions_018_add_sourcestampset.py M master/buildbot/test/unit/test_db_sourcestamps.py A master/buildbot/test/unit/test_db_sourcestampsets.py M master/buildbot/test/unit/test_master.py M master/buildbot/test/unit/test_process_builder.py M master/buildbot/test/unit/test_process_buildrequest.py M master/buildbot/test/unit/test_schedulers_base.py M master/buildbot/test/unit/test_schedulers_dependent.py M master/buildbot/test/unit/test_schedulers_forcesched.py M master/buildbot/test/unit/test_schedulers_triggerable.py M master/buildbot/test/unit/test_schedulers_trysched.py M master/buildbot/test/unit/test_sourcestamp.py M master/buildbot/test/unit/test_status_client.py M master/buildbot/test/unit/test_status_mail.py M master/buildbot/test/unit/test_status_master.py A master/buildbot/test/unit/test_util_sautils.py M master/buildbot/test/util/sourcesteps.py M master/buildbot/util/sautils.py M master/docs/developer/database.rst M master/docs/release-notes.rst Log Message: ----------- Merge branch 'multirepo' * multirepo: fix sqlalchemy's handling of server defaults in reflection run monkeypatches on create-master and ugprade-master, too add release notes fix pyflakes, comments monkeypatch sqlalchemy to not use constraint names with sqlite add sa_version function, use it rename test script to correspond to migration script name add two buildset indexes after creating the table markup and index issues fixed Test if a assertion fails when sourcestampset is empty All pull request comment processed Comment removed Index added for performance Fixed failing tests due to new multirepo functionality This patch contains the first modifications for supporting multi repository buildsets. database: new table 'sourcestampsets' buildsets and sourcestamps refere to this table business logic: build can return sourcestamps for given 'repo id' or buildrequest.source builder can handle sourcestamp sets containing exactly 1 sourcestamp buildrequest has now properties 'source' (backwards comp) and 'sources' status/web: rebuild and force can handle sourcestampsets with exacly 1 sourcestamp test: all test modified to support sourcestampsets (add set when insertdata) Compare: https://github.com/buildbot/buildbot/compare/bc2169b...2230580 From nobody at buildbot.net Sun Jan 8 00:07:20 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 08 Jan 2012 00:07:20 -0000 Subject: [Buildbot-commits] [Buildbot] #2171: older sqlalchemies fail to quote default values In-Reply-To: <038.644d4364ed71900e09958d97da7d84ce@buildbot.net> References: <038.644d4364ed71900e09958d97da7d84ce@buildbot.net> Message-ID: <053.c004f204c2b3d2f6b21712363976db2f@buildbot.net> #2171: older sqlalchemies fail to quote default values ---------------------+--------------------- Reporter: dustin | Owner: dustin Type: defect | Status: closed Priority: major | Milestone: 0.8.6 Version: 0.8.5 | Resolution: fixed Keywords: database | ---------------------+--------------------- Changes (by Dustin J. Mitchell): * status: new => closed * resolution: => fixed Comment: fix sqlalchemy's handling of server defaults in reflection This fixes #2171, based on sqlalchemy bug 2189. Changeset: 9bc8fb20d4145d9138f2ab1b3de76f6382eb46e0 -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sun Jan 8 01:01:14 2012 From: noreply at github.com (GitHub) Date: Sat, 07 Jan 2012 17:01:14 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] : remove support for sqlalchemy-migrate 0.6.0 Message-ID: <4f08eada3f9c5_c573fd3b2fc62f81080c1@sh1.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: f802065cf414c7bd24dbfb630eab26201ad8f849 https://github.com/buildbot/buildbot/commit/f802065cf414c7bd24dbfb630eab26201ad8f849 Author: Dustin J. Mitchell Date: 2012-01-07 (Sat, 07 Jan 2012) Changed paths: M master/docs/manual/installation.rst M master/docs/release-notes.rst Log Message: ----------- remove support for sqlalchemy-migrate 0.6.0 Commit: ea8df1155bafa5d5a473d560731da183714e1817 https://github.com/buildbot/buildbot/commit/ea8df1155bafa5d5a473d560731da183714e1817 Author: Dustin J. Mitchell Date: 2012-01-07 (Sat, 07 Jan 2012) Changed paths: M master/buildbot/test/unit/test_db_migrate_versions_018_add_sourcestampset.py Log Message: ----------- do not depend on hash-table order for foreign keys Compare: https://github.com/buildbot/buildbot/compare/2230580...ea8df11 From noreply at github.com Sun Jan 8 01:19:44 2012 From: noreply at github.com (GitHub) Date: Sat, 07 Jan 2012 17:19:44 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] : remove non-existent symbol from __all__ Message-ID: <4f08ef30e5007_54933fd388376af42035b6@sh1.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 46d2141c9449e38e7c72946353e29c7d4a2abb95 https://github.com/buildbot/buildbot/commit/46d2141c9449e38e7c72946353e29c7d4a2abb95 Author: Dustin J. Mitchell Date: 2012-01-07 (Sat, 07 Jan 2012) Changed paths: M master/buildbot/util/__init__.py Log Message: ----------- remove non-existent symbol from __all__ Commit: 69e4081b459a6524611c80191db37b091734dd4e https://github.com/buildbot/buildbot/commit/69e4081b459a6524611c80191db37b091734dd4e Author: Dustin J. Mitchell Date: 2012-01-07 (Sat, 07 Jan 2012) Changed paths: M master/buildbot/test/unit/test_db_migrate_versions_018_add_sourcestampset.py Log Message: ----------- database columns hold integer timestamps Commit: d0710199da990c37d9b5d40ec55872803c6627a6 https://github.com/buildbot/buildbot/commit/d0710199da990c37d9b5d40ec55872803c6627a6 Author: Dustin J. Mitchell Date: 2012-01-07 (Sat, 07 Jan 2012) Changed paths: M master/buildbot/test/unit/test_db_migrate_versions_018_add_sourcestampset.py Log Message: ----------- do not check foreign keys on MySQL, which ignores them Compare: https://github.com/buildbot/buildbot/compare/ea8df11...d071019 From noreply at github.com Sun Jan 8 02:33:34 2012 From: noreply at github.com (GitHub) Date: Sat, 07 Jan 2012 18:33:34 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] : create sourcestampsets table, fixing errors on pos... Message-ID: <4f09007eaaf40_6d113fe8e3fe52fc112880@sh1.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: c5a46d80541b3227fb11e2968f4caae6bdffddce https://github.com/buildbot/buildbot/commit/c5a46d80541b3227fb11e2968f4caae6bdffddce Author: Dustin J. Mitchell Date: 2012-01-07 (Sat, 07 Jan 2012) Changed paths: M master/buildbot/test/unit/test_db_connector.py Log Message: ----------- create sourcestampsets table, fixing errors on postgres From nobody at buildbot.net Sun Jan 8 03:04:23 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 08 Jan 2012 03:04:23 -0000 Subject: [Buildbot-commits] [Buildbot] #2170: Trigger steps could link to triggered builds In-Reply-To: <042.6e80a0d0bfe7fc7b121e773479357903@buildbot.net> References: <042.6e80a0d0bfe7fc7b121e773479357903@buildbot.net> Message-ID: <057.291fb92b3d6d0a6ef45cf3fe5c41d141@buildbot.net> #2170: Trigger steps could link to triggered builds ------------------------+------------------------- Reporter: jaredgrubb | Owner: jaredgrubb Type: enhancement | Status: accepted Priority: major | Milestone: 0.8.6 Version: 0.8.5 | Resolution: Keywords: | ------------------------+------------------------- Comment (by dustin): Pull req is https://github.com/buildbot/buildbot/pull/296 and comments are there. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sun Jan 8 16:25:00 2012 From: noreply at github.com (GitHub) Date: Sun, 08 Jan 2012 08:25:00 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] : fix tests on MySQL Message-ID: <4f09c35c349d4_3cfe3fe94e7392f0127521@sh1.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 6d54089cb4bdd6435a5dc308d3034e9598bef202 https://github.com/buildbot/buildbot/commit/6d54089cb4bdd6435a5dc308d3034e9598bef202 Author: Dustin J. Mitchell Date: 2012-01-08 (Sun, 08 Jan 2012) Changed paths: M master/buildbot/db/model.py M master/buildbot/test/unit/test_db_sourcestampsets.py Log Message: ----------- fix tests on MySQL From noreply at github.com Sun Jan 8 20:50:44 2012 From: noreply at github.com (GitHub) Date: Sun, 08 Jan 2012 12:50:44 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] : honor foreign key references Message-ID: <4f0a01a420feb_67513fe0766cc2f8203125@sh1.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 80f2bd81743b7b2c0efc44558a6ad7deb2452bd9 https://github.com/buildbot/buildbot/commit/80f2bd81743b7b2c0efc44558a6ad7deb2452bd9 Author: Dustin J. Mitchell Date: 2012-01-08 (Sun, 08 Jan 2012) Changed paths: M master/buildbot/test/unit/test_db_buildsets.py Log Message: ----------- honor foreign key references Commit: 46d8d6c064ddccd6ab100c3ef97e4a6168e22008 https://github.com/buildbot/buildbot/commit/46d8d6c064ddccd6ab100c3ef97e4a6168e22008 Author: Dustin J. Mitchell Date: 2012-01-08 (Sun, 08 Jan 2012) Changed paths: M master/buildbot/db/migrate/versions/018_add_sourcestampset.py M master/buildbot/db/model.py Log Message: ----------- don't do a temporary table manually - let sqlalchemy-migrate do it as necessary Commit: 20f1fb1731e8aa53baf3075f06e1407ef93aaed9 https://github.com/buildbot/buildbot/commit/20f1fb1731e8aa53baf3075f06e1407ef93aaed9 Author: Dustin J. Mitchell Date: 2012-01-08 (Sun, 08 Jan 2012) Changed paths: M master/buildbot/test/integration/test_upgrade.py Log Message: ----------- sort column names when comparing indexes Commit: fccfbd8b4a27b03589bd0b887c35abf9d1b45995 https://github.com/buildbot/buildbot/commit/fccfbd8b4a27b03589bd0b887c35abf9d1b45995 Author: Dustin J. Mitchell Date: 2012-01-08 (Sun, 08 Jan 2012) Changed paths: M master/buildbot/test/unit/test_db_changes.py Log Message: ----------- include sourcestampsets in the dependent ables for changes Commit: 17262519a0195b8049c6e258e8ab70ad31da49ca https://github.com/buildbot/buildbot/commit/17262519a0195b8049c6e258e8ab70ad31da49ca Author: Dustin J. Mitchell Date: 2012-01-08 (Sun, 08 Jan 2012) Changed paths: M master/buildbot/test/util/db.py Log Message: ----------- be more lenient if the metadata fails to free tables in the right order Commit: ed74f73fefda9b27b8c0ab99bd8de93591bc7204 https://github.com/buildbot/buildbot/commit/ed74f73fefda9b27b8c0ab99bd8de93591bc7204 Author: Dustin J. Mitchell Date: 2012-01-08 (Sun, 08 Jan 2012) Changed paths: M master/buildbot/db/migrate/versions/018_add_sourcestampset.py M master/buildbot/db/model.py M master/buildbot/test/integration/test_upgrade.py M master/buildbot/test/unit/test_db_buildsets.py M master/buildbot/test/unit/test_db_changes.py M master/buildbot/test/util/db.py Log Message: ----------- Merge branch 'dbfixes' * dbfixes: be more lenient if the metadata fails to free tables in the right order include sourcestampsets in the dependent ables for changes sort column names when comparing indexes don't do a temporary table manually - let sqlalchemy-migrate do it as necessary honor foreign key references Compare: https://github.com/buildbot/buildbot/compare/6d54089...ed74f73 From noreply at github.com Mon Jan 9 05:22:23 2012 From: noreply at github.com (GitHub) Date: Sun, 08 Jan 2012 21:22:23 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] : actually create the indexes on buildsets in test s... Message-ID: <4f0a798f5226a_3cfe3fe94e7392f021875d@sh1.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 6b1eda5bb2d831e2de3590692e3ec0eb2092e8ee https://github.com/buildbot/buildbot/commit/6b1eda5bb2d831e2de3590692e3ec0eb2092e8ee Author: Dustin J. Mitchell Date: 2012-01-08 (Sun, 08 Jan 2012) Changed paths: M master/buildbot/test/unit/test_db_migrate_versions_018_add_sourcestampset.py Log Message: ----------- actually create the indexes on buildsets in test setup Commit: d95accc918dc9fdf1e307c2cba4a99967784c8d3 https://github.com/buildbot/buildbot/commit/d95accc918dc9fdf1e307c2cba4a99967784c8d3 Author: Jared Grubb Date: 2012-01-08 (Sun, 08 Jan 2012) Changed paths: M master/buildbot/steps/trigger.py M master/buildbot/test/unit/test_steps_trigger.py M master/docs/manual/cfg-buildsteps.rst M master/docs/release-notes.rst Log Message: ----------- Dont record the 'triggered_builds' statistic Commit: b11b843be4391eb33eef795222cf02245a42fe59 https://github.com/buildbot/buildbot/commit/b11b843be4391eb33eef795222cf02245a42fe59 Author: Jared Grubb Date: 2012-01-08 (Sun, 08 Jan 2012) Changed paths: M master/buildbot/test/unit/test_steps_trigger.py Log Message: ----------- Pushed too quickly; unit tests pass, pyflakes pass, docs build Commit: 3d8215933a4a4ee59e0ca238864f7408e0d9829b https://github.com/buildbot/buildbot/commit/3d8215933a4a4ee59e0ca238864f7408e0d9829b Author: Dustin J. Mitchell Date: 2012-01-08 (Sun, 08 Jan 2012) Changed paths: M master/buildbot/schedulers/triggerable.py M master/buildbot/status/master.py M master/buildbot/steps/trigger.py M master/buildbot/test/fake/fakedb.py M master/buildbot/test/unit/test_schedulers_triggerable.py M master/buildbot/test/unit/test_steps_trigger.py M master/docs/manual/cfg-buildsteps.rst M master/docs/release-notes.rst Log Message: ----------- Merge branch 'trigger-link-builds-2170' of git://github.com/jaredgrubb/buildbot * 'trigger-link-builds-2170' of git://github.com/jaredgrubb/buildbot: Pushed too quickly; unit tests pass, pyflakes pass, docs build Dont record the 'triggered_builds' statistic Trigger steps could link to triggered builds (fixes #2170) Conflicts: master/buildbot/test/fake/fakedb.py master/buildbot/test/unit/test_schedulers_triggerable.py Compare: https://github.com/buildbot/buildbot/compare/ed74f73...3d82159 From nobody at buildbot.net Mon Jan 9 05:22:30 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 09 Jan 2012 05:22:30 -0000 Subject: [Buildbot-commits] [Buildbot] #2170: Trigger steps could link to triggered builds In-Reply-To: <042.6e80a0d0bfe7fc7b121e773479357903@buildbot.net> References: <042.6e80a0d0bfe7fc7b121e773479357903@buildbot.net> Message-ID: <057.ec286af8921057af429115dacf6d3d79@buildbot.net> #2170: Trigger steps could link to triggered builds ------------------------+------------------------- Reporter: jaredgrubb | Owner: jaredgrubb Type: enhancement | Status: closed Priority: major | Milestone: 0.8.6 Version: 0.8.5 | Resolution: fixed Keywords: | ------------------------+------------------------- Changes (by Dustin J. Mitchell): * status: accepted => closed * resolution: => fixed Comment: Merge branch 'trigger-link-builds-2170' of git://github.com/jaredgrubb/buildbot * 'trigger-link-builds-2170' of git://github.com/jaredgrubb/buildbot: Pushed too quickly; unit tests pass, pyflakes pass, docs build Dont record the 'triggered_builds' statistic Trigger steps could link to triggered builds (fixes #2170) Conflicts: master/buildbot/test/fake/fakedb.py master/buildbot/test/unit/test_schedulers_triggerable.py Changeset: 3d8215933a4a4ee59e0ca238864f7408e0d9829b -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Tue Jan 10 22:24:31 2012 From: nobody at buildbot.net (Buildbot) Date: Tue, 10 Jan 2012 22:24:31 -0000 Subject: [Buildbot-commits] [Buildbot] #2172: View logfiles with html content Message-ID: <046.577de192eca2fd173afeaf22c78c133b@buildbot.net> #2172: View logfiles with html content ---------------------------+--------------------------- Reporter: materialdreams | Owner: Type: enhancement | Status: new Priority: minor | Milestone: undecided Version: 0.8.4p2 | Keywords: logfiles html ---------------------------+--------------------------- It seems as if it would not be possible to view a native html file when using the logfiles argument in a ShellCommand build step. It would be great to specify the type of the log file as html and by doing so allowing to see it the proper format. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Jan 11 05:04:06 2012 From: nobody at buildbot.net (Buildbot) Date: Wed, 11 Jan 2012 05:04:06 -0000 Subject: [Buildbot-commits] [Buildbot] #2126: buildbot try --properties=prop=value doesn't work with try_jobdir In-Reply-To: <035.99c90048ac5befbeb80a67a3e92d2cee@buildbot.net> References: <035.99c90048ac5befbeb80a67a3e92d2cee@buildbot.net> Message-ID: <050.4138d9ceb11b158907202e42dc84f0a0@buildbot.net> #2126: buildbot try --properties=prop=value doesn't work with try_jobdir -------------------+-------------------- Reporter: gg0 | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.6 Version: 0.8.5 | Resolution: Keywords: try | -------------------+-------------------- Comment (by dlatornell): I've explored this issue a bit. I can confirm that: {{{ buildbot try --connect=ssh --properties=abc=def,ghi=jkl ... }}} can trigger a build but the properties will not be passed to the builder. I was expecting to find that the properties had just been dropped somewhere along the chain of events, however, that's not what I found. In short, the properties option is not implemented for the try client when it is used in `ssh` mode; it's only there for `pb` mode. I think the `ssh` implementation would require handling of properties in the `createJobfile` function in `tryclient.py` and the `parseJob` and `handleJobFile` methods in `trysched.py`. The job file format will have to be extended to support key/value pairs. Unfortunately, I can't devote the time to implement this now. But I thought I should share my findings and opinions. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Jan 11 19:08:17 2012 From: nobody at buildbot.net (Buildbot) Date: Wed, 11 Jan 2012 19:08:17 -0000 Subject: [Buildbot-commits] [Buildbot] #2173: Add mail option "failure or change" Message-ID: <038.9466ce838746c9d9e406432d6a5c3f07@buildbot.net> #2173: Add mail option "failure or change" ------------------------+----------------------- Reporter: kwerle | Owner: Type: enhancement | Status: new Priority: trivial | Milestone: undecided Version: 0.8.5 | Keywords: ------------------------+----------------------- We would like to receive build notifications for all failures and changes to success. Right now buildbot supports either of those, but not both. One of: all - Send mail about all builds, both passing and failing change - Only send mail about builds which change status failing - Only send mail about builds which fail passing - Only send mail about builds which succeed problem - Only send mail about a build which failed when the previous build has passed. If your builds usually pass, then this will only send mail when a problem occurs. please add change or failing - Send email on all failing builds and also the change to success -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Thu Jan 12 13:32:46 2012 From: nobody at buildbot.net (Buildbot) Date: Thu, 12 Jan 2012 13:32:46 -0000 Subject: [Buildbot-commits] [Buildbot] #2174: Metrics require that db_poll_interval is set to a non-None value Message-ID: <038.c140c7147816d74fd828bf1ad0c9ae84@buildbot.net> #2174: Metrics require that db_poll_interval is set to a non-None value ----------------------+----------------------- Reporter: iustin | Owner: Type: undecided | Status: new Priority: minor | Milestone: undecided Version: 0.8.5 | Keywords: metrics ----------------------+----------------------- I'm following the docs for 0.8.5 and I've enabled the metrics system via: {{{ c['metrics'] = dict(log_interval=600, periodic_interval=10) }}} However, doing just this in a single-master setup results int: {{{ 2012-01-12 13:26:54+0000 [-] Log observer > failed. Traceback (most recent call last): ? File "/usr/local/lib/python2.6/dist- packages/buildbot-0.8.5-py2.6.egg/buildbot/process/metrics.py", line 286, in run if t < 0.8 * db_poll_interval: exceptions.TypeError: unsupported operand type(s) for *: 'float' and 'NoneType' }}} This is trivially fixable by adding a `db_poll_interval`, however I don't know if this affects anything in a single-master setup (and what should be the value). -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Thu Jan 12 15:55:39 2012 From: noreply at github.com (GitHub) Date: Thu, 12 Jan 2012 07:55:39 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] : Add fakemaster.py script to contrib Message-ID: <4f0f027b9b54a_5d7d3fe9f2ae9af4112990@sh1.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: e1b3b9f79672bf35ecf8fd2e21dc24856618c219 https://github.com/buildbot/buildbot/commit/e1b3b9f79672bf35ecf8fd2e21dc24856618c219 Author: Chris AtLee Date: 2012-01-12 (Thu, 12 Jan 2012) Changed paths: A master/contrib/fakemaster.py Log Message: ----------- Add fakemaster.py script to contrib fakemaster allows you to enter commands via stdin to a connected buildslave. From nobody at buildbot.net Fri Jan 13 04:19:43 2012 From: nobody at buildbot.net (Buildbot) Date: Fri, 13 Jan 2012 04:19:43 -0000 Subject: [Buildbot-commits] [Buildbot] #2172: View logfiles with html content In-Reply-To: <046.577de192eca2fd173afeaf22c78c133b@buildbot.net> References: <046.577de192eca2fd173afeaf22c78c133b@buildbot.net> Message-ID: <061.b57ec88acd519208ab316cf9192a6872@buildbot.net> #2172: View logfiles with html content ---------------------------+------------------------ Reporter: materialdreams | Owner: Type: enhancement | Status: closed Priority: minor | Milestone: undecided Version: 0.8.4p2 | Resolution: duplicate Keywords: logfiles html | ---------------------------+------------------------ Changes (by dustin): * status: new => closed * resolution: => duplicate Comment: See #371. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Jan 13 04:22:47 2012 From: nobody at buildbot.net (Buildbot) Date: Fri, 13 Jan 2012 04:22:47 -0000 Subject: [Buildbot-commits] [Buildbot] #2173: Add mail option "failure or change" In-Reply-To: <038.9466ce838746c9d9e406432d6a5c3f07@buildbot.net> References: <038.9466ce838746c9d9e406432d6a5c3f07@buildbot.net> Message-ID: <053.4f199b8238e27bf968b4c8ddc98db411@buildbot.net> #2173: Add mail option "failure or change" ------------------------+-------------------- Reporter: kwerle | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.9.+ Version: 0.8.5 | Resolution: Keywords: | ------------------------+-------------------- Changes (by dustin): * priority: trivial => minor * milestone: undecided => 0.9.+ Old description: > We would like to receive build notifications for all failures and changes > to success. Right now buildbot supports either of those, but not both. > > One of: > all - Send mail about all builds, both passing and failing > change - Only send mail about builds which change status > failing - Only send mail about builds which fail > passing - Only send mail about builds which succeed > problem - Only send mail about a build which failed when the previous > build has passed. If your builds usually pass, then this will only send > mail when a problem occurs. > > please add > change or failing - Send email on all failing builds and also the change > to success New description: We would like to receive build notifications for all failures and changes to success. Right now buildbot supports either of those, but not both. One of: * all - Send mail about all builds, both passing and failing * change - Only send mail about builds which change status * failing - Only send mail about builds which fail * passing - Only send mail about builds which succeed * problem - Only send mail about a build which failed when the previous build has passed. If your builds usually pass, then this will only send mail when a problem occurs. please add * change or failing - Send email on all failing builds and also the change to success -- -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Jan 13 04:26:35 2012 From: nobody at buildbot.net (Buildbot) Date: Fri, 13 Jan 2012 04:26:35 -0000 Subject: [Buildbot-commits] [Buildbot] #2174: Metrics require that db_poll_interval is set to a non-None value In-Reply-To: <038.c140c7147816d74fd828bf1ad0c9ae84@buildbot.net> References: <038.c140c7147816d74fd828bf1ad0c9ae84@buildbot.net> Message-ID: <053.447ff8e63c52576c4d0a3d47b6e08f35@buildbot.net> #2174: Metrics require that db_poll_interval is set to a non-None value -------------------+--------------------- Reporter: iustin | Owner: Type: defect | Status: closed Priority: minor | Milestone: 0.8.6 Version: 0.8.5 | Resolution: fixed Keywords: | -------------------+--------------------- Changes (by dustin): * keywords: metrics => * status: new => closed * type: undecided => defect * resolution: => fixed * milestone: undecided => 0.8.6 Comment: This is fixed for the next release, in {{{ commit b4fb9fbf2243db6d091202f58ced453483fecd29 Author: Dustin J. Mitchell Date: Sat Nov 12 00:32:16 2011 -0600 Refactor configuration handling This moves configuration loading and checking out of the master, and into a new module. Where possible, configuration is accessed directly in as many cases as possible, rather than being disseminated across the master at reconfiguration time. For services that need to modify their behavior when reconfigured, the ReconfigurableServiceMixin defines a general method of notification, eliminating service-specific code from the master. Schedulers are still stopped and re-started at every reconfiguration; this may be changed in the future. }}} -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Jan 13 12:32:37 2012 From: nobody at buildbot.net (Buildbot) Date: Fri, 13 Jan 2012 12:32:37 -0000 Subject: [Buildbot-commits] [Buildbot] #2174: Metrics require that db_poll_interval is set to a non-None value In-Reply-To: <038.c140c7147816d74fd828bf1ad0c9ae84@buildbot.net> References: <038.c140c7147816d74fd828bf1ad0c9ae84@buildbot.net> Message-ID: <053.f77cbf19317672fd86ae801fb62d0530@buildbot.net> #2174: Metrics require that db_poll_interval is set to a non-None value -------------------+--------------------- Reporter: iustin | Owner: Type: defect | Status: closed Priority: minor | Milestone: 0.8.6 Version: 0.8.5 | Resolution: fixed Keywords: | -------------------+--------------------- Comment (by iustin): Ah sorry. I searched for a similar bug before filling, but I didn't think of looking at the git repo. Thanks! -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Jan 13 13:29:53 2012 From: nobody at buildbot.net (Buildbot) Date: Fri, 13 Jan 2012 13:29:53 -0000 Subject: [Buildbot-commits] [Buildbot] #2175: Wrong ordering of next builds in the waterfall display? Message-ID: <038.9c7a061d295e764f4d61a2ccb884b307@buildbot.net> #2175: Wrong ordering of next builds in the waterfall display? ----------------------+----------------------- Reporter: iustin | Owner: Type: undecided | Status: new Priority: trivial | Milestone: undecided Version: 0.8.5 | Keywords: ----------------------+----------------------- Hi, I'm not entirely sure but I think there's a cosmetic bug in the waterfall display. I have some periodic builders and this is how the display looks: {{{ waiting next in ~ 18 hrs 56 mins at 08:00 next in ~ 2 hrs 56 mins at 16:00 next in ~ 10 hrs 56 mins at 00:00 }}} For another builder, it is: {{{ waiting next in ~ 20 hrs 56 mins at 10:00 next in ~ 4 hrs 56 mins at 18:00 next in ~ 12 hrs 56 mins at 02:00 }}} Normally I would expect these to be sorted in terms of start time, and not somewhat random (I can't find the logic here). I think this is due to the fact that in waterfally.py, the code does: {{{ for t in upcoming: if t is not None: eta = t - util.now() text.extend(self.formatETA("next in", eta)) }}} without ordering the upcoming list beforehand. Simply changing this to: {{{ for t in sorted(upcoming): ? }}} fixes the display for me, but I don't know if the upcoming list will always hold just integers so that sort makes sense. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Fri Jan 13 16:20:00 2012 From: noreply at github.com (GitHub) Date: Fri, 13 Jan 2012 08:20:00 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] : NEWS for fakemaster.py Message-ID: <4f1059b033fe6_1fbd3fde430bbaec17728a@sh1.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 25cee4360e57733816ab55cee3fc383abd0d9b90 https://github.com/buildbot/buildbot/commit/25cee4360e57733816ab55cee3fc383abd0d9b90 Author: Dustin J. Mitchell Date: 2012-01-12 (Thu, 12 Jan 2012) Changed paths: M master/docs/release-notes.rst Log Message: ----------- NEWS for fakemaster.py Commit: cda35a4edcc822b0169412e2ad17c75973050807 https://github.com/buildbot/buildbot/commit/cda35a4edcc822b0169412e2ad17c75973050807 Author: Dustin J. Mitchell Date: 2012-01-13 (Fri, 13 Jan 2012) Changed paths: M master/buildbot/db/pool.py M master/docs/manual/installation.rst M master/docs/release-notes.rst Log Message: ----------- be more forceful in sqlite version requirements Compare: https://github.com/buildbot/buildbot/compare/e1b3b9f...cda35a4 From noreply at github.com Fri Jan 13 17:20:40 2012 From: noreply at github.com (GitHub) Date: Fri, 13 Jan 2012 09:20:40 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] : correctly determine master and status in manhole Message-ID: <4f1067e851e03_59843ff6d7876af0881bc@sh1.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: a3287e9f5b9a6deb5cd18659c4805af456925ec4 https://github.com/buildbot/buildbot/commit/a3287e9f5b9a6deb5cd18659c4805af456925ec4 Author: Dustin J. Mitchell Date: 2012-01-13 (Fri, 13 Jan 2012) Changed paths: M master/buildbot/manhole.py Log Message: ----------- correctly determine master and status in manhole Commit: 010843731454b64c0b029425de280ce0f7a5772d https://github.com/buildbot/buildbot/commit/010843731454b64c0b029425de280ce0f7a5772d Author: Dustin J. Mitchell Date: 2012-01-13 (Fri, 13 Jan 2012) Changed paths: M master/buildbot/status/client.py Log Message: ----------- correctly determine status object in status client Commit: 259465bb7b486691e618c8328d55e0dac74ebf47 https://github.com/buildbot/buildbot/commit/259465bb7b486691e618c8328d55e0dac74ebf47 Author: Dustin J. Mitchell Date: 2012-01-13 (Fri, 13 Jan 2012) Changed paths: M master/buildbot/status/master.py Log Message: ----------- backward compatiblity for status clients to find the master status object Compare: https://github.com/buildbot/buildbot/compare/cda35a4...259465b From noreply at github.com Fri Jan 13 17:45:25 2012 From: noreply at github.com (GitHub) Date: Fri, 13 Jan 2012 09:45:25 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] 16302a: Merge pull request #297 from jaredgrubb/hide-in-wa... Message-ID: <4f106db569c1_661b3fd9233b6af071639@sh1.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 16302aded05a9619faed01c89cc01bde12f4141f https://github.com/buildbot/buildbot/commit/16302aded05a9619faed01c89cc01bde12f4141f Author: Tom Prince Date: 2012-01-13 (Fri, 13 Jan 2012) Changed paths: M master/buildbot/process/buildstep.py M master/buildbot/status/buildstep.py M master/buildbot/status/web/build.py M master/buildbot/status/web/waterfall.py M master/buildbot/test/unit/test_steps_shell.py M master/buildbot/test/util/steps.py M master/docs/developer/cls-buildsteps.rst M master/docs/manual/cfg-buildsteps.rst M master/docs/release-notes.rst Log Message: ----------- Merge pull request #297 from jaredgrubb/hide-in-waterfall Create option for a BuildStep to be suppressed if skipped (#1743) From noreply at github.com Fri Jan 13 23:37:11 2012 From: noreply at github.com (GitHub) Date: Fri, 13 Jan 2012 15:37:11 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] 8a78ee: fix reconfig priorities Message-ID: <4f10c0277c9ba_65e3f886d08eaf0437f3@sh1.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 8a78ee0fabe8704e1f8a443232ff7a01f1430630 https://github.com/buildbot/buildbot/commit/8a78ee0fabe8704e1f8a443232ff7a01f1430630 Author: Dustin J. Mitchell Date: 2012-01-13 (Fri, 13 Jan 2012) Changed paths: M master/buildbot/config.py M master/buildbot/test/unit/test_config.py Log Message: ----------- fix reconfig priorities The reconfig code was sorting services in the reverse of the direction the docs -- and all users of the priority -- indicated. From noreply at github.com Sat Jan 14 00:31:57 2012 From: noreply at github.com (GitHub) Date: Fri, 13 Jan 2012 16:31:57 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] 3c03fb: Allow DirectoryUploads to have renderable urls. Message-ID: <4f10ccfd95d73_8ec3f85969a62fc33473@sh1.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 3c03fb0ed753e33e3ab01e94ddcb37bedffc8cea https://github.com/buildbot/buildbot/commit/3c03fb0ed753e33e3ab01e94ddcb37bedffc8cea Author: Joshua Olson Date: 2012-01-13 (Fri, 13 Jan 2012) Changed paths: M master/buildbot/steps/transfer.py Log Message: ----------- Allow DirectoryUploads to have renderable urls. Commit: 175f874127a25e7d1e4a121b8a72aaac10ced9ab https://github.com/buildbot/buildbot/commit/175f874127a25e7d1e4a121b8a72aaac10ced9ab Author: Tom Prince Date: 2012-01-13 (Fri, 13 Jan 2012) Changed paths: M master/buildbot/steps/transfer.py Log Message: ----------- Merge pull request #299 from solarmist/patch-1 Allow DirectoryUploads to have renderable urls. Compare: https://github.com/buildbot/buildbot/compare/8a78ee0...175f874 From noreply at github.com Sat Jan 14 02:12:56 2012 From: noreply at github.com (GitHub) Date: Fri, 13 Jan 2012 18:12:56 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] fb9826: update docs to not suggest that masterdest='~/publ... Message-ID: <4f10e4a863670_8ec3f85969a62fc69781@sh1.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: fb9826e2266c9b7aa35118aac4564064b6611e38 https://github.com/buildbot/buildbot/commit/fb9826e2266c9b7aa35118aac4564064b6611e38 Author: Dustin J. Mitchell Date: 2012-01-13 (Fri, 13 Jan 2012) Changed paths: M master/docs/manual/cfg-buildsteps.rst Log Message: ----------- update docs to not suggest that masterdest='~/public_html' will work Commit: c3f44516ceaa7e4f6121fcc42e18a7159c11cc8e https://github.com/buildbot/buildbot/commit/c3f44516ceaa7e4f6121fcc42e18a7159c11cc8e Author: Dustin J. Mitchell Date: 2012-01-13 (Fri, 13 Jan 2012) Changed paths: M master/buildbot/test/unit/test_process_buildstep.py M master/buildbot/test/unit/test_steps_shell.py M master/buildbot/test/util/steps.py Log Message: ----------- move tests for doStepIf to BuildStep tests, rather than ShellCommand tests Commit: 34871410ff4440596807ce14c7010cdd6a83f70e https://github.com/buildbot/buildbot/commit/34871410ff4440596807ce14c7010cdd6a83f70e Author: Dustin J. Mitchell Date: 2012-01-13 (Fri, 13 Jan 2012) Changed paths: M master/buildbot/steps/transfer.py Log Message: ----------- Merge branch 'master' of github.com:buildbot/buildbot * 'master' of github.com:buildbot/buildbot: Allow DirectoryUploads to have renderable urls. Compare: https://github.com/buildbot/buildbot/compare/175f874...3487141 From noreply at github.com Sat Jan 14 02:26:26 2012 From: noreply at github.com (GitHub) Date: Fri, 13 Jan 2012 18:26:26 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] 4f60e2: set self.changes even with _ignoreChanges Message-ID: <4f10e7d2c2923_39c3fd5ef755af8103724@sh1.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 4f60e25e1bb85b7b8853f83b3af68607f9190026 https://github.com/buildbot/buildbot/commit/4f60e25e1bb85b7b8853f83b3af68607f9190026 Author: Dustin J. Mitchell Date: 2012-01-13 (Fri, 13 Jan 2012) Changed paths: M master/buildbot/sourcestamp.py Log Message: ----------- set self.changes even with _ignoreChanges From noreply at github.com Sat Jan 14 06:10:13 2012 From: noreply at github.com (GitHub) Date: Fri, 13 Jan 2012 22:10:13 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] 53a71c: update CREDITS from git history Message-ID: <4f111c456558b_7f43fc6247922f8938d0@sh1.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 53a71c981d009d0af69c2678af36142ae643fc26 https://github.com/buildbot/buildbot/commit/53a71c981d009d0af69c2678af36142ae643fc26 Author: Dustin J. Mitchell Date: 2012-01-13 (Fri, 13 Jan 2012) Changed paths: M master/CREDITS Log Message: ----------- update CREDITS from git history From noreply at github.com Sat Jan 14 20:21:33 2012 From: noreply at github.com (GitHub) Date: Sat, 14 Jan 2012 12:21:33 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] 85c525: add/fix comments in model.py Message-ID: <4f11e3cdb0aab_65e3f886d08eaf019345@sh1.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 85c52549e3a1467e1f3d37e77c0c25afddfbd7c6 https://github.com/buildbot/buildbot/commit/85c52549e3a1467e1f3d37e77c0c25afddfbd7c6 Author: Dustin J. Mitchell Date: 2012-01-13 (Fri, 13 Jan 2012) Changed paths: M master/buildbot/db/model.py Log Message: ----------- add/fix comments in model.py Commit: aa33b96aa03070a63490351dd0f0e232092965b0 https://github.com/buildbot/buildbot/commit/aa33b96aa03070a63490351dd0f0e232092965b0 Author: Dustin J. Mitchell Date: 2012-01-14 (Sat, 14 Jan 2012) Changed paths: M master/buildbot/db/__init__.py M master/buildbot/db/buildsets.py A master/buildbot/db/migrate/versions/019_merge_schedulers_to_objects.py M master/buildbot/db/model.py M master/buildbot/db/schedulers.py M master/buildbot/schedulers/base.py M master/buildbot/schedulers/basic.py M master/buildbot/schedulers/dependent.py M master/buildbot/schedulers/manager.py M master/buildbot/schedulers/timed.py M master/buildbot/test/fake/fakedb.py M master/buildbot/test/unit/test_db_buildsets.py M master/buildbot/test/unit/test_db_changes.py A master/buildbot/test/unit/test_db_migrate_versions_019_merge_schedulers_to_objects.py M master/buildbot/test/unit/test_db_schedulers.py M master/buildbot/test/unit/test_schedulers_base.py M master/buildbot/test/unit/test_schedulers_basic.py M master/buildbot/test/unit/test_schedulers_dependent.py M master/buildbot/test/unit/test_schedulers_forcesched.py M master/buildbot/test/unit/test_schedulers_manager.py M master/buildbot/test/unit/test_schedulers_timed_Nightly.py M master/buildbot/test/unit/test_schedulers_timed_Timed.py M master/buildbot/test/unit/test_schedulers_triggerable.py M master/buildbot/test/unit/test_schedulers_trysched.py M master/buildbot/test/util/scheduler.py M master/docs/developer/database.rst M master/docs/release-notes.rst Log Message: ----------- Simplify scheduler-related DB schema Schedulers identities are now tracked as objects, rather than with a distinct table -- so the 'schedulers' table is gone. The Dependent scheduler no longer has a dedicated table to keep track of upstream buildsets. This is handled with object state, instead. So the 'scheduler_upstream_buildsets' table is gone, too. Compare: https://github.com/buildbot/buildbot/compare/53a71c9...aa33b96 From noreply at github.com Sat Jan 14 20:42:53 2012 From: noreply at github.com (GitHub) Date: Sat, 14 Jan 2012 12:42:53 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] 3fbea2: don't use sa.Boolean Message-ID: <4f11e8cd4208b_40913fcfcc9722ec1362d0@sh1.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 3fbea2a2f85e315e49d9917834619742ebb776e5 https://github.com/buildbot/buildbot/commit/3fbea2a2f85e315e49d9917834619742ebb776e5 Author: Dustin J. Mitchell Date: 2012-01-14 (Sat, 14 Jan 2012) Changed paths: M master/buildbot/db/migrate/versions/019_merge_schedulers_to_objects.py M master/buildbot/db/model.py Log Message: ----------- don't use sa.Boolean From nobody at buildbot.net Mon Jan 16 03:54:30 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 16 Jan 2012 03:54:30 -0000 Subject: [Buildbot-commits] [Buildbot] #2122: Race condition causes error describing step In-Reply-To: <037.bae614ef17847763cea74c9cb0e1a868@buildbot.net> References: <037.bae614ef17847763cea74c9cb0e1a868@buildbot.net> Message-ID: <052.3ce19467a5d1e6884b3fd89c96a2c273@buildbot.net> #2122: Race condition causes error describing step -------------------+-------------------- Reporter: tmidd | Owner: Type: defect | Status: new Priority: minor | Milestone: 0.8.6 Version: 0.8.5 | Resolution: Keywords: | -------------------+-------------------- Comment (by seb_kuzminsky): I get this same traceback. It seems to happen when I run a SetProperty() buildstep that has a WithProperties() for a command. I'm on 0.8.5, on Ubuntu Precise 12.04 Alpha, fwiw. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Jan 16 04:35:52 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 16 Jan 2012 04:35:52 -0000 Subject: [Buildbot-commits] [Buildbot] #2122: Race condition causes error describing step In-Reply-To: <037.bae614ef17847763cea74c9cb0e1a868@buildbot.net> References: <037.bae614ef17847763cea74c9cb0e1a868@buildbot.net> Message-ID: <052.bae4969494144ac79959f4875b110be4@buildbot.net> #2122: Race condition causes error describing step -------------------+-------------------- Reporter: tmidd | Owner: Type: defect | Status: new Priority: minor | Milestone: 0.8.6 Version: 0.8.5 | Resolution: Keywords: | -------------------+-------------------- Comment (by dustin): Does that WithProperties reference something that the SetProperty should set? -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Jan 16 13:02:26 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 16 Jan 2012 13:02:26 -0000 Subject: [Buildbot-commits] [Buildbot] #2176: buildslave hangs trying to kill process after "1200 seconds without output" Message-ID: <036.b16b7bc9de52fc28c23a1d1e44d26fb4@buildbot.net> #2176: buildslave hangs trying to kill process after "1200 seconds without output" ----------------------+----------------------- Reporter: hjwp | Owner: Type: undecided | Status: new Priority: major | Milestone: undecided Version: 0.8.5 | Keywords: ----------------------+----------------------- The buildbot logs show the usual message: `command timed out: 1200 seconds without output, attempting to kill` looking at the console window of the machine that's running the buildslave.bat, we see a message: `ERROR: The process "None" not found.` Do you know where this message is coming from? Could it be that buildbot is trying to kill a process that's already died? It seems that the "attempting to kill" message is the last one that makes it to the logs - Looking through the code in `runprocess.py`, that doesn't make any sense - it seems to me that there's no way of getting through that function without hitting at least one other `log.msg` call... weird. anyway, this hangs the build, and we're forced to go in and reboot the buildslave machine. that then produces one final line in the logs: `remoteFailed: [Failure instance: Traceback (failure with no frames): : Connection to the other side was lost in a non-clean fashion.]` No doubt we should try and write better test code that doesn't cause the 1200 second timeout, but still, it would be good if buildbot didn't hang... additional info: * buildbot-master is running on debian * buildslave is running windows vista * seems to be an intermittent problem - maybe one in 5 runs? * we're using buildslave to run selenium webdriver tests, driven from python 2.7 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Jan 16 22:10:27 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 16 Jan 2012 22:10:27 -0000 Subject: [Buildbot-commits] [Buildbot] #2045: Implicit limit of 1000 builders per slave In-Reply-To: <035.55d811d1be045ddf3ef52ca4764c3b95@buildbot.net> References: <035.55d811d1be045ddf3ef52ca4764c3b95@buildbot.net> Message-ID: <050.fe2ca4b1313f1a512344ee7d25253eda@buildbot.net> #2045: Implicit limit of 1000 builders per slave ------------------------+-------------------- Reporter: xrg | Owner: Type: defect | Status: new Priority: minor | Milestone: 0.8.+ Version: 0.8.4 | Resolution: Keywords: performance | ------------------------+-------------------- Comment (by armenzg): We might be hitting the same issue in https://bugzilla.mozilla.org/show_bug.cgi?id=712244 Can the PB limit be increased? 2011-12-16 18:22:01-0800 [Broker,client] ReconnectingPBClientFactory.failedToGetPerspective 2011-12-16 18:22:01-0800 [Broker,client] While trying to connect: Traceback from remote host -- Traceback (most recent call last): File "/builds/buildbot/tests1-windows/lib/python2.6/site- packages/twisted/internet/defer.py", line 363, in unpause self._runCallbacks() File "/builds/buildbot/tests1-windows/lib/python2.6/site- packages/twisted/internet/defer.py", line 441, in _runCallbacks self.result = callback(self.result, *args, **kw) File "/builds/buildbot/tests1-windows/lib/python2.6/site- packages/twisted/internet/defer.py", line 397, in _continue self.unpause() File "/builds/buildbot/tests1-windows/lib/python2.6/site- packages/twisted/internet/defer.py", line 363, in unpause self._runCallbacks() --- --- File "/builds/buildbot/tests1-windows/lib/python2.6/site- packages/twisted/internet/defer.py", line 441, in _runCallbacks self.result = callback(self.result, *args, **kw) File "/builds/buildbot/tests1-windows/lib/python2.6/site- packages/twisted/spread/pb.py", line 763, in serialize return jelly(object, self.security, None, self) File "/builds/buildbot/tests1-windows/lib/python2.6/site- packages/twisted/spread/jelly.py", line 1122, in jelly return _Jellier(taster, persistentStore, invoker).jelly(object) File "/builds/buildbot/tests1-windows/lib/python2.6/site- packages/twisted/spread/jelly.py", line 475, in jelly return obj.jellyFor(self) File "/builds/buildbot/tests1-windows/lib/python2.6/site- packages/twisted/spread/flavors.py", line 127, in jellyFor return "remote", jellier.invoker.registerReference(self) File "/builds/buildbot/tests1-windows/lib/python2.6/site- packages/twisted/spread/pb.py", line 664, in registerReference raise Error("Maximum PB reference count exceeded. " twisted.spread.pb.Error: Maximum PB reference count exceeded. Goodbye. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Tue Jan 17 00:26:51 2012 From: nobody at buildbot.net (Buildbot) Date: Tue, 17 Jan 2012 00:26:51 -0000 Subject: [Buildbot-commits] [Buildbot] #2045: Implicit limit of 1000 builders per slave In-Reply-To: <035.55d811d1be045ddf3ef52ca4764c3b95@buildbot.net> References: <035.55d811d1be045ddf3ef52ca4764c3b95@buildbot.net> Message-ID: <050.1e76d58c4917aef18b4a2f60c8f30e37@buildbot.net> #2045: Implicit limit of 1000 builders per slave ------------------------+-------------------- Reporter: xrg | Owner: Type: defect | Status: new Priority: minor | Milestone: 0.8.+ Version: 0.8.4 | Resolution: Keywords: performance | ------------------------+-------------------- Comment (by dustin): Well, the value to patch is here: http://twistedmatrix.com/trac/browser/trunk/twisted/spread/pb.py#L72 so you can monkey-patch that fairly easily at runtime: {{{ from twisted.spread import pb pb.MAX_BROKER_REFS = 2048 }}} I don't necessarily think that's a good idea! I'll leave this bug open to track finding a better solution that doesn't burden PB with so many references. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Tue Jan 17 02:27:27 2012 From: nobody at buildbot.net (Buildbot) Date: Tue, 17 Jan 2012 02:27:27 -0000 Subject: [Buildbot-commits] [Buildbot] #2122: Race condition causes error describing step In-Reply-To: <037.bae614ef17847763cea74c9cb0e1a868@buildbot.net> References: <037.bae614ef17847763cea74c9cb0e1a868@buildbot.net> Message-ID: <052.5d3c74c645f4f6c894faa7314655c9a9@buildbot.net> #2122: Race condition causes error describing step -------------------+-------------------- Reporter: tmidd | Owner: Type: defect | Status: new Priority: minor | Milestone: 0.8.6 Version: 0.8.5 | Resolution: Keywords: | -------------------+-------------------- Comment (by seb_kuzminsky): Replying to [comment:3 dustin]: > Does that WithProperties reference something that the SetProperty should set? I have two SetProperty() calls that have trouble; one tries to use the property it sets and one doesn't. Here's the one that uses its own property: {{{ set_property_branch = shell.SetProperty( command = WithProperties('if [ ! -z "%(branch)s" ]; then echo %(branch)s; else echo master; fi'), property = 'branch', haltOnFailure = 1 ) }}} And here's the one that doesn't: {{{ def get_version_extractor(rc, stdout, stderr): s = stdout.strip() if s == '': return None # how do you report error from an extract_fn? return { 'version': s } set_property_version = shell.SetProperty( command = WithProperties("scripts/get-version-from-git %(branch)s"), extract_fn = get_version_extractor, haltOnFailure = 1 ) }}} -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Tue Jan 17 03:29:27 2012 From: nobody at buildbot.net (Buildbot) Date: Tue, 17 Jan 2012 03:29:27 -0000 Subject: [Buildbot-commits] [Buildbot] #2122: Race condition causes error describing step In-Reply-To: <037.bae614ef17847763cea74c9cb0e1a868@buildbot.net> References: <037.bae614ef17847763cea74c9cb0e1a868@buildbot.net> Message-ID: <052.d4a77dcc4ae398a872dbeabca2efd297@buildbot.net> #2122: Race condition causes error describing step -------------------+-------------------- Reporter: tmidd | Owner: Type: defect | Status: new Priority: minor | Milestone: 0.8.6 Version: 0.8.5 | Resolution: Keywords: | -------------------+-------------------- Comment (by seb_kuzminsky): Here is my master config, and two relevant twistd.logs: http://highlab.com/~seb/buildbot-2122/ At 2012-01-13 09:00:47-0700 in [http://highlab.com/~seb/buildbot-2122/twistd.log.2 twistd.log.2], there's a traceback from the first SetProperty(). Then at 2012-01-13 09:01:44-0700 in the same log there's a traceback from the second SetProperty(). -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Tue Jan 17 03:46:37 2012 From: nobody at buildbot.net (Buildbot) Date: Tue, 17 Jan 2012 03:46:37 -0000 Subject: [Buildbot-commits] [Buildbot] #2177: Trigger goes out to lunch and never comes back! Message-ID: <045.a0c9ec445e31cd17ee70f017d7e4b177@buildbot.net> #2177: Trigger goes out to lunch and never comes back! --------------------------+----------------------- Reporter: seb_kuzminsky | Owner: Type: undecided | Status: new Priority: major | Milestone: undecided Version: 0.8.5 | Keywords: --------------------------+----------------------- Hi there, i run a buildbot for the [http://linuxcnc.org LinuxCNC] project. Buildbot has been great for us, so first of all thanks! I recently upgraded my buildmaster from Buildbot 0.7.12 running on Ubuntu Lucid to Buildbot 0.8.5 running on Ubuntu Precise, and now i have a strange new problem. First of all, my buildmaster config and a couple of relevant logs are here: http://highlab.com/~seb/buildbot-2122/ As you can see, my master config has a scheduler watching our git repo, and a post-update hook in our repo kicks off the 'checkin' builder. 'checkin' triggers a build-and-test scheduler, and if that passes it next triggers a couple of packaging and docs-building schedulers. This setup used to work great with 0.7.12, but since the upgrade to 0.8.5 i get occasional hangs. The first Trigger does its thing and returns to the checkin builder, which then runs the second Triggers (which triggers several schedulers). The second round of schedulers all run and do their thing, but the 'checkin' builds' second Trigger buildstep never returns! The waterfall shows all triggered builds completed, but the triggering build is still yellow and waiting for something. If i stop and restart the buildbot, it picks right up and begins the next pending build. Here's a recent run where this happened: http://buildbot.linuxcnc.org/buildbot/builders/checkin/builds/88 I spoke with tomprince on #buildbot about this issue (and about issue #2122) recently, and he was able to reproduce the hang: {{{ seb_kuzminsky: I can reproduce it locally: https://github.com/tomprince/buildbot-configs/tree/test It took about 292 builds, while refreshing the webstatus page. :) }}} I'll be happy to do whatever debugging or testing i can to help resolve this issue. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Tue Jan 17 04:00:35 2012 From: noreply at github.com (GitHub) Date: Mon, 16 Jan 2012 20:00:35 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] 450778: Changed default port to connect to PBChangeListene... Message-ID: <4f14f26365b55_5c7f3fe886be82ec12163f@sh1.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 45077871c412f842206d742c6540ab9412c6c070 https://github.com/buildbot/buildbot/commit/45077871c412f842206d742c6540ab9412c6c070 Author: William Deegan Date: 2012-01-16 (Mon, 16 Jan 2012) Changed paths: M master/contrib/bitbucket_buildbot.py Log Message: ----------- Changed default port to connect to PBChangeListener to 9999 (from 9989 which is the 'normal' slave connection port. Added some debug logging when trying to connect to bb master Commit: 3387577ac8de193556102bcaa2a3afa70b7a4d37 https://github.com/buildbot/buildbot/commit/3387577ac8de193556102bcaa2a3afa70b7a4d37 Author: William Deegan Date: 2012-01-16 (Mon, 16 Jan 2012) Changed paths: M master/contrib/bitbucket_buildbot.py Log Message: ----------- just improve logging. Don't change default port Commit: 1fc38776c288c409663c2814475d56e69d5db134 https://github.com/buildbot/buildbot/commit/1fc38776c288c409663c2814475d56e69d5db134 Author: Tom Prince Date: 2012-01-16 (Mon, 16 Jan 2012) Changed paths: M master/contrib/bitbucket_buildbot.py Log Message: ----------- Merge pull request #300 from bdbaddog/fix_bb_script_1 Changed default port to connect to PBChangeListener to 9999 Compare: https://github.com/buildbot/buildbot/compare/3fbea2a...1fc3877 From nobody at buildbot.net Tue Jan 17 15:57:17 2012 From: nobody at buildbot.net (Buildbot) Date: Tue, 17 Jan 2012 15:57:17 -0000 Subject: [Buildbot-commits] [Buildbot] #2110: New SVN checkout step does not respect workdir when using full mode and copy method In-Reply-To: <042.2246a41c8b1a4e13b60fdad8042854d7@buildbot.net> References: <042.2246a41c8b1a4e13b60fdad8042854d7@buildbot.net> Message-ID: <057.2d6afc96354ff992a5f42a86d61b46c9@buildbot.net> #2110: New SVN checkout step does not respect workdir when using full mode and copy method -----------------------+--------------------- Reporter: garmstrong | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.6 Version: 0.8.5 | Resolution: fixed Keywords: svn | -----------------------+--------------------- Changes (by dustin): * status: new => closed * resolution: => fixed Comment: Ah, the bug is actually in sourcestamp.py. getAbsoluteSourceStamp passes _ignoreChanges so that the revision, branch, etc. are not set from the changes -- however, that is taken to mean that changes should not be kept at all, which is incorrect. {{{ #!patch commit 4f60e25e1bb85b7b8853f83b3af68607f9190026 Author: Dustin J. Mitchell Date: Fri Jan 13 20:25:31 2012 -0600 set self.changes even with _ignoreChanges diff --git a/master/buildbot/sourcestamp.py b/master/buildbot/sourcestamp.py index e7c3fb9..a81ef56 100644 --- a/master/buildbot/sourcestamp.py +++ b/master/buildbot/sourcestamp.py @@ -145,8 +145,9 @@ class SourceStamp(util.ComparableMixin, styles.Versioned): self.patch_info = patch_info self.project = project or '' self.repository = repository or '' - if changes and not _ignoreChanges: + if changes: self.changes = tuple(changes) + if changes and not _ignoreChanges: # set branch and revision to most recent change self.branch = changes[-1].branch revision = changes[-1].revision }}} -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Tue Jan 17 16:03:39 2012 From: nobody at buildbot.net (Buildbot) Date: Tue, 17 Jan 2012 16:03:39 -0000 Subject: [Buildbot-commits] [Buildbot] #2111: Triggerable sheduler does not inherit Blamelist or Changes from upstream timed.Nightly scheduler In-Reply-To: <042.88390c604c1552229eaef3bcca93281a@buildbot.net> References: <042.88390c604c1552229eaef3bcca93281a@buildbot.net> Message-ID: <057.8a15286e2058128c2b391121a268ca82@buildbot.net> #2111: Triggerable sheduler does not inherit Blamelist or Changes from upstream timed.Nightly scheduler -----------------------+--------------------- Reporter: garmstrong | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.6 Version: 0.8.5 | Resolution: fixed Keywords: | -----------------------+--------------------- Changes (by dustin): * status: new => closed * resolution: => fixed Comment: Ah, the bug is actually in sourcestamp.py. getAbsoluteSourceStamp passes _ignoreChanges so that the revision, branch, etc. are not set from the changes -- however, that is taken to mean that changes should not be kept at all, which is incorrect. {{{ #!patch commit 4f60e25e1bb85b7b8853f83b3af68607f9190026 Author: Dustin J. Mitchell Date: Fri Jan 13 20:25:31 2012 -0600 set self.changes even with _ignoreChanges diff --git a/master/buildbot/sourcestamp.py b/master/buildbot/sourcestamp.py index e7c3fb9..a81ef56 100644 --- a/master/buildbot/sourcestamp.py +++ b/master/buildbot/sourcestamp.py @@ -145,8 +145,9 @@ class SourceStamp(util.ComparableMixin, styles.Versioned): self.patch_info = patch_info self.project = project or '' self.repository = repository or '' - if changes and not _ignoreChanges: + if changes: self.changes = tuple(changes) + if changes and not _ignoreChanges: # set branch and revision to most recent change self.branch = changes[-1].branch revision = changes[-1].revision }}} -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Wed Jan 18 04:43:48 2012 From: noreply at github.com (GitHub) Date: Tue, 17 Jan 2012 20:43:48 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] 8e8e43: Sort next builds in waterfall Message-ID: <4f164e04372b5_135d3fc78dc36aec71778@sh1.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 8e8e43e38c93bc6ad5c3dcd2f11231690c332d6b https://github.com/buildbot/buildbot/commit/8e8e43e38c93bc6ad5c3dcd2f11231690c332d6b Author: Iustin Pop Date: 2012-01-17 (Tue, 17 Jan 2012) Changed paths: M master/buildbot/status/web/waterfall.py Log Message: ----------- Sort next builds in waterfall Fixes #2175. From nobody at buildbot.net Wed Jan 18 04:43:55 2012 From: nobody at buildbot.net (Buildbot) Date: Wed, 18 Jan 2012 04:43:55 -0000 Subject: [Buildbot-commits] [Buildbot] #2175: Wrong ordering of next builds in the waterfall display? In-Reply-To: <038.9c7a061d295e764f4d61a2ccb884b307@buildbot.net> References: <038.9c7a061d295e764f4d61a2ccb884b307@buildbot.net> Message-ID: <053.9b338b1ed93a4716f09ac3d0c13524b8@buildbot.net> #2175: Wrong ordering of next builds in the waterfall display? ----------------------+------------------------ Reporter: iustin | Owner: Type: undecided | Status: closed Priority: trivial | Milestone: undecided Version: 0.8.5 | Resolution: fixed Keywords: | ----------------------+------------------------ Changes (by Iustin Pop): * status: new => closed * resolution: => fixed Comment: Sort next builds in waterfall Fixes #2175. Changeset: 8e8e43e38c93bc6ad5c3dcd2f11231690c332d6b -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Jan 18 05:04:59 2012 From: nobody at buildbot.net (Buildbot) Date: Wed, 18 Jan 2012 05:04:59 -0000 Subject: [Buildbot-commits] [Buildbot] #2176: buildslave hangs trying to kill process after "1200 seconds without output" In-Reply-To: <036.b16b7bc9de52fc28c23a1d1e44d26fb4@buildbot.net> References: <036.b16b7bc9de52fc28c23a1d1e44d26fb4@buildbot.net> Message-ID: <051.6da06632ce268e0415a5eaab2af69774@buildbot.net> #2176: buildslave hangs trying to kill process after "1200 seconds without output" --------------------+-------------------- Reporter: hjwp | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.5 | Resolution: Keywords: windows | --------------------+-------------------- Changes (by dustin): * keywords: => windows * type: undecided => defect * milestone: undecided => 0.8.+ Comment: What version is running on the slave? There have been problems killing processes on Windows, and sadly we haven't had anyone with enough Windows savvy step up to fix them. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Jan 18 05:52:48 2012 From: nobody at buildbot.net (Buildbot) Date: Wed, 18 Jan 2012 05:52:48 -0000 Subject: [Buildbot-commits] [Buildbot] #2122: Race condition causes error describing step In-Reply-To: <037.bae614ef17847763cea74c9cb0e1a868@buildbot.net> References: <037.bae614ef17847763cea74c9cb0e1a868@buildbot.net> Message-ID: <052.5cc763ecae79c08c5d3144ccd49e46ad@buildbot.net> #2122: Race condition causes error describing step -------------------+-------------------- Reporter: tmidd | Owner: Type: defect | Status: new Priority: minor | Milestone: 0.8.6 Version: 0.8.5 | Resolution: Keywords: | -------------------+-------------------- Comment (by dustin): Sorry, my question in comment 3 was bogus -- it doesn't matter. I think that the fix for this is to note when the step is rendered, and then use self.build.render in describe if the command hasn't been rendered yet. This may result in incorrect descriptions while the build is still running, but I think that's an acceptable problem -- what else could we do? -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Jan 18 18:43:22 2012 From: nobody at buildbot.net (Buildbot) Date: Wed, 18 Jan 2012 18:43:22 -0000 Subject: [Buildbot-commits] [Buildbot] #2176: buildslave hangs trying to kill process after "1200 seconds without output" In-Reply-To: <036.b16b7bc9de52fc28c23a1d1e44d26fb4@buildbot.net> References: <036.b16b7bc9de52fc28c23a1d1e44d26fb4@buildbot.net> Message-ID: <051.f9796299a8ffca625a85b27727fb457e@buildbot.net> #2176: buildslave hangs trying to kill process after "1200 seconds without output" --------------------+-------------------- Reporter: hjwp | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.5 | Resolution: Keywords: windows | --------------------+-------------------- Comment (by hjwp): It is running on 0.8.5. The really weird thing is that it doesn't log anything at all after the "attempting to kill" message. From my reading of the source in runprocess.py, that must mean it's crashing inside `self.sendStatus`?? -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Jan 18 18:54:23 2012 From: nobody at buildbot.net (Buildbot) Date: Wed, 18 Jan 2012 18:54:23 -0000 Subject: [Buildbot-commits] [Buildbot] #2176: buildslave hangs trying to kill process after "1200 seconds without output" In-Reply-To: <036.b16b7bc9de52fc28c23a1d1e44d26fb4@buildbot.net> References: <036.b16b7bc9de52fc28c23a1d1e44d26fb4@buildbot.net> Message-ID: <051.c1f0757bfa0c53ab6bb23ca361f53d0a@buildbot.net> #2176: buildslave hangs trying to kill process after "1200 seconds without output" --------------------+-------------------- Reporter: hjwp | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.5 | Resolution: Keywords: windows | --------------------+-------------------- Comment (by dustin): I agree, that is very strange. This sounds like the {{{sendStatus}}} call completes -- the message arrives on the master, at any rate. The "None" error you're seeing indicates that it's trying to kill something - presumably either TASKKILL or {{{process.signalProcess}}. But you're right -- I don't see how it could get there without logging. Unless logging is somehow buffered on Windows? Perhaps, try adding additional logging calls to {{{runprocess.py}}}? -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Jan 18 22:08:36 2012 From: nobody at buildbot.net (Buildbot) Date: Wed, 18 Jan 2012 22:08:36 -0000 Subject: [Buildbot-commits] [Buildbot] #2178: buildSetSummary=True for MailNotifier exceptions.AttributeError: Status instance has no attribute 'subscribeToBuildsetCompletions' Message-ID: <040.1ab0627bf600c79daa0aa74421c03003@buildbot.net> #2178: buildSetSummary=True for MailNotifier exceptions.AttributeError: Status instance has no attribute 'subscribeToBuildsetCompletions' ---------------------+-------------------------- Reporter: kevbroch | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: master | Keywords: mail, status ---------------------+-------------------------- Setting this in my master.cfg as and getting the following error: from buildbot.status.mail import MailNotifier mn = MailNotifier(fromaddr="buildbot at example.org", buildSetSummary=True, ) c['status'].append(mn) File "/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site- packages/buildbot-0.8.5_322_g8e8e43e-py2.7.egg/buildbot/status/mail.py", line 359, in startService self.parent.subscribeToBuildsetCompletions(self.buildsetFinished) exceptions.AttributeError: Status instance has no attribute 'subscribeToBuildsetCompletions' 2012-01-18 13:58:52-0800 [-] WARNING: reconfig partially applied; master may malfunction -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Jan 18 23:45:56 2012 From: nobody at buildbot.net (Buildbot) Date: Wed, 18 Jan 2012 23:45:56 -0000 Subject: [Buildbot-commits] [Buildbot] #1778: Add a way of specifying a revlink from GitPoller. In-Reply-To: <042.1104c30bf7a031e1c00e179c3d86d887@buildbot.net> References: <042.1104c30bf7a031e1c00e179c3d86d887@buildbot.net> Message-ID: <057.ae079cd5817137938b6810beb9cb85f8@buildbot.net> #1778: Add a way of specifying a revlink from GitPoller. ------------------------+---------------------- Reporter: tom.prince | Owner: Type: enhancement | Status: closed Priority: major | Milestone: 0.8.6 Version: 0.8.3p1 | Resolution: wontfix Keywords: git | ------------------------+---------------------- Changes (by tom.prince): * status: new => closed * resolution: => wontfix Comment: Specifying revlinks for changes is deprecated. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Thu Jan 19 03:45:42 2012 From: nobody at buildbot.net (Buildbot) Date: Thu, 19 Jan 2012 03:45:42 -0000 Subject: [Buildbot-commits] [Buildbot] #2149: "Stop build" button cannot kill dependent schedule In-Reply-To: <035.16ba8e8d373d7917569116956748908b@buildbot.net> References: <035.16ba8e8d373d7917569116956748908b@buildbot.net> Message-ID: <050.2535d53a24da3ac786522b6e8f4caecc@buildbot.net> #2149: "Stop build" button cannot kill dependent schedule --------------------+------------------------ Reporter: pwp | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.4p2 | Resolution: Keywords: | --------------------+------------------------ Changes (by tom.prince): * cc: tom.prince@? (added) * milestone: 0.8.6 => undecided Comment: I am not entirely sure what you are expecting to happens vs. what is actually happening. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Thu Jan 19 03:49:56 2012 From: nobody at buildbot.net (Buildbot) Date: Thu, 19 Jan 2012 03:49:56 -0000 Subject: [Buildbot-commits] [Buildbot] #899: AttributeError on reconfig In-Reply-To: <038.004033e7a6e0b558a7ebbad5fce7ba59@buildbot.net> References: <038.004033e7a6e0b558a7ebbad5fce7ba59@buildbot.net> Message-ID: <053.6ce94889826aae87df0aa3bd69004cf9@buildbot.net> #899: AttributeError on reconfig ------------------------------+-------------------- Reporter: catlee | Owner: Type: defect | Status: new Priority: critical | Milestone: 0.8.+ Version: 0.8.0 | Resolution: Keywords: database reconfig | ------------------------------+-------------------- Comment (by tom.prince): I suspect this may be at least partially fixed by the new config system. I suggest closing this, on the assumption that it has. We can then open a new bug, if the new system exhibits similar errors. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Thu Jan 19 14:10:00 2012 From: nobody at buildbot.net (Buildbot) Date: Thu, 19 Jan 2012 14:10:00 -0000 Subject: [Buildbot-commits] [Buildbot] #2179: Test Suite fails to detect missing 'yield wfd; res = wfd.getResult()' in build step tests. Message-ID: <042.a4a888721a06040f079b4ceb4aa1e771@buildbot.net> #2179: Test Suite fails to detect missing 'yield wfd; res = wfd.getResult()' in build step tests. -----------------------+----------------------- Reporter: tom.prince | Owner: Type: defect | Status: new Priority: minor | Milestone: undecided Version: master | Keywords: -----------------------+----------------------- -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Thu Jan 19 15:03:41 2012 From: nobody at buildbot.net (Buildbot) Date: Thu, 19 Jan 2012 15:03:41 -0000 Subject: [Buildbot-commits] [Buildbot] #1743: Create option for a BuildStep to be suppressed if skipped In-Reply-To: <042.4f4da741f4c5a452909182e887b421e6@buildbot.net> References: <042.4f4da741f4c5a452909182e887b421e6@buildbot.net> Message-ID: <057.ca6c7cc00d831e3a73b78229d215a052@buildbot.net> #1743: Create option for a BuildStep to be suppressed if skipped ------------------------+------------------------- Reporter: Sly_Squash | Owner: jaredgrubb Type: enhancement | Status: closed Priority: trivial | Milestone: 0.8.6 Version: 0.8.2 | Resolution: fixed Keywords: web | ------------------------+------------------------- Changes (by tom.prince): * status: accepted => closed * resolution: => fixed Comment: Fixed in 16302aded05a9619faed01c89cc01bde12f4141f -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Thu Jan 19 15:07:54 2012 From: nobody at buildbot.net (Buildbot) Date: Thu, 19 Jan 2012 15:07:54 -0000 Subject: [Buildbot-commits] [Buildbot] #2123: Changes sent over the wire should be compressed In-Reply-To: <036.8cceb3fe6a6edabb86fbef518ee3826f@buildbot.net> References: <036.8cceb3fe6a6edabb86fbef518ee3826f@buildbot.net> Message-ID: <051.96f931f30de0fb21c00512bb83002a5a@buildbot.net> #2123: Changes sent over the wire should be compressed ------------------------+-------------------- Reporter: dank | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.6 Version: 0.8.5 | Resolution: Keywords: | ------------------------+-------------------- Comment (by tom.prince): Using buildbot try with the PBListner will also trigger this. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Thu Jan 19 16:26:13 2012 From: nobody at buildbot.net (Buildbot) Date: Thu, 19 Jan 2012 16:26:13 -0000 Subject: [Buildbot-commits] [Buildbot] #2139: locks held by slaves are not released when slave goes missing In-Reply-To: <039.9c45009795e8e9815fcee44f137bd228@buildbot.net> References: <039.9c45009795e8e9815fcee44f137bd228@buildbot.net> Message-ID: <054.8c1132da92c404778931307cc5d6e3fd@buildbot.net> #2139: locks held by slaves are not released when slave goes missing --------------------+-------------------- Reporter: dwlocks | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.6 Version: 0.8.4p2 | Resolution: Keywords: | --------------------+-------------------- Comment (by dustin): tomprince suggets {{{ #!patch diff --git a/master/buildbot/buildslave.py b/master/buildbot/buildslave.py index 9f06e65..b8c3c3a 100644 --- a/master/buildbot/buildslave.py +++ b/master/buildbot/buildslave.py @@ -460,6 +460,7 @@ class AbstractBuildSlave(config.ReconfigurableServiceMixin, pb.Avatar, log.msg("BuildSlave.detached(%s)" % self.slavename) self.botmaster.master.status.slaveDisconnected(self.slavename) self.stopKeepaliveTimer() + self.release() # notify watchers, but do so in the next reactor iteration so that # any further detached() action by subclasses happens first }}} which seems adequate to me, but is untested. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Thu Jan 19 21:06:35 2012 From: noreply at github.com (GitHub) Date: Thu, 19 Jan 2012 13:06:35 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] f40f62: Release lock held by slave, when we lose the conne... Message-ID: <4f1885db7256b_2ef23fc7156e4af888041@sh1.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: f40f62cfcb9d456957dc179faced285d1699b1e2 https://github.com/buildbot/buildbot/commit/f40f62cfcb9d456957dc179faced285d1699b1e2 Author: Tom Prince Date: 2012-01-19 (Thu, 19 Jan 2012) Changed paths: M master/buildbot/buildslave.py Log Message: ----------- Release lock held by slave, when we lose the connection to the slave. Fixes #2139 Commit: a804d78de6944ff4e7664221bbe0118508fb13a6 https://github.com/buildbot/buildbot/commit/a804d78de6944ff4e7664221bbe0118508fb13a6 Author: Tom Prince Date: 2012-01-19 (Thu, 19 Jan 2012) Changed paths: M master/buildbot/buildslave.py Log Message: ----------- Merge pull request #305 from tomprince/bug2139 Release lock held by slave, when we lose the connection to the slave. Compare: https://github.com/buildbot/buildbot/compare/8e8e43e...a804d78 From nobody at buildbot.net Thu Jan 19 21:06:41 2012 From: nobody at buildbot.net (Buildbot) Date: Thu, 19 Jan 2012 21:06:41 -0000 Subject: [Buildbot-commits] [Buildbot] #2139: locks held by slaves are not released when slave goes missing In-Reply-To: <039.9c45009795e8e9815fcee44f137bd228@buildbot.net> References: <039.9c45009795e8e9815fcee44f137bd228@buildbot.net> Message-ID: <054.3ef59593082bcde4edf59ff5ade7ffc2@buildbot.net> #2139: locks held by slaves are not released when slave goes missing --------------------+--------------------- Reporter: dwlocks | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.6 Version: 0.8.4p2 | Resolution: fixed Keywords: | --------------------+--------------------- Changes (by Tom Prince): * status: new => closed * resolution: => fixed Comment: Release lock held by slave, when we lose the connection to the slave. Fixes #2139 Changeset: f40f62cfcb9d456957dc179faced285d1699b1e2 -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Thu Jan 19 21:29:14 2012 From: noreply at github.com (GitHub) Date: Thu, 19 Jan 2012 13:29:14 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] 7d78de: Fix stupid type s/release/releaseLocks/. Message-ID: <4f188b2a5dd9c_3a9a3fa9ecf6a2f41095fc@sh1.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 7d78de7d0b311ac34261a7e08eb951394c9ac734 https://github.com/buildbot/buildbot/commit/7d78de7d0b311ac34261a7e08eb951394c9ac734 Author: Tom Prince Date: 2012-01-19 (Thu, 19 Jan 2012) Changed paths: M master/buildbot/buildslave.py Log Message: ----------- Fix stupid type s/release/releaseLocks/. Commit: d25474662e7f3e44532751a6b3ee328b0c91d882 https://github.com/buildbot/buildbot/commit/d25474662e7f3e44532751a6b3ee328b0c91d882 Author: Tom Prince Date: 2012-01-19 (Thu, 19 Jan 2012) Changed paths: M master/buildbot/buildslave.py Log Message: ----------- Merge pull request #306 from tomprince/bug2139 Fix stupid type s/release/releaseLocks/. Compare: https://github.com/buildbot/buildbot/compare/a804d78...d254746 From noreply at github.com Fri Jan 20 15:01:26 2012 From: noreply at github.com (GitHub) Date: Fri, 20 Jan 2012 07:01:26 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] d4cedf: Merge branch 'bug2122' of git://github.com/tomprin... Message-ID: <4f1981c61b0cd_40e3f8966ae32f42015e@sh1.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: d4cedf867068a3c28c94e91b4a3f640fdeba8fe9 https://github.com/buildbot/buildbot/commit/d4cedf867068a3c28c94e91b4a3f640fdeba8fe9 Author: Dustin J. Mitchell Date: 2012-01-20 (Fri, 20 Jan 2012) Changed paths: M master/buildbot/steps/shell.py M master/buildbot/test/unit/test_steps_shell.py Log Message: ----------- Merge branch 'bug2122' of git://github.com/tomprince/buildbot * 'bug2122' of git://github.com/tomprince/buildbot: ShellCommand.describe(): Ignore AttributeError Conflicts: master/buildbot/steps/shell.py From noreply at github.com Fri Jan 20 15:05:44 2012 From: noreply at github.com (GitHub) Date: Fri, 20 Jan 2012 07:05:44 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] 8986ce: Merge branch 'bug2125' of git://github.com/tomprin... Message-ID: <4f1982c85b25f_38cf3fe92395c2ec77071@sh1.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 8986cee7f4c8818fd09fb45d7cc613526241cedf https://github.com/buildbot/buildbot/commit/8986cee7f4c8818fd09fb45d7cc613526241cedf Author: Dustin J. Mitchell Date: 2012-01-20 (Fri, 20 Jan 2012) Changed paths: M master/buildbot/test/unit/test_steps_slave.py M master/docs/manual/cfg-buildsteps.rst Log Message: ----------- Merge branch 'bug2125' of git://github.com/tomprince/buildbot * 'bug2125' of git://github.com/tomprince/buildbot: Document and test MakeDirectory. From noreply at github.com Fri Jan 20 15:12:56 2012 From: noreply at github.com (GitHub) Date: Fri, 20 Jan 2012 07:12:56 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] 5d3ecc: IRC: Remove some of the extraneous logging and sub... Message-ID: <4f1984788f454_38cf3fe92395c2ec79456@sh1.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 5d3ecc2dd1de0f265227de55aee4ef8bbc9475eb https://github.com/buildbot/buildbot/commit/5d3ecc2dd1de0f265227de55aee4ef8bbc9475eb Author: Tom Prince Date: 2012-01-20 (Fri, 20 Jan 2012) Changed paths: M master/buildbot/status/words.py Log Message: ----------- IRC: Remove some of the extraneous logging and subscriptions. see #2124. Commit: a0f14f2c62f66ea35c2f7b4a4f50c3aaaa49cede https://github.com/buildbot/buildbot/commit/a0f14f2c62f66ea35c2f7b4a4f50c3aaaa49cede Author: Tom Prince Date: 2012-01-20 (Fri, 20 Jan 2012) Changed paths: M master/buildbot/status/words.py Log Message: ----------- Merge pull request #303 from tomprince/irc-logs IRC: Remove some of the extraneous logging and subscriptions. Compare: https://github.com/buildbot/buildbot/compare/8986cee...a0f14f2 From nobody at buildbot.net Fri Jan 20 15:13:11 2012 From: nobody at buildbot.net (Buildbot) Date: Fri, 20 Jan 2012 15:13:11 -0000 Subject: [Buildbot-commits] [Buildbot] #2124: IRC oversubsribes to buildsets, logs too much In-Reply-To: <038.e3d7141541e658c55cc0f198870726b6@buildbot.net> References: <038.e3d7141541e658c55cc0f198870726b6@buildbot.net> Message-ID: <053.e13c36482d383b11f1139d6fdf189e97@buildbot.net> #2124: IRC oversubsribes to buildsets, logs too much -------------------+-------------------- Reporter: dustin | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.6 Version: 0.8.5 | Resolution: Keywords: irc | -------------------+-------------------- Comment (by Tom Prince): IRC: Remove some of the extraneous logging and subscriptions. see #2124. Changeset: 5d3ecc2dd1de0f265227de55aee4ef8bbc9475eb -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Fri Jan 20 15:42:57 2012 From: noreply at github.com (GitHub) Date: Fri, 20 Jan 2012 07:42:57 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] 9b72ca: Merge branch 'master' of github.com:buildbot/build... Message-ID: <4f198b81e08c5_40e3f8966ae32f421535c@sh1.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 9b72ca51895afac85c7dc1585e86a42810f5060d https://github.com/buildbot/buildbot/commit/9b72ca51895afac85c7dc1585e86a42810f5060d Author: Dustin J. Mitchell Date: 2012-01-20 (Fri, 20 Jan 2012) Changed paths: M master/buildbot/status/words.py Log Message: ----------- Merge branch 'master' of github.com:buildbot/buildbot * 'master' of github.com:buildbot/buildbot: IRC: Remove some of the extraneous logging and subscriptions. From nobody at buildbot.net Fri Jan 20 16:48:20 2012 From: nobody at buildbot.net (Buildbot) Date: Fri, 20 Jan 2012 16:48:20 -0000 Subject: [Buildbot-commits] [Buildbot] #2179: Test Suite fails to detect missing 'yield wfd; res = wfd.getResult()' in build step tests. In-Reply-To: <042.a4a888721a06040f079b4ceb4aa1e771@buildbot.net> References: <042.a4a888721a06040f079b4ceb4aa1e771@buildbot.net> Message-ID: <057.12c69512e6c57aca71e2865e964ad206@buildbot.net> #2179: Test Suite fails to detect missing 'yield wfd; res = wfd.getResult()' in build step tests. -----------------------+------------------------ Reporter: tom.prince | Owner: Type: defect | Status: new Priority: minor | Milestone: undecided Version: master | Resolution: Keywords: | -----------------------+------------------------ Comment (by dustin): When I was building http://code.google.com/p/uthreads, I used some funny gc tricks to figure out when an object that should have been handled appropriately wasn't. I wonder if we could monkey-patch waitForDeferred to do the same? -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Jan 20 16:51:53 2012 From: nobody at buildbot.net (Buildbot) Date: Fri, 20 Jan 2012 16:51:53 -0000 Subject: [Buildbot-commits] [Buildbot] #899: AttributeError on reconfig In-Reply-To: <038.004033e7a6e0b558a7ebbad5fce7ba59@buildbot.net> References: <038.004033e7a6e0b558a7ebbad5fce7ba59@buildbot.net> Message-ID: <053.693bc95888ef99d7e97d2ed4df61dbab@buildbot.net> #899: AttributeError on reconfig ------------------------------+--------------------- Reporter: catlee | Owner: Type: defect | Status: closed Priority: critical | Milestone: 0.8.+ Version: 0.8.0 | Resolution: fixed Keywords: database reconfig | ------------------------------+--------------------- Changes (by dustin): * status: new => closed * resolution: => fixed Comment: Good idea. This sort of error will be even better-handled by further improving the config system to reconfig status listeners, rather than destroy and re- create them. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Jan 20 18:05:47 2012 From: nobody at buildbot.net (Buildbot) Date: Fri, 20 Jan 2012 18:05:47 -0000 Subject: [Buildbot-commits] [Buildbot] #2180: Allow for "git describe" in addition to got_revision Message-ID: <042.f0bb38d6a7f6d5b4159cc3a8bf6a0f8c@buildbot.net> #2180: Allow for "git describe" in addition to got_revision ------------------------+----------------------------- Reporter: jaredgrubb | Owner: Type: enhancement | Status: new Priority: minor | Milestone: undecided Version: 0.8.5 | Keywords: git, buildslave ------------------------+----------------------------- It would be nice if there was a flag to retrieve the "git describe" value for the checked out revision, just like buildbot does for got_revision. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Jan 21 05:03:04 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 21 Jan 2012 05:03:04 -0000 Subject: [Buildbot-commits] [Buildbot] #2123: Changes sent over the wire should be compressed In-Reply-To: <036.8cceb3fe6a6edabb86fbef518ee3826f@buildbot.net> References: <036.8cceb3fe6a6edabb86fbef518ee3826f@buildbot.net> Message-ID: <051.07982c9866d942e32e390a82553de06b@buildbot.net> #2123: Changes sent over the wire should be compressed ------------------------+-------------------- Reporter: dank | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.6 Version: 0.8.5 | Resolution: Keywords: | ------------------------+-------------------- Comment (by dustin): Indeed - this is a fundamental flaw of na?ve use of RPC for data transfer, in both cases. Compressing patches will only buy time (space?) until this hurts a particular use. At least changing the SIZE_LIMIT lets the user dial in their own ceiling. Let's do the documentation as a simple step to get 0.8.6 out the door. If there's clamor for it, we can later implement this as a master configuration parameter (and call a method on the slave to set the corresponding value, and similarly get the try client to determine the appropriate SIZE_LIMIT before sending a patch). -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Jan 21 05:11:19 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 21 Jan 2012 05:11:19 -0000 Subject: [Buildbot-commits] [Buildbot] #2123: Changes sent over the wire should be compressed In-Reply-To: <036.8cceb3fe6a6edabb86fbef518ee3826f@buildbot.net> References: <036.8cceb3fe6a6edabb86fbef518ee3826f@buildbot.net> Message-ID: <051.131c25a05be8422d2b71f525a9ca3fc6@buildbot.net> #2123: Changes sent over the wire should be compressed ------------------------+-------------------- Reporter: dank | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.6 Version: 0.8.5 | Resolution: Keywords: | ------------------------+-------------------- Comment (by dank): Documenting the limit and how to tweak it would be helpful (especially if you emit a warning pointing to the doc when the limit is exceeded). Later, though, compression would be a big win in some cases. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Jan 21 05:17:48 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 21 Jan 2012 05:17:48 -0000 Subject: [Buildbot-commits] [Buildbot] #2123: Changes sent over the wire should be compressed In-Reply-To: <036.8cceb3fe6a6edabb86fbef518ee3826f@buildbot.net> References: <036.8cceb3fe6a6edabb86fbef518ee3826f@buildbot.net> Message-ID: <051.384b1ca4c09db156c910090f8bfe92fe@buildbot.net> #2123: Changes sent over the wire should be compressed ------------------------+-------------------- Reporter: dank | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.6 Version: 0.8.5 | Resolution: Keywords: | ------------------------+-------------------- Comment (by dustin): Hm, this may need to be adjusted in the buildbot try client, too - dank, can you verify how best to set SIZE_LIMIT in that case? I was thinking of the master/slave communication, which is just a buildbot.tac modification. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Jan 21 05:25:31 2012 From: nobody at buildbot.net (Buildbot) Date: Sat, 21 Jan 2012 05:25:31 -0000 Subject: [Buildbot-commits] [Buildbot] #2123: Changes sent over the wire should be compressed In-Reply-To: <036.8cceb3fe6a6edabb86fbef518ee3826f@buildbot.net> References: <036.8cceb3fe6a6edabb86fbef518ee3826f@buildbot.net> Message-ID: <051.8901f7060b1980e614e92d8edb138ac3@buildbot.net> #2123: Changes sent over the wire should be compressed ------------------------+-------------------- Reporter: dank | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.6 Version: 0.8.5 | Resolution: Keywords: | ------------------------+-------------------- Comment (by dank): Both my client and my server install scripts contain this line: # Large patches cause problems without this. Need on both sides, # see http://twistedmatrix.com/documents/current/core/howto/pb- limits.html sed -i.bak -e 's/SIZE_LIMIT =.*/SIZE_LIMIT = 2 * 1024 * 1024/' \ $TOP/sandbox/lib/python2.?/site-packages/twisted/spread/banana.py -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sat Jan 21 18:52:14 2012 From: noreply at github.com (GitHub) Date: Sat, 21 Jan 2012 10:52:14 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] a874e8: remove old conf.py Message-ID: <4f1b095e2d56f_39763ff21ddb22f869553@sh1.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: a874e8db0a505e53b112a18c43cc08ec48adf178 https://github.com/buildbot/buildbot/commit/a874e8db0a505e53b112a18c43cc08ec48adf178 Author: Dustin J. Mitchell Date: 2012-01-20 (Fri, 20 Jan 2012) Changed paths: R master/docs/manual/conf.py Log Message: ----------- remove old conf.py Commit: a29bdcc4715683315b491602326e1c60ccf1a118 https://github.com/buildbot/buildbot/commit/a29bdcc4715683315b491602326e1c60ccf1a118 Author: Dustin J. Mitchell Date: 2012-01-21 (Sat, 21 Jan 2012) Changed paths: M slave/buildslave/test/unit/test_runprocess.py Log Message: ----------- better name, technique for triggering exception, in buildslave.test.unit.test_runprocess.TestRunProcess.test_startCommand_exception Compare: https://github.com/buildbot/buildbot/compare/9b72ca5...a29bdcc From noreply at github.com Sun Jan 22 00:08:27 2012 From: noreply at github.com (GitHub) Date: Sat, 21 Jan 2012 16:08:27 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] af7302: Merge Expect and ExpectLogged. Message-ID: <4f1b537b12821_70693f9109ebcaec2218fe@sh1.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: af73027c78aba2783eef5fa27db9950b7fcdb7f1 https://github.com/buildbot/buildbot/commit/af73027c78aba2783eef5fa27db9950b7fcdb7f1 Author: Tom Prince Date: 2012-01-21 (Sat, 21 Jan 2012) Changed paths: M master/buildbot/test/fake/remotecommand.py M master/buildbot/test/unit/test_steps_slave.py M master/buildbot/test/unit/test_steps_source_bzr.py M master/buildbot/test/unit/test_steps_source_cvs.py M master/buildbot/test/unit/test_steps_source_git.py M master/buildbot/test/unit/test_steps_source_mercurial.py M master/buildbot/test/unit/test_steps_source_svn.py Log Message: ----------- Merge Expect and ExpectLogged. Since we merged the commands themselves, merge the expectations as well. Commit: 5cfb8f597d647ee9e7b984ca5a41d7d2e5f301f1 https://github.com/buildbot/buildbot/commit/5cfb8f597d647ee9e7b984ca5a41d7d2e5f301f1 Author: Tom Prince Date: 2012-01-21 (Sat, 21 Jan 2012) Changed paths: M master/docs/developer/cls-remotecommands.rst Log Message: ----------- Update docs to reflect merging LoggedRemoteCommand into RemoteCommand. Commit: b2289515c1a4a0d262984ad094db572257f5e970 https://github.com/buildbot/buildbot/commit/b2289515c1a4a0d262984ad094db572257f5e970 Author: Dustin J. Mitchell Date: 2012-01-21 (Sat, 21 Jan 2012) Changed paths: M master/CREDITS M master/buildbot/buildslave.py M master/buildbot/config.py M master/buildbot/db/__init__.py M master/buildbot/db/buildsets.py M master/buildbot/db/connector.py M master/buildbot/db/enginestrategy.py A master/buildbot/db/migrate/versions/018_add_sourcestampset.py A master/buildbot/db/migrate/versions/019_merge_schedulers_to_objects.py M master/buildbot/db/model.py M master/buildbot/db/pool.py M master/buildbot/db/schedulers.py M master/buildbot/db/sourcestamps.py A master/buildbot/db/sourcestampsets.py M master/buildbot/manhole.py M master/buildbot/monkeypatches/__init__.py A master/buildbot/monkeypatches/sqlalchemy2189.py A master/buildbot/monkeypatches/sqlalchemy2364.py M master/buildbot/process/build.py M master/buildbot/process/builder.py M master/buildbot/process/buildrequest.py M master/buildbot/process/buildstep.py M master/buildbot/schedulers/base.py M master/buildbot/schedulers/basic.py M master/buildbot/schedulers/dependent.py M master/buildbot/schedulers/forcesched.py M master/buildbot/schedulers/manager.py M master/buildbot/schedulers/timed.py M master/buildbot/schedulers/triggerable.py M master/buildbot/schedulers/trysched.py M master/buildbot/scripts/runner.py M master/buildbot/sourcestamp.py M master/buildbot/status/buildstep.py M master/buildbot/status/client.py M master/buildbot/status/mail.py M master/buildbot/status/master.py M master/buildbot/status/web/build.py M master/buildbot/status/web/builder.py M master/buildbot/status/web/waterfall.py M master/buildbot/status/words.py M master/buildbot/steps/shell.py M master/buildbot/steps/source/git.py M master/buildbot/steps/source/oldsource.py M master/buildbot/steps/transfer.py M master/buildbot/steps/trigger.py M master/buildbot/test/fake/fakedb.py M master/buildbot/test/fake/remotecommand.py M master/buildbot/test/integration/test_upgrade.py M master/buildbot/test/unit/test_config.py M master/buildbot/test/unit/test_db_buildrequests.py M master/buildbot/test/unit/test_db_builds.py M master/buildbot/test/unit/test_db_buildsets.py M master/buildbot/test/unit/test_db_changes.py M master/buildbot/test/unit/test_db_connector.py A master/buildbot/test/unit/test_db_migrate_versions_018_add_sourcestampset.py A master/buildbot/test/unit/test_db_migrate_versions_019_merge_schedulers_to_objects.py M master/buildbot/test/unit/test_db_schedulers.py M master/buildbot/test/unit/test_db_sourcestamps.py A master/buildbot/test/unit/test_db_sourcestampsets.py M master/buildbot/test/unit/test_master.py M master/buildbot/test/unit/test_process_builder.py M master/buildbot/test/unit/test_process_buildrequest.py M master/buildbot/test/unit/test_process_buildstep.py M master/buildbot/test/unit/test_schedulers_base.py M master/buildbot/test/unit/test_schedulers_basic.py M master/buildbot/test/unit/test_schedulers_dependent.py M master/buildbot/test/unit/test_schedulers_forcesched.py M master/buildbot/test/unit/test_schedulers_manager.py M master/buildbot/test/unit/test_schedulers_timed_Nightly.py M master/buildbot/test/unit/test_schedulers_timed_Timed.py M master/buildbot/test/unit/test_schedulers_triggerable.py M master/buildbot/test/unit/test_schedulers_trysched.py M master/buildbot/test/unit/test_sourcestamp.py M master/buildbot/test/unit/test_status_client.py M master/buildbot/test/unit/test_status_mail.py M master/buildbot/test/unit/test_status_master.py M master/buildbot/test/unit/test_steps_shell.py M master/buildbot/test/unit/test_steps_slave.py M master/buildbot/test/unit/test_steps_source_git.py M master/buildbot/test/unit/test_steps_trigger.py A master/buildbot/test/unit/test_util_sautils.py M master/buildbot/test/util/db.py M master/buildbot/test/util/scheduler.py M master/buildbot/test/util/sourcesteps.py M master/buildbot/test/util/steps.py M master/buildbot/util/__init__.py M master/buildbot/util/sautils.py M master/contrib/bitbucket_buildbot.py A master/contrib/fakemaster.py M master/docs/developer/cls-buildsteps.rst M master/docs/developer/database.rst M master/docs/manual/cfg-buildsteps.rst R master/docs/manual/conf.py M master/docs/manual/installation.rst M master/docs/release-notes.rst M slave/buildslave/test/unit/test_runprocess.py Log Message: ----------- Merge branch 'master' into pull307 * master: (69 commits) better name, technique for triggering exception, in buildslave.test.unit.test_runprocess.TestRunProcess.test_startCommand_exception remove old conf.py IRC: Remove some of the extraneous logging and subscriptions. NEWS for previous Fix stupid type s/release/releaseLocks/. Release lock held by slave, when we lose the connection to the slave. Git: Properly ignore errors on 'git branch -M'. ShellCommand.describe(): Ignore AttributeError Document and test MakeDirectory. Git: Support source-stamp patches. Git: Rename local branch to match remote branch name. Git: Remove bogus raise failure.Failure. Git: Use provide or default branch when cloning and fetching, rather than master. Sort next builds in waterfall just improve logging. Don't change default port Changed default port to connect to PBChangeListener to 9999 (from 9989 which is the 'normal' slave connection port. Added some debug logging when trying to connect to bb master don't use sa.Boolean Simplify scheduler-related DB schema add/fix comments in model.py update CREDITS from git history ... Commit: 8b84670bf02ee495d72c713f90bbe735a967fe67 https://github.com/buildbot/buildbot/commit/8b84670bf02ee495d72c713f90bbe735a967fe67 Author: Dustin J. Mitchell Date: 2012-01-21 (Sat, 21 Jan 2012) Changed paths: M master/buildbot/test/unit/test_steps_slave.py M master/buildbot/test/unit/test_steps_source_git.py Log Message: ----------- update ExpectLogged->Expect to master Compare: https://github.com/buildbot/buildbot/compare/a29bdcc...8b84670 From noreply at github.com Sun Jan 22 05:19:37 2012 From: noreply at github.com (GitHub) Date: Sat, 21 Jan 2012 21:19:37 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] cb48a8: make verbose db logging even more verbose Message-ID: <4f1b9c69162c8_aff3f89391fd2fc2160ac@sh1.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: cb48a8f8aba22e47938a68ee82f2e518c62a6e99 https://github.com/buildbot/buildbot/commit/cb48a8f8aba22e47938a68ee82f2e518c62a6e99 Author: Dustin J. Mitchell Date: 2012-01-21 (Sat, 21 Jan 2012) Changed paths: M master/buildbot/db/pool.py Log Message: ----------- make verbose db logging even more verbose * add unique IDs to each call * show caller's local variables * show when each thread starts and ends Commit: c69b40cde4b14e68a1fb2ca31cd5ebf975d3d8ed https://github.com/buildbot/buildbot/commit/c69b40cde4b14e68a1fb2ca31cd5ebf975d3d8ed Author: Dustin J. Mitchell Date: 2012-01-21 (Sat, 21 Jan 2012) Changed paths: M master/buildbot/db/pool.py Log Message: ----------- Merge remote-tracking branch 'lorentz/master' * lorentz/master: make verbose db logging even more verbose Compare: https://github.com/buildbot/buildbot/compare/8b84670...c69b40c From noreply at github.com Sun Jan 22 16:41:16 2012 From: noreply at github.com (GitHub) Date: Sun, 22 Jan 2012 08:41:16 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] 6a9457: Reference the master, not the status object Message-ID: <4f1c3c2c684d8_ae33ff39004d2ec1164fc@sh1.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 6a94572b4a285849948dfc99adac8e733a50e502 https://github.com/buildbot/buildbot/commit/6a94572b4a285849948dfc99adac8e733a50e502 Author: Dustin J. Mitchell Date: 2012-01-22 (Sun, 22 Jan 2012) Changed paths: A lorentz M master/buildbot/status/mail.py Log Message: ----------- Reference the master, not the status object This fixes #2178. From nobody at buildbot.net Sun Jan 22 16:41:22 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 22 Jan 2012 16:41:22 -0000 Subject: [Buildbot-commits] [Buildbot] #2178: buildSetSummary=True for MailNotifier exceptions.AttributeError: Status instance has no attribute 'subscribeToBuildsetCompletions' In-Reply-To: <040.1ab0627bf600c79daa0aa74421c03003@buildbot.net> References: <040.1ab0627bf600c79daa0aa74421c03003@buildbot.net> Message-ID: <055.97073b0b0c8863b65b98bb18bb95e32a@buildbot.net> #2178: buildSetSummary=True for MailNotifier exceptions.AttributeError: Status instance has no attribute 'subscribeToBuildsetCompletions' -------------------------+-------------------- Reporter: kevbroch | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.6 Version: master | Resolution: Keywords: mail, status | -------------------------+-------------------- Changes (by dustin): * milestone: undecided => 0.8.6 Comment: easy fix.. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Jan 22 16:41:24 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 22 Jan 2012 16:41:24 -0000 Subject: [Buildbot-commits] [Buildbot] #2178: buildSetSummary=True for MailNotifier exceptions.AttributeError: Status instance has no attribute 'subscribeToBuildsetCompletions' In-Reply-To: <040.1ab0627bf600c79daa0aa74421c03003@buildbot.net> References: <040.1ab0627bf600c79daa0aa74421c03003@buildbot.net> Message-ID: <055.93c2cf5be0aaf356a290687ed7d05208@buildbot.net> #2178: buildSetSummary=True for MailNotifier exceptions.AttributeError: Status instance has no attribute 'subscribeToBuildsetCompletions' -------------------------+--------------------- Reporter: kevbroch | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.6 Version: master | Resolution: fixed Keywords: mail, status | -------------------------+--------------------- Changes (by Dustin J. Mitchell): * status: new => closed * resolution: => fixed Comment: Reference the master, not the status object This fixes #2178. Changeset: 6a94572b4a285849948dfc99adac8e733a50e502 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Jan 22 17:05:04 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 22 Jan 2012 17:05:04 -0000 Subject: [Buildbot-commits] [Buildbot] #2153: Master-side git source step always uses default branch after clone In-Reply-To: <036.c50ccb745b2fe2556ca841426b0f0f81@buildbot.net> References: <036.c50ccb745b2fe2556ca841426b0f0f81@buildbot.net> Message-ID: <051.babdd9bef791c431124f344c2591c663@buildbot.net> #2153: Master-side git source step always uses default branch after clone ---------------------+--------------------- Reporter: Tobi | Owner: Type: defect | Status: closed Priority: critical | Milestone: 0.8.6 Version: master | Resolution: fixed Keywords: git | ---------------------+--------------------- Changes (by tom.prince): * status: new => closed * resolution: => fixed -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Jan 22 17:05:38 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 22 Jan 2012 17:05:38 -0000 Subject: [Buildbot-commits] [Buildbot] #2093: try does not understand patches generated by git In-Reply-To: <036.ec4af867fa6da598c739c385436b18ee@buildbot.net> References: <036.ec4af867fa6da598c739c385436b18ee@buildbot.net> Message-ID: <051.50acd03fc9d1e76b99ff338765938fc4@buildbot.net> #2093: try does not understand patches generated by git ------------------------+--------------------- Reporter: dank | Owner: Type: enhancement | Status: closed Priority: major | Milestone: 0.8.+ Version: master | Resolution: fixed Keywords: git | ------------------------+--------------------- Changes (by tom.prince): * status: new => closed * resolution: => fixed -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Jan 22 17:06:10 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 22 Jan 2012 17:06:10 -0000 Subject: [Buildbot-commits] [Buildbot] #2156: Master-side git step does not rename local branch In-Reply-To: <036.e104f6f0d415ead3cbc379afb2ddd1f9@buildbot.net> References: <036.e104f6f0d415ead3cbc379afb2ddd1f9@buildbot.net> Message-ID: <051.e75e825873e739bcc1edfbad6f790491@buildbot.net> #2156: Master-side git step does not rename local branch -------------------+--------------------- Reporter: Tobi | Owner: Tobi Type: defect | Status: closed Priority: major | Milestone: 0.8.6 Version: master | Resolution: fixed Keywords: git | -------------------+--------------------- Changes (by tom.prince): * status: assigned => closed * resolution: => fixed -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Jan 22 17:07:30 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 22 Jan 2012 17:07:30 -0000 Subject: [Buildbot-commits] [Buildbot] #2122: Race condition causes error describing step In-Reply-To: <037.bae614ef17847763cea74c9cb0e1a868@buildbot.net> References: <037.bae614ef17847763cea74c9cb0e1a868@buildbot.net> Message-ID: <052.52571c30a0fa0920c649e7cf7595078e@buildbot.net> #2122: Race condition causes error describing step -------------------+--------------------- Reporter: tmidd | Owner: Type: defect | Status: closed Priority: minor | Milestone: 0.8.6 Version: 0.8.5 | Resolution: fixed Keywords: | -------------------+--------------------- Changes (by tom.prince): * status: new => closed * resolution: => fixed -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Jan 22 17:17:07 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 22 Jan 2012 17:17:07 -0000 Subject: [Buildbot-commits] [Buildbot] #2125: buildbot.steps.slave.MakeDirectory needs tests/docs In-Reply-To: <042.9783a81166d26b38c71303f2df2d06d0@buildbot.net> References: <042.9783a81166d26b38c71303f2df2d06d0@buildbot.net> Message-ID: <057.d64092bbdcfdf8b33200ac6fc507f55e@buildbot.net> #2125: buildbot.steps.slave.MakeDirectory needs tests/docs ------------------------+------------------------- Reporter: tom.prince | Owner: tom.prince Type: enhancement | Status: closed Priority: major | Milestone: 0.8.6 Version: 0.8.5 | Resolution: fixed Keywords: | ------------------------+------------------------- Changes (by tom.prince): * status: new => closed * resolution: => fixed -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sun Jan 22 17:24:41 2012 From: noreply at github.com (GitHub) Date: Sun, 22 Jan 2012 09:24:41 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] a14fd0: remove spurious file Message-ID: <4f1c4659ce4af_7d4c3fb7268ceafc76596@sh1.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: a14fd0cb0ce3aaf4b70647ca6570c1645dd8a10e https://github.com/buildbot/buildbot/commit/a14fd0cb0ce3aaf4b70647ca6570c1645dd8a10e Author: Dustin J. Mitchell Date: 2012-01-22 (Sun, 22 Jan 2012) Changed paths: R lorentz Log Message: ----------- remove spurious file From nobody at buildbot.net Sun Jan 22 17:29:17 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 22 Jan 2012 17:29:17 -0000 Subject: [Buildbot-commits] [Buildbot] #1990: Source steps falling back to complete re-initialization should not be mandatory In-Reply-To: <037.a8ad1401ad7ff566359b5a60a33f9e3e@buildbot.net> References: <037.a8ad1401ad7ff566359b5a60a33f9e3e@buildbot.net> Message-ID: <052.f63170ce21a55e71db57ea323cd15bad@buildbot.net> #1990: Source steps falling back to complete re-initialization should not be mandatory ------------------------+------------------------ Reporter: ayust | Owner: Type: enhancement | Status: new Priority: major | Milestone: undecided Version: 0.8.4 | Resolution: Keywords: | ------------------------+------------------------ Changes (by tom.prince): * milestone: 0.8.6 => undecided Comment: It looks like none of the master-side source steps do do a full clone on failed update (excpet git which defaults to off). Perhaps there should be an option to do a full clone on failure. But this seems like it fixed with the new steps? -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Jan 22 18:22:02 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 22 Jan 2012 18:22:02 -0000 Subject: [Buildbot-commits] [Buildbot] #2177: Trigger goes out to lunch and never comes back! In-Reply-To: <045.a0c9ec445e31cd17ee70f017d7e4b177@buildbot.net> References: <045.a0c9ec445e31cd17ee70f017d7e4b177@buildbot.net> Message-ID: <060.c157ee23e9a413165d16bdab9cf652a2@buildbot.net> #2177: Trigger goes out to lunch and never comes back! --------------------------+------------------------ Reporter: seb_kuzminsky | Owner: Type: undecided | Status: new Priority: major | Milestone: undecided Version: 0.8.5 | Resolution: Keywords: | --------------------------+------------------------ Comment (by dustin): I'm trying to reproduce with a master.cfg containing: {{{ NUM_BLDRS = 10 c['schedulers'] = [] c['schedulers'].append(triggerable.Triggerable(name="t", builderNames=["sometask"])) for x in range(NUM_BLDRS): c['schedulers'].append(triggerable.Triggerable(name=str(x), builderNames=["sometask"])) c['schedulers'].append(timed.Periodic(name="n", periodicBuildTimer=1, builderNames=["trig"])) f1 = factory.BuildFactory() f1.addStep(ShellCommand(command="echo hi", description='echoing', descriptionDone='echoed', usePTY=True)) f2 = factory.BuildFactory() f2.addStep(Trigger(schedulerNames=[ 't' ], waitForFinish=True)) f2.addStep(Trigger(schedulerNames=[ str(x) for x in range(NUM_BLDRS) ], waitForFinish=True)) from buildbot.config import BuilderConfig c['builders'] = [ BuilderConfig( name = "sometask", slavenames = "example-slave", factory = f1, category = 'x7', mergeRequests = False ), BuilderConfig( name = "trig", slavenames = "example-slave", factory = f2, category = 'x7', mergeRequests = False ), ] }}} with the idea that when this fails, the "trig" builder will start to pile up jobs waiting for the single slave builder it runs on. 700 builds in, I've still not seen a failure. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Jan 22 18:31:40 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 22 Jan 2012 18:31:40 -0000 Subject: [Buildbot-commits] [Buildbot] #2177: Trigger goes out to lunch and never comes back! In-Reply-To: <045.a0c9ec445e31cd17ee70f017d7e4b177@buildbot.net> References: <045.a0c9ec445e31cd17ee70f017d7e4b177@buildbot.net> Message-ID: <060.5bc1c2450552f1831744733c67436af8@buildbot.net> #2177: Trigger goes out to lunch and never comes back! --------------------------+------------------------ Reporter: seb_kuzminsky | Owner: Type: undecided | Status: new Priority: major | Milestone: undecided Version: 0.8.5 | Resolution: Keywords: | --------------------------+------------------------ Comment (by dustin): 15,000 buildsets now, and 1300 builds on "trig", with no failures. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Jan 22 18:45:27 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 22 Jan 2012 18:45:27 -0000 Subject: [Buildbot-commits] [Buildbot] #2177: Trigger goes out to lunch and never comes back! In-Reply-To: <045.a0c9ec445e31cd17ee70f017d7e4b177@buildbot.net> References: <045.a0c9ec445e31cd17ee70f017d7e4b177@buildbot.net> Message-ID: <060.78cffd9aa9de75e524b75180fd88f0ed@buildbot.net> #2177: Trigger goes out to lunch and never comes back! --------------------------+------------------------ Reporter: seb_kuzminsky | Owner: Type: undecided | Status: new Priority: major | Milestone: undecided Version: 0.8.5 | Resolution: Keywords: | --------------------------+------------------------ Comment (by dustin): Oh, I bet it's these: {{{ sqlalchemy.exc.OperationalError: (OperationalError) database is locked u'UPDATE buildrequests SET complete=?, results=?, complete_at=? WHERE buildrequests.id IN (?) AND buildrequests.complete != ?' (1, 1, 1326476610.146077, 1895, 1) }}} where such an error would cause a buildrequest to not be marked complete. Such a build request should eventually be run-run, but a failure to mark a buildset as complete would not be fixed up later. What version of sqlite are you using? -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Jan 22 18:51:32 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 22 Jan 2012 18:51:32 -0000 Subject: [Buildbot-commits] [Buildbot] #2005: SQLAlchemy Operational errors with SQLite: Database is locked In-Reply-To: <040.08a071a74acf7400775dd33a90e10ace@buildbot.net> References: <040.08a071a74acf7400775dd33a90e10ace@buildbot.net> Message-ID: <055.9d6276aad4b6832af49d92e171ec7553@buildbot.net> #2005: SQLAlchemy Operational errors with SQLite: Database is locked ---------------------+------------------------- Reporter: abompard | Owner: Type: defect | Status: closed Priority: critical | Milestone: 0.8.5 Version: 0.8.4p1 | Resolution: worksforme Keywords: database | ---------------------+------------------------- Comment (by dustin): duped from #2177 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Jan 22 18:51:43 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 22 Jan 2012 18:51:43 -0000 Subject: [Buildbot-commits] [Buildbot] #2005: SQLAlchemy Operational errors with SQLite: Database is locked In-Reply-To: <040.08a071a74acf7400775dd33a90e10ace@buildbot.net> References: <040.08a071a74acf7400775dd33a90e10ace@buildbot.net> Message-ID: <055.638b171a7375159b9abc0cede7432c68@buildbot.net> #2005: SQLAlchemy Operational errors with SQLite: Database is locked ---------------------+----------------------- Reporter: abompard | Owner: Type: defect | Status: reopened Priority: critical | Milestone: 0.8.5 Version: 0.8.4p1 | Resolution: Keywords: database | ---------------------+----------------------- Changes (by dustin): * status: closed => reopened * resolution: worksforme => -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Jan 22 18:51:59 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 22 Jan 2012 18:51:59 -0000 Subject: [Buildbot-commits] [Buildbot] #2177: Trigger goes out to lunch and never comes back! In-Reply-To: <045.a0c9ec445e31cd17ee70f017d7e4b177@buildbot.net> References: <045.a0c9ec445e31cd17ee70f017d7e4b177@buildbot.net> Message-ID: <060.d31a8ccaeeeacad918e5d2a0b2996093@buildbot.net> #2177: Trigger goes out to lunch and never comes back! --------------------------+------------------------ Reporter: seb_kuzminsky | Owner: Type: undecided | Status: closed Priority: major | Milestone: undecided Version: 0.8.5 | Resolution: duplicate Keywords: | --------------------------+------------------------ Changes (by dustin): * status: new => closed * resolution: => duplicate Comment: see #2005 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Jan 22 19:05:37 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 22 Jan 2012 19:05:37 -0000 Subject: [Buildbot-commits] [Buildbot] #2181: triggerable broken with sourcestampsets Message-ID: <038.ea83a3efb6ac67f3a5168c5c5a0d26bc@buildbot.net> #2181: triggerable broken with sourcestampsets ---------------------+------------------- Reporter: dustin | Owner: Type: defect | Status: new Priority: critical | Milestone: 0.8.6 Version: 0.8.5 | Keywords: ---------------------+------------------- the Trigger step calls {{{ss.getSourceStampId}}}, which no longer exists. I suspect that triggering could use sourcestamp set ids? -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Jan 22 19:16:34 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 22 Jan 2012 19:16:34 -0000 Subject: [Buildbot-commits] [Buildbot] #2005: SQLAlchemy Operational errors with SQLite: Database is locked In-Reply-To: <040.08a071a74acf7400775dd33a90e10ace@buildbot.net> References: <040.08a071a74acf7400775dd33a90e10ace@buildbot.net> Message-ID: <055.b76ef7332f55fcad681ae09346ff8d5b@buildbot.net> #2005: SQLAlchemy Operational errors with SQLite: Database is locked ---------------------+----------------------- Reporter: abompard | Owner: Type: defect | Status: reopened Priority: critical | Milestone: 0.8.5 Version: 0.8.4p1 | Resolution: Keywords: database | ---------------------+----------------------- Comment (by dustin): Evidence for the "database is locked" = "SQLITE_BUSY" assertion: * pysqlite just calls sqlite3_errmsg - http://code.google.com/codesearch#aEvhAxCkZ8U/src/util.c&q=SQLITE_BUSY%20package:http://pysqlite%5C.googlecode%5C.com&l=68 * sqlite3.c reads the message from an array, and: {{{ 113089 /* SQLITE_BUSY */ "database is locked", }}} -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Jan 22 19:31:12 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 22 Jan 2012 19:31:12 -0000 Subject: [Buildbot-commits] [Buildbot] #2005: SQLAlchemy Operational errors with SQLite: Database is locked In-Reply-To: <040.08a071a74acf7400775dd33a90e10ace@buildbot.net> References: <040.08a071a74acf7400775dd33a90e10ace@buildbot.net> Message-ID: <055.c702e809a251901c2b89c618729e97f0@buildbot.net> #2005: SQLAlchemy Operational errors with SQLite: Database is locked ---------------------+----------------------- Reporter: abompard | Owner: Type: defect | Status: reopened Priority: critical | Milestone: 0.8.5 Version: 0.8.4p1 | Resolution: Keywords: database | ---------------------+----------------------- Comment (by dustin): http://www.sqlite.org/cvstrac/wiki?p=MultiThreading: Make sure you handle the likely possibility that one or more threads collide when they access the db file at the same time: handle SQLITE_BUSY appropriately. so, basically, sqlite can do multi-threaded read, but is limited to single-threaded writes. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Jan 22 21:34:55 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 22 Jan 2012 21:34:55 -0000 Subject: [Buildbot-commits] [Buildbot] #2005: SQLAlchemy Operational errors with SQLite: Database is locked In-Reply-To: <040.08a071a74acf7400775dd33a90e10ace@buildbot.net> References: <040.08a071a74acf7400775dd33a90e10ace@buildbot.net> Message-ID: <055.f38203a027b414c70cf7404314069358@buildbot.net> #2005: SQLAlchemy Operational errors with SQLite: Database is locked ---------------------+----------------------- Reporter: abompard | Owner: Type: defect | Status: reopened Priority: critical | Milestone: 0.8.5 Version: 0.8.4p1 | Resolution: Keywords: database | ---------------------+----------------------- Comment (by dustin): reliably replicated with {{{ #!python @defer.deferredGenerator def test_inserts(self): def write(conn): trans = conn.begin() conn.execute("INSERT INTO test VALUES (1, 1)") time.sleep(31) trans.commit() d1 = self.pool.do(write) def write2(conn): trans = conn.begin() conn.execute("INSERT INTO test VALUES (1, 1)") trans.commit() d2 = defer.Deferred() d2.addCallback(lambda _ : self.pool.do(write2)) reactor.callLater(0.1, d2.callback, None) wfd = defer.waitForDeferred( defer.DeferredList([ d1, d2 ])) yield wfd wfd.getResult() }}} -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sun Jan 22 21:54:35 2012 From: noreply at github.com (GitHub) Date: Sun, 22 Jan 2012 13:54:35 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] 691965: transfer: Remove __del__. Message-ID: <4f1c859b7cdfb_7fbe3ff4433862fc22766b@sh1.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 6919655b27e7c8b5b81c0420ef802c18131bf42e https://github.com/buildbot/buildbot/commit/6919655b27e7c8b5b81c0420ef802c18131bf42e Author: Tom Prince Date: 2012-01-22 (Sun, 22 Jan 2012) Changed paths: M master/buildbot/steps/transfer.py Log Message: ----------- transfer: Remove __del__. Fixes #1946. Commit: c303d1037439a77a9079c15b859e812c8d2ff426 https://github.com/buildbot/buildbot/commit/c303d1037439a77a9079c15b859e812c8d2ff426 Author: Tom Prince Date: 2012-01-22 (Sun, 22 Jan 2012) Changed paths: M master/buildbot/steps/source/oldsource.py Log Message: ----------- source: Make alwaysUseLatest ignore the SourceStamp's branch. alwaysUseLatest is typically used for checking out secondary repos, which won't be on the same branch as master. with fixes from Stuart Auchterlonie. Commit: 130c32b30e270d5c01c94c6d10a0bd2f4e1aaf3a https://github.com/buildbot/buildbot/commit/130c32b30e270d5c01c94c6d10a0bd2f4e1aaf3a Author: Dustin J. Mitchell Date: 2012-01-22 (Sun, 22 Jan 2012) Changed paths: A lorentz M master/buildbot/status/mail.py M master/buildbot/steps/source/oldsource.py Log Message: ----------- Merge branch 'alwaysUseLatest-honor-branch' of git://github.com/tomprince/buildbot Commit: 3b3e49c6934fca11f4ba05908141d9804475a3db https://github.com/buildbot/buildbot/commit/3b3e49c6934fca11f4ba05908141d9804475a3db Author: Dustin J. Mitchell Date: 2012-01-22 (Sun, 22 Jan 2012) Changed paths: M master/buildbot/steps/transfer.py Log Message: ----------- Merge branch 'remove-__del__' of git://github.com/tomprince/buildbot Commit: c9323fdeb40a2802bbe97bdd69967f0a4e630b85 https://github.com/buildbot/buildbot/commit/c9323fdeb40a2802bbe97bdd69967f0a4e630b85 Author: Dustin J. Mitchell Date: 2012-01-22 (Sun, 22 Jan 2012) Changed paths: R lorentz Log Message: ----------- Merge branch 'master' of ssh://euclid.r.igoro.us/home/dustin/code/buildbot/t/buildbot Compare: https://github.com/buildbot/buildbot/compare/a14fd0c...c9323fd From nobody at buildbot.net Sun Jan 22 21:54:42 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 22 Jan 2012 21:54:42 -0000 Subject: [Buildbot-commits] [Buildbot] #1946: buildbot.steps.transfer._FileWriter uses __del__ In-Reply-To: <038.ac84b40eacc83bbeed29e7604c23ac9c@buildbot.net> References: <038.ac84b40eacc83bbeed29e7604c23ac9c@buildbot.net> Message-ID: <053.64a3d7294044bc00504ae6337f071cb0@buildbot.net> #1946: buildbot.steps.transfer._FileWriter uses __del__ ----------------------------------+--------------------- Reporter: dustin | Owner: Type: enhancement | Status: closed Priority: major | Milestone: 0.8.6 Version: master | Resolution: fixed Keywords: performance, transfer | ----------------------------------+--------------------- Changes (by Tom Prince): * status: new => closed * resolution: => fixed Comment: transfer: Remove __del__. Fixes #1946. Changeset: 6919655b27e7c8b5b81c0420ef802c18131bf42e -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Jan 23 06:16:48 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 23 Jan 2012 06:16:48 -0000 Subject: [Buildbot-commits] [Buildbot] #2182: deprecate compatibility with Twisted-8.x.x after 0.8.6 Message-ID: <038.223490c7b83417680ae2cbf57b74b762@buildbot.net> #2182: deprecate compatibility with Twisted-8.x.x after 0.8.6 ------------------------+------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.5 | Keywords: ------------------------+------------------- There are a few hacks specifically designed for 8.x.x compatibility. And it's almost 4 years old now. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Mon Jan 23 06:20:12 2012 From: noreply at github.com (GitHub) Date: Sun, 22 Jan 2012 22:20:12 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] 51f1f0: Indicate that Twisted-8.x.y compatibility is depre... Message-ID: <4f1cfc1ca7d82_44763fbfef0bf2f4367d9@sh1.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 51f1f0ee1daeb4c1b84de0ed59124920ddddbfd4 https://github.com/buildbot/buildbot/commit/51f1f0ee1daeb4c1b84de0ed59124920ddddbfd4 Author: Dustin J. Mitchell Date: 2012-01-22 (Sun, 22 Jan 2012) Changed paths: M master/docs/release-notes.rst Log Message: ----------- Indicate that Twisted-8.x.y compatibility is deprecated. Refs #2182. Commit: ef019badc23ba78112f182fcf1f56f90893a1171 https://github.com/buildbot/buildbot/commit/ef019badc23ba78112f182fcf1f56f90893a1171 Author: Dustin J. Mitchell Date: 2012-01-22 (Sun, 22 Jan 2012) Changed paths: M master/buildbot/steps/source/oldsource.py M master/buildbot/steps/transfer.py Log Message: ----------- Merge branch 'master' of github.com:buildbot/buildbot * 'master' of github.com:buildbot/buildbot: source: Make alwaysUseLatest ignore the SourceStamp's branch. transfer: Remove __del__. Compare: https://github.com/buildbot/buildbot/compare/c9323fd...ef019ba From nobody at buildbot.net Mon Jan 23 06:20:19 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 23 Jan 2012 06:20:19 -0000 Subject: [Buildbot-commits] [Buildbot] #2182: deprecate compatibility with Twisted-8.x.x after 0.8.6 In-Reply-To: <038.223490c7b83417680ae2cbf57b74b762@buildbot.net> References: <038.223490c7b83417680ae2cbf57b74b762@buildbot.net> Message-ID: <053.af4497e9582be8201043e1885034c6a0@buildbot.net> #2182: deprecate compatibility with Twisted-8.x.x after 0.8.6 ------------------------+-------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.5 | Resolution: Keywords: | ------------------------+-------------------- Comment (by Dustin J. Mitchell): Indicate that Twisted-8.x.y compatibility is deprecated. Refs #2182. Changeset: 51f1f0ee1daeb4c1b84de0ed59124920ddddbfd4 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Jan 23 12:22:21 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 23 Jan 2012 12:22:21 -0000 Subject: [Buildbot-commits] [Buildbot] #2127: Git 1.7.7: Recent change causes buildbot to always fail to fetch from git In-Reply-To: <040.4bdbb1fd8d851abd20e958f552f40733@buildbot.net> References: <040.4bdbb1fd8d851abd20e958f552f40733@buildbot.net> Message-ID: <055.0fcfe0b1de4e7f0fdd30fed5dede477e@buildbot.net> #2127: Git 1.7.7: Recent change causes buildbot to always fail to fetch from git ---------------------+------------------------ Reporter: cdavis5x | Owner: Type: defect | Status: closed Priority: critical | Milestone: undecided Version: master | Resolution: fixed Keywords: git | ---------------------+------------------------ Comment (by mattock): The backported fix was generated with {{{ git-format-patch 300fbcf...6f5ce3b }}} It can be applied on top of buildbot installed with ''easy_install''. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Mon Jan 23 15:47:40 2012 From: noreply at github.com (GitHub) Date: Mon, 23 Jan 2012 07:47:40 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] 95521c: Fix local variable 'patch' referenced before assig... Message-ID: <4f1d811c96882_ae33ff39004d2ec383776@sh1.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 95521c542a7ffa0d77499837fdf9bc51034e546e https://github.com/buildbot/buildbot/commit/95521c542a7ffa0d77499837fdf9bc51034e546e Author: Stuart Auchterlonie Date: 2012-01-23 (Mon, 23 Jan 2012) Changed paths: M master/buildbot/steps/source/oldsource.py Log Message: ----------- Fix local variable 'patch' referenced before assignment when alwaysUseLatest=True Commit: d972f0cf7b4fad68dbd5d2b13ca3549a1bf751a3 https://github.com/buildbot/buildbot/commit/d972f0cf7b4fad68dbd5d2b13ca3549a1bf751a3 Author: Dustin J. Mitchell Date: 2012-01-23 (Mon, 23 Jan 2012) Changed paths: M master/buildbot/steps/source/oldsource.py Log Message: ----------- Merge pull request #311 from stuarta/master Fix local variable 'patch' referenced before assignment when alwaysUseLatest=True Compare: https://github.com/buildbot/buildbot/compare/ef019ba...d972f0c From nobody at buildbot.net Mon Jan 23 17:23:18 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 23 Jan 2012 17:23:18 -0000 Subject: [Buildbot-commits] [Buildbot] #2183: SVNPoller stops after failure Message-ID: <037.681b6161918e718d0afe485e5788d0c3@buildbot.net> #2183: SVNPoller stops after failure ---------------------+----------------------- Reporter: fgsch | Owner: Type: defect | Status: new Priority: critical | Milestone: undecided Version: 0.8.5 | Keywords: ---------------------+----------------------- I arrived today at work and buildbot was not working. Checking the logs I found: 2012-01-20 02:30:28+0000 [-] SVNPoller: Error in while polling Traceback (most recent call last): Failure: twisted.internet.utils._UnexpectedErrorOutput: got stderr: "svn: REPORT request failed on '/xxx/!svn/bc/25979/packages/yyy/trunk'\nsvn: REPORT of '/xxx/!svn/bc/25979/packages/yyy/trunk': Could not read chunk size: Secure connection truncated (https://server)\n" And: 2012-01-20 02:32:25+0000 [-] Unhandled error in Deferred: 2012-01-20 02:32:25+0000 [-] Unhandled Error Traceback (most recent call last): Failure: twisted.internet.error.ProcessTerminated: A process has ended with a probable error condition: process ended with exit code 1. And another ocurrence for the second SVNPoller (my change_source polls 2 different locations within the same repo). After the second error the logs were showing only one polling. Before: 2012-01-20 02:26:23+0000 [-] SVNPoller: polling 2012-01-20 02:26:23+0000 [-] SVNPoller: polling 2012-01-20 02:26:25+0000 [-] SVNPoller: no changes 2012-01-20 02:26:25+0000 [-] SVNPoller: _process_changes 25898 .. 25898 2012-01-20 02:26:25+0000 [-] SVNPoller: finished polling None 2012-01-20 02:26:30+0000 [-] SVNPoller: no changes 2012-01-20 02:26:30+0000 [-] SVNPoller: _process_changes 25979 .. 25979 2012-01-20 02:26:30+0000 [-] SVNPoller: finished polling None After: 2012-01-23 09:44:23+0000 [-] SVNPoller: polling 2012-01-23 09:44:25+0000 [-] SVNPoller: no changes 2012-01-23 09:44:25+0000 [-] SVNPoller: _process_changes 25898 .. 25898 2012-01-23 09:44:25+0000 [-] SVNPoller: finished polling None Instance details: - twistd 11.1.0 - buildbot.version: 0.8.5 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Jan 23 17:27:41 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 23 Jan 2012 17:27:41 -0000 Subject: [Buildbot-commits] [Buildbot] #2183: SVNPoller stops after failure In-Reply-To: <037.681b6161918e718d0afe485e5788d0c3@buildbot.net> References: <037.681b6161918e718d0afe485e5788d0c3@buildbot.net> Message-ID: <052.abce7bfd07bc418599004ee18d10b8af@buildbot.net> #2183: SVNPoller stops after failure ---------------------+-------------------- Reporter: fgsch | Owner: Type: defect | Status: new Priority: critical | Milestone: 0.8.6 Version: 0.8.5 | Resolution: Keywords: | ---------------------+-------------------- Changes (by dustin): * milestone: undecided => 0.8.6 Old description: > I arrived today at work and buildbot was not working. > Checking the logs I found: > > 2012-01-20 02:30:28+0000 [-] SVNPoller: Error in while polling > Traceback (most recent call last): > Failure: twisted.internet.utils._UnexpectedErrorOutput: got > stderr: "svn: REPORT request failed on > '/xxx/!svn/bc/25979/packages/yyy/trunk'\nsvn: REPORT of > '/xxx/!svn/bc/25979/packages/yyy/trunk': Could not read chunk size: > Secure connection truncated (https://server)\n" > > And: > > 2012-01-20 02:32:25+0000 [-] Unhandled error in Deferred: > 2012-01-20 02:32:25+0000 [-] Unhandled Error > Traceback (most recent call last): > Failure: twisted.internet.error.ProcessTerminated: A process has > ended with a probable error condition: process ended with exit code 1. > > And another ocurrence for the second SVNPoller (my change_source polls 2 > different locations within the same repo). > > After the second error the logs were showing only one polling. > Before: > > 2012-01-20 02:26:23+0000 [-] SVNPoller: polling > 2012-01-20 02:26:23+0000 [-] SVNPoller: polling > 2012-01-20 02:26:25+0000 [-] SVNPoller: no changes > 2012-01-20 02:26:25+0000 [-] SVNPoller: _process_changes 25898 .. 25898 > 2012-01-20 02:26:25+0000 [-] SVNPoller: finished polling None > 2012-01-20 02:26:30+0000 [-] SVNPoller: no changes > 2012-01-20 02:26:30+0000 [-] SVNPoller: _process_changes 25979 .. 25979 > 2012-01-20 02:26:30+0000 [-] SVNPoller: finished polling None > > After: > > 2012-01-23 09:44:23+0000 [-] SVNPoller: polling > 2012-01-23 09:44:25+0000 [-] SVNPoller: no changes > 2012-01-23 09:44:25+0000 [-] SVNPoller: _process_changes 25898 .. 25898 > 2012-01-23 09:44:25+0000 [-] SVNPoller: finished polling None > > Instance details: > > - twistd 11.1.0 > - buildbot.version: 0.8.5 New description: I arrived today at work and buildbot was not working. Checking the logs I found: {{{ 2012-01-20 02:30:28+0000 [-] SVNPoller: Error in while polling Traceback (most recent call last): Failure: twisted.internet.utils._UnexpectedErrorOutput: got stderr: "svn: REPORT request failed on '/xxx/!svn/bc/25979/packages/yyy/trunk'\nsvn: REPORT of '/xxx/!svn/bc/25979/packages/yyy/trunk': Could not read chunk size: Secure connection truncated (https://server)\n" And: 2012-01-20 02:32:25+0000 [-] Unhandled error in Deferred: 2012-01-20 02:32:25+0000 [-] Unhandled Error Traceback (most recent call last): Failure: twisted.internet.error.ProcessTerminated: A process has ended with a probable error condition: process ended with exit code 1. }}} And another ocurrence for the second SVNPoller (my change_source polls 2 different locations within the same repo). After the second error the logs were showing only one polling. Before: {{{ 2012-01-20 02:26:23+0000 [-] SVNPoller: polling 2012-01-20 02:26:23+0000 [-] SVNPoller: polling 2012-01-20 02:26:25+0000 [-] SVNPoller: no changes 2012-01-20 02:26:25+0000 [-] SVNPoller: _process_changes 25898 .. 25898 2012-01-20 02:26:25+0000 [-] SVNPoller: finished polling None 2012-01-20 02:26:30+0000 [-] SVNPoller: no changes 2012-01-20 02:26:30+0000 [-] SVNPoller: _process_changes 25979 .. 25979 2012-01-20 02:26:30+0000 [-] SVNPoller: finished polling None }}} After: {{{ 2012-01-23 09:44:23+0000 [-] SVNPoller: polling 2012-01-23 09:44:25+0000 [-] SVNPoller: no changes 2012-01-23 09:44:25+0000 [-] SVNPoller: _process_changes 25898 .. 25898 2012-01-23 09:44:25+0000 [-] SVNPoller: finished polling None }}} Instance details: * twistd 11.1.0 * buildbot.version: 0.8.5 -- -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Tue Jan 24 04:36:14 2012 From: noreply at github.com (GitHub) Date: Mon, 23 Jan 2012 20:36:14 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] ebe76c: Add some tests for alwaysUseLatest. Message-ID: <4f1e353ecc7f8_66d33f8b2a8e1af8288e0@sh1.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: ebe76c0ead052aaa32dd61f8c7392c2a56ebc45e https://github.com/buildbot/buildbot/commit/ebe76c0ead052aaa32dd61f8c7392c2a56ebc45e Author: Tom Prince Date: 2012-01-23 (Mon, 23 Jan 2012) Changed paths: M master/buildbot/test/unit/test_steps_source_oldsource_Source.py Log Message: ----------- Add some tests for alwaysUseLatest. This catches the bugs fixed in c303d1037439a77a9079c15b859e812c8d2ff426 and 95521c542a7ffa0d77499837fdf9bc51034e546e Commit: 9a87837518909dd0fbc78a8361419d892b1aaab6 https://github.com/buildbot/buildbot/commit/9a87837518909dd0fbc78a8361419d892b1aaab6 Author: Tom Prince Date: 2012-01-23 (Mon, 23 Jan 2012) Changed paths: M master/buildbot/test/unit/test_steps_source_oldsource_Source.py Log Message: ----------- Merge pull request #312 from tomprince/always-use-latest-tests Add some tests for alwaysUseLatest. Compare: https://github.com/buildbot/buildbot/compare/d972f0c...9a87837 From nobody at buildbot.net Tue Jan 24 07:19:48 2012 From: nobody at buildbot.net (Buildbot) Date: Tue, 24 Jan 2012 07:19:48 -0000 Subject: [Buildbot-commits] [Buildbot] #2149: "Stop build" button cannot kill dependent schedule In-Reply-To: <035.16ba8e8d373d7917569116956748908b@buildbot.net> References: <035.16ba8e8d373d7917569116956748908b@buildbot.net> Message-ID: <050.8fd0bb283bace1c993d3e0faa752c20e@buildbot.net> #2149: "Stop build" button cannot kill dependent schedule --------------------+------------------------ Reporter: pwp | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.4p2 | Resolution: Keywords: | --------------------+------------------------ Comment (by pwp): Say there is a scheduler called sched, and then create another dependent scheduler sched1 sched1 = Dependent(upstream=sched, name="test", builderNames=test?) cschedulers.append(sched1) If sched1 is calling cmd1 underneath, pressing Stop build button cannot kill dependent schedule cmd1 and sched1. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Tue Jan 24 17:16:44 2012 From: noreply at github.com (GitHub) Date: Tue, 24 Jan 2012 09:16:44 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] 95deef: Re-run queries after certain OperationalErrors Message-ID: <4f1ee77c144f7_1bd93fc100dce2f8186577@sh1.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 95deef27d7c531ead19e0ac86a9aa1546d4ee7f9 https://github.com/buildbot/buildbot/commit/95deef27d7c531ead19e0ac86a9aa1546d4ee7f9 Author: Dustin J. Mitchell Date: 2012-01-23 (Mon, 23 Jan 2012) Changed paths: M master/buildbot/db/pool.py M master/buildbot/test/unit/test_db_pool.py Log Message: ----------- Re-run queries after certain OperationalErrors Sometimes malformed SQL can generate an OperationalError, so this looks at the message itself. It's unclear how this will work with localization. The code uses an exponential backoff algorithm (with a relatively small multiplier), and will retry for a day, which seems a reasonable get-the-db-server-fixed time. Fixes #2005. Hoepfully for good! Commit: 6a37b90add743e4e6f10b6cfe4eef82180941e31 https://github.com/buildbot/buildbot/commit/6a37b90add743e4e6f10b6cfe4eef82180941e31 Author: Dustin J. Mitchell Date: 2012-01-24 (Tue, 24 Jan 2012) Changed paths: M master/buildbot/db/pool.py M master/buildbot/test/unit/test_db_pool.py Log Message: ----------- Merge branch 'bug2005' * bug2005: Re-run queries after certain OperationalErrors Compare: https://github.com/buildbot/buildbot/compare/9a87837...6a37b90 From nobody at buildbot.net Tue Jan 24 17:16:49 2012 From: nobody at buildbot.net (Buildbot) Date: Tue, 24 Jan 2012 17:16:49 -0000 Subject: [Buildbot-commits] [Buildbot] #2005: SQLAlchemy Operational errors with SQLite: Database is locked In-Reply-To: <040.08a071a74acf7400775dd33a90e10ace@buildbot.net> References: <040.08a071a74acf7400775dd33a90e10ace@buildbot.net> Message-ID: <055.7b512bc003ea8558e96c9aa9b2daf2ee@buildbot.net> #2005: SQLAlchemy Operational errors with SQLite: Database is locked ---------------------+--------------------- Reporter: abompard | Owner: Type: defect | Status: closed Priority: critical | Milestone: 0.8.5 Version: 0.8.4p1 | Resolution: fixed Keywords: database | ---------------------+--------------------- Changes (by Dustin J. Mitchell): * status: reopened => closed * resolution: => fixed Comment: Re-run queries after certain OperationalErrors Sometimes malformed SQL can generate an OperationalError, so this looks at the message itself. It's unclear how this will work with localization. The code uses an exponential backoff algorithm (with a relatively small multiplier), and will retry for a day, which seems a reasonable get-the-db-server-fixed time. Fixes #2005. Hoepfully for good! Changeset: 95deef27d7c531ead19e0ac86a9aa1546d4ee7f9 -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Tue Jan 24 17:28:58 2012 From: noreply at github.com (GitHub) Date: Tue, 24 Jan 2012 09:28:58 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] 08bb41: python2.4-compatible syntax Message-ID: <4f1eea5a1299_4b93f9a22870af4246821@sh1.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 08bb41932ae3834c4684ad44d5d462121ae73a21 https://github.com/buildbot/buildbot/commit/08bb41932ae3834c4684ad44d5d462121ae73a21 Author: Dustin J. Mitchell Date: 2012-01-24 (Tue, 24 Jan 2012) Changed paths: M master/buildbot/db/pool.py Log Message: ----------- python2.4-compatible syntax From noreply at github.com Wed Jan 25 04:43:19 2012 From: noreply at github.com (GitHub) Date: Tue, 24 Jan 2012 20:43:19 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] ba520e: add transactions to all multiple-statement db meth... Message-ID: <4f1f886735487_1983fe2f2dddaf0513ea@sh1.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: ba520efdaa69f6715875a740a89ab8c8d6fb81e2 https://github.com/buildbot/buildbot/commit/ba520efdaa69f6715875a740a89ab8c8d6fb81e2 Author: Dustin J. Mitchell Date: 2012-01-24 (Tue, 24 Jan 2012) Changed paths: M master/buildbot/db/builds.py M master/buildbot/db/schedulers.py M master/buildbot/db/sourcestamps.py M master/buildbot/db/users.py Log Message: ----------- add transactions to all multiple-statement db methods From nobody at buildbot.net Wed Jan 25 17:00:10 2012 From: nobody at buildbot.net (Buildbot) Date: Wed, 25 Jan 2012 17:00:10 -0000 Subject: [Buildbot-commits] [Buildbot] #2183: SVNPoller stops after failure In-Reply-To: <037.681b6161918e718d0afe485e5788d0c3@buildbot.net> References: <037.681b6161918e718d0afe485e5788d0c3@buildbot.net> Message-ID: <052.fc7abc3e070c49104dc8b6783e5429e2@buildbot.net> #2183: SVNPoller stops after failure ---------------------+-------------------- Reporter: fgsch | Owner: Type: defect | Status: new Priority: critical | Milestone: 0.8.6 Version: 0.8.5 | Resolution: Keywords: | ---------------------+-------------------- Comment (by dustin): I may need some more information here. The first error is expected -- it's reporting a failure -- but I don't see how that would stop the poller from doing its polling thing. The string "Error in while polling" is from {{{ #! python d.addErrback(log.err, 'SVNPoller: Error while polling:') # eat errors return d }}} in `poll()`. That's an unconditional "if an error occurs, log it and resume normal processing of the deferred". So that deferred's next value is a successful None. Back in `base.py`, `poll()` is called in {{{ #! python def do_poll(): d = defer.maybeDeferred(self.poll) d.addErrback(log.err, 'while polling for changes') return d }}} which is *another* unconditional catch-all. And while your log snippets are abbreviated, I assume you would have included this output if it existed. That it doesn't makes sense - that deferred was successful. So the LoopingCall has no reason to stop looping. Now, the second error, almost two minutes later: {{{ 2012-01-20 02:32:25+0000 [-] Unhandled error in Deferred: }}} That's clearly not related to the *same* failure as two minutes earlier, and in fact it's not obvious that's related to svn at all. Looking at the invocations of `getProcessOutput` in the poller, all feed their deferreds back into the main `poll` deferred, which as we've seen is protected against unhandled errors. I think the next step is to figure out what that second, unhandled error is about, as that will point us to the bug. Can you tell what was around that in the logs? If not, we may need to add some debugging code. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Jan 25 20:20:01 2012 From: nobody at buildbot.net (Buildbot) Date: Wed, 25 Jan 2012 20:20:01 -0000 Subject: [Buildbot-commits] [Buildbot] #2183: SVNPoller stops after failure In-Reply-To: <037.681b6161918e718d0afe485e5788d0c3@buildbot.net> References: <037.681b6161918e718d0afe485e5788d0c3@buildbot.net> Message-ID: <052.5f17c0c166d2605a8d37c5b5a5f697ba@buildbot.net> #2183: SVNPoller stops after failure ---------------------+-------------------- Reporter: fgsch | Owner: Type: defect | Status: new Priority: critical | Milestone: 0.8.6 Version: 0.8.5 | Resolution: Keywords: | ---------------------+-------------------- Comment (by fgsch): Unfortunately there was nothing else between those 2 logs, all the information I had is in this report. Let me know what debugging code I need to add should this happen again. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Jan 25 21:22:27 2012 From: nobody at buildbot.net (Buildbot) Date: Wed, 25 Jan 2012 21:22:27 -0000 Subject: [Buildbot-commits] [Buildbot] #2184: hgbuildbot.py produces changes with bogus repository strings Message-ID: <038.16b7093fed5c08a337a60eba314b5221@buildbot.net> #2184: hgbuildbot.py produces changes with bogus repository strings -------------------+--------------------- Reporter: dustin | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.6 Version: 0.8.5 | Keywords: hg docs -------------------+--------------------- It's stripping components from the left of the string, so that the result is a right-aligned substring of the full URL. This should, instead, be the full URL. Also, the meaning of 'repository' and 'project' should be *much* more clearly documented. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Thu Jan 26 04:12:45 2012 From: nobody at buildbot.net (Buildbot) Date: Thu, 26 Jan 2012 04:12:45 -0000 Subject: [Buildbot-commits] [Buildbot] #2183: SVNPoller stops after failure In-Reply-To: <037.681b6161918e718d0afe485e5788d0c3@buildbot.net> References: <037.681b6161918e718d0afe485e5788d0c3@buildbot.net> Message-ID: <052.e9a87777ec1b1071e34f75bbf5b1b922@buildbot.net> #2183: SVNPoller stops after failure ---------------------+-------------------- Reporter: fgsch | Owner: Type: defect | Status: new Priority: critical | Milestone: 0.8.6 Version: 0.8.5 | Resolution: Keywords: | ---------------------+-------------------- Comment (by dustin): How often does your poller run? Try this: {{{ #!patch diff --git a/master/buildbot/changes/svnpoller.py b/master/buildbot/changes/svnpoller.py index 93c14bb..70845b2 100644 --- a/master/buildbot/changes/svnpoller.py +++ b/master/buildbot/changes/svnpoller.py @@ -162,10 +162,16 @@ class SVNPoller(base.PollingChangeSource, util.ComparableMixin): def getProcessOutput(self, args): # this exists so we can override it during the unit tests + log.msg("svnpoller %s GPO %s" % (self.svnurl, args)) d = utils.getProcessOutput(self.svnbin, args, self.environ) + @d.addBoth + def report(x): + log.msg("svnpoller %s GPO %s -> %s" % (self.svnurl, args, x)) + return x return d def get_prefix(self): + log.msg("svnpoller %s get_prefix" % (self.svnurl,)) args = ["info", "--xml", "--non-interactive", self.svnurl] if self.svnuser: args.extend(["--username=%s" % self.svnuser]) @@ -201,6 +207,7 @@ class SVNPoller(base.PollingChangeSource, util.ComparableMixin): return d def get_logs(self, _): + log.msg("svnpoller %s get_logs" % (self.svnurl,)) args = [] args.extend(["log", "--xml", "--verbose", "--non-interactive"]) if self.svnuser: @@ -212,6 +219,7 @@ class SVNPoller(base.PollingChangeSource, util.ComparableMixin): return d def parse_logs(self, output): + log.msg("svnpoller %s parse_logs" % (self.svnurl,)) # parse the XML output, return a list of nodes try: doc = xml.dom.minidom.parseString(output) @@ -223,6 +231,7 @@ class SVNPoller(base.PollingChangeSource, util.ComparableMixin): def get_new_logentries(self, logentries): + log.msg("svnpoller %s get_new_logentries" % (self.svnurl,)) last_change = old_last_change = self.last_change # given a list of logentries, calculate new_last_change, and @@ -275,6 +284,7 @@ class SVNPoller(base.PollingChangeSource, util.ComparableMixin): return where def create_changes(self, new_logentries): + log.msg("svnpoller %s create_changes" % (self.svnurl,)) changes = [] for el in new_logentries: @@ -348,6 +358,7 @@ class SVNPoller(base.PollingChangeSource, util.ComparableMixin): @defer.deferredGenerator def submit_changes(self, changes): + log.msg("svnpoller %s submit_changes" % (self.svnurl,)) for chdict in changes: wfd = defer.waitForDeferred(self.master.addChange(src='svn', **chdict)) @@ -355,6 +366,7 @@ class SVNPoller(base.PollingChangeSource, util.ComparableMixin): wfd.getResult() def finished_ok(self, res): + log.msg("svnpoller %s finished_ok" % (self.svnurl,)) if self.cachepath: f = open(self.cachepath, "w") f.write(str(self.last_change)) }}} -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Thu Jan 26 04:14:49 2012 From: noreply at github.com (GitHub) Date: Wed, 25 Jan 2012 20:14:49 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] 1ea56d: add tests for svn command failures in svnpoller Message-ID: <4f20d339d989_14743fa2e0ef62f4169964@sh1.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 1ea56daebbf37c337040dea43156ee51f1c1e16a https://github.com/buildbot/buildbot/commit/1ea56daebbf37c337040dea43156ee51f1c1e16a Author: Dustin J. Mitchell Date: 2012-01-25 (Wed, 25 Jan 2012) Changed paths: M master/buildbot/test/unit/test_changes_svnpoller.py Log Message: ----------- add tests for svn command failures in svnpoller Refs #2138. It doesn't fix this bug, but at least tests the obvious suspects. From nobody at buildbot.net Thu Jan 26 04:14:55 2012 From: nobody at buildbot.net (Buildbot) Date: Thu, 26 Jan 2012 04:14:55 -0000 Subject: [Buildbot-commits] [Buildbot] #2138: ability to plug-in new slave-side commands In-Reply-To: <038.1ae0499b220d892beff33bf2becdf64d@buildbot.net> References: <038.1ae0499b220d892beff33bf2becdf64d@buildbot.net> Message-ID: <053.2d2d4b091922d6bab9412bfa5c5d2bc1@buildbot.net> #2138: ability to plug-in new slave-side commands ------------------------+--------------------- Reporter: dustin | Owner: dustin Type: enhancement | Status: new Priority: major | Milestone: 0.8.6 Version: 0.8.5 | Resolution: Keywords: | ------------------------+--------------------- Comment (by Dustin J. Mitchell): add tests for svn command failures in svnpoller Refs #2138. It doesn't fix this bug, but at least tests the obvious suspects. Changeset: 1ea56daebbf37c337040dea43156ee51f1c1e16a -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Thu Jan 26 04:24:42 2012 From: nobody at buildbot.net (Buildbot) Date: Thu, 26 Jan 2012 04:24:42 -0000 Subject: [Buildbot-commits] [Buildbot] #2138: ability to plug-in new slave-side commands In-Reply-To: <038.1ae0499b220d892beff33bf2becdf64d@buildbot.net> References: <038.1ae0499b220d892beff33bf2becdf64d@buildbot.net> Message-ID: <053.0eb5c33192aa899f7890eae9f9908689@buildbot.net> #2138: ability to plug-in new slave-side commands ------------------------+--------------------- Reporter: dustin | Owner: dustin Type: enhancement | Status: new Priority: major | Milestone: 0.8.6 Version: 0.8.5 | Resolution: Keywords: | ------------------------+--------------------- Comment (by dustin): Er, wrong bug - should have been #2183. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Jan 27 00:54:07 2012 From: nobody at buildbot.net (Buildbot) Date: Fri, 27 Jan 2012 00:54:07 -0000 Subject: [Buildbot-commits] [Buildbot] #2183: SVNPoller stops after failure In-Reply-To: <037.681b6161918e718d0afe485e5788d0c3@buildbot.net> References: <037.681b6161918e718d0afe485e5788d0c3@buildbot.net> Message-ID: <052.79d030a6d493d379d6e7a0cf74fd8154@buildbot.net> #2183: SVNPoller stops after failure ---------------------+-------------------- Reporter: fgsch | Owner: Type: defect | Status: new Priority: critical | Milestone: 0.8.6 Version: 0.8.5 | Resolution: Keywords: | ---------------------+-------------------- Comment (by fgsch): Currently it runs every minute but I will apply your diff and change it to 5 minutes on Monday. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Jan 27 11:05:07 2012 From: nobody at buildbot.net (Buildbot) Date: Fri, 27 Jan 2012 11:05:07 -0000 Subject: [Buildbot-commits] [Buildbot] #2185: GerritChangeSource: owner email can be missing Message-ID: <039.707d8b986e252d06445abb3b8223c4d3@buildbot.net> #2185: GerritChangeSource: owner email can be missing --------------------+----------------------- Reporter: sanxiyn | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.5 | Keywords: gerrit --------------------+----------------------- I got: {{{ Traceback (most recent call last): File "/home/tinuviel/buildbot/master/gerritchangesource.py", line 125, in eventReceived_patchset_created author="%s <%s>" % (change["owner"]["name"], change["owner"]["email"]), exceptions.KeyError: 'email' }}} In general, as you can read at [http://gerrit- documentation.googlecode.com/svn/Documentation/2.2.2/json.html Gerrit documentation], "any field may be missing in the JSON messages, so consumers of this JSON stream should deal with that appropriately". -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sat Jan 28 01:42:42 2012 From: noreply at github.com (GitHub) Date: Fri, 27 Jan 2012 17:42:42 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] 9a18fd: Fix db.users findUserByAttr to return the correct ... Message-ID: <4f235292b5b52_55c93f8792bb9af060515@sh1.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 9a18fd12e302f2b6e179e9f9ebeaf656617abf38 https://github.com/buildbot/buildbot/commit/9a18fd12e302f2b6e179e9f9ebeaf656617abf38 Author: jdolson Date: 2012-01-26 (Thu, 26 Jan 2012) Changed paths: M master/buildbot/db/users.py M master/buildbot/test/unit/test_db_users.py Log Message: ----------- Fix db.users findUserByAttr to return the correct user includes a test to catch this error Commit: 85b5f20026574cdf905f961717c7532df4dbe42b https://github.com/buildbot/buildbot/commit/85b5f20026574cdf905f961717c7532df4dbe42b Author: Dustin J. Mitchell Date: 2012-01-27 (Fri, 27 Jan 2012) Changed paths: M master/buildbot/db/users.py M master/buildbot/test/unit/test_db_users.py Log Message: ----------- Merge branch 'db_users_patch' of git://github.com/solarmist/buildbot * 'db_users_patch' of git://github.com/solarmist/buildbot: Fix db.users findUserByAttr to return the correct user includes a test to catch this error Compare: https://github.com/buildbot/buildbot/compare/1ea56da...85b5f20 From noreply at github.com Sat Jan 28 02:05:09 2012 From: noreply at github.com (GitHub) Date: Fri, 27 Jan 2012 18:05:09 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] 4ddda3: fix unintentional dependency on result-set order Message-ID: <4f2357d5aa585_5f213ff36896caf8948c4@sh1.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 4ddda37c7d341d4d0c5b1600b264d8b84d187a98 https://github.com/buildbot/buildbot/commit/4ddda37c7d341d4d0c5b1600b264d8b84d187a98 Author: Dustin J. Mitchell Date: 2012-01-27 (Fri, 27 Jan 2012) Changed paths: M master/buildbot/test/unit/test_db_users.py Log Message: ----------- fix unintentional dependency on result-set order From noreply at github.com Sat Jan 28 20:44:22 2012 From: noreply at github.com (GitHub) Date: Sat, 28 Jan 2012 12:44:22 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] 5c794a: fix AttributeError in BuilderStatus.asDict Message-ID: <4f245e26896f1_2d123f8bae05d2f442309b@sh1.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 5c794af9f0937fac6d161b6dd8d1c3a2d5491e66 https://github.com/buildbot/buildbot/commit/5c794af9f0937fac6d161b6dd8d1c3a2d5491e66 Author: Dustin J. Mitchell Date: 2012-01-28 (Sat, 28 Jan 2012) Changed paths: M master/buildbot/status/builder.py Log Message: ----------- fix AttributeError in BuilderStatus.asDict From nobody at buildbot.net Sun Jan 29 20:43:24 2012 From: nobody at buildbot.net (Buildbot) Date: Sun, 29 Jan 2012 20:43:24 -0000 Subject: [Buildbot-commits] [Buildbot] #456: Slave's ShellCommand and msys are broken In-Reply-To: <036.bc75f521bf32e05852d1430271013ff5@buildbot.net> References: <036.bc75f521bf32e05852d1430271013ff5@buildbot.net> Message-ID: <051.7d169a403cc1edea3f04fcd165686ab5@buildbot.net> #456: Slave's ShellCommand and msys are broken --------------------+----------------------- Reporter: even | Owner: even Type: defect | Status: reopened Priority: major | Milestone: 0.8.+ Version: 0.7.10 | Resolution: Keywords: windows | --------------------+----------------------- Comment (by hushp1pt): Replying to above: > For extra credit, ... Hi, please forget all about that "for extra credit" idea- my mistake. Please reconsider the simple bug fix dustin proposed, > Could we add a !ShellCommand option that would be passed to the slave to enable this particular behavior? I suggest the new !ShellCommand option be named {{{with_cygwin_path}}}. If {{{with_cygwin_path}}} == None, no change- same as regular Windows process. If != None, skip the PWD reset in runprocess.py. Thanks. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Jan 30 00:13:29 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 30 Jan 2012 00:13:29 -0000 Subject: [Buildbot-commits] [Buildbot] #2186: github change_hook needs security by default Message-ID: <040.b0011a230d9ec9a00c8a78bbb647063d@buildbot.net> #2186: github change_hook needs security by default ------------------------+------------------------ Reporter: stefanha | Owner: Type: enhancement | Status: new Priority: major | Milestone: undecided Version: 0.8.5 | Keywords: github,web ------------------------+------------------------ The github change_hook allows Github POST requests to trigger builds. It is part of WebStatus and can be accessed via http://server/change_hook/github. The buildbot documentation does not explain the security implications of enabling this change_hook. From what I can tell there are no checks in place to ensure the HTTP request is really from Github. Anyone who pokes this URL will be able to trigger builds. It's also not clear to me whether builds are restricted to just the git repositories configured on the buildmaster or whether the repo URL from the HTTP request will be used. Please document the security implications of the github change_hook. I suggest supporting a secret token that can be configured both on the buildmaster and github side. If the HTTP request does not include the secret token then it will be denied. One way of doing this would be to customize the github change_hook URI, e.g. http://server/change_hook/1e505aa83c25910, so that it is not guessable. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Jan 30 01:04:35 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 30 Jan 2012 01:04:35 -0000 Subject: [Buildbot-commits] [Buildbot] #2187: test and enable support for sqlalchemy-migrate 0.7.2 Message-ID: <038.4203be0a3c83015e92c248537d1d6ef1@buildbot.net> #2187: test and enable support for sqlalchemy-migrate 0.7.2 ------------------------+------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.6 Version: 0.8.5 | Keywords: ------------------------+------------------- Recently released, maybe with fewer bugs! -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Jan 30 01:08:21 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 30 Jan 2012 01:08:21 -0000 Subject: [Buildbot-commits] [Buildbot] #2149: "Stop build" button cannot kill dependent schedule In-Reply-To: <035.16ba8e8d373d7917569116956748908b@buildbot.net> References: <035.16ba8e8d373d7917569116956748908b@buildbot.net> Message-ID: <050.54165fc6bd5ede75ab00b2decfebfe5f@buildbot.net> #2149: "Stop build" button cannot kill dependent schedule --------------------+------------------------ Reporter: pwp | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.4p2 | Resolution: Keywords: | --------------------+------------------------ Comment (by dustin): OK, here's what I did to try to replicate: {{{ c['schedulers'].append(ForceScheduler( name="force", builderNames=["builder"])) c['schedulers'].append(dependent.Dependent(name="dep", builderNames=[ 'builder2', ], upstream=c['schedulers'][-1])) }}} I then forced a build on 'builder'. The dependent correctly triggered a build on 'builder2'. I hit the "stop build" there, and the build stopped. I'm confused by your replication recipe -- schedulers don't call commands, and the "Stop Build" button doesn't kill schedulers (or "schedules", which isn't a concept in Buildbot). -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Mon Jan 30 01:44:39 2012 From: noreply at github.com (GitHub) Date: Sun, 29 Jan 2012 17:44:39 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] c91acd: do a better job of simulating a race condition Message-ID: <4f25f6076a86a_54f3fc65d82e2f0994b0@sh1.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: c91acdf108203c01f03e01e5d753c7a2137a8292 https://github.com/buildbot/buildbot/commit/c91acdf108203c01f03e01e5d753c7a2137a8292 Author: Dustin J. Mitchell Date: 2012-01-29 (Sun, 29 Jan 2012) Changed paths: M master/buildbot/db/users.py M master/buildbot/test/unit/test_db_users.py Log Message: ----------- do a better job of simulating a race condition From noreply at github.com Mon Jan 30 03:27:55 2012 From: noreply at github.com (GitHub) Date: Sun, 29 Jan 2012 19:27:55 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] fd82b9: Add missing asDict() method on BuildSetStatus. Message-ID: <4f260e3b4ca66_70ab3fcde1db2aec165791@sh1.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: fd82b9244a57ccc360c7dae4c6d461c11c8e296a https://github.com/buildbot/buildbot/commit/fd82b9244a57ccc360c7dae4c6d461c11c8e296a Author: Amar Takhar Date: 2012-01-29 (Sun, 29 Jan 2012) Changed paths: M master/buildbot/status/buildset.py Log Message: ----------- Add missing asDict() method on BuildSetStatus. From nobody at buildbot.net Mon Jan 30 05:09:42 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 30 Jan 2012 05:09:42 -0000 Subject: [Buildbot-commits] [Buildbot] #2188: status targets are replaced, even if their configuration is unchanged. Message-ID: <042.92a01be8422aa1bf756415ec9d9859ef@buildbot.net> #2188: status targets are replaced, even if their configuration is unchanged. ------------------------+------------------- Reporter: tom.prince | Owner: Type: enhancement | Status: new Priority: trivial | Milestone: 0.8.+ Version: master | Keywords: ------------------------+------------------- -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Jan 30 05:53:42 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 30 Jan 2012 05:53:42 -0000 Subject: [Buildbot-commits] [Buildbot] #2188: status targets are replaced, even if their configuration is unchanged. In-Reply-To: <042.92a01be8422aa1bf756415ec9d9859ef@buildbot.net> References: <042.92a01be8422aa1bf756415ec9d9859ef@buildbot.net> Message-ID: <057.249d912ab84c0344b78e04ff3f1c4e16@buildbot.net> #2188: status targets are replaced, even if their configuration is unchanged. ------------------------+-------------------- Reporter: tom.prince | Owner: Type: enhancement | Status: new Priority: trivial | Milestone: 0.8.+ Version: master | Resolution: Keywords: | ------------------------+-------------------- Comment (by dustin): Yeah, this is historic behavior, and not *that* easily fixed since status targets don't have names. It would make the !WebStatus a lot more reliable if it didn't get yanked and re-created on every reconfig. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Mon Jan 30 06:21:25 2012 From: noreply at github.com (GitHub) Date: Sun, 29 Jan 2012 22:21:25 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] 14b318: remove spurious MANIFEST.in line Message-ID: <4f2636e51fdb1_39d63f83beb912f8578f0@sh1.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 14b3181d6a4f9ca52312449cf743bc035f3649d7 https://github.com/buildbot/buildbot/commit/14b3181d6a4f9ca52312449cf743bc035f3649d7 Author: Dustin J. Mitchell Date: 2012-01-29 (Sun, 29 Jan 2012) Changed paths: M master/MANIFEST.in Log Message: ----------- remove spurious MANIFEST.in line Commit: d25a07f2e7d3f827a15f98a131f29382b20fd87c https://github.com/buildbot/buildbot/commit/d25a07f2e7d3f827a15f98a131f29382b20fd87c Author: Dustin J. Mitchell Date: 2012-01-29 (Sun, 29 Jan 2012) Changed paths: M master/buildbot/status/buildset.py Log Message: ----------- Merge branch 'master' of github.com:buildbot/buildbot * 'master' of github.com:buildbot/buildbot: Add missing asDict() method on BuildSetStatus. Compare: https://github.com/buildbot/buildbot/compare/fd82b92...d25a07f From noreply at github.com Mon Jan 30 06:31:32 2012 From: noreply at github.com (GitHub) Date: Sun, 29 Jan 2012 22:31:32 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] 596916: last rites for BK Message-ID: <4f26394456eb5_3713fbc6530baf42243dd@sh1.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 59691638c88a913390b23a1d56841c72dcb9a4ff https://github.com/buildbot/buildbot/commit/59691638c88a913390b23a1d56841c72dcb9a4ff Author: Dustin J. Mitchell Date: 2012-01-29 (Sun, 29 Jan 2012) Changed paths: M MAINTAINERS.txt M master/docs/release-notes.rst Log Message: ----------- last rites for BK From nobody at buildbot.net Mon Jan 30 10:35:42 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 30 Jan 2012 10:35:42 -0000 Subject: [Buildbot-commits] [Buildbot] #2149: "Stop build" button cannot kill dependent schedule In-Reply-To: <035.16ba8e8d373d7917569116956748908b@buildbot.net> References: <035.16ba8e8d373d7917569116956748908b@buildbot.net> Message-ID: <050.eaed78d600f13dc44ad9f1b0c7927b2a@buildbot.net> #2149: "Stop build" button cannot kill dependent schedule --------------------+------------------------ Reporter: pwp | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.4p2 | Resolution: Keywords: | --------------------+------------------------ Comment (by pwp): Would multiple-step builder make a difference here? Our dependent builder has 10 steps. We always wanted to kill a middle step which failed. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Jan 30 15:32:29 2012 From: nobody at buildbot.net (Buildbot) Date: Mon, 30 Jan 2012 15:32:29 -0000 Subject: [Buildbot-commits] [Buildbot] #2149: "Stop build" button cannot kill dependent schedule In-Reply-To: <035.16ba8e8d373d7917569116956748908b@buildbot.net> References: <035.16ba8e8d373d7917569116956748908b@buildbot.net> Message-ID: <050.7ae16ef088f2238af526a7f9302cb71e@buildbot.net> #2149: "Stop build" button cannot kill dependent schedule --------------------+------------------------ Reporter: pwp | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.4p2 | Resolution: Keywords: | --------------------+------------------------ Comment (by dustin): It shouldn't make a difference. You still haven't told me precisely what you're seeing, so it's hard to say. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Mon Jan 30 17:03:44 2012 From: noreply at github.com (GitHub) Date: Mon, 30 Jan 2012 09:03:44 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] 4247d4: Merge pull request #315 from funman/irc Message-ID: <4f26cd70afb16_5323f90210d9af838196@sh1.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 4247d4fe811d62ea806fe2cd3df58f923fa79ac2 https://github.com/buildbot/buildbot/commit/4247d4fe811d62ea806fe2cd3df58f923fa79ac2 Author: Tom Prince Date: 2012-01-30 (Mon, 30 Jan 2012) Changed paths: M master/buildbot/status/words.py M master/docs/manual/cfg-statustargets.rst M master/docs/release-notes.rst Log Message: ----------- Merge pull request #315 from funman/irc IRC: add colored messages From nobody at buildbot.net Tue Jan 31 06:16:56 2012 From: nobody at buildbot.net (Buildbot) Date: Tue, 31 Jan 2012 06:16:56 -0000 Subject: [Buildbot-commits] [Buildbot] #2189: buildbot upgrade-master should refuse to run, with a running master. Message-ID: <042.dac33b22b01f1a47787ecf254636d309@buildbot.net> #2189: buildbot upgrade-master should refuse to run, with a running master. -----------------------+----------------------- Reporter: tom.prince | Owner: Type: defect | Status: new Priority: trivial | Milestone: undecided Version: master | Keywords: -----------------------+----------------------- -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Tue Jan 31 07:25:25 2012 From: nobody at buildbot.net (Buildbot) Date: Tue, 31 Jan 2012 07:25:25 -0000 Subject: [Buildbot-commits] [Buildbot] #2149: "Stop build" button cannot kill dependent schedule In-Reply-To: <035.16ba8e8d373d7917569116956748908b@buildbot.net> References: <035.16ba8e8d373d7917569116956748908b@buildbot.net> Message-ID: <050.008f73ff9844ab85dad6c327e5fc9ada@buildbot.net> #2149: "Stop build" button cannot kill dependent schedule --------------------+------------------------ Reporter: pwp | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.4p2 | Resolution: Keywords: | --------------------+------------------------ Comment (by pwp): When I click the stop button, nothing happened. Everything is running as usual. I can click the button as many times as I want. BTW, the builder is running in buildmaster by using MasterShellCommand() But if I go to buildmaster to kill (without -9, just kill cmd) the process, buildbot can show the builder as an exception. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Tue Jan 31 07:32:03 2012 From: nobody at buildbot.net (Buildbot) Date: Tue, 31 Jan 2012 07:32:03 -0000 Subject: [Buildbot-commits] [Buildbot] #2149: MasterShellCommand cannot be interrupted (was: "Stop build" button cannot kill dependent schedule) In-Reply-To: <035.16ba8e8d373d7917569116956748908b@buildbot.net> References: <035.16ba8e8d373d7917569116956748908b@buildbot.net> Message-ID: <050.b64bc7344d755bb6c7c255a03f01003a@buildbot.net> #2149: MasterShellCommand cannot be interrupted --------------------+-------------------- Reporter: pwp | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.4p2 | Resolution: Keywords: | --------------------+-------------------- Changes (by dustin): * milestone: undecided => 0.8.+ Comment: Ah! I suspect you've incidentally mentioned what is actually the culprit here. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Tue Jan 31 07:35:45 2012 From: noreply at github.com (GitHub) Date: Mon, 30 Jan 2012 23:35:45 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] 093f89: Add support for sqlalchemy-migrate-0.7.2 Message-ID: <4f2799d1900f_57cc3f9069042afc718f5@sh1.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 093f897b5ca2a0408e99ce1a62724c0017f3c97d https://github.com/buildbot/buildbot/commit/093f897b5ca2a0408e99ce1a62724c0017f3c97d Author: Dustin J. Mitchell Date: 2012-01-30 (Mon, 30 Jan 2012) Changed paths: M master/setup.py Log Message: ----------- Add support for sqlalchemy-migrate-0.7.2 Refs #2187 From nobody at buildbot.net Tue Jan 31 07:35:51 2012 From: nobody at buildbot.net (Buildbot) Date: Tue, 31 Jan 2012 07:35:51 -0000 Subject: [Buildbot-commits] [Buildbot] #2187: test and enable support for sqlalchemy-migrate 0.7.2 In-Reply-To: <038.4203be0a3c83015e92c248537d1d6ef1@buildbot.net> References: <038.4203be0a3c83015e92c248537d1d6ef1@buildbot.net> Message-ID: <053.9f0b3570efb3c3342a992cc6db791fcc@buildbot.net> #2187: test and enable support for sqlalchemy-migrate 0.7.2 ------------------------+-------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.6 Version: 0.8.5 | Resolution: Keywords: | ------------------------+-------------------- Comment (by Dustin J. Mitchell): Add support for sqlalchemy-migrate-0.7.2 Refs #2187 Changeset: 093f897b5ca2a0408e99ce1a62724c0017f3c97d -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Tue Jan 31 07:39:43 2012 From: nobody at buildbot.net (Buildbot) Date: Tue, 31 Jan 2012 07:39:43 -0000 Subject: [Buildbot-commits] [Buildbot] #2187: test and enable support for sqlalchemy-migrate 0.7.2 In-Reply-To: <038.4203be0a3c83015e92c248537d1d6ef1@buildbot.net> References: <038.4203be0a3c83015e92c248537d1d6ef1@buildbot.net> Message-ID: <053.e76acd9878b6f16672fb1cc1532236af@buildbot.net> #2187: test and enable support for sqlalchemy-migrate 0.7.2 ------------------------+--------------------- Reporter: dustin | Owner: Type: enhancement | Status: closed Priority: major | Milestone: 0.8.6 Version: 0.8.5 | Resolution: fixed Keywords: | ------------------------+--------------------- Changes (by dustin): * status: new => closed * resolution: => fixed Comment: It's in the metabuildbot now, too. -- Ticket URL: Buildbot Buildbot: build/test automation