[Buildbot-commits] [buildbot/buildbot] e7861e: Fix bogus moockCheckCall in change_hook tests.

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot
  Commit: e7861e71a971e203f323acedcf1d336111689480
      https://github.com/buildbot/buildbot/commit/e7861e71a971e203f323acedcf1d336111689480
  Author: Tom Prince <tom.prince at ualberta.net>
  Date:   2012-02-26 (Sun, 26 Feb 2012)

  Changed paths:
    M master/buildbot/test/unit/test_status_web_change_hook.py

  Log Message:
  -----------
  Fix bogus moockCheckCall in change_hook tests.

The method doesn't exists, and bogusly succeeds, since the object
is a mock.


  Commit: 164d599ccc01745be70a7a905a8d243bb73d3814
      https://github.com/buildbot/buildbot/commit/164d599ccc01745be70a7a905a8d243bb73d3814
  Author: Tom Prince <tom.prince at ualberta.net>
  Date:   2012-02-26 (Sun, 26 Feb 2012)

  Changed paths:
    M master/buildbot/status/web/change_hook.py
  M master/buildbot/test/unit/test_status_web_change_hook.py

  Log Message:
  -----------
  Catch all errors during change_hook processing.

We shouldn't let errors in change_hooks escape to the user.


  Commit: 80a482d46d0a3c7adc3e16ad98f4d511faf39387
      https://github.com/buildbot/buildbot/commit/80a482d46d0a3c7adc3e16ad98f4d511faf39387
  Author: Tom Prince <tom.prince at ualberta.net>
  Date:   2012-02-26 (Sun, 26 Feb 2012)

  Changed paths:
    M master/buildbot/status/web/hooks/github.py
  M master/buildbot/status/web/hooks/googlecode.py
  M master/buildbot/test/unit/test_status_web_change_hooks_github.py

  Log Message:
  -----------
  Don't worry about errors in github or goolecode change hook.

The generic code catches and logs all errors, so don't bother also
doing it in the specific change hook.


  Commit: 757e0e34e18d366e114fe6b73dc40ef922c831dc
      https://github.com/buildbot/buildbot/commit/757e0e34e18d366e114fe6b73dc40ef922c831dc
  Author: Tom Prince <tom.prince at ualberta.net>
  Date:   2012-02-26 (Sun, 26 Feb 2012)

  Changed paths:
    M master/buildbot/status/web/change_hook.py
  M master/buildbot/status/web/hooks/github.py
  M master/buildbot/status/web/hooks/googlecode.py
  M master/buildbot/test/unit/test_status_web_change_hook.py
  M master/buildbot/test/unit/test_status_web_change_hooks_github.py

  Log Message:
  -----------
  Merge branch 'change-hook-tests'


Compare: https://github.com/buildbot/buildbot/compare/c7c173d...757e0e3