[Buildbot-commits] [Buildbot] #2208: GerritChangeSource: orphan SSH process

[Buildbot]

#2208: GerritChangeSource: orphan SSH process
--------------------+--------------------
Reporter:  sanxiyn  |       Owner:
    Type:  defect   |      Status:  new
Priority:  minor    |   Milestone:  0.8.+
 Version:  0.8.5    |  Resolution:
Keywords:  gerrit   |
--------------------+--------------------

Comment (by dustin):

 This:
 {{{
 #!python
     def stopService(self):
         if self.process:
             self.process.signalProcess("KILL")
 }}}
 is killing the process, and then
 {{{
 #!python
     def streamProcessStopped(self):
         self.process = None

         # if the service is stopped, don't try to restart
         if not self.parent:
             log.msg("service is not running; not reconnecting")
             return
 }}}
 is re-starting it.  The check for `self.parent` is not the same as
 `self.running` which is, sadly, an undocumented attribute of
 service.Service.

 I think that the fix here is to add a new attribute to track whether the
 process should be running.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2208#comment:3>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation