[Buildbot-commits] [Buildbot] #2213: console webpage doesn't always show revisions when using branch=*

[Buildbot]

#2213: console webpage doesn't always show revisions when using branch=*
----------------------+-----------------------
Reporter:  JocelynJ   |      Owner:
    Type:  undecided  |     Status:  new
Priority:  major      |  Milestone:  undecided
 Version:  0.8.5      |   Keywords:  web
----------------------+-----------------------
 Hi,

 I'm using a buildbot master that polls a SVN repository, with a busy
 trunk, and a quiet branch. I want to be able to use
 console.py?branch=branches/test so that only revisions and builds relevant
 to the branch are shown.

 What I can see is that, if there are too many revisions on trunk since
 last commit on the branch, the console doesn't show any revisions - which
 makes it hard to directly check if the branch is OK or not.

 According to the code in 0.8.5 of buildbot/status/web/console.py, this is
 because getAllChanges() only gets up to 25 revisions, and the filtering by
 branch is done a little later in stripRevisions(). I think these two
 functions should be merged, so that it is more similar to
 getRecentSourcestamps() in grid.py.

 Is the current behavior expected ?

 Is there any reason to split getAllChanges() and stripRevisions() in two
 different functions ?


 Thanks,
 Jocelyn

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2213>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation