[Buildbot-commits] [Buildbot] #2206: Change Hooks always return a HTTP 500 error

Buildbot nobody at buildbot.net
Fri Feb 17 00:46:27 UTC 2012


#2206: Change Hooks always return a HTTP 500 error
---------------------------------------------+------------------------
Reporter:  kalessin                          |       Owner:
    Type:  defect                            |      Status:  closed
Priority:  major                             |   Milestone:  undecided
 Version:  master                            |  Resolution:  fixed
Keywords:  master, status, web, change_hook  |
---------------------------------------------+------------------------
Changes (by Tom Prince):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 web: Return server.NOT_DONE_YET from change_hooks.

 twisted.web.resource predates deferreds, and so has idiosyncratic handling
 of
 asynchronous results. Fix /change_hook handling to return proper results
 and
 add support from properly testing this in FakeRequest.test_render.

 Fixes #2206.
  Changeset: 2e25ec71c0791178de84222228b147ab309b77d6

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2206#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation


More information about the Commits mailing list