[Buildbot-commits] [buildbot/buildbot] 2e25ec: web: Return server.NOT_DONE_YET from change_hooks.

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot
  Commit: 2e25ec71c0791178de84222228b147ab309b77d6
      https://github.com/buildbot/buildbot/commit/2e25ec71c0791178de84222228b147ab309b77d6
  Author: Tom Prince <tom.prince at ualberta.net>
  Date:   2012-02-16 (Thu, 16 Feb 2012)

  Changed paths:
    M master/buildbot/status/web/change_hook.py
  M master/buildbot/test/fake/web.py
  M master/buildbot/test/unit/test_status_web_base.py
  M master/buildbot/test/unit/test_status_web_change_hook.py
  M master/buildbot/test/unit/test_status_web_change_hooks_github.py
  M master/buildbot/test/unit/test_status_web_change_hooks_googlecode.py

  Log Message:
  -----------
  web: Return server.NOT_DONE_YET from change_hooks.

twisted.web.resource predates deferreds, and so has idiosyncratic handling of
asynchronous results. Fix /change_hook handling to return proper results and
add support from properly testing this in FakeRequest.test_render.

Fixes #2206.