[Buildbot-commits] [Buildbot] #2199: Bzr hook has hardcoded credentials

[Buildbot]

#2199: Bzr hook has hardcoded credentials
------------------------+-----------------------------
Reporter:  gracinet     |      Owner:
    Type:  enhancement  |     Status:  new
Priority:  major        |  Milestone:  undecided
 Version:  0.8.5        |   Keywords:  bazaar bzr hook
------------------------+-----------------------------
 The default name/password pair (change/changepw) is hardcoded.
 This is a bit surprising for someone used to, e.g., the mercurial hook,
 like I am.

 Moreover, the [http://buildbot.net/buildbot/docs/current/manual/cfg-
 changesources.html#chsrc-PBChangeSource general doc on PBChangeSource]
 says:

 "If you have a publicly accessible slave port, and are using
 PBChangeSource, you must establish a secure username and password for the
 change source."

 For consistency with Hg plugin and other Bzr hook parameters, I'd suggest
 to present the option in ```locations.conf``` as following:

 {{{
     buildbot_auth = joe:secretpwd
 }}}

 (Seen both on 0.8.5 and latest git master)

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2199>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation