[Buildbot-commits] [Buildbot] #2400: Logging in does not clear "Authentication failed" message

Buildbot nobody at buildbot.net
Sat Dec 15 19:49:57 UTC 2012


#2400: Logging in does not clear "Authentication failed" message
-------------------+--------------------
Reporter:  dank    |       Owner:
    Type:  defect  |      Status:  new
Priority:  minor   |   Milestone:  0.8.8
 Version:  0.8.7   |  Resolution:
Keywords:  web     |
-------------------+--------------------

Comment (by dustin):

 That is storing the originalPage state on the !LoginResource object, which
 is global to all users of the site -- not what we want.

 Following HATEOAS (google that one!), the client's state (including
 originalPage) needs to be stored on the client.  The easiest way to do
 that is to embed it in the URL.  For example, when authentication fails,
 redirect to

   /authfail.html?originalPage=http%3A%2F%2Fserver.com%2Fbuilder%2Ffoo%2F

 then, when rendering authfail, extract that URL and redirect to it if the
 user is logged in.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2400#comment:7>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation


More information about the Commits mailing list