[Buildbot-commits] [Buildbot] #2411: waterfall exception when using newer version of git source step with gerrit

[Buildbot]

#2411: waterfall exception when using newer version of git source step with gerrit
----------------------+-----------------------
Reporter:  philippem  |      Owner:
    Type:  undecided  |     Status:  new
Priority:  major      |  Milestone:  undecided
 Version:  0.8.7p1    |   Keywords:
----------------------+-----------------------
 I created a buildbot master pullling from gerrit; everything works fine
 with multiple builders, some building on gerrit patchset-created events,
 and others on ref-updated events. This master.cfg used the older version
 of the git step.

 I switched to the newer version of the git step, because I wanted to use
 the clean method rather than a full clobber.

 The waterfall page now displays an exception, after switching the git step
 to use the new version of the git step
 "from buildbot.steps.source.git import Git" and modifying the
 corresponding mode and method args.

 The exception is below.

 When reverting the source step back to "from buildbot.steps.source import
 Git", the waterfall page continues to show the exception. When recreating
 the master from scratch with the same config, the waterfall page renders
 correctly.

 web.Server Traceback (most recent call last):
 exceptions.AttributeError: WithProperties instance has no attribute
 '__getitem__'
 /usr/lib/python2.7/dist-packages/twisted/internet/defer.py:551 in
 _runCallbacks
 550                    try:
 551                        current.result = callback(current.result,
 *args, **kw)
 552                    finally:
 /usr/local/lib/python2.7/dist-
 packages/buildbot/status/web/waterfall.py:426 in call_content
 425            return self.content_with_db_data(results['changes'],
 426                    brcounts, request, ctx)
 427        d.addCallback(call_content)
 /usr/local/lib/python2.7/dist-
 packages/buildbot/status/web/waterfall.py:490 in content_with_db_data
 489        ctx.update(self.phase2(request, changeNames + builderNames,
 timestamps, eventGrid,
 490                  sourceEvents))
 491
 /usr/local/lib/python2.7/dist-
 packages/buildbot/status/web/waterfall.py:743 in phase2
 742                    # so the events are bottom-justified
 743                    b = IBox(block[i]).getBox(request)
 744                    b.parms['valign'] = "top"
 /usr/local/lib/python2.7/dist-
 packages/buildbot/status/web/waterfall.py:173 in getBox
 172            text = []
 173        text = text[:]
 174        logs = self.original.getLogs()
 exceptions.AttributeError: WithProperties instance has no attribute
 '__getitem__'



 buildbot at gerrit:~/buildbot-master$ buildbot --version
 Buildbot version: 0.8.7p1
 Twisted version: 12.2.0
 buildbot at gerrit:~/buildbot-master$ cat /etc/issue
 Ubuntu 12.10 \n \l

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2411>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation