[Buildbot-commits] [Buildbot] #2363: The workdir property is set to slavebuilddir, not workdir

Buildbot nobody at buildbot.net
Fri Aug 31 09:28:53 UTC 2012


#2363: The workdir property is set to slavebuilddir, not workdir
----------------------+-----------------------
Reporter:  pepsiman   |      Owner:
    Type:  undecided  |     Status:  new
Priority:  major      |  Milestone:  undecided
 Version:  master     |   Keywords:
----------------------+-----------------------
 master/buildbot/process/build.py sets the "workdir" property like this:
 {{{
             self.setProperty("workdir",
                     self.path_module.join(
                         slavebuilder.slave.slave_basedir,
                         self.builder.config.slavebuilddir),
                     "slave")
 }}}

 This is confusing, as build steps can specify a workdir which is a
 subdirectory of slavebuilddir.

 I'd expect this property to be called "slavebuilddir".

 I'd also expect the source of this property to be "Slave", as all other
 sources start with a capital letter.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2363>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation


More information about the Commits mailing list