[Buildbot-commits] [Buildbot] #2279: checkconfig returns exit code 1 on success?

[Buildbot]

#2279: checkconfig returns exit code 1 on success?
----------------------+-----------------------
Reporter:  Jc2k       |      Owner:
    Type:  undecided  |     Status:  new
Priority:  major      |  Milestone:  undecided
 Version:  0.8.6p1    |   Keywords:
----------------------+-----------------------
 Our internal meta-ci runs checkconfig on commit to the ci config. Since
 upgrading to 0.8.6 it fails despite printing out that the Config is good!

 Looking at:

 https://github.com/buildbot/buildbot/blob/master/master/buildbot/scripts/checkconfig.py

 This returns a shell style true or false - 1 for fail, 0 for success.

 Looking at:

 https://github.com/buildbot/buildbot/blob/master/master/buildbot/scripts/runner.py

 The logic seems to be the other way around.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2279>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation