[Buildbot-commits] [Buildbot] #2091: MailNotifier chokes on try job with non-ascii char in first line of patch?

[Buildbot]

#2091: MailNotifier chokes on try job with non-ascii char in first line of patch?
---------------------+---------------------
Reporter:  dank      |       Owner:
    Type:  defect    |      Status:  closed
Priority:  major     |   Milestone:  0.8.5
 Version:  master    |  Resolution:  fixed
Keywords:  encoding  |
---------------------+---------------------

Comment (by dank):

 Still failing.  Here's the current stack trace with yesterday's git:

 2011-09-18 11:33:40-0700 [-] Exception caught notifying
 <buildbot.status.mail.MailNotifier instance at 0xa00212c> of buildFinished
 event
 2011-09-18 11:33:40-0700 [-] Unhandled Error
   Traceback (most recent call last):
     File "buildbot-git/master/buildbot/status/build.py", line 290, in
 buildFinished
       w.callback(self)
     File "lib/python2.7/site-packages/twisted/internet/defer.py", line
 361, in callback
       self._startRunCallbacks(result)
     File "lib/python2.7/site-packages/twisted/internet/defer.py", line
 455, in _startRunCallbacks
       self._runCallbacks()
     File "lib/python2.7/site-packages/twisted/internet/defer.py", line
 542, in _runCallbacks
       current.result = callback(current.result, *args, **kw)
   --- <exception caught here> ---
     File "buildbot-git/master/buildbot/status/builder.py", line 535, in
 _buildFinished
       w.buildFinished(name, s, results)
     File "buildbot-git/master/buildbot/status/mail.py", line 412, in
 buildFinished
       return self.buildMessage(name, [build], results)
     File "buildbot-git/master/buildbot/status/mail.py", line 618, in
 buildMessage
       results, builds, patches, logs)
     File "buildbot-git/master/buildbot/status/mail.py", line 520, in
 createEmail
       text = msgdict['body'].encode(ENCODING)
   exceptions.UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in
 position 582: ordinal not in range(128)

 Not sure what it was unhappy about, the patch it was trying to attach is
 http://source.winehq.org/patches/data/79014
 From: Francois Gouget <fgouget at free.fr>
 Subject: msxml3: Fix printing NULL strings.
 and has no funny characters in it anywhere I can see.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2091#comment:3>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation