[Buildbot-commits] [Buildbot] #2105: Mercurial hook - exceptions.ValueError: signal only works in main thread

[Buildbot]

#2105: Mercurial hook - exceptions.ValueError: signal only works in main thread
----------------------+-----------------------
Reporter:  jpichon    |      Owner:
    Type:  undecided  |     Status:  new
Priority:  major      |  Milestone:  undecided
 Version:  0.8.4p2    |   Keywords:
----------------------+-----------------------
 I'm having a problem with using Mercurial and buildbot together. This
 looks similar to the problem described in #397 (which I found searching
 for my error thanks to http://ur1.ca/52q6p), unfortunately applying the
 suggested change in changes/buildbot.py didn't solve it for me.

 I've set up buildbot on a few other machines with Mercurial and a very
 similar config file just fine, the only major difference I can think of is
 that this is the first time master and the repositories are on a different
 machine. Master is set up to listen to Mercurial via PBChangeSource, the
 hook is like this:


 {{{
 [hooks]
 changegroup.buildbot = python:buildbot.changes.hgbuildbot.hook

 [hgbuildbot]
 master = buildbot:9989
 }}}

 When I push for the first time to the repository, I get the following
 traceback. The repo is set up to work with HTTP. The changeset does go
 through to the buildbot master. For this traceback's purpose, I'm pushing
 with the --debug -v flags, and I also changed hook() in
 changes/buildbot.py to wrap the function into a try/catch.


 {{{
 1 changesets found
 list of changesets:
 a7cbcacb6a1034ab436fac506e1fb9e78f3dd56b
 bundling: 1/1 changesets (100.00%)
 bundling: 1/1 manifests (100.00%)
 bundling: thirdfile 1/1 files (100.00%)
 sending unbundle command
 sending 298 bytes
 sending: 0 kb
 sending: 0 kb
 remote: adding changesets
 remote: adding manifests
 remote: adding file changes
 remote: added 1 changesets with 1 changes to 1 files
 remote: /usr/lib/python2.6/dist-packages/zope/__init__.py:3: UserWarning:
 Module twisted was already imported from /usr/lib/python2.6/dist-
 packages/twisted/__init__.pyc, but /usr/local/lib/python2.6/dist-packages
 is being added to sys.path
 remote:   import pkg_resources
 remote: Traceback (most recent call last):
 remote:   File "/usr/lib/python2.6/dist-
 packages/twisted/internet/base.py", line 396, in fireEvent
 remote:     DeferredList(beforeResults).addCallback(self._continueFiring)
 remote:   File "/usr/lib/python2.6/dist-
 packages/twisted/internet/defer.py", line 224, in addCallback
 remote:     callbackKeywords=kw)
 remote:   File "/usr/lib/python2.6/dist-
 packages/twisted/internet/defer.py", line 213, in addCallbacks
 remote:     self._runCallbacks()
 remote:   File "/usr/lib/python2.6/dist-
 packages/twisted/internet/defer.py", line 371, in _runCallbacks
 remote:     self.result = callback(self.result, *args, **kw)
 remote: --- <exception caught here> ---
 remote:   File "/usr/lib/python2.6/dist-
 packages/twisted/internet/base.py", line 409, in _continueFiring
 remote:     callable(*args, **kwargs)
 remote:   File "/usr/lib/python2.6/dist-
 packages/twisted/internet/base.py", line 1165, in _reallyStartRunning
 remote:     self._handleSignals()
 remote:   File "/usr/lib/python2.6/dist-
 packages/twisted/internet/base.py", line 1105, in _handleSignals
 remote:     signal.signal(signal.SIGINT, self.sigInt)
 remote: exceptions.ValueError: signal only works in main thread
 remote: rev a7cbcacb6a1034ab436fac506e1fb9e78f3dd56b sent
 checking for updated bookmarks
 sending listkeys command
 }}}


 The 2nd changeset I push will hang, with no error message.


 {{{
 1 changesets found
 list of changesets:
 04b9ca66ef8238f2265bcd798106b673df2648aa
 bundling: 1/1 changesets (100.00%)
 bundling: 1/1 manifests (100.00%)
 bundling: thirdfile 1/1 files (100.00%)
 sending unbundle command
 sending 301 bytes
 sending: 0 kb
 sending: 0 kb
 }}}


 I have to kill it. It still goes through to the buildbot master, though.

 From then on I will always get the following exception, even though the
 changes do get through to Master.


 {{{
 1 changesets found
 list of changesets:
 3eb90d2ce2e2b1d472ff8164801a04a386b11d53
 bundling: 1/1 changesets (100.00%)
 bundling: 1/1 manifests (100.00%)
 bundling: thirdfile 1/1 files (100.00%)
 sending unbundle command
 sending 298 bytes
 sending: 0 kb
 sending: 0 kb
 remote: adding changesets
 remote: adding manifests
 remote: adding file changes
 remote: added 1 changesets with 1 changes to 1 files
 remote: Traceback (most recent call last):
 remote:   File "/usr/local/lib/python2.6/dist-
 packages/buildbot/changes/hgbuildbot.py", line 178, in hook
 remote:     reactor.run()
 remote:   File "/usr/lib/python2.6/dist-
 packages/twisted/internet/base.py", line 1169, in run
 remote:     self.startRunning(installSignalHandlers=installSignalHandlers)
 remote:   File "/usr/lib/python2.6/dist-
 packages/twisted/internet/base.py", line 1149, in startRunning
 remote:     ReactorBase.startRunning(self)
 remote:   File "/usr/lib/python2.6/dist-
 packages/twisted/internet/base.py", line 652, in startRunning
 remote:     raise error.ReactorAlreadyRunning()
 remote: ReactorAlreadyRunning
 checking for updated bookmarks
 sending listkeys command
 }}}

 The only way to stop it is to restart Mercurial, and it's back to
 Traceback #1 above. Before I wrapped hook() in a try/catch statement, the
 output of that last traceback was only this:

 {{{
 1 changesets found
 remote: adding changesets
 remote: adding manifests
 remote: adding file changes
 remote: added 1 changesets with 1 changes to 1 files
 remote: error: changegroup.buildbot hook raised an exception:
 }}}

 The master's logs don't seem to provide information relevant to this. In
 #397 a more specific traceback is requested, if this one isn't enough let
 me know where I can get what's needed. Thanks!

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2105>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation