[Buildbot-commits] [Buildbot] #2100: GoogleCodeAtomPoller fails with AttributeError when changes are detected

[Buildbot]

#2100: GoogleCodeAtomPoller fails with AttributeError when changes are detected
-------------------------+-----------------------
Reporter:  andialbrecht  |      Owner:
    Type:  defect        |     Status:  new
Priority:  major         |  Milestone:  undecided
 Version:  master        |   Keywords:
-------------------------+-----------------------
 GoogleCodeAtomPoller fails with an AttributeError when it detects changes.
 Here is the relevant part from my twistd.log with two events: The first is
 a successful poll without changes (08:00), the second event one minute
 later is a failing poll where the Atom feed had changes.

 {{{
 2011-09-06 08:00:42+0200 [-] Starting factory <HTTPClientFactory:
 http://code.google.com/feeds/p/python-sqlparse/hgchanges/basic>
 2011-09-06 08:00:43+0200 [HTTPPageGetter,client] GoogleCodeAtomPoller poll
 success
 2011-09-06 08:00:43+0200 [HTTPPageGetter,client] Stopping factory
 <HTTPClientFactory: http://code.google.com/feeds/p/python-
 sqlparse/hgchanges/basic>
 2011-09-06 08:01:42+0200 [-] GoogleCodeAtomPoller polling
 http://code.google.com/feeds/p/python-sqlparse/hgchanges/basic
 2011-09-06 08:01:42+0200 [-] Starting factory <HTTPClientFactory:
 http://code.google.com/feeds/p/python-sqlparse/hgchanges/basic>
 2011-09-06 08:01:43+0200 [HTTPPageGetter,client] GoogleCodeAtomPoller poll
 failed: [Failure instance: Traceback: <type 'exceptions.AttributeError'>:
 ChangeManager instance has no attribute 'addChange'
         /home/build/.virtualenvs/buildbot/lib/python2.7/site-
 packages/twisted/web/client.py:182:handleResponse
         /home/build/.virtualenvs/buildbot/lib/python2.7/site-
 packages/twisted/web/client.py:347:page
         /home/build/.virtualenvs/buildbot/lib/python2.7/site-
 packages/twisted/internet/defer.py:361:callback
         /home/build/.virtualenvs/buildbot/lib/python2.7/site-
 packages/twisted/internet/defer.py:455:_startRunCallbacks
         --- <exception caught here> ---
         /home/build/.virtualenvs/buildbot/lib/python2.7/site-
 packages/twisted/internet/defer.py:542:_runCallbacks
         /home/build/bots/sqlparse-
 master/googlecode_atom.py:181:_process_changes
         ]
 2011-09-06 08:01:43+0200 [HTTPPageGetter,client] Stopping factory
 <HTTPClientFactory: http://code.google.com/feeds/p/python-
 sqlparse/hgchanges/basic>
 }}}

 The Atom poller is configured as

 {{{
 #!python
 from googlecode_atom import GoogleCodeAtomPoller
 poller = GoogleCodeAtomPoller(
     feedurl="http://code.google.com/feeds/p/python-
 sqlparse/hgchanges/basic",
     pollinterval=60)
 c['change_source'] = [ poller ]
 }}}

 Buildbot is

 {{{
 #!sh
 $ buildbot --version
 Buildbot version: 0.8.6-pre-21-gd359727
 Twisted version: 11.0.0
 }}}

 The error occurred after upgrading from Buildbot 0.8.2 to 0.8.5rc1, but is
 reproducible with current master. GoogleCodeAtomPoller is from master too.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2100>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation