From nobody at buildbot.net Thu Sep 1 02:42:44 2011 From: nobody at buildbot.net (Buildbot) Date: Thu, 01 Sep 2011 02:42:44 -0000 Subject: [Buildbot-commits] [Buildbot] #2095: master-side commands only have access to full logfiles Message-ID: <038.ffe451e3e91ab365cd161be6ae6a8dc5@buildbot.net> #2095: master-side commands only have access to full logfiles --------------------+------------------- Reporter: dustin | Owner: Type: defect | Status: new Priority: minor | Milestone: 0.8.5 Version: 0.8.4p2 | Keywords: --------------------+------------------- Pradeep worked around this in some clever ways, but master-side source steps' only access to the output of remote commands is {{{.getLogs}}} which (in both tests and real steps) returns the entire set of log outputs, not just those from the most recent command. We'll need to add a new interface that allows the results of a single command to be analyzed on their own. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Thu Sep 1 02:43:21 2011 From: nobody at buildbot.net (Buildbot) Date: Thu, 01 Sep 2011 02:43:21 -0000 Subject: [Buildbot-commits] [Buildbot] #2095: master-side commands only have access to full logfiles In-Reply-To: <038.ffe451e3e91ab365cd161be6ae6a8dc5@buildbot.net> References: <038.ffe451e3e91ab365cd161be6ae6a8dc5@buildbot.net> Message-ID: <053.ea19dcaf6bd5fa0edc8cb78199b1f85b@buildbot.net> #2095: master-side commands only have access to full logfiles --------------------+-------------------- Reporter: dustin | Owner: Type: defect | Status: new Priority: minor | Milestone: 0.8.5 Version: 0.8.4p2 | Resolution: Keywords: | --------------------+-------------------- Comment (by dustin): I have some work on this (tests, at least) in my bug2095 branch. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Thu Sep 1 02:46:24 2011 From: noreply at github.com (noreply at github.com) Date: Wed, 31 Aug 2011 19:46:24 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 5fa684: Allow a 'P' suffix from svnmerge, too Message-ID: <20110901024624.5276042703@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 5fa6847a2a615773ee9764cf3984eae665444188 https://github.com/buildbot/buildbot/commit/5fa6847a2a615773ee9764cf3984eae665444188 Author: Dustin J. Mitchell Date: 2011-08-31 (Wed, 31 Aug 2011) Changed paths: M master/buildbot/steps/source/svn.py M slave/buildslave/commands/svn.py Log Message: ----------- Allow a 'P' suffix from svnmerge, too Fixes #2089. From nobody at buildbot.net Thu Sep 1 02:46:30 2011 From: nobody at buildbot.net (Buildbot) Date: Thu, 01 Sep 2011 02:46:30 -0000 Subject: [Buildbot-commits] [Buildbot] #2089: Slave SVN.parseGotRevision() needs to expect a 'P' suffix, too In-Reply-To: <039.0eb9674e5149bcd7001c027e1aca0249@buildbot.net> References: <039.0eb9674e5149bcd7001c027e1aca0249@buildbot.net> Message-ID: <054.ce1c9766ce1b6f2cdb1b76a56c27c3c7@buildbot.net> #2089: Slave SVN.parseGotRevision() needs to expect a 'P' suffix, too --------------------+------------------------ Reporter: spencer | Owner: Type: defect | Status: closed Priority: minor | Milestone: undecided Version: 0.7.12 | Resolution: fixed Keywords: svn | --------------------+------------------------ Changes (by Dustin J. Mitchell): * status: new => closed * resolution: => fixed Comment: Allow a 'P' suffix from svnmerge, too Fixes #2089. Changeset: 5fa6847a2a615773ee9764cf3984eae665444188 -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Thu Sep 1 03:05:48 2011 From: noreply at github.com (noreply at github.com) Date: Wed, 31 Aug 2011 20:05:48 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 898616: Merge branch '2081' of git://github.com/dzhurley/b... Message-ID: <20110901030548.1BA9A42625@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 89861642dbe42cd063e7b0672cde380f4c8f9b5b https://github.com/buildbot/buildbot/commit/89861642dbe42cd063e7b0672cde380f4c8f9b5b Author: Dustin J. Mitchell Date: 2011-08-31 (Wed, 31 Aug 2011) Changed paths: M master/contrib/git_buildbot.py Log Message: ----------- Merge branch '2081' of git://github.com/dzhurley/buildbot * '2081' of git://github.com/dzhurley/buildbot: pull user/pass in git_buildbot into option From nobody at buildbot.net Thu Sep 1 03:09:52 2011 From: nobody at buildbot.net (Buildbot) Date: Thu, 01 Sep 2011 03:09:52 -0000 Subject: [Buildbot-commits] [Buildbot] #2081: Username and password for git_buildbot.py ought to be configurable from the top of the script In-Reply-To: <041.186a05b3ce76abc37cddd027bf30bf15@buildbot.net> References: <041.186a05b3ce76abc37cddd027bf30bf15@buildbot.net> Message-ID: <056.73bc57704f2898f5fc977a78596ed0bb@buildbot.net> #2081: Username and password for git_buildbot.py ought to be configurable from the top of the script -------------------------------+--------------------- Reporter: ulfalizer | Owner: Type: enhancement | Status: closed Priority: minor | Milestone: 0.8.+ Version: 0.8.4p2 | Resolution: fixed Keywords: git, redheadphones | -------------------------------+--------------------- Changes (by dustin): * status: new => closed * resolution: => fixed Comment: {{{ commit cded936728626019e2c38f6164abb65b52a615f5 Author: Derek Hurley Date: Mon Aug 29 13:37:33 2011 -0700 pull user/pass in git_buildbot into option This moves "change" and "changepw" into defaults for the script and makes the username/password arguments configurable, with the defaults located near the top of the file. fixes #2081 }}} -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Thu Sep 1 03:12:19 2011 From: noreply at github.com (noreply at github.com) Date: Wed, 31 Aug 2011 20:12:19 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] ec9935: Merge branch '2092' of git://github.com/dzhurley/b... Message-ID: <20110901031219.690EE426EA@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: ec9935068ef00d94733781a4d3e2bfdc36c83b2b https://github.com/buildbot/buildbot/commit/ec9935068ef00d94733781a4d3e2bfdc36c83b2b Author: Dustin J. Mitchell Date: 2011-08-31 (Wed, 31 Aug 2011) Changed paths: M master/buildbot/status/mail.py M master/buildbot/test/unit/test_status_mail.py Log Message: ----------- Merge branch '2092' of git://github.com/dzhurley/buildbot * '2092' of git://github.com/dzhurley/buildbot: make sure d is assigned if sendToInterestedUsers=False From nobody at buildbot.net Thu Sep 1 03:19:03 2011 From: nobody at buildbot.net (Buildbot) Date: Thu, 01 Sep 2011 03:19:03 -0000 Subject: [Buildbot-commits] [Buildbot] #2092: MailNotifier crashes if sendToInterestedUsers=False In-Reply-To: <036.2faca924724066af8ac9bca5d8ddfd04@buildbot.net> References: <036.2faca924724066af8ac9bca5d8ddfd04@buildbot.net> Message-ID: <051.a5202071ec3aa25322951544448ad79d@buildbot.net> #2092: MailNotifier crashes if sendToInterestedUsers=False -------------------+------------------------ Reporter: dank | Owner: Type: defect | Status: closed Priority: major | Milestone: undecided Version: master | Resolution: fixed Keywords: | -------------------+------------------------ Changes (by dustin): * status: new => closed * resolution: => fixed Comment: {{{ commit 737d731300915c2bbd1b7b76cb0807619b386a04 Author: Derek Hurley Date: Mon Aug 29 13:52:25 2011 -0700 make sure d is assigned if sendToInterestedUsers=False This fixes #2092 and adds another test for coverage. }}} -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Thu Sep 1 05:18:14 2011 From: nobody at buildbot.net (Buildbot) Date: Thu, 01 Sep 2011 05:18:14 -0000 Subject: [Buildbot-commits] [Buildbot] #2095: master-side commands only have access to full logfiles In-Reply-To: <038.ffe451e3e91ab365cd161be6ae6a8dc5@buildbot.net> References: <038.ffe451e3e91ab365cd161be6ae6a8dc5@buildbot.net> Message-ID: <053.af19127899cdf1583c5ca44797ae9317@buildbot.net> #2095: master-side commands only have access to full logfiles --------------------+-------------------- Reporter: dustin | Owner: Type: defect | Status: new Priority: minor | Milestone: 0.8.5 Version: 0.8.4p2 | Resolution: Keywords: | --------------------+-------------------- Comment (by in3xes): Yes, I did feel the need of such function. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Thu Sep 1 23:09:57 2011 From: nobody at buildbot.net (Buildbot) Date: Thu, 01 Sep 2011 23:09:57 -0000 Subject: [Buildbot-commits] [Buildbot] #2055: buildmaster spins when build starts In-Reply-To: <038.7c5d837314c12cddc1ef74bf0334dab5@buildbot.net> References: <038.7c5d837314c12cddc1ef74bf0334dab5@buildbot.net> Message-ID: <053.29fd86a9340560ec18395d14e398e916@buildbot.net> #2055: buildmaster spins when build starts -----------------------+---------------------- Reporter: mmorse | Owner: Type: defect | Status: new Priority: major | Milestone: ongoing Version: 0.8.4p2 | Resolution: Keywords: threadbugs | -----------------------+---------------------- Comment (by wms): I was able to work around the problem by running "buildbot start" inside of a screen session, and leaving the screen detached, so that suggests that launchd has something to do with it. I suspect that part of the source of the deadlock might be events coming in via PBChangeSource, but I was unable to reproduce this in a test environment. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Sep 2 04:38:21 2011 From: nobody at buildbot.net (Buildbot) Date: Fri, 02 Sep 2011 04:38:21 -0000 Subject: [Buildbot-commits] [Buildbot] #2095: master-side commands only have access to full logfiles In-Reply-To: <038.ffe451e3e91ab365cd161be6ae6a8dc5@buildbot.net> References: <038.ffe451e3e91ab365cd161be6ae6a8dc5@buildbot.net> Message-ID: <053.c830936abf14552a275ecaf4998938fd@buildbot.net> #2095: master-side commands only have access to full logfiles --------------------+-------------------- Reporter: dustin | Owner: Type: defect | Status: new Priority: minor | Milestone: 0.8.5 Version: 0.8.4p2 | Resolution: Keywords: | --------------------+-------------------- Comment (by dustin): tomprince points me to https://github.com/tomprince/buildbot/commit/2ed03c9435065282171607b82f3dcb2b81435618#L0R990 -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Fri Sep 2 22:55:59 2011 From: noreply at github.com (noreply at github.com) Date: Fri, 2 Sep 2011 15:55:59 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 1effc4: create _getSourceStampId_lock in _make_ss Message-ID: <20110902225559.A998B42765@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 1effc49f0d0205e58000fac8a54b69c7395824f5 https://github.com/buildbot/buildbot/commit/1effc49f0d0205e58000fac8a54b69c7395824f5 Author: Dustin J. Mitchell Date: 2011-09-02 (Fri, 02 Sep 2011) Changed paths: M master/buildbot/sourcestamp.py Log Message: ----------- create _getSourceStampId_lock in _make_ss Commit: aa2b86d10fae58c20bf7c5d2fb1c4ccbc399f7f5 https://github.com/buildbot/buildbot/commit/aa2b86d10fae58c20bf7c5d2fb1c4ccbc399f7f5 Author: Dustin J. Mitchell Date: 2011-09-02 (Fri, 02 Sep 2011) Changed paths: M master/setup.py Log Message: ----------- add buildbot.process.users to setup.py Compare: https://github.com/buildbot/buildbot/compare/ec99350...aa2b86d From nobody at buildbot.net Fri Sep 2 23:31:03 2011 From: nobody at buildbot.net (Buildbot) Date: Fri, 02 Sep 2011 23:31:03 -0000 Subject: [Buildbot-commits] [Buildbot] #2096: Pickled SourceStamp's may not have _getSourceStampId_lock set on them. Message-ID: <042.ec17a813cfbacb68500b8dc4f6b03f91@buildbot.net> #2096: Pickled SourceStamp's may not have _getSourceStampId_lock set on them. -----------------------+----------------------- Reporter: tom.prince | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: master | Keywords: -----------------------+----------------------- This triggers an exception when trying to force build an old build. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Sep 2 23:33:25 2011 From: nobody at buildbot.net (Buildbot) Date: Fri, 02 Sep 2011 23:33:25 -0000 Subject: [Buildbot-commits] [Buildbot] #2096: Pickled SourceStamp's may not have _getSourceStampId_lock set on them. In-Reply-To: <042.ec17a813cfbacb68500b8dc4f6b03f91@buildbot.net> References: <042.ec17a813cfbacb68500b8dc4f6b03f91@buildbot.net> Message-ID: <057.5c87a7bc1ae499730d75b201490eedb1@buildbot.net> #2096: Pickled SourceStamp's may not have _getSourceStampId_lock set on them. -----------------------+------------------------ Reporter: tom.prince | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: master | Resolution: Keywords: | -----------------------+------------------------ Comment (by tom.prince): {{{ 17:27:15 +djmitche | a bit harder to solve 17:27:31 +djmitche | I'll need to override __setstate__, and make sure to still call through to the Versioned stuff 17:27:34 +djmitche | I'll want to write some tests 17:32:13 tomprince | Another possibility might be to override __new__, although I don't know the repurcussions of that. 17:32:46 +djmitche | yeah, I'd rather tiptoe around the still- persisted classes }}} -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sat Sep 3 17:42:55 2011 From: noreply at github.com (noreply at github.com) Date: Sat, 3 Sep 2011 10:42:55 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 8b0ac2: Fix sqlalchemy warnings about listeners Message-ID: <20110903174255.2DD24425DC@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 8b0ac262e4d9df26d812d639b9c063187d4345c0 https://github.com/buildbot/buildbot/commit/8b0ac262e4d9df26d812d639b9c063187d4345c0 Author: Dustin J. Mitchell Date: 2011-09-03 (Sat, 03 Sep 2011) Changed paths: M master/buildbot/db/enginestrategy.py M master/buildbot/test/unit/test_db_enginestrategy.py Log Message: ----------- Fix sqlalchemy warnings about listeners From nobody at buildbot.net Sat Sep 3 17:47:42 2011 From: nobody at buildbot.net (Buildbot) Date: Sat, 03 Sep 2011 17:47:42 -0000 Subject: [Buildbot-commits] [Buildbot] #2091: MailNotifier chokes on try job with non-ascii char in first line of patch? In-Reply-To: <036.f0e569802d6f78483b94442701bcb9e8@buildbot.net> References: <036.f0e569802d6f78483b94442701bcb9e8@buildbot.net> Message-ID: <051.2c53ffdf2fd809da6ddbfd2bd8d47dd0@buildbot.net> #2091: MailNotifier chokes on try job with non-ascii char in first line of patch? ---------------------+-------------------- Reporter: dank | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.5 Version: master | Resolution: Keywords: encoding | ---------------------+-------------------- Changes (by dustin): * keywords: => encoding * milestone: undecided => 0.8.5 Comment: Hmm, patches don't generally come with an encoding - they're bytestrings. I suspect that the best we can do here is to try to decode the patch using a default encoding, ignoring errors, and then re-encode it as utf8. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Sep 3 18:07:39 2011 From: nobody at buildbot.net (Buildbot) Date: Sat, 03 Sep 2011 18:07:39 -0000 Subject: [Buildbot-commits] [Buildbot] #2093: try does not understand patches generated by git In-Reply-To: <036.ec4af867fa6da598c739c385436b18ee@buildbot.net> References: <036.ec4af867fa6da598c739c385436b18ee@buildbot.net> Message-ID: <051.87a6c9120060bdddc9a352a85fe2a1b2@buildbot.net> #2093: try does not understand patches generated by git ------------------------+-------------------- Reporter: dank | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: master | Resolution: Keywords: git | ------------------------+-------------------- Changes (by dustin): * keywords: => git * type: undecided => enhancement * milestone: undecided => 0.8.+ Comment: Can you make the same change to the master-side Git step, and adjust unit tests to match? -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sat Sep 3 18:14:26 2011 From: noreply at github.com (noreply at github.com) Date: Sat, 3 Sep 2011 11:14:26 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] ce2217: retain backward-compatibility with older sqlalchem... Message-ID: <20110903181426.BBADB42519@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: ce22177dd33641679267c051191277d0416380e4 https://github.com/buildbot/buildbot/commit/ce22177dd33641679267c051191277d0416380e4 Author: Dustin J. Mitchell Date: 2011-09-03 (Sat, 03 Sep 2011) Changed paths: M master/buildbot/db/enginestrategy.py M master/buildbot/test/unit/test_db_enginestrategy.py Log Message: ----------- retain backward-compatibility with older sqlalchemies From nobody at buildbot.net Sat Sep 3 18:18:59 2011 From: nobody at buildbot.net (Buildbot) Date: Sat, 03 Sep 2011 18:18:59 -0000 Subject: [Buildbot-commits] [Buildbot] #2086: better indexing for sphinx docs In-Reply-To: <038.403ce6948ee43ef1da80b8d31d74728b@buildbot.net> References: <038.403ce6948ee43ef1da80b8d31d74728b@buildbot.net> Message-ID: <053.b3d1a6c54d0c0bb9e8d66918de1a2976@buildbot.net> #2086: better indexing for sphinx docs ------------------------+--------------------- Reporter: dustin | Owner: Type: enhancement | Status: closed Priority: major | Milestone: 0.8.5 Version: master | Resolution: fixed Keywords: docs | ------------------------+--------------------- Changes (by dustin): * status: new => closed * resolution: => fixed Comment: I've added a number of indices now, and I think that's enough :) -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Sep 3 18:19:44 2011 From: nobody at buildbot.net (Buildbot) Date: Sat, 03 Sep 2011 18:19:44 -0000 Subject: [Buildbot-commits] [Buildbot] #2094: latest contrib/git_buildbot.py not compatible with older installs of buildbot In-Reply-To: <035.e9c10835c051dbcb97489bb12d4781de@buildbot.net> References: <035.e9c10835c051dbcb97489bb12d4781de@buildbot.net> Message-ID: <050.1ef44572f29663db74dedb769034a17d@buildbot.net> #2094: latest contrib/git_buildbot.py not compatible with older installs of buildbot ---------------------+-------------------- Reporter: ajb | Owner: Type: defect | Status: new Priority: critical | Milestone: 0.8.5 Version: master | Resolution: Keywords: git | ---------------------+-------------------- Changes (by dustin): * priority: major => critical * version: 0.8.4p2 => master * milestone: undecided => 0.8.5 -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sat Sep 3 19:15:11 2011 From: noreply at github.com (noreply at github.com) Date: Sat, 3 Sep 2011 12:15:11 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 9c95d5: Merge branch '1970' of git://github.com/dzhurley/b... Message-ID: <20110903191511.BBA5B42625@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 9c95d5043ac166061f0c096a1f8bc05a86e2b968 https://github.com/buildbot/buildbot/commit/9c95d5043ac166061f0c096a1f8bc05a86e2b968 Author: Dustin J. Mitchell Date: 2011-09-03 (Sat, 03 Sep 2011) Changed paths: M master/buildbot/status/words.py M master/docs/manual/cfg-statustargets.rst Log Message: ----------- Merge branch '1970' of git://github.com/dzhurley/buildbot * '1970' of git://github.com/dzhurley/buildbot: add args for lostDelay and failedDelay, fixes #1970 Fixes #1970. From nobody at buildbot.net Sat Sep 3 19:15:18 2011 From: nobody at buildbot.net (Buildbot) Date: Sat, 03 Sep 2011 19:15:18 -0000 Subject: [Buildbot-commits] [Buildbot] #1970: IRC status notifier is reconnecting too fast In-Reply-To: <037.f93a33de7d321ac6aed00eaf68e15f66@buildbot.net> References: <037.f93a33de7d321ac6aed00eaf68e15f66@buildbot.net> Message-ID: <052.9ef8a7e2c4bc532551004578746c1f98@buildbot.net> #1970: IRC status notifier is reconnecting too fast --------------------------+--------------------- Reporter: Almad | Owner: Type: enhancement | Status: closed Priority: major | Milestone: 0.8.+ Version: 0.8.0 | Resolution: fixed Keywords: redheadphones | --------------------------+--------------------- Changes (by Dustin J. Mitchell): * status: new => closed * resolution: => fixed Comment: Merge branch '1970' of git://github.com/dzhurley/buildbot * '1970' of git://github.com/dzhurley/buildbot: add args for lostDelay and failedDelay, fixes #1970 Fixes #1970. Changeset: 9c95d5043ac166061f0c096a1f8bc05a86e2b968 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Sep 3 19:19:06 2011 From: nobody at buildbot.net (Buildbot) Date: Sat, 03 Sep 2011 19:19:06 -0000 Subject: [Buildbot-commits] [Buildbot] #2055: buildmaster spins when build starts In-Reply-To: <038.7c5d837314c12cddc1ef74bf0334dab5@buildbot.net> References: <038.7c5d837314c12cddc1ef74bf0334dab5@buildbot.net> Message-ID: <053.b3f30aff64be9e007ea5ec536e51dba9@buildbot.net> #2055: buildmaster spins when build starts -----------------------+---------------------- Reporter: mmorse | Owner: Type: defect | Status: new Priority: major | Milestone: ongoing Version: 0.8.4p2 | Resolution: Keywords: threadbugs | -----------------------+---------------------- Comment (by dustin): This lends credence to the idea that the signals are causing the deadlock. Perhaps running a Python application from launchd causes a greater number of signals to be delivered to implement some clever Apple technology? -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sat Sep 3 19:36:00 2011 From: noreply at github.com (noreply at github.com) Date: Sat, 3 Sep 2011 12:36:00 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] c53c8d: Merge branch 'user_objects_authz_commit' of git://... Message-ID: <20110903193600.2B7E6426FE@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: c53c8d2137bb471f7d68b5bc9c7672f63f81cbae https://github.com/buildbot/buildbot/commit/c53c8d2137bb471f7d68b5bc9c7672f63f81cbae Author: Dustin J. Mitchell Date: 2011-09-03 (Sat, 03 Sep 2011) Changed paths: M master/buildbot/clients/usersclient.py A master/buildbot/db/migrate/versions/014_add_users_userpass_columns.py M master/buildbot/db/model.py M master/buildbot/db/users.py M master/buildbot/process/users/manual.py M master/buildbot/process/users/users.py M master/buildbot/scripts/runner.py M master/buildbot/status/web/auth.py M master/buildbot/status/web/baseweb.py M master/buildbot/test/fake/fakedb.py M master/buildbot/test/unit/test_clients_usersclient.py M master/buildbot/test/unit/test_db_users.py M master/buildbot/test/unit/test_process_users_manual.py M master/buildbot/test/unit/test_process_users_users.py M master/buildbot/test/unit/test_scripts_runner.py M master/docs/manual/cfg-statustargets.rst M master/docs/manual/cmdline.rst M master/docs/manual/concepts.rst Log Message: ----------- Merge branch 'user_objects_authz_commit' of git://github.com/dzhurley/buildbot * 'user_objects_authz_commit' of git://github.com/dzhurley/buildbot: refactored UsersAuth IAuth instance based on feedback added UsersAuth IAuth instance Commit: 136cd2036a134d9789badbfdef6a2dcaa275db56 https://github.com/buildbot/buildbot/commit/136cd2036a134d9789badbfdef6a2dcaa275db56 Author: Dustin J. Mitchell Date: 2011-09-03 (Sat, 03 Sep 2011) Changed paths: M master/docs/manual/concepts.rst Log Message: ----------- fix xref in documentation Compare: https://github.com/buildbot/buildbot/compare/9c95d50...136cd20 From nobody at buildbot.net Sat Sep 3 19:38:39 2011 From: nobody at buildbot.net (Buildbot) Date: Sat, 03 Sep 2011 19:38:39 -0000 Subject: [Buildbot-commits] [Buildbot] #2096: Pickled SourceStamp's may not have _getSourceStampId_lock set on them. In-Reply-To: <042.ec17a813cfbacb68500b8dc4f6b03f91@buildbot.net> References: <042.ec17a813cfbacb68500b8dc4f6b03f91@buildbot.net> Message-ID: <057.e5fe09732aa44093c759aae7efde9ab2@buildbot.net> #2096: Pickled SourceStamp's may not have _getSourceStampId_lock set on them. -----------------------+-------------------- Reporter: tom.prince | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.5 Version: master | Resolution: Keywords: | -----------------------+-------------------- Changes (by dustin): * milestone: undecided => 0.8.5 -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sat Sep 3 19:39:48 2011 From: noreply at github.com (noreply at github.com) Date: Sat, 3 Sep 2011 12:39:48 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 3af661: Merge branch 'git' of git://github.com/tomprince/b... Message-ID: <20110903193948.16E0E4275A@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 3af6611d417aba5e88dfd4a3e10480e5c98d6748 https://github.com/buildbot/buildbot/commit/3af6611d417aba5e88dfd4a3e10480e5c98d6748 Author: Dustin J. Mitchell Date: 2011-09-03 (Sat, 03 Sep 2011) Changed paths: M master/buildbot/steps/source/git.py Log Message: ----------- Merge branch 'git' of git://github.com/tomprince/buildbot * 'git' of git://github.com/tomprince/buildbot: Git: Don't fail on missing revision in repository. From noreply at github.com Sat Sep 3 20:07:20 2011 From: noreply at github.com (noreply at github.com) Date: Sat, 3 Sep 2011 13:07:20 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 019ec8: Ensure that SourceStamps unpickle correctly Message-ID: <20110903200720.DF49F424DA@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 019ec87808ea08c57067ebf7ac8223e245598478 https://github.com/buildbot/buildbot/commit/019ec87808ea08c57067ebf7ac8223e245598478 Author: Dustin J. Mitchell Date: 2011-09-03 (Sat, 03 Sep 2011) Changed paths: M master/buildbot/sourcestamp.py M master/buildbot/test/integration/test_upgrade.py Log Message: ----------- Ensure that SourceStamps unpickle correctly This adds _getSourceStampId_lock when unpickling. Fixes #2096. From nobody at buildbot.net Sat Sep 3 20:07:26 2011 From: nobody at buildbot.net (Buildbot) Date: Sat, 03 Sep 2011 20:07:26 -0000 Subject: [Buildbot-commits] [Buildbot] #2096: Pickled SourceStamp's may not have _getSourceStampId_lock set on them. In-Reply-To: <042.ec17a813cfbacb68500b8dc4f6b03f91@buildbot.net> References: <042.ec17a813cfbacb68500b8dc4f6b03f91@buildbot.net> Message-ID: <057.59edba5da97381f5dbf79c9feeceb154@buildbot.net> #2096: Pickled SourceStamp's may not have _getSourceStampId_lock set on them. -----------------------+--------------------- Reporter: tom.prince | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.5 Version: master | Resolution: fixed Keywords: | -----------------------+--------------------- Changes (by Dustin J. Mitchell): * status: new => closed * resolution: => fixed Comment: Ensure that SourceStamps unpickle correctly This adds _getSourceStampId_lock when unpickling. Fixes #2096. Changeset: 019ec87808ea08c57067ebf7ac8223e245598478 -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sat Sep 3 20:18:59 2011 From: noreply at github.com (noreply at github.com) Date: Sat, 3 Sep 2011 13:18:59 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 46b646: clean git builddirs after patches Message-ID: <20110903201859.0F214423EA@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 46b64601449abb4238c3bd991c278da540ecd865 https://github.com/buildbot/buildbot/commit/46b64601449abb4238c3bd991c278da540ecd865 Author: Dustin J. Mitchell Date: 2011-09-03 (Sat, 03 Sep 2011) Changed paths: M slave/buildslave/commands/git.py Log Message: ----------- clean git builddirs after patches Fixes #2084. From nobody at buildbot.net Sat Sep 3 20:19:04 2011 From: nobody at buildbot.net (Buildbot) Date: Sat, 03 Sep 2011 20:19:04 -0000 Subject: [Buildbot-commits] [Buildbot] #2084: files created by trypatches are not removed. next similar tryruns fail In-Reply-To: <035.389af69927aba43a68ad9398f7bb0933@buildbot.net> References: <035.389af69927aba43a68ad9398f7bb0933@buildbot.net> Message-ID: <050.9d4aa77a7ef56832779aba590c56df0d@buildbot.net> #2084: files created by trypatches are not removed. next similar tryruns fail ----------------------+------------------------ Reporter: gg0 | Owner: Type: undecided | Status: closed Priority: major | Milestone: undecided Version: 0.8.4p2 | Resolution: fixed Keywords: | ----------------------+------------------------ Changes (by Dustin J. Mitchell): * status: new => closed * resolution: => fixed Comment: clean git builddirs after patches Fixes #2084. Changeset: 46b64601449abb4238c3bd991c278da540ecd865 -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sat Sep 3 21:16:55 2011 From: noreply at github.com (noreply at github.com) Date: Sat, 3 Sep 2011 14:16:55 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 0d85e9: Allow command invocations to get stdout back if de... Message-ID: <20110903211655.CF7A5425AA@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 0d85e971e15530588fad2e59db5fd6b57c2bb560 https://github.com/buildbot/buildbot/commit/0d85e971e15530588fad2e59db5fd6b57c2bb560 Author: Dustin J. Mitchell Date: 2011-09-03 (Sat, 03 Sep 2011) Changed paths: M master/buildbot/process/buildstep.py M master/buildbot/steps/source/bzr.py M master/buildbot/steps/source/git.py M master/buildbot/steps/source/mercurial.py M master/buildbot/steps/source/svn.py M master/buildbot/test/fake/remotecommand.py M master/buildbot/test/unit/test_steps_source_svn.py Log Message: ----------- Allow command invocations to get stdout back if desired Fixes #2095. From nobody at buildbot.net Sat Sep 3 21:17:01 2011 From: nobody at buildbot.net (Buildbot) Date: Sat, 03 Sep 2011 21:17:01 -0000 Subject: [Buildbot-commits] [Buildbot] #2095: master-side commands only have access to full logfiles In-Reply-To: <038.ffe451e3e91ab365cd161be6ae6a8dc5@buildbot.net> References: <038.ffe451e3e91ab365cd161be6ae6a8dc5@buildbot.net> Message-ID: <053.d38bd83cdcf7f628d95836e612426886@buildbot.net> #2095: master-side commands only have access to full logfiles --------------------+--------------------- Reporter: dustin | Owner: Type: defect | Status: closed Priority: minor | Milestone: 0.8.5 Version: 0.8.4p2 | Resolution: fixed Keywords: | --------------------+--------------------- Changes (by Dustin J. Mitchell): * status: new => closed * resolution: => fixed Comment: Allow command invocations to get stdout back if desired Fixes #2095. Changeset: 0d85e971e15530588fad2e59db5fd6b57c2bb560 -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sat Sep 3 22:03:55 2011 From: noreply at github.com (noreply at github.com) Date: Sat, 3 Sep 2011 15:03:55 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] f88b6d: Revert the change to add a new keyword argument to... Message-ID: <20110903220355.21E9042355@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: f88b6d09de6552e08febec0bf7d5c26a85a20897 https://github.com/buildbot/buildbot/commit/f88b6d09de6552e08febec0bf7d5c26a85a20897 Author: Dustin J. Mitchell Date: 2011-09-03 (Sat, 03 Sep 2011) Changed paths: M master/buildbot/changes/pb.py M master/buildbot/clients/sendchange.py M master/buildbot/test/unit/test_changes_pb.py M master/buildbot/test/unit/test_clients_sendchange.py M master/contrib/bitbucket_buildbot.py M master/contrib/bzr_buildbot.py M master/contrib/git_buildbot.py M master/contrib/github_buildbot.py M master/contrib/svn_buildbot.py M master/contrib/viewcvspoll.py Log Message: ----------- Revert the change to add a new keyword argument to perspective_addChange Rather than add a new keyword argument (which will be rejected when a new client connects to an old master), this adds 'src' to the change dict; this will be ignored by old masters. Fixes #2094. From nobody at buildbot.net Sat Sep 3 22:04:00 2011 From: nobody at buildbot.net (Buildbot) Date: Sat, 03 Sep 2011 22:04:00 -0000 Subject: [Buildbot-commits] [Buildbot] #2094: latest contrib/git_buildbot.py not compatible with older installs of buildbot In-Reply-To: <035.e9c10835c051dbcb97489bb12d4781de@buildbot.net> References: <035.e9c10835c051dbcb97489bb12d4781de@buildbot.net> Message-ID: <050.4eb51e1e1068eff7769fcce0b4449a32@buildbot.net> #2094: latest contrib/git_buildbot.py not compatible with older installs of buildbot ---------------------+--------------------- Reporter: ajb | Owner: Type: defect | Status: closed Priority: critical | Milestone: 0.8.5 Version: master | Resolution: fixed Keywords: git | ---------------------+--------------------- Changes (by Dustin J. Mitchell): * status: new => closed * resolution: => fixed Comment: Revert the change to add a new keyword argument to perspective_addChange Rather than add a new keyword argument (which will be rejected when a new client connects to an old master), this adds 'src' to the change dict; this will be ignored by old masters. Fixes #2094. Changeset: f88b6d09de6552e08febec0bf7d5c26a85a20897 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Sep 3 22:04:43 2011 From: nobody at buildbot.net (Buildbot) Date: Sat, 03 Sep 2011 22:04:43 -0000 Subject: [Buildbot-commits] [Buildbot] #1061: Buildbot locks downloaded files In-Reply-To: <039.3caf071a0bf60c4df27fb569d19d0709@buildbot.net> References: <039.3caf071a0bf60c4df27fb569d19d0709@buildbot.net> Message-ID: <054.749795633c8aac7152f955747ccc0551@buildbot.net> #1061: Buildbot locks downloaded files ------------------------------+-------------------- Reporter: parshin | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.2 | Resolution: Keywords: windows, transfer | ------------------------------+-------------------- Changes (by dustin): * milestone: 0.8.5 => 0.8.+ Comment: I'm not sure this can be easily fixed in 0.8.5. I suspect that all process spawning in Buildbot should be farmed out to a helper process. I wonder how difficult it would be to use Multiprocessing to accomplish that? -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sat Sep 3 22:27:36 2011 From: noreply at github.com (noreply at github.com) Date: Sat, 3 Sep 2011 15:27:36 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 6c0f1b: Handle non-unicode patches in MailNotifier Message-ID: <20110903222736.DF1A0425BC@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 6c0f1bb630f42df4cb5b02de3e4c2349e196dca8 https://github.com/buildbot/buildbot/commit/6c0f1bb630f42df4cb5b02de3e4c2349e196dca8 Author: Dustin J. Mitchell Date: 2011-09-03 (Sat, 03 Sep 2011) Changed paths: M master/buildbot/status/mail.py M master/buildbot/test/unit/test_status_mail.py Log Message: ----------- Handle non-unicode patches in MailNotifier This makes the reasonable assumption that most patches will be interpretable as unicode, even though they are fundamentally bytestrings. Where such interpretation fails, they will be attached to the mail as binary blobs. Fixes #2091. From nobody at buildbot.net Sat Sep 3 22:27:42 2011 From: nobody at buildbot.net (Buildbot) Date: Sat, 03 Sep 2011 22:27:42 -0000 Subject: [Buildbot-commits] [Buildbot] #2091: MailNotifier chokes on try job with non-ascii char in first line of patch? In-Reply-To: <036.f0e569802d6f78483b94442701bcb9e8@buildbot.net> References: <036.f0e569802d6f78483b94442701bcb9e8@buildbot.net> Message-ID: <051.d9659cb7a877498709882a50cfd49a86@buildbot.net> #2091: MailNotifier chokes on try job with non-ascii char in first line of patch? ---------------------+--------------------- Reporter: dank | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.5 Version: master | Resolution: fixed Keywords: encoding | ---------------------+--------------------- Changes (by Dustin J. Mitchell): * status: new => closed * resolution: => fixed Comment: Handle non-unicode patches in MailNotifier This makes the reasonable assumption that most patches will be interpretable as unicode, even though they are fundamentally bytestrings. Where such interpretation fails, they will be attached to the mail as binary blobs. Fixes #2091. Changeset: 6c0f1bb630f42df4cb5b02de3e4c2349e196dca8 -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sat Sep 3 22:35:11 2011 From: noreply at github.com (noreply at github.com) Date: Sat, 3 Sep 2011 15:35:11 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 9c5386: branch for buildbot-0.8.5 Message-ID: <20110903223511.B01BD425DD@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 9c53866369a58be401c76039dc332729eaa56116 https://github.com/buildbot/buildbot/commit/9c53866369a58be401c76039dc332729eaa56116 Author: Dustin J. Mitchell Date: 2011-09-03 (Sat, 03 Sep 2011) Changed paths: M master/NEWS M slave/NEWS Log Message: ----------- branch for buildbot-0.8.5 Commit: d1433380387779de4e67523c36d9dd580b84f6df https://github.com/buildbot/buildbot/commit/d1433380387779de4e67523c36d9dd580b84f6df Author: Dustin J. Mitchell Date: 2011-09-03 (Sat, 03 Sep 2011) Changed paths: M master/NEWS M slave/NEWS Log Message: ----------- add 'Next Version' to NEWS Compare: https://github.com/buildbot/buildbot/compare/6c0f1bb...d143338 From noreply at github.com Sat Sep 3 22:50:59 2011 From: noreply at github.com (noreply at github.com) Date: Sat, 3 Sep 2011 15:50:59 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 7f0ea5: Properly handle rendering of logfiles. Message-ID: <20110903225059.2E92A42604@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 7f0ea55d67f07b20dda5e7591e6b348bf5c7c3fd https://github.com/buildbot/buildbot/commit/7f0ea55d67f07b20dda5e7591e6b348bf5c7c3fd Author: Tom Prince Date: 2011-09-03 (Sat, 03 Sep 2011) Changed paths: M master/buildbot/process/buildstep.py Log Message: ----------- Properly handle rendering of logfiles. Commit: 011dc1ec28a1eb4e79ecdea02a615abc024992cb https://github.com/buildbot/buildbot/commit/011dc1ec28a1eb4e79ecdea02a615abc024992cb Author: Tom Prince Date: 2011-09-03 (Sat, 03 Sep 2011) Changed paths: M master/buildbot/status/web/baseweb.py Log Message: ----------- WebStatus: allow not specifying any auth database. Commit: 19c22e5bbcb0e95b5831ba118a2558d6a50903ef https://github.com/buildbot/buildbot/commit/19c22e5bbcb0e95b5831ba118a2558d6a50903ef Author: Dustin J. Mitchell Date: 2011-09-03 (Sat, 03 Sep 2011) Changed paths: M master/docs/manual/cfg-properties.rst Log Message: ----------- call out a common error with properties Commit: 6397c32cf2e30650500a36a10be191fb765083f7 https://github.com/buildbot/buildbot/commit/6397c32cf2e30650500a36a10be191fb765083f7 Author: Dustin J. Mitchell Date: 2011-09-03 (Sat, 03 Sep 2011) Changed paths: M master/buildbot/process/buildstep.py M master/buildbot/status/web/baseweb.py Log Message: ----------- Merge branch 'misc' of git://github.com/tomprince/buildbot * 'misc' of git://github.com/tomprince/buildbot: WebStatus: allow not specifying any auth database. Properly handle rendering of logfiles. Compare: https://github.com/buildbot/buildbot/compare/d143338...6397c32 From noreply at github.com Sat Sep 3 22:53:26 2011 From: noreply at github.com (noreply at github.com) Date: Sat, 3 Sep 2011 15:53:26 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 681bfa: Properly handle rendering of logfiles. Message-ID: <20110903225326.3A9DA42604@smtp1.rs.github.com> Branch: refs/heads/buildbot-0.8.5 Home: https://github.com/buildbot/buildbot Commit: 681bfa10f4a6003e49e4c00b08c5d835f218dea4 https://github.com/buildbot/buildbot/commit/681bfa10f4a6003e49e4c00b08c5d835f218dea4 Author: Tom Prince Date: 2011-09-03 (Sat, 03 Sep 2011) Changed paths: M master/buildbot/process/buildstep.py Log Message: ----------- Properly handle rendering of logfiles. Commit: e31a8b52f3ad21bb6ed55e2f54763c526adfaad6 https://github.com/buildbot/buildbot/commit/e31a8b52f3ad21bb6ed55e2f54763c526adfaad6 Author: Tom Prince Date: 2011-09-03 (Sat, 03 Sep 2011) Changed paths: M master/buildbot/status/web/baseweb.py Log Message: ----------- WebStatus: allow not specifying any auth database. Commit: 1f9955386fc3f428828230a4cfd9652485e3f715 https://github.com/buildbot/buildbot/commit/1f9955386fc3f428828230a4cfd9652485e3f715 Author: Dustin J. Mitchell Date: 2011-09-03 (Sat, 03 Sep 2011) Changed paths: M master/docs/manual/cfg-properties.rst Log Message: ----------- call out a common error with properties Compare: https://github.com/buildbot/buildbot/compare/9c53866...1f99553 From noreply at github.com Sat Sep 3 22:58:37 2011 From: noreply at github.com (noreply at github.com) Date: Sat, 3 Sep 2011 15:58:37 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 5d1ae8: Initialize metrics variables in LoggedRemoteComman... Message-ID: <20110903225837.45A2442685@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 5d1ae8a093d552621dc4a87c230b25a3ad7ba1ed https://github.com/buildbot/buildbot/commit/5d1ae8a093d552621dc4a87c230b25a3ad7ba1ed Author: Tom Prince Date: 2011-09-03 (Sat, 03 Sep 2011) Changed paths: M master/buildbot/process/buildstep.py Log Message: ----------- Initialize metrics variables in LoggedRemoteCommand.__init__ not .useLog. Not every user of LoggedRemoteCommand calls useLog. Those that don't fail due to the metrics. From noreply at github.com Sat Sep 3 22:58:37 2011 From: noreply at github.com (noreply at github.com) Date: Sat, 3 Sep 2011 15:58:37 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 69db90: Initialize metrics variables in LoggedRemoteComman... Message-ID: <20110903225837.0A0584267B@smtp1.rs.github.com> Branch: refs/heads/buildbot-0.8.5 Home: https://github.com/buildbot/buildbot Commit: 69db90983a15fe249271092eb5ef4daeb213a54b https://github.com/buildbot/buildbot/commit/69db90983a15fe249271092eb5ef4daeb213a54b Author: Tom Prince Date: 2011-09-03 (Sat, 03 Sep 2011) Changed paths: M master/buildbot/process/buildstep.py Log Message: ----------- Initialize metrics variables in LoggedRemoteCommand.__init__ not .useLog. Not every user of LoggedRemoteCommand calls useLog. Those that don't fail due to the metrics. From noreply at github.com Sun Sep 4 15:25:22 2011 From: noreply at github.com (noreply at github.com) Date: Sun, 4 Sep 2011 08:25:22 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 3a02fa: document buildbot try's --comments option Message-ID: <20110904152522.5CBBA4265F@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 3a02fa978ada5187d47edc715f9c6f4bf8d45394 https://github.com/buildbot/buildbot/commit/3a02fa978ada5187d47edc715f9c6f4bf8d45394 Author: Dustin J. Mitchell Date: 2011-09-04 (Sun, 04 Sep 2011) Changed paths: M master/docs/manual/cmdline.rst Log Message: ----------- document buildbot try's --comments option From noreply at github.com Sun Sep 4 15:25:22 2011 From: noreply at github.com (noreply at github.com) Date: Sun, 4 Sep 2011 08:25:22 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 11c3f5: document buildbot try's --comments option Message-ID: <20110904152522.4A81242658@smtp1.rs.github.com> Branch: refs/heads/buildbot-0.8.5 Home: https://github.com/buildbot/buildbot Commit: 11c3f57e8c49b2c8ea5993ea6196b3dea2d74540 https://github.com/buildbot/buildbot/commit/11c3f57e8c49b2c8ea5993ea6196b3dea2d74540 Author: Dustin J. Mitchell Date: 2011-09-04 (Sun, 04 Sep 2011) Changed paths: M master/docs/manual/cmdline.rst Log Message: ----------- document buildbot try's --comments option From nobody at buildbot.net Sun Sep 4 16:48:43 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 04 Sep 2011 16:48:43 -0000 Subject: [Buildbot-commits] [Buildbot] #2097: new Git step fails with exception rather than failure. Message-ID: <042.e31f5b2a7788606f293646763eed11a0@buildbot.net> #2097: new Git step fails with exception rather than failure. -----------------------+----------------------- Reporter: tom.prince | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: master | Keywords: git -----------------------+----------------------- http://coq.hocat.ca/buildbot/builders/math-classes/builds/5/steps/git -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Sep 4 17:18:32 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 04 Sep 2011 17:18:32 -0000 Subject: [Buildbot-commits] [Buildbot] #2097: new Git step fails with exception rather than failure. In-Reply-To: <042.e31f5b2a7788606f293646763eed11a0@buildbot.net> References: <042.e31f5b2a7788606f293646763eed11a0@buildbot.net> Message-ID: <057.0959d975759f33220adef3ab9b2bdc6b@buildbot.net> #2097: new Git step fails with exception rather than failure. -----------------------+-------------------- Reporter: tom.prince | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.5 Version: master | Resolution: Keywords: git | -----------------------+-------------------- Changes (by dustin): * cc: in3xes (added) * milestone: undecided => 0.8.5 -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sun Sep 4 17:36:30 2011 From: noreply at github.com (noreply at github.com) Date: Sun, 4 Sep 2011 10:36:30 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 6c51cd: update NEWS with GSoC projects Message-ID: <20110904173630.BADFC42634@smtp1.rs.github.com> Branch: refs/heads/buildbot-0.8.5 Home: https://github.com/buildbot/buildbot Commit: 6c51cd4137d850cdfba21e02cd5bb670e072542c https://github.com/buildbot/buildbot/commit/6c51cd4137d850cdfba21e02cd5bb670e072542c Author: Dustin J. Mitchell Date: 2011-09-04 (Sun, 04 Sep 2011) Changed paths: M master/NEWS Log Message: ----------- update NEWS with GSoC projects From noreply at github.com Sun Sep 4 17:36:30 2011 From: noreply at github.com (noreply at github.com) Date: Sun, 4 Sep 2011 10:36:30 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 0398df: update NEWS with GSoC projects Message-ID: <20110904173630.C8D194266E@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 0398df189a285b9270c0ba9ca285ae136ed28829 https://github.com/buildbot/buildbot/commit/0398df189a285b9270c0ba9ca285ae136ed28829 Author: Dustin J. Mitchell Date: 2011-09-04 (Sun, 04 Sep 2011) Changed paths: M master/NEWS Log Message: ----------- update NEWS with GSoC projects Commit: 49f636813b3f4dc5b2b2a12e759dbb5160cd40c8 https://github.com/buildbot/buildbot/commit/49f636813b3f4dc5b2b2a12e759dbb5160cd40c8 Author: Dustin J. Mitchell Date: 2011-09-04 (Sun, 04 Sep 2011) Changed paths: M master/buildbot/steps/source/git.py Log Message: ----------- refactor Git.incremental into a deferredGenerator Compare: https://github.com/buildbot/buildbot/compare/3a02fa9...49f6368 From nobody at buildbot.net Sun Sep 4 17:37:25 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 04 Sep 2011 17:37:25 -0000 Subject: [Buildbot-commits] [Buildbot] #2097: new Git step fails with exception rather than failure. In-Reply-To: <042.e31f5b2a7788606f293646763eed11a0@buildbot.net> References: <042.e31f5b2a7788606f293646763eed11a0@buildbot.net> Message-ID: <057.e9892cf5b48e65d2ae04e589c0422f04@buildbot.net> #2097: new Git step fails with exception rather than failure. -----------------------+-------------------- Reporter: tom.prince | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.5 Version: master | Resolution: Keywords: git | -----------------------+-------------------- Comment (by dustin): This looks like a wider problem -- I see {{{raise failure.Failure(rc)}}} (or, worse, {{{raise failure.Failure}}}) in a number of places in the new code. This will need to be the local equivalent of !AbandonChain, although I'm not sure exactly what that is! -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Sep 4 17:39:05 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 04 Sep 2011 17:39:05 -0000 Subject: [Buildbot-commits] [Buildbot] #2092: MailNotifier crashes if sendToInterestedUsers=False In-Reply-To: <036.2faca924724066af8ac9bca5d8ddfd04@buildbot.net> References: <036.2faca924724066af8ac9bca5d8ddfd04@buildbot.net> Message-ID: <051.28644b8e664ece10f10e2afa65ce5a81@buildbot.net> #2092: MailNotifier crashes if sendToInterestedUsers=False -------------------+------------------------ Reporter: dank | Owner: Type: defect | Status: closed Priority: major | Milestone: undecided Version: master | Resolution: fixed Keywords: | -------------------+------------------------ Comment (by dank): Thanks. I'm using buildbot from git, and it no longer crashes when sendToInterestedUsers=False. Oddly, though, it seems to ignore the value of sendToInterestedUsers. If I set it to False, the author of the try job still gets email. I haven't dug into this in detail, so treat this as a rumor. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Sep 4 18:17:34 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 04 Sep 2011 18:17:34 -0000 Subject: [Buildbot-commits] [Buildbot] #2097: new Git step fails with exception rather than failure. In-Reply-To: <042.e31f5b2a7788606f293646763eed11a0@buildbot.net> References: <042.e31f5b2a7788606f293646763eed11a0@buildbot.net> Message-ID: <057.1d38e31ccc50ec30fecabbb15f8f20c5@buildbot.net> #2097: new Git step fails with exception rather than failure. -----------------------+-------------------- Reporter: tom.prince | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.5 Version: master | Resolution: Keywords: git | -----------------------+-------------------- Comment (by tom.prince): It also doesn't seem to always respond promptly to interruption requests. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Sep 4 22:36:23 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 04 Sep 2011 22:36:23 -0000 Subject: [Buildbot-commits] [Buildbot] #2042: remove schedulers.state column In-Reply-To: <038.093465493dc77fd489f2a277fa8cc1a7@buildbot.net> References: <038.093465493dc77fd489f2a277fa8cc1a7@buildbot.net> Message-ID: <053.3648d678c7bc8a38473819edc0dbc5a4@buildbot.net> #2042: remove schedulers.state column -----------------------------+-------------------- Reporter: dustin | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.5 Version: 0.8.4p2 | Resolution: Keywords: database, simple | -----------------------------+-------------------- Changes (by dustin): * type: enhancement => defect Comment: There's still some work to do here: * remove the methods from master.db.schedulers * remove the state-management methods from BaseScheduler * fix Timed to not use state * update the corresponding migration script -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sun Sep 4 22:37:27 2011 From: noreply at github.com (noreply at github.com) Date: Sun, 4 Sep 2011 15:37:27 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 25570f: Fix passing of collectStdout from RemoteShellComma... Message-ID: <20110904223727.5F70F4262C@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 25570f85a44f6c451bf4064cbd9e6b2c8aeb8521 https://github.com/buildbot/buildbot/commit/25570f85a44f6c451bf4064cbd9e6b2c8aeb8521 Author: Tom Prince Date: 2011-09-04 (Sun, 04 Sep 2011) Changed paths: M master/buildbot/process/buildstep.py Log Message: ----------- Fix passing of collectStdout from RemoteShellCommand to LoggedRemoteCommand. Commit: e96251b069a9501e468347571191d4dedddb9e52 https://github.com/buildbot/buildbot/commit/e96251b069a9501e468347571191d4dedddb9e52 Author: Dustin J. Mitchell Date: 2011-09-04 (Sun, 04 Sep 2011) Changed paths: M master/buildbot/process/buildstep.py Log Message: ----------- Merge pull request #242 from tomprince/misc Fix passing of collectStdout from RemoteShellCommand to LoggedRemoteComma Compare: https://github.com/buildbot/buildbot/compare/49f6368...e96251b From nobody at buildbot.net Sun Sep 4 22:42:02 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 04 Sep 2011 22:42:02 -0000 Subject: [Buildbot-commits] [Buildbot] #1061: Buildbot locks downloaded files In-Reply-To: <039.3caf071a0bf60c4df27fb569d19d0709@buildbot.net> References: <039.3caf071a0bf60c4df27fb569d19d0709@buildbot.net> Message-ID: <054.684f846a7210f02c85a78857bca2f341@buildbot.net> #1061: Buildbot locks downloaded files ------------------------------+-------------------- Reporter: parshin | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.2 | Resolution: Keywords: windows, transfer | ------------------------------+-------------------- Comment (by parshin): I can reproduce this bug with buildbot 0.8.4p2 and twisted 11.0.0 on Windows. But can't reproduce it on Ubuntu 11.04, buildbot 0.8.5rc1, twisted 11.0.0 ... So, maybe it is windows-specific problem (twisted.spawnProcess() uses platform-specific code)... -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Sep 4 22:52:36 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 04 Sep 2011 22:52:36 -0000 Subject: [Buildbot-commits] [Buildbot] #1061: Buildbot locks downloaded files In-Reply-To: <039.3caf071a0bf60c4df27fb569d19d0709@buildbot.net> References: <039.3caf071a0bf60c4df27fb569d19d0709@buildbot.net> Message-ID: <054.a821ec68dfb3045d140628b60f87fefa@buildbot.net> #1061: Buildbot locks downloaded files ------------------------------+-------------------- Reporter: parshin | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.2 | Resolution: Keywords: windows, transfer | ------------------------------+-------------------- Comment (by dustin): Well, it's NTFS-specific, since NTFS does not allow the same file to be opened more than once. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sun Sep 4 23:35:58 2011 From: noreply at github.com (noreply at github.com) Date: Sun, 4 Sep 2011 16:35:58 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] d8c2d1: Finish removing schedulers.state column Message-ID: <20110904233558.E451F425FE@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: d8c2d1b1f5527c6d336b1c8278fee1eb34ff5529 https://github.com/buildbot/buildbot/commit/d8c2d1b1f5527c6d336b1c8278fee1eb34ff5529 Author: Dustin J. Mitchell Date: 2011-09-04 (Sun, 04 Sep 2011) Changed paths: M master/buildbot/db/schedulers.py M master/buildbot/schedulers/base.py M master/buildbot/test/fake/fakedb.py M master/buildbot/test/unit/test_schedulers_base.py M master/buildbot/test/unit/test_schedulers_timed_Nightly.py Log Message: ----------- Finish removing schedulers.state column The Nightly scheduler was still expecting scheduler state, and as such would fail without the column. This removes a bunch of now-dead code, and re-implements the BaseScheduler get/setState methods to use the master.db.state, along with updated tests. Fixes #2042. From nobody at buildbot.net Sun Sep 4 23:36:04 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 04 Sep 2011 23:36:04 -0000 Subject: [Buildbot-commits] [Buildbot] #2042: remove schedulers.state column In-Reply-To: <038.093465493dc77fd489f2a277fa8cc1a7@buildbot.net> References: <038.093465493dc77fd489f2a277fa8cc1a7@buildbot.net> Message-ID: <053.bfe3d3a6ef79c23e1b6198cb06198ab0@buildbot.net> #2042: remove schedulers.state column -----------------------------+--------------------- Reporter: dustin | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.5 Version: 0.8.4p2 | Resolution: fixed Keywords: database, simple | -----------------------------+--------------------- Changes (by Dustin J. Mitchell): * status: new => closed * resolution: => fixed Comment: Finish removing schedulers.state column The Nightly scheduler was still expecting scheduler state, and as such would fail without the column. This removes a bunch of now-dead code, and re-implements the BaseScheduler get/setState methods to use the master.db.state, along with updated tests. Fixes #2042. Changeset: d8c2d1b1f5527c6d336b1c8278fee1eb34ff5529 -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Mon Sep 5 04:19:55 2011 From: noreply at github.com (noreply at github.com) Date: Sun, 4 Sep 2011 21:19:55 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 6cd2ce: Handle errors in master-side source steps Message-ID: <20110905041955.DB2614261A@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 6cd2ceac5ff6fbb74fedb2855381051546b40f13 https://github.com/buildbot/buildbot/commit/6cd2ceac5ff6fbb74fedb2855381051546b40f13 Author: Dustin J. Mitchell Date: 2011-09-04 (Sun, 04 Sep 2011) Changed paths: M master/buildbot/process/buildstep.py M master/buildbot/steps/source/bzr.py M master/buildbot/steps/source/cvs.py M master/buildbot/steps/source/git.py M master/buildbot/steps/source/mercurial.py M master/buildbot/steps/source/svn.py M master/buildbot/test/unit/test_steps_source_bzr.py M master/buildbot/test/unit/test_steps_source_cvs.py M master/buildbot/test/unit/test_steps_source_git.py M master/buildbot/test/unit/test_steps_source_mercurial.py M master/buildbot/test/unit/test_steps_source_svn.py Log Message: ----------- Handle errors in master-side source steps This adds a BuildStepFailed exception that can be raised within anything that leads to step.failed; from there, it will be punted to step.finished(FAILURE). Fixes #2097. From nobody at buildbot.net Mon Sep 5 04:20:01 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 05 Sep 2011 04:20:01 -0000 Subject: [Buildbot-commits] [Buildbot] #2097: new Git step fails with exception rather than failure. In-Reply-To: <042.e31f5b2a7788606f293646763eed11a0@buildbot.net> References: <042.e31f5b2a7788606f293646763eed11a0@buildbot.net> Message-ID: <057.322fe90cc365756d6917158f7db78ce1@buildbot.net> #2097: new Git step fails with exception rather than failure. -----------------------+--------------------- Reporter: tom.prince | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.5 Version: master | Resolution: fixed Keywords: git | -----------------------+--------------------- Changes (by Dustin J. Mitchell): * status: new => closed * resolution: => fixed Comment: Handle errors in master-side source steps This adds a BuildStepFailed exception that can be raised within anything that leads to step.failed; from there, it will be punted to step.finished(FAILURE). Fixes #2097. Changeset: 6cd2ceac5ff6fbb74fedb2855381051546b40f13 -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Mon Sep 5 04:59:10 2011 From: noreply at github.com (noreply at github.com) Date: Sun, 4 Sep 2011 21:59:10 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 2a36eb: refactor Git.incremental into a deferredGenerator Message-ID: <20110905045910.EEE54423A0@smtp1.rs.github.com> Branch: refs/heads/buildbot-0.8.5 Home: https://github.com/buildbot/buildbot Commit: 2a36eb619d91d6bfec8d500cec36725d4c5f8f64 https://github.com/buildbot/buildbot/commit/2a36eb619d91d6bfec8d500cec36725d4c5f8f64 Author: Dustin J. Mitchell Date: 2011-09-04 (Sun, 04 Sep 2011) Changed paths: M master/buildbot/steps/source/git.py Log Message: ----------- refactor Git.incremental into a deferredGenerator Commit: 165849b8ca1f67241464575e347ba26b9b54a509 https://github.com/buildbot/buildbot/commit/165849b8ca1f67241464575e347ba26b9b54a509 Author: Tom Prince Date: 2011-09-04 (Sun, 04 Sep 2011) Changed paths: M master/buildbot/process/buildstep.py Log Message: ----------- Fix passing of collectStdout from RemoteShellCommand to LoggedRemoteCommand. Commit: cc11223d873b0c835b06e67cc7e21749a8cad763 https://github.com/buildbot/buildbot/commit/cc11223d873b0c835b06e67cc7e21749a8cad763 Author: Dustin J. Mitchell Date: 2011-09-04 (Sun, 04 Sep 2011) Changed paths: M master/buildbot/db/schedulers.py M master/buildbot/schedulers/base.py M master/buildbot/test/fake/fakedb.py M master/buildbot/test/unit/test_schedulers_base.py M master/buildbot/test/unit/test_schedulers_timed_Nightly.py Log Message: ----------- Finish removing schedulers.state column The Nightly scheduler was still expecting scheduler state, and as such would fail without the column. This removes a bunch of now-dead code, and re-implements the BaseScheduler get/setState methods to use the master.db.state, along with updated tests. Fixes #2042. Commit: a076b445b2e80ed7da3df4d3b7b9430f42a4a879 https://github.com/buildbot/buildbot/commit/a076b445b2e80ed7da3df4d3b7b9430f42a4a879 Author: Dustin J. Mitchell Date: 2011-09-04 (Sun, 04 Sep 2011) Changed paths: M master/buildbot/process/buildstep.py M master/buildbot/steps/source/bzr.py M master/buildbot/steps/source/cvs.py M master/buildbot/steps/source/git.py M master/buildbot/steps/source/mercurial.py M master/buildbot/steps/source/svn.py M master/buildbot/test/unit/test_steps_source_bzr.py M master/buildbot/test/unit/test_steps_source_cvs.py M master/buildbot/test/unit/test_steps_source_git.py M master/buildbot/test/unit/test_steps_source_mercurial.py M master/buildbot/test/unit/test_steps_source_svn.py Log Message: ----------- Handle errors in master-side source steps This adds a BuildStepFailed exception that can be raised within anything that leads to step.failed; from there, it will be punted to step.finished(FAILURE). Fixes #2097. Commit: e80ee685729b8cd68f4fd3dc85dffa592d48e2eb https://github.com/buildbot/buildbot/commit/e80ee685729b8cd68f4fd3dc85dffa592d48e2eb Author: Dustin J. Mitchell Date: 2011-09-04 (Sun, 04 Sep 2011) Changed paths: M master/buildbot/steps/source/svn.py Log Message: ----------- don't use try/finally in a generator on python-2.4 Compare: https://github.com/buildbot/buildbot/compare/6c51cd4...e80ee68 From noreply at github.com Mon Sep 5 04:59:10 2011 From: noreply at github.com (noreply at github.com) Date: Sun, 4 Sep 2011 21:59:10 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 3b925a: don't use try/finally in a generator on python-2.4 Message-ID: <20110905045910.E562842303@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 3b925afd18cc38798659a2729f8e90044bb903a9 https://github.com/buildbot/buildbot/commit/3b925afd18cc38798659a2729f8e90044bb903a9 Author: Dustin J. Mitchell Date: 2011-09-04 (Sun, 04 Sep 2011) Changed paths: M master/buildbot/steps/source/svn.py Log Message: ----------- don't use try/finally in a generator on python-2.4 From nobody at buildbot.net Mon Sep 5 04:59:34 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 05 Sep 2011 04:59:34 -0000 Subject: [Buildbot-commits] [Buildbot] #2042: remove schedulers.state column In-Reply-To: <038.093465493dc77fd489f2a277fa8cc1a7@buildbot.net> References: <038.093465493dc77fd489f2a277fa8cc1a7@buildbot.net> Message-ID: <053.75232426934229215a0c05025cfe4830@buildbot.net> #2042: remove schedulers.state column -----------------------------+--------------------- Reporter: dustin | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.5 Version: 0.8.4p2 | Resolution: fixed Keywords: database, simple | -----------------------------+--------------------- Comment (by Dustin J. Mitchell): Finish removing schedulers.state column The Nightly scheduler was still expecting scheduler state, and as such would fail without the column. This removes a bunch of now-dead code, and re-implements the BaseScheduler get/setState methods to use the master.db.state, along with updated tests. Fixes #2042. Changeset: cc11223d873b0c835b06e67cc7e21749a8cad763 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Sep 5 04:59:35 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 05 Sep 2011 04:59:35 -0000 Subject: [Buildbot-commits] [Buildbot] #2097: new Git step fails with exception rather than failure. In-Reply-To: <042.e31f5b2a7788606f293646763eed11a0@buildbot.net> References: <042.e31f5b2a7788606f293646763eed11a0@buildbot.net> Message-ID: <057.ccc9de5cd32c978363d5e3edf5afa80a@buildbot.net> #2097: new Git step fails with exception rather than failure. -----------------------+--------------------- Reporter: tom.prince | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.5 Version: master | Resolution: fixed Keywords: git | -----------------------+--------------------- Comment (by Dustin J. Mitchell): Handle errors in master-side source steps This adds a BuildStepFailed exception that can be raised within anything that leads to step.failed; from there, it will be punted to step.finished(FAILURE). Fixes #2097. Changeset: a076b445b2e80ed7da3df4d3b7b9430f42a4a879 -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Mon Sep 5 05:40:47 2011 From: noreply at github.com (noreply at github.com) Date: Sun, 4 Sep 2011 22:40:47 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 84aa24: factor development docs into subfiles Message-ID: <20110905054047.6BB51425C4@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 84aa24e9250e10ebe5dabc9f7478690d1a9ac421 https://github.com/buildbot/buildbot/commit/84aa24e9250e10ebe5dabc9f7478690d1a9ac421 Author: Dustin J. Mitchell Date: 2011-09-04 (Sun, 04 Sep 2011) Changed paths: A master/docs/developer/classes.rst A master/docs/developer/cls-buildfactory.rst A master/docs/developer/config.rst A master/docs/developer/database.rst A master/docs/developer/encodings.rst A master/docs/developer/formats.rst M master/docs/developer/index.rst A master/docs/developer/master-overview.rst A master/docs/developer/master-slave.rst A master/docs/developer/metrics.rst A master/docs/developer/style.rst A master/docs/developer/utils.rst A master/docs/developer/webstatus.rst Log Message: ----------- factor development docs into subfiles From nobody at buildbot.net Mon Sep 5 15:11:09 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 05 Sep 2011 15:11:09 -0000 Subject: [Buildbot-commits] [Buildbot] #2098: support for patches in master-side source steps Message-ID: <038.7bf88629819eaedd012609f66bc29db2@buildbot.net> #2098: support for patches in master-side source steps ------------------------+------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: critical | Milestone: 0.8.+ Version: 0.8.4p2 | Keywords: ------------------------+------------------- This support is not included in 0.8.5. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Mon Sep 5 15:14:54 2011 From: noreply at github.com (noreply at github.com) Date: Mon, 5 Sep 2011 08:14:54 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] ad072a: Pass un-mangled git commit message to the buildbot Message-ID: <20110905151454.95593424B4@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: ad072aa76ba2e4536f0d2c7715ff22286da1a2e0 https://github.com/buildbot/buildbot/commit/ad072aa76ba2e4536f0d2c7715ff22286da1a2e0 Author: Mikhail Gusarov Date: 2011-09-05 (Mon, 05 Sep 2011) Changed paths: M master/contrib/git_buildbot.py Log Message: ----------- Pass un-mangled git commit message to the buildbot Previously commit message was based on output of 'git rev-parse' which stripped out all "insignificant" whitespace, like newlines. Given grab_commit_info() already gets other kinds of commit information from 'git show', get the commit message from it as well, unaltered. Commit: 5eaa6f6036915ede1cd065930cc7e17167a9fb25 https://github.com/buildbot/buildbot/commit/5eaa6f6036915ede1cd065930cc7e17167a9fb25 Author: Dustin J. Mitchell Date: 2011-09-05 (Mon, 05 Sep 2011) Changed paths: M master/contrib/git_buildbot.py Log Message: ----------- Merge branch 'git-buildbot-fixes' of git://github.com/dottedmag/buildbot * 'git-buildbot-fixes' of git://github.com/dottedmag/buildbot: Pass un-mangled git commit message to the buildbot Compare: https://github.com/buildbot/buildbot/compare/84aa24e...5eaa6f6 From nobody at buildbot.net Mon Sep 5 18:26:00 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 05 Sep 2011 18:26:00 -0000 Subject: [Buildbot-commits] [Buildbot] #2099: Various web errors after extended uptime indicating missing files Message-ID: <047.d4c52f69d8ee3f6e185898e5cac7f41c@buildbot.net> #2099: Various web errors after extended uptime indicating missing files ----------------------------+----------------------- Reporter: MostAwesomeDude | Owner: Type: undecided | Status: new Priority: major | Milestone: undecided Version: 0.8.4p2 | Keywords: ----------------------------+----------------------- This one's just plain confusing, and I'll probably be updating it as I see more of it. For the past few days, I've been running on what appears to be the bleeding edge of BB: 0.8.4 and newer. The upgrade was part of a bigger pip upgrade to bump my virtualenv, so Jinja2 and SQLAlchemy were bumped at the same time, however, I believe that they are fine, since several Flask apps I have running do not have this problem. (I rely on this virtualenv pretty heavily, so I can't respin it. Sorry.) Anyway, the actual errors indicate things like the SQLA database being set to None, or the Jinja templates vanishing into thin air. A "buildbot restart master" suffices to get things rolling again, but I have yet to experience more than 12h of uptime, which is really cutting into my CI. :3 The Jinja2 exceptions look like: : root.html I don't have a SQLA exception at the moment, but when I get one, I'll put it in here. I'm marking this as 0.8.4p2, but it occurs with 0.8.4 through 0.8.5rc1. If it's important, this is with CPython 2.7, in a virtualenv, on recent Ubuntu. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Mon Sep 5 23:44:10 2011 From: noreply at github.com (noreply at github.com) Date: Mon, 5 Sep 2011 16:44:10 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 30122a: factor development docs into subfiles Message-ID: <20110905234410.AB308423EB@smtp1.rs.github.com> Branch: refs/heads/buildbot-0.8.5 Home: https://github.com/buildbot/buildbot Commit: 30122a95108bcf3ba40f91174b6a973ef536544a https://github.com/buildbot/buildbot/commit/30122a95108bcf3ba40f91174b6a973ef536544a Author: Dustin J. Mitchell Date: 2011-09-05 (Mon, 05 Sep 2011) Changed paths: A master/docs/developer/classes.rst A master/docs/developer/cls-buildfactory.rst A master/docs/developer/config.rst A master/docs/developer/database.rst A master/docs/developer/encodings.rst A master/docs/developer/formats.rst M master/docs/developer/index.rst A master/docs/developer/master-overview.rst A master/docs/developer/master-slave.rst A master/docs/developer/metrics.rst A master/docs/developer/style.rst A master/docs/developer/utils.rst A master/docs/developer/webstatus.rst Log Message: ----------- factor development docs into subfiles Commit: c05790aa192c8d425f7f9cae0e975ca2c8d146b5 https://github.com/buildbot/buildbot/commit/c05790aa192c8d425f7f9cae0e975ca2c8d146b5 Author: Mikhail Gusarov Date: 2011-09-05 (Mon, 05 Sep 2011) Changed paths: M master/contrib/git_buildbot.py Log Message: ----------- Pass un-mangled git commit message to the buildbot Previously commit message was based on output of 'git rev-parse' which stripped out all "insignificant" whitespace, like newlines. Given grab_commit_info() already gets other kinds of commit information from 'git show', get the commit message from it as well, unaltered. Commit: 08185fb93b0dc1f5cd2e1d8b5bf31b5ee96f075a https://github.com/buildbot/buildbot/commit/08185fb93b0dc1f5cd2e1d8b5bf31b5ee96f075a Author: Dustin J. Mitchell Date: 2011-09-05 (Mon, 05 Sep 2011) Changed paths: M master/buildbot/steps/vstudio.py M master/buildbot/test/fake/remotecommand.py M master/buildbot/test/unit/test_steps_vstudio.py M master/buildbot/test/util/steps.py M master/docs/manual/cfg-buildsteps.rst Log Message: ----------- tests for vstudio.py Compare: https://github.com/buildbot/buildbot/compare/e80ee68...08185fb From noreply at github.com Mon Sep 5 23:44:11 2011 From: noreply at github.com (noreply at github.com) Date: Mon, 5 Sep 2011 16:44:11 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 150bbb: tests for vstudio.py Message-ID: <20110905234411.40ADC4241B@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 150bbb9401da5c11a7669c2d1dfd6e0bfc4bd3e8 https://github.com/buildbot/buildbot/commit/150bbb9401da5c11a7669c2d1dfd6e0bfc4bd3e8 Author: Dustin J. Mitchell Date: 2011-09-05 (Mon, 05 Sep 2011) Changed paths: M master/buildbot/steps/vstudio.py M master/buildbot/test/fake/remotecommand.py M master/buildbot/test/unit/test_steps_vstudio.py M master/buildbot/test/util/steps.py M master/docs/manual/cfg-buildsteps.rst Log Message: ----------- tests for vstudio.py Commit: a3f75e70d494267cc2772bf101c3e0a1c3c3673b https://github.com/buildbot/buildbot/commit/a3f75e70d494267cc2772bf101c3e0a1c3c3673b Author: Dustin J. Mitchell Date: 2011-09-05 (Mon, 05 Sep 2011) Changed paths: M master/buildbot/steps/vstudio.py M master/buildbot/test/fake/remotecommand.py M master/buildbot/test/unit/test_steps_vstudio.py M master/buildbot/test/util/steps.py M master/docs/manual/cfg-buildsteps.rst Log Message: ----------- Merge remote-tracking branch 'lorentz/master' * lorentz/master: tests for vstudio.py Compare: https://github.com/buildbot/buildbot/compare/5eaa6f6...a3f75e7 From noreply at github.com Tue Sep 6 04:45:46 2011 From: noreply at github.com (noreply at github.com) Date: Mon, 5 Sep 2011 21:45:46 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 44e7fa: use 'vlatest' when VERSION=latest Message-ID: <20110906044546.6E51542572@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 44e7fad43b0f9c49bdf54ef086e1093bfcf41570 https://github.com/buildbot/buildbot/commit/44e7fad43b0f9c49bdf54ef086e1093bfcf41570 Author: Dustin J. Mitchell Date: 2011-09-05 (Mon, 05 Sep 2011) Changed paths: M master/docs/conf.py Log Message: ----------- use 'vlatest' when VERSION=latest Commit: 1305da198eb597b4c831d2f6a4d1e3acc4f472dc https://github.com/buildbot/buildbot/commit/1305da198eb597b4c831d2f6a4d1e3acc4f472dc Author: Dustin J. Mitchell Date: 2011-09-05 (Mon, 05 Sep 2011) Changed paths: M master/buildbot/db/buildrequests.py M master/buildbot/db/builds.py M master/buildbot/db/buildsets.py M master/buildbot/db/changes.py M master/buildbot/db/schedulers.py M master/buildbot/db/sourcestamps.py M master/buildbot/db/state.py M master/buildbot/db/users.py M master/docs/developer/database.rst M master/docs/developer/index.rst A master/docs/developer/results.rst M master/docs/manual/cfg-buildsteps.rst M master/docs/manual/cfg-global.rst Log Message: ----------- Move DB API documentation to Sphinx Compare: https://github.com/buildbot/buildbot/compare/a3f75e7...1305da1 From noreply at github.com Tue Sep 6 04:47:31 2011 From: noreply at github.com (noreply at github.com) Date: Mon, 5 Sep 2011 21:47:31 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] d35972: docs typos Message-ID: <20110906044732.00D104258F@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: d3597276a1735c63d85106ecb4514797338d396e https://github.com/buildbot/buildbot/commit/d3597276a1735c63d85106ecb4514797338d396e Author: Dustin J. Mitchell Date: 2011-09-05 (Mon, 05 Sep 2011) Changed paths: M master/docs/developer/database.rst Log Message: ----------- docs typos From nobody at buildbot.net Tue Sep 6 06:11:21 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 06 Sep 2011 06:11:21 -0000 Subject: [Buildbot-commits] [Buildbot] #2100: GoogleCodeAtomPoller fails with AttributeError when changes are detected Message-ID: <044.0d017672cc5bf9033e149e8770df0fa9@buildbot.net> #2100: GoogleCodeAtomPoller fails with AttributeError when changes are detected -------------------------+----------------------- Reporter: andialbrecht | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: master | Keywords: -------------------------+----------------------- GoogleCodeAtomPoller fails with an AttributeError when it detects changes. Here is the relevant part from my twistd.log with two events: The first is a successful poll without changes (08:00), the second event one minute later is a failing poll where the Atom feed had changes. {{{ 2011-09-06 08:00:42+0200 [-] Starting factory 2011-09-06 08:00:43+0200 [HTTPPageGetter,client] GoogleCodeAtomPoller poll success 2011-09-06 08:00:43+0200 [HTTPPageGetter,client] Stopping factory 2011-09-06 08:01:42+0200 [-] GoogleCodeAtomPoller polling http://code.google.com/feeds/p/python-sqlparse/hgchanges/basic 2011-09-06 08:01:42+0200 [-] Starting factory 2011-09-06 08:01:43+0200 [HTTPPageGetter,client] GoogleCodeAtomPoller poll failed: [Failure instance: Traceback: : ChangeManager instance has no attribute 'addChange' /home/build/.virtualenvs/buildbot/lib/python2.7/site- packages/twisted/web/client.py:182:handleResponse /home/build/.virtualenvs/buildbot/lib/python2.7/site- packages/twisted/web/client.py:347:page /home/build/.virtualenvs/buildbot/lib/python2.7/site- packages/twisted/internet/defer.py:361:callback /home/build/.virtualenvs/buildbot/lib/python2.7/site- packages/twisted/internet/defer.py:455:_startRunCallbacks --- --- /home/build/.virtualenvs/buildbot/lib/python2.7/site- packages/twisted/internet/defer.py:542:_runCallbacks /home/build/bots/sqlparse- master/googlecode_atom.py:181:_process_changes ] 2011-09-06 08:01:43+0200 [HTTPPageGetter,client] Stopping factory }}} The Atom poller is configured as {{{ #!python from googlecode_atom import GoogleCodeAtomPoller poller = GoogleCodeAtomPoller( feedurl="http://code.google.com/feeds/p/python- sqlparse/hgchanges/basic", pollinterval=60) c['change_source'] = [ poller ] }}} Buildbot is {{{ #!sh $ buildbot --version Buildbot version: 0.8.6-pre-21-gd359727 Twisted version: 11.0.0 }}} The error occurred after upgrading from Buildbot 0.8.2 to 0.8.5rc1, but is reproducible with current master. GoogleCodeAtomPoller is from master too. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Tue Sep 6 14:16:52 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 06 Sep 2011 14:16:52 -0000 Subject: [Buildbot-commits] [Buildbot] #2100: GoogleCodeAtomPoller fails with AttributeError when changes are detected In-Reply-To: <044.0d017672cc5bf9033e149e8770df0fa9@buildbot.net> References: <044.0d017672cc5bf9033e149e8770df0fa9@buildbot.net> Message-ID: <059.41861e3cf87686a872f163b7357a7d40@buildbot.net> #2100: GoogleCodeAtomPoller fails with AttributeError when changes are detected -------------------------+-------------------- Reporter: andialbrecht | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.5 Version: master | Resolution: Keywords: git | -------------------------+-------------------- Changes (by dustin): * keywords: => git * milestone: undecided => 0.8.5 -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Tue Sep 6 14:30:25 2011 From: noreply at github.com (noreply at github.com) Date: Tue, 6 Sep 2011 07:30:25 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] c31564: Move DB API documentation to Sphinx Message-ID: <20110906143025.6FABC42384@smtp1.rs.github.com> Branch: refs/heads/buildbot-0.8.5 Home: https://github.com/buildbot/buildbot Commit: c31564ce407df22e60fe0b09c3784f69bc3b5aa1 https://github.com/buildbot/buildbot/commit/c31564ce407df22e60fe0b09c3784f69bc3b5aa1 Author: Dustin J. Mitchell Date: 2011-09-05 (Mon, 05 Sep 2011) Changed paths: M master/buildbot/db/buildrequests.py M master/buildbot/db/builds.py M master/buildbot/db/buildsets.py M master/buildbot/db/changes.py M master/buildbot/db/schedulers.py M master/buildbot/db/sourcestamps.py M master/buildbot/db/state.py M master/buildbot/db/users.py M master/docs/developer/database.rst M master/docs/developer/index.rst A master/docs/developer/results.rst M master/docs/manual/cfg-buildsteps.rst M master/docs/manual/cfg-global.rst Log Message: ----------- Move DB API documentation to Sphinx Commit: 68d79b8dd55ee9ca8b2f7e8ef240caae407d9ae0 https://github.com/buildbot/buildbot/commit/68d79b8dd55ee9ca8b2f7e8ef240caae407d9ae0 Author: Dustin J. Mitchell Date: 2011-09-05 (Mon, 05 Sep 2011) Changed paths: M master/docs/developer/database.rst Log Message: ----------- docs typos Compare: https://github.com/buildbot/buildbot/compare/08185fb...68d79b8 From noreply at github.com Tue Sep 6 14:30:26 2011 From: noreply at github.com (noreply at github.com) Date: Tue, 6 Sep 2011 07:30:26 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 25ee14: add media top-level directory, full of stuff Message-ID: <20110906143026.295CD424F0@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 25ee140cddaa31c611406c606eb64f61ab6174ee https://github.com/buildbot/buildbot/commit/25ee140cddaa31c611406c606eb64f61ab6174ee Author: Dustin J. Mitchell Date: 2011-09-06 (Tue, 06 Sep 2011) Changed paths: R master/docs/hexnut32.png R master/docs/hexnut48.png R master/docs/hexnut64.png R master/docs/tutorial/conf.py A media/buildbot_large.tif A media/buildbot_nut_for_cutting.svg A media/header-text-transparent.png A media/hexnut32.png A media/hexnut48.png A media/hexnut64.png A media/icon.blend Log Message: ----------- add media top-level directory, full of stuff Commit: 6aa60ba2bad7ab226ab0a69aa70a09962762d3f0 https://github.com/buildbot/buildbot/commit/6aa60ba2bad7ab226ab0a69aa70a09962762d3f0 Author: Dustin J. Mitchell Date: 2011-09-06 (Tue, 06 Sep 2011) Changed paths: R master/docs/hexnut32.png R master/docs/hexnut48.png R master/docs/hexnut64.png R master/docs/tutorial/conf.py A media/buildbot_large.tif A media/buildbot_nut_for_cutting.svg A media/header-text-transparent.png A media/hexnut32.png A media/hexnut48.png A media/hexnut64.png A media/icon.blend Log Message: ----------- Merge remote-tracking branch 'lorentz/master' * lorentz/master: add media top-level directory, full of stuff Compare: https://github.com/buildbot/buildbot/compare/d359727...6aa60ba From nobody at buildbot.net Tue Sep 6 18:21:52 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 06 Sep 2011 18:21:52 -0000 Subject: [Buildbot-commits] [Buildbot] #2100: GoogleCodeAtomPoller fails with AttributeError when changes are detected In-Reply-To: <044.0d017672cc5bf9033e149e8770df0fa9@buildbot.net> References: <044.0d017672cc5bf9033e149e8770df0fa9@buildbot.net> Message-ID: <059.b86d74a96f75d272106473888fc4f300@buildbot.net> #2100: GoogleCodeAtomPoller fails with AttributeError when changes are detected -------------------------+-------------------- Reporter: andialbrecht | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.5 Version: master | Resolution: Keywords: | -------------------------+-------------------- Changes (by dustin): * keywords: git => -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Sep 7 05:44:30 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 07 Sep 2011 05:44:30 -0000 Subject: [Buildbot-commits] [Buildbot] #2101: .svg file in new-format documentation downloads as a file on chrome mac Message-ID: <037.ee5b06906c473529f72295a738e0a7c5@buildbot.net> #2101: .svg file in new-format documentation downloads as a file on chrome mac --------------------+---------------------- Reporter: ayust | Owner: djmitche Type: defect | Status: new Priority: blocker | Milestone: 0.8.5 Version: master | Keywords: --------------------+---------------------- Latest Chrome version as of Sept. 7th, 2011 - when loading the url http://buildbot.net/buildbot/docs/latest/full.html the `overview.svg` file which is supposed to be displayed in the System Architecture portion of the page instead shows up as a separate file download, and doesn't display on the page (though manually opening the file in another Chrome tab displays it as the correct image, so the file itself isn't corrupt). I'm not sure if this is an issue with the documentation itself, or an issue with Chrome, but I'm filing it here for now since this is the only place I've run into it. My guess is that Chrome may not like the way the image is being included, since it's using an `object` rather than `img` tag: {{{ }}} -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Sep 7 05:47:39 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 07 Sep 2011 05:47:39 -0000 Subject: [Buildbot-commits] [Buildbot] #2101: .svg file in new-format documentation downloads as a file on chrome mac In-Reply-To: <037.ee5b06906c473529f72295a738e0a7c5@buildbot.net> References: <037.ee5b06906c473529f72295a738e0a7c5@buildbot.net> Message-ID: <052.be4ae432d64fe06dbed21ea7c93b1429@buildbot.net> #2101: .svg file in new-format documentation downloads as a file on chrome mac --------------------+----------------------- Reporter: ayust | Owner: djmitche Type: defect | Status: new Priority: blocker | Milestone: 0.8.5 Version: master | Resolution: Keywords: | --------------------+----------------------- Comment (by dustin): This is a sphinx bug: https://bitbucket.org/birkenfeld/sphinx/issue/752/svg-images-are-linked- in-a-way-browsers I'll fix this by hand in the generated docs for 0.8.5, assuming that the sphinx folks don't merge the fix before then :) -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Sep 7 05:58:44 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 07 Sep 2011 05:58:44 -0000 Subject: [Buildbot-commits] [Buildbot] #2101: .svg file in new-format documentation downloads as a file on chrome mac In-Reply-To: <037.ee5b06906c473529f72295a738e0a7c5@buildbot.net> References: <037.ee5b06906c473529f72295a738e0a7c5@buildbot.net> Message-ID: <052.56f273b94f1cd06df653ee025eddbe4e@buildbot.net> #2101: .svg file in new-format documentation downloads as a file on chrome mac --------------------+----------------------- Reporter: ayust | Owner: djmitche Type: defect | Status: new Priority: blocker | Milestone: 0.8.5 Version: master | Resolution: Keywords: | --------------------+----------------------- Comment (by ayust): Actually, I think I found the real issue (for this particular case). `nginx` isn't providing the right `Content-Type` header for SVG files. For example, when you request the buildbot logo (which is a PNG), you get the following: {{{ $ curl --head http://trac.buildbot.net/chrome/site/header-text- transparent.png HTTP/1.1 200 Ok Server: nginx/0.8.54 Date: Wed, 07 Sep 2011 05:54:19 GMT Content-Type: image/png Connection: keep-alive Keep-Alive: timeout=45 Content-Length: 14301 Last-Modified: Thu, 09 Apr 2009 23:22:17 GMT }}} But, note the Content-Type header when requesting an SVG: {{{ $ curl --head http://buildbot.net/buildbot/docs/latest/_images/overview.svg HTTP/1.1 200 OK Server: nginx/0.8.54 Date: Wed, 07 Sep 2011 05:53:07 GMT Content-Type: application/octet-stream Content-Length: 119768 Last-Modified: Mon, 22 Aug 2011 02:39:20 GMT Connection: keep-alive Keep-Alive: timeout=45 Accept-Ranges: bytes }}} As it turns out, browsers treat `application/octet-stream` as a download (no big surprise). -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Sep 7 18:51:19 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 07 Sep 2011 18:51:19 -0000 Subject: [Buildbot-commits] [Buildbot] #2102: links from the build status page don't properly escape / Message-ID: <042.f4438daf332d3a0a0d640ebbc2e317c8@buildbot.net> #2102: links from the build status page don't properly escape / -----------------------+------------------- Reporter: tom.prince | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.5 Version: master | Keywords: web -----------------------+------------------- but ones from the waterfall do: http://buildbot.gemrb.org/builders/mingw32/builds/179 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Thu Sep 8 03:52:37 2011 From: nobody at buildbot.net (Buildbot) Date: Thu, 08 Sep 2011 03:52:37 -0000 Subject: [Buildbot-commits] [Buildbot] #2101: .svg file in new-format documentation downloads as a file on chrome mac In-Reply-To: <037.ee5b06906c473529f72295a738e0a7c5@buildbot.net> References: <037.ee5b06906c473529f72295a738e0a7c5@buildbot.net> Message-ID: <052.f6ea87f39d55c2ecff664de6d5948df8@buildbot.net> #2101: .svg file in new-format documentation downloads as a file on chrome mac --------------------+----------------------- Reporter: ayust | Owner: djmitche Type: defect | Status: new Priority: blocker | Milestone: 0.8.5 Version: master | Resolution: Keywords: | --------------------+----------------------- Comment (by dustin): Thanks - that fixed it. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Thu Sep 8 03:52:43 2011 From: nobody at buildbot.net (Buildbot) Date: Thu, 08 Sep 2011 03:52:43 -0000 Subject: [Buildbot-commits] [Buildbot] #2101: .svg file in new-format documentation downloads as a file on chrome mac In-Reply-To: <037.ee5b06906c473529f72295a738e0a7c5@buildbot.net> References: <037.ee5b06906c473529f72295a738e0a7c5@buildbot.net> Message-ID: <052.5e6c5588264557d7fa6fa0893d05e56a@buildbot.net> #2101: .svg file in new-format documentation downloads as a file on chrome mac --------------------+----------------------- Reporter: ayust | Owner: djmitche Type: defect | Status: closed Priority: blocker | Milestone: 0.8.5 Version: master | Resolution: fixed Keywords: | --------------------+----------------------- Changes (by dustin): * status: new => closed * resolution: => fixed -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Thu Sep 8 04:08:10 2011 From: noreply at github.com (noreply at github.com) Date: Wed, 7 Sep 2011 21:08:10 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] c2e8b1: rename db.users.addUser to db.users.findUserByAttr Message-ID: <20110908040810.7BFC742603@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: c2e8b11e5bc904dde1d074588c7d3a463ddbdcbf https://github.com/buildbot/buildbot/commit/c2e8b11e5bc904dde1d074588c7d3a463ddbdcbf Author: Dustin J. Mitchell Date: 2011-09-06 (Tue, 06 Sep 2011) Changed paths: M master/buildbot/db/users.py M master/buildbot/process/users/manual.py M master/buildbot/process/users/users.py M master/buildbot/status/client.py M master/buildbot/test/fake/fakedb.py M master/buildbot/test/unit/test_db_users.py M master/docs/developer/database.rst Log Message: ----------- rename db.users.addUser to db.users.findUserByAttr Commit: 1f015307fbe94bd7e6f6f435b0165695bfbc77d0 https://github.com/buildbot/buildbot/commit/1f015307fbe94bd7e6f6f435b0165695bfbc77d0 Author: Dustin J. Mitchell Date: 2011-09-07 (Wed, 07 Sep 2011) Changed paths: M master/buildbot/status/master.py M master/buildbot/status/web/build.py Log Message: ----------- properly quote '/' in step names, log names Fixes #2102. Compare: https://github.com/buildbot/buildbot/compare/6aa60ba...1f01530 From noreply at github.com Thu Sep 8 04:08:10 2011 From: noreply at github.com (noreply at github.com) Date: Wed, 7 Sep 2011 21:08:10 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] c02026: rename db.users.addUser to db.users.findUserByAttr Message-ID: <20110908040810.4D445425DA@smtp1.rs.github.com> Branch: refs/heads/buildbot-0.8.5 Home: https://github.com/buildbot/buildbot Commit: c0202674e7348c721943cf3dd4a05fe1c5c0a5c8 https://github.com/buildbot/buildbot/commit/c0202674e7348c721943cf3dd4a05fe1c5c0a5c8 Author: Dustin J. Mitchell Date: 2011-09-06 (Tue, 06 Sep 2011) Changed paths: M master/buildbot/db/users.py M master/buildbot/process/users/manual.py M master/buildbot/process/users/users.py M master/buildbot/status/client.py M master/buildbot/test/fake/fakedb.py M master/buildbot/test/unit/test_db_users.py M master/docs/developer/database.rst Log Message: ----------- rename db.users.addUser to db.users.findUserByAttr From nobody at buildbot.net Thu Sep 8 04:08:36 2011 From: nobody at buildbot.net (Buildbot) Date: Thu, 08 Sep 2011 04:08:36 -0000 Subject: [Buildbot-commits] [Buildbot] #2102: links from the build status page don't properly escape / In-Reply-To: <042.f4438daf332d3a0a0d640ebbc2e317c8@buildbot.net> References: <042.f4438daf332d3a0a0d640ebbc2e317c8@buildbot.net> Message-ID: <057.55b304f638a40e097c521eaef1743c3d@buildbot.net> #2102: links from the build status page don't properly escape / -----------------------+--------------------- Reporter: tom.prince | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.5 Version: master | Resolution: fixed Keywords: web | -----------------------+--------------------- Changes (by Dustin J. Mitchell): * status: new => closed * resolution: => fixed Comment: properly quote '/' in step names, log names Fixes #2102. Changeset: 1f015307fbe94bd7e6f6f435b0165695bfbc77d0 -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Thu Sep 8 04:14:14 2011 From: noreply at github.com (noreply at github.com) Date: Wed, 7 Sep 2011 21:14:14 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 4a61be: Merge branch 'master' of git://github.com/andialbr... Message-ID: <20110908041414.13C434247F@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 4a61bedfc13cab32247e8a59873af385bdde0d48 https://github.com/buildbot/buildbot/commit/4a61bedfc13cab32247e8a59873af385bdde0d48 Author: Dustin J. Mitchell Date: 2011-09-07 (Wed, 07 Sep 2011) Changed paths: M master/contrib/googlecode_atom.py Log Message: ----------- Merge branch 'master' of git://github.com/andialbrecht/buildbot * 'master' of git://github.com/andialbrecht/buildbot: Process deferred returned by addChange. Refactor GoogleAtomPoller to use keyword arguments when calling addChange (fixes #2100). From nobody at buildbot.net Thu Sep 8 04:14:20 2011 From: nobody at buildbot.net (Buildbot) Date: Thu, 08 Sep 2011 04:14:20 -0000 Subject: [Buildbot-commits] [Buildbot] #2100: GoogleCodeAtomPoller fails with AttributeError when changes are detected In-Reply-To: <044.0d017672cc5bf9033e149e8770df0fa9@buildbot.net> References: <044.0d017672cc5bf9033e149e8770df0fa9@buildbot.net> Message-ID: <059.c44e775f9d9765cb9dfa13d1a79c9870@buildbot.net> #2100: GoogleCodeAtomPoller fails with AttributeError when changes are detected -------------------------+--------------------- Reporter: andialbrecht | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.5 Version: master | Resolution: fixed Keywords: | -------------------------+--------------------- Changes (by Dustin J. Mitchell): * status: new => closed * resolution: => fixed Comment: Merge branch 'master' of git://github.com/andialbrecht/buildbot * 'master' of git://github.com/andialbrecht/buildbot: Process deferred returned by addChange. Refactor GoogleAtomPoller to use keyword arguments when calling addChange (fixes #2100). Changeset: 4a61bedfc13cab32247e8a59873af385bdde0d48 -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Thu Sep 8 04:39:45 2011 From: noreply at github.com (noreply at github.com) Date: Wed, 7 Sep 2011 21:39:45 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] f12992: properly quote '/' in step names, log names Message-ID: <20110908043945.1B3AE4252C@smtp1.rs.github.com> Branch: refs/heads/buildbot-0.8.5 Home: https://github.com/buildbot/buildbot Commit: f12992052b504a2a57d02ccd5fbf6bffed35e392 https://github.com/buildbot/buildbot/commit/f12992052b504a2a57d02ccd5fbf6bffed35e392 Author: Dustin J. Mitchell Date: 2011-09-07 (Wed, 07 Sep 2011) Changed paths: M master/buildbot/status/master.py M master/buildbot/status/web/build.py Log Message: ----------- properly quote '/' in step names, log names Fixes #2102. Commit: 6cfb95d5d93dbfa3c9b6c5c8770817d96fb2260b https://github.com/buildbot/buildbot/commit/6cfb95d5d93dbfa3c9b6c5c8770817d96fb2260b Author: Andi Albrecht Date: 2011-09-07 (Wed, 07 Sep 2011) Changed paths: M master/contrib/googlecode_atom.py Log Message: ----------- Refactor GoogleAtomPoller to use keyword arguments when calling addChange (fixes #2100). Commit: 7f04f1729d124cdcd6002e51daafe1d6389d4c35 https://github.com/buildbot/buildbot/commit/7f04f1729d124cdcd6002e51daafe1d6389d4c35 Author: Andi Albrecht Date: 2011-09-07 (Wed, 07 Sep 2011) Changed paths: M master/contrib/googlecode_atom.py Log Message: ----------- Process deferred returned by addChange. Commit: 56376f06c93bcd38533ec22c304e208bff153294 https://github.com/buildbot/buildbot/commit/56376f06c93bcd38533ec22c304e208bff153294 Author: Benoit Allard Date: 2011-09-07 (Wed, 07 Sep 2011) Changed paths: M master/buildbot/steps/python.py M master/buildbot/test/unit/test_steps_python.py M master/docs/manual/cfg-buildsteps.rst Log Message: ----------- Sphinx: add a mode parameter and fix the way log file were parsed Compare: https://github.com/buildbot/buildbot/compare/c020267...56376f0 From noreply at github.com Thu Sep 8 04:39:45 2011 From: noreply at github.com (noreply at github.com) Date: Wed, 7 Sep 2011 21:39:45 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 67565e: Sphinx: add a mode parameter and fix the way log f... Message-ID: <20110908043945.444A542548@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 67565e9ba09f26fcccb3c82dd81a918c939a7267 https://github.com/buildbot/buildbot/commit/67565e9ba09f26fcccb3c82dd81a918c939a7267 Author: Benoit Allard Date: 2011-09-07 (Wed, 07 Sep 2011) Changed paths: M master/buildbot/steps/python.py M master/buildbot/test/unit/test_steps_python.py M master/docs/manual/cfg-buildsteps.rst Log Message: ----------- Sphinx: add a mode parameter and fix the way log file were parsed From nobody at buildbot.net Thu Sep 8 04:39:51 2011 From: nobody at buildbot.net (Buildbot) Date: Thu, 08 Sep 2011 04:39:51 -0000 Subject: [Buildbot-commits] [Buildbot] #2102: links from the build status page don't properly escape / In-Reply-To: <042.f4438daf332d3a0a0d640ebbc2e317c8@buildbot.net> References: <042.f4438daf332d3a0a0d640ebbc2e317c8@buildbot.net> Message-ID: <057.54c06777c38e719d1cb142ea1e8bd0be@buildbot.net> #2102: links from the build status page don't properly escape / -----------------------+--------------------- Reporter: tom.prince | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.5 Version: master | Resolution: fixed Keywords: web | -----------------------+--------------------- Comment (by Dustin J. Mitchell): properly quote '/' in step names, log names Fixes #2102. Changeset: f12992052b504a2a57d02ccd5fbf6bffed35e392 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Thu Sep 8 04:39:51 2011 From: nobody at buildbot.net (Buildbot) Date: Thu, 08 Sep 2011 04:39:51 -0000 Subject: [Buildbot-commits] [Buildbot] #2100: GoogleCodeAtomPoller fails with AttributeError when changes are detected In-Reply-To: <044.0d017672cc5bf9033e149e8770df0fa9@buildbot.net> References: <044.0d017672cc5bf9033e149e8770df0fa9@buildbot.net> Message-ID: <059.9798fffbc48e2e36cf3eeb0b36518a37@buildbot.net> #2100: GoogleCodeAtomPoller fails with AttributeError when changes are detected -------------------------+--------------------- Reporter: andialbrecht | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.5 Version: master | Resolution: fixed Keywords: | -------------------------+--------------------- Comment (by Andi Albrecht): Refactor GoogleAtomPoller to use keyword arguments when calling addChange (fixes #2100). Changeset: 6cfb95d5d93dbfa3c9b6c5c8770817d96fb2260b -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Thu Sep 8 04:50:53 2011 From: nobody at buildbot.net (Buildbot) Date: Thu, 08 Sep 2011 04:50:53 -0000 Subject: [Buildbot-commits] [Buildbot] #2099: Various web errors after extended uptime indicating missing files In-Reply-To: <047.d4c52f69d8ee3f6e185898e5cac7f41c@buildbot.net> References: <047.d4c52f69d8ee3f6e185898e5cac7f41c@buildbot.net> Message-ID: <062.c0e2549e68bcef76fb56cc4c418c1fa3@buildbot.net> #2099: Various web errors after extended uptime indicating missing files ----------------------------+------------------------ Reporter: MostAwesomeDude | Owner: Type: undecided | Status: new Priority: major | Milestone: undecided Version: 0.8.4p2 | Resolution: Keywords: | ----------------------------+------------------------ Comment (by dustin): can you paste a traceback or two from twistd.log? -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Thu Sep 8 05:38:33 2011 From: noreply at github.com (noreply at github.com) Date: Wed, 7 Sep 2011 22:38:33 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 162460: Merge branch 'master' of git://github.com/sffjunki... Message-ID: <20110908053833.C4CD54264F@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 1624601705f2adf2d86ffb97e6034f58077077f9 https://github.com/buildbot/buildbot/commit/1624601705f2adf2d86ffb97e6034f58077077f9 Author: Dustin J. Mitchell Date: 2011-09-07 (Wed, 07 Sep 2011) Changed paths: M master/docs/Makefile Log Message: ----------- Merge branch 'master' of git://github.com/sffjunkie/buildbot * 'master' of git://github.com/sffjunkie/buildbot: Remove comment It is actually bsdtar which cannot handle the transform option not just OSX's version. Therefore change check to see if tar is bsdtar. tar on OSX does not have the --transform option but instead uses "-s s/search/replace" From noreply at github.com Thu Sep 8 05:38:33 2011 From: noreply at github.com (noreply at github.com) Date: Wed, 7 Sep 2011 22:38:33 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] f6f158: tar on OSX does not have the --transform option bu... Message-ID: <20110908053833.E838F42665@smtp1.rs.github.com> Branch: refs/heads/buildbot-0.8.5 Home: https://github.com/buildbot/buildbot Commit: f6f158ba513c3205b3f0220b5a647fbe1dd9a365 https://github.com/buildbot/buildbot/commit/f6f158ba513c3205b3f0220b5a647fbe1dd9a365 Author: Simon Kennedy Date: 2011-09-07 (Wed, 07 Sep 2011) Changed paths: M master/docs/Makefile Log Message: ----------- tar on OSX does not have the --transform option but instead uses "-s s/search/replace" Commit: 6a472030ccb9d2ac657c082650f978be8ceafe81 https://github.com/buildbot/buildbot/commit/6a472030ccb9d2ac657c082650f978be8ceafe81 Author: Simon Kennedy Date: 2011-09-07 (Wed, 07 Sep 2011) Changed paths: M master/docs/Makefile Log Message: ----------- It is actually bsdtar which cannot handle the transform option not just OSX's version. Therefore change check to see if tar is bsdtar. Commit: 800bcbfb6412c774db534e4d0a8960eed07e84fa https://github.com/buildbot/buildbot/commit/800bcbfb6412c774db534e4d0a8960eed07e84fa Author: Simon Kennedy Date: 2011-09-07 (Wed, 07 Sep 2011) Changed paths: M master/docs/Makefile Log Message: ----------- Remove comment Compare: https://github.com/buildbot/buildbot/compare/56376f0...800bcbf From nobody at buildbot.net Thu Sep 8 06:37:40 2011 From: nobody at buildbot.net (Buildbot) Date: Thu, 08 Sep 2011 06:37:40 -0000 Subject: [Buildbot-commits] [Buildbot] #2099: Various web errors after extended uptime indicating missing files In-Reply-To: <047.d4c52f69d8ee3f6e185898e5cac7f41c@buildbot.net> References: <047.d4c52f69d8ee3f6e185898e5cac7f41c@buildbot.net> Message-ID: <062.c2d75495f5580f4d2879d56fc8e4b50a@buildbot.net> #2099: Various web errors after extended uptime indicating missing files ----------------------------+------------------------ Reporter: MostAwesomeDude | Owner: Type: undecided | Status: new Priority: major | Milestone: undecided Version: 0.8.4p2 | Resolution: Keywords: | ----------------------------+------------------------ Comment (by MostAwesomeDude): Here's one about Jinja: 2011-09-06 15:23:17-0700 [HTTPChannel,7,75.73.181.4] Unhandled Error Traceback (most recent call last): File "/home/simpson/local/lib/python2.6/site- packages/buildbot/status/web/base.py", line 315, in render File "/home/simpson/local/lib/python2.6/site- packages/twisted/internet/defer.py", line 133, in maybeDeferred File "/home/simpson/local/lib/python2.6/site- packages/buildbot/status/web/base.py", line 315, in File "/home/simpson/local/lib/python2.6/site- packages/twisted/internet/defer.py", line 964, in unwindGenerator --- --- File "/home/simpson/local/lib/python2.6/site- packages/twisted/internet/defer.py", line 866, in _deferGenerator File "/home/simpson/local/lib/python2.6/site- packages/buildbot/status/web/root.py", line 56, in content File "/home/simpson/local/lib/python2.6/site- packages/jinja2/environment.py", line 719, in get_template File "/home/simpson/local/lib/python2.6/site- packages/jinja2/environment.py", line 693, in _load_template File "/home/simpson/local/lib/python2.6/site- packages/jinja2/loaders.py", line 115, in load File "/home/simpson/local/lib/python2.6/site- packages/jinja2/loaders.py", line 377, in get_source jinja2.exceptions.TemplateNotFound: root.html And here's another one from SQLA: 2011-09-05 15:41:53-0700 [-] Unhandled Error Traceback (most recent call last): File "/home/simpson/local/lib/python2.6/site- packages/twisted/internet/defer.py", line 388, in errback File "/home/simpson/local/lib/python2.6/site- packages/twisted/internet/defer.py", line 455, in _startRunCallbacks File "/home/simpson/local/lib/python2.6/site- packages/twisted/internet/defer.py", line 542, in _runCallbacks File "/home/simpson/local/lib/python2.6/site- packages/twisted/internet/defer.py", line 891, in gotResult --- --- File "/home/simpson/local/lib/python2.6/site- packages/twisted/internet/defer.py", line 866, in _deferGenerator File "/home/simpson/local/lib/python2.6/site- packages/buildbot/status/web/builder.py", line 245, in content File "/home/simpson/local/lib/python2.6/site- packages/twisted/internet/defer.py", line 845, in getResult File "/home/simpson/local/lib/python2.6/site- packages/twisted/python/threadpool.py", line 207, in _worker File "/home/simpson/local/lib/python2.6/site- packages/twisted/python/context.py", line 118, in callWithContext File "/home/simpson/local/lib/python2.6/site- packages/twisted/python/context.py", line 81, in callWithContext File "/home/simpson/local/lib/python2.6/site- packages/buildbot/db/pool.py", line 132, in thd File "/home/simpson/local/lib/python2.6/site- packages/sqlalchemy/engine/threadlocal.py", line 55, in contextual_connect File "/home/simpson/local/lib/python2.6/site- packages/sqlalchemy/pool.py", line 209, in connect File "/home/simpson/local/lib/python2.6/site- packages/sqlalchemy/pool.py", line 370, in __init__ File "/home/simpson/local/lib/python2.6/site- packages/sqlalchemy/pool.py", line 757, in _do_get File "/home/simpson/local/lib/python2.6/site- packages/sqlalchemy/pool.py", line 174, in _create_connection File "/home/simpson/local/lib/python2.6/site- packages/sqlalchemy/pool.py", line 255, in __init__ File "/home/simpson/local/lib/python2.6/site- packages/sqlalchemy/pool.py", line 315, in __connect File "/home/simpson/local/lib/python2.6/site- packages/sqlalchemy/engine/strategies.py", line 80, in connect File "/home/simpson/local/lib/python2.6/site- packages/sqlalchemy/engine/default.py", line 275, in connect sqlalchemy.exc.OperationalError: (OperationalError) unable to open database file None None Sorry these are so bare; this is just how they were in the log. I haven't been able to reproduce this since I opened the bug, which is kind of annoying. I haven't observed any other behavior which might point in a direction. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Thu Sep 8 22:14:32 2011 From: noreply at github.com (noreply at github.com) Date: Thu, 8 Sep 2011 15:14:32 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] ede5f3: revert overzealous s/addUser/findUserByAttr/g Message-ID: <20110908221432.6849242663@smtp1.rs.github.com> Branch: refs/heads/buildbot-0.8.5 Home: https://github.com/buildbot/buildbot Commit: ede5f3c08afbc43de3d4ffc2f7890cb3471494de https://github.com/buildbot/buildbot/commit/ede5f3c08afbc43de3d4ffc2f7890cb3471494de Author: Dustin J. Mitchell Date: 2011-09-08 (Thu, 08 Sep 2011) Changed paths: M master/buildbot/status/client.py Log Message: ----------- revert overzealous s/addUser/findUserByAttr/g From noreply at github.com Thu Sep 8 22:14:32 2011 From: noreply at github.com (noreply at github.com) Date: Thu, 8 Sep 2011 15:14:32 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 616b6c: revert overzealous s/addUser/findUserByAttr/g Message-ID: <20110908221432.71C704266C@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 616b6cf81cf58efb28d2eedea348b092c4695d9b https://github.com/buildbot/buildbot/commit/616b6cf81cf58efb28d2eedea348b092c4695d9b Author: Dustin J. Mitchell Date: 2011-09-08 (Thu, 08 Sep 2011) Changed paths: M master/buildbot/status/client.py Log Message: ----------- revert overzealous s/addUser/findUserByAttr/g From nobody at buildbot.net Fri Sep 9 02:31:18 2011 From: nobody at buildbot.net (Buildbot) Date: Fri, 09 Sep 2011 02:31:18 -0000 Subject: [Buildbot-commits] [Buildbot] #2103: merge schedulers table into objects table Message-ID: <038.b37253e89f25a5bf222cf1440f88a6a4@buildbot.net> #2103: merge schedulers table into objects table ------------------------+---------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.4p2 | Keywords: database ------------------------+---------------------- Currently, the schedulers table exists only to map (name,class) to schedulerid. This is exactly the same function as the objects table, except that the latter is more general. It would be great to get rid of the schedulers table altogether and use the objects table exclusively. This would require mapping schedulerids into new objectids, adding an objectid column to scheduler_changes and scheduler_upstream_buildsets, setting it appropriately, and then dropping the schedulerid-related stuff. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Sep 9 02:36:35 2011 From: nobody at buildbot.net (Buildbot) Date: Fri, 09 Sep 2011 02:36:35 -0000 Subject: [Buildbot-commits] [Buildbot] #2104: Get rid of buildbot.db.exceptions Message-ID: <038.a32f1401f55659de13514f87663610b8@buildbot.net> #2104: Get rid of buildbot.db.exceptions ------------------------+------------------------------ Reporter: dustin | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.4p2 | Keywords: database, simple ------------------------+------------------------------ !DBAlreadyExistsError isn't used, and !DatabaseNotReadyError is only raised in the master, where it could probably better be handled with some logging. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Fri Sep 9 04:12:34 2011 From: noreply at github.com (noreply at github.com) Date: Thu, 8 Sep 2011 21:12:34 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] bde780: document model.py in developer/database.rst, and m... Message-ID: <20110909041234.870BE42484@smtp1.rs.github.com> Branch: refs/heads/buildbot-0.8.5 Home: https://github.com/buildbot/buildbot Commit: bde7801e2afb196331d2f3444c47853484a290bf https://github.com/buildbot/buildbot/commit/bde7801e2afb196331d2f3444c47853484a290bf Author: Dustin J. Mitchell Date: 2011-09-08 (Thu, 08 Sep 2011) Changed paths: M master/buildbot/db/model.py M master/docs/conf.py M master/docs/developer/database.rst Log Message: ----------- document model.py in developer/database.rst, and move docstrings to comments Commit: 4405bd3c83ac4c085cfbcc766f6fe48ee61d8740 https://github.com/buildbot/buildbot/commit/4405bd3c83ac4c085cfbcc766f6fe48ee61d8740 Author: Dustin J. Mitchell Date: 2011-09-08 (Thu, 08 Sep 2011) Changed paths: M master/buildbot/db/pool.py M master/docs/developer/database.rst Log Message: ----------- document buildbot.db.pool Commit: ae6854fbc7da41b0319722d18de0350c50436ab0 https://github.com/buildbot/buildbot/commit/ae6854fbc7da41b0319722d18de0350c50436ab0 Author: Dustin J. Mitchell Date: 2011-09-08 (Thu, 08 Sep 2011) Changed paths: M master/buildbot/db/base.py M master/buildbot/db/connector.py M master/buildbot/db/enginestrategy.py M master/docs/developer/database.rst Log Message: ----------- document connectors and caching Commit: f0ffbcaf961fdbaaa35e24595da835b21a84ad75 https://github.com/buildbot/buildbot/commit/f0ffbcaf961fdbaaa35e24595da835b21a84ad75 Author: Dustin J. Mitchell Date: 2011-09-08 (Thu, 08 Sep 2011) Changed paths: M master/buildbot/db/schedulers.py M master/buildbot/db/sourcestamps.py Log Message: ----------- remove unnecessary docstrings Commit: eae79d5338865e148af1015a6579e5e98ca9e17f https://github.com/buildbot/buildbot/commit/eae79d5338865e148af1015a6579e5e98ca9e17f Author: Dustin J. Mitchell Date: 2011-09-08 (Thu, 08 Sep 2011) Changed paths: M master/docs/developer/database.rst Log Message: ----------- database compatibility notes Commit: 510240d6c92b372825d19b34ce027a221ac35a3e https://github.com/buildbot/buildbot/commit/510240d6c92b372825d19b34ce027a221ac35a3e Author: Dustin J. Mitchell Date: 2011-09-08 (Thu, 08 Sep 2011) Changed paths: M master/docs/developer/database.rst Log Message: ----------- add instructions for modifying the schema Compare: https://github.com/buildbot/buildbot/compare/ede5f3c...510240d From noreply at github.com Fri Sep 9 04:12:35 2011 From: noreply at github.com (noreply at github.com) Date: Thu, 8 Sep 2011 21:12:35 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 6f8f34: document model.py in developer/database.rst, and m... Message-ID: <20110909041235.40B254276E@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 6f8f341478ec7710d8949f2b11264fe04aca7f13 https://github.com/buildbot/buildbot/commit/6f8f341478ec7710d8949f2b11264fe04aca7f13 Author: Dustin J. Mitchell Date: 2011-09-08 (Thu, 08 Sep 2011) Changed paths: M master/buildbot/db/model.py M master/docs/conf.py M master/docs/developer/database.rst Log Message: ----------- document model.py in developer/database.rst, and move docstrings to comments Commit: 7d31a0593e2e207289511c10f68a8bc4ba13b759 https://github.com/buildbot/buildbot/commit/7d31a0593e2e207289511c10f68a8bc4ba13b759 Author: Dustin J. Mitchell Date: 2011-09-08 (Thu, 08 Sep 2011) Changed paths: M master/buildbot/db/pool.py M master/docs/developer/database.rst Log Message: ----------- document buildbot.db.pool Commit: 5e910c7757629936f167ba1cffca7116092f48e4 https://github.com/buildbot/buildbot/commit/5e910c7757629936f167ba1cffca7116092f48e4 Author: Dustin J. Mitchell Date: 2011-09-08 (Thu, 08 Sep 2011) Changed paths: M master/buildbot/db/base.py M master/buildbot/db/connector.py M master/buildbot/db/enginestrategy.py M master/docs/developer/database.rst Log Message: ----------- document connectors and caching Commit: 7ce0a125f690cd9f3693e38e3d0b16f51c284308 https://github.com/buildbot/buildbot/commit/7ce0a125f690cd9f3693e38e3d0b16f51c284308 Author: Dustin J. Mitchell Date: 2011-09-08 (Thu, 08 Sep 2011) Changed paths: M master/buildbot/db/schedulers.py M master/buildbot/db/sourcestamps.py Log Message: ----------- remove unnecessary docstrings Commit: e9590e7c7ca4e0c7e516c32d8329655236b155f1 https://github.com/buildbot/buildbot/commit/e9590e7c7ca4e0c7e516c32d8329655236b155f1 Author: Dustin J. Mitchell Date: 2011-09-08 (Thu, 08 Sep 2011) Changed paths: M master/docs/developer/database.rst Log Message: ----------- database compatibility notes Commit: f114ec108e629e9ee9f4f6462ebf35c9636b2b79 https://github.com/buildbot/buildbot/commit/f114ec108e629e9ee9f4f6462ebf35c9636b2b79 Author: Dustin J. Mitchell Date: 2011-09-08 (Thu, 08 Sep 2011) Changed paths: M master/docs/developer/database.rst Log Message: ----------- add instructions for modifying the schema Compare: https://github.com/buildbot/buildbot/compare/616b6cf...f114ec1 From noreply at github.com Fri Sep 9 04:18:30 2011 From: noreply at github.com (noreply at github.com) Date: Thu, 8 Sep 2011 21:18:30 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] a701ee: ok, ok, the db is not *the* storage backend Message-ID: <20110909041830.DB6E34277A@smtp1.rs.github.com> Branch: refs/heads/buildbot-0.8.5 Home: https://github.com/buildbot/buildbot Commit: a701ee971a74b8b119d8d17b2bf6342374dcda72 https://github.com/buildbot/buildbot/commit/a701ee971a74b8b119d8d17b2bf6342374dcda72 Author: Dustin J. Mitchell Date: 2011-09-08 (Thu, 08 Sep 2011) Changed paths: M master/docs/developer/database.rst Log Message: ----------- ok, ok, the db is not *the* storage backend From noreply at github.com Fri Sep 9 04:18:31 2011 From: noreply at github.com (noreply at github.com) Date: Thu, 8 Sep 2011 21:18:31 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 7d87c1: ok, ok, the db is not *the* storage backend Message-ID: <20110909041831.16DB84277C@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 7d87c16de174537d694a8f1f9d4136d7d8b898c7 https://github.com/buildbot/buildbot/commit/7d87c16de174537d694a8f1f9d4136d7d8b898c7 Author: Dustin J. Mitchell Date: 2011-09-08 (Thu, 08 Sep 2011) Changed paths: M master/docs/developer/database.rst Log Message: ----------- ok, ok, the db is not *the* storage backend From noreply at github.com Sun Sep 11 21:02:30 2011 From: noreply at github.com (noreply at github.com) Date: Sun, 11 Sep 2011 14:02:30 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 1743fc: remove unused testing classes Message-ID: <20110911210230.3CDBC425F2@smtp1.rs.github.com> Branch: refs/heads/buildbot-0.8.5 Home: https://github.com/buildbot/buildbot Commit: 1743fcf73f68256fb451ae5b6067b732d0bc048f https://github.com/buildbot/buildbot/commit/1743fcf73f68256fb451ae5b6067b732d0bc048f Author: Dustin J. Mitchell Date: 2011-09-11 (Sun, 11 Sep 2011) Changed paths: R master/buildbot/steps/dummy.py M master/buildbot/test/test_extra_coverage.py Log Message: ----------- remove unused testing classes Commit: d604114a8a79c1353755c921de24cf3da8d2090a https://github.com/buildbot/buildbot/commit/d604114a8a79c1353755c921de24cf3da8d2090a Author: Dustin J. Mitchell Date: 2011-09-11 (Sun, 11 Sep 2011) Changed paths: A master/buildbot/test/unit/test_steps_master.py Log Message: ----------- tests for master steps Commit: c586138b72f814ff355e9bdaf9d48034a51533d6 https://github.com/buildbot/buildbot/commit/c586138b72f814ff355e9bdaf9d48034a51533d6 Author: Dustin J. Mitchell Date: 2011-09-11 (Sun, 11 Sep 2011) Changed paths: M master/buildbot/steps/maxq.py A master/buildbot/test/unit/test_steps_maxq.py M master/docs/manual/cfg-buildsteps.rst Log Message: ----------- tests and docs for MaxQ Commit: 54f9c4ab53f24b739541c9ff397d97b668040aa0 https://github.com/buildbot/buildbot/commit/54f9c4ab53f24b739541c9ff397d97b668040aa0 Author: Dustin J. Mitchell Date: 2011-09-11 (Sun, 11 Sep 2011) Changed paths: M master/buildbot/process/buildstep.py M master/buildbot/steps/slave.py M master/buildbot/test/fake/remotecommand.py M master/buildbot/test/unit/test_steps_shell.py M master/buildbot/test/unit/test_steps_slave.py M master/buildbot/test/util/steps.py M master/docs/developer/master-slave.rst M master/docs/manual/cfg-buildsteps.rst Log Message: ----------- test and document slave steps Commit: 8a40be47b6c499a41ea12b37d216806ef593130f https://github.com/buildbot/buildbot/commit/8a40be47b6c499a41ea12b37d216806ef593130f Author: Dustin J. Mitchell Date: 2011-09-11 (Sun, 11 Sep 2011) Changed paths: M master/buildbot/steps/subunit.py A master/buildbot/test/unit/test_steps_subunit.py Log Message: ----------- some, but not enough, tests for subunit Compare: https://github.com/buildbot/buildbot/compare/a701ee9...8a40be4 From noreply at github.com Sun Sep 11 21:02:30 2011 From: noreply at github.com (noreply at github.com) Date: Sun, 11 Sep 2011 14:02:30 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 17b247: remove unused testing classes Message-ID: <20110911210230.67EB24260C@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 17b2477f4f3fc2322c16fea7919b195df36d227d https://github.com/buildbot/buildbot/commit/17b2477f4f3fc2322c16fea7919b195df36d227d Author: Dustin J. Mitchell Date: 2011-09-11 (Sun, 11 Sep 2011) Changed paths: R master/buildbot/steps/dummy.py M master/buildbot/test/test_extra_coverage.py Log Message: ----------- remove unused testing classes Commit: 7439b2c7e2844a417399cc0b2090634ccca93b33 https://github.com/buildbot/buildbot/commit/7439b2c7e2844a417399cc0b2090634ccca93b33 Author: Dustin J. Mitchell Date: 2011-09-11 (Sun, 11 Sep 2011) Changed paths: A master/buildbot/test/unit/test_steps_master.py Log Message: ----------- tests for master steps Commit: f03ff09330c8219fa45949ab01b2779d0501e398 https://github.com/buildbot/buildbot/commit/f03ff09330c8219fa45949ab01b2779d0501e398 Author: Dustin J. Mitchell Date: 2011-09-11 (Sun, 11 Sep 2011) Changed paths: M master/buildbot/steps/maxq.py A master/buildbot/test/unit/test_steps_maxq.py M master/docs/manual/cfg-buildsteps.rst Log Message: ----------- tests and docs for MaxQ Commit: 0f8f0a77a91a3d28aaa2569efda65376146b80b4 https://github.com/buildbot/buildbot/commit/0f8f0a77a91a3d28aaa2569efda65376146b80b4 Author: Dustin J. Mitchell Date: 2011-09-11 (Sun, 11 Sep 2011) Changed paths: M master/buildbot/process/buildstep.py M master/buildbot/steps/slave.py M master/buildbot/test/fake/remotecommand.py M master/buildbot/test/unit/test_steps_shell.py M master/buildbot/test/unit/test_steps_slave.py M master/buildbot/test/util/steps.py M master/docs/developer/master-slave.rst M master/docs/manual/cfg-buildsteps.rst Log Message: ----------- test and document slave steps Commit: 4d555075b1bd5cbb6929aaf5906cb862c288ed5b https://github.com/buildbot/buildbot/commit/4d555075b1bd5cbb6929aaf5906cb862c288ed5b Author: Dustin J. Mitchell Date: 2011-09-11 (Sun, 11 Sep 2011) Changed paths: M master/buildbot/steps/subunit.py A master/buildbot/test/unit/test_steps_subunit.py Log Message: ----------- some, but not enough, tests for subunit Compare: https://github.com/buildbot/buildbot/compare/7d87c16...4d55507 From noreply at github.com Sun Sep 11 21:22:02 2011 From: noreply at github.com (noreply at github.com) Date: Sun, 11 Sep 2011 14:22:02 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 9fcbfa: fix MasterShellCommand tests for windows Message-ID: <20110911212202.3EC8F425DD@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 9fcbfa3b555199aee978a5c4d9b992da915ffe37 https://github.com/buildbot/buildbot/commit/9fcbfa3b555199aee978a5c4d9b992da915ffe37 Author: Dustin J. Mitchell Date: 2011-09-11 (Sun, 11 Sep 2011) Changed paths: M master/buildbot/test/unit/test_steps_master.py Log Message: ----------- fix MasterShellCommand tests for windows From noreply at github.com Mon Sep 12 07:06:07 2011 From: noreply at github.com (noreply at github.com) Date: Mon, 12 Sep 2011 00:06:07 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 822fa5: add tests for the Trigger step Message-ID: <20110912070607.65188425C3@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 822fa5b81a7791274feaf8ff33cbfb0055adb2b5 https://github.com/buildbot/buildbot/commit/822fa5b81a7791274feaf8ff33cbfb0055adb2b5 Author: Dustin J. Mitchell Date: 2011-09-11 (Sun, 11 Sep 2011) Changed paths: M master/buildbot/steps/trigger.py M master/buildbot/test/fake/fakebuild.py A master/buildbot/test/unit/test_steps_trigger.py M master/docs/manual/cfg-buildsteps.rst Log Message: ----------- add tests for the Trigger step From nobody at buildbot.net Tue Sep 13 11:24:32 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 13 Sep 2011 11:24:32 -0000 Subject: [Buildbot-commits] [Buildbot] #2105: Mercurial hook - exceptions.ValueError: signal only works in main thread Message-ID: <039.ae0e754847623a7d7fd8839cdfcb6097@buildbot.net> #2105: Mercurial hook - exceptions.ValueError: signal only works in main thread ----------------------+----------------------- Reporter: jpichon | Owner: Type: undecided | Status: new Priority: major | Milestone: undecided Version: 0.8.4p2 | Keywords: ----------------------+----------------------- I'm having a problem with using Mercurial and buildbot together. This looks similar to the problem described in #397 (which I found searching for my error thanks to http://ur1.ca/52q6p), unfortunately applying the suggested change in changes/buildbot.py didn't solve it for me. I've set up buildbot on a few other machines with Mercurial and a very similar config file just fine, the only major difference I can think of is that this is the first time master and the repositories are on a different machine. Master is set up to listen to Mercurial via PBChangeSource, the hook is like this: {{{ [hooks] changegroup.buildbot = python:buildbot.changes.hgbuildbot.hook [hgbuildbot] master = buildbot:9989 }}} When I push for the first time to the repository, I get the following traceback. The repo is set up to work with HTTP. The changeset does go through to the buildbot master. For this traceback's purpose, I'm pushing with the --debug -v flags, and I also changed hook() in changes/buildbot.py to wrap the function into a try/catch. {{{ 1 changesets found list of changesets: a7cbcacb6a1034ab436fac506e1fb9e78f3dd56b bundling: 1/1 changesets (100.00%) bundling: 1/1 manifests (100.00%) bundling: thirdfile 1/1 files (100.00%) sending unbundle command sending 298 bytes sending: 0 kb sending: 0 kb remote: adding changesets remote: adding manifests remote: adding file changes remote: added 1 changesets with 1 changes to 1 files remote: /usr/lib/python2.6/dist-packages/zope/__init__.py:3: UserWarning: Module twisted was already imported from /usr/lib/python2.6/dist- packages/twisted/__init__.pyc, but /usr/local/lib/python2.6/dist-packages is being added to sys.path remote: import pkg_resources remote: Traceback (most recent call last): remote: File "/usr/lib/python2.6/dist- packages/twisted/internet/base.py", line 396, in fireEvent remote: DeferredList(beforeResults).addCallback(self._continueFiring) remote: File "/usr/lib/python2.6/dist- packages/twisted/internet/defer.py", line 224, in addCallback remote: callbackKeywords=kw) remote: File "/usr/lib/python2.6/dist- packages/twisted/internet/defer.py", line 213, in addCallbacks remote: self._runCallbacks() remote: File "/usr/lib/python2.6/dist- packages/twisted/internet/defer.py", line 371, in _runCallbacks remote: self.result = callback(self.result, *args, **kw) remote: --- --- remote: File "/usr/lib/python2.6/dist- packages/twisted/internet/base.py", line 409, in _continueFiring remote: callable(*args, **kwargs) remote: File "/usr/lib/python2.6/dist- packages/twisted/internet/base.py", line 1165, in _reallyStartRunning remote: self._handleSignals() remote: File "/usr/lib/python2.6/dist- packages/twisted/internet/base.py", line 1105, in _handleSignals remote: signal.signal(signal.SIGINT, self.sigInt) remote: exceptions.ValueError: signal only works in main thread remote: rev a7cbcacb6a1034ab436fac506e1fb9e78f3dd56b sent checking for updated bookmarks sending listkeys command }}} The 2nd changeset I push will hang, with no error message. {{{ 1 changesets found list of changesets: 04b9ca66ef8238f2265bcd798106b673df2648aa bundling: 1/1 changesets (100.00%) bundling: 1/1 manifests (100.00%) bundling: thirdfile 1/1 files (100.00%) sending unbundle command sending 301 bytes sending: 0 kb sending: 0 kb }}} I have to kill it. It still goes through to the buildbot master, though. From then on I will always get the following exception, even though the changes do get through to Master. {{{ 1 changesets found list of changesets: 3eb90d2ce2e2b1d472ff8164801a04a386b11d53 bundling: 1/1 changesets (100.00%) bundling: 1/1 manifests (100.00%) bundling: thirdfile 1/1 files (100.00%) sending unbundle command sending 298 bytes sending: 0 kb sending: 0 kb remote: adding changesets remote: adding manifests remote: adding file changes remote: added 1 changesets with 1 changes to 1 files remote: Traceback (most recent call last): remote: File "/usr/local/lib/python2.6/dist- packages/buildbot/changes/hgbuildbot.py", line 178, in hook remote: reactor.run() remote: File "/usr/lib/python2.6/dist- packages/twisted/internet/base.py", line 1169, in run remote: self.startRunning(installSignalHandlers=installSignalHandlers) remote: File "/usr/lib/python2.6/dist- packages/twisted/internet/base.py", line 1149, in startRunning remote: ReactorBase.startRunning(self) remote: File "/usr/lib/python2.6/dist- packages/twisted/internet/base.py", line 652, in startRunning remote: raise error.ReactorAlreadyRunning() remote: ReactorAlreadyRunning checking for updated bookmarks sending listkeys command }}} The only way to stop it is to restart Mercurial, and it's back to Traceback #1 above. Before I wrapped hook() in a try/catch statement, the output of that last traceback was only this: {{{ 1 changesets found remote: adding changesets remote: adding manifests remote: adding file changes remote: added 1 changesets with 1 changes to 1 files remote: error: changegroup.buildbot hook raised an exception: }}} The master's logs don't seem to provide information relevant to this. In #397 a more specific traceback is requested, if this one isn't enough let me know where I can get what's needed. Thanks! -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Tue Sep 13 14:32:39 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 13 Sep 2011 14:32:39 -0000 Subject: [Buildbot-commits] [Buildbot] #2106: Buildbot requires pycrypto to setup even an unencrypted manhole Message-ID: <042.b881d87fc9ffff62fed02b40b1d6272b@buildbot.net> #2106: Buildbot requires pycrypto to setup even an unencrypted manhole -----------------------+----------------------- Reporter: jollyroger | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.4p2 | Keywords: -----------------------+----------------------- Reported on IRC, appeared for windows. Not tested on other platforms. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Tue Sep 13 15:12:24 2011 From: noreply at github.com (noreply at github.com) Date: Tue, 13 Sep 2011 08:12:24 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] acbb24: overhaul the master-slave docs Message-ID: <20110913151224.5BBC34261E@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: acbb243b7f6d32ce197f7e684036dacef5ca6e8f https://github.com/buildbot/buildbot/commit/acbb243b7f6d32ce197f7e684036dacef5ca6e8f Author: Dustin J. Mitchell Date: 2011-09-13 (Tue, 13 Sep 2011) Changed paths: M master/buildbot/steps/transfer.py M master/docs/developer/master-slave.rst M slave/buildslave/commands/fs.py M slave/buildslave/commands/shell.py M slave/buildslave/commands/transfer.py Log Message: ----------- overhaul the master-slave docs From nobody at buildbot.net Tue Sep 13 20:38:33 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 13 Sep 2011 20:38:33 -0000 Subject: [Buildbot-commits] [Buildbot] #2107: The Test BuildStep would be more useful with a failurePattern argument Message-ID: <041.1dc009a8017f923531af3cb579c24652@buildbot.net> #2107: The Test BuildStep would be more useful with a failurePattern argument ------------------------+---------------------------- Reporter: ulfalizer | Owner: Type: enhancement | Status: new Priority: major | Milestone: undecided Version: 0.8.4p2 | Keywords: BuildStep Test ------------------------+---------------------------- When running tests through "make" you usually can't determine success or failure by looking at the exit status. The Test BuildStep would be more useful if it had a failurePattern argument for recognizing failed tests in the output of the command. This would also let it present a summary of failed tests. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Tue Sep 13 20:42:47 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 13 Sep 2011 20:42:47 -0000 Subject: [Buildbot-commits] [Buildbot] #2107: The Test BuildStep would be more useful with a failurePattern argument In-Reply-To: <041.1dc009a8017f923531af3cb579c24652@buildbot.net> References: <041.1dc009a8017f923531af3cb579c24652@buildbot.net> Message-ID: <056.06f9138549b009f9a4b6eb39fb02502c@buildbot.net> #2107: The Test BuildStep would be more useful with a failurePattern argument ---------------------------+------------------------ Reporter: ulfalizer | Owner: Type: enhancement | Status: new Priority: minor | Milestone: undecided Version: 0.8.4p2 | Resolution: Keywords: BuildStep Test | ---------------------------+------------------------ Changes (by ulfalizer): * priority: major => minor -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Tue Sep 13 21:13:56 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 13 Sep 2011 21:13:56 -0000 Subject: [Buildbot-commits] [Buildbot] #2107: The Test BuildStep would be more useful with a failurePattern argument In-Reply-To: <041.1dc009a8017f923531af3cb579c24652@buildbot.net> References: <041.1dc009a8017f923531af3cb579c24652@buildbot.net> Message-ID: <056.9cbe6b9a8c4edbc9c90169de7623c07c@buildbot.net> #2107: The Test BuildStep would be more useful with a failurePattern argument ---------------------------+------------------------ Reporter: ulfalizer | Owner: Type: enhancement | Status: new Priority: minor | Milestone: undecided Version: 0.8.4p2 | Resolution: Keywords: BuildStep Test | ---------------------------+------------------------ Comment (by ulfalizer): Hmm, seems similar functionality is already present. Undocumented? -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Tue Sep 13 21:35:36 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 13 Sep 2011 21:35:36 -0000 Subject: [Buildbot-commits] [Buildbot] #2107: The Test BuildStep would be more useful with a failurePattern argument In-Reply-To: <041.1dc009a8017f923531af3cb579c24652@buildbot.net> References: <041.1dc009a8017f923531af3cb579c24652@buildbot.net> Message-ID: <056.2ff6c3e9917e4be869048f636b6e895b@buildbot.net> #2107: The Test BuildStep would be more useful with a failurePattern argument ---------------------------+------------------------ Reporter: ulfalizer | Owner: Type: enhancement | Status: new Priority: minor | Milestone: undecided Version: 0.8.4p2 | Resolution: Keywords: BuildStep Test | ---------------------------+------------------------ Comment (by ulfalizer): Ops, I just realized you usually _can_ determine success by looking at the exit status from "make", by generating a non-0 exit status if a test fails. In my case I'm running the tests on an external device and capturing output, but could still do something like ' | grep "All tests succeeded"' I guess. That makes this slightly less useful, but still handy I guess :) -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Sep 16 04:24:33 2011 From: nobody at buildbot.net (Buildbot) Date: Fri, 16 Sep 2011 04:24:33 -0000 Subject: [Buildbot-commits] [Buildbot] #2105: Mercurial hook - exceptions.ValueError: signal only works in main thread In-Reply-To: <039.ae0e754847623a7d7fd8839cdfcb6097@buildbot.net> References: <039.ae0e754847623a7d7fd8839cdfcb6097@buildbot.net> Message-ID: <054.cbe630f8896f0e06200f8cda34befb5f@buildbot.net> #2105: Mercurial hook - exceptions.ValueError: signal only works in main thread ----------------------+------------------------ Reporter: jpichon | Owner: Type: undecided | Status: new Priority: major | Milestone: undecided Version: 0.8.4p2 | Resolution: Keywords: | ----------------------+------------------------ Comment (by hsorby): I am also experiencing difficulties with this. I have a few differences though. #397 suggestion did work for me and I stopped getting the exception related to the signal handler. What happens for me, On the first push I get {{{ #!text pushing to http://localhost:8000 searching for changes remote: adding changesets remote: adding manifests remote: adding file changes remote: added 1 changesets with 1 changes to 1 files remote: rev c34a848fd0f45a56f807638acfcc7f6dbe172039 sent }}} and everything works great. However on the second push I get: {{{ #!text pushing to http://localhost:8000 searching for changes remote: adding changesets remote: adding manifests remote: adding file changes remote: added 1 changesets with 1 changes to 1 files remote: error: changegroup.buildbot hook raised an exception: }}} and nothing gets sent to the build master. As far as my limited tracing has gotten me is to the line of code {{{ #!python reactor.run() }}} in the hgbuildbot.hook script this returns an exception from which it never recovers and I have to restart the mercurial server. Thanks. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sat Sep 17 17:23:10 2011 From: noreply at github.com (noreply at github.com) Date: Sat, 17 Sep 2011 10:23:10 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] b9c4d6: fix MasterShellCommand tests for windows Message-ID: <20110917172310.3340642853@smtp1.rs.github.com> Branch: refs/heads/buildbot-0.8.5 Home: https://github.com/buildbot/buildbot Commit: b9c4d67ea4c2432495000e517e9f16b253016752 https://github.com/buildbot/buildbot/commit/b9c4d67ea4c2432495000e517e9f16b253016752 Author: Dustin J. Mitchell Date: 2011-09-17 (Sat, 17 Sep 2011) Changed paths: M master/buildbot/test/unit/test_steps_master.py Log Message: ----------- fix MasterShellCommand tests for windows Commit: f9160e548a4cecb449af0ea741b894d2bdf33c36 https://github.com/buildbot/buildbot/commit/f9160e548a4cecb449af0ea741b894d2bdf33c36 Author: Dustin J. Mitchell Date: 2011-09-17 (Sat, 17 Sep 2011) Changed paths: M master/buildbot/steps/trigger.py M master/buildbot/test/fake/fakebuild.py A master/buildbot/test/unit/test_steps_trigger.py M master/docs/manual/cfg-buildsteps.rst Log Message: ----------- add tests for the Trigger step Commit: b700465b091cf764d28eb2e914c845c27b4a548e https://github.com/buildbot/buildbot/commit/b700465b091cf764d28eb2e914c845c27b4a548e Author: Dustin J. Mitchell Date: 2011-09-17 (Sat, 17 Sep 2011) Changed paths: M master/buildbot/steps/transfer.py M master/docs/developer/master-slave.rst M slave/buildslave/commands/fs.py M slave/buildslave/commands/shell.py M slave/buildslave/commands/transfer.py Log Message: ----------- overhaul the master-slave docs Commit: 94ff6c46c6bb9bd7a6f4e7d42c1a5ee48ac8e7cf https://github.com/buildbot/buildbot/commit/94ff6c46c6bb9bd7a6f4e7d42c1a5ee48ac8e7cf Author: Dustin J. Mitchell Date: 2011-09-17 (Sat, 17 Sep 2011) Changed paths: M master/buildbot/process/buildstep.py M master/docs/developer/classes.rst A master/docs/developer/cls-buildsteps.rst A master/docs/developer/cls-remotecommands.rst M master/docs/developer/master-slave.rst M master/docs/manual/customization.rst Log Message: ----------- Document build steps and remote commands Compare: https://github.com/buildbot/buildbot/compare/8a40be4...94ff6c4 From noreply at github.com Sat Sep 17 17:23:10 2011 From: noreply at github.com (noreply at github.com) Date: Sat, 17 Sep 2011 10:23:10 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 7aebbf: Document build steps and remote commands Message-ID: <20110917172310.B94254286B@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 7aebbf0b680b9f5d22a0ebebbf2cb69c1e92e035 https://github.com/buildbot/buildbot/commit/7aebbf0b680b9f5d22a0ebebbf2cb69c1e92e035 Author: Dustin J. Mitchell Date: 2011-09-16 (Fri, 16 Sep 2011) Changed paths: M master/buildbot/process/buildstep.py M master/docs/developer/classes.rst A master/docs/developer/cls-buildsteps.rst A master/docs/developer/cls-remotecommands.rst M master/docs/developer/master-slave.rst M master/docs/manual/customization.rst Log Message: ----------- Document build steps and remote commands From noreply at github.com Sat Sep 17 17:49:04 2011 From: noreply at github.com (noreply at github.com) Date: Sat, 17 Sep 2011 10:49:04 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 41bc2a: minor docs typos Message-ID: <20110917174904.806D64286B@smtp1.rs.github.com> Branch: refs/heads/buildbot-0.8.5 Home: https://github.com/buildbot/buildbot Commit: 41bc2a65677f14a392258d0b4d501a66e5bef298 https://github.com/buildbot/buildbot/commit/41bc2a65677f14a392258d0b4d501a66e5bef298 Author: Dustin J. Mitchell Date: 2011-09-17 (Sat, 17 Sep 2011) Changed paths: M master/docs/developer/cls-buildsteps.rst Log Message: ----------- minor docs typos From noreply at github.com Sat Sep 17 17:49:04 2011 From: noreply at github.com (noreply at github.com) Date: Sat, 17 Sep 2011 10:49:04 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 198964: minor docs typos Message-ID: <20110917174904.97DC342872@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 198964c46083dfe2e2188c04b5595fde5a1fd943 https://github.com/buildbot/buildbot/commit/198964c46083dfe2e2188c04b5595fde5a1fd943 Author: Dustin J. Mitchell Date: 2011-09-17 (Sat, 17 Sep 2011) Changed paths: M master/docs/developer/cls-buildsteps.rst Log Message: ----------- minor docs typos From nobody at buildbot.net Sun Sep 18 19:21:01 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 18 Sep 2011 19:21:01 -0000 Subject: [Buildbot-commits] [Buildbot] #2091: MailNotifier chokes on try job with non-ascii char in first line of patch? In-Reply-To: <036.f0e569802d6f78483b94442701bcb9e8@buildbot.net> References: <036.f0e569802d6f78483b94442701bcb9e8@buildbot.net> Message-ID: <051.b141b5a8bd5ac4f090ff04feaa22e8db@buildbot.net> #2091: MailNotifier chokes on try job with non-ascii char in first line of patch? ---------------------+--------------------- Reporter: dank | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.5 Version: master | Resolution: fixed Keywords: encoding | ---------------------+--------------------- Comment (by dank): Still failing. Here's the current stack trace with yesterday's git: 2011-09-18 11:33:40-0700 [-] Exception caught notifying of buildFinished event 2011-09-18 11:33:40-0700 [-] Unhandled Error Traceback (most recent call last): File "buildbot-git/master/buildbot/status/build.py", line 290, in buildFinished w.callback(self) File "lib/python2.7/site-packages/twisted/internet/defer.py", line 361, in callback self._startRunCallbacks(result) File "lib/python2.7/site-packages/twisted/internet/defer.py", line 455, in _startRunCallbacks self._runCallbacks() File "lib/python2.7/site-packages/twisted/internet/defer.py", line 542, in _runCallbacks current.result = callback(current.result, *args, **kw) --- --- File "buildbot-git/master/buildbot/status/builder.py", line 535, in _buildFinished w.buildFinished(name, s, results) File "buildbot-git/master/buildbot/status/mail.py", line 412, in buildFinished return self.buildMessage(name, [build], results) File "buildbot-git/master/buildbot/status/mail.py", line 618, in buildMessage results, builds, patches, logs) File "buildbot-git/master/buildbot/status/mail.py", line 520, in createEmail text = msgdict['body'].encode(ENCODING) exceptions.UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 582: ordinal not in range(128) Not sure what it was unhappy about, the patch it was trying to attach is http://source.winehq.org/patches/data/79014 From: Francois Gouget Subject: msxml3: Fix printing NULL strings. and has no funny characters in it anywhere I can see. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Sep 18 19:21:51 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 18 Sep 2011 19:21:51 -0000 Subject: [Buildbot-commits] [Buildbot] #2091: MailNotifier chokes on try job with non-ascii char in first line of patch? In-Reply-To: <036.f0e569802d6f78483b94442701bcb9e8@buildbot.net> References: <036.f0e569802d6f78483b94442701bcb9e8@buildbot.net> Message-ID: <051.54c891dd2a709a4f29b48d679fb3a86b@buildbot.net> #2091: MailNotifier chokes on try job with non-ascii char in first line of patch? ---------------------+----------------------- Reporter: dank | Owner: Type: defect | Status: reopened Priority: major | Milestone: 0.8.5 Version: master | Resolution: Keywords: encoding | ---------------------+----------------------- Changes (by dank): * status: closed => reopened * resolution: fixed => -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Sep 18 22:45:46 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 18 Sep 2011 22:45:46 -0000 Subject: [Buildbot-commits] [Buildbot] #2106: Buildbot requires pycrypto to setup even an unencrypted manhole In-Reply-To: <042.b881d87fc9ffff62fed02b40b1d6272b@buildbot.net> References: <042.b881d87fc9ffff62fed02b40b1d6272b@buildbot.net> Message-ID: <057.5febb82d3f2265f092641bf9bd7a27cf@buildbot.net> #2106: Buildbot requires pycrypto to setup even an unencrypted manhole -----------------------+-------------------- Reporter: jollyroger | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.4p2 | Resolution: Keywords: | -----------------------+-------------------- Changes (by dustin): * milestone: undecided => 0.8.+ -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Sep 18 22:46:49 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 18 Sep 2011 22:46:49 -0000 Subject: [Buildbot-commits] [Buildbot] #2107: The Test BuildStep would be more useful with a failurePattern argument In-Reply-To: <041.1dc009a8017f923531af3cb579c24652@buildbot.net> References: <041.1dc009a8017f923531af3cb579c24652@buildbot.net> Message-ID: <056.206573ca705dbf4368dbe7d0460eb7bd@buildbot.net> #2107: The Test BuildStep would be more useful with a failurePattern argument ---------------------------+------------------------ Reporter: ulfalizer | Owner: Type: enhancement | Status: new Priority: minor | Milestone: undecided Version: 0.8.4p2 | Resolution: Keywords: BuildStep Test | ---------------------------+------------------------ Comment (by dustin): Where did you notice similar functionality? I'm happy to document if something was missed.. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Sep 18 23:06:07 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 18 Sep 2011 23:06:07 -0000 Subject: [Buildbot-commits] [Buildbot] #2107: The Test BuildStep would be more useful with a failurePattern argument In-Reply-To: <041.1dc009a8017f923531af3cb579c24652@buildbot.net> References: <041.1dc009a8017f923531af3cb579c24652@buildbot.net> Message-ID: <056.d7df004b0a5c175deb38f302637355c0@buildbot.net> #2107: The Test BuildStep would be more useful with a failurePattern argument ---------------------------+------------------------ Reporter: ulfalizer | Owner: Type: enhancement | Status: new Priority: minor | Milestone: undecided Version: 0.8.4p2 | Resolution: Keywords: BuildStep Test | ---------------------------+------------------------ Comment (by ulfalizer): Replying to [comment:4 dustin]: > Where did you notice similar functionality? I'm happy to document if something was missed.. I think it was just a misunderstanding on my part. There's some "protected:" stuff in Test (PerlModuleTest uses it), but nothing you can use directly without subclassing. So something like this could still be useful. Test taking success/failure/warningPattern arguments would probably cover the needs of lots of users. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sun Sep 18 23:16:08 2011 From: noreply at github.com (noreply at github.com) Date: Sun, 18 Sep 2011 16:16:08 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 54c1d1: add an additional test for vstudio steps Message-ID: <20110918231608.9E33B4265C@smtp1.rs.github.com> Branch: refs/heads/buildbot-0.8.5 Home: https://github.com/buildbot/buildbot Commit: 54c1d14236d8b5496764d2a6b0fa15772d3394af https://github.com/buildbot/buildbot/commit/54c1d14236d8b5496764d2a6b0fa15772d3394af Author: Dustin J. Mitchell Date: 2011-09-18 (Sun, 18 Sep 2011) Changed paths: M master/buildbot/test/unit/test_steps_vstudio.py Log Message: ----------- add an additional test for vstudio steps From noreply at github.com Sun Sep 18 23:16:08 2011 From: noreply at github.com (noreply at github.com) Date: Sun, 18 Sep 2011 16:16:08 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 8cf850: add an additional test for vstudio steps Message-ID: <20110918231608.4C5A942633@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 8cf8503b6f2a4f007f7db57c69a90bddded44dba https://github.com/buildbot/buildbot/commit/8cf8503b6f2a4f007f7db57c69a90bddded44dba Author: Dustin J. Mitchell Date: 2011-09-18 (Sun, 18 Sep 2011) Changed paths: M master/buildbot/test/unit/test_steps_vstudio.py Log Message: ----------- add an additional test for vstudio steps From noreply at github.com Sun Sep 18 23:54:52 2011 From: noreply at github.com (noreply at github.com) Date: Sun, 18 Sep 2011 16:54:52 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 3ec49b: persist patch_info in getAbsoluteSourceStamp Message-ID: <20110918235452.609CA42505@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 3ec49b7cb484fdabbe8ad537f9c5c757d31a7107 https://github.com/buildbot/buildbot/commit/3ec49b7cb484fdabbe8ad537f9c5c757d31a7107 Author: Dustin J. Mitchell Date: 2011-09-18 (Sun, 18 Sep 2011) Changed paths: M master/buildbot/sourcestamp.py Log Message: ----------- persist patch_info in getAbsoluteSourceStamp From nobody at buildbot.net Mon Sep 19 00:14:12 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 19 Sep 2011 00:14:12 -0000 Subject: [Buildbot-commits] [Buildbot] #2091: MailNotifier chokes on try job with non-ascii char in first line of patch? In-Reply-To: <036.f0e569802d6f78483b94442701bcb9e8@buildbot.net> References: <036.f0e569802d6f78483b94442701bcb9e8@buildbot.net> Message-ID: <051.d5101d6cb14bfb0ec0795fefa559acbf@buildbot.net> #2091: MailNotifier chokes on try job with non-ascii char in first line of patch? ---------------------+----------------------- Reporter: dank | Owner: Type: defect | Status: reopened Priority: major | Milestone: 0.8.+ Version: master | Resolution: Keywords: encoding | ---------------------+----------------------- Changes (by dustin): * milestone: 0.8.5 => 0.8.+ Comment: I think we'll need to defer this to the next release.. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Mon Sep 19 00:43:37 2011 From: noreply at github.com (noreply at github.com) Date: Sun, 18 Sep 2011 17:43:37 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 33e63c: add link to github's compare to NEWS, add NEWS ite... Message-ID: <20110919004337.AE37C42620@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 33e63cf8cfeabac43ecf40f368b096bc5032a767 https://github.com/buildbot/buildbot/commit/33e63cf8cfeabac43ecf40f368b096bc5032a767 Author: Dustin J. Mitchell Date: 2011-09-18 (Sun, 18 Sep 2011) Changed paths: M master/NEWS M slave/NEWS Log Message: ----------- add link to github's compare to NEWS, add NEWS item about docs From noreply at github.com Mon Sep 19 00:43:37 2011 From: noreply at github.com (noreply at github.com) Date: Sun, 18 Sep 2011 17:43:37 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 1061e1: persist patch_info in getAbsoluteSourceStamp Message-ID: <20110919004337.D74D9426EE@smtp1.rs.github.com> Branch: refs/heads/buildbot-0.8.5 Home: https://github.com/buildbot/buildbot Commit: 1061e10ced47afdb51811dd1e89efc0bd456b92e https://github.com/buildbot/buildbot/commit/1061e10ced47afdb51811dd1e89efc0bd456b92e Author: Dustin J. Mitchell Date: 2011-09-18 (Sun, 18 Sep 2011) Changed paths: M master/buildbot/sourcestamp.py Log Message: ----------- persist patch_info in getAbsoluteSourceStamp Commit: 80a524bb75ccac88894a22827d7df2fddcd81557 https://github.com/buildbot/buildbot/commit/80a524bb75ccac88894a22827d7df2fddcd81557 Author: Dustin J. Mitchell Date: 2011-09-18 (Sun, 18 Sep 2011) Changed paths: M master/NEWS M slave/NEWS Log Message: ----------- add link to github's compare to NEWS, add NEWS item about docs Compare: https://github.com/buildbot/buildbot/compare/54c1d14...80a524b From noreply at github.com Mon Sep 19 10:23:04 2011 From: noreply at github.com (noreply at github.com) Date: Mon, 19 Sep 2011 03:23:04 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] f77c47: Add sphinx extension to manifest Message-ID: <20110919102304.CF25942695@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: f77c47aa5fb9ba56dbe7d16c450990d186e2ff6d https://github.com/buildbot/buildbot/commit/f77c47aa5fb9ba56dbe7d16c450990d186e2ff6d Author: jbergstroem Date: 2011-09-19 (Mon, 19 Sep 2011) Changed paths: M master/MANIFEST.in Log Message: ----------- Add sphinx extension to manifest Commit: c65e84b007d334de5690738fdab7dd8cae479cce https://github.com/buildbot/buildbot/commit/c65e84b007d334de5690738fdab7dd8cae479cce Author: jbergstroem Date: 2011-09-19 (Mon, 19 Sep 2011) Changed paths: M master/MANIFEST.in Log Message: ----------- Add missing documentation folder to manifest Commit: 5d08332ebdc5a751ecf8bdba5ebc3840511c718b https://github.com/buildbot/buildbot/commit/5d08332ebdc5a751ecf8bdba5ebc3840511c718b Author: Amber Yust Date: 2011-09-19 (Mon, 19 Sep 2011) Changed paths: M master/MANIFEST.in Log Message: ----------- Merge pull request #248 from jbergstroem/doc-fixes Make document generation work on sdist packages Compare: https://github.com/buildbot/buildbot/compare/33e63cf...5d08332 From noreply at github.com Mon Sep 19 16:00:43 2011 From: noreply at github.com (noreply at github.com) Date: Mon, 19 Sep 2011 09:00:43 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 5a448b: Merge branch 'master' of github.com:buildbot/build... Message-ID: <20110919160043.BE9594246F@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 5a448ba70522d1ba909dc4c815ad804f74324bcf https://github.com/buildbot/buildbot/commit/5a448ba70522d1ba909dc4c815ad804f74324bcf Author: Dustin J. Mitchell Date: 2011-09-19 (Mon, 19 Sep 2011) Changed paths: M master/MANIFEST.in Log Message: ----------- Merge branch 'master' of github.com:buildbot/buildbot * 'master' of github.com:buildbot/buildbot: Add missing documentation folder to manifest Add sphinx extension to manifest From nobody at buildbot.net Tue Sep 20 04:33:09 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 20 Sep 2011 04:33:09 -0000 Subject: [Buildbot-commits] [Buildbot] #669: Clean up VC modes In-Reply-To: <038.ef722893af44e1713fb7212c6d56ca76@buildbot.net> References: <038.ef722893af44e1713fb7212c6d56ca76@buildbot.net> Message-ID: <053.d4403e1505851e797dc5e3dd612e7f0b@buildbot.net> #669: Clean up VC modes -------------------------------------------------+--------------------- Reporter: dustin | Owner: dustin Type: enhancement | Status: closed Priority: major | Milestone: 1.0.+ Version: 0.7.12 | Resolution: fixed Keywords: svn hg git cvs p4 bk darcs ship-this | -------------------------------------------------+--------------------- Changes (by dustin): * status: new => closed * resolution: => fixed Comment: This was largely implemented this summer by in3xes, yay! -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Tue Sep 20 04:41:05 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 20 Sep 2011 04:41:05 -0000 Subject: [Buildbot-commits] [Buildbot] #24: save build status in an SQL database In-Reply-To: <038.79520b4a8accd5cb1f26c635b721c8f8@buildbot.net> References: <038.79520b4a8accd5cb1f26c635b721c8f8@buildbot.net> Message-ID: <053.51eaaf108e517d4dc62bb69fb15a1483@buildbot.net> #24: save build status in an SQL database -------------------------------+----------------------- Reporter: warner | Owner: warner Type: enhancement | Status: assigned Priority: minor | Milestone: 0.9.0 Version: | Resolution: Keywords: database ship-this | -------------------------------+----------------------- Changes (by dustin): * milestone: 0.8.+ => 0.9.0 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Tue Sep 20 04:36:09 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 20 Sep 2011 04:36:09 -0000 Subject: [Buildbot-commits] [Buildbot] #1839: replace apidocs with something like LXR In-Reply-To: <038.9d1bc7b4a0237e361c6c248811bc13c8@buildbot.net> References: <038.9d1bc7b4a0237e361c6c248811bc13c8@buildbot.net> Message-ID: <053.600455a7adf812f86b6eb588bc6c75e0@buildbot.net> #1839: replace apidocs with something like LXR -------------------+---------------------- Reporter: dustin | Owner: Type: task | Status: new Priority: major | Milestone: ongoing Version: master | Resolution: Keywords: docs | -------------------+---------------------- Comment (by dustin): The better solution for documentation is just to describe these APIs using sphinx, which has already begun. Still, searchable source would be nice. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Tue Sep 20 16:13:04 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 20 Sep 2011 16:13:04 -0000 Subject: [Buildbot-commits] [Buildbot] #2108: BuildBot uses incorrect method for default location of Visual Studios Message-ID: <045.85ed2bd6655c4fd7b0274987c6dd1583@buildbot.net> #2108: BuildBot uses incorrect method for default location of Visual Studios --------------------------+----------------------- Reporter: TemporalBeing | Owner: Type: enhancement | Status: new Priority: minor | Milestone: undecided Version: 0.8.5 | Keywords: --------------------------+----------------------- Buildbot presently uses a hard coded value for the default location of Visual Studios. This means that the user would need to use the 'installdir' parameter to the VS builders whenever they (i) install to a different drive, (ii) install to a different directory. This could be very common, especially on computers that have multiple OSes installed. Fortunately, Microsoft did provide a nice way around this issue - look to the Windows Registry. Personally I have done this for scripting for VS6, VS2003, and VS2008 in which I can report the following registry keys work very well: Visual Studios 6 HKLM\Software\Microsoft\VisualStudio\6.0\Setup\Microsoft Visual C++\ProductDir Visual Studios 7.1 (aka VS2003) HKLM\Software\Microsoft\VisualStudio\7.1\Setup\VS\VS7CommonBinDir Visual Studios 9 (aka VS2008) HKLM\Software\Microsoft\VisualStudio\9.0\Setup\VS\VS7CommonBinDir We should be able to use the pattern above (for VS7/9) for a starting point for later versions at the very least, using the following pattern: HKLM\Software\Microsoft\VisualStudios\\Setup\VS\VS7CommonBinDir Doing this provides two major benefits: 1) Default is now the default of the installed version of Visual Studios. So 'installdir' is only useful in very weird installations (such as having custom built installations or multiple installations of the same version on the same system, etc.) 2) Buildbot can now provide a check to see if the requested version of VS is installed prior to attempting the build, and provide a good error message if it is not (something like VS2008 is not installed on the buildSlave) as opposed to simply reporting that the build program (e.g. devenv.com or msbuild) was not found in the path. The only potential problem is the client-server approach of Buildbot since the registry would need to be read on the build slave instead of the build master. This could provide some challenges to implementation. PyWin32 provides support for accessing the registry via the the win32api module, which seems to use the same interfaces as VC++ code so it should be pretty straight forward. Python also natively supports the Windows Registry via the _winreg (2.x) and winreg (3.x) modules. http://docs.python.org/library/_winreg.html http://docs.activestate.com/activepython/2.7/pywin32/win32api.html -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Sep 21 23:02:19 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 21 Sep 2011 23:02:19 -0000 Subject: [Buildbot-commits] [Buildbot] #2109: Need method to limit the number of concurrent builds to start for a builder regardless of # of buildslaves assigned Message-ID: <040.c074e51c81e649fdf4f8ba7ef42680b1@buildbot.net> #2109: Need method to limit the number of concurrent builds to start for a builder regardless of # of buildslaves assigned ------------------------+----------------------- Reporter: bdbaddog | Owner: Type: enhancement | Status: new Priority: major | Milestone: undecided Version: 0.8.5 | Keywords: ------------------------+----------------------- It would be nice to be able to specify max_builds to the builder (rather than the buildslave). {{{ MasterLock() }}} won't resolve this issue as the builds start in the builder, then get held by the lock. This doesn't allow for builds to be merged. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Thu Sep 22 04:26:03 2011 From: nobody at buildbot.net (Buildbot) Date: Thu, 22 Sep 2011 04:26:03 -0000 Subject: [Buildbot-commits] [Buildbot] #2105: Mercurial hook - exceptions.ValueError: signal only works in main thread In-Reply-To: <039.ae0e754847623a7d7fd8839cdfcb6097@buildbot.net> References: <039.ae0e754847623a7d7fd8839cdfcb6097@buildbot.net> Message-ID: <054.360b4bde537226873aa610ebb969c465@buildbot.net> #2105: Mercurial hook - exceptions.ValueError: signal only works in main thread ----------------------+------------------------ Reporter: jpichon | Owner: Type: undecided | Status: new Priority: major | Milestone: undecided Version: 0.8.4p2 | Resolution: Keywords: | ----------------------+------------------------ Comment (by hsorby): I appear to have sorted out my problem. I had to do two things. 1. Change reactor.run() line in hgbuildbot.hook to reactor.run(installSignalHandlers=0) 2. Set the [hgbuildbot] section in .hg/hgrc from my repository where hg serve is running to {{{ [hgbuildbot] master = master.is.here:8080 branch = my_branch fork = true }}} After doing this I have continuous building/testing joy. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Thu Sep 22 07:01:09 2011 From: noreply at github.com (noreply at github.com) Date: Thu, 22 Sep 2011 00:01:09 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 28682e: fixed small typo on cfg-interlocks page Message-ID: <20110922070109.36B55424FF@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 28682ec29450e3b3b9f283c169b928de6b108610 https://github.com/buildbot/buildbot/commit/28682ec29450e3b3b9f283c169b928de6b108610 Author: William Deegan Date: 2011-09-20 (Tue, 20 Sep 2011) Changed paths: M master/docs/manual/cfg-interlocks.rst Log Message: ----------- fixed small typo on cfg-interlocks page Commit: ee7d36d5609d19b3f9372e134306572055e9f9c4 https://github.com/buildbot/buildbot/commit/ee7d36d5609d19b3f9372e134306572055e9f9c4 Author: William Deegan Date: 2011-09-20 (Tue, 20 Sep 2011) Changed paths: M master/docs/manual/cfg-interlocks.rst Log Message: ----------- fixed lock mode description, should be counting or exclusive and not counting or shared Commit: 8e0282935576fff81fa0d526799cac58d68ed6af https://github.com/buildbot/buildbot/commit/8e0282935576fff81fa0d526799cac58d68ed6af Author: Amber Yust Date: 2011-09-22 (Thu, 22 Sep 2011) Changed paths: M master/docs/manual/cfg-interlocks.rst Log Message: ----------- Merge pull request #249 from bdbaddog/084_misc_text_fixes 084 misc text fixes Compare: https://github.com/buildbot/buildbot/compare/5a448ba...8e02829 From nobody at buildbot.net Thu Sep 22 07:35:43 2011 From: nobody at buildbot.net (Buildbot) Date: Thu, 22 Sep 2011 07:35:43 -0000 Subject: [Buildbot-commits] [Buildbot] #1932: property value can't have space if submitted from "Force build" or "Resubmit build" form In-Reply-To: <041.481a71d3a6c8475a62e5907fd4fcb4af@buildbot.net> References: <041.481a71d3a6c8475a62e5907fd4fcb4af@buildbot.net> Message-ID: <056.d27b676f66af98c8d4bb6351c7b40a5d@buildbot.net> #1932: property value can't have space if submitted from "Force build" or "Resubmit build" form ------------------------+------------------------ Reporter: liucougar | Owner: Type: enhancement | Status: closed Priority: minor | Milestone: Version: 0.8.3p1 | Resolution: duplicate Keywords: | ------------------------+------------------------ Changes (by jmr): * status: new => closed * resolution: => duplicate Comment: Duplicate of #985. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Thu Sep 22 08:06:59 2011 From: nobody at buildbot.net (Buildbot) Date: Thu, 22 Sep 2011 08:06:59 -0000 Subject: [Buildbot-commits] [Buildbot] #2105: Mercurial hook - exceptions.ValueError: signal only works in main thread In-Reply-To: <039.ae0e754847623a7d7fd8839cdfcb6097@buildbot.net> References: <039.ae0e754847623a7d7fd8839cdfcb6097@buildbot.net> Message-ID: <054.3eb128dc07cc6415fb7f45cf78529749@buildbot.net> #2105: Mercurial hook - exceptions.ValueError: signal only works in main thread ----------------------+------------------------ Reporter: jpichon | Owner: Type: undecided | Status: new Priority: major | Milestone: undecided Version: 0.8.4p2 | Resolution: Keywords: | ----------------------+------------------------ Comment (by jpichon): Have you taken a look at your process list after doing this? When I started using "fork" I ended up with a lot of defunct processes (children of Mercurial, one for every push) that wouldn't disappear until Mercurial is restarted. I only left them hanging a few hours, so perhaps they do go away after a while. My current workaround is to mirror the repositories on the buildbot server, which is less than ideal but does the job for now. (I tried installing buildbot master on the same server than Mercurial, but the problem didn't disappear.) -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Thu Sep 22 13:43:08 2011 From: nobody at buildbot.net (Buildbot) Date: Thu, 22 Sep 2011 13:43:08 -0000 Subject: [Buildbot-commits] [Buildbot] #2110: New SVN checkout step does not respect workdir when using full mode and copy method Message-ID: <042.2246a41c8b1a4e13b60fdad8042854d7@buildbot.net> #2110: New SVN checkout step does not respect workdir when using full mode and copy method -----------------------+----------------------- Reporter: garmstrong | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.5 | Keywords: -----------------------+----------------------- I aligned one of our simpler projects with BuildBot 0.8.5 and aligned on the new master side source step for SVN for source checkout. Code is checked to the source directory as advertised in the Buildbot 0.8.5 documentation and then copied to the build/source as advertised. However, I was expecting that the workdir parameter be respected as in the case with the incremental mode. The contents of the source should be copied to workdir (as with the old buildslave SVN command copy mode). -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Thu Sep 22 14:51:08 2011 From: nobody at buildbot.net (Buildbot) Date: Thu, 22 Sep 2011 14:51:08 -0000 Subject: [Buildbot-commits] [Buildbot] #2111: Triggerable sheduler does not inherit Blamelist or Changes from upstream timed.Nightly scheduler Message-ID: <042.88390c604c1552229eaef3bcca93281a@buildbot.net> #2111: Triggerable sheduler does not inherit Blamelist or Changes from upstream timed.Nightly scheduler -----------------------+----------------------- Reporter: garmstrong | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.5 | Keywords: -----------------------+----------------------- Previously in Buildbot 0.8.4p2 and earlier a quick or full build initiated by a Triggerable scheduler would inherit the Blamelist and Changes from its upstream timed.Nightly scheduler. This is no longer the case in Buildbot 0.8.5. In my particular case, this leads to a reporting issue when builds fails as the mail sent by the MailNotifier contains no information on possible suspects. The parts of the build managed by the upstream timed.Nightly schedulers do contain the Blamelist and associated changes. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Thu Sep 22 21:17:51 2011 From: nobody at buildbot.net (Buildbot) Date: Thu, 22 Sep 2011 21:17:51 -0000 Subject: [Buildbot-commits] [Buildbot] #1936: optimize getOldestRequestTime In-Reply-To: <038.7a24f9fbb575b54572e76045aa2d1886@buildbot.net> References: <038.7a24f9fbb575b54572e76045aa2d1886@buildbot.net> Message-ID: <053.c604be451e3db385c485c56f37e0e11c@buildbot.net> #1936: optimize getOldestRequestTime ----------------------------------+-------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.6 Version: 0.8.3p1 | Resolution: Keywords: database, performance | ----------------------------------+-------------------- Comment (by aivarsk): Can you provide a link to Catlee's code? This kills performance of our buildmaster. We have 35 builders and each getOldestRequestTime SELECT takes 0.01-0.07 seconds (buildrequests has 125,400 records and buildsets has 14,461 records). 10 builders have about 650 buildrequests each day (nightly build for 600 "projects") and others about 50 buildrequests per day. Tables had 1,344,969 and 165,365 records before and queries often showed up in logfiles ("Long query..." with 2 and more seconds). Not sure why tables were not cleaned up. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Sep 23 00:26:45 2011 From: nobody at buildbot.net (Buildbot) Date: Fri, 23 Sep 2011 00:26:45 -0000 Subject: [Buildbot-commits] [Buildbot] #1936: optimize getOldestRequestTime In-Reply-To: <038.7a24f9fbb575b54572e76045aa2d1886@buildbot.net> References: <038.7a24f9fbb575b54572e76045aa2d1886@buildbot.net> Message-ID: <053.3d1c09b16f751a53aa178299cedc7488@buildbot.net> #1936: optimize getOldestRequestTime ----------------------------------+-------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.6 Version: 0.8.3p1 | Resolution: Keywords: database, performance | ----------------------------------+-------------------- Comment (by dustin): Catlee's patch is for 0.8.2, and won't apply anymore. After a quick look through the code (e.g., http://hg.mozilla.org/build/buildbot/annotate/d73b422653de/master/buildbot/process/builder.py), I can't find it. Maybe it never landed? 0.8.4 and 0.8.5 do quite a bit better at this -- only builders which actually have outstanding build requests are sorted, rather than all builders. Are there a lot of unclaimed build requests that you're finding? Could you define a less computationally-intensive prioritizeBuilders function? -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Sep 23 02:34:06 2011 From: nobody at buildbot.net (Buildbot) Date: Fri, 23 Sep 2011 02:34:06 -0000 Subject: [Buildbot-commits] [Buildbot] #2107: The Test BuildStep would be more useful with a failurePattern argument In-Reply-To: <041.1dc009a8017f923531af3cb579c24652@buildbot.net> References: <041.1dc009a8017f923531af3cb579c24652@buildbot.net> Message-ID: <056.c72dff7113592e9ad7e7281b3dd54131@buildbot.net> #2107: The Test BuildStep would be more useful with a failurePattern argument ---------------------------+------------------------ Reporter: ulfalizer | Owner: Type: enhancement | Status: new Priority: minor | Milestone: undecided Version: 0.8.4p2 | Resolution: Keywords: BuildStep Test | ---------------------------+------------------------ Comment (by dustin): Is WarningCountingShellCommand what you're looking for? -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Sep 23 02:44:39 2011 From: nobody at buildbot.net (Buildbot) Date: Fri, 23 Sep 2011 02:44:39 -0000 Subject: [Buildbot-commits] [Buildbot] #2108: BuildBot uses incorrect method for default location of Visual Studios In-Reply-To: <045.85ed2bd6655c4fd7b0274987c6dd1583@buildbot.net> References: <045.85ed2bd6655c4fd7b0274987c6dd1583@buildbot.net> Message-ID: <060.0b7f59a8ad341fd36f9d721bf73a170c@buildbot.net> #2108: BuildBot uses incorrect method for default location of Visual Studios --------------------------+-------------------- Reporter: TemporalBeing | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.+ Version: 0.8.5 | Resolution: Keywords: windows | --------------------------+-------------------- Changes (by dustin): * keywords: => windows * milestone: undecided => 0.8.+ Comment: I wouldn't be opposed to adding a read_registry slave command, and using that in the vstudio class. Do you want to give that a shot? -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Sep 23 03:02:34 2011 From: nobody at buildbot.net (Buildbot) Date: Fri, 23 Sep 2011 03:02:34 -0000 Subject: [Buildbot-commits] [Buildbot] #2108: BuildBot uses incorrect method for default location of Visual Studios In-Reply-To: <045.85ed2bd6655c4fd7b0274987c6dd1583@buildbot.net> References: <045.85ed2bd6655c4fd7b0274987c6dd1583@buildbot.net> Message-ID: <060.bd70476cfe0d7d6d9d4e350bc1164b22@buildbot.net> #2108: BuildBot uses incorrect method for default location of Visual Studios --------------------------+-------------------- Reporter: TemporalBeing | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.+ Version: 0.8.5 | Resolution: Keywords: windows | --------------------------+-------------------- Comment (by dustin): There's a good discussion of this issue on the mailing list now: http://article.gmane.org/gmane.comp.python.buildbot.devel/7736 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Sep 23 03:23:03 2011 From: nobody at buildbot.net (Buildbot) Date: Fri, 23 Sep 2011 03:23:03 -0000 Subject: [Buildbot-commits] [Buildbot] #2105: Mercurial hook - exceptions.ValueError: signal only works in main thread In-Reply-To: <039.ae0e754847623a7d7fd8839cdfcb6097@buildbot.net> References: <039.ae0e754847623a7d7fd8839cdfcb6097@buildbot.net> Message-ID: <054.66c7cabc5b5e906cdb9e43b07652f54c@buildbot.net> #2105: Mercurial hook - exceptions.ValueError: signal only works in main thread --------------------+-------------------- Reporter: jpichon | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.6 Version: 0.8.4p2 | Resolution: Keywords: hg | --------------------+-------------------- Changes (by dustin): * keywords: => hg * type: undecided => defect * milestone: undecided => 0.8.6 Comment: So here's what's happening: Mercurial is running the hook in a thread. The hook is using Twisted Python, which really, really does not want to run in a thread. Adding `installSignalHandlers=0` avoids the call to `signal(..)`, but has other effects -- notably, Twisted does not get SIGCHLD, so it never cleans up its children. I'm not sure this can be made to work easily. I suspect that, if we want to keep supporting a mercurial hook, it will need to fire off an external script that submits the change to the master, rather than trying to do so within the Mercurial process. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Sep 23 03:24:57 2011 From: nobody at buildbot.net (Buildbot) Date: Fri, 23 Sep 2011 03:24:57 -0000 Subject: [Buildbot-commits] [Buildbot] #2110: New SVN checkout step does not respect workdir when using full mode and copy method In-Reply-To: <042.2246a41c8b1a4e13b60fdad8042854d7@buildbot.net> References: <042.2246a41c8b1a4e13b60fdad8042854d7@buildbot.net> Message-ID: <057.470fd5296536ff687a9c35900e14e25a@buildbot.net> #2110: New SVN checkout step does not respect workdir when using full mode and copy method -----------------------+-------------------- Reporter: garmstrong | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.6 Version: 0.8.5 | Resolution: Keywords: svn | -----------------------+-------------------- Changes (by dustin): * keywords: => svn * milestone: undecided => 0.8.6 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Sep 23 03:26:53 2011 From: nobody at buildbot.net (Buildbot) Date: Fri, 23 Sep 2011 03:26:53 -0000 Subject: [Buildbot-commits] [Buildbot] #2111: Triggerable sheduler does not inherit Blamelist or Changes from upstream timed.Nightly scheduler In-Reply-To: <042.88390c604c1552229eaef3bcca93281a@buildbot.net> References: <042.88390c604c1552229eaef3bcca93281a@buildbot.net> Message-ID: <057.22c420614524e335c02416b4d2affc58@buildbot.net> #2111: Triggerable sheduler does not inherit Blamelist or Changes from upstream timed.Nightly scheduler -----------------------+-------------------- Reporter: garmstrong | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.6 Version: 0.8.5 | Resolution: Keywords: | -----------------------+-------------------- Changes (by dustin): * milestone: undecided => 0.8.6 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Sep 23 12:06:19 2011 From: nobody at buildbot.net (Buildbot) Date: Fri, 23 Sep 2011 12:06:19 -0000 Subject: [Buildbot-commits] [Buildbot] #1936: optimize getOldestRequestTime In-Reply-To: <038.7a24f9fbb575b54572e76045aa2d1886@buildbot.net> References: <038.7a24f9fbb575b54572e76045aa2d1886@buildbot.net> Message-ID: <053.e1f2581daaa5570c7751fdf50ecec07b@buildbot.net> #1936: optimize getOldestRequestTime ----------------------------------+-------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.6 Version: 0.8.3p1 | Resolution: Keywords: database, performance | ----------------------------------+-------------------- Comment (by aivarsk): Thanks for the idea about custom prioritizeBuilders function. I'm not familiar with buildbot DB structure so I can't answer about unclaimed builds. But I will take a closer look because state.sqlite keeps growing (it was 0.5Gb before last manual cleanup) -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sat Sep 24 05:58:09 2011 From: noreply at github.com (noreply at github.com) Date: Fri, 23 Sep 2011 22:58:09 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 4b0275: Added "validation" to the list of known config key... Message-ID: <20110924055809.8F1934204A@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 4b0275772b8a7f42bc7aa558f09d62a7095de8cf https://github.com/buildbot/buildbot/commit/4b0275772b8a7f42bc7aa558f09d62a7095de8cf Author: Joshua Root Date: 2011-09-23 (Fri, 23 Sep 2011) Changed paths: M master/buildbot/master.py Log Message: ----------- Added "validation" to the list of known config keys. Commit: 6dcb5c95c729cb13a94ec534a22489282ccc819e https://github.com/buildbot/buildbot/commit/6dcb5c95c729cb13a94ec534a22489282ccc819e Author: Joshua Root Date: 2011-09-23 (Fri, 23 Sep 2011) Changed paths: M master/buildbot/master.py Log Message: ----------- Alphabetised the list of known config keys. This makes it easier to see if a particular key is in the list. Commit: 5beba78e3ee9669eba8905cb4f62c3e8159badb5 https://github.com/buildbot/buildbot/commit/5beba78e3ee9669eba8905cb4f62c3e8159badb5 Author: Amber Yust Date: 2011-09-23 (Fri, 23 Sep 2011) Changed paths: M master/buildbot/master.py Log Message: ----------- Merge pull request #251 from jmroot/myfixes Fixes for known config keys list Compare: https://github.com/buildbot/buildbot/compare/8e02829...5beba78 From nobody at buildbot.net Sun Sep 25 00:44:50 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 25 Sep 2011 00:44:50 -0000 Subject: [Buildbot-commits] [Buildbot] #2112: Adding a large batch of changes seems to run at about 7 changes/s. Message-ID: <042.387ab9bf04f6b1118c006875a47221cf@buildbot.net> #2112: Adding a large batch of changes seems to run at about 7 changes/s. ------------------------+----------------------- Reporter: tom.prince | Owner: Type: enhancement | Status: new Priority: minor | Milestone: undecided Version: master | Keywords: ------------------------+----------------------- -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Sep 25 05:21:27 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 25 Sep 2011 05:21:27 -0000 Subject: [Buildbot-commits] [Buildbot] #2112: Adding a large batch of changes seems to run at about 7 changes/s. In-Reply-To: <042.387ab9bf04f6b1118c006875a47221cf@buildbot.net> References: <042.387ab9bf04f6b1118c006875a47221cf@buildbot.net> Message-ID: <057.e6ae062d6a29510a4a3625bb38dcf426@buildbot.net> #2112: Adding a large batch of changes seems to run at about 7 changes/s. ------------------------+-------------------- Reporter: tom.prince | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.+ Version: master | Resolution: Keywords: performance | ------------------------+-------------------- Changes (by dustin): * keywords: => performance * milestone: undecided => 0.8.+ Comment: We should look into the queries that are executed, and the speed with which they occur. This may be due to the extra user-related queries? -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Sep 25 05:25:37 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 25 Sep 2011 05:25:37 -0000 Subject: [Buildbot-commits] [Buildbot] #2113: documentation for status_gerrit Message-ID: <038.344b9f94a669d5823f7671a264ad3755@buildbot.net> #2113: documentation for status_gerrit ------------------------+------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.+ Version: 0.8.4p2 | Keywords: docs ------------------------+------------------- 'gerrit' doesn't appear anywhere in the master/docs/manual, so I'm assuming at least some of the documentation is missing :) -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Sep 25 05:54:31 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 25 Sep 2011 05:54:31 -0000 Subject: [Buildbot-commits] [Buildbot] #2114: database length restrictions on properties are silent Message-ID: <038.c9b81d79bc98f826f36732a2c508d9ef@buildbot.net> #2114: database length restrictions on properties are silent --------------------+---------------------- Reporter: dustin | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.6 Version: 0.8.4p2 | Keywords: database --------------------+---------------------- If you create a property that's too long, the database fails to tell you about it, and you get an error reading the JSON back. We should detect this and error out at insert/update time. See https://github.com/tardyp/buildbot/commit/03f8fcb35552991663a177c7ff160993741f921a -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sun Sep 25 06:15:36 2011 From: noreply at github.com (noreply at github.com) Date: Sat, 24 Sep 2011 23:15:36 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 67c0ab: db: more robustness to property parsing Message-ID: <20110925061536.D25DC4243C@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 67c0ab21b3947a13f1327665d95690b0888f316e https://github.com/buildbot/buildbot/commit/67c0ab21b3947a13f1327665d95690b0888f316e Author: Pierre Tardy Date: 2011-09-24 (Sat, 24 Sep 2011) Changed paths: M master/buildbot/db/buildsets.py M master/buildbot/db/changes.py Log Message: ----------- db: more robustness to property parsing The properties are limited by the DB to a certain amount of bytes They will be silently truncated by DB. This leads pickle to fail unserialize them. We add more exception catching, and let the status page display, even if we will not have many usefull thing for that builset Signed-off-by: Pierre Tardy Commit: 4511165debe24b0e1222ad6ee785ccdd882eff2f https://github.com/buildbot/buildbot/commit/4511165debe24b0e1222ad6ee785ccdd882eff2f Author: Pierre Tardy Date: 2011-09-24 (Sat, 24 Sep 2011) Changed paths: M master/buildbot/steps/source/oldsource.py M slave/buildslave/commands/repo.py Log Message: ----------- repo: add manifest_override_url People often ask to be able to rebuild one build, and append some more patch above it. We give the option to pass a url to a manifest that will be used instead of the latest manifest. Signed-off-by: Pierre Tardy Commit: 3b3ed8d3bf450b943b687281c5acc3c441761ddb https://github.com/buildbot/buildbot/commit/3b3ed8d3bf450b943b687281c5acc3c441761ddb Author: Pierre Tardy Date: 2011-09-24 (Sat, 24 Sep 2011) Changed paths: M slave/buildslave/commands/repo.py Log Message: ----------- slave:repo: show the list of downloaded patches so it is more clear what is really downloaded people can more easily reproduce the build manually Signed-off-by: Pierre Tardy Commit: 8f037ce8f8de6b59882c59dce31f39364dbb9c11 https://github.com/buildbot/buildbot/commit/8f037ce8f8de6b59882c59dce31f39364dbb9c11 Author: Pierre Tardy Date: 2011-09-24 (Sat, 24 Sep 2011) Changed paths: M slave/buildslave/commands/repo.py Log Message: ----------- slave:repo: generate manifest-original.xml This manifest is the manifest describing the repo state before applying any cherry-pick. manigest after cherry-pick is less usefull, as cherry-pick commitid are not reproducible it is up to the config file to make something valuable from this generated file Signed-off-by: Pierre Tardy Commit: dc27f13eb9b5152776571de66d29d6c076c1b9cc https://github.com/buildbot/buildbot/commit/dc27f13eb9b5152776571de66d29d6c076c1b9cc Author: Dustin J. Mitchell Date: 2011-09-24 (Sat, 24 Sep 2011) Changed paths: M slave/buildslave/commands/repo.py Log Message: ----------- remove tabs, use textwrap.dedent in repo.py Commit: cdffd4443cc710d5840603de7d280d09d86e916d https://github.com/buildbot/buildbot/commit/cdffd4443cc710d5840603de7d280d09d86e916d Author: Dustin J. Mitchell Date: 2011-09-24 (Sat, 24 Sep 2011) Changed paths: M master/buildbot/master.py Log Message: ----------- Merge branch 'master' of github.com:buildbot/buildbot * 'master' of github.com:buildbot/buildbot: Alphabetised the list of known config keys. This makes it easier to see if a particular key is in the list. Added "validation" to the list of known config keys. Compare: https://github.com/buildbot/buildbot/compare/5beba78...cdffd44 From noreply at github.com Sun Sep 25 15:24:50 2011 From: noreply at github.com (noreply at github.com) Date: Sun, 25 Sep 2011 08:24:50 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] c9fd4d: fix typo Message-ID: <20110925152450.6C53642642@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: c9fd4d2b5d071e7c6ba38f56c6b815bbaea6c305 https://github.com/buildbot/buildbot/commit/c9fd4d2b5d071e7c6ba38f56c6b815bbaea6c305 Author: Dustin J. Mitchell Date: 2011-09-25 (Sun, 25 Sep 2011) Changed paths: M master/docs/tutorial/tour.rst Log Message: ----------- fix typo Commit: 1fed964da6b1c15e409dacb6ce0c9585e3669f3c https://github.com/buildbot/buildbot/commit/1fed964da6b1c15e409dacb6ce0c9585e3669f3c Author: Dustin J. Mitchell Date: 2011-09-25 (Sun, 25 Sep 2011) Changed paths: M master/buildbot/status/words.py Log Message: ----------- fix error when forcing build from IRC with no properties defined (in tutorial) Compare: https://github.com/buildbot/buildbot/compare/cdffd44...1fed964 From nobody at buildbot.net Sun Sep 25 15:59:14 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 25 Sep 2011 15:59:14 -0000 Subject: [Buildbot-commits] [Buildbot] #2107: The Test BuildStep would be more useful with a failurePattern argument In-Reply-To: <041.1dc009a8017f923531af3cb579c24652@buildbot.net> References: <041.1dc009a8017f923531af3cb579c24652@buildbot.net> Message-ID: <056.4fe01c162863e07cbc3441c63dc2f57a@buildbot.net> #2107: The Test BuildStep would be more useful with a failurePattern argument ------------------------+------------------------ Reporter: ulfalizer | Owner: Type: enhancement | Status: new Priority: minor | Milestone: undecided Version: 0.8.4p2 | Resolution: Keywords: | ------------------------+------------------------ Changes (by dustin): * keywords: BuildStep Test => -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Sep 25 16:00:03 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 25 Sep 2011 16:00:03 -0000 Subject: [Buildbot-commits] [Buildbot] #1942: Store passwords in hashed form In-Reply-To: <041.ab8723608c9e5208d80dd1a487892b28@buildbot.net> References: <041.ab8723608c9e5208d80dd1a487892b28@buildbot.net> Message-ID: <056.c2b08f3a8f049c24cbb7baefd9073cfb@buildbot.net> #1942: Store passwords in hashed form ------------------------+-------------------- Reporter: dabrahams | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.3p1 | Resolution: Keywords: | ------------------------+-------------------- Changes (by dustin): * keywords: redheaphones => -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Sep 25 16:00:11 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 25 Sep 2011 16:00:11 -0000 Subject: [Buildbot-commits] [Buildbot] #2048: Also adding 'committer' to interested users for MailNotifier In-Reply-To: <036.ddab455e872e0cf7c0f4c1546cd25fe3@buildbot.net> References: <036.ddab455e872e0cf7c0f4c1546cd25fe3@buildbot.net> Message-ID: <051.6edabe83aaa6b060a2b4b7007231c1c0@buildbot.net> #2048: Also adding 'committer' to interested users for MailNotifier ------------------------+-------------------- Reporter: deng | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.+ Version: 0.8.4p1 | Resolution: Keywords: | ------------------------+-------------------- Changes (by dustin): * keywords: redheadphones => -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Sep 25 16:00:13 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 25 Sep 2011 16:00:13 -0000 Subject: [Buildbot-commits] [Buildbot] #1848: Cookies to remember web usernames In-Reply-To: <041.c7ad4e6001681bf1a08277684316ffbb@buildbot.net> References: <041.c7ad4e6001681bf1a08277684316ffbb@buildbot.net> Message-ID: <056.df461b3386d4eb38ad2b29d495c7a34a@buildbot.net> #1848: Cookies to remember web usernames ------------------------+-------------------- Reporter: dabrahams | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.+ Version: 0.8.3p1 | Resolution: Keywords: web | ------------------------+-------------------- Changes (by dustin): * keywords: web, readheadphones => web -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sun Sep 25 16:38:16 2011 From: noreply at github.com (noreply at github.com) Date: Sun, 25 Sep 2011 09:38:16 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] d25d04: bail out early if mock isn't installed Message-ID: <20110925163816.CE59A425F3@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: d25d04ad17babbbcf1bc6070f6419f684bc07286 https://github.com/buildbot/buildbot/commit/d25d04ad17babbbcf1bc6070f6419f684bc07286 Author: Dustin J. Mitchell Date: 2011-09-25 (Sun, 25 Sep 2011) Changed paths: M master/buildbot/test/__init__.py M master/setup.py M slave/buildslave/test/__init__.py Log Message: ----------- bail out early if mock isn't installed but don't add it to test_requires, as easy_install gets confused by that. From noreply at github.com Sun Sep 25 20:06:24 2011 From: noreply at github.com (noreply at github.com) Date: Sun, 25 Sep 2011 13:06:24 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] b58d24: update version reqs for sqlalchemy-migrate Message-ID: <20110925200624.8D58842593@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: b58d24a109e8a71f3da7b78ca995e4831009cb40 https://github.com/buildbot/buildbot/commit/b58d24a109e8a71f3da7b78ca995e4831009cb40 Author: Dustin J. Mitchell Date: 2011-09-25 (Sun, 25 Sep 2011) Changed paths: M master/docs/manual/installation.rst Log Message: ----------- update version reqs for sqlalchemy-migrate From noreply at github.com Sun Sep 25 21:06:29 2011 From: noreply at github.com (noreply at github.com) Date: Sun, 25 Sep 2011 14:06:29 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] dd3ee2: remove unnecessary double-@ (holdover from texinfo... Message-ID: <20110925210629.7A63C42540@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: dd3ee266e176967e5a7f986e85f089832e07cef9 https://github.com/buildbot/buildbot/commit/dd3ee266e176967e5a7f986e85f089832e07cef9 Author: Dustin J. Mitchell Date: 2011-09-25 (Sun, 25 Sep 2011) Changed paths: M master/docs/manual/cfg-buildslaves.rst M master/docs/manual/cfg-buildsteps.rst M master/docs/manual/cfg-changesources.rst M master/docs/manual/cfg-global.rst M master/docs/manual/customization.rst M master/docs/manual/installation.rst Log Message: ----------- remove unnecessary double-@ (holdover from texinfo) From noreply at github.com Mon Sep 26 00:47:34 2011 From: noreply at github.com (noreply at github.com) Date: Sun, 25 Sep 2011 17:47:34 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] aaa88d: remove unused code Message-ID: <20110926004734.B92E14258C@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: aaa88d12925576d37e01b28460a7c7d3b632cf0b https://github.com/buildbot/buildbot/commit/aaa88d12925576d37e01b28460a7c7d3b632cf0b Author: Dustin J. Mitchell Date: 2011-09-25 (Sun, 25 Sep 2011) Changed paths: M master/buildbot/status/build.py M master/buildbot/status/builder.py M master/buildbot/status/master.py Log Message: ----------- remove unused code From noreply at github.com Mon Sep 26 20:48:01 2011 From: noreply at github.com (noreply at github.com) Date: Mon, 26 Sep 2011 13:48:01 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 5795d1: replace old path with something generic Message-ID: <20110926204801.889B742746@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 5795d11d0020da94aa052c7dd7ce2991209b0474 https://github.com/buildbot/buildbot/commit/5795d11d0020da94aa052c7dd7ce2991209b0474 Author: Dustin J. Mitchell Date: 2011-09-26 (Mon, 26 Sep 2011) Changed paths: M master/docs/manual/installation.rst Log Message: ----------- replace old path with something generic From nobody at buildbot.net Tue Sep 27 00:33:31 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 27 Sep 2011 00:33:31 -0000 Subject: [Buildbot-commits] [Buildbot] #2105: Mercurial hook - exceptions.ValueError: signal only works in main thread In-Reply-To: <039.ae0e754847623a7d7fd8839cdfcb6097@buildbot.net> References: <039.ae0e754847623a7d7fd8839cdfcb6097@buildbot.net> Message-ID: <054.8e8a49f0f8795ff2e1f3cd5ec8f0f4eb@buildbot.net> #2105: Mercurial hook - exceptions.ValueError: signal only works in main thread --------------------+-------------------- Reporter: jpichon | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.6 Version: 0.8.4p2 | Resolution: Keywords: hg | --------------------+-------------------- Comment (by hsorby): Replying to [comment:3 jpichon]: > Have you taken a look at your process list after doing this? When I started using "fork" I ended up with a lot of defunct processes (children of Mercurial, one for every push) that wouldn't disappear until Mercurial is restarted. I only left them hanging a few hours, so perhaps they do go away after a while. No I hadn't but I have now thanks for pointing this out. Yes I do get zombie processes lying around. I can live with this for the mean time, I am just running hg serve on my local machine and I have not shifted it onto a proper web server. I probably won't shift until this is fixed. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Tue Sep 27 00:37:01 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 27 Sep 2011 00:37:01 -0000 Subject: [Buildbot-commits] [Buildbot] #2105: Mercurial hook - exceptions.ValueError: signal only works in main thread In-Reply-To: <039.ae0e754847623a7d7fd8839cdfcb6097@buildbot.net> References: <039.ae0e754847623a7d7fd8839cdfcb6097@buildbot.net> Message-ID: <054.a559d42471091d2ddc410712cc955746@buildbot.net> #2105: Mercurial hook - exceptions.ValueError: signal only works in main thread --------------------+-------------------- Reporter: jpichon | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.6 Version: 0.8.4p2 | Resolution: Keywords: hg | --------------------+-------------------- Comment (by hsorby): Replying to [comment:4 dustin]: I would like to see this change and hope that you continue to support mercurial. Is this something that could be changed from the mercurial side? Would it be easier to get mercurial not running this script in another thread? -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Tue Sep 27 18:20:32 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 27 Sep 2011 18:20:32 -0000 Subject: [Buildbot-commits] [Buildbot] #2115: Periodic builder stops being assigned to slave Message-ID: <039.dda1ee489ce00f326587aa5fdf61b238@buildbot.net> #2115: Periodic builder stops being assigned to slave --------------------+----------------------- Reporter: ajdavis | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.4p1 | Keywords: --------------------+----------------------- Maybe related to #85: I have a single master and single slave, and 4 once- per-minute periodic builds. The master and slave have been running for a few days, and at some point ONE of the periodic builds stopped being assigned (I think that's the problem), while the other 3 builds are continuing once per minute as normal. Pending builds for the builder (called "send_confirmation_emails_and_smses") have stacked up so that there are thousands pending. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Tue Sep 27 18:54:12 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 27 Sep 2011 18:54:12 -0000 Subject: [Buildbot-commits] [Buildbot] #2115: Periodic builder stops being assigned to slave In-Reply-To: <039.dda1ee489ce00f326587aa5fdf61b238@buildbot.net> References: <039.dda1ee489ce00f326587aa5fdf61b238@buildbot.net> Message-ID: <054.345df4aca5df5a333211ceeabe8ba376@buildbot.net> #2115: Periodic builder stops being assigned to slave --------------------+------------------------ Reporter: ajdavis | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.4p1 | Resolution: Keywords: | --------------------+------------------------ Comment (by ajdavis): sudo /etc/init.d/buildbot restart fixes the problem for now. I may write a cron job to restart buildbot nightly. Who watches the watchmen? -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Tue Sep 27 19:49:50 2011 From: noreply at github.com (noreply at github.com) Date: Tue, 27 Sep 2011 12:49:50 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 58552a: added missing grave accent in the Command-line Too... Message-ID: <20110927194950.467C4425C6@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 58552ae45f3ebd4fb04ddc0950cb0c58ff0a5474 https://github.com/buildbot/buildbot/commit/58552ae45f3ebd4fb04ddc0950cb0c58ff0a5474 Author: Micha? ?rajer Date: 2011-09-27 (Tue, 27 Sep 2011) Changed paths: M master/docs/manual/cmdline.rst Log Message: ----------- added missing grave accent in the Command-line Tool Manual Commit: 747483fb0981e7066ced96e3afe29f370487ce19 https://github.com/buildbot/buildbot/commit/747483fb0981e7066ced96e3afe29f370487ce19 Author: Amber Yust Date: 2011-09-27 (Tue, 27 Sep 2011) Changed paths: M master/docs/manual/cmdline.rst Log Message: ----------- Merge pull request #252 from michals/master Typo in the documentation. Compare: https://github.com/buildbot/buildbot/compare/5795d11...747483f From nobody at buildbot.net Tue Sep 27 23:20:55 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 27 Sep 2011 23:20:55 -0000 Subject: [Buildbot-commits] [Buildbot] #2116: gitpoller does not pass environment to git commands Message-ID: <040.6de817dbc72f64ce2ed53e923fef5b3b@buildbot.net> #2116: gitpoller does not pass environment to git commands ---------------------+---------------------------- Reporter: msabramo | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: master | Keywords: gitpoller, git ---------------------+---------------------------- The problem is that gitpoller does not pass the environment to git commands. This is problematic when you have a git repository that is accessed over ssh using an ssh key with a passphrase and you use ssh-agent to cache the keys. In this case, gitpoller does not pass the {{{SSH_AGENT_PID}}} and {{{SSH_AUTH_SOCK}}} environment variables so the git commands to pull down the repo will fail with errors like: {{{ Failure: twisted.internet.utils._UnexpectedErrorOutput: got stderr: "fatal: ambiguous argument 'master..origin/master': unknown revision or path not in the working tree.\nUse '--' to separate paths from revisions\n" }}} I modified my buildbot locally to fix this issue and will send a GitHub pull request momentarily. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Tue Sep 27 23:44:54 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 27 Sep 2011 23:44:54 -0000 Subject: [Buildbot-commits] [Buildbot] #2116: gitpoller does not pass environment to git commands In-Reply-To: <040.6de817dbc72f64ce2ed53e923fef5b3b@buildbot.net> References: <040.6de817dbc72f64ce2ed53e923fef5b3b@buildbot.net> Message-ID: <055.af98da85fc8f0443ad4c9449e4d22342@buildbot.net> #2116: gitpoller does not pass environment to git commands ---------------------------+------------------------ Reporter: msabramo | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: master | Resolution: Keywords: gitpoller, git | ---------------------------+------------------------ Comment (by msabramo): Pull request: https://github.com/buildbot/buildbot/pull/254 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Tue Sep 27 23:45:54 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 27 Sep 2011 23:45:54 -0000 Subject: [Buildbot-commits] [Buildbot] #2116: gitpoller does not pass environment to git commands In-Reply-To: <040.6de817dbc72f64ce2ed53e923fef5b3b@buildbot.net> References: <040.6de817dbc72f64ce2ed53e923fef5b3b@buildbot.net> Message-ID: <055.7c7e2e4ce5fa97aa00f4a098f7a92c66@buildbot.net> #2116: gitpoller does not pass environment to git commands ---------------------------+------------------------ Reporter: msabramo | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: master | Resolution: Keywords: gitpoller, git | ---------------------------+------------------------ Changes (by msabramo): * cc: msabramo@? (added) -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Sep 28 21:03:12 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 28 Sep 2011 21:03:12 -0000 Subject: [Buildbot-commits] [Buildbot] #2117: Error when forcing build through IRC Message-ID: <040.bb530d01f9c571028d64b88e49e55099@buildbot.net> #2117: Error when forcing build through IRC ---------------------+----------------------- Reporter: lotodore | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.4p2 | Keywords: ---------------------+----------------------- After updating to 0.8.5, I got an error when forcing a build through IRC. The error looks like this on IRC: [22:29:58] build: force build proj [22:29:58] Something bad happened (see logs): The twistd log file shows an error like this: http://pastebin.com/48RPbbV1 A workaround, as explained by djmitche on IRC, is to change the line which causes the error (buildbot/status/words.py, line 524, in command_FORCE) to d = bc.submitBuildRequest(ss, reason) (i.e. deleting the props= from that line). -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Thu Sep 29 19:37:25 2011 From: nobody at buildbot.net (Buildbot) Date: Thu, 29 Sep 2011 19:37:25 -0000 Subject: [Buildbot-commits] [Buildbot] #2118: one-page html docs don't link to full.html Message-ID: <038.71ec7cedfcbde374c51682346354142c@buildbot.net> #2118: one-page html docs don't link to full.html --------------------+------------------- Reporter: dustin | Owner: Type: defect | Status: new Priority: minor | Milestone: 0.8.6 Version: 0.8.4p2 | Keywords: docs --------------------+------------------- They have links to index.html#anchorname, which doesn't work. Maybe that can be fixed with a simple regex? -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Thu Sep 29 21:44:55 2011 From: nobody at buildbot.net (Buildbot) Date: Thu, 29 Sep 2011 21:44:55 -0000 Subject: [Buildbot-commits] [Buildbot] #2108: BuildBot uses incorrect method for default location of Visual Studios In-Reply-To: <045.85ed2bd6655c4fd7b0274987c6dd1583@buildbot.net> References: <045.85ed2bd6655c4fd7b0274987c6dd1583@buildbot.net> Message-ID: <060.226d0c9dd9a03e6ae347133ff6711db1@buildbot.net> #2108: BuildBot uses incorrect method for default location of Visual Studios --------------------------+-------------------- Reporter: TemporalBeing | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.+ Version: 0.8.5 | Resolution: Keywords: windows | --------------------------+-------------------- Comment (by TemporalBeing): Yes I'll give it a shot. Already have something partially done that I need to test for the registry access. That'll be one patch. Then I'll try to update the VS stuff to use it as another patch. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Sep 30 17:58:24 2011 From: nobody at buildbot.net (Buildbot) Date: Fri, 30 Sep 2011 17:58:24 -0000 Subject: [Buildbot-commits] [Buildbot] #2119: upgrade-master sets auto-increment counters for id fields incorrectly in postgresql Message-ID: <038.b0cda045808f9a229824b84613d32f05@buildbot.net> #2119: upgrade-master sets auto-increment counters for id fields incorrectly in postgresql --------------------+----------------------- Reporter: szager | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.4p1 | Keywords: --------------------+----------------------- When upgrading master database from 0.7.12 to 0.8.4p1, and creating the new database in postgresql, some of the tables have an 'id' field that uses an auto-increment counter to get a value for newly-added rows; something like this: CREATE TABLE changes ( changeid PRIMARY KEY DEFAULT nextval('changes_changeid_seq'), ... ); The problem is that the state of the counter is set incorrectly after the upgrade. For example, I upgraded a database that had 775 change records. The imported change records had the expected sequential changeid values 1-775, but the 'last_value' field of the changes_changeid_seq counter was 20, rather than the expected 775. I have seen this in the changes.changeid field and the build.id field. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Fri Sep 30 19:35:38 2011 From: noreply at github.com (noreply at github.com) Date: Fri, 30 Sep 2011 12:35:38 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] f49d9e: Add tests that check that environment variables ar... Message-ID: <20110930193538.5EBAB42554@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: f49d9e90cc4ffa1ce4e90f283a396c4866a08ee0 https://github.com/buildbot/buildbot/commit/f49d9e90cc4ffa1ce4e90f283a396c4866a08ee0 Author: Marc Abramowitz Date: 2011-09-30 (Fri, 30 Sep 2011) Changed paths: M master/buildbot/test/unit/test_changes_gitpoller.py M master/buildbot/test/util/gpo.py Log Message: ----------- Add tests that check that environment variables are propagated. Commit: 81eb07625d43c275584eae190d90b33f5da51050 https://github.com/buildbot/buildbot/commit/81eb07625d43c275584eae190d90b33f5da51050 Author: Marc Abramowitz Date: 2011-09-30 (Fri, 30 Sep 2011) Changed paths: M master/buildbot/changes/gitpoller.py Log Message: ----------- When calling external git commands, pass the environment so that crucial environment variables like SSH_AGENT_PID and SSH_AUTH_SOCK get propagated. Otherwise, buildbot will not be able to make use of ssh keys with passphrases that are cached by ssh-agent. Commit: 8d9377d845fdfa33385b68406b079fba84f591d7 https://github.com/buildbot/buildbot/commit/8d9377d845fdfa33385b68406b079fba84f591d7 Author: Amber Yust Date: 2011-09-30 (Fri, 30 Sep 2011) Changed paths: M master/buildbot/changes/gitpoller.py M master/buildbot/test/unit/test_changes_gitpoller.py M master/buildbot/test/util/gpo.py Log Message: ----------- Merge pull request #255 from msabramo/gitpoller_propagate_env_to_git_2116_2 Gitpoller propagate env to git 2116 attempt #2 Compare: https://github.com/buildbot/buildbot/compare/747483f...8d9377d From nobody at buildbot.net Fri Sep 30 20:58:35 2011 From: nobody at buildbot.net (Buildbot) Date: Fri, 30 Sep 2011 20:58:35 -0000 Subject: [Buildbot-commits] [Buildbot] #2116: gitpoller does not pass environment to git commands In-Reply-To: <040.6de817dbc72f64ce2ed53e923fef5b3b@buildbot.net> References: <040.6de817dbc72f64ce2ed53e923fef5b3b@buildbot.net> Message-ID: <055.05e01c786c639bedab9c64f1236cbea6@buildbot.net> #2116: gitpoller does not pass environment to git commands ---------------------------+------------------------ Reporter: msabramo | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: master | Resolution: Keywords: gitpoller, git | ---------------------------+------------------------ Comment (by msabramo): New and improved pull request: https://github.com/buildbot/buildbot/pull/255 -- Ticket URL: Buildbot Buildbot: build/test automation