[Buildbot-commits] [Buildbot] #2122: Race condition causes error describing step

[Buildbot]

#2122: Race condition causes error describing step
-------------------+-----------------------
Reporter:  tmidd   |      Owner:
    Type:  defect  |     Status:  new
Priority:  minor   |  Milestone:  undecided
 Version:  0.8.5   |   Keywords:
-------------------+-----------------------
 Not sure on the details, but it seems that sometimes when the waterfall
 page is refreshed it causes the following exception in twistd.log (and one
 of the commands on the waterfall just shows '???'). It seems to be some
 kind of race condition, since most of the time the same command will
 display normally and not generate an exception. As suggested in the
 traceback, the command uses WithProperties... I don't know how those are
 actually handled, but at a guess something is meant to parse it into a
 string before describe is called? Let me know if you need any further
 info.

 {{{
 2011-10-05 14:06:07+1300 [-] Error describing step
         Traceback (most recent call last):
           File "/usr/local/lib/python2.6/dist-
 packages/buildbot-0.8.5-py2.6.egg/buildbot/process/build.py", line 389, in
 _stepDone
             return self.startNextStep()
           File "/usr/local/lib/python2.6/dist-
 packages/buildbot-0.8.5-py2.6.egg/buildbot/process/build.py", line 378, in
 startNextStep
             d = defer.maybeDeferred(s.startStep, self.remote)
           File "/usr/local/lib/python2.6/dist-
 packages/Twisted-11.0.0-py2.6-linux-x86_64.egg/twisted/internet/defer.py",
 line 133, in maybeDeferred
             result = f(*args, **kw)
           File "/usr/local/lib/python2.6/dist-
 packages/buildbot-0.8.5-py2.6.egg/buildbot/process/buildstep.py", line
 514, in startStep
             self.step_status.setText(self.describe(False))
         --- <exception caught here> ---
           File "/usr/local/lib/python2.6/dist-
 packages/buildbot-0.8.5-py2.6.egg/buildbot/steps/shell.py", line 173, in
 describe
             if len(words) < 1:
         exceptions.AttributeError: WithProperties instance has no
 attribute '__len__'
 }}}

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2122>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation