From noreply at github.com Sat Oct 1 17:14:24 2011 From: noreply at github.com (noreply at github.com) Date: Sat, 1 Oct 2011 10:14:24 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 490e6f: fixes a bug in bzr_buildbot.py. Message-ID: <20111001171424.99450427B9@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 490e6f38eac0769ae145e655ccaa697ea3547acc https://github.com/buildbot/buildbot/commit/490e6f38eac0769ae145e655ccaa697ea3547acc Author: Andreas Lawitzky Date: 2011-10-01 (Sat, 01 Oct 2011) Changed paths: M master/contrib/bzr_buildbot.py Log Message: ----------- fixes a bug in bzr_buildbot.py. The bug has been discussed in #buildbot and #bzr on IRC. The call to get_apparent_author() changed to get_apparent_authors()[0] since the Bazaar API changed and returns now a list of authors. get_apparent_author() is not part of the API anymore. This simply uses the first list entry of the authors list. Commit: b4bee54c77e730260d337d5e7e6e3826f75e1909 https://github.com/buildbot/buildbot/commit/b4bee54c77e730260d337d5e7e6e3826f75e1909 Author: Amber Yust Date: 2011-10-01 (Sat, 01 Oct 2011) Changed paths: M master/contrib/bzr_buildbot.py Log Message: ----------- Merge pull request #256 from televator/myfixes fixes a bug in bzr_buildbot.py. Compare: https://github.com/buildbot/buildbot/compare/8d9377d...b4bee54 From noreply at github.com Sat Oct 1 23:56:19 2011 From: noreply at github.com (noreply at github.com) Date: Sat, 1 Oct 2011 16:56:19 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] dc63ce: Fix cancel_pending_build template Message-ID: <20111001235619.12008426DC@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: dc63ce030fc5156cb84ad44516a6db6ae0238851 https://github.com/buildbot/buildbot/commit/dc63ce030fc5156cb84ad44516a6db6ae0238851 Author: Patrick Gansterer Date: 2011-10-01 (Sat, 01 Oct 2011) Changed paths: M master/buildbot/status/web/templates/forms.html Log Message: ----------- Fix cancel_pending_build template Compare id with 'all' since the parameter on_all has been removed. Make output message about how to cancel an individual build independet of authz.needAuthForm(). Commit: 1fc4cb967654f7ae5ac4322dab316d8546d160e2 https://github.com/buildbot/buildbot/commit/1fc4cb967654f7ae5ac4322dab316d8546d160e2 Author: Patrick Gansterer Date: 2011-10-01 (Sat, 01 Oct 2011) Changed paths: M master/buildbot/status/web/templates/forms.html M master/docs/developer/webstatus.rst Log Message: ----------- Unify generation of auth form When used without authentication some actions generate "... button was pressed by ''" messages only, since they don't provide a form for entering the name. Change forms.html to show a form for the username at all places where authentication is possible. Commit: 1059420435083c830c9838bcefa24017b153b02f https://github.com/buildbot/buildbot/commit/1059420435083c830c9838bcefa24017b153b02f Author: Amber Yust Date: 2011-10-01 (Sat, 01 Oct 2011) Changed paths: M master/buildbot/status/web/templates/forms.html M master/docs/developer/webstatus.rst Log Message: ----------- Merge pull request #257 from paroga/auth_form Auth form Compare: https://github.com/buildbot/buildbot/compare/b4bee54...1059420 From nobody at buildbot.net Mon Oct 3 05:15:00 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 03 Oct 2011 05:15:00 -0000 Subject: [Buildbot-commits] [Buildbot] #2120: TextLog.getChild broken Message-ID: <038.7a9bbf7a5e4088c5c983e02584a2d1f5@buildbot.net> #2120: TextLog.getChild broken -------------------+----------------------- Reporter: szager | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: master | Keywords: -------------------+----------------------- In master/buildbot/status/web/logs.py, this looks fishy to me: class TextLog(Resource): .... def getChild(self, path, req): if path == "text": self.asText = True return self return HtmlResource.getChild(self, path, req) As you can see, TextLog doesn't inherit from HtmlResource, so the call to HtmlResource.getChild is broken. Indeed, when I hit that code path, I get this exception: in getChild return HtmlResource.getChild(self, path, req) exceptions.TypeError: unbound method getChild() must be called with HtmlResource instance as first argument (got TextLog instance instead) I believe this ought to fix it: index cb201bf..79b953a 100644 --- a/master/buildbot/status/web/logs.py +++ b/master/buildbot/status/web/logs.py @@ -65,7 +65,7 @@ class TextLog(Resource): if path == "text": self.asText = True return self - return HtmlResource.getChild(self, path, req) + return Resource.getChild(self, path, req) def content(self, entries): html_entries = [] Thanks, Stefan -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Oct 3 13:06:52 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 03 Oct 2011 13:06:52 -0000 Subject: [Buildbot-commits] [Buildbot] #438: Mercurial does not update to the right revision when building a tag from a named branch In-Reply-To: <041.981e251e2d06093a72516dffe4ddcfc5@buildbot.net> References: <041.981e251e2d06093a72516dffe4ddcfc5@buildbot.net> Message-ID: <056.2ed580e412a12380d9165b866a2d4e1c@buildbot.net> #438: Mercurial does not update to the right revision when building a tag from a named branch ----------------------+------------------------ Reporter: cdevienne | Owner: Type: defect | Status: reopened Priority: major | Milestone: undecided Version: 0.8.5 | Resolution: Keywords: | ----------------------+------------------------ Changes (by marcusl): * status: closed => reopened * version: 0.7.10 => 0.8.5 * resolution: worksforme => Comment: This happens again in 0.8.5. * I press "Force build" with revision set to "v0.2.1" * Slave does {{{'hg.EXE' 'clone' '--verbose' '--noupdate' '--rev' u'v0.2.1' '' 'build'}}} which gets the rev, but misses the changeset that created the tag * Then it tries to update to tag {{{'hg.EXE' 'update' '--clean' '-- repository' 'build' '--rev' u'v0.2.1'}}} and fails with: > **abort: unknown revision 'v0.2.1'! ** -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Tue Oct 4 04:18:12 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 04 Oct 2011 04:18:12 -0000 Subject: [Buildbot-commits] [Buildbot] #2105: Mercurial hook - exceptions.ValueError: signal only works in main thread In-Reply-To: <039.ae0e754847623a7d7fd8839cdfcb6097@buildbot.net> References: <039.ae0e754847623a7d7fd8839cdfcb6097@buildbot.net> Message-ID: <054.5f3bf812652d8cc66b4de7d01b8d9712@buildbot.net> #2105: Mercurial hook - exceptions.ValueError: signal only works in main thread --------------------+-------------------- Reporter: jpichon | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.6 Version: 0.8.4p2 | Resolution: Keywords: hg | --------------------+-------------------- Comment (by dustin): Oh, we'll definitely continue to support *Mercurial* - the question is, will the hook remain supported :) Yes, it would be easier to get mercurial to not run this script in another thread, or even in the same process space - best to fork and run it as a separate script. Mixing twisted's runtime libraries with mercurial's is really asking for trouble. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Tue Oct 4 04:42:55 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 04 Oct 2011 04:42:55 -0000 Subject: [Buildbot-commits] [Buildbot] #2115: Periodic builder stops being assigned to slave In-Reply-To: <039.dda1ee489ce00f326587aa5fdf61b238@buildbot.net> References: <039.dda1ee489ce00f326587aa5fdf61b238@buildbot.net> Message-ID: <054.56a0d020296946691fab746fcf4f92bf@buildbot.net> #2115: Periodic builder stops being assigned to slave --------------------+--------------------- Reporter: ajdavis | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.4 Version: 0.8.4p1 | Resolution: fixed Keywords: | --------------------+--------------------- Changes (by dustin): * status: new => closed * resolution: => fixed * milestone: undecided => 0.8.4 Comment: I'm missing how that chunk of twistd.log is relevant? It looks like it's *before* the last successful build? 0.8.4p1 had some problems with dropping build requests. Try 0.8.4p2, or even 0.8.5? Re-open with a changed version field if it's still failing the same way. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Tue Oct 4 04:49:22 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 04 Oct 2011 04:49:22 -0000 Subject: [Buildbot-commits] [Buildbot] #2117: Error when forcing build through IRC In-Reply-To: <040.bb530d01f9c571028d64b88e49e55099@buildbot.net> References: <040.bb530d01f9c571028d64b88e49e55099@buildbot.net> Message-ID: <055.0587b52dd1c1683fadfa3b0880619718@buildbot.net> #2117: Error when forcing build through IRC ---------------------+------------------------ Reporter: lotodore | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.4p2 | Resolution: Keywords: | ---------------------+------------------------ Comment (by dustin): Logfile in the pastebin is {{{ 2011-09-25 13:17:49+0200 [IrcStatusBot,client] Unhandled Error Traceback (most recent call last): File "/home/nohero/tmp/buildbot/sandbox/lib/python2.6/site- packages/twisted/words/protocols/irc.py", line 2305, in lineReceived self.handleCommand(command, prefix, params) File "/home/nohero/tmp/buildbot/sandbox/lib/python2.6/site- packages/twisted/words/protocols/irc.py", line 2349, in handleCommand method(prefix, params) File "/home/nohero/tmp/buildbot/sandbox/lib/python2.6/site- packages/twisted/words/protocols/irc.py", line 1833, in irc_PRIVMSG self.privmsg(user, channel, message) File "/home/nohero/tmp/buildbot/sandbox/lib/python2.6/site- packages/buildbot/status/words.py", line 864, in privmsg contact.handleMessage(message, user) --- --- File "/home/nohero/tmp/buildbot/sandbox/lib/python2.6/site- packages/buildbot/status/words.py", line 754, in handleMessage meth(args.strip(), who) File "/home/nohero/tmp/buildbot/sandbox/lib/python2.6/site- packages/buildbot/status/words.py", line 524, in command_FORCE d = bc.submitBuildRequest(ss, reason, props=properties.asDict()) exceptions.AttributeError: 'NoneType' object has no attribute 'asDict' }}} -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Tue Oct 4 04:51:05 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 04 Oct 2011 04:51:05 -0000 Subject: [Buildbot-commits] [Buildbot] #2117: Error when forcing build through IRC In-Reply-To: <040.bb530d01f9c571028d64b88e49e55099@buildbot.net> References: <040.bb530d01f9c571028d64b88e49e55099@buildbot.net> Message-ID: <055.a9497fe67198c1b9b9c580ad2e355026@buildbot.net> #2117: Error when forcing build through IRC ---------------------+--------------------- Reporter: lotodore | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.6 Version: 0.8.4p2 | Resolution: fixed Keywords: irc | ---------------------+--------------------- Changes (by dustin): * keywords: => irc * status: new => closed * resolution: => fixed * milestone: undecided => 0.8.6 Comment: {{{ commit 1fed964da6b1c15e409dacb6ce0c9585e3669f3c Author: Dustin J. Mitchell Date: Sun Sep 25 10:23:59 2011 -0500 fix error when forcing build from IRC with no properties defined (in tutorial) }}} -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Tue Oct 4 05:02:10 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 04 Oct 2011 05:02:10 -0000 Subject: [Buildbot-commits] [Buildbot] #2119: upgrade-master sets auto-increment counters for id fields incorrectly in postgresql In-Reply-To: <038.b0cda045808f9a229824b84613d32f05@buildbot.net> References: <038.b0cda045808f9a229824b84613d32f05@buildbot.net> Message-ID: <053.731491c92d8208c910b31c92e23d7167@buildbot.net> #2119: upgrade-master sets auto-increment counters for id fields incorrectly in postgresql ---------------------+-------------------- Reporter: szager | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.6 Version: 0.8.4p1 | Resolution: Keywords: database | ---------------------+-------------------- Changes (by dustin): * keywords: => database * milestone: undecided => 0.8.6 Comment: It would be great to have a test that can reproduce this. Off the top of my head, I can't see why this would happen. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Tue Oct 4 05:06:38 2011 From: noreply at github.com (noreply at github.com) Date: Mon, 3 Oct 2011 22:06:38 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] f019ab: Properly call the parent class of TextLog Message-ID: <20111004050638.339AA425EC@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: f019ab0cb80e14b3a3058907568ad1bfa723e392 https://github.com/buildbot/buildbot/commit/f019ab0cb80e14b3a3058907568ad1bfa723e392 Author: Dustin J. Mitchell Date: 2011-10-03 (Mon, 03 Oct 2011) Changed paths: M master/buildbot/status/web/logs.py Log Message: ----------- Properly call the parent class of TextLog Fixes #2120. From nobody at buildbot.net Tue Oct 4 05:06:45 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 04 Oct 2011 05:06:45 -0000 Subject: [Buildbot-commits] [Buildbot] #2120: TextLog.getChild broken In-Reply-To: <038.7a9bbf7a5e4088c5c983e02584a2d1f5@buildbot.net> References: <038.7a9bbf7a5e4088c5c983e02584a2d1f5@buildbot.net> Message-ID: <053.1436da5d87cdd0f93344476a421590cc@buildbot.net> #2120: TextLog.getChild broken -------------------+------------------------ Reporter: szager | Owner: Type: defect | Status: closed Priority: major | Milestone: undecided Version: master | Resolution: fixed Keywords: | -------------------+------------------------ Changes (by Dustin J. Mitchell): * status: new => closed * resolution: => fixed Comment: Properly call the parent class of TextLog Fixes #2120. Changeset: f019ab0cb80e14b3a3058907568ad1bfa723e392 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Tue Oct 4 15:30:35 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 04 Oct 2011 15:30:35 -0000 Subject: [Buildbot-commits] [Buildbot] #2115: Periodic builder stops being assigned to slave In-Reply-To: <039.dda1ee489ce00f326587aa5fdf61b238@buildbot.net> References: <039.dda1ee489ce00f326587aa5fdf61b238@buildbot.net> Message-ID: <054.fb801a389fd5d46cbe89ef7e331c7aba@buildbot.net> #2115: Periodic builder stops being assigned to slave --------------------+--------------------- Reporter: ajdavis | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.4 Version: 0.8.4p1 | Resolution: fixed Keywords: | --------------------+--------------------- Comment (by ajdavis): Thanks, I've upgraded to 0.8.5. We'll see. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Tue Oct 4 17:51:27 2011 From: noreply at github.com (noreply at github.com) Date: Tue, 4 Oct 2011 10:51:27 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 5828ad: replace iff with if (and only if) for non-math spe... Message-ID: <20111004175127.D824442524@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 5828ad8336d2a303cd493790b1fdc54f9bb27107 https://github.com/buildbot/buildbot/commit/5828ad8336d2a303cd493790b1fdc54f9bb27107 Author: Michael Stapelberg Date: 2011-10-04 (Tue, 04 Oct 2011) Changed paths: M master/contrib/git_buildbot.py Log Message: ----------- replace iff with if (and only if) for non-math speakers ;) Commit: d793fceb2104e2d7c59c3df6bb28a22ebc627952 https://github.com/buildbot/buildbot/commit/d793fceb2104e2d7c59c3df6bb28a22ebc627952 Author: Dustin J. Mitchell Date: 2011-10-04 (Tue, 04 Oct 2011) Changed paths: M master/contrib/git_buildbot.py Log Message: ----------- Merge pull request #258 from mstap/patch-1 Fixed a few comments (server:port instead of server:host, s/iff/if) Compare: https://github.com/buildbot/buildbot/compare/f019ab0...d793fce From noreply at github.com Tue Oct 4 19:32:11 2011 From: noreply at github.com (noreply at github.com) Date: Tue, 4 Oct 2011 12:32:11 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] e3c8fc: Fixed 1fc4cb967654f7ae5ac4322dab316d8546d160e2 Message-ID: <20111004193211.CB0AD42645@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: e3c8fc52daf62319bd781fd7b09acfff3f4702eb https://github.com/buildbot/buildbot/commit/e3c8fc52daf62319bd781fd7b09acfff3f4702eb Author: Patrick Gansterer Date: 2011-10-04 (Tue, 04 Oct 2011) Changed paths: M master/buildbot/status/web/templates/forms.html Log Message: ----------- Fixed 1fc4cb967654f7ae5ac4322dab316d8546d160e2 The else part of an if statement has been left in forms.html. Remove it. Commit: 139c4ca3c453391fbac941b01e92f7f22f43ca7d https://github.com/buildbot/buildbot/commit/139c4ca3c453391fbac941b01e92f7f22f43ca7d Author: Amber Yust Date: 2011-10-04 (Tue, 04 Oct 2011) Changed paths: M master/buildbot/status/web/templates/forms.html Log Message: ----------- Merge pull request #259 from paroga/forms Fixed 1fc4cb967654f7ae5ac4322dab316d8546d160e2 Compare: https://github.com/buildbot/buildbot/compare/d793fce...139c4ca From nobody at buildbot.net Tue Oct 4 23:35:47 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 04 Oct 2011 23:35:47 -0000 Subject: [Buildbot-commits] [Buildbot] #2121: Allow limited-scope Perforce checkouts Message-ID: <038.2d3e83e9c8fe3c7a2852341a9be765e7@buildbot.net> #2121: Allow limited-scope Perforce checkouts ----------------------+----------------------- Reporter: gmcnew | Owner: Type: undecided | Status: new Priority: major | Milestone: undecided Version: 0.8.4p2 | Keywords: p4 ----------------------+----------------------- I use Buildbot for projects stored in Perforce, and it works great. However, our builds require one's clientspec to span hundreds of gigabytes of data, very small portions of which may be synced during the build. You're probably wondering, "Why do your builds need to do that?" I could provide more detail, but it's complicated, proprietary, and, most importantly, out of my control. Sorry. The default behavior of a [http://buildbot.net/buildbot/docs/current/manual/cfg- buildsteps.html#step-P4%20%28Slave-Side%29 P4 sync step] is to sync everything in the clientspec. However, this simply does not work for me, because the clientspec is far too broad. As a workaround, I've hacked my Buildbot slaves' [https://github.com/buildbot/buildbot/blob/master/slave/buildslave/commands/p4.py p4.py] to only sync p4base, rather than everything in my clientspec. This works fine, but I'd really love similar functionality to be in Buildbot proper so my coworkers and I won't have to hack Buildbot's code every time we install it. '''I'll be happy to write and test a patch for this.''' Mostly I'd like a little feedback to figure out: 1. the best way to implement this 2. whether a patch would have a chance of actually being mainlined My first instinct would be to add an optional "p4sync" argument to P4(). The value would be a [http://www.perforce.com/perforce/doc.current/manuals/cmdref/o.fspecs.html Perforce filespec] (example: "!//depot/path/to/sync/..."). If supplied, P4._doP4Sync() would pass this string verbatim to "p4 sync" to limit the scope of the sync. If not supplied, nothing would change -- the entire clientspec would be synced, as before. Thoughts? -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Oct 5 01:27:44 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 05 Oct 2011 01:27:44 -0000 Subject: [Buildbot-commits] [Buildbot] #2122: Race condition causes error describing step Message-ID: <037.bae614ef17847763cea74c9cb0e1a868@buildbot.net> #2122: Race condition causes error describing step -------------------+----------------------- Reporter: tmidd | Owner: Type: defect | Status: new Priority: minor | Milestone: undecided Version: 0.8.5 | Keywords: -------------------+----------------------- Not sure on the details, but it seems that sometimes when the waterfall page is refreshed it causes the following exception in twistd.log (and one of the commands on the waterfall just shows '???'). It seems to be some kind of race condition, since most of the time the same command will display normally and not generate an exception. As suggested in the traceback, the command uses WithProperties... I don't know how those are actually handled, but at a guess something is meant to parse it into a string before describe is called? Let me know if you need any further info. {{{ 2011-10-05 14:06:07+1300 [-] Error describing step Traceback (most recent call last): File "/usr/local/lib/python2.6/dist- packages/buildbot-0.8.5-py2.6.egg/buildbot/process/build.py", line 389, in _stepDone return self.startNextStep() File "/usr/local/lib/python2.6/dist- packages/buildbot-0.8.5-py2.6.egg/buildbot/process/build.py", line 378, in startNextStep d = defer.maybeDeferred(s.startStep, self.remote) File "/usr/local/lib/python2.6/dist- packages/Twisted-11.0.0-py2.6-linux-x86_64.egg/twisted/internet/defer.py", line 133, in maybeDeferred result = f(*args, **kw) File "/usr/local/lib/python2.6/dist- packages/buildbot-0.8.5-py2.6.egg/buildbot/process/buildstep.py", line 514, in startStep self.step_status.setText(self.describe(False)) --- --- File "/usr/local/lib/python2.6/dist- packages/buildbot-0.8.5-py2.6.egg/buildbot/steps/shell.py", line 173, in describe if len(words) < 1: exceptions.AttributeError: WithProperties instance has no attribute '__len__' }}} -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Wed Oct 5 02:21:44 2011 From: noreply at github.com (noreply at github.com) Date: Tue, 4 Oct 2011 19:21:44 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 1eaaf8: Merge branch 'username' of git://github.com/paroga... Message-ID: <20111005022144.99E6742698@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 1eaaf8b9f385be33534079fbb4ebae9af6a27979 https://github.com/buildbot/buildbot/commit/1eaaf8b9f385be33534079fbb4ebae9af6a27979 Author: Dustin J. Mitchell Date: 2011-10-04 (Tue, 04 Oct 2011) Changed paths: M master/buildbot/status/web/authz.py M master/buildbot/status/web/build.py M master/buildbot/status/web/builder.py M master/buildbot/test/unit/test_status_web_authz_Authz.py Log Message: ----------- Merge branch 'username' of git://github.com/paroga/buildbot * 'username' of git://github.com/paroga/buildbot: Unify username handling From nobody at buildbot.net Wed Oct 5 02:31:45 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 05 Oct 2011 02:31:45 -0000 Subject: [Buildbot-commits] [Buildbot] #438: Mercurial does not update to the right revision when building a tag from a named branch In-Reply-To: <041.981e251e2d06093a72516dffe4ddcfc5@buildbot.net> References: <041.981e251e2d06093a72516dffe4ddcfc5@buildbot.net> Message-ID: <056.da2462130ed3d2bf77529dd3faca3a8c@buildbot.net> #438: Mercurial does not update to the right revision when building a tag from a named branch ----------------------+------------------------ Reporter: cdevienne | Owner: Type: defect | Status: reopened Priority: major | Milestone: undecided Version: 0.8.5 | Resolution: Keywords: | ----------------------+------------------------ Comment (by dustin): Marcus, what command *should* it run? It seems like the --rev should do the trick, right? -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Oct 5 03:20:36 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 05 Oct 2011 03:20:36 -0000 Subject: [Buildbot-commits] [Buildbot] #2123: Changes sent over the wire should be compressed Message-ID: <036.8cceb3fe6a6edabb86fbef518ee3826f@buildbot.net> #2123: Changes sent over the wire should be compressed ------------------------+----------------------- Reporter: dank | Owner: Type: enhancement | Status: new Priority: minor | Milestone: undecided Version: 0.8.5 | Keywords: ------------------------+----------------------- There is currently an arbitrary 640KB limit on the size of changes, imposed by twisted.spread.banana.SIZE_LIMIT, see http://twistedmatrix.com/documents/current/core/howto/pb-limits.html This becomes a problem when patches are sent that replace large components (see e.g. the nine patch series at http://www.winehq.org/pipermail/wine-patches/2011-September/107181.html, which, when concatenated to be submitted as a try, hits about 900KB. ) Either that limit needs to be raised or removed, or changes should be compressed, or both. On slow links, compression would be a big win. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Oct 5 04:52:07 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 05 Oct 2011 04:52:07 -0000 Subject: [Buildbot-commits] [Buildbot] #296: should have a way of running builds after X seconds of idle In-Reply-To: <040.ea708353268e803375c01ee12e90e8fb@buildbot.net> References: <040.ea708353268e803375c01ee12e90e8fb@buildbot.net> Message-ID: <055.68c1a25153f1104d746f060b4f6fefef@buildbot.net> #296: should have a way of running builds after X seconds of idle ------------------------+-------------------- Reporter: bhearsum | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: 0.7.7 | Resolution: Keywords: | ------------------------+-------------------- Comment (by dank): I could use an idleScheduler to scrub trunk for flaky tests while I wait for try jobs to be submitted... running a scrub job every N minutes isn't optimal, either it doesn't build as often as it could, or it gets in the way of try jobs. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Oct 5 17:25:15 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 05 Oct 2011 17:25:15 -0000 Subject: [Buildbot-commits] [Buildbot] #2121: Allow limited-scope Perforce checkouts In-Reply-To: <038.2d3e83e9c8fe3c7a2852341a9be765e7@buildbot.net> References: <038.2d3e83e9c8fe3c7a2852341a9be765e7@buildbot.net> Message-ID: <053.397fe3ded59d9a4d0fd10415da387198@buildbot.net> #2121: Allow limited-scope Perforce checkouts ----------------------+------------------------ Reporter: gmcnew | Owner: Type: undecided | Status: new Priority: major | Milestone: undecided Version: 0.8.4p2 | Resolution: Keywords: p4 | ----------------------+------------------------ Comment (by fcrestois): I started long time ago like you, after a string, I was passing an array of workspace line, quickly I let the slave creating (and updating) the workspace client view and starting to manage the exclusion (-) , at the end, most of the change on the master.cfg was to change workspaces views. It?s why now I use only one line description (no more restart of the master) The location of the p4s file (p4 client ?o) in perforce p4sync(?//depot/project/project.p4s?) I use also this argument to ?p4scheduler? the builder only if the changed files map in the workspace view. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Thu Oct 6 00:38:33 2011 From: nobody at buildbot.net (Buildbot) Date: Thu, 06 Oct 2011 00:38:33 -0000 Subject: [Buildbot-commits] [Buildbot] #498: IRC client fails to reconnect after IP change. In-Reply-To: <040.96a75f3f7053d12dc05c793924522fe3@buildbot.net> References: <040.96a75f3f7053d12dc05c793924522fe3@buildbot.net> Message-ID: <055.a151406d2be6f1b0a1dbcce4715ca7d3@buildbot.net> #498: IRC client fails to reconnect after IP change. ---------------------+-------------------- Reporter: ipv6guru | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.+ Version: 0.7.10 | Resolution: Keywords: irc | ---------------------+-------------------- Comment (by tom.prince): A data point: So, my irc bot stopped being connected, and didn't reconnect. I went into the manhole, and it thought it was still connected. Then I poked it, and managed to get it to reconnect. I think it might have been due to my internet connection being down for a period of time today, and it seems it didn't notice that it lost the connection. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Thu Oct 6 01:28:20 2011 From: nobody at buildbot.net (Buildbot) Date: Thu, 06 Oct 2011 01:28:20 -0000 Subject: [Buildbot-commits] [Buildbot] #498: IRC client fails to reconnect after IP change. In-Reply-To: <040.96a75f3f7053d12dc05c793924522fe3@buildbot.net> References: <040.96a75f3f7053d12dc05c793924522fe3@buildbot.net> Message-ID: <055.0256cfdcfd7594693f3a0adabcd7f3b0@buildbot.net> #498: IRC client fails to reconnect after IP change. ---------------------+-------------------- Reporter: ipv6guru | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.+ Version: 0.7.10 | Resolution: Keywords: irc | ---------------------+-------------------- Comment (by tom.prince): I tried adding a LoopingCall that I start in IrcStatusBot.connectionMade and stop in IrcStatusBot.connectionLost, that calls self.ping(self.nickname). It tested by using iptables to block outgoing packets to the IRC server, and after ~4min (and pings) it tried reconnecting (which worked, since it connected to a different server on the same network). -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Thu Oct 6 02:00:38 2011 From: noreply at github.com (noreply at github.com) Date: Wed, 5 Oct 2011 19:00:38 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 56ada6: Load config for upgrade-master and checkconfig whi... Message-ID: <20111006020038.C633742768@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 56ada6ea5fdaa80aa064118493870e9e5f9bc94c https://github.com/buildbot/buildbot/commit/56ada6ea5fdaa80aa064118493870e9e5f9bc94c Author: Tom Prince Date: 2011-10-05 (Wed, 05 Oct 2011) Changed paths: M master/buildbot/scripts/runner.py Log Message: ----------- Load config for upgrade-master and checkconfig while in buildbot directory. This is where the master is run from, and this way relative paths work the same in checkconfig as normally. Commit: 2d6dcee98c6c0ceb77a950bd565e73ae3a4ba1ec https://github.com/buildbot/buildbot/commit/2d6dcee98c6c0ceb77a950bd565e73ae3a4ba1ec Author: Amber Yust Date: 2011-10-05 (Wed, 05 Oct 2011) Changed paths: M master/buildbot/scripts/runner.py Log Message: ----------- Merge pull request #263 from tomprince/chdir-for-upgrade+checkconfig Load config for upgrade-master and checkconfig while in buildbot director Compare: https://github.com/buildbot/buildbot/compare/1eaaf8b...2d6dcee From noreply at github.com Thu Oct 6 02:42:55 2011 From: noreply at github.com (noreply at github.com) Date: Wed, 5 Oct 2011 19:42:55 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 450d53: Merge branch 'irc-keep-alive' of git://github.com/... Message-ID: <20111006024255.C33D042568@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 450d53020bfb2e27a5fa4bc3ef4cc8b9877de608 https://github.com/buildbot/buildbot/commit/450d53020bfb2e27a5fa4bc3ef4cc8b9877de608 Author: Dustin J. Mitchell Date: 2011-10-05 (Wed, 05 Oct 2011) Changed paths: M master/buildbot/status/words.py Log Message: ----------- Merge branch 'irc-keep-alive' of git://github.com/tomprince/buildbot * 'irc-keep-alive' of git://github.com/tomprince/buildbot: irc: Send keep-alive to detect lost connections. From nobody at buildbot.net Thu Oct 6 02:51:38 2011 From: nobody at buildbot.net (Buildbot) Date: Thu, 06 Oct 2011 02:51:38 -0000 Subject: [Buildbot-commits] [Buildbot] #2122: Race condition causes error describing step In-Reply-To: <037.bae614ef17847763cea74c9cb0e1a868@buildbot.net> References: <037.bae614ef17847763cea74c9cb0e1a868@buildbot.net> Message-ID: <052.371fd9c7631a358695dd7a2197ea8e67@buildbot.net> #2122: Race condition causes error describing step -------------------+-------------------- Reporter: tmidd | Owner: Type: defect | Status: new Priority: minor | Milestone: 0.8.6 Version: 0.8.5 | Resolution: Keywords: | -------------------+-------------------- Changes (by dustin): * milestone: undecided => 0.8.6 Comment: I'm guessing that this is happening before the step is run, so its properties haven't been rendered yet. It's pretty tricky to determine whether {{{self.command}}} needs to be rendered (since the renderables may be buried in a list). This is relatively harmless, as you've seen - the waterfall renders, albiet with a traceback in the logfile. Still, I bet we can find a fix -- describe() should be resilient. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Thu Oct 6 03:02:14 2011 From: nobody at buildbot.net (Buildbot) Date: Thu, 06 Oct 2011 03:02:14 -0000 Subject: [Buildbot-commits] [Buildbot] #2123: Changes sent over the wire should be compressed In-Reply-To: <036.8cceb3fe6a6edabb86fbef518ee3826f@buildbot.net> References: <036.8cceb3fe6a6edabb86fbef518ee3826f@buildbot.net> Message-ID: <051.0925caf770057a806ce68a60b8ea1e37@buildbot.net> #2123: Changes sent over the wire should be compressed ------------------------+-------------------- Reporter: dank | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.6 Version: 0.8.5 | Resolution: Keywords: | ------------------------+-------------------- Changes (by dustin): * milestone: undecided => 0.8.6 Comment: So there are two things to do in this bug: - make `twisted.spread.banana.SIZE_LIMIT` configurable - compress patches The first is fairly straightforward, and with a little care in protocol design, could even be configured only on the master. The second may occur automatically when support for patches is added to the master-side source steps. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Thu Oct 6 03:03:45 2011 From: nobody at buildbot.net (Buildbot) Date: Thu, 06 Oct 2011 03:03:45 -0000 Subject: [Buildbot-commits] [Buildbot] #2123: Changes sent over the wire should be compressed In-Reply-To: <036.8cceb3fe6a6edabb86fbef518ee3826f@buildbot.net> References: <036.8cceb3fe6a6edabb86fbef518ee3826f@buildbot.net> Message-ID: <051.4277864a82b5c10c4b622dfff69e7a2e@buildbot.net> #2123: Changes sent over the wire should be compressed ------------------------+-------------------- Reporter: dank | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.6 Version: 0.8.5 | Resolution: Keywords: | ------------------------+-------------------- Comment (by dustin): In fact, once patches are transferred using !FileDownload, there won't be any need to change SIZE_LIMIT, so maybe the first point is just a documentation change to suggest adding {{{ #!python from twisted.spread import banana banana.SIZE_LIMIT = 1024**2 }}} to buildbot.tac on the master and slave (with suitable security warnings). -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Thu Oct 6 03:08:48 2011 From: nobody at buildbot.net (Buildbot) Date: Thu, 06 Oct 2011 03:08:48 -0000 Subject: [Buildbot-commits] [Buildbot] #296: should have a way of running builds after X seconds of idle In-Reply-To: <040.ea708353268e803375c01ee12e90e8fb@buildbot.net> References: <040.ea708353268e803375c01ee12e90e8fb@buildbot.net> Message-ID: <055.b60222980384f703673799262547670a@buildbot.net> #296: should have a way of running builds after X seconds of idle ------------------------+-------------------- Reporter: bhearsum | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.9.+ Version: 0.7.7 | Resolution: Keywords: | ------------------------+-------------------- Changes (by dustin): * milestone: 0.8.+ => 0.9.+ Comment: It's hard to detect "idle", which users will expect to be a slave-related concept, not builder-related. It's particularly hard to detect in a distributed sense - and I want to get away from implementing single-master features that break down in a multi-master context. With a message-bus in place, it would be possible for the scheduler to schedule a build for a builder if it hadn't heard about any new build requests for that scheduler in N seconds, and there were no outstanding build requests for the builder at that time. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Thu Oct 6 03:12:45 2011 From: nobody at buildbot.net (Buildbot) Date: Thu, 06 Oct 2011 03:12:45 -0000 Subject: [Buildbot-commits] [Buildbot] #2121: Allow limited-scope Perforce checkouts In-Reply-To: <038.2d3e83e9c8fe3c7a2852341a9be765e7@buildbot.net> References: <038.2d3e83e9c8fe3c7a2852341a9be765e7@buildbot.net> Message-ID: <053.fb6d5d9f81a6bf1832738e0ee5fff185@buildbot.net> #2121: Allow limited-scope Perforce checkouts ----------------------+------------------------ Reporter: gmcnew | Owner: Type: undecided | Status: new Priority: major | Milestone: undecided Version: 0.8.4p2 | Resolution: Keywords: p4 | ----------------------+------------------------ Comment (by dustin): To speak to your two questions: 1. This should be implemented in a master-side P4 step. We've ported several other VC's to the master side, but since Perforce is proprietary, we weren't able to do so for P4. Still, there are sufficient examples to make this clear. Once the port is complete, I expect it will be fairly trivial to add some new step-constructor parameters (or alter existing parameters, since the master-side implementation represents a clean break) to support the functionality you're looking for. 1. As for being maintained - I can only guarantee that any unit tests you write will continue to pass. Perforce is currently listed as "Orphaned" in MAINTAINERS.txt: {{{ Perforce VC S: Orphaned U: http://trac.buildbot.net/wiki/p4 }}} Of course, you're welcome to step up as a maintainer of this component! -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Thu Oct 6 03:13:56 2011 From: nobody at buildbot.net (Buildbot) Date: Thu, 06 Oct 2011 03:13:56 -0000 Subject: [Buildbot-commits] [Buildbot] #498: IRC client fails to reconnect after IP change. In-Reply-To: <040.96a75f3f7053d12dc05c793924522fe3@buildbot.net> References: <040.96a75f3f7053d12dc05c793924522fe3@buildbot.net> Message-ID: <055.94ae98619aa7c45a4ad708ce4733ae04@buildbot.net> #498: IRC client fails to reconnect after IP change. ---------------------+--------------------- Reporter: ipv6guru | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.+ Version: 0.7.10 | Resolution: fixed Keywords: irc | ---------------------+--------------------- Changes (by dustin): * status: new => closed * resolution: => fixed Comment: Thanks, Tom! {{{ commit 0611f55dd88c3bd18c97e88905910719304c8fa0 Author: Tom Prince Date: Wed Oct 5 21:30:53 2011 -0400 irc: Send keep-alive to detect lost connections. Fixes #498. }}} re-open if this doesn't fix it. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Thu Oct 6 03:14:06 2011 From: nobody at buildbot.net (Buildbot) Date: Thu, 06 Oct 2011 03:14:06 -0000 Subject: [Buildbot-commits] [Buildbot] #498: IRC client fails to reconnect after IP change. In-Reply-To: <040.96a75f3f7053d12dc05c793924522fe3@buildbot.net> References: <040.96a75f3f7053d12dc05c793924522fe3@buildbot.net> Message-ID: <055.d199725b975e61e701cdf4f2ccecf900@buildbot.net> #498: IRC client fails to reconnect after IP change. ---------------------+--------------------- Reporter: ipv6guru | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.6 Version: 0.7.10 | Resolution: fixed Keywords: irc | ---------------------+--------------------- Changes (by dustin): * milestone: 0.8.+ => 0.8.6 -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Thu Oct 6 03:39:36 2011 From: noreply at github.com (noreply at github.com) Date: Wed, 5 Oct 2011 20:39:36 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 255803: Fix a test; a P4 change has a 'project' string now Message-ID: <20111006033936.1A59A4279F@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 25580335a069df77afe6f88d462891651d4976da https://github.com/buildbot/buildbot/commit/25580335a069df77afe6f88d462891651d4976da Author: Greg McNew Date: 2011-10-05 (Wed, 05 Oct 2011) Changed paths: M master/buildbot/test/unit/test_changes_p4poller.py Log Message: ----------- Fix a test; a P4 change has a 'project' string now Commit: 7f9c6afeb94ec3438024160e5c5d1835c7dc616f https://github.com/buildbot/buildbot/commit/7f9c6afeb94ec3438024160e5c5d1835c7dc616f Author: Dustin J. Mitchell Date: 2011-10-05 (Wed, 05 Oct 2011) Changed paths: M master/CREDITS M master/buildbot/changes/p4poller.py M master/buildbot/test/unit/test_changes_p4poller.py Log Message: ----------- Merge branch 'master' of git://github.com/gmcnew/buildbot * 'master' of git://github.com/gmcnew/buildbot: Fix a test; a P4 change has a 'project' string now Populate the "project" field of P4Source changes. Compare: https://github.com/buildbot/buildbot/compare/450d530...7f9c6af From nobody at buildbot.net Thu Oct 6 05:15:44 2011 From: nobody at buildbot.net (Buildbot) Date: Thu, 06 Oct 2011 05:15:44 -0000 Subject: [Buildbot-commits] [Buildbot] #2124: IRC oversubsribes to buildsets, logs too much Message-ID: <038.e3d7141541e658c55cc0f198870726b6@buildbot.net> #2124: IRC oversubsribes to buildsets, logs too much -------------------+------------------- Reporter: dustin | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.6 Version: 0.8.5 | Keywords: irc -------------------+------------------- From Gavin: {{{ 18:04 < gmcdonald+> .. 18:04 < gmcdonald+> why is my twistd.log full of these: 18:04 < gmcdonald+> buildmaster at aegis:~/master1$ cat twistd.log | grep 'Buildset added' | wc -l 18:04 < gmcdonald+> 7593 18:04 < gmcdonald+> .. 18:05 < gmcdonald+> all added at the same time I might add 18:09 < gmcdonald+> .. 18:09 < gmcdonald+> buildmaster at aegis:~/master1$ cat twistd.log | grep 'Not notifying for a build in the wrong category' | wc -l 18:09 < gmcdonald+> 1002 18:09 < gmcdonald+> .. 18:09 < gmcdonald+> thats new too 18:10 < gmcdonald+> .. }}} it seems that for every one thing done logs are repeated thousands of times, or I can believe the status being set on one builder actually is happening over 7000 times in one second? --- Both of these messages come from `words.IRC`; the first makes me think that it's being "oversubscribed" to build status, so that `buildsetSubmitted` is being called many times for each new buildset. The latter could be similar, but may also be a reasonable number of ignored buildsets by IRC bots that are not interested in them. So that message should probably just be removed. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Thu Oct 6 05:51:38 2011 From: noreply at github.com (noreply at github.com) Date: Wed, 5 Oct 2011 22:51:38 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 488773: Add a step to create a directory on the slave. Message-ID: <20111006055138.1E4AA4278B@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 48877317ee598fdece0f2796b1e9677238d873ee https://github.com/buildbot/buildbot/commit/48877317ee598fdece0f2796b1e9677238d873ee Author: Tom Prince Date: 2011-10-05 (Wed, 05 Oct 2011) Changed paths: M master/buildbot/steps/slave.py Log Message: ----------- Add a step to create a directory on the slave. Commit: 030802399db27115d845889b4643bfffea9f03a6 https://github.com/buildbot/buildbot/commit/030802399db27115d845889b4643bfffea9f03a6 Author: Amber Yust Date: 2011-10-05 (Wed, 05 Oct 2011) Changed paths: M master/buildbot/steps/slave.py Log Message: ----------- Merge pull request #264 from tomprince/make-dir Add a step to create a directory on the slave. Compare: https://github.com/buildbot/buildbot/compare/7f9c6af...0308023 From noreply at github.com Thu Oct 6 05:56:59 2011 From: noreply at github.com (noreply at github.com) Date: Wed, 5 Oct 2011 22:56:59 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] c13582: Add missing 'buildstep.' in MakeDirectory. Message-ID: <20111006055659.66688427AC@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: c13582511a20416e8cd72b69f1fb33fd2331bf6f https://github.com/buildbot/buildbot/commit/c13582511a20416e8cd72b69f1fb33fd2331bf6f Author: Amber Yust Date: 2011-10-05 (Wed, 05 Oct 2011) Changed paths: M master/buildbot/steps/slave.py Log Message: ----------- Add missing 'buildstep.' in MakeDirectory. From nobody at buildbot.net Thu Oct 6 05:59:26 2011 From: nobody at buildbot.net (Buildbot) Date: Thu, 06 Oct 2011 05:59:26 -0000 Subject: [Buildbot-commits] [Buildbot] #2125: buildbot.steps.slave.MakeDirectory needs tests/docs Message-ID: <042.9783a81166d26b38c71303f2df2d06d0@buildbot.net> #2125: buildbot.steps.slave.MakeDirectory needs tests/docs -----------------------+------------------------ Reporter: tom.prince | Owner: tom.prince Type: undecided | Status: new Priority: major | Milestone: undecided Version: 0.8.5 | Keywords: -----------------------+------------------------ -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Thu Oct 6 06:49:47 2011 From: nobody at buildbot.net (Buildbot) Date: Thu, 06 Oct 2011 06:49:47 -0000 Subject: [Buildbot-commits] [Buildbot] #2121: Allow limited-scope Perforce checkouts In-Reply-To: <038.2d3e83e9c8fe3c7a2852341a9be765e7@buildbot.net> References: <038.2d3e83e9c8fe3c7a2852341a9be765e7@buildbot.net> Message-ID: <053.32da4d175b41eb8027e19f0bb11c1053@buildbot.net> #2121: Allow limited-scope Perforce checkouts ----------------------+------------------------ Reporter: gmcnew | Owner: Type: undecided | Status: new Priority: major | Milestone: undecided Version: 0.8.4p2 | Resolution: Keywords: p4 | ----------------------+------------------------ Comment (by gmcnew): Thanks Dustin! I'll look into the master/slave-side stuff. Replying to [comment:2 dustin]: > 2. As for being maintained - I can only guarantee that any unit tests you write will continue to pass. ... I think you misread "mainlined" as "maintained" in my description above. =) What I was really asking was "would a patch for this feature have a chance of being accepted, or is this use case too rare?" -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Oct 7 00:03:11 2011 From: nobody at buildbot.net (Buildbot) Date: Fri, 07 Oct 2011 00:03:11 -0000 Subject: [Buildbot-commits] [Buildbot] #2121: Allow limited-scope Perforce checkouts In-Reply-To: <038.2d3e83e9c8fe3c7a2852341a9be765e7@buildbot.net> References: <038.2d3e83e9c8fe3c7a2852341a9be765e7@buildbot.net> Message-ID: <053.e4fb5bf342bd5dad994be0cedc777fcd@buildbot.net> #2121: Allow limited-scope Perforce checkouts ----------------------+------------------------ Reporter: gmcnew | Owner: Type: undecided | Status: new Priority: major | Milestone: undecided Version: 0.8.4p2 | Resolution: Keywords: p4 | ----------------------+------------------------ Comment (by dustin): I did misread it :) Honestly I don't know enough about perforce to understand what you're suggesting, but if it's written, tested, and documented, I'm happy to merge it. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Oct 7 00:07:00 2011 From: nobody at buildbot.net (Buildbot) Date: Fri, 07 Oct 2011 00:07:00 -0000 Subject: [Buildbot-commits] [Buildbot] #2124: IRC oversubsribes to buildsets, logs too much In-Reply-To: <038.e3d7141541e658c55cc0f198870726b6@buildbot.net> References: <038.e3d7141541e658c55cc0f198870726b6@buildbot.net> Message-ID: <053.2ea0f28c82387533dda6667a7eef1e25@buildbot.net> #2124: IRC oversubsribes to buildsets, logs too much -------------------+-------------------- Reporter: dustin | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.6 Version: 0.8.5 | Resolution: Keywords: irc | -------------------+-------------------- Comment (by dustin): There are a few problems here: - words.py logs *way* too much. Really. - most likely some kind of multiple subscription to the same status object - gavin's seeing runs of 107 log messages, with only ~40 bots - every bot subscribes to every builder, even if the categories don't match -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Oct 7 00:07:11 2011 From: nobody at buildbot.net (Buildbot) Date: Fri, 07 Oct 2011 00:07:11 -0000 Subject: [Buildbot-commits] [Buildbot] #2124: IRC oversubsribes to buildsets, logs too much In-Reply-To: <038.e3d7141541e658c55cc0f198870726b6@buildbot.net> References: <038.e3d7141541e658c55cc0f198870726b6@buildbot.net> Message-ID: <053.2d0a3fa8e6db43a40cd21d91bc59e008@buildbot.net> #2124: IRC oversubsribes to buildsets, logs too much -------------------+-------------------- Reporter: dustin | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.6 Version: 0.8.5 | Resolution: Keywords: irc | -------------------+-------------------- Comment (by dustin): and - no tests -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Oct 7 04:57:05 2011 From: nobody at buildbot.net (Buildbot) Date: Fri, 07 Oct 2011 04:57:05 -0000 Subject: [Buildbot-commits] [Buildbot] #1827: Make graceful shutdown a buildbot command In-Reply-To: <035.0e49a5e0b9b88be7892ca41082c5f07e@buildbot.net> References: <035.0e49a5e0b9b88be7892ca41082c5f07e@buildbot.net> Message-ID: <050.77cc36a7e95cce01ea33bda629557ff8@buildbot.net> #1827: Make graceful shutdown a buildbot command ------------------------+----------------------- Reporter: mjw | Owner: ayust Type: enhancement | Status: assigned Priority: major | Milestone: 0.8.+ Version: 0.8.3p1 | Resolution: Keywords: sprint | ------------------------+----------------------- Comment (by dank): I would like this, too. My bots need to shut down if /var/run/reboot- required is set. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Oct 7 04:59:04 2011 From: nobody at buildbot.net (Buildbot) Date: Fri, 07 Oct 2011 04:59:04 -0000 Subject: [Buildbot-commits] [Buildbot] #1827: Make graceful shutdown a buildbot command In-Reply-To: <035.0e49a5e0b9b88be7892ca41082c5f07e@buildbot.net> References: <035.0e49a5e0b9b88be7892ca41082c5f07e@buildbot.net> Message-ID: <050.a18fa06013cb6cb00efec9b7a052b9a3@buildbot.net> #1827: Make graceful shutdown a buildbot command ------------------------+----------------------- Reporter: mjw | Owner: ayust Type: enhancement | Status: assigned Priority: major | Milestone: 0.8.+ Version: 0.8.3p1 | Resolution: Keywords: sprint | ------------------------+----------------------- Comment (by dank): Wait a minute, I think I meant to say this on bug 849, since it's just the slave that needs to shut down for me. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Oct 7 05:01:07 2011 From: nobody at buildbot.net (Buildbot) Date: Fri, 07 Oct 2011 05:01:07 -0000 Subject: [Buildbot-commits] [Buildbot] #849: slave-initiated graceful shutdown In-Reply-To: <038.9dc94939c7758b0dfda65dda7d9a1479@buildbot.net> References: <038.9dc94939c7758b0dfda65dda7d9a1479@buildbot.net> Message-ID: <053.f1fc2598b7de88677d97b7285eca3235@buildbot.net> #849: slave-initiated graceful shutdown ------------------------+----------------------- Reporter: catlee | Owner: catlee Type: enhancement | Status: assigned Priority: minor | Milestone: 0.8.+ Version: 0.8.0 | Resolution: Keywords: | ------------------------+----------------------- Comment (by dank): My buildslaves need to shut down if the system needs a reboot (e.g. if ubuntu's update manager has created the file /var/run/reboot-required), since the usual cause of that state is a graphics driver update which causes all my tests to fail. I'll hack that in some other way for now (like with killall from a build step). -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Oct 8 00:50:32 2011 From: nobody at buildbot.net (Buildbot) Date: Sat, 08 Oct 2011 00:50:32 -0000 Subject: [Buildbot-commits] [Buildbot] #2126: buildbot try --properties=prop=value doesn't work Message-ID: <035.99c90048ac5befbeb80a67a3e92d2cee@buildbot.net> #2126: buildbot try --properties=prop=value doesn't work ----------------------+----------------------- Reporter: gg0 | Owner: Type: undecided | Status: new Priority: major | Milestone: undecided Version: 0.8.5 | Keywords: ----------------------+----------------------- try build runs correctly but it doesn't consider the property you pass. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Oct 8 13:13:21 2011 From: nobody at buildbot.net (Buildbot) Date: Sat, 08 Oct 2011 13:13:21 -0000 Subject: [Buildbot-commits] [Buildbot] #2091: MailNotifier chokes on try job with non-ascii char in first line of patch? In-Reply-To: <036.f0e569802d6f78483b94442701bcb9e8@buildbot.net> References: <036.f0e569802d6f78483b94442701bcb9e8@buildbot.net> Message-ID: <051.316fd63a08834cbb72dc44d45b38a308@buildbot.net> #2091: MailNotifier chokes on try job with non-ascii char in first line of patch? ---------------------+--------------------- Reporter: dank | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.+ Version: master | Resolution: fixed Keywords: encoding | ---------------------+--------------------- Changes (by dank): * status: reopened => closed * resolution: => fixed Comment: Hah. It happened again, and I took a closer look. Note the tail end of the exception: File "buildbot-git/master/buildbot/status/mail.py", line 520, in createEmail text = msgdict['body'].encode(ENCODING) exceptions.UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 582: ordinal not in range(128) This is *before* attachments happen; it's in the body. Suspecting it was in the summary of the error that my custom message formatter inserts, I looked for the byte it couldn't decode: wget http://buildbot.kegel.com:8010/builders/runtests-default- x86_64/builds/55/steps/shell_2/logs/stdio/text hexdump -C text > hex grep -C3 'e2 ' hex And voila: 0014f9c0 2d 75 6e 75 73 65 64 2d 62 75 74 2d 73 65 74 2d |-unused-but- set-| 0014f9d0 76 61 72 69 61 62 6c 65 22 0a 74 6d 61 72 73 68 |variable".tmarsh| 0014f9e0 61 6c 2e 63 3a 20 49 6e 20 66 75 6e 63 74 69 6f |al.c: In functio| 0014f9f0 6e 20 e2 80 98 73 65 72 69 61 6c 69 7a 65 5f 70 |n ...serialize_p| 0014fa00 61 72 61 6d e2 80 99 3a 0a 74 6d 61 72 73 68 61 |aram...:.tmarsha| 0014fa10 6c 2e 63 3a 37 31 37 3a 32 37 39 3a 20 77 61 72 |l.c:717:279: war| 0014fa20 6e 69 6e 67 3a 20 63 61 73 74 20 74 6f 20 70 6f |ning: cast to po| 0014fa30 69 6e 74 65 72 20 66 72 6f 6d 20 69 6e 74 65 67 |inter from integ| gcc itself is using non-ascii characters in its error messages! The line generated.c: In function ?test_pack_LPNONCLIENTMETRICSA?: uses a non-ascii opening single quote. So this newer crash is different from the older one, and we can close this bug. (Easy workaround for me: when running gcc, use LANG=C. Alternately, figure out how to do a destructive mapping to ascii in my custom message formatter.) -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Oct 9 04:07:11 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 09 Oct 2011 04:07:11 -0000 Subject: [Buildbot-commits] [Buildbot] #2127: Git 1.7.7: Recent change causes buildbot to always fail to fetch from git Message-ID: <040.4bdbb1fd8d851abd20e958f552f40733@buildbot.net> #2127: Git 1.7.7: Recent change causes buildbot to always fail to fetch from git ---------------------+----------------------- Reporter: cdavis5x | Owner: Type: defect | Status: new Priority: critical | Milestone: undecided Version: master | Keywords: git ---------------------+----------------------- When buildbot updates a repository using Git, one of the things it does is: {{{ $ git branch -M }}} where `` is the target branch. Even if the branch already existed, this worked fine... ...up until Git 1.7.7, which for some reason changed this. Now when you try to rename the current branch, `git branch -M` throws this error: {{{ fatal: Cannot force update the current branch. }}} Unless this bug is fixed, '''IT WILL NOT BE POSSIBLE TO USE BUILDBOT WITH GIT >= 1.7.7'''. Luckily for you all, I went ahead and fixed this for you. (Watch for an upcoming pull request.) -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sun Oct 9 14:46:47 2011 From: noreply at github.com (noreply at github.com) Date: Sun, 9 Oct 2011 07:46:47 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 9642f9: Merge branch 'patch-3' of git://github.com/benalla... Message-ID: <20111009144647.88C2A426B4@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 9642f9df857b2edc9152cc3c21d0d46f24459da6 https://github.com/buildbot/buildbot/commit/9642f9df857b2edc9152cc3c21d0d46f24459da6 Author: Dustin J. Mitchell Date: 2011-10-09 (Sun, 09 Oct 2011) Changed paths: M master/buildbot/steps/transfer.py M master/buildbot/test/unit/test_steps_transfer.py M master/docs/manual/cfg-buildsteps.rst M master/docs/manual/installation.rst Log Message: ----------- Merge branch 'patch-3' of git://github.com/benallard/buildbot * 'patch-3' of git://github.com/benallard/buildbot: Add a test for the url argument of the FileUpload step Update documentation about the url parameter of the transfer steps Add an url parameter to the FileFransfer steps to show in the HTML status Commit: 5d4cea5a38b3ed1e64c56bcdab63cd565a7cd9dd https://github.com/buildbot/buildbot/commit/5d4cea5a38b3ed1e64c56bcdab63cd565a7cd9dd Author: Dustin J. Mitchell Date: 2011-10-09 (Sun, 09 Oct 2011) Changed paths: M master/buildbot/steps/slave.py Log Message: ----------- Merge branch 'master' of github.com:buildbot/buildbot * 'master' of github.com:buildbot/buildbot: Add missing 'buildstep.' in MakeDirectory. Add a step to create a directory on the slave. Compare: https://github.com/buildbot/buildbot/compare/c135825...5d4cea5 From noreply at github.com Sun Oct 9 14:53:54 2011 From: noreply at github.com (noreply at github.com) Date: Sun, 9 Oct 2011 07:53:54 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 0499d5: Merge branch 'http_auth' of git://github.com/parog... Message-ID: <20111009145354.733C2426AE@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 0499d5d7cc54dbf9fb9ce38547c59b0e62de39b5 https://github.com/buildbot/buildbot/commit/0499d5d7cc54dbf9fb9ce38547c59b0e62de39b5 Author: Dustin J. Mitchell Date: 2011-10-09 (Sun, 09 Oct 2011) Changed paths: M master/CREDITS M master/buildbot/status/web/authz.py M master/buildbot/status/web/templates/forms.html M master/buildbot/test/unit/test_status_web_authz_Authz.py M master/docs/manual/cfg-statustargets.rst Log Message: ----------- Merge branch 'http_auth' of git://github.com/paroga/buildbot * 'http_auth' of git://github.com/paroga/buildbot: Hide "username" field when HTTP authentication is enabled Add support for getting HTTP username Commit: 300fbcf05518551451f91023ef604dbbb24e538f https://github.com/buildbot/buildbot/commit/300fbcf05518551451f91023ef604dbbb24e538f Author: Dustin J. Mitchell Date: 2011-10-09 (Sun, 09 Oct 2011) Changed paths: M master/NEWS Log Message: ----------- add NEWS Compare: https://github.com/buildbot/buildbot/compare/5d4cea5...300fbcf From nobody at buildbot.net Sun Oct 9 15:40:18 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 09 Oct 2011 15:40:18 -0000 Subject: [Buildbot-commits] [Buildbot] #849: slave-initiated graceful shutdown In-Reply-To: <038.9dc94939c7758b0dfda65dda7d9a1479@buildbot.net> References: <038.9dc94939c7758b0dfda65dda7d9a1479@buildbot.net> Message-ID: <053.f5389438d95e142a2714d0e08793af73@buildbot.net> #849: slave-initiated graceful shutdown ------------------------+--------------------- Reporter: catlee | Owner: catlee Type: enhancement | Status: closed Priority: minor | Milestone: 0.8.+ Version: 0.8.0 | Resolution: fixed Keywords: | ------------------------+--------------------- Changes (by dustin): * status: assigned => closed * resolution: => fixed Comment: This is already solved, and in fact documented, although not in a very visible place: http://buildbot.net/buildbot/docs/latest/manual/installation.html#other- buildslave-configuration (I'm not sure where would be a better place for that?) -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Oct 9 15:58:28 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 09 Oct 2011 15:58:28 -0000 Subject: [Buildbot-commits] [Buildbot] #2126: buildbot try --properties=prop=value doesn't work In-Reply-To: <035.99c90048ac5befbeb80a67a3e92d2cee@buildbot.net> References: <035.99c90048ac5befbeb80a67a3e92d2cee@buildbot.net> Message-ID: <050.496d971a4fba12db6c775325d942527a@buildbot.net> #2126: buildbot try --properties=prop=value doesn't work ----------------------+------------------------ Reporter: gg0 | Owner: Type: undecided | Status: new Priority: major | Milestone: undecided Version: 0.8.5 | Resolution: Keywords: | ----------------------+------------------------ Comment (by dustin): I can't replicate. I ran a basic master, then {{{ buildbot try --vc=git -b builder --properties=abc=def,ghi=jkl }}} and I see properties `abc` and `ghi` in the resulting web status, with appropriate values. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Oct 9 16:00:11 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 09 Oct 2011 16:00:11 -0000 Subject: [Buildbot-commits] [Buildbot] #2091: MailNotifier chokes on try job with non-ascii char in first line of patch? In-Reply-To: <036.f0e569802d6f78483b94442701bcb9e8@buildbot.net> References: <036.f0e569802d6f78483b94442701bcb9e8@buildbot.net> Message-ID: <051.cb6fd4a71f7ed5668fae43744e21715f@buildbot.net> #2091: MailNotifier chokes on try job with non-ascii char in first line of patch? ---------------------+--------------------- Reporter: dank | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.+ Version: master | Resolution: fixed Keywords: encoding | ---------------------+--------------------- Comment (by dustin): Hah, this "feature" of GCC has annoyed me many times! You can encode to ascii with `str.encode('ascii', 'replace')`, by the way. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sun Oct 9 16:05:39 2011 From: noreply at github.com (noreply at github.com) Date: Sun, 9 Oct 2011 09:05:39 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 6f5ce3: Merge branch 'git-fixes' of git://github.com/cdavi... Message-ID: <20111009160539.BAE6F42743@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 6f5ce3b2ab033338f3ad7ddccbf8b6542311f70b https://github.com/buildbot/buildbot/commit/6f5ce3b2ab033338f3ad7ddccbf8b6542311f70b Author: Dustin J. Mitchell Date: 2011-10-09 (Sun, 09 Oct 2011) Changed paths: M slave/buildslave/commands/git.py Log Message: ----------- Merge branch 'git-fixes' of git://github.com/cdavis5x/buildbot * 'git-fixes' of git://github.com/cdavis5x/buildbot: buildslave/git: Don't fail the whole build if git branch -M can't rename master. From nobody at buildbot.net Sun Oct 9 16:08:42 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 09 Oct 2011 16:08:42 -0000 Subject: [Buildbot-commits] [Buildbot] #2127: Git 1.7.7: Recent change causes buildbot to always fail to fetch from git In-Reply-To: <040.4bdbb1fd8d851abd20e958f552f40733@buildbot.net> References: <040.4bdbb1fd8d851abd20e958f552f40733@buildbot.net> Message-ID: <055.33ce14a44d88a5f384b23d06ad413d6d@buildbot.net> #2127: Git 1.7.7: Recent change causes buildbot to always fail to fetch from git ---------------------+------------------------ Reporter: cdavis5x | Owner: Type: defect | Status: closed Priority: critical | Milestone: undecided Version: master | Resolution: fixed Keywords: git | ---------------------+------------------------ Changes (by dustin): * status: new => closed * resolution: => fixed Comment: Fix is merged - thanks for spotting that! -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Oct 9 19:15:26 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 09 Oct 2011 19:15:26 -0000 Subject: [Buildbot-commits] [Buildbot] #2126: buildbot try --properties=prop=value doesn't work In-Reply-To: <035.99c90048ac5befbeb80a67a3e92d2cee@buildbot.net> References: <035.99c90048ac5befbeb80a67a3e92d2cee@buildbot.net> Message-ID: <050.59a7686b76b5194410897764ff2d79c9@buildbot.net> #2126: buildbot try --properties=prop=value doesn't work ----------------------+------------------------ Reporter: gg0 | Owner: Type: undecided | Status: new Priority: major | Milestone: undecided Version: 0.8.5 | Resolution: Keywords: | ----------------------+------------------------ Comment (by gg0): Sorry missing initial info: I usually use Try_Jobdir (ssh). I tried to switch to Try_Userpass (pb) and it works, props are passed correctly. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Oct 9 22:35:32 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 09 Oct 2011 22:35:32 -0000 Subject: [Buildbot-commits] [Buildbot] #2126: buildbot try --properties=prop=value doesn't work In-Reply-To: <035.99c90048ac5befbeb80a67a3e92d2cee@buildbot.net> References: <035.99c90048ac5befbeb80a67a3e92d2cee@buildbot.net> Message-ID: <050.9ffa6a72012e2324948fa0f290967eb5@buildbot.net> #2126: buildbot try --properties=prop=value doesn't work -------------------+-------------------- Reporter: gg0 | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.6 Version: 0.8.5 | Resolution: Keywords: | -------------------+-------------------- Changes (by dustin): * type: undecided => defect * milestone: undecided => 0.8.6 -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sun Oct 9 23:14:07 2011 From: noreply at github.com (noreply at github.com) Date: Sun, 9 Oct 2011 16:14:07 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] de928a: add warning for older than sqlite-3.7 regarding WA... Message-ID: <20111009231407.186EF426F0@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: de928a17f52dd91e17fab66d1cd5a60eed6aa360 https://github.com/buildbot/buildbot/commit/de928a17f52dd91e17fab66d1cd5a60eed6aa360 Author: Dustin J. Mitchell Date: 2011-10-09 (Sun, 09 Oct 2011) Changed paths: M master/buildbot/db/pool.py Log Message: ----------- add warning for older than sqlite-3.7 regarding WAL logs From noreply at github.com Sun Oct 9 23:19:40 2011 From: noreply at github.com (noreply at github.com) Date: Sun, 9 Oct 2011 16:19:40 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] f8255e: Merge branch 'envarray' of git://github.com/benall... Message-ID: <20111009231940.D79CE426EF@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: f8255e15de9c1b4a2d2816dc3e723ea66ac4c741 https://github.com/buildbot/buildbot/commit/f8255e15de9c1b4a2d2816dc3e723ea66ac4c741 Author: Dustin J. Mitchell Date: 2011-10-09 (Sun, 09 Oct 2011) Changed paths: M slave/buildslave/runprocess.py M slave/buildslave/test/unit/test_runprocess.py Log Message: ----------- Merge branch 'envarray' of git://github.com/benallard/buildbot * 'envarray' of git://github.com/benallard/buildbot: Make the PYTHONPATH env variable less specific, allow other variables to accept list From nobody at buildbot.net Mon Oct 10 10:23:13 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 10 Oct 2011 10:23:13 -0000 Subject: [Buildbot-commits] [Buildbot] #438: Mercurial does not update to the right revision when building a tag from a named branch In-Reply-To: <041.981e251e2d06093a72516dffe4ddcfc5@buildbot.net> References: <041.981e251e2d06093a72516dffe4ddcfc5@buildbot.net> Message-ID: <056.8b48a771044ad065501842152ff1a68f@buildbot.net> #438: Mercurial does not update to the right revision when building a tag from a named branch ----------------------+------------------------ Reporter: cdevienne | Owner: Type: defect | Status: reopened Priority: major | Milestone: undecided Version: 0.8.5 | Resolution: Keywords: | ----------------------+------------------------ Comment (by marcusl): Dustin: It would seem so, for the causal observer. :) However, due to the (slightly bone-headed, IMO) way tags are handled in Mercurial, the info about the tag itself is not preserved when cloning with '--rev', so the tag-info will not exist in the clone, even though the top revision is the one that was tagged. Tags are handled by a .hgtags, which is version controlled too, and since the tags are created in that file in a revision made **after** the revision being tagged ( Basically: * Revision A is created * Revision B adds tag X to revision A * If "clone --rev = X" is executed, the clone contains rev A, but not B, so it does not know about tag X, so "update X" fails, as do my scripts for detecting the current version from vc tags) There are a few ways to tackle this: * Always clone everything (easy, but potentially wasteful if a very old tag is being checked out) * Detect the revision B where tag was made, clone that one (tricky to implement, but certainly possible. I've seen code for this on stackoverflow.com ) * Add tag locally using "hg tag X --local" (potentially dangerous due to conflicts with later updates, unless tag is removed after build or clone is not re-used" This has been discussed in several places, and the root issue has not been fixed yet. There is some resistance to fixing this in the Mercurial dev team, obviously for a few good reasons, and maybe because no fully superior solution is available, yet. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Oct 10 13:28:46 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 10 Oct 2011 13:28:46 -0000 Subject: [Buildbot-commits] [Buildbot] #2127: Git 1.7.7: Recent change causes buildbot to always fail to fetch from git In-Reply-To: <040.4bdbb1fd8d851abd20e958f552f40733@buildbot.net> References: <040.4bdbb1fd8d851abd20e958f552f40733@buildbot.net> Message-ID: <055.6cf453a4b979933eb9b42dadb661e8c6@buildbot.net> #2127: Git 1.7.7: Recent change causes buildbot to always fail to fetch from git ---------------------+------------------------ Reporter: cdavis5x | Owner: Type: defect | Status: closed Priority: critical | Milestone: undecided Version: master | Resolution: fixed Keywords: git | ---------------------+------------------------ Comment (by mattock): I backported this patch to buildbot 0.7.12 manually, but unfortunately it did not fix the problem. What did seem to fix this was skipping the ''git branch -M master'' step conditionally: {{{ def _didFetch(self, res): if self.revision: head = self.revision else: head = 'FETCH_HEAD' # That is not sufficient. git will leave unversioned files and empty # directories. Clean them up manually in _didReset. command = ['reset', '--hard', head] if self.branch == "master": return self._dovccmd(command, self._initSubmodules) else: return self._dovccmd(command, self._didHeadCheckout) }}} Didn't look deep enough in the code to know if this has some unwanted side-effects. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Tue Oct 11 19:59:41 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 11 Oct 2011 19:59:41 -0000 Subject: [Buildbot-commits] [Buildbot] #2091: MailNotifier chokes on try job with non-ascii char in first line of patch? In-Reply-To: <036.f0e569802d6f78483b94442701bcb9e8@buildbot.net> References: <036.f0e569802d6f78483b94442701bcb9e8@buildbot.net> Message-ID: <051.bba8adff1debf669d8c6bfbb821eca7b@buildbot.net> #2091: MailNotifier chokes on try job with non-ascii char in first line of patch? ---------------------+--------------------- Reporter: dank | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.+ Version: master | Resolution: fixed Keywords: encoding | ---------------------+--------------------- Comment (by dank): For completeness, I should mention that I had to set LC_CTYPE=C, too, else gcc would continue using the funky character. (Probably because buildbot sets LC_CTYPE explicitly, so it needs overriding.) -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Oct 12 22:29:17 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 12 Oct 2011 22:29:17 -0000 Subject: [Buildbot-commits] [Buildbot] #2128: Git + submodules => TypeError exception Message-ID: <038.ca7f4efca699851fb6083785b1c65654@buildbot.net> #2128: Git + submodules => TypeError exception -------------------+----------------------- Reporter: pigmej | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.5 | Keywords: -------------------+----------------------- {{{ exceptions.TypeError: .__init__ got unexpected keyword argument(s) ['submodules'] }}} When trying to: {{{ f.addStep(Git(repourl = 'REPO', mode = 'full', method = 'clobber', submodules = True )) }}} -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Oct 12 23:17:45 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 12 Oct 2011 23:17:45 -0000 Subject: [Buildbot-commits] [Buildbot] #2129: Support unix domain sockets for build slaves. Message-ID: <042.5d0d5f84857cae42694c0568b95d07c2@buildbot.net> #2129: Support unix domain sockets for build slaves. ------------------------+----------------------- Reporter: simpletoon | Owner: Type: enhancement | Status: new Priority: major | Milestone: undecided Version: 0.8.5 | Keywords: ------------------------+----------------------- I'm using build-bot for a simple single-machine continuous build system. I don't really care to have TCP sockets open if not really needed. I have noticed that both status and slave ports can work with unix domain sockets: c [ 'slavePortnum' ] = "unix:/home/user/build/master/slaveconnect" c [ 'status' ].append(html.WebStatus(http_port="unix:/home/user/build/master/status")) This way it doesn't open any TCP ports on the host system. When I desire to view the status I can start as simple socat connection to redirect to the socket and use any web browser. socat -v tcp-l:,fork,reuseaddr,bind=127.0.0.1 unix:/home/user/build/master/status I would like to find a way to configure the build slave (/home/user/build/slave) to connect to the master by using unix domain sockets instead of requiring a TCP connection. The buildbot.slave.bot.BuildSlave code uses internet.TCPClient so it can't do this. It seems like a simple check could be done on hostname (if it starts with unix:) and then use internet.UnixClient instead. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Oct 12 23:22:31 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 12 Oct 2011 23:22:31 -0000 Subject: [Buildbot-commits] [Buildbot] #2129: Support unix domain sockets for build slaves. In-Reply-To: <042.5d0d5f84857cae42694c0568b95d07c2@buildbot.net> References: <042.5d0d5f84857cae42694c0568b95d07c2@buildbot.net> Message-ID: <057.376033faecb0346c8377dfb7c89b57eb@buildbot.net> #2129: Support unix domain sockets for build slaves. ------------------------+-------------------- Reporter: simpletoon | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.5 | Resolution: Keywords: | ------------------------+-------------------- Changes (by dustin): * milestone: undecided => 0.8.+ Comment: Ideally this would use endpoint strings, just like the master-side stuff you described. Can you hack that in? -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Thu Oct 13 16:24:59 2011 From: nobody at buildbot.net (Buildbot) Date: Thu, 13 Oct 2011 16:24:59 -0000 Subject: [Buildbot-commits] [Buildbot] #2129: Support unix domain sockets for build slaves. In-Reply-To: <042.5d0d5f84857cae42694c0568b95d07c2@buildbot.net> References: <042.5d0d5f84857cae42694c0568b95d07c2@buildbot.net> Message-ID: <057.d13018a7058927775d2545b37277e75d@buildbot.net> #2129: Support unix domain sockets for build slaves. ------------------------+-------------------- Reporter: simpletoon | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.5 | Resolution: Keywords: | ------------------------+-------------------- Comment (by simpletoon): I don't know enough about Twisted or the buildbot code to do anything with it myself. An idea may be something like using twisted.internet.endpoints.clientFromString. In order to be backwards compatible, BuildSlave could take both parameters still. If the port parameter is None, then treat the hostname parameter as the string and use clientFromString. Otherwise use the current TCPClient. New slaves created with buildbot create-slave would have the 'masterEndpoint' variable, and would call BuildSlave(masterEndpoint, None, ...), while current slaves would use BuildSlave(hostname, portnum, ...) -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Thu Oct 13 20:49:43 2011 From: nobody at buildbot.net (Buildbot) Date: Thu, 13 Oct 2011 20:49:43 -0000 Subject: [Buildbot-commits] [Buildbot] #2130: PBChangesource passwd code example is wrong Message-ID: <046.5018d64b9e853548f7d36575863170c2@buildbot.net> #2130: PBChangesource passwd code example is wrong ---------------------------+----------------------------------- Reporter: joshua.clayton | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: master | Keywords: manual PBChangesource ---------------------------+----------------------------------- In at least the 0.8.5 and latest buildbot manual, Change source, PBChangesoure section http://buildbot.net/buildbot/docs/0.8.5/manual/cfg-changesources.html #chsrc-PBChangeSource there is a code example that reads: {{{ #!python from buildbot.changes import pb c['changes'] = pb.PBChangeSource(port=9999, user='laura', password='fpga') }}} "password" should be "passwd" Also (though less important) the whole section would be less confusing if passwd had its own very short entry instead of being listed as 'user and passwd', which makes it look like they are one kw. It was this confusion that led me to copy the code example in the first place. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Thu Oct 13 23:05:24 2011 From: nobody at buildbot.net (Buildbot) Date: Thu, 13 Oct 2011 23:05:24 -0000 Subject: [Buildbot-commits] [Buildbot] #2116: gitpoller does not pass environment to git commands In-Reply-To: <040.6de817dbc72f64ce2ed53e923fef5b3b@buildbot.net> References: <040.6de817dbc72f64ce2ed53e923fef5b3b@buildbot.net> Message-ID: <055.698ad440786dcedac02494ca40c49ce8@buildbot.net> #2116: gitpoller does not pass environment to git commands ---------------------------+------------------------ Reporter: msabramo | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: master | Resolution: Keywords: gitpoller, git | ---------------------------+------------------------ Comment (by msabramo): Merge [https://github.com/buildbot/buildbot/pull/255 pull request #255] from msabramo/gitpoller_propagate_env_to_git_2116_2... ayust merged commit 8d9377d into buildbot:master from msabramo:gitpoller_propagate_env_to_git_2116_2 September 30, 2011 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Oct 14 00:25:16 2011 From: nobody at buildbot.net (Buildbot) Date: Fri, 14 Oct 2011 00:25:16 -0000 Subject: [Buildbot-commits] [Buildbot] #438: Mercurial does not update to the right revision when building a tag from a named branch In-Reply-To: <041.981e251e2d06093a72516dffe4ddcfc5@buildbot.net> References: <041.981e251e2d06093a72516dffe4ddcfc5@buildbot.net> Message-ID: <056.e3b541973ec0a8bb6847e3903bb07c50@buildbot.net> #438: Mercurial does not update to the right revision when building a tag from a named branch ----------------------+------------------------ Reporter: cdevienne | Owner: Type: defect | Status: reopened Priority: major | Milestone: undecided Version: 0.8.5 | Resolution: Keywords: | ----------------------+------------------------ Comment (by dustin): Interesting. I think the only option for Buildbot will be the first - "always clone everything". How can we do that? Just omit the --rev? How can we know that the requested revision is a tag and not a branch or a revision string? Coincidentally, I'm helping to debug failures in Mozilla where clones are taking longer than an hour, precisely because we have to clone everything and can't do shallow clones. Mercurial's got some growing pains! -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Fri Oct 14 00:27:43 2011 From: noreply at github.com (noreply at github.com) Date: Thu, 13 Oct 2011 17:27:43 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] af4529: Add doc about env variables also being arrays Message-ID: <20111014002743.D87C542887@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: af4529d9539d1c1d2adb6865d3e6f5d5f8100cbf https://github.com/buildbot/buildbot/commit/af4529d9539d1c1d2adb6865d3e6f5d5f8100cbf Author: Benoit Allard Date: 2011-10-10 (Mon, 10 Oct 2011) Changed paths: M master/docs/manual/cfg-buildsteps.rst Log Message: ----------- Add doc about env variables also being arrays Commit: fb638f1fafb11c7522eefbbe0394eb0dc8f1cc25 https://github.com/buildbot/buildbot/commit/fb638f1fafb11c7522eefbbe0394eb0dc8f1cc25 Author: Dustin J. Mitchell Date: 2011-10-13 (Thu, 13 Oct 2011) Changed paths: M master/docs/manual/cfg-buildsteps.rst Log Message: ----------- Merge pull request #269 from benallard/envarray Add doc about env variables also being arrays Compare: https://github.com/buildbot/buildbot/compare/f8255e1...fb638f1 From nobody at buildbot.net Fri Oct 14 00:56:32 2011 From: nobody at buildbot.net (Buildbot) Date: Fri, 14 Oct 2011 00:56:32 -0000 Subject: [Buildbot-commits] [Buildbot] #2128: Git + submodules => TypeError exception In-Reply-To: <038.ca7f4efca699851fb6083785b1c65654@buildbot.net> References: <038.ca7f4efca699851fb6083785b1c65654@buildbot.net> Message-ID: <053.ab85900d3827d691185277ff37509a64@buildbot.net> #2128: Git + submodules => TypeError exception -------------------+-------------------- Reporter: pigmej | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.6 Version: 0.8.5 | Resolution: Keywords: git | -------------------+-------------------- Changes (by dustin): * keywords: => git * milestone: undecided => 0.8.6 Comment: Indeed - this is a typo in the implementation. Patch shortly. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Fri Oct 14 00:58:04 2011 From: noreply at github.com (noreply at github.com) Date: Thu, 13 Oct 2011 17:58:04 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 714abc: Use 'submodule' as the parameter name for master-s... Message-ID: <20111014005804.685F242546@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 714abca880fdc6f1e72a340ae3518695d144b614 https://github.com/buildbot/buildbot/commit/714abca880fdc6f1e72a340ae3518695d144b614 Author: Dustin J. Mitchell Date: 2011-10-13 (Thu, 13 Oct 2011) Changed paths: M master/buildbot/steps/source/git.py M master/buildbot/test/unit/test_steps_source_git.py Log Message: ----------- Use 'submodule' as the parameter name for master-side Git Fixes #2128. From nobody at buildbot.net Fri Oct 14 00:58:05 2011 From: nobody at buildbot.net (Buildbot) Date: Fri, 14 Oct 2011 00:58:05 -0000 Subject: [Buildbot-commits] [Buildbot] #2128: Git + submodules => TypeError exception In-Reply-To: <038.ca7f4efca699851fb6083785b1c65654@buildbot.net> References: <038.ca7f4efca699851fb6083785b1c65654@buildbot.net> Message-ID: <053.5e3616283000f04be94eeb891722593b@buildbot.net> #2128: Git + submodules => TypeError exception -------------------+--------------------- Reporter: pigmej | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.6 Version: 0.8.5 | Resolution: fixed Keywords: git | -------------------+--------------------- Changes (by Dustin J. Mitchell): * status: new => closed * resolution: => fixed Comment: Use 'submodule' as the parameter name for master-side Git Fixes #2128. Changeset: 714abca880fdc6f1e72a340ae3518695d144b614 -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Fri Oct 14 01:05:22 2011 From: noreply at github.com (noreply at github.com) Date: Thu, 13 Oct 2011 18:05:22 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 0ee4fe: fix up docs for PBChangeSource passwd parameter - ... Message-ID: <20111014010522.64DBA42820@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 0ee4fe21f494caf8236941f6c964fada086801ce https://github.com/buildbot/buildbot/commit/0ee4fe21f494caf8236941f6c964fada086801ce Author: Dustin J. Mitchell Date: 2011-10-13 (Thu, 13 Oct 2011) Changed paths: M master/docs/manual/cfg-changesources.rst Log Message: ----------- fix up docs for PBChangeSource passwd parameter - fixes #2130 From nobody at buildbot.net Fri Oct 14 01:05:25 2011 From: nobody at buildbot.net (Buildbot) Date: Fri, 14 Oct 2011 01:05:25 -0000 Subject: [Buildbot-commits] [Buildbot] #2130: PBChangesource passwd code example is wrong In-Reply-To: <046.5018d64b9e853548f7d36575863170c2@buildbot.net> References: <046.5018d64b9e853548f7d36575863170c2@buildbot.net> Message-ID: <061.85e3f1daca72d2aaa2e784f44e58f66b@buildbot.net> #2130: PBChangesource passwd code example is wrong ----------------------------------+------------------------ Reporter: joshua.clayton | Owner: Type: defect | Status: closed Priority: major | Milestone: undecided Version: master | Resolution: fixed Keywords: manual PBChangesource | ----------------------------------+------------------------ Changes (by Dustin J. Mitchell): * status: new => closed * resolution: => fixed Comment: fix up docs for PBChangeSource passwd parameter - fixes #2130 Changeset: 0ee4fe21f494caf8236941f6c964fada086801ce -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Oct 14 01:07:38 2011 From: nobody at buildbot.net (Buildbot) Date: Fri, 14 Oct 2011 01:07:38 -0000 Subject: [Buildbot-commits] [Buildbot] #2116: gitpoller does not pass environment to git commands In-Reply-To: <040.6de817dbc72f64ce2ed53e923fef5b3b@buildbot.net> References: <040.6de817dbc72f64ce2ed53e923fef5b3b@buildbot.net> Message-ID: <055.b3f46eddc962a4bb1ce50851b82118e4@buildbot.net> #2116: gitpoller does not pass environment to git commands ---------------------+--------------------- Reporter: msabramo | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.6 Version: master | Resolution: fixed Keywords: git | ---------------------+--------------------- Changes (by dustin): * keywords: gitpoller, git => git * status: new => closed * resolution: => fixed * milestone: undecided => 0.8.6 Comment: Thanks! -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Oct 14 01:12:13 2011 From: nobody at buildbot.net (Buildbot) Date: Fri, 14 Oct 2011 01:12:13 -0000 Subject: [Buildbot-commits] [Buildbot] #2131: Can't tell if rebuild button has been pressed Message-ID: <036.7122e229416b1bd757741a8e182a6d10@buildbot.net> #2131: Can't tell if rebuild button has been pressed ------------------------+----------------------- Reporter: dank | Owner: Type: enhancement | Status: new Priority: minor | Milestone: undecided Version: 0.8.5 | Keywords: ------------------------+----------------------- User Alice can't remember whether she pressed Rebuild. Should she press it again? She can't tell, because the UI for a particular build result doesn't give any indication of whether the Rebuild button has been pressed already. Result: extra builds gumming up the works. Be kind to amnesiacs, and add a little more status to the UI. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Oct 14 11:14:10 2011 From: nobody at buildbot.net (Buildbot) Date: Fri, 14 Oct 2011 11:14:10 -0000 Subject: [Buildbot-commits] [Buildbot] #438: Mercurial does not update to the right revision when building a tag from a named branch In-Reply-To: <041.981e251e2d06093a72516dffe4ddcfc5@buildbot.net> References: <041.981e251e2d06093a72516dffe4ddcfc5@buildbot.net> Message-ID: <056.7be55bd5fb75930bc6d2d5585d6aa554@buildbot.net> #438: Mercurial does not update to the right revision when building a tag from a named branch ----------------------+------------------------ Reporter: cdevienne | Owner: Type: defect | Status: reopened Priority: major | Milestone: undecided Version: 0.8.5 | Resolution: Keywords: | ----------------------+------------------------ Comment (by marcusl): Yes, just omitting the rev will work, which is what the OP said too. * A revision string will either be an int, a 12-char hex, or a 40-char hex. * Branch names could be anything though, so that's trickier. One could, of course, run 'hg tags' or 'hg branches' against the remote repo and see if it's included in the result. I agree with the growing pains thing. I think we should really look at repo-caching on the slave(s), in order to reduce this (something I wanted to do with SVN too, btw), or just wait for http://mercurial.selenic.com/wiki/ShallowClone to be done. :) -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Oct 14 19:33:55 2011 From: nobody at buildbot.net (Buildbot) Date: Fri, 14 Oct 2011 19:33:55 -0000 Subject: [Buildbot-commits] [Buildbot] #2132: Builder status in waterfall not updated Message-ID: <041.4a880c39b94b8731b1b9377f4a70dea4@buildbot.net> #2132: Builder status in waterfall not updated ----------------------+----------------------- Reporter: homer5439 | Owner: Type: defect | Status: new Priority: minor | Milestone: undecided Version: 0.8.5 | Keywords: ----------------------+----------------------- More often than not, once a build has completed its status remains "building" in the respective waterfall summary column. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Oct 14 19:35:33 2011 From: nobody at buildbot.net (Buildbot) Date: Fri, 14 Oct 2011 19:35:33 -0000 Subject: [Buildbot-commits] [Buildbot] #2132: Builder status in waterfall not updated In-Reply-To: <041.4a880c39b94b8731b1b9377f4a70dea4@buildbot.net> References: <041.4a880c39b94b8731b1b9377f4a70dea4@buildbot.net> Message-ID: <056.a8c157161db81610bf2ff199eb02e28b@buildbot.net> #2132: Builder status in waterfall not updated ----------------------+------------------------ Reporter: homer5439 | Owner: Type: defect | Status: new Priority: minor | Milestone: undecided Version: 0.8.5 | Resolution: Keywords: | ----------------------+------------------------ Changes (by homer5439): * cc: persson@? (added) Comment: the builder status page correctly reports "no current builds" and "no pending build requests". -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Oct 15 21:31:47 2011 From: nobody at buildbot.net (Buildbot) Date: Sat, 15 Oct 2011 21:31:47 -0000 Subject: [Buildbot-commits] [Buildbot] #2133: Cannot open 'stdio' links from buildbot waterfall Message-ID: <039.e84af97199d81966cd249330b74ead62@buildbot.net> #2133: Cannot open 'stdio' links from buildbot waterfall ----------------------------+----------------------- Reporter: cwilson | Owner: Type: support-request | Status: new Priority: minor | Milestone: undecided Version: 0.7.12 | Keywords: ----------------------------+----------------------- Hello, I've just upgraded ubuntu 10.04 (lucid) to 11.04 (natty) - buildbot 0.7.12 on both, twisted 10.0.0 to 10.2.0 - and my buildbot http status interface can no longer access my (stdio) logs. See http://diana.apam.columbia.edu:8010/waterfall and try any stdio link. I can see and open the log files myself and have tried playing with permissions on both the files and folders with no joy. Has anyone seen this before/got any tips to fix? Many thanks, Cian -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Oct 16 02:34:45 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 16 Oct 2011 02:34:45 -0000 Subject: [Buildbot-commits] [Buildbot] #2132: Builder status in waterfall not updated In-Reply-To: <041.4a880c39b94b8731b1b9377f4a70dea4@buildbot.net> References: <041.4a880c39b94b8731b1b9377f4a70dea4@buildbot.net> Message-ID: <056.5ff1cd4f11beee11fa6baa7f6ce8aac8@buildbot.net> #2132: Builder status in waterfall not updated ----------------------+------------------------ Reporter: homer5439 | Owner: Type: defect | Status: new Priority: minor | Milestone: undecided Version: 0.8.5 | Resolution: Keywords: | ----------------------+------------------------ Comment (by dustin): This was fixed in 0.8.4p2 - are you using a version earlier than that? -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Oct 16 03:01:05 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 16 Oct 2011 03:01:05 -0000 Subject: [Buildbot-commits] [Buildbot] #2133: Cannot open 'stdio' links from buildbot waterfall In-Reply-To: <039.e84af97199d81966cd249330b74ead62@buildbot.net> References: <039.e84af97199d81966cd249330b74ead62@buildbot.net> Message-ID: <054.bcc5da7c90b732e26552bf75e123c829@buildbot.net> #2133: Cannot open 'stdio' links from buildbot waterfall ----------------------------+------------------------ Reporter: cwilson | Owner: Type: support-request | Status: new Priority: minor | Milestone: undecided Version: 0.7.12 | Resolution: Keywords: | ----------------------------+------------------------ Comment (by dustin): At a guess, are you using an http proxy of some sort in front of the buildmaster? That can sometimes interfere with logfile streaming. Do you see any exceptions in the buildmaster's twistd.log? -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Oct 16 03:23:12 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 16 Oct 2011 03:23:12 -0000 Subject: [Buildbot-commits] [Buildbot] #2133: Cannot open 'stdio' links from buildbot waterfall In-Reply-To: <039.e84af97199d81966cd249330b74ead62@buildbot.net> References: <039.e84af97199d81966cd249330b74ead62@buildbot.net> Message-ID: <054.57c6b752b8207924ac12789c9970be92@buildbot.net> #2133: Cannot open 'stdio' links from buildbot waterfall ----------------------------+------------------------ Reporter: cwilson | Owner: Type: support-request | Status: new Priority: minor | Milestone: undecided Version: 0.7.12 | Resolution: Keywords: | ----------------------------+------------------------ Comment (by cwilson): No proxy, no. Thanks for the tip about twistd.log. Stupidly hadn't thought to look there. I do get an exception when clicking on a link but unfortunately it keeps getting flagged as spam content when I try to paste it here so I've thrown it on pastebin instead: http://pastebin.com/Mp0BWUEu Looking into it now. Thanks. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Oct 16 03:31:01 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 16 Oct 2011 03:31:01 -0000 Subject: [Buildbot-commits] [Buildbot] #2133: Cannot open 'stdio' links from buildbot waterfall In-Reply-To: <039.e84af97199d81966cd249330b74ead62@buildbot.net> References: <039.e84af97199d81966cd249330b74ead62@buildbot.net> Message-ID: <054.c4712f27c2c360e8c5f02d599ffdca7b@buildbot.net> #2133: Cannot open 'stdio' links from buildbot waterfall ----------------------------+------------------------ Reporter: cwilson | Owner: Type: support-request | Status: new Priority: minor | Milestone: undecided Version: 0.7.12 | Resolution: Keywords: | ----------------------------+------------------------ Comment (by dustin): Darn spam filters! {{{ 2011-10-15 23:08:24-0400 [-] Unhandled Error Traceback (most recent call last): File "/usr/lib/python2.7/dist- packages/twisted/application/app.py", line 390, in startReactor self.config, oldstdout, oldstderr, self.profiler, reactor) File "/usr/lib/python2.7/dist- packages/twisted/application/app.py", line 311, in runReactorWithLogging reactor.run() File "/usr/lib/python2.7/dist- packages/twisted/internet/base.py", line 1158, in run self.mainLoop() File "/usr/lib/python2.7/dist- packages/twisted/internet/base.py", line 1167, in mainLoop self.runUntilCurrent() --- --- File "/usr/lib/python2.7/dist- packages/twisted/internet/base.py", line 789, in runUntilCurrent call.func(*call.args, **call.kw) File "/usr/lib/python2.7/dist- packages/buildbot/status/builder.py", line 178, in _resumeProducing chunk = self.chunkGenerator.next() File "/usr/lib/python2.7/dist- packages/buildbot/status/builder.py", line 119, in getChunks p.dataReceived(data) File "/usr/lib/python2.7/dist- packages/twisted/protocols/basic.py", line 178, in dataReceived self._remainingData += data exceptions.AttributeError: LogFileScanner instance has no attribute '_remainingData' }}} -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Oct 16 03:34:30 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 16 Oct 2011 03:34:30 -0000 Subject: [Buildbot-commits] [Buildbot] #2133: Cannot open 'stdio' links from buildbot waterfall In-Reply-To: <039.e84af97199d81966cd249330b74ead62@buildbot.net> References: <039.e84af97199d81966cd249330b74ead62@buildbot.net> Message-ID: <054.499e3bb7a3ae0fb595e5c9bacf1e49a9@buildbot.net> #2133: Cannot open 'stdio' links from buildbot waterfall ----------------------------+------------------------- Reporter: cwilson | Owner: Type: support-request | Status: closed Priority: minor | Milestone: ongoing Version: 0.7.12 | Resolution: worksforme Keywords: | ----------------------------+------------------------- Changes (by dustin): * status: new => closed * resolution: => worksforme * milestone: undecided => ongoing Comment: Ah, yes.. that was fixed quite a while ago! It's an incompatibility between Buildbot and newer versions of Twisted. You'd probably do best to upgrade to a reasonably recent version using a virtualenv, rather than trying to backport this patch. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Oct 16 04:03:00 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 16 Oct 2011 04:03:00 -0000 Subject: [Buildbot-commits] [Buildbot] #2133: Cannot open 'stdio' links from buildbot waterfall In-Reply-To: <039.e84af97199d81966cd249330b74ead62@buildbot.net> References: <039.e84af97199d81966cd249330b74ead62@buildbot.net> Message-ID: <054.0459a39b945ce7ad2c15ee4588a9c887@buildbot.net> #2133: Cannot open 'stdio' links from buildbot waterfall ----------------------------+------------------------- Reporter: cwilson | Owner: Type: support-request | Status: closed Priority: minor | Milestone: ongoing Version: 0.7.12 | Resolution: worksforme Keywords: | ----------------------------+------------------------- Comment (by cwilson): Thanks, upgrading buildbot beyond the default packages worked. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sun Oct 16 05:22:29 2011 From: noreply at github.com (noreply at github.com) Date: Sat, 15 Oct 2011 22:22:29 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 5c91ef: Do not assume the value of COMSPEC in tests Message-ID: <20111016052229.A8A5D426AF@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 5c91efa0911b672cf997b4fff33b18103db21e76 https://github.com/buildbot/buildbot/commit/5c91efa0911b672cf997b4fff33b18103db21e76 Author: Dustin J. Mitchell Date: 2011-10-15 (Sat, 15 Oct 2011) Changed paths: M master/buildbot/test/unit/test_steps_master.py Log Message: ----------- Do not assume the value of COMSPEC in tests From nobody at buildbot.net Sun Oct 16 11:01:33 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 16 Oct 2011 11:01:33 -0000 Subject: [Buildbot-commits] [Buildbot] #2132: Builder status in waterfall not updated In-Reply-To: <041.4a880c39b94b8731b1b9377f4a70dea4@buildbot.net> References: <041.4a880c39b94b8731b1b9377f4a70dea4@buildbot.net> Message-ID: <056.9581340363b0c42cee716e3a0051ffc1@buildbot.net> #2132: Builder status in waterfall not updated ----------------------+------------------------ Reporter: homer5439 | Owner: Type: defect | Status: new Priority: minor | Milestone: undecided Version: 0.8.5 | Resolution: Keywords: | ----------------------+------------------------ Comment (by homer5439): I'm using 0.8.5 on suse from OBS: # rpm -qa | grep buildbot buildbot-master-0.8.5-1.1 buildbot-slave-0.8.5-1.1 Perhaps any of the depedencies? (can provide all the info) -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sun Oct 16 20:07:19 2011 From: noreply at github.com (noreply at github.com) Date: Sun, 16 Oct 2011 13:07:19 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] d5afb9: docs cleanup Message-ID: <20111016200719.819BB4264D@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: d5afb9ade5b926c9811e01e2cf53edcd0ca4a25e https://github.com/buildbot/buildbot/commit/d5afb9ade5b926c9811e01e2cf53edcd0ca4a25e Author: Dustin J. Mitchell Date: 2011-10-16 (Sun, 16 Oct 2011) Changed paths: M master/docs/developer/database.rst M master/docs/developer/index.rst Log Message: ----------- docs cleanup From nobody at buildbot.net Mon Oct 17 08:31:40 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 17 Oct 2011 08:31:40 -0000 Subject: [Buildbot-commits] [Buildbot] #2134: Exception while releasing lock for a slave Message-ID: <041.fc6bc0cfce9cc402abb04e3dfb3b835e@buildbot.net> #2134: Exception while releasing lock for a slave ----------------------+----------------------- Reporter: homer5439 | Owner: Type: undecided | Status: new Priority: minor | Milestone: undecided Version: 0.8.5 | Keywords: ----------------------+----------------------- See the attached file for the exception I see in the master's log. Now build requests get stuck enqueued at the slave and are never run. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Oct 17 08:33:03 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 17 Oct 2011 08:33:03 -0000 Subject: [Buildbot-commits] [Buildbot] #2134: Exception while releasing lock for a slave In-Reply-To: <041.fc6bc0cfce9cc402abb04e3dfb3b835e@buildbot.net> References: <041.fc6bc0cfce9cc402abb04e3dfb3b835e@buildbot.net> Message-ID: <056.15fb16c0d85189524e83c0ae8164f2a4@buildbot.net> #2134: Exception while releasing lock for a slave ----------------------+------------------------ Reporter: homer5439 | Owner: Type: undecided | Status: new Priority: minor | Milestone: undecided Version: 0.8.5 | Resolution: Keywords: | ----------------------+------------------------ Comment (by homer5439): Sorry, I can't insert the exception either inline or as attachment because the system rejects it as spam. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Oct 17 20:40:35 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 17 Oct 2011 20:40:35 -0000 Subject: [Buildbot-commits] [Buildbot] #2135: GitPoller problem "OSError: [Errno 2] No such file or directory" Message-ID: <038.106b9cd0873ca484123663239440f0c1@buildbot.net> #2135: GitPoller problem "OSError: [Errno 2] No such file or directory" ----------------------+----------------------- Reporter: pigmej | Owner: Type: undecided | Status: new Priority: major | Milestone: undecided Version: 0.8.5 | Keywords: ----------------------+----------------------- traceback: {{{ 2011-10-17 22:34:39+0200 [-] while initializing GitPoller repository Traceback (most recent call last): File "/opt/buildbot/buildbot_env/lib/python2.6/site- packages/twisted/internet/_baseprocess.py", line 60, in maybeCallProcessEnded proto.processEnded(Failure(reason)) File "/opt/buildbot/buildbot_env/lib/python2.6/site- packages/twisted/internet/utils.py", line 159, in processEnded self.deferred.callback((out, err, code)) File "/opt/buildbot/buildbot_env/lib/python2.6/site- packages/twisted/internet/defer.py", line 361, in callback self._startRunCallbacks(result) File "/opt/buildbot/buildbot_env/lib/python2.6/site- packages/twisted/internet/defer.py", line 455, in _startRunCallbacks self._runCallbacks() --- --- File "/opt/buildbot/buildbot_env/lib/python2.6/site- packages/twisted/internet/defer.py", line 542, in _runCallbacks current.result = callback(current.result, *args, **kw) File "/opt/buildbot/buildbot_env/lib/python2.6/site- packages/buildbot/changes/gitpoller.py", line 318, in _convert_nonzero_to_failure raise EnvironmentError('command failed with exit code %d: %s' % (code, stderr)) exceptions.EnvironmentError: command failed with exit code 1: Upon execvpe git ['git', 'init', '/tmp/gitpoller_work'] in environment id 38200288 :Traceback (most recent call last): File "/opt/buildbot/buildbot_env/lib/python2.6/site- packages/twisted/internet/process.py", line 414, in _fork executable, args, environment) File "/opt/buildbot/buildbot_env/lib/python2.6/site- packages/twisted/internet/process.py", line 460, in _execChild os.execvpe(executable, args, environment) File "/opt/buildbot/buildbot_env/lib/python2.6/os.py", line 353, in execvpe _execvpe(file, args, env) File "/opt/buildbot/buildbot_env/lib/python2.6/os.py", line 380, in _execvpe func(fullname, *argrest) OSError: [Errno 2] No such file or directory }}} poller config: {{{ c['change_source'] = GitPoller( repourl = 'git://url/repo.git', branch = 'master', pollinterval=30) }}} -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Oct 17 21:35:10 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 17 Oct 2011 21:35:10 -0000 Subject: [Buildbot-commits] [Buildbot] #2135: GitPoller problem "OSError: [Errno 2] No such file or directory" In-Reply-To: <038.106b9cd0873ca484123663239440f0c1@buildbot.net> References: <038.106b9cd0873ca484123663239440f0c1@buildbot.net> Message-ID: <053.493da228fbcc3c1aa55daa8ec49061e4@buildbot.net> #2135: GitPoller problem "OSError: [Errno 2] No such file or directory" ----------------------+------------------------ Reporter: pigmej | Owner: Type: undecided | Status: closed Priority: major | Milestone: undecided Version: 0.8.5 | Resolution: invalid Keywords: | ----------------------+------------------------ Changes (by pigmej): * status: new => closed * resolution: => invalid Comment: Ok apt-get install git-core fixed it :) -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Wed Oct 19 21:24:46 2011 From: noreply at github.com (noreply at github.com) Date: Wed, 19 Oct 2011 14:24:46 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 0dc606: Be more specific when complaining about unknown bu... Message-ID: <20111019212446.935574273B@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 0dc6060fe10ae1421d95ac71b6df186e7d92225d https://github.com/buildbot/buildbot/commit/0dc6060fe10ae1421d95ac71b6df186e7d92225d Author: John Ford Date: 2011-10-19 (Wed, 19 Oct 2011) Changed paths: M master/buildbot/master.py Log Message: ----------- Be more specific when complaining about unknown builder Commit: 71fa644eccfaa2c910754b92f378f3b8d5db6bfa https://github.com/buildbot/buildbot/commit/71fa644eccfaa2c910754b92f378f3b8d5db6bfa Author: John Ford Date: 2011-10-19 (Wed, 19 Oct 2011) Changed paths: M master/buildbot/master.py Log Message: ----------- print all unknown builders instead of just the first one Commit: 8ad77a0c3421781ca4d4e130fba0cdb0341ea4c6 https://github.com/buildbot/buildbot/commit/8ad77a0c3421781ca4d4e130fba0cdb0341ea4c6 Author: Dustin J. Mitchell Date: 2011-10-19 (Wed, 19 Oct 2011) Changed paths: M master/buildbot/master.py Log Message: ----------- Merge branch 'master' of https://github.com/jhford/buildbot-1 * 'master' of https://github.com/jhford/buildbot-1: print all unknown builders instead of just the first one Be more specific when complaining about unknown builder Compare: https://github.com/buildbot/buildbot/compare/d5afb9a...8ad77a0 From noreply at github.com Thu Oct 20 19:30:33 2011 From: noreply at github.com (noreply at github.com) Date: Thu, 20 Oct 2011 12:30:33 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 7d0ff3: Support properties with colons in them in the comm... Message-ID: <20111020193033.270A7427AD@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 7d0ff3269bc8332159cda19eebf18e6da5fbce62 https://github.com/buildbot/buildbot/commit/7d0ff3269bc8332159cda19eebf18e6da5fbce62 Author: Ben Hearsum Date: 2011-10-20 (Thu, 20 Oct 2011) Changed paths: M master/buildbot/scripts/runner.py M master/buildbot/test/unit/test_scripts_runner.py Log Message: ----------- Support properties with colons in them in the command-line sendchange client From nobody at buildbot.net Fri Oct 21 17:23:52 2011 From: nobody at buildbot.net (Buildbot) Date: Fri, 21 Oct 2011 17:23:52 -0000 Subject: [Buildbot-commits] [Buildbot] #2136: support binary log files in build steps Message-ID: <039.4c41784b1676f3669d61fe2781986672@buildbot.net> #2136: support binary log files in build steps ------------------------+--------------------------- Reporter: brendan | Owner: Type: enhancement | Status: new Priority: minor | Milestone: undecided Version: 0.8.5 | Keywords: web buildstep ------------------------+--------------------------- I have buildsteps that produce a tarball containing debug information (coredumps etc) when tests fail. I'd like to include these as log files so that I can grab them from the summary page. Adding them as logfiles sort of works, but when I click on the link it comes back as text/html that my browser attempts to render. I'd like to be able to just download it directly. Ideally, I'd just flag a log file as binary in the buildstep constructor. For reference, I've attached the hack I'm using right now (I am not proposing to include this patch). -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Mon Oct 24 20:53:34 2011 From: noreply at github.com (noreply at github.com) Date: Mon, 24 Oct 2011 13:53:34 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] f8b43e: Add support for patch_subdir to SourceStamp Message-ID: <20111024205334.B8ACB42417@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: f8b43eeea3ac09c0281d391ca6bf7ad745c05376 https://github.com/buildbot/buildbot/commit/f8b43eeea3ac09c0281d391ca6bf7ad745c05376 Author: Marc-Antoine Ruel Date: 2011-10-24 (Mon, 24 Oct 2011) Changed paths: M master/buildbot/sourcestamp.py Log Message: ----------- Add support for patch_subdir to SourceStamp Commit: 9750abc01c6420fd1f8a9cffb48a25e4ead6f96f https://github.com/buildbot/buildbot/commit/9750abc01c6420fd1f8a9cffb48a25e4ead6f96f Author: Marc-Antoine Ruel Date: 2011-10-24 (Mon, 24 Oct 2011) Changed paths: M master/buildbot/test/unit/test_sourcestamp.py Log Message: ----------- Update test_sourcestamp Commit: da3ee2073b28fd838dbea53e4ef4ebda5f774e09 https://github.com/buildbot/buildbot/commit/da3ee2073b28fd838dbea53e4ef4ebda5f774e09 Author: Amber Yust Date: 2011-10-24 (Mon, 24 Oct 2011) Changed paths: M master/buildbot/sourcestamp.py M master/buildbot/test/unit/test_sourcestamp.py Log Message: ----------- Merge pull request #272 from maruel/bb_sourcestamp Compare: https://github.com/buildbot/buildbot/compare/7d0ff32...da3ee20 From noreply at github.com Mon Oct 24 23:49:58 2011 From: noreply at github.com (noreply at github.com) Date: Mon, 24 Oct 2011 16:49:58 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] b46cb0: Merge pull request #271 from bobbyi/master Message-ID: <20111024234958.2DAAF4240F@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: b46cb09ccdfe660ac7b7ae6eab868f02cf5fda79 https://github.com/buildbot/buildbot/commit/b46cb09ccdfe660ac7b7ae6eab868f02cf5fda79 Author: Amber Yust Date: 2011-10-24 (Mon, 24 Oct 2011) Changed paths: M master/contrib/svn_buildbot.py M master/docs/manual/cfg-builders.rst Log Message: ----------- Merge pull request #271 from bobbyi/master Update contrib/svn_buildbot.py to allow specifying username/ password for PBChangeSource From noreply at github.com Tue Oct 25 19:46:53 2011 From: noreply at github.com (noreply at github.com) Date: Tue, 25 Oct 2011 12:46:53 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 518fda: Merge pull request #273 from maruel/bb_sourcestamp... Message-ID: <20111025194653.5E24642547@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 518fdacdecc4eafcb834bf67bd7ac3ee0ceba669 https://github.com/buildbot/buildbot/commit/518fdacdecc4eafcb834bf67bd7ac3ee0ceba669 Author: Amber Yust Date: 2011-10-25 (Tue, 25 Oct 2011) Changed paths: M master/buildbot/sourcestamp.py Log Message: ----------- Merge pull request #273 from maruel/bb_sourcestamp2 Change SourceStamp.canBeMergedWith to behave like described in the doc. From nobody at buildbot.net Wed Oct 26 08:09:14 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 26 Oct 2011 08:09:14 -0000 Subject: [Buildbot-commits] [Buildbot] #2132: Builder status in waterfall not updated In-Reply-To: <041.4a880c39b94b8731b1b9377f4a70dea4@buildbot.net> References: <041.4a880c39b94b8731b1b9377f4a70dea4@buildbot.net> Message-ID: <056.bbf2c1119b5b1a89de1aded829252e5e@buildbot.net> #2132: Builder status in waterfall not updated ----------------------+------------------------ Reporter: homer5439 | Owner: Type: defect | Status: new Priority: minor | Milestone: undecided Version: 0.8.5 | Resolution: Keywords: | ----------------------+------------------------ Comment (by tonylazarew): I confirm, we're also seeing this on 0.8.5 downloaded from buildbot.net: http://buildbot.googlecode.com/files/buildbot-0.8.5.tar.gz Btw, right now this happening to 'docs' builder in metabuildbot: http://buildbot.buildbot.net/waterfall?show=docs -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Oct 26 08:10:27 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 26 Oct 2011 08:10:27 -0000 Subject: [Buildbot-commits] [Buildbot] #2132: Builder status in waterfall not updated In-Reply-To: <041.4a880c39b94b8731b1b9377f4a70dea4@buildbot.net> References: <041.4a880c39b94b8731b1b9377f4a70dea4@buildbot.net> Message-ID: <056.6174dcd131dbcabd6a0424599d0c49c2@buildbot.net> #2132: Builder status in waterfall not updated ----------------------+------------------------ Reporter: homer5439 | Owner: Type: defect | Status: new Priority: minor | Milestone: undecided Version: 0.8.5 | Resolution: Keywords: | ----------------------+------------------------ Changes (by tonylazarew): * cc: tony@? (added) -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Oct 26 12:00:07 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 26 Oct 2011 12:00:07 -0000 Subject: [Buildbot-commits] [Buildbot] #845: shutil.copytree timeout for mode=copy In-Reply-To: <036.258f92bf68d08b55c6f985d5134094ef@buildbot.net> References: <036.258f92bf68d08b55c6f985d5134094ef@buildbot.net> Message-ID: <051.aa42b62d7095297ac8ad036d563191c6@buildbot.net> #845: shutil.copytree timeout for mode=copy --------------------+-------------------- Reporter: phil | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.+ Version: 0.7.12 | Resolution: Keywords: windows | --------------------+-------------------- Comment (by phil): I guess that would work if errors in shutil.copy are caught properly and signalled to the main thread. Any chance this fix would be available for 8.6? -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Thu Oct 27 15:19:24 2011 From: nobody at buildbot.net (Buildbot) Date: Thu, 27 Oct 2011 15:19:24 -0000 Subject: [Buildbot-commits] [Buildbot] #2137: Cache slave information on master Message-ID: <038.f26f9ab318df9cac4be74655285c5715@buildbot.net> #2137: Cache slave information on master ------------------------+----------------------- Reporter: tfogal | Owner: Type: enhancement | Status: new Priority: minor | Milestone: undecided Version: 0.8.5 | Keywords: ------------------------+----------------------- If you click a slave through the web interface, you get information on: current builds, recent builds, and connection status/information. If the slave is currently connected, you also get the information that the slave configured for "Administrator" and "Information", plus a graceful shutdown button. I have lots of slaves and I keep them named based on OS type, and then keep the hostname or some hint to it in the slave information, so that when something goes wrong I know where to ssh and fix it. Unfortunately if "something wrong" == "the slave disconnects", I have a difficult time identifying where to go and fix the problem. So: can the master please cache the "Administrator" and "Information" and display the last-known values, even when the slave is not connected? -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Oct 28 01:12:10 2011 From: nobody at buildbot.net (Buildbot) Date: Fri, 28 Oct 2011 01:12:10 -0000 Subject: [Buildbot-commits] [Buildbot] #2005: SQLAlchemy Operational errors with SQLite: Database is locked In-Reply-To: <040.08a071a74acf7400775dd33a90e10ace@buildbot.net> References: <040.08a071a74acf7400775dd33a90e10ace@buildbot.net> Message-ID: <055.cb269aa68307fbbf2b74c4b902c16bf1@buildbot.net> #2005: SQLAlchemy Operational errors with SQLite: Database is locked ---------------------+------------------------- Reporter: abompard | Owner: Type: defect | Status: closed Priority: critical | Milestone: 0.8.5 Version: 0.8.4p1 | Resolution: worksforme Keywords: database | ---------------------+------------------------- Comment (by dustin): duped from #2134 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Oct 28 01:13:27 2011 From: nobody at buildbot.net (Buildbot) Date: Fri, 28 Oct 2011 01:13:27 -0000 Subject: [Buildbot-commits] [Buildbot] #2134: Exception while releasing lock for a slave In-Reply-To: <041.fc6bc0cfce9cc402abb04e3dfb3b835e@buildbot.net> References: <041.fc6bc0cfce9cc402abb04e3dfb3b835e@buildbot.net> Message-ID: <056.fa63aed361550f168aed8241102f3534@buildbot.net> #2134: Exception while releasing lock for a slave ----------------------+------------------------ Reporter: homer5439 | Owner: Type: undecided | Status: closed Priority: minor | Milestone: undecided Version: 0.8.5 | Resolution: duplicate Keywords: | ----------------------+------------------------ Changes (by dustin): * status: new => closed * resolution: => duplicate Comment: {{{ [-] releaseLocks(): [] [-] in maybeStartBuild for Traceback (most recent call last): File "/usr/lib64/python2.6/site- packages/twisted/internet/defer.py", line 388, in errback self._startRunCallbacks(fail) File "/usr/lib64/python2.6/site- packages/twisted/internet/defer.py", line 455, in _startRunCallbacks self._runCallbacks() File "/usr/lib64/python2.6/site- packages/twisted/internet/defer.py", line 542, in _runCallbacks current.result = callback(current.result, *args, **kw) File "/usr/lib64/python2.6/site- packages/twisted/internet/defer.py", line 891, in gotResult _deferGenerator(g, deferred) --- --- File "/usr/lib64/python2.6/site- packages/twisted/internet/defer.py", line 866, in _deferGenerator result = g.next() File "/usr/lib64/python2.6/site- packages/buildbot/process/builder.py", line 698, in maybeStartBuild wfd.getResult() File "/usr/lib64/python2.6/site- packages/twisted/internet/defer.py", line 845, in getResult self.result.raiseException() File "/usr/lib64/python2.6/site- packages/twisted/python/threadpool.py", line 207, in _worker result = context.call(ctx, function, *args, **kwargs) File "/usr/lib64/python2.6/site- packages/twisted/python/context.py", line 118, in callWithContext return self.currentContext().callWithContext(ctx, func, *args, **kw) File "/usr/lib64/python2.6/site- packages/twisted/python/context.py", line 81, in callWithContext return func(*args,**kw) File "/usr/lib64/python2.6/site-packages/buildbot/db/pool.py", line 128, in thd rv = callable(conn, *args, **kwargs) File "/usr/lib64/python2.6/site- packages/buildbot/db/buildrequests.py", line 111, in thd for id in brids ]) File "/usr/lib64/python2.6/site- packages/sqlalchemy/engine/base.py", line 1399, in execute params) File "/usr/lib64/python2.6/site- packages/sqlalchemy/engine/base.py", line 1532, in _execute_clauseelement compiled_sql, distilled_params File "/usr/lib64/python2.6/site- packages/sqlalchemy/engine/base.py", line 1640, in _execute_context context) File "/usr/lib64/python2.6/site- packages/sqlalchemy/engine/base.py", line 1633, in _execute_context context) File "/usr/lib64/python2.6/site- packages/sqlalchemy/engine/default.py", line 325, in do_execute cursor.execute(statement, parameters) sqlalchemy.exc.OperationalError: (OperationalError) database is locked u'INSERT INTO buildrequest_claims (brid, objectid, claimed_at) VALUES (?, ?, ?)' (650, 4, 1318838031.52985) }}} See #2005. If you're using an older version of Buildbot, you can set WAL mode by hand. Otherwise, you may need a more recent version of SQLite that supports WAL mode. If this is the case, you'll see a warning in the logfile at Buildbot startup. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Oct 28 01:36:52 2011 From: nobody at buildbot.net (Buildbot) Date: Fri, 28 Oct 2011 01:36:52 -0000 Subject: [Buildbot-commits] [Buildbot] #2136: support binary log files in build steps In-Reply-To: <039.4c41784b1676f3669d61fe2781986672@buildbot.net> References: <039.4c41784b1676f3669d61fe2781986672@buildbot.net> Message-ID: <054.55bbf22f93aee2fbcc353cf6f34b1c0f@buildbot.net> #2136: support binary log files in build steps --------------------------+------------------------- Reporter: brendan | Owner: Type: enhancement | Status: closed Priority: minor | Milestone: undecided Version: 0.8.5 | Resolution: worksforme Keywords: web buildstep | --------------------------+------------------------- Changes (by dustin): * status: new => closed * resolution: => worksforme Comment: That's pretty much the correct strategy. It'd be nice if it was easier, but you seem to have implemented it quite well :) -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Oct 28 01:37:13 2011 From: nobody at buildbot.net (Buildbot) Date: Fri, 28 Oct 2011 01:37:13 -0000 Subject: [Buildbot-commits] [Buildbot] #2136: support binary log files in build steps In-Reply-To: <039.4c41784b1676f3669d61fe2781986672@buildbot.net> References: <039.4c41784b1676f3669d61fe2781986672@buildbot.net> Message-ID: <054.e0ba74738f877ff627803a5a5ed16cbd@buildbot.net> #2136: support binary log files in build steps ------------------------+------------------------- Reporter: brendan | Owner: Type: enhancement | Status: closed Priority: minor | Milestone: undecided Version: 0.8.5 | Resolution: worksforme Keywords: web | ------------------------+------------------------- Changes (by dustin): * keywords: web buildstep => web -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Oct 28 01:50:18 2011 From: nobody at buildbot.net (Buildbot) Date: Fri, 28 Oct 2011 01:50:18 -0000 Subject: [Buildbot-commits] [Buildbot] #2137: Cache slave information on master In-Reply-To: <038.f26f9ab318df9cac4be74655285c5715@buildbot.net> References: <038.f26f9ab318df9cac4be74655285c5715@buildbot.net> Message-ID: <053.086c1ce117c7af6b9cc9ddd956738d27@buildbot.net> #2137: Cache slave information on master ------------------------+-------------------- Reporter: tfogal | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.6 Version: 0.8.5 | Resolution: Keywords: simple | ------------------------+-------------------- Changes (by dustin): * keywords: => simple * milestone: undecided => 0.8.6 Comment: A runtime (memory) cache should be easy enough. Ideally this would go into the DB eventually. Perhaps someone can work on this? -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Oct 28 02:03:40 2011 From: nobody at buildbot.net (Buildbot) Date: Fri, 28 Oct 2011 02:03:40 -0000 Subject: [Buildbot-commits] [Buildbot] #845: shutil.copytree timeout for mode=copy In-Reply-To: <036.258f92bf68d08b55c6f985d5134094ef@buildbot.net> References: <036.258f92bf68d08b55c6f985d5134094ef@buildbot.net> Message-ID: <051.855e49ea413480aad489aa548af0b02f@buildbot.net> #845: shutil.copytree timeout for mode=copy ----------------------------+-------------------- Reporter: phil | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.+ Version: 0.7.12 | Resolution: Keywords: windows, simple | ----------------------------+-------------------- Changes (by dustin): * keywords: windows => windows, simple Comment: I can't promise it will be implemented, but it should be simple enough for someone with a bit of twisted skills to handle - basically just {{{deferToThread}}} or {{{callInThread}}}. There are some examples in {{{master/buildbot/db/pool.py}}}. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Oct 28 02:04:21 2011 From: nobody at buildbot.net (Buildbot) Date: Fri, 28 Oct 2011 02:04:21 -0000 Subject: [Buildbot-commits] [Buildbot] #2132: Builder status in waterfall not updated In-Reply-To: <041.4a880c39b94b8731b1b9377f4a70dea4@buildbot.net> References: <041.4a880c39b94b8731b1b9377f4a70dea4@buildbot.net> Message-ID: <056.8b92390e2667dc44c86ed77a21290fa8@buildbot.net> #2132: Builder status in waterfall not updated ----------------------+------------------------ Reporter: homer5439 | Owner: Type: defect | Status: new Priority: minor | Milestone: undecided Version: 0.8.5 | Resolution: Keywords: | ----------------------+------------------------ Comment (by dustin): Indeed, it is. That "big status" just doesn't want to stay updated correctly. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Oct 28 13:46:36 2011 From: nobody at buildbot.net (Buildbot) Date: Fri, 28 Oct 2011 13:46:36 -0000 Subject: [Buildbot-commits] [Buildbot] #845: shutil.copytree timeout for mode=copy In-Reply-To: <036.258f92bf68d08b55c6f985d5134094ef@buildbot.net> References: <036.258f92bf68d08b55c6f985d5134094ef@buildbot.net> Message-ID: <051.2bc6093237ab53a4da58777624e033d2@buildbot.net> #845: shutil.copytree timeout for mode=copy ----------------------------+-------------------- Reporter: phil | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.+ Version: 0.7.12 | Resolution: Keywords: windows, simple | ----------------------------+-------------------- Comment (by phil): Hello Dustin I've only used Python for configuring buildbot and Twisted is a box of magic to me but you make it sound like we could replace the if runtime.platformType != "posix": self.sendStatus({'header': "Since we're on a non-POSIX platform, " "we're not going to try to execute cp in a subprocess, but instead " "use shutil.copytree(), which will block until it is complete. " "fromdir: %s, todir: %s\n" % (fromdir, todir)}) shutil.copytree(fromdir, todir) d = defer.succeed(0) else: by something such as if runtime.platformType != "posix": d = ?.deferToThread(shutil.copy, fromdir, todir) # add some error callback here? return d else: to resolve the timeout issue? -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Oct 28 22:08:29 2011 From: nobody at buildbot.net (Buildbot) Date: Fri, 28 Oct 2011 22:08:29 -0000 Subject: [Buildbot-commits] [Buildbot] #2134: Exception while releasing lock for a slave In-Reply-To: <041.fc6bc0cfce9cc402abb04e3dfb3b835e@buildbot.net> References: <041.fc6bc0cfce9cc402abb04e3dfb3b835e@buildbot.net> Message-ID: <056.826054de39ea52881e9c59876a06c3ac@buildbot.net> #2134: Exception while releasing lock for a slave ----------------------+------------------------ Reporter: homer5439 | Owner: Type: undecided | Status: closed Priority: minor | Milestone: undecided Version: 0.8.5 | Resolution: duplicate Keywords: | ----------------------+------------------------ Comment (by homer5439): I have buildbot 0.8.5, and sqlite 3.6.4. Unless I'm grepping for the wrong keywords, I don't get any warning, but just: setting database journal mode to 'wal' Using SQLite Version (3, 6, 4) Applying SQLite workaround from Buildbot but #1810 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Oct 28 22:16:04 2011 From: nobody at buildbot.net (Buildbot) Date: Fri, 28 Oct 2011 22:16:04 -0000 Subject: [Buildbot-commits] [Buildbot] #2134: Exception while releasing lock for a slave In-Reply-To: <041.fc6bc0cfce9cc402abb04e3dfb3b835e@buildbot.net> References: <041.fc6bc0cfce9cc402abb04e3dfb3b835e@buildbot.net> Message-ID: <056.e9a48786175a6db4bf223de2a5cdde22@buildbot.net> #2134: Exception while releasing lock for a slave ----------------------+------------------------ Reporter: homer5439 | Owner: Type: undecided | Status: closed Priority: minor | Milestone: undecided Version: 0.8.5 | Resolution: duplicate Keywords: | ----------------------+------------------------ Comment (by dustin): Sorry, the warning was added after 0.8.5. You need at least sqlite 3.7 to get WAL logging. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Oct 28 22:18:28 2011 From: nobody at buildbot.net (Buildbot) Date: Fri, 28 Oct 2011 22:18:28 -0000 Subject: [Buildbot-commits] [Buildbot] #845: shutil.copytree timeout for mode=copy In-Reply-To: <036.258f92bf68d08b55c6f985d5134094ef@buildbot.net> References: <036.258f92bf68d08b55c6f985d5134094ef@buildbot.net> Message-ID: <051.a617874012a9d3d3ae0571ce0dafe88f@buildbot.net> #845: shutil.copytree timeout for mode=copy ----------------------------+-------------------- Reporter: phil | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.+ Version: 0.7.12 | Resolution: Keywords: windows, simple | ----------------------------+-------------------- Comment (by dustin): You're definitely on the right track. The `?` is `reactor`, which you can import with `from twisted.internet import reactor` if it's not already imported in that file. Do you want to test it out and make a patch? Please let me know how you should be credited. I'll add tests as necessary. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Oct 29 07:45:24 2011 From: nobody at buildbot.net (Buildbot) Date: Sat, 29 Oct 2011 07:45:24 -0000 Subject: [Buildbot-commits] [Buildbot] #845: shutil.copytree timeout for mode=copy In-Reply-To: <036.258f92bf68d08b55c6f985d5134094ef@buildbot.net> References: <036.258f92bf68d08b55c6f985d5134094ef@buildbot.net> Message-ID: <051.e9a3b6b505fc9fc4dfc75b0ae9d224a6@buildbot.net> #845: shutil.copytree timeout for mode=copy ----------------------------+-------------------- Reporter: phil | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.+ Version: 0.7.12 | Resolution: Keywords: windows, simple | ----------------------------+-------------------- Comment (by phil): We are still running 0.8.3p1 on both server and slaves. I will upgrade to 0.8.5 and insert the patches (there are a few other places where this POSIX check is present). If our builds are working without hickups I will send you the patched files for review. Is there any kind of callback required (eg to signal errors in the copytree) or is all of that handled with the deferred automatically? How can I send you the files or would you like me to attach them to this ticket? -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Oct 29 19:25:10 2011 From: nobody at buildbot.net (Buildbot) Date: Sat, 29 Oct 2011 19:25:10 -0000 Subject: [Buildbot-commits] [Buildbot] #845: shutil.copytree timeout for mode=copy In-Reply-To: <036.258f92bf68d08b55c6f985d5134094ef@buildbot.net> References: <036.258f92bf68d08b55c6f985d5134094ef@buildbot.net> Message-ID: <051.7c42fa6c627a818c915e3041ecda319a@buildbot.net> #845: shutil.copytree timeout for mode=copy ----------------------------+-------------------- Reporter: phil | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.+ Version: 0.7.12 | Resolution: Keywords: windows, simple | ----------------------------+-------------------- Comment (by dustin): deferToThread handles errors as errbacks on the Deferred, so you're OK there. I'll add testes to verify. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sat Oct 29 22:04:45 2011 From: noreply at github.com (noreply at github.com) Date: Sat, 29 Oct 2011 15:04:45 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 3b3fc2: when specifying XML for the latent virtual slave, ... Message-ID: <20111029220445.50584427A5@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 3b3fc2ef569438d33c6011c6a0574c061ceef2de https://github.com/buildbot/buildbot/commit/3b3fc2ef569438d33c6011c6a0574c061ceef2de Author: Charles Hardin Date: 2011-10-29 (Sat, 29 Oct 2011) Changed paths: M master/buildbot/libvirtbuildslave.py Log Message: ----------- when specifying XML for the latent virtual slave, a callback still needs to be used to get the Domain object so the slave can be shutdown when the test is completed Commit: d8ac7725acfdb6df87aa376dda5c0e70b2029d7c https://github.com/buildbot/buildbot/commit/d8ac7725acfdb6df87aa376dda5c0e70b2029d7c Author: Dustin J. Mitchell Date: 2011-10-29 (Sat, 29 Oct 2011) Changed paths: M master/buildbot/libvirtbuildslave.py Log Message: ----------- Merge pull request #275 from ckhardin/master Libvirt slaves created with XML don't get shutdown Compare: https://github.com/buildbot/buildbot/compare/518fdac...d8ac772 From nobody at buildbot.net Sun Oct 30 17:25:31 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 30 Oct 2011 17:25:31 -0000 Subject: [Buildbot-commits] [Buildbot] #2138: ability to plug-in new slave-side commands Message-ID: <038.1ae0499b220d892beff33bf2becdf64d@buildbot.net> #2138: ability to plug-in new slave-side commands ------------------------+-------------------- Reporter: dustin | Owner: dustin Type: enhancement | Status: new Priority: major | Milestone: 0.8.6 Version: 0.8.5 | Keywords: ------------------------+-------------------- Some users would like to be able to add additional slave-side Command subclasses, both for performance and flexibility. Right now, you can do this from `buildbot.tac`: {{{ from buildslave.commands.registry import commandRegistry commandRegistry['mycommand'] = 'my.module.CommandClass' }}} This should be pretty easy to document, and should be tested manually to ensure there are no sharp edges or other gotchas. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Oct 31 11:07:13 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 31 Oct 2011 11:07:13 -0000 Subject: [Buildbot-commits] [Buildbot] #845: shutil.copytree timeout for mode=copy In-Reply-To: <036.258f92bf68d08b55c6f985d5134094ef@buildbot.net> References: <036.258f92bf68d08b55c6f985d5134094ef@buildbot.net> Message-ID: <051.c712e26c64ab3ca123aede398906f949@buildbot.net> #845: shutil.copytree timeout for mode=copy ----------------------------+-------------------- Reporter: phil | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.+ Version: 0.7.12 | Resolution: Keywords: windows, simple | ----------------------------+-------------------- Comment (by phil): I have attached the two files I modified (based on version buildslave-0.8.5). I have been able to test only one of the changes (base.py: doCopy) and that seems to work fine now on our Windows buildslave. Please double/triple check as I am not a python nor twisted programmer. In total two invokations of copytree and two invokations of rmdirRecursive have been modified. Use a text diff or search for "threads" in both files. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Oct 31 12:56:12 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 31 Oct 2011 12:56:12 -0000 Subject: [Buildbot-commits] [Buildbot] #845: shutil.copytree timeout for mode=copy In-Reply-To: <036.258f92bf68d08b55c6f985d5134094ef@buildbot.net> References: <036.258f92bf68d08b55c6f985d5134094ef@buildbot.net> Message-ID: <051.2dde4401f54842da732aea5fa252bcfe@buildbot.net> #845: shutil.copytree timeout for mode=copy ----------------------------+-------------------- Reporter: phil | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.+ Version: 0.7.12 | Resolution: Keywords: windows, simple | ----------------------------+-------------------- Comment (by phil): Actually I am not so sure whether it is a good idea to do the rmdirRecursive in a separate thread. Waiting for your feedback... -- Ticket URL: Buildbot Buildbot: build/test automation