[Buildbot-commits] [Buildbot] #97: Use svn switch to improve efficiency

[Buildbot]

#97: Use svn switch to improve efficiency
------------------------+------------------------
Reporter:  retracile    |       Owner:
    Type:  enhancement  |      Status:  reopened
Priority:  major        |   Milestone:  undecided
 Version:  0.7.5        |  Resolution:
Keywords:               |
------------------------+------------------------
Changes (by duncanphilipnorman):

 * cc: duncanphilipnorman@… (added)
 * status:  closed => reopened
 * resolution:  wontfix =>


Comment:

 Replying to [comment:1 dustin]:
 > You write:
 >  An 'svn switch' of a working copy containing unversioned files can in
 some cases fail; that is not handled in this patch.
 > which is what worries me.  I'm always in favor of burning a few more
 cycles over introducing spurious build failures.
 I'm using a similar patch against [milestone:0.8.3], which I'll attach as
 [attachment:buildbot-slave-0.8.3-svn_switch.patch].

 Here's why I think the patch (or the one above) should be reconsidered,
 despite `svn switch` sometimes failing:
  1. Saves a ton of resources when using a single builder for multiple
 branches (common situation).
  1. Low risk, since `SourceBaseCommand.doVC` uses
 `SourceBaseCommand.maybeDoVCFallback` if the update fails.
   * `maybeDoVCFallback` calls `doClobber` and then `doVCFull`.
   * In particular, if the `update`/`switch` fails, then we're getting the
 old behaviour (clobber and checkout).  A build step that succeeds without
 this patch will succeed with this patch (possible coding bugs aside).

 (''I hope it's okay to reopen this ticket;  let me know if I should just
 start a new one with the same summary and description.'')

-- 
Ticket URL: <http://trac.buildbot.net/ticket/97#comment:2>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation