[Buildbot-commits] [Buildbot] #2143: Mail status fails with UnicodeDecodeError

[Buildbot]

#2143: Mail status fails with UnicodeDecodeError
-------------------------+-----------------------
Reporter:  andialbrecht  |      Owner:
    Type:  defect        |     Status:  new
Priority:  major         |  Milestone:  undecided
 Version:  0.8.5         |   Keywords:
-------------------------+-----------------------
 Mail status failed to send mail when attaching a log of a !PyLint step
 where the output contained non-ASCII chars.

 Tracback:
 {{{
 2011-11-10 14:20:12+0100 [-] Exception caught notifying
 <buildbot.status.mail.MailNotifier instance at 0x928b54c> of buildFinished
 event
 2011-11-10 14:20:12+0100 [-] Unhandled Error
         Traceback (most recent call last):
           File "/home/build/.virtualenvs/buildbot/lib/python2.6/site-
 packages/buildbot/status/build.py", line 290, in buildFinished
             w.callback(self)
           File "/home/build/.virtualenvs/buildbot/lib/python2.6/site-
 packages/twisted/internet/defer.py", line 361, in callback
             self._startRunCallbacks(result)
           File "/home/build/.virtualenvs/buildbot/lib/python2.6/site-
 packages/twisted/internet/defer.py", line 455, in _startRunCallbacks
             self._runCallbacks()
           File "/home/build/.virtualenvs/buildbot/lib/python2.6/site-
 packages/twisted/internet/defer.py", line 542, in _runCallbacks
             current.result = callback(current.result, *args, **kw)
         --- <exception caught here> ---
           File "/home/build/.virtualenvs/buildbot/lib/python2.6/site-
 packages/buildbot/status/builder.py", line 535, in _buildFinished
             w.buildFinished(name, s, results)
           File "/home/build/.virtualenvs/buildbot/lib/python2.6/site-
 packages/buildbot/status/mail.py", line 412, in buildFinished
             return self.buildMessage(name, [build], results)
           File "/home/build/.virtualenvs/buildbot/lib/python2.6/site-
 packages/buildbot/status/mail.py", line 620, in buildMessage
             results, builds, patches, logs)
           File "/home/build/.virtualenvs/buildbot/lib/python2.6/site-
 packages/buildbot/status/mail.py", line 560, in createEmail
             a = MIMEText(log.getText().encode(ENCODING),
         exceptions.UnicodeDecodeError: 'ascii' codec can't decode byte
 0xc3 in position 4857: ordinal not in range(128)
 }}}

 The relevant line in !PyLint output was a FIXME with an umlaut similar to
 this one:

 {{{'W0511:810,0: FIXME (foo): Mindestl\xc3\xa4nge beachten'}}}

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2143>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation