[Buildbot-commits] [Buildbot] #180: buildbot try does the wrong thing with mercurial queues

[Buildbot]

#180: buildbot try does the wrong thing with mercurial queues
------------------------+------------------------
Reporter:  dsallings    |       Owner:  dsallings
    Type:  enhancement  |      Status:  new
Priority:  major        |   Milestone:  0.8.+
 Version:  0.7.6        |  Resolution:
Keywords:  hg           |
------------------------+------------------------

Comment (by marcusl):

 The commit was made to only disable the testTryMq() test, not the entire
 Mercurial test case, when mq is not enabled. (Since I and many others
 didn't use MQ, Mercurial tests weren't run at all.)

 That was the intention at least. Looking at it now, it seems as if
 MercurialHelper._qnew_supported might be set (or not), and the commit
 removed some code which would update that value again.

 The right thing would be to make sure that _qnew_supported has a correct
 value always, and not to rely on the unit tests to check and set it.
 (Could be a property that's set lazily inside MercurialHelper, on first
 access....)

-- 
Ticket URL: <http://trac.buildbot.net/ticket/180#comment:31>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation