From nobody at buildbot.net Tue Nov 1 05:57:29 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 01 Nov 2011 05:57:29 -0000 Subject: [Buildbot-commits] [Buildbot] #2136: support binary log files in build steps In-Reply-To: <039.4c41784b1676f3669d61fe2781986672@buildbot.net> References: <039.4c41784b1676f3669d61fe2781986672@buildbot.net> Message-ID: <054.c69ac0e7aa6ebb84f90596ce4e631090@buildbot.net> #2136: support binary log files in build steps ------------------------+------------------------- Reporter: brendan | Owner: Type: enhancement | Status: closed Priority: minor | Milestone: undecided Version: 0.8.5 | Resolution: worksforme Keywords: web | ------------------------+------------------------- Comment (by brendan): Well, alright. One of the reasons I don't like my patch is that it relies on an internal API (`transfer._FileWriter`). It would also be nice to be able to store the file alongside the other build logs in the build directory instead of stuffing them in public_html (for instance, to make it easier to garbage collect them). I think it's fair game for an enhancement request, but if you want to leave it closed I'm not going to keep reopening it :) -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Tue Nov 1 05:58:26 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 01 Nov 2011 05:58:26 -0000 Subject: [Buildbot-commits] [Buildbot] #2136: support binary log files in build steps In-Reply-To: <039.4c41784b1676f3669d61fe2781986672@buildbot.net> References: <039.4c41784b1676f3669d61fe2781986672@buildbot.net> Message-ID: <054.d8ea815031fad538d3769d9dc5eda5c3@buildbot.net> #2136: support binary log files in build steps ------------------------+------------------------ Reporter: brendan | Owner: Type: enhancement | Status: reopened Priority: minor | Milestone: undecided Version: 0.8.5 | Resolution: Keywords: web | ------------------------+------------------------ Changes (by brendan): * status: closed => reopened * resolution: worksforme => Comment: (reopening just this once, in case comments just go into the bitbucket otherwise) -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Tue Nov 1 20:40:27 2011 From: noreply at github.com (noreply at github.com) Date: Tue, 1 Nov 2011 13:40:27 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] ecf275: messageFormatter should equal html_message_formatt... Message-ID: <20111101204027.6B6B542629@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: ecf2758a235269b6c8f94ce957bf9ef255e603e2 https://github.com/buildbot/buildbot/commit/ecf2758a235269b6c8f94ce957bf9ef255e603e2 Author: John F Leach Date: 2011-11-01 (Tue, 01 Nov 2011) Changed paths: M master/docs/manual/cfg-statustargets.rst Log Message: ----------- messageFormatter should equal html_message_formatter, not message_formatter in example documentation Commit: 2e1557696a884aaccb0bfbe6e04c39f758a96846 https://github.com/buildbot/buildbot/commit/2e1557696a884aaccb0bfbe6e04c39f758a96846 Author: John F Leach Date: 2011-11-01 (Tue, 01 Nov 2011) Changed paths: M master/docs/manual/cfg-statustargets.rst Log Message: ----------- add import cgi, datetime to html_message_formatter and remove source += error Commit: ef373f8f74e4d579990aa921e41bd604f827e0c8 https://github.com/buildbot/buildbot/commit/ef373f8f74e4d579990aa921e41bd604f827e0c8 Author: Amber Yust Date: 2011-11-01 (Tue, 01 Nov 2011) Changed paths: M master/docs/manual/cfg-statustargets.rst Log Message: ----------- Merge pull request #277 from jfleach/master Updated Documentation Pull Request Compare: https://github.com/buildbot/buildbot/compare/d8ac772...ef373f8 From nobody at buildbot.net Tue Nov 1 21:56:42 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 01 Nov 2011 21:56:42 -0000 Subject: [Buildbot-commits] [Buildbot] #2139: locks held by slaves are not released when slave goes missing Message-ID: <039.9c45009795e8e9815fcee44f137bd228@buildbot.net> #2139: locks held by slaves are not released when slave goes missing ----------------------+----------------------- Reporter: dwlocks | Owner: Type: undecided | Status: new Priority: major | Milestone: undecided Version: 0.8.4p2 | Keywords: ----------------------+----------------------- It's a subtle bug. It only shows up when a slave goes missing while holding a lock. That lock is not released, and the slave (when it returns) does not pick up the same lock, so the lock is held until the buildmaster is restarted. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Tue Nov 1 23:19:51 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 01 Nov 2011 23:19:51 -0000 Subject: [Buildbot-commits] [Buildbot] #2140: Incorrect code snippet for SingleBranchScheduler Message-ID: <038.d2e499da28de4b1832935563d23d4b05@buildbot.net> #2140: Incorrect code snippet for SingleBranchScheduler -------------------+----------------------- Reporter: mmadia | Owner: Type: defect | Status: new Priority: minor | Milestone: undecided Version: 0.8.5 | Keywords: docs -------------------+----------------------- As informed on IRC (thanks again for the help!) ... The calls to SingleBranchScheduler should be using keyword arguments, i.e. key=value. Passing the arguments positionally only works for name=value. This can result in a {{{ exceptions.AssertionError: pass arguments to schedulers using keyword arguments }}} A code snippet for SingleBranchScheduler in http://buildbot.net/buildbot/docs/0.8.5/manual/cfg-schedulers.html #dependent-scheduler does not use key=value. Resultingly, additional readers may be confused. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Wed Nov 2 22:33:38 2011 From: noreply at github.com (noreply at github.com) Date: Wed, 2 Nov 2011 15:33:38 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] d49551: Fix typo in cfg-properties.rst Message-ID: <20111102223338.7226342427@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: d4955160456b4b7840598cb9f524efc624d700d8 https://github.com/buildbot/buildbot/commit/d4955160456b4b7840598cb9f524efc624d700d8 Author: Amber Yust Date: 2011-11-02 (Wed, 02 Nov 2011) Changed paths: M master/docs/manual/cfg-properties.rst Log Message: ----------- Fix typo in cfg-properties.rst From noreply at github.com Thu Nov 3 00:17:57 2011 From: noreply at github.com (noreply at github.com) Date: Wed, 2 Nov 2011 17:17:57 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] a31321: add PyWin32 requirement to docs Message-ID: <20111103001757.19F3F427B9@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: a313210f501f990413f85ce231c8608e5269d5ed https://github.com/buildbot/buildbot/commit/a313210f501f990413f85ce231c8608e5269d5ed Author: Dustin J. Mitchell Date: 2011-11-02 (Wed, 02 Nov 2011) Changed paths: M master/docs/manual/installation.rst Log Message: ----------- add PyWin32 requirement to docs From nobody at buildbot.net Thu Nov 3 04:18:31 2011 From: nobody at buildbot.net (Buildbot) Date: Thu, 03 Nov 2011 04:18:31 -0000 Subject: [Buildbot-commits] [Buildbot] #845: shutil.copytree timeout for mode=copy In-Reply-To: <036.258f92bf68d08b55c6f985d5134094ef@buildbot.net> References: <036.258f92bf68d08b55c6f985d5134094ef@buildbot.net> Message-ID: <051.26d964b6d40762c36e4bf3384de2af0c@buildbot.net> #845: shutil.copytree timeout for mode=copy ----------------------------+-------------------- Reporter: phil | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.+ Version: 0.7.12 | Resolution: Keywords: windows, simple | ----------------------------+-------------------- Comment (by dustin): Why do you think it's not a good idea? This looks fine to me - I'll test it out to be sure. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Thu Nov 3 04:20:01 2011 From: nobody at buildbot.net (Buildbot) Date: Thu, 03 Nov 2011 04:20:01 -0000 Subject: [Buildbot-commits] [Buildbot] #845: shutil.copytree timeout for mode=copy In-Reply-To: <036.258f92bf68d08b55c6f985d5134094ef@buildbot.net> References: <036.258f92bf68d08b55c6f985d5134094ef@buildbot.net> Message-ID: <051.d70e7a4eee349a8edd323e2d7049f727@buildbot.net> #845: shutil.copytree timeout for mode=copy ----------------------------+-------------------- Reporter: phil | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.+ Version: 0.7.12 | Resolution: Keywords: windows, simple | ----------------------------+-------------------- Comment (by dustin): bug845.patch is the patch equivalent of patch-unblock-windows- on-0.8.5.rar. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Thu Nov 3 08:35:03 2011 From: nobody at buildbot.net (Buildbot) Date: Thu, 03 Nov 2011 08:35:03 -0000 Subject: [Buildbot-commits] [Buildbot] #85: sometimes buildmaster does not hand pending jobs to the idle slave, even though buildmaster can ping buildslave In-Reply-To: <039.404d88a945b465fd0213d2a73a04dbcb@buildbot.net> References: <039.404d88a945b465fd0213d2a73a04dbcb@buildbot.net> Message-ID: <054.fd8dca0011d086b96a8843f337366651@buildbot.net> #85: sometimes buildmaster does not hand pending jobs to the idle slave, even though buildmaster can ping buildslave ---------------------------+--------------------- Reporter: joduinn | Owner: dustin Type: defect | Status: closed Priority: major | Milestone: 0.7.10 Version: 0.7.5 | Resolution: fixed Keywords: virtualization | ---------------------------+--------------------- Comment (by dyzmillz80): I in addition to my pals appeared to be digesting the great tips and tricks on the website and all of the sudden I got a horrible suspicion I had not thanked the website owner for those tips. Those young men happened to be absolutely happy to study all of them and already have sincerely been making the most of them. I appreciate you for simply being well thoughtful as well as for obtaining this kind of fabulous guides millions of individuals are really needing to learn about. My sincere regret for not expressing appreciation to you sooner. [http://edproblemsolver.com/ levitra usa] [http://france-pharma.com/achat Viagra] [http://kamagra.name/ kamagra] -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Thu Nov 3 08:30:14 2011 From: nobody at buildbot.net (Buildbot) Date: Thu, 03 Nov 2011 08:30:14 -0000 Subject: [Buildbot-commits] [Buildbot] #85: sometimes buildmaster does not hand pending jobs to the idle slave, even though buildmaster can ping buildslave In-Reply-To: <039.404d88a945b465fd0213d2a73a04dbcb@buildbot.net> References: <039.404d88a945b465fd0213d2a73a04dbcb@buildbot.net> Message-ID: <054.edbf219402b3ef434a3f773dce3308bb@buildbot.net> #85: sometimes buildmaster does not hand pending jobs to the idle slave, even though buildmaster can ping buildslave ---------------------------+--------------------- Reporter: joduinn | Owner: dustin Type: defect | Status: closed Priority: major | Milestone: 0.7.10 Version: 0.7.5 | Resolution: fixed Keywords: virtualization | ---------------------------+--------------------- Comment (by dyzmillz80): Thanks a lot for providing individuals with an extremely pleasant possiblity to read articles and blog posts from here. It's always very excellent and as well , full of a good time for me and my office peers to search your blog not less than three times per week to find out the latest guides you have got. And of course, I am certainly astounded with your beautiful tips served by you. [http://edPillenLaden.com/ viagra kaufen] [http://edpillsaustralia.com/ buy viagra] [http://edpillsuk.com/ kamagra] -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Thu Nov 3 08:39:22 2011 From: nobody at buildbot.net (Buildbot) Date: Thu, 03 Nov 2011 08:39:22 -0000 Subject: [Buildbot-commits] [Buildbot] #9: master.cfg should define names rather than keys in a single named dictionary In-Reply-To: <038.b36685897ea46d0db6b11df0bb498bea@buildbot.net> References: <038.b36685897ea46d0db6b11df0bb498bea@buildbot.net> Message-ID: <053.f9cb9a72435b4a09e26eacb78fcd3535@buildbot.net> #9: master.cfg should define names rather than keys in a single named dictionary ------------------------+---------------------- Reporter: warner | Owner: warner Type: enhancement | Status: closed Priority: minor | Milestone: 0.8.+ Version: | Resolution: wontfix Keywords: | ------------------------+---------------------- Comment (by dyzmillz80): An interesting dialogue is worth comment. I feel that you should write more on this subject, it may not be a taboo subject but generally people are not sufficient to talk on such as [http://auedtabs.com/ viagra] [http://blauepillenkaufen.com viagra kaufen] [http://brazil-farmacia.com/ Viagra] topics. To the next. Cheers -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Thu Nov 3 08:41:21 2011 From: nobody at buildbot.net (Buildbot) Date: Thu, 03 Nov 2011 08:41:21 -0000 Subject: [Buildbot-commits] [Buildbot] #189: Rewrite Buildbot docs in Sphinx In-Reply-To: <039.a8def7e36e19b169a2efad013e9f5094@buildbot.net> References: <039.a8def7e36e19b169a2efad013e9f5094@buildbot.net> Message-ID: <054.01be8c6c06c1f06bcb0b398ab0183bf5@buildbot.net> #189: Rewrite Buildbot docs in Sphinx -------------------------+--------------------- Reporter: ludovic | Owner: Type: enhancement | Status: closed Priority: minor | Milestone: 0.8.5 Version: 0.7.6 | Resolution: fixed Keywords: docs, sprint | -------------------------+--------------------- Comment (by dyzmillz80): Hello! I just wish to give a huge thumbs up for the great info you have got right here on this post. [http://edPillenLaden.com/ viagra], [http://edpillsaustralia.com/ buy viagra], [http://edpillsuk.com/ kamagra] will probably be coming again to your blog for extra soon. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Thu Nov 3 09:39:49 2011 From: nobody at buildbot.net (Buildbot) Date: Thu, 03 Nov 2011 09:39:49 -0000 Subject: [Buildbot-commits] [Buildbot] #9: master.cfg should define names rather than keys in a single named dictionary In-Reply-To: <038.b36685897ea46d0db6b11df0bb498bea@buildbot.net> References: <038.b36685897ea46d0db6b11df0bb498bea@buildbot.net> Message-ID: <053.29162345858f4e6c079ea99df12d0808@buildbot.net> #9: master.cfg should define names rather than keys in a single named dictionary ------------------------+---------------------- Reporter: warner | Owner: warner Type: enhancement | Status: closed Priority: minor | Milestone: 0.8.+ Version: | Resolution: wontfix Keywords: | ------------------------+---------------------- Comment (by dyzmillz80): I?d need to verify with you here. Which isn't one thing I normally do! I take pleasure in studying a post that may make people think. Also, thanks for allowing me to remark! [http://edproblemsolver.com/ levitra usa] [http://france-pharma.com/ achat Viagra] [http://kamagra.name/ kamagra] -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Thu Nov 3 09:41:25 2011 From: nobody at buildbot.net (Buildbot) Date: Thu, 03 Nov 2011 09:41:25 -0000 Subject: [Buildbot-commits] [Buildbot] #189: Rewrite Buildbot docs in Sphinx In-Reply-To: <039.a8def7e36e19b169a2efad013e9f5094@buildbot.net> References: <039.a8def7e36e19b169a2efad013e9f5094@buildbot.net> Message-ID: <054.100aeeb4c6ebe33e9e94c14be791229b@buildbot.net> #189: Rewrite Buildbot docs in Sphinx -------------------------+--------------------- Reporter: ludovic | Owner: Type: enhancement | Status: closed Priority: minor | Milestone: 0.8.5 Version: 0.7.6 | Resolution: fixed Keywords: docs, sprint | -------------------------+--------------------- Comment (by dyzmillz80): I?d need to verify with you here. Which isn't one thing I normally do! I take pleasure in studying a post that may make people think. Also, thanks for allowing me to remark! [http://auedtabs.com/ viagra] [http://blauepillenkaufen.com/ viagra kaufen] [http://brazil-farmacia.com/ Viagra] -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Thu Nov 3 10:50:09 2011 From: nobody at buildbot.net (Buildbot) Date: Thu, 03 Nov 2011 10:50:09 -0000 Subject: [Buildbot-commits] [Buildbot] #2134: Exception while releasing lock for a slave In-Reply-To: <041.fc6bc0cfce9cc402abb04e3dfb3b835e@buildbot.net> References: <041.fc6bc0cfce9cc402abb04e3dfb3b835e@buildbot.net> Message-ID: <056.7485d747fd83e4d3f3b7d2f877ffb6af@buildbot.net> #2134: Exception while releasing lock for a slave ----------------------+------------------------ Reporter: homer5439 | Owner: Type: undecided | Status: closed Priority: minor | Milestone: undecided Version: 0.8.5 | Resolution: duplicate Keywords: | ----------------------+------------------------ Comment (by homer5439): Ok, I can upgrade sqlite. This would only be needed on the master, right? -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Fri Nov 4 04:27:42 2011 From: noreply at github.com (noreply at github.com) Date: Thu, 3 Nov 2011 21:27:42 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 66450f: consider branch in reconfig Message-ID: <20111104042742.13BBB428A8@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 66450f46a3b05f64e30caaffb54947012e763ba7 https://github.com/buildbot/buildbot/commit/66450f46a3b05f64e30caaffb54947012e763ba7 Author: Dustin J. Mitchell Date: 2011-11-03 (Thu, 03 Nov 2011) Changed paths: M master/buildbot/schedulers/timed.py Log Message: ----------- consider branch in reconfig From nobody at buildbot.net Fri Nov 4 18:42:26 2011 From: nobody at buildbot.net (Buildbot) Date: Fri, 04 Nov 2011 18:42:26 -0000 Subject: [Buildbot-commits] [Buildbot] #2134: Exception while releasing lock for a slave In-Reply-To: <041.fc6bc0cfce9cc402abb04e3dfb3b835e@buildbot.net> References: <041.fc6bc0cfce9cc402abb04e3dfb3b835e@buildbot.net> Message-ID: <056.1e3f961441187cb1729cf5de94a85694@buildbot.net> #2134: Exception while releasing lock for a slave ----------------------+------------------------ Reporter: homer5439 | Owner: Type: undecided | Status: closed Priority: minor | Milestone: undecided Version: 0.8.5 | Resolution: duplicate Keywords: | ----------------------+------------------------ Comment (by dustin): correct -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sat Nov 5 00:28:42 2011 From: noreply at github.com (noreply at github.com) Date: Fri, 4 Nov 2011 17:28:42 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 475741: add tests, fix whitespace, and fix error handling Message-ID: <20111105002842.8C4A942949@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 475741f5d611ca23a0e22c4faa32acb2f55f9f9b https://github.com/buildbot/buildbot/commit/475741f5d611ca23a0e22c4faa32acb2f55f9f9b Author: Dustin J. Mitchell Date: 2011-11-04 (Fri, 04 Nov 2011) Changed paths: M slave/buildslave/commands/base.py M slave/buildslave/commands/fs.py M slave/buildslave/test/unit/test_commands_fs.py Log Message: ----------- add tests, fix whitespace, and fix error handling Fixes #845 Commit: 79c872d93290eb121696ee719b279eccf2645572 https://github.com/buildbot/buildbot/commit/79c872d93290eb121696ee719b279eccf2645572 Author: Dustin J. Mitchell Date: 2011-11-04 (Fri, 04 Nov 2011) Changed paths: M slave/buildslave/commands/base.py M slave/buildslave/commands/fs.py M slave/buildslave/test/unit/test_commands_fs.py Log Message: ----------- Merge branch 'bug845' * bug845: add tests, fix whitespace, and fix error handling defer long-running filesystem operations to a thread on Windows Compare: https://github.com/buildbot/buildbot/compare/66450f4...79c872d From nobody at buildbot.net Sat Nov 5 00:28:49 2011 From: nobody at buildbot.net (Buildbot) Date: Sat, 05 Nov 2011 00:28:49 -0000 Subject: [Buildbot-commits] [Buildbot] #845: shutil.copytree timeout for mode=copy In-Reply-To: <036.258f92bf68d08b55c6f985d5134094ef@buildbot.net> References: <036.258f92bf68d08b55c6f985d5134094ef@buildbot.net> Message-ID: <051.41a9c66b0158c57240514dfa0c05e495@buildbot.net> #845: shutil.copytree timeout for mode=copy ----------------------------+--------------------- Reporter: phil | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.+ Version: 0.7.12 | Resolution: fixed Keywords: windows, simple | ----------------------------+--------------------- Changes (by Dustin J. Mitchell): * status: new => closed * resolution: => fixed Comment: add tests, fix whitespace, and fix error handling Fixes #845 Changeset: 475741f5d611ca23a0e22c4faa32acb2f55f9f9b -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Nov 5 00:30:02 2011 From: nobody at buildbot.net (Buildbot) Date: Sat, 05 Nov 2011 00:30:02 -0000 Subject: [Buildbot-commits] [Buildbot] #845: shutil.copytree timeout for mode=copy In-Reply-To: <036.258f92bf68d08b55c6f985d5134094ef@buildbot.net> References: <036.258f92bf68d08b55c6f985d5134094ef@buildbot.net> Message-ID: <051.196b8a21e4d7d7ce65a74a5c124f5961@buildbot.net> #845: shutil.copytree timeout for mode=copy ----------------------------+--------------------- Reporter: phil | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.+ Version: 0.7.12 | Resolution: fixed Keywords: windows, simple | ----------------------------+--------------------- Comment (by dustin): phil, your commit was the parent to 475741. Thanks! -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sat Nov 5 16:07:17 2011 From: noreply at github.com (noreply at github.com) Date: Sat, 5 Nov 2011 09:07:17 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 6f4e3b: Merge branch 'interruptSignal' of git://github.com... Message-ID: <20111105160717.617EA42832@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 6f4e3bc90a3d7da60908a16e04e7e132518b8fd0 https://github.com/buildbot/buildbot/commit/6f4e3bc90a3d7da60908a16e04e7e132518b8fd0 Author: Dustin J. Mitchell Date: 2011-11-05 (Sat, 05 Nov 2011) Changed paths: M master/buildbot/process/buildstep.py M master/buildbot/steps/shell.py M master/docs/manual/cfg-buildsteps.rst M slave/buildslave/commands/base.py M slave/buildslave/commands/shell.py M slave/buildslave/runprocess.py M slave/buildslave/test/unit/test_runprocess.py Log Message: ----------- Merge branch 'interruptSignal' of git://github.com/liucougar/buildbot * 'interruptSignal' of git://github.com/liucougar/buildbot: add interruptSignal option to shell command Commit: bfd7d763a1c56e4b2b462c06de56a40736f89963 https://github.com/buildbot/buildbot/commit/bfd7d763a1c56e4b2b462c06de56a40736f89963 Author: Dustin J. Mitchell Date: 2011-11-05 (Sat, 05 Nov 2011) Changed paths: M master/docs/manual/cfg-buildsteps.rst Log Message: ----------- update docs to make it clear that the interruptSignal arg is a string Compare: https://github.com/buildbot/buildbot/compare/79c872d...bfd7d76 From nobody at buildbot.net Sun Nov 6 21:31:17 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 06 Nov 2011 21:31:17 -0000 Subject: [Buildbot-commits] [Buildbot] #845: shutil.copytree timeout for mode=copy In-Reply-To: <036.258f92bf68d08b55c6f985d5134094ef@buildbot.net> References: <036.258f92bf68d08b55c6f985d5134094ef@buildbot.net> Message-ID: <051.58959dffc48ed6ea47a22ffa6bb1ded5@buildbot.net> #845: shutil.copytree timeout for mode=copy ----------------------------+--------------------- Reporter: phil | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.+ Version: 0.7.12 | Resolution: fixed Keywords: windows, simple | ----------------------------+--------------------- Comment (by phil): Glad to hear that and see this bug finally resolved! I'm encountering another (unrelated to this bug entry) problem now... -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Tue Nov 8 11:54:28 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 08 Nov 2011 11:54:28 -0000 Subject: [Buildbot-commits] [Buildbot] #180: buildbot try does the wrong thing with mercurial queues In-Reply-To: <041.a504c6cfb098c443be86bcf2b37992f0@buildbot.net> References: <041.a504c6cfb098c443be86bcf2b37992f0@buildbot.net> Message-ID: <056.8681d571c740fa90871c033a74808190@buildbot.net> #180: buildbot try does the wrong thing with mercurial queues ------------------------+------------------------ Reporter: dsallings | Owner: dsallings Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: 0.7.6 | Resolution: Keywords: hg | ------------------------+------------------------ Changes (by burcin): * cc: burcin@? (added) Comment: attachment:try-mq.diff works for me, after manually applying the patch to `tryclient.py`. Could this be merged for the next release? The first hunk of https://github.com/marcusl/buildbot/commit/50c3be07aa646a3668e38503e3abd25d1bb00879 seems to remove the code that checks if mq is available. Perhaps reverting this would fix the tests. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Tue Nov 8 12:15:23 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 08 Nov 2011 12:15:23 -0000 Subject: [Buildbot-commits] [Buildbot] #180: buildbot try does the wrong thing with mercurial queues In-Reply-To: <041.a504c6cfb098c443be86bcf2b37992f0@buildbot.net> References: <041.a504c6cfb098c443be86bcf2b37992f0@buildbot.net> Message-ID: <056.01e333340ff6961b999705fceadaf2ab@buildbot.net> #180: buildbot try does the wrong thing with mercurial queues ------------------------+------------------------ Reporter: dsallings | Owner: dsallings Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: 0.7.6 | Resolution: Keywords: hg | ------------------------+------------------------ Comment (by marcusl): The commit was made to only disable the testTryMq() test, not the entire Mercurial test case, when mq is not enabled. (Since I and many others didn't use MQ, Mercurial tests weren't run at all.) That was the intention at least. Looking at it now, it seems as if MercurialHelper._qnew_supported might be set (or not), and the commit removed some code which would update that value again. The right thing would be to make sure that _qnew_supported has a correct value always, and not to rely on the unit tests to check and set it. (Could be a property that's set lazily inside MercurialHelper, on first access....) -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Nov 9 23:00:56 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 09 Nov 2011 23:00:56 -0000 Subject: [Buildbot-commits] [Buildbot] #2141: SVN post commit script successfully submits change to PBChangeSource but reports Unpersistable data: instance of class buildbot.changes.changes.Change deemed insecure Message-ID: <038.fdbed69a05a3369693d07a80238cd05d@buildbot.net> #2141: SVN post commit script successfully submits change to PBChangeSource but reports Unpersistable data: instance of class buildbot.changes.changes.Change deemed insecure -------------------+-------------------------------- Reporter: ggolan | Owner: Type: defect | Status: new Priority: minor | Milestone: undecided Version: 0.8.5 | Keywords: svn pbchangesource -------------------+-------------------------------- During a migration from 0.8.3 to 0.8.5 the `svn_buildbot.py` script began to emit a message not previously seen reporting that there was unpresistable data in the form of an instance of the class buildbot.changes.changes.Change which is deemed insecure. Though the change is correctly submitted to the buildmaster and everything flows correctly after that, some understanding of the severity of this message would be useful. The script has been modified from the one found in the contrib directory but a double check of the diff between the 0.8.5 script and the one in use does not show any obvious cause. The only major difference is that my version of the script populates the category field in the change. I have included a pprint of the change object. The command and return value: {{{ bash# ./svn_buildbot.py -s buildbot -p 9989 -r "/var/www/svn/" -v "12345" Repo: /var/www/svn/ quitting! because ([(True, Unpersistable('Unpersistable data: instance of class buildbot.changes.changes.Change deemed insecure'))], 'SUCCESS') }}} The `changes` object before it is returned by `getChanges` in the `ChangeSender` class: {{{ [{'branch': u'branches/brname', 'category': u'branches', 'comments': u'this is a comment', 'files': [u'somedir/file1.c', u'somedir/file2.c'], 'project': u'projname', 'repository': u'/var/www/svn/', 'revision': '12345', 'src': 'svn', 'who': u'myusername'}] }}} -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Thu Nov 10 03:41:10 2011 From: nobody at buildbot.net (Buildbot) Date: Thu, 10 Nov 2011 03:41:10 -0000 Subject: [Buildbot-commits] [Buildbot] #2142: Newlines in subject lines cause message formatter to send garbage through MailNotifier Message-ID: <038.e9d2130e0f6bbebb4f129f7b9faed31d@buildbot.net> #2142: Newlines in subject lines cause message formatter to send garbage through MailNotifier -------------------+----------------------- Reporter: Ukyo81 | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.5 | Keywords: mail -------------------+----------------------- When a newline is inserted anywhere in the subject line of a custom message formatter function, this causes MailNotifier to send garbage in the body of the build result email. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Thu Nov 10 19:08:32 2011 From: nobody at buildbot.net (Buildbot) Date: Thu, 10 Nov 2011 19:08:32 -0000 Subject: [Buildbot-commits] [Buildbot] #2142: Newlines in subject lines cause message formatter to send garbage through MailNotifier In-Reply-To: <038.e9d2130e0f6bbebb4f129f7b9faed31d@buildbot.net> References: <038.e9d2130e0f6bbebb4f129f7b9faed31d@buildbot.net> Message-ID: <053.e47de3410eacd801b602fa1bccec2acc@buildbot.net> #2142: Newlines in subject lines cause message formatter to send garbage through MailNotifier -------------------+------------------------ Reporter: Ukyo81 | Owner: Type: defect | Status: new Priority: minor | Milestone: undecided Version: 0.8.5 | Resolution: Keywords: mail | -------------------+------------------------ Changes (by Ukyo81): * priority: major => minor -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Thu Nov 10 19:16:08 2011 From: nobody at buildbot.net (Buildbot) Date: Thu, 10 Nov 2011 19:16:08 -0000 Subject: [Buildbot-commits] [Buildbot] #2143: Mail status fails with UnicodeDecodeError Message-ID: <044.6c85420da7289f0de971991bb9e0e34c@buildbot.net> #2143: Mail status fails with UnicodeDecodeError -------------------------+----------------------- Reporter: andialbrecht | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.5 | Keywords: -------------------------+----------------------- Mail status failed to send mail when attaching a log of a !PyLint step where the output contained non-ASCII chars. Tracback: {{{ 2011-11-10 14:20:12+0100 [-] Exception caught notifying of buildFinished event 2011-11-10 14:20:12+0100 [-] Unhandled Error Traceback (most recent call last): File "/home/build/.virtualenvs/buildbot/lib/python2.6/site- packages/buildbot/status/build.py", line 290, in buildFinished w.callback(self) File "/home/build/.virtualenvs/buildbot/lib/python2.6/site- packages/twisted/internet/defer.py", line 361, in callback self._startRunCallbacks(result) File "/home/build/.virtualenvs/buildbot/lib/python2.6/site- packages/twisted/internet/defer.py", line 455, in _startRunCallbacks self._runCallbacks() File "/home/build/.virtualenvs/buildbot/lib/python2.6/site- packages/twisted/internet/defer.py", line 542, in _runCallbacks current.result = callback(current.result, *args, **kw) --- --- File "/home/build/.virtualenvs/buildbot/lib/python2.6/site- packages/buildbot/status/builder.py", line 535, in _buildFinished w.buildFinished(name, s, results) File "/home/build/.virtualenvs/buildbot/lib/python2.6/site- packages/buildbot/status/mail.py", line 412, in buildFinished return self.buildMessage(name, [build], results) File "/home/build/.virtualenvs/buildbot/lib/python2.6/site- packages/buildbot/status/mail.py", line 620, in buildMessage results, builds, patches, logs) File "/home/build/.virtualenvs/buildbot/lib/python2.6/site- packages/buildbot/status/mail.py", line 560, in createEmail a = MIMEText(log.getText().encode(ENCODING), exceptions.UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 4857: ordinal not in range(128) }}} The relevant line in !PyLint output was a FIXME with an umlaut similar to this one: {{{'W0511:810,0: FIXME (foo): Mindestl\xc3\xa4nge beachten'}}} -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sat Nov 12 07:27:28 2011 From: noreply at github.com (noreply at github.com) Date: Fri, 11 Nov 2011 23:27:28 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] e1e6cc: split release notes into individual text files, st... Message-ID: <20111112072728.520AE42723@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: e1e6cc8d2ff7f48d9b8f177ca014903e40a88125 https://github.com/buildbot/buildbot/commit/e1e6cc8d2ff7f48d9b8f177ca014903e40a88125 Author: Dustin J. Mitchell Date: 2011-11-11 (Fri, 11 Nov 2011) Changed paths: M master/NEWS M master/docs/index.rst A master/docs/release-notes.rst A master/docs/release-notes/0.3.1.txt A master/docs/release-notes/0.3.2.txt A master/docs/release-notes/0.3.3.txt A master/docs/release-notes/0.3.4.txt A master/docs/release-notes/0.3.5.txt A master/docs/release-notes/0.4.0.txt A master/docs/release-notes/0.4.1.txt A master/docs/release-notes/0.4.2.txt A master/docs/release-notes/0.4.3.txt A master/docs/release-notes/0.5.0.txt A master/docs/release-notes/0.6.0.txt A master/docs/release-notes/0.6.1.txt A master/docs/release-notes/0.6.2.txt A master/docs/release-notes/0.6.3.txt A master/docs/release-notes/0.6.4.txt A master/docs/release-notes/0.6.5.txt A master/docs/release-notes/0.6.6.txt A master/docs/release-notes/0.7.0.txt A master/docs/release-notes/0.7.1.txt A master/docs/release-notes/0.7.10.txt A master/docs/release-notes/0.7.11.txt A master/docs/release-notes/0.7.12.txt A master/docs/release-notes/0.7.2.txt A master/docs/release-notes/0.7.3.txt A master/docs/release-notes/0.7.4.txt A master/docs/release-notes/0.7.5.txt A master/docs/release-notes/0.7.6.txt A master/docs/release-notes/0.7.7.txt A master/docs/release-notes/0.7.8.txt A master/docs/release-notes/0.7.9.txt A master/docs/release-notes/0.8.0.txt A master/docs/release-notes/0.8.1.txt A master/docs/release-notes/0.8.2.txt A master/docs/release-notes/0.8.3.txt A master/docs/release-notes/0.8.4.txt A master/docs/release-notes/0.8.5.txt M slave/NEWS Log Message: ----------- split release notes into individual text files, start tracking as part of the sphinx documentation Commit: 4b82f3a3acf6aeb91784c6b12a17b6f633681d7f https://github.com/buildbot/buildbot/commit/4b82f3a3acf6aeb91784c6b12a17b6f633681d7f Author: Dustin J. Mitchell Date: 2011-11-11 (Fri, 11 Nov 2011) Changed paths: M master/buildbot/scripts/runner.py M master/buildbot/scripts/startup.py M master/docs/manual/installation.rst M master/docs/release-notes.rst Log Message: ----------- Remove support for invoking 'make' during startup This removal was promised to occur in 0.8.2, so if you're using it, you've been granted a reprieve, and it's expired! Commit: 75e30c25fe309f2a926a0d9c6d7e8e1619e834f7 https://github.com/buildbot/buildbot/commit/75e30c25fe309f2a926a0d9c6d7e8e1619e834f7 Author: Dustin J. Mitchell Date: 2011-11-11 (Fri, 11 Nov 2011) Changed paths: M master/docs/manual/cfg-changesources.rst Log Message: ----------- don't use now-removed SyncmailMaildirSource in an example Commit: 93712b43a9d565fc34e6d68027a74a12387172e5 https://github.com/buildbot/buildbot/commit/93712b43a9d565fc34e6d68027a74a12387172e5 Author: Dustin J. Mitchell Date: 2011-11-11 (Fri, 11 Nov 2011) Changed paths: M master/buildbot/scripts/runner.py M master/buildbot/test/unit/test_scripts_runner.py M master/docs/release-notes.rst Log Message: ----------- remove deprecated --username option to 'buildbot sendchange' Commit: 571e7646c81733f1466f6b3226b9c9ed74f79e82 https://github.com/buildbot/buildbot/commit/571e7646c81733f1466f6b3226b9c9ed74f79e82 Author: Dustin J. Mitchell Date: 2011-11-11 (Fri, 11 Nov 2011) Changed paths: M master/docs/bbdocs/ext.py M master/docs/developer/database.rst M master/docs/manual/cfg-statustargets.rst M master/docs/release-notes.rst Log Message: ----------- add :bb:src:`..`, :bb:bug:`..`, and :bb:pull:`..` sphinx roles Commit: b4fb9fbf2243db6d091202f58ced453483fecd29 https://github.com/buildbot/buildbot/commit/b4fb9fbf2243db6d091202f58ced453483fecd29 Author: Dustin J. Mitchell Date: 2011-11-11 (Fri, 11 Nov 2011) Changed paths: M master/NEWS M master/buildbot/buildslave.py M master/buildbot/changes/manager.py M master/buildbot/changes/pb.py M master/buildbot/config.py M master/buildbot/db/connector.py M master/buildbot/db/exceptions.py M master/buildbot/interfaces.py M master/buildbot/master.py M master/buildbot/pbmanager.py M master/buildbot/process/botmaster.py M master/buildbot/process/build.py M master/buildbot/process/builder.py M master/buildbot/process/cache.py M master/buildbot/process/debug.py M master/buildbot/process/metrics.py M master/buildbot/process/users/manager.py M master/buildbot/schedulers/base.py M master/buildbot/schedulers/basic.py M master/buildbot/schedulers/dependent.py M master/buildbot/schedulers/manager.py M master/buildbot/schedulers/timed.py M master/buildbot/scripts/checkconfig.py M master/buildbot/scripts/runner.py M master/buildbot/status/base.py M master/buildbot/status/build.py M master/buildbot/status/builder.py M master/buildbot/status/buildstep.py M master/buildbot/status/logfile.py M master/buildbot/status/mail.py M master/buildbot/status/master.py M master/buildbot/status/web/baseweb.py M master/buildbot/status/web/status_json.py M master/buildbot/steps/blocker.py M master/buildbot/steps/maxq.py M master/buildbot/steps/python.py M master/buildbot/steps/shell.py M master/buildbot/steps/transfer.py M master/buildbot/steps/trigger.py M master/buildbot/test/fake/fakedb.py M master/buildbot/test/fake/fakemaster.py M master/buildbot/test/integration/test_configs.py M master/buildbot/test/integration/test_slave_comm.py M master/buildbot/test/integration/test_upgrade.py M master/buildbot/test/regressions/test_import_unicode_changes.py M master/buildbot/test/regressions/test_shell_command_properties.py R master/buildbot/test/unit/test_blocker.py M master/buildbot/test/unit/test_buildslave.py M master/buildbot/test/unit/test_changes_manager.py M master/buildbot/test/unit/test_changes_pb.py M master/buildbot/test/unit/test_db_connector.py M master/buildbot/test/unit/test_master.py M master/buildbot/test/unit/test_process_botmaster_BotMaster.py M master/buildbot/test/unit/test_process_botmaster_BuildRequestDistributor.py M master/buildbot/test/unit/test_process_builder.py M master/buildbot/test/unit/test_process_cache.py M master/buildbot/test/unit/test_process_debug.py M master/buildbot/test/unit/test_process_metrics.py M master/buildbot/test/unit/test_process_users_manager.py M master/buildbot/test/unit/test_schedulers_base.py M master/buildbot/test/unit/test_schedulers_basic.py M master/buildbot/test/unit/test_schedulers_dependent.py M master/buildbot/test/unit/test_schedulers_manager.py M master/buildbot/test/unit/test_schedulers_timed_Nightly.py M master/buildbot/test/unit/test_schedulers_timed_Periodic.py M master/buildbot/test/unit/test_scripts_checkconfig.py M master/buildbot/test/unit/test_scripts_runner.py M master/buildbot/test/unit/test_status_build.py M master/buildbot/test/unit/test_status_buildstep.py M master/buildbot/test/unit/test_status_logfile.py M master/buildbot/test/unit/test_status_mail.py M master/buildbot/test/unit/test_status_master.py M master/buildbot/test/unit/test_steps_maxq.py M master/buildbot/test/unit/test_steps_python.py M master/buildbot/test/unit/test_steps_shell.py M master/buildbot/test/unit/test_steps_transfer.py M master/buildbot/test/unit/test_steps_trigger.py M master/buildbot/test/unit/test_util.py M master/buildbot/test/util/pbmanager.py M master/buildbot/util/__init__.py M master/docs/developer/config.rst M master/docs/developer/database.rst M master/docs/developer/master-overview.rst M master/docs/developer/utils.rst M master/docs/manual/cfg-global.rst M master/docs/release-notes.rst Log Message: ----------- Refactor configuration handling This moves configuration loading and checking out of the master, and into a new module. Where possible, configuration is accessed directly in as many cases as possible, rather than being disseminated across the master at reconfiguration time. For services that need to modify their behavior when reconfigured, the ReconfigurableServiceMixin defines a general method of notification, eliminating service-specific code from the master. Schedulers are still stopped and re-started at every reconfiguration; this may be changed in the future. Compare: https://github.com/buildbot/buildbot/compare/bfd7d76...b4fb9fb From nobody at buildbot.net Sat Nov 12 19:22:54 2011 From: nobody at buildbot.net (Buildbot) Date: Sat, 12 Nov 2011 19:22:54 -0000 Subject: [Buildbot-commits] [Buildbot] #159: should be possible to have two buildbot.steps.source.SVN(mode="copy") steps in a single build factory In-Reply-To: <039.026d4399280638dac0c43934f327f915@buildbot.net> References: <039.026d4399280638dac0c43934f327f915@buildbot.net> Message-ID: <054.794948d451f50f839b02389f2d6b090a@buildbot.net> #159: should be possible to have two buildbot.steps.source.SVN(mode="copy") steps in a single build factory ------------------------+-------------------- Reporter: exarkun | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: 0.7.6 | Resolution: Keywords: projrepo | ------------------------+-------------------- Comment (by jaredgrubb): How would this be different from workdir? I think that pretty much does the same thing, or? -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Nov 12 23:51:56 2011 From: nobody at buildbot.net (Buildbot) Date: Sat, 12 Nov 2011 23:51:56 -0000 Subject: [Buildbot-commits] [Buildbot] #2144: sample.cfg needlessly depends on mail.smtp Message-ID: <042.c28d133e494823106cc9539e50e0a25e@buildbot.net> #2144: sample.cfg needlessly depends on mail.smtp -----------------------+----------------------- Reporter: tom.prince | Owner: Type: undecided | Status: new Priority: major | Milestone: undecided Version: 0.8.5 | Keywords: -----------------------+----------------------- This seems to be due to the fact that buildbot.buildslave imports buildbot.status.mail to automatically send mail on missing slaves. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Nov 12 23:56:55 2011 From: nobody at buildbot.net (Buildbot) Date: Sat, 12 Nov 2011 23:56:55 -0000 Subject: [Buildbot-commits] [Buildbot] #2144: sample.cfg needlessly depends on mail.smtp In-Reply-To: <042.c28d133e494823106cc9539e50e0a25e@buildbot.net> References: <042.c28d133e494823106cc9539e50e0a25e@buildbot.net> Message-ID: <057.7fc40c94a30d5bd5e1e2b9871deedbbb@buildbot.net> #2144: sample.cfg needlessly depends on mail.smtp -----------------------+------------------------ Reporter: tom.prince | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.5 | Resolution: Keywords: | -----------------------+------------------------ Changes (by tom.prince): * type: undecided => defect Comment: That is, twisted.mail.smtp (i.e. twisted-mail) But, this isn't a dependency. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Nov 13 06:19:38 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 13 Nov 2011 06:19:38 -0000 Subject: [Buildbot-commits] [Buildbot] #2145: UnicodeDecodeError on buildslave in runprocess.py Message-ID: <041.c7350f164b7ef0dc3fa8123ddf5ccadf@buildbot.net> #2145: UnicodeDecodeError on buildslave in runprocess.py ----------------------+--------------------------------- Reporter: mitchellh | Owner: Type: defect | Status: new Priority: blocker | Milestone: undecided Version: 0.8.5 | Keywords: unicode, bug, slave ----------------------+--------------------------------- Hello, I've setup a fairly simple BuildBot 0.8.5 installation. Along with this I've setup the GitHub post-receive hook for the WebStatus status hook, and I've setup my GitHub project to push to this. When I do this, every build results in the following stack trace: {{{ 2011-11-12 22:08:02-0800 [-] unexpected error in processEnded Traceback (most recent call last): File "/Users/mitchellh/code/personal/ruby/vagrant/test/buildbot/env/lib/python2.7 /site-packages/twisted/internet/abstract.py", line 262, in readConnectionLost self.connectionLost(reason) File "/Users/mitchellh/code/personal/ruby/vagrant/test/buildbot/env/lib/python2.7 /site-packages/twisted/internet/process.py", line 275, in connectionLost self.proc.childConnectionLost(self.name, reason) File "/Users/mitchellh/code/personal/ruby/vagrant/test/buildbot/env/lib/python2.7 /site-packages/twisted/internet/process.py", line 903, in childConnectionLost self.maybeCallProcessEnded() File "/Users/mitchellh/code/personal/ruby/vagrant/test/buildbot/env/lib/python2.7 /site-packages/twisted/internet/process.py", line 916, in maybeCallProcessEnded _BaseProcess.maybeCallProcessEnded(self) --- --- File "/Users/mitchellh/code/personal/ruby/vagrant/test/buildbot/env/lib/python2.7 /site-packages/twisted/internet/_baseprocess.py", line 60, in maybeCallProcessEnded proto.processEnded(Failure(reason)) File "/Users/mitchellh/code/personal/ruby/vagrant/test/buildbot/env/lib/python2.7 /site-packages/buildslave/runprocess.py", line 201, in processEnded self.command.finished(sig, rc) File "/Users/mitchellh/code/personal/ruby/vagrant/test/buildbot/env/lib/python2.7 /site-packages/buildslave/runprocess.py", line 662, in finished self._sendBuffers() File "/Users/mitchellh/code/personal/ruby/vagrant/test/buildbot/env/lib/python2.7 /site-packages/buildslave/runprocess.py", line 587, in _sendBuffers self._sendMessage(msg) File "/Users/mitchellh/code/personal/ruby/vagrant/test/buildbot/env/lib/python2.7 /site-packages/buildslave/runprocess.py", line 557, in _sendMessage msg = self._collapseMsg(msg) File "/Users/mitchellh/code/personal/ruby/vagrant/test/buildbot/env/lib/python2.7 /site-packages/buildslave/runprocess.py", line 544, in _collapseMsg data = "".join(msg[k]) exceptions.UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 1494: ordinal not in range(128) }}} I added some logging before the line which errors to output the string, and this is what is causing problems. The `msg` variable looks like this: {{{ {'header': [u'git reset --hard b62d7c317c0b39896169e0529540abdd817305f8\n', ' in dir /Users/mitchellh/code/personal/ruby/vagrant/test/buildbot/slave/vagrant- master-unit/build (timeout 1200 secs)\n', ... } }}} Notice that the first element is for some reason a unicode object while the remainders are regular str objects. This causes the `"".join` to fail. Oddly, this does not happen when I force a build manually. I'm not sure how this happens, but it is blocking my hook from working at all. Best, Mitchell -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Nov 13 07:12:32 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 13 Nov 2011 07:12:32 -0000 Subject: [Buildbot-commits] [Buildbot] #2145: UnicodeDecodeError on buildslave in runprocess.py In-Reply-To: <041.c7350f164b7ef0dc3fa8123ddf5ccadf@buildbot.net> References: <041.c7350f164b7ef0dc3fa8123ddf5ccadf@buildbot.net> Message-ID: <056.2b063f9e566063055e67513e775292c0@buildbot.net> #2145: UnicodeDecodeError on buildslave in runprocess.py --------------------------------+------------------------ Reporter: mitchellh | Owner: Type: defect | Status: new Priority: blocker | Milestone: undecided Version: 0.8.5 | Resolution: Keywords: unicode, bug, slave | --------------------------------+------------------------ Comment (by mitchellh): Alright, digging deeper into this I've found the problem, though I'm not sure what the proper solution is. The issue is that the `command` getting sent to `RunProcess` on the slave is a `unicode` type. Now, this section of `RunProcess` properly turns this unicode type into a str type for the platform: https://github.com/buildbot/buildbot/blob/master/slave/buildslave/runprocess.py#L255-272 However, `self.fake_command` is not properly encoded, and remains unicode. `self.fake_command` is then later used as the log message in the headers: https://github.com/buildbot/buildbot/blob/master/slave/buildslave/runprocess.py#L438 This causes that one log entry to be unicode. So finally, when the log messages are attempted to be joined, a `UnicodeDecodeError` is raised since it is trying to join many `unicode` and `str` items: https://github.com/buildbot/buildbot/blob/master/slave/buildslave/runprocess.py#L542 My solution, which may not be correct since I'm unsure of the codebase, was to to simply change the `fake_command` assignment to the following: {{{ self.fake_command = self.command }}} This causes it to pick up the proper encoding and work. However, I'm not convinced this is the correct solution and I'm sure with the above information a proper fix can be deployed. Please fix this! -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Nov 13 18:02:06 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 13 Nov 2011 18:02:06 -0000 Subject: [Buildbot-commits] [Buildbot] #2136: support binary log files in build steps In-Reply-To: <039.4c41784b1676f3669d61fe2781986672@buildbot.net> References: <039.4c41784b1676f3669d61fe2781986672@buildbot.net> Message-ID: <054.07d07efb00e7ba22fd9c0072c272f2c8@buildbot.net> #2136: support binary log files in build steps ------------------------+------------------------- Reporter: brendan | Owner: Type: enhancement | Status: closed Priority: minor | Milestone: undecided Version: 0.8.5 | Resolution: worksforme Keywords: web | ------------------------+------------------------- Changes (by dustin): * status: reopened => closed * resolution: => worksforme Comment: There's a larger question in buildbot of how to deal with build artifacts. I think you'll agree that these are *not* logs, and don't warrant the same treatment. The file upload/download support is fairly primitive, and the ways to expand this would be: * track uploaded files explicitly in the build status, so that they can be expired with something similar to the logHorizon, and are automatically linked from the build/step that generated them * allow files to flow through some other channel than the master/slave channel, as this channel - being RPC-based - is less than optimal for transfer of large files, and also places a lot of load on the master. I'm going to re-close this bug, as you've addressed the particular purpose of your request, but if you're interested in doing some more general work on artifact handling, please get in touch on the mailing list! -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sun Nov 13 18:38:31 2011 From: noreply at github.com (noreply at github.com) Date: Sun, 13 Nov 2011 10:38:31 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] ba27ff: add missed files in previous commit Message-ID: <20111113183831.38953425E9@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: ba27ffbcb72591117a305535fe2adad01956be9d https://github.com/buildbot/buildbot/commit/ba27ffbcb72591117a305535fe2adad01956be9d Author: Dustin J. Mitchell Date: 2011-11-13 (Sun, 13 Nov 2011) Changed paths: M master/buildbot/config.py A master/buildbot/test/unit/test_config.py A master/buildbot/test/unit/test_steps_blocker.py Log Message: ----------- add missed files in previous commit From nobody at buildbot.net Sun Nov 13 18:53:42 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 13 Nov 2011 18:53:42 -0000 Subject: [Buildbot-commits] [Buildbot] #1711: remove sendchange -u/--username options In-Reply-To: <038.7b36028043100c648ef59637e7fd4641@buildbot.net> References: <038.7b36028043100c648ef59637e7fd4641@buildbot.net> Message-ID: <053.e37b8a71c228943bf83979c282412f5c@buildbot.net> #1711: remove sendchange -u/--username options ------------------------+-------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.6 Version: 0.8.2 | Resolution: Keywords: | ------------------------+-------------------- Changes (by dustin): * milestone: 0.8.+ => 0.8.6 Comment: Removed for 0.8.6. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Nov 13 19:29:02 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 13 Nov 2011 19:29:02 -0000 Subject: [Buildbot-commits] [Buildbot] #2139: locks held by slaves are not released when slave goes missing In-Reply-To: <039.9c45009795e8e9815fcee44f137bd228@buildbot.net> References: <039.9c45009795e8e9815fcee44f137bd228@buildbot.net> Message-ID: <054.4ae39eb97fb8ded5956252f9aa50c097@buildbot.net> #2139: locks held by slaves are not released when slave goes missing --------------------+-------------------- Reporter: dwlocks | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.6 Version: 0.8.4p2 | Resolution: Keywords: | --------------------+-------------------- Changes (by dustin): * type: undecided => defect * milestone: undecided => 0.8.6 -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sun Nov 13 19:32:36 2011 From: noreply at github.com (noreply at github.com) Date: Sun, 13 Nov 2011 11:32:36 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] 762a4c: use keyword arguments in example; fixes #2140. Message-ID: <20111113193236.24E164261D@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 762a4c96099ad04c4e8a4d2f576a94fd26252d04 https://github.com/buildbot/buildbot/commit/762a4c96099ad04c4e8a4d2f576a94fd26252d04 Author: Dustin J. Mitchell Date: 2011-11-13 (Sun, 13 Nov 2011) Changed paths: M master/docs/manual/cfg-schedulers.rst Log Message: ----------- use keyword arguments in example; fixes #2140. From nobody at buildbot.net Sun Nov 13 19:32:41 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 13 Nov 2011 19:32:41 -0000 Subject: [Buildbot-commits] [Buildbot] #2140: Incorrect code snippet for SingleBranchScheduler In-Reply-To: <038.d2e499da28de4b1832935563d23d4b05@buildbot.net> References: <038.d2e499da28de4b1832935563d23d4b05@buildbot.net> Message-ID: <053.7141abb0eee737006e02fd139653e995@buildbot.net> #2140: Incorrect code snippet for SingleBranchScheduler -------------------+------------------------ Reporter: mmadia | Owner: Type: defect | Status: closed Priority: minor | Milestone: undecided Version: 0.8.5 | Resolution: fixed Keywords: docs | -------------------+------------------------ Changes (by Dustin J. Mitchell): * status: new => closed * resolution: => fixed Comment: use keyword arguments in example; fixes #2140. Changeset: 762a4c96099ad04c4e8a4d2f576a94fd26252d04 -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Mon Nov 14 01:09:06 2011 From: noreply at github.com (noreply at github.com) Date: Sun, 13 Nov 2011 17:09:06 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] 1a9e41: fix typos Message-ID: <20111114010906.E7A55423CD@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 1a9e419496ca9eeb0c55bcbc1c1f991ef968522a https://github.com/buildbot/buildbot/commit/1a9e419496ca9eeb0c55bcbc1c1f991ef968522a Author: Dustin J. Mitchell Date: 2011-11-13 (Sun, 13 Nov 2011) Changed paths: M master/buildbot/status/web/baseweb.py Log Message: ----------- fix typos From noreply at github.com Mon Nov 14 04:46:13 2011 From: noreply at github.com (noreply at github.com) Date: Sun, 13 Nov 2011 20:46:13 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] 10e1f7: add ReconfigurableServiceMixin to PBChangeSource Message-ID: <20111114044613.A8B1E42588@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 10e1f73929098f0aebda08774081442f8ea54bc5 https://github.com/buildbot/buildbot/commit/10e1f73929098f0aebda08774081442f8ea54bc5 Author: Dustin J. Mitchell Date: 2011-11-13 (Sun, 13 Nov 2011) Changed paths: M master/buildbot/changes/pb.py Log Message: ----------- add ReconfigurableServiceMixin to PBChangeSource Commit: 46f9f5be7fc10979c288ceea698dbbf309d08c51 https://github.com/buildbot/buildbot/commit/46f9f5be7fc10979c288ceea698dbbf309d08c51 Author: Dustin J. Mitchell Date: 2011-11-13 (Sun, 13 Nov 2011) Changed paths: M master/buildbot/changes/pb.py Log Message: ----------- Don't return Change objects from perspective_addChange Change objects aren't safely jellyable, so they cannot be returned. Fixes #2141. Compare: https://github.com/buildbot/buildbot/compare/1a9e419...46f9f5b From nobody at buildbot.net Mon Nov 14 04:46:15 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 14 Nov 2011 04:46:15 -0000 Subject: [Buildbot-commits] [Buildbot] #2141: SVN post commit script successfully submits change to PBChangeSource but reports Unpersistable data: instance of class buildbot.changes.changes.Change deemed insecure In-Reply-To: <038.fdbed69a05a3369693d07a80238cd05d@buildbot.net> References: <038.fdbed69a05a3369693d07a80238cd05d@buildbot.net> Message-ID: <053.cb5d605e262a38ab0f26022da18e7c88@buildbot.net> #2141: SVN post commit script successfully submits change to PBChangeSource but reports Unpersistable data: instance of class buildbot.changes.changes.Change deemed insecure -------------------+-------------------- Reporter: ggolan | Owner: Type: defect | Status: new Priority: minor | Milestone: 0.8.6 Version: 0.8.5 | Resolution: Keywords: svn | -------------------+-------------------- Changes (by dustin): * keywords: svn pbchangesource => svn * milestone: undecided => 0.8.6 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Nov 14 04:46:20 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 14 Nov 2011 04:46:20 -0000 Subject: [Buildbot-commits] [Buildbot] #2141: SVN post commit script successfully submits change to PBChangeSource but reports Unpersistable data: instance of class buildbot.changes.changes.Change deemed insecure In-Reply-To: <038.fdbed69a05a3369693d07a80238cd05d@buildbot.net> References: <038.fdbed69a05a3369693d07a80238cd05d@buildbot.net> Message-ID: <053.601844acb76607675e0e814875ff967c@buildbot.net> #2141: SVN post commit script successfully submits change to PBChangeSource but reports Unpersistable data: instance of class buildbot.changes.changes.Change deemed insecure -------------------+--------------------- Reporter: ggolan | Owner: Type: defect | Status: closed Priority: minor | Milestone: 0.8.6 Version: 0.8.5 | Resolution: fixed Keywords: svn | -------------------+--------------------- Changes (by Dustin J. Mitchell): * status: new => closed * resolution: => fixed Comment: Don't return Change objects from perspective_addChange Change objects aren't safely jellyable, so they cannot be returned. Fixes #2141. Changeset: 46f9f5be7fc10979c288ceea698dbbf309d08c51 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Nov 14 04:47:37 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 14 Nov 2011 04:47:37 -0000 Subject: [Buildbot-commits] [Buildbot] #2141: SVN post commit script successfully submits change to PBChangeSource but reports Unpersistable data: instance of class buildbot.changes.changes.Change deemed insecure In-Reply-To: <038.fdbed69a05a3369693d07a80238cd05d@buildbot.net> References: <038.fdbed69a05a3369693d07a80238cd05d@buildbot.net> Message-ID: <053.158225cea0785943f768b47c59cae35e@buildbot.net> #2141: SVN post commit script successfully submits change to PBChangeSource but reports Unpersistable data: instance of class buildbot.changes.changes.Change deemed insecure -------------------+--------------------- Reporter: ggolan | Owner: Type: defect | Status: closed Priority: minor | Milestone: 0.8.6 Version: 0.8.5 | Resolution: fixed Keywords: svn | -------------------+--------------------- Comment (by dustin): Which is to say, this was a bug in 0.8.5, and the linked patch fixes it. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Nov 14 04:56:04 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 14 Nov 2011 04:56:04 -0000 Subject: [Buildbot-commits] [Buildbot] #2142: Newlines in subject lines cause message formatter to send garbage through MailNotifier In-Reply-To: <038.e9d2130e0f6bbebb4f129f7b9faed31d@buildbot.net> References: <038.e9d2130e0f6bbebb4f129f7b9faed31d@buildbot.net> Message-ID: <053.29ca8953c97988d812e8a4bd9d6e67f6@buildbot.net> #2142: Newlines in subject lines cause message formatter to send garbage through MailNotifier -------------------+------------------------ Reporter: Ukyo81 | Owner: Type: defect | Status: new Priority: minor | Milestone: undecided Version: 0.8.5 | Resolution: Keywords: mail | -------------------+------------------------ Comment (by dustin): Then .. don't do that! I'll put in a check or two.. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Mon Nov 14 04:57:33 2011 From: noreply at github.com (noreply at github.com) Date: Sun, 13 Nov 2011 20:57:33 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] 876de7: Don't allow newlines in subject Message-ID: <20111114045733.729D3425B2@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 876de7b4c31bbd1b6979e28574d9730cb620047e https://github.com/buildbot/buildbot/commit/876de7b4c31bbd1b6979e28574d9730cb620047e Author: Dustin J. Mitchell Date: 2011-11-13 (Sun, 13 Nov 2011) Changed paths: M master/buildbot/status/mail.py Log Message: ----------- Don't allow newlines in subject Fixes #2142. From nobody at buildbot.net Mon Nov 14 04:57:37 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 14 Nov 2011 04:57:37 -0000 Subject: [Buildbot-commits] [Buildbot] #2142: Newlines in subject lines cause message formatter to send garbage through MailNotifier In-Reply-To: <038.e9d2130e0f6bbebb4f129f7b9faed31d@buildbot.net> References: <038.e9d2130e0f6bbebb4f129f7b9faed31d@buildbot.net> Message-ID: <053.ae3dfddf82261c2eb6f1a9f19f048518@buildbot.net> #2142: Newlines in subject lines cause message formatter to send garbage through MailNotifier -------------------+------------------------ Reporter: Ukyo81 | Owner: Type: defect | Status: closed Priority: minor | Milestone: undecided Version: 0.8.5 | Resolution: fixed Keywords: mail | -------------------+------------------------ Changes (by Dustin J. Mitchell): * status: new => closed * resolution: => fixed Comment: Don't allow newlines in subject Fixes #2142. Changeset: 876de7b4c31bbd1b6979e28574d9730cb620047e -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Nov 14 05:03:05 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 14 Nov 2011 05:03:05 -0000 Subject: [Buildbot-commits] [Buildbot] #159: should be possible to have two buildbot.steps.source.SVN(mode="copy") steps in a single build factory In-Reply-To: <039.026d4399280638dac0c43934f327f915@buildbot.net> References: <039.026d4399280638dac0c43934f327f915@buildbot.net> Message-ID: <054.899d9014ee7d7434a165d5af2de1a836@buildbot.net> #159: should be possible to have two buildbot.steps.source.SVN(mode="copy") steps in a single build factory ------------------------+-------------------- Reporter: exarkun | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: 0.7.6 | Resolution: Keywords: projrepo | ------------------------+-------------------- Comment (by dustin): jared, we're reaching that conclusion in https://github.com/buildbot/buildbot/pull/253 - but that's not the same issue as is addressed in this bug. Here we're looking at the hard-coded `$builddir/source` directory, rather than the workdir (`$builddir/build`) -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Mon Nov 14 05:44:20 2011 From: noreply at github.com (noreply at github.com) Date: Sun, 13 Nov 2011 21:44:20 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] de491b: Do not fail if twisted.mail can't be imported Message-ID: <20111114054421.0F01942524@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: de491bcc39eba823da377d57378906933b10674f https://github.com/buildbot/buildbot/commit/de491bcc39eba823da377d57378906933b10674f Author: Dustin J. Mitchell Date: 2011-11-13 (Sun, 13 Nov 2011) Changed paths: M master/buildbot/status/mail.py Log Message: ----------- Do not fail if twisted.mail can't be imported This allows other parts of Buildbot (e.g., buildbot.buildslave) to import mail.py, even if only some parts of Twisted are installed. Fixes #2144. From nobody at buildbot.net Mon Nov 14 05:44:26 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 14 Nov 2011 05:44:26 -0000 Subject: [Buildbot-commits] [Buildbot] #2144: sample.cfg needlessly depends on mail.smtp In-Reply-To: <042.c28d133e494823106cc9539e50e0a25e@buildbot.net> References: <042.c28d133e494823106cc9539e50e0a25e@buildbot.net> Message-ID: <057.098faedeb6f41ed43c93c10756658c5a@buildbot.net> #2144: sample.cfg needlessly depends on mail.smtp -----------------------+------------------------ Reporter: tom.prince | Owner: Type: defect | Status: closed Priority: major | Milestone: undecided Version: 0.8.5 | Resolution: fixed Keywords: | -----------------------+------------------------ Changes (by Dustin J. Mitchell): * status: new => closed * resolution: => fixed Comment: Do not fail if twisted.mail can't be imported This allows other parts of Buildbot (e.g., buildbot.buildslave) to import mail.py, even if only some parts of Twisted are installed. Fixes #2144. Changeset: de491bcc39eba823da377d57378906933b10674f -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Mon Nov 14 06:22:55 2011 From: noreply at github.com (noreply at github.com) Date: Sun, 13 Nov 2011 22:22:55 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] 1a82eb: Convert both fake and real commands to bytestrings Message-ID: <20111114062255.00C2A4256D@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 1a82eb2340b177d903639bddeb8fcea8e6bb4122 https://github.com/buildbot/buildbot/commit/1a82eb2340b177d903639bddeb8fcea8e6bb4122 Author: Dustin J. Mitchell Date: 2011-11-13 (Sun, 13 Nov 2011) Changed paths: M slave/buildslave/runprocess.py M slave/buildslave/test/fake/slavebuilder.py M slave/buildslave/test/unit/test_runprocess.py Log Message: ----------- Convert both fake and real commands to bytestrings Fixes #2145, where the fake command was not properly converted From nobody at buildbot.net Mon Nov 14 06:23:04 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 14 Nov 2011 06:23:04 -0000 Subject: [Buildbot-commits] [Buildbot] #2145: UnicodeDecodeError on buildslave in runprocess.py In-Reply-To: <041.c7350f164b7ef0dc3fa8123ddf5ccadf@buildbot.net> References: <041.c7350f164b7ef0dc3fa8123ddf5ccadf@buildbot.net> Message-ID: <056.dfceb1ddae982aac2f2e8c9dc07afa7f@buildbot.net> #2145: UnicodeDecodeError on buildslave in runprocess.py --------------------------------+------------------------ Reporter: mitchellh | Owner: Type: defect | Status: closed Priority: blocker | Milestone: undecided Version: 0.8.5 | Resolution: fixed Keywords: unicode, bug, slave | --------------------------------+------------------------ Changes (by Dustin J. Mitchell): * status: new => closed * resolution: => fixed Comment: Convert both fake and real commands to bytestrings Fixes #2145, where the fake command was not properly converted Changeset: 1a82eb2340b177d903639bddeb8fcea8e6bb4122 -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Mon Nov 14 06:24:40 2011 From: noreply at github.com (noreply at github.com) Date: Sun, 13 Nov 2011 22:24:40 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] d14f92: Merge branch 'master' of git://github.com/tvo/buil... Message-ID: <20111114062440.64A5142565@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: d14f92dc6a8f3d11d392462486b6f3d2571b9265 https://github.com/buildbot/buildbot/commit/d14f92dc6a8f3d11d392462486b6f3d2571b9265 Author: Dustin J. Mitchell Date: 2011-11-13 (Sun, 13 Nov 2011) Changed paths: M master/buildbot/status/web/files/robots.txt Log Message: ----------- Merge branch 'master' of git://github.com/tvo/buildbot * 'master' of git://github.com/tvo/buildbot: Disallow crawling /json From nobody at buildbot.net Mon Nov 14 13:04:43 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 14 Nov 2011 13:04:43 -0000 Subject: [Buildbot-commits] [Buildbot] #2065: Error during setup of buildslave on Windows 7 64bit In-Reply-To: <046.67e1d61ea2ba36f97b6d0597743e90a8@buildbot.net> References: <046.67e1d61ea2ba36f97b6d0597743e90a8@buildbot.net> Message-ID: <061.cf598629b4ce338084bcd7b9f4b908b8@buildbot.net> #2065: Error during setup of buildslave on Windows 7 64bit ---------------------------+------------------------- Reporter: materialdreams | Owner: Type: undecided | Status: closed Priority: minor | Milestone: undecided Version: 0.8.4p2 | Resolution: worksforme Keywords: | ---------------------------+------------------------- Comment (by ssbarnea): Please reopen the issue, I do have a 32bit Python 2.5 on Windows 7 and I get the same error. {{{ easy_install buildbot Searching for buildbot Reading http://pypi.python.org/simple/buildbot/ Reading http://buildbot.net/ Reading http://code.google.com/p/buildbot/downloads/list Reading http://buildbot.sourceforge.net/ Reading https://sourceforge.net/project/showfiles.php?group_id=73177&package_id= Best match: buildbot 0.8.5 Downloading http://buildbot.googlecode.com/files/buildbot-0.8.5.zip Processing buildbot-0.8.5.zip Running buildbot-0.8.5\setup.py -q bdist_egg --dist-dir c:\users\sbso\appdata\lo dist-tmp-n_f063 C:\Python25\lib\distutils\dist.py:263: UserWarning: Unknown distribution option: warnings.warn(msg) No eggs found in c:\users\sbso\appdata\local\temp\easy_install- zjgsap\buildbot-0 }}} -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Nov 14 14:14:13 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 14 Nov 2011 14:14:13 -0000 Subject: [Buildbot-commits] [Buildbot] #2146: GitPoller should support multiple branches Message-ID: <043.fe4479a6480df7cc1f520f2021c8cb64@buildbot.net> #2146: GitPoller should support multiple branches ------------------------+------------------- Reporter: MikeMcQuaid | Owner: Type: enhancement | Status: new Priority: trivial | Milestone: 0.8.+ Version: 0.8.5 | Keywords: git ------------------------+------------------- It seems GitPoller only currently supports generating ChangeEvents for a single branch whereas SVNPoller can create them for multiple branches. It would be good if this was also supported in GitPoller. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Mon Nov 14 16:35:56 2011 From: noreply at github.com (noreply at github.com) Date: Mon, 14 Nov 2011 08:35:56 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] 9cc65c: Merge remote-tracking branch 'upstream/master' Message-ID: <20111114163556.9CB6031858@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 9cc65c3397b1f4f5acfab130c6f28c06af49b7ea https://github.com/buildbot/buildbot/commit/9cc65c3397b1f4f5acfab130c6f28c06af49b7ea Author: Andi Albrecht Date: 2011-11-14 (Mon, 14 Nov 2011) Changed paths: M master/NEWS M master/buildbot/buildslave.py M master/buildbot/changes/manager.py M master/buildbot/changes/pb.py M master/buildbot/config.py M master/buildbot/db/connector.py M master/buildbot/db/exceptions.py M master/buildbot/interfaces.py M master/buildbot/master.py M master/buildbot/pbmanager.py M master/buildbot/process/botmaster.py M master/buildbot/process/build.py M master/buildbot/process/builder.py M master/buildbot/process/cache.py M master/buildbot/process/debug.py M master/buildbot/process/metrics.py M master/buildbot/process/users/manager.py M master/buildbot/schedulers/base.py M master/buildbot/schedulers/basic.py M master/buildbot/schedulers/dependent.py M master/buildbot/schedulers/manager.py M master/buildbot/schedulers/timed.py M master/buildbot/scripts/checkconfig.py M master/buildbot/scripts/runner.py M master/buildbot/scripts/startup.py M master/buildbot/status/base.py M master/buildbot/status/build.py M master/buildbot/status/builder.py M master/buildbot/status/buildstep.py M master/buildbot/status/logfile.py M master/buildbot/status/mail.py M master/buildbot/status/master.py M master/buildbot/status/web/baseweb.py M master/buildbot/status/web/files/robots.txt M master/buildbot/status/web/status_json.py M master/buildbot/steps/blocker.py M master/buildbot/steps/maxq.py M master/buildbot/steps/python.py M master/buildbot/steps/shell.py M master/buildbot/steps/transfer.py M master/buildbot/steps/trigger.py M master/buildbot/test/fake/fakedb.py M master/buildbot/test/fake/fakemaster.py M master/buildbot/test/integration/test_configs.py M master/buildbot/test/integration/test_slave_comm.py M master/buildbot/test/integration/test_upgrade.py M master/buildbot/test/regressions/test_import_unicode_changes.py M master/buildbot/test/regressions/test_shell_command_properties.py R master/buildbot/test/unit/test_blocker.py M master/buildbot/test/unit/test_buildslave.py M master/buildbot/test/unit/test_changes_manager.py M master/buildbot/test/unit/test_changes_pb.py A master/buildbot/test/unit/test_config.py M master/buildbot/test/unit/test_db_connector.py M master/buildbot/test/unit/test_master.py M master/buildbot/test/unit/test_process_botmaster_BotMaster.py M master/buildbot/test/unit/test_process_botmaster_BuildRequestDistributor.py M master/buildbot/test/unit/test_process_builder.py M master/buildbot/test/unit/test_process_cache.py M master/buildbot/test/unit/test_process_debug.py M master/buildbot/test/unit/test_process_metrics.py M master/buildbot/test/unit/test_process_users_manager.py M master/buildbot/test/unit/test_schedulers_base.py M master/buildbot/test/unit/test_schedulers_basic.py M master/buildbot/test/unit/test_schedulers_dependent.py M master/buildbot/test/unit/test_schedulers_manager.py M master/buildbot/test/unit/test_schedulers_timed_Nightly.py M master/buildbot/test/unit/test_schedulers_timed_Periodic.py M master/buildbot/test/unit/test_scripts_checkconfig.py M master/buildbot/test/unit/test_scripts_runner.py M master/buildbot/test/unit/test_status_build.py M master/buildbot/test/unit/test_status_buildstep.py M master/buildbot/test/unit/test_status_logfile.py M master/buildbot/test/unit/test_status_mail.py M master/buildbot/test/unit/test_status_master.py A master/buildbot/test/unit/test_steps_blocker.py M master/buildbot/test/unit/test_steps_maxq.py M master/buildbot/test/unit/test_steps_python.py M master/buildbot/test/unit/test_steps_shell.py M master/buildbot/test/unit/test_steps_transfer.py M master/buildbot/test/unit/test_steps_trigger.py M master/buildbot/test/unit/test_util.py M master/buildbot/test/util/pbmanager.py M master/buildbot/util/__init__.py M master/docs/bbdocs/ext.py M master/docs/developer/config.rst M master/docs/developer/database.rst M master/docs/developer/master-overview.rst M master/docs/developer/utils.rst M master/docs/index.rst M master/docs/manual/cfg-changesources.rst M master/docs/manual/cfg-global.rst M master/docs/manual/cfg-schedulers.rst M master/docs/manual/cfg-statustargets.rst M master/docs/manual/installation.rst A master/docs/release-notes.rst A master/docs/release-notes/0.3.1.txt A master/docs/release-notes/0.3.2.txt A master/docs/release-notes/0.3.3.txt A master/docs/release-notes/0.3.4.txt A master/docs/release-notes/0.3.5.txt A master/docs/release-notes/0.4.0.txt A master/docs/release-notes/0.4.1.txt A master/docs/release-notes/0.4.2.txt A master/docs/release-notes/0.4.3.txt A master/docs/release-notes/0.5.0.txt A master/docs/release-notes/0.6.0.txt A master/docs/release-notes/0.6.1.txt A master/docs/release-notes/0.6.2.txt A master/docs/release-notes/0.6.3.txt A master/docs/release-notes/0.6.4.txt A master/docs/release-notes/0.6.5.txt A master/docs/release-notes/0.6.6.txt A master/docs/release-notes/0.7.0.txt A master/docs/release-notes/0.7.1.txt A master/docs/release-notes/0.7.10.txt A master/docs/release-notes/0.7.11.txt A master/docs/release-notes/0.7.12.txt A master/docs/release-notes/0.7.2.txt A master/docs/release-notes/0.7.3.txt A master/docs/release-notes/0.7.4.txt A master/docs/release-notes/0.7.5.txt A master/docs/release-notes/0.7.6.txt A master/docs/release-notes/0.7.7.txt A master/docs/release-notes/0.7.8.txt A master/docs/release-notes/0.7.9.txt A master/docs/release-notes/0.8.0.txt A master/docs/release-notes/0.8.1.txt A master/docs/release-notes/0.8.2.txt A master/docs/release-notes/0.8.3.txt A master/docs/release-notes/0.8.4.txt A master/docs/release-notes/0.8.5.txt M slave/NEWS M slave/buildslave/runprocess.py M slave/buildslave/test/fake/slavebuilder.py M slave/buildslave/test/unit/test_runprocess.py Log Message: ----------- Merge remote-tracking branch 'upstream/master' Commit: 43ebc294c414b389181b8e78ff4e8b8ff1aaca5b https://github.com/buildbot/buildbot/commit/43ebc294c414b389181b8e78ff4e8b8ff1aaca5b Author: Andi Albrecht Date: 2011-11-14 (Mon, 14 Nov 2011) Changed paths: M master/buildbot/status/mail.py Log Message: ----------- Make LOG_ENCODING a module constant. Commit: 7497effe5283d0ff051947f922f79fbb05259295 https://github.com/buildbot/buildbot/commit/7497effe5283d0ff051947f922f79fbb05259295 Author: Dustin J. Mitchell Date: 2011-11-14 (Mon, 14 Nov 2011) Changed paths: M master/buildbot/status/mail.py M master/buildbot/test/unit/test_status_mail.py Log Message: ----------- Merge branch 'master' of git://github.com/andialbrecht/buildbot * 'master' of git://github.com/andialbrecht/buildbot: Make LOG_ENCODING a module constant. Decode str before encoding when a log is added as mail attachment (fixes #2143). Compare: https://github.com/buildbot/buildbot/compare/d14f92d...7497eff From nobody at buildbot.net Mon Nov 14 16:36:04 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 14 Nov 2011 16:36:04 -0000 Subject: [Buildbot-commits] [Buildbot] #2143: Mail status fails with UnicodeDecodeError In-Reply-To: <044.6c85420da7289f0de971991bb9e0e34c@buildbot.net> References: <044.6c85420da7289f0de971991bb9e0e34c@buildbot.net> Message-ID: <059.af24c01f7ab8de58cb07c16b8c19ff4d@buildbot.net> #2143: Mail status fails with UnicodeDecodeError -------------------------+------------------------ Reporter: andialbrecht | Owner: Type: defect | Status: closed Priority: major | Milestone: undecided Version: 0.8.5 | Resolution: fixed Keywords: | -------------------------+------------------------ Changes (by Dustin J. Mitchell): * status: new => closed * resolution: => fixed Comment: Merge branch 'master' of git://github.com/andialbrecht/buildbot * 'master' of git://github.com/andialbrecht/buildbot: Make LOG_ENCODING a module constant. Decode str before encoding when a log is added as mail attachment (fixes #2143). Changeset: 7497effe5283d0ff051947f922f79fbb05259295 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Tue Nov 15 16:05:33 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 15 Nov 2011 16:05:33 -0000 Subject: [Buildbot-commits] [Buildbot] #2146: GitPoller should support multiple branches In-Reply-To: <043.fe4479a6480df7cc1f520f2021c8cb64@buildbot.net> References: <043.fe4479a6480df7cc1f520f2021c8cb64@buildbot.net> Message-ID: <058.81410795d762d022f69ba11bb018735e@buildbot.net> #2146: GitPoller should support multiple branches ------------------------+-------------------- Reporter: MikeMcQuaid | Owner: Type: enhancement | Status: new Priority: trivial | Milestone: 0.8.+ Version: 0.8.5 | Resolution: Keywords: git | ------------------------+-------------------- Comment (by MikeMcQuaid): It appears some partial work has happened here by erg: https://github.com/xrg/buildbot/tree/xrg-0.8 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Tue Nov 15 23:23:56 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 15 Nov 2011 23:23:56 -0000 Subject: [Buildbot-commits] [Buildbot] #2147: buildslave losing connection to buildmaster Message-ID: <044.5751d9dd85f0e7b228b9cf9f7caa4f49@buildbot.net> #2147: buildslave losing connection to buildmaster -------------------------+------------------------------------------------- Reporter: mariamarcano | Owner: Type: undecided | Status: new Priority: major | Milestone: undecided Version: 0.8.3 | Keywords: buildslave losing connection to | buildmaster -------------------------+------------------------------------------------- I Started getting the following issue when running the builds: this is what i see on the buildstep / buildbot waterfall: remoteFailed: [Failure instance: Traceback (failure with no frames): : Connection to the other side was lost in a non-clean fashion. ] builds were running fine, maybe related to adding more slaves to the master?. Currently using Slave: C:\Python27\Scripts>buildslave --version Buildslave version: 0.8.3 Twisted version: 10.2.0 Master: c:\Python27\Scripts>buildbot --version Buildbot version: 0.8.3p1 Twisted version: 10.2.0 This is what I see on the slave twistd.log: 2011-11-15 10:36:35-0800 [Broker,client] RunProcess._startCommand 2011-11-15 10:36:35-0800 [Broker,client] 'xunit.console.exe' 'XXTests.dll' '/html' 'xunit-output.html' 2011-11-15 10:36:35-0800 [Broker,client] in dir C:\Source\xx\AutomatedTests\XXTests\bin\Release (timeout 21600 secs) 2011-11-15 10:36:35-0800 [Broker,client] watching logfiles {'xunit log': 'C:\\temp\\XX_log.txt', 'xunit-output.html': 'xunit-output.html'} 2011-11-15 10:36:35-0800 [Broker,client] argv: ['xunit.console.exe', 'XXTests.dll', '/html', 'xunit-output.html'] 2011-11-15 10:36:35-0800 [Broker,client] environment: {..} 2011-11-15 10:36:35-0800 [Broker,client] closing stdin 2011-11-15 10:36:35-0800 [Broker,client] using PTY: False 2011-11-15 10:46:24-0800 [-] sending app-level keepalive 2011-11-15 10:56:24-0800 [-] sending app-level keepalive 2011-11-15 11:06:24-0800 [-] sending app-level keepalive 2011-11-15 11:16:24-0800 [-] sending app-level keepalive 2011-11-15 11:26:24-0800 [-] sending app-level keepalive 2011-11-15 11:36:24-0800 [-] sending app-level keepalive 2011-11-15 11:46:24-0800 [-] sending app-level keepalive 2011-11-15 11:56:24-0800 [-] sending app-level keepalive 2011-11-15 12:06:24-0800 [-] sending app-level keepalive 2011-11-15 12:06:54-0800 [-] BotFactory.checkActivity: nothing from master for 630 secs 2011-11-15 12:06:54-0800 [Broker,client] BotFactory.keepaliveLost 2011-11-15 12:06:54-0800 [Broker,client] lost remote 2011-11-15 12:06:54-0800 [Broker,client] lost remote step 2011-11-15 12:06:54-0800 [Broker,client] stopCommand: halting current command 2011-11-15 12:06:54-0800 [Broker,client] command interrupted, killing pid 2624 2011-11-15 12:06:54-0800 [Broker,client] trying process.signalProcess('KILL') 2011-11-15 12:06:54-0800 [Broker,client] signal KILL sent successfully 2011-11-15 12:06:54-0800 [Broker,client] Lost connection to buildbot.app.com:9989 2011-11-15 12:06:54-0800 [Broker,client] will retry in 1 seconds 2011-11-15 12:06:54-0800 [Broker,client] Stopping factory 2011-11-15 12:06:56-0800 [-] Starting factory 2011-11-15 12:06:56-0800 [-] Connecting to buildbot.app.com:9989 2011-11-15 12:06:59-0800 [-] we tried to kill the process, and it wouldn't die.. finish anyway 2011-11-15 12:06:59-0800 [-] RunProcess.failed: command failed: SIGKILL failed to kill process 2011-11-15 12:06:59-0800 [-] SlaveBuilder.commandFailed None 2011-11-15 12:06:59-0800 [-] Unhandled Error Traceback (most recent call last): Failure: exceptions.RuntimeError: SIGKILL failed to kill process 2011-11-15 12:07:29-0800 [Broker,client] message from master: attached 2011-11-15 12:07:29-0800 [Broker,client] SlaveBuilder.remote_print(rc38 -app-selenium-tests): message from master: attached 2011-11-15 12:07:29-0800 [Broker,client] Connected to buildbot.app.com:9989; slave is ready 2011-11-15 12:07:29-0800 [Broker,client] sending application-level keepalives every 600 seconds 2011-11-15 12:16:59-0800 [-] sending app-level keepalive 2011-11-15 12:26:59-0800 [-] sending app-level keepalive 2011-11-15 12:34:39-0800 [-] command finished with signal None, exit code 1, elapsedTime: 7084.500000 2011-11-15 12:34:39-0800 [-] Hey, command finished twice 2011-11-15 12:36:59-0800 [-] sending app-level keepalive 2011-11-15 12:46:59-0800 [-] sending app-level keepalive -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Tue Nov 15 23:43:17 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 15 Nov 2011 23:43:17 -0000 Subject: [Buildbot-commits] [Buildbot] #2147: buildslave losing connection to buildmaster In-Reply-To: <044.5751d9dd85f0e7b228b9cf9f7caa4f49@buildbot.net> References: <044.5751d9dd85f0e7b228b9cf9f7caa4f49@buildbot.net> Message-ID: <059.3185419db12e1d64a25dacc6f15db0ca@buildbot.net> #2147: buildslave losing connection to buildmaster -------------------------------------------------+------------------------- Reporter: mariamarcano | Owner: Type: undecided | Status: new Priority: major | Milestone: undecided Version: 0.8.3 | Resolution: Keywords: buildslave losing connection to | buildmaster | -------------------------------------------------+------------------------- Comment (by mariamarcano): the issue manifest when running integration tests, xunit.console is running a process that takes a while, this was ruining fine with master and 6 slaves, had issues started appearing after added 2 more slaves. thanks for your help -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Nov 16 06:42:29 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 16 Nov 2011 06:42:29 -0000 Subject: [Buildbot-commits] [Buildbot] #2065: Error during setup of buildslave on Windows 7 64bit In-Reply-To: <046.67e1d61ea2ba36f97b6d0597743e90a8@buildbot.net> References: <046.67e1d61ea2ba36f97b6d0597743e90a8@buildbot.net> Message-ID: <061.093076ca750b758213b20e2f4ead0ea9@buildbot.net> #2065: Error during setup of buildslave on Windows 7 64bit ---------------------------+------------------------- Reporter: materialdreams | Owner: Type: undecided | Status: closed Priority: minor | Milestone: undecided Version: 0.8.4p2 | Resolution: worksforme Keywords: | ---------------------------+------------------------- Comment (by dustin): It looks like you need a newer version of distribute and/or setuptools: https://github.com/pypa/pip/issues/286 -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Wed Nov 16 15:53:35 2011 From: noreply at github.com (noreply at github.com) Date: Wed, 16 Nov 2011 07:53:35 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] 125681: Correct symbolic link to docs/release-notes.rst. Message-ID: <20111116155335.C3D1442641@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 125681bcf414f98efdee8fe1540e096174b79a8d https://github.com/buildbot/buildbot/commit/125681bcf414f98efdee8fe1540e096174b79a8d Author: Andi Albrecht Date: 2011-11-16 (Wed, 16 Nov 2011) Changed paths: M master/NEWS Log Message: ----------- Correct symbolic link to docs/release-notes.rst. Commit: e116548647703b83c5315811ae04a9abac160c38 https://github.com/buildbot/buildbot/commit/e116548647703b83c5315811ae04a9abac160c38 Author: Dustin J. Mitchell Date: 2011-11-16 (Wed, 16 Nov 2011) Changed paths: M master/NEWS Log Message: ----------- Merge pull request #283 from andialbrecht/master Correct symlink for NEWS file in master/. Compare: https://github.com/buildbot/buildbot/compare/7497eff...e116548 From nobody at buildbot.net Thu Nov 17 01:08:08 2011 From: nobody at buildbot.net (Buildbot) Date: Thu, 17 Nov 2011 01:08:08 -0000 Subject: [Buildbot-commits] [Buildbot] #2148: buildbot.schedulers.trysched.BadJobfile: unable to parse netstrings Message-ID: <041.13fa1004380c63458d36746f531598ef@buildbot.net> #2148: buildbot.schedulers.trysched.BadJobfile: unable to parse netstrings ----------------------+------------------------------------ Reporter: mlakewood | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.4p2 | Keywords: NetString Buildbot Try ----------------------+------------------------------------ Hi all, Im using buildbot try, using jobdir and ssh to submit builds to buildbot. Sometimes I get the following error/traceback in the twistd.log of the buildbot server and the job isnt run 11-11-16 16:23:21+0800 [Broker,0,127.0.0.1] slave 'slave' attaching from IPv4Address(TCP, '127.0.0.1', 38491) 2011-11-16 16:23:21+0800 [Broker,0,127.0.0.1] Starting buildslave keepalive timer for 'slave' 2011-11-16 16:23:21+0800 [Broker,0,127.0.0.1] Got slaveinfo from 'slave' 2011-11-16 16:23:21+0800 [Broker,0,127.0.0.1] bot attached 2011-11-16 16:23:21+0800 [Broker,0,127.0.0.1] Buildslave slave attached to sws-build_try 2011-11-16 16:23:21+0800 [Broker,0,127.0.0.1] Buildslave slave attached to sws-build 2011-11-16 16:23:50+0800 [-] reports a bad jobfile in 1321431829-d57b4f44f31d2eea16e0a88732cdbce6 2011-11-16 16:23:50+0800 [-] Unhandled Error Traceback (most recent call last): File "/usr/local/lib/python2.6/dist- packages/Twisted-11.0.0-py2.6-linux-i686.egg/twisted/internet/defer.py", line 964, in unwindGenerator return _deferGenerator(f(*args, **kwargs), Deferred()) File "/usr/local/lib/python2.6/dist- packages/Twisted-11.0.0-py2.6-linux-i686.egg/twisted/internet/defer.py", line 866, in _deferGenerator result = g.next() File "/usr/local/lib/python2.6/dist- packages/buildbot/util/maildir.py", line 124, in poll wfd = defer.waitForDeferred(self.messageReceived(n)) File "/usr/local/lib/python2.6/dist- packages/buildbot/schedulers/trysched.py", line 66, in messageReceived return self.parent.handleJobFile(filename, f) --- --- File "/usr/local/lib/python2.6/dist- packages/buildbot/schedulers/trysched.py", line 148, in handleJobFile parsed_job = self.parseJob(f) File "/usr/local/lib/python2.6/dist- packages/buildbot/schedulers/trysched.py", line 100, in parseJob raise BadJobfile("unable to parse netstrings") buildbot.schedulers.trysched.BadJobfile: unable to parse netstrings I've sent the file and our config to djmitche that was helping out on the IRC channel. Our setup is Client Submitting job Ubuntu 10.04, python 2.6.5 Twistd 10 Buildbot 0.8.5 Server Ubuntu 10.04 python 2.6.5 Twisted 11 Buildbot 0.8.4p2 Cheers Mark -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Thu Nov 17 02:37:24 2011 From: nobody at buildbot.net (Buildbot) Date: Thu, 17 Nov 2011 02:37:24 -0000 Subject: [Buildbot-commits] [Buildbot] #2149: "Stop build" button cannot kill dependent schedule Message-ID: <035.16ba8e8d373d7917569116956748908b@buildbot.net> #2149: "Stop build" button cannot kill dependent schedule --------------------+------------------------------------- Reporter: pwp | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.4p2 | Keywords: kill dependent schedule --------------------+------------------------------------- Stop build button cannot kill dependent schedule sched1. Even after kill the related processes in buildmaster, the buildbot still show sched1 as building. sched1 = Dependent(upstream=sched, name="test", builderNames=["test"]) c['schedulers'].append(sched1) -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Thu Nov 17 05:58:06 2011 From: nobody at buildbot.net (Buildbot) Date: Thu, 17 Nov 2011 05:58:06 -0000 Subject: [Buildbot-commits] [Buildbot] #2147: buildslave losing connection to buildmaster In-Reply-To: <044.5751d9dd85f0e7b228b9cf9f7caa4f49@buildbot.net> References: <044.5751d9dd85f0e7b228b9cf9f7caa4f49@buildbot.net> Message-ID: <059.937c41caf3c90abaccd2d04337990321@buildbot.net> #2147: buildslave losing connection to buildmaster -------------------------+-------------------- Reporter: mariamarcano | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.3 Version: 0.8.3 | Resolution: Keywords: | -------------------------+-------------------- Changes (by dustin): * keywords: buildslave losing connection to buildmaster => * type: undecided => defect * milestone: undecided => 0.8.3 Old description: > I Started getting the following issue when running the builds: > this is what i see on the buildstep / buildbot waterfall: > > remoteFailed: [Failure instance: Traceback (failure with no frames): > : Connection to the other > side was lost in a non-clean fashion. > ] > > builds were running fine, maybe related to adding more slaves to the > master?. > > Currently using Slave: > > C:\Python27\Scripts>buildslave --version > > Buildslave version: 0.8.3 > > Twisted version: 10.2.0 > > Master: > > c:\Python27\Scripts>buildbot --version > > Buildbot version: 0.8.3p1 > > Twisted version: 10.2.0 > > This is what I see on the slave twistd.log: > > 2011-11-15 10:36:35-0800 [Broker,client] RunProcess._startCommand > > 2011-11-15 10:36:35-0800 [Broker,client] 'xunit.console.exe' > 'XXTests.dll' '/html' 'xunit-output.html' > > 2011-11-15 10:36:35-0800 [Broker,client] in dir > C:\Source\xx\AutomatedTests\XXTests\bin\Release (timeout 21600 secs) > > 2011-11-15 10:36:35-0800 [Broker,client] watching logfiles {'xunit > log': 'C:\\temp\\XX_log.txt', 'xunit-output.html': 'xunit-output.html'} > > 2011-11-15 10:36:35-0800 [Broker,client] argv: ['xunit.console.exe', > 'XXTests.dll', '/html', 'xunit-output.html'] > > 2011-11-15 10:36:35-0800 [Broker,client] environment: {..} > > 2011-11-15 10:36:35-0800 [Broker,client] closing stdin > > 2011-11-15 10:36:35-0800 [Broker,client] using PTY: False > > 2011-11-15 10:46:24-0800 [-] sending app-level keepalive > > 2011-11-15 10:56:24-0800 [-] sending app-level keepalive > > 2011-11-15 11:06:24-0800 [-] sending app-level keepalive > > 2011-11-15 11:16:24-0800 [-] sending app-level keepalive > > 2011-11-15 11:26:24-0800 [-] sending app-level keepalive > > 2011-11-15 11:36:24-0800 [-] sending app-level keepalive > > 2011-11-15 11:46:24-0800 [-] sending app-level keepalive > > 2011-11-15 11:56:24-0800 [-] sending app-level keepalive > > 2011-11-15 12:06:24-0800 [-] sending app-level keepalive > > 2011-11-15 12:06:54-0800 [-] BotFactory.checkActivity: nothing from > master for 630 secs > > 2011-11-15 12:06:54-0800 [Broker,client] BotFactory.keepaliveLost > > 2011-11-15 12:06:54-0800 [Broker,client] lost remote > > 2011-11-15 12:06:54-0800 [Broker,client] lost remote step > > 2011-11-15 12:06:54-0800 [Broker,client] stopCommand: halting current > command 0x01BF2670> > > 2011-11-15 12:06:54-0800 [Broker,client] command interrupted, killing pid > 2624 > > 2011-11-15 12:06:54-0800 [Broker,client] trying > process.signalProcess('KILL') > > 2011-11-15 12:06:54-0800 [Broker,client] signal KILL sent successfully > > 2011-11-15 12:06:54-0800 [Broker,client] Lost connection to > buildbot.app.com:9989 > > 2011-11-15 12:06:54-0800 [Broker,client] instance at 0x010D3328> will retry in 1 seconds > > 2011-11-15 12:06:54-0800 [Broker,client] Stopping factory > > > 2011-11-15 12:06:56-0800 [-] Starting factory instance at 0x011EF9E0> > > 2011-11-15 12:06:56-0800 [-] Connecting to buildbot.app.com:9989 > > 2011-11-15 12:06:59-0800 [-] we tried to kill the process, and it > wouldn't die.. finish anyway > > 2011-11-15 12:06:59-0800 [-] RunProcess.failed: command failed: SIGKILL > failed to kill process > > 2011-11-15 12:06:59-0800 [-] SlaveBuilder.commandFailed None > > 2011-11-15 12:06:59-0800 [-] Unhandled Error > Traceback (most recent call last): > Failure: exceptions.RuntimeError: SIGKILL failed to kill process > > 2011-11-15 12:07:29-0800 [Broker,client] message from master: attached > > 2011-11-15 12:07:29-0800 [Broker,client] SlaveBuilder.remote_print(rc38 > -app-selenium-tests): message from master: attached > > 2011-11-15 12:07:29-0800 [Broker,client] Connected to > buildbot.app.com:9989; slave is ready > > 2011-11-15 12:07:29-0800 [Broker,client] sending application-level > keepalives every 600 seconds > > 2011-11-15 12:16:59-0800 [-] sending app-level keepalive > > 2011-11-15 12:26:59-0800 [-] sending app-level keepalive > > 2011-11-15 12:34:39-0800 [-] command finished with signal None, exit code > 1, elapsedTime: 7084.500000 > > 2011-11-15 12:34:39-0800 [-] Hey, command '['xunit.console.exe', 'XXTests.dll', '/html', 'xunit-output.html']'> > finished twice > > 2011-11-15 12:36:59-0800 [-] sending app-level keepalive > > 2011-11-15 12:46:59-0800 [-] sending app-level keepalive New description: I Started getting the following issue when running the builds: this is what i see on the buildstep / buildbot waterfall: {{{ remoteFailed: [Failure instance: Traceback (failure with no frames): : Connection to the other side was lost in a non-clean fashion. ] }}} builds were running fine, maybe related to adding more slaves to the master?. Currently using Slave: {{{ C:\Python27\Scripts>buildslave --version Buildslave version: 0.8.3 Twisted version: 10.2.0 }}} Master: {{{ c:\Python27\Scripts>buildbot --version Buildbot version: 0.8.3p1 Twisted version: 10.2.0 }}} This is what I see on the slave twistd.log: {{{ 2011-11-15 10:36:35-0800 [Broker,client] RunProcess._startCommand 2011-11-15 10:36:35-0800 [Broker,client] 'xunit.console.exe' 'XXTests.dll' '/html' 'xunit-output.html' 2011-11-15 10:36:35-0800 [Broker,client] in dir C:\Source\xx\AutomatedTests\XXTests\bin\Release (timeout 21600 secs) 2011-11-15 10:36:35-0800 [Broker,client] watching logfiles {'xunit log': 'C:\\temp\\XX_log.txt', 'xunit-output.html': 'xunit-output.html'} 2011-11-15 10:36:35-0800 [Broker,client] argv: ['xunit.console.exe', 'XXTests.dll', '/html', 'xunit-output.html'] 2011-11-15 10:36:35-0800 [Broker,client] environment: {..} 2011-11-15 10:36:35-0800 [Broker,client] closing stdin 2011-11-15 10:36:35-0800 [Broker,client] using PTY: False 2011-11-15 10:46:24-0800 [-] sending app-level keepalive 2011-11-15 10:56:24-0800 [-] sending app-level keepalive 2011-11-15 11:06:24-0800 [-] sending app-level keepalive 2011-11-15 11:16:24-0800 [-] sending app-level keepalive 2011-11-15 11:26:24-0800 [-] sending app-level keepalive 2011-11-15 11:36:24-0800 [-] sending app-level keepalive 2011-11-15 11:46:24-0800 [-] sending app-level keepalive 2011-11-15 11:56:24-0800 [-] sending app-level keepalive 2011-11-15 12:06:24-0800 [-] sending app-level keepalive 2011-11-15 12:06:54-0800 [-] BotFactory.checkActivity: nothing from master for 630 secs 2011-11-15 12:06:54-0800 [Broker,client] BotFactory.keepaliveLost 2011-11-15 12:06:54-0800 [Broker,client] lost remote 2011-11-15 12:06:54-0800 [Broker,client] lost remote step 2011-11-15 12:06:54-0800 [Broker,client] stopCommand: halting current command 2011-11-15 12:06:54-0800 [Broker,client] command interrupted, killing pid 2624 2011-11-15 12:06:54-0800 [Broker,client] trying process.signalProcess('KILL') 2011-11-15 12:06:54-0800 [Broker,client] signal KILL sent successfully 2011-11-15 12:06:54-0800 [Broker,client] Lost connection to buildbot.app.com:9989 2011-11-15 12:06:54-0800 [Broker,client] will retry in 1 seconds 2011-11-15 12:06:54-0800 [Broker,client] Stopping factory 2011-11-15 12:06:56-0800 [-] Starting factory 2011-11-15 12:06:56-0800 [-] Connecting to buildbot.app.com:9989 2011-11-15 12:06:59-0800 [-] we tried to kill the process, and it wouldn't die.. finish anyway 2011-11-15 12:06:59-0800 [-] RunProcess.failed: command failed: SIGKILL failed to kill process 2011-11-15 12:06:59-0800 [-] SlaveBuilder.commandFailed None 2011-11-15 12:06:59-0800 [-] Unhandled Error Traceback (most recent call last): Failure: exceptions.RuntimeError: SIGKILL failed to kill process 2011-11-15 12:07:29-0800 [Broker,client] message from master: attached 2011-11-15 12:07:29-0800 [Broker,client] SlaveBuilder.remote_print(rc38 -app-selenium-tests): message from master: attached 2011-11-15 12:07:29-0800 [Broker,client] Connected to buildbot.app.com:9989; slave is ready 2011-11-15 12:07:29-0800 [Broker,client] sending application-level keepalives every 600 seconds 2011-11-15 12:16:59-0800 [-] sending app-level keepalive 2011-11-15 12:26:59-0800 [-] sending app-level keepalive 2011-11-15 12:34:39-0800 [-] command finished with signal None, exit code 1, elapsedTime: 7084.500000 2011-11-15 12:34:39-0800 [-] Hey, command finished twice 2011-11-15 12:36:59-0800 [-] sending app-level keepalive 2011-11-15 12:46:59-0800 [-] sending app-level keepalive }}} -- -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Thu Nov 17 06:10:49 2011 From: nobody at buildbot.net (Buildbot) Date: Thu, 17 Nov 2011 06:10:49 -0000 Subject: [Buildbot-commits] [Buildbot] #2147: buildslave losing connection to buildmaster In-Reply-To: <044.5751d9dd85f0e7b228b9cf9f7caa4f49@buildbot.net> References: <044.5751d9dd85f0e7b228b9cf9f7caa4f49@buildbot.net> Message-ID: <059.ed03c5c5b5af6b6bd891dc19dc7275f1@buildbot.net> #2147: buildslave losing connection to buildmaster ----------------------------+-------------------- Reporter: mariamarcano | Owner: Type: support-request | Status: new Priority: major | Milestone: 0.8.3 Version: 0.8.3 | Resolution: Keywords: | ----------------------------+-------------------- Changes (by dustin): * type: defect => support-request Comment: I suspect that your master is very busy, and is not able to reply to the slave's keepalives for > 600 seconds. We've seen other similar problems, and it turns out that bailing out if you don't hear back from a keepalive is actually a bad idea, so this has been removed in newer versions. That said, if this only occurred with additional slaves, you could probably fix it by: * increasing the timeouts on the slave side * not using the waterfall, which is ridiculously CPU and IO intensive * looking at master performance in general -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Thu Nov 17 06:45:47 2011 From: nobody at buildbot.net (Buildbot) Date: Thu, 17 Nov 2011 06:45:47 -0000 Subject: [Buildbot-commits] [Buildbot] #2104: Get rid of buildbot.db.exceptions In-Reply-To: <038.a32f1401f55659de13514f87663610b8@buildbot.net> References: <038.a32f1401f55659de13514f87663610b8@buildbot.net> Message-ID: <053.ec64807e07b0596adec49d8f7ce7c5fc@buildbot.net> #2104: Get rid of buildbot.db.exceptions -----------------------------+--------------------- Reporter: dustin | Owner: Type: enhancement | Status: closed Priority: major | Milestone: 0.8.+ Version: 0.8.4p2 | Resolution: fixed Keywords: database, simple | -----------------------------+--------------------- Changes (by dustin): * status: new => closed * resolution: => fixed Comment: This got fixed in the master.config stuff that just landed. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Thu Nov 17 06:58:29 2011 From: nobody at buildbot.net (Buildbot) Date: Thu, 17 Nov 2011 06:58:29 -0000 Subject: [Buildbot-commits] [Buildbot] #2066: Fix new source steps' URL handling In-Reply-To: <038.4b2beb27a185303ae6bd92ef91a5b2d9@buildbot.net> References: <038.4b2beb27a185303ae6bd92ef91a5b2d9@buildbot.net> Message-ID: <053.e52a40d3e61670a5db24e51685422090@buildbot.net> #2066: Fix new source steps' URL handling ------------------------+-------------------- Reporter: in3xes | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.6 Version: 0.8.4p2 | Resolution: Keywords: | ------------------------+-------------------- Changes (by dustin): * keywords: Source => -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Thu Nov 17 06:59:22 2011 From: nobody at buildbot.net (Buildbot) Date: Thu, 17 Nov 2011 06:59:22 -0000 Subject: [Buildbot-commits] [Buildbot] #2066: Fix new source steps' URL handling In-Reply-To: <038.4b2beb27a185303ae6bd92ef91a5b2d9@buildbot.net> References: <038.4b2beb27a185303ae6bd92ef91a5b2d9@buildbot.net> Message-ID: <053.7ff7c892c35b8cec91b9e74c1f8694da@buildbot.net> #2066: Fix new source steps' URL handling ------------------------+-------------------- Reporter: in3xes | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.6 Version: 0.8.4p2 | Resolution: Keywords: simple | ------------------------+-------------------- Changes (by dustin): * keywords: => simple Comment: See the referenced comments. The new master-side source steps don't handle URLs the same way as the old (slave-side) source steps did, and this should be fixed. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Thu Nov 17 07:09:51 2011 From: nobody at buildbot.net (Buildbot) Date: Thu, 17 Nov 2011 07:09:51 -0000 Subject: [Buildbot-commits] [Buildbot] #2148: buildbot.schedulers.trysched.BadJobfile: unable to parse netstrings In-Reply-To: <041.13fa1004380c63458d36746f531598ef@buildbot.net> References: <041.13fa1004380c63458d36746f531598ef@buildbot.net> Message-ID: <056.74b77db6f9fddb36598f3ce6bc8f1a93@buildbot.net> #2148: buildbot.schedulers.trysched.BadJobfile: unable to parse netstrings ----------------------+-------------------- Reporter: mlakewood | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.6 Version: 0.8.4p2 | Resolution: Keywords: try | ----------------------+-------------------- Changes (by dustin): * keywords: NetString Buildbot Try => try * milestone: undecided => 0.8.6 Old description: > Hi all, > > Im using buildbot try, using jobdir and ssh to submit builds to buildbot. > Sometimes I get the following error/traceback in the twistd.log of the > buildbot server and the job isnt run > > 11-11-16 16:23:21+0800 [Broker,0,127.0.0.1] slave 'slave' attaching from > IPv4Address(TCP, '127.0.0.1', 38491) > 2011-11-16 16:23:21+0800 [Broker,0,127.0.0.1] Starting buildslave > keepalive timer for 'slave' > 2011-11-16 16:23:21+0800 [Broker,0,127.0.0.1] Got slaveinfo from 'slave' > 2011-11-16 16:23:21+0800 [Broker,0,127.0.0.1] bot attached > 2011-11-16 16:23:21+0800 [Broker,0,127.0.0.1] Buildslave slave attached > to sws-build_try > 2011-11-16 16:23:21+0800 [Broker,0,127.0.0.1] Buildslave slave attached > to sws-build > 2011-11-16 16:23:50+0800 [-] instance at 0xa6d286c> reports a bad jobfile in > 1321431829-d57b4f44f31d2eea16e0a88732cdbce6 > 2011-11-16 16:23:50+0800 [-] Unhandled Error > Traceback (most recent call last): > File "/usr/local/lib/python2.6/dist- > packages/Twisted-11.0.0-py2.6-linux-i686.egg/twisted/internet/defer.py", > line 964, in unwindGenerator > return _deferGenerator(f(*args, **kwargs), Deferred()) > File "/usr/local/lib/python2.6/dist- > packages/Twisted-11.0.0-py2.6-linux-i686.egg/twisted/internet/defer.py", > line 866, in _deferGenerator > result = g.next() > File "/usr/local/lib/python2.6/dist- > packages/buildbot/util/maildir.py", line 124, in poll > wfd = defer.waitForDeferred(self.messageReceived(n)) > File "/usr/local/lib/python2.6/dist- > packages/buildbot/schedulers/trysched.py", line 66, in messageReceived > return self.parent.handleJobFile(filename, f) > --- --- > File "/usr/local/lib/python2.6/dist- > packages/buildbot/schedulers/trysched.py", line 148, in handleJobFile > parsed_job = self.parseJob(f) > File "/usr/local/lib/python2.6/dist- > packages/buildbot/schedulers/trysched.py", line 100, in parseJob > raise BadJobfile("unable to parse netstrings") > buildbot.schedulers.trysched.BadJobfile: unable to parse > netstrings > > I've sent the file and our config to djmitche that was helping out on the > IRC channel. Our setup is > > Client Submitting job > > Ubuntu 10.04, > python 2.6.5 > Twistd 10 > Buildbot 0.8.5 > > Server > Ubuntu 10.04 > python 2.6.5 > Twisted 11 > Buildbot 0.8.4p2 > > Cheers > Mark New description: Hi all, Im using buildbot try, using jobdir and ssh to submit builds to buildbot. Sometimes I get the following error/traceback in the twistd.log of the buildbot server and the job isnt run {{{ 11-11-16 16:23:21+0800 [Broker,0,127.0.0.1] slave 'slave' attaching from IPv4Address(TCP, '127.0.0.1', 38491) 2011-11-16 16:23:21+0800 [Broker,0,127.0.0.1] Starting buildslave keepalive timer for 'slave' 2011-11-16 16:23:21+0800 [Broker,0,127.0.0.1] Got slaveinfo from 'slave' 2011-11-16 16:23:21+0800 [Broker,0,127.0.0.1] bot attached 2011-11-16 16:23:21+0800 [Broker,0,127.0.0.1] Buildslave slave attached to sws-build_try 2011-11-16 16:23:21+0800 [Broker,0,127.0.0.1] Buildslave slave attached to sws-build 2011-11-16 16:23:50+0800 [-] reports a bad jobfile in 1321431829-d57b4f44f31d2eea16e0a88732cdbce6 2011-11-16 16:23:50+0800 [-] Unhandled Error Traceback (most recent call last): File "/usr/local/lib/python2.6/dist- packages/Twisted-11.0.0-py2.6-linux-i686.egg/twisted/internet/defer.py", line 964, in unwindGenerator return _deferGenerator(f(*args, **kwargs), Deferred()) File "/usr/local/lib/python2.6/dist- packages/Twisted-11.0.0-py2.6-linux-i686.egg/twisted/internet/defer.py", line 866, in _deferGenerator result = g.next() File "/usr/local/lib/python2.6/dist- packages/buildbot/util/maildir.py", line 124, in poll wfd = defer.waitForDeferred(self.messageReceived(n)) File "/usr/local/lib/python2.6/dist- packages/buildbot/schedulers/trysched.py", line 66, in messageReceived return self.parent.handleJobFile(filename, f) --- --- File "/usr/local/lib/python2.6/dist- packages/buildbot/schedulers/trysched.py", line 148, in handleJobFile parsed_job = self.parseJob(f) File "/usr/local/lib/python2.6/dist- packages/buildbot/schedulers/trysched.py", line 100, in parseJob raise BadJobfile("unable to parse netstrings") buildbot.schedulers.trysched.BadJobfile: unable to parse netstrings }}} I've sent the file and our config to djmitche that was helping out on the IRC channel. Our setup is Client Submitting job {{{ Ubuntu 10.04, python 2.6.5 Twistd 10 Buildbot 0.8.5 }}} Server {{{ Ubuntu 10.04 python 2.6.5 Twisted 11 Buildbot 0.8.4p2 }}} Cheers Mark -- Comment: So I had a look at the file. Two odd things. First, it has a header of spaces in this format (* for space): {{{ ********************************************************************* ********************************************************************* ********************************************************************* ********************************************* }}} which may have been an artifact of the email attachment -- who knows. Stripping that, what looks like a proper netstring begins: {{{ 1:2,17:1321431405-417459,0:,3:283,1:0,106896:Index: ... }}} that portion of the netstring is, in fact, 106896 bytes long, and finishes with a few more netstring components of the proper length. Having a look at the source, though: {{{ #!python MAX_LENGTH = 99999 }}} (twisted/protocols/basic.py:115) so I think it's a matter of netstring length, as you suggested in IRC. Probably the easiest thing to do is simply increase that in your master.cfg: {{{ #!python from twisted.protocols.basic import NetstringReceiver NetstringReceiver.MAX_LENGTH = 1000000 }}} I'm not sure where best to include this in the documentation. 100KiB seems a bit small for a maximum allowed patch size in the try scheduler, but having no limits is problematic for potential memory consumption. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Thu Nov 17 07:14:54 2011 From: noreply at github.com (noreply at github.com) Date: Wed, 16 Nov 2011 23:14:54 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] b68747: include a suggestion to increase netstring max siz... Message-ID: <20111117071454.72722425EE@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: b6874701b54e0043a78882b020afc86033133f91 https://github.com/buildbot/buildbot/commit/b6874701b54e0043a78882b020afc86033133f91 Author: Dustin J. Mitchell Date: 2011-11-16 (Wed, 16 Nov 2011) Changed paths: M master/docs/manual/cfg-schedulers.rst Log Message: ----------- include a suggestion to increase netstring max size Fixes #2148. From nobody at buildbot.net Thu Nov 17 07:14:59 2011 From: nobody at buildbot.net (Buildbot) Date: Thu, 17 Nov 2011 07:14:59 -0000 Subject: [Buildbot-commits] [Buildbot] #2148: buildbot.schedulers.trysched.BadJobfile: unable to parse netstrings In-Reply-To: <041.13fa1004380c63458d36746f531598ef@buildbot.net> References: <041.13fa1004380c63458d36746f531598ef@buildbot.net> Message-ID: <056.81f58e2c53a5e689a4d21b98d2fcef51@buildbot.net> #2148: buildbot.schedulers.trysched.BadJobfile: unable to parse netstrings ----------------------+--------------------- Reporter: mlakewood | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.6 Version: 0.8.4p2 | Resolution: fixed Keywords: try | ----------------------+--------------------- Changes (by Dustin J. Mitchell): * status: new => closed * resolution: => fixed Comment: include a suggestion to increase netstring max size Fixes #2148. Changeset: b6874701b54e0043a78882b020afc86033133f91 -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Fri Nov 18 00:25:18 2011 From: noreply at github.com (noreply at github.com) Date: Thu, 17 Nov 2011 16:25:18 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] 75c888: Fixes for config changes. Message-ID: <20111118002518.67C5A42633@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 75c8886998d27ccea4d27dceeda4c4f25ce1bbf2 https://github.com/buildbot/buildbot/commit/75c8886998d27ccea4d27dceeda4c4f25ce1bbf2 Author: Tom Prince Date: 2011-11-17 (Thu, 17 Nov 2011) Changed paths: M master/buildbot/buildslave.py M master/buildbot/status/words.py Log Message: ----------- Fixes for config changes. Commit: ea9b092ae3fc6fe7916b765655031f378357e0f3 https://github.com/buildbot/buildbot/commit/ea9b092ae3fc6fe7916b765655031f378357e0f3 Author: Dustin J. Mitchell Date: 2011-11-17 (Thu, 17 Nov 2011) Changed paths: M master/buildbot/buildslave.py M master/buildbot/status/words.py Log Message: ----------- Merge pull request #285 from tomprince/fixes Fixes for config changes. Compare: https://github.com/buildbot/buildbot/compare/b687470...ea9b092 From noreply at github.com Fri Nov 18 02:03:33 2011 From: noreply at github.com (noreply at github.com) Date: Thu, 17 Nov 2011 18:03:33 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] d095ee: align startup and reconfig messages in master and ... Message-ID: <20111118020333.E84184274B@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: d095ee3558ae38fa9e302c9631df4d1bae380314 https://github.com/buildbot/buildbot/commit/d095ee3558ae38fa9e302c9631df4d1bae380314 Author: Dustin J. Mitchell Date: 2011-11-17 (Thu, 17 Nov 2011) Changed paths: M master/buildbot/master.py M master/buildbot/scripts/logwatcher.py M master/buildbot/scripts/startup.py Log Message: ----------- align startup and reconfig messages in master and logwatcher Commit: 1d16a203235f5b56f0e632cd38223508894e74db https://github.com/buildbot/buildbot/commit/1d16a203235f5b56f0e632cd38223508894e74db Author: Dustin J. Mitchell Date: 2011-11-17 (Thu, 17 Nov 2011) Changed paths: M master/buildbot/scripts/reconfig.py Log Message: ----------- get exit value right from 'buildbot reconfig' Commit: 31b65a058dc759a8586f22810ffdc4ee7121625f https://github.com/buildbot/buildbot/commit/31b65a058dc759a8586f22810ffdc4ee7121625f Author: Dustin J. Mitchell Date: 2011-11-17 (Thu, 17 Nov 2011) Changed paths: M master/buildbot/scripts/logwatcher.py Log Message: ----------- stop immediately when the server fails to start Commit: aa3a86ab69c25fe6027cd564e2458daaa5344462 https://github.com/buildbot/buildbot/commit/aa3a86ab69c25fe6027cd564e2458daaa5344462 Author: Dustin J. Mitchell Date: 2011-11-17 (Thu, 17 Nov 2011) Changed paths: M master/buildbot/process/users/manager.py M master/buildbot/status/master.py M master/buildbot/test/unit/test_status_master.py Log Message: ----------- Test for re-adding multiple status receivers, and fix. This catches a regression - looping over self, while removing things from self, results in undefined behavior. Commit: bbd12875820e5a949825fdf04cfca69b3ad513c9 https://github.com/buildbot/buildbot/commit/bbd12875820e5a949825fdf04cfca69b3ad513c9 Author: Dustin J. Mitchell Date: 2011-11-17 (Thu, 17 Nov 2011) Changed paths: M master/buildbot/config.py M master/buildbot/process/metrics.py M master/buildbot/test/unit/test_config.py Log Message: ----------- config.metrics should default to None, not {}, and be disabled in that case Commit: 7fa49becce97a1d9f622b3df23a3bf4d9b6f3b89 https://github.com/buildbot/buildbot/commit/7fa49becce97a1d9f622b3df23a3bf4d9b6f3b89 Author: Dustin J. Mitchell Date: 2011-11-17 (Thu, 17 Nov 2011) Changed paths: M master/buildbot/buildslave.py M master/buildbot/status/words.py Log Message: ----------- Merge branch 'master' of github.com:buildbot/buildbot * 'master' of github.com:buildbot/buildbot: Fixes for config changes. Compare: https://github.com/buildbot/buildbot/compare/ea9b092...7fa49be From noreply at github.com Fri Nov 18 05:27:31 2011 From: noreply at github.com (noreply at github.com) Date: Thu, 17 Nov 2011 21:27:31 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] e82868: Merge branch 'svn_export' of git://github.com/in3x... Message-ID: <20111118052731.0A5A242736@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: e82868da0232622fffee7b8408b51f4c0409850d https://github.com/buildbot/buildbot/commit/e82868da0232622fffee7b8408b51f4c0409850d Author: Dustin J. Mitchell Date: 2011-11-17 (Thu, 17 Nov 2011) Changed paths: M master/buildbot/steps/source/svn.py M master/buildbot/test/unit/test_steps_source_svn.py M master/docs/manual/cfg-buildsteps.rst M master/docs/release-notes.rst Log Message: ----------- Merge branch 'svn_export' of git://github.com/in3xes/buildbot * 'svn_export' of git://github.com/in3xes/buildbot: Add export method to svn. Fixes #2078 Conflicts: master/buildbot/steps/source/svn.py Forward-ported (by dustin) and altered to not assume workdir='build', Release Notes added, docs edited. From nobody at buildbot.net Fri Nov 18 05:27:37 2011 From: nobody at buildbot.net (Buildbot) Date: Fri, 18 Nov 2011 05:27:37 -0000 Subject: [Buildbot-commits] [Buildbot] #2078: new SVN step does not have a mode that eliminates .svn dirs In-Reply-To: <038.ead96b5a17cedc674501d24e8fc4d379@buildbot.net> References: <038.ead96b5a17cedc674501d24e8fc4d379@buildbot.net> Message-ID: <053.9112be133675e872aba98da2ef7c2934@buildbot.net> #2078: new SVN step does not have a mode that eliminates .svn dirs ------------------------+--------------------- Reporter: dustin | Owner: Type: enhancement | Status: closed Priority: major | Milestone: 0.8.6 Version: 0.8.4p2 | Resolution: fixed Keywords: svn | ------------------------+--------------------- Changes (by Dustin J. Mitchell): * status: new => closed * resolution: => fixed Comment: Merge branch 'svn_export' of git://github.com/in3xes/buildbot * 'svn_export' of git://github.com/in3xes/buildbot: Add export method to svn. Fixes #2078 Conflicts: master/buildbot/steps/source/svn.py Forward-ported (by dustin) and altered to not assume workdir='build', Release Notes added, docs edited. Changeset: e82868da0232622fffee7b8408b51f4c0409850d -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Fri Nov 18 05:33:11 2011 From: noreply at github.com (noreply at github.com) Date: Thu, 17 Nov 2011 21:33:11 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] ffe5bb: Merge branch 'lock-scheduling' Message-ID: <20111118053311.9BE354277B@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: ffe5bb2662f1554d9a83d6cbc1c1c77f2e5a1f32 https://github.com/buildbot/buildbot/commit/ffe5bb2662f1554d9a83d6cbc1c1c77f2e5a1f32 Author: Dustin J. Mitchell Date: 2011-11-17 (Thu, 17 Nov 2011) Changed paths: M master/buildbot/buildslave.py M master/buildbot/locks.py Log Message: ----------- Merge branch 'lock-scheduling' * lock-scheduling: changes suggested by dwlocks Re-try scheduling build requests for slaves when locks are released Conflicts: master/buildbot/buildslave.py From noreply at github.com Fri Nov 18 05:35:59 2011 From: noreply at github.com (noreply at github.com) Date: Thu, 17 Nov 2011 21:35:59 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] 58eb0d: Merge branch 'json_changes' of git://github.com/ta... Message-ID: <20111118053559.2223742783@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 58eb0d5f40e95dc12f6be2001b084fb4acd5c2a9 https://github.com/buildbot/buildbot/commit/58eb0d5f40e95dc12f6be2001b084fb4acd5c2a9 Author: Dustin J. Mitchell Date: 2011-11-17 (Thu, 17 Nov 2011) Changed paths: M master/buildbot/status/builder.py M master/buildbot/status/web/status_json.py Log Message: ----------- Merge branch 'json_changes' of git://github.com/tardyp/buildbot * 'json_changes' of git://github.com/tardyp/buildbot: builder: add information about schedulers in asDict status_json: add numbuilds argument in slave From nobody at buildbot.net Fri Nov 18 07:33:31 2011 From: nobody at buildbot.net (Buildbot) Date: Fri, 18 Nov 2011 07:33:31 -0000 Subject: [Buildbot-commits] [Buildbot] #2000: "alwaysUseLatest" doesn't do what it says In-Reply-To: <041.16f29ce554aad5e31a1a961ab126f0d3@buildbot.net> References: <041.16f29ce554aad5e31a1a961ab126f0d3@buildbot.net> Message-ID: <056.13e18acbd186aa233cc04759a8d45c85@buildbot.net> #2000: "alwaysUseLatest" doesn't do what it says --------------------------+-------------------- Reporter: dabrahams | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.4p1 | Resolution: Keywords: git, projrepo | --------------------------+-------------------- Comment (by brendan): Is there a reason for the builder to override the branch for git when alwaysUseLatest is set? In git the revision is more precise than the branch, so when alwaysUseLatest isn't set, branch is meaningless. So it seems like the 'branch' field should override whatever's coming in from the build. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Nov 20 20:00:14 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 20 Nov 2011 20:00:14 -0000 Subject: [Buildbot-commits] [Buildbot] #2150: Interpolate lists into lists using properties Message-ID: <038.14f993230a6f84afcbdc15438565f7ea@buildbot.net> #2150: Interpolate lists into lists using properties ----------------------+----------------------- Reporter: mmadia | Owner: Type: undecided | Status: new Priority: major | Milestone: undecided Version: 0.8.5 | Keywords: ----------------------+----------------------- The following usage of properties={},Property() will not work as expected. master.cfg: {{{ BuildSlave("my-build-slave", "my-password", properties={ 'configure':'--use-gcc-pipe --use-xattr' }) #.... fX86Quick.addStep(ShellCommand( command=[ '../../haiku/configure', Property('configure'), '--cross-tools-prefix', '../../cross-tools-x86gcc2/cross-tools/bin/i586-pc- haiku-'], description="Configuring X86 GCC 2 normal with cross-tools- prefix", name="Configure cross-tools-prefix x86gcc2")) }}} logs/stdio {{{ ../../haiku/configure '--use-gcc-pipe --use-xattr' --cross-tools-prefix ../../cross-tools-x86gcc2/cross-tools/bin/i586-pc-haiku- in dir /storage/public/mmadia-buildbot- exp/sandbox/slave/x86gcc2-quick/build (timeout 1200 secs) watching logfiles {} argv: ['../../haiku/configure', '--use-gcc-pipe --use-xattr', '--cross- tools-prefix', '../../cross-tools-x86gcc2/cross-tools/bin/i586-pc-haiku-'] environment: SHELL=/usr/local/bin/bash using PTY: False Invalid argument: `--use-gcc-pipe --use-xattr' program finished with exit code 1 elapsedTime=0.008083 }}} -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Nov 23 06:08:53 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 23 Nov 2011 06:08:53 -0000 Subject: [Buildbot-commits] [Buildbot] #2151: Buildbot adds an wrong argument to bzr command line Message-ID: <040.ba355ab1cabf176bd4b5432414498a88@buildbot.net> #2151: Buildbot adds an wrong argument to bzr command line ---------------------+----------------------- Reporter: sleebin9 | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.5 | Keywords: bzr ---------------------+----------------------- Buildbot checkout step fails. The log says "bzr: ERROR: extra argument to command checkout: ['-r', u'3730']". After checked the log, we found buildbot generates a wrong bzr command. It is bzr checkout bzr+ssh://buildbot at 172.16.70.152/data/bzrroot/mysql-server /greatsql-trunk . "['-r', u'3730']" -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Nov 23 06:13:22 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 23 Nov 2011 06:13:22 -0000 Subject: [Buildbot-commits] [Buildbot] #2151: Buildbot adds an wrong argument to bzr command line In-Reply-To: <040.ba355ab1cabf176bd4b5432414498a88@buildbot.net> References: <040.ba355ab1cabf176bd4b5432414498a88@buildbot.net> Message-ID: <055.58c5423da0d7540fed0b7f8026b81d14@buildbot.net> #2151: Buildbot adds an wrong argument to bzr command line ---------------------+------------------------ Reporter: sleebin9 | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.5 | Resolution: Keywords: bzr | ---------------------+------------------------ Comment (by sleebin9): Buildbot generated a 'bzr checkout' command with an wrong option like {{{ bzr checkout . "['-r', u'3730']" }}} So buildslave was aborted by the wrong command. It was caused by a wrong function call in bzr.py. List.append appends an object treat. "['-r', self.revision]" is treated as an List object. List object's string output is '[elem1, elem2, ..]'. To solve the problem, List.extend instead of List.append is used. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Thu Nov 24 04:53:50 2011 From: nobody at buildbot.net (Buildbot) Date: Thu, 24 Nov 2011 04:53:50 -0000 Subject: [Buildbot-commits] [Buildbot] #2000: "alwaysUseLatest" doesn't do what it says In-Reply-To: <041.16f29ce554aad5e31a1a961ab126f0d3@buildbot.net> References: <041.16f29ce554aad5e31a1a961ab126f0d3@buildbot.net> Message-ID: <056.9a90183bd3d126f43c34aae307d37a8a@buildbot.net> #2000: "alwaysUseLatest" doesn't do what it says --------------------------+-------------------- Reporter: dabrahams | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.4p1 | Resolution: Keywords: git, projrepo | --------------------------+-------------------- Comment (by dustin): I suspect that people rely on the current behavior, e.g., to build the same branch name in multiple repos. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Thu Nov 24 06:37:36 2011 From: nobody at buildbot.net (Buildbot) Date: Thu, 24 Nov 2011 06:37:36 -0000 Subject: [Buildbot-commits] [Buildbot] #2152: Let forced build properties override all others Message-ID: <039.9170da361be89e31dd1b29dc58e838d7@buildbot.net> #2152: Let forced build properties override all others --------------------+------------------------ Reporter: brendan | Owner: Type: defect | Status: new Priority: minor | Milestone: undecided Version: 0.8.5 | Keywords: properties --------------------+------------------------ I have some slaves with certain default properties set, but I'd like to be able to override them in a forced build. Right now the forced build silently discards my specified properties. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Thu Nov 24 16:09:52 2011 From: noreply at github.com (noreply at github.com) Date: Thu, 24 Nov 2011 08:09:52 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] a35433: change lingering texinfo-isms Message-ID: <20111124160952.C721242F6F@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: a35433ec0cb548f65d251105b4179e1384dd9665 https://github.com/buildbot/buildbot/commit/a35433ec0cb548f65d251105b4179e1384dd9665 Author: Dustin J. Mitchell Date: 2011-11-23 (Wed, 23 Nov 2011) Changed paths: M master/docs/manual/cfg-buildsteps.rst Log Message: ----------- change lingering texinfo-isms Commit: 54728899517a134f6b3678fcd038c796f51072d5 https://github.com/buildbot/buildbot/commit/54728899517a134f6b3678fcd038c796f51072d5 Author: Dustin J. Mitchell Date: 2011-11-24 (Thu, 24 Nov 2011) Changed paths: M master/buildbot/process/properties.py M master/buildbot/test/unit/test_process_properties.py M master/docs/manual/cfg-properties.rst M master/docs/release-notes.rst Log Message: ----------- Allow Properties(default=..) to contain further properties Commit: d0d2c3d4cfa8928fdba4550593afe2134f5d9939 https://github.com/buildbot/buildbot/commit/d0d2c3d4cfa8928fdba4550593afe2134f5d9939 Author: Dustin J. Mitchell Date: 2011-11-24 (Thu, 24 Nov 2011) Changed paths: M master/docs/manual/cfg-buildsteps.rst Log Message: ----------- minor docs edit Compare: https://github.com/buildbot/buildbot/compare/58eb0d5...d0d2c3d From nobody at buildbot.net Thu Nov 24 18:03:14 2011 From: nobody at buildbot.net (Buildbot) Date: Thu, 24 Nov 2011 18:03:14 -0000 Subject: [Buildbot-commits] [Buildbot] #2152: Let forced build properties override all others In-Reply-To: <039.9170da361be89e31dd1b29dc58e838d7@buildbot.net> References: <039.9170da361be89e31dd1b29dc58e838d7@buildbot.net> Message-ID: <054.af09eb54a215b58323954a9a965d98f7@buildbot.net> #2152: Let forced build properties override all others -----------------------+------------------------ Reporter: brendan | Owner: Type: defect | Status: closed Priority: minor | Milestone: undecided Version: 0.8.5 | Resolution: wontfix Keywords: properties | -----------------------+------------------------ Changes (by dustin): * status: new => closed * resolution: => wontfix Comment: As tomprince mentioned in channel, this is because slave parameters override scheduler parameters -- see http://buildbot.net/buildbot/docs/latest/manual/cfg- properties.html#properties With the !ForceScheduler changes that are about to land (https://github.com/buildbot/buildbot/pull/278), this will seem more sensible, since the builds will be triggered by the force scheduler. In other words, this is by design and expected behavior. You'll need to work around this with your properties. We did add the ability to use properties in a Properties(default=..): https://github.com/buildbot/buildbot/commit/54728899517a134f6b3678fcd038c796f51072d5 -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Fri Nov 25 16:04:51 2011 From: noreply at github.com (noreply at github.com) Date: Fri, 25 Nov 2011 08:04:51 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] 69eb16: Add note about pyasn1-0.1.1 bug Message-ID: <20111125160451.AB5AA42CCA@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 69eb1685ffc3a111ccff5b9e9670a216ccbebb35 https://github.com/buildbot/buildbot/commit/69eb1685ffc3a111ccff5b9e9670a216ccbebb35 Author: Dustin J. Mitchell Date: 2011-11-25 (Fri, 25 Nov 2011) Changed paths: M master/docs/tutorial/tour.rst Log Message: ----------- Add note about pyasn1-0.1.1 bug This was brought up on the mailing list on November 22 by Maarten Verwijs. From nobody at buildbot.net Sat Nov 26 16:37:18 2011 From: nobody at buildbot.net (Buildbot) Date: Sat, 26 Nov 2011 16:37:18 -0000 Subject: [Buildbot-commits] [Buildbot] #2150: flatten nested lists in ShellCommands commands=.. (was: Interpolate lists into lists using properties) In-Reply-To: <038.14f993230a6f84afcbdc15438565f7ea@buildbot.net> References: <038.14f993230a6f84afcbdc15438565f7ea@buildbot.net> Message-ID: <053.89a974ffb02a1d9633760a7b130f9381@buildbot.net> #2150: flatten nested lists in ShellCommands commands=.. ------------------------+-------------------- Reporter: mmadia | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.6 Version: 0.8.5 | Resolution: Keywords: simple | ------------------------+-------------------- Changes (by dustin): * keywords: => simple * type: undecided => enhancement * milestone: undecided => 0.8.6 -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sat Nov 26 17:33:40 2011 From: noreply at github.com (noreply at github.com) Date: Sat, 26 Nov 2011 09:33:40 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] 741e1a: allow new-style c['db'] = .. Message-ID: <20111126173340.586BE425B8@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 741e1a6adf45924e5843073383e0f5708aa5cce7 https://github.com/buildbot/buildbot/commit/741e1a6adf45924e5843073383e0f5708aa5cce7 Author: Dustin J. Mitchell Date: 2011-11-26 (Sat, 26 Nov 2011) Changed paths: M master/buildbot/config.py Log Message: ----------- allow new-style c['db'] = .. Commit: 1a09bcb06a6321b939d18dfb98cd7df89b3dd824 https://github.com/buildbot/buildbot/commit/1a09bcb06a6321b939d18dfb98cd7df89b3dd824 Author: Dustin J. Mitchell Date: 2011-11-26 (Sat, 26 Nov 2011) Changed paths: M master/buildbot/scripts/runner.py M master/buildbot/scripts/sample.cfg Log Message: ----------- fix create-master and upgrade-master create-master now creates the correct db, and edits master.cfg.sample accordingly. upgrade-master now correctly pulls the db_url value from the config and ugprades that database Compare: https://github.com/buildbot/buildbot/compare/69eb168...1a09bcb From noreply at github.com Sat Nov 26 18:02:04 2011 From: noreply at github.com (noreply at github.com) Date: Sat, 26 Nov 2011 10:02:04 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] 4954bf: Use command.extend to add -r argument to bzr updat... Message-ID: <20111126180204.E4EDA4299A@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 4954bf4fff3163409022d24a60d57506e7306352 https://github.com/buildbot/buildbot/commit/4954bf4fff3163409022d24a60d57506e7306352 Author: Dustin J. Mitchell Date: 2011-11-26 (Sat, 26 Nov 2011) Changed paths: M master/buildbot/steps/source/bzr.py M master/buildbot/test/unit/test_steps_source_bzr.py Log Message: ----------- Use command.extend to add -r argument to bzr update/checkout Fixes #2151. Including new tests of all occurrences. From nobody at buildbot.net Sat Nov 26 18:02:09 2011 From: nobody at buildbot.net (Buildbot) Date: Sat, 26 Nov 2011 18:02:09 -0000 Subject: [Buildbot-commits] [Buildbot] #2151: Buildbot adds an wrong argument to bzr command line In-Reply-To: <040.ba355ab1cabf176bd4b5432414498a88@buildbot.net> References: <040.ba355ab1cabf176bd4b5432414498a88@buildbot.net> Message-ID: <055.87a75db566baa456df4ed11eaec102c0@buildbot.net> #2151: Buildbot adds an wrong argument to bzr command line ---------------------+------------------------ Reporter: sleebin9 | Owner: Type: defect | Status: closed Priority: major | Milestone: undecided Version: 0.8.5 | Resolution: fixed Keywords: bzr | ---------------------+------------------------ Changes (by Dustin J. Mitchell): * status: new => closed * resolution: => fixed Comment: Use command.extend to add -r argument to bzr update/checkout Fixes #2151. Including new tests of all occurrences. Changeset: 4954bf4fff3163409022d24a60d57506e7306352 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Nov 26 18:05:58 2011 From: nobody at buildbot.net (Buildbot) Date: Sat, 26 Nov 2011 18:05:58 -0000 Subject: [Buildbot-commits] [Buildbot] #2151: Buildbot adds an wrong argument to bzr command line In-Reply-To: <040.ba355ab1cabf176bd4b5432414498a88@buildbot.net> References: <040.ba355ab1cabf176bd4b5432414498a88@buildbot.net> Message-ID: <055.0637bb13f64f090c3559b42565ec7a5c@buildbot.net> #2151: Buildbot adds an wrong argument to bzr command line ---------------------+------------------------ Reporter: sleebin9 | Owner: Type: defect | Status: closed Priority: major | Milestone: undecided Version: 0.8.5 | Resolution: fixed Keywords: bzr | ---------------------+------------------------ Comment (by dustin): Oops, now that I see your patch, I see that I missed one :) -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sat Nov 26 18:06:28 2011 From: noreply at github.com (noreply at github.com) Date: Sat, 26 Nov 2011 10:06:28 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] a15f76: one additional command.append in bzr.py Message-ID: <20111126180628.5D9C8429A4@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: a15f7652817f0ce6fdbff36e14ac4c7b4646f3e0 https://github.com/buildbot/buildbot/commit/a15f7652817f0ce6fdbff36e14ac4c7b4646f3e0 Author: Dustin J. Mitchell Date: 2011-11-26 (Sat, 26 Nov 2011) Changed paths: M master/buildbot/steps/source/bzr.py M master/buildbot/test/unit/test_steps_source_bzr.py Log Message: ----------- one additional command.append in bzr.py Refs #2151. From nobody at buildbot.net Sat Nov 26 18:06:34 2011 From: nobody at buildbot.net (Buildbot) Date: Sat, 26 Nov 2011 18:06:34 -0000 Subject: [Buildbot-commits] [Buildbot] #2151: Buildbot adds an wrong argument to bzr command line In-Reply-To: <040.ba355ab1cabf176bd4b5432414498a88@buildbot.net> References: <040.ba355ab1cabf176bd4b5432414498a88@buildbot.net> Message-ID: <055.279dfbd970fb693631d5db5141d0bd26@buildbot.net> #2151: Buildbot adds an wrong argument to bzr command line ---------------------+------------------------ Reporter: sleebin9 | Owner: Type: defect | Status: closed Priority: major | Milestone: undecided Version: 0.8.5 | Resolution: fixed Keywords: bzr | ---------------------+------------------------ Comment (by Dustin J. Mitchell): one additional command.append in bzr.py Refs #2151. Changeset: a15f7652817f0ce6fdbff36e14ac4c7b4646f3e0 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Nov 26 23:30:40 2011 From: nobody at buildbot.net (Buildbot) Date: Sat, 26 Nov 2011 23:30:40 -0000 Subject: [Buildbot-commits] [Buildbot] #2127: Git 1.7.7: Recent change causes buildbot to always fail to fetch from git In-Reply-To: <040.4bdbb1fd8d851abd20e958f552f40733@buildbot.net> References: <040.4bdbb1fd8d851abd20e958f552f40733@buildbot.net> Message-ID: <055.de2cb0463ec41a5291f85ea669e7468c@buildbot.net> #2127: Git 1.7.7: Recent change causes buildbot to always fail to fetch from git ---------------------+------------------------ Reporter: cdavis5x | Owner: Type: defect | Status: closed Priority: critical | Milestone: undecided Version: master | Resolution: fixed Keywords: git | ---------------------+------------------------ Comment (by dustin): This was fixed in 6f5ce3b2ab033338f3ad7ddccbf8b6542311f70b. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Nov 27 11:28:47 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 27 Nov 2011 11:28:47 -0000 Subject: [Buildbot-commits] [Buildbot] #2153: Master-side git source step always uses default branch after clone Message-ID: <036.c50ccb745b2fe2556ca841426b0f0f81@buildbot.net> #2153: Master-side git source step always uses default branch after clone ----------------------+----------------------------- Reporter: Tobi | Owner: Type: undecided | Status: new Priority: major | Milestone: undecided Version: master | Keywords: master-side git ----------------------+----------------------------- Master-side git source step doesn't respect the branch property of the build request when has to do a full clone. This means that for all modes/methods, it may build the wrong branch if the source dir is not updateable, and in particular '''full/clobber will always build the default branch''', regardless of the branch property. This happens because the master-side git source step only does a git clone if source is missing: it does not checkout any branch in particular, so it will happen to build the branch git clone checked out (typically, master). -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Nov 27 11:43:25 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 27 Nov 2011 11:43:25 -0000 Subject: [Buildbot-commits] [Buildbot] #2154: Master-side git source step breaks revision+shallow Message-ID: <036.86713fb284eb4264cef6d32314567f45@buildbot.net> #2154: Master-side git source step breaks revision+shallow ----------------------+----------------------------- Reporter: Tobi | Owner: Type: undecided | Status: new Priority: minor | Milestone: undecided Version: 0.8.5 | Keywords: git master-side ----------------------+----------------------------- Master-side git source step breaks situation of specifying shallow=True, and then passing a revision property to a build request, that it hasn't / won't fetch, due to the shallow clone. Slave-side git source step would, with full builds, detect this situation and do a "git init ; git fetch ..." instead. E.g. this code in slave-side git source step: {{{ #!python # If they didn't ask for a specific revision, we can get away with a # shallow clone. if not self.args.get('revision') and self.args.get('shallow'): }}} I'm not sure how slave-side git handled incremental builds in shallow clones. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Nov 27 11:53:42 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 27 Nov 2011 11:53:42 -0000 Subject: [Buildbot-commits] [Buildbot] #2155: Change git submodule handling in incremental builds Message-ID: <036.07f814fcec807e9739bac3f40e62497b@buildbot.net> #2155: Change git submodule handling in incremental builds ------------------------+---------------------------- Reporter: Tobi | Owner: Type: enhancement | Status: new Priority: major | Milestone: undecided Version: 0.8.5 | Keywords: git submodules ------------------------+---------------------------- Currently, master-side git source step does only "git submodule update --recursive" if submodules=True. Thus: * If upstream adds a new submodule, it won't be visible to the slaves before they perform a full/clobber build. As far as I know, there is no way to trigger a full/clobber build in an incremental builder remotely: someone needs to go on the slave machine and remove the build directory. * If the fetch URL of a submodule changes, the slave won't be able to update it anymore. This is uncommon, but may happen nevertheless (e.g., if someone who's submodule you have added changes his github username ;-)). So I suggest to add always the "--init" argument to "git submodule update", so that new submodules get picked up. This will solve the first point. The second point can be fixed by running "git submodule sync" before "git submodule update". -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Nov 27 11:59:11 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 27 Nov 2011 11:59:11 -0000 Subject: [Buildbot-commits] [Buildbot] #2154: Master-side git source step breaks revision+shallow In-Reply-To: <036.86713fb284eb4264cef6d32314567f45@buildbot.net> References: <036.86713fb284eb4264cef6d32314567f45@buildbot.net> Message-ID: <051.0f7ce6f6fd683e754acdd83bfc7bbc20@buildbot.net> #2154: Master-side git source step breaks revision+shallow ----------------------------+------------------------ Reporter: Tobi | Owner: Type: defect | Status: new Priority: minor | Milestone: undecided Version: master | Resolution: Keywords: git master-side | ----------------------------+------------------------ Changes (by Tobi): * version: 0.8.5 => master * type: undecided => defect -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Nov 27 11:59:33 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 27 Nov 2011 11:59:33 -0000 Subject: [Buildbot-commits] [Buildbot] #2155: Change git submodule handling in incremental builds In-Reply-To: <036.07f814fcec807e9739bac3f40e62497b@buildbot.net> References: <036.07f814fcec807e9739bac3f40e62497b@buildbot.net> Message-ID: <051.a14e32970e5941a626fa3253d896a0d3@buildbot.net> #2155: Change git submodule handling in incremental builds ---------------------------+------------------------ Reporter: Tobi | Owner: Type: enhancement | Status: new Priority: major | Milestone: undecided Version: master | Resolution: Keywords: git submodules | ---------------------------+------------------------ Changes (by Tobi): * version: 0.8.5 => master -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Nov 27 13:26:15 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 27 Nov 2011 13:26:15 -0000 Subject: [Buildbot-commits] [Buildbot] #2156: Master-side git step does not rename local branch Message-ID: <036.e104f6f0d415ead3cbc379afb2ddd1f9@buildbot.net> #2156: Master-side git step does not rename local branch -------------------+----------------------- Reporter: Tobi | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: master | Keywords: -------------------+----------------------- While the slave-side git step uses "git branch -M " to rename the local branch to the requested branch, the master-side git step does not do this. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sun Nov 27 17:52:43 2011 From: noreply at github.com (noreply at github.com) Date: Sun, 27 Nov 2011 09:52:43 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] 166d0d: use uname, if possible, on slaves, to avoid socket... Message-ID: <20111127175243.D8D68426FC@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 166d0de13ca38643b69ca2140c00f5981ba0d9d9 https://github.com/buildbot/buildbot/commit/166d0de13ca38643b69ca2140c00f5981ba0d9d9 Author: Dustin J. Mitchell Date: 2011-11-26 (Sat, 26 Nov 2011) Changed paths: M slave/buildslave/bot.py M slave/buildslave/test/unit/test_bot_BuildSlave.py Log Message: ----------- use uname, if possible, on slaves, to avoid socket.getfqdn hangs Commit: 7fb2bf75dcd3316245f7d2a085dae39e13677516 https://github.com/buildbot/buildbot/commit/7fb2bf75dcd3316245f7d2a085dae39e13677516 Author: Dustin J. Mitchell Date: 2011-11-27 (Sun, 27 Nov 2011) Changed paths: A master/buildbot/db/migrate/versions/015_remove_bad_master_objectid.py M master/buildbot/master.py M master/buildbot/test/integration/test_upgrade.py A master/buildbot/test/unit/test_db_migrate_versions_015_remove_bad_master_objectid.py M master/buildbot/test/unit/test_master.py A master/buildbot/test/util/migration.py M master/docs/developer/database.rst Log Message: ----------- Fix master state tracking. In the previous version, the master tracked its last_processed_change using a name/class of 'master'/'buildbot.master.BuildMaster', but tracked build requests using the master name with class 'BuildMaster'. The migration script given here combines these two objects into one, discarding the last_processed_change value if it is ambiguous which master owns it. In the end, the object name is the master name, and the class is 'buildbot.master.BuildMaster'. This also adds a framework for unit-testing migration scripts, and uses it. Compare: https://github.com/buildbot/buildbot/compare/a15f765...7fb2bf7 From noreply at github.com Sun Nov 27 18:47:32 2011 From: noreply at github.com (noreply at github.com) Date: Sun, 27 Nov 2011 10:47:32 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] 7897ec: ensure that the master's class name is changed in ... Message-ID: <20111127184732.2DDFE425B5@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 7897ec5f93e7b7717ef6f0775fef3081f8e34414 https://github.com/buildbot/buildbot/commit/7897ec5f93e7b7717ef6f0775fef3081f8e34414 Author: Dustin J. Mitchell Date: 2011-11-27 (Sun, 27 Nov 2011) Changed paths: M master/buildbot/db/migrate/versions/015_remove_bad_master_objectid.py M master/buildbot/test/integration/test_upgrade.py M master/buildbot/test/unit/test_db_migrate_versions_015_remove_bad_master_objectid.py Log Message: ----------- ensure that the master's class name is changed in all cases Commit: 4e485aa4c6e5024e7dd98f39c0dee111291105c9 https://github.com/buildbot/buildbot/commit/4e485aa4c6e5024e7dd98f39c0dee111291105c9 Author: Dustin J. Mitchell Date: 2011-11-27 (Sun, 27 Nov 2011) Changed paths: M master/buildbot/test/unit/test_master.py A master/buildbot/test/util/misc.py M slave/buildslave/test/unit/test_bot_BuildSlave.py M slave/buildslave/test/util/misc.py Log Message: ----------- handle patching os.uname correctly on Windows Compare: https://github.com/buildbot/buildbot/compare/7fb2bf7...4e485aa From noreply at github.com Sun Nov 27 19:08:54 2011 From: noreply at github.com (noreply at github.com) Date: Sun, 27 Nov 2011 11:08:54 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] d0afd9: small docs fixes Message-ID: <20111127190854.85A8F4256A@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: d0afd9b6727e77a79c004794128c5dc887ef14d5 https://github.com/buildbot/buildbot/commit/d0afd9b6727e77a79c004794128c5dc887ef14d5 Author: Dustin J. Mitchell Date: 2011-11-27 (Sun, 27 Nov 2011) Changed paths: M master/docs/manual/installation.rst Log Message: ----------- small docs fixes From nobody at buildbot.net Sun Nov 27 19:14:57 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 27 Nov 2011 19:14:57 -0000 Subject: [Buildbot-commits] [Buildbot] #2157: drop support for Python-2.4 Message-ID: <038.ef994c5ec15e437a654d0b735959adeb@buildbot.net> #2157: drop support for Python-2.4 ------------------------+-------------------- Reporter: dustin | Owner: dustin Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: master | Keywords: ------------------------+-------------------- This will happen *after* 0.8.6 is released. This was discussed on the mailing list [http://comments.gmane.org/gmane.comp.python.buildbot.devel/7907 here]. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sun Nov 27 19:16:45 2011 From: noreply at github.com (noreply at github.com) Date: Sun, 27 Nov 2011 11:16:45 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] 842221: Advertise 2.5 requirement in the next version afte... Message-ID: <20111127191645.35344426DF@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 8422217fff87fe11b27f17ea982be4b78f3921c6 https://github.com/buildbot/buildbot/commit/8422217fff87fe11b27f17ea982be4b78f3921c6 Author: Dustin J. Mitchell Date: 2011-11-27 (Sun, 27 Nov 2011) Changed paths: M master/docs/manual/installation.rst M master/docs/release-notes.rst Log Message: ----------- Advertise 2.5 requirement in the next version after 0.8.6 From nobody at buildbot.net Sun Nov 27 19:28:55 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 27 Nov 2011 19:28:55 -0000 Subject: [Buildbot-commits] [Buildbot] #2156: Master-side git step does not rename local branch In-Reply-To: <036.e104f6f0d415ead3cbc379afb2ddd1f9@buildbot.net> References: <036.e104f6f0d415ead3cbc379afb2ddd1f9@buildbot.net> Message-ID: <051.ee43bb9c3af3a24a4a86aaa58b265236@buildbot.net> #2156: Master-side git step does not rename local branch -------------------+------------------------ Reporter: Tobi | Owner: Tobi Type: defect | Status: assigned Priority: major | Milestone: undecided Version: master | Resolution: Keywords: | -------------------+------------------------ Changes (by Tobi): * owner: => Tobi * status: new => assigned -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Nov 27 23:10:23 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 27 Nov 2011 23:10:23 -0000 Subject: [Buildbot-commits] [Buildbot] #2157: drop support for Python-2.4 In-Reply-To: <038.ef994c5ec15e437a654d0b735959adeb@buildbot.net> References: <038.ef994c5ec15e437a654d0b735959adeb@buildbot.net> Message-ID: <053.d5c11e2567cb645e75e09d5980756736@buildbot.net> #2157: drop support for Python-2.4 ------------------------+--------------------- Reporter: dustin | Owner: dustin Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: master | Resolution: Keywords: | ------------------------+--------------------- Comment (by dustin): Let's keep compatibility with 2.4 on slaves for as long as practical - that shouldn't be too hard, since the slave code is rarely modified and much simpler than the master. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Nov 27 23:12:15 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 27 Nov 2011 23:12:15 -0000 Subject: [Buildbot-commits] [Buildbot] #2158: db version 011 unintentionally drops indexes, foreign-key constraints on buildrequests Message-ID: <038.c1fbadee4af70f3764b93df47ffa5bf8@buildbot.net> #2158: db version 011 unintentionally drops indexes, foreign-key constraints on buildrequests -------------------+---------------------- Reporter: dustin | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.6 Version: 0.8.5 | Keywords: database -------------------+---------------------- See discussion at https://github.com/buildbot/buildbot/commit/8b1cee84683fd185d46aea193a01f2b42b4f5503#commitcomment-747834 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Nov 28 01:04:52 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 28 Nov 2011 01:04:52 -0000 Subject: [Buildbot-commits] [Buildbot] #2158: db version 011 unintentionally drops indexes, foreign-key constraints on buildrequests In-Reply-To: <038.c1fbadee4af70f3764b93df47ffa5bf8@buildbot.net> References: <038.c1fbadee4af70f3764b93df47ffa5bf8@buildbot.net> Message-ID: <053.a4c396b18f5252dda05f26ce4e38cb46@buildbot.net> #2158: db version 011 unintentionally drops indexes, foreign-key constraints on buildrequests ---------------------+-------------------- Reporter: dustin | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.6 Version: 0.8.5 | Resolution: Keywords: database | ---------------------+-------------------- Comment (by dustin): Ugh, sqlalchemy-migrate strikes again :( Logging this upgrade on sqlite shows: {{{ 2011-11-27 18:48:36-0600 [-] ALTER TABLE buildrequests RENAME TO migration_tmp 2011-11-27 18:48:36-0600 [-] () 2011-11-27 18:48:36-0600 [-] COMMIT 2011-11-27 18:48:36-0600 [-]? ????CREATE TABLE buildrequests ( ????????id INTEGER NOT NULL,? ????????buildsetid INTEGER NOT NULL,? ????????buildername VARCHAR(256) NOT NULL,? ????????priority INTEGER DEFAULT '0' NOT NULL,? ????????claimed_by_incarnation VARCHAR(256),? ????????complete INTEGER DEFAULT '0',? ????????results SMALLINT,? ????????submitted_at INTEGER NOT NULL,? ????????complete_at INTEGER,? ????????PRIMARY KEY (id) ????) ???? ???? 2011-11-27 18:48:36-0600 [-] () 2011-11-27 18:48:36-0600 [-] COMMIT 2011-11-27 18:48:36-0600 [-] INSERT INTO buildrequests SELECT id ,buildsetid ,buildername ,priority ,claimed_by_incarnation ,complete ,results ,submitted_at ,complete_at from migration_tmp 2011-11-27 18:48:36-0600 [-] () 2011-11-27 18:48:36-0600 [-] COMMIT 2011-11-27 18:48:36-0600 [-] DROP TABLE migration_tmp 2011-11-27 18:48:36-0600 [-] () 2011-11-27 18:48:36-0600 [-] COMMIT }}} -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Tue Nov 29 05:30:13 2011 From: noreply at github.com (noreply at github.com) Date: Mon, 28 Nov 2011 21:30:13 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] 9fc056: test migration with a fixed table definition, rath... Message-ID: <20111129053013.127C042353@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 9fc0562284b7a2306fa00058760839ebaf0f7a91 https://github.com/buildbot/buildbot/commit/9fc0562284b7a2306fa00058760839ebaf0f7a91 Author: Dustin J. Mitchell Date: 2011-11-27 (Sun, 27 Nov 2011) Changed paths: M master/buildbot/test/unit/test_db_migrate_versions_015_remove_bad_master_objectid.py Log Message: ----------- test migration with a fixed table definition, rather than model.py Commit: dba638142e8ab7aa2e612c7c99d608614354f7c0 https://github.com/buildbot/buildbot/commit/dba638142e8ab7aa2e612c7c99d608614354f7c0 Author: Dustin J. Mitchell Date: 2011-11-27 (Sun, 27 Nov 2011) Changed paths: M master/buildbot/test/util/migration.py A master/buildbot/test/util/querylog.py Log Message: ----------- add query logging to all migration tests Commit: 2aa97b8d889e91fb27ddbcc680cecd379975b92d https://github.com/buildbot/buildbot/commit/2aa97b8d889e91fb27ddbcc680cecd379975b92d Author: Dustin J. Mitchell Date: 2011-11-28 (Mon, 28 Nov 2011) Changed paths: A master/buildbot/db/migrate/versions/016_restore_buildrequest_indices.py A master/buildbot/test/unit/test_db_migrate_versions_011_add_buildrequest_claims.py A master/buildbot/test/unit/test_db_migrate_versions_016_restore_buildrequest_indices.py Log Message: ----------- Restore lost indices from db version 011 This adds some tests both to demonstrate the failure in 011, and to demonstrate that it's fixed in 016. Fixes #2158. Thanks to Benoit Allard for noticing this! Compare: https://github.com/buildbot/buildbot/compare/8422217...2aa97b8 From nobody at buildbot.net Tue Nov 29 05:30:20 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 29 Nov 2011 05:30:20 -0000 Subject: [Buildbot-commits] [Buildbot] #2158: db version 011 unintentionally drops indexes, foreign-key constraints on buildrequests In-Reply-To: <038.c1fbadee4af70f3764b93df47ffa5bf8@buildbot.net> References: <038.c1fbadee4af70f3764b93df47ffa5bf8@buildbot.net> Message-ID: <053.45392ee7871afa39d6f6eb0e8a51ebd2@buildbot.net> #2158: db version 011 unintentionally drops indexes, foreign-key constraints on buildrequests ---------------------+--------------------- Reporter: dustin | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.6 Version: 0.8.5 | Resolution: fixed Keywords: database | ---------------------+--------------------- Changes (by Dustin J. Mitchell): * status: new => closed * resolution: => fixed Comment: Restore lost indices from db version 011 This adds some tests both to demonstrate the failure in 011, and to demonstrate that it's fixed in 016. Fixes #2158. Thanks to Benoit Allard for noticing this! Changeset: 2aa97b8d889e91fb27ddbcc680cecd379975b92d -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Tue Nov 29 05:50:11 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 29 Nov 2011 05:50:11 -0000 Subject: [Buildbot-commits] [Buildbot] #2158: db version 011 unintentionally drops indexes, foreign-key constraints on buildrequests In-Reply-To: <038.c1fbadee4af70f3764b93df47ffa5bf8@buildbot.net> References: <038.c1fbadee4af70f3764b93df47ffa5bf8@buildbot.net> Message-ID: <053.29f88307fde0cdb7dceedc1ef734ac10@buildbot.net> #2158: db version 011 unintentionally drops indexes, foreign-key constraints on buildrequests ---------------------+----------------------- Reporter: dustin | Owner: Type: defect | Status: reopened Priority: major | Milestone: 0.8.6 Version: 0.8.5 | Resolution: Keywords: database | ---------------------+----------------------- Changes (by dustin): * status: closed => reopened * resolution: fixed => Comment: Hm, adding index comparison to the `compare_model_to_db` calls shows that there's more breakage than just this.. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Tue Nov 29 06:17:50 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 29 Nov 2011 06:17:50 -0000 Subject: [Buildbot-commits] [Buildbot] #2158: db version 011 unintentionally drops indexes, foreign-key constraints on buildrequests In-Reply-To: <038.c1fbadee4af70f3764b93df47ffa5bf8@buildbot.net> References: <038.c1fbadee4af70f3764b93df47ffa5bf8@buildbot.net> Message-ID: <053.f1474d9ee36615c03bec76e3349b9aca@buildbot.net> #2158: db version 011 unintentionally drops indexes, foreign-key constraints on buildrequests ---------------------+----------------------- Reporter: dustin | Owner: Type: defect | Status: reopened Priority: major | Milestone: 0.8.6 Version: 0.8.5 | Resolution: Keywords: database | ---------------------+----------------------- Comment (by dustin): I'm tracking these fixes at https://github.com/djmitche/buildbot/commits /index-tests -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Tue Nov 29 19:15:11 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 29 Nov 2011 19:15:11 -0000 Subject: [Buildbot-commits] [Buildbot] #97: Use svn switch to improve efficiency In-Reply-To: <041.fdcc077787c8f6a36b12df6a065f70a9@buildbot.net> References: <041.fdcc077787c8f6a36b12df6a065f70a9@buildbot.net> Message-ID: <056.e0ebc440d14df38e58ce38473cc4ad8e@buildbot.net> #97: Use svn switch to improve efficiency ------------------------+------------------------ Reporter: retracile | Owner: Type: enhancement | Status: reopened Priority: major | Milestone: undecided Version: 0.7.5 | Resolution: Keywords: | ------------------------+------------------------ Changes (by duncanphilipnorman): * cc: duncanphilipnorman@? (added) * status: closed => reopened * resolution: wontfix => Comment: Replying to [comment:1 dustin]: > You write: > An 'svn switch' of a working copy containing unversioned files can in some cases fail; that is not handled in this patch. > which is what worries me. I'm always in favor of burning a few more cycles over introducing spurious build failures. I'm using a similar patch against [milestone:0.8.3], which I'll attach as [attachment:buildbot-slave-0.8.3-svn_switch.patch]. Here's why I think the patch (or the one above) should be reconsidered, despite `svn switch` sometimes failing: 1. Saves a ton of resources when using a single builder for multiple branches (common situation). 1. Low risk, since `SourceBaseCommand.doVC` uses `SourceBaseCommand.maybeDoVCFallback` if the update fails. * `maybeDoVCFallback` calls `doClobber` and then `doVCFull`. * In particular, if the `update`/`switch` fails, then we're getting the old behaviour (clobber and checkout). A build step that succeeds without this patch will succeed with this patch (possible coding bugs aside). (''I hope it's okay to reopen this ticket; let me know if I should just start a new one with the same summary and description.'') -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Wed Nov 30 03:38:38 2011 From: noreply at github.com (noreply at github.com) Date: Tue, 29 Nov 2011 19:38:38 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] 9bdc51: Log queries during upgrade tests, and compare inde... Message-ID: <20111130033838.72430426D1@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 9bdc51d8054550e67d4131d48c4047cc290f0d41 https://github.com/buildbot/buildbot/commit/9bdc51d8054550e67d4131d48c4047cc290f0d41 Author: Dustin J. Mitchell Date: 2011-11-29 (Tue, 29 Nov 2011) Changed paths: M master/buildbot/test/integration/test_upgrade.py Log Message: ----------- Log queries during upgrade tests, and compare indexes Note that this fails: none of the changes or schedulers indexes exist after upgrade with SQLite (Which is the only DB that the upgrade tests use). Hand verification shows that they do exist with MySQL and Postgres. Commit: ae887a9dacbf22711f848352f308860ed07b4017 https://github.com/buildbot/buildbot/commit/ae887a9dacbf22711f848352f308860ed07b4017 Author: Dustin J. Mitchell Date: 2011-11-29 (Tue, 29 Nov 2011) Changed paths: M master/buildbot/db/migrate/versions/016_restore_buildrequest_indices.py A master/buildbot/db/migrate/versions/017_restore_other_indices.py M master/buildbot/test/unit/test_db_migrate_versions_016_restore_buildrequest_indices.py A master/buildbot/test/unit/test_db_migrate_versions_017_restore_other_indices.py Log Message: ----------- more index fixes This restores changes_author changes_branch changes_category changes_revision changes_when_timestamp name_and_class that were accidentally deleted on SQLite, and also fixes the uniqueness constraint on users.identifier. Commit: de15bdf49ee3920c18b2eddb6e56ca3df4025245 https://github.com/buildbot/buildbot/commit/de15bdf49ee3920c18b2eddb6e56ca3df4025245 Author: Dustin J. Mitchell Date: 2011-11-29 (Tue, 29 Nov 2011) Changed paths: M master/buildbot/test/integration/test_upgrade.py M master/buildbot/test/util/db.py Log Message: ----------- try an empty upgrade of the real db, too, and give better diffs of indexes Commit: de676629f55a012553d90e12811f1000a1a569fc https://github.com/buildbot/buildbot/commit/de676629f55a012553d90e12811f1000a1a569fc Author: Dustin J. Mitchell Date: 2011-11-29 (Tue, 29 Nov 2011) Changed paths: M master/buildbot/db/migrate/versions/017_restore_other_indices.py M master/buildbot/db/model.py Log Message: ----------- move object_identity index into a separate index object Commit: 758743661897250985341f3e3132424cb88e3138 https://github.com/buildbot/buildbot/commit/758743661897250985341f3e3132424cb88e3138 Author: Dustin J. Mitchell Date: 2011-11-29 (Tue, 29 Nov 2011) Changed paths: M master/buildbot/db/migrate/versions/017_restore_other_indices.py M master/buildbot/db/model.py M master/buildbot/test/integration/test_upgrade.py M master/buildbot/test/unit/test_db_migrate_versions_017_restore_other_indices.py Log Message: ----------- fixes for all supported database engines Commit: 127a9fe523c786f73f6b6d1f4543eca659ba7fe4 https://github.com/buildbot/buildbot/commit/127a9fe523c786f73f6b6d1f4543eca659ba7fe4 Author: Dustin J. Mitchell Date: 2011-11-29 (Tue, 29 Nov 2011) Changed paths: M master/docs/developer/database.rst Log Message: ----------- mention new tests and implied_indexes in docs Commit: 3d8126969e61ef579fc12545b0d844354bf9eaf4 https://github.com/buildbot/buildbot/commit/3d8126969e61ef579fc12545b0d844354bf9eaf4 Author: Dustin J. Mitchell Date: 2011-11-29 (Tue, 29 Nov 2011) Changed paths: M master/buildbot/db/migrate/versions/016_restore_buildrequest_indices.py A master/buildbot/db/migrate/versions/017_restore_other_indices.py M master/buildbot/db/model.py M master/buildbot/test/integration/test_upgrade.py M master/buildbot/test/unit/test_db_migrate_versions_016_restore_buildrequest_indices.py A master/buildbot/test/unit/test_db_migrate_versions_017_restore_other_indices.py M master/buildbot/test/util/db.py M master/docs/developer/database.rst Log Message: ----------- Merge branch 'index-tests' * index-tests: mention new tests and implied_indexes in docs fixes for all supported database engines move object_identity index into a separate index object try an empty upgrade of the real db, too, and give better diffs of indexes more index fixes Log queries during upgrade tests, and compare indexes Fixes #2158 Compare: https://github.com/buildbot/buildbot/compare/2aa97b8...3d81269 From nobody at buildbot.net Wed Nov 30 03:38:44 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 30 Nov 2011 03:38:44 -0000 Subject: [Buildbot-commits] [Buildbot] #2158: db version 011 unintentionally drops indexes, foreign-key constraints on buildrequests In-Reply-To: <038.c1fbadee4af70f3764b93df47ffa5bf8@buildbot.net> References: <038.c1fbadee4af70f3764b93df47ffa5bf8@buildbot.net> Message-ID: <053.379a1e9bff2d734ad95a0dae23cd5ad1@buildbot.net> #2158: db version 011 unintentionally drops indexes, foreign-key constraints on buildrequests ---------------------+--------------------- Reporter: dustin | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.6 Version: 0.8.5 | Resolution: fixed Keywords: database | ---------------------+--------------------- Changes (by Dustin J. Mitchell): * status: reopened => closed * resolution: => fixed Comment: Merge branch 'index-tests' * index-tests: mention new tests and implied_indexes in docs fixes for all supported database engines move object_identity index into a separate index object try an empty upgrade of the real db, too, and give better diffs of indexes more index fixes Log queries during upgrade tests, and compare indexes Fixes #2158 Changeset: 3d8126969e61ef579fc12545b0d844354bf9eaf4 -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Wed Nov 30 03:48:07 2011 From: noreply at github.com (noreply at github.com) Date: Tue, 29 Nov 2011 19:48:07 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] 36d392: don't use conditional expressions that aren't avai... Message-ID: <20111130034807.97D24426E1@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 36d392ad69c34b55f2107c384c8e0efcfc3f3bf3 https://github.com/buildbot/buildbot/commit/36d392ad69c34b55f2107c384c8e0efcfc3f3bf3 Author: Dustin J. Mitchell Date: 2011-11-29 (Tue, 29 Nov 2011) Changed paths: M master/buildbot/test/integration/test_upgrade.py Log Message: ----------- don't use conditional expressions that aren't available on 2.4 From noreply at github.com Wed Nov 30 06:31:58 2011 From: noreply at github.com (noreply at github.com) Date: Tue, 29 Nov 2011 22:31:58 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] 2e6e74: implied indexes are only present in MySQL, not Pos... Message-ID: <20111130063158.D6639426D1@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 2e6e7419c6674460593d780aff94fbc7e939e800 https://github.com/buildbot/buildbot/commit/2e6e7419c6674460593d780aff94fbc7e939e800 Author: Dustin J. Mitchell Date: 2011-11-29 (Tue, 29 Nov 2011) Changed paths: M master/buildbot/db/model.py M master/buildbot/test/integration/test_upgrade.py M master/docs/developer/database.rst Log Message: ----------- implied indexes are only present in MySQL, not Postgres Commit: d13c9a931140616f246e3b86f457795443185df1 https://github.com/buildbot/buildbot/commit/d13c9a931140616f246e3b86f457795443185df1 Author: Dustin J. Mitchell Date: 2011-11-29 (Tue, 29 Nov 2011) Changed paths: M master/buildbot/test/integration/test_upgrade.py Log Message: ----------- fix copy/paste error looking at the wrong index Compare: https://github.com/buildbot/buildbot/compare/36d392a...d13c9a9 From nobody at buildbot.net Wed Nov 30 06:46:18 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 30 Nov 2011 06:46:18 -0000 Subject: [Buildbot-commits] [Buildbot] #97: Use svn switch to improve efficiency In-Reply-To: <041.fdcc077787c8f6a36b12df6a065f70a9@buildbot.net> References: <041.fdcc077787c8f6a36b12df6a065f70a9@buildbot.net> Message-ID: <056.2cf94904fe9b2dcfdc58959cabe888f1@buildbot.net> #97: Use svn switch to improve efficiency ------------------------+------------------------ Reporter: retracile | Owner: Type: enhancement | Status: reopened Priority: major | Milestone: undecided Version: 0.7.5 | Resolution: Keywords: | ------------------------+------------------------ Comment (by dustin): Reopening is fine. However, this should be implemented in the new master- side step, rather than in the slave-side step. On the master-side step, this should probably be a new method for the svn step. Thanks for continuing to work on this - let me know if you need any pointers! -- Ticket URL: Buildbot Buildbot: build/test automation