[Buildbot-commits] [Buildbot] #1971: Nightly timered build using incorrect change for revision

[Buildbot]

#1971: Nightly timered build using incorrect change for revision
--------------------+------------------------
Reporter:  zacw     |       Owner:
    Type:  defect   |      Status:  new
Priority:  major    |   Milestone:  undecided
 Version:  0.8.3p1  |  Resolution:
Keywords:           |
--------------------+------------------------

Comment (by dustin):

 Here's the code in {{{Nightly}}} that's handling this case:
 {{{
 #!python
             changeids = sorted(classifications.keys())
             wfd = defer.waitForDeferred(
                     self.addBuildsetForChanges(reason=self.reason,
 changeids=changeids))
             yield wfd
             wfd.getResult()
 }}}
 so from what I can tell, changeids should be [31,32,35,36] in this case.
 Then, in source:master/buildbot/schedulers/base.py,
 {{{
 #!python
         # attributes for this sourcestamp will be based on the most recent
         # change, so fetch the change with the highest id
         d = self.master.db.changes.getChange(max(changeids))
         def chdict2change(chdict):
             if not chdict:
                 return None
             return changes.Change.fromChdict(self.master, chdict)
         d.addCallback(chdict2change)
         def create_sourcestamp(change):
             return self.master.db.sourcestamps.addSourceStamp(
                     branch=change.branch,
                     revision=change.revision,
                     repository=change.repository,
                     project=change.project,
                     changeids=changeids)
         d.addCallback(create_sourcestamp)
         d.addCallback(self.addBuildsetForSourceStamp, reason=reason,
                                 external_idstring=external_idstring,
                                 builderNames=builderNames,
                                 properties=properties)
         return d
 }}}

 so max(changeids) there should be 36, not 31.

 Can you add some {{{print}}} statements to this code to verify, or to see
 what's wrong?

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1971#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation