[Buildbot-commits] [Buildbot] #1967: mode="copy" fails the second+ time around on win32, due to the directory sticking around.

[Buildbot]

#1967: mode="copy" fails the second+ time around on win32, due to the directory
sticking around.
----------------------+-----------------------
Reporter:  tfogal     |      Owner:
    Type:  undecided  |     Status:  new
Priority:  major      |  Milestone:  undecided
 Version:  0.8.3p1    |   Keywords:  windows
----------------------+-----------------------
 The buildstep:
 {{{
 tvk.addStep(SVN(svnurl=tuvok_root,
                 mode="copy",
                 always_purge=True,
                 alwaysUseLatest=True))
 }}}

 is failing every iteration beyond the first on a Windows 7 machine.  The
 issue appears to be that the build directory still exists.

 I notice that with the OS X build step, the first thing an SVN() step does
 is `rm -rf` the `build/` directory.  The SVN() step on windows does no
 such thing.  First thing it does is a `status`, then the `update` it
 should do.

 Error message I get, with shortened ("`xxx`") paths:

 {{{
 Since we're on a non-POSIX platform, we're not going to try to execute cp
 in a subprocess, but instead use shutil.copytree(), which will block until
 it is complete.  fromdir: c:\xxx\source, todir: c:\xxx\build

 remoteFailed: [Failure instance: Traceback from remote host -- Traceback
 (most recent call last):
   File "c:\Python26\lib\site-packages\twisted\internet\defer.py", line
 280, in unpause
     self._runCallbacks()
   File "c:\Python26\lib\site-packages\twisted\internet\defer.py", line
 323, in _runCallbacks
     self.result = callback(self.result, *args, **kw)
   File "c:\Python26\lib\site-packages\twisted\internet\defer.py", line
 284, in _continue
     self.unpause()
   File "c:\Python26\lib\site-packages\twisted\internet\defer.py", line
 280, in unpause
     self._runCallbacks()
 --- <exception caught here> ---
   File "c:\Python26\lib\site-packages\twisted\internet\defer.py", line
 323, in _runCallbacks
     self.result = callback(self.result, *args, **kw)
   File "c:\Python26\lib\site-packages\buildslave\commands\base.py", line
 533, in doCopy
     shutil.copytree(fromdir, todir)
   File "c:\Python26\lib\shutil.py", line 146, in copytree
     os.makedirs(dst)
   File "c:\Python26\lib\os.py", line 157, in makedirs
     mkdir(name, mode)
 exceptions.WindowsError: [Error 183] Cannot create a file when that file
 already exists: 'c:\\xxx\\build'
 ]
 }}}

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1967>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation