[Buildbot-commits] [Buildbot] #1961: Better monkey-patching architecture

[Buildbot]

#1961: Better monkey-patching architecture
------------------------+-----------------------
Reporter:  dustin       |       Owner:  dustin
    Type:  enhancement  |      Status:  reopened
Priority:  major        |   Milestone:  0.8.4
 Version:  0.8.3p1      |  Resolution:
Keywords:               |
------------------------+-----------------------
Changes (by dustin):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 That did not fix the tests, at least; on FreeBSD:

 {{{
 (view as text)

 ===============================================================================
 [ERROR]
 Traceback (most recent call last):
 Failure: twisted.internet.defer.TimeoutError:
 <buildbot.test.unit.test_contrib_buildbot_cvs_mail.TestBuildbotCvsMail
 testMethod=test_buildbot_cvs_mail_from_cvs1_11>
 (test_buildbot_cvs_mail_from_cvs1_11) still running at 120.0 secs

 buildbot.test.unit.test_contrib_buildbot_cvs_mail.TestBuildbotCvsMail.test_buildbot_cvs_mail_from_cvs1_11
 ===============================================================================
 [ERROR]
 Traceback (most recent call last):
 Failure: twisted.trial.util.DirtyReactorAggregateError: Reactor was
 unclean.
 Selectables:
 <twisted.internet.process.ProcessReader object at 0x29fa980c>
 <twisted.internet.process.ProcessReader object at 0x29fa9e8c>

 buildbot.test.unit.test_contrib_buildbot_cvs_mail.TestBuildbotCvsMail.test_buildbot_cvs_mail_from_cvs1_11
 ===============================================================================
 [ERROR]
 Traceback (most recent call last):
 Failure: twisted.internet.defer.TimeoutError:
 <buildbot.test.unit.test_contrib_buildbot_cvs_mail.TestBuildbotCvsMail
 testMethod=test_buildbot_cvs_mail_from_cvs1_12>
 (test_buildbot_cvs_mail_from_cvs1_12) still running at 120.0 secs

 buildbot.test.unit.test_contrib_buildbot_cvs_mail.TestBuildbotCvsMail.test_buildbot_cvs_mail_from_cvs1_12
 ===============================================================================
 [ERROR]
 Traceback (most recent call last):
 Failure: twisted.trial.util.DirtyReactorAggregateError: Reactor was
 unclean.
 Selectables:
 <twisted.internet.process.ProcessReader object at 0x29fa98ac>
 <twisted.internet.process.ProcessReader object at 0x29fa9ecc>

 buildbot.test.unit.test_contrib_buildbot_cvs_mail.TestBuildbotCvsMail.test_buildbot_cvs_mail_from_cvs1_12
 -------------------------------------------------------------------------------
 Ran 737 tests in 296.503s

 FAILED (errors=4, successes=735)

 }}}

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1961#comment:2>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation