[Buildbot-commits] [buildbot/buildbot] 39cdbc: Fix db.changes.addChange to not create or return a...

[noreply at github.com]

Branch: refs/heads/master
Home:   https://github.com/buildbot/buildbot

Commit: 39cdbc3a26807d89ed17e2ac660cd10fe8587f82
    https://github.com/buildbot/buildbot/commit/39cdbc3a26807d89ed17e2ac660cd10fe8587f82
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-05-08 (Sun, 08 May 2011)

Changed paths:
  M master/buildbot/db/changes.py
  M master/buildbot/master.py
  M master/buildbot/test/fake/fakedb.py
  M master/buildbot/test/unit/test_db_changes.py
  M master/buildbot/test/unit/test_master.py

Log Message:
-----------
Fix db.changes.addChange to not create or return a Change instance

The master.addChange wrapper, however, still does return such an
instance, and this is what all of the ChangeSources point to.


Commit: a252ba26b4e3d20e81e44951b82e33d5fcc87e09
    https://github.com/buildbot/buildbot/commit/a252ba26b4e3d20e81e44951b82e33d5fcc87e09
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-05-09 (Mon, 09 May 2011)

Changed paths:
  M master/buildbot/db/changes.py
  M master/buildbot/master.py
  M master/buildbot/test/unit/test_db_changes.py
  M master/buildbot/test/unit/test_master.py

Log Message:
-----------
Refactor db.addChange parameters

This makes the following changes:
* 'who' becomes 'author'
* 'isdir' becomes 'is_dir'
* 'when' becomes 'when_timestamp', and changes type to datetime
* 'properties' must now specify a source ({ k : (v,s) }), just like
    the same argument to addBuildset

The master.addChange method takes care of these translations, so Change
Sources need not be altered, although it will log a warning for the old
parameters (except for properties).  Built-in change sources will be
changed in a subsequent commit.


Commit: 56d87cb6f798a613da76990b039ece45aea6e3a8
    https://github.com/buildbot/buildbot/commit/56d87cb6f798a613da76990b039ece45aea6e3a8
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-05-09 (Mon, 09 May 2011)

Changed paths:
  M master/buildbot/changes/bonsaipoller.py
  M master/buildbot/changes/gerritchangesource.py
  M master/buildbot/changes/gitpoller.py
  M master/buildbot/changes/p4poller.py
  M master/buildbot/changes/pb.py
  M master/buildbot/test/unit/test_changes_bonsaipoller.py
  M master/buildbot/test/unit/test_changes_gerritchangesource.py
  M master/buildbot/test/unit/test_changes_gitpoller.py
  M master/buildbot/test/unit/test_changes_p4poller.py
  M master/buildbot/test/unit/test_changes_pb.py

Log Message:
-----------
Update change sources to use the new addChange parameter names

Note that sendchange will still use the old parameter names on the wire,
although the master accepts the new names now.  Once 0.8.4 or higher are
the majority of installed masters, we can alter sendchange.

Refs #1905.


Commit: a3112345af637253c70de8782ce79e7fa618c143
    https://github.com/buildbot/buildbot/commit/a3112345af637253c70de8782ce79e7fa618c143
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-05-09 (Mon, 09 May 2011)

Changed paths:
  M master/buildbot/changes/bonsaipoller.py
  M master/buildbot/changes/changes.py
  M master/buildbot/changes/gerritchangesource.py
  M master/buildbot/changes/gitpoller.py
  M master/buildbot/changes/p4poller.py
  M master/buildbot/changes/pb.py
  M master/buildbot/db/changes.py
  M master/buildbot/master.py
  M master/buildbot/schedulers/base.py
  M master/buildbot/schedulers/basic.py
  M master/buildbot/sourcestamp.py
  M master/buildbot/status/master.py
  M master/buildbot/status/web/console.py
  M master/buildbot/status/web/waterfall.py
  M master/buildbot/test/fake/fakedb.py
  M master/buildbot/test/integration/test_upgrade.py
  M master/buildbot/test/regressions/test_bad_change_properties_rows.py
  M master/buildbot/test/regressions/test_import_unicode_changes.py
  M master/buildbot/test/unit/test_changes_bonsaipoller.py
  M master/buildbot/test/unit/test_changes_gerritchangesource.py
  M master/buildbot/test/unit/test_changes_gitpoller.py
  M master/buildbot/test/unit/test_changes_p4poller.py
  M master/buildbot/test/unit/test_changes_pb.py
  M master/buildbot/test/unit/test_db_changes.py
  M master/buildbot/test/unit/test_master.py

Log Message:
-----------
Merge branch 'bug1905'

* bug1905:
  Update change sources to use the new addChange parameter names
  Refactor db.addChange parameters
  Fix db.changes.addChange to not create or return a Change instance
  replace db.changes.getChangeInstance with getChange
  Remove db.changes.getRecentChangeInstances
  Define a chdict, using names based on db columns
  Begin to transition db.changes to use chdicts
  Rename private parameter to SourceStamp.__init__


Compare: https://github.com/buildbot/buildbot/compare/e095585...a311234