[Buildbot-commits] [Buildbot] #1946: buildbot.steps.transfer._FileWriter uses __del__

[Buildbot]

#1946: buildbot.steps.transfer._FileWriter uses __del__
------------------------+--------------------
Reporter:  dustin       |       Owner:
    Type:  enhancement  |      Status:  new
Priority:  major        |   Milestone:  0.8.4
 Version:  master       |  Resolution:
Keywords:  performance  |
------------------------+--------------------

Comment (by tom.prince):

 There are probably two ways to handle this. Move the logic from __del__ to
 the errback of the remote transfer command, or hook into the brokers
 notifyOnConnectionLost.

 A related issue is whether the logic in remote_close (particularly for the
 _DirectoryWriter) should be driven by the slave.

 Lastly, (so it doesn't get lost), the slave exposes uploading a file, or a
 directory as a tarfile. It would seem reasonable to expose the latter
 ability directly, which would (in some cases) save generating and storing
 a tarfile on the slave.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1946#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation