From nobody at buildbot.net Sun May 1 02:43:45 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 01 May 2011 02:43:45 -0000 Subject: [Buildbot-commits] [Buildbot] #1943: Suppress warnings from old twisted on Darwin Message-ID: <041.c136a0f5736559a2294f9f9222dbd25b@buildbot.net> #1943: Suppress warnings from old twisted on Darwin ------------------------+----------------------- Reporter: dabrahams | Owner: Type: enhancement | Status: new Priority: major | Milestone: undecided Version: 0.8.3p1 | Keywords: ------------------------+----------------------- MacOS users are saddled with twisted 0.8.2 because upgrading apparently disturbs some built-in functionality of MacOS. As a result, these warnings occur: {{{ /System/Library/Frameworks/Python.framework/Versions/2.6/Extras/lib/python/twisted/internet/_sslverify.py:5: DeprecationWarning: the md5 module is deprecated; use hashlib instead import itertools, md5 /System/Library/Frameworks/Python.framework/Versions/2.6/Extras/lib/python/twisted/python/filepath.py:12: DeprecationWarning: the sha module is deprecated; use the hashlib module instead import sha /System/Library/Frameworks/Python.framework/Versions/2.6/Extras/lib/python/twisted/web/microdom.py:181: SyntaxWarning: assertion is always true, perhaps remove parentheses? assert (oldChild.parentNode is self, /Library/Python/2.6/site-packages/lazy_reload.py:83: DeprecationWarning: the MimeWriter module is deprecated; use the email package instead }}} These warnings interfere with my local configuration testing. Buildbot gives me no way to suppress these warnings other than by patching the installed buildbot executable, which I do by adding: {{{ #!python from warnings import filterwarnings filterwarnings('ignore', r'the .* module is deprecated; use .* instead|assertion is always true, perhaps remove parentheses\?') }}} It would be nicer if BB took care of this for me. I guess I couldn't really blame you if you decided this was a twisted issue, but as I say, twisted can't be upgraded. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun May 1 15:27:36 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 01 May 2011 15:27:36 -0000 Subject: [Buildbot-commits] [Buildbot] #1943: Suppress warnings from old twisted on Darwin In-Reply-To: <041.c136a0f5736559a2294f9f9222dbd25b@buildbot.net> References: <041.c136a0f5736559a2294f9f9222dbd25b@buildbot.net> Message-ID: <056.3ccc455567643fa4b7827d80f9fc0078@buildbot.net> #1943: Suppress warnings from old twisted on Darwin ------------------------+------------------------ Reporter: dabrahams | Owner: Type: enhancement | Status: closed Priority: major | Milestone: undecided Version: 0.8.3p1 | Resolution: wontfix Keywords: | ------------------------+------------------------ Changes (by dustin): * status: new => closed * resolution: => wontfix Comment: Well, you can use any version of Twisted you'd like in a virtualenv - just don't upgrade the system Twisted (which I believe caldav depends on, among other things). I think the technique you've suggested is the best for this situation. I'd be hesitant to filter those warnings globally, and I think that special-casing them for the particular version of Twisted and Python found on a mac would be a bit too complicated. I'm surprised Apple has shipped an incompatible version of Twisted and Python - or have you ugpraded Python? Also, note that the final warning is not even in Twisted - it's in lazy_reload.py, which I believe is your code? -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun May 1 16:00:22 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 01 May 2011 16:00:22 -0000 Subject: [Buildbot-commits] [Buildbot] #1943: Suppress warnings from old twisted on Darwin In-Reply-To: <041.c136a0f5736559a2294f9f9222dbd25b@buildbot.net> References: <041.c136a0f5736559a2294f9f9222dbd25b@buildbot.net> Message-ID: <056.b7567cf9c6b9710c84429269087f561a@buildbot.net> #1943: Suppress warnings from old twisted on Darwin ------------------------+------------------------ Reporter: dabrahams | Owner: Type: enhancement | Status: closed Priority: major | Milestone: undecided Version: 0.8.3p1 | Resolution: wontfix Keywords: | ------------------------+------------------------ Comment (by dabrahams): Replying to [comment:1 dustin]: > Well, you can use any version of Twisted you'd like in a virtualenv - just don't upgrade the system Twisted (which I believe caldav depends on, among other things). Right, or I can use a different Python that comes with macports. However, that's all more complication than I want to deal with. > I think the technique you've suggested is the best for this situation. I'd be hesitant to filter those warnings globally, and I think that special-casing them for the particular version of Twisted and Python found on a mac would be a bit too complicated. > > I'm surprised Apple has shipped an incompatible version of Twisted and Python - or have you ugpraded Python? Nope; that's the built-in one. > Also, note that the final warning is not even in Twisted - it's in lazy_reload.py, which I believe is your code? Yes, but since lazy_reload doesn't use the thing being warned about, I figure it's spurious. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun May 1 16:18:13 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 01 May 2011 16:18:13 -0000 Subject: [Buildbot-commits] [Buildbot] #1943: Suppress warnings from old twisted on Darwin In-Reply-To: <041.c136a0f5736559a2294f9f9222dbd25b@buildbot.net> References: <041.c136a0f5736559a2294f9f9222dbd25b@buildbot.net> Message-ID: <056.1d70a252bfde9770cf380a1310d1fdc9@buildbot.net> #1943: Suppress warnings from old twisted on Darwin ------------------------+------------------------ Reporter: dabrahams | Owner: Type: enhancement | Status: closed Priority: major | Milestone: undecided Version: 0.8.3p1 | Resolution: wontfix Keywords: | ------------------------+------------------------ Comment (by dustin): Replying to [comment:2 dabrahams]: > Replying to [comment:1 dustin]: > > Well, you can use any version of Twisted you'd like in a virtualenv - just don't upgrade the system Twisted (which I believe caldav depends on, among other things). > > Right, or I can use a different Python that comes with macports. However, that's all more complication than I want to deal with. Perhaps, but I think that's the right solution here. Most deployments of Python apps occur in virtualenvs these days, as far as I can tell. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sun May 1 17:00:43 2011 From: noreply at github.com (noreply at github.com) Date: Sun, 1 May 2011 10:00:43 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 78322b: mention Blocker in NEWS Message-ID: <20110501170043.ED2F6422DD@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 78322b74dc976294e659dbf10c5f95ec05642652 https://github.com/buildbot/buildbot/commit/78322b74dc976294e659dbf10c5f95ec05642652 Author: Dustin J. Mitchell Date: 2011-04-30 (Sat, 30 Apr 2011) Changed paths: M master/NEWS Log Message: ----------- mention Blocker in NEWS Commit: 2808007ea8ee913b5d525d0d946947e9721725cc https://github.com/buildbot/buildbot/commit/2808007ea8ee913b5d525d0d946947e9721725cc Author: Dustin J. Mitchell Date: 2011-05-01 (Sun, 01 May 2011) Changed paths: M master/buildbot/db/buildrequests.py A master/buildbot/db/builds.py M master/buildbot/db/connector.py M master/buildbot/test/fake/fakedb.py A master/buildbot/test/unit/test_db_builds.py Log Message: ----------- add master.db.builds Commit: 96f07a34a39d0b506379afdff0d49164964b5b61 https://github.com/buildbot/buildbot/commit/96f07a34a39d0b506379afdff0d49164964b5b61 Author: Dustin J. Mitchell Date: 2011-05-01 (Sun, 01 May 2011) Changed paths: M master/buildbot/process/builder.py Log Message: ----------- refactor Builder._startBuildFor into a deferredGenerator Compare: https://github.com/buildbot/buildbot/compare/b433334...96f07a3 From noreply at github.com Sun May 1 17:07:44 2011 From: noreply at github.com (noreply at github.com) Date: Sun, 1 May 2011 10:07:44 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 002809: do not violate foreign key constraints in tests Message-ID: <20110501170744.37623423D3@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 00280980f201e2cb0254bfcd794301f219588bee https://github.com/buildbot/buildbot/commit/00280980f201e2cb0254bfcd794301f219588bee Author: Dustin J. Mitchell Date: 2011-05-01 (Sun, 01 May 2011) Changed paths: M master/buildbot/test/unit/test_db_builds.py Log Message: ----------- do not violate foreign key constraints in tests From nobody at buildbot.net Sun May 1 20:52:43 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 01 May 2011 20:52:43 -0000 Subject: [Buildbot-commits] [Buildbot] #1944: ?project= Message-ID: <041.284fa08995a1bb2d59b6361a6d1f9ef5@buildbot.net> #1944: ?project= ----------------------+----------------------- Reporter: dabrahams | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: master | Keywords: ----------------------+----------------------- http://buildbot.net/buildbot/docs/latest/Change-Hooks.html makes it sound like {{{?project=}}}? is optional for the github hook, but taht appears not to be the case any longer See https://gist.github.com/950854 (trac rejecting it for "too many links). -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon May 2 00:27:11 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 02 May 2011 00:27:11 -0000 Subject: [Buildbot-commits] [Buildbot] #1944: ?project= In-Reply-To: <041.284fa08995a1bb2d59b6361a6d1f9ef5@buildbot.net> References: <041.284fa08995a1bb2d59b6361a6d1f9ef5@buildbot.net> Message-ID: <056.6893d66226648160a4eb4487273c5495@buildbot.net> #1944: ?project= ------------------------+-------------------- Reporter: dabrahams | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.4 Version: master | Resolution: Keywords: simple, git | ------------------------+-------------------- Changes (by dustin): * keywords: => simple, git * milestone: undecided => 0.8.4 Comment: The hook should be translating a missing {{{project=}}} parameter into an empty string. Projects must be strings - None is not allowed. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Mon May 2 00:29:05 2011 From: noreply at github.com (noreply at github.com) Date: Sun, 1 May 2011 17:29:05 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 398ab3: Handle local encoding for branch == None case. Message-ID: <20110502002905.26833423EF@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 398ab3def145f483d92436436a65dcced71257f6 https://github.com/buildbot/buildbot/commit/398ab3def145f483d92436436a65dcced71257f6 Author: Doug Latornell Date: 2011-05-01 (Sun, 01 May 2011) Changed paths: M master/buildbot/changes/hgbuildbot.py Log Message: ----------- Handle local encoding for branch == None case. Commit: 116d642658fb491b8974c98e1d2fcc5bb8bb74e4 https://github.com/buildbot/buildbot/commit/116d642658fb491b8974c98e1d2fcc5bb8bb74e4 Author: Dustin J. Mitchell Date: 2011-05-01 (Sun, 01 May 2011) Changed paths: M master/buildbot/changes/hgbuildbot.py Log Message: ----------- Merge pull request #114 from douglatornell/master. Patch to deal with hg>1.7 local encoding when branch == None Compare: https://github.com/buildbot/buildbot/compare/0028098...116d642 From noreply at github.com Mon May 2 00:52:27 2011 From: noreply at github.com (noreply at github.com) Date: Sun, 1 May 2011 17:52:27 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] daa9ff: remove db.build_started and db.get_build_info Message-ID: <20110502005227.AD062423DD@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: daa9ff735e63fdebb55f3fba1e002630345a2aee https://github.com/buildbot/buildbot/commit/daa9ff735e63fdebb55f3fba1e002630345a2aee Author: Dustin J. Mitchell Date: 2011-05-01 (Sun, 01 May 2011) Changed paths: M master/buildbot/db/connector.py M master/buildbot/master.py M master/buildbot/process/builder.py M master/buildbot/status/master.py Log Message: ----------- remove db.build_started and db.get_build_info This makes the Builder notify the Status class directly, rather than sticking information into a database and sending an incomplete notification about it. Commit: 8e4fce62f7110b56dfadc74916f5a8b3fd09f0c8 https://github.com/buildbot/buildbot/commit/8e4fce62f7110b56dfadc74916f5a8b3fd09f0c8 Author: Dustin J. Mitchell Date: 2011-05-01 (Sun, 01 May 2011) Changed paths: M master/buildbot/db/connector.py M master/buildbot/status/master.py Log Message: ----------- remove unused notification support from DBConnector Commit: 417e9692a5012acfcf7a2acc76642f9fadc4df5a https://github.com/buildbot/buildbot/commit/417e9692a5012acfcf7a2acc76642f9fadc4df5a Author: Dustin J. Mitchell Date: 2011-05-01 (Sun, 01 May 2011) Changed paths: M master/buildbot/db/connector.py M master/buildbot/process/builder.py Log Message: ----------- remove db.builds_finished Commit: 6762e8b9a29a728040707c64a095ee06f5e5b3d6 https://github.com/buildbot/buildbot/commit/6762e8b9a29a728040707c64a095ee06f5e5b3d6 Author: Dustin J. Mitchell Date: 2011-05-01 (Sun, 01 May 2011) Changed paths: M master/buildbot/db/buildrequests.py M master/buildbot/test/unit/test_db_buildrequests.py Log Message: ----------- Add master.db.buildrequests.unclaimBuildRequests Commit: 433c198a43c2b638b62bcb4e56471fb1faa8653c https://github.com/buildbot/buildbot/commit/433c198a43c2b638b62bcb4e56471fb1faa8653c Author: Dustin J. Mitchell Date: 2011-05-01 (Sun, 01 May 2011) Changed paths: M master/buildbot/db/connector.py M master/buildbot/process/builder.py M master/buildbot/process/slavebuilder.py Log Message: ----------- Use db.buildrequests.unclaimBuildRequests Remove db.resubmit_requests Also fix an error in handling disconnected slaves Commit: 67e32ccfe87e215d1da7cee1c5596628d4858500 https://github.com/buildbot/buildbot/commit/67e32ccfe87e215d1da7cee1c5596628d4858500 Author: Dustin J. Mitchell Date: 2011-05-01 (Sun, 01 May 2011) Changed paths: M master/buildbot/test/fake/fakedb.py Log Message: ----------- Fix fakedb simulation of builds component Commit: 2f681301b0d446a274cc74d7b3e7ee8c70863541 https://github.com/buildbot/buildbot/commit/2f681301b0d446a274cc74d7b3e7ee8c70863541 Author: Dustin J. Mitchell Date: 2011-05-01 (Sun, 01 May 2011) Changed paths: M master/buildbot/process/botmaster.py M master/buildbot/test/unit/test_process_botmaster_BuildRequestDistributor.py Log Message: ----------- fix sorting of buildrequests (based on datetime, not integers) Commit: f7830df638986224fffcd0eb70250516e0494f46 https://github.com/buildbot/buildbot/commit/f7830df638986224fffcd0eb70250516e0494f46 Author: Dustin J. Mitchell Date: 2011-05-01 (Sun, 01 May 2011) Changed paths: M master/buildbot/status/master.py M master/buildbot/test/fake/fakedb.py Log Message: ----------- spell getBuildsets correctly (no capital s) Commit: 1bb1ef7c62c5bcda2dc1d2b88b4b404681c2e607 https://github.com/buildbot/buildbot/commit/1bb1ef7c62c5bcda2dc1d2b88b4b404681c2e607 Author: Dustin J. Mitchell Date: 2011-05-01 (Sun, 01 May 2011) Changed paths: M master/buildbot/db/connector.py M master/buildbot/schedulers/trysched.py M master/buildbot/status/buildset.py M master/buildbot/status/master.py M master/buildbot/test/fake/fakedb.py Log Message: ----------- construct BuildSetStatus from a bsdict; remove db.get_buildset_info Commit: 24398dd4ccc934703a166f309e29ee166020c0f0 https://github.com/buildbot/buildbot/commit/24398dd4ccc934703a166f309e29ee166020c0f0 Author: Dustin J. Mitchell Date: 2011-05-01 (Sun, 01 May 2011) Changed paths: M master/buildbot/db/connector.py Log Message: ----------- remove now-unused get_buildername_for_brid Commit: d5ccf1da05d2bcddfab0b6aff6798a4b626e8252 https://github.com/buildbot/buildbot/commit/d5ccf1da05d2bcddfab0b6aff6798a4b626e8252 Author: Dustin J. Mitchell Date: 2011-05-01 (Sun, 01 May 2011) Changed paths: M master/buildbot/db/connector.py Log Message: ----------- remove now-unused db.examine_buildset Commit: 992b356994fd8df68fb91625cdbbba0c70b18b5e https://github.com/buildbot/buildbot/commit/992b356994fd8df68fb91625cdbbba0c70b18b5e Author: Dustin J. Mitchell Date: 2011-05-01 (Sun, 01 May 2011) Log Message: ----------- Merge branch 'master' of github.com:buildbot/buildbot * 'master' of github.com:buildbot/buildbot: Compare: https://github.com/buildbot/buildbot/compare/116d642...992b356 From noreply at github.com Mon May 2 01:42:39 2011 From: noreply at github.com (noreply at github.com) Date: Sun, 1 May 2011 18:42:39 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 104b1a: add db.builds.getBuildsForRequest Message-ID: <20110502014239.248F042434@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 104b1a0fc77cfe107d2109ce597d04bf169340ec https://github.com/buildbot/buildbot/commit/104b1a0fc77cfe107d2109ce597d04bf169340ec Author: Dustin J. Mitchell Date: 2011-05-01 (Sun, 01 May 2011) Changed paths: M master/buildbot/db/builds.py M master/buildbot/test/unit/test_db_builds.py Log Message: ----------- add db.builds.getBuildsForRequest Commit: bd4fcfb826c976b6a8c1c4572316f5b7b6175af9 https://github.com/buildbot/buildbot/commit/bd4fcfb826c976b6a8c1c4572316f5b7b6175af9 Author: Dustin J. Mitchell Date: 2011-05-01 (Sun, 01 May 2011) Changed paths: M master/buildbot/db/connector.py M master/buildbot/status/buildrequest.py Log Message: ----------- remove db.get_buildnums_for_brid This also removes the 'build' key from BuildRequestStatus.asDict(), although it is still available in the async version. Commit: 809e9c13ac4a4c8b9b7f61ae524de3d1f79f7e7c https://github.com/buildbot/buildbot/commit/809e9c13ac4a4c8b9b7f61ae524de3d1f79f7e7c Author: Dustin J. Mitchell Date: 2011-05-01 (Sun, 01 May 2011) Changed paths: M master/buildbot/db/connector.py M master/buildbot/interfaces.py M master/buildbot/status/buildset.py M master/buildbot/test/unit/test_db_connector.py Log Message: ----------- remove unused BuildSetStatus.getSourceStamp and with it several now-unused DBConnector methods Compare: https://github.com/buildbot/buildbot/compare/992b356...809e9c1 From noreply at github.com Mon May 2 03:50:48 2011 From: noreply at github.com (noreply at github.com) Date: Sun, 1 May 2011 20:50:48 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] a9de2c: remove unused BuildSetStatus.getBuildRequests Message-ID: <20110502035048.B37AE4232F@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: a9de2c074de544bf27465346946996d8d3dee605 https://github.com/buildbot/buildbot/commit/a9de2c074de544bf27465346946996d8d3dee605 Author: Dustin J. Mitchell Date: 2011-05-01 (Sun, 01 May 2011) Changed paths: M master/buildbot/interfaces.py M master/buildbot/status/buildset.py Log Message: ----------- remove unused BuildSetStatus.getBuildRequests Commit: 10fc166fc81943aaf317281e72ee52637f951c45 https://github.com/buildbot/buildbot/commit/10fc166fc81943aaf317281e72ee52637f951c45 Author: Dustin J. Mitchell Date: 2011-05-01 (Sun, 01 May 2011) Changed paths: M master/buildbot/db/buildrequests.py M master/buildbot/test/unit/test_db_buildrequests.py Log Message: ----------- Add bsid=.. parameter to db.buildrequests.getBuildRequests Commit: cc79df7306d97546e7135c234039700b51109f75 https://github.com/buildbot/buildbot/commit/cc79df7306d97546e7135c234039700b51109f75 Author: Dustin J. Mitchell Date: 2011-05-01 (Sun, 01 May 2011) Changed paths: M master/buildbot/db/connector.py M master/buildbot/interfaces.py M master/buildbot/status/buildset.py M master/buildbot/status/client.py Log Message: ----------- remove get_buildrequestids_for_buildset and rewrite methods using it Commit: af9e10b1b7588afe2f094286182f221c15ad4658 https://github.com/buildbot/buildbot/commit/af9e10b1b7588afe2f094286182f221c15ad4658 Author: Dustin J. Mitchell Date: 2011-05-01 (Sun, 01 May 2011) Changed paths: M master/buildbot/db/buildsets.py M master/buildbot/test/unit/test_db_buildsets.py Log Message: ----------- add db.buildsets.completeBuildset Commit: 444251aaf85b8a3c77ba2368d8be154d33ae3e26 https://github.com/buildbot/buildbot/commit/444251aaf85b8a3c77ba2368d8be154d33ae3e26 Author: Dustin J. Mitchell Date: 2011-05-01 (Sun, 01 May 2011) Changed paths: M master/buildbot/db/connector.py M master/buildbot/master.py M master/buildbot/process/builder.py M master/buildbot/process/buildrequest.py M master/buildbot/test/unit/test_master.py Log Message: ----------- Fix buildset completion remove db.cancel_buildrequests and monitor buildsets for completion every time a buildrequest is completed Compare: https://github.com/buildbot/buildbot/compare/809e9c1...444251a From noreply at github.com Mon May 2 04:07:39 2011 From: noreply at github.com (noreply at github.com) Date: Sun, 1 May 2011 21:07:39 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 6feec7: add new db methods to fakedb Message-ID: <20110502040739.D17664243D@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 6feec7d9e3b22893c0cbd4338e0ccd37ff2f1278 https://github.com/buildbot/buildbot/commit/6feec7d9e3b22893c0cbd4338e0ccd37ff2f1278 Author: Dustin J. Mitchell Date: 2011-05-01 (Sun, 01 May 2011) Changed paths: M master/buildbot/test/fake/fakedb.py Log Message: ----------- add new db methods to fakedb Commit: 0f6a5b2e1334dfde2081661c737443a6b7903128 https://github.com/buildbot/buildbot/commit/0f6a5b2e1334dfde2081661c737443a6b7903128 Author: Dustin J. Mitchell Date: 2011-05-01 (Sun, 01 May 2011) Changed paths: M master/buildbot/db/connector.py M master/buildbot/master.py M master/buildbot/test/integration/test_upgrade.py M master/buildbot/test/regressions/test_import_unicode_changes.py M master/buildbot/test/unit/test_db_connector.py Log Message: ----------- final cleanout of db.connector At this point, all access to the database is asynchronous. Hooray! Compare: https://github.com/buildbot/buildbot/compare/444251a...0f6a5b2 From nobody at buildbot.net Mon May 2 14:08:18 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 02 May 2011 14:08:18 -0000 Subject: [Buildbot-commits] [Buildbot] #1025: don't use functions as dictionary keys In-Reply-To: <038.fc9e0c960c692cb74015af42c495aa5b@buildbot.net> References: <038.fc9e0c960c692cb74015af42c495aa5b@buildbot.net> Message-ID: <053.c97d50433a5da15254d67caccb07c0c5@buildbot.net> #1025: don't use functions as dictionary keys ------------------------+--------------------- Reporter: dustin | Owner: Type: enhancement | Status: closed Priority: blocker | Milestone: 0.8.+ Version: master | Resolution: fixed Keywords: database | ------------------------+--------------------- Changes (by dustin): * status: new => closed * resolution: => fixed Comment: Loops are gone now. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon May 2 14:29:40 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 02 May 2011 14:29:40 -0000 Subject: [Buildbot-commits] [Buildbot] #1904: Set MySQL storage engine using a connect listener In-Reply-To: <038.ceea238afc35e392fd17e532c44654f3@buildbot.net> References: <038.ceea238afc35e392fd17e532c44654f3@buildbot.net> Message-ID: <053.8780334317057b22b1838c83cb956755@buildbot.net> #1904: Set MySQL storage engine using a connect listener ------------------------+-------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.5 Version: 0.8.3p1 | Resolution: Keywords: database | ------------------------+-------------------- Changes (by dustin): * milestone: 0.8.4 => 0.8.5 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon May 2 14:35:48 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 02 May 2011 14:35:48 -0000 Subject: [Buildbot-commits] [Buildbot] #836: remove Change.links In-Reply-To: <038.a71a59a6a99fb011e7f7c9ff2dbef9cd@buildbot.net> References: <038.a71a59a6a99fb011e7f7c9ff2dbef9cd@buildbot.net> Message-ID: <053.b5faba185094d2aa8733e55be509a5ad@buildbot.net> #836: remove Change.links --------------------------+-------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.5 Version: 0.8.0 | Resolution: Keywords: database, web | --------------------------+-------------------- Changes (by dustin): * milestone: 0.8.4 => 0.8.5 -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Mon May 2 14:36:22 2011 From: noreply at github.com (noreply at github.com) Date: Mon, 2 May 2011 07:36:22 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 8fa431: add JSON API to header link bar Message-ID: <20110502143622.5B1C942377@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 8fa4316aeb9a5f813e23173dc121b7084d7d1b1f https://github.com/buildbot/buildbot/commit/8fa4316aeb9a5f813e23173dc121b7084d7d1b1f Author: Dustin J. Mitchell Date: 2011-05-02 (Mon, 02 May 2011) Changed paths: M master/buildbot/status/web/templates/layout.html Log Message: ----------- add JSON API to header link bar From nobody at buildbot.net Mon May 2 14:38:10 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 02 May 2011 14:38:10 -0000 Subject: [Buildbot-commits] [Buildbot] #1036: buildrequest can be multiply claimed on MySQL In-Reply-To: <038.e7f6e2904c75db40ead925b3fbd5d384@buildbot.net> References: <038.e7f6e2904c75db40ead925b3fbd5d384@buildbot.net> Message-ID: <053.07de5e5b723103db37242cdb1b08c81b@buildbot.net> #1036: buildrequest can be multiply claimed on MySQL ---------------------+-------------------- Reporter: dustin | Owner: Type: defect | Status: new Priority: blocker | Milestone: 0.8.5 Version: 0.8.1 | Resolution: Keywords: database | ---------------------+-------------------- Changes (by dustin): * milestone: 0.8.4 => 0.8.5 Comment: This is a (big) schema change, so it will wait for 0.8.5. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon May 2 14:38:37 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 02 May 2011 14:38:37 -0000 Subject: [Buildbot-commits] [Buildbot] #1824: Dependent build depends on scheduler property In-Reply-To: <038.5e9d2be315d14148cde444957abc6f92@buildbot.net> References: <038.5e9d2be315d14148cde444957abc6f92@buildbot.net> Message-ID: <053.656b229273418f6a24dad3b397d7a09d@buildbot.net> #1824: Dependent build depends on scheduler property ------------------------+-------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: critical | Milestone: 0.8.5 Version: master | Resolution: Keywords: database | ------------------------+-------------------- Changes (by dustin): * milestone: 0.8.4 => 0.8.5 Comment: schema change -> 0.8.5 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon May 2 14:39:06 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 02 May 2011 14:39:06 -0000 Subject: [Buildbot-commits] [Buildbot] #1053: schedulerdb should have id columns on all tables In-Reply-To: <036.4ff7f269375e4aa2c6c44266d369e161@buildbot.net> References: <036.4ff7f269375e4aa2c6c44266d369e161@buildbot.net> Message-ID: <051.45783f96558d175078716925a05ad25f@buildbot.net> #1053: schedulerdb should have id columns on all tables ------------------------+-------------------- Reporter: Pike | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.5 Version: 0.8.2 | Resolution: Keywords: database | ------------------------+-------------------- Changes (by dustin): * milestone: 0.8.4 => 0.8.5 Comment: schema change -> 0.8.5 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon May 2 14:45:36 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 02 May 2011 14:45:36 -0000 Subject: [Buildbot-commits] [Buildbot] #1770: rewrite database support using SQLAlchmey In-Reply-To: <038.cbfe33529b7379515c7699f99f2680ab@buildbot.net> References: <038.cbfe33529b7379515c7699f99f2680ab@buildbot.net> Message-ID: <053.3f69b120117561352576ae088eaf6856@buildbot.net> #1770: rewrite database support using SQLAlchmey ------------------------+--------------------- Reporter: dustin | Owner: dustin Type: enhancement | Status: closed Priority: major | Milestone: 0.8.4 Version: master | Resolution: fixed Keywords: database | ------------------------+--------------------- Changes (by dustin): * status: new => closed * resolution: => fixed Comment: This is fixed! {{{ commit 0f6a5b2e1334dfde2081661c737443a6b7903128 Author: Dustin J. Mitchell Date: Sun May 1 23:03:03 2011 -0500 final cleanout of db.connector At this point, all access to the database is asynchronous. Hooray! }}} -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon May 2 14:46:29 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 02 May 2011 14:46:29 -0000 Subject: [Buildbot-commits] [Buildbot] #1771: Store 'slavename' in the database for every build In-Reply-To: <044.bf6b7e9c1f97aab3078fb21140d7ccc6@buildbot.net> References: <044.bf6b7e9c1f97aab3078fb21140d7ccc6@buildbot.net> Message-ID: <059.cbbba27f9b0c970be8ad3e19a576c443@buildbot.net> #1771: Store 'slavename' in the database for every build -------------------------+-------------------- Reporter: jhopkinsmomo | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.5 Version: 0.8.2 | Resolution: Keywords: database | -------------------------+-------------------- Changes (by dustin): * milestone: 0.8.4 => 0.8.5 Comment: Schema change -> 0.8.5 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon May 2 14:47:40 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 02 May 2011 14:47:40 -0000 Subject: [Buildbot-commits] [Buildbot] #1037: Refactor builds/build_requests tables to remove duplicate rows in builds table. In-Reply-To: <038.3079e84f94ab81c71bd89b104899b418@buildbot.net> References: <038.3079e84f94ab81c71bd89b104899b418@buildbot.net> Message-ID: <053.2c414ee20a3b0ebc8ee2ea88dac9d6d2@buildbot.net> #1037: Refactor builds/build_requests tables to remove duplicate rows in builds table. ------------------------+-------------------- Reporter: catlee | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.5 Version: 0.8.1 | Resolution: Keywords: database | ------------------------+-------------------- Changes (by dustin): * milestone: 0.8.4 => 0.8.5 Comment: schema change -> 0.8.5 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon May 2 14:47:58 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 02 May 2011 14:47:58 -0000 Subject: [Buildbot-commits] [Buildbot] #1729: Need indices on sourcestamps.branch, sourcestamps.revision In-Reply-To: <038.c1dbef0f1097d9136229989274618d24@buildbot.net> References: <038.c1dbef0f1097d9136229989274618d24@buildbot.net> Message-ID: <053.81a70ca22cfe4b4c6fded8c871181015@buildbot.net> #1729: Need indices on sourcestamps.branch, sourcestamps.revision ------------------------+-------------------- Reporter: catlee | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.5 Version: 0.8.2 | Resolution: Keywords: database | ------------------------+-------------------- Changes (by dustin): * milestone: 0.8.4 => 0.8.5 Comment: schema change -> 0.8.5 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon May 2 15:08:23 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 02 May 2011 15:08:23 -0000 Subject: [Buildbot-commits] [Buildbot] #1747: output from different stages mixed after slave disconnects/reconnects In-Reply-To: <041.dc47916f5f59bc1973e6919b8a0771c9@buildbot.net> References: <041.dc47916f5f59bc1973e6919b8a0771c9@buildbot.net> Message-ID: <056.305f3b6b5c9231d8b79c5fc6950a6d35@buildbot.net> #1747: output from different stages mixed after slave disconnects/reconnects ----------------------+----------------------- Reporter: philippem | Owner: Type: defect | Status: reopened Priority: major | Milestone: 0.8.+ Version: 0.8.2 | Resolution: Keywords: windows | ----------------------+----------------------- Changes (by dustin): * milestone: 0.8.4 => 0.8.+ -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Mon May 2 15:28:53 2011 From: noreply at github.com (noreply at github.com) Date: Mon, 2 May 2011 08:28:53 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 8efde9: add 'self.master' to BuildRequest objects Message-ID: <20110502152853.DCFD742396@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 8efde9b43ecaa61a66237aa778acd2207abff1e7 https://github.com/buildbot/buildbot/commit/8efde9b43ecaa61a66237aa778acd2207abff1e7 Author: Dustin J. Mitchell Date: 2011-05-02 (Mon, 02 May 2011) Changed paths: M master/buildbot/process/buildrequest.py Log Message: ----------- add 'self.master' to BuildRequest objects From noreply at github.com Mon May 2 17:15:45 2011 From: noreply at github.com (noreply at github.com) Date: Mon, 2 May 2011 10:15:45 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] a2b58b: rename title to pageTitle where it refers to HTML ... Message-ID: <20110502171545.EBDB5422C5@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: a2b58bddbcc79f72de521717393ef87455c6e903 https://github.com/buildbot/buildbot/commit/a2b58bddbcc79f72de521717393ef87455c6e903 Author: Dave Abrahams Date: 2011-05-02 (Mon, 02 May 2011) Changed paths: M master/buildbot/status/web/about.py M master/buildbot/status/web/auth.py M master/buildbot/status/web/base.py M master/buildbot/status/web/build.py M master/buildbot/status/web/builder.py M master/buildbot/status/web/changes.py M master/buildbot/status/web/console.py M master/buildbot/status/web/feeds.py M master/buildbot/status/web/grid.py M master/buildbot/status/web/logs.py M master/buildbot/status/web/olpb.py M master/buildbot/status/web/root.py M master/buildbot/status/web/slaves.py M master/buildbot/status/web/status_json.py M master/buildbot/status/web/step.py M master/buildbot/status/web/templates/change.html M master/buildbot/status/web/templates/change_macros.html M master/buildbot/status/web/templates/console.html M master/buildbot/status/web/templates/feed_atom10.xml M master/buildbot/status/web/templates/feed_rss20.xml M master/buildbot/status/web/templates/layout.html M master/buildbot/status/web/templates/logs.html M master/buildbot/status/web/tests.py M master/buildbot/status/web/waterfall.py Log Message: ----------- rename title to pageTitle where it refers to HTML or XML elements Commit: d3bf9062baa56187867fa806eced318d430f02d4 https://github.com/buildbot/buildbot/commit/d3bf9062baa56187867fa806eced318d430f02d4 Author: Dustin J. Mitchell <dustin at mozilla.com> Date: 2011-05-02 (Mon, 02 May 2011) Changed paths: M master/buildbot/buildslave.py M master/buildbot/interfaces.py M master/buildbot/master.py M master/buildbot/scripts/sample.cfg M master/buildbot/status/mail.py M master/buildbot/status/master.py M master/buildbot/status/status_push.py M master/buildbot/status/web/about.py M master/buildbot/status/web/auth.py M master/buildbot/status/web/base.py M master/buildbot/status/web/baseweb.py M master/buildbot/status/web/build.py M master/buildbot/status/web/builder.py M master/buildbot/status/web/changes.py M master/buildbot/status/web/console.py M master/buildbot/status/web/feeds.py M master/buildbot/status/web/grid.py M master/buildbot/status/web/logs.py M master/buildbot/status/web/olpb.py M master/buildbot/status/web/root.py M master/buildbot/status/web/slaves.py M master/buildbot/status/web/status_json.py M master/buildbot/status/web/step.py M master/buildbot/status/web/templates/change.html M master/buildbot/status/web/templates/change_macros.html M master/buildbot/status/web/templates/console.html M master/buildbot/status/web/templates/feed_atom10.xml M master/buildbot/status/web/templates/feed_description.html M master/buildbot/status/web/templates/feed_rss20.xml M master/buildbot/status/web/templates/footer.html M master/buildbot/status/web/templates/grid.html M master/buildbot/status/web/templates/grid_transposed.html M master/buildbot/status/web/templates/layout.html M master/buildbot/status/web/templates/logs.html M master/buildbot/status/web/templates/root.html M master/buildbot/status/web/tests.py M master/buildbot/status/web/waterfall.py M master/contrib/blockertest/master.cfg M master/docs/cfg-global.texinfo M master/docs/cfg-statustargets.texinfo M master/docs/examples/hello.cfg M master/docs/examples/repo_gerrit.cfg M master/docs/examples/twisted_master.cfg M master/docs/tutorial/tour.txt Log Message: ----------- Merge branch 'volatile/top-level-project-rename' of git://github.com/dabrahams/buildbot * 'volatile/top-level-project-rename' of git://github.com/dabrahams/buildbot: rename title to pageTitle where it refers to HTML or XML <title> elements Backward compatibility for email templates Rename projectName => title and projectURL => titleURL Compare: https://github.com/buildbot/buildbot/compare/8efde9b...d3bf906 From nobody at buildbot.net Tue May 3 15:57:58 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 03 May 2011 15:57:58 -0000 Subject: [Buildbot-commits] [Buildbot] #1945: add systemwide metrics support Message-ID: <038.0c124240b73136321a9564af7cffc13a@buildbot.net> #1945: add systemwide metrics support ------------------------+------------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: critical | Milestone: 0.8.4 Version: master | Keywords: performance ------------------------+------------------------- Catlee's working on a patch to add metrics to Buildbot: https://github.com/catlee/buildbot/compare/metrics This should get merged before 0.8.4. -- Ticket URL: <http://trac.buildbot.net/ticket/1945> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Tue May 3 21:34:46 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 03 May 2011 21:34:46 -0000 Subject: [Buildbot-commits] [Buildbot] #1946: buildbot.steps.transfer._FileWriter uses __del__ Message-ID: <038.ac84b40eacc83bbeed29e7604c23ac9c@buildbot.net> #1946: buildbot.steps.transfer._FileWriter uses __del__ ------------------------+------------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.4 Version: master | Keywords: performance ------------------------+------------------------- This means the object cannot be gc'd if it's involved in a reference loop. And I suspect that PB makes a number of reference loops. -- Ticket URL: <http://trac.buildbot.net/ticket/1946> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Wed May 4 21:13:02 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 04 May 2011 21:13:02 -0000 Subject: [Buildbot-commits] [Buildbot] #1947: exceptions.TypeError: <buildbot.status.builder.BuildStepStatus instance at 0x3da3c20> is not JSON serializable Message-ID: <042.e9734e12fc8a2fb0dc7129480560a171@buildbot.net> #1947: exceptions.TypeError: <buildbot.status.builder.BuildStepStatus instance at 0x3da3c20> is not JSON serializable -----------------------+---------------------- Reporter: tom.prince | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.4 Version: 0.8.3p1 | Keywords: web json -----------------------+---------------------- 2011-05-04 16:39:41-0400 [HTTPChannel,1117,127.0.0.1] Unhandled Error Traceback (most recent call last): File "/Depot/BuildBot/bbot/lib/python2.7/site- packages/buildbot/status/web/status_json.py", line 188, in render_GET d = defer.maybeDeferred(lambda : self.content(request)) File "/usr/lib/python2.7/site- packages/twisted/internet/defer.py", line 133, in maybeDeferred result = f(*args, **kw) File "/Depot/BuildBot/bbot/lib/python2.7/site- packages/buildbot/status/web/status_json.py", line 188, in <lambda> d = defer.maybeDeferred(lambda : self.content(request)) File "/usr/lib/python2.7/site- packages/twisted/internet/defer.py", line 964, in unwindGenerator return _deferGenerator(f(*args, **kwargs), Deferred()) --- <exception caught here> --- File "/usr/lib/python2.7/site- packages/twisted/internet/defer.py", line 866, in _deferGenerator result = g.next() File "/Depot/BuildBot/bbot/lib/python2.7/site- packages/buildbot/status/web/status_json.py", line 272, in content data = json.dumps(data, sort_keys=True, separators=(',',':')) File "/usr/lib/python2.7/site-packages/simplejson/__init__.py", line 269, in dumps use_decimal=use_decimal, **kw).encode(obj) File "/usr/lib/python2.7/site-packages/simplejson/encoder.py", line 214, in encode chunks = self.iterencode(o, _one_shot=True) File "/usr/lib/python2.7/site-packages/simplejson/encoder.py", line 282, in iterencode return _iterencode(o, 0) File "/usr/lib/python2.7/site-packages/simplejson/encoder.py", line 190, in default raise TypeError(repr(o) + " is not JSON serializable") exceptions.TypeError: <buildbot.status.builder.BuildStepStatus instance at 0x3da3c20> is not JSON serializable -- Ticket URL: <http://trac.buildbot.net/ticket/1947> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Wed May 4 21:47:00 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 04 May 2011 21:47:00 -0000 Subject: [Buildbot-commits] [Buildbot] #1947: exceptions.TypeError: <buildbot.status.builder.BuildStepStatus instance at 0x3da3c20> is not JSON serializable In-Reply-To: <042.e9734e12fc8a2fb0dc7129480560a171@buildbot.net> References: <042.e9734e12fc8a2fb0dc7129480560a171@buildbot.net> Message-ID: <057.eaa9d0cabbc360e8eb23de81832c7c23@buildbot.net> #1947: exceptions.TypeError: <buildbot.status.builder.BuildStepStatus instance at 0x3da3c20> is not JSON serializable -----------------------+-------------------- Reporter: tom.prince | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.4 Version: 0.8.3p1 | Resolution: Keywords: web json | -----------------------+-------------------- Description changed by dustin: Old description: > 2011-05-04 16:39:41-0400 [HTTPChannel,1117,127.0.0.1] Unhandled Error > Traceback (most recent call last): > File "/Depot/BuildBot/bbot/lib/python2.7/site- > packages/buildbot/status/web/status_json.py", line 188, in render_GET > d = defer.maybeDeferred(lambda : self.content(request)) > File "/usr/lib/python2.7/site- > packages/twisted/internet/defer.py", line 133, in maybeDeferred > result = f(*args, **kw) > File "/Depot/BuildBot/bbot/lib/python2.7/site- > packages/buildbot/status/web/status_json.py", line 188, in <lambda> > d = defer.maybeDeferred(lambda : self.content(request)) > File "/usr/lib/python2.7/site- > packages/twisted/internet/defer.py", line 964, in unwindGenerator > return _deferGenerator(f(*args, **kwargs), Deferred()) > --- <exception caught here> --- > File "/usr/lib/python2.7/site- > packages/twisted/internet/defer.py", line 866, in _deferGenerator > result = g.next() > File "/Depot/BuildBot/bbot/lib/python2.7/site- > packages/buildbot/status/web/status_json.py", line 272, in content > data = json.dumps(data, sort_keys=True, separators=(',',':')) > File "/usr/lib/python2.7/site-packages/simplejson/__init__.py", > line 269, in dumps > use_decimal=use_decimal, **kw).encode(obj) > File "/usr/lib/python2.7/site-packages/simplejson/encoder.py", > line 214, in encode > chunks = self.iterencode(o, _one_shot=True) > File "/usr/lib/python2.7/site-packages/simplejson/encoder.py", > line 282, in iterencode > return _iterencode(o, 0) > File "/usr/lib/python2.7/site-packages/simplejson/encoder.py", > line 190, in default > raise TypeError(repr(o) + " is not JSON serializable") > exceptions.TypeError: <buildbot.status.builder.BuildStepStatus > instance at 0x3da3c20> is not JSON serializable New description: {{{ 2011-05-04 16:39:41-0400 [HTTPChannel,1117,127.0.0.1] Unhandled Error Traceback (most recent call last): File "/Depot/BuildBot/bbot/lib/python2.7/site- packages/buildbot/status/web/status_json.py", line 188, in render_GET d = defer.maybeDeferred(lambda : self.content(request)) File "/usr/lib/python2.7/site- packages/twisted/internet/defer.py", line 133, in maybeDeferred result = f(*args, **kw) File "/Depot/BuildBot/bbot/lib/python2.7/site- packages/buildbot/status/web/status_json.py", line 188, in <lambda> d = defer.maybeDeferred(lambda : self.content(request)) File "/usr/lib/python2.7/site- packages/twisted/internet/defer.py", line 964, in unwindGenerator return _deferGenerator(f(*args, **kwargs), Deferred()) --- <exception caught here> --- File "/usr/lib/python2.7/site- packages/twisted/internet/defer.py", line 866, in _deferGenerator result = g.next() File "/Depot/BuildBot/bbot/lib/python2.7/site- packages/buildbot/status/web/status_json.py", line 272, in content data = json.dumps(data, sort_keys=True, separators=(',',':')) File "/usr/lib/python2.7/site-packages/simplejson/__init__.py", line 269, in dumps use_decimal=use_decimal, **kw).encode(obj) File "/usr/lib/python2.7/site-packages/simplejson/encoder.py", line 214, in encode chunks = self.iterencode(o, _one_shot=True) File "/usr/lib/python2.7/site-packages/simplejson/encoder.py", line 282, in iterencode return _iterencode(o, 0) File "/usr/lib/python2.7/site-packages/simplejson/encoder.py", line 190, in default raise TypeError(repr(o) + " is not JSON serializable") exceptions.TypeError: <buildbot.status.builder.BuildStepStatus instance at 0x3da3c20> is not JSON serializable }}} -- -- Ticket URL: <http://trac.buildbot.net/ticket/1947#comment:1> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Wed May 4 22:28:40 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 04 May 2011 22:28:40 -0000 Subject: [Buildbot-commits] [Buildbot] #1942: Store passwords in hashed form In-Reply-To: <041.ab8723608c9e5208d80dd1a487892b28@buildbot.net> References: <041.ab8723608c9e5208d80dd1a487892b28@buildbot.net> Message-ID: <056.f10f554f9132d691a9bad76927c55b73@buildbot.net> #1942: Store passwords in hashed form ------------------------+------------------------ Reporter: dabrahams | Owner: Type: enhancement | Status: new Priority: major | Milestone: undecided Version: 0.8.3p1 | Resolution: Keywords: auth | ------------------------+------------------------ Comment (by tom.prince): I think the canonical solution to this is to load the passwords from a file. To have the hashes be secure, you would also have to make sure that the hashed passwords were properly salted. A more sensible option might be to expose twisted.cred, which has support for unix password files, among other things. -- Ticket URL: <http://trac.buildbot.net/ticket/1942#comment:1> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Wed May 4 22:36:33 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 04 May 2011 22:36:33 -0000 Subject: [Buildbot-commits] [Buildbot] #1895: reconfig that removes a builder may fail first time In-Reply-To: <038.707a20dec757fab79cc80349898666ec@buildbot.net> References: <038.707a20dec757fab79cc80349898666ec@buildbot.net> Message-ID: <053.8ec9681282bb5d10d3feadee0eb38639@buildbot.net> #1895: reconfig that removes a builder may fail first time ---------------------+------------------------ Reporter: dustin | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.+ Version: 0.8.3p1 | Resolution: duplicate Keywords: reconfig | ---------------------+------------------------ Changes (by tom.prince): * status: new => closed * resolution: => duplicate Comment: Duplicates #1921 -- Ticket URL: <http://trac.buildbot.net/ticket/1895#comment:1> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Wed May 4 22:40:28 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 04 May 2011 22:40:28 -0000 Subject: [Buildbot-commits] [Buildbot] #1911: Cannot checkout from default branch trunk when creating a Scheduler that uses SVN repository. Failure by using keyword None as branch In-Reply-To: <039.8112b27cb69f91b9f8b466fb87e8e70a@buildbot.net> References: <039.8112b27cb69f91b9f8b466fb87e8e70a@buildbot.net> Message-ID: <054.1aaa8b29879ae1e31ac54790b6beb0d6@buildbot.net> #1911: Cannot checkout from default branch trunk when creating a Scheduler that uses SVN repository. Failure by using keyword None as branch -------------------------------------------------+------------------------- Reporter: rodrigo | Owner: Type: support-request | Status: new Priority: critical | Milestone: undecided Version: 0.7.12 | Resolution: Keywords: None, Scheduler, SVN, trunk, default | branch | -------------------------------------------------+------------------------- Comment (by tom.prince): The contents of twistd.log that refer to SVNPoller would be useful in figuring out what is wrong. -- Ticket URL: <http://trac.buildbot.net/ticket/1911#comment:2> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Thu May 5 01:39:52 2011 From: nobody at buildbot.net (Buildbot) Date: Thu, 05 May 2011 01:39:52 -0000 Subject: [Buildbot-commits] [Buildbot] #1942: Store passwords in hashed form In-Reply-To: <041.ab8723608c9e5208d80dd1a487892b28@buildbot.net> References: <041.ab8723608c9e5208d80dd1a487892b28@buildbot.net> Message-ID: <056.2e724b6a9a54aafc31c373b24239fa0d@buildbot.net> #1942: Store passwords in hashed form ------------------------+------------------------ Reporter: dabrahams | Owner: Type: enhancement | Status: new Priority: major | Milestone: undecided Version: 0.8.3p1 | Resolution: Keywords: auth | ------------------------+------------------------ Comment (by dabrahams): Replying to [comment:1 tom.prince]: > I think the canonical solution to this is to load the passwords from a file. Yes it is. And a variety of factors make this much more painful than it should be. You can see some evidence for this in my bbot framework. > To have the hashes be secure, you would also have to make sure that the hashed passwords were properly salted. I confess that I'm not a security expert... but that wouldn't be so bad, would it? > A more sensible option might be to expose twisted.cred, which has support for unix password files, among other things. I assumed that twisted probably had some facilities for this kind of thing, but I'm also not a twisted expert ;-) -- Ticket URL: <http://trac.buildbot.net/ticket/1942#comment:2> Buildbot <http://buildbot.net/> Buildbot: build/test automation From noreply at github.com Thu May 5 15:39:46 2011 From: noreply at github.com (noreply at github.com) Date: Thu, 5 May 2011 08:39:46 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 6ec155: add a 'Performance' project Message-ID: <20110505153946.8A49642334@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 6ec155d1e2b9cd87c11d650ee010e9ba1ac4245d https://github.com/buildbot/buildbot/commit/6ec155d1e2b9cd87c11d650ee010e9ba1ac4245d Author: Dustin J. Mitchell <dustin at mozilla.com> Date: 2011-05-03 (Tue, 03 May 2011) Changed paths: M MAINTAINERS.txt Log Message: ----------- add a 'Performance' project Commit: f28592296b21f3bf8380cf6262eed52667ce7712 https://github.com/buildbot/buildbot/commit/f28592296b21f3bf8380cf6262eed52667ce7712 Author: Dave Abrahams <dave at boostpro.com> Date: 2011-05-05 (Thu, 05 May 2011) Changed paths: M master/buildbot/buildslave.py M master/buildbot/process/botmaster.py Log Message: ----------- Don't rebuild slaves just because the identity of their __class__ has changed If the user has subclassed BuildSlave, a reconfig will likely reload their subclass Commit: 7ae0470df5b91cc5788756f4d130476341bede2e https://github.com/buildbot/buildbot/commit/7ae0470df5b91cc5788756f4d130476341bede2e Author: Dustin J. Mitchell <dustin at mozilla.com> Date: 2011-05-05 (Thu, 05 May 2011) Changed paths: M master/buildbot/buildslave.py M master/buildbot/process/botmaster.py Log Message: ----------- Merge branch 'volatile/slave-preservation' of git://github.com/dabrahams/buildbot * 'volatile/slave-preservation' of git://github.com/dabrahams/buildbot: Don't rebuild slaves just because the identity of their __class__ has changed Compare: https://github.com/buildbot/buildbot/compare/d3bf906...7ae0470 From noreply at github.com Thu May 5 20:24:22 2011 From: noreply at github.com (noreply at github.com) Date: Thu, 5 May 2011 13:24:22 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 0a5e28: fix missing keyword arguments in example Message-ID: <20110505202422.81B42423B5@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 0a5e28f4c0d15c16e8a64ea42967fbb2b6849253 https://github.com/buildbot/buildbot/commit/0a5e28f4c0d15c16e8a64ea42967fbb2b6849253 Author: Dustin J. Mitchell <dustin at mozilla.com> Date: 2011-05-05 (Thu, 05 May 2011) Changed paths: M master/docs/cfg-schedulers.texinfo Log Message: ----------- fix missing keyword arguments in example From nobody at buildbot.net Fri May 6 03:36:45 2011 From: nobody at buildbot.net (Buildbot) Date: Fri, 06 May 2011 03:36:45 -0000 Subject: [Buildbot-commits] [Buildbot] #1948: WithProperties doesn't interact properly with reconfig Message-ID: <041.537f4449c6c3fce9ae209d184140932f@buildbot.net> #1948: WithProperties doesn't interact properly with reconfig ----------------------+----------------------- Reporter: dabrahams | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.3p1 | Keywords: ----------------------+----------------------- In particular, builders are detected as not having changed when lambdas used with WithProperties change. -- Ticket URL: <http://trac.buildbot.net/ticket/1948> Buildbot <http://buildbot.net/> Buildbot: build/test automation From noreply at github.com Fri May 6 15:00:14 2011 From: noreply at github.com (noreply at github.com) Date: Fri, 6 May 2011 08:00:14 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 400bf1: Demonstrate and fix getAbsoluteSourceStamp bug Message-ID: <20110506150014.9013A42480@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 400bf12d965feec3f86ab6d8e0f57a7e89212b2b https://github.com/buildbot/buildbot/commit/400bf12d965feec3f86ab6d8e0f57a7e89212b2b Author: Dustin J. Mitchell <dustin at mozilla.com> Date: 2011-05-06 (Fri, 06 May 2011) Changed paths: M master/buildbot/sourcestamp.py M master/buildbot/test/unit/test_sourcestamp.py Log Message: ----------- Demonstrate and fix getAbsoluteSourceStamp bug getAbsoluteSourceStamp would ignore the revision= parameter if there were changes in the SS. From nobody at buildbot.net Fri May 6 15:06:29 2011 From: nobody at buildbot.net (Buildbot) Date: Fri, 06 May 2011 15:06:29 -0000 Subject: [Buildbot-commits] [Buildbot] #1949: irc bot force command needs branch option Message-ID: <035.193ee026bfec9b27866696576e57c66b@buildbot.net> #1949: irc bot force command needs branch option ------------------------+----------------------- Reporter: H__ | Owner: Type: enhancement | Status: new Priority: minor | Milestone: undecided Version: 0.8.3p1 | Keywords: irc ------------------------+----------------------- [21:30:28] <H__> question : The irc plugin mentions "force build <which> <reason> - Force a build" , how does one specify the branch to build ? [21:56:09] <djmitche> H__: it doesn't :( [16:31:40] <H__> djmitche: ok thanks. pity one cannot specify the branch to build via irc yet. We'll just have to wait (or free up resources to help but I can expect the outcome of such a request :-D ) [16:32:16] <djmitche> :/ [16:32:52] <verm__> H__: open a ticket with 'irc' in the keywords list -- Ticket URL: <http://trac.buildbot.net/ticket/1949> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Sat May 7 00:33:03 2011 From: nobody at buildbot.net (Buildbot) Date: Sat, 07 May 2011 00:33:03 -0000 Subject: [Buildbot-commits] [Buildbot] #1950: EC2 docs need updating to new AWS terminology Message-ID: <038.804edab703f26dcac940eae9cbb6d1c5@buildbot.net> #1950: EC2 docs need updating to new AWS terminology ------------------------+------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.4 Version: 0.8.3p1 | Keywords: docs ------------------------+------------------- {{{ 19:28 <+exarkun> not to be confused with AWS AMIs obviously 19:29 <+exarkun> where the docs say "Access Identifiers" and "Your Account -> Access Identifiers" they should say "AWS IAM" and then a bunch of stuff about creating a group and some users 19:29 <+exarkun> and it's probably worth pointing out that "publickey" and "privatekey" have nothing to do with the RSA keys used elsewhere in AWS 19:30 <+exarkun> the docs don't say that they do, but that's how _I_ access AWS, I didn't know buildbot would access it differently 19:30 <+exarkun> also... blocking boto calls in __init__... so not cool :/ 19:30 <+exarkun> (I know, only so many hours in the day... but still...) }}} -- Ticket URL: <http://trac.buildbot.net/ticket/1950> Buildbot <http://buildbot.net/> Buildbot: build/test automation From noreply at github.com Sat May 7 00:44:34 2011 From: noreply at github.com (noreply at github.com) Date: Fri, 6 May 2011 17:44:34 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 767818: only monkepatch if twisted is installed Message-ID: <20110507004434.0D00E423FD@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 767818ae18dd50a691b5890df86a18273829b30e https://github.com/buildbot/buildbot/commit/767818ae18dd50a691b5890df86a18273829b30e Author: Dustin J. Mitchell <dustin at mozilla.com> Date: 2011-05-06 (Fri, 06 May 2011) Changed paths: M master/buildbot/monkeypatches/__init__.py M slave/buildslave/monkeypatches/__init__.py Log Message: ----------- only monkepatch if twisted is installed From noreply at github.com Sat May 7 16:17:41 2011 From: noreply at github.com (noreply at github.com) Date: Sat, 7 May 2011 09:17:41 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] f7eaaa: Update the docs to reflect the latest changes. Message-ID: <20110507161742.008B342442@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: f7eaaa4743cd67ea809bb417ea7f18f0b982ac20 https://github.com/buildbot/buildbot/commit/f7eaaa4743cd67ea809bb417ea7f18f0b982ac20 Author: Tomaz Muraus <tomaz at tomaz.me> Date: 2011-05-07 (Sat, 07 May 2011) Changed paths: M master/docs/cfg-statustargets.texinfo Log Message: ----------- Update the docs to reflect the latest changes. Commit: 0dcd260cdcabe5381365705b6fab13891486d6a9 https://github.com/buildbot/buildbot/commit/0dcd260cdcabe5381365705b6fab13891486d6a9 Author: Dustin J. Mitchell <dustin at mozilla.com> Date: 2011-05-07 (Sat, 07 May 2011) Changed paths: M master/docs/cfg-statustargets.texinfo Log Message: ----------- fix texinfo Commit: 1b22899598333c243630a021c3c6d1bb133fbdd6 https://github.com/buildbot/buildbot/commit/1b22899598333c243630a021c3c6d1bb133fbdd6 Author: Dustin J. Mitchell <dustin at mozilla.com> Date: 2011-05-07 (Sat, 07 May 2011) Changed paths: M master/buildbot/status/words.py M master/docs/cfg-statustargets.texinfo Log Message: ----------- Merge branch 'irc_channel_password_support' * irc_channel_password_support: fix texinfo Update the docs to reflect the latest changes. Allow user to specify a channel password. Compare: https://github.com/buildbot/buildbot/compare/767818a...1b22899 From noreply at github.com Sat May 7 16:56:59 2011 From: noreply at github.com (noreply at github.com) Date: Sat, 7 May 2011 09:56:59 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 1f7754: use in-memory database for testing Message-ID: <20110507165659.5051D42421@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 1f7754997656745a7ec71cf1ba8b7c6e18d85457 https://github.com/buildbot/buildbot/commit/1f7754997656745a7ec71cf1ba8b7c6e18d85457 Author: Dustin J. Mitchell <dustin at mozilla.com> Date: 2011-05-07 (Sat, 07 May 2011) Changed paths: M master/buildbot/test/util/db.py Log Message: ----------- use in-memory database for testing From nobody at buildbot.net Sat May 7 18:22:54 2011 From: nobody at buildbot.net (Buildbot) Date: Sat, 07 May 2011 18:22:54 -0000 Subject: [Buildbot-commits] [Buildbot] #1904: Set MySQL storage engine using a connect listener In-Reply-To: <038.ceea238afc35e392fd17e532c44654f3@buildbot.net> References: <038.ceea238afc35e392fd17e532c44654f3@buildbot.net> Message-ID: <053.3365fce51c72d8dce81c3f35538a6707@buildbot.net> #1904: Set MySQL storage engine using a connect listener ------------------------+-------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.5 Version: 0.8.3p1 | Resolution: Keywords: database | ------------------------+-------------------- Comment (by dustin): Sadly, InnoDB has an even smaller key-length restriction than MyISAM, and it doesn't look like that will be fixed any time soon: http://bugs.mysql.com/bug.php?id=4541 so while you can now select a storage engine, InnoDB isn't an option. May I suggest a real database, like Postgres? -- Ticket URL: <http://trac.buildbot.net/ticket/1904#comment:2> Buildbot <http://buildbot.net/> Buildbot: build/test automation From noreply at github.com Sat May 7 18:25:47 2011 From: noreply at github.com (noreply at github.com) Date: Sat, 7 May 2011 11:25:47 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 5c55cd: Add the ability to specify storage_engine for MySQ... Message-ID: <20110507182547.7C74D423F4@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 5c55cd304baf53bc511e685303458628ff7ab371 https://github.com/buildbot/buildbot/commit/5c55cd304baf53bc511e685303458628ff7ab371 Author: Dustin J. Mitchell <dustin at mozilla.com> Date: 2011-05-07 (Sat, 07 May 2011) Changed paths: M master/buildbot/db/enginestrategy.py M master/buildbot/test/unit/test_db_enginestrategy.py M master/docs/cfg-global.texinfo Log Message: ----------- Add the ability to specify storage_engine for MySQL Fixes #1904. Well, sort of fixes it. You can't actually *use* InnoDB, but that's a MySQL bug. Don't hold your breath waiting for a fix - it's been 7 years now. From nobody at buildbot.net Sat May 7 18:26:03 2011 From: nobody at buildbot.net (Buildbot) Date: Sat, 07 May 2011 18:26:03 -0000 Subject: [Buildbot-commits] [Buildbot] #1904: Set MySQL storage engine using a connect listener In-Reply-To: <038.ceea238afc35e392fd17e532c44654f3@buildbot.net> References: <038.ceea238afc35e392fd17e532c44654f3@buildbot.net> Message-ID: <053.81e67b94682d57c0188a1c6d9f72477e@buildbot.net> #1904: Set MySQL storage engine using a connect listener ------------------------+--------------------- Reporter: dustin | Owner: Type: enhancement | Status: closed Priority: major | Milestone: 0.8.5 Version: 0.8.3p1 | Resolution: fixed Keywords: database | ------------------------+--------------------- Changes (by Dustin J. Mitchell): * status: new => closed * resolution: => fixed Comment: Add the ability to specify storage_engine for MySQL Fixes #1904. Well, sort of fixes it. You can't actually *use* InnoDB, but that's a MySQL bug. Don't hold your breath waiting for a fix - it's been 7 years now. Changeset: 5c55cd304baf53bc511e685303458628ff7ab371 -- Ticket URL: <http://trac.buildbot.net/ticket/1904#comment:3> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Sat May 7 18:27:27 2011 From: nobody at buildbot.net (Buildbot) Date: Sat, 07 May 2011 18:27:27 -0000 Subject: [Buildbot-commits] [Buildbot] #1869: use surrogateescape to escape filesystem strings in Unicode In-Reply-To: <038.172d8ed2b2aa719db1dbd1f0b8f3235f@buildbot.net> References: <038.172d8ed2b2aa719db1dbd1f0b8f3235f@buildbot.net> Message-ID: <053.1a856791976a92e24501625d61f26ebb@buildbot.net> #1869: use surrogateescape to escape filesystem strings in Unicode ------------------------+---------------------- Reporter: dustin | Owner: Type: enhancement | Status: closed Priority: major | Milestone: 1.0.+ Version: 0.8.3p1 | Resolution: wontfix Keywords: encoding | ------------------------+---------------------- Changes (by dustin): * status: new => closed * resolution: => wontfix Comment: This isn't actually helpful for Buildbot. It's intended to allow strings from arbitrary filesystems to be losslessly represented by a single type (Unicode) in Python. However, the representation does *not* encode to utf8 - it's *only* useful when passing such strings back to the filesystem (where they must match byte-for-byte what came from the filesystem). Buildbot never does this - it just takes strings and displays them in status plugins. -- Ticket URL: <http://trac.buildbot.net/ticket/1869#comment:1> Buildbot <http://buildbot.net/> Buildbot: build/test automation From noreply at github.com Sat May 7 18:42:08 2011 From: noreply at github.com (noreply at github.com) Date: Sat, 7 May 2011 11:42:08 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 0ac188: Documentation on string encodings Message-ID: <20110507184208.C988C423FD@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 0ac18880d60dd7b1107054fc0cc1796c3cad7642 https://github.com/buildbot/buildbot/commit/0ac18880d60dd7b1107054fc0cc1796c3cad7642 Author: Dustin J. Mitchell <dustin at mozilla.com> Date: 2011-05-07 (Sat, 07 May 2011) Changed paths: M master/docs/developer.texinfo Log Message: ----------- Documentation on string encodings Fixes #1056. There's actually nothing to do for this bug - strings in the database are explicitly utf-8 encoded, which means that we see them in Python as unicode strings. So this commit merely documents the expectations that other Buildbot components (inputs and outputs) must live up to. From nobody at buildbot.net Sat May 7 18:42:14 2011 From: nobody at buildbot.net (Buildbot) Date: Sat, 07 May 2011 18:42:14 -0000 Subject: [Buildbot-commits] [Buildbot] #1056: handle encodings of change_files properly In-Reply-To: <038.4a06b9686bd3ff1ac4cdca55dfaea0f1@buildbot.net> References: <038.4a06b9686bd3ff1ac4cdca55dfaea0f1@buildbot.net> Message-ID: <053.fe879a2ab63a2673a8ebac09d9cabf0f@buildbot.net> #1056: handle encodings of change_files properly -------------------------------+--------------------- Reporter: dustin | Owner: dustin Type: enhancement | Status: closed Priority: major | Milestone: 0.8.4 Version: 0.8.2 | Resolution: fixed Keywords: encoding, database | -------------------------------+--------------------- Changes (by Dustin J. Mitchell): * status: new => closed * resolution: => fixed Comment: Documentation on string encodings Fixes #1056. There's actually nothing to do for this bug - strings in the database are explicitly utf-8 encoded, which means that we see them in Python as unicode strings. So this commit merely documents the expectations that other Buildbot components (inputs and outputs) must live up to. Changeset: 0ac18880d60dd7b1107054fc0cc1796c3cad7642 -- Ticket URL: <http://trac.buildbot.net/ticket/1056#comment:6> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Sat May 7 18:43:19 2011 From: nobody at buildbot.net (Buildbot) Date: Sat, 07 May 2011 18:43:19 -0000 Subject: [Buildbot-commits] [Buildbot] #1936: optimize getOldestRequestTime In-Reply-To: <038.7a24f9fbb575b54572e76045aa2d1886@buildbot.net> References: <038.7a24f9fbb575b54572e76045aa2d1886@buildbot.net> Message-ID: <053.b32d0278731af011445d5d1a66b84023@buildbot.net> #1936: optimize getOldestRequestTime ----------------------------------+-------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.4 Version: 0.8.3p1 | Resolution: Keywords: database, performance | ----------------------------------+-------------------- Changes (by dustin): * keywords: database => database, performance -- Ticket URL: <http://trac.buildbot.net/ticket/1936#comment:1> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Sat May 7 18:55:20 2011 From: nobody at buildbot.net (Buildbot) Date: Sat, 07 May 2011 18:55:20 -0000 Subject: [Buildbot-commits] [Buildbot] #1941: status json creates a full set of Resources ahead of time In-Reply-To: <038.e4dc834881b307fe50b5be379fa844bb@buildbot.net> References: <038.e4dc834881b307fe50b5be379fa844bb@buildbot.net> Message-ID: <053.15fa0f6c538ab4b289f16240e97ec8fd@buildbot.net> #1941: status json creates a full set of Resources ahead of time -----------------------------+-------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.9.+ Version: 0.8.2 | Resolution: Keywords: web, performance | -----------------------------+-------------------- Changes (by dustin): * keywords: web => web, performance -- Ticket URL: <http://trac.buildbot.net/ticket/1941#comment:2> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Sat May 7 18:59:59 2011 From: nobody at buildbot.net (Buildbot) Date: Sat, 07 May 2011 18:59:59 -0000 Subject: [Buildbot-commits] [Buildbot] #1947: exceptions.TypeError: <buildbot.status.builder.BuildStepStatus instance at 0x3da3c20> is not JSON serializable In-Reply-To: <042.e9734e12fc8a2fb0dc7129480560a171@buildbot.net> References: <042.e9734e12fc8a2fb0dc7129480560a171@buildbot.net> Message-ID: <057.c1f62c35c3c8acd93e93733d79b22b13@buildbot.net> #1947: exceptions.TypeError: <buildbot.status.builder.BuildStepStatus instance at 0x3da3c20> is not JSON serializable -----------------------+-------------------- Reporter: tom.prince | Owner: Type: defect | Status: new Priority: critical | Milestone: 0.8.4 Version: 0.8.3p1 | Resolution: Keywords: web | -----------------------+-------------------- Changes (by dustin): * keywords: web json => web * priority: major => critical -- Ticket URL: <http://trac.buildbot.net/ticket/1947#comment:2> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Sat May 7 19:11:56 2011 From: nobody at buildbot.net (Buildbot) Date: Sat, 07 May 2011 19:11:56 -0000 Subject: [Buildbot-commits] [Buildbot] #1947: exceptions.TypeError: <buildbot.status.builder.BuildStepStatus instance at 0x3da3c20> is not JSON serializable In-Reply-To: <042.e9734e12fc8a2fb0dc7129480560a171@buildbot.net> References: <042.e9734e12fc8a2fb0dc7129480560a171@buildbot.net> Message-ID: <057.ac22489ebe389901e7320f88c94500f2@buildbot.net> #1947: exceptions.TypeError: <buildbot.status.builder.BuildStepStatus instance at 0x3da3c20> is not JSON serializable -----------------------+-------------------- Reporter: tom.prince | Owner: Type: defect | Status: new Priority: critical | Milestone: 0.8.4 Version: 0.8.3p1 | Resolution: Keywords: web | -----------------------+-------------------- Comment (by dustin): I can duplicate the original error with /json/builders/builder/builds/_all/0/steps A different, but related bug: doing a recursive wget on /json, I get {{{ 2011-05-07 14:05:47-0500 [HTTPChannel,45,172.16.1.18] Unhandled Error Traceback (most recent call last): File "/home/dustin/code/buildbot/t/buildbot/master/buildbot/status/web/status_json.py", line 188, in <lambda> d = defer.maybeDeferred(lambda : self.content(request)) File "/home/dustin/code/buildbot/t/buildbot/sand26/lib/python2.6 /site-packages/twisted/internet/defer.py", line 697, in unwindGenerator return _deferGenerator(f(*args, **kwargs), Deferred()) File "/home/dustin/code/buildbot/t/buildbot/sand26/lib/python2.6 /site-packages/twisted/internet/defer.py", line 600, in _deferGenerator result = g.next() File "/home/dustin/code/buildbot/t/buildbot/master/buildbot/status/web/status_json.py", line 255, in content defer.maybeDeferred(lambda : --- <exception caught here> --- File "/home/dustin/code/buildbot/t/buildbot/sand26/lib/python2.6 /site-packages/twisted/internet/defer.py", line 102, in maybeDeferred result = f(*args, **kw) File "/home/dustin/code/buildbot/t/buildbot/master/buildbot/status/web/status_json.py", line 256, in <lambda> child.asDict(request))) exceptions.AttributeError: NoResource instance has no attribute 'asDict' }}} for /json/builders/builder/builds?select=-1&select=-2&as_text=1 /json/builders/builder/builds?select=-1/source_stamp/changes&select=-2/source_stamp/changes&as_text=1 I think this is because I didn't have any changes present - adding some builds with changes fixed it. -- Ticket URL: <http://trac.buildbot.net/ticket/1947#comment:3> Buildbot <http://buildbot.net/> Buildbot: build/test automation From noreply at github.com Sat May 7 19:24:06 2011 From: noreply at github.com (noreply at github.com) Date: Sat, 7 May 2011 12:24:06 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] b66bab: Fix tracebacks in status_json Message-ID: <20110507192406.53B804245C@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: b66bab3ce13c8ca0a5acf5a97d7d69e2706193cd https://github.com/buildbot/buildbot/commit/b66bab3ce13c8ca0a5acf5a97d7d69e2706193cd Author: Dustin J. Mitchell <dustin at mozilla.com> Date: 2011-05-07 (Sat, 07 May 2011) Changed paths: M master/buildbot/status/web/baseweb.py M master/buildbot/status/web/status_json.py Log Message: ----------- Fix tracebacks in status_json Fixes #1947. The error handling isn't too good, but it could be worse. From nobody at buildbot.net Sat May 7 19:24:11 2011 From: nobody at buildbot.net (Buildbot) Date: Sat, 07 May 2011 19:24:11 -0000 Subject: [Buildbot-commits] [Buildbot] #1947: exceptions.TypeError: <buildbot.status.builder.BuildStepStatus instance at 0x3da3c20> is not JSON serializable In-Reply-To: <042.e9734e12fc8a2fb0dc7129480560a171@buildbot.net> References: <042.e9734e12fc8a2fb0dc7129480560a171@buildbot.net> Message-ID: <057.8e7a13b6fca6e3daa4e88f94dd2fbc6e@buildbot.net> #1947: exceptions.TypeError: <buildbot.status.builder.BuildStepStatus instance at 0x3da3c20> is not JSON serializable -----------------------+--------------------- Reporter: tom.prince | Owner: Type: defect | Status: closed Priority: critical | Milestone: 0.8.4 Version: 0.8.3p1 | Resolution: fixed Keywords: web | -----------------------+--------------------- Changes (by Dustin J. Mitchell): * status: new => closed * resolution: => fixed Comment: Fix tracebacks in status_json Fixes #1947. The error handling isn't too good, but it could be worse. Changeset: b66bab3ce13c8ca0a5acf5a97d7d69e2706193cd -- Ticket URL: <http://trac.buildbot.net/ticket/1947#comment:4> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Sun May 8 03:55:18 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 08 May 2011 03:55:18 -0000 Subject: [Buildbot-commits] [Buildbot] #1951: Improve Nightly's next-build-finding algorithm Message-ID: <038.cadfd8cbd2ebf386bea86eaaf5cffd2a@buildbot.net> #1951: Improve Nightly's next-build-finding algorithm ------------------------+------------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.+ Version: 0.8.3p1 | Keywords: performance ------------------------+------------------------- Nightly currently iterates through minutes from now until two years from now looking for a matching time. This isn't very efficient! The algorithm is well-tested, so a refactor should be safe. -- Ticket URL: <http://trac.buildbot.net/ticket/1951> Buildbot <http://buildbot.net/> Buildbot: build/test automation From noreply at github.com Sun May 8 04:01:06 2011 From: noreply at github.com (noreply at github.com) Date: Sat, 7 May 2011 21:01:06 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] ca16bd: assert that project and repository are strings for... Message-ID: <20110508040106.F3ECD420CD@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: ca16bdf2dd2727fbb3ece14d455d561c32dbf200 https://github.com/buildbot/buildbot/commit/ca16bdf2dd2727fbb3ece14d455d561c32dbf200 Author: Dustin J. Mitchell <dustin at mozilla.com> Date: 2011-05-07 (Sat, 07 May 2011) Changed paths: M master/buildbot/db/changes.py Log Message: ----------- assert that project and repository are strings for a new change From noreply at github.com Sun May 8 04:03:13 2011 From: noreply at github.com (noreply at github.com) Date: Sat, 7 May 2011 21:03:13 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] bb7b10: set project to '' if it's found to be None Message-ID: <20110508040313.CFEFD424CE@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: bb7b10d665d44d012e03dc82b3fc93e3a969ca14 https://github.com/buildbot/buildbot/commit/bb7b10d665d44d012e03dc82b3fc93e3a969ca14 Author: Derek Hurley <dzhurley at gmail.com> Date: 2011-05-07 (Sat, 07 May 2011) Changed paths: M master/buildbot/status/web/hooks/github.py Log Message: ----------- set project to '' if it's found to be None From nobody at buildbot.net Sun May 8 04:13:03 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 08 May 2011 04:13:03 -0000 Subject: [Buildbot-commits] [Buildbot] #1944: ?project= In-Reply-To: <041.284fa08995a1bb2d59b6361a6d1f9ef5@buildbot.net> References: <041.284fa08995a1bb2d59b6361a6d1f9ef5@buildbot.net> Message-ID: <056.22aa2f6b51385684937d2551d089c1b7@buildbot.net> #1944: ?project= ------------------------+--------------------- Reporter: dabrahams | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.4 Version: master | Resolution: fixed Keywords: simple, git | ------------------------+--------------------- Changes (by redheadphones): * status: new => closed * resolution: => fixed Comment: resolved with https://github.com/buildbot/buildbot/commit/bb7b10d665d44d012e03dc82b3fc93e3a969ca14 -- Ticket URL: <http://trac.buildbot.net/ticket/1944#comment:2> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Sun May 8 05:41:53 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 08 May 2011 05:41:53 -0000 Subject: [Buildbot-commits] [Buildbot] #1946: buildbot.steps.transfer._FileWriter uses __del__ In-Reply-To: <038.ac84b40eacc83bbeed29e7604c23ac9c@buildbot.net> References: <038.ac84b40eacc83bbeed29e7604c23ac9c@buildbot.net> Message-ID: <053.07407e8d5097521e538297d41c2d0eba@buildbot.net> #1946: buildbot.steps.transfer._FileWriter uses __del__ ------------------------+-------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.4 Version: master | Resolution: Keywords: performance | ------------------------+-------------------- Comment (by tom.prince): There are probably two ways to handle this. Move the logic from __del__ to the errback of the remote transfer command, or hook into the brokers notifyOnConnectionLost. A related issue is whether the logic in remote_close (particularly for the _DirectoryWriter) should be driven by the slave. Lastly, (so it doesn't get lost), the slave exposes uploading a file, or a directory as a tarfile. It would seem reasonable to expose the latter ability directly, which would (in some cases) save generating and storing a tarfile on the slave. -- Ticket URL: <http://trac.buildbot.net/ticket/1946#comment:1> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Sun May 8 05:42:03 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 08 May 2011 05:42:03 -0000 Subject: [Buildbot-commits] [Buildbot] #1946: buildbot.steps.transfer._FileWriter uses __del__ In-Reply-To: <038.ac84b40eacc83bbeed29e7604c23ac9c@buildbot.net> References: <038.ac84b40eacc83bbeed29e7604c23ac9c@buildbot.net> Message-ID: <053.9c5e0a864dac5bdab04f1ba27117e17f@buildbot.net> #1946: buildbot.steps.transfer._FileWriter uses __del__ ------------------------+-------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.4 Version: master | Resolution: Keywords: performance | ------------------------+-------------------- Changes (by tom.prince): * cc: tom.prince@? (added) -- Ticket URL: <http://trac.buildbot.net/ticket/1946#comment:2> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Sun May 8 05:44:03 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 08 May 2011 05:44:03 -0000 Subject: [Buildbot-commits] [Buildbot] #1861: github hook should optionally ignore distinct=false In-Reply-To: <038.28bd8207d25cfc78c10bb532db1c009b@buildbot.net> References: <038.28bd8207d25cfc78c10bb532db1c009b@buildbot.net> Message-ID: <053.9717bbd2bb4f44ed91a3f1d4aff8d1c0@buildbot.net> #1861: github hook should optionally ignore distinct=false ------------------------+-------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.4 Version: 0.8.3p1 | Resolution: Keywords: git | ------------------------+-------------------- Comment (by tom.prince): I agree that this should be exposed. I am not entirely sure how though, since multiple repositories may use the same hook, but want different settings. -- Ticket URL: <http://trac.buildbot.net/ticket/1861#comment:1> Buildbot <http://buildbot.net/> Buildbot: build/test automation From noreply at github.com Sun May 8 16:14:38 2011 From: noreply at github.com (noreply at github.com) Date: Sun, 8 May 2011 09:14:38 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] e70e6f: Make PBChangeSource more resilient to malformed da... Message-ID: <20110508161439.00E55424B5@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: e70e6f75c43660fe2ac84de41e845c31f03889f3 https://github.com/buildbot/buildbot/commit/e70e6f75c43660fe2ac84de41e845c31f03889f3 Author: Tom Prince <tom.prince at ualberta.net> Date: 2011-05-07 (Sat, 07 May 2011) Changed paths: M master/buildbot/changes/pb.py M master/buildbot/test/unit/test_changes_pb.py Log Message: ----------- Make PBChangeSource more resilient to malformed data. Signed-off-by: Tom Prince <tom.prince at ualberta.net> Commit: 37ad8de1c6cf9614eb933e0a661b431eda28f24f https://github.com/buildbot/buildbot/commit/37ad8de1c6cf9614eb933e0a661b431eda28f24f Author: Tom Prince <tom.prince at ualberta.net> Date: 2011-05-07 (Sat, 07 May 2011) Changed paths: M master/buildbot/status/web/status_json.py Log Message: ----------- Update pointer to wikipedia JSONP page. Signed-off-by: Tom Prince <tom.prince at ualberta.net> Commit: e7329f67d2dfaa43ae9fea402badea803b15c973 https://github.com/buildbot/buildbot/commit/e7329f67d2dfaa43ae9fea402badea803b15c973 Author: Tom Prince <tom.prince at ualberta.net> Date: 2011-05-07 (Sat, 07 May 2011) Changed paths: M master/buildbot/steps/source.py Log Message: ----------- Fix handling of branch option to Git source step. Git.__init__ just stuffed it into args, which meant that the WithProperties rendering code in Source doesn't get a hold of it. Signed-off-by: Tom Prince <tom.prince at ualberta.net> Commit: 9b2d2bf0af96d9c24427fd04ac6c63a84459f414 https://github.com/buildbot/buildbot/commit/9b2d2bf0af96d9c24427fd04ac6c63a84459f414 Author: Dustin J. Mitchell <dustin at v.igoro.us> Date: 2011-05-08 (Sun, 08 May 2011) Changed paths: M master/buildbot/changes/pb.py M master/buildbot/status/web/status_json.py M master/buildbot/steps/source.py M master/buildbot/test/unit/test_changes_pb.py Log Message: ----------- Merge pull request #118 from tomprince/postel Misc fixes. Compare: https://github.com/buildbot/buildbot/compare/bb7b10d...9b2d2bf From nobody at buildbot.net Sun May 8 20:01:51 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 08 May 2011 20:01:51 -0000 Subject: [Buildbot-commits] [Buildbot] #1952: change properties imported incorrectly Message-ID: <038.6b28bc97991139f8195cdcbdfbcbf018@buildbot.net> #1952: change properties imported incorrectly ---------------------+---------------------- Reporter: dustin | Owner: Type: defect | Status: new Priority: critical | Milestone: 0.8.4 Version: 0.8.3p1 | Keywords: database ---------------------+---------------------- Buildbot 0.8.3 and earlier versions stores change properties in the {{{property_value}}} column as a list [value, source], where source is always 'Change'. In the sqlalchemy rewrite, I've assumed that {{{property_value}}} contained only the value, and missed the discrepancy due to an error in the tests. -- Ticket URL: <http://trac.buildbot.net/ticket/1952> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Sun May 8 20:46:24 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 08 May 2011 20:46:24 -0000 Subject: [Buildbot-commits] [Buildbot] #1952: change properties imported incorrectly In-Reply-To: <038.6b28bc97991139f8195cdcbdfbcbf018@buildbot.net> References: <038.6b28bc97991139f8195cdcbdfbcbf018@buildbot.net> Message-ID: <053.fa85822e08ba22360c33388b334c726f@buildbot.net> #1952: change properties imported incorrectly ---------------------+-------------------- Reporter: dustin | Owner: Type: defect | Status: new Priority: critical | Milestone: 0.8.4 Version: 0.8.3p1 | Resolution: Keywords: database | ---------------------+-------------------- Comment (by dustin): Because there are a number of people running development versions (0.8.4-pre), this will need some compatibility allowances. -- Ticket URL: <http://trac.buildbot.net/ticket/1952#comment:1> Buildbot <http://buildbot.net/> Buildbot: build/test automation From noreply at github.com Sun May 8 20:48:40 2011 From: noreply at github.com (noreply at github.com) Date: Sun, 8 May 2011 13:48:40 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 5e5d29: changes_properties.property_value stores [value, s... Message-ID: <20110508204840.E01FA422FC@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 5e5d29f469c20a42257750c0301bc0d9001c8284 https://github.com/buildbot/buildbot/commit/5e5d29f469c20a42257750c0301bc0d9001c8284 Author: Dustin J. Mitchell <dustin at mozilla.com> Date: 2011-05-08 (Sun, 08 May 2011) Changed paths: M master/buildbot/db/changes.py M master/buildbot/db/model.py M master/buildbot/test/integration/test_upgrade.py A master/buildbot/test/regressions/test_bad_change_properties_rows.py M master/buildbot/test/unit/test_db_changes.py Log Message: ----------- changes_properties.property_value stores [value, source] (Even though source is always "Change") This fixes a bug that's been present in many development versions *since* 0.8.3, but not in 0.8.3 itself, so there are no significant compatibility problems for most users. However, users who have run development versions may have changes without a source, so some additional code is included to handle that case gracefully. And that exceptional code is tested with a regression test. From noreply at github.com Mon May 9 00:08:37 2011 From: noreply at github.com (noreply at github.com) Date: Sun, 8 May 2011 17:08:37 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] e09558: revert debugging change, accidentally committed Message-ID: <20110509000837.30673424A5@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: e095585356e9fedafb729ef64f8b26f5a1453aba https://github.com/buildbot/buildbot/commit/e095585356e9fedafb729ef64f8b26f5a1453aba Author: Dustin J. Mitchell <dustin at mozilla.com> Date: 2011-05-08 (Sun, 08 May 2011) Changed paths: M master/buildbot/status/web/baseweb.py Log Message: ----------- revert debugging change, accidentally committed From noreply at github.com Mon May 9 19:16:01 2011 From: noreply at github.com (noreply at github.com) Date: Mon, 9 May 2011 12:16:01 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 39cdbc: Fix db.changes.addChange to not create or return a... Message-ID: <20110509191601.88055422FC@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 39cdbc3a26807d89ed17e2ac660cd10fe8587f82 https://github.com/buildbot/buildbot/commit/39cdbc3a26807d89ed17e2ac660cd10fe8587f82 Author: Dustin J. Mitchell <dustin at mozilla.com> Date: 2011-05-08 (Sun, 08 May 2011) Changed paths: M master/buildbot/db/changes.py M master/buildbot/master.py M master/buildbot/test/fake/fakedb.py M master/buildbot/test/unit/test_db_changes.py M master/buildbot/test/unit/test_master.py Log Message: ----------- Fix db.changes.addChange to not create or return a Change instance The master.addChange wrapper, however, still does return such an instance, and this is what all of the ChangeSources point to. Commit: a252ba26b4e3d20e81e44951b82e33d5fcc87e09 https://github.com/buildbot/buildbot/commit/a252ba26b4e3d20e81e44951b82e33d5fcc87e09 Author: Dustin J. Mitchell <dustin at mozilla.com> Date: 2011-05-09 (Mon, 09 May 2011) Changed paths: M master/buildbot/db/changes.py M master/buildbot/master.py M master/buildbot/test/unit/test_db_changes.py M master/buildbot/test/unit/test_master.py Log Message: ----------- Refactor db.addChange parameters This makes the following changes: * 'who' becomes 'author' * 'isdir' becomes 'is_dir' * 'when' becomes 'when_timestamp', and changes type to datetime * 'properties' must now specify a source ({ k : (v,s) }), just like the same argument to addBuildset The master.addChange method takes care of these translations, so Change Sources need not be altered, although it will log a warning for the old parameters (except for properties). Built-in change sources will be changed in a subsequent commit. Commit: 56d87cb6f798a613da76990b039ece45aea6e3a8 https://github.com/buildbot/buildbot/commit/56d87cb6f798a613da76990b039ece45aea6e3a8 Author: Dustin J. Mitchell <dustin at mozilla.com> Date: 2011-05-09 (Mon, 09 May 2011) Changed paths: M master/buildbot/changes/bonsaipoller.py M master/buildbot/changes/gerritchangesource.py M master/buildbot/changes/gitpoller.py M master/buildbot/changes/p4poller.py M master/buildbot/changes/pb.py M master/buildbot/test/unit/test_changes_bonsaipoller.py M master/buildbot/test/unit/test_changes_gerritchangesource.py M master/buildbot/test/unit/test_changes_gitpoller.py M master/buildbot/test/unit/test_changes_p4poller.py M master/buildbot/test/unit/test_changes_pb.py Log Message: ----------- Update change sources to use the new addChange parameter names Note that sendchange will still use the old parameter names on the wire, although the master accepts the new names now. Once 0.8.4 or higher are the majority of installed masters, we can alter sendchange. Refs #1905. Commit: a3112345af637253c70de8782ce79e7fa618c143 https://github.com/buildbot/buildbot/commit/a3112345af637253c70de8782ce79e7fa618c143 Author: Dustin J. Mitchell <dustin at mozilla.com> Date: 2011-05-09 (Mon, 09 May 2011) Changed paths: M master/buildbot/changes/bonsaipoller.py M master/buildbot/changes/changes.py M master/buildbot/changes/gerritchangesource.py M master/buildbot/changes/gitpoller.py M master/buildbot/changes/p4poller.py M master/buildbot/changes/pb.py M master/buildbot/db/changes.py M master/buildbot/master.py M master/buildbot/schedulers/base.py M master/buildbot/schedulers/basic.py M master/buildbot/sourcestamp.py M master/buildbot/status/master.py M master/buildbot/status/web/console.py M master/buildbot/status/web/waterfall.py M master/buildbot/test/fake/fakedb.py M master/buildbot/test/integration/test_upgrade.py M master/buildbot/test/regressions/test_bad_change_properties_rows.py M master/buildbot/test/regressions/test_import_unicode_changes.py M master/buildbot/test/unit/test_changes_bonsaipoller.py M master/buildbot/test/unit/test_changes_gerritchangesource.py M master/buildbot/test/unit/test_changes_gitpoller.py M master/buildbot/test/unit/test_changes_p4poller.py M master/buildbot/test/unit/test_changes_pb.py M master/buildbot/test/unit/test_db_changes.py M master/buildbot/test/unit/test_master.py Log Message: ----------- Merge branch 'bug1905' * bug1905: Update change sources to use the new addChange parameter names Refactor db.addChange parameters Fix db.changes.addChange to not create or return a Change instance replace db.changes.getChangeInstance with getChange Remove db.changes.getRecentChangeInstances Define a chdict, using names based on db columns Begin to transition db.changes to use chdicts Rename private parameter to SourceStamp.__init__ Compare: https://github.com/buildbot/buildbot/compare/e095585...a311234 From nobody at buildbot.net Mon May 9 19:16:08 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 09 May 2011 19:16:08 -0000 Subject: [Buildbot-commits] [Buildbot] #1905: create Change.fronChdict and move instance creation out of db.changes In-Reply-To: <038.1192e65e0d317fcae9040902c3b18fbe@buildbot.net> References: <038.1192e65e0d317fcae9040902c3b18fbe@buildbot.net> Message-ID: <053.c0620f1b105b6ded3e12319123cbd5b6@buildbot.net> #1905: create Change.fronChdict and move instance creation out of db.changes ------------------------+--------------------- Reporter: dustin | Owner: dustin Type: enhancement | Status: new Priority: major | Milestone: 0.8.4 Version: master | Resolution: Keywords: database | ------------------------+--------------------- Comment (by Dustin J. Mitchell): Update change sources to use the new addChange parameter names Note that sendchange will still use the old parameter names on the wire, although the master accepts the new names now. Once 0.8.4 or higher are the majority of installed masters, we can alter sendchange. Refs #1905. Changeset: 56d87cb6f798a613da76990b039ece45aea6e3a8 -- Ticket URL: <http://trac.buildbot.net/ticket/1905#comment:2> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Mon May 9 19:18:39 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 09 May 2011 19:18:39 -0000 Subject: [Buildbot-commits] [Buildbot] #1905: create Change.fronChdict and move instance creation out of db.changes In-Reply-To: <038.1192e65e0d317fcae9040902c3b18fbe@buildbot.net> References: <038.1192e65e0d317fcae9040902c3b18fbe@buildbot.net> Message-ID: <053.b01d95deecf3f1023c4abfc047a271a1@buildbot.net> #1905: create Change.fronChdict and move instance creation out of db.changes ------------------------+--------------------- Reporter: dustin | Owner: dustin Type: enhancement | Status: closed Priority: major | Milestone: 0.8.4 Version: master | Resolution: fixed Keywords: database | ------------------------+--------------------- Changes (by dustin): * status: new => closed * resolution: => fixed Comment: So this is done, and thoroughly. There were several related commits that I pushed all at once, but not all of them showed up. -- Ticket URL: <http://trac.buildbot.net/ticket/1905#comment:3> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Mon May 9 20:17:41 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 09 May 2011 20:17:41 -0000 Subject: [Buildbot-commits] [Buildbot] #1818: sqlalchemy-migrate uses full paths in the 'migrate_version' database table In-Reply-To: <038.ecd1553f82421bf6df35851d7bf005b4@buildbot.net> References: <038.ecd1553f82421bf6df35851d7bf005b4@buildbot.net> Message-ID: <053.da00c37aaa7d1d5d8d4449bec0b32c31@buildbot.net> #1818: sqlalchemy-migrate uses full paths in the 'migrate_version' database table ---------------------+-------------------- Reporter: dustin | Owner: Type: defect | Status: new Priority: minor | Milestone: 0.8.4 Version: master | Resolution: Keywords: database | ---------------------+-------------------- Changes (by dustin): * version: 0.8.3p1 => master * milestone: 0.8.+ => 0.8.4 Comment: This needs to happen for 0.8.4. -- Ticket URL: <http://trac.buildbot.net/ticket/1818#comment:1> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Mon May 9 20:46:20 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 09 May 2011 20:46:20 -0000 Subject: [Buildbot-commits] [Buildbot] #1952: change properties imported incorrectly In-Reply-To: <038.6b28bc97991139f8195cdcbdfbcbf018@buildbot.net> References: <038.6b28bc97991139f8195cdcbdfbcbf018@buildbot.net> Message-ID: <053.0240aca3458cb744630cc28dfd3f1a72@buildbot.net> #1952: change properties imported incorrectly ---------------------+--------------------- Reporter: dustin | Owner: Type: defect | Status: closed Priority: critical | Milestone: 0.8.4 Version: 0.8.3p1 | Resolution: fixed Keywords: database | ---------------------+--------------------- Changes (by dustin): * status: new => closed * resolution: => fixed Comment: Fixed in [5e5d29f469c20a42257750c0301bc0d9001c8284]. -- Ticket URL: <http://trac.buildbot.net/ticket/1952#comment:2> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Mon May 9 20:53:15 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 09 May 2011 20:53:15 -0000 Subject: [Buildbot-commits] [Buildbot] #1818: sqlalchemy-migrate uses full paths in the 'migrate_version' database table In-Reply-To: <038.ecd1553f82421bf6df35851d7bf005b4@buildbot.net> References: <038.ecd1553f82421bf6df35851d7bf005b4@buildbot.net> Message-ID: <053.0600866e0e9f4b17a5339cbacc99e31c@buildbot.net> #1818: sqlalchemy-migrate uses full paths in the 'migrate_version' database table ---------------------+------------------------- Reporter: dustin | Owner: Type: defect | Status: closed Priority: minor | Milestone: 0.8.4 Version: master | Resolution: worksforme Keywords: database | ---------------------+------------------------- Changes (by dustin): * status: new => closed * resolution: => worksforme Comment: This is not actually a problem. The schema for the {{{migrate_version}}} table is: {{{ CREATE TABLE migrate_version ( repository_id VARCHAR(250) NOT NULL, repository_path TEXT, version INTEGER, PRIMARY KEY (repository_id) ); }}} where repository_path has the full Python path of the migrate repository ({{{/home/dustin/code/buildbot/t/buildbot/master/buildbot/db/migrate}}} on my system). However, according to my greps and a quick test by hand, that column is never checked. -- Ticket URL: <http://trac.buildbot.net/ticket/1818#comment:2> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Mon May 9 21:23:37 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 09 May 2011 21:23:37 -0000 Subject: [Buildbot-commits] [Buildbot] #1953: add aggressive caching in the db layer Message-ID: <038.55a64c0302e3f9034fd17d48112cd80b@buildbot.net> #1953: add aggressive caching in the db layer ------------------------+----------------------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: critical | Milestone: 0.8.4 Version: master | Keywords: database, performance ------------------------+----------------------------------- This should be implemented at {{{master.db.cache}}} and should have a configurable global size limit. It should probably also be able to cache process objects (the results of {{{fromSsdict}}}, {{{fromChdict}}}, etc.) A few details: * lots of tables are write-only, so those can be cached easily and newly- written records should go into the cache too (write-through) * dynamic state should be written through a write-coalescing cache * scheduler state * build request / buildset results -- Ticket URL: <http://trac.buildbot.net/ticket/1953> Buildbot <http://buildbot.net/> Buildbot: build/test automation From noreply at github.com Tue May 10 02:29:23 2011 From: noreply at github.com (noreply at github.com) Date: Mon, 9 May 2011 19:29:23 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 2e0a9c: rename createSourceStamp to addSourceStamp Message-ID: <20110510022923.1353342513@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 2e0a9c7429c9c64925c8f4744244376e4b5e8e98 https://github.com/buildbot/buildbot/commit/2e0a9c7429c9c64925c8f4744244376e4b5e8e98 Author: Dustin J. Mitchell <dustin at mozilla.com> Date: 2011-05-09 (Mon, 09 May 2011) Changed paths: M master/buildbot/db/sourcestamps.py M master/buildbot/schedulers/base.py M master/buildbot/schedulers/trysched.py M master/buildbot/sourcestamp.py M master/buildbot/status/web/builder.py M master/buildbot/steps/trigger.py M master/buildbot/test/fake/fakedb.py M master/buildbot/test/unit/test_db_sourcestamps.py Log Message: ----------- rename createSourceStamp to addSourceStamp From nobody at buildbot.net Tue May 10 03:02:38 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 10 May 2011 03:02:38 -0000 Subject: [Buildbot-commits] [Buildbot] #1953: add aggressive caching in the db layer In-Reply-To: <038.55a64c0302e3f9034fd17d48112cd80b@buildbot.net> References: <038.55a64c0302e3f9034fd17d48112cd80b@buildbot.net> Message-ID: <053.6f9d6601d4154fafeb93dae193df587d@buildbot.net> #1953: add aggressive caching in the db layer ----------------------------------+-------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: critical | Milestone: 0.8.4 Version: master | Resolution: Keywords: database, performance | ----------------------------------+-------------------- Comment (by dustin): Amar recommends http://beaker.groovie.org/ -- Ticket URL: <http://trac.buildbot.net/ticket/1953#comment:1> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Tue May 10 03:33:40 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 10 May 2011 03:33:40 -0000 Subject: [Buildbot-commits] [Buildbot] #1900: no way to upgrade directly to MySQL In-Reply-To: <038.bdefb07aa87476caf3cc0e658830d974@buildbot.net> References: <038.bdefb07aa87476caf3cc0e658830d974@buildbot.net> Message-ID: <053.64950ff416ba7e2e7e68c214d45f97d7@buildbot.net> #1900: no way to upgrade directly to MySQL ---------------------+-------------------- Reporter: dustin | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.4 Version: 0.8.3p1 | Resolution: Keywords: database | ---------------------+-------------------- Comment (by dustin): Actually, {{{upgrade-master}}} __does__ take a {{{--db}}} argument. So the proper course is to upgrade with this argument, and then edit your master.cfg accordingly. -- Ticket URL: <http://trac.buildbot.net/ticket/1900#comment:1> Buildbot <http://buildbot.net/> Buildbot: build/test automation From noreply at github.com Tue May 10 05:05:46 2011 From: noreply at github.com (noreply at github.com) Date: Mon, 9 May 2011 22:05:46 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] b10550: Check that --db == db_url in upgrade-master Message-ID: <20110510050546.B9F5D42520@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: b105501c1bf8d730eb9b06cbdda521f01a70a292 https://github.com/buildbot/buildbot/commit/b105501c1bf8d730eb9b06cbdda521f01a70a292 Author: Dustin J. Mitchell <dustin at mozilla.com> Date: 2011-05-09 (Mon, 09 May 2011) Changed paths: M master/buildbot/master.py M master/buildbot/scripts/runner.py M master/docs/installation.texinfo Log Message: ----------- Check that --db == db_url in upgrade-master This also clarifies how to upgrade to a db other than sqlite. Fixes #1900. From nobody at buildbot.net Tue May 10 05:05:52 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 10 May 2011 05:05:52 -0000 Subject: [Buildbot-commits] [Buildbot] #1900: no way to upgrade directly to MySQL In-Reply-To: <038.bdefb07aa87476caf3cc0e658830d974@buildbot.net> References: <038.bdefb07aa87476caf3cc0e658830d974@buildbot.net> Message-ID: <053.1e2b36c48e05aa4ed10154d043b0298f@buildbot.net> #1900: no way to upgrade directly to MySQL ---------------------+--------------------- Reporter: dustin | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.4 Version: 0.8.3p1 | Resolution: fixed Keywords: database | ---------------------+--------------------- Changes (by Dustin J. Mitchell): * status: new => closed * resolution: => fixed Comment: Check that --db == db_url in upgrade-master This also clarifies how to upgrade to a db other than sqlite. Fixes #1900. Changeset: b105501c1bf8d730eb9b06cbdda521f01a70a292 -- Ticket URL: <http://trac.buildbot.net/ticket/1900#comment:2> Buildbot <http://buildbot.net/> Buildbot: build/test automation From noreply at github.com Tue May 10 15:22:36 2011 From: noreply at github.com (noreply at github.com) Date: Tue, 10 May 2011 08:22:36 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] daef63: added '__file__' attribute to localDict, Fixes #19... Message-ID: <20110510152236.F02AB424F0@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: daef638e1365e9a3f893e63239b4124cfbdcfe8b https://github.com/buildbot/buildbot/commit/daef638e1365e9a3f893e63239b4124cfbdcfe8b Author: Derek Hurley <dzhurley at gmail.com> Date: 2011-05-10 (Tue, 10 May 2011) Changed paths: M master/buildbot/master.py M master/docs/configuration.texinfo Log Message: ----------- added '__file__' attribute to localDict, Fixes #1933 Commit: 9e2979b98de5a0a5d17057fcc0cbbd1fcb630f43 https://github.com/buildbot/buildbot/commit/9e2979b98de5a0a5d17057fcc0cbbd1fcb630f43 Author: Dustin J. Mitchell <dustin at mozilla.com> Date: 2011-05-10 (Tue, 10 May 2011) Changed paths: M master/buildbot/master.py M master/docs/configuration.texinfo Log Message: ----------- Merge branch 'master' of git://github.com/dzhurley/buildbot * 'master' of git://github.com/dzhurley/buildbot: added '__file__' attribute to localDict, Fixes #1933 Fixes #1933. Compare: https://github.com/buildbot/buildbot/compare/b105501...9e2979b From nobody at buildbot.net Tue May 10 15:22:43 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 10 May 2011 15:22:43 -0000 Subject: [Buildbot-commits] [Buildbot] #1933: Give config files a reliable way to determine their directory In-Reply-To: <041.61cbc592b4a174f5e38ff6b676e0b7ed@buildbot.net> References: <041.61cbc592b4a174f5e38ff6b676e0b7ed@buildbot.net> Message-ID: <056.65b9ffa89441ba89af2d8c82416f700e@buildbot.net> #1933: Give config files a reliable way to determine their directory ------------------------+--------------------- Reporter: dabrahams | Owner: Type: enhancement | Status: closed Priority: major | Milestone: 0.8.4 Version: 0.8.3p1 | Resolution: fixed Keywords: simple | ------------------------+--------------------- Changes (by Derek Hurley): * status: new => closed * resolution: => fixed Comment: added '__file__' attribute to localDict, Fixes #1933 Changeset: daef638e1365e9a3f893e63239b4124cfbdcfe8b -- Ticket URL: <http://trac.buildbot.net/ticket/1933#comment:3> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Tue May 10 15:22:43 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 10 May 2011 15:22:43 -0000 Subject: [Buildbot-commits] [Buildbot] #1933: Give config files a reliable way to determine their directory In-Reply-To: <041.61cbc592b4a174f5e38ff6b676e0b7ed@buildbot.net> References: <041.61cbc592b4a174f5e38ff6b676e0b7ed@buildbot.net> Message-ID: <056.ff7afe9d891a4cf4333610d749dfa579@buildbot.net> #1933: Give config files a reliable way to determine their directory ------------------------+--------------------- Reporter: dabrahams | Owner: Type: enhancement | Status: closed Priority: major | Milestone: 0.8.4 Version: 0.8.3p1 | Resolution: fixed Keywords: simple | ------------------------+--------------------- Comment (by Dustin J. Mitchell): Merge branch 'master' of git://github.com/dzhurley/buildbot * 'master' of git://github.com/dzhurley/buildbot: added '__file__' attribute to localDict, Fixes #1933 Fixes #1933. Changeset: 9e2979b98de5a0a5d17057fcc0cbbd1fcb630f43 -- Ticket URL: <http://trac.buildbot.net/ticket/1933#comment:4> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Tue May 10 22:15:30 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 10 May 2011 22:15:30 -0000 Subject: [Buildbot-commits] [Buildbot] #1954: Master fails to terminate EC2LatentBuildSlave Message-ID: <039.8fa2b2f3116d465e93e76f91ce9d60e8@buildbot.net> #1954: Master fails to terminate EC2LatentBuildSlave ---------------------+----------------------- Reporter: exarkun | Owner: Type: defect | Status: new Priority: critical | Milestone: undecided Version: 0.8.3p1 | Keywords: ---------------------+----------------------- On the first (and so far, only) substantiation of an EC2LatentBuildSlave, the master failed to actually stop the instance. The logs have: {{{ 2011-05-10 17:36:23-0400 [-] disconnecting old slave bot-exarkun-2 now 2011-05-10 17:36:23-0400 [-] waiting for slave to finish disconnecting 2011-05-10 17:36:23-0400 [KeepaliveBroker,19,50.17.81.112] BuildSlave.detached(bot-exarkun-2) 2011-05-10 17:36:26-0400 [KeepaliveBroker,20,50.17.81.112] Slave bot- exarkun-2 received connection while not trying to substantiate. Disconnecting. 2011-05-10 17:36:26-0400 [KeepaliveBroker,20,50.17.81.112] waiting for slave to finish disconnecting 2011-05-10 17:36:26-0400 [KeepaliveBroker,20,50.17.81.112] Peer will receive following PB traceback: 2011-05-10 17:36:26-0400 [KeepaliveBroker,20,50.17.81.112] Unhandled Error Traceback (most recent call last): Failure: exceptions.RuntimeError: Slave bot-exarkun-2 received connection while not trying to substantiate. Disconnecting. }}} and apparently nothing else related to the issue. The result seems to be that the instance will run forever, or until I intervene to correct the situation. -- Ticket URL: <http://trac.buildbot.net/ticket/1954> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Wed May 11 03:23:43 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 11 May 2011 03:23:43 -0000 Subject: [Buildbot-commits] [Buildbot] #1953: add aggressive caching in the db layer In-Reply-To: <038.55a64c0302e3f9034fd17d48112cd80b@buildbot.net> References: <038.55a64c0302e3f9034fd17d48112cd80b@buildbot.net> Message-ID: <053.35c2bff22cf28017ea1346401fa65aa1@buildbot.net> #1953: add aggressive caching in the db layer ----------------------------------+-------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: critical | Milestone: 0.8.4 Version: master | Resolution: Keywords: database, performance | ----------------------------------+-------------------- Comment (by dustin): beaker doesn't seem to implement what we need, yet brings a lot of baggage to implement things we don't need (web sessions, pluggable backends, etc.) Options with compatible licenses: * http://code.activestate.com/recipes/252524-length-limited-o1-lru-cache- implementation/ (GPL) * http://evan.prodromou.name/Software/Python/LRUCache (AFL) * http://code.activestate.com/recipes/498245-lru-and-lfu-cache- decorators/ (PSF; By Raymond Hettinger!) -- Ticket URL: <http://trac.buildbot.net/ticket/1953#comment:2> Buildbot <http://buildbot.net/> Buildbot: build/test automation From noreply at github.com Wed May 11 05:28:18 2011 From: noreply at github.com (noreply at github.com) Date: Tue, 10 May 2011 22:28:18 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 38c706: remove unused LRUCache from ChangeManager Message-ID: <20110511052818.AB901424DE@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 38c70642ad4244826bff43390c33f754fdffe435 https://github.com/buildbot/buildbot/commit/38c70642ad4244826bff43390c33f754fdffe435 Author: Dustin J. Mitchell <dustin at mozilla.com> Date: 2011-05-10 (Tue, 10 May 2011) Changed paths: M master/buildbot/changes/manager.py Log Message: ----------- remove unused LRUCache from ChangeManager Commit: 9b3d62d654b51f394eb8b54ac49ea8e8be5d0ed6 https://github.com/buildbot/buildbot/commit/9b3d62d654b51f394eb8b54ac49ea8e8be5d0ed6 Author: Dustin J. Mitchell <dustin at mozilla.com> Date: 2011-05-10 (Tue, 10 May 2011) Changed paths: M master/buildbot/schedulers/basic.py M master/buildbot/schedulers/manager.py M master/buildbot/status/master.py M master/buildbot/test/test_extra_coverage.py A master/buildbot/test/unit/test_util_bbcollections.py R master/buildbot/test/unit/test_util_collections.py A master/buildbot/util/bbcollections.py R master/buildbot/util/collections.py M master/docs/developer.texinfo Log Message: ----------- move buildbot.util.collections to buildbot.util.bbcollections Compare: https://github.com/buildbot/buildbot/compare/9e2979b...9b3d62d From nobody at buildbot.net Wed May 11 11:01:57 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 11 May 2011 11:01:57 -0000 Subject: [Buildbot-commits] [Buildbot] #1953: add aggressive caching in the db layer In-Reply-To: <038.55a64c0302e3f9034fd17d48112cd80b@buildbot.net> References: <038.55a64c0302e3f9034fd17d48112cd80b@buildbot.net> Message-ID: <053.24436b85470cc7de7af82b2c30685f1e@buildbot.net> #1953: add aggressive caching in the db layer ----------------------------------+-------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: critical | Milestone: 0.8.4 Version: master | Resolution: Keywords: database, performance | ----------------------------------+-------------------- Comment (by catlee): It would be nice if you could configure buildbot to use an external memcached or redis cache. -- Ticket URL: <http://trac.buildbot.net/ticket/1953#comment:3> Buildbot <http://buildbot.net/> Buildbot: build/test automation From noreply at github.com Wed May 11 15:23:05 2011 From: noreply at github.com (noreply at github.com) Date: Wed, 11 May 2011 08:23:05 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] ea6735: Moved the project argument to the base VisualStudi... Message-ID: <20110511152305.7A90E424BB@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: ea6735d1caa340222499217f761d68e9cc06abf2 https://github.com/buildbot/buildbot/commit/ea6735d1caa340222499217f761d68e9cc06abf2 Author: nate <nate.bragg at adb-air.com> Date: 2011-05-11 (Wed, 11 May 2011) Changed paths: M master/buildbot/steps/vstudio.py Log Message: ----------- Moved the project argument to the base VisualStudio class Commit: a87d86a305fa53def15e694c08b6c4d1e3a3617f https://github.com/buildbot/buildbot/commit/a87d86a305fa53def15e694c08b6c4d1e3a3617f Author: nate <nate.bragg at adb-air.com> Date: 2011-05-11 (Wed, 11 May 2011) Changed paths: M master/docs/cfg-buildsteps.texinfo Log Message: ----------- Moved the project argument to the base VisualStudio class Commit: 900c3a00154d6ed65d7f663b521df6589d95456f https://github.com/buildbot/buildbot/commit/900c3a00154d6ed65d7f663b521df6589d95456f Author: Dustin J. Mitchell <dustin at mozilla.com> Date: 2011-05-11 (Wed, 11 May 2011) Changed paths: M master/buildbot/steps/vstudio.py M master/docs/cfg-buildsteps.texinfo Log Message: ----------- Merge branch 'vstudiofeature' of git://github.com/NateBragg/buildbot * 'vstudiofeature' of git://github.com/NateBragg/buildbot: Moved the project argument to the base VisualStudio class Moved the project argument to the base VisualStudio class Compare: https://github.com/buildbot/buildbot/compare/9b3d62d...900c3a0 From nobody at buildbot.net Wed May 11 15:57:50 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 11 May 2011 15:57:50 -0000 Subject: [Buildbot-commits] [Buildbot] #1954: Master fails to terminate EC2LatentBuildSlave In-Reply-To: <039.8fa2b2f3116d465e93e76f91ce9d60e8@buildbot.net> References: <039.8fa2b2f3116d465e93e76f91ce9d60e8@buildbot.net> Message-ID: <054.2e6c97b7e1796bb06123cc6ee9f60f45@buildbot.net> #1954: Master fails to terminate EC2LatentBuildSlave ---------------------------+-------------------- Reporter: exarkun | Owner: Type: defect | Status: new Priority: critical | Milestone: 0.8.4 Version: 0.8.3p1 | Resolution: Keywords: virtualization | ---------------------------+-------------------- Changes (by dustin): * cc: tom@?, john.carr@? (added) * keywords: => virtualization * milestone: undecided => 0.8.4 Comment: So I think what's happening here is this: * master disconnects slave * master begins to shut down slave EC2 instance * slave process reconnects to master * master errback's on the perspective_login call, with failure as detailed above I think the correct solution is to gracefully shut down the slave, instead of just disconnecting it, so that it will not try to reconnect. I *thought* this was already done, but I don't see it in the code or in the git log. -- Ticket URL: <http://trac.buildbot.net/ticket/1954#comment:1> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Wed May 11 15:59:30 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 11 May 2011 15:59:30 -0000 Subject: [Buildbot-commits] [Buildbot] #1780: Latent build slaves shut down uncleanly and get forgotten by the master In-Reply-To: <040.ea5c2cbbd82d21ecc7d22b950b6307bf@buildbot.net> References: <040.ea5c2cbbd82d21ecc7d22b950b6307bf@buildbot.net> Message-ID: <055.5fc73e2bffda978a17e436e41a196f25@buildbot.net> #1780: Latent build slaves shut down uncleanly and get forgotten by the master ---------------------------+-------------------- Reporter: jacobian | Owner: Type: defect | Status: new Priority: critical | Milestone: 0.8.4 Version: 0.8.3p1 | Resolution: Keywords: virtualization | ---------------------------+-------------------- Changes (by dustin): * cc: tom@?, john.carr@? (added) * priority: major => critical Comment: The latter should be a new issue. Also, #1954 is a dupe of this bug (marking as such) -- Ticket URL: <http://trac.buildbot.net/ticket/1780#comment:8> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Wed May 11 15:59:52 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 11 May 2011 15:59:52 -0000 Subject: [Buildbot-commits] [Buildbot] #1954: Master fails to terminate EC2LatentBuildSlave In-Reply-To: <039.8fa2b2f3116d465e93e76f91ce9d60e8@buildbot.net> References: <039.8fa2b2f3116d465e93e76f91ce9d60e8@buildbot.net> Message-ID: <054.98beaa7648f06766ae28d67c286f1a69@buildbot.net> #1954: Master fails to terminate EC2LatentBuildSlave ---------------------------+------------------------ Reporter: exarkun | Owner: Type: defect | Status: closed Priority: critical | Milestone: 0.8.4 Version: 0.8.3p1 | Resolution: duplicate Keywords: virtualization | ---------------------------+------------------------ Changes (by dustin): * status: new => closed * resolution: => duplicate Comment: Ah, I *suggested* that solution, but it's not implemented yet - see #1780. -- Ticket URL: <http://trac.buildbot.net/ticket/1954#comment:2> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Wed May 11 16:01:34 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 11 May 2011 16:01:34 -0000 Subject: [Buildbot-commits] [Buildbot] #1780: Latent build slaves shut down uncleanly and get forgotten by the master In-Reply-To: <040.ea5c2cbbd82d21ecc7d22b950b6307bf@buildbot.net> References: <040.ea5c2cbbd82d21ecc7d22b950b6307bf@buildbot.net> Message-ID: <055.76253d6027e94f1fa125d77d36f0d0ee@buildbot.net> #1780: Latent build slaves shut down uncleanly and get forgotten by the master ---------------------------+-------------------- Reporter: jacobian | Owner: Type: defect | Status: new Priority: critical | Milestone: 0.8.4 Version: 0.8.3p1 | Resolution: Keywords: virtualization | ---------------------------+-------------------- Changes (by dustin): * cc: exarkun (added) -- Ticket URL: <http://trac.buildbot.net/ticket/1780#comment:9> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Wed May 11 16:32:45 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 11 May 2011 16:32:45 -0000 Subject: [Buildbot-commits] [Buildbot] #1780: Latent build slaves shut down uncleanly and get forgotten by the master In-Reply-To: <040.ea5c2cbbd82d21ecc7d22b950b6307bf@buildbot.net> References: <040.ea5c2cbbd82d21ecc7d22b950b6307bf@buildbot.net> Message-ID: <055.92336da72de1f07cfef5eb1823b89124@buildbot.net> #1780: Latent build slaves shut down uncleanly and get forgotten by the master ---------------------------+-------------------- Reporter: jacobian | Owner: Type: defect | Status: new Priority: critical | Milestone: 0.8.4 Version: 0.8.3p1 | Resolution: Keywords: virtualization | ---------------------------+-------------------- Comment (by exarkun): What if the master didn't shut down the slave at all as part of unsubstantiation? -- Ticket URL: <http://trac.buildbot.net/ticket/1780#comment:10> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Wed May 11 16:45:45 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 11 May 2011 16:45:45 -0000 Subject: [Buildbot-commits] [Buildbot] #1780: Latent build slaves shut down uncleanly and get forgotten by the master In-Reply-To: <040.ea5c2cbbd82d21ecc7d22b950b6307bf@buildbot.net> References: <040.ea5c2cbbd82d21ecc7d22b950b6307bf@buildbot.net> Message-ID: <055.3bb51cbb4f45746fc2c714f3427a49d2@buildbot.net> #1780: Latent build slaves shut down uncleanly and get forgotten by the master ---------------------------+-------------------- Reporter: jacobian | Owner: Type: defect | Status: new Priority: critical | Milestone: 0.8.4 Version: 0.8.3p1 | Resolution: Keywords: virtualization | ---------------------------+-------------------- Comment (by dustin): Neither graceful-shutdown nor disconnect it - just turn off the EC2 instance? That would work, too, and might be easier. -- Ticket URL: <http://trac.buildbot.net/ticket/1780#comment:11> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Wed May 11 17:13:02 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 11 May 2011 17:13:02 -0000 Subject: [Buildbot-commits] [Buildbot] #1955: Suboptimal default for submodules Message-ID: <041.8b7585719df8a41d43b4694a8ea41155@buildbot.net> #1955: Suboptimal default for submodules ----------------------+----------------------- Reporter: dabrahams | Owner: Type: undecided | Status: new Priority: trivial | Milestone: undecided Version: 0.8.3p1 | Keywords: git ----------------------+----------------------- In the FWIW department: It's too late to change this without breaking backward compatibility for a few projects out there, but IMO the default value of {{{submodules}}} for Git steps is poorly chosen. Seriously, who puts submodules in their project and then doesn't want them considered during testing? I'm certain that it happens, but I'm also certain that it's rare. -- Ticket URL: <http://trac.buildbot.net/ticket/1955> Buildbot <http://buildbot.net/> Buildbot: build/test automation From noreply at github.com Wed May 11 17:17:47 2011 From: noreply at github.com (noreply at github.com) Date: Wed, 11 May 2011 10:17:47 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] de168a: don't try to patch twisted.internet.process on win... Message-ID: <20110511171747.9C63E4252F@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: de168ab023b2c0769f15837959a2a5189269097e https://github.com/buildbot/buildbot/commit/de168ab023b2c0769f15837959a2a5189269097e Author: Dustin J. Mitchell <dustin at mozilla.com> Date: 2011-05-11 (Wed, 11 May 2011) Changed paths: M master/buildbot/monkeypatches/__init__.py M slave/buildslave/monkeypatches/__init__.py Log Message: ----------- don't try to patch twisted.internet.process on windows From nobody at buildbot.net Wed May 11 19:55:07 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 11 May 2011 19:55:07 -0000 Subject: [Buildbot-commits] [Buildbot] #1956: Can't cancel builds which haven't started. Message-ID: <042.2620a0c6a729c11b74b03738d3783611@buildbot.net> #1956: Can't cancel builds which haven't started. -----------------------+----------------------- Reporter: tom.prince | Owner: Type: undecided | Status: new Priority: major | Milestone: undecided Version: 0.8.3p1 | Keywords: -----------------------+----------------------- djmitche suggests this is due to having a single master. {{{ 2011-05-11 15:52:35-0400 [-] Cancelling <buildbot.process.buildrequest.BuildRequestControl instance at 0x3511cb0> 2011-05-11 15:52:35-0400 [-] while cancelling build request Traceback (most recent call last): File "/usr/lib/python2.7/threading.py", line 503, in __bootstrap self.__bootstrap_inner() File "/usr/lib/python2.7/threading.py", line 530, in __bootstrap_inner self.run() File "/usr/lib/python2.7/threading.py", line 483, in run self.__target(*self.__args, **self.__kwargs) --- <exception caught here> --- File "/usr/lib/python2.7/site- packages/twisted/python/threadpool.py", line 207, in _worker result = context.call(ctx, function, *args, **kwargs) File "/usr/lib/python2.7/site- packages/twisted/python/context.py", line 118, in callWithContext return self.currentContext().callWithContext(ctx, func, *args, **kw) File "/usr/lib/python2.7/site- packages/twisted/python/context.py", line 81, in callWithContext return func(*args,**kw) File "/Depot/BuildBot/bbot/lib/python2.7/site- packages/buildbot/db/pool.py", line 91, in thd rv = callable(conn, *args, **kwargs) File "/Depot/BuildBot/bbot/lib/python2.7/site- packages/buildbot/db/buildrequests.py", line 320, in thd raise NotClaimedError buildbot.db.buildrequests.NotClaimedError: }}} -- Ticket URL: <http://trac.buildbot.net/ticket/1956> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Wed May 11 23:37:10 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 11 May 2011 23:37:10 -0000 Subject: [Buildbot-commits] [Buildbot] #650: switch to CIA for IRC notifications In-Reply-To: <038.27337af0be6d219464bb7bf4ac3572dd@buildbot.net> References: <038.27337af0be6d219464bb7bf4ac3572dd@buildbot.net> Message-ID: <053.fc4f8f99824f14e8bc403e1c5f56d7cf@buildbot.net> #650: switch to CIA for IRC notifications -------------------+---------------------- Reporter: dustin | Owner: Type: task | Status: closed Priority: major | Milestone: ongoing Version: | Resolution: wontfix Keywords: | -------------------+---------------------- Comment (by Nicolas): [http://scanlime.org/2011/05/cia-vc-service-is-down-indefinitely/ CIA.vc service is down indefinitely] -- Ticket URL: <http://trac.buildbot.net/ticket/650#comment:3> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Wed May 11 23:42:11 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 11 May 2011 23:42:11 -0000 Subject: [Buildbot-commits] [Buildbot] #650: switch to CIA for IRC notifications In-Reply-To: <038.27337af0be6d219464bb7bf4ac3572dd@buildbot.net> References: <038.27337af0be6d219464bb7bf4ac3572dd@buildbot.net> Message-ID: <053.e0ad23466be88edad8fe0a7b61f4e9df@buildbot.net> #650: switch to CIA for IRC notifications -------------------+---------------------- Reporter: dustin | Owner: Type: task | Status: closed Priority: major | Milestone: ongoing Version: | Resolution: wontfix Keywords: | -------------------+---------------------- Comment (by dustin): Well, I guess we made the right call :) -- Ticket URL: <http://trac.buildbot.net/ticket/650#comment:4> Buildbot <http://buildbot.net/> Buildbot: build/test automation From noreply at github.com Thu May 12 03:48:55 2011 From: noreply at github.com (noreply at github.com) Date: Wed, 11 May 2011 20:48:55 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] a389b0: replace old LRUCache with a niftier AsyncLRUCache Message-ID: <20110512034855.D643242529@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: a389b086e65ac8107ae6fdd288dc51a9854a992c https://github.com/buildbot/buildbot/commit/a389b086e65ac8107ae6fdd288dc51a9854a992c Author: Dustin J. Mitchell <dustin at mozilla.com> Date: 2011-05-11 (Wed, 11 May 2011) Changed paths: M master/buildbot/test/unit/test_util.py A master/buildbot/test/unit/test_util_lru.py M master/buildbot/util/__init__.py A master/buildbot/util/lru.py Log Message: ----------- replace old LRUCache with a niftier AsyncLRUCache This AsyncLRUCache handles: * asynchronous fetches from the cache * batching concurrent fetching to avoid the dog-pile effect * using weak refs to "rescue" items expired from the cache but still in memory From nobody at buildbot.net Thu May 12 14:26:12 2011 From: nobody at buildbot.net (Buildbot) Date: Thu, 12 May 2011 14:26:12 -0000 Subject: [Buildbot-commits] [Buildbot] #1957: Expand blamelist only by 'interested users' that are relevant for the build. Message-ID: <041.c8c3a27c9095e765e20f8885cd5613d6@buildbot.net> #1957: Expand blamelist only by 'interested users' that are relevant for the build. ----------------------+------------------------------ Reporter: rgoergens | Owner: Type: undecided | Status: new Priority: major | Milestone: undecided Version: 0.8.3p1 | Keywords: filter blamelist ----------------------+------------------------------ We have the issue that we just want to notify those users with an blame mail whose change led to an build, users whose changes has been filtered out through the Scheduler class via 'fileIsImportant' or an 'ChangeFilter' should not be in the blame list. -- Ticket URL: <http://trac.buildbot.net/ticket/1957> Buildbot <http://buildbot.net/> Buildbot: build/test automation From noreply at github.com Thu May 12 15:36:52 2011 From: noreply at github.com (noreply at github.com) Date: Thu, 12 May 2011 08:36:52 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] a044ca: Fixed buildmaster's init-script "reload" command. Message-ID: <20110512153652.37F5142502@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: a044ca99f2ca5b3b83cfa222b224656928122c41 https://github.com/buildbot/buildbot/commit/a044ca99f2ca5b3b83cfa222b224656928122c41 Author: Stanislav Kupryakhin <skupryakhin at croco3.(none)> Date: 2011-05-12 (Thu, 12 May 2011) Changed paths: M master/contrib/init-scripts/buildmaster.init.sh Log Message: ----------- Fixed buildmaster's init-script "reload" command. Commit: 84fb187808f25e76666eed2d8c3f2c840747f322 https://github.com/buildbot/buildbot/commit/84fb187808f25e76666eed2d8c3f2c840747f322 Author: Dustin J. Mitchell <dustin at mozilla.com> Date: 2011-05-12 (Thu, 12 May 2011) Changed paths: M master/contrib/init-scripts/buildmaster.init.sh Log Message: ----------- Merge branch 'myfixes' of git://github.com/skupr/buildbot * 'myfixes' of git://github.com/skupr/buildbot: Fixed buildmaster's init-script "reload" command. Compare: https://github.com/buildbot/buildbot/compare/a389b08...84fb187 From nobody at buildbot.net Thu May 12 15:41:06 2011 From: nobody at buildbot.net (Buildbot) Date: Thu, 12 May 2011 15:41:06 -0000 Subject: [Buildbot-commits] [Buildbot] #1957: Expand blamelist only by 'interested users' that are relevant for the build. In-Reply-To: <041.c8c3a27c9095e765e20f8885cd5613d6@buildbot.net> References: <041.c8c3a27c9095e765e20f8885cd5613d6@buildbot.net> Message-ID: <056.a98ef85e3172ab46160941ffeef4ee15@buildbot.net> #1957: Expand blamelist only by 'interested users' that are relevant for the build. ------------------------+-------------------- Reporter: rgoergens | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.3p1 | Resolution: Keywords: | ------------------------+-------------------- Changes (by dustin): * cc: redheadphones (added) * keywords: filter blamelist => * type: undecided => enhancement * milestone: undecided => 0.8.+ Comment: copying redheadphones, who's working on improving the support for user identity in Buildbot. -- Ticket URL: <http://trac.buildbot.net/ticket/1957#comment:1> Buildbot <http://buildbot.net/> Buildbot: build/test automation From noreply at github.com Thu May 12 15:56:45 2011 From: noreply at github.com (noreply at github.com) Date: Thu, 12 May 2011 08:56:45 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 992cd8: shorten LRU queue more aggressively; 100% coverage... Message-ID: <20110512155645.C43E4423E3@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 992cd82cc1169b83c5b738d6541fae037ceb69dd https://github.com/buildbot/buildbot/commit/992cd82cc1169b83c5b738d6541fae037ceb69dd Author: Dustin J. Mitchell <dustin at mozilla.com> Date: 2011-05-12 (Thu, 12 May 2011) Changed paths: M master/buildbot/test/unit/test_util_lru.py M master/buildbot/util/lru.py M master/docs/developer.texinfo Log Message: ----------- shorten LRU queue more aggressively; 100% coverage of lru.py Also update the developer docs. From nobody at buildbot.net Fri May 13 00:37:38 2011 From: nobody at buildbot.net (Buildbot) Date: Fri, 13 May 2011 00:37:38 -0000 Subject: [Buildbot-commits] [Buildbot] #1780: Latent build slaves shut down uncleanly and get forgotten by the master In-Reply-To: <040.ea5c2cbbd82d21ecc7d22b950b6307bf@buildbot.net> References: <040.ea5c2cbbd82d21ecc7d22b950b6307bf@buildbot.net> Message-ID: <055.d97622d59599acdd8df4a0f1dbd75a00@buildbot.net> #1780: Latent build slaves shut down uncleanly and get forgotten by the master ---------------------------+-------------------- Reporter: jacobian | Owner: Type: defect | Status: new Priority: critical | Milestone: 0.8.4 Version: 0.8.3p1 | Resolution: Keywords: virtualization | ---------------------------+-------------------- Comment (by exarkun): Eventually (when I shut the master down) this appeared in my logs as well: {{{ 2011-05-12 20:34:37-0400 [-] Unhandled error in Deferred: 2011-05-12 20:34:37-0400 [-] Unhandled Error Traceback (most recent call last): File "/usr/lib/python2.5/threading.py", line 462, in __bootstrap self.__bootstrap_inner() File "/usr/lib/python2.5/threading.py", line 486, in __bootstrap_inner self.run() File "/usr/lib/python2.5/threading.py", line 446, in run self.__target(*self.__args, **self.__kwargs) --- <exception caught here> --- File "/srv/bb- master/Projects/Twisted/trunk/twisted/python/threadpool.py", line 210, in _worker result = context.call(ctx, function, *args, **kwargs) File "/srv/bb- master/Projects/Twisted/trunk/twisted/python/context.py", line 59, in callWithContext return self.currentContext().callWithContext(ctx, func, *args, **kw) File "/srv/bb- master/Projects/Twisted/trunk/twisted/python/context.py", line 37, in callWithContext return func(*args,**kw) File "/srv/bb-master/.local/lib/python2.5/site- packages/buildbot-0.8.2-py2.5.egg/buildbot/ec2buildslave.py", line 260, in _stop_instance instance.stop() File "build/bdist.linux-i686/egg/boto/ec2/instance.py", line 244, in stop File "build/bdist.linux-i686/egg/boto/ec2/connection.py", line 610, in stop_instances File "build/bdist.linux-i686/egg/boto/connection.py", line 595, in get_list boto.exception.EC2ResponseError: EC2ResponseError: 400 Bad Request <?xml version="1.0" encoding="UTF-8"?> <Response><Errors><Error><Code>UnsupportedOperation</Code><Message>The instance 'i-f6c3dc99' does not have an 'ebs' root device type and cannot be stopped.</Message></Error></Errors><RequestID>18ab3806-62cb- 4de7-a4e1-723d712f8340</RequestID></Response> }}} -- Ticket URL: <http://trac.buildbot.net/ticket/1780#comment:12> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Fri May 13 01:08:14 2011 From: nobody at buildbot.net (Buildbot) Date: Fri, 13 May 2011 01:08:14 -0000 Subject: [Buildbot-commits] [Buildbot] #1958: Monkey-patch Twisted memory leak Message-ID: <038.72b04799a36bfce9741b72578a235918@buildbot.net> #1958: Monkey-patch Twisted memory leak ------------------------+------------------------- Reporter: dustin | Owner: dustin Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: master | Keywords: performance ------------------------+------------------------- PB has a leak: http://twistedmatrix.com/trac/ticket/5079 We should add that monkey-patch using Buildbot, once it's accepted in Twisted. -- Ticket URL: <http://trac.buildbot.net/ticket/1958> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Fri May 13 18:12:27 2011 From: nobody at buildbot.net (Buildbot) Date: Fri, 13 May 2011 18:12:27 -0000 Subject: [Buildbot-commits] [Buildbot] #1959: svn sourcestep mode="copy" always_purge=True fails with externals. Message-ID: <038.636b061c8766d32821938963a900ef49@buildbot.net> #1959: svn sourcestep mode="copy" always_purge=True fails with externals. ----------------------+----------------------- Reporter: tfogal | Owner: Type: undecided | Status: new Priority: minor | Milestone: undecided Version: 0.8.1 | Keywords: ----------------------+----------------------- The step: {{{ tvk.addStep(SVN(svnurl=tuvok_root, mode="copy", always_purge=True, alwaysUseLatest=True)) }}} is failing repeatedly in the presence of repositories with svn:externals. The issue appears to be that a pre-setup phase deletes the entire "build" directory (via fork-exec 'rm'), and then a later step attempts to delete each external. Of course, the external is a subdirectory of the "build" directory and it therefore no longer exists. Master version: {{{ iv3d at buildbot $ buildbot --version Buildbot version: 0.8.1rc3-785-g8147f92 Twisted version: 10.0.0 }}} Slave version: {{{ tfogal at cibc-rd6 $ buildslave --version Buildslave version: 0.8.1 Twisted version: 10.0.0 }}} {{{ starting svn operation rm -rf /scratch/iv3d/tvk-ubuntu-9.10-amd64/build in dir /scratch/iv3d/tvk-ubuntu-9.10-amd64 (timeout 1200 secs) watching logfiles {} argv: ['rm', '-rf', '/scratch/iv3d/tvk-ubuntu-9.10-amd64/build'] environment: DISPLAY=:0 HOME=/scratch/iv3d PATH=/bin:/home/sci/tfogal/cibc-rd6/bin:/usr/local/bin:/usr/bin PWD=/scratch/iv3d/tvk-ubuntu-9.10-amd64 PYTHONPATH=/home/sci/tfogal/cibc-rd6/lib64/python2.6/site- packages:/home/sci/tfogal/cibc-rd6/lib/python2.6/site-packages: closing stdin using PTY: False elapsedTime=0.012536 /usr/bin/svn status --non-interactive --no-auth-cache --xml --no-ignore in dir /scratch/iv3d/tvk-ubuntu-9.10-amd64/source (timeout 1200 secs) watching logfiles {} argv: ['/usr/bin/svn', 'status', '--non-interactive', '--no-auth-cache', '--xml', '--no-ignore'] environment: DISPLAY=:0 HOME=/scratch/iv3d LC_MESSAGES=C PATH=/bin:/home/sci/tfogal/cibc-rd6/bin:/usr/local/bin:/usr/bin PWD=/scratch/iv3d/tvk-ubuntu-9.10-amd64/source PYTHONPATH=/home/sci/tfogal/cibc-rd6/lib64/python2.6/site- packages:/home/sci/tfogal/cibc-rd6/lib/python2.6/site- packages::/home/sci/tfogal/cibc-rd6/lib64/python2.6/site- packages:/home/sci/tfogal/cibc-rd6/lib/python2.6/site-packages: closing stdin using PTY: False elapsedTime=0.036347 /scratch/iv3d/tvk-ubuntu-9.10-amd64/build/Basics remoteFailed: [Failure instance: Traceback from remote host -- Traceback (most recent call last): File "/home/sci/tfogal/cibc-rd6/lib/python2.6/site- packages/buildslave/commands/base.py", line 169, in processEnded self.command.finished(sig, rc) File "/home/sci/tfogal/cibc-rd6/lib/python2.6/site- packages/buildslave/commands/base.py", line 703, in finished d.callback(rc) File "/usr/lib/python2.6/dist-packages/twisted/internet/defer.py", line 280, in callback self._startRunCallbacks(result) File "/usr/lib/python2.6/dist-packages/twisted/internet/defer.py", line 354, in _startRunCallbacks self._runCallbacks() --- <exception caught here> --- File "/usr/lib/python2.6/dist-packages/twisted/internet/defer.py", line 371, in _runCallbacks self.result = callback(self.result, *args, **kw) File "/home/sci/tfogal/cibc-rd6/lib/python2.6/site- packages/buildslave/commands/vcs.py", line 672, in _purgeAndUpdate2 rmdirRecursive(filepath) File "/usr/lib/python2.6/shutil.py", line 208, in rmtree onerror(os.listdir, path, sys.exc_info()) File "/usr/lib/python2.6/shutil.py", line 206, in rmtree names = os.listdir(path) exceptions.OSError: [Errno 2] No such file or directory: '/scratch/iv3d /tvk-ubuntu-9.10-amd64/build/Basics' ] }}} The 'svn status' command produces some XML if I run it manually: {{{ tfogal at cibc-rd6 $ /usr/bin/svn status --non-interactive --no-auth-cache --xml --no-ignore <?xml version="1.0"?> <status> <target path="."> <entry path="Basics"> <wc-status props="none" item="external"> </wc-status> </entry> <entry path="IO"> <wc-status props="none" item="external"> </wc-status> </entry> <entry path=".buildbot-sourcedata"> <wc-status props="none" item="unversioned"> </wc-status> </entry> </target> </status> }}} As can be seen from the XML, the one line of real, actual output that you can see in the first paste: '{{{/scratch/iv3d/tvk-ubuntu-9.10-amd64/build/Basics}}}' happens to be an svn external directory. -- Ticket URL: <http://trac.buildbot.net/ticket/1959> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Fri May 13 18:21:37 2011 From: nobody at buildbot.net (Buildbot) Date: Fri, 13 May 2011 18:21:37 -0000 Subject: [Buildbot-commits] [Buildbot] #1959: svn sourcestep mode="copy" always_purge=True fails with externals. In-Reply-To: <038.636b061c8766d32821938963a900ef49@buildbot.net> References: <038.636b061c8766d32821938963a900ef49@buildbot.net> Message-ID: <053.3703cfb5f5cbedb9ead175ddf76b4c93@buildbot.net> #1959: svn sourcestep mode="copy" always_purge=True fails with externals. ----------------------+------------------------ Reporter: tfogal | Owner: Type: undecided | Status: new Priority: minor | Milestone: undecided Version: 0.8.1 | Resolution: Keywords: | ----------------------+------------------------ Comment (by tfogal): Digging a bit deeper, it appears that the issue is that the method `getUnversionedFiles` is yielding filenames which have `item` equal to `"external"`. There is an explicit check for this in the method, but I guess it must not be working correctly. -- Ticket URL: <http://trac.buildbot.net/ticket/1959#comment:1> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Fri May 13 18:52:05 2011 From: nobody at buildbot.net (Buildbot) Date: Fri, 13 May 2011 18:52:05 -0000 Subject: [Buildbot-commits] [Buildbot] #1960: upgrade-master fails when upgrading from pre-db_url configs Message-ID: <038.e5bd2a6c902b3a3de22e69548e0bc0e5@buildbot.net> #1960: upgrade-master fails when upgrading from pre-db_url configs ----------------------+----------------------- Reporter: tfogal | Owner: Type: undecided | Status: new Priority: major | Milestone: undecided Version: master | Keywords: ----------------------+----------------------- b105501c1bf8d730eb9b06cbdda521f01a70a292 introduced checks for `db_url`, but in doing so it: {{{ def check_db_url(config): if expected_db_url and config['db_url'] != expected_db_url: raise ValueError("c['db_url'] in the config file ('%s') does" " not match '%s'; please edit the configuration" " file before upgrading." % (config['db_url'], expected_db_url)) }}} The `config['db_url']` part raises a `KeyError` exception if the master.cfg is from a version which predates `db_url`. The solution is simply to add `c['db_url'] = "sqlite://state.sqlite"` to the configuration. It would be nice if upgrade-master could: see that `KeyError` is happening, notice that `state.sqlite` exists, and then just add the needed line to the configuration. -- Ticket URL: <http://trac.buildbot.net/ticket/1960> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Fri May 13 18:53:37 2011 From: nobody at buildbot.net (Buildbot) Date: Fri, 13 May 2011 18:53:37 -0000 Subject: [Buildbot-commits] [Buildbot] #1960: upgrade-master fails when upgrading from pre-db_url configs In-Reply-To: <038.e5bd2a6c902b3a3de22e69548e0bc0e5@buildbot.net> References: <038.e5bd2a6c902b3a3de22e69548e0bc0e5@buildbot.net> Message-ID: <053.475641c52cad3ce5e5fd957f092847bd@buildbot.net> #1960: upgrade-master fails when upgrading from pre-db_url configs ----------------------+------------------------ Reporter: tfogal | Owner: Type: undecided | Status: new Priority: major | Milestone: undecided Version: master | Resolution: Keywords: | ----------------------+------------------------ Comment (by tfogal): Err, after reading djmitche's IRC message, it's probably a better idea to set `c['db_url']` to `"sqlite://state.sqlite"` at initialization time, and rely on the reading of the configuration file to overwrite this if it wants. -- Ticket URL: <http://trac.buildbot.net/ticket/1960#comment:1> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Fri May 13 21:12:26 2011 From: nobody at buildbot.net (Buildbot) Date: Fri, 13 May 2011 21:12:26 -0000 Subject: [Buildbot-commits] [Buildbot] #1959: svn sourcestep mode="copy" always_purge=True fails with externals. In-Reply-To: <038.636b061c8766d32821938963a900ef49@buildbot.net> References: <038.636b061c8766d32821938963a900ef49@buildbot.net> Message-ID: <053.6518fc709e510089409a372d9055caca@buildbot.net> #1959: svn sourcestep mode="copy" always_purge=True fails with externals. ----------------------+------------------------ Reporter: tfogal | Owner: Type: undecided | Status: new Priority: minor | Milestone: undecided Version: 0.8.1 | Resolution: Keywords: | ----------------------+------------------------ Comment (by tfogal): I applied this patch: {{{ for entry in result_xml.getElementsByTagName('entry'): (wc_status,) = entry.getElementsByTagName('wc-status') + log.msg("item attr: %s" % wc_status.getAttribute('item')) if wc_status.getAttribute('item') == 'external': continue if wc_status.getAttribute('item') == 'missing': }}} and didn't see a "item attr" message in my twistd.logs on either the master or slave. I guess the XML is somehow getting parsed somewhere else?? -- Ticket URL: <http://trac.buildbot.net/ticket/1959#comment:2> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Sat May 14 04:31:57 2011 From: nobody at buildbot.net (Buildbot) Date: Sat, 14 May 2011 04:31:57 -0000 Subject: [Buildbot-commits] [Buildbot] #1960: upgrade-master fails when upgrading from pre-db_url configs In-Reply-To: <038.e5bd2a6c902b3a3de22e69548e0bc0e5@buildbot.net> References: <038.e5bd2a6c902b3a3de22e69548e0bc0e5@buildbot.net> Message-ID: <053.d5fbefa5711cbdd86ac86612985d07e8@buildbot.net> #1960: upgrade-master fails when upgrading from pre-db_url configs ----------------------+------------------------ Reporter: tfogal | Owner: Type: undecided | Status: new Priority: major | Milestone: undecided Version: master | Resolution: Keywords: | ----------------------+------------------------ Comment (by dustin): Ah, yes, I orginally wrote this to look at master.db_url, which contains the default value if it is not specified in the config dictionary. I'll add some extra logic here. -- Ticket URL: <http://trac.buildbot.net/ticket/1960#comment:2> Buildbot <http://buildbot.net/> Buildbot: build/test automation From noreply at github.com Sat May 14 04:38:14 2011 From: noreply at github.com (noreply at github.com) Date: Fri, 13 May 2011 21:38:14 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 05218f: Accomodate default db_url in upgrade-master Message-ID: <20110514043814.DC77142420@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 05218fb0b7085ea67c9d875883f15a9717282e1e https://github.com/buildbot/buildbot/commit/05218fb0b7085ea67c9d875883f15a9717282e1e Author: Dustin J. Mitchell <dustin at mozilla.com> Date: 2011-05-13 (Fri, 13 May 2011) Changed paths: M master/buildbot/scripts/runner.py Log Message: ----------- Accomodate default db_url in upgrade-master Fixes #1960. From nobody at buildbot.net Sat May 14 04:38:20 2011 From: nobody at buildbot.net (Buildbot) Date: Sat, 14 May 2011 04:38:20 -0000 Subject: [Buildbot-commits] [Buildbot] #1960: upgrade-master fails when upgrading from pre-db_url configs In-Reply-To: <038.e5bd2a6c902b3a3de22e69548e0bc0e5@buildbot.net> References: <038.e5bd2a6c902b3a3de22e69548e0bc0e5@buildbot.net> Message-ID: <053.afc27b67cb40bdf791409dba791ce9e3@buildbot.net> #1960: upgrade-master fails when upgrading from pre-db_url configs ----------------------+------------------------ Reporter: tfogal | Owner: Type: undecided | Status: closed Priority: major | Milestone: undecided Version: master | Resolution: fixed Keywords: | ----------------------+------------------------ Changes (by Dustin J. Mitchell): * status: new => closed * resolution: => fixed Comment: Accomodate default db_url in upgrade-master Fixes #1960. Changeset: 05218fb0b7085ea67c9d875883f15a9717282e1e -- Ticket URL: <http://trac.buildbot.net/ticket/1960#comment:3> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Sat May 14 04:40:10 2011 From: nobody at buildbot.net (Buildbot) Date: Sat, 14 May 2011 04:40:10 -0000 Subject: [Buildbot-commits] [Buildbot] #1959: svn sourcestep mode="copy" always_purge=True fails with externals. In-Reply-To: <038.636b061c8766d32821938963a900ef49@buildbot.net> References: <038.636b061c8766d32821938963a900ef49@buildbot.net> Message-ID: <053.e83c1845708803e25c28e5c7575c4f78@buildbot.net> #1959: svn sourcestep mode="copy" always_purge=True fails with externals. -------------------+-------------------- Reporter: tfogal | Owner: Type: defect | Status: new Priority: minor | Milestone: 0.8.+ Version: 0.8.1 | Resolution: Keywords: svn | -------------------+-------------------- Changes (by dustin): * cc: in3xes (added) * keywords: => svn * type: undecided => defect * milestone: undecided => 0.8.+ -- Ticket URL: <http://trac.buildbot.net/ticket/1959#comment:3> Buildbot <http://buildbot.net/> Buildbot: build/test automation From noreply at github.com Sat May 14 14:59:03 2011 From: noreply at github.com (noreply at github.com) Date: Sat, 14 May 2011 07:59:03 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] d71942: Make the render method of WithProperties take a mo... Message-ID: <20110514145903.AB0244243E@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: d7194207152f9247f965436a1a58cd5449ba7b12 https://github.com/buildbot/buildbot/commit/d7194207152f9247f965436a1a58cd5449ba7b12 Author: Tom Prince <tom.prince at ualberta.net> Date: 2011-05-13 (Fri, 13 May 2011) Changed paths: M master/buildbot/process/properties.py Log Message: ----------- Make the render method of WithProperties take a more sensible argument. The purpose of PropertyMap is to handle the temporary values from WithProperties, as well as well as shell-like default values. For somebody implementing a different render, it makes more sense to receive the Properties object, than the PropertyMap. Signed-off-by: Tom Prince <tom.prince at ualberta.net> Commit: 7381723a9bdb3a49d07fa3e99c53efefc51a1f45 https://github.com/buildbot/buildbot/commit/7381723a9bdb3a49d07fa3e99c53efefc51a1f45 Author: Tom Prince <tom.prince at ualberta.net> Date: 2011-05-13 (Fri, 13 May 2011) Changed paths: M master/buildbot/interfaces.py M master/buildbot/process/properties.py Log Message: ----------- Change Properties to use IRenderable for rendering properties. This removes the hard-coded instance checks and allows the easy addition of additional renderers. Signed-off-by: Tom Prince <tom.prince at ualberta.net> Commit: c6db109de215a75db899d920c479daf11edfd869 https://github.com/buildbot/buildbot/commit/c6db109de215a75db899d920c479daf11edfd869 Author: Tom Prince <tom.prince at ualberta.net> Date: 2011-05-14 (Sat, 14 May 2011) Changed paths: M master/buildbot/process/properties.py M master/buildbot/test/unit/test_process_properties.py M master/docs/cfg-buildsteps.texinfo Log Message: ----------- Add simple IRenderable for getting a single property unchanged. Signed-off-by: Tom Prince <tom.prince at ualberta.net> Commit: 3bd32cc56b86cfd4b027e13978aff2e59ef50901 https://github.com/buildbot/buildbot/commit/3bd32cc56b86cfd4b027e13978aff2e59ef50901 Author: Tom Prince <tom.prince at ualberta.net> Date: 2011-05-14 (Sat, 14 May 2011) Changed paths: M master/buildbot/steps/source.py Log Message: ----------- Remove restrictive instance check in computeRepositoryURL. Since the set of objects that can be rendered is open-ended, don't use a restrictive instance test before hand. Signed-off-by: Tom Prince <tom.prince at ualberta.net> Commit: 4907868493c426e109183ba4329516349c9e22fc https://github.com/buildbot/buildbot/commit/4907868493c426e109183ba4329516349c9e22fc Author: Tom Prince <tom.prince at ualberta.net> Date: 2011-05-14 (Sat, 14 May 2011) Changed paths: M master/docs/cfg-buildsteps.texinfo Log Message: ----------- Reorganize WithProperties documentation to prefer dict syntax. Signed-off-by: Tom Prince <tom.prince at ualberta.net> Commit: 4af7d73b0fddd76f652d866c05c3ae61199cddd4 https://github.com/buildbot/buildbot/commit/4af7d73b0fddd76f652d866c05c3ae61199cddd4 Author: Dustin J. Mitchell <dustin at mozilla.com> Date: 2011-05-14 (Sat, 14 May 2011) Changed paths: M master/buildbot/interfaces.py M master/buildbot/process/properties.py M master/buildbot/steps/source.py M master/buildbot/test/unit/test_process_properties.py M master/docs/cfg-buildsteps.texinfo Log Message: ----------- Merge branch 'prop' of git://github.com/tomprince/buildbot * 'prop' of git://github.com/tomprince/buildbot: Reorganize WithProperties documentation to prefer dict syntax. Remove restrictive instance check in computeRepositoryURL. Add simple IRenderable for getting a single property unchanged. Change Properties to use IRenderable for rendering properties. Make the render method of WithProperties take a more sensible argument. Commit: 0dc8614248407f7163672ea325ee691897a09f9f https://github.com/buildbot/buildbot/commit/0dc8614248407f7163672ea325ee691897a09f9f Author: Dustin J. Mitchell <dustin at mozilla.com> Date: 2011-05-14 (Sat, 14 May 2011) Changed paths: M master/docs/cfg-buildsteps.texinfo Log Message: ----------- docs typos Compare: https://github.com/buildbot/buildbot/compare/05218fb...0dc8614 From nobody at buildbot.net Sat May 14 15:04:54 2011 From: nobody at buildbot.net (Buildbot) Date: Sat, 14 May 2011 15:04:54 -0000 Subject: [Buildbot-commits] [Buildbot] #1961: Better monkey-patching architecture Message-ID: <038.c032a31f9694c6aa2b1e0cbdb10bab40@buildbot.net> #1961: Better monkey-patching architecture ------------------------+-------------------- Reporter: dustin | Owner: dustin Type: enhancement | Status: new Priority: major | Milestone: 0.8.4 Version: 0.8.3p1 | Keywords: ------------------------+-------------------- We currently monkey-patch Twisted from {{{buildbot/__init__.py}}}, which gets imported during setup.py, when Twisted may not be available. Also, logging is not available at that point, so any messages about success or failure are not seen by the user. We should try to do this a little bit later. A good option is {{{BuildMaster.startProcess}}}, but maybe that's too late? -- Ticket URL: <http://trac.buildbot.net/ticket/1961> Buildbot <http://buildbot.net/> Buildbot: build/test automation From noreply at github.com Sat May 14 15:27:05 2011 From: noreply at github.com (noreply at github.com) Date: Sat, 14 May 2011 08:27:05 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] eab918: Make Property use default for false property value... Message-ID: <20110514152705.9DC3242491@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: eab918dfd2d7cfa812358b52252756665dc7d001 https://github.com/buildbot/buildbot/commit/eab918dfd2d7cfa812358b52252756665dc7d001 Author: Tom Prince <tom.prince at ualberta.net> Date: 2011-05-14 (Sat, 14 May 2011) Changed paths: M master/buildbot/process/properties.py M master/buildbot/test/unit/test_process_properties.py M master/docs/cfg-buildsteps.texinfo Log Message: ----------- Make Property use default for false property values. This behaviour can be turned off with defaultWhenFalse=False Signed-off-by: Tom Prince <tom.prince at ualberta.net> Commit: 510b42662bf8ba38f3d91ba74a4049c2eb14d625 https://github.com/buildbot/buildbot/commit/510b42662bf8ba38f3d91ba74a4049c2eb14d625 Author: Dustin J. Mitchell <dustin at v.igoro.us> Date: 2011-05-14 (Sat, 14 May 2011) Changed paths: M master/buildbot/process/properties.py M master/buildbot/test/unit/test_process_properties.py M master/docs/cfg-buildsteps.texinfo Log Message: ----------- Merge pull request #126 from tomprince/prop Make Property use default for false property values. Compare: https://github.com/buildbot/buildbot/compare/0dc8614...510b426 From nobody at buildbot.net Sun May 15 03:24:56 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 15 May 2011 03:24:56 -0000 Subject: [Buildbot-commits] [Buildbot] #1962: Source steps should take an env paramater. Message-ID: <042.bb3f08bde133c0fe0588df258091dcbb@buildbot.net> #1962: Source steps should take an env paramater. ------------------------+----------------------- Reporter: tom.prince | Owner: Type: enhancement | Status: new Priority: minor | Milestone: undecided Version: 0.8.3p1 | Keywords: source ------------------------+----------------------- -- Ticket URL: <http://trac.buildbot.net/ticket/1962> Buildbot <http://buildbot.net/> Buildbot: build/test automation From noreply at github.com Sun May 15 04:04:38 2011 From: noreply at github.com (noreply at github.com) Date: Sat, 14 May 2011 21:04:38 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 6a655c: Add RemoveDirectory build step. Message-ID: <20110515040438.F3BAF42375@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 6a655c7eabe3594a6e550cfcdb7641561516dc0e https://github.com/buildbot/buildbot/commit/6a655c7eabe3594a6e550cfcdb7641561516dc0e Author: Tom Prince <tom.prince at ualberta.net> Date: 2011-05-14 (Sat, 14 May 2011) Changed paths: M master/buildbot/steps/slave.py Log Message: ----------- Add RemoveDirectory build step. Signed-off-by: Tom Prince <tom.prince at ualberta.net> Commit: 828fe1a52c429750748a18164b598ba74028d7ad https://github.com/buildbot/buildbot/commit/828fe1a52c429750748a18164b598ba74028d7ad Author: Tom Prince <tom.prince at ualberta.net> Date: 2011-05-14 (Sat, 14 May 2011) Changed paths: M master/docs/cfg-buildsteps.texinfo Log Message: ----------- Make the documentation mention the defaults for timeout and maxTime. Signed-off-by: Tom Prince <tom.prince at ualberta.net> Commit: 0ad353afa1d0549d4c9a9d7779b3cc657ebd78ba https://github.com/buildbot/buildbot/commit/0ad353afa1d0549d4c9a9d7779b3cc657ebd78ba Author: Tom Prince <tom.prince at ualberta.net> Date: 2011-05-14 (Sat, 14 May 2011) Changed paths: M master/docs/cfg-buildsteps.texinfo Log Message: ----------- Document RemoveDirectory build step. Signed-off-by: Tom Prince <tom.prince at ualberta.net> Commit: 2bcd3ce392b7241ba03fbdd87dc56d4adc21622a https://github.com/buildbot/buildbot/commit/2bcd3ce392b7241ba03fbdd87dc56d4adc21622a Author: Dustin J. Mitchell <dustin at mozilla.com> Date: 2011-05-14 (Sat, 14 May 2011) Changed paths: M master/buildbot/steps/slave.py M master/docs/cfg-buildsteps.texinfo Log Message: ----------- Merge branch 'master' of git://github.com/tomprince/buildbot * 'master' of git://github.com/tomprince/buildbot: Document RemoveDirectory build step. Make the documentation mention the defaults for timeout and maxTime. Add RemoveDirectory build step. Commit: 2c27932fb2a17a34bf8cab4a606eb937500bffcf https://github.com/buildbot/buildbot/commit/2c27932fb2a17a34bf8cab4a606eb937500bffcf Author: Dustin J. Mitchell <dustin at mozilla.com> Date: 2011-05-14 (Sat, 14 May 2011) Changed paths: M master/docs/cfg-buildsteps.texinfo Log Message: ----------- fix docs sectioning Compare: https://github.com/buildbot/buildbot/compare/510b426...2c27932 From nobody at buildbot.net Sun May 15 09:23:52 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 15 May 2011 09:23:52 -0000 Subject: [Buildbot-commits] [Buildbot] #1963: FileUpload creates truncated file when buildslave is not on localhost Message-ID: <038.d8aba18af3dd124e6fb92915e876c160@buildbot.net> #1963: FileUpload creates truncated file when buildslave is not on localhost ----------------------+----------------------- Reporter: landry | Owner: Type: undecided | Status: new Priority: major | Milestone: undecided Version: 0.8.3p1 | Keywords: ----------------------+----------------------- I'm getting a strange issue running a buildbot for mozilla on OpenBSD. After a build, i'd like to upload the resulting package from the buildslave to the buildmaster, it works fine if the slave (amd64) is local, but generates a 14-bytes truncated file if the slave is remote (sparc64) Here's my master.cfg snippet : {{{ factory.addStep(SetProperty(name="get package name", command="find objdir/ -name *.tar.bz2 -exec basename {} \;", property='package_name')) factory.addStep(SetProperty(name="get package path", command="find objdir/ -name *.tar.bz2", property='package_path')) factory.addStep(FileUpload(slavesrc=WithProperties("%(package_path)s"), masterdest= WithProperties("public_html/builds/%(package_name)s") )) }}} You can see the files here : http://buildbot.rhaalovely.net/builds/ The buildmaster twistd.log shows nothing strange : {{{ 2011-05-15 10:07:24+0200 [-] FileUpload started, from slave 'objdir/dist/firefox-5.0a2.en-US.openbsd4.9-sparc64.tar.bz2' to master 'public_html/builds/firefox-5.0a2.en-US .openbsd4.9-sparc64.tar.bz2' 2011-05-15 10:07:24+0200 [-] <buildbot.steps.transfer.StatusRemoteCommand instance at 0x20ccc7878>: RemoteCommand.run [1018] 2011-05-15 10:07:24+0200 [-] releaseLocks(<buildbot.steps.transfer.FileUpload instance at 0x20f197cb0>): [] 2011-05-15 10:07:24+0200 [-] step 'upload_1' complete: success }}} But the file is truncated : {{{ # file //var/buildbot/public_html/builds/firefox-5* //var/buildbot/public_html/builds/firefox-5.0a2.en- US.openbsd4.9-sparc64.tar.bz2: bzip2 compressed data, block size = 900k //var/buildbot/public_html/builds/firefox-5.0a2.en- US.openbsd4.9-x86_64.tar.bz2: bzip2 compressed data, block size = 900k # ls -l //var/buildbot/public_html/builds/firefox-5* -rw------- 1 _buildbot _buildbot 14 May 15 10:07 //var/buildbot/public_html/builds/firefox-5.0a2.en- US.openbsd4.9-sparc64.tar.bz2 -rw------- 1 _buildbot _buildbot 17278587 May 15 05:25 //var/buildbot/public_html/builds/firefox-5.0a2.en- US.openbsd4.9-x86_64.tar.bz2 #tar tzf /var/buildbot/public_html/builds/firefox-5.0a2.en- US.openbsd4.9-sparc64.tar.bz2 gzip: stdin: unrecognized file format tar: End of archive volume 1 reached tar: Sorry, unable to determine archive format. }}} As a detail, 'objdir' path for the SetProperty call on both slaves is a symlink. Could it be related ? Or arch-related ? {{{ # ls -l /var/buildslave/mozilla-aurora-sparc64/build/objdir lrwxrwxrwx 1 root _buildslave 30 May 7 13:12 /var/buildslave/mozilla- aurora-sparc64/build/objdir -> obj-sparc64-unknown-openbsd4.9 }}} How can i debug that issue ? -- Ticket URL: <http://trac.buildbot.net/ticket/1963> Buildbot <http://buildbot.net/> Buildbot: build/test automation From noreply at github.com Mon May 16 21:55:39 2011 From: noreply at github.com (noreply at github.com) Date: Mon, 16 May 2011 14:55:39 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 85cc5a: Fix test_steps_source_Source to actually use WithP... Message-ID: <20110516215539.2A07942546@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 85cc5ab58e1e5ade71528e919ee8db5b969ac94b https://github.com/buildbot/buildbot/commit/85cc5ab58e1e5ade71528e919ee8db5b969ac94b Author: Tom Prince <tom.prince at ualberta.net> Date: 2011-05-16 (Mon, 16 May 2011) Changed paths: M master/buildbot/test/unit/test_steps_source_Source.py Log Message: ----------- Fix test_steps_source_Source to actually use WithProperites. The original code faked it by pretending strings were WithProperty instances. Signed-off-by: Tom Prince <tom.prince at ualberta.net> Commit: 5bb89f908f17ced7f0112101393d8f500b7e71ab https://github.com/buildbot/buildbot/commit/5bb89f908f17ced7f0112101393d8f500b7e71ab Author: Dustin J. Mitchell <dustin at mozilla.com> Date: 2011-05-16 (Mon, 16 May 2011) Changed paths: M master/buildbot/test/unit/test_steps_source_Source.py Log Message: ----------- Merge branch 'master' of git://github.com/tomprince/buildbot * 'master' of git://github.com/tomprince/buildbot: Fix test_steps_source_Source to actually use WithProperites. Compare: https://github.com/buildbot/buildbot/compare/2c27932...5bb89f9 From noreply at github.com Mon May 16 21:57:58 2011 From: noreply at github.com (noreply at github.com) Date: Mon, 16 May 2011 14:57:58 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] ba7aea: Merge branch 'volatile/docfix' of git://github.com... Message-ID: <20110516215758.D37BA42532@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: ba7aea86b8e55ffd0394ad149047435b97a4faf5 https://github.com/buildbot/buildbot/commit/ba7aea86b8e55ffd0394ad149047435b97a4faf5 Author: Dustin J. Mitchell <dustin at mozilla.com> Date: 2011-05-16 (Mon, 16 May 2011) Changed paths: M master/docs/cfg-global.texinfo Log Message: ----------- Merge branch 'volatile/docfix' of git://github.com/dabrahams/buildbot * 'volatile/docfix' of git://github.com/dabrahams/buildbot: Strike references to "project" where they no longer make sense From nobody at buildbot.net Mon May 16 21:58:53 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 16 May 2011 21:58:53 -0000 Subject: [Buildbot-commits] [Buildbot] #1956: Can't cancel builds which haven't started. In-Reply-To: <042.2620a0c6a729c11b74b03738d3783611@buildbot.net> References: <042.2620a0c6a729c11b74b03738d3783611@buildbot.net> Message-ID: <057.0efded6ad05e8204514bfbc3872279dc@buildbot.net> #1956: Can't cancel builds which haven't started. -----------------------+-------------------- Reporter: tom.prince | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.4 Version: 0.8.3p1 | Resolution: Keywords: database | -----------------------+-------------------- Changes (by dustin): * keywords: => database * type: undecided => defect * milestone: undecided => 0.8.4 Comment: For the record, I was only asking if it was a single master to see if this had something to do with races between masters. That it's a single master means it's probably a simpler bug to solve, is all. -- Ticket URL: <http://trac.buildbot.net/ticket/1956#comment:1> Buildbot <http://buildbot.net/> Buildbot: build/test automation From noreply at github.com Mon May 16 22:08:56 2011 From: noreply at github.com (noreply at github.com) Date: Mon, 16 May 2011 15:08:56 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 924a75: Claim build requests before cancelling them Message-ID: <20110516220856.58B6242515@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 924a75e5481f6129dbf02d1c987d9681a04ab20d https://github.com/buildbot/buildbot/commit/924a75e5481f6129dbf02d1c987d9681a04ab20d Author: Dustin J. Mitchell <dustin at mozilla.com> Date: 2011-05-16 (Mon, 16 May 2011) Changed paths: M master/buildbot/process/buildrequest.py Log Message: ----------- Claim build requests before cancelling them This avoids marking builds as completed that another master has already claimed. It also avoids a traceback when cancelling unclaimed builds! Fixes #1956. From nobody at buildbot.net Mon May 16 22:09:02 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 16 May 2011 22:09:02 -0000 Subject: [Buildbot-commits] [Buildbot] #1956: Can't cancel builds which haven't started. In-Reply-To: <042.2620a0c6a729c11b74b03738d3783611@buildbot.net> References: <042.2620a0c6a729c11b74b03738d3783611@buildbot.net> Message-ID: <057.41c5d6cd30920dd362aea9247f00a15d@buildbot.net> #1956: Can't cancel builds which haven't started. -----------------------+--------------------- Reporter: tom.prince | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.4 Version: 0.8.3p1 | Resolution: fixed Keywords: database | -----------------------+--------------------- Changes (by Dustin J. Mitchell): * status: new => closed * resolution: => fixed Comment: Claim build requests before cancelling them This avoids marking builds as completed that another master has already claimed. It also avoids a traceback when cancelling unclaimed builds! Fixes #1956. Changeset: 924a75e5481f6129dbf02d1c987d9681a04ab20d -- Ticket URL: <http://trac.buildbot.net/ticket/1956#comment:2> Buildbot <http://buildbot.net/> Buildbot: build/test automation From noreply at github.com Mon May 16 22:36:40 2011 From: noreply at github.com (noreply at github.com) Date: Mon, 16 May 2011 15:36:40 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 0db995: Move monkeypatching to $top_object.startService Message-ID: <20110516223640.7C868424C1@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 0db9958412fb01b7de9a5d9db570cb254b894ec9 https://github.com/buildbot/buildbot/commit/0db9958412fb01b7de9a5d9db570cb254b894ec9 Author: Dustin J. Mitchell <dustin at mozilla.com> Date: 2011-05-16 (Mon, 16 May 2011) Changed paths: M master/buildbot/__init__.py M master/buildbot/master.py M master/buildbot/monkeypatches/__init__.py M master/buildbot/monkeypatches/bug4881.py M slave/buildslave/__init__.py M slave/buildslave/bot.py M slave/buildslave/monkeypatches/__init__.py M slave/buildslave/monkeypatches/bug4881.py Log Message: ----------- Move monkeypatching to $top_object.startService This should allow setup.py to import buildbot or buildslave without invoking the monkey-patching, while not loading things so late as to not be useful. Hopefully. Fixes #1961. From nobody at buildbot.net Mon May 16 22:36:48 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 16 May 2011 22:36:48 -0000 Subject: [Buildbot-commits] [Buildbot] #1961: Better monkey-patching architecture In-Reply-To: <038.c032a31f9694c6aa2b1e0cbdb10bab40@buildbot.net> References: <038.c032a31f9694c6aa2b1e0cbdb10bab40@buildbot.net> Message-ID: <053.9db181bd8c31a42d06cf89b516d91518@buildbot.net> #1961: Better monkey-patching architecture ------------------------+--------------------- Reporter: dustin | Owner: dustin Type: enhancement | Status: closed Priority: major | Milestone: 0.8.4 Version: 0.8.3p1 | Resolution: fixed Keywords: | ------------------------+--------------------- Changes (by Dustin J. Mitchell): * status: new => closed * resolution: => fixed Comment: Move monkeypatching to $top_object.startService This should allow setup.py to import buildbot or buildslave without invoking the monkey-patching, while not loading things so late as to not be useful. Hopefully. Fixes #1961. Changeset: 0db9958412fb01b7de9a5d9db570cb254b894ec9 -- Ticket URL: <http://trac.buildbot.net/ticket/1961#comment:1> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Mon May 16 22:48:12 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 16 May 2011 22:48:12 -0000 Subject: [Buildbot-commits] [Buildbot] #1961: Better monkey-patching architecture In-Reply-To: <038.c032a31f9694c6aa2b1e0cbdb10bab40@buildbot.net> References: <038.c032a31f9694c6aa2b1e0cbdb10bab40@buildbot.net> Message-ID: <053.bcd8675f2be91f8ba19d1aab9b9ea4d4@buildbot.net> #1961: Better monkey-patching architecture ------------------------+----------------------- Reporter: dustin | Owner: dustin Type: enhancement | Status: reopened Priority: major | Milestone: 0.8.4 Version: 0.8.3p1 | Resolution: Keywords: | ------------------------+----------------------- Changes (by dustin): * status: closed => reopened * resolution: fixed => Comment: That did not fix the tests, at least; on FreeBSD: {{{ (view as text) =============================================================================== [ERROR] Traceback (most recent call last): Failure: twisted.internet.defer.TimeoutError: <buildbot.test.unit.test_contrib_buildbot_cvs_mail.TestBuildbotCvsMail testMethod=test_buildbot_cvs_mail_from_cvs1_11> (test_buildbot_cvs_mail_from_cvs1_11) still running at 120.0 secs buildbot.test.unit.test_contrib_buildbot_cvs_mail.TestBuildbotCvsMail.test_buildbot_cvs_mail_from_cvs1_11 =============================================================================== [ERROR] Traceback (most recent call last): Failure: twisted.trial.util.DirtyReactorAggregateError: Reactor was unclean. Selectables: <twisted.internet.process.ProcessReader object at 0x29fa980c> <twisted.internet.process.ProcessReader object at 0x29fa9e8c> buildbot.test.unit.test_contrib_buildbot_cvs_mail.TestBuildbotCvsMail.test_buildbot_cvs_mail_from_cvs1_11 =============================================================================== [ERROR] Traceback (most recent call last): Failure: twisted.internet.defer.TimeoutError: <buildbot.test.unit.test_contrib_buildbot_cvs_mail.TestBuildbotCvsMail testMethod=test_buildbot_cvs_mail_from_cvs1_12> (test_buildbot_cvs_mail_from_cvs1_12) still running at 120.0 secs buildbot.test.unit.test_contrib_buildbot_cvs_mail.TestBuildbotCvsMail.test_buildbot_cvs_mail_from_cvs1_12 =============================================================================== [ERROR] Traceback (most recent call last): Failure: twisted.trial.util.DirtyReactorAggregateError: Reactor was unclean. Selectables: <twisted.internet.process.ProcessReader object at 0x29fa98ac> <twisted.internet.process.ProcessReader object at 0x29fa9ecc> buildbot.test.unit.test_contrib_buildbot_cvs_mail.TestBuildbotCvsMail.test_buildbot_cvs_mail_from_cvs1_12 ------------------------------------------------------------------------------- Ran 737 tests in 296.503s FAILED (errors=4, successes=735) }}} -- Ticket URL: <http://trac.buildbot.net/ticket/1961#comment:2> Buildbot <http://buildbot.net/> Buildbot: build/test automation From noreply at github.com Mon May 16 22:55:53 2011 From: noreply at github.com (noreply at github.com) Date: Mon, 16 May 2011 15:55:53 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 9af636: Install monkeypatches for tests, too. Message-ID: <20110516225553.1D24D42550@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 9af636b55b20807aed5e3c46c8794ae8ef5b6aff https://github.com/buildbot/buildbot/commit/9af636b55b20807aed5e3c46c8794ae8ef5b6aff Author: Dustin J. Mitchell <dustin at mozilla.com> Date: 2011-05-16 (Mon, 16 May 2011) Changed paths: M master/buildbot/test/__init__.py M slave/buildslave/test/__init__.py Log Message: ----------- Install monkeypatches for tests, too. Refs #1961. From nobody at buildbot.net Mon May 16 22:55:59 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 16 May 2011 22:55:59 -0000 Subject: [Buildbot-commits] [Buildbot] #1961: Better monkey-patching architecture In-Reply-To: <038.c032a31f9694c6aa2b1e0cbdb10bab40@buildbot.net> References: <038.c032a31f9694c6aa2b1e0cbdb10bab40@buildbot.net> Message-ID: <053.33cab1ea17fb9deb3b1f5c84e98b06fd@buildbot.net> #1961: Better monkey-patching architecture ------------------------+----------------------- Reporter: dustin | Owner: dustin Type: enhancement | Status: reopened Priority: major | Milestone: 0.8.4 Version: 0.8.3p1 | Resolution: Keywords: | ------------------------+----------------------- Comment (by Dustin J. Mitchell): Install monkeypatches for tests, too. Refs #1961. Changeset: 9af636b55b20807aed5e3c46c8794ae8ef5b6aff -- Ticket URL: <http://trac.buildbot.net/ticket/1961#comment:3> Buildbot <http://buildbot.net/> Buildbot: build/test automation From noreply at github.com Mon May 16 23:03:08 2011 From: noreply at github.com (noreply at github.com) Date: Mon, 16 May 2011 16:03:08 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 4983d4: Monkey-patch a Twisted memory leak Message-ID: <20110516230308.164F742508@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 4983d414b5193950cfba09e9a859fcda929d2a6f https://github.com/buildbot/buildbot/commit/4983d414b5193950cfba09e9a859fcda929d2a6f Author: Dustin J. Mitchell <dustin at mozilla.com> Date: 2011-05-16 (Mon, 16 May 2011) Changed paths: M master/buildbot/monkeypatches/__init__.py A master/buildbot/monkeypatches/bug5079.py M slave/buildslave/monkeypatches/__init__.py A slave/buildslave/monkeypatches/bug5079.py Log Message: ----------- Monkey-patch a Twisted memory leak Refs #1958. Hopefully 'fixes', but we'll see. From nobody at buildbot.net Mon May 16 23:03:13 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 16 May 2011 23:03:13 -0000 Subject: [Buildbot-commits] [Buildbot] #1958: Monkey-patch Twisted memory leak In-Reply-To: <038.72b04799a36bfce9741b72578a235918@buildbot.net> References: <038.72b04799a36bfce9741b72578a235918@buildbot.net> Message-ID: <053.646787ce4bebb82c74fdc8a9f10e49e8@buildbot.net> #1958: Monkey-patch Twisted memory leak ------------------------+--------------------- Reporter: dustin | Owner: dustin Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: master | Resolution: Keywords: performance | ------------------------+--------------------- Comment (by Dustin J. Mitchell): Monkey-patch a Twisted memory leak Refs #1958. Hopefully 'fixes', but we'll see. Changeset: 4983d414b5193950cfba09e9a859fcda929d2a6f -- Ticket URL: <http://trac.buildbot.net/ticket/1958#comment:1> Buildbot <http://buildbot.net/> Buildbot: build/test automation From noreply at github.com Tue May 17 00:10:15 2011 From: noreply at github.com (noreply at github.com) Date: Mon, 16 May 2011 17:10:15 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 979b00: Merge pull request #121 from NateBragg/transfertim... Message-ID: <20110517001015.0951C42554@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 979b0067d6f5dcaf44efddbb51862704d1e2a87a https://github.com/buildbot/buildbot/commit/979b0067d6f5dcaf44efddbb51862704d1e2a87a Author: Amber Yust <amber.yust at gmail.com> Date: 2011-05-16 (Mon, 16 May 2011) Changed paths: M master/buildbot/steps/transfer.py M master/buildbot/test/unit/test_steps_transfer.py M master/docs/cfg-buildsteps.texinfo M slave/buildslave/commands/base.py M slave/buildslave/commands/transfer.py M slave/buildslave/test/unit/test_commands_transfer.py Log Message: ----------- Merge pull request #121 from NateBragg/transfertimestamp Added optional keepstamp argument for FileUpload buildstep, that, when True, forces the timestamp of the destination file to match the source file. From noreply at github.com Tue May 17 00:40:12 2011 From: noreply at github.com (noreply at github.com) Date: Mon, 16 May 2011 17:40:12 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 29a2d0: Fix tests that were breaking on Pythons older than... Message-ID: <20110517004012.346D74235C@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 29a2d0861876e9f2cdbc8c21a4fa4683d1146cb7 https://github.com/buildbot/buildbot/commit/29a2d0861876e9f2cdbc8c21a4fa4683d1146cb7 Author: Amber Yust <ayust at yelp.com> Date: 2011-05-16 (Mon, 16 May 2011) Changed paths: M slave/buildslave/test/unit/test_commands_transfer.py Log Message: ----------- Fix tests that were breaking on Pythons older than 2.6 due to lack of str.format From noreply at github.com Tue May 17 00:44:33 2011 From: noreply at github.com (noreply at github.com) Date: Mon, 16 May 2011 17:44:33 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 89803b: Missed one format string Message-ID: <20110517004433.2052742544@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 89803b40f18f3891fb55075ae20878a4b6a34035 https://github.com/buildbot/buildbot/commit/89803b40f18f3891fb55075ae20878a4b6a34035 Author: Amber Yust <ayust at yelp.com> Date: 2011-05-16 (Mon, 16 May 2011) Changed paths: M slave/buildslave/test/unit/test_commands_transfer.py Log Message: ----------- Missed one format string From nobody at buildbot.net Tue May 17 02:09:04 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 17 May 2011 02:09:04 -0000 Subject: [Buildbot-commits] [Buildbot] #953: Bad interaction between (contrib) darcs_buildbot.py and buildmaster >= 0.7.12. In-Reply-To: <040.3920ad7a73638efd64f4c8f6a985f387@buildbot.net> References: <040.3920ad7a73638efd64f4c8f6a985f387@buildbot.net> Message-ID: <055.ec2c6b99111dc4af9c067d5d712b7266@buildbot.net> #953: Bad interaction between (contrib) darcs_buildbot.py and buildmaster >= 0.7.12. ---------------------+-------------------- Reporter: mornfall | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.+ Version: 0.7.12 | Resolution: Keywords: darcs | ---------------------+-------------------- Comment (by zooko): dustin: I *think* that both darcs_buildbot.py and the buildbot step code both changed to use hashes in 0.7.12. I don't remember for certain, and it doesn't seem easy to peruse history that old through github: https://github.com/buildbot/buildbot -- Ticket URL: <http://trac.buildbot.net/ticket/953#comment:8> Buildbot <http://buildbot.net/> Buildbot: build/test automation From noreply at github.com Tue May 17 04:34:27 2011 From: noreply at github.com (noreply at github.com) Date: Mon, 16 May 2011 21:34:27 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 55d3e3: Add configurable warning threshold before failing ... Message-ID: <20110517043427.2236E42355@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 55d3e36741443aa15339995ff69755de4240ff51 https://github.com/buildbot/buildbot/commit/55d3e36741443aa15339995ff69755de4240ff51 Author: Adam <adam at bastard.(none)> Date: 2011-05-16 (Mon, 16 May 2011) Changed paths: M master/buildbot/steps/shell.py Log Message: ----------- Add configurable warning threshold before failing a warning counting shell step Commit: 3dcaa6e14768c03f39e24dff51530fce2577dc6f https://github.com/buildbot/buildbot/commit/3dcaa6e14768c03f39e24dff51530fce2577dc6f Author: Adam <adam at bastard.(none)> Date: 2011-05-16 (Mon, 16 May 2011) Changed paths: M master/docs/cfg-buildsteps.texinfo Log Message: ----------- Added documentation Commit: 82d83fd3d8d91c5fe25a39980190fa17f623a064 https://github.com/buildbot/buildbot/commit/82d83fd3d8d91c5fe25a39980190fa17f623a064 Author: Amber Yust <amber.yust at gmail.com> Date: 2011-05-16 (Mon, 16 May 2011) Changed paths: M master/buildbot/steps/shell.py M master/docs/cfg-buildsteps.texinfo Log Message: ----------- Merge pull request #129 from HukdUnFonx/add_max_warnings Add max warnings Compare: https://github.com/buildbot/buildbot/compare/89803b4...82d83fd From nobody at buildbot.net Tue May 17 13:36:08 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 17 May 2011 13:36:08 -0000 Subject: [Buildbot-commits] [Buildbot] #1964: If a shell script (.sh) has to be run from the master.cfg file , in which path should the script exist and what is the add step command that needs to be given in the master.cfg file? Message-ID: <047.f6c2e4c4fb69c71413268dae65be661c@buildbot.net> #1964: If a shell script (.sh) has to be run from the master.cfg file , in which path should the script exist and what is the add step command that needs to be given in the master.cfg file? ----------------------------+------------------- Reporter: sanlokenpatidar | Owner: Type: support-request | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.3p1 | Keywords: ----------------------------+------------------- If I give ? f_pro4_full_periodic.addStep(shell.ShellCommand( name = "TriggerBuild", command=[ "pro4_full_periodic/build/build/scripts/triggerBuild.sh" ] )) It showed error - 'pro4_full_periodic' is not recognized as an internal or external command, operable program or batch file if I give ? f_pro4_full_periodic.addStep(shell.ShellCommand( name = "TriggerBuild", command=[ "/pro4_full_periodic/build/build/scripts/triggerBuild.sh" ] )) It showed error - The system cannot find the path specified. If I give ? f_pro4_full_periodic.addStep(shell.ShellCommand( name = "TriggerBuild", command=[ "./pro4_full_periodic/build/build/scripts/triggerBuild.sh" ] )) It showed error - '.' is not recognized as an internal or external command, operable program or batch file. Some timed it showed in other case - '/' is not recognized as an internal or external command, operable program or batch file. .sh file in slave machine and base directory is - 'C:\cygwin\home\buildbot\slave_pro4' .sh file directory (after creating the build) - /home/buildbot/slave_pro4/pro4_full_periodic/build/build/scripts/triggerBuild.sh -- Ticket URL: <http://trac.buildbot.net/ticket/1964> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Tue May 17 17:21:47 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 17 May 2011 17:21:47 -0000 Subject: [Buildbot-commits] [Buildbot] #1965: Improve subunit support. Message-ID: <042.69b13198a240affc1584c9f73f3e2dda@buildbot.net> #1965: Improve subunit support. ------------------------+----------------------- Reporter: tom.prince | Owner: Type: enhancement | Status: new Priority: minor | Milestone: undecided Version: master | Keywords: ------------------------+----------------------- In particular, subunit exposes the richer TestResult coming from testtools, but we only implement base python TestResult, losing some of the details. Thus, test output is disguised as: {{{ _StringException: Text attachment: traceback }}} -- Ticket URL: <http://trac.buildbot.net/ticket/1965> Buildbot <http://buildbot.net/> Buildbot: build/test automation From noreply at github.com Wed May 18 15:18:49 2011 From: noreply at github.com (noreply at github.com) Date: Wed, 18 May 2011 08:18:49 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] c12dd5: Allow a selection of builds to be started or stopp... Message-ID: <20110518151849.928D742578@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: c12dd547f651f0b32405fcc0224f0bf5054d7ec9 https://github.com/buildbot/buildbot/commit/c12dd547f651f0b32405fcc0224f0bf5054d7ec9 Author: Gareth Armstrong <gareth.armstrong at hp.com> Date: 2011-05-18 (Wed, 18 May 2011) Changed paths: M master/buildbot/status/web/builder.py M master/buildbot/status/web/templates/builders.html M master/buildbot/status/web/templates/forms.html Log Message: ----------- Allow a selection of builds to be started or stopped from the builders webpage. Commit: bdf99e930ade74ead4ac0ad224dc7cf731f1d804 https://github.com/buildbot/buildbot/commit/bdf99e930ade74ead4ac0ad224dc7cf731f1d804 Author: Amber Yust <amber.yust at gmail.com> Date: 2011-05-18 (Wed, 18 May 2011) Changed paths: M master/buildbot/status/web/builder.py M master/buildbot/status/web/templates/builders.html M master/buildbot/status/web/templates/forms.html Log Message: ----------- Merge pull request #131 from garetharmstronghp/web_select_builders3 Allow a selection of builds to be started or stopped from the available builders. Compare: https://github.com/buildbot/buildbot/compare/82d83fd...bdf99e9 From noreply at github.com Wed May 18 19:38:25 2011 From: noreply at github.com (noreply at github.com) Date: Wed, 18 May 2011 12:38:25 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] a15b12: Change default of AllowForce to False for IRC Message-ID: <20110518193825.49C25425C1@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: a15b123e54256878c578cb706c8ddf7dc45ac8cb https://github.com/buildbot/buildbot/commit/a15b123e54256878c578cb706c8ddf7dc45ac8cb Author: Dan Scott <dan at coffeecode.net> Date: 2011-05-18 (Wed, 18 May 2011) Changed paths: M master/NEWS M master/buildbot/status/words.py Log Message: ----------- Change default of AllowForce to False for IRC Allowing IRC bots to force and stop builds by default was somewhat surprising behavior; we now default to False and allow admins to override the parameter in master.cfg. Signed-off-by: Dan Scott <dscott at laurentian.ca> From nobody at buildbot.net Thu May 19 14:26:37 2011 From: nobody at buildbot.net (Buildbot) Date: Thu, 19 May 2011 14:26:37 -0000 Subject: [Buildbot-commits] [Buildbot] #1966: Buildstep throws an unhandled error if it has alwaysRun=True and buildslave is lost Message-ID: <040.0cfe83bc1d7b2d6d16ba1b8b619a6767@buildbot.net> #1966: Buildstep throws an unhandled error if it has alwaysRun=True and buildslave is lost ---------------------+--------------------------------- Reporter: JustAMan | Owner: Type: defect | Status: new Priority: minor | Milestone: undecided Version: 0.8.0 | Keywords: alwaysrun exception ---------------------+--------------------------------- It occurs because probably no one considered such a case, thus there's no check if BuildStep.remote is valid instance. In the case when buildslave is lost it's equal to None. I've created a patch to fix such an issue. It stops the build altogether if build's remote went away, even if there are any buildsteps which have alwaysRun=True set. -- Ticket URL: <http://trac.buildbot.net/ticket/1966> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Thu May 19 16:47:22 2011 From: nobody at buildbot.net (Buildbot) Date: Thu, 19 May 2011 16:47:22 -0000 Subject: [Buildbot-commits] [Buildbot] #1963: FileUpload creates truncated file when buildslave is not on localhost In-Reply-To: <038.d8aba18af3dd124e6fb92915e876c160@buildbot.net> References: <038.d8aba18af3dd124e6fb92915e876c160@buildbot.net> Message-ID: <053.018d07253ee5ba60c004a2a85739c65f@buildbot.net> #1963: FileUpload creates truncated file when buildslave is not on localhost ----------------------+------------------------ Reporter: landry | Owner: Type: undecided | Status: new Priority: major | Milestone: undecided Version: 0.8.3p1 | Resolution: Keywords: | ----------------------+------------------------ Comment (by dustin): That *might* be related, but the symlnik is 30 characters long ({{{len ("obj-sparc64-unknown-openbsd4.9")}}}), so perhaps not. What are the contents of the truncated file? Can you add some debug logging on the client side to see what's happening? Huh, "Aurora" - I hear a lot about that at work, too ;) -- Ticket URL: <http://trac.buildbot.net/ticket/1963#comment:1> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Thu May 19 19:07:43 2011 From: nobody at buildbot.net (Buildbot) Date: Thu, 19 May 2011 19:07:43 -0000 Subject: [Buildbot-commits] [Buildbot] #1964: If a shell script (.sh) has to be run from the master.cfg file , in which path should the script exist and what is the add step command that needs to be given in the master.cfg file? In-Reply-To: <047.f6c2e4c4fb69c71413268dae65be661c@buildbot.net> References: <047.f6c2e4c4fb69c71413268dae65be661c@buildbot.net> Message-ID: <062.e55d858e4166bf4f9a748ae662d0b523@buildbot.net> #1964: If a shell script (.sh) has to be run from the master.cfg file , in which path should the script exist and what is the add step command that needs to be given in the master.cfg file? ----------------------------+-------------------- Reporter: sanlokenpatidar | Owner: Type: support-request | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.3p1 | Resolution: Keywords: | ----------------------------+-------------------- Comment (by dustin): I don't think you can run a shell script directly on Windows - you have to pass it as an argument to bash, e.g., {{{ command=[r"C:\PATH\TO\BASH.EXE", "C:\PATH\TO\MY\SHELL\SCRIPT.SH"] }}} -- Ticket URL: <http://trac.buildbot.net/ticket/1964#comment:1> Buildbot <http://buildbot.net/> Buildbot: build/test automation From noreply at github.com Thu May 19 21:11:58 2011 From: noreply at github.com (noreply at github.com) Date: Thu, 19 May 2011 14:11:58 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] e00a37: Merge branch 'master' of git://github.com/dzhurley... Message-ID: <20110519211158.C545E42636@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: e00a37f833e26ce35fdcdfcf0c03f3f6aaa20cb1 https://github.com/buildbot/buildbot/commit/e00a37f833e26ce35fdcdfcf0c03f3f6aaa20cb1 Author: Dustin J. Mitchell <dustin at mozilla.com> Date: 2011-05-19 (Thu, 19 May 2011) Changed paths: M master/buildbot/status/words.py M master/docs/cfg-statustargets.texinfo Log Message: ----------- Merge branch 'master' of git://github.com/dzhurley/buildbot * 'master' of git://github.com/dzhurley/buildbot: updated docs and command_FORCE usage to include details about --branch and --revision options Fixes #1949. From nobody at buildbot.net Thu May 19 21:12:04 2011 From: nobody at buildbot.net (Buildbot) Date: Thu, 19 May 2011 21:12:04 -0000 Subject: [Buildbot-commits] [Buildbot] #1949: irc bot force command needs branch option In-Reply-To: <035.193ee026bfec9b27866696576e57c66b@buildbot.net> References: <035.193ee026bfec9b27866696576e57c66b@buildbot.net> Message-ID: <050.0a7bc1cfea3b6b0c6127d86007dd5340@buildbot.net> #1949: irc bot force command needs branch option ------------------------+------------------------ Reporter: H__ | Owner: Type: enhancement | Status: closed Priority: minor | Milestone: undecided Version: 0.8.3p1 | Resolution: fixed Keywords: irc | ------------------------+------------------------ Changes (by Dustin J. Mitchell): * status: new => closed * resolution: => fixed Comment: Merge branch 'master' of git://github.com/dzhurley/buildbot * 'master' of git://github.com/dzhurley/buildbot: updated docs and command_FORCE usage to include details about --branch and --revision options Fixes #1949. Changeset: e00a37f833e26ce35fdcdfcf0c03f3f6aaa20cb1 -- Ticket URL: <http://trac.buildbot.net/ticket/1949#comment:1> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Thu May 19 21:12:57 2011 From: nobody at buildbot.net (Buildbot) Date: Thu, 19 May 2011 21:12:57 -0000 Subject: [Buildbot-commits] [Buildbot] #1963: FileUpload creates truncated file when buildslave is not on localhost In-Reply-To: <038.d8aba18af3dd124e6fb92915e876c160@buildbot.net> References: <038.d8aba18af3dd124e6fb92915e876c160@buildbot.net> Message-ID: <053.4c95acc8a4f6bb89a19092621651d43c@buildbot.net> #1963: FileUpload creates truncated file when buildslave is not on localhost ----------------------+------------------------ Reporter: landry | Owner: Type: undecided | Status: new Priority: major | Milestone: undecided Version: 0.8.3p1 | Resolution: Keywords: | ----------------------+------------------------ Comment (by landry): files contain : {{{ # cat /var/buildbot/public_html/builds/firefox-5.0a2.en- US.openbsd4.9-sparc64.tar.bz2 BZh9rE8P }}} (plus an unprintable char at the end) and each contain the same garbage, be it thunderbird-3.4a1pre.en- US.openbsd4.9-sparc64.tar.bz2, firefox-5.0a2.en- US.openbsd4.9-sparc64.tar.bz2 or firefox-6.0a1.en- US.openbsd4.9-sparc64.tar.bz2. All the 'objdir' symlinks of course point to a dir named 'obj-sparc64-unknown-openbsd4.9'. I'll set MOZ_OBJDIR in .mozconfig to 'objdirtest' (the objdir symlink target), to see if the size of the bogus transferred file corresponds to the length of the symlink target filename... 10 in our case. results in http://buildbot.rhaalovely.net/builds/ tomorrow, i've only changed the mozilla-aurora-sparc64 buildslave, so we'll see it on firefox-5.0a2 file size. -- Ticket URL: <http://trac.buildbot.net/ticket/1963#comment:2> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Thu May 19 21:30:19 2011 From: nobody at buildbot.net (Buildbot) Date: Thu, 19 May 2011 21:30:19 -0000 Subject: [Buildbot-commits] [Buildbot] #1963: FileUpload creates truncated file when buildslave is not on localhost In-Reply-To: <038.d8aba18af3dd124e6fb92915e876c160@buildbot.net> References: <038.d8aba18af3dd124e6fb92915e876c160@buildbot.net> Message-ID: <053.517f9aabcc1227f1c30a23fc44f24d12@buildbot.net> #1963: FileUpload creates truncated file when buildslave is not on localhost ----------------------+------------------------ Reporter: landry | Owner: Type: undecided | Status: new Priority: major | Milestone: undecided Version: 0.8.3p1 | Resolution: Keywords: | ----------------------+------------------------ Comment (by dustin): well, it's unlikely to correspond to the symlink length if it doesn't contain the text of the symlink. Can you add some {{{print}}}s to the sparc buildslave's transfer implementation to see if you can tell what's happening? Basically, get a picture of what, or at least how many bytes, are being passed to the relevant callRemote's, and compare that to what you see on the master. -- Ticket URL: <http://trac.buildbot.net/ticket/1963#comment:3> Buildbot <http://buildbot.net/> Buildbot: build/test automation From noreply at github.com Fri May 20 14:32:39 2011 From: noreply at github.com (noreply at github.com) Date: Fri, 20 May 2011 07:32:39 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] cc2bde: maxWarnings -> maxWarnCount Message-ID: <20110520143239.6FB9B4262C@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: cc2bde3124ab7da3a813ea03ff49dfcbc2be0dc3 https://github.com/buildbot/buildbot/commit/cc2bde3124ab7da3a813ea03ff49dfcbc2be0dc3 Author: Love H?rnquist ?strand <lha at kth.se> Date: 2011-05-19 (Thu, 19 May 2011) Changed paths: M master/buildbot/steps/shell.py Log Message: ----------- maxWarnings -> maxWarnCount Commit: bbff0cc019b7776961852393dd2959909a1e8f7f https://github.com/buildbot/buildbot/commit/bbff0cc019b7776961852393dd2959909a1e8f7f Author: Love H?rnquist ?strand <lha at kth.se> Date: 2011-05-19 (Thu, 19 May 2011) Changed paths: M master/buildbot/steps/shell.py Log Message: ----------- always set self.maxWarnCount so it can use used later Commit: 828e372925051303a5145f62e1cab3ac56fc4de1 https://github.com/buildbot/buildbot/commit/828e372925051303a5145f62e1cab3ac56fc4de1 Author: Dustin J. Mitchell <dustin at v.igoro.us> Date: 2011-05-20 (Fri, 20 May 2011) Changed paths: M master/buildbot/steps/shell.py Log Message: ----------- Merge pull request #132 from lha/patch-1 Fixes exceptions.AttributeError: Compile instance has no attribute 'maxWarnCount' Compare: https://github.com/buildbot/buildbot/compare/e00a37f...828e372 From nobody at buildbot.net Fri May 20 22:01:27 2011 From: nobody at buildbot.net (Buildbot) Date: Fri, 20 May 2011 22:01:27 -0000 Subject: [Buildbot-commits] [Buildbot] #1967: mode="copy" fails the second+ time around on win32, due to the directory sticking around. Message-ID: <038.3b750927173a9c90bf755ae6d9158961@buildbot.net> #1967: mode="copy" fails the second+ time around on win32, due to the directory sticking around. ----------------------+----------------------- Reporter: tfogal | Owner: Type: undecided | Status: new Priority: major | Milestone: undecided Version: 0.8.3p1 | Keywords: windows ----------------------+----------------------- The buildstep: {{{ tvk.addStep(SVN(svnurl=tuvok_root, mode="copy", always_purge=True, alwaysUseLatest=True)) }}} is failing every iteration beyond the first on a Windows 7 machine. The issue appears to be that the build directory still exists. I notice that with the OS X build step, the first thing an SVN() step does is `rm -rf` the `build/` directory. The SVN() step on windows does no such thing. First thing it does is a `status`, then the `update` it should do. Error message I get, with shortened ("`xxx`") paths: {{{ Since we're on a non-POSIX platform, we're not going to try to execute cp in a subprocess, but instead use shutil.copytree(), which will block until it is complete. fromdir: c:\xxx\source, todir: c:\xxx\build remoteFailed: [Failure instance: Traceback from remote host -- Traceback (most recent call last): File "c:\Python26\lib\site-packages\twisted\internet\defer.py", line 280, in unpause self._runCallbacks() File "c:\Python26\lib\site-packages\twisted\internet\defer.py", line 323, in _runCallbacks self.result = callback(self.result, *args, **kw) File "c:\Python26\lib\site-packages\twisted\internet\defer.py", line 284, in _continue self.unpause() File "c:\Python26\lib\site-packages\twisted\internet\defer.py", line 280, in unpause self._runCallbacks() --- <exception caught here> --- File "c:\Python26\lib\site-packages\twisted\internet\defer.py", line 323, in _runCallbacks self.result = callback(self.result, *args, **kw) File "c:\Python26\lib\site-packages\buildslave\commands\base.py", line 533, in doCopy shutil.copytree(fromdir, todir) File "c:\Python26\lib\shutil.py", line 146, in copytree os.makedirs(dst) File "c:\Python26\lib\os.py", line 157, in makedirs mkdir(name, mode) exceptions.WindowsError: [Error 183] Cannot create a file when that file already exists: 'c:\\xxx\\build' ] }}} -- Ticket URL: <http://trac.buildbot.net/ticket/1967> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Sun May 22 07:01:33 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 22 May 2011 07:01:33 -0000 Subject: [Buildbot-commits] [Buildbot] #1684: Buildbot doesn't detect a broken configuration file In-Reply-To: <038.73dfe541d584cc91781ed4b83cbf58c0@buildbot.net> References: <038.73dfe541d584cc91781ed4b83cbf58c0@buildbot.net> Message-ID: <053.17786c842b8d1222e2fe4d3bea0e73be@buildbot.net> #1684: Buildbot doesn't detect a broken configuration file ------------------------+-------------------- Reporter: kostja | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.2 | Resolution: Keywords: simple | ------------------------+-------------------- Comment (by in3xes): This is reproducible with latest version? I can see all the slaves and they are working fine. In my config file I put the below bit twice. {{{ from buildbot.status import html c['status'].append(html.WebStatus(http_port=8010, allowForce=True)) }}} buildbot started with same error mentioned and it is working. -- Ticket URL: <http://trac.buildbot.net/ticket/1684#comment:3> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Mon May 23 06:57:25 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 23 May 2011 06:57:25 -0000 Subject: [Buildbot-commits] [Buildbot] #1968: Multi-prefix support for PBChangeSource Message-ID: <037.6e39d558ae82ef5d43aec9db24951f82@buildbot.net> #1968: Multi-prefix support for PBChangeSource ------------------------+----------------------------------------- Reporter: LoTek | Owner: Type: enhancement | Status: new Priority: minor | Milestone: undecided Version: 0.8.3p1 | Keywords: PBChangeSource, prefix, svn ------------------------+----------------------------------------- Since we use subversion externals in our project, it became important to receive updates on changes on all the different parts (and in our case, from multiple servers), so I implemented the accompanying patch (which we currently just inject in master.cfg). It may not be ideal, but enables multiple subversion sources to trigger a single buildbot. -- Ticket URL: <http://trac.buildbot.net/ticket/1968> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Mon May 23 15:41:41 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 23 May 2011 15:41:41 -0000 Subject: [Buildbot-commits] [Buildbot] #1876: words.IRC Support for categories somewhat undocumented In-Reply-To: <041.14b21b9a3756f06e7551fda30de32467@buildbot.net> References: <041.14b21b9a3756f06e7551fda30de32467@buildbot.net> Message-ID: <056.ec8cf40eb1db97c02efa13d828bcddf5@buildbot.net> #1876: words.IRC Support for categories somewhat undocumented -------------------------+-------------------- Reporter: dabrahams | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.4 Version: 0.8.3p1 | Resolution: Keywords: docs, simple | -------------------------+-------------------- Comment (by in3xes): Tested. It is working. -- Ticket URL: <http://trac.buildbot.net/ticket/1876#comment:2> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Mon May 23 15:54:58 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 23 May 2011 15:54:58 -0000 Subject: [Buildbot-commits] [Buildbot] #1876: words.IRC Support for categories somewhat undocumented In-Reply-To: <041.14b21b9a3756f06e7551fda30de32467@buildbot.net> References: <041.14b21b9a3756f06e7551fda30de32467@buildbot.net> Message-ID: <056.4d6e09d1ebea493e57cb182ac7b28223@buildbot.net> #1876: words.IRC Support for categories somewhat undocumented -------------------------+-------------------- Reporter: dabrahams | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.4 Version: 0.8.3p1 | Resolution: Keywords: docs, simple | -------------------------+-------------------- Comment (by dustin): Cool - just needs documentation, then. -- Ticket URL: <http://trac.buildbot.net/ticket/1876#comment:3> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Mon May 23 16:23:20 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 23 May 2011 16:23:20 -0000 Subject: [Buildbot-commits] [Buildbot] #1876: words.IRC Support for categories somewhat undocumented In-Reply-To: <041.14b21b9a3756f06e7551fda30de32467@buildbot.net> References: <041.14b21b9a3756f06e7551fda30de32467@buildbot.net> Message-ID: <056.a31405c63a3913d11ce6a0eb9cfc594d@buildbot.net> #1876: words.IRC Support for categories somewhat undocumented -------------------------+-------------------- Reporter: dabrahams | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.4 Version: 0.8.3p1 | Resolution: Keywords: docs, simple | -------------------------+-------------------- Comment (by dabrahams): Replying to [comment:2 in3xes]: > Tested. It is working. Is it unrealistic to hope for these tests to be added to the metabuildbot? -- Ticket URL: <http://trac.buildbot.net/ticket/1876#comment:4> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Mon May 23 16:49:25 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 23 May 2011 16:49:25 -0000 Subject: [Buildbot-commits] [Buildbot] #1876: words.IRC Support for categories somewhat undocumented In-Reply-To: <041.14b21b9a3756f06e7551fda30de32467@buildbot.net> References: <041.14b21b9a3756f06e7551fda30de32467@buildbot.net> Message-ID: <056.867f7762e4c1403895070ee1198e5dcd@buildbot.net> #1876: words.IRC Support for categories somewhat undocumented -------------------------+-------------------- Reporter: dabrahams | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.4 Version: 0.8.3p1 | Resolution: Keywords: docs, simple | -------------------------+-------------------- Comment (by dustin): I'm not sure how best to test an IRC client, but if you want to give it a shot, by all means - on a new bug, though. -- Ticket URL: <http://trac.buildbot.net/ticket/1876#comment:5> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Mon May 23 18:36:02 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 23 May 2011 18:36:02 -0000 Subject: [Buildbot-commits] [Buildbot] #1965: Improve subunit support. In-Reply-To: <042.69b13198a240affc1584c9f73f3e2dda@buildbot.net> References: <042.69b13198a240affc1584c9f73f3e2dda@buildbot.net> Message-ID: <057.900e05ec83b46035e03660e8324b8a73@buildbot.net> #1965: Improve subunit support. ------------------------+-------------------- Reporter: tom.prince | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.+ Version: master | Resolution: Keywords: | ------------------------+-------------------- Changes (by dustin): * milestone: undecided => 0.8.+ -- Ticket URL: <http://trac.buildbot.net/ticket/1965#comment:1> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Mon May 23 18:48:59 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 23 May 2011 18:48:59 -0000 Subject: [Buildbot-commits] [Buildbot] #890: need to monkeypatch in a TestCase.patch on Twisted-2.5.0 In-Reply-To: <038.b0e26b7fdaaba31088cd2ccd9228453c@buildbot.net> References: <038.b0e26b7fdaaba31088cd2ccd9228453c@buildbot.net> Message-ID: <053.603f4abcc30fefa42c8e9f3f6d53a3eb@buildbot.net> #890: need to monkeypatch in a TestCase.patch on Twisted-2.5.0 ------------------------+--------------------- Reporter: dustin | Owner: Type: enhancement | Status: closed Priority: major | Milestone: 0.8.+ Version: 0.8.0 | Resolution: fixed Keywords: tests | ------------------------+--------------------- Changes (by dustin): * status: new => closed * resolution: => fixed Comment: We don't support Twisted-2.5.0; support is also missing in Twisted-8.0.0, and we've hacked a way to skip those tests. -- Ticket URL: <http://trac.buildbot.net/ticket/890#comment:1> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Mon May 23 18:49:26 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 23 May 2011 18:49:26 -0000 Subject: [Buildbot-commits] [Buildbot] #872: hook pylint up to metabuildbot In-Reply-To: <038.cae341a2be83bff59439d7075294b994@buildbot.net> References: <038.cae341a2be83bff59439d7075294b994@buildbot.net> Message-ID: <053.a3643f5ddbf852abb0a04b1095158331@buildbot.net> #872: hook pylint up to metabuildbot -------------------+---------------------- Reporter: dustin | Owner: dustin Type: task | Status: closed Priority: major | Milestone: 0.8.+ Version: 0.8.0 | Resolution: wontfix Keywords: tests | -------------------+---------------------- Changes (by dustin): * status: new => closed * resolution: => wontfix Comment: Calling this 'wontfix' based on the above. -- Ticket URL: <http://trac.buildbot.net/ticket/872#comment:7> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Mon May 23 18:50:00 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 23 May 2011 18:50:00 -0000 Subject: [Buildbot-commits] [Buildbot] #1961: Better monkey-patching architecture In-Reply-To: <038.c032a31f9694c6aa2b1e0cbdb10bab40@buildbot.net> References: <038.c032a31f9694c6aa2b1e0cbdb10bab40@buildbot.net> Message-ID: <053.54cbb85cf8676ffee782528b6ac6053b@buildbot.net> #1961: Better monkey-patching architecture ------------------------+--------------------- Reporter: dustin | Owner: dustin Type: enhancement | Status: closed Priority: major | Milestone: 0.8.4 Version: 0.8.3p1 | Resolution: fixed Keywords: | ------------------------+--------------------- Changes (by dustin): * status: reopened => closed * resolution: => fixed Comment: Fixed now. -- Ticket URL: <http://trac.buildbot.net/ticket/1961#comment:4> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Mon May 23 18:53:49 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 23 May 2011 18:53:49 -0000 Subject: [Buildbot-commits] [Buildbot] #1966: Buildstep throws an unhandled error if it has alwaysRun=True and buildslave is lost In-Reply-To: <040.0cfe83bc1d7b2d6d16ba1b8b619a6767@buildbot.net> References: <040.0cfe83bc1d7b2d6d16ba1b8b619a6767@buildbot.net> Message-ID: <055.182a98c6871d385f4d34e2c2c13d16c8@buildbot.net> #1966: Buildstep throws an unhandled error if it has alwaysRun=True and buildslave is lost ---------------------+------------------------ Reporter: JustAMan | Owner: Type: defect | Status: closed Priority: minor | Milestone: undecided Version: 0.8.0 | Resolution: duplicate Keywords: | ---------------------+------------------------ Changes (by dustin): * keywords: alwaysrun exception => * status: new => closed * resolution: => duplicate Comment: Dupe of #822, with the same fix :) -- Ticket URL: <http://trac.buildbot.net/ticket/1966#comment:1> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Mon May 23 20:15:10 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 23 May 2011 20:15:10 -0000 Subject: [Buildbot-commits] [Buildbot] #1967: mode="copy" fails the second+ time around on win32, due to the directory sticking around. In-Reply-To: <038.3b750927173a9c90bf755ae6d9158961@buildbot.net> References: <038.3b750927173a9c90bf755ae6d9158961@buildbot.net> Message-ID: <053.f728892947baf20e91c79f405c47ff0e@buildbot.net> #1967: mode="copy" fails the second+ time around on win32, due to the directory sticking around. --------------------+-------------------- Reporter: tfogal | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.4 Version: 0.8.3p1 | Resolution: Keywords: windows | --------------------+-------------------- Changes (by dustin): * cc: in3xes (added) * type: undecided => defect * milestone: undecided => 0.8.4 Comment: in3xes, is this something you'll be able to fix during your work? -- Ticket URL: <http://trac.buildbot.net/ticket/1967#comment:1> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Mon May 23 20:17:12 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 23 May 2011 20:17:12 -0000 Subject: [Buildbot-commits] [Buildbot] #1684: Buildbot doesn't detect a broken configuration file In-Reply-To: <038.73dfe541d584cc91781ed4b83cbf58c0@buildbot.net> References: <038.73dfe541d584cc91781ed4b83cbf58c0@buildbot.net> Message-ID: <053.34ecf3f8714a7af68124714b0e3e8b5c@buildbot.net> #1684: Buildbot doesn't detect a broken configuration file ------------------------+-------------------- Reporter: kostja | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.2 | Resolution: Keywords: simple | ------------------------+-------------------- Comment (by dustin): That it worked after giving the error message is good news (and probably due to a difference in error handling somewhere else?) We still should catch this particular misconfiguration earlier and give a more reasonable error message. -- Ticket URL: <http://trac.buildbot.net/ticket/1684#comment:4> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Mon May 23 20:31:35 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 23 May 2011 20:31:35 -0000 Subject: [Buildbot-commits] [Buildbot] #1968: Multi-prefix support for PBChangeSource In-Reply-To: <037.6e39d558ae82ef5d43aec9db24951f82@buildbot.net> References: <037.6e39d558ae82ef5d43aec9db24951f82@buildbot.net> Message-ID: <052.0b9c49c29f7010ba9686a5ca00275ba0@buildbot.net> #1968: Multi-prefix support for PBChangeSource ----------------------------------------+------------------------ Reporter: LoTek | Owner: Type: enhancement | Status: new Priority: minor | Milestone: undecided Version: 0.8.3p1 | Resolution: Keywords: PBChangeSource, prefix, svn | ----------------------------------------+------------------------ Comment (by dustin): This looks good, but needs a few things: 1. tests 1. docs Also, I'm not sure why you used {{{str(self.prefixes)}}} in the last hunk - would it be better to use the %s stringification? -- Ticket URL: <http://trac.buildbot.net/ticket/1968#comment:1> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Tue May 24 02:25:36 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 24 May 2011 02:25:36 -0000 Subject: [Buildbot-commits] [Buildbot] #1939: Can not trigger build when I use timed.Nightly with onlyIfChanged=True, using GerritChangeSource In-Reply-To: <037.fc48fcede16bcf96e03a993f5a3f2272@buildbot.net> References: <037.fc48fcede16bcf96e03a993f5a3f2272@buildbot.net> Message-ID: <052.69025482c09387d2f8082ff0470960de@buildbot.net> #1939: Can not trigger build when I use timed.Nightly with onlyIfChanged=True,using GerritChangeSource -------------------+----------------------- Reporter: clino | Owner: Type: defect | Status: reopened Priority: major | Milestone: 0.8.4 Version: master | Resolution: Keywords: gerrit | -------------------+----------------------- Changes (by clino): * status: closed => reopened * resolution: fixed => Comment: Now the exception not happen,but GerritChangeSource still do not trigger building And I change to SingleBranchScheduler or AnyBranchScheduler,it does not trigger building. Or I have to do more before I use GerritChangeSource? -- Ticket URL: <http://trac.buildbot.net/ticket/1939#comment:3> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Tue May 24 02:47:54 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 24 May 2011 02:47:54 -0000 Subject: [Buildbot-commits] [Buildbot] #1939: Can not trigger build when I use timed.Nightly with onlyIfChanged=True, using GerritChangeSource In-Reply-To: <037.fc48fcede16bcf96e03a993f5a3f2272@buildbot.net> References: <037.fc48fcede16bcf96e03a993f5a3f2272@buildbot.net> Message-ID: <052.fbe2a8edbe103cdbe41a25c37aeb4a64@buildbot.net> #1939: Can not trigger build when I use timed.Nightly with onlyIfChanged=True,using GerritChangeSource -------------------+--------------------- Reporter: clino | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.4 Version: master | Resolution: fixed Keywords: gerrit | -------------------+--------------------- Changes (by dustin): * status: reopened => closed * resolution: => fixed Comment: You may need to configure your schedulers to look for the changes coming from !GerritChangeSource. Check with the mailing list or on IRC, or open a new bug. -- Ticket URL: <http://trac.buildbot.net/ticket/1939#comment:4> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Tue May 24 03:16:07 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 24 May 2011 03:16:07 -0000 Subject: [Buildbot-commits] [Buildbot] #1940: noticeOnChannel undocumented In-Reply-To: <041.a5ae3901a09a0a130e5d47c64b763e3b@buildbot.net> References: <041.a5ae3901a09a0a130e5d47c64b763e3b@buildbot.net> Message-ID: <056.3f60c37acbc134d66e91832af9d2df59@buildbot.net> #1940: noticeOnChannel undocumented ----------------------------------------+--------------------- Reporter: dabrahams | Owner: Type: enhancement | Status: closed Priority: major | Milestone: 0.8.4 Version: master | Resolution: fixed Keywords: docs, simple, redheadphones | ----------------------------------------+--------------------- Changes (by redheadphones): * keywords: docs, simple => docs, simple, redheadphones -- Ticket URL: <http://trac.buildbot.net/ticket/1940#comment:4> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Tue May 24 03:26:12 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 24 May 2011 03:26:12 -0000 Subject: [Buildbot-commits] [Buildbot] #1933: Give config files a reliable way to determine their directory In-Reply-To: <041.61cbc592b4a174f5e38ff6b676e0b7ed@buildbot.net> References: <041.61cbc592b4a174f5e38ff6b676e0b7ed@buildbot.net> Message-ID: <056.c0436a55ca4869ed40a22ffb601beffa@buildbot.net> #1933: Give config files a reliable way to determine their directory ----------------------------------+--------------------- Reporter: dabrahams | Owner: Type: enhancement | Status: closed Priority: major | Milestone: 0.8.4 Version: 0.8.3p1 | Resolution: fixed Keywords: simple, redheadphones | ----------------------------------+--------------------- Changes (by redheadphones): * keywords: simple => simple, redheadphones -- Ticket URL: <http://trac.buildbot.net/ticket/1933#comment:5> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Tue May 24 03:30:20 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 24 May 2011 03:30:20 -0000 Subject: [Buildbot-commits] [Buildbot] #1944: ?project= In-Reply-To: <041.284fa08995a1bb2d59b6361a6d1f9ef5@buildbot.net> References: <041.284fa08995a1bb2d59b6361a6d1f9ef5@buildbot.net> Message-ID: <056.b19949aeb361ee8e965a9d309f81fad5@buildbot.net> #1944: ?project= ---------------------------------------+--------------------- Reporter: dabrahams | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.4 Version: master | Resolution: fixed Keywords: simple, git, redheadphones | ---------------------------------------+--------------------- Changes (by redheadphones): * keywords: simple, git => simple, git, redheadphones -- Ticket URL: <http://trac.buildbot.net/ticket/1944#comment:3> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Tue May 24 03:30:55 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 24 May 2011 03:30:55 -0000 Subject: [Buildbot-commits] [Buildbot] #1949: irc bot force command needs branch option In-Reply-To: <035.193ee026bfec9b27866696576e57c66b@buildbot.net> References: <035.193ee026bfec9b27866696576e57c66b@buildbot.net> Message-ID: <050.daeef379aedbcd7353a5cfbd98da8ea0@buildbot.net> #1949: irc bot force command needs branch option -------------------------------+------------------------ Reporter: H__ | Owner: Type: enhancement | Status: closed Priority: minor | Milestone: undecided Version: 0.8.3p1 | Resolution: fixed Keywords: irc, redheadphones | -------------------------------+------------------------ Changes (by redheadphones): * keywords: irc => irc, redheadphones -- Ticket URL: <http://trac.buildbot.net/ticket/1949#comment:2> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Tue May 24 03:36:09 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 24 May 2011 03:36:09 -0000 Subject: [Buildbot-commits] [Buildbot] #1969: How can I config GerritChangeSource trigger building? Message-ID: <037.93871fe205ab7159e963d8beed138b2d@buildbot.net> #1969: How can I config GerritChangeSource trigger building? -------------------+----------------------- Reporter: clino | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: master | Keywords: -------------------+----------------------- After Ticket #1939 fixed,I can see GerritChangeSource changes in waterfall view.But it does not trigger building. First I use timed.Nightly schedule,after I set "onlyIfChanged=True",it will not build after it is the time I set(if "onlyIfChanged=False",it will build) Then I try SingleBranchScheduler and AnyBranchScheduler,it seems that these 2 can trigger building when receive changes,but these 2 do not work either. Or I have to do more before I use GerritChangeSource? my version: Buildbot: 0.8.4-pre-562-gd3bf906 Twisted: 11.0.0 Jinja: 2.5.5 Python: 2.6.5 (r265:79063, Apr 16 2010, 13:57:41) [GCC 4.4.3] Buildmaster platform: linux2 -- Ticket URL: <http://trac.buildbot.net/ticket/1969> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Tue May 24 03:40:19 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 24 May 2011 03:40:19 -0000 Subject: [Buildbot-commits] [Buildbot] #1968: Multi-prefix support for PBChangeSource In-Reply-To: <037.6e39d558ae82ef5d43aec9db24951f82@buildbot.net> References: <037.6e39d558ae82ef5d43aec9db24951f82@buildbot.net> Message-ID: <052.fa2bd9d0a56832d9a76b2f59de031a75@buildbot.net> #1968: Multi-prefix support for PBChangeSource ------------------------+-------------------- Reporter: LoTek | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.+ Version: 0.8.3p1 | Resolution: Keywords: try | ------------------------+-------------------- Changes (by dustin): * keywords: PBChangeSource, prefix, svn => try * milestone: undecided => 0.8.+ -- Ticket URL: <http://trac.buildbot.net/ticket/1968#comment:2> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Tue May 24 03:41:25 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 24 May 2011 03:41:25 -0000 Subject: [Buildbot-commits] [Buildbot] #1911: Cannot checkout from default branch trunk when creating a Scheduler that uses SVN repository. Failure by using keyword None as branch In-Reply-To: <039.8112b27cb69f91b9f8b466fb87e8e70a@buildbot.net> References: <039.8112b27cb69f91b9f8b466fb87e8e70a@buildbot.net> Message-ID: <054.ed86de4dda5fce78a183410f7dbe3eb8@buildbot.net> #1911: Cannot checkout from default branch trunk when creating a Scheduler that uses SVN repository. Failure by using keyword None as branch ----------------------------+---------------------- Reporter: rodrigo | Owner: Type: support-request | Status: new Priority: critical | Milestone: ongoing Version: 0.7.12 | Resolution: Keywords: svn | ----------------------------+---------------------- Changes (by dustin): * keywords: None, Scheduler, SVN, trunk, default branch => svn * milestone: undecided => ongoing -- Ticket URL: <http://trac.buildbot.net/ticket/1911#comment:3> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Tue May 24 03:41:54 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 24 May 2011 03:41:54 -0000 Subject: [Buildbot-commits] [Buildbot] #1962: Source steps should take an env paramater. In-Reply-To: <042.bb3f08bde133c0fe0588df258091dcbb@buildbot.net> References: <042.bb3f08bde133c0fe0588df258091dcbb@buildbot.net> Message-ID: <057.0dcb81567fc04e58e234e49a5e0696f3@buildbot.net> #1962: Source steps should take an env paramater. --------------------------------------------------+-------------------- Reporter: tom.prince | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.+ Version: 0.8.3p1 | Resolution: Keywords: bk, bzr, cvs, darcs, git, hg, p4, svn | --------------------------------------------------+-------------------- Changes (by dustin): * cc: in3xes (added) * keywords: source => bk, bzr, cvs, darcs, git, hg, p4, svn * milestone: undecided => 0.8.+ -- Ticket URL: <http://trac.buildbot.net/ticket/1962#comment:1> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Tue May 24 03:42:17 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 24 May 2011 03:42:17 -0000 Subject: [Buildbot-commits] [Buildbot] #1969: How can I config GerritChangeSource trigger building? In-Reply-To: <037.93871fe205ab7159e963d8beed138b2d@buildbot.net> References: <037.93871fe205ab7159e963d8beed138b2d@buildbot.net> Message-ID: <052.d7d3a8667dffb456cfc7b315538256c5@buildbot.net> #1969: How can I config GerritChangeSource trigger building? ----------------------------+---------------------- Reporter: clino | Owner: Type: support-request | Status: new Priority: major | Milestone: ongoing Version: master | Resolution: Keywords: gerrit | ----------------------------+---------------------- Changes (by dustin): * keywords: => gerrit * type: defect => support-request * milestone: undecided => ongoing Comment: It's hard to answer this question without knowing what you're doing. What is your configuration, and what behavior are you seeing? What have you done to try to troubleshoot? -- Ticket URL: <http://trac.buildbot.net/ticket/1969#comment:1> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Tue May 24 03:42:54 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 24 May 2011 03:42:54 -0000 Subject: [Buildbot-commits] [Buildbot] #1942: Store passwords in hashed form In-Reply-To: <041.ab8723608c9e5208d80dd1a487892b28@buildbot.net> References: <041.ab8723608c9e5208d80dd1a487892b28@buildbot.net> Message-ID: <056.2385757dec0c2787ef329713e72416e0@buildbot.net> #1942: Store passwords in hashed form -------------------------+------------------------ Reporter: dabrahams | Owner: Type: enhancement | Status: new Priority: major | Milestone: undecided Version: 0.8.3p1 | Resolution: Keywords: redheaphones | -------------------------+------------------------ Changes (by dustin): * cc: redheadphones (added) * keywords: auth => redheaphones -- Ticket URL: <http://trac.buildbot.net/ticket/1942#comment:3> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Tue May 24 04:01:32 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 24 May 2011 04:01:32 -0000 Subject: [Buildbot-commits] [Buildbot] #1784: Buildmaster blocks In-Reply-To: <040.b9bf7390b4609c7970b110cd158d5cf1@buildbot.net> References: <040.b9bf7390b4609c7970b110cd158d5cf1@buildbot.net> Message-ID: <055.ee415014b84c14996ce16565807cdb83@buildbot.net> #1784: Buildmaster blocks ---------------------+-------------------- Reporter: Schenker | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.4 Version: 0.8.0 | Resolution: Keywords: | ---------------------+-------------------- Comment (by dustin): Do you have a firewall between your master and slave? -- Ticket URL: <http://trac.buildbot.net/ticket/1784#comment:7> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Tue May 24 04:06:06 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 24 May 2011 04:06:06 -0000 Subject: [Buildbot-commits] [Buildbot] #1886: who submitted try? In-Reply-To: <035.87bfcb3d119881308ffe6c4d41d41bf1@buildbot.net> References: <035.87bfcb3d119881308ffe6c4d41d41bf1@buildbot.net> Message-ID: <050.852b8ab57046cb96a757b541190ca1ef@buildbot.net> #1886: who submitted try? --------------------------+-------------------- Reporter: gg0 | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.4 Version: 0.8.3 | Resolution: Keywords: redheadphones | --------------------------+-------------------- Changes (by redheadphones): * keywords: => redheadphones -- Ticket URL: <http://trac.buildbot.net/ticket/1886#comment:2> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Tue May 24 05:26:56 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 24 May 2011 05:26:56 -0000 Subject: [Buildbot-commits] [Buildbot] #1957: Expand blamelist only by 'interested users' that are relevant for the build. In-Reply-To: <041.c8c3a27c9095e765e20f8885cd5613d6@buildbot.net> References: <041.c8c3a27c9095e765e20f8885cd5613d6@buildbot.net> Message-ID: <056.459d1dfc0803751c843f3b3dcc5306b0@buildbot.net> #1957: Expand blamelist only by 'interested users' that are relevant for the build. --------------------------+-------------------- Reporter: rgoergens | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.3p1 | Resolution: Keywords: redheadphones | --------------------------+-------------------- Changes (by redheadphones): * keywords: => redheadphones -- Ticket URL: <http://trac.buildbot.net/ticket/1957#comment:2> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Tue May 24 05:37:03 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 24 May 2011 05:37:03 -0000 Subject: [Buildbot-commits] [Buildbot] #1968: Multi-prefix support for PBChangeSource In-Reply-To: <037.6e39d558ae82ef5d43aec9db24951f82@buildbot.net> References: <037.6e39d558ae82ef5d43aec9db24951f82@buildbot.net> Message-ID: <052.77643d88e4c75d64870f033df09a6754@buildbot.net> #1968: Multi-prefix support for PBChangeSource ------------------------+-------------------- Reporter: LoTek | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.+ Version: 0.8.3p1 | Resolution: Keywords: try | ------------------------+-------------------- Comment (by LoTek): That's what I get for doing things in a rush, you're right, could just go with (self.prefixes,) -- Ticket URL: <http://trac.buildbot.net/ticket/1968#comment:3> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Tue May 24 06:15:38 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 24 May 2011 06:15:38 -0000 Subject: [Buildbot-commits] [Buildbot] #1969: How can I config GerritChangeSource trigger building? In-Reply-To: <037.93871fe205ab7159e963d8beed138b2d@buildbot.net> References: <037.93871fe205ab7159e963d8beed138b2d@buildbot.net> Message-ID: <052.b13e92805bae7db0b8b17dc02d5ddc7b@buildbot.net> #1969: How can I config GerritChangeSource trigger building? ----------------------------+---------------------- Reporter: clino | Owner: Type: support-request | Status: new Priority: major | Milestone: ongoing Version: master | Resolution: Keywords: gerrit | ----------------------------+---------------------- Comment (by clino): I modify my master.cfg from buildbot/master/docs/examples/repo_gerrit.cfg. related python code snippets: first time: {{{ from buildbot.changes.gerritchangesource import GerritChangeSource c['change_source'] = GerritChangeSource(gerrit_server, gerrit_user) #.... from buildbot.schedulers import timed from buildbot.changes.filter import ChangeFilter daily_sched = timed.Nightly(name="daily", branch = None, builderNames=get_buildernames("daily"), dayOfWeek=range(0,5), hour=[10,12,15,18,23], onlyIfChanged=False,#if change to "onlyIfChanged=False",it will not build at all ) }}} Using this config I can see changes in waterfall view,and in builder column,it show something like"waiting next in ~ 45 mins at 15:00 ",and when time is up it will begin build,but after change to "onlyIfChanged=False",it will not build even time is up. -- Ticket URL: <http://trac.buildbot.net/ticket/1969#comment:2> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Tue May 24 06:27:12 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 24 May 2011 06:27:12 -0000 Subject: [Buildbot-commits] [Buildbot] #1969: How can I config GerritChangeSource trigger building? In-Reply-To: <037.93871fe205ab7159e963d8beed138b2d@buildbot.net> References: <037.93871fe205ab7159e963d8beed138b2d@buildbot.net> Message-ID: <052.00fbdfcbc16145585865569ae96ad217@buildbot.net> #1969: How can I config GerritChangeSource trigger building? ----------------------------+---------------------- Reporter: clino | Owner: Type: support-request | Status: new Priority: major | Milestone: ongoing Version: master | Resolution: Keywords: gerrit | ----------------------------+---------------------- Comment (by clino): Then after I read manual,I try SingleBranchScheduler and AnyBranchScheduler,they do not work either. my config: {{{ from buildbot.schedulers.basic import SingleBranchScheduler,AnyBranchScheduler quick = AnyBranchScheduler(name="quick", treeStableTimer=10, builderNames=["test_master"]) c['schedulers'] = [quick] }}} and I make the gerrit receive some push,I can see them in changes column in waterfall view,but the build not trigger,it always show "idle" -- Ticket URL: <http://trac.buildbot.net/ticket/1969#comment:3> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Tue May 24 18:58:28 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 24 May 2011 18:58:28 -0000 Subject: [Buildbot-commits] [Buildbot] #1963: FileUpload creates truncated file when buildslave is not on localhost In-Reply-To: <038.d8aba18af3dd124e6fb92915e876c160@buildbot.net> References: <038.d8aba18af3dd124e6fb92915e876c160@buildbot.net> Message-ID: <053.e4b31547bf7b30fcd024f8d6109e4496@buildbot.net> #1963: FileUpload creates truncated file when buildslave is not on localhost ----------------------+------------------------ Reporter: landry | Owner: Type: undecided | Status: new Priority: major | Milestone: undecided Version: 0.8.3p1 | Resolution: Keywords: | ----------------------+------------------------ Comment (by landry): I've just changed debug = True in buildslave/commands/transfer.py, and here's what i'm getting : {{{ 2011-05-24 09:54:39+0200 [Broker,client] startCommand:uploadFile [id 1576] 2011-05-24 09:54:39+0200 [Broker,client] SlaveFileUploadCommand started 2011-05-24 09:54:39+0200 [Broker,client] Opened '/var/buildslave/mozilla- aurora-sparc64/build/objdir/dist/firefox-5.0a2.en- US.openbsd4.9-sparc64.tar.bz2' for upload 2011-05-24 09:54:39+0200 [Broker,client] sendStatus {'header': 'sending /var/buildslave/mozilla-aurora-sparc64/build/objdir/dist/firefox-5.0a2.en- US.openbsd4.9-sparc64.tar.bz2'} 2011-05-24 09:54:39+0200 [-] SlaveFileUploadCommand._writeBlock(): allowed=16384 readlen=14 2011-05-24 09:54:39+0200 [Broker,client] SlaveFileUploadCommand._writeBlock(): allowed=16384 readlen=0 2011-05-24 09:54:39+0200 [Broker,client] EOF: callRemote(close) 2011-05-24 09:54:39+0200 [Broker,client] finished: stderr=None, rc=0 2011-05-24 09:54:39+0200 [Broker,client] sendStatus {'rc': 0} 2011-05-24 09:54:39+0200 [Broker,client] SlaveBuilder.commandComplete <buildslave.commands.transfer.SlaveFileUploadCommand instance at 0x2087e9b00> }}} So it looks like the slave has some issues reading the file, but the file was generated by the previous buildstep (make package), and is supposed to be here. I was using previously the following steps : - run a script which copies the file in a known dir on the slave - DirectoryUpload the dir to the master and it worked... -- Ticket URL: <http://trac.buildbot.net/ticket/1963#comment:4> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Wed May 25 04:08:54 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 25 May 2011 04:08:54 -0000 Subject: [Buildbot-commits] [Buildbot] #1969: How can I config GerritChangeSource trigger building? In-Reply-To: <037.93871fe205ab7159e963d8beed138b2d@buildbot.net> References: <037.93871fe205ab7159e963d8beed138b2d@buildbot.net> Message-ID: <052.171cf7ba50090f9e2d113043db966096@buildbot.net> #1969: How can I config GerritChangeSource trigger building? ----------------------------+---------------------- Reporter: clino | Owner: Type: support-request | Status: new Priority: major | Milestone: ongoing Version: master | Resolution: Keywords: gerrit | ----------------------------+---------------------- Comment (by dustin): When you click on the changes in the waterfall, what branch do you see? I suspect that the !AnyBranchScheduler is ignoring the changes for some reason.. -- Ticket URL: <http://trac.buildbot.net/ticket/1969#comment:4> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Wed May 25 04:41:57 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 25 May 2011 04:41:57 -0000 Subject: [Buildbot-commits] [Buildbot] #1963: FileUpload creates truncated file when buildslave is not on localhost In-Reply-To: <038.d8aba18af3dd124e6fb92915e876c160@buildbot.net> References: <038.d8aba18af3dd124e6fb92915e876c160@buildbot.net> Message-ID: <053.961ee74aecb4b8a54a3146ebbc1edad5@buildbot.net> #1963: FileUpload creates truncated file when buildslave is not on localhost ----------------------+------------------------ Reporter: landry | Owner: Type: undecided | Status: new Priority: major | Milestone: undecided Version: 0.8.3p1 | Resolution: Keywords: | ----------------------+------------------------ Comment (by dustin): So I bet that the previous step isn't done writing that file when it's uploaded. "BZh9" is a BZ2 header - http://en.wikipedia.org/wiki/Bzip2#File_format So it's getting the bytes from the file - just only 14 of them. Is the file on NFS? Are you sure 'make package' is done by the time 'make' exits? IIRC there are versions of tar which don't wait for the compression subprocess to exit before exiting -- maybe bzip is still running? Running 'make package && sleep 10' might help. -- Ticket URL: <http://trac.buildbot.net/ticket/1963#comment:5> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Wed May 25 05:42:40 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 25 May 2011 05:42:40 -0000 Subject: [Buildbot-commits] [Buildbot] #1969: How can I config GerritChangeSource trigger building? In-Reply-To: <037.93871fe205ab7159e963d8beed138b2d@buildbot.net> References: <037.93871fe205ab7159e963d8beed138b2d@buildbot.net> Message-ID: <052.6ea5add33a5ddbb1b4ee877210858a38@buildbot.net> #1969: How can I config GerritChangeSource trigger building? ----------------------------+---------------------- Reporter: clino | Owner: Type: support-request | Status: new Priority: major | Milestone: ongoing Version: master | Resolution: Keywords: gerrit | ----------------------------+---------------------- Comment (by clino): Replying to [comment:4 dustin]: > When you click on the changes in the waterfall, what branch do you see? I suspect that the !AnyBranchScheduler is ignoring the changes for some reason.. I just git push a test branch "work",and after click the changes in the waterfall,I see "work",I think it is right. If AnyBrnchScheduler ignore the changes,so do SingleBranchScheduler and timed.Nightly scheduler? I try to read the code of buildbot,but so complicated that I can not find where the changes trigger the building action. -- Ticket URL: <http://trac.buildbot.net/ticket/1969#comment:5> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Wed May 25 05:48:16 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 25 May 2011 05:48:16 -0000 Subject: [Buildbot-commits] [Buildbot] #1969: How can I config GerritChangeSource trigger building? In-Reply-To: <037.93871fe205ab7159e963d8beed138b2d@buildbot.net> References: <037.93871fe205ab7159e963d8beed138b2d@buildbot.net> Message-ID: <052.64eab85d203d9a4673c0e217d7a1f468@buildbot.net> #1969: How can I config GerritChangeSource trigger building? ----------------------------+---------------------- Reporter: clino | Owner: Type: support-request | Status: new Priority: major | Milestone: ongoing Version: master | Resolution: Keywords: gerrit | ----------------------------+---------------------- Comment (by dustin): This is probably the function you want to look at, in master/buildbot/schedulers/basic.py: {{{ #!py def changeCallback(change): # ignore changes delivered while we're not running if not self._change_subscription: return if change_filter and not change_filter.filter_change(change): return if fileIsImportant: try: important = fileIsImportant(change) except: log.err(failure.Failure(), 'in fileIsImportant check for %s' % change) return else: important = True }}} If you insert a few 'print' statements at various points (probably before and after the change_filter check), you should be able to see what's going on. You may also want to update to the most recent commits on master - many bugs have been fixed since May 2. -- Ticket URL: <http://trac.buildbot.net/ticket/1969#comment:6> Buildbot <http://buildbot.net/> Buildbot: build/test automation From noreply at github.com Wed May 25 05:56:49 2011 From: noreply at github.com (noreply at github.com) Date: Tue, 24 May 2011 22:56:49 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] f46514: fix reference loop between buildbot.status.buildre... Message-ID: <20110525055649.1B37D42492@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: f46514a47a16ff18044ef697b2da0d80e2225960 https://github.com/buildbot/buildbot/commit/f46514a47a16ff18044ef697b2da0d80e2225960 Author: Dustin J. Mitchell <dustin at v.igoro.us> Date: 2011-05-24 (Tue, 24 May 2011) Changed paths: M master/buildbot/status/buildrequest.py Log Message: ----------- fix reference loop between buildbot.status.buildrequest and buildbot.process.buildrequest From nobody at buildbot.net Wed May 25 06:56:52 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 25 May 2011 06:56:52 -0000 Subject: [Buildbot-commits] [Buildbot] #1886: who submitted try? In-Reply-To: <035.87bfcb3d119881308ffe6c4d41d41bf1@buildbot.net> References: <035.87bfcb3d119881308ffe6c4d41d41bf1@buildbot.net> Message-ID: <050.68652a9a46b36e0ee48d202d7bf6aab5@buildbot.net> #1886: who submitted try? --------------------------+---------------------------- Reporter: gg0 | Owner: redheadphones Type: enhancement | Status: assigned Priority: major | Milestone: 0.8.4 Version: 0.8.3 | Resolution: Keywords: redheadphones | --------------------------+---------------------------- Changes (by redheadphones): * owner: => redheadphones * status: new => assigned -- Ticket URL: <http://trac.buildbot.net/ticket/1886#comment:3> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Wed May 25 08:05:09 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 25 May 2011 08:05:09 -0000 Subject: [Buildbot-commits] [Buildbot] #1963: FileUpload creates truncated file when buildslave is not on localhost In-Reply-To: <038.d8aba18af3dd124e6fb92915e876c160@buildbot.net> References: <038.d8aba18af3dd124e6fb92915e876c160@buildbot.net> Message-ID: <053.8f1a795dd948ac0dc05ab187c911add4@buildbot.net> #1963: FileUpload creates truncated file when buildslave is not on localhost ----------------------+------------------------ Reporter: landry | Owner: Type: undecided | Status: new Priority: major | Milestone: undecided Version: 0.8.3p1 | Resolution: Keywords: | ----------------------+------------------------ Comment (by landry): As a sidenote, i've ruled out the symlink from the equation. If objdir is a real dir, it fails the same. The file sure does exist as the previous build steps are : {{{ factory.addStep(SetProperty(name="get package name", command="find objdir/ -name *.tar.bz2 -exec basename {} \;", property='package_name')) factory.addStep(SetProperty(name="get package path", command="find objdir/ -name *.tar.bz2", property='package_path')) }}} But those steps don't check for the file size. The command run by make package is {{{ tar -c --owner=0 --group=0 --numeric-owner --mode="go-w" -f - firefox | bzip2 -vf > firefox-5.0a2.en-US.openbsd4.9-sparc64.tar.bz2 }}} It's in a subshell, but in the middle of make package step, ie the langpacks are created after (see full log at http://buildbot.rhaalovely.net/builders/mozilla-aurora- sparc64/builds/23/steps/package/logs/stdio) The file isn't on NFS, but i'll add a sleep 5 command before the FileUpload step. To check if that can be the issue, but then i wonder why i don't see it on the other host (where buildslave and buildmaster are on the same host) -- Ticket URL: <http://trac.buildbot.net/ticket/1963#comment:6> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Wed May 25 09:03:53 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 25 May 2011 09:03:53 -0000 Subject: [Buildbot-commits] [Buildbot] #1970: IRC status notifier is reconnecting too fast Message-ID: <037.f93a33de7d321ac6aed00eaf68e15f66@buildbot.net> #1970: IRC status notifier is reconnecting too fast ------------------------+----------------------- Reporter: Almad | Owner: Type: enhancement | Status: new Priority: major | Milestone: undecided Version: 0.8.0 | Keywords: ------------------------+----------------------- IRC servers are mostly configured to require some interval between reconnecting. Multiple IRC status plugins running on same machine can deny each other access by flooding irc server. Solution would be to add a parameter to allow reconnection interval, plus maybe use some random as default. -- Ticket URL: <http://trac.buildbot.net/ticket/1970> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Wed May 25 13:12:27 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 25 May 2011 13:12:27 -0000 Subject: [Buildbot-commits] [Buildbot] #1963: FileUpload creates truncated file when buildslave is not on localhost In-Reply-To: <038.d8aba18af3dd124e6fb92915e876c160@buildbot.net> References: <038.d8aba18af3dd124e6fb92915e876c160@buildbot.net> Message-ID: <053.8d0935fc9046f89b083f7f213df2e446@buildbot.net> #1963: FileUpload creates truncated file when buildslave is not on localhost ----------------------+------------------------ Reporter: landry | Owner: Type: undecided | Status: new Priority: major | Milestone: undecided Version: 0.8.3p1 | Resolution: Keywords: | ----------------------+------------------------ Comment (by landry): Alas, adding a sleep 10 step didnt fix it. Still the same issue. See http://buildbot.rhaalovely.net/builders/mozilla-aurora- sparc64/builds/24, and the resulting http://buildbot.rhaalovely.net/builds /mozilla-aurora- sparc64/2011-05-25-58ed2542c7968d987b1060621f690226d248e8e0/ Given that the previous find step lasts 5 secs, sleep adds 10 sec to that, i'd be surprised if the file is not fully here on the filesystem after 15 secs. If you give me the code to check for a file size in python i'll paste it in the SlaveFileUploadCommand.writeBlock() function.. -- Ticket URL: <http://trac.buildbot.net/ticket/1963#comment:7> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Wed May 25 15:20:56 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 25 May 2011 15:20:56 -0000 Subject: [Buildbot-commits] [Buildbot] #1963: FileUpload creates truncated file when buildslave is not on localhost In-Reply-To: <038.d8aba18af3dd124e6fb92915e876c160@buildbot.net> References: <038.d8aba18af3dd124e6fb92915e876c160@buildbot.net> Message-ID: <053.88d86bedde85354fec63f16623311169@buildbot.net> #1963: FileUpload creates truncated file when buildslave is not on localhost ----------------------+------------------------ Reporter: landry | Owner: Type: undecided | Status: new Priority: major | Milestone: undecided Version: 0.8.3p1 | Resolution: Keywords: | ----------------------+------------------------ Comment (by dustin): This should do the trick: {{{ #!py import os, stat print os.fstat(self.fp.fileno()) }}} Since one read returns 14, and the next returns 0, *something* funny is going on here! -- Ticket URL: <http://trac.buildbot.net/ticket/1963#comment:8> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Thu May 26 15:41:48 2011 From: nobody at buildbot.net (Buildbot) Date: Thu, 26 May 2011 15:41:48 -0000 Subject: [Buildbot-commits] [Buildbot] #1971: Nightly timered build using incorrect change for revision Message-ID: <036.779b116119e5a128e7a6989ab6e5a352@buildbot.net> #1971: Nightly timered build using incorrect change for revision --------------------+----------------------- Reporter: zacw | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.3p1 | Keywords: --------------------+----------------------- == Summary == Given a list of changes, a nightly build performs the build using the revision from a historical change, not the latest change in the list. == Environment == * '''Buildbot''': 0.8.4-pre-639-g82d83fd * '''Twisted''': 8.2.0 * '''Jinja''': 2.5.5 * '''Python''': 2.6.1 (!r261:67515, Jun 24 2010, 21:47:49) [GCC 4.2.1 (Apple Inc. build 5646)] * '''Buildmaster platform''': darwin == Steps to reproduce == (Ignore any obvious incongruities; copying/pasting the setup code from more generic code.) 1. Create a nightly build with the following generic setup: {{{ c['schedulers'].append(timed.Nightly( name ="icephone-unstable-nightly", branch = "branches/icephone-1.10", builderNames = ["icephone-unstable-nightly"], hour = 7, minute = 0, onlyIfChanged = True)) }}} 1. Create an SVNPoller source for the change: {{{ c['change_source'].append(SVNPoller( svnurl = REPOSITORY_ICEPHONE, project = "icephone", svnuser = SVN_USERNAME, svnpasswd = SVN_PASSWORD, split_file = split_file_branches, pollInterval = POLL_INTERVAL_SEC)) }}} 1. Perform a number of commits on the branch for the nightly. 1. Observe nightly build using the incorrect revision from a given change list. == Expected result == Nightly build sorts the list of its changes, and uses the latest change to pluck the revision for the build. == Actual Result == Nightly build picks an incorrect change, which yields the incorrect revision being built by the builder. == Debug Logs == From the master, at poll time: {{{ 2011-05-25 11:50:50-0400 [-] svnPoller: _process_changes 5435 .. 5438 2011-05-25 11:50:50-0400 [-] Adding change revision 5436 2011-05-25 11:50:50-0400 [-] Adding change revision 5437 2011-05-25 11:50:50-0400 [-] Adding change revision 5438 2011-05-25 11:50:50-0400 [-] WARNING: change source is using deprecated addChange parameter 'who' 2011-05-25 11:50:50-0400 [-] added change Change(who=u'zwest', files=[?redacted?], comments=u'?redacted?', revision=u'5436', when=1306338650, category=None, project=u'icephone', repository=u'?redacted/icephone') to database 2011-05-25 11:50:50-0400 [-] WARNING: change source is using deprecated addChange parameter 'who' 2011-05-25 11:50:50-0400 [-] added change Change(who=u'zwest', files=[?redacted?], comments=u'?redacted?', revision=u'5437', when=1306338650, category=None, project=u'icephone', repository=u'?redacted/icephone') to database 2011-05-25 11:50:50-0400 [-] WARNING: change source is using deprecated addChange parameter 'who' 2011-05-25 11:50:50-0400 [-] added change Change(who=u'zwest', files=[?redacted?], comments=u'?redacted?', revision=u'5438', when=1306338650, category=None, project=u'icephone', repository=u'?redacted/icephone') to database 2011-05-25 11:50:50-0400 [-] SVNPoller finished polling None ? 2011-05-25 13:46:48-0400 [-] svnPoller: _process_changes 5438 .. 5442 2011-05-25 13:46:48-0400 [-] Adding change revision 5439 2011-05-25 13:46:48-0400 [-] Adding change revision 5440 2011-05-25 13:46:48-0400 [-] Adding change revision 5441 2011-05-25 13:46:48-0400 [-] Adding change revision 5442 2011-05-25 13:46:48-0400 [-] WARNING: change source is using deprecated addChange parameter 'who' 2011-05-25 13:46:48-0400 [-] added change Change(who=u'zwest', files=[?redacted?], comments=u'?redacted?', revision=u'5439', when=1306345608, category=None, project=u'icephone', repository=u'?redacted/icephone') to database 2011-05-25 13:46:48-0400 [-] WARNING: change source is using deprecated addChange parameter 'who' 2011-05-25 13:46:49-0400 [-] added change Change(who=u'zwest', files=[?redacted?], comments=u'?redacted?', revision=u'5440', when=1306345608, category=None, project=u'icephone', repository=u'?redacted/icephone') to database 2011-05-25 13:46:49-0400 [-] WARNING: change source is using deprecated addChange parameter 'who' 2011-05-25 13:46:49-0400 [-] added change Change(who=u'zwest', files=[?redacted?], comments=u'?redacted?', revision=u'5441', when=1306345609, category=None, project=u'icephone', repository=u'?redacted/icephone') to database 2011-05-25 13:46:49-0400 [-] WARNING: change source is using deprecated addChange parameter 'who' 2011-05-25 13:46:49-0400 [-] added change Change(who=u'zwest', files=[?redacted?], comments=u'?redacted?', revision=u'5442', when=1306345609, category=None, project=u'icephone', repository=u'?redacted/icephone') to database 2011-05-25 13:46:49-0400 [-] SVNPoller finished polling None }}} From the master, at build time: {{{ 2011-05-26 07:00:50-0400 [-] ShellCommand.startCommand(cmd=<RemoteCommand 'svn' at 4331438024>) 2011-05-26 07:00:50-0400 [-] cmd.args = {'username': '?redacted?', 'password': '?redacted?', 'workdir': 'build', 'patch': None, 'retry': None, 'mode': 'update', 'timeout': 1200, 'svnurl': u'?redacted/icephone/branches/icephone-1.10', 'always_purge': None, 'revision': u'5437'} 2011-05-26 07:00:50-0400 [-] <RemoteCommand 'svn' at 4331438024>: RemoteCommand.run [75] 2011-05-26 07:00:50-0400 [-] LoggedRemoteCommand.start 2011-05-26 07:00:51-0400 [-] sending ping 2011-05-26 07:00:51-0400 [Broker,0,127.0.0.1] ping finished: success 2011-05-26 07:01:01-0400 [Broker,0,127.0.0.1] <RemoteCommand 'svn' at 4331438024> rc=0 2011-05-26 07:01:01-0400 [-] closing log <buildbot.status.logfile.LogFile instance at 0x10421e950> 2011-05-26 07:01:01-0400 [-] releaseLocks(<buildbot.steps.source.SVN instance at 0x1038a9830>): [] 2011-05-26 07:01:01-0400 [-] step 'svn' complete: success ?build steps redacted? 2011-05-26 07:53:11-0400 [-] <Build icephone-stable-nightly>: build finished 2011-05-26 07:53:11-0400 [-] setting expectations for next time 2011-05-26 07:53:11-0400 [-] new expectations: 3227.62330431 seconds }}} == Changes in build == From the !WebStatus output, these are the changes in order. The final one (!#31) is the revision it chose to build (!r5437): === Change !#32 === {{{ Changed by zwest Changed at Wed 25 May 2011 11:50:50 Repository ?redacted/icephone Project icephone Branch branches/icephone-1.10 Revision 5438 Comments ?redacted? Changed files ?redacted }}} === Change !#35 === {{{ Changed by zwest Changed at Wed 25 May 2011 13:46:49 Repository ?redacted/icephone Project icephone Branch branches/icephone-1.10 Revision 5441 Comments ?redacted? Changed files ?redacted? }}} === Change !#36 === {{{ Changed by zwest Changed at Wed 25 May 2011 13:46:49 Repository ?redacted/icephone Project icephone Branch branches/icephone-1.10 Revision 5442 Comments ?redacted? Changed files ?redacted? }}} === Change !#31 === {{{ Changed by zwest Changed at Wed 25 May 2011 11:50:50 Repository ?redacted/icephone Project icephone Branch branches/icephone-1.10 Revision 5437 Comments ?redacted? Changed files ?redacted? }}} == Build Data == ||Name||Value||Source|| ||branch||branches/icephone-1.10||Build|| ||buildername||icephone-stable-nightly||Builder|| ||buildnumber||5||Build|| ||got_revision||5437||Source|| ||project||icephone||Build|| ||repository||?redacted/icephone||Build|| ||revision||5437||Build|| ||scheduler||icephone-stable-nightly||Scheduler|| ||slavename||QAMacbookPro||BuildSlave|| ||warnings-count||34656||WarningCountingShellCommand|| ||workdir||/Users/buildbot/bb/slave/icephone-stable-nightly||slave|| (How awesome is that warning count?) == Notes == I've stashed away the debug log in case you need more information. Just want to strip away any information that needs redacting, so let me know if you need more. -- Ticket URL: <http://trac.buildbot.net/ticket/1971> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Thu May 26 18:31:31 2011 From: nobody at buildbot.net (Buildbot) Date: Thu, 26 May 2011 18:31:31 -0000 Subject: [Buildbot-commits] [Buildbot] #1959: svn sourcestep mode="copy" always_purge=True fails with externals. In-Reply-To: <038.636b061c8766d32821938963a900ef49@buildbot.net> References: <038.636b061c8766d32821938963a900ef49@buildbot.net> Message-ID: <053.c8ce2af656b857c00170bddf444ed615@buildbot.net> #1959: svn sourcestep mode="copy" always_purge=True fails with externals. --------------------+-------------------- Reporter: tfogal | Owner: Type: defect | Status: new Priority: trivial | Milestone: 0.8.+ Version: 0.8.1 | Resolution: Keywords: svn | --------------------+-------------------- Changes (by tfogal): * priority: minor => trivial Comment: I blew away the slave's builder directory complete, the master's log directory for this, and the master's state.sqlite, then upgraded the slave to the latest release. Everything appears to be fine now. So I guess this issue is more complicated; there was some sort of state that was messed up. Sorry for changing so much in one go && thus confusing what the real issue is... -- Ticket URL: <http://trac.buildbot.net/ticket/1959#comment:4> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Fri May 27 04:09:16 2011 From: nobody at buildbot.net (Buildbot) Date: Fri, 27 May 2011 04:09:16 -0000 Subject: [Buildbot-commits] [Buildbot] #1971: Nightly timered build using incorrect change for revision In-Reply-To: <036.779b116119e5a128e7a6989ab6e5a352@buildbot.net> References: <036.779b116119e5a128e7a6989ab6e5a352@buildbot.net> Message-ID: <051.06ff812c5f64a2c31d3226bd57b1e695@buildbot.net> #1971: Nightly timered build using incorrect change for revision --------------------+------------------------ Reporter: zacw | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.3p1 | Resolution: Keywords: | --------------------+------------------------ Comment (by dustin): Here's the code in {{{Nightly}}} that's handling this case: {{{ #!python changeids = sorted(classifications.keys()) wfd = defer.waitForDeferred( self.addBuildsetForChanges(reason=self.reason, changeids=changeids)) yield wfd wfd.getResult() }}} so from what I can tell, changeids should be [31,32,35,36] in this case. Then, in source:master/buildbot/schedulers/base.py, {{{ #!python # attributes for this sourcestamp will be based on the most recent # change, so fetch the change with the highest id d = self.master.db.changes.getChange(max(changeids)) def chdict2change(chdict): if not chdict: return None return changes.Change.fromChdict(self.master, chdict) d.addCallback(chdict2change) def create_sourcestamp(change): return self.master.db.sourcestamps.addSourceStamp( branch=change.branch, revision=change.revision, repository=change.repository, project=change.project, changeids=changeids) d.addCallback(create_sourcestamp) d.addCallback(self.addBuildsetForSourceStamp, reason=reason, external_idstring=external_idstring, builderNames=builderNames, properties=properties) return d }}} so max(changeids) there should be 36, not 31. Can you add some {{{print}}} statements to this code to verify, or to see what's wrong? -- Ticket URL: <http://trac.buildbot.net/ticket/1971#comment:1> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Fri May 27 04:09:38 2011 From: nobody at buildbot.net (Buildbot) Date: Fri, 27 May 2011 04:09:38 -0000 Subject: [Buildbot-commits] [Buildbot] #1971: Nightly timered build using incorrect change for revision In-Reply-To: <036.779b116119e5a128e7a6989ab6e5a352@buildbot.net> References: <036.779b116119e5a128e7a6989ab6e5a352@buildbot.net> Message-ID: <051.9c49d25948920d22a8ef337c318e6d33@buildbot.net> #1971: Nightly timered build using incorrect change for revision -------------------+-------------------- Reporter: zacw | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.4 Version: master | Resolution: Keywords: | -------------------+-------------------- Changes (by dustin): * version: 0.8.3p1 => master * milestone: undecided => 0.8.4 -- Ticket URL: <http://trac.buildbot.net/ticket/1971#comment:2> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Fri May 27 04:13:21 2011 From: nobody at buildbot.net (Buildbot) Date: Fri, 27 May 2011 04:13:21 -0000 Subject: [Buildbot-commits] [Buildbot] #1959: svn sourcestep mode="copy" always_purge=True fails with externals. In-Reply-To: <038.636b061c8766d32821938963a900ef49@buildbot.net> References: <038.636b061c8766d32821938963a900ef49@buildbot.net> Message-ID: <053.f998d34b5fb52fb0860d6aaf76662200@buildbot.net> #1959: svn sourcestep mode="copy" always_purge=True fails with externals. --------------------+------------------------- Reporter: tfogal | Owner: Type: defect | Status: closed Priority: trivial | Milestone: 0.8.+ Version: 0.8.1 | Resolution: worksforme Keywords: svn | --------------------+------------------------- Changes (by dustin): * status: new => closed * resolution: => worksforme Comment: Let's see if someone else finds the ticket and can reproduce :( -- Ticket URL: <http://trac.buildbot.net/ticket/1959#comment:5> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Fri May 27 15:39:07 2011 From: nobody at buildbot.net (Buildbot) Date: Fri, 27 May 2011 15:39:07 -0000 Subject: [Buildbot-commits] [Buildbot] #1971: Nightly timered build using incorrect change for revision In-Reply-To: <036.779b116119e5a128e7a6989ab6e5a352@buildbot.net> References: <036.779b116119e5a128e7a6989ab6e5a352@buildbot.net> Message-ID: <051.e46417f7fe32a4915b04d3b7abd72468@buildbot.net> #1971: Nightly timered build using incorrect change for revision -------------------+-------------------- Reporter: zacw | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.4 Version: master | Resolution: Keywords: | -------------------+-------------------- Comment (by zacw): Looks like I can reproduce it by commtting to trunk and the branch (in separate revisions, of course). Order displayed in !WebStatus: {{{[48, 49, 45, 46, 47]}}}.[[br]] {{{changeids}}} in the {{{timed.py}}} code: {{{[45, 46, 47, 48, 49]}}}.[[br]] {{{max(changeids)}}} in the {{{base.py}}} code: {{{49}}} However, the build was done off {{{47}}}. -- Ticket URL: <http://trac.buildbot.net/ticket/1971#comment:3> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Fri May 27 16:02:20 2011 From: nobody at buildbot.net (Buildbot) Date: Fri, 27 May 2011 16:02:20 -0000 Subject: [Buildbot-commits] [Buildbot] #1971: Nightly timered build using incorrect change for revision In-Reply-To: <036.779b116119e5a128e7a6989ab6e5a352@buildbot.net> References: <036.779b116119e5a128e7a6989ab6e5a352@buildbot.net> Message-ID: <051.9deeea7bd3dbed586c0f14f22ae417eb@buildbot.net> #1971: Nightly timered build using incorrect change for revision -------------------+-------------------- Reporter: zacw | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.4 Version: master | Resolution: Keywords: | -------------------+-------------------- Comment (by zacw): Browsing around with no idea what I'm looking at, {{{ # fetch change ids tbl = self.db.model.sourcestamp_changes q = tbl.select(whereclause=(tbl.c.sourcestampid == ssid)) res = conn.execute(q) for row in res: ssdict['changeids'].add(row.changeid) res.close() }}} Does the where clause need to be sorted in some way? I don't know what source stamps are, nor how they interact with anything, but this was the only thing that stuck out. I can add some debug code if you let me know what values you're interested in and where. -- Ticket URL: <http://trac.buildbot.net/ticket/1971#comment:4> Buildbot <http://buildbot.net/> Buildbot: build/test automation From noreply at github.com Fri May 27 19:07:50 2011 From: noreply at github.com (noreply at github.com) Date: Fri, 27 May 2011 12:07:50 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 0c995e: Fixed typos. Added documentation for words.IRC sup... Message-ID: <20110527190750.CD0CF42526@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 0c995e82bb6c3888215eee35f4e45f2fa5f3f4dd https://github.com/buildbot/buildbot/commit/0c995e82bb6c3888215eee35f4e45f2fa5f3f4dd Author: Pradeepkumar Gayam <in3xes at gmail.com> Date: 2011-05-27 (Fri, 27 May 2011) Changed paths: M master/docs/cfg-changesources.texinfo M master/docs/cfg-statustargets.texinfo Log Message: ----------- Fixed typos. Added documentation for words.IRC support for categories after testing. Fixes #1876 Commit: 2b9c42903d89e8745432b650befad85548a1033f https://github.com/buildbot/buildbot/commit/2b9c42903d89e8745432b650befad85548a1033f Author: Dustin J. Mitchell <dustin at mozilla.com> Date: 2011-05-27 (Fri, 27 May 2011) Changed paths: M master/docs/cfg-changesources.texinfo M master/docs/cfg-statustargets.texinfo Log Message: ----------- Merge branch '1876' of git://github.com/in3xes/buildbot * '1876' of git://github.com/in3xes/buildbot: Fixed typos. Added documentation for words.IRC support for categories after testing. Fixes #1876 Compare: https://github.com/buildbot/buildbot/compare/f46514a...2b9c429 From nobody at buildbot.net Fri May 27 19:07:57 2011 From: nobody at buildbot.net (Buildbot) Date: Fri, 27 May 2011 19:07:57 -0000 Subject: [Buildbot-commits] [Buildbot] #1876: words.IRC Support for categories somewhat undocumented In-Reply-To: <041.14b21b9a3756f06e7551fda30de32467@buildbot.net> References: <041.14b21b9a3756f06e7551fda30de32467@buildbot.net> Message-ID: <056.6cd9c5734611c19ab9482a29dbcfe927@buildbot.net> #1876: words.IRC Support for categories somewhat undocumented -------------------------+--------------------- Reporter: dabrahams | Owner: Type: enhancement | Status: closed Priority: minor | Milestone: 0.8.4 Version: 0.8.3p1 | Resolution: fixed Keywords: docs, simple | -------------------------+--------------------- Changes (by Pradeepkumar Gayam): * status: new => closed * resolution: => fixed Comment: Fixed typos. Added documentation for words.IRC support for categories after testing. Fixes #1876 Changeset: 0c995e82bb6c3888215eee35f4e45f2fa5f3f4dd -- Ticket URL: <http://trac.buildbot.net/ticket/1876#comment:6> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Fri May 27 19:07:57 2011 From: nobody at buildbot.net (Buildbot) Date: Fri, 27 May 2011 19:07:57 -0000 Subject: [Buildbot-commits] [Buildbot] #1876: words.IRC Support for categories somewhat undocumented In-Reply-To: <041.14b21b9a3756f06e7551fda30de32467@buildbot.net> References: <041.14b21b9a3756f06e7551fda30de32467@buildbot.net> Message-ID: <056.7b4a07eaf36d4849b58875752ae44b7c@buildbot.net> #1876: words.IRC Support for categories somewhat undocumented -------------------------+--------------------- Reporter: dabrahams | Owner: Type: enhancement | Status: closed Priority: minor | Milestone: 0.8.4 Version: 0.8.3p1 | Resolution: fixed Keywords: docs, simple | -------------------------+--------------------- Comment (by Dustin J. Mitchell): Merge branch '1876' of git://github.com/in3xes/buildbot * '1876' of git://github.com/in3xes/buildbot: Fixed typos. Added documentation for words.IRC support for categories after testing. Fixes #1876 Changeset: 2b9c42903d89e8745432b650befad85548a1033f -- Ticket URL: <http://trac.buildbot.net/ticket/1876#comment:7> Buildbot <http://buildbot.net/> Buildbot: build/test automation From noreply at github.com Fri May 27 19:17:40 2011 From: noreply at github.com (noreply at github.com) Date: Fri, 27 May 2011 12:17:40 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 230225: Merge branch '1874' of git://github.com/in3xes/bui... Message-ID: <20110527191740.1788C4253D@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 230225d8bdd6a202e7fe2415f8a5aaf38c5543f1 https://github.com/buildbot/buildbot/commit/230225d8bdd6a202e7fe2415f8a5aaf38c5543f1 Author: Dustin J. Mitchell <dustin at mozilla.com> Date: 2011-05-27 (Fri, 27 May 2011) Changed paths: M master/buildbot/status/web/templates/root.html M master/buildbot/status/web/templates/waterfall.html Log Message: ----------- Merge branch '1874' of git://github.com/in3xes/buildbot * '1874' of git://github.com/in3xes/buildbot: Move waterfall help to top of the page. Fixes #1874 From nobody at buildbot.net Fri May 27 19:17:45 2011 From: nobody at buildbot.net (Buildbot) Date: Fri, 27 May 2011 19:17:45 -0000 Subject: [Buildbot-commits] [Buildbot] #1874: Waterfall help is hiding In-Reply-To: <041.e32fc3fbb450b60d161baa55f8ded362@buildbot.net> References: <041.e32fc3fbb450b60d161baa55f8ded362@buildbot.net> Message-ID: <056.1a006065f3539547149a5536e1b3484a@buildbot.net> #1874: Waterfall help is hiding ------------------------+--------------------- Reporter: dabrahams | Owner: Type: enhancement | Status: closed Priority: major | Milestone: 0.8.4 Version: 0.8.3p1 | Resolution: fixed Keywords: web, simple | ------------------------+--------------------- Changes (by Dustin J. Mitchell): * status: new => closed * resolution: => fixed Comment: Merge branch '1874' of git://github.com/in3xes/buildbot * '1874' of git://github.com/in3xes/buildbot: Move waterfall help to top of the page. Fixes #1874 Changeset: 230225d8bdd6a202e7fe2415f8a5aaf38c5543f1 -- Ticket URL: <http://trac.buildbot.net/ticket/1874#comment:2> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Fri May 27 23:45:17 2011 From: nobody at buildbot.net (Buildbot) Date: Fri, 27 May 2011 23:45:17 -0000 Subject: [Buildbot-commits] [Buildbot] #1908: Warn users of configuration keys that need changing during an upgrade. In-Reply-To: <036.b968338e20d9405c26e52c9555016f56@buildbot.net> References: <036.b968338e20d9405c26e52c9555016f56@buildbot.net> Message-ID: <051.1a2359aeb5c1676525868ad220441950@buildbot.net> #1908: Warn users of configuration keys that need changing during an upgrade. -----------------------------------+------------------------ Reporter: verm | Owner: Type: enhancement | Status: new Priority: minor | Milestone: undecided Version: master | Resolution: Keywords: upgrade, redheadphones | -----------------------------------+------------------------ Changes (by redheadphones): * keywords: upgrade => upgrade, redheadphones -- Ticket URL: <http://trac.buildbot.net/ticket/1908#comment:2> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Fri May 27 23:46:06 2011 From: nobody at buildbot.net (Buildbot) Date: Fri, 27 May 2011 23:46:06 -0000 Subject: [Buildbot-commits] [Buildbot] #1889: add a "glossary" to the buildbot docs In-Reply-To: <038.b7364e7622e4243de676aab721cf4f55@buildbot.net> References: <038.b7364e7622e4243de676aab721cf4f55@buildbot.net> Message-ID: <053.0864be1f46412719b0b19172147661bd@buildbot.net> #1889: add a "glossary" to the buildbot docs --------------------------------+-------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.3p1 | Resolution: Keywords: docs, redheadphones | --------------------------------+-------------------- Changes (by redheadphones): * keywords: docs => docs, redheadphones -- Ticket URL: <http://trac.buildbot.net/ticket/1889#comment:1> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Fri May 27 23:47:17 2011 From: nobody at buildbot.net (Buildbot) Date: Fri, 27 May 2011 23:47:17 -0000 Subject: [Buildbot-commits] [Buildbot] #1873: web status does not ask for name when auth not in use In-Reply-To: <038.57714f0dc960c5a06e3ee2e18d56deed@buildbot.net> References: <038.57714f0dc960c5a06e3ee2e18d56deed@buildbot.net> Message-ID: <053.c5367bf272d4ab3d97126f034c026ed0@buildbot.net> #1873: web status does not ask for name when auth not in use -------------------------------+-------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.4 Version: 0.8.3p1 | Resolution: Keywords: web, redheadphones | -------------------------------+-------------------- Changes (by redheadphones): * keywords: web => web, redheadphones -- Ticket URL: <http://trac.buildbot.net/ticket/1873#comment:2> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Fri May 27 23:53:09 2011 From: nobody at buildbot.net (Buildbot) Date: Fri, 27 May 2011 23:53:09 -0000 Subject: [Buildbot-commits] [Buildbot] #1848: Cookies to remember web usernames In-Reply-To: <041.c7ad4e6001681bf1a08277684316ffbb@buildbot.net> References: <041.c7ad4e6001681bf1a08277684316ffbb@buildbot.net> Message-ID: <056.8135a67626d8a2e347add06e44bab507@buildbot.net> #1848: Cookies to remember web usernames --------------------------------+-------------------- Reporter: dabrahams | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.+ Version: 0.8.3p1 | Resolution: Keywords: web, readheadphones | --------------------------------+-------------------- Changes (by redheadphones): * keywords: web => web, readheadphones -- Ticket URL: <http://trac.buildbot.net/ticket/1848#comment:4> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Fri May 27 23:55:48 2011 From: nobody at buildbot.net (Buildbot) Date: Fri, 27 May 2011 23:55:48 -0000 Subject: [Buildbot-commits] [Buildbot] #1782: Hide email address in web status In-Reply-To: <038.56052ef3d3464397f95b3fcc291e0c55@buildbot.net> References: <038.56052ef3d3464397f95b3fcc291e0c55@buildbot.net> Message-ID: <053.c09aa920c97f80d2382c44a85c2eeb43@buildbot.net> #1782: Hide email address in web status --------------------------+-------------------- Reporter: tfogal | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.3p1 | Resolution: Keywords: redheadphones | --------------------------+-------------------- Changes (by redheadphones): * keywords: => redheadphones -- Ticket URL: <http://trac.buildbot.net/ticket/1782#comment:3> Buildbot <http://buildbot.net/> Buildbot: build/test automation From noreply at github.com Sat May 28 15:56:16 2011 From: noreply at github.com (noreply at github.com) Date: Sat, 28 May 2011 08:56:16 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] a39719: Added support for EC2 regions Message-ID: <20110528155616.A73FE4237F@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: a3971905b762e8474d74360063fba0d9684dcf07 https://github.com/buildbot/buildbot/commit/a3971905b762e8474d74360063fba0d9684dcf07 Author: Brandon R. Stoner <monokrome at monokro.me> Date: 2011-05-27 (Fri, 27 May 2011) Changed paths: M master/buildbot/ec2buildslave.py Log Message: ----------- Added support for EC2 regions Commit: e43c3ffeb23c80114c244bb6fe2bd807ab9b5f56 https://github.com/buildbot/buildbot/commit/e43c3ffeb23c80114c244bb6fe2bd807ab9b5f56 Author: Brandon R. Stoner <monokrome at monokro.me> Date: 2011-05-28 (Sat, 28 May 2011) Changed paths: M master/buildbot/ec2buildslave.py Log Message: ----------- Updated EC2 slave to throw an error when the specified region does not exist. Commit: dd198a96a209f40bbe40e610e218ec6cb2dbf1a7 https://github.com/buildbot/buildbot/commit/dd198a96a209f40bbe40e610e218ec6cb2dbf1a7 Author: Dustin J. Mitchell <dustin at mozilla.com> Date: 2011-05-28 (Sat, 28 May 2011) Changed paths: M master/buildbot/ec2buildslave.py Log Message: ----------- Merge branch 'master' of git://github.com/monokrome/buildbot * 'master' of git://github.com/monokrome/buildbot: Updated EC2 slave to throw an error when the specified region does not exist. Added support for EC2 regions Compare: https://github.com/buildbot/buildbot/compare/230225d...dd198a9 From nobody at buildbot.net Sat May 28 16:41:11 2011 From: nobody at buildbot.net (Buildbot) Date: Sat, 28 May 2011 16:41:11 -0000 Subject: [Buildbot-commits] [Buildbot] #1972: Buildbot doesn't terminate latent EC2 servers upon shutdown Message-ID: <041.27ff6cc6ca3ab497acb6fc7cba86244c@buildbot.net> #1972: Buildbot doesn't terminate latent EC2 servers upon shutdown ----------------------+----------------------- Reporter: monokrome | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.3p1 | Keywords: ----------------------+----------------------- When stopping the buildbot master server, the master doesn't terminate any latent EC2 instances that are running on it's behalf. This causes an issue where a server is never shut down. -- Ticket URL: <http://trac.buildbot.net/ticket/1972> Buildbot <http://buildbot.net/> Buildbot: build/test automation From noreply at github.com Sat May 28 21:33:28 2011 From: noreply at github.com (noreply at github.com) Date: Sat, 28 May 2011 14:33:28 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] dc3ca6: Sort changes before creating a SourceStamp from an... Message-ID: <20110528213328.2B23F424C2@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: dc3ca6e278c44e9a8a2ca8784ca29d8081a41df1 https://github.com/buildbot/buildbot/commit/dc3ca6e278c44e9a8a2ca8784ca29d8081a41df1 Author: Dustin J. Mitchell <dustin at v.igoro.us> Date: 2011-05-28 (Sat, 28 May 2011) Changed paths: M master/buildbot/db/sourcestamps.py M master/buildbot/sourcestamp.py M master/buildbot/test/unit/test_sourcestamp.py Log Message: ----------- Sort changes before creating a SourceStamp from an ssdict This includes an improved test - the old test worked by chance. Fixes #1971. From nobody at buildbot.net Sat May 28 21:33:37 2011 From: nobody at buildbot.net (Buildbot) Date: Sat, 28 May 2011 21:33:37 -0000 Subject: [Buildbot-commits] [Buildbot] #1971: Nightly timered build using incorrect change for revision In-Reply-To: <036.779b116119e5a128e7a6989ab6e5a352@buildbot.net> References: <036.779b116119e5a128e7a6989ab6e5a352@buildbot.net> Message-ID: <051.c0abefe759ff3f3ace4373dcc9189033@buildbot.net> #1971: Nightly timered build using incorrect change for revision -------------------+--------------------- Reporter: zacw | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.4 Version: master | Resolution: fixed Keywords: | -------------------+--------------------- Changes (by Dustin J. Mitchell): * status: new => closed * resolution: => fixed Comment: Sort changes before creating a SourceStamp from an ssdict This includes an improved test - the old test worked by chance. Fixes #1971. Changeset: dc3ca6e278c44e9a8a2ca8784ca29d8081a41df1 -- Ticket URL: <http://trac.buildbot.net/ticket/1971#comment:5> Buildbot <http://buildbot.net/> Buildbot: build/test automation From noreply at github.com Sat May 28 21:47:01 2011 From: noreply at github.com (noreply at github.com) Date: Sat, 28 May 2011 14:47:01 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 30f61e: AsyncLRUCache changes Message-ID: <20110528214701.078AE424AC@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 30f61e3c28b00e3da405d51c748ad0023ea53e25 https://github.com/buildbot/buildbot/commit/30f61e3c28b00e3da405d51c748ad0023ea53e25 Author: Dustin J. Mitchell <dustin at v.igoro.us> Date: 2011-05-28 (Sat, 28 May 2011) Changed paths: M master/buildbot/test/unit/test_util_lru.py M master/buildbot/util/lru.py Log Message: ----------- AsyncLRUCache changes * add set_max_size method * make miss_fn an instance attr * allow **miss_fn_kwargs for get() invocations, to pass "hints" * do not cache negative results * add 'put' method to update a value Commit: dc86b375596eab8a69053945b89c6e8aed1303d2 https://github.com/buildbot/buildbot/commit/dc86b375596eab8a69053945b89c6e8aed1303d2 Author: Dustin J. Mitchell <dustin at v.igoro.us> Date: 2011-05-28 (Sat, 28 May 2011) Changed paths: A master/buildbot/cache.py M master/buildbot/master.py A master/buildbot/test/unit/test_cache.py Log Message: ----------- add master.caches, so-far unused Commit: 8e87bc986e657d5c9d6779e8a3978835c566b691 https://github.com/buildbot/buildbot/commit/8e87bc986e657d5c9d6779e8a3978835c566b691 Author: Dustin J. Mitchell <dustin at v.igoro.us> Date: 2011-05-28 (Sat, 28 May 2011) Changed paths: M master/buildbot/db/base.py A master/buildbot/test/unit/test_db_base.py Log Message: ----------- Add @base.cached for DBConnectorComponents This adds caching to "getter" methods, using lazy binding to the caches. Commit: c7b8b02595541ca924b21f4a957be1279cb1023a https://github.com/buildbot/buildbot/commit/c7b8b02595541ca924b21f4a957be1279cb1023a Author: Dustin J. Mitchell <dustin at v.igoro.us> Date: 2011-05-28 (Sat, 28 May 2011) Changed paths: M master/buildbot/db/base.py M master/buildbot/db/buildrequests.py M master/buildbot/db/buildsets.py M master/buildbot/db/changes.py M master/buildbot/db/sourcestamps.py M master/buildbot/scripts/runner.py A master/buildbot/test/fake/fakemaster.py M master/buildbot/test/integration/test_upgrade.py M master/buildbot/test/regressions/test_import_unicode_changes.py M master/buildbot/test/unit/test_db_base.py M master/buildbot/test/unit/test_db_buildrequests.py M master/buildbot/test/util/connector_component.py Log Message: ----------- cache db results This adds caches for ssdicts, brdicts, chdicts, bsdicts, and adds a no_cache=1 option to all master.db.comp.getFooBar methods Commit: 6e282456dc924bf0b0e9e0718ace72ce7b408373 https://github.com/buildbot/buildbot/commit/6e282456dc924bf0b0e9e0718ace72ce7b408373 Author: Dustin J. Mitchell <dustin at v.igoro.us> Date: 2011-05-28 (Sat, 28 May 2011) Changed paths: M master/buildbot/sourcestamp.py M master/buildbot/test/unit/test_process_builder.py M master/buildbot/test/unit/test_process_buildrequest.py M master/buildbot/test/unit/test_sourcestamp.py Log Message: ----------- cache SourceStamps; add a fakemaster module to help tests Commit: cc0f7dc66f0093754a374aa66f5a1f2abb7b5f93 https://github.com/buildbot/buildbot/commit/cc0f7dc66f0093754a374aa66f5a1f2abb7b5f93 Author: Dustin J. Mitchell <dustin at mozilla.com> Date: 2011-05-28 (Sat, 28 May 2011) Changed paths: M master/buildbot/process/buildrequest.py Log Message: ----------- cache BuildRequest instances Commit: ab8926341888b54567c9691803acdcd436533e6f https://github.com/buildbot/buildbot/commit/ab8926341888b54567c9691803acdcd436533e6f Author: Dustin J. Mitchell <dustin at mozilla.com> Date: 2011-05-28 (Sat, 28 May 2011) Changed paths: M master/buildbot/changes/changes.py M master/buildbot/schedulers/basic.py M master/buildbot/test/util/scheduler.py Log Message: ----------- cache Change instances Commit: 9e2408449d0fb9d10807ab03bb0cd4cb38a42800 https://github.com/buildbot/buildbot/commit/9e2408449d0fb9d10807ab03bb0cd4cb38a42800 Author: Dustin J. Mitchell <dustin at mozilla.com> Date: 2011-05-28 (Sat, 28 May 2011) Changed paths: A master/buildbot/cache.py M master/buildbot/changes/changes.py M master/buildbot/db/base.py M master/buildbot/db/buildrequests.py M master/buildbot/db/buildsets.py M master/buildbot/db/changes.py M master/buildbot/db/sourcestamps.py M master/buildbot/master.py M master/buildbot/process/buildrequest.py M master/buildbot/schedulers/basic.py M master/buildbot/scripts/runner.py M master/buildbot/sourcestamp.py A master/buildbot/test/fake/fakemaster.py M master/buildbot/test/integration/test_upgrade.py M master/buildbot/test/regressions/test_import_unicode_changes.py A master/buildbot/test/unit/test_cache.py A master/buildbot/test/unit/test_db_base.py M master/buildbot/test/unit/test_db_buildrequests.py M master/buildbot/test/unit/test_process_builder.py M master/buildbot/test/unit/test_process_buildrequest.py M master/buildbot/test/unit/test_sourcestamp.py M master/buildbot/test/unit/test_util_lru.py M master/buildbot/test/util/connector_component.py M master/buildbot/test/util/scheduler.py M master/buildbot/util/lru.py Log Message: ----------- Implement caching This is conservative in how it caches database dictionaries, but more aggressive with process objects. * bug1953: cache Change instances cache BuildRequest instances cache SourceStamps; add a fakemaster module to help tests cache db results Add @base.cached for DBConnectorComponents add master.caches, so-far unused AsyncLRUCache changes Fixes #1953. Compare: https://github.com/buildbot/buildbot/compare/dc3ca6e...9e24084 From nobody at buildbot.net Sat May 28 21:47:16 2011 From: nobody at buildbot.net (Buildbot) Date: Sat, 28 May 2011 21:47:16 -0000 Subject: [Buildbot-commits] [Buildbot] #1953: add aggressive caching in the db layer In-Reply-To: <038.55a64c0302e3f9034fd17d48112cd80b@buildbot.net> References: <038.55a64c0302e3f9034fd17d48112cd80b@buildbot.net> Message-ID: <053.79b2e5b9943ec6268765d56c5fa2e6f4@buildbot.net> #1953: add aggressive caching in the db layer ----------------------------------+--------------------- Reporter: dustin | Owner: Type: enhancement | Status: closed Priority: critical | Milestone: 0.8.4 Version: master | Resolution: fixed Keywords: database, performance | ----------------------------------+--------------------- Changes (by Dustin J. Mitchell): * status: new => closed * resolution: => fixed Comment: Implement caching This is conservative in how it caches database dictionaries, but more aggressive with process objects. * bug1953: cache Change instances cache BuildRequest instances cache SourceStamps; add a fakemaster module to help tests cache db results Add @base.cached for DBConnectorComponents add master.caches, so-far unused AsyncLRUCache changes Fixes #1953. Changeset: 9e2408449d0fb9d10807ab03bb0cd4cb38a42800 -- Ticket URL: <http://trac.buildbot.net/ticket/1953#comment:4> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Sat May 28 21:53:20 2011 From: nobody at buildbot.net (Buildbot) Date: Sat, 28 May 2011 21:53:20 -0000 Subject: [Buildbot-commits] [Buildbot] #913: revlink callback and builders view does not work together. In-Reply-To: <041.112559e1d8b72c9b44183fd09197ae39@buildbot.net> References: <041.112559e1d8b72c9b44183fd09197ae39@buildbot.net> Message-ID: <056.965cc832ba1aa6fb41fdb8f74d1a549c@buildbot.net> #913: revlink callback and builders view does not work together. --------------------------+-------------------- Reporter: cdadhemar | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.0 | Resolution: Keywords: web, projrepo | --------------------------+-------------------- Changes (by dustin): * milestone: 0.8.4 => 0.8.+ -- Ticket URL: <http://trac.buildbot.net/ticket/913#comment:8> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Sat May 28 21:53:59 2011 From: nobody at buildbot.net (Buildbot) Date: Sat, 28 May 2011 21:53:59 -0000 Subject: [Buildbot-commits] [Buildbot] #985: wierd behaviour for some custom property values from force build page In-Reply-To: <039.9c19da66cfd0d81bd21cbb22407290df@buildbot.net> References: <039.9c19da66cfd0d81bd21cbb22407290df@buildbot.net> Message-ID: <054.24887da9f3f1266969f6d21e66e4a705@buildbot.net> #985: wierd behaviour for some custom property values from force build page --------------------+-------------------- Reporter: rmdugal | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.5 Version: 0.7.12 | Resolution: Keywords: web | --------------------+-------------------- Changes (by dustin): * milestone: 0.8.4 => 0.8.5 -- Ticket URL: <http://trac.buildbot.net/ticket/985#comment:5> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Sat May 28 21:54:25 2011 From: nobody at buildbot.net (Buildbot) Date: Sat, 28 May 2011 21:54:25 -0000 Subject: [Buildbot-commits] [Buildbot] #1764: buildbot reconfig command doesn't restart MailNotifier In-Reply-To: <038.ba64b83122feb9dc9ec7b7ad5365e8aa@buildbot.net> References: <038.ba64b83122feb9dc9ec7b7ad5365e8aa@buildbot.net> Message-ID: <053.7448edf8e7ff5724a28dbb7a98fc6177@buildbot.net> #1764: buildbot reconfig command doesn't restart MailNotifier --------------------+------------------------- Reporter: akevan | Owner: Type: defect | Status: closed Priority: minor | Milestone: 0.8.4 Version: 0.8.3p1 | Resolution: worksforme Keywords: | --------------------+------------------------- Changes (by dustin): * status: new => closed * resolution: => worksforme Comment: Re-open if this can be reproduced. -- Ticket URL: <http://trac.buildbot.net/ticket/1764#comment:3> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Sat May 28 22:32:29 2011 From: nobody at buildbot.net (Buildbot) Date: Sat, 28 May 2011 22:32:29 -0000 Subject: [Buildbot-commits] [Buildbot] #1768: MailNotifier emails sent with base64 encoding In-Reply-To: <039.a3c5ed7b7703fddacb868504fd6c9228@buildbot.net> References: <039.a3c5ed7b7703fddacb868504fd6c9228@buildbot.net> Message-ID: <054.3895e7433232553f8ad76dfff1a77ee7@buildbot.net> #1768: MailNotifier emails sent with base64 encoding --------------------+-------------------- Reporter: cortana | Owner: Type: defect | Status: new Priority: trivial | Milestone: 0.8.+ Version: 0.8.3p1 | Resolution: Keywords: mail | --------------------+-------------------- Changes (by dustin): * milestone: 0.8.4 => 0.8.+ -- Ticket URL: <http://trac.buildbot.net/ticket/1768#comment:4> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Sat May 28 22:32:46 2011 From: nobody at buildbot.net (Buildbot) Date: Sat, 28 May 2011 22:32:46 -0000 Subject: [Buildbot-commits] [Buildbot] #1772: vstudio.py misses compile errors and doesn't check for exit status In-Reply-To: <041.e84e795e122ec83abcea86b809814a63@buildbot.net> References: <041.e84e795e122ec83abcea86b809814a63@buildbot.net> Message-ID: <056.43148bc75fb18ee67a3807e8d6b43a4f@buildbot.net> #1772: vstudio.py misses compile errors and doesn't check for exit status ----------------------+----------------------- Reporter: philippem | Owner: Type: defect | Status: reopened Priority: major | Milestone: 0.8.5 Version: 0.8.3 | Resolution: Keywords: windows | ----------------------+----------------------- Changes (by dustin): * milestone: 0.8.4 => 0.8.5 -- Ticket URL: <http://trac.buildbot.net/ticket/1772#comment:14> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Sat May 28 22:33:42 2011 From: nobody at buildbot.net (Buildbot) Date: Sat, 28 May 2011 22:33:42 -0000 Subject: [Buildbot-commits] [Buildbot] #1777: Dependent scheduler forgets who to trigger In-Reply-To: <039.4f396a5c8b35334402d8ca09ee2341fb@buildbot.net> References: <039.4f396a5c8b35334402d8ca09ee2341fb@buildbot.net> Message-ID: <054.78f8272ee0ae0eba768b8c4948399c23@buildbot.net> #1777: Dependent scheduler forgets who to trigger -------------------------------+--------------------- Reporter: armenzg | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.4 Version: 0.8.3p1 | Resolution: fixed Keywords: database, reconfig | -------------------------------+--------------------- Changes (by dustin): * status: new => closed * resolution: => fixed Comment: Should be good. Re-open if this is still a problem in 0.8.4. -- Ticket URL: <http://trac.buildbot.net/ticket/1777#comment:2> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Sat May 28 22:34:29 2011 From: nobody at buildbot.net (Buildbot) Date: Sat, 28 May 2011 22:34:29 -0000 Subject: [Buildbot-commits] [Buildbot] #1780: Latent build slaves shut down uncleanly and get forgotten by the master In-Reply-To: <040.ea5c2cbbd82d21ecc7d22b950b6307bf@buildbot.net> References: <040.ea5c2cbbd82d21ecc7d22b950b6307bf@buildbot.net> Message-ID: <055.62ba1592bc0ebe10efb28c91dc7ee392@buildbot.net> #1780: Latent build slaves shut down uncleanly and get forgotten by the master ---------------------------+-------------------- Reporter: jacobian | Owner: Type: defect | Status: new Priority: critical | Milestone: 0.8.+ Version: 0.8.3p1 | Resolution: Keywords: virtualization | ---------------------------+-------------------- Changes (by dustin): * milestone: 0.8.4 => 0.8.+ -- Ticket URL: <http://trac.buildbot.net/ticket/1780#comment:13> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Sat May 28 22:34:52 2011 From: nobody at buildbot.net (Buildbot) Date: Sat, 28 May 2011 22:34:52 -0000 Subject: [Buildbot-commits] [Buildbot] #1784: Buildmaster blocks In-Reply-To: <040.b9bf7390b4609c7970b110cd158d5cf1@buildbot.net> References: <040.b9bf7390b4609c7970b110cd158d5cf1@buildbot.net> Message-ID: <055.164263bce32a7fba012c62f6afb869a5@buildbot.net> #1784: Buildmaster blocks ------------------------+-------------------- Reporter: Schenker | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.0 | Resolution: Keywords: performance | ------------------------+-------------------- Changes (by dustin): * keywords: => performance * milestone: 0.8.4 => 0.8.+ -- Ticket URL: <http://trac.buildbot.net/ticket/1784#comment:8> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Sat May 28 22:44:14 2011 From: nobody at buildbot.net (Buildbot) Date: Sat, 28 May 2011 22:44:14 -0000 Subject: [Buildbot-commits] [Buildbot] #1804: DirectoryUpload does not raise an error if it can't copy all the files In-Reply-To: <039.4c8f26f7950601795b47b896a9c35b3a@buildbot.net> References: <039.4c8f26f7950601795b47b896a9c35b3a@buildbot.net> Message-ID: <054.47c0d7a74644d10b6428fcc69372f9eb@buildbot.net> #1804: DirectoryUpload does not raise an error if it can't copy all the files ---------------------+-------------------- Reporter: cortana | Owner: Type: defect | Status: new Priority: minor | Milestone: 0.8.5 Version: 0.8.2 | Resolution: Keywords: transfer | ---------------------+-------------------- Changes (by dustin): * keywords: => transfer * milestone: 0.8.4 => 0.8.5 Comment: One of several problems with the transfer steps that we really should address soon. -- Ticket URL: <http://trac.buildbot.net/ticket/1804#comment:3> Buildbot <http://buildbot.net/> Buildbot: build/test automation From noreply at github.com Sat May 28 22:45:10 2011 From: noreply at github.com (noreply at github.com) Date: Sat, 28 May 2011 15:45:10 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 65da79: Override startService, not setServiceParent Message-ID: <20110528224510.0D28B424B0@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 65da79fa71587c67d5fa82139324c4800e66b82d https://github.com/buildbot/buildbot/commit/65da79fa71587c67d5fa82139324c4800e66b82d Author: Dustin J. Mitchell <dustin at mozilla.com> Date: 2011-05-28 (Sat, 28 May 2011) Changed paths: M master/buildbot/status/status_gerrit.py M master/buildbot/status/status_push.py Log Message: ----------- Override startService, not setServiceParent Fixes #1793. From nobody at buildbot.net Sat May 28 22:45:17 2011 From: nobody at buildbot.net (Buildbot) Date: Sat, 28 May 2011 22:45:17 -0000 Subject: [Buildbot-commits] [Buildbot] #1793: StatusPush uses setServiceParent instead of startService In-Reply-To: <038.535a6264c4fbfbb9e9546ca90a7f01d4@buildbot.net> References: <038.535a6264c4fbfbb9e9546ca90a7f01d4@buildbot.net> Message-ID: <053.9ef5045fec3ed2855a3fef8a56ffdf35@buildbot.net> #1793: StatusPush uses setServiceParent instead of startService --------------------+--------------------- Reporter: dustin | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.4 Version: 0.8.3p1 | Resolution: fixed Keywords: | --------------------+--------------------- Changes (by Dustin J. Mitchell): * status: new => closed * resolution: => fixed Comment: Override startService, not setServiceParent Fixes #1793. Changeset: 65da79fa71587c67d5fa82139324c4800e66b82d -- Ticket URL: <http://trac.buildbot.net/ticket/1793#comment:1> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Sat May 28 22:45:39 2011 From: nobody at buildbot.net (Buildbot) Date: Sat, 28 May 2011 22:45:39 -0000 Subject: [Buildbot-commits] [Buildbot] #1808: Scheduler with treeStableTimer "merges" changes to multiple projects into single SourceStamp In-Reply-To: <039.cd87665d300c4855d7e125d8690e0a31@buildbot.net> References: <039.cd87665d300c4855d7e125d8690e0a31@buildbot.net> Message-ID: <054.c82d160688da5675c91c677bb9b71c83@buildbot.net> #1808: Scheduler with treeStableTimer "merges" changes to multiple projects into single SourceStamp --------------------+-------------------- Reporter: aivarsk | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.3p1 | Resolution: Keywords: | --------------------+-------------------- Changes (by dustin): * milestone: 0.8.4 => 0.8.+ -- Ticket URL: <http://trac.buildbot.net/ticket/1808#comment:3> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Sat May 28 22:55:01 2011 From: nobody at buildbot.net (Buildbot) Date: Sat, 28 May 2011 22:55:01 -0000 Subject: [Buildbot-commits] [Buildbot] #1972: Buildbot doesn't terminate latent EC2 servers upon shutdown In-Reply-To: <041.27ff6cc6ca3ab497acb6fc7cba86244c@buildbot.net> References: <041.27ff6cc6ca3ab497acb6fc7cba86244c@buildbot.net> Message-ID: <056.f8f515293680afe4e7738dba5967c471@buildbot.net> #1972: Buildbot doesn't terminate latent EC2 servers upon shutdown ---------------------------+-------------------- Reporter: monokrome | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.3p1 | Resolution: Keywords: virtualization | ---------------------------+-------------------- Changes (by dustin): * keywords: => virtualization * milestone: undecided => 0.8.+ -- Ticket URL: <http://trac.buildbot.net/ticket/1972#comment:1> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Sat May 28 23:02:11 2011 From: nobody at buildbot.net (Buildbot) Date: Sat, 28 May 2011 23:02:11 -0000 Subject: [Buildbot-commits] [Buildbot] #1829: PBChangeSource loses string encodings In-Reply-To: <038.41f0798f20411d2d3d87b3680817ccc5@buildbot.net> References: <038.41f0798f20411d2d3d87b3680817ccc5@buildbot.net> Message-ID: <053.e9d8d68b9ceeb4681e30ec05b40d4f8d@buildbot.net> #1829: PBChangeSource loses string encodings ---------------------+-------------------- Reporter: dustin | Owner: Type: defect | Status: new Priority: minor | Milestone: 0.8.4 Version: master | Resolution: Keywords: encoding | ---------------------+-------------------- Comment (by dustin): Twistd-8.2.0's PB handles unicode just fine in my manual testing. -- Ticket URL: <http://trac.buildbot.net/ticket/1829#comment:3> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Sat May 28 23:02:32 2011 From: nobody at buildbot.net (Buildbot) Date: Sat, 28 May 2011 23:02:32 -0000 Subject: [Buildbot-commits] [Buildbot] #1854: FileUpload never times out In-Reply-To: <039.e7bfab756d445121a2e0b7af56f23535@buildbot.net> References: <039.e7bfab756d445121a2e0b7af56f23535@buildbot.net> Message-ID: <054.b904600d029a9d5ca75101bd3c7ccf3e@buildbot.net> #1854: FileUpload never times out ---------------------+-------------------- Reporter: exarkun | Owner: Type: defect | Status: new Priority: critical | Milestone: 0.8.+ Version: 0.8.2 | Resolution: Keywords: transfer | ---------------------+-------------------- Changes (by dustin): * keywords: sprint => transfer * milestone: 0.8.4 => 0.8.+ -- Ticket URL: <http://trac.buildbot.net/ticket/1854#comment:3> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Sun May 29 15:58:29 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 29 May 2011 15:58:29 -0000 Subject: [Buildbot-commits] [Buildbot] #1973: test with SQLAlchemy==0.7.0 Message-ID: <038.f251d98e7cd53203c92d031bc72c1ff1@buildbot.net> #1973: test with SQLAlchemy==0.7.0 ---------------------+----------------------------- Reporter: dustin | Owner: dustin Type: task | Status: new Priority: critical | Milestone: 0.8.4 Version: 0.8.3p1 | Keywords: database, tests ---------------------+----------------------------- I'm seeing failures in a brand-new virtualenv that I believe are traceable to this new version. {{{ [ERROR]: buildbot.test.unit.test_db_changes.TestChangesConnectorComponent.test_addChange Traceback (most recent call last): File "/home/dustin/code/buildbot/t/buildbot/sand26/lib/python2.6/site- packages/twisted/python/threadpool.py", line 210, in _worker result = context.call(ctx, function, *args, **kwargs) File "/home/dustin/code/buildbot/t/buildbot/sand26/lib/python2.6/site- packages/twisted/python/context.py", line 59, in callWithContext return self.currentContext().callWithContext(ctx, func, *args, **kw) File "/home/dustin/code/buildbot/t/buildbot/sand26/lib/python2.6/site- packages/twisted/python/context.py", line 37, in callWithContext return func(*args,**kw) File "/home/dustin/code/buildbot/t/buildbot/master/buildbot/db/pool.py", line 91, in thd rv = callable(conn, *args, **kwargs) File "/home/dustin/code/buildbot/t/buildbot/master/buildbot/test/unit/test_db_changes.py", line 220, in thd query.order_by([self.db.model.change_links.c.link]) File "<string>", line 1, in <lambda> File "/home/dustin/code/buildbot/t/buildbot/sand26/lib/python2.6/site- packages/sqlalchemy/sql/expression.py", line 1304, in _generative fn(self, *args[1:], **kw) File "/home/dustin/code/buildbot/t/buildbot/sand26/lib/python2.6/site- packages/sqlalchemy/sql/expression.py", line 4181, in order_by self.append_order_by(*clauses) File "/home/dustin/code/buildbot/t/buildbot/sand26/lib/python2.6/site- packages/sqlalchemy/sql/expression.py", line 4206, in append_order_by self._order_by_clause = ClauseList(*clauses) File "/home/dustin/code/buildbot/t/buildbot/sand26/lib/python2.6/site- packages/sqlalchemy/sql/expression.py", line 2889, in __init__ for clause in clauses if clause is not None] File "/home/dustin/code/buildbot/t/buildbot/sand26/lib/python2.6/site- packages/sqlalchemy/sql/expression.py", line 1219, in _literal_as_text "SQL expression object or string expected." sqlalchemy.exc.ArgumentError: SQL expression object or string expected. }}} -- Ticket URL: <http://trac.buildbot.net/ticket/1973> Buildbot <http://buildbot.net/> Buildbot: build/test automation From noreply at github.com Sun May 29 16:01:27 2011 From: noreply at github.com (noreply at github.com) Date: Sun, 29 May 2011 09:01:27 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 729e09: added --who option to try builds, updated docs and... Message-ID: <20110529160127.8E34442334@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 729e0944788006472a64a1b78b5a080ccbc01285 https://github.com/buildbot/buildbot/commit/729e0944788006472a64a1b78b5a080ccbc01285 Author: Derek Hurley <dzhurley at gmail.com> Date: 2011-05-28 (Sat, 28 May 2011) Changed paths: M master/buildbot/clients/tryclient.py M master/buildbot/schedulers/trysched.py M master/buildbot/scripts/runner.py M master/buildbot/test/unit/test_schedulers_trysched.py M master/docs/cmdline.texinfo Log Message: ----------- added --who option to try builds, updated docs and tests, fixes #1886 Commit: a4655f070b83c652ac25b5b6a26a682baebb27f5 https://github.com/buildbot/buildbot/commit/a4655f070b83c652ac25b5b6a26a682baebb27f5 Author: Dustin J. Mitchell <dustin at mozilla.com> Date: 2011-05-29 (Sun, 29 May 2011) Changed paths: M master/buildbot/clients/tryclient.py M master/buildbot/schedulers/trysched.py M master/buildbot/scripts/runner.py M master/buildbot/test/unit/test_schedulers_trysched.py M master/docs/cmdline.texinfo Log Message: ----------- Merge branch '1886_fix' of git://github.com/dzhurley/buildbot * '1886_fix' of git://github.com/dzhurley/buildbot: added --who option to try builds, updated docs and tests, fixes #1886 Compare: https://github.com/buildbot/buildbot/compare/65da79f...a4655f0 From nobody at buildbot.net Sun May 29 16:01:34 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 29 May 2011 16:01:34 -0000 Subject: [Buildbot-commits] [Buildbot] #1886: who submitted try? In-Reply-To: <035.87bfcb3d119881308ffe6c4d41d41bf1@buildbot.net> References: <035.87bfcb3d119881308ffe6c4d41d41bf1@buildbot.net> Message-ID: <050.d28c67ad098df668a81d3041f419248e@buildbot.net> #1886: who submitted try? --------------------------+---------------------------- Reporter: gg0 | Owner: redheadphones Type: enhancement | Status: closed Priority: major | Milestone: 0.8.4 Version: 0.8.3 | Resolution: fixed Keywords: redheadphones | --------------------------+---------------------------- Changes (by Derek Hurley): * status: assigned => closed * resolution: => fixed Comment: added --who option to try builds, updated docs and tests, fixes #1886 Changeset: 729e0944788006472a64a1b78b5a080ccbc01285 -- Ticket URL: <http://trac.buildbot.net/ticket/1886#comment:4> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Sun May 29 16:01:34 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 29 May 2011 16:01:34 -0000 Subject: [Buildbot-commits] [Buildbot] #1886: who submitted try? In-Reply-To: <035.87bfcb3d119881308ffe6c4d41d41bf1@buildbot.net> References: <035.87bfcb3d119881308ffe6c4d41d41bf1@buildbot.net> Message-ID: <050.489692914a6248aeace2a57882a80664@buildbot.net> #1886: who submitted try? --------------------------+---------------------------- Reporter: gg0 | Owner: redheadphones Type: enhancement | Status: closed Priority: major | Milestone: 0.8.4 Version: 0.8.3 | Resolution: fixed Keywords: redheadphones | --------------------------+---------------------------- Comment (by Dustin J. Mitchell): Merge branch '1886_fix' of git://github.com/dzhurley/buildbot * '1886_fix' of git://github.com/dzhurley/buildbot: added --who option to try builds, updated docs and tests, fixes #1886 Changeset: a4655f070b83c652ac25b5b6a26a682baebb27f5 -- Ticket URL: <http://trac.buildbot.net/ticket/1886#comment:5> Buildbot <http://buildbot.net/> Buildbot: build/test automation From noreply at github.com Sun May 29 16:34:22 2011 From: noreply at github.com (noreply at github.com) Date: Sun, 29 May 2011 09:34:22 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] c21478: fix bugs in tests revealed with sqlalchemy-0.7.0 Message-ID: <20110529163422.47974423FD@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: c21478d24493f83034390b0dc2d7582ccfc3d446 https://github.com/buildbot/buildbot/commit/c21478d24493f83034390b0dc2d7582ccfc3d446 Author: Dustin J. Mitchell <dustin at mozilla.com> Date: 2011-05-29 (Sun, 29 May 2011) Changed paths: M master/buildbot/test/unit/test_db_changes.py Log Message: ----------- fix bugs in tests revealed with sqlalchemy-0.7.0 From nobody at buildbot.net Sun May 29 16:35:31 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 29 May 2011 16:35:31 -0000 Subject: [Buildbot-commits] [Buildbot] #1973: test with SQLAlchemy==0.7.0 In-Reply-To: <038.f251d98e7cd53203c92d031bc72c1ff1@buildbot.net> References: <038.f251d98e7cd53203c92d031bc72c1ff1@buildbot.net> Message-ID: <053.964914219204c6377affeb9870b62560@buildbot.net> #1973: test with SQLAlchemy==0.7.0 ----------------------------+--------------------- Reporter: dustin | Owner: dustin Type: task | Status: new Priority: critical | Milestone: 0.8.4 Version: 0.8.3p1 | Resolution: Keywords: database, tests | ----------------------------+--------------------- Comment (by dustin): Fixed. Now testing with * sqlalchemy-0.6.0 (the minimum version) - http://buildbot.buildbot.net/builders/py27-sa060 * sqlalchemy-0.6.6 (the common version) - http://buildbot.buildbot.net/builders/py27-sa066 * sqlalchemy-0.7.0 (the latest version) - http://buildbot.buildbot.net/builders/py27-sa070 -- Ticket URL: <http://trac.buildbot.net/ticket/1973#comment:1> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Sun May 29 16:36:04 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 29 May 2011 16:36:04 -0000 Subject: [Buildbot-commits] [Buildbot] #1973: test with SQLAlchemy==0.7.0 In-Reply-To: <038.f251d98e7cd53203c92d031bc72c1ff1@buildbot.net> References: <038.f251d98e7cd53203c92d031bc72c1ff1@buildbot.net> Message-ID: <053.cc95013e3704d25fc9878170953866f6@buildbot.net> #1973: test with SQLAlchemy==0.7.0 ----------------------------+--------------------- Reporter: dustin | Owner: dustin Type: task | Status: closed Priority: critical | Milestone: 0.8.4 Version: 0.8.3p1 | Resolution: fixed Keywords: database, tests | ----------------------------+--------------------- Changes (by dustin): * status: new => closed * resolution: => fixed -- Ticket URL: <http://trac.buildbot.net/ticket/1973#comment:2> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Sun May 29 17:51:36 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 29 May 2011 17:51:36 -0000 Subject: [Buildbot-commits] [Buildbot] #1829: PBChangeSource loses string encodings In-Reply-To: <038.41f0798f20411d2d3d87b3680817ccc5@buildbot.net> References: <038.41f0798f20411d2d3d87b3680817ccc5@buildbot.net> Message-ID: <053.faac2821c0cc82263f72687f39d52c55@buildbot.net> #1829: PBChangeSource loses string encodings ---------------------+-------------------- Reporter: dustin | Owner: Type: defect | Status: new Priority: minor | Milestone: 0.8.4 Version: master | Resolution: Keywords: encoding | ---------------------+-------------------- Comment (by Dustin J. Mitchell): Handle bytestrings on input to PBChangeSource This handles bytestrings by assuming, softly, that they are in utf8. Ideally the PB client would not send bytestrings, but at least this avoids crashing. Refs #1829. Changeset: dcc08973694d6c6dc2f482c83bd51317c2839c07 -- Ticket URL: <http://trac.buildbot.net/ticket/1829#comment:4> Buildbot <http://buildbot.net/> Buildbot: build/test automation From noreply at github.com Sun May 29 17:51:28 2011 From: noreply at github.com (noreply at github.com) Date: Sun, 29 May 2011 10:51:28 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] dcc089: Handle bytestrings on input to PBChangeSource Message-ID: <20110529175128.995C6422DE@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: dcc08973694d6c6dc2f482c83bd51317c2839c07 https://github.com/buildbot/buildbot/commit/dcc08973694d6c6dc2f482c83bd51317c2839c07 Author: Dustin J. Mitchell <dustin at mozilla.com> Date: 2011-05-29 (Sun, 29 May 2011) Changed paths: M master/buildbot/changes/pb.py M master/buildbot/test/unit/test_changes_pb.py Log Message: ----------- Handle bytestrings on input to PBChangeSource This handles bytestrings by assuming, softly, that they are in utf8. Ideally the PB client would not send bytestrings, but at least this avoids crashing. Refs #1829. From nobody at buildbot.net Mon May 30 03:56:29 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 30 May 2011 03:56:29 -0000 Subject: [Buildbot-commits] [Buildbot] #1915: GitPoller stops on wrong revision while fetching buildbot repo at the first time. In-Reply-To: <042.ae7c8809eda0e5cea36fc31b642b34b5@buildbot.net> References: <042.ae7c8809eda0e5cea36fc31b642b34b5@buildbot.net> Message-ID: <057.6fbd264765d50fb970d8df30b4e23ff7@buildbot.net> #1915: GitPoller stops on wrong revision while fetching buildbot repo at the first time. -----------------------+------------------------- Reporter: jollyroger | Owner: Type: defect | Status: closed Priority: minor | Milestone: 0.8.4 Version: 0.8.3p1 | Resolution: worksforme Keywords: git | -----------------------+------------------------- Changes (by dustin): * status: new => closed * resolution: => worksforme -- Ticket URL: <http://trac.buildbot.net/ticket/1915#comment:2> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Mon May 30 03:56:49 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 30 May 2011 03:56:49 -0000 Subject: [Buildbot-commits] [Buildbot] #1921: a reconfig that removes builders will fail the first time In-Reply-To: <038.eb6fe87c6263ddeb2884c53d62d3d85f@buildbot.net> References: <038.eb6fe87c6263ddeb2884c53d62d3d85f@buildbot.net> Message-ID: <053.8dd40623cff083e4e2d22bf1f7c06089@buildbot.net> #1921: a reconfig that removes builders will fail the first time ---------------------+------------------------- Reporter: dustin | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.4 Version: 0.8.3p1 | Resolution: worksforme Keywords: reconfig | ---------------------+------------------------- Changes (by dustin): * status: new => closed * resolution: => worksforme -- Ticket URL: <http://trac.buildbot.net/ticket/1921#comment:2> Buildbot <http://buildbot.net/> Buildbot: build/test automation From noreply at github.com Mon May 30 05:41:52 2011 From: noreply at github.com (noreply at github.com) Date: Sun, 29 May 2011 22:41:52 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 605ac9: Try to decode strings in 'buildbot sendchange' Message-ID: <20110530054152.A748D423BE@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 605ac9aaf644613a43f076fd25ddcbef93a6c087 https://github.com/buildbot/buildbot/commit/605ac9aaf644613a43f076fd25ddcbef93a6c087 Author: Dustin J. Mitchell <dustin at mozilla.com> Date: 2011-05-29 (Sun, 29 May 2011) Changed paths: M master/buildbot/clients/sendchange.py M master/buildbot/scripts/runner.py A master/buildbot/test/unit/test_clients_sendchange.py M master/contrib/darcs_buildbot.py M master/docs/cmdline.texinfo Log Message: ----------- Try to decode strings in 'buildbot sendchange' By default, this uses utf8, but that can be specified on the command line with --encoding. Refs #1829. From nobody at buildbot.net Mon May 30 05:41:59 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 30 May 2011 05:41:59 -0000 Subject: [Buildbot-commits] [Buildbot] #1829: PBChangeSource loses string encodings In-Reply-To: <038.41f0798f20411d2d3d87b3680817ccc5@buildbot.net> References: <038.41f0798f20411d2d3d87b3680817ccc5@buildbot.net> Message-ID: <053.56ac0a6424d5f4fba83e7e3419af9177@buildbot.net> #1829: PBChangeSource loses string encodings ---------------------+-------------------- Reporter: dustin | Owner: Type: defect | Status: new Priority: minor | Milestone: 0.8.4 Version: master | Resolution: Keywords: encoding | ---------------------+-------------------- Comment (by Dustin J. Mitchell): Try to decode strings in 'buildbot sendchange' By default, this uses utf8, but that can be specified on the command line with --encoding. Refs #1829. Changeset: 605ac9aaf644613a43f076fd25ddcbef93a6c087 -- Ticket URL: <http://trac.buildbot.net/ticket/1829#comment:5> Buildbot <http://buildbot.net/> Buildbot: build/test automation From noreply at github.com Mon May 30 05:46:13 2011 From: noreply at github.com (noreply at github.com) Date: Sun, 29 May 2011 22:46:13 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 30f7e4: don't use characters that Python-2.4 doesn't know ... Message-ID: <20110530054613.A1871420D4@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 30f7e4245f7c5f0f6b10219f2ee69d891d0be39d https://github.com/buildbot/buildbot/commit/30f7e4245f7c5f0f6b10219f2ee69d891d0be39d Author: Dustin J. Mitchell <dustin at mozilla.com> Date: 2011-05-29 (Sun, 29 May 2011) Changed paths: M master/buildbot/test/unit/test_clients_sendchange.py Log Message: ----------- don't use characters that Python-2.4 doesn't know about From noreply at github.com Mon May 30 05:49:31 2011 From: noreply at github.com (noreply at github.com) Date: Sun, 29 May 2011 22:49:31 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] d1737c: remove unused code Message-ID: <20110530054931.B888B423A7@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: d1737cde639393b8e8098672e79409fd352c0c0f https://github.com/buildbot/buildbot/commit/d1737cde639393b8e8098672e79409fd352c0c0f Author: Dustin J. Mitchell <dustin at mozilla.com> Date: 2011-05-29 (Sun, 29 May 2011) Changed paths: M master/buildbot/clients/sendchange.py Log Message: ----------- remove unused code From nobody at buildbot.net Mon May 30 05:55:32 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 30 May 2011 05:55:32 -0000 Subject: [Buildbot-commits] [Buildbot] #1974: "Cannot operate on a closed database" with sqlalchemy-0.7.0 Message-ID: <038.074db89d7e94a6c42eb61b8f20ca2dbb@buildbot.net> #1974: "Cannot operate on a closed database" with sqlalchemy-0.7.0 --------------------+---------------------- Reporter: dustin | Owner: dustin Type: defect | Status: new Priority: blocker | Milestone: 0.8.4 Version: master | Keywords: database --------------------+---------------------- {{{ (view as text) =============================================================================== [ERROR] Traceback (most recent call last): File "/Users/buildbot/slave/py27-sa070/build/master/buildbot/test/unit/test_db_pool.py", line 121, in tearDown native_tests.drop(bind=self.db_engine, checkfirst=True) File "/Users/buildbot/slave/py27-sa070/sandbox-python2.7-twisted- sqlalchemy==0.7.0/lib/python2.7/site-packages/sqlalchemy/schema.py", line 521, in drop bind.drop(self, checkfirst=checkfirst) File "/Users/buildbot/slave/py27-sa070/sandbox-python2.7-twisted- sqlalchemy==0.7.0/lib/python2.7/site-packages/sqlalchemy/engine/base.py", line 1976, in drop connection=connection, **kwargs) File "/Users/buildbot/slave/py27-sa070/sandbox-python2.7-twisted- sqlalchemy==0.7.0/lib/python2.7/site-packages/sqlalchemy/engine/base.py", line 2009, in _run_visitor **kwargs).traverse_single(element) File "/Users/buildbot/slave/py27-sa070/sandbox-python2.7-twisted- sqlalchemy==0.7.0/lib/python2.7/site-packages/sqlalchemy/sql/visitors.py", line 86, in traverse_single return meth(obj, **kw) File "/Users/buildbot/slave/py27-sa070/sandbox-python2.7-twisted- sqlalchemy==0.7.0/lib/python2.7/site-packages/sqlalchemy/engine/ddl.py", line 154, in visit_table if not drop_ok and not self._can_drop_table(table): File "/Users/buildbot/slave/py27-sa070/sandbox-python2.7-twisted- sqlalchemy==0.7.0/lib/python2.7/site-packages/sqlalchemy/engine/ddl.py", line 137, in _can_drop_table table.name, schema=table.schema) File "/Users/buildbot/slave/py27-sa070/sandbox-python2.7-twisted- sqlalchemy==0.7.0/lib/python2.7/site- packages/sqlalchemy/dialects/sqlite/base.py", line 555, in has_table cursor = _pragma_cursor(connection.execute("%stable_info(%s)" % (pragma, qtable))) File "/Users/buildbot/slave/py27-sa070/sandbox-python2.7-twisted- sqlalchemy==0.7.0/lib/python2.7/site-packages/sqlalchemy/engine/base.py", line 1294, in execute params) File "/Users/buildbot/slave/py27-sa070/sandbox-python2.7-twisted- sqlalchemy==0.7.0/lib/python2.7/site-packages/sqlalchemy/engine/base.py", line 1471, in _execute_text statement, parameters File "/Users/buildbot/slave/py27-sa070/sandbox-python2.7-twisted- sqlalchemy==0.7.0/lib/python2.7/site-packages/sqlalchemy/engine/base.py", line 1494, in _execute_context None, None) File "/Users/buildbot/slave/py27-sa070/sandbox-python2.7-twisted- sqlalchemy==0.7.0/lib/python2.7/site-packages/sqlalchemy/engine/base.py", line 1490, in _execute_context context = constructor(dialect, self, conn, *args) File "/Users/buildbot/slave/py27-sa070/sandbox-python2.7-twisted- sqlalchemy==0.7.0/lib/python2.7/site- packages/sqlalchemy/engine/default.py", line 514, in _init_statement self.cursor = self.create_cursor() File "/Users/buildbot/slave/py27-sa070/sandbox-python2.7-twisted- sqlalchemy==0.7.0/lib/python2.7/site- packages/sqlalchemy/engine/default.py", line 587, in create_cursor return self._dbapi_connection.cursor() File "/Users/buildbot/slave/py27-sa070/sandbox-python2.7-twisted- sqlalchemy==0.7.0/lib/python2.7/site-packages/sqlalchemy/pool.py", line 424, in cursor return self.connection.cursor(*args, **kwargs) sqlalchemy.exc.ProgrammingError: (ProgrammingError) Cannot operate on a closed database. 'PRAGMA table_info("native_tests")' [] buildbot.test.unit.test_db_pool.Native.test_ddl_and_queries ------------------------------------------------------------------------------- Ran 755 tests in 24.506s FAILED (errors=1, successes=754) }}} -- Ticket URL: <http://trac.buildbot.net/ticket/1974> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Mon May 30 10:23:45 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 30 May 2011 10:23:45 -0000 Subject: [Buildbot-commits] [Buildbot] #1915: GitPoller stops on wrong revision while fetching buildbot repo at the first time. In-Reply-To: <042.ae7c8809eda0e5cea36fc31b642b34b5@buildbot.net> References: <042.ae7c8809eda0e5cea36fc31b642b34b5@buildbot.net> Message-ID: <057.4b7358e99f8988a90a78538ee4ccbe07@buildbot.net> #1915: GitPoller stops on wrong revision while fetching buildbot repo at the first time. -----------------------+------------------------- Reporter: jollyroger | Owner: Type: defect | Status: closed Priority: minor | Milestone: 0.8.4 Version: 0.8.3p1 | Resolution: worksforme Keywords: git | -----------------------+------------------------- Comment (by jollyroger): Checked once more. Yes, the second pull done by GitPoller gets all revisions left. Sorry for so long reply. -- Ticket URL: <http://trac.buildbot.net/ticket/1915#comment:3> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Mon May 30 16:09:52 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 30 May 2011 16:09:52 -0000 Subject: [Buildbot-commits] [Buildbot] #1856: duplicate slave arbitrator waits too long In-Reply-To: <038.859b7522a6b15f569a3eac05d34d638d@buildbot.net> References: <038.859b7522a6b15f569a3eac05d34d638d@buildbot.net> Message-ID: <053.c4416ce1ff0cfba3b514228a139f497d@buildbot.net> #1856: duplicate slave arbitrator waits too long -------------------+------------------------- Reporter: dustin | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.4 Version: 0.8.0 | Resolution: worksforme Keywords: sprint | -------------------+------------------------- Changes (by dustin): * status: new => closed * resolution: => worksforme Comment: I can't replicate this in master, using iptables to make a connection from my laptop to my server "disappear". If this happens again, we'll need to dig into the circumstances more deeply. -- Ticket URL: <http://trac.buildbot.net/ticket/1856#comment:2> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Mon May 30 16:11:00 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 30 May 2011 16:11:00 -0000 Subject: [Buildbot-commits] [Buildbot] #1829: PBChangeSource loses string encodings In-Reply-To: <038.41f0798f20411d2d3d87b3680817ccc5@buildbot.net> References: <038.41f0798f20411d2d3d87b3680817ccc5@buildbot.net> Message-ID: <053.b6d034c062f089e775904864060f394b@buildbot.net> #1829: PBChangeSource loses string encodings ---------------------+--------------------- Reporter: dustin | Owner: Type: defect | Status: closed Priority: minor | Milestone: 0.8.4 Version: master | Resolution: fixed Keywords: encoding | ---------------------+--------------------- Changes (by dustin): * status: new => closed * resolution: => fixed -- Ticket URL: <http://trac.buildbot.net/ticket/1829#comment:6> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Mon May 30 16:14:07 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 30 May 2011 16:14:07 -0000 Subject: [Buildbot-commits] [Buildbot] #827: ChangeSources may produce changes containing non-ascii bytestrings In-Reply-To: <038.ae761c4a7372f16842cdf0af25f40038@buildbot.net> References: <038.ae761c4a7372f16842cdf0af25f40038@buildbot.net> Message-ID: <053.346bcd92beded91e2f5e98e056de69ec@buildbot.net> #827: ChangeSources may produce changes containing non-ascii bytestrings ------------------------------+--------------------- Reporter: dustin | Owner: Type: defect | Status: closed Priority: critical | Milestone: 0.8.+ Version: 0.7.12 | Resolution: fixed Keywords: encoding database | ------------------------------+--------------------- Changes (by dustin): * status: new => closed * resolution: => fixed Comment: Now that everything's in the db, this is pretty much solved by force (since the db's store unicode). There are a few remaining bugs to get e.g., PBChangeSource to do the right thing, but there's no need for a general framework. -- Ticket URL: <http://trac.buildbot.net/ticket/827#comment:13> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Mon May 30 16:17:16 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 30 May 2011 16:17:16 -0000 Subject: [Buildbot-commits] [Buildbot] #1867: use unicode-nazi in testing In-Reply-To: <038.2cde126f5b9393b3aaacc79948e752ad@buildbot.net> References: <038.2cde126f5b9393b3aaacc79948e752ad@buildbot.net> Message-ID: <053.d08530a029076264102f5e43dd269c73@buildbot.net> #1867: use unicode-nazi in testing ----------------------------+---------------------- Reporter: dustin | Owner: Type: enhancement | Status: closed Priority: major | Milestone: 0.8.5 Version: 0.8.3p1 | Resolution: wontfix Keywords: encoding, tests | ----------------------------+---------------------- Changes (by dustin): * status: new => closed * resolution: => wontfix Comment: This looks *way* too verbose, and doesn't seem to find the errors we're still seeing with unicode (which stem from inputs that arrive as bytestrings without an accompanying encoding). -- Ticket URL: <http://trac.buildbot.net/ticket/1867#comment:1> Buildbot <http://buildbot.net/> Buildbot: build/test automation From noreply at github.com Mon May 30 21:06:22 2011 From: noreply at github.com (noreply at github.com) Date: Mon, 30 May 2011 14:06:22 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] d8d4f2: Don't try to clean up a closed memory DB Message-ID: <20110530210622.8483C422E7@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: d8d4f2074d80fb508df62a7f813ef5d44ebb2e58 https://github.com/buildbot/buildbot/commit/d8d4f2074d80fb508df62a7f813ef5d44ebb2e58 Author: Dustin J. Mitchell <dustin at mozilla.com> Date: 2011-05-30 (Mon, 30 May 2011) Changed paths: M master/buildbot/test/unit/test_db_pool.py Log Message: ----------- Don't try to clean up a closed memory DB Fixes #1974. From nobody at buildbot.net Mon May 30 21:06:29 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 30 May 2011 21:06:29 -0000 Subject: [Buildbot-commits] [Buildbot] #1974: "Cannot operate on a closed database" with sqlalchemy-0.7.0 In-Reply-To: <038.074db89d7e94a6c42eb61b8f20ca2dbb@buildbot.net> References: <038.074db89d7e94a6c42eb61b8f20ca2dbb@buildbot.net> Message-ID: <053.d910e5f6169acc93dc509b0dd07052bc@buildbot.net> #1974: "Cannot operate on a closed database" with sqlalchemy-0.7.0 ---------------------+--------------------- Reporter: dustin | Owner: dustin Type: defect | Status: closed Priority: blocker | Milestone: 0.8.4 Version: master | Resolution: fixed Keywords: database | ---------------------+--------------------- Changes (by Dustin J. Mitchell): * status: new => closed * resolution: => fixed Comment: Don't try to clean up a closed memory DB Fixes #1974. Changeset: d8d4f2074d80fb508df62a7f813ef5d44ebb2e58 -- Ticket URL: <http://trac.buildbot.net/ticket/1974#comment:1> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Mon May 30 22:23:58 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 30 May 2011 22:23:58 -0000 Subject: [Buildbot-commits] [Buildbot] #1967: mode="copy" fails the second+ time around on win32, due to the directory sticking around. In-Reply-To: <038.3b750927173a9c90bf755ae6d9158961@buildbot.net> References: <038.3b750927173a9c90bf755ae6d9158961@buildbot.net> Message-ID: <053.31cc9d04fb3c6d0eea94d1b99af016b5@buildbot.net> #1967: mode="copy" fails the second+ time around on win32, due to the directory sticking around. --------------------+-------------------- Reporter: tfogal | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.3p1 | Resolution: Keywords: windows | --------------------+-------------------- Changes (by dustin): * milestone: 0.8.4 => 0.8.+ Comment: So, I can't replicate this on W7. I set up a config with {{{ f1.addStep(SVN(svnurl='svn://svn.twistedmatrix.com/svn/Twisted/trunk', mode='copy')) }}} and forced it twice. It checked out the first time, and successfully updated and copied the second time. It seems that windows often has timing issues, where a folder doesn't disappear immediately when it's deleted. Is it possible this is intermittent? -- Ticket URL: <http://trac.buildbot.net/ticket/1967#comment:2> Buildbot <http://buildbot.net/> Buildbot: build/test automation From noreply at github.com Tue May 31 00:10:37 2011 From: noreply at github.com (noreply at github.com) Date: Mon, 30 May 2011 17:10:37 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 498a6c: Test and succeed at claiming lots of build request... Message-ID: <20110531001037.099DC42032@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 498a6c4a6f6f13237def7b27684496605866c845 https://github.com/buildbot/buildbot/commit/498a6c4a6f6f13237def7b27684496605866c845 Author: Dustin J. Mitchell <dustin at mozilla.com> Date: 2011-05-30 (Mon, 30 May 2011) Changed paths: M master/NEWS M master/buildbot/db/buildrequests.py M master/buildbot/test/unit/test_db_buildrequests.py M master/docs/cfg-global.texinfo Log Message: ----------- Test and succeed at claiming lots of build requests The previous version used a query variable for each brid, which db engines limit. New version uses a temporary table to hold an arbitrary quantity of brids. This also adds some additional consistency checks, one of which MySQL is incapable of satisfying. From noreply at github.com Tue May 31 00:18:08 2011 From: noreply at github.com (noreply at github.com) Date: Mon, 30 May 2011 17:18:08 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 022391: manual rollbacks on MySQL Message-ID: <20110531001808.9A184423C8@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 02239144821ee2a521705aed4418dc391ec3e459 https://github.com/buildbot/buildbot/commit/02239144821ee2a521705aed4418dc391ec3e459 Author: Dustin J. Mitchell <dustin at mozilla.com> Date: 2011-05-30 (Mon, 30 May 2011) Changed paths: M master/buildbot/db/buildrequests.py Log Message: ----------- manual rollbacks on MySQL Commit: 4dd0a895da5a20ed5a1d272ac86848391631497c https://github.com/buildbot/buildbot/commit/4dd0a895da5a20ed5a1d272ac86848391631497c Author: Dustin J. Mitchell <dustin at mozilla.com> Date: 2011-05-30 (Mon, 30 May 2011) Changed paths: M master/buildbot/db/buildrequests.py Log Message: ----------- drop unnecessary try/except Compare: https://github.com/buildbot/buildbot/compare/498a6c4...4dd0a89 From nobody at buildbot.net Tue May 31 00:18:35 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 31 May 2011 00:18:35 -0000 Subject: [Buildbot-commits] [Buildbot] #1935: build request claiming needs to operate in "batches" In-Reply-To: <038.9e82dc1170d4d343f91f96014fc7a17e@buildbot.net> References: <038.9e82dc1170d4d343f91f96014fc7a17e@buildbot.net> Message-ID: <053.9307f727c2ef6551d9143b8ab8773f91@buildbot.net> #1935: build request claiming needs to operate in "batches" ---------------------+--------------------- Reporter: dustin | Owner: dustin Type: defect | Status: new Priority: major | Milestone: 0.8.4 Version: 0.8.3p1 | Resolution: Keywords: database | ---------------------+--------------------- Comment (by dustin): Fixed by using temporary tables, rather than batching. Doesn't work so well for MySQL, but that's par for the course. -- Ticket URL: <http://trac.buildbot.net/ticket/1935#comment:2> Buildbot <http://buildbot.net/> Buildbot: build/test automation From noreply at github.com Tue May 31 00:21:32 2011 From: noreply at github.com (noreply at github.com) Date: Mon, 30 May 2011 17:21:32 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 84c6fd: Merge branch 'build_set_status' of git://github.co... Message-ID: <20110531002132.C94CC422F7@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 84c6fd5d7a4c3375a910f4798e6c4219cdbe9ae1 https://github.com/buildbot/buildbot/commit/84c6fd5d7a4c3375a910f4798e6c4219cdbe9ae1 Author: Dustin J. Mitchell <dustin at mozilla.com> Date: 2011-05-30 (Mon, 30 May 2011) Changed paths: M master/buildbot/status/mail.py M master/buildbot/test/fake/fakedb.py M master/buildbot/test/unit/test_status_mail_MailNotifier.py M master/docs/cfg-statustargets.texinfo Log Message: ----------- Merge branch 'build_set_status' of git://github.com/aslater/buildbot * 'build_set_status' of git://github.com/aslater/buildbot: Corrected order of operations in MailNotifier startService/stopService Added return value to MailNotifier stopService Fixed one more long line Added buildset subscribe/unsubscribe in MailNotifier start/stopService Fixed long lines Added documentation Removed unnecessary import Added the ability to only send a single summary email from a MailNotifier when an entire buildset completes, rather than sending one for each build Commit: 90370bdf1d1a472e446e35dacb3eb46f3a6a462a https://github.com/buildbot/buildbot/commit/90370bdf1d1a472e446e35dacb3eb46f3a6a462a Author: Dustin J. Mitchell <dustin at mozilla.com> Date: 2011-05-30 (Mon, 30 May 2011) Changed paths: M master/buildbot/test/unit/test_status_mail_MailNotifier.py Log Message: ----------- fix pyflakes Compare: https://github.com/buildbot/buildbot/compare/4dd0a89...90370bd From noreply at github.com Tue May 31 01:17:49 2011 From: noreply at github.com (noreply at github.com) Date: Mon, 30 May 2011 18:17:49 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] e56fcc: use a try/finally to drop the temporary table Message-ID: <20110531011749.06838424B5@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: e56fcc0eba0e489f5c4c19073e083dd8c72d669d https://github.com/buildbot/buildbot/commit/e56fcc0eba0e489f5c4c19073e083dd8c72d669d Author: Dustin J. Mitchell <dustin at mozilla.com> Date: 2011-05-30 (Mon, 30 May 2011) Changed paths: M master/buildbot/db/buildrequests.py Log Message: ----------- use a try/finally to drop the temporary table From nobody at buildbot.net Tue May 31 03:45:42 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 31 May 2011 03:45:42 -0000 Subject: [Buildbot-commits] [Buildbot] #1935: build request claiming needs to operate in "batches" In-Reply-To: <038.9e82dc1170d4d343f91f96014fc7a17e@buildbot.net> References: <038.9e82dc1170d4d343f91f96014fc7a17e@buildbot.net> Message-ID: <053.77a4e8f8e4bb15a27257af4556074b83@buildbot.net> #1935: build request claiming needs to operate in "batches" ---------------------+--------------------- Reporter: dustin | Owner: dustin Type: defect | Status: closed Priority: major | Milestone: 0.8.4 Version: 0.8.3p1 | Resolution: fixed Keywords: database | ---------------------+--------------------- Changes (by dustin): * status: new => closed * resolution: => fixed -- Ticket URL: <http://trac.buildbot.net/ticket/1935#comment:3> Buildbot <http://buildbot.net/> Buildbot: build/test automation From noreply at github.com Tue May 31 05:18:47 2011 From: noreply at github.com (noreply at github.com) Date: Mon, 30 May 2011 22:18:47 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] edeb80: some tests for buildslave Message-ID: <20110531051847.9C5684233C@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: edeb80df82d8120c6a9a1f553e79875af66b034e https://github.com/buildbot/buildbot/commit/edeb80df82d8120c6a9a1f553e79875af66b034e Author: Dustin J. Mitchell <dustin at mozilla.com> Date: 2011-05-30 (Mon, 30 May 2011) Changed paths: M master/buildbot/buildslave.py A master/buildbot/test/unit/test_buildslave.py Log Message: ----------- some tests for buildslave From nobody at buildbot.net Tue May 31 05:20:31 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 31 May 2011 05:20:31 -0000 Subject: [Buildbot-commits] [Buildbot] #1945: add systemwide metrics support In-Reply-To: <038.0c124240b73136321a9564af7cffc13a@buildbot.net> References: <038.0c124240b73136321a9564af7cffc13a@buildbot.net> Message-ID: <053.9b151336cdb18766bf6a5150f285ae50@buildbot.net> #1945: add systemwide metrics support ------------------------+-------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: critical | Milestone: 0.8.5 Version: master | Resolution: Keywords: performance | ------------------------+-------------------- Changes (by dustin): * milestone: 0.8.4 => 0.8.5 Comment: or 0.8.5? -- Ticket URL: <http://trac.buildbot.net/ticket/1945#comment:1> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Tue May 31 05:20:32 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 31 May 2011 05:20:32 -0000 Subject: [Buildbot-commits] [Buildbot] #1946: buildbot.steps.transfer._FileWriter uses __del__ In-Reply-To: <038.ac84b40eacc83bbeed29e7604c23ac9c@buildbot.net> References: <038.ac84b40eacc83bbeed29e7604c23ac9c@buildbot.net> Message-ID: <053.879821e04fe4b63585f0420916393263@buildbot.net> #1946: buildbot.steps.transfer._FileWriter uses __del__ ----------------------------------+-------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.5 Version: master | Resolution: Keywords: performance, transfer | ----------------------------------+-------------------- Changes (by dustin): * keywords: performance => performance, transfer * milestone: 0.8.4 => 0.8.5 -- Ticket URL: <http://trac.buildbot.net/ticket/1946#comment:3> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Tue May 31 05:20:34 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 31 May 2011 05:20:34 -0000 Subject: [Buildbot-commits] [Buildbot] #1950: EC2 docs need updating to new AWS terminology In-Reply-To: <038.804edab703f26dcac940eae9cbb6d1c5@buildbot.net> References: <038.804edab703f26dcac940eae9cbb6d1c5@buildbot.net> Message-ID: <053.a8f4e2217c9cb52525763e19dfaf851a@buildbot.net> #1950: EC2 docs need updating to new AWS terminology ------------------------+-------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.5 Version: 0.8.3p1 | Resolution: Keywords: docs | ------------------------+-------------------- Changes (by dustin): * milestone: 0.8.4 => 0.8.5 -- Ticket URL: <http://trac.buildbot.net/ticket/1950#comment:1> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Tue May 31 05:21:06 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 31 May 2011 05:21:06 -0000 Subject: [Buildbot-commits] [Buildbot] #1936: optimize getOldestRequestTime In-Reply-To: <038.7a24f9fbb575b54572e76045aa2d1886@buildbot.net> References: <038.7a24f9fbb575b54572e76045aa2d1886@buildbot.net> Message-ID: <053.a920b8b794a4e246bc65eb4d2597dc64@buildbot.net> #1936: optimize getOldestRequestTime ----------------------------------+-------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.5 Version: 0.8.3p1 | Resolution: Keywords: database, performance | ----------------------------------+-------------------- Changes (by dustin): * milestone: 0.8.4 => 0.8.5 -- Ticket URL: <http://trac.buildbot.net/ticket/1936#comment:2> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Tue May 31 05:21:47 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 31 May 2011 05:21:47 -0000 Subject: [Buildbot-commits] [Buildbot] #1884: transfer steps should include progress info In-Reply-To: <038.959cbfda66e15d0d2f7b00bfece81d58@buildbot.net> References: <038.959cbfda66e15d0d2f7b00bfece81d58@buildbot.net> Message-ID: <053.bdc116534068a7a21bebed61c5573927@buildbot.net> #1884: transfer steps should include progress info --------------------------+-------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.5 Version: 0.8.3p1 | Resolution: Keywords: web, transfer | --------------------------+-------------------- Changes (by dustin): * keywords: web => web, transfer * milestone: 0.8.4 => 0.8.5 -- Ticket URL: <http://trac.buildbot.net/ticket/1884#comment:2> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Tue May 31 05:22:00 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 31 May 2011 05:22:00 -0000 Subject: [Buildbot-commits] [Buildbot] #1873: web status does not ask for name when auth not in use In-Reply-To: <038.57714f0dc960c5a06e3ee2e18d56deed@buildbot.net> References: <038.57714f0dc960c5a06e3ee2e18d56deed@buildbot.net> Message-ID: <053.f576ee8977476c8d9c6fa3dd08b1d6d7@buildbot.net> #1873: web status does not ask for name when auth not in use -------------------------------+-------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.5 Version: 0.8.3p1 | Resolution: Keywords: web, redheadphones | -------------------------------+-------------------- Changes (by dustin): * milestone: 0.8.4 => 0.8.5 -- Ticket URL: <http://trac.buildbot.net/ticket/1873#comment:3> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Tue May 31 05:22:48 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 31 May 2011 05:22:48 -0000 Subject: [Buildbot-commits] [Buildbot] #1871: Goofy quoting/space handling in buildbot_service.py In-Reply-To: <041.01b11010e70edfcc9095f4da89015f6c@buildbot.net> References: <041.01b11010e70edfcc9095f4da89015f6c@buildbot.net> Message-ID: <056.22f3324d6a680b2200d80de57fb923b2@buildbot.net> #1871: Goofy quoting/space handling in buildbot_service.py ------------------------+-------------------- Reporter: dabrahams | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.5 Version: 0.8.3p1 | Resolution: Keywords: docs | ------------------------+-------------------- Changes (by dustin): * keywords: => docs * type: undecided => enhancement * milestone: 0.8.4 => 0.8.5 Comment: I'm still not skilled enough in Windows to understand this. Wiki editing is free, though :) -- Ticket URL: <http://trac.buildbot.net/ticket/1871#comment:2> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Tue May 31 05:23:35 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 31 May 2011 05:23:35 -0000 Subject: [Buildbot-commits] [Buildbot] #1861: github hook should optionally ignore distinct=false In-Reply-To: <038.28bd8207d25cfc78c10bb532db1c009b@buildbot.net> References: <038.28bd8207d25cfc78c10bb532db1c009b@buildbot.net> Message-ID: <053.8b6f4188eae843f3f2db2311e75e1cfb@buildbot.net> #1861: github hook should optionally ignore distinct=false ------------------------+-------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.5 Version: 0.8.3p1 | Resolution: Keywords: git | ------------------------+-------------------- Changes (by dustin): * milestone: 0.8.4 => 0.8.5 -- Ticket URL: <http://trac.buildbot.net/ticket/1861#comment:2> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Tue May 31 05:25:07 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 31 May 2011 05:25:07 -0000 Subject: [Buildbot-commits] [Buildbot] #1832: GitPoller unhandled error on adding a change In-Reply-To: <046.1580261d7ececbba4e1cf2e7e15be043@buildbot.net> References: <046.1580261d7ececbba4e1cf2e7e15be043@buildbot.net> Message-ID: <061.7f27754f99c36780f4c0879eb6f994c5@buildbot.net> #1832: GitPoller unhandled error on adding a change ----------------------------+--------------------- Reporter: davidholsgrove | Owner: Type: support-request | Status: closed Priority: major | Milestone: 0.8.4 Version: 0.8.3p1 | Resolution: fixed Keywords: git | ----------------------------+--------------------- Changes (by dustin): * status: new => closed * resolution: => fixed -- Ticket URL: <http://trac.buildbot.net/ticket/1832#comment:2> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Tue May 31 05:25:23 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 31 May 2011 05:25:23 -0000 Subject: [Buildbot-commits] [Buildbot] #1830: ER : Add a warning for logfiles if the log file does not exist or is not found In-Reply-To: <039.372e33a57b836ef962d4796cba2c0ee3@buildbot.net> References: <039.372e33a57b836ef962d4796cba2c0ee3@buildbot.net> Message-ID: <054.146ad2e18a0ab5dbea07c7c9491dd9c8@buildbot.net> #1830: ER : Add a warning for logfiles if the log file does not exist or is not found ------------------------+-------------------- Reporter: darshie | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.5 Version: 0.8.3 | Resolution: Keywords: | ------------------------+-------------------- Changes (by dustin): * milestone: 0.8.4 => 0.8.5 -- Ticket URL: <http://trac.buildbot.net/ticket/1830#comment:2> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Tue May 31 05:26:08 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 31 May 2011 05:26:08 -0000 Subject: [Buildbot-commits] [Buildbot] #1821: scheduler usability improvements In-Reply-To: <038.38073a6e2654ee7a291ee089b013a6d2@buildbot.net> References: <038.38073a6e2654ee7a291ee089b013a6d2@buildbot.net> Message-ID: <053.f7a24864b6493eb99d01886bf2354676@buildbot.net> #1821: scheduler usability improvements ------------------------+-------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.5 Version: master | Resolution: Keywords: projrepo | ------------------------+-------------------- Changes (by dustin): * milestone: 0.8.4 => 0.8.5 -- Ticket URL: <http://trac.buildbot.net/ticket/1821#comment:3> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Tue May 31 05:27:06 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 31 May 2011 05:27:06 -0000 Subject: [Buildbot-commits] [Buildbot] #1778: Add a way of specifying a revlink from GitPoller. In-Reply-To: <042.1104c30bf7a031e1c00e179c3d86d887@buildbot.net> References: <042.1104c30bf7a031e1c00e179c3d86d887@buildbot.net> Message-ID: <057.c8e86fd0b2ea636dc7dca4d07c79b31d@buildbot.net> #1778: Add a way of specifying a revlink from GitPoller. ------------------------+-------------------- Reporter: tom.prince | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.5 Version: 0.8.3p1 | Resolution: Keywords: git | ------------------------+-------------------- Changes (by dustin): * milestone: 0.8.4 => 0.8.5 Comment: I'm still not clear how the various revlink parameters work. I suppose I should look into that! -- Ticket URL: <http://trac.buildbot.net/ticket/1778#comment:2> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Tue May 31 05:51:44 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 31 May 2011 05:51:44 -0000 Subject: [Buildbot-commits] [Buildbot] #1767: SVNPoller does not support logEnviron In-Reply-To: <037.723f28971a56e2d4357bf3c11dc762f0@buildbot.net> References: <037.723f28971a56e2d4357bf3c11dc762f0@buildbot.net> Message-ID: <052.a7883e99b06a4e17699234f31a65902c@buildbot.net> #1767: SVNPoller does not support logEnviron ------------------------+-------------------- Reporter: fgsch | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.5 Version: 0.8.3p1 | Resolution: Keywords: svn | ------------------------+-------------------- Changes (by dustin): * milestone: 0.8.4 => 0.8.5 -- Ticket URL: <http://trac.buildbot.net/ticket/1767#comment:3> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Tue May 31 05:52:15 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 31 May 2011 05:52:15 -0000 Subject: [Buildbot-commits] [Buildbot] #1748: Hiding strings from ShellCommands command= in factories using something like Obfuscated In-Reply-To: <039.910168808e260ab34929252b74922c44@buildbot.net> References: <039.910168808e260ab34929252b74922c44@buildbot.net> Message-ID: <054.c9496d9c07eb22f23948f4f1e79a0b4f@buildbot.net> #1748: Hiding strings from ShellCommands command= in factories using something like Obfuscated ------------------------+-------------------- Reporter: GreYFoX | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.+ Version: 0.8.3 | Resolution: Keywords: | ------------------------+-------------------- Changes (by dustin): * milestone: 0.8.4 => 0.8.+ -- Ticket URL: <http://trac.buildbot.net/ticket/1748#comment:4> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Tue May 31 05:52:25 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 31 May 2011 05:52:25 -0000 Subject: [Buildbot-commits] [Buildbot] #1743: Create option for a BuildStep to be suppressed if skipped In-Reply-To: <042.4f4da741f4c5a452909182e887b421e6@buildbot.net> References: <042.4f4da741f4c5a452909182e887b421e6@buildbot.net> Message-ID: <057.3b6faf51854e8dbc5ee7a6d9ca2447a5@buildbot.net> #1743: Create option for a BuildStep to be suppressed if skipped ------------------------+-------------------- Reporter: Sly_Squash | Owner: Type: enhancement | Status: new Priority: trivial | Milestone: 0.8.5 Version: 0.8.2 | Resolution: Keywords: web | ------------------------+-------------------- Changes (by dustin): * milestone: 0.8.4 => 0.8.5 -- Ticket URL: <http://trac.buildbot.net/ticket/1743#comment:2> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Tue May 31 05:52:46 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 31 May 2011 05:52:46 -0000 Subject: [Buildbot-commits] [Buildbot] #1738: Properties: "category" property is missing from Build properties In-Reply-To: <043.f64838526d69c05c8d221730a5d4a65d@buildbot.net> References: <043.f64838526d69c05c8d221730a5d4a65d@buildbot.net> Message-ID: <058.2a0f36e951d7e8656e836988fea55b9b@buildbot.net> #1738: Properties: "category" property is missing from Build properties ------------------------+-------------------- Reporter: PiotrSikora | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.+ Version: 0.8.2 | Resolution: Keywords: | ------------------------+-------------------- Changes (by dustin): * milestone: 0.8.4 => 0.8.+ -- Ticket URL: <http://trac.buildbot.net/ticket/1738#comment:4> Buildbot <http://buildbot.net/> Buildbot: build/test automation From nobody at buildbot.net Tue May 31 05:52:57 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 31 May 2011 05:52:57 -0000 Subject: [Buildbot-commits] [Buildbot] #1725: GerritStatusPush: add filters on builderName, project, branch In-Reply-To: <043.b6be9d54d3cee8199a78e9ff41b4f4e4@buildbot.net> References: <043.b6be9d54d3cee8199a78e9ff41b4f4e4@buildbot.net> Message-ID: <058.d7732ae3b4d94a2b1e997acc25241a4a@buildbot.net> #1725: GerritStatusPush: add filters on builderName, project, branch ------------------------+-------------------------- Reporter: PiotrSikora | Owner: PiotrSikora Type: enhancement | Status: new Priority: major | Milestone: 0.8.5 Version: 0.8.2 | Resolution: Keywords: gerrit | ------------------------+-------------------------- Changes (by dustin): * milestone: 0.8.4 => 0.8.5 -- Ticket URL: <http://trac.buildbot.net/ticket/1725#comment:2> Buildbot <http://buildbot.net/> Buildbot: build/test automation From noreply at github.com Tue May 31 05:55:49 2011 From: noreply at github.com (noreply at github.com) Date: Mon, 30 May 2011 22:55:49 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 5c894b: don't use mock's spec= with a class instead of an ... Message-ID: <20110531055549.D370642351@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 5c894bb771efa64f3a78124519ec60bf53672cc4 https://github.com/buildbot/buildbot/commit/5c894bb771efa64f3a78124519ec60bf53672cc4 Author: Dustin J. Mitchell <dustin at mozilla.com> Date: 2011-05-30 (Mon, 30 May 2011) Changed paths: M master/buildbot/test/unit/test_buildslave.py Log Message: ----------- don't use mock's spec= with a class instead of an instance From noreply at github.com Tue May 31 14:32:16 2011 From: noreply at github.com (noreply at github.com) Date: Tue, 31 May 2011 07:32:16 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] eb771d: Fix weird *_ENABLED behaviour in /etc/default/* fi... Message-ID: <20110531143216.82C95423A2@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: eb771d1748bec50a3c14af68714a10d8f02d5484 https://github.com/buildbot/buildbot/commit/eb771d1748bec50a3c14af68714a10d8f02d5484 Author: Andriy Senkovych <jolly_roger at itblog.org.ua> Date: 2011-05-31 (Tue, 31 May 2011) Changed paths: M master/NEWS M master/contrib/init-scripts/buildmaster.default M master/contrib/init-scripts/buildmaster.init.sh M slave/NEWS M slave/contrib/init-scripts/buildslave.default M slave/contrib/init-scripts/buildslave.init.sh Log Message: ----------- Fix weird *_ENABLED behaviour in /etc/default/* files Commit: 49ba1e782b283e538a1f9a4cca38a1eb151186ba https://github.com/buildbot/buildbot/commit/49ba1e782b283e538a1f9a4cca38a1eb151186ba Author: Dustin J. Mitchell <dustin at mozilla.com> Date: 2011-05-31 (Tue, 31 May 2011) Changed paths: M master/NEWS M master/contrib/init-scripts/buildmaster.default M master/contrib/init-scripts/buildmaster.init.sh M slave/NEWS M slave/contrib/init-scripts/buildslave.default M slave/contrib/init-scripts/buildslave.init.sh Log Message: ----------- Merge branch 'deb-bug-625555' of git://github.com/jollyroger/buildbot * 'deb-bug-625555' of git://github.com/jollyroger/buildbot: Fix weird *_ENABLED behaviour in /etc/default/* files Remove trailing whitespace Init script fixes from Debian BTS (bug #625555). buildmaster init script should use /etc/default/buildmaster Compare: https://github.com/buildbot/buildbot/compare/5c894bb...49ba1e7 From noreply at github.com Tue May 31 20:19:21 2011 From: noreply at github.com (noreply at github.com) Date: Tue, 31 May 2011 13:19:21 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] e50450: Pass a fake BuildMaster when upgrading master Message-ID: <20110531201921.2F0824238E@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: e50450d346e7a13c13db9faf33413bdb1b3b512d https://github.com/buildbot/buildbot/commit/e50450d346e7a13c13db9faf33413bdb1b3b512d Author: Dustin J. Mitchell <dustin at mozilla.com> Date: 2011-05-31 (Tue, 31 May 2011) Changed paths: M master/buildbot/scripts/runner.py Log Message: ----------- Pass a fake BuildMaster when upgrading master