[Buildbot-commits] [Buildbot] #1902: gitpoller doesn't handle non-ascii commit messages

[Buildbot]

#1902: gitpoller doesn't handle non-ascii commit messages
--------------------+----------------------------
Reporter:  dustin   |      Owner:
    Type:  defect   |     Status:  new
Priority:  major    |  Milestone:  0.8.4
 Version:  0.8.3p1  |   Keywords:  git, encodings
--------------------+----------------------------
 {{{
 ....
 2011-03-27 15:57:32+0000 [-] gitpoller: _add_change results: "[(True,
 1268714670.0), (True, 'arma at torproject.org'), (True, ['ChangeLog',
 'ReleaseNotes']), (True, 'give us a blurb; add stanza to the
 releasenotes')]", rev: "6b7e5eb5f1ee9d6ef24cbe7d96fa5388f7a54bf0" in
 "/tmp/gitpoller_work"
 2011-03-27 15:57:32+0000 [-] gitpoller: change
 "<buildbot.changes.changes.Change instance at 0x2972950>" in
 "/tmp/gitpoller_work"
 2011-03-27 15:57:32+0000 [-] adding change, who arma at torproject.org, 2
 files, rev=6b7e5eb5f1ee9d6ef24cbe7d96fa5388f7a54bf0, branch=master,
 repository=https://git.torproject.org/tor.git, comments give us a blurb;
 add stanza to the releasenotes, category None, project
 2011-03-27 15:57:33+0000 [-] gitpoller: _add_change results: "[(True,
 1268726538.0), (True, 'arma at torproject.org'), (True,
 ['src/or/dirserv.c']), (True, "In the glorious future, all relays cache
 dir info.\nNow if you're a published relay and you set RefuseUnknownExits,
 even\nif your dirport is off, you'll fetch dir info from the
 authorities,\nfetch it early, and cache it.\n\nIn the future,
 RefuseUnknownExits (or something like it) will be on\nby default.")]",
 rev: "fe3380609e6444aadb88c534de0281d9d15d3c85" in "/tmp/gitpoller_work"
 2011-03-27 15:57:33+0000 [-] gitpoller: change
 "<buildbot.changes.changes.Change instance at 0x239e320>" in
 "/tmp/gitpoller_work"
 2011-03-27 15:57:33+0000 [-] adding change, who arma at torproject.org, 1
 files, rev=fe3380609e6444aadb88c534de0281d9d15d3c85, branch=master,
 repository=https://git.torproject.org/tor.git, comments In the glorious
 future, all relays cache dir info.
         Now if you're a published relay and you set RefuseUnknownExits,
 even
         if your dirport is off, you'll fetch dir info from the
 authorities,
         fetch it early, and cache it.

         In the future, RefuseUnknownExits (or something like it) will be
 on
         by default., category None, project
 2011-03-27 15:57:33+0000 [-] gitpoller: _add_change results: "[(True,
 1269189901.0), (True, 'nickm at torproject.org'), (True, ['doc/spec/dir-
 spec.txt']), (True, 'Add a missing NL to dir-spec.\nFound by
 O\xc4\x9fuz')]", rev: "28cda33299d2654ff43b7174c9e71fb64ad53b3b" in
 "/tmp/gitpoller_work"
 2011-03-27 15:57:33+0000 [-] gitpoller: change
 "<buildbot.changes.changes.Change instance at 0x283c5a8>" in
 "/tmp/gitpoller_work"
 2011-03-27 15:57:33+0000 [-] gitpoller: repo poll failed
 2011-03-27 15:57:33+0000 [-] Unhandled Error
         Traceback (most recent call last):
           File "/usr/lib/python2.6/dist-
 packages/twisted/internet/defer.py", line 318, in callback
             self._startRunCallbacks(result)
           File "/usr/lib/python2.6/dist-
 packages/twisted/internet/defer.py", line 424, in _startRunCallbacks
             self._runCallbacks()
           File "/usr/lib/python2.6/dist-
 packages/twisted/internet/defer.py", line 441, in _runCallbacks
             self.result = callback(self.result, *args, **kw)
           File "/usr/lib/python2.6/dist-
 packages/twisted/internet/defer.py", line 764, in gotResult
             _deferGenerator(g, deferred)
         --- <exception caught here> ---
           File "/usr/lib/python2.6/dist-
 packages/twisted/internet/defer.py", line 739, in _deferGenerator
             result = g.next()
           File "/usr/lib/python2.6/dist-
 packages/buildbot/changes/gitpoller.py", line 207, in
 _process_changes_in_output
             wfd.getResult()
           File "/usr/lib/python2.6/dist-
 packages/twisted/internet/defer.py", line 718, in getResult
             self.result.raiseException()
           File "/usr/lib/python2.6/dist-
 packages/twisted/internet/defer.py", line 441, in _runCallbacks
             self.result = callback(self.result, *args, **kw)
           File "/usr/lib/python2.6/dist-
 packages/buildbot/changes/gitpoller.py", line 223, in _add_change
             self.parent.addChange(c)
           File "/usr/lib/python2.6/dist-
 packages/buildbot/changes/manager.py", line 82, in addChange
             change.comments, change.category, change.project))
         exceptions.UnicodeDecodeError: 'ascii' codec can't decode byte
 0xc4 in position 40: ordinal not in range(128)

 2011-03-27 15:57:33+0000 [-] gitpoller: catching up to FETCH_HEAD
 }}}

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1902>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation