[Buildbot-commits] [Buildbot] #1892: SetPropertiesFromEnv should be case-insensitive on Windows

[Buildbot]

#1892: SetPropertiesFromEnv should be case-insensitive on Windows
------------------------+------------------------
Reporter:  dabrahams    |       Owner:
    Type:  defect       |      Status:  new
Priority:  major        |   Milestone:  undecided
 Version:  0.8.3p1      |  Resolution:
Keywords:  windows git  |
------------------------+------------------------

Comment (by dabrahams):

 First, I apologize for the escalation in tone.  I assure you, neither
 aggression nor accusation was intended, but perception is everything, so
 again, I apologize.  Also, I understand that making it work properly is
 high-impact compared with the scale of the problem.

 I evaluate the options as follows: #``1 helps, but makes it difficult to
 write portable test recipes and requires some intricate documentation,
 making `SetPropertiesFromEnv` harder to use for everyone, #``2 doesn't
 help at all (if you know to pass the `uppercase=True` argument, you would
 also know to upcase the variable name), and #``3 looks like a bit of a
 hack that introduces a (admittedly small) maintenance hassle for you,
 still needs to be documented (and thus decreases usability) and could
 theoretically cause problems in *nix-only environments.  That said, those
 theoretical problems look very unlikely, so maybe #``3 is the least of all
 evils.  I'd say #``1 or something like it runs a close second.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1892#comment:10>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation